1 2020-07-28T00:00:01  *** ogelbukh has quit IRC
  2 2020-07-28T00:01:30  *** mdunnio has joined #bitcoin-core-dev
  3 2020-07-28T00:04:18  *** AaronvanW has quit IRC
  4 2020-07-28T00:06:49  *** mdunnio has quit IRC
  5 2020-07-28T00:17:28  *** Victorsueca has joined #bitcoin-core-dev
  6 2020-07-28T00:22:01  *** ByronT has joined #bitcoin-core-dev
  7 2020-07-28T00:31:22  *** proofofkeags has joined #bitcoin-core-dev
  8 2020-07-28T00:35:07  *** arowser_ has quit IRC
  9 2020-07-28T00:35:35  *** arowser_ has joined #bitcoin-core-dev
 10 2020-07-28T00:35:58  *** proofofkeags has quit IRC
 11 2020-07-28T00:43:06  *** AaronvanW has joined #bitcoin-core-dev
 12 2020-07-28T00:48:29  *** AaronvanW has quit IRC
 13 2020-07-28T00:48:42  *** promag_ has joined #bitcoin-core-dev
 14 2020-07-28T00:51:27  *** CodeShark___ has quit IRC
 15 2020-07-28T00:51:42  *** CodeShark___ has joined #bitcoin-core-dev
 16 2020-07-28T00:52:05  *** stackingcore21_ has joined #bitcoin-core-dev
 17 2020-07-28T00:52:27  *** peltre has quit IRC
 18 2020-07-28T00:52:27  *** valwal_ has quit IRC
 19 2020-07-28T00:52:47  *** stackingcore21 has quit IRC
 20 2020-07-28T00:54:27  *** valwal_ has joined #bitcoin-core-dev
 21 2020-07-28T00:55:17  *** peltre has joined #bitcoin-core-dev
 22 2020-07-28T01:00:11  *** Victorsueca has quit IRC
 23 2020-07-28T01:04:38  *** promag_ has quit IRC
 24 2020-07-28T01:05:42  *** arowser_ has quit IRC
 25 2020-07-28T01:06:00  *** arowser_ has joined #bitcoin-core-dev
 26 2020-07-28T01:07:42  *** Victorsueca has joined #bitcoin-core-dev
 27 2020-07-28T01:17:11  *** arowser_ has quit IRC
 28 2020-07-28T01:17:57  *** arowser_ has joined #bitcoin-core-dev
 29 2020-07-28T01:19:41  *** troygiorshev has joined #bitcoin-core-dev
 30 2020-07-28T01:22:32  *** mdunnio has joined #bitcoin-core-dev
 31 2020-07-28T01:26:11  *** thunderbiscuit has quit IRC
 32 2020-07-28T01:55:57  *** thunderbiscuit has joined #bitcoin-core-dev
 33 2020-07-28T02:04:04  *** thunderbiscuit1 has left #bitcoin-core-dev
 34 2020-07-28T02:04:57  *** justanotheruser has quit IRC
 35 2020-07-28T02:07:18  *** arowser_ has quit IRC
 36 2020-07-28T02:15:38  *** davec has quit IRC
 37 2020-07-28T02:16:41  *** davec has joined #bitcoin-core-dev
 38 2020-07-28T02:19:33  *** arowser_ has joined #bitcoin-core-dev
 39 2020-07-28T02:27:04  *** bitdex has joined #bitcoin-core-dev
 40 2020-07-28T02:32:04  *** thunderbiscuit[m has joined #bitcoin-core-dev
 41 2020-07-28T02:35:14  *** thunderbiscuit has left #bitcoin-core-dev
 42 2020-07-28T02:45:49  *** AaronvanW has joined #bitcoin-core-dev
 43 2020-07-28T02:51:50  *** Madars has quit IRC
 44 2020-07-28T02:52:25  *** arowser_ has quit IRC
 45 2020-07-28T02:53:22  *** arowser_ has joined #bitcoin-core-dev
 46 2020-07-28T02:57:11  *** arowser_ has quit IRC
 47 2020-07-28T02:57:42  *** arowser_ has joined #bitcoin-core-dev
 48 2020-07-28T02:58:47  *** proofofkeags has joined #bitcoin-core-dev
 49 2020-07-28T03:00:02  *** ByronT has quit IRC
 50 2020-07-28T03:02:42  *** notmandatory[m] has joined #bitcoin-core-dev
 51 2020-07-28T03:14:52  *** Madars has joined #bitcoin-core-dev
 52 2020-07-28T03:17:00  *** justanotheruser has joined #bitcoin-core-dev
 53 2020-07-28T03:17:22  *** mdunnio has quit IRC
 54 2020-07-28T03:17:47  *** AaronvanW has quit IRC
 55 2020-07-28T03:21:47  *** JesusFreke has joined #bitcoin-core-dev
 56 2020-07-28T03:24:11  *** arowser_ has quit IRC
 57 2020-07-28T03:24:36  *** arowser_ has joined #bitcoin-core-dev
 58 2020-07-28T03:26:10  *** arowser_ has quit IRC
 59 2020-07-28T03:26:40  *** arowser_ has joined #bitcoin-core-dev
 60 2020-07-28T03:31:08  *** vasild_ has joined #bitcoin-core-dev
 61 2020-07-28T03:34:03  *** vasild has quit IRC
 62 2020-07-28T03:34:04  *** vasild_ is now known as vasild
 63 2020-07-28T03:36:57  <fanquake> wumpus: I think I've tracked down the issue with your test for the ELF  header LOAD commands 🚀
 64 2020-07-28T03:37:26  <fanquake> Just looks like some alignment issuses in the readelf output.
 65 2020-07-28T03:37:45  *** Madars has quit IRC
 66 2020-07-28T03:38:06  <fanquake> Still need to investigate your queries about potential alignment issues in the actual binary
 67 2020-07-28T03:44:00  <fanquake> The problem only shows up in readelf when the binary itself is large, and the addr/size columns push into the Flg column. So you ended up with '9 R' rather than 'R E' etc
 68 2020-07-28T03:48:43  *** mdunnio has joined #bitcoin-core-dev
 69 2020-07-28T03:56:05  *** mdunnio has quit IRC
 70 2020-07-28T03:59:13  *** arowser_ has quit IRC
 71 2020-07-28T03:59:31  *** jarthur_ has joined #bitcoin-core-dev
 72 2020-07-28T03:59:37  *** arowser_ has joined #bitcoin-core-dev
 73 2020-07-28T04:01:07  *** jarthur has quit IRC
 74 2020-07-28T04:01:10  *** jarthur_ is now known as jarthur
 75 2020-07-28T04:08:24  *** Madars has joined #bitcoin-core-dev
 76 2020-07-28T04:10:38  *** proofofkeags has quit IRC
 77 2020-07-28T04:27:44  *** Madars has quit IRC
 78 2020-07-28T04:49:30  *** Madars has joined #bitcoin-core-dev
 79 2020-07-28T05:07:02  *** rh0nj has quit IRC
 80 2020-07-28T05:10:16  *** Madars has quit IRC
 81 2020-07-28T05:15:25  *** AaronvanW has joined #bitcoin-core-dev
 82 2020-07-28T05:19:52  *** arowser_ has quit IRC
 83 2020-07-28T05:20:51  *** arowser_ has joined #bitcoin-core-dev
 84 2020-07-28T05:26:41  *** proofofkeags has joined #bitcoin-core-dev
 85 2020-07-28T05:31:22  *** proofofkeags has quit IRC
 86 2020-07-28T05:34:34  *** Madars has joined #bitcoin-core-dev
 87 2020-07-28T05:49:08  *** arowser_ has quit IRC
 88 2020-07-28T05:49:25  *** AaronvanW has quit IRC
 89 2020-07-28T05:49:28  *** arowser_ has joined #bitcoin-core-dev
 90 2020-07-28T05:52:47  *** bitcoin-git has joined #bitcoin-core-dev
 91 2020-07-28T05:52:47  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19604: Pass mempool pointer to UnloadBlockIndex/GetCoinsCacheSizeState (master...2007-memPointer) https://github.com/bitcoin/bitcoin/pull/19604
 92 2020-07-28T05:52:48  *** bitcoin-git has left #bitcoin-core-dev
 93 2020-07-28T05:52:54  *** Madars has quit IRC
 94 2020-07-28T05:58:56  *** jarthur has quit IRC
 95 2020-07-28T06:00:01  *** JesusFreke has quit IRC
 96 2020-07-28T06:05:24  *** proofofkeags has joined #bitcoin-core-dev
 97 2020-07-28T06:06:11  *** arowser_ has quit IRC
 98 2020-07-28T06:06:31  *** arowser_ has joined #bitcoin-core-dev
 99 2020-07-28T06:09:47  *** proofofkeags has quit IRC
100 2020-07-28T06:09:48  *** Madars has joined #bitcoin-core-dev
101 2020-07-28T06:13:12  *** arowser_ has quit IRC
102 2020-07-28T06:20:59  *** jarthur has joined #bitcoin-core-dev
103 2020-07-28T06:21:10  *** ircmaxell1 has joined #bitcoin-core-dev
104 2020-07-28T06:21:27  *** proofofkeags has joined #bitcoin-core-dev
105 2020-07-28T06:25:21  *** arowser_ has joined #bitcoin-core-dev
106 2020-07-28T06:25:27  *** jarthur has quit IRC
107 2020-07-28T06:25:45  *** proofofkeags has quit IRC
108 2020-07-28T06:31:05  *** Madars has quit IRC
109 2020-07-28T06:39:35  *** dviola has quit IRC
110 2020-07-28T06:43:10  *** jarthur has joined #bitcoin-core-dev
111 2020-07-28T06:44:10  *** arowser_ has quit IRC
112 2020-07-28T06:44:34  *** arowser_ has joined #bitcoin-core-dev
113 2020-07-28T06:53:09  *** Madars has joined #bitcoin-core-dev
114 2020-07-28T06:54:33  *** bitcoin-git has joined #bitcoin-core-dev
115 2020-07-28T06:54:34  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b62fbf9e1c19...a1da180b1b27
116 2020-07-28T06:54:35  <bitcoin-git> bitcoin/master fa1f7f2 MarcoFalke: rpc: Style fixups in gettxoutproof
117 2020-07-28T06:54:35  <bitcoin-git> bitcoin/master fa5979d MarcoFalke: rpc: Avoid useless mempool query in gettxoutproof
118 2020-07-28T06:54:36  <bitcoin-git> bitcoin/master a1da180 fanquake: Merge #19589: rpc: Avoid useless mempool query in gettxoutproof
119 2020-07-28T06:54:45  *** bitcoin-git has left #bitcoin-core-dev
120 2020-07-28T06:54:59  *** bitcoin-git has joined #bitcoin-core-dev
121 2020-07-28T06:54:59  <bitcoin-git> [bitcoin] fanquake merged pull request #19589: rpc: Avoid useless mempool query in gettxoutproof (master...2007-rpcMempool) https://github.com/bitcoin/bitcoin/pull/19589
122 2020-07-28T06:55:00  *** bitcoin-git has left #bitcoin-core-dev
123 2020-07-28T06:59:51  *** marcoagner has joined #bitcoin-core-dev
124 2020-07-28T07:13:02  *** Madars has quit IRC
125 2020-07-28T07:16:04  *** bitcoin-git has joined #bitcoin-core-dev
126 2020-07-28T07:16:06  <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a1da180b1b27...2979a7aff04b
127 2020-07-28T07:16:07  <bitcoin-git> bitcoin/master 634144a John Newbery: [net processing] Fixup MaybeDiscourageAndDisconnect() style
128 2020-07-28T07:16:08  <bitcoin-git> bitcoin/master d15b3af John Newbery: [net processing] Always supply debug message to Misbehaving()
129 2020-07-28T07:16:09  <bitcoin-git> bitcoin/master a8865f8 John Newbery: [net processing] Tidy up Misbehaving()
130 2020-07-28T07:16:11  *** bitcoin-git has left #bitcoin-core-dev
131 2020-07-28T07:16:28  *** bitcoin-git has joined #bitcoin-core-dev
132 2020-07-28T07:16:28  <bitcoin-git> [bitcoin] fanquake merged pull request #19583: p2p: clean up Misbehaving() (master...2020-07-tidy-misbehavior) https://github.com/bitcoin/bitcoin/pull/19583
133 2020-07-28T07:16:29  *** bitcoin-git has left #bitcoin-core-dev
134 2020-07-28T07:18:45  *** arowser_ has quit IRC
135 2020-07-28T07:19:32  *** bitcoin-git has joined #bitcoin-core-dev
136 2020-07-28T07:19:32  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2979a7aff04b...cea39fc268e3
137 2020-07-28T07:19:33  <bitcoin-git> bitcoin/master 623f665 Hennadii Stepanov: Fix .gitignore for src/test/fuzz directory
138 2020-07-28T07:19:33  <bitcoin-git> bitcoin/master cea39fc fanquake: Merge #19595: Fix .gitignore for src/test/fuzz directory
139 2020-07-28T07:19:42  *** bitcoin-git has left #bitcoin-core-dev
140 2020-07-28T07:20:02  *** bitcoin-git has joined #bitcoin-core-dev
141 2020-07-28T07:20:02  <bitcoin-git> [bitcoin] fanquake merged pull request #19595: Fix .gitignore for src/test/fuzz directory (master...200727-fuzz) https://github.com/bitcoin/bitcoin/pull/19595
142 2020-07-28T07:20:12  *** bitcoin-git has left #bitcoin-core-dev
143 2020-07-28T07:24:04  *** arowser_ has joined #bitcoin-core-dev
144 2020-07-28T07:26:07  *** Guyver2 has joined #bitcoin-core-dev
145 2020-07-28T07:26:47  *** bitcoin-git has joined #bitcoin-core-dev
146 2020-07-28T07:26:48  <bitcoin-git> [bitcoin] fanquake closed pull request #19578: wallet: Avoid duplicate checks on signing failure (master...2020-07-signtransaction) https://github.com/bitcoin/bitcoin/pull/19578
147 2020-07-28T07:26:49  *** bitcoin-git has left #bitcoin-core-dev
148 2020-07-28T07:35:12  *** Madars has joined #bitcoin-core-dev
149 2020-07-28T07:46:05  *** arowser_ has quit IRC
150 2020-07-28T07:46:09  *** AaronvanW has joined #bitcoin-core-dev
151 2020-07-28T07:46:35  *** davec has quit IRC
152 2020-07-28T07:46:52  *** davec has joined #bitcoin-core-dev
153 2020-07-28T07:53:13  *** Pavlenex has joined #bitcoin-core-dev
154 2020-07-28T07:54:13  *** Madars has quit IRC
155 2020-07-28T07:55:03  *** jonatack has quit IRC
156 2020-07-28T07:58:17  *** arowser_ has joined #bitcoin-core-dev
157 2020-07-28T08:02:04  *** bitcoin-git has joined #bitcoin-core-dev
158 2020-07-28T08:02:06  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/cea39fc268e3...e0ed4cc50de1
159 2020-07-28T08:02:06  <bitcoin-git> bitcoin/master 00d1ba7 Cory Fields: depends: enable lto support for Apple's ld64
160 2020-07-28T08:02:07  <bitcoin-git> bitcoin/master 5962522 Cory Fields: depends: bump native_cctools for fixed lto with external clang
161 2020-07-28T08:02:08  <bitcoin-git> bitcoin/master e0ed4cc fanquake: Merge #19530: depends: build LTO support into Apple's ld64
162 2020-07-28T08:02:10  *** bitcoin-git has left #bitcoin-core-dev
163 2020-07-28T08:02:24  *** bitcoin-git has joined #bitcoin-core-dev
164 2020-07-28T08:02:24  <bitcoin-git> [bitcoin] fanquake merged pull request #19530: depends: build LTO support into Apple's ld64 (master...darwin-lto) https://github.com/bitcoin/bitcoin/pull/19530
165 2020-07-28T08:02:25  *** bitcoin-git has left #bitcoin-core-dev
166 2020-07-28T08:08:08  *** davec has quit IRC
167 2020-07-28T08:09:30  *** davec has joined #bitcoin-core-dev
168 2020-07-28T08:13:13  *** arowser_ has quit IRC
169 2020-07-28T08:13:32  *** arowser_ has joined #bitcoin-core-dev
170 2020-07-28T08:15:23  *** mutatrum has quit IRC
171 2020-07-28T08:15:23  *** davec has quit IRC
172 2020-07-28T08:16:07  *** davec has joined #bitcoin-core-dev
173 2020-07-28T08:17:10  *** Madars has joined #bitcoin-core-dev
174 2020-07-28T08:18:25  *** AaronvanW has quit IRC
175 2020-07-28T08:26:18  *** bitcoin-git has joined #bitcoin-core-dev
176 2020-07-28T08:26:18  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e0ed4cc50de1...24ead1a923e3
177 2020-07-28T08:26:19  <bitcoin-git> bitcoin/master fdf697f Hennadii Stepanov: ci: Increase CCACHE_SIZE in some builds on Travis
178 2020-07-28T08:26:19  <bitcoin-git> bitcoin/master 24ead1a MarcoFalke: Merge #19519: ci: Increase CCACHE_SIZE in some builds on Travis
179 2020-07-28T08:26:21  *** bitcoin-git has left #bitcoin-core-dev
180 2020-07-28T08:26:38  *** bitcoin-git has joined #bitcoin-core-dev
181 2020-07-28T08:26:38  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19519: ci: Increase CCACHE_SIZE in some builds on Travis (master...200714-ccache) https://github.com/bitcoin/bitcoin/pull/19519
182 2020-07-28T08:26:39  *** bitcoin-git has left #bitcoin-core-dev
183 2020-07-28T08:33:55  *** bitcoin-git has joined #bitcoin-core-dev
184 2020-07-28T08:33:55  <bitcoin-git> [bitcoin] fanquake opened pull request #19605: doc: set CC_FOR_BUILD when building on OpenBSD (master...openbsd_cc_for_build) https://github.com/bitcoin/bitcoin/pull/19605
185 2020-07-28T08:33:56  *** bitcoin-git has left #bitcoin-core-dev
186 2020-07-28T08:37:02  *** Madars has quit IRC
187 2020-07-28T08:40:11  *** bitcoin-git has joined #bitcoin-core-dev
188 2020-07-28T08:40:11  <bitcoin-git> [bitcoin] jnewbery opened pull request #19606: Backport wtxid to v0.20 (0.20...2020-07-v20-wtxid-relay) https://github.com/bitcoin/bitcoin/pull/19606
189 2020-07-28T08:40:12  *** bitcoin-git has left #bitcoin-core-dev
190 2020-07-28T08:46:17  *** AaronvanW has joined #bitcoin-core-dev
191 2020-07-28T08:56:36  *** Madars has joined #bitcoin-core-dev
192 2020-07-28T08:57:53  *** dfmb_ has joined #bitcoin-core-dev
193 2020-07-28T08:58:09  *** arowser_ has quit IRC
194 2020-07-28T08:58:27  *** dfmb_ has quit IRC
195 2020-07-28T08:58:33  *** arowser_ has joined #bitcoin-core-dev
196 2020-07-28T08:58:51  *** promag_ has joined #bitcoin-core-dev
197 2020-07-28T08:59:09  *** promag__ has joined #bitcoin-core-dev
198 2020-07-28T08:59:12  *** promag_ has quit IRC
199 2020-07-28T09:00:02  *** ircmaxell1 has quit IRC
200 2020-07-28T09:05:15  *** dfmb_ has joined #bitcoin-core-dev
201 2020-07-28T09:05:33  *** dfmb_ has quit IRC
202 2020-07-28T09:05:41  *** el_yapoo has joined #bitcoin-core-dev
203 2020-07-28T09:07:12  *** promag_ has joined #bitcoin-core-dev
204 2020-07-28T09:10:38  *** promag__ has quit IRC
205 2020-07-28T09:13:35  *** promag_ has quit IRC
206 2020-07-28T09:14:46  *** promag_ has joined #bitcoin-core-dev
207 2020-07-28T09:17:13  *** bitcoin-git has joined #bitcoin-core-dev
208 2020-07-28T09:17:14  <bitcoin-git> [bitcoin] jnewbery opened pull request #19607: [p2p] Add Peer struct for per-peer data in net processing (master...2020-07-peer) https://github.com/bitcoin/bitcoin/pull/19607
209 2020-07-28T09:17:15  *** bitcoin-git has left #bitcoin-core-dev
210 2020-07-28T09:18:05  *** Madars has quit IRC
211 2020-07-28T09:19:26  *** promag_ has quit IRC
212 2020-07-28T09:20:59  *** esotericnonsense has quit IRC
213 2020-07-28T09:22:01  *** el_yapoo has quit IRC
214 2020-07-28T09:22:11  *** carvsdriver1 has joined #bitcoin-core-dev
215 2020-07-28T09:22:20  *** Pavlenex has quit IRC
216 2020-07-28T09:33:08  <jnewbery> ShellCheck is breaking travis builds: https://travis-ci.org/github/bitcoin/bitcoin/jobs/712484395
217 2020-07-28T09:33:37  <jnewbery> You are downloading ShellCheck from an outdated URL!
218 2020-07-28T09:33:37  <jnewbery> Please update to the new URL:
219 2020-07-28T09:33:37  <jnewbery> https://github.com/koalaman/shellcheck/releases/download/v0.6.0/shellcheck-v0.6.0.linux.x86_64.tar.xz
220 2020-07-28T09:33:40  <jnewbery> For more information, see:
221 2020-07-28T09:33:41  <jnewbery> PS: Sorry for breaking your build. The hosting costs were getting out of hand :(
222 2020-07-28T09:33:44  <jnewbery> https://github.com/koalaman/shellcheck/issues/1871
223 2020-07-28T09:33:59  *** esotericnonsense has joined #bitcoin-core-dev
224 2020-07-28T09:34:31  <fanquake> ugh
225 2020-07-28T09:34:46  <fanquake> I can fix that now if you're not going to
226 2020-07-28T09:36:53  <fanquake> Actually. We are already downloading from https://github.com/koalaman/shellcheck/. So I'm not sure why that would have broken.
227 2020-07-28T09:37:15  <jnewbery> ah, it's for my backport to the 0.20 branch
228 2020-07-28T09:37:39  <jnewbery> I suppose I need to backport the ShellCheck fix too?
229 2020-07-28T09:38:19  <fanquake> Just PR that separately. If it's going to break any other builds / backports and be a pain no need for it to wait on your PR.
230 2020-07-28T09:38:31  <jnewbery> will do. Thanks!
231 2020-07-28T09:38:33  <fanquake> Should be able to merge right away
232 2020-07-28T09:40:58  *** Madars has joined #bitcoin-core-dev
233 2020-07-28T09:42:28  *** Pavlenex has joined #bitcoin-core-dev
234 2020-07-28T09:48:28  *** AaronvanW has quit IRC
235 2020-07-28T09:48:44  *** AaronvanW has joined #bitcoin-core-dev
236 2020-07-28T09:59:29  *** EagleTM has joined #bitcoin-core-dev
237 2020-07-28T10:03:15  *** promag_ has joined #bitcoin-core-dev
238 2020-07-28T10:03:23  *** Bart41Schneider has joined #bitcoin-core-dev
239 2020-07-28T10:06:12  *** Madars has quit IRC
240 2020-07-28T10:09:19  *** bitdex has quit IRC
241 2020-07-28T10:09:56  *** promag_ has quit IRC
242 2020-07-28T10:10:00  *** arowser_ has quit IRC
243 2020-07-28T10:14:47  *** promag_ has joined #bitcoin-core-dev
244 2020-07-28T10:16:40  *** arowser_ has joined #bitcoin-core-dev
245 2020-07-28T10:17:35  *** promag_ has quit IRC
246 2020-07-28T10:20:55  *** promag_ has joined #bitcoin-core-dev
247 2020-07-28T10:21:45  *** Bart41Schneider has quit IRC
248 2020-07-28T10:23:58  *** promag_ has quit IRC
249 2020-07-28T10:26:26  *** promag_ has joined #bitcoin-core-dev
250 2020-07-28T10:28:10  *** promag_ has quit IRC
251 2020-07-28T10:31:41  *** Madars has joined #bitcoin-core-dev
252 2020-07-28T10:52:40  *** Madars has quit IRC
253 2020-07-28T10:54:16  *** reallll has joined #bitcoin-core-dev
254 2020-07-28T10:56:43  *** sipa has quit IRC
255 2020-07-28T10:57:10  *** reallll is now known as belcher
256 2020-07-28T10:57:58  *** belcher_ has quit IRC
257 2020-07-28T11:02:02  *** bitcoin-git has joined #bitcoin-core-dev
258 2020-07-28T11:02:03  <bitcoin-git> [bitcoin] jonatack opened pull request #19610: p2p, refactor: add `CInv` block message helpers; use in net processing (master...CInv-block-message-helpers) https://github.com/bitcoin/bitcoin/pull/19610
259 2020-07-28T11:02:04  *** bitcoin-git has left #bitcoin-core-dev
260 2020-07-28T11:02:37  *** troygiorshev has quit IRC
261 2020-07-28T11:03:01  *** troygiorshev has joined #bitcoin-core-dev
262 2020-07-28T11:03:51  *** sipa has joined #bitcoin-core-dev
263 2020-07-28T11:08:13  *** Chris_Stewart_5 has joined #bitcoin-core-dev
264 2020-07-28T11:11:40  *** bitcoin-git has joined #bitcoin-core-dev
265 2020-07-28T11:11:40  <bitcoin-git> [bitcoin] jonatack opened pull request #19611: p2p: refactor CInv::type from public int to private uint32_t (master...CInv-type-refactoring) https://github.com/bitcoin/bitcoin/pull/19611
266 2020-07-28T11:11:50  *** bitcoin-git has left #bitcoin-core-dev
267 2020-07-28T11:16:55  *** jrawsthorne has joined #bitcoin-core-dev
268 2020-07-28T11:19:24  *** jrawsthorne has quit IRC
269 2020-07-28T11:20:13  *** Madars has joined #bitcoin-core-dev
270 2020-07-28T11:21:13  *** arowser_ has quit IRC
271 2020-07-28T11:21:49  *** arowser_ has joined #bitcoin-core-dev
272 2020-07-28T11:28:21  *** infernix has quit IRC
273 2020-07-28T11:29:14  *** jrawsthorne has joined #bitcoin-core-dev
274 2020-07-28T11:33:08  *** jeremyrubin has quit IRC
275 2020-07-28T11:37:45  *** promag_ has joined #bitcoin-core-dev
276 2020-07-28T11:39:27  *** Guyver2_ has joined #bitcoin-core-dev
277 2020-07-28T11:42:32  *** Guyver2 has quit IRC
278 2020-07-28T11:42:38  *** Madars has quit IRC
279 2020-07-28T11:46:13  *** promag_ has quit IRC
280 2020-07-28T11:52:25  *** arowser_ has quit IRC
281 2020-07-28T11:57:04  *** provoostenator has quit IRC
282 2020-07-28T11:58:28  *** Guyver2__ has joined #bitcoin-core-dev
283 2020-07-28T11:58:55  *** arowser_ has joined #bitcoin-core-dev
284 2020-07-28T12:00:02  *** carvsdriver1 has quit IRC
285 2020-07-28T12:00:39  *** infernix has joined #bitcoin-core-dev
286 2020-07-28T12:01:15  *** arowser_ has quit IRC
287 2020-07-28T12:01:25  *** Guyver2_ has quit IRC
288 2020-07-28T12:01:35  *** arowser_ has joined #bitcoin-core-dev
289 2020-07-28T12:02:56  <darosior> MarcoFalke: regarding https://github.com/bitcoin/bitcoin/pull/19556. I plan to rebase https://github.com/bitcoin/bitcoin/pull/18766 on top of it and you mentioned "Removing the fee estimates global": do you think the fee estimator could be a field of CTxMemPool instead ?
290 2020-07-28T12:05:02  *** bitcoin-git has joined #bitcoin-core-dev
291 2020-07-28T12:05:03  <bitcoin-git> [bitcoin] fanquake opened pull request #19612: [0.20] lint: fix shellcheck URL in CI install (0.20...fix_shellcheck_0_20) https://github.com/bitcoin/bitcoin/pull/19612
292 2020-07-28T12:05:04  *** bitcoin-git has left #bitcoin-core-dev
293 2020-07-28T12:05:18  <fanquake> #pointlessPRoftheweek
294 2020-07-28T12:05:52  *** Madars has joined #bitcoin-core-dev
295 2020-07-28T12:22:11  *** BjarniRunar1 has joined #bitcoin-core-dev
296 2020-07-28T12:22:28  *** bitcoin-git has joined #bitcoin-core-dev
297 2020-07-28T12:22:29  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/58feb9ecb647...6acb21e724e3
298 2020-07-28T12:22:29  <bitcoin-git> bitcoin/0.20 7ee4769 fanquake: [0.20] lint: fix shellcheck URL in CI install
299 2020-07-28T12:22:30  <bitcoin-git> bitcoin/0.20 6acb21e MarcoFalke: Merge #19612: [0.20] lint: fix shellcheck URL in CI install
300 2020-07-28T12:22:32  *** bitcoin-git has left #bitcoin-core-dev
301 2020-07-28T12:22:48  *** bitcoin-git has joined #bitcoin-core-dev
302 2020-07-28T12:22:48  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19612: [0.20] lint: fix shellcheck URL in CI install (0.20...fix_shellcheck_0_20) https://github.com/bitcoin/bitcoin/pull/19612
303 2020-07-28T12:22:49  *** bitcoin-git has left #bitcoin-core-dev
304 2020-07-28T12:26:30  *** Madars has quit IRC
305 2020-07-28T12:42:13  *** arowser_ has quit IRC
306 2020-07-28T12:42:37  *** arowser_ has joined #bitcoin-core-dev
307 2020-07-28T12:44:03  *** Pavlenex has quit IRC
308 2020-07-28T12:46:34  *** EagleTM has quit IRC
309 2020-07-28T12:47:04  *** Madars has joined #bitcoin-core-dev
310 2020-07-28T12:56:43  *** Emcy_ has joined #bitcoin-core-dev
311 2020-07-28T12:57:10  *** Emcy has quit IRC
312 2020-07-28T12:57:10  *** arowser_ has quit IRC
313 2020-07-28T12:57:27  *** dongcarl has quit IRC
314 2020-07-28T12:57:47  *** dongcarl has joined #bitcoin-core-dev
315 2020-07-28T12:59:42  *** andreacab has joined #bitcoin-core-dev
316 2020-07-28T13:02:57  *** EagleTM has joined #bitcoin-core-dev
317 2020-07-28T13:03:44  *** arowser_ has joined #bitcoin-core-dev
318 2020-07-28T13:04:09  *** arowser_ has quit IRC
319 2020-07-28T13:10:14  *** shesek has quit IRC
320 2020-07-28T13:10:42  *** Madars has quit IRC
321 2020-07-28T13:11:08  *** shesek has joined #bitcoin-core-dev
322 2020-07-28T13:11:08  *** shesek has joined #bitcoin-core-dev
323 2020-07-28T13:16:21  *** arowser_ has joined #bitcoin-core-dev
324 2020-07-28T13:25:13  *** arowser_ has quit IRC
325 2020-07-28T13:29:38  *** warren has quit IRC
326 2020-07-28T13:32:00  *** warren has joined #bitcoin-core-dev
327 2020-07-28T13:37:32  *** arowser_ has joined #bitcoin-core-dev
328 2020-07-28T13:41:43  *** vasild has quit IRC
329 2020-07-28T13:46:32  *** mdunnio has joined #bitcoin-core-dev
330 2020-07-28T13:47:02  *** vasild has joined #bitcoin-core-dev
331 2020-07-28T13:50:44  *** Madars has joined #bitcoin-core-dev
332 2020-07-28T13:55:13  *** arowser_ has quit IRC
333 2020-07-28T13:55:37  *** arowser_ has joined #bitcoin-core-dev
334 2020-07-28T13:56:35  *** troygiorshev has quit IRC
335 2020-07-28T13:57:39  *** troygiorshev has joined #bitcoin-core-dev
336 2020-07-28T14:00:42  *** proofofkeags has joined #bitcoin-core-dev
337 2020-07-28T14:02:13  *** arowser_ has quit IRC
338 2020-07-28T14:03:40  *** bitcoin-git has joined #bitcoin-core-dev
339 2020-07-28T14:03:41  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19613: travis: Re-enable s390x (master...2007-travisS390x) https://github.com/bitcoin/bitcoin/pull/19613
340 2020-07-28T14:03:52  *** bitcoin-git has left #bitcoin-core-dev
341 2020-07-28T14:04:19  *** mdunnio has quit IRC
342 2020-07-28T14:04:32  *** mdunnio has joined #bitcoin-core-dev
343 2020-07-28T14:07:58  *** proofofkeags has quit IRC
344 2020-07-28T14:08:12  *** proofofkeags has joined #bitcoin-core-dev
345 2020-07-28T14:09:33  <shesek> I released Minsc, a compile-to-Miniscript scripting language with some additional features and syntactic sugar. Documentation and a live compiler are available on https://min.sc/, source code is at https://github.com/shesek/minsc
346 2020-07-28T14:09:48  <shesek> on twitter: https://twitter.com/shesek/status/1288111748432576512
347 2020-07-28T14:10:41  *** Madars has quit IRC
348 2020-07-28T14:16:14  *** andreacab has quit IRC
349 2020-07-28T14:16:33  *** andreacab2 has joined #bitcoin-core-dev
350 2020-07-28T14:18:46  *** gzhao408 has joined #bitcoin-core-dev
351 2020-07-28T14:28:47  *** jonatack has joined #bitcoin-core-dev
352 2020-07-28T14:30:03  *** joerodgers has joined #bitcoin-core-dev
353 2020-07-28T14:44:46  *** bitcoin-git has joined #bitcoin-core-dev
354 2020-07-28T14:44:46  <bitcoin-git> [bitcoin] fanquake opened pull request #19614: util: use HAVE_FDATASYNC to determine fdatasync() use (master...use_have_fdatasync) https://github.com/bitcoin/bitcoin/pull/19614
355 2020-07-28T14:44:47  *** bitcoin-git has left #bitcoin-core-dev
356 2020-07-28T14:45:24  *** arowser_ has joined #bitcoin-core-dev
357 2020-07-28T14:45:57  *** Madars has joined #bitcoin-core-dev
358 2020-07-28T14:49:31  *** andreacab2 has quit IRC
359 2020-07-28T14:50:15  *** arowser_ has quit IRC
360 2020-07-28T14:52:26  *** arowser_ has joined #bitcoin-core-dev
361 2020-07-28T14:54:13  *** Davterra has quit IRC
362 2020-07-28T14:56:11  *** isis_ is now known as isis
363 2020-07-28T14:57:00  *** proofofkeags has quit IRC
364 2020-07-28T15:00:01  *** BjarniRunar1 has quit IRC
365 2020-07-28T15:02:33  *** andreacab2 has joined #bitcoin-core-dev
366 2020-07-28T15:03:18  *** andreaca_ has joined #bitcoin-core-dev
367 2020-07-28T15:05:34  *** Davterra has joined #bitcoin-core-dev
368 2020-07-28T15:06:45  *** andreacab2 has quit IRC
369 2020-07-28T15:07:23  *** Madars has quit IRC
370 2020-07-28T15:11:51  *** jonatack has quit IRC
371 2020-07-28T15:12:38  *** andreaca_ has quit IRC
372 2020-07-28T15:13:15  *** andreacab2 has joined #bitcoin-core-dev
373 2020-07-28T15:14:14  *** arowser_ has quit IRC
374 2020-07-28T15:17:52  *** andreacab2 has quit IRC
375 2020-07-28T15:18:54  *** proofofkeags has joined #bitcoin-core-dev
376 2020-07-28T15:21:41  *** untwisted has joined #bitcoin-core-dev
377 2020-07-28T15:27:03  *** yancy has quit IRC
378 2020-07-28T15:27:19  *** yancy has joined #bitcoin-core-dev
379 2020-07-28T15:31:08  *** vasild_ has joined #bitcoin-core-dev
380 2020-07-28T15:34:43  *** vasild has quit IRC
381 2020-07-28T15:34:44  *** vasild_ is now known as vasild
382 2020-07-28T15:48:17  *** jonatack has joined #bitcoin-core-dev
383 2020-07-28T15:50:07  *** rh0nj has joined #bitcoin-core-dev
384 2020-07-28T15:51:48  *** andreaca_ has joined #bitcoin-core-dev
385 2020-07-28T15:53:03  *** gzhao408 has quit IRC
386 2020-07-28T15:53:17  *** bitcoin-git has joined #bitcoin-core-dev
387 2020-07-28T15:53:17  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/24ead1a923e3...a41ae6805338
388 2020-07-28T15:53:18  <bitcoin-git> bitcoin/master fae6561 MarcoFalke: travis: Re-enable s390x
389 2020-07-28T15:53:18  <bitcoin-git> bitcoin/master a41ae68 MarcoFalke: Merge #19613: travis: Re-enable s390x
390 2020-07-28T15:53:20  *** bitcoin-git has left #bitcoin-core-dev
391 2020-07-28T15:53:26  *** Madars has joined #bitcoin-core-dev
392 2020-07-28T15:53:37  *** bitcoin-git has joined #bitcoin-core-dev
393 2020-07-28T15:53:37  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19613: travis: Re-enable s390x (master...2007-travisS390x) https://github.com/bitcoin/bitcoin/pull/19613
394 2020-07-28T15:53:38  *** bitcoin-git has left #bitcoin-core-dev
395 2020-07-28T15:54:02  *** bitcoin-git has joined #bitcoin-core-dev
396 2020-07-28T15:54:02  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #19509: Per-Peer Message Logging (master...message-dump) https://github.com/bitcoin/bitcoin/pull/19509
397 2020-07-28T15:54:11  *** bitcoin-git has left #bitcoin-core-dev
398 2020-07-28T15:54:27  *** bitcoin-git has joined #bitcoin-core-dev
399 2020-07-28T15:54:27  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #19509: Per-Peer Message Logging (master...message-dump) https://github.com/bitcoin/bitcoin/pull/19509
400 2020-07-28T15:54:28  *** bitcoin-git has left #bitcoin-core-dev
401 2020-07-28T15:56:05  *** andreaca_ has quit IRC
402 2020-07-28T16:04:44  *** Pavlenex has joined #bitcoin-core-dev
403 2020-07-28T16:12:02  *** Pavlenex1 has joined #bitcoin-core-dev
404 2020-07-28T16:15:30  *** Pavlenex has quit IRC
405 2020-07-28T16:15:31  *** Pavlenex1 is now known as Pavlenex
406 2020-07-28T16:17:45  *** Bullit has quit IRC
407 2020-07-28T16:18:00  *** arowser_ has joined #bitcoin-core-dev
408 2020-07-28T16:19:38  *** Madars has quit IRC
409 2020-07-28T16:27:28  *** Talkless has joined #bitcoin-core-dev
410 2020-07-28T16:31:23  *** andreacab2 has joined #bitcoin-core-dev
411 2020-07-28T16:34:09  *** arowser_ has quit IRC
412 2020-07-28T16:35:25  *** andreacab2 has quit IRC
413 2020-07-28T16:38:01  *** jb55 has quit IRC
414 2020-07-28T16:50:46  *** Madars has joined #bitcoin-core-dev
415 2020-07-28T16:55:31  *** Tennis has joined #bitcoin-core-dev
416 2020-07-28T16:55:37  *** jeremyrubin has joined #bitcoin-core-dev
417 2020-07-28T16:55:51  *** jb55 has joined #bitcoin-core-dev
418 2020-07-28T17:09:18  *** andreaca_ has joined #bitcoin-core-dev
419 2020-07-28T17:12:35  *** Madars has quit IRC
420 2020-07-28T17:13:25  *** andreaca_ has quit IRC
421 2020-07-28T17:16:51  *** arowser_ has joined #bitcoin-core-dev
422 2020-07-28T18:00:02  *** untwisted has quit IRC
423 2020-07-28T18:12:55  *** Pavlenex has quit IRC
424 2020-07-28T18:15:02  *** vincenzopalazzo has joined #bitcoin-core-dev
425 2020-07-28T18:20:01  *** Fuchs1 has joined #bitcoin-core-dev
426 2020-07-28T18:21:28  *** andreacab2 has joined #bitcoin-core-dev
427 2020-07-28T18:25:25  *** andreacab2 has quit IRC
428 2020-07-28T18:30:02  *** hex17or has quit IRC
429 2020-07-28T18:32:18  *** arowser_ has quit IRC
430 2020-07-28T18:33:08  *** EagleTM has quit IRC
431 2020-07-28T18:35:28  *** Madars has joined #bitcoin-core-dev
432 2020-07-28T18:46:17  *** proofofkeags has quit IRC
433 2020-07-28T18:46:53  *** proofofkeags has joined #bitcoin-core-dev
434 2020-07-28T18:48:03  *** proofofkeags has quit IRC
435 2020-07-28T18:48:17  *** proofofkeags has joined #bitcoin-core-dev
436 2020-07-28T18:56:37  *** Madars has quit IRC
437 2020-07-28T18:57:15  *** justanotheruser has quit IRC
438 2020-07-28T19:01:42  *** justanotheruser has joined #bitcoin-core-dev
439 2020-07-28T19:04:59  *** EagleTM has joined #bitcoin-core-dev
440 2020-07-28T19:09:59  *** Talkless has quit IRC
441 2020-07-28T19:10:44  *** oldNorth has joined #bitcoin-core-dev
442 2020-07-28T19:17:40  *** oldNorth has quit IRC
443 2020-07-28T19:17:56  *** oldNorth has joined #bitcoin-core-dev
444 2020-07-28T19:21:40  *** promag_ has joined #bitcoin-core-dev
445 2020-07-28T19:34:14  *** andreacab2 has joined #bitcoin-core-dev
446 2020-07-28T19:34:48  *** Madars has joined #bitcoin-core-dev
447 2020-07-28T19:35:00  *** andreaca_ has joined #bitcoin-core-dev
448 2020-07-28T19:38:25  *** andreacab2 has quit IRC
449 2020-07-28T19:40:00  *** owowo has joined #bitcoin-core-dev
450 2020-07-28T19:41:10  *** andreacab2 has joined #bitcoin-core-dev
451 2020-07-28T19:44:05  *** andreaca_ has quit IRC
452 2020-07-28T19:44:38  *** promag_ has quit IRC
453 2020-07-28T19:57:24  *** andreacab2 has quit IRC
454 2020-07-28T19:58:42  *** Madars has quit IRC
455 2020-07-28T20:02:09  *** promag_ has joined #bitcoin-core-dev
456 2020-07-28T20:05:53  *** icota[m] has quit IRC
457 2020-07-28T20:06:25  *** promag_ has quit IRC
458 2020-07-28T20:08:31  *** icota[m] has joined #bitcoin-core-dev
459 2020-07-28T20:18:48  *** joerodgers has quit IRC
460 2020-07-28T20:22:08  *** ritalinona has joined #bitcoin-core-dev
461 2020-07-28T20:31:58  *** tryphe_ has quit IRC
462 2020-07-28T20:34:44  *** tryphe has joined #bitcoin-core-dev
463 2020-07-28T20:42:05  *** Madars has joined #bitcoin-core-dev
464 2020-07-28T20:47:01  *** promag_ has joined #bitcoin-core-dev
465 2020-07-28T20:48:31  *** michagogo has joined #bitcoin-core-dev
466 2020-07-28T20:49:51  *** michagogo has joined #bitcoin-core-dev
467 2020-07-28T20:58:16  *** promag_ has quit IRC
468 2020-07-28T20:58:54  *** proofofkeags has quit IRC
469 2020-07-28T20:59:09  *** promag_ has joined #bitcoin-core-dev
470 2020-07-28T21:00:01  *** Fuchs1 has quit IRC
471 2020-07-28T21:01:31  *** justanotheruser has quit IRC
472 2020-07-28T21:01:50  *** oldNorth has quit IRC
473 2020-07-28T21:04:11  *** promag_ has quit IRC
474 2020-07-28T21:05:00  *** Madars has quit IRC
475 2020-07-28T21:05:19  *** Guyver2__ has quit IRC
476 2020-07-28T21:14:00  *** promag_ has joined #bitcoin-core-dev
477 2020-07-28T21:20:41  *** steven1 has joined #bitcoin-core-dev
478 2020-07-28T21:22:12  *** proofofkeags has joined #bitcoin-core-dev
479 2020-07-28T21:29:51  *** arowser_ has joined #bitcoin-core-dev
480 2020-07-28T21:32:12  *** EagleTM has quit IRC
481 2020-07-28T21:38:41  *** Madars has joined #bitcoin-core-dev
482 2020-07-28T22:01:06  *** EagleTM has joined #bitcoin-core-dev
483 2020-07-28T22:01:53  *** Madars has quit IRC
484 2020-07-28T22:03:13  *** nckx has quit IRC
485 2020-07-28T22:05:18  *** nckx has joined #bitcoin-core-dev
486 2020-07-28T22:10:25  *** roconnor has quit IRC
487 2020-07-28T22:13:32  *** promag_ has quit IRC
488 2020-07-28T22:27:49  *** mdunnio has quit IRC
489 2020-07-28T22:29:46  *** roconnor has joined #bitcoin-core-dev
490 2020-07-28T22:30:58  *** Madars has joined #bitcoin-core-dev
491 2020-07-28T22:31:45  *** promag_ has joined #bitcoin-core-dev
492 2020-07-28T22:32:39  *** hex17or has joined #bitcoin-core-dev
493 2020-07-28T22:33:46  *** promag_ has quit IRC
494 2020-07-28T22:34:03  *** marcoagner has quit IRC
495 2020-07-28T22:42:38  *** EagleTM has quit IRC
496 2020-07-28T22:44:26  *** justanotheruser has joined #bitcoin-core-dev
497 2020-07-28T22:45:02  *** arowser_ has quit IRC
498 2020-07-28T22:51:49  *** Madars has quit IRC
499 2020-07-28T22:52:29  *** EagleTM has joined #bitcoin-core-dev
500 2020-07-28T23:01:47  *** gzhao408 has joined #bitcoin-core-dev
501 2020-07-28T23:06:14  *** promag_ has joined #bitcoin-core-dev
502 2020-07-28T23:06:51  *** vincenzopalazzo has quit IRC
503 2020-07-28T23:07:04  *** mdunnio has joined #bitcoin-core-dev
504 2020-07-28T23:10:57  *** Deacyde has quit IRC
505 2020-07-28T23:12:27  *** mdunnio has quit IRC
506 2020-07-28T23:13:00  *** Madars has joined #bitcoin-core-dev
507 2020-07-28T23:13:26  *** promag_ has quit IRC
508 2020-07-28T23:26:59  *** EagleTM has quit IRC
509 2020-07-28T23:37:15  *** EagleTM has joined #bitcoin-core-dev
510 2020-07-28T23:43:05  *** ritalinona has left #bitcoin-core-dev
511 2020-07-28T23:45:29  <sdaftuar> i saw i missed some discussion around wtxid-relay being deployed in advance of taproot, driving some desire to backport it
512 2020-07-28T23:45:38  <sdaftuar> jnewbery: sipa: ^^
513 2020-07-28T23:45:48  <sdaftuar> it's not clear to me how important that is...
514 2020-07-28T23:47:50  <sdaftuar> for instance, a simpler solution might be to just backport a patch to 0.20 (and 0.19 and older, however far back people want to go) that adds txids of transactions that fail the AreInputsStandard check to the reject filter
515 2020-07-28T23:48:16  <sdaftuar> that might take some small refactoring of the logic, but would involve a much less involved p2p change and would presumably be much easier to test and reason about
516 2020-07-28T23:48:48  <sdaftuar> i haven't tried doing it to see how hard it would be though, so up to whoever is interested in what direction to go
517 2020-07-28T23:50:00  <sipa> sdaftuar: another alternative that was suggested somewhere was just not relaying taproot spending txn to non-wtxidrelay peers
518 2020-07-28T23:51:21  <sdaftuar> i guess that would work too -- and also is much simpler than backporting
519 2020-07-28T23:51:25  <sipa> (i'm not a fan in general of adding these ad-hoc assumptions about relay policy, but if there is a concern about timelines of wtxid relay and taproot interacting, that's a simple solution)
520 2020-07-28T23:51:48  *** promag_ has joined #bitcoin-core-dev
521 2020-07-28T23:51:54  <sdaftuar> i like the simple fix to the reject filter because it gives users concerned about bandwidth considerations a simple way to mitigate the issue
522 2020-07-28T23:52:03  <sdaftuar> without redoing a lot of p2p code, which is higher risk
523 2020-07-28T23:52:17  <sdaftuar> and it should be exactly correct
524 2020-07-28T23:52:25  <sdaftuar> and it should be exactly correct/
525 2020-07-28T23:52:34  <sdaftuar> that was supposed to say: taproot doesn't support p2sh, right?
526 2020-07-28T23:52:40  <sipa> indeed
527 2020-07-28T23:53:07  <sipa> adding AreInputsStandard failures to the reject filter also seems simple
528 2020-07-28T23:53:25  <sipa> but it will only benefit nodes that adopt that patch
529 2020-07-28T23:53:53  <sdaftuar> which i think is (more than?) sufficient for this type of concern
530 2020-07-28T23:55:07  <sipa> regarding p2dh: that isn't relevant i think?
531 2020-07-28T23:55:24  <sipa> sends to future witness versions are standard already
532 2020-07-28T23:55:31  <sipa> only spends from them aren't
533 2020-07-28T23:55:33  <sipa> ah.
534 2020-07-28T23:55:34  <sdaftuar> i'd have to double-chekc, but i think if taproot supported p2sh wrapped outputs, the witness check would happen elsewhere no?
535 2020-07-28T23:55:48  <sipa> but this also means that AreInputsStandard won't detect this
536 2020-07-28T23:56:10  <sipa> it needs script execution to detect?
537 2020-07-28T23:56:13  <sdaftuar> i think it will -- i think spending a (bare) v1 output will fail there
538 2020-07-28T23:56:23  <sdaftuar> we use that solver thing in AreInputsStandard? i'll double check
539 2020-07-28T23:56:58  <sipa> ah ye
540 2020-07-28T23:58:05  <sipa> Solver will return WITNESS_UNKNOWN, which isn't automatically rejected
541 2020-07-28T23:58:31  <sipa> by AreInputsStandard, but it easily could be made so
542 2020-07-28T23:59:00  <sdaftuar> oh, you're right -- i assumed that was a failure
543 2020-07-28T23:59:14  <sdaftuar> odd