1 2020-08-02T00:00:03  *** Perceptes has quit IRC
  2 2020-08-02T00:01:29  *** proofofkeags has quit IRC
  3 2020-08-02T00:05:29  *** Tennis has quit IRC
  4 2020-08-02T00:06:08  *** mdunnio has joined #bitcoin-core-dev
  5 2020-08-02T00:06:51  *** promag has quit IRC
  6 2020-08-02T00:07:28  *** promag has joined #bitcoin-core-dev
  7 2020-08-02T00:09:02  *** kinlo has quit IRC
  8 2020-08-02T00:10:28  *** mdunnio has quit IRC
  9 2020-08-02T00:11:50  *** promag has quit IRC
 10 2020-08-02T00:21:34  *** binwiederhier has joined #bitcoin-core-dev
 11 2020-08-02T00:22:57  *** go121212 has joined #bitcoin-core-dev
 12 2020-08-02T00:25:46  *** go11111111111 has quit IRC
 13 2020-08-02T00:36:07  *** proofofkeags has joined #bitcoin-core-dev
 14 2020-08-02T00:39:27  *** promag has joined #bitcoin-core-dev
 15 2020-08-02T00:40:16  *** proofofkeags has quit IRC
 16 2020-08-02T00:43:01  *** kinlo has joined #bitcoin-core-dev
 17 2020-08-02T00:43:23  *** kinlo has joined #bitcoin-core-dev
 18 2020-08-02T00:45:03  <meshcollider> review beg for #15382
 19 2020-08-02T00:45:05  <gribble> https://github.com/bitcoin/bitcoin/issues/15382 | util: add RunCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
 20 2020-08-02T00:45:22  <meshcollider> very nearly RTM
 21 2020-08-02T01:11:16  *** proofofkeags has joined #bitcoin-core-dev
 22 2020-08-02T01:15:38  *** proofofkeags has quit IRC
 23 2020-08-02T01:18:15  *** promag has quit IRC
 24 2020-08-02T01:18:52  *** promag has joined #bitcoin-core-dev
 25 2020-08-02T01:22:58  *** promag has quit IRC
 26 2020-08-02T01:30:59  *** alko89 has quit IRC
 27 2020-08-02T01:49:04  *** go11111111111 has joined #bitcoin-core-dev
 28 2020-08-02T01:50:44  *** go11111111111 has quit IRC
 29 2020-08-02T01:51:03  *** shesek has quit IRC
 30 2020-08-02T01:51:05  *** go121212 has quit IRC
 31 2020-08-02T01:51:06  *** go11111111111 has joined #bitcoin-core-dev
 32 2020-08-02T01:51:43  *** gzhao408 has quit IRC
 33 2020-08-02T01:53:59  *** go11111111111 has quit IRC
 34 2020-08-02T01:55:31  *** go1111111 has joined #bitcoin-core-dev
 35 2020-08-02T01:55:31  *** promag has joined #bitcoin-core-dev
 36 2020-08-02T01:56:04  *** go1111111 has quit IRC
 37 2020-08-02T01:56:19  *** go1111111 has joined #bitcoin-core-dev
 38 2020-08-02T01:57:41  *** go1111111 has quit IRC
 39 2020-08-02T01:58:03  *** go1111111 has joined #bitcoin-core-dev
 40 2020-08-02T01:59:18  *** go1111111 has quit IRC
 41 2020-08-02T01:59:38  *** go1111111 has joined #bitcoin-core-dev
 42 2020-08-02T01:59:54  *** promag has quit IRC
 43 2020-08-02T02:08:56  *** go11111111111 has joined #bitcoin-core-dev
 44 2020-08-02T02:10:11  *** AaronvanW has joined #bitcoin-core-dev
 45 2020-08-02T02:11:16  *** go1111111 has quit IRC
 46 2020-08-02T02:38:21  *** hekl68 has joined #bitcoin-core-dev
 47 2020-08-02T02:56:08  *** arowser_ has quit IRC
 48 2020-08-02T02:56:41  *** arowser_ has joined #bitcoin-core-dev
 49 2020-08-02T02:56:48  *** schmidty has quit IRC
 50 2020-08-02T02:56:49  *** vfP56jSe has quit IRC
 51 2020-08-02T02:57:15  *** amiti has quit IRC
 52 2020-08-02T02:57:17  *** Isthmus has quit IRC
 53 2020-08-02T02:57:28  *** amiti has joined #bitcoin-core-dev
 54 2020-08-02T02:58:36  *** vfP56jSe has joined #bitcoin-core-dev
 55 2020-08-02T02:59:31  *** michagogo has quit IRC
 56 2020-08-02T03:00:01  *** binwiederhier has quit IRC
 57 2020-08-02T03:00:19  *** Isthmus has joined #bitcoin-core-dev
 58 2020-08-02T03:01:21  *** michagogo has joined #bitcoin-core-dev
 59 2020-08-02T03:12:23  *** proofofkeags has joined #bitcoin-core-dev
 60 2020-08-02T03:12:30  *** alko89 has joined #bitcoin-core-dev
 61 2020-08-02T03:14:34  *** schmidty has joined #bitcoin-core-dev
 62 2020-08-02T03:16:35  *** proofofkeags has quit IRC
 63 2020-08-02T03:20:40  *** Maijin has joined #bitcoin-core-dev
 64 2020-08-02T03:41:32  *** AaronvanW has quit IRC
 65 2020-08-02T03:42:11  *** AaronvanW has joined #bitcoin-core-dev
 66 2020-08-02T03:46:25  *** AaronvanW has quit IRC
 67 2020-08-02T03:51:54  *** proofofkeags has joined #bitcoin-core-dev
 68 2020-08-02T03:56:05  *** proofofkeags has quit IRC
 69 2020-08-02T04:20:35  *** justanotheruser has quit IRC
 70 2020-08-02T04:26:35  *** proofofkeags has joined #bitcoin-core-dev
 71 2020-08-02T04:58:04  *** mdunnio has joined #bitcoin-core-dev
 72 2020-08-02T05:02:25  *** mdunnio has quit IRC
 73 2020-08-02T05:16:23  *** promag has joined #bitcoin-core-dev
 74 2020-08-02T05:18:13  *** shesek has joined #bitcoin-core-dev
 75 2020-08-02T05:18:13  *** shesek has joined #bitcoin-core-dev
 76 2020-08-02T05:19:49  *** proofofkeags has quit IRC
 77 2020-08-02T05:20:24  *** proofofkeags has joined #bitcoin-core-dev
 78 2020-08-02T05:21:05  *** promag has quit IRC
 79 2020-08-02T05:24:35  *** proofofkeags has quit IRC
 80 2020-08-02T05:51:56  *** Talkless has joined #bitcoin-core-dev
 81 2020-08-02T05:53:06  *** justanotheruser has joined #bitcoin-core-dev
 82 2020-08-02T06:00:02  *** Maijin has quit IRC
 83 2020-08-02T06:14:03  *** Talkless has quit IRC
 84 2020-08-02T06:20:15  *** sendak has joined #bitcoin-core-dev
 85 2020-08-02T06:22:36  *** Talkless has joined #bitcoin-core-dev
 86 2020-08-02T06:39:32  *** tryphe_ has joined #bitcoin-core-dev
 87 2020-08-02T06:41:19  *** promag has joined #bitcoin-core-dev
 88 2020-08-02T06:42:25  *** tryphe has quit IRC
 89 2020-08-02T06:45:25  *** promag has quit IRC
 90 2020-08-02T07:02:56  *** Pavlenex has joined #bitcoin-core-dev
 91 2020-08-02T07:15:17  *** Pavlenex has quit IRC
 92 2020-08-02T07:19:07  *** arowser_ has quit IRC
 93 2020-08-02T07:19:32  *** arowser_ has joined #bitcoin-core-dev
 94 2020-08-02T07:23:25  *** davec has quit IRC
 95 2020-08-02T07:28:41  *** davec has joined #bitcoin-core-dev
 96 2020-08-02T07:34:30  *** marcoagner has joined #bitcoin-core-dev
 97 2020-08-02T07:48:16  *** proofofkeags has joined #bitcoin-core-dev
 98 2020-08-02T07:51:06  *** mdunnio has joined #bitcoin-core-dev
 99 2020-08-02T07:52:06  *** bitcoin-git has joined #bitcoin-core-dev
100 2020-08-02T07:52:06  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f7c73b03d975...8443fb11ad64
101 2020-08-02T07:52:07  <bitcoin-git> bitcoin/master 05e2740 Wladimir J. van der Laan: doc: Add historical release notes for 0.20.1
102 2020-08-02T07:52:07  <bitcoin-git> bitcoin/master 8443fb1 MarcoFalke: Merge #19637: doc: Add historical release notes for 0.20.1
103 2020-08-02T07:52:09  *** bitcoin-git has left #bitcoin-core-dev
104 2020-08-02T07:52:26  *** bitcoin-git has joined #bitcoin-core-dev
105 2020-08-02T07:52:26  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19637: doc: Add historical release notes for 0.20.1 (master...2020_08_relnot_0.20.1) https://github.com/bitcoin/bitcoin/pull/19637
106 2020-08-02T07:52:27  *** bitcoin-git has left #bitcoin-core-dev
107 2020-08-02T07:52:56  *** proofofkeags has quit IRC
108 2020-08-02T08:06:01  *** Pavlenex has joined #bitcoin-core-dev
109 2020-08-02T08:14:50  *** bitcoin-git has joined #bitcoin-core-dev
110 2020-08-02T08:14:51  <bitcoin-git> [bitcoin] hebasto closed pull request #19627: build: Drop per-host faketime wrappers in gitian-linux build (master...200729-fake) https://github.com/bitcoin/bitcoin/pull/19627
111 2020-08-02T08:14:51  *** bitcoin-git has left #bitcoin-core-dev
112 2020-08-02T08:24:48  *** MrSquanchee has joined #bitcoin-core-dev
113 2020-08-02T08:36:27  *** sendak has quit IRC
114 2020-08-02T08:37:47  *** Santi has joined #bitcoin-core-dev
115 2020-08-02T08:37:56  *** Santi has left #bitcoin-core-dev
116 2020-08-02T08:51:08  *** mdunnio has quit IRC
117 2020-08-02T08:59:13  *** jeremyrubin has quit IRC
118 2020-08-02T09:18:08  *** promag has joined #bitcoin-core-dev
119 2020-08-02T09:18:23  *** arowser_ has quit IRC
120 2020-08-02T09:18:49  *** arowser_ has joined #bitcoin-core-dev
121 2020-08-02T09:21:16  *** Pavlenex has quit IRC
122 2020-08-02T09:21:16  *** reallll has joined #bitcoin-core-dev
123 2020-08-02T09:22:28  *** kinouchou has joined #bitcoin-core-dev
124 2020-08-02T09:23:02  *** promag has quit IRC
125 2020-08-02T09:23:52  *** mdunnio has joined #bitcoin-core-dev
126 2020-08-02T09:24:34  *** belcher_ has quit IRC
127 2020-08-02T09:28:25  *** mdunnio has quit IRC
128 2020-08-02T09:28:38  *** promag has joined #bitcoin-core-dev
129 2020-08-02T09:33:14  *** promag has quit IRC
130 2020-08-02T09:41:20  *** MrSquanchee has quit IRC
131 2020-08-02T10:01:00  *** mdunnio has joined #bitcoin-core-dev
132 2020-08-02T10:03:28  *** Gladyce68Hammes has joined #bitcoin-core-dev
133 2020-08-02T10:05:32  *** mdunnio has quit IRC
134 2020-08-02T10:19:52  *** Gladyce68Hammes has quit IRC
135 2020-08-02T10:44:53  *** bitcoin-git has joined #bitcoin-core-dev
136 2020-08-02T10:44:54  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8443fb11ad64...a78742830aa3
137 2020-08-02T10:44:55  <bitcoin-git> bitcoin/master 334de75 Robert: scripted-diff: Remove Reference Links
138 2020-08-02T10:44:56  <bitcoin-git> bitcoin/master a787428 MarcoFalke: Merge #19639: doc: Remove Reference Links #19582
139 2020-08-02T10:44:58  *** bitcoin-git has left #bitcoin-core-dev
140 2020-08-02T10:45:13  *** bitcoin-git has joined #bitcoin-core-dev
141 2020-08-02T10:45:14  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19639: doc: Remove Reference Links #19582 (master...remove-reference-links) https://github.com/bitcoin/bitcoin/pull/19639
142 2020-08-02T10:45:15  *** bitcoin-git has left #bitcoin-core-dev
143 2020-08-02T10:46:08  *** bitcoin-git has joined #bitcoin-core-dev
144 2020-08-02T10:46:09  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #19584: doc: Update obsolete links to online reference #19582 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/19584
145 2020-08-02T10:46:20  *** bitcoin-git has left #bitcoin-core-dev
146 2020-08-02T10:48:15  *** balbirs has quit IRC
147 2020-08-02T10:48:33  *** balbirs has joined #bitcoin-core-dev
148 2020-08-02T10:53:19  *** Talkless has quit IRC
149 2020-08-02T10:55:35  *** vasild_ has joined #bitcoin-core-dev
150 2020-08-02T10:59:03  *** vasild has quit IRC
151 2020-08-02T10:59:04  *** vasild_ is now known as vasild
152 2020-08-02T11:16:29  *** gzhao408 has joined #bitcoin-core-dev
153 2020-08-02T11:31:11  *** gzhao408 has quit IRC
154 2020-08-02T11:52:57  *** knote3 has joined #bitcoin-core-dev
155 2020-08-02T12:00:02  *** kinouchou has quit IRC
156 2020-08-02T12:03:11  *** knote3 has left #bitcoin-core-dev
157 2020-08-02T12:21:48  *** Dieterbe1 has joined #bitcoin-core-dev
158 2020-08-02T12:43:48  *** Guyver2 has joined #bitcoin-core-dev
159 2020-08-02T12:55:08  *** arowser_ has quit IRC
160 2020-08-02T12:55:44  *** arowser_ has joined #bitcoin-core-dev
161 2020-08-02T12:56:12  *** mdunnio has joined #bitcoin-core-dev
162 2020-08-02T13:00:48  *** mdunnio has quit IRC
163 2020-08-02T13:04:29  <instagibbs> fjahr, https://github.com/bitcoin/bitcoin/pull/18044/commits/8d8099e97ab8af2126f6fbd223fbd82c52f2e85e#r464076378 am I missing something?
164 2020-08-02T13:05:08  *** arowser_ has quit IRC
165 2020-08-02T13:05:32  *** arowser_ has joined #bitcoin-core-dev
166 2020-08-02T13:06:10  *** arowser_ has quit IRC
167 2020-08-02T13:06:35  *** arowser_ has joined #bitcoin-core-dev
168 2020-08-02T13:08:08  *** arowser_ has quit IRC
169 2020-08-02T13:08:33  *** arowser_ has joined #bitcoin-core-dev
170 2020-08-02T13:10:09  *** arowser_ has quit IRC
171 2020-08-02T13:10:27  *** arowser_ has joined #bitcoin-core-dev
172 2020-08-02T13:12:11  *** arowser_ has quit IRC
173 2020-08-02T13:12:47  *** arowser_ has joined #bitcoin-core-dev
174 2020-08-02T13:16:10  *** arowser_ has quit IRC
175 2020-08-02T13:16:31  *** arowser_ has joined #bitcoin-core-dev
176 2020-08-02T13:17:11  *** arowser_ has quit IRC
177 2020-08-02T13:17:39  *** arowser_ has joined #bitcoin-core-dev
178 2020-08-02T13:19:25  *** alko89 has quit IRC
179 2020-08-02T13:28:01  *** gzhao408 has joined #bitcoin-core-dev
180 2020-08-02T13:38:04  *** bitcoin-git has joined #bitcoin-core-dev
181 2020-08-02T13:38:04  <bitcoin-git> [bitcoin] theStack closed pull request #19626: refactor: replace sizeof(a)/sizeof(a[0]) by ARRAYLEN(a) (master...20200726-refactor-replace-sizeof-by-arraylen) https://github.com/bitcoin/bitcoin/pull/19626
182 2020-08-02T13:38:13  *** bitcoin-git has left #bitcoin-core-dev
183 2020-08-02T13:41:42  *** promag has joined #bitcoin-core-dev
184 2020-08-02T13:42:48  *** gzhao408 has quit IRC
185 2020-08-02T13:43:28  *** promag_ has joined #bitcoin-core-dev
186 2020-08-02T13:45:36  *** mdunnio has joined #bitcoin-core-dev
187 2020-08-02T13:46:38  *** promag has quit IRC
188 2020-08-02T13:53:33  *** Dieterbe1 has quit IRC
189 2020-08-02T14:08:51  *** Highway61 has joined #bitcoin-core-dev
190 2020-08-02T14:09:14  *** arowser_ has quit IRC
191 2020-08-02T14:09:33  *** arowser_ has joined #bitcoin-core-dev
192 2020-08-02T14:10:22  *** arowser_ has quit IRC
193 2020-08-02T14:10:42  *** arowser_ has joined #bitcoin-core-dev
194 2020-08-02T14:16:39  *** vincenzopalazzo has joined #bitcoin-core-dev
195 2020-08-02T14:26:04  *** Lasall has joined #bitcoin-core-dev
196 2020-08-02T14:27:07  *** reallll is now known as belcher
197 2020-08-02T14:33:30  *** alko89 has joined #bitcoin-core-dev
198 2020-08-02T14:34:02  *** bitcoin-git has joined #bitcoin-core-dev
199 2020-08-02T14:34:02  <bitcoin-git> [bitcoin] hebasto opened pull request #19642: Fix deadlock detection for RecursiveMutex (master...200802-rmut) https://github.com/bitcoin/bitcoin/pull/19642
200 2020-08-02T14:34:02  *** bitcoin-git has left #bitcoin-core-dev
201 2020-08-02T14:46:07  *** promag_ has quit IRC
202 2020-08-02T14:48:13  *** justanotheruser has quit IRC
203 2020-08-02T14:49:25  *** mdunnio has quit IRC
204 2020-08-02T15:00:02  *** Lasall has quit IRC
205 2020-08-02T15:14:54  *** justanotheruser has joined #bitcoin-core-dev
206 2020-08-02T15:16:59  *** Chris_Stewart_5 has quit IRC
207 2020-08-02T15:19:56  *** itnet7 has joined #bitcoin-core-dev
208 2020-08-02T15:25:17  *** mdunnio has joined #bitcoin-core-dev
209 2020-08-02T15:28:11  *** Talkless has joined #bitcoin-core-dev
210 2020-08-02T15:28:17  *** mdunnio has quit IRC
211 2020-08-02T15:28:52  *** promag has joined #bitcoin-core-dev
212 2020-08-02T15:31:52  *** promag has quit IRC
213 2020-08-02T15:40:47  *** AaronvanW has joined #bitcoin-core-dev
214 2020-08-02T15:49:59  *** Talkless has quit IRC
215 2020-08-02T16:02:08  *** gzhao408 has joined #bitcoin-core-dev
216 2020-08-02T16:08:33  *** mdunnio has joined #bitcoin-core-dev
217 2020-08-02T16:10:21  *** onokatio has joined #bitcoin-core-dev
218 2020-08-02T16:13:28  *** mdunnio has quit IRC
219 2020-08-02T16:16:57  *** gzhao408 has quit IRC
220 2020-08-02T16:21:25  *** onokatio has quit IRC
221 2020-08-02T16:30:41  *** gzhao408 has joined #bitcoin-core-dev
222 2020-08-02T16:33:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
223 2020-08-02T16:35:07  *** bitcoin-git has joined #bitcoin-core-dev
224 2020-08-02T16:35:07  <bitcoin-git> [bitcoin] ariard closed pull request #18797: Export standard Script flags in bitcoinconsensus (master...2020-04-export-standard-flags) https://github.com/bitcoin/bitcoin/pull/18797
225 2020-08-02T16:35:08  *** bitcoin-git has left #bitcoin-core-dev
226 2020-08-02T16:36:21  <fjahr> instagibbs: I noticed some lines in the original tests that seemed like dublicates/unnecessary to me and did not add to the test coverage and I removed those (mentioned in the commit message). I think that had nothing to do with the changes in the test framework because I did those pretty late and I moved those lines pretty early when I started working on tests for wtxid iirc.
227 2020-08-02T16:38:27  *** bitcoin-git has joined #bitcoin-core-dev
228 2020-08-02T16:38:27  <bitcoin-git> [bitcoin] jonatack opened pull request #19643: Add `-netinfo` peer connections dashboard (master...netinfo) https://github.com/bitcoin/bitcoin/pull/19643
229 2020-08-02T16:38:28  *** bitcoin-git has left #bitcoin-core-dev
230 2020-08-02T16:45:49  *** Highway62 has joined #bitcoin-core-dev
231 2020-08-02T16:46:52  *** gzhao408 has quit IRC
232 2020-08-02T16:47:23  *** Highway61 has quit IRC
233 2020-08-02T16:47:23  *** Highway62 is now known as Highway61
234 2020-08-02T16:48:36  *** mdunnio has joined #bitcoin-core-dev
235 2020-08-02T16:49:56  *** bitcoin-git has joined #bitcoin-core-dev
236 2020-08-02T16:49:57  <bitcoin-git> [bitcoin] theStack opened pull request #19644: rpc: document returned error fields as optional if applicable (master...20200802-rpc-document_errors_fields_as_optional) https://github.com/bitcoin/bitcoin/pull/19644
237 2020-08-02T16:50:08  *** bitcoin-git has left #bitcoin-core-dev
238 2020-08-02T16:52:39  *** onokatio has joined #bitcoin-core-dev
239 2020-08-02T16:53:16  *** mdunnio has quit IRC
240 2020-08-02T16:53:41  *** onokatio has quit IRC
241 2020-08-02T16:56:10  <instagibbs> fjahr, ahok
242 2020-08-02T16:56:52  *** Highway61 has quit IRC
243 2020-08-02T16:58:37  <instagibbs> fjahr, it's not duplicate though, they were checking explicitly for a case we care about. Will continue in DM
244 2020-08-02T17:00:36  *** gzhao408 has joined #bitcoin-core-dev
245 2020-08-02T17:01:37  <elichai2> The new benchmark suite is cool, but I can't figure out which metric I should look at 😅
246 2020-08-02T17:02:56  <elichai2> should I look at ins/op? at cyc/op? at ns/op? something else? argh
247 2020-08-02T17:03:12  *** coinGuyBri has joined #bitcoin-core-dev
248 2020-08-02T17:04:22  *** Highway61 has joined #bitcoin-core-dev
249 2020-08-02T17:04:59  <elichai2> the only measure that actually stays consistent between each run is the instruction per ops, but I'm not sure when is it good enough (ie should I only look at that as long as I know there are no expensive SIMD/CRYPTO -like instructions? or is there also a big difference in the timing of ie MOV vs ADD)
250 2020-08-02T17:08:43  <sipa> elichai2: if your frequency scaling is off, they should all be proportional
251 2020-08-02T17:11:30  <sipa> and ultimately what you're interested in as absolutely numbers in ns/op; if you had to downscale your cpu speed to get consistent results, cyc/op may be better so you don't need to report "X ns/op @ frequency"
252 2020-08-02T17:11:55  <sipa> ins/op i don't know - perhaps that's just the best approximation to be had when your cpu is dynamically scaling frequency
253 2020-08-02T17:14:13  *** coinGuyBri has quit IRC
254 2020-08-02T17:15:02  *** coinGuyBri has joined #bitcoin-core-dev
255 2020-08-02T17:15:46  <elichai2> I'm locking the frequency using  `sudo pyperf system tune` but I still get small changes in the cycles+ns
256 2020-08-02T17:17:28  <sipa> to actually lock the frequency on my cpu i need to boot with intel_pstate=disable on the kernel commandline, i think
257 2020-08-02T17:18:17  <elichai2> oh wow, ok
258 2020-08-02T17:18:20  <sipa> but some variation of cycles/ns is inevitable, due to random environment changes, like memory layout, other processing interrupting, ...
259 2020-08-02T17:20:05  <elichai2> sipa: I just realized there's somewhat of a bug in the siphash, you can't mix between calling `CSipHasher& Write(uint64_t data);` and `CSipHasher& Write(const unsigned char* data, size_t size);` because the former will ignore anything that the latter hasn't hashed yet
260 2020-08-02T17:21:56  <sipa> elichai2: that's documented
261 2020-08-02T17:22:15  <elichai2> "This function can only be used when a multiple of 8 bytes have been written so far" :D
262 2020-08-02T17:22:16  <sipa>     /** Hash a 64-bit integer worth of data
263 2020-08-02T17:22:17  <sipa>      *  It is treated as if this was the little-endian interpretation of 8 bytes.
264 2020-08-02T17:22:17  <elichai2> You're right
265 2020-08-02T17:22:19  <sipa>      *  This function can only be used when a multiple of 8 bytes have been written so far.
266 2020-08-02T17:22:22  <sipa>      */
267 2020-08-02T17:24:12  <elichai2> I need to pay more attention to comments :P
268 2020-08-02T17:29:49  *** Pavlenex has joined #bitcoin-core-dev
269 2020-08-02T17:30:33  *** coinGuyBri has quit IRC
270 2020-08-02T17:31:16  *** onokatio has joined #bitcoin-core-dev
271 2020-08-02T17:35:39  *** coinGuyBri has joined #bitcoin-core-dev
272 2020-08-02T17:37:13  *** coinGuyBri has quit IRC
273 2020-08-02T17:37:28  <phantomcircuit> sipa, im assuming the single parameter just blindly modifies the state assuming it's already on an 8 byte boundary right?
274 2020-08-02T17:38:50  <phantomcircuit> it's got an assert that would catch using it improperly actually
275 2020-08-02T17:39:09  <sipa> indeed
276 2020-08-02T17:42:14  *** jeremyrubin has joined #bitcoin-core-dev
277 2020-08-02T17:42:52  <phantomcircuit> sipa, this is probably pedantic af, but what's the advantage of using an assert there instead of throwing an exception?
278 2020-08-02T17:43:26  <phantomcircuit> are asserts still always enabled?
279 2020-08-02T17:43:48  <sipa> yes
280 2020-08-02T17:44:04  <elichai2> bitcoin core is always compiled with asserts enabled
281 2020-08-02T17:46:13  <phantomcircuit> that's an instance where it's not concensus critical that it fail and the only way to catch a violation of the api is at runtime, so maybe it should be an exception not an assert?
282 2020-08-02T17:46:18  <phantomcircuit> anyways, pedantry
283 2020-08-02T17:47:00  <sipa> phantomcircuit: that's always a hard question; clearly some assumptions underlying the code are wrong, so it becomes very hard to reason about correctness
284 2020-08-02T17:50:15  <phantomcircuit> sipa, this is of course not in-scope for bitcoin dev but i've tried using some of the "library"ish things outside of core before and mostly run into random things like needing uint256 which then needs the serialization stuff
285 2020-08-02T17:55:36  <phantomcircuit> things like throwing an exception instead of calling assert would be useful for that, but like
286 2020-08-02T17:55:37  <phantomcircuit> yeah
287 2020-08-02T17:57:09  *** Pavlenex has quit IRC
288 2020-08-02T18:00:01  *** itnet7 has quit IRC
289 2020-08-02T18:04:57  *** promag has joined #bitcoin-core-dev
290 2020-08-02T18:07:33  *** justanotheruser has quit IRC
291 2020-08-02T18:09:49  *** promag has quit IRC
292 2020-08-02T18:13:55  *** tryphe has joined #bitcoin-core-dev
293 2020-08-02T18:14:35  *** tryphe_ has quit IRC
294 2020-08-02T18:18:24  *** bitcoin-git has joined #bitcoin-core-dev
295 2020-08-02T18:18:24  <bitcoin-git> [bitcoin] ariard opened pull request #19645: Allow wtxid-acceptance to the mempool (master...2020-08-wtxid-replacement) https://github.com/bitcoin/bitcoin/pull/19645
296 2020-08-02T18:18:25  *** promag has joined #bitcoin-core-dev
297 2020-08-02T18:18:25  *** bitcoin-git has left #bitcoin-core-dev
298 2020-08-02T18:22:05  *** mengu has joined #bitcoin-core-dev
299 2020-08-02T18:22:21  *** mengu is now known as Guest67272
300 2020-08-02T18:24:35  *** Tralfaz has quit IRC
301 2020-08-02T18:25:20  *** cfields_ has quit IRC
302 2020-08-02T18:37:14  *** Highway61 has quit IRC
303 2020-08-02T18:40:04  *** cfields has joined #bitcoin-core-dev
304 2020-08-02T18:41:01  *** promag has quit IRC
305 2020-08-02T18:41:44  *** promag has joined #bitcoin-core-dev
306 2020-08-02T18:46:17  *** jarthur has joined #bitcoin-core-dev
307 2020-08-02T18:47:00  *** promag has quit IRC
308 2020-08-02T18:49:12  *** promag has joined #bitcoin-core-dev
309 2020-08-02T18:51:14  *** promag has quit IRC
310 2020-08-02T18:59:14  *** promag has joined #bitcoin-core-dev
311 2020-08-02T19:11:07  *** promag has quit IRC
312 2020-08-02T19:28:16  *** Highway61 has joined #bitcoin-core-dev
313 2020-08-02T19:37:35  *** gzhao408 has quit IRC
314 2020-08-02T19:44:19  *** bitcoin-git has joined #bitcoin-core-dev
315 2020-08-02T19:44:20  <bitcoin-git> [bitcoin] hebasto closed pull request #19642: Fix potential deadlock detection for RecursiveMutex (master...200802-rmut) https://github.com/bitcoin/bitcoin/pull/19642
316 2020-08-02T19:44:21  *** bitcoin-git has left #bitcoin-core-dev
317 2020-08-02T19:54:07  *** mdunnio has joined #bitcoin-core-dev
318 2020-08-02T19:56:25  *** bitcoin-git has joined #bitcoin-core-dev
319 2020-08-02T19:56:25  <bitcoin-git> [bitcoin] jakeleventhal opened pull request #19646: doc: Updated outdated help command for getblocktemplate (fixes #19625) (master...fix-outdated-getblocktemplate-help) https://github.com/bitcoin/bitcoin/pull/19646
320 2020-08-02T19:56:26  *** bitcoin-git has left #bitcoin-core-dev
321 2020-08-02T19:58:34  *** mdunnio has quit IRC
322 2020-08-02T20:00:45  *** arowser_ has quit IRC
323 2020-08-02T20:01:08  *** arowser_ has joined #bitcoin-core-dev
324 2020-08-02T20:14:39  *** promag has joined #bitcoin-core-dev
325 2020-08-02T20:24:30  *** mdunnio has joined #bitcoin-core-dev
326 2020-08-02T20:30:15  *** promag has quit IRC
327 2020-08-02T20:43:15  *** mutatrum has joined #bitcoin-core-dev
328 2020-08-02T20:53:10  *** mutatrum has quit IRC
329 2020-08-02T21:00:02  *** Guest67272 has quit IRC
330 2020-08-02T21:05:33  *** Henry151 has quit IRC
331 2020-08-02T21:06:01  *** promag has joined #bitcoin-core-dev
332 2020-08-02T21:16:42  *** Guyver2 has quit IRC
333 2020-08-02T21:21:54  *** strattog has joined #bitcoin-core-dev
334 2020-08-02T21:22:03  *** gzhao408 has joined #bitcoin-core-dev
335 2020-08-02T21:24:15  *** mdunnio has quit IRC
336 2020-08-02T21:25:01  *** Davterra has joined #bitcoin-core-dev
337 2020-08-02T21:27:48  *** mdunnio has joined #bitcoin-core-dev
338 2020-08-02T21:27:48  *** mdunnio has quit IRC
339 2020-08-02T21:28:21  *** mdunnio has joined #bitcoin-core-dev
340 2020-08-02T21:33:14  *** mdunnio has quit IRC
341 2020-08-02T21:43:41  *** gzhao408 has quit IRC
342 2020-08-02T22:02:20  *** mdunnio has joined #bitcoin-core-dev
343 2020-08-02T22:07:25  *** mdunnio has quit IRC
344 2020-08-02T22:10:11  *** promag has quit IRC
345 2020-08-02T22:14:49  *** promag has joined #bitcoin-core-dev
346 2020-08-02T22:19:44  *** promag has quit IRC
347 2020-08-02T22:20:36  *** promag has joined #bitcoin-core-dev
348 2020-08-02T22:27:07  *** dgenr8 has quit IRC
349 2020-08-02T22:28:55  *** marcoagner has quit IRC
350 2020-08-02T22:29:07  *** promag has quit IRC
351 2020-08-02T22:39:44  *** dgenr8 has joined #bitcoin-core-dev
352 2020-08-02T22:42:50  *** bitcoin-git has joined #bitcoin-core-dev
353 2020-08-02T22:42:50  <bitcoin-git> [bitcoin] hebasto opened pull request #19647: Add thread safety annotations to CTxMemPool methods (master...200802-mmx-1) https://github.com/bitcoin/bitcoin/pull/19647
354 2020-08-02T22:42:51  *** bitcoin-git has left #bitcoin-core-dev
355 2020-08-02T22:55:31  *** vasild_ has joined #bitcoin-core-dev
356 2020-08-02T22:58:43  *** vasild has quit IRC
357 2020-08-02T22:58:44  *** vasild_ is now known as vasild
358 2020-08-02T22:59:09  *** Henry151 has joined #bitcoin-core-dev
359 2020-08-02T22:59:52  *** AaronvanW has quit IRC
360 2020-08-02T23:26:23  *** vincenzopalazzo has quit IRC
361 2020-08-02T23:35:06  *** promag has joined #bitcoin-core-dev
362 2020-08-02T23:48:04  *** cfields_ has joined #bitcoin-core-dev
363 2020-08-02T23:48:21  *** cfields has quit IRC