1 2020-08-03T00:00:02  *** strattog has quit IRC
  2 2020-08-03T00:00:33  *** Pavlenex has joined #bitcoin-core-dev
  3 2020-08-03T00:08:44  *** justanotheruser has joined #bitcoin-core-dev
  4 2020-08-03T00:13:59  *** Pavlenex has quit IRC
  5 2020-08-03T00:20:02  *** justanotheruser has quit IRC
  6 2020-08-03T00:20:11  *** AaronvanW has joined #bitcoin-core-dev
  7 2020-08-03T00:21:57  *** traph has joined #bitcoin-core-dev
  8 2020-08-03T00:27:58  *** gzhao408 has joined #bitcoin-core-dev
  9 2020-08-03T00:33:14  *** promag has quit IRC
 10 2020-08-03T00:50:20  *** AaronvanW has quit IRC
 11 2020-08-03T01:03:37  *** bitcoin-git has joined #bitcoin-core-dev
 12 2020-08-03T01:03:37  <bitcoin-git> [bitcoin] instagibbs opened pull request #19649: Restore test case for p2p transaction blinding (master...p2p_segwit_reject) https://github.com/bitcoin/bitcoin/pull/19649
 13 2020-08-03T01:03:38  *** bitcoin-git has left #bitcoin-core-dev
 14 2020-08-03T01:05:05  *** tomahawk has joined #bitcoin-core-dev
 15 2020-08-03T01:06:19  *** tomahawk has quit IRC
 16 2020-08-03T01:11:55  *** troygiorshev has joined #bitcoin-core-dev
 17 2020-08-03T01:44:29  *** gzhao408 has quit IRC
 18 2020-08-03T01:51:13  *** shesek has quit IRC
 19 2020-08-03T01:53:09  *** mdunnio has joined #bitcoin-core-dev
 20 2020-08-03T01:57:23  *** mdunnio has quit IRC
 21 2020-08-03T02:05:10  *** arowser_ has quit IRC
 22 2020-08-03T02:05:38  *** arowser_ has joined #bitcoin-core-dev
 23 2020-08-03T02:12:20  *** proofofkeags has joined #bitcoin-core-dev
 24 2020-08-03T02:19:36  *** AaronvanW has joined #bitcoin-core-dev
 25 2020-08-03T02:21:50  *** Highway61 has quit IRC
 26 2020-08-03T02:23:09  *** Bullitje has joined #bitcoin-core-dev
 27 2020-08-03T02:25:53  *** Bullit has quit IRC
 28 2020-08-03T02:27:59  *** gzhao408 has joined #bitcoin-core-dev
 29 2020-08-03T02:48:12  *** justanotheruser has joined #bitcoin-core-dev
 30 2020-08-03T02:49:12  *** arowser_ has quit IRC
 31 2020-08-03T02:49:40  *** arowser_ has joined #bitcoin-core-dev
 32 2020-08-03T02:52:35  *** AaronvanW has quit IRC
 33 2020-08-03T02:55:53  *** proofofkeags has quit IRC
 34 2020-08-03T02:56:26  *** proofofkeags has joined #bitcoin-core-dev
 35 2020-08-03T03:00:01  *** traph has quit IRC
 36 2020-08-03T03:01:00  *** proofofkeags has quit IRC
 37 2020-08-03T03:05:11  *** arowser_ has quit IRC
 38 2020-08-03T03:05:39  *** arowser_ has joined #bitcoin-core-dev
 39 2020-08-03T03:08:03  *** luke-jr has quit IRC
 40 2020-08-03T03:08:58  *** luke-jr has joined #bitcoin-core-dev
 41 2020-08-03T03:12:12  *** cfields_ has quit IRC
 42 2020-08-03T03:12:22  *** cfields has joined #bitcoin-core-dev
 43 2020-08-03T03:12:38  *** AaronvanW has joined #bitcoin-core-dev
 44 2020-08-03T03:14:08  *** cfields has quit IRC
 45 2020-08-03T03:15:03  *** cfields has joined #bitcoin-core-dev
 46 2020-08-03T03:15:45  *** cfields has quit IRC
 47 2020-08-03T03:22:18  *** glidenote has joined #bitcoin-core-dev
 48 2020-08-03T03:23:59  *** arowser_ has quit IRC
 49 2020-08-03T03:24:24  *** arowser_ has joined #bitcoin-core-dev
 50 2020-08-03T03:28:59  *** rabidus has quit IRC
 51 2020-08-03T03:29:39  *** berndj has quit IRC
 52 2020-08-03T03:29:59  *** rabidus has joined #bitcoin-core-dev
 53 2020-08-03T03:30:15  *** berndj has joined #bitcoin-core-dev
 54 2020-08-03T03:38:16  *** justanotheruser has quit IRC
 55 2020-08-03T03:38:54  *** justanotheruser has joined #bitcoin-core-dev
 56 2020-08-03T03:41:21  *** bitcoin-git has joined #bitcoin-core-dev
 57 2020-08-03T03:41:21  <bitcoin-git> [bitcoin] kallewoof reopened pull request #14582: wallet: always do avoid partial spends if fees are within a specified range (master...181026-try-avoidpartialspends) https://github.com/bitcoin/bitcoin/pull/14582
 58 2020-08-03T03:41:22  *** bitcoin-git has left #bitcoin-core-dev
 59 2020-08-03T03:46:47  *** jarthur_ has joined #bitcoin-core-dev
 60 2020-08-03T03:47:32  *** jarthur has quit IRC
 61 2020-08-03T04:01:11  *** arowser_ has quit IRC
 62 2020-08-03T04:01:37  *** arowser_ has joined #bitcoin-core-dev
 63 2020-08-03T04:02:14  *** gzhao408 has quit IRC
 64 2020-08-03T04:31:06  *** shesek has joined #bitcoin-core-dev
 65 2020-08-03T04:31:06  *** shesek has joined #bitcoin-core-dev
 66 2020-08-03T05:02:58  *** dviola has joined #bitcoin-core-dev
 67 2020-08-03T05:06:57  *** dviola has quit IRC
 68 2020-08-03T05:09:03  *** Talkless has joined #bitcoin-core-dev
 69 2020-08-03T06:00:02  *** glidenote has quit IRC
 70 2020-08-03T06:06:25  *** onokatio has quit IRC
 71 2020-08-03T06:21:32  *** arowser_ has quit IRC
 72 2020-08-03T06:22:11  *** Snuupy1 has joined #bitcoin-core-dev
 73 2020-08-03T06:22:35  *** luke-jr has quit IRC
 74 2020-08-03T06:23:35  *** arowser_ has joined #bitcoin-core-dev
 75 2020-08-03T06:25:28  *** luke-jr has joined #bitcoin-core-dev
 76 2020-08-03T07:15:38  *** marcoagner has joined #bitcoin-core-dev
 77 2020-08-03T07:19:23  *** TheHoliestRoger has quit IRC
 78 2020-08-03T07:21:40  *** TheHoliestRoger has joined #bitcoin-core-dev
 79 2020-08-03T07:36:06  *** justanotheruser has quit IRC
 80 2020-08-03T07:43:54  *** promag has joined #bitcoin-core-dev
 81 2020-08-03T07:48:36  *** jonatack has quit IRC
 82 2020-08-03T07:48:52  *** promag has quit IRC
 83 2020-08-03T07:56:44  *** dviola has joined #bitcoin-core-dev
 84 2020-08-03T07:57:52  *** promag has joined #bitcoin-core-dev
 85 2020-08-03T08:00:08  *** arowser_ has quit IRC
 86 2020-08-03T08:00:36  *** arowser_ has joined #bitcoin-core-dev
 87 2020-08-03T08:02:28  *** promag has quit IRC
 88 2020-08-03T08:21:36  *** victorSN has quit IRC
 89 2020-08-03T08:21:36  *** rockhouse has quit IRC
 90 2020-08-03T08:24:11  *** rockhouse has joined #bitcoin-core-dev
 91 2020-08-03T08:24:32  *** victorSN has joined #bitcoin-core-dev
 92 2020-08-03T08:28:57  *** Guyver2 has joined #bitcoin-core-dev
 93 2020-08-03T08:31:01  *** promag has joined #bitcoin-core-dev
 94 2020-08-03T08:35:50  *** promag has quit IRC
 95 2020-08-03T08:38:35  *** arowser_ has quit IRC
 96 2020-08-03T08:38:59  *** arowser_ has joined #bitcoin-core-dev
 97 2020-08-03T08:40:12  *** arowser_ has quit IRC
 98 2020-08-03T08:40:51  *** arowser_ has joined #bitcoin-core-dev
 99 2020-08-03T08:41:11  *** arowser_ has quit IRC
100 2020-08-03T08:41:31  *** arowser_ has joined #bitcoin-core-dev
101 2020-08-03T08:53:04  *** arowser_ has quit IRC
102 2020-08-03T08:56:43  *** arowser_ has joined #bitcoin-core-dev
103 2020-08-03T09:00:02  *** Snuupy1 has quit IRC
104 2020-08-03T09:01:34  *** wullon5 has quit IRC
105 2020-08-03T09:04:59  *** SergeySherkunov[ has quit IRC
106 2020-08-03T09:05:14  *** promag has joined #bitcoin-core-dev
107 2020-08-03T09:06:04  *** Pavlenex has joined #bitcoin-core-dev
108 2020-08-03T09:12:41  *** BGL has quit IRC
109 2020-08-03T09:13:21  *** infamously[m] has left #bitcoin-core-dev
110 2020-08-03T09:16:38  *** jonas_ has joined #bitcoin-core-dev
111 2020-08-03T09:17:43  *** Pavlenex has quit IRC
112 2020-08-03T09:20:45  *** Gunni1 has joined #bitcoin-core-dev
113 2020-08-03T09:21:32  *** belcher_ has joined #bitcoin-core-dev
114 2020-08-03T09:24:45  *** belcher has quit IRC
115 2020-08-03T09:25:43  *** jb55 has quit IRC
116 2020-08-03T09:31:17  *** promag has quit IRC
117 2020-08-03T09:31:54  *** promag has joined #bitcoin-core-dev
118 2020-08-03T09:33:45  *** arowser_ has quit IRC
119 2020-08-03T09:36:11  *** promag has quit IRC
120 2020-08-03T09:36:49  *** jonatack has joined #bitcoin-core-dev
121 2020-08-03T09:37:23  *** arowser_ has joined #bitcoin-core-dev
122 2020-08-03T09:37:23  *** jonatack has quit IRC
123 2020-08-03T09:38:40  *** promag has joined #bitcoin-core-dev
124 2020-08-03T09:39:17  *** jb55 has joined #bitcoin-core-dev
125 2020-08-03T09:43:38  *** jonatack has joined #bitcoin-core-dev
126 2020-08-03T09:44:25  *** promag has quit IRC
127 2020-08-03T09:45:02  *** promag has joined #bitcoin-core-dev
128 2020-08-03T09:49:41  *** promag has quit IRC
129 2020-08-03T09:53:08  *** arowser_ has quit IRC
130 2020-08-03T09:53:36  *** arowser_ has joined #bitcoin-core-dev
131 2020-08-03T09:56:02  *** jonas_ has quit IRC
132 2020-08-03T10:03:26  *** Annie78Runte has joined #bitcoin-core-dev
133 2020-08-03T10:05:39  *** promag has joined #bitcoin-core-dev
134 2020-08-03T10:08:56  *** Pavlenex has joined #bitcoin-core-dev
135 2020-08-03T10:11:48  *** promag_ has joined #bitcoin-core-dev
136 2020-08-03T10:13:25  *** arowser_ has quit IRC
137 2020-08-03T10:15:05  *** promag has quit IRC
138 2020-08-03T10:15:16  *** BGL has joined #bitcoin-core-dev
139 2020-08-03T10:16:05  *** belcher_ has quit IRC
140 2020-08-03T10:16:17  *** promag_ has quit IRC
141 2020-08-03T10:16:47  *** promag has joined #bitcoin-core-dev
142 2020-08-03T10:16:58  *** arowser_ has joined #bitcoin-core-dev
143 2020-08-03T10:18:15  *** wullon5 has joined #bitcoin-core-dev
144 2020-08-03T10:22:26  <jnewbery> wumpus MarcoFalke fanquake: I think #18991 may be ready for merge. It's had a ton of review and has three ACKs on the most recent branch (and a bunch more ACKs/concept ACKs on previous branches)
145 2020-08-03T10:22:29  <gribble> https://github.com/bitcoin/bitcoin/issues/18991 | Cache responses to GETADDR to prevent topology leaks by naumenkogs · Pull Request #18991 · bitcoin/bitcoin · GitHub
146 2020-08-03T10:24:41  *** Annie78Runte has quit IRC
147 2020-08-03T10:27:36  *** Pavlenex has quit IRC
148 2020-08-03T10:28:46  *** Highway61 has joined #bitcoin-core-dev
149 2020-08-03T10:36:29  *** Highway61 has quit IRC
150 2020-08-03T10:41:37  *** promag has quit IRC
151 2020-08-03T10:42:09  *** arowser_ has quit IRC
152 2020-08-03T10:42:32  *** arowser_ has joined #bitcoin-core-dev
153 2020-08-03T10:43:09  *** arowser_ has quit IRC
154 2020-08-03T10:43:38  *** arowser_ has joined #bitcoin-core-dev
155 2020-08-03T10:52:26  *** Highway61 has joined #bitcoin-core-dev
156 2020-08-03T10:55:08  *** harrigan has quit IRC
157 2020-08-03T10:55:24  *** harrigan has joined #bitcoin-core-dev
158 2020-08-03T10:55:41  *** vasild_ has joined #bitcoin-core-dev
159 2020-08-03T10:58:43  *** vasild has quit IRC
160 2020-08-03T10:58:45  *** vasild_ is now known as vasild
161 2020-08-03T11:02:35  *** promag has joined #bitcoin-core-dev
162 2020-08-03T11:06:41  *** andreacab has joined #bitcoin-core-dev
163 2020-08-03T11:06:55  *** jonatack has quit IRC
164 2020-08-03T11:07:10  *** promag has quit IRC
165 2020-08-03T11:39:38  *** andreacab has quit IRC
166 2020-08-03T11:40:05  *** andreacab has joined #bitcoin-core-dev
167 2020-08-03T11:43:17  *** Mercury_Vapor has quit IRC
168 2020-08-03T11:44:33  *** andreacab has quit IRC
169 2020-08-03T11:47:05  *** IGHOR has quit IRC
170 2020-08-03T11:47:23  *** bitcoin-git has joined #bitcoin-core-dev
171 2020-08-03T11:47:23  <bitcoin-git> [bitcoin] S3RK opened pull request #19651: wallet: allow import same descriptor twice (master...importdescriptors_twice) https://github.com/bitcoin/bitcoin/pull/19651
172 2020-08-03T11:47:24  *** bitcoin-git has left #bitcoin-core-dev
173 2020-08-03T11:48:49  *** troygiorshev has quit IRC
174 2020-08-03T11:49:32  *** Mercury_Vapor has joined #bitcoin-core-dev
175 2020-08-03T11:49:33  *** troygiorshev has joined #bitcoin-core-dev
176 2020-08-03T11:51:22  *** shesek has quit IRC
177 2020-08-03T11:54:59  *** harrigan has quit IRC
178 2020-08-03T11:56:02  *** harrigan has joined #bitcoin-core-dev
179 2020-08-03T12:00:02  *** Gunni1 has quit IRC
180 2020-08-03T12:02:16  *** proofofkeags has joined #bitcoin-core-dev
181 2020-08-03T12:02:28  <wumpus> jnewbery: thanks will take a look
182 2020-08-03T12:08:17  *** proofofkeags has quit IRC
183 2020-08-03T12:08:53  *** proofofkeags has joined #bitcoin-core-dev
184 2020-08-03T12:12:12  *** proofofkeags has quit IRC
185 2020-08-03T12:20:43  *** jb55 has quit IRC
186 2020-08-03T12:21:16  *** langseth1 has joined #bitcoin-core-dev
187 2020-08-03T12:21:20  *** jb55 has joined #bitcoin-core-dev
188 2020-08-03T12:24:18  *** Pavlenex has joined #bitcoin-core-dev
189 2020-08-03T12:31:17  *** proofofkeags has joined #bitcoin-core-dev
190 2020-08-03T12:44:46  *** shesek has joined #bitcoin-core-dev
191 2020-08-03T12:44:46  *** shesek has joined #bitcoin-core-dev
192 2020-08-03T12:50:04  *** bitcoin-git has joined #bitcoin-core-dev
193 2020-08-03T12:50:05  <bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/a78742830aa3...14ceddd29085
194 2020-08-03T12:50:05  <bitcoin-git> bitcoin/master ded742b Gleb Naumenko: Move filtering banned addrs inside GetAddresses()
195 2020-08-03T12:50:06  <bitcoin-git> bitcoin/master 7cc0e81 Gleb Naumenko: Remove useless 2500 limit on AddrMan queries
196 2020-08-03T12:50:06  <bitcoin-git> bitcoin/master acd6135 Gleb Naumenko: Cache responses to addr requests
197 2020-08-03T12:50:09  *** bitcoin-git has left #bitcoin-core-dev
198 2020-08-03T12:50:49  *** bitcoin-git has joined #bitcoin-core-dev
199 2020-08-03T12:50:49  <bitcoin-git> [bitcoin] laanwj merged pull request #18991: Cache responses to GETADDR to prevent topology leaks (master...2020-05-addr-response-caching) https://github.com/bitcoin/bitcoin/pull/18991
200 2020-08-03T12:50:58  *** bitcoin-git has left #bitcoin-core-dev
201 2020-08-03T12:57:17  *** arowser_ has quit IRC
202 2020-08-03T12:57:41  *** arowser_ has joined #bitcoin-core-dev
203 2020-08-03T13:03:57  *** Pavlenex has quit IRC
204 2020-08-03T13:06:19  *** arowser_ has quit IRC
205 2020-08-03T13:06:43  *** arowser_ has joined #bitcoin-core-dev
206 2020-08-03T13:08:10  *** arowser_ has quit IRC
207 2020-08-03T13:08:44  *** arowser_ has joined #bitcoin-core-dev
208 2020-08-03T13:09:11  *** arowser_ has quit IRC
209 2020-08-03T13:09:39  *** arowser_ has joined #bitcoin-core-dev
210 2020-08-03T13:10:09  *** arowser_ has quit IRC
211 2020-08-03T13:10:37  *** arowser_ has joined #bitcoin-core-dev
212 2020-08-03T13:11:14  *** arowser_ has quit IRC
213 2020-08-03T13:11:33  *** arowser_ has joined #bitcoin-core-dev
214 2020-08-03T13:13:16  *** arowser_ has quit IRC
215 2020-08-03T13:13:41  *** arowser_ has joined #bitcoin-core-dev
216 2020-08-03T13:23:28  *** promag has joined #bitcoin-core-dev
217 2020-08-03T13:24:04  *** LuisAranguren has quit IRC
218 2020-08-03T13:26:24  *** bitcoin-git has joined #bitcoin-core-dev
219 2020-08-03T13:26:24  <bitcoin-git> [bitcoin] hebasto opened pull request #19652: Add thread safety annotations to Mempool{Info}ToJSON() (master...200803-mmx-2) https://github.com/bitcoin/bitcoin/pull/19652
220 2020-08-03T13:26:25  *** bitcoin-git has left #bitcoin-core-dev
221 2020-08-03T13:45:45  *** mdunnio has joined #bitcoin-core-dev
222 2020-08-03T13:45:53  *** proofofkeags has quit IRC
223 2020-08-03T13:51:18  *** Davterra has quit IRC
224 2020-08-03T13:52:16  *** arowser_ has quit IRC
225 2020-08-03T13:52:36  *** arowser_ has joined #bitcoin-core-dev
226 2020-08-03T13:53:09  *** Davterra has joined #bitcoin-core-dev
227 2020-08-03T13:53:45  <hebasto> jeremyrubin: did you see recent #18710 update and its benchmarks by martinus?
228 2020-08-03T13:53:48  <gribble> https://github.com/bitcoin/bitcoin/issues/18710 | Add local thread pool to CCheckQueue by hebasto · Pull Request #18710 · bitcoin/bitcoin · GitHub
229 2020-08-03T13:54:15  *** arowser_ has quit IRC
230 2020-08-03T13:54:43  *** arowser_ has joined #bitcoin-core-dev
231 2020-08-03T14:11:53  *** mdunnio has quit IRC
232 2020-08-03T14:12:07  *** mdunnio has joined #bitcoin-core-dev
233 2020-08-03T14:13:15  <aj> hebasto: why do you think adding GUARDED_BY is a design change? it's just those members existed before bitcoin source had thread safety annotations, as far as i know?
234 2020-08-03T14:13:44  *** Tralfaz has joined #bitcoin-core-dev
235 2020-08-03T14:14:10  <hebasto> aj: it changes class invariants
236 2020-08-03T14:14:24  <aj> hebasto: no it doesn't? (or: i don't see how?)
237 2020-08-03T14:14:48  *** Pavlenex has joined #bitcoin-core-dev
238 2020-08-03T14:14:49  <aj> hebasto: (i'd say that it *documents* class invariants, just like the rest of your pr)
239 2020-08-03T14:15:21  *** Davterra has quit IRC
240 2020-08-03T14:16:09  <hebasto> aj: ok, if new GUARDED_BY will not cause to introduce new need to acquire a lock somewhere
241 2020-08-03T14:16:28  <aj> hebasto: seemed to work fine for me, fwiw
242 2020-08-03T14:17:08  <aj> hebasto: (if it did demand a lock was acquired somewhere, i'd expect that to be a bug worth fixing anyway)
243 2020-08-03T14:17:09  *** proofofkeags has joined #bitcoin-core-dev
244 2020-08-03T14:18:16  <hebasto> btw, `AssertLock{Not}Held` were my tools to transit `CTxMemPool::cs` to `RecursiveMutex` in #19306
245 2020-08-03T14:18:18  <gribble> https://github.com/bitcoin/bitcoin/issues/19306 | refactor: Replace RecursiveMutex with Mutex in CTxMemPool by hebasto · Pull Request #19306 · bitcoin/bitcoin · GitHub
246 2020-08-03T14:18:33  <aj> hebasto: yep
247 2020-08-03T14:18:47  <hebasto> oops s/RecursiveMutex/Mutex/
248 2020-08-03T14:19:01  <aj> s/to/from/ would've been shorter
249 2020-08-03T14:19:11  * hebasto :)
250 2020-08-03T14:21:50  *** proofofkeags has quit IRC
251 2020-08-03T14:21:54  <hebasto> aj: sudden run-time error that were not caught by compile-time thread safety analysis could be (almost) eliminated with full annotation coverage
252 2020-08-03T14:24:23  *** Tralfaz has quit IRC
253 2020-08-03T14:25:21  <aj> hebasto: it crossed my mind that maybe DEBUG_LOCKORDER should check for accidental recursive locking attempts with Mutex (or even RecursiveMutex if it just logged a warning on first occurence or so?)
254 2020-08-03T14:26:47  <aj> hebasto: hmm, "EX_LOCKS_REQ(!cs)" complaints are only warnings, not errors?
255 2020-08-03T14:27:59  <hebasto> we could always pass -Werror, no?
256 2020-08-03T14:28:20  <aj> hebasto: i thought we were?
257 2020-08-03T14:29:05  <aj> no, apparently not? did i do configure wrong?
258 2020-08-03T14:29:13  *** arowser_ has quit IRC
259 2020-08-03T14:29:15  *** Davterra has joined #bitcoin-core-dev
260 2020-08-03T14:29:36  *** Pavlenex has quit IRC
261 2020-08-03T14:29:38  *** arowser_ has joined #bitcoin-core-dev
262 2020-08-03T14:30:18  <aj> ah, missed --enable-werror i guess?
263 2020-08-03T14:30:30  <hebasto> by default `--enable-werror=no`
264 2020-08-03T14:31:16  <aj> yeah, there's already '-Werror=thread-safety' by default
265 2020-08-03T14:32:15  <aj> or not?
266 2020-08-03T14:33:13  <hebasto> you should add `--enable-werror`
267 2020-08-03T14:33:15  *** rafalcpp has joined #bitcoin-core-dev
268 2020-08-03T14:34:14  <aj> yeah, have done so. weird i haven't felt forced to before
269 2020-08-03T14:37:49  *** Luke has joined #bitcoin-core-dev
270 2020-08-03T14:39:25  <aj> hebasto: hmm, apart from a missing EXCLUSIVE_LOCKS_REQUIRED(!cs_wallet) in BlockUntilSyncedToCurrentChain(), it seems possible to annotate AssertLockNotHeldInternal with EXCLUSIVE_LOCKS_REQUIRED(!*cs) (have to templatize it to avoid "dereferencing" a void* too of course)
271 2020-08-03T14:40:14  *** bitdex has quit IRC
272 2020-08-03T14:41:11  <hebasto> aj: did you see #19337 ?
273 2020-08-03T14:41:12  *** arowser_ has quit IRC
274 2020-08-03T14:41:14  <gribble> https://github.com/bitcoin/bitcoin/issues/19337 | sync: detect double lock from the same thread by vasild · Pull Request #19337 · bitcoin/bitcoin · GitHub
275 2020-08-03T14:41:40  *** arowser_ has joined #bitcoin-core-dev
276 2020-08-03T14:47:25  <aj> hebasto: yay!
277 2020-08-03T14:49:52  *** Davterra has quit IRC
278 2020-08-03T14:51:18  *** proofofkeags has joined #bitcoin-core-dev
279 2020-08-03T15:00:02  *** langseth1 has quit IRC
280 2020-08-03T15:00:13  *** rafalcpp has quit IRC
281 2020-08-03T15:17:41  *** Deinogalerix21 has joined #bitcoin-core-dev
282 2020-08-03T15:19:47  *** Guyver2 has quit IRC
283 2020-08-03T15:19:59  *** Guyver2 has joined #bitcoin-core-dev
284 2020-08-03T15:20:48  *** Pavlenex has joined #bitcoin-core-dev
285 2020-08-03T15:22:17  *** directhex1 has joined #bitcoin-core-dev
286 2020-08-03T15:28:24  *** bitcoin-git has joined #bitcoin-core-dev
287 2020-08-03T15:28:25  <bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/14ceddd29085...34eb2362581d
288 2020-08-03T15:28:26  <bitcoin-git> bitcoin/master 131a2f0 Pieter Wuille: scripted-diff: rename base_blob::data to m_data
289 2020-08-03T15:28:27  <bitcoin-git> bitcoin/master 5678250 Pieter Wuille: Make uint256 Span-convertible by adding ::data()
290 2020-08-03T15:28:27  <bitcoin-git> bitcoin/master e63dcc3 Pieter Wuille: Add MakeUCharSpan, to help constructing Span<[const] unsigned char>
291 2020-08-03T15:28:29  *** bitcoin-git has left #bitcoin-core-dev
292 2020-08-03T15:28:49  *** bitcoin-git has joined #bitcoin-core-dev
293 2020-08-03T15:28:49  <bitcoin-git> [bitcoin] laanwj merged pull request #19326: Simplify hash.h interface using Spans (master...202006_spanhashes) https://github.com/bitcoin/bitcoin/pull/19326
294 2020-08-03T15:28:54  *** rafalcpp has joined #bitcoin-core-dev
295 2020-08-03T15:28:58  *** bitcoin-git has left #bitcoin-core-dev
296 2020-08-03T15:39:15  <hebasto> aj: to feel safe a "clone" of `AssertLockHeld()` needed but without `ASSERT_EXCLUSIVE_LOCK()`
297 2020-08-03T15:39:28  <hebasto> how it could be named?
298 2020-08-03T15:39:55  <aj> hebasto: RequireLockHeld or ExpectLockHeld maybe? *shrug*
299 2020-08-03T15:41:05  <hebasto> `RequireLockHeld` looks good!
300 2020-08-03T15:47:05  *** Pavlenex has quit IRC
301 2020-08-03T15:57:13  *** Highway61 has quit IRC
302 2020-08-03T15:59:15  *** promag_ has joined #bitcoin-core-dev
303 2020-08-03T16:03:12  *** Highway61 has joined #bitcoin-core-dev
304 2020-08-03T16:04:32  *** promag_ has quit IRC
305 2020-08-03T16:08:12  *** arowser_ has quit IRC
306 2020-08-03T16:08:40  *** arowser_ has joined #bitcoin-core-dev
307 2020-08-03T16:19:25  *** jonatack has joined #bitcoin-core-dev
308 2020-08-03T16:21:08  *** Luke has quit IRC
309 2020-08-03T16:22:20  <warren> jonasschnelli: hey. Curious whatever happened to BIP150 and 151. Did that end up getting rolled into a replacement BIP?
310 2020-08-03T16:23:40  <sipa> warren: BIP324 will replace BIP151
311 2020-08-03T16:24:03  <warren> thanks
312 2020-08-03T16:25:40  <warren> is any authentication scheme currently favored in conjunction with this?
313 2020-08-03T16:26:07  <sipa> we have some theoretic work, a successor to countersign, but nothing published
314 2020-08-03T16:26:47  *** jarthur has joined #bitcoin-core-dev
315 2020-08-03T16:28:33  *** jarthur_ has quit IRC
316 2020-08-03T16:30:17  *** Davterra has joined #bitcoin-core-dev
317 2020-08-03T16:46:39  *** proofofkeags has quit IRC
318 2020-08-03T16:49:05  *** alko89 has quit IRC
319 2020-08-03T16:52:22  *** Pavlenex has joined #bitcoin-core-dev
320 2020-08-03T17:01:12  *** arowser_ has quit IRC
321 2020-08-03T17:01:34  *** arowser_ has joined #bitcoin-core-dev
322 2020-08-03T17:06:21  *** justanotheruser has joined #bitcoin-core-dev
323 2020-08-03T17:11:35  *** Davterra has quit IRC
324 2020-08-03T17:22:35  *** pinheadmz has quit IRC
325 2020-08-03T17:23:34  *** Highway61 has quit IRC
326 2020-08-03T17:24:06  <jeremyrubin> Does the linter need to be kicked?
327 2020-08-03T17:24:08  <jeremyrubin> https://travis-ci.org/github/bitcoin/bitcoin/jobs/714556846
328 2020-08-03T17:25:35  <fjahr> jeremyrubin: seems so, I saw this yesterday: https://github.com/bitcoin/bitcoin/pull/19439#issuecomment-667732466
329 2020-08-03T17:25:52  <fjahr> But it doesn't fail locally for me
330 2020-08-03T17:27:05  *** hanhua has joined #bitcoin-core-dev
331 2020-08-03T17:27:30  <fjahr> seems to be an error specific to the CI environment, but maybe someone else can reproduce it?
332 2020-08-03T17:32:19  <jeremyrubin> that seemed to be the issue thanks
333 2020-08-03T17:32:54  *** proofofkeags has joined #bitcoin-core-dev
334 2020-08-03T17:38:09  *** arowser_ has quit IRC
335 2020-08-03T17:38:37  *** arowser_ has joined #bitcoin-core-dev
336 2020-08-03T17:45:33  *** Guyver2_ has joined #bitcoin-core-dev
337 2020-08-03T17:48:13  *** Guyver2 has quit IRC
338 2020-08-03T18:00:02  *** directhex1 has quit IRC
339 2020-08-03T18:04:05  *** shesek has quit IRC
340 2020-08-03T18:13:38  *** alko89 has joined #bitcoin-core-dev
341 2020-08-03T18:16:28  *** pinheadmz has joined #bitcoin-core-dev
342 2020-08-03T18:17:38  *** Talkless has quit IRC
343 2020-08-03T18:21:58  *** stranger64 has joined #bitcoin-core-dev
344 2020-08-03T18:25:02  *** Deacyde has joined #bitcoin-core-dev
345 2020-08-03T18:34:18  *** owowo has joined #bitcoin-core-dev
346 2020-08-03T18:40:44  *** Davterra has joined #bitcoin-core-dev
347 2020-08-03T18:41:10  *** mdrollette has quit IRC
348 2020-08-03T18:44:44  *** mdrollette has joined #bitcoin-core-dev
349 2020-08-03T18:59:09  *** Pavlenex has quit IRC
350 2020-08-03T19:12:47  *** troygiorshev has quit IRC
351 2020-08-03T19:13:35  *** troygiorshev has joined #bitcoin-core-dev
352 2020-08-03T19:16:06  *** alko89 has quit IRC
353 2020-08-03T19:18:07  *** hanhua has quit IRC
354 2020-08-03T19:18:47  *** alko89 has joined #bitcoin-core-dev
355 2020-08-03T19:22:35  *** Davterra has quit IRC
356 2020-08-03T19:23:56  *** Pavlenex has joined #bitcoin-core-dev
357 2020-08-03T19:24:14  *** Davterra has joined #bitcoin-core-dev
358 2020-08-03T19:32:05  *** mutatrum has joined #bitcoin-core-dev
359 2020-08-03T19:33:32  *** Pavlenex has quit IRC
360 2020-08-03T19:38:26  *** ovovo has joined #bitcoin-core-dev
361 2020-08-03T19:40:39  *** Pavlenex has joined #bitcoin-core-dev
362 2020-08-03T19:42:22  *** owowo has quit IRC
363 2020-08-03T19:43:40  *** pinheadmz has quit IRC
364 2020-08-03T19:47:31  *** pinheadmz has joined #bitcoin-core-dev
365 2020-08-03T19:48:59  *** pinheadmz has quit IRC
366 2020-08-03T20:03:03  *** jb55 has quit IRC
367 2020-08-03T20:15:55  *** jb55 has joined #bitcoin-core-dev
368 2020-08-03T20:19:40  *** bitcoin-git has joined #bitcoin-core-dev
369 2020-08-03T20:19:40  <bitcoin-git> [bitcoin] achow101 opened pull request #19653: wallet: Replace -zapwallettxes with zapwallettxes RPC (master...zapwallettxes-rpc) https://github.com/bitcoin/bitcoin/pull/19653
370 2020-08-03T20:19:41  *** bitcoin-git has left #bitcoin-core-dev
371 2020-08-03T20:26:54  *** pinheadmz has joined #bitcoin-core-dev
372 2020-08-03T20:34:10  <luke-jr> achow101: please introduce and remove in separate PRs..
373 2020-08-03T20:35:19  <achow101> luke-jr: it's moving one functionality to another place
374 2020-08-03T20:35:24  <achow101> we did the same thing for upgradewallet
375 2020-08-03T20:36:29  <luke-jr> pretty sure I said the same for that too
376 2020-08-03T20:50:05  *** mutatrum has quit IRC
377 2020-08-03T20:52:58  *** isis is now known as isis_
378 2020-08-03T20:57:33  *** Guyver2_ has quit IRC
379 2020-08-03T21:00:02  *** stranger64 has quit IRC
380 2020-08-03T21:05:06  *** cfields has joined #bitcoin-core-dev
381 2020-08-03T21:06:12  *** filchef has joined #bitcoin-core-dev
382 2020-08-03T21:07:04  *** filchef has quit IRC
383 2020-08-03T21:15:00  *** Joy has joined #bitcoin-core-dev
384 2020-08-03T21:20:39  *** erwin_bullet has joined #bitcoin-core-dev
385 2020-08-03T21:55:34  *** dviola has quit IRC
386 2020-08-03T21:56:45  *** Joy has quit IRC
387 2020-08-03T22:02:03  *** bitdex has joined #bitcoin-core-dev
388 2020-08-03T22:03:59  *** proofofkeags has quit IRC
389 2020-08-03T22:11:57  *** proofofkeags has joined #bitcoin-core-dev
390 2020-08-03T22:25:05  *** Pavlenex has joined #bitcoin-core-dev
391 2020-08-03T22:27:21  *** Pavlenex has quit IRC
392 2020-08-03T22:31:24  *** proofofkeags has quit IRC
393 2020-08-03T22:50:52  *** proofofkeags has joined #bitcoin-core-dev
394 2020-08-03T22:55:38  *** vasild_ has joined #bitcoin-core-dev
395 2020-08-03T22:55:57  *** proofofkeags has quit IRC
396 2020-08-03T22:55:58  *** marcoagner has quit IRC
397 2020-08-03T22:58:43  *** vasild has quit IRC
398 2020-08-03T22:58:45  *** vasild_ is now known as vasild
399 2020-08-03T23:11:58  *** Chris_Stewart_5 has quit IRC
400 2020-08-03T23:27:52  *** proofofkeags has joined #bitcoin-core-dev
401 2020-08-03T23:28:18  *** Chris_Stewart_5 has joined #bitcoin-core-dev
402 2020-08-03T23:31:09  *** kristapsk has joined #bitcoin-core-dev
403 2020-08-03T23:33:17  *** proofofkeags has quit IRC
404 2020-08-03T23:42:53  *** mdunnio has quit IRC
405 2020-08-03T23:43:36  *** mdrollette has quit IRC
406 2020-08-03T23:43:55  *** mdrollette has joined #bitcoin-core-dev
407 2020-08-03T23:51:04  *** dviola has joined #bitcoin-core-dev