1 2020-08-05T00:00:02  *** Guest49850 has quit IRC
  2 2020-08-05T00:00:05  *** Davterra has quit IRC
  3 2020-08-05T00:01:20  *** mdunnio has quit IRC
  4 2020-08-05T00:21:06  *** devdsp has joined #bitcoin-core-dev
  5 2020-08-05T00:30:42  *** Tralfaz is now known as Davterra
  6 2020-08-05T00:35:08  *** arowser_ has quit IRC
  7 2020-08-05T00:35:41  *** arowser_ has joined #bitcoin-core-dev
  8 2020-08-05T00:36:21  *** mdunnio has joined #bitcoin-core-dev
  9 2020-08-05T00:40:35  *** mdunnio has quit IRC
 10 2020-08-05T00:57:47  *** luke-jr has quit IRC
 11 2020-08-05T00:59:11  *** luke-jr has joined #bitcoin-core-dev
 12 2020-08-05T01:02:00  *** adiabat has joined #bitcoin-core-dev
 13 2020-08-05T01:05:52  *** proofofkeags has quit IRC
 14 2020-08-05T01:06:28  *** proofofkeags has joined #bitcoin-core-dev
 15 2020-08-05T01:10:47  *** proofofkeags has quit IRC
 16 2020-08-05T01:11:56  *** bitdex has joined #bitcoin-core-dev
 17 2020-08-05T01:43:27  *** proofofkeags has joined #bitcoin-core-dev
 18 2020-08-05T01:47:58  *** mdunnio has joined #bitcoin-core-dev
 19 2020-08-05T01:49:25  *** proofofkeags has quit IRC
 20 2020-08-05T01:51:17  *** shesek has quit IRC
 21 2020-08-05T01:52:19  *** gzhao408 has joined #bitcoin-core-dev
 22 2020-08-05T01:52:44  *** mdunnio has quit IRC
 23 2020-08-05T02:05:06  *** ensign has quit IRC
 24 2020-08-05T02:07:53  *** gzhao408 has quit IRC
 25 2020-08-05T02:11:11  *** ensign has joined #bitcoin-core-dev
 26 2020-08-05T02:13:59  *** AaronvanW has joined #bitcoin-core-dev
 27 2020-08-05T02:17:22  *** promag has quit IRC
 28 2020-08-05T02:18:58  *** cubancorona has quit IRC
 29 2020-08-05T02:21:05  *** roconnor has quit IRC
 30 2020-08-05T02:22:58  *** adiabat has quit IRC
 31 2020-08-05T02:24:03  *** proofofkeags has joined #bitcoin-core-dev
 32 2020-08-05T02:28:18  *** roconnor has joined #bitcoin-core-dev
 33 2020-08-05T02:32:59  *** proofofkeags has quit IRC
 34 2020-08-05T02:44:13  *** AaronvanW has quit IRC
 35 2020-08-05T02:48:03  *** jules2383 has joined #bitcoin-core-dev
 36 2020-08-05T02:51:39  *** jules2383 has quit IRC
 37 2020-08-05T02:57:11  *** arowser_ has quit IRC
 38 2020-08-05T02:57:36  *** arowser_ has joined #bitcoin-core-dev
 39 2020-08-05T03:00:02  *** devdsp has quit IRC
 40 2020-08-05T03:02:11  *** arowser_ has quit IRC
 41 2020-08-05T03:02:39  *** arowser_ has joined #bitcoin-core-dev
 42 2020-08-05T03:11:31  *** justanotheruser has quit IRC
 43 2020-08-05T03:16:12  *** bitcoin-git has joined #bitcoin-core-dev
 44 2020-08-05T03:16:12  <bitcoin-git> [bitcoin] TheRook opened pull request #19665: Floating-Point Nakamoto Consensus  (master...master) https://github.com/bitcoin/bitcoin/pull/19665
 45 2020-08-05T03:16:13  *** bitcoin-git has left #bitcoin-core-dev
 46 2020-08-05T03:19:48  *** proofofkeags has joined #bitcoin-core-dev
 47 2020-08-05T03:21:21  *** auscompgeek1 has joined #bitcoin-core-dev
 48 2020-08-05T03:24:00  *** adaminsky has joined #bitcoin-core-dev
 49 2020-08-05T03:24:29  *** Highway61 has quit IRC
 50 2020-08-05T03:29:08  *** proofofkeags has quit IRC
 51 2020-08-05T03:29:45  *** proofofkeags has joined #bitcoin-core-dev
 52 2020-08-05T03:31:25  *** arowser_ has quit IRC
 53 2020-08-05T03:32:47  *** arowser_ has joined #bitcoin-core-dev
 54 2020-08-05T03:33:45  *** proofofkeags has quit IRC
 55 2020-08-05T03:33:50  *** adaminsky has quit IRC
 56 2020-08-05T03:36:10  *** arowser_ has quit IRC
 57 2020-08-05T03:36:56  *** arowser_ has joined #bitcoin-core-dev
 58 2020-08-05T04:16:39  *** justanotheruser has joined #bitcoin-core-dev
 59 2020-08-05T04:32:16  *** watersnake1 has quit IRC
 60 2020-08-05T04:41:49  *** bitcoin-git has joined #bitcoin-core-dev
 61 2020-08-05T04:41:49  <bitcoin-git> [bitcoin] fanquake closed pull request #19665: Floating-Point Nakamoto Consensus  (master...master) https://github.com/bitcoin/bitcoin/pull/19665
 62 2020-08-05T04:41:59  *** bitcoin-git has left #bitcoin-core-dev
 63 2020-08-05T04:57:13  *** sipsorcery has quit IRC
 64 2020-08-05T05:09:02  *** shesek has joined #bitcoin-core-dev
 65 2020-08-05T05:09:02  *** shesek has joined #bitcoin-core-dev
 66 2020-08-05T05:23:04  *** bitcoin-git has joined #bitcoin-core-dev
 67 2020-08-05T05:23:04  <bitcoin-git> [bitcoin] fanquake opened pull request #19667: build: set minimum required Boost to 1.58.0 (master...boost_1_58_0) https://github.com/bitcoin/bitcoin/pull/19667
 68 2020-08-05T05:23:05  *** bitcoin-git has left #bitcoin-core-dev
 69 2020-08-05T06:00:02  *** auscompgeek1 has quit IRC
 70 2020-08-05T06:11:55  *** Asbestos_Vapor has joined #bitcoin-core-dev
 71 2020-08-05T06:12:12  *** mdunnio has joined #bitcoin-core-dev
 72 2020-08-05T06:15:07  *** Mercury_Vapor has quit IRC
 73 2020-08-05T06:16:12  *** sipsorcery has joined #bitcoin-core-dev
 74 2020-08-05T06:17:10  *** mdunnio has quit IRC
 75 2020-08-05T06:22:13  *** nand has joined #bitcoin-core-dev
 76 2020-08-05T06:30:06  *** kristapsk has quit IRC
 77 2020-08-05T06:30:30  *** kristapsk has joined #bitcoin-core-dev
 78 2020-08-05T06:32:31  *** _0x0ff has quit IRC
 79 2020-08-05T06:34:56  *** _0x0ff has joined #bitcoin-core-dev
 80 2020-08-05T06:39:03  *** bitdex has quit IRC
 81 2020-08-05T06:40:04  *** bitdex has joined #bitcoin-core-dev
 82 2020-08-05T06:40:11  *** arowser_ has quit IRC
 83 2020-08-05T06:41:00  *** arowser_ has joined #bitcoin-core-dev
 84 2020-08-05T06:46:39  *** mdunnio has joined #bitcoin-core-dev
 85 2020-08-05T06:48:03  *** kristapsk has quit IRC
 86 2020-08-05T06:48:03  *** afk11 has quit IRC
 87 2020-08-05T06:48:24  *** kristapsk has joined #bitcoin-core-dev
 88 2020-08-05T06:49:13  *** afk11 has joined #bitcoin-core-dev
 89 2020-08-05T06:51:23  *** mdunnio has quit IRC
 90 2020-08-05T06:59:18  *** arowser_ has quit IRC
 91 2020-08-05T07:00:22  *** arowser_ has joined #bitcoin-core-dev
 92 2020-08-05T07:03:47  *** jeremyrubin has quit IRC
 93 2020-08-05T07:06:37  *** marcoagner has joined #bitcoin-core-dev
 94 2020-08-05T07:15:14  *** bitcoin-git has joined #bitcoin-core-dev
 95 2020-08-05T07:15:15  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #19661: suggest a convention for python string quoting (master...doc-python-quoting) https://github.com/bitcoin/bitcoin/pull/19661
 96 2020-08-05T07:15:15  *** bitcoin-git has left #bitcoin-core-dev
 97 2020-08-05T07:24:05  *** sipsorcery has quit IRC
 98 2020-08-05T07:25:17  *** mdunnio has joined #bitcoin-core-dev
 99 2020-08-05T07:29:58  *** mdunnio has quit IRC
100 2020-08-05T07:48:44  *** mutatrum has joined #bitcoin-core-dev
101 2020-08-05T07:49:23  *** morcos has quit IRC
102 2020-08-05T07:50:30  *** morcos has joined #bitcoin-core-dev
103 2020-08-05T07:52:19  *** Pavlenex has joined #bitcoin-core-dev
104 2020-08-05T07:53:54  *** dr-orlovsky has joined #bitcoin-core-dev
105 2020-08-05T08:01:45  *** arowser_ has quit IRC
106 2020-08-05T08:05:36  *** arowser_ has joined #bitcoin-core-dev
107 2020-08-05T08:11:40  *** Tralfaz has joined #bitcoin-core-dev
108 2020-08-05T08:13:52  *** Davterra has quit IRC
109 2020-08-05T08:18:22  *** AaronvanW has joined #bitcoin-core-dev
110 2020-08-05T08:20:46  *** andreacab has joined #bitcoin-core-dev
111 2020-08-05T08:24:34  *** dr-orlovsky has quit IRC
112 2020-08-05T08:25:36  *** Bullitje has quit IRC
113 2020-08-05T08:26:15  *** Bullitje has joined #bitcoin-core-dev
114 2020-08-05T08:32:17  *** andreacab has quit IRC
115 2020-08-05T08:32:35  *** kristapsk has quit IRC
116 2020-08-05T08:32:55  *** kristapsk has joined #bitcoin-core-dev
117 2020-08-05T08:33:38  *** andreacab has joined #bitcoin-core-dev
118 2020-08-05T08:34:28  *** AaronvanW has quit IRC
119 2020-08-05T08:34:53  *** AaronvanW has joined #bitcoin-core-dev
120 2020-08-05T08:42:29  *** nand has quit IRC
121 2020-08-05T08:45:23  *** mutatrum has quit IRC
122 2020-08-05T08:47:12  *** arowser_ has quit IRC
123 2020-08-05T08:47:13  *** bitcoin-git has joined #bitcoin-core-dev
124 2020-08-05T08:47:14  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0f16212c5931...65e4ecabd5b4
125 2020-08-05T08:47:14  <bitcoin-git> bitcoin/master 7235178 Fabian Jahr: lint: Remove travis env var from commit linter
126 2020-08-05T08:47:14  <bitcoin-git> bitcoin/master 65e4eca MarcoFalke: Merge #19654: lint: Don't use TRAVIS_COMMIT_RANGE in commit message linter...
127 2020-08-05T08:47:15  *** bitcoin-git has left #bitcoin-core-dev
128 2020-08-05T08:47:33  *** bitcoin-git has joined #bitcoin-core-dev
129 2020-08-05T08:47:34  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19654: lint: Don't use TRAVIS_COMMIT_RANGE in commit message linter (master...commit-lint) https://github.com/bitcoin/bitcoin/pull/19654
130 2020-08-05T08:47:35  *** bitcoin-git has left #bitcoin-core-dev
131 2020-08-05T08:53:42  *** andreacab has quit IRC
132 2020-08-05T09:03:31  *** sipsorcery has joined #bitcoin-core-dev
133 2020-08-05T09:04:41  *** promag has joined #bitcoin-core-dev
134 2020-08-05T09:05:28  *** Pavlenex has quit IRC
135 2020-08-05T09:10:01  *** arowser_ has joined #bitcoin-core-dev
136 2020-08-05T09:15:48  <darosior> MarcoFalke: what is the minimum supported Python version ?
137 2020-08-05T09:15:56  <darosior> Wondering if i should drop the fstring
138 2020-08-05T09:16:21  <fanquake> darosior: it's 3.5
139 2020-08-05T09:16:27  <fanquake> you'll have to drop the fstring
140 2020-08-05T09:16:29  <darosior> Arf, thanks!
141 2020-08-05T09:17:05  <fanquake> 3.6 soon: #19504
142 2020-08-05T09:17:07  <gribble> https://github.com/bitcoin/bitcoin/issues/19504 | Bump minimum python version to 3.6 by ajtowns · Pull Request #19504 · bitcoin/bitcoin · GitHub
143 2020-08-05T09:22:06  *** shoman94 has joined #bitcoin-core-dev
144 2020-08-05T09:34:45  *** sipsorcery has quit IRC
145 2020-08-05T09:39:38  *** justanotheruser has quit IRC
146 2020-08-05T09:46:29  *** tryphe_ has quit IRC
147 2020-08-05T09:47:17  *** tryphe_ has joined #bitcoin-core-dev
148 2020-08-05T09:47:57  *** AaronvanW has quit IRC
149 2020-08-05T09:57:47  *** shoman94 has quit IRC
150 2020-08-05T10:03:24  *** Aaliyah51Hammes has joined #bitcoin-core-dev
151 2020-08-05T10:04:49  *** sipsorcery has joined #bitcoin-core-dev
152 2020-08-05T10:08:15  *** arowser_ has quit IRC
153 2020-08-05T10:08:53  *** arowser_ has joined #bitcoin-core-dev
154 2020-08-05T10:15:30  *** per has joined #bitcoin-core-dev
155 2020-08-05T10:15:53  *** per is now known as Guest25949
156 2020-08-05T10:16:35  *** sipsorcery has quit IRC
157 2020-08-05T10:17:09  *** sipsorcery has joined #bitcoin-core-dev
158 2020-08-05T10:17:25  *** Highway61 has joined #bitcoin-core-dev
159 2020-08-05T10:19:25  *** Aaliyah51Hammes has quit IRC
160 2020-08-05T10:27:42  *** sendak has joined #bitcoin-core-dev
161 2020-08-05T10:44:14  *** jonatack has quit IRC
162 2020-08-05T10:46:09  *** adiabat has joined #bitcoin-core-dev
163 2020-08-05T10:50:15  *** sdaftuar has quit IRC
164 2020-08-05T10:50:21  *** K4TJANG has joined #bitcoin-core-dev
165 2020-08-05T10:50:39  *** sdaftuar has joined #bitcoin-core-dev
166 2020-08-05T10:55:28  *** AaronvanW has joined #bitcoin-core-dev
167 2020-08-05T10:55:37  *** vasild_ has joined #bitcoin-core-dev
168 2020-08-05T10:55:47  *** AaronvanW has quit IRC
169 2020-08-05T10:56:15  <wumpus> python went through a few different kinds of 'recommended' formatting in quick succession, i hope they settle with fstrings now
170 2020-08-05T10:56:20  *** sipsorcery has quit IRC
171 2020-08-05T10:56:40  <wumpus> not that much fun to keep learning new ways to do the same :-)
172 2020-08-05T10:56:54  *** sipsorcery has joined #bitcoin-core-dev
173 2020-08-05T10:59:03  *** vasild has quit IRC
174 2020-08-05T10:59:04  *** vasild_ is now known as vasild
175 2020-08-05T11:07:44  *** Pavlenex has joined #bitcoin-core-dev
176 2020-08-05T11:35:20  *** andreacab has joined #bitcoin-core-dev
177 2020-08-05T11:36:10  *** arowser_ has quit IRC
178 2020-08-05T11:39:03  *** arowser_ has joined #bitcoin-core-dev
179 2020-08-05T11:44:14  *** andreacab has quit IRC
180 2020-08-05T11:44:19  *** bitcoin-git has joined #bitcoin-core-dev
181 2020-08-05T11:44:20  <bitcoin-git> [bitcoin] meshcollider pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/65e4ecabd5b4...e4df534c60e1
182 2020-08-05T11:44:20  <bitcoin-git> bitcoin/master 8314c23 Sjors Provoost: [depends] boost: patch unused variable in boost_process
183 2020-08-05T11:44:21  <bitcoin-git> bitcoin/master 929cda5 Sjors Provoost: configure: add ax_boost_process
184 2020-08-05T11:44:22  <bitcoin-git> bitcoin/master c47e4bb Sjors Provoost: [build] make boost-process opt-in
185 2020-08-05T11:44:24  *** bitcoin-git has left #bitcoin-core-dev
186 2020-08-05T11:44:41  *** andreacab has joined #bitcoin-core-dev
187 2020-08-05T11:45:21  *** andreaca_ has joined #bitcoin-core-dev
188 2020-08-05T11:46:08  *** bitcoin-git has joined #bitcoin-core-dev
189 2020-08-05T11:46:09  <bitcoin-git> [bitcoin] meshcollider merged pull request #15382: util: add RunCommandParseJSON (master...2019/02/runCommandParseJSON) https://github.com/bitcoin/bitcoin/pull/15382
190 2020-08-05T11:46:09  <wumpus> achow101: re #19653, I sometimes wonder why this functionality is not part of the bitcoin-wallet tool instead
191 2020-08-05T11:46:10  *** bitcoin-git has left #bitcoin-core-dev
192 2020-08-05T11:46:11  <gribble> https://github.com/bitcoin/bitcoin/issues/19653 | wallet: Replace -zapwallettxes with zapwallettxes RPC by achow101 · Pull Request #19653 · bitcoin/bitcoin · GitHub
193 2020-08-05T11:46:28  <wumpus> achow101: (in any case, clearly, having it as RPC is better than a command line argument)
194 2020-08-05T11:47:00  <wumpus> but it's really a maintenance/recovery command
195 2020-08-05T11:49:10  *** andreacab has quit IRC
196 2020-08-05T11:55:58  *** troygiorshev has quit IRC
197 2020-08-05T11:59:12  *** arowser_ has quit IRC
198 2020-08-05T11:59:58  *** arowser_ has joined #bitcoin-core-dev
199 2020-08-05T12:00:02  *** sendak has quit IRC
200 2020-08-05T12:18:51  *** Guyver2 has joined #bitcoin-core-dev
201 2020-08-05T12:19:15  *** cato_ has quit IRC
202 2020-08-05T12:19:26  *** cato_ has joined #bitcoin-core-dev
203 2020-08-05T12:19:57  *** jonatack has joined #bitcoin-core-dev
204 2020-08-05T12:22:06  *** byte[]1 has joined #bitcoin-core-dev
205 2020-08-05T12:30:45  *** belcher has joined #bitcoin-core-dev
206 2020-08-05T12:35:08  *** jonatack has quit IRC
207 2020-08-05T12:41:20  *** jonatack has joined #bitcoin-core-dev
208 2020-08-05T12:42:34  *** promag_ has joined #bitcoin-core-dev
209 2020-08-05T12:43:52  *** bitcoin-git has joined #bitcoin-core-dev
210 2020-08-05T12:43:53  <bitcoin-git> [bitcoin] hebasto opened pull request #19668: Do not hide compile-time thread safety warnings (master...200805-assert) https://github.com/bitcoin/bitcoin/pull/19668
211 2020-08-05T12:43:53  *** bitcoin-git has left #bitcoin-core-dev
212 2020-08-05T13:02:37  *** arowser_ has quit IRC
213 2020-08-05T13:03:36  *** arowser_ has joined #bitcoin-core-dev
214 2020-08-05T13:06:12  *** arowser_ has quit IRC
215 2020-08-05T13:06:41  *** arowser_ has joined #bitcoin-core-dev
216 2020-08-05T13:08:11  *** arowser_ has quit IRC
217 2020-08-05T13:08:35  *** arowser_ has joined #bitcoin-core-dev
218 2020-08-05T13:09:14  *** arowser_ has quit IRC
219 2020-08-05T13:09:43  *** arowser_ has joined #bitcoin-core-dev
220 2020-08-05T13:10:13  *** arowser_ has quit IRC
221 2020-08-05T13:10:53  *** arowser_ has joined #bitcoin-core-dev
222 2020-08-05T13:11:10  *** andreaca_ has quit IRC
223 2020-08-05T13:11:13  *** troygiorshev has joined #bitcoin-core-dev
224 2020-08-05T13:11:14  *** arowser_ has quit IRC
225 2020-08-05T13:11:33  *** arowser_ has joined #bitcoin-core-dev
226 2020-08-05T13:11:37  *** andreacab has joined #bitcoin-core-dev
227 2020-08-05T13:12:14  *** arowser_ has quit IRC
228 2020-08-05T13:12:46  *** arowser_ has joined #bitcoin-core-dev
229 2020-08-05T13:13:14  *** arowser_ has quit IRC
230 2020-08-05T13:13:47  *** arowser_ has joined #bitcoin-core-dev
231 2020-08-05T13:14:13  *** arowser_ has quit IRC
232 2020-08-05T13:14:33  *** arowser_ has joined #bitcoin-core-dev
233 2020-08-05T13:15:15  *** arowser_ has quit IRC
234 2020-08-05T13:15:43  *** arowser_ has joined #bitcoin-core-dev
235 2020-08-05T13:15:58  *** andreacab has quit IRC
236 2020-08-05T13:22:32  *** promag_ has quit IRC
237 2020-08-05T13:23:11  *** bitdex has quit IRC
238 2020-08-05T13:26:49  *** arowser_ has quit IRC
239 2020-08-05T13:27:35  *** arowser_ has joined #bitcoin-core-dev
240 2020-08-05T13:33:34  *** promag_ has joined #bitcoin-core-dev
241 2020-08-05T13:39:52  *** troygiorshev has quit IRC
242 2020-08-05T13:40:41  *** troygiorshev has joined #bitcoin-core-dev
243 2020-08-05T14:00:36  *** mdunnio has joined #bitcoin-core-dev
244 2020-08-05T14:02:23  *** mdunnio has quit IRC
245 2020-08-05T14:02:39  *** mdunnio has joined #bitcoin-core-dev
246 2020-08-05T14:15:48  *** TallTim has quit IRC
247 2020-08-05T14:15:58  <MarcoFalke> Hi, I won't be around tomorrow, but I'd like to add #19629 to high prio. Can I add it today or should I store it in a meeting topic?
248 2020-08-05T14:16:00  <gribble> https://github.com/bitcoin/bitcoin/issues/19629 | Pass mempool pointer to chainstate constructor by MarcoFalke · Pull Request #19629 · bitcoin/bitcoin · GitHub
249 2020-08-05T14:22:52  *** TallTim has joined #bitcoin-core-dev
250 2020-08-05T14:25:07  *** Tralfaz has quit IRC
251 2020-08-05T14:25:33  *** Tralfaz has joined #bitcoin-core-dev
252 2020-08-05T14:28:32  *** bitcoin-git has joined #bitcoin-core-dev
253 2020-08-05T14:28:32  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e4df534c60e1...4644b13b4499
254 2020-08-05T14:28:33  <bitcoin-git> bitcoin/master 82fc401 Ben Woosley: test: Catch decimal.InvalidOperation from TestNodeCLI#send_cli
255 2020-08-05T14:28:34  <bitcoin-git> bitcoin/master 4644b13 Wladimir J. van der Laan: Merge #19632: test: Catch decimal.InvalidOperation from TestNodeCLI#send_c...
256 2020-08-05T14:28:35  *** bitcoin-git has left #bitcoin-core-dev
257 2020-08-05T14:28:52  *** bitcoin-git has joined #bitcoin-core-dev
258 2020-08-05T14:28:52  <bitcoin-git> [bitcoin] laanwj merged pull request #19632: test: Catch decimal.InvalidOperation from TestNodeCLI#send_cli (master...2020-07-send_cli-invalid-op) https://github.com/bitcoin/bitcoin/pull/19632
259 2020-08-05T14:28:53  *** bitcoin-git has left #bitcoin-core-dev
260 2020-08-05T14:32:45  *** promag_ has quit IRC
261 2020-08-05T14:33:17  *** promag_ has joined #bitcoin-core-dev
262 2020-08-05T14:33:37  *** promag_ has joined #bitcoin-core-dev
263 2020-08-05T14:38:33  *** promag_ has quit IRC
264 2020-08-05T14:39:13  <MarcoFalke> #proposedmeetingtopic add #19629 to high prio, discuss whether to remove the pulls that need rebase from high prio. (MarcoFalke, but won't be around)
265 2020-08-05T14:39:14  *** promag_ has joined #bitcoin-core-dev
266 2020-08-05T14:39:15  <gribble> https://github.com/bitcoin/bitcoin/issues/19629 | Pass mempool pointer to chainstate constructor by MarcoFalke · Pull Request #19629 · bitcoin/bitcoin · GitHub
267 2020-08-05T14:46:14  *** bitcoin-git has joined #bitcoin-core-dev
268 2020-08-05T14:46:15  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19669: contrib: Fixup valgrind suppressions file (master...2008-valSupp) https://github.com/bitcoin/bitcoin/pull/19669
269 2020-08-05T14:46:15  *** bitcoin-git has left #bitcoin-core-dev
270 2020-08-05T14:51:49  *** Chris_Stewart_5 has quit IRC
271 2020-08-05T14:55:31  *** Chris_Stewart_5 has joined #bitcoin-core-dev
272 2020-08-05T14:58:23  *** andreacab has joined #bitcoin-core-dev
273 2020-08-05T14:59:53  *** Tennis has joined #bitcoin-core-dev
274 2020-08-05T15:00:01  *** byte[]1 has quit IRC
275 2020-08-05T15:00:52  *** andreacab has quit IRC
276 2020-08-05T15:01:19  *** andreacab has joined #bitcoin-core-dev
277 2020-08-05T15:01:27  *** Pavlenex has quit IRC
278 2020-08-05T15:02:27  *** dviola has joined #bitcoin-core-dev
279 2020-08-05T15:03:51  <wumpus> MarcoFalke: sure, let's just add it, I prefer doing high prio list changes only during the meeting but also understand not everyone can be there at that time
280 2020-08-05T15:05:50  *** andreacab has quit IRC
281 2020-08-05T15:09:08  *** Chris_Stewart_5 has quit IRC
282 2020-08-05T15:10:30  *** proofofkeags has joined #bitcoin-core-dev
283 2020-08-05T15:13:24  *** Chris_Stewart_5 has joined #bitcoin-core-dev
284 2020-08-05T15:21:10  *** Hexxeh has joined #bitcoin-core-dev
285 2020-08-05T15:23:18  *** Talkless has joined #bitcoin-core-dev
286 2020-08-05T15:30:42  <wumpus> added
287 2020-08-05T15:34:16  *** bitcoin-git has joined #bitcoin-core-dev
288 2020-08-05T15:34:17  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4644b13b4499...e3272ff2907c
289 2020-08-05T15:34:17  <bitcoin-git> bitcoin/master 1d8338d fanquake: util: use HAVE_FDATASYNC to determine fdatasync() use
290 2020-08-05T15:34:18  <bitcoin-git> bitcoin/master e3272ff Wladimir J. van der Laan: Merge #19614: util: use HAVE_FDATASYNC to determine fdatasync() use
291 2020-08-05T15:34:20  *** bitcoin-git has left #bitcoin-core-dev
292 2020-08-05T15:34:35  *** bitcoin-git has joined #bitcoin-core-dev
293 2020-08-05T15:34:35  <bitcoin-git> [bitcoin] laanwj merged pull request #19614: util: use HAVE_FDATASYNC to determine fdatasync() use (master...use_have_fdatasync) https://github.com/bitcoin/bitcoin/pull/19614
294 2020-08-05T15:34:37  *** bitcoin-git has left #bitcoin-core-dev
295 2020-08-05T15:40:10  <achow101> wumpus: it's actually not clear to me whether we should even keep zapwallettxes since we have abandontransaction
296 2020-08-05T15:40:17  <instagibbs> can someone remind me where a test reads off logs looking for a string
297 2020-08-05T15:40:44  <instagibbs> ah tiny grepfu got it nvm
298 2020-08-05T15:47:09  *** morcos has quit IRC
299 2020-08-05T15:47:26  *** morcos has joined #bitcoin-core-dev
300 2020-08-05T15:59:03  *** AaronvanW has joined #bitcoin-core-dev
301 2020-08-05T16:02:24  *** promag_ has quit IRC
302 2020-08-05T16:04:57  *** promag_ has joined #bitcoin-core-dev
303 2020-08-05T16:08:59  *** promag_ has quit IRC
304 2020-08-05T16:09:14  *** jeremyrubin has joined #bitcoin-core-dev
305 2020-08-05T16:10:41  *** andreacab has joined #bitcoin-core-dev
306 2020-08-05T16:10:45  <instagibbs> what's the maximum time a node is supposed to wait before getdata'ing an tx it gets an inv for?
307 2020-08-05T16:11:00  *** Highway61 has quit IRC
308 2020-08-05T16:11:19  *** andreacab has quit IRC
309 2020-08-05T16:11:20  *** Highway61 has joined #bitcoin-core-dev
310 2020-08-05T16:11:27  <instagibbs> Just encountered a 50 second gap on regtest, that seems a bit extreme, wondering if I'm missing something
311 2020-08-05T16:11:46  *** andreacab has joined #bitcoin-core-dev
312 2020-08-05T16:11:47  *** Highway61 has quit IRC
313 2020-08-05T16:12:18  <sipa> instagibbs: there is no limit, really
314 2020-08-05T16:12:49  <instagibbs> hmm ok, because im modifying a test that claims the getdata won't happen(because of outstanding getdata request to other peer)
315 2020-08-05T16:12:58  *** Highway61 has joined #bitcoin-core-dev
316 2020-08-05T16:12:59  <sipa> but if you have N peers announcing, and the first N-1 ones don't respond, it'll take N-1 minutes
317 2020-08-05T16:13:10  <instagibbs> ah!
318 2020-08-05T16:13:22  <instagibbs> that lines up basically perfectly, thanks
319 2020-08-05T16:13:52  <instagibbs> is that some timer based logic? Can I get a pointer?
320 2020-08-05T16:14:32  <sipa> g_already_asked_for
321 2020-08-05T16:14:44  <sipa> coordinates what gets requested from whom wheb
322 2020-08-05T16:15:46  *** andreacab has quit IRC
323 2020-08-05T16:17:12  *** bitcoin-git has joined #bitcoin-core-dev
324 2020-08-05T16:17:13  <bitcoin-git> [bitcoin] promag closed pull request #19640: refactor: Improve GetWitnessCommitmentIndex (master...2020-08-getwitnesscommitmentindex) https://github.com/bitcoin/bitcoin/pull/19640
325 2020-08-05T16:17:14  *** bitcoin-git has left #bitcoin-core-dev
326 2020-08-05T16:17:22  <instagibbs> yeah ok found the block, perfect
327 2020-08-05T16:18:08  *** arowser_ has quit IRC
328 2020-08-05T16:18:10  <sipa> #19184 rewrites all of that
329 2020-08-05T16:18:14  <gribble> https://github.com/bitcoin/bitcoin/issues/19184 | Overhaul transaction request logic by sipa · Pull Request #19184 · bitcoin/bitcoin · GitHub
330 2020-08-05T16:18:29  *** arowser_ has joined #bitcoin-core-dev
331 2020-08-05T16:18:47  *** troygiorshev has quit IRC
332 2020-08-05T16:19:05  *** troygiorshev has joined #bitcoin-core-dev
333 2020-08-05T16:19:23  *** sdaftuar has quit IRC
334 2020-08-05T16:19:46  *** sdaftuar has joined #bitcoin-core-dev
335 2020-08-05T16:26:49  <wumpus> achow101: yes, that's another point
336 2020-08-05T16:27:48  <achow101> #proposedmeetingtopic: what to do about zapwallettxes
337 2020-08-05T16:27:50  <wumpus> achow101: I think zapwallettx was introduced for the same reason as abandontransaction
338 2020-08-05T16:28:11  <achow101> wumpus: it seems like that's been the only use for it
339 2020-08-05T16:28:13  *** proofofkeags has quit IRC
340 2020-08-05T16:28:13  <wumpus> I'm not sure people are actually ever using it
341 2020-08-05T16:28:18  <wumpus> right
342 2020-08-05T16:28:32  <achow101> and both don't work with -persistmempool
343 2020-08-05T16:28:48  *** proofofkeags has joined #bitcoin-core-dev
344 2020-08-05T16:29:01  <wumpus> I think abandontransaction, to be able to abandon specific conflicted or stuck transaction, is superior in every case
345 2020-08-05T16:29:29  <wumpus> but I'm not sure, it might be zapwallettx is more of a sledge hammer that can be useful in some cases
346 2020-08-05T16:29:40  <sipa> i think zapwallettxes was also intended as a way to.recover from very corrupted wallet files
347 2020-08-05T16:29:51  <sipa> or is that savagewallet
348 2020-08-05T16:30:04  <wumpus> that ^^
349 2020-08-05T16:30:27  <achow101> there was a test case MarcoFalke made recently that did savagewallet and zapwallettxes would fix the problem
350 2020-08-05T16:30:28  <wumpus> salvagewallet already has multiple settings IIRC
351 2020-08-05T16:30:48  <wumpus> I guess zapwallettxes could be another salvagewallet level
352 2020-08-05T16:31:03  <achow101> it was something like savagewallet ended up adding a tx to the wallet multiple times, so zapwallettxs could fix that with dumping all the txs
353 2020-08-05T16:31:58  <wumpus> salvagewallet is ugly and unreliable as it goes over the raw database file data, so it sometimes misinterprets things
354 2020-08-05T16:32:16  <wumpus> so it can create spurious records
355 2020-08-05T16:32:36  <achow101> https://github.com/bitcoin/bitcoin/pull/19457#discussion_r460653761
356 2020-08-05T16:32:51  <wumpus> the private key entries have a hash now so should be protected from this, buttransactions have not
357 2020-08-05T16:32:59  *** proofofkeags has quit IRC
358 2020-08-05T16:33:21  <achow101> transactions have txid, for the things covered by that..
359 2020-08-05T16:33:27  <wumpus> maybe salvage shouldn't salvage transactions at all
360 2020-08-05T16:33:32  <wumpus> just the keys
361 2020-08-05T16:33:35  <achow101> but a tx record contains a bunch of other crap
362 2020-08-05T16:33:40  <wumpus> ohh
363 2020-08-05T16:34:05  <wumpus> (and scripts!)
364 2020-08-05T16:35:23  *** sdaftuar has quit IRC
365 2020-08-05T16:35:39  *** sdaftuar has joined #bitcoin-core-dev
366 2020-08-05T16:51:54  *** K4TJANG has quit IRC
367 2020-08-05T16:56:02  *** dviola has quit IRC
368 2020-08-05T16:56:57  *** gzhao408 has joined #bitcoin-core-dev
369 2020-08-05T17:01:50  *** Pavlenex has joined #bitcoin-core-dev
370 2020-08-05T17:01:57  *** K4TJANG has joined #bitcoin-core-dev
371 2020-08-05T17:14:39  *** Tennis has quit IRC
372 2020-08-05T17:14:59  *** dviola has joined #bitcoin-core-dev
373 2020-08-05T17:19:14  *** Pavlenex has quit IRC
374 2020-08-05T17:19:20  *** dviola has left #bitcoin-core-dev
375 2020-08-05T17:19:47  *** dviola has joined #bitcoin-core-dev
376 2020-08-05T17:22:03  *** promag_ has joined #bitcoin-core-dev
377 2020-08-05T17:22:23  *** Highway61 has quit IRC
378 2020-08-05T17:26:38  *** rafalcpp has quit IRC
379 2020-08-05T17:31:46  *** Pavlenex has joined #bitcoin-core-dev
380 2020-08-05T17:34:29  *** tryphe_ has quit IRC
381 2020-08-05T17:35:20  *** tryphe_ has joined #bitcoin-core-dev
382 2020-08-05T17:36:09  *** promag_ has joined #bitcoin-core-dev
383 2020-08-05T17:36:32  *** Pavlenex has quit IRC
384 2020-08-05T17:39:01  *** rafalcpp has joined #bitcoin-core-dev
385 2020-08-05T17:40:35  *** promag_ has quit IRC
386 2020-08-05T17:42:02  *** mrostecki has joined #bitcoin-core-dev
387 2020-08-05T17:57:39  *** gzhao408 has quit IRC
388 2020-08-05T18:00:02  *** Hexxeh has quit IRC
389 2020-08-05T18:02:07  *** jimpo has quit IRC
390 2020-08-05T18:05:12  *** rafalcpp has quit IRC
391 2020-08-05T18:13:25  *** proofofkeags has joined #bitcoin-core-dev
392 2020-08-05T18:19:39  *** justanotheruser has joined #bitcoin-core-dev
393 2020-08-05T18:22:35  *** ka6sox1 has joined #bitcoin-core-dev
394 2020-08-05T18:35:34  *** jimpo has joined #bitcoin-core-dev
395 2020-08-05T18:41:17  *** jimpo has quit IRC
396 2020-08-05T18:45:11  *** jimpo has joined #bitcoin-core-dev
397 2020-08-05T18:52:10  *** jimpo has quit IRC
398 2020-08-05T18:54:16  *** jimpo has joined #bitcoin-core-dev
399 2020-08-05T18:55:20  *** jimpo has quit IRC
400 2020-08-05T18:55:25  *** Chris_Stewart_5 has quit IRC
401 2020-08-05T18:58:58  *** bitcoin-git has joined #bitcoin-core-dev
402 2020-08-05T18:58:59  <bitcoin-git> [bitcoin] sdaftuar opened pull request #19670: Protect localhost and block-relay-only peers from eviction (master...2020-08-improved-eviction) https://github.com/bitcoin/bitcoin/pull/19670
403 2020-08-05T18:59:00  *** bitcoin-git has left #bitcoin-core-dev
404 2020-08-05T18:59:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
405 2020-08-05T19:09:25  *** Talkless has quit IRC
406 2020-08-05T19:27:13  *** troygiorshev has quit IRC
407 2020-08-05T19:28:59  *** troygiorshev has joined #bitcoin-core-dev
408 2020-08-05T19:32:32  *** K4TJANG has quit IRC
409 2020-08-05T19:41:15  *** Highway61 has joined #bitcoin-core-dev
410 2020-08-05T19:46:06  *** arowser_ has quit IRC
411 2020-08-05T19:46:44  *** arowser_ has joined #bitcoin-core-dev
412 2020-08-05T19:56:51  *** Chris_Stewart_5 has quit IRC
413 2020-08-05T19:58:53  *** Chris_Stewart_5 has joined #bitcoin-core-dev
414 2020-08-05T19:59:02  *** AaronvanW has quit IRC
415 2020-08-05T20:00:40  *** arowser_ has quit IRC
416 2020-08-05T20:00:57  *** arowser_ has joined #bitcoin-core-dev
417 2020-08-05T20:07:10  *** cato_ has quit IRC
418 2020-08-05T20:07:20  *** cato_ has joined #bitcoin-core-dev
419 2020-08-05T20:14:15  *** DeanWeen has quit IRC
420 2020-08-05T20:14:59  *** Tralfaz is now known as davterra
421 2020-08-05T20:15:15  *** DeanWeen has joined #bitcoin-core-dev
422 2020-08-05T20:15:23  *** proofofkeags has quit IRC
423 2020-08-05T20:15:58  *** proofofkeags has joined #bitcoin-core-dev
424 2020-08-05T20:19:31  *** cubancorona has joined #bitcoin-core-dev
425 2020-08-05T20:19:40  *** cubancorona has left #bitcoin-core-dev
426 2020-08-05T20:20:11  *** proofofkeags has quit IRC
427 2020-08-05T20:20:14  *** K4TJANG has joined #bitcoin-core-dev
428 2020-08-05T20:28:18  *** rafalcpp has joined #bitcoin-core-dev
429 2020-08-05T20:28:55  *** andreacab has joined #bitcoin-core-dev
430 2020-08-05T20:44:21  *** bitcoin-git has joined #bitcoin-core-dev
431 2020-08-05T20:44:21  <bitcoin-git> [bitcoin] achow101 opened pull request #19671: wallet: Remove -zapwallettxes (master...rm-zapwallettxes) https://github.com/bitcoin/bitcoin/pull/19671
432 2020-08-05T20:44:22  *** bitcoin-git has left #bitcoin-core-dev
433 2020-08-05T20:45:34  *** mutatrum has joined #bitcoin-core-dev
434 2020-08-05T20:45:47  *** owowo has quit IRC
435 2020-08-05T20:46:10  *** Guyver2 has quit IRC
436 2020-08-05T20:46:43  *** andreacab has quit IRC
437 2020-08-05T20:47:10  *** andreacab has joined #bitcoin-core-dev
438 2020-08-05T20:51:03  *** owowo has joined #bitcoin-core-dev
439 2020-08-05T20:51:04  *** owowo has joined #bitcoin-core-dev
440 2020-08-05T20:51:40  *** andreacab has quit IRC
441 2020-08-05T21:00:01  *** ka6sox1 has quit IRC
442 2020-08-05T21:03:13  *** mutatrum has quit IRC
443 2020-08-05T21:07:04  *** mol_ has joined #bitcoin-core-dev
444 2020-08-05T21:11:14  *** mol has quit IRC
445 2020-08-05T21:19:07  *** promag_ has joined #bitcoin-core-dev
446 2020-08-05T21:21:57  *** jwheare1 has joined #bitcoin-core-dev
447 2020-08-05T21:27:00  *** proofofkeags has joined #bitcoin-core-dev
448 2020-08-05T21:34:48  *** proofofkeags has quit IRC
449 2020-08-05T21:44:31  *** AaronvanW has joined #bitcoin-core-dev
450 2020-08-05T21:49:49  *** fox2p has joined #bitcoin-core-dev
451 2020-08-05T21:53:35  *** nanotube has quit IRC
452 2020-08-05T21:53:38  *** rafalcpp has quit IRC
453 2020-08-05T21:55:45  *** promag_ has quit IRC
454 2020-08-05T21:55:46  *** tjw11 has joined #bitcoin-core-dev
455 2020-08-05T21:56:40  *** promag_ has joined #bitcoin-core-dev
456 2020-08-05T22:00:21  *** promag_ has quit IRC
457 2020-08-05T22:10:35  *** proofofkeags has joined #bitcoin-core-dev
458 2020-08-05T22:10:54  *** promag_ has joined #bitcoin-core-dev
459 2020-08-05T22:15:06  *** proofofkeags has quit IRC
460 2020-08-05T22:27:56  *** baldur has quit IRC
461 2020-08-05T22:31:54  *** marcoagner has quit IRC
462 2020-08-05T22:41:01  *** baldur has joined #bitcoin-core-dev
463 2020-08-05T22:55:35  *** vasild_ has joined #bitcoin-core-dev
464 2020-08-05T22:56:53  *** davterra has quit IRC
465 2020-08-05T22:58:43  *** vasild has quit IRC
466 2020-08-05T22:58:44  *** vasild_ is now known as vasild
467 2020-08-05T22:59:30  *** proofofkeags has joined #bitcoin-core-dev
468 2020-08-05T23:12:54  *** K4TJANG has quit IRC
469 2020-08-05T23:13:40  *** mrostecki has quit IRC
470 2020-08-05T23:15:12  *** nanotube has joined #bitcoin-core-dev
471 2020-08-05T23:15:41  *** promag_ has quit IRC
472 2020-08-05T23:16:33  *** K4TJANG has joined #bitcoin-core-dev
473 2020-08-05T23:20:47  *** justanotheruser has quit IRC
474 2020-08-05T23:22:24  *** mrostecki has joined #bitcoin-core-dev
475 2020-08-05T23:37:51  *** bitdex has joined #bitcoin-core-dev
476 2020-08-05T23:40:47  *** justanotheruser has joined #bitcoin-core-dev
477 2020-08-05T23:44:48  *** tryphe_ is now known as tryphe