1 2020-08-12T00:00:03  *** kwm1 has quit IRC
  2 2020-08-12T00:03:19  *** promag has quit IRC
  3 2020-08-12T00:04:23  *** promag has joined #bitcoin-core-dev
  4 2020-08-12T00:13:41  *** jonatack has quit IRC
  5 2020-08-12T00:20:58  *** diogorsergio has joined #bitcoin-core-dev
  6 2020-08-12T00:22:04  *** SukhE1 has joined #bitcoin-core-dev
  7 2020-08-12T00:27:04  *** promag has quit IRC
  8 2020-08-12T00:29:21  *** Davterra has joined #bitcoin-core-dev
  9 2020-08-12T00:33:52  *** mdunnio has joined #bitcoin-core-dev
 10 2020-08-12T00:44:57  *** promag has joined #bitcoin-core-dev
 11 2020-08-12T00:48:25  *** SukhE1 has quit IRC
 12 2020-08-12T00:49:43  *** bitcoin-git has joined #bitcoin-core-dev
 13 2020-08-12T00:49:43  <bitcoin-git> [bitcoin] achow101 opened pull request #19700: wallet: Replace -zapwallettxes with wallet tool command (master...zapwallettxes-wallettool) https://github.com/bitcoin/bitcoin/pull/19700
 14 2020-08-12T00:49:45  *** bitcoin-git has left #bitcoin-core-dev
 15 2020-08-12T00:58:51  <luke-jr> I thought that was already open O.o
 16 2020-08-12T00:59:13  *** jb55 has quit IRC
 17 2020-08-12T00:59:45  *** jb55 has joined #bitcoin-core-dev
 18 2020-08-12T01:05:56  *** promag has quit IRC
 19 2020-08-12T01:06:01  <achow101> luke-jr: I've opened 3 prs, one for each option
 20 2020-08-12T01:06:58  <luke-jr> aha
 21 2020-08-12T01:09:20  *** justanotheruser has joined #bitcoin-core-dev
 22 2020-08-12T01:10:49  *** promag has joined #bitcoin-core-dev
 23 2020-08-12T01:13:40  *** promag has quit IRC
 24 2020-08-12T01:25:10  *** arowser_ has quit IRC
 25 2020-08-12T01:25:32  *** arowser_ has joined #bitcoin-core-dev
 26 2020-08-12T01:27:15  *** promag has joined #bitcoin-core-dev
 27 2020-08-12T01:31:07  *** joeykrim1 has joined #bitcoin-core-dev
 28 2020-08-12T01:31:24  *** trash_mapache has joined #bitcoin-core-dev
 29 2020-08-12T01:34:39  *** Eagle[TM] has joined #bitcoin-core-dev
 30 2020-08-12T01:34:42  *** mdunnio has quit IRC
 31 2020-08-12T01:36:42  *** EagleTM has quit IRC
 32 2020-08-12T01:53:42  *** promag has quit IRC
 33 2020-08-12T01:57:08  *** arowser_ has quit IRC
 34 2020-08-12T01:59:14  <luke-jr> where can I learn about this crazy(?) new RPC implementation syntax, and why it's better than the older more readable version?
 35 2020-08-12T02:02:26  *** bitcoin-git has joined #bitcoin-core-dev
 36 2020-08-12T02:02:27  <bitcoin-git> [bitcoin] fanquake pushed 20 commits to master: https://github.com/bitcoin/bitcoin/compare/cb1ee1551cf3...ce3bdd0ed1bb
 37 2020-08-12T02:02:28  <bitcoin-git> bitcoin/master 3f1b714 Amiti Uttarwar: scripted-diff: Rename OneShot to AddrFetch
 38 2020-08-12T02:02:29  <bitcoin-git> bitcoin/master 26304b4 Amiti Uttarwar: [net/refactor] Introduce an enum to distinguish type of connection
 39 2020-08-12T02:02:30  <bitcoin-git> bitcoin/master 1521c47 Amiti Uttarwar: [net/refactor] Add manual connections to ConnectionType enum
 40 2020-08-12T02:02:31  *** bitcoin-git has left #bitcoin-core-dev
 41 2020-08-12T02:02:50  *** bitcoin-git has joined #bitcoin-core-dev
 42 2020-08-12T02:02:51  <bitcoin-git> [bitcoin] fanquake merged pull request #19316: [net] Cleanup logic around connection types (master...2020-06-conn-refactor) https://github.com/bitcoin/bitcoin/pull/19316
 43 2020-08-12T02:02:52  *** bitcoin-git has left #bitcoin-core-dev
 44 2020-08-12T02:03:36  *** arowser_ has joined #bitcoin-core-dev
 45 2020-08-12T02:07:08  *** Davterra has quit IRC
 46 2020-08-12T02:08:57  *** mdunnio has joined #bitcoin-core-dev
 47 2020-08-12T02:09:37  *** Davterra has joined #bitcoin-core-dev
 48 2020-08-12T02:12:30  <jeremyrubin> luke-jr: eh? example
 49 2020-08-12T02:13:05  <achow101> you mean the RPCHelpMan stuff?
 50 2020-08-12T02:13:08  <luke-jr> yes
 51 2020-08-12T02:13:14  <luke-jr> jeremyrubin: https://github.com/bitcoin/bitcoin/pull/19550
 52 2020-08-12T02:13:25  *** mdunnio has quit IRC
 53 2020-08-12T02:13:51  <achow101> luke-jr: it's better because it aligns all the help text correctly
 54 2020-08-12T02:14:01  <achow101> the syntax is just matching brackets correctly
 55 2020-08-12T02:14:08  *** arowser_ has quit IRC
 56 2020-08-12T02:16:50  <luke-jr> achow101: I don't mean RPCHelpMan itself, I mean the new change of moving code inside it
 57 2020-08-12T02:17:40  <jeremyrubin> it looks like it has for some time now
 58 2020-08-12T02:17:53  <jeremyrubin> i don't see any changes from what it's been for a while
 59 2020-08-12T02:18:18  <achow101> luke-jr: oh, I see, 19550 is don't something funky
 60 2020-08-12T02:18:23  <achow101> *doing
 61 2020-08-12T02:18:56  <jeremyrubin> line 638?
 62 2020-08-12T02:19:07  <achow101> I assume so
 63 2020-08-12T02:19:12  *** arowser_ has joined #bitcoin-core-dev
 64 2020-08-12T02:19:22  <luke-jr> yeah
 65 2020-08-12T02:19:44  <achow101> did someone suggest him to do that? I haven't seen that syntax before
 66 2020-08-12T02:20:14  <luke-jr> https://github.com/bitcoin/bitcoin/pull/19550#discussion_r456865552
 67 2020-08-12T02:21:22  <achow101> luke-jr: I guess #19528 explains it
 68 2020-08-12T02:21:24  <gribble> https://github.com/bitcoin/bitcoin/issues/19528 | rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc) by MarcoFalke · Pull Request #19528 · bitcoin/bitcoin · GitHub
 69 2020-08-12T02:22:48  <jeremyrubin> seems like a good change
 70 2020-08-12T02:23:00  <achow101> this'll be one of those things that you just copy and paste
 71 2020-08-12T02:24:18  <luke-jr> I don't see the explanation
 72 2020-08-12T02:24:50  <achow101> " However, in the future they could be used to teach the server the named arguments. Named arguments are currently registered by the CRPCCommands and duplicate the RPCArg names from the documentation. This redundancy is fragile, and has lead to errors in the past (despite having linters to catch those kind of errors)."
 73 2020-08-12T02:25:13  <luke-jr> what does that have to do with this new RPC method definition stuff?
 74 2020-08-12T02:25:28  <jeremyrubin> it checks the args and then makes the call
 75 2020-08-12T02:25:41  <achow101> it makes the function return the RPCHelpMan which can then report the arg names
 76 2020-08-12T02:25:43  <luke-jr> it did that before this..?
 77 2020-08-12T02:25:45  *** justanotheruser has quit IRC
 78 2020-08-12T02:25:59  <achow101> then the actual RPC stuff is a function within the RPCHelpMan
 79 2020-08-12T02:26:04  <jeremyrubin> but it required redundant and potentially inconsistent info
 80 2020-08-12T02:27:16  <luke-jr> this seems like a rather ugly way to accomplish it :/
 81 2020-08-12T02:30:05  <luke-jr> probably better to get rid of the function/return, and just declare it as a static variable?
 82 2020-08-12T02:31:46  *** justanotheruser has joined #bitcoin-core-dev
 83 2020-08-12T02:32:35  <achow101> it's just a lambda
 84 2020-08-12T02:33:40  *** troygior1hev has quit IRC
 85 2020-08-12T02:34:05  <luke-jr> #proposedmeetingtopic Can we recreate bitcoin-core/gui so GitHub will let us do PRs from the same <user>/bitcoin forks instead of making a new remote for everyone?
 86 2020-08-12T02:34:35  *** arowser_ has quit IRC
 87 2020-08-12T02:35:02  *** arowser_ has joined #bitcoin-core-dev
 88 2020-08-12T02:52:35  *** Highway61 has quit IRC
 89 2020-08-12T03:00:02  *** joeykrim1 has quit IRC
 90 2020-08-12T03:05:50  *** Eagle[TM] has quit IRC
 91 2020-08-12T03:06:50  *** EagleTM has joined #bitcoin-core-dev
 92 2020-08-12T03:09:32  *** Emcy has quit IRC
 93 2020-08-12T03:13:02  *** Emcy has joined #bitcoin-core-dev
 94 2020-08-12T03:16:37  *** trash_mapache has quit IRC
 95 2020-08-12T03:21:52  *** Phace has joined #bitcoin-core-dev
 96 2020-08-12T03:41:10  *** arowser_ has quit IRC
 97 2020-08-12T03:41:59  *** arowser_ has joined #bitcoin-core-dev
 98 2020-08-12T03:43:11  *** arowser_ has quit IRC
 99 2020-08-12T03:43:41  *** arowser_ has joined #bitcoin-core-dev
100 2020-08-12T03:45:02  *** watersnake1 has quit IRC
101 2020-08-12T03:46:09  *** arowser_ has quit IRC
102 2020-08-12T03:46:29  *** arowser_ has joined #bitcoin-core-dev
103 2020-08-12T03:50:05  <kallewoof> Signet pull request has been updated with ajtowns suggestions, and the network is up and running now. Please review! https://github.com/bitcoin/bitcoin/pull/18267
104 2020-08-12T03:53:35  *** Dean_Guss has joined #bitcoin-core-dev
105 2020-08-12T03:55:43  *** DeanWeen has quit IRC
106 2020-08-12T04:25:09  *** arowser_ has quit IRC
107 2020-08-12T04:25:34  *** arowser_ has joined #bitcoin-core-dev
108 2020-08-12T04:35:08  *** arowser_ has quit IRC
109 2020-08-12T04:35:36  *** arowser_ has joined #bitcoin-core-dev
110 2020-08-12T04:55:38  *** TheHoliestRoger has quit IRC
111 2020-08-12T04:55:43  *** TheHoliestRoger_ has joined #bitcoin-core-dev
112 2020-08-12T04:56:10  *** arowser_ has quit IRC
113 2020-08-12T04:56:35  *** arowser_ has joined #bitcoin-core-dev
114 2020-08-12T04:57:08  *** mdunnio has joined #bitcoin-core-dev
115 2020-08-12T05:05:37  *** mdunnio has quit IRC
116 2020-08-12T05:21:09  *** arowser_ has quit IRC
117 2020-08-12T05:21:28  *** arowser_ has joined #bitcoin-core-dev
118 2020-08-12T05:30:13  *** Dean_Guss has quit IRC
119 2020-08-12T05:30:24  *** Dean_Guss has joined #bitcoin-core-dev
120 2020-08-12T05:33:37  *** Emcy has quit IRC
121 2020-08-12T05:35:11  *** arowser_ has quit IRC
122 2020-08-12T05:35:39  *** arowser_ has joined #bitcoin-core-dev
123 2020-08-12T05:36:08  *** Emcy has joined #bitcoin-core-dev
124 2020-08-12T05:36:41  *** justanotheruser has quit IRC
125 2020-08-12T05:42:47  *** jb55 has quit IRC
126 2020-08-12T05:44:33  *** Deacydal has quit IRC
127 2020-08-12T06:00:01  *** Phace has quit IRC
128 2020-08-12T06:11:37  *** arowser_ has quit IRC
129 2020-08-12T06:12:59  *** vfP56jSe has quit IRC
130 2020-08-12T06:14:14  *** vfP56jSe has joined #bitcoin-core-dev
131 2020-08-12T06:22:16  *** torax has joined #bitcoin-core-dev
132 2020-08-12T06:23:40  *** arowser_ has joined #bitcoin-core-dev
133 2020-08-12T06:37:09  *** EagleTM has quit IRC
134 2020-08-12T06:47:12  *** arowser_ has quit IRC
135 2020-08-12T06:47:35  *** arowser_ has joined #bitcoin-core-dev
136 2020-08-12T06:59:48  *** marcoagner has joined #bitcoin-core-dev
137 2020-08-12T07:05:17  *** DeanWeen has joined #bitcoin-core-dev
138 2020-08-12T07:05:47  *** Dean_Guss has quit IRC
139 2020-08-12T07:09:20  *** davec has quit IRC
140 2020-08-12T07:09:56  *** davec has joined #bitcoin-core-dev
141 2020-08-12T07:12:18  *** Guyver2 has joined #bitcoin-core-dev
142 2020-08-12T07:18:45  *** arowser_ has quit IRC
143 2020-08-12T07:19:34  *** davec has quit IRC
144 2020-08-12T07:21:11  *** davec has joined #bitcoin-core-dev
145 2020-08-12T07:30:59  *** arowser_ has joined #bitcoin-core-dev
146 2020-08-12T07:43:13  *** arowser_ has quit IRC
147 2020-08-12T07:43:42  *** arowser_ has joined #bitcoin-core-dev
148 2020-08-12T07:46:00  *** vincenzopalazzo has quit IRC
149 2020-08-12T07:50:23  *** jonatack has joined #bitcoin-core-dev
150 2020-08-12T07:56:32  *** sipsorcery has joined #bitcoin-core-dev
151 2020-08-12T08:08:54  *** midnight has quit IRC
152 2020-08-12T08:11:03  *** midnight has joined #bitcoin-core-dev
153 2020-08-12T08:12:46  *** vincenzopalazzo has joined #bitcoin-core-dev
154 2020-08-12T08:15:41  *** davec has quit IRC
155 2020-08-12T08:16:24  *** Deacyde has joined #bitcoin-core-dev
156 2020-08-12T08:28:19  *** arowser_ has quit IRC
157 2020-08-12T08:28:39  *** arowser_ has joined #bitcoin-core-dev
158 2020-08-12T08:29:16  *** arowser_ has quit IRC
159 2020-08-12T08:29:36  *** arowser_ has joined #bitcoin-core-dev
160 2020-08-12T08:35:09  *** davec has joined #bitcoin-core-dev
161 2020-08-12T08:45:19  *** b10c has joined #bitcoin-core-dev
162 2020-08-12T08:51:05  <jonatack> review beg for #19455 (which arguably should have been in the last release with -generate to make multiple bitcoin command line tutorials work again for users), as requested by ajonas and MarcoFalke. It's a quick review with complete test coverage.
163 2020-08-12T08:51:07  <gribble> https://github.com/bitcoin/bitcoin/issues/19455 | rpc generate: print useful help and error message by jonatack · Pull Request #19455 · bitcoin/bitcoin · GitHub
164 2020-08-12T08:54:49  *** promag has joined #bitcoin-core-dev
165 2020-08-12T08:59:26  *** promag has quit IRC
166 2020-08-12T09:00:02  *** torax has quit IRC
167 2020-08-12T09:05:39  *** TheFuzzStone[m] has quit IRC
168 2020-08-12T09:05:39  *** icota[m] has quit IRC
169 2020-08-12T09:05:47  *** thunderbiscuit[m has quit IRC
170 2020-08-12T09:06:16  *** AaronvanW has quit IRC
171 2020-08-12T09:08:14  *** Pavlenex has joined #bitcoin-core-dev
172 2020-08-12T09:12:39  *** SergeySherkunov[ has joined #bitcoin-core-dev
173 2020-08-12T09:18:38  *** b10c_ has joined #bitcoin-core-dev
174 2020-08-12T09:22:14  *** zakk has joined #bitcoin-core-dev
175 2020-08-12T09:22:36  *** zakk is now known as Guest84477
176 2020-08-12T09:25:07  *** Pavlenex has quit IRC
177 2020-08-12T09:28:45  *** davec has quit IRC
178 2020-08-12T09:29:36  *** davec has joined #bitcoin-core-dev
179 2020-08-12T09:32:14  *** AaronvanW has joined #bitcoin-core-dev
180 2020-08-12T09:34:20  *** thunderbiscuit[m has joined #bitcoin-core-dev
181 2020-08-12T09:34:21  *** icota[m] has joined #bitcoin-core-dev
182 2020-08-12T09:34:21  *** TheFuzzStone[m] has joined #bitcoin-core-dev
183 2020-08-12T09:49:10  *** arowser_ has quit IRC
184 2020-08-12T09:49:26  *** reallll has joined #bitcoin-core-dev
185 2020-08-12T09:49:56  *** arowser_ has joined #bitcoin-core-dev
186 2020-08-12T09:51:09  *** davec has quit IRC
187 2020-08-12T09:51:41  *** davec has joined #bitcoin-core-dev
188 2020-08-12T09:53:11  *** belcher_ has quit IRC
189 2020-08-12T09:53:27  *** AaronvanW has quit IRC
190 2020-08-12T09:58:17  *** jeremyrubin has quit IRC
191 2020-08-12T09:59:42  *** EagleTM has joined #bitcoin-core-dev
192 2020-08-12T10:03:18  *** Vinnie23Vandervo has joined #bitcoin-core-dev
193 2020-08-12T10:11:34  *** Pavlenex has joined #bitcoin-core-dev
194 2020-08-12T10:12:25  *** sipsorcery has quit IRC
195 2020-08-12T10:13:18  *** SergeySherkunov[ has quit IRC
196 2020-08-12T10:14:02  *** Pavlenex has quit IRC
197 2020-08-12T10:17:01  *** sipsorcery has joined #bitcoin-core-dev
198 2020-08-12T10:19:15  *** Talkless has joined #bitcoin-core-dev
199 2020-08-12T10:37:08  <jonatack> elichai2: "<elichai2> I don't work on anything p2p related right now, but I do plan to review a bunch of stuff, so if there'll be a high priority for review out of this it would be great" --> high prority suggestion: #19628
200 2020-08-12T10:37:10  <gribble> https://github.com/bitcoin/bitcoin/issues/19628 | net: change CNetAddr::ip to have flexible size by vasild · Pull Request #19628 · bitcoin/bitcoin · GitHub
201 2020-08-12T10:37:20  <jonatack> as part of #19031
202 2020-08-12T10:37:22  <gribble> https://github.com/bitcoin/bitcoin/issues/19031 | Implement ADDRv2 support (part of BIP155) by vasild · Pull Request #19031 · bitcoin/bitcoin · GitHub
203 2020-08-12T10:37:55  <vasild> +1
204 2020-08-12T10:38:34  <elichai2> jonatack: Thanks!
205 2020-08-12T10:40:48  <jonatack> elichai2: 10/10 you'll like it, lots of low-level memcpy/memcmp mixed with some Span to overhaul the critical netaddress infra ;)
206 2020-08-12T10:40:48  *** Vinnie23Vandervo has quit IRC
207 2020-08-12T10:40:59  <elichai2> :D
208 2020-08-12T10:42:05  <vasild> well, in my defence, I tried to split the patch, but everything seems to be linked together...
209 2020-08-12T10:43:23  <jonatack> that is true
210 2020-08-12T10:45:29  <vasild> it would be possible to remove GetByte() as a first patch, but that would be lots of mechanical changes, all retouched/redone in the second patch
211 2020-08-12T10:49:19  <jonatack> while shilling PRs, i find having the cli -netinfo peer connections dashboard (e.g. <human-readable getpeerinfo>) reassuring as a sanity check for testing running nodes with the addrv2 changes
212 2020-08-12T10:50:16  <vasild> e.g. GetByte(3) (this gets the first byte!) would become ip[sizeof(IPV4_IN_IPV6_PREFIX) + 0] (in about 100 places) and then all those will be changed to m_addr[0] in a second patch - I think that would be wasting reviewer's time
213 2020-08-12T10:51:20  *** Highway61 has joined #bitcoin-core-dev
214 2020-08-12T10:53:35  <jonatack> vasild: i think you'll have several acks soon so would not rework it now
215 2020-08-12T10:54:05  <vasild> let it rain acks! :)
216 2020-08-12T10:54:20  <ryanofsky> fanquake, can you give specific examples of where review recap comments have been misleading? I think they are essential for long-lived prs because we have no explicit standards for merging
217 2020-08-12T10:54:20  <vasild> (but not before I address your suggestions)
218 2020-08-12T10:55:25  <ryanofsky> so without review recap comments, there's basically no transparency about why a pr has or hasn't been merged
219 2020-08-12T10:55:37  *** vasild_ has joined #bitcoin-core-dev
220 2020-08-12T10:56:42  <ryanofsky> if a comment is misleading, you can call out the comment, not discourage comments in general
221 2020-08-12T10:58:43  *** vasild has quit IRC
222 2020-08-12T10:58:44  *** vasild_ is now known as vasild
223 2020-08-12T11:11:47  *** jonatack has quit IRC
224 2020-08-12T11:19:32  <fanquake> ryanofsky: Sure, I'll try dig up some examples. I wasn't trying to discourage commenting. My point is that Concept ACKs left at the opening of a PR, are not necessarily relevant if they are being "recapped" 2 months later, after the implementation has changed, or a different approach is being taken. Similarly, if someone ACK'd something 3 rebases and a few code changes ago, I'm not really looking at  that as
225 2020-08-12T11:19:32  <fanquake> a "tested ACK".
226 2020-08-12T11:19:59  <fanquake> Do you think people are changing how they are reviewing based on these comments, or just wether or not they are going to review something in the first place?
227 2020-08-12T11:21:21  *** sipsorcery has quit IRC
228 2020-08-12T11:21:45  <fanquake> I'd also like to avoid the idea that just because a PR has *had* a large number of ACKs throughout it's lifetime, it just ready to merge. Obviously this is all dependent on the change itself, and a bit hard to generalize. However as I mentioned above, ACKs are certainly not equal when it comes to more important parts of the code.
229 2020-08-12T11:22:39  *** sipsorcery has joined #bitcoin-core-dev
230 2020-08-12T11:23:35  <fanquake> Hopefully this is something we'll only have to worry about less as more (frequent) contributors are onboarded etc etc
231 2020-08-12T11:26:29  <ryanofsky> Sure I agree with all that, I just think it's mostly obvious. I plan to keep making review recap comments and want to encourage other people to make them
232 2020-08-12T11:27:09  <ryanofsky> So if there are specific comments that are misleading, which includes outdated acks, or mischaracterized acks, let's just respond to and fix those comments
233 2020-08-12T11:38:40  *** bitcoin-git has joined #bitcoin-core-dev
234 2020-08-12T11:38:40  <bitcoin-git> [bitcoin] jnewbery opened pull request #19704: Net processing: move ProcessMessage() to PeerLogicValidation (master...2020-07-process-message-plv) https://github.com/bitcoin/bitcoin/pull/19704
235 2020-08-12T11:38:42  *** bitcoin-git has left #bitcoin-core-dev
236 2020-08-12T11:48:50  *** spikee has joined #bitcoin-core-dev
237 2020-08-12T11:49:51  *** spikee has joined #bitcoin-core-dev
238 2020-08-12T11:49:55  *** Pavlenex has joined #bitcoin-core-dev
239 2020-08-12T11:51:04  *** andreacab has joined #bitcoin-core-dev
240 2020-08-12T11:56:50  *** Highway61 has quit IRC
241 2020-08-12T11:57:27  *** Guest84477 has quit IRC
242 2020-08-12T12:00:23  *** Highway61 has joined #bitcoin-core-dev
243 2020-08-12T12:03:33  *** andreacab has quit IRC
244 2020-08-12T12:04:00  *** andreacab has joined #bitcoin-core-dev
245 2020-08-12T12:07:02  *** Highway61 has quit IRC
246 2020-08-12T12:08:02  *** andreacab has quit IRC
247 2020-08-12T12:18:56  *** lliehu has joined #bitcoin-core-dev
248 2020-08-12T12:19:22  *** Highway61 has joined #bitcoin-core-dev
249 2020-08-12T12:21:21  *** spikee has quit IRC
250 2020-08-12T12:22:33  <wumpus> yes, definitely call out comments that you think are misleading or ask for more information if you think someone is not clear enough in their review, I definitely agree "number of ACKs" is not the only measure, judging whether something is ready for merge is not *that* trivial
251 2020-08-12T12:23:03  *** wullon58 has joined #bitcoin-core-dev
252 2020-08-12T12:23:19  *** wullon5 has quit IRC
253 2020-08-12T12:24:25  <wumpus> in general I pay attention to: number of ACKs, who has ACKed, are there tests that cover the functionality, are there any unaddressed comments, if it's a bugfix did the original reporter test it, is there anyone with principal problems with the concept or its implementation, etc etc…
254 2020-08-12T12:26:07  <wumpus> it definitely also matters where the code change is, is it in one of the risky parts or only user facing, need different kinds of review
255 2020-08-12T12:26:48  <wumpus> this is why we need actual maintainers and not a merge-bot :-)
256 2020-08-12T12:27:18  *** troygiorshev has joined #bitcoin-core-dev
257 2020-08-12T12:29:05  *** davec has quit IRC
258 2020-08-12T12:29:20  *** davec has joined #bitcoin-core-dev
259 2020-08-12T12:36:06  *** davec has quit IRC
260 2020-08-12T12:41:42  <jnewbery> is there a make target that I can run before pushing that will maximize my chances of passing travis? I used to do `make check && ./test/functional/test_runner.py`, but that often doesn't catch stuff now because of linters and fuzzers.
261 2020-08-12T12:41:56  *** justanotheruser has joined #bitcoin-core-dev
262 2020-08-12T12:42:46  <fanquake> You could append && ./test/lint/lint-all.sh (I think) for the linters
263 2020-08-12T12:43:11  <fanquake> If you want to sanity check the fuzzers you'll have to recompile
264 2020-08-12T12:46:03  *** andreacab has joined #bitcoin-core-dev
265 2020-08-12T12:53:19  *** andreacab has quit IRC
266 2020-08-12T12:53:31  <troygiorshev> We were trying to get away from that, right?  in #19388?
267 2020-08-12T12:53:33  <gribble> https://github.com/bitcoin/bitcoin/issues/19388 | Build fuzz tests by default · Issue #19388 · bitcoin/bitcoin · GitHub
268 2020-08-12T12:58:15  *** Pavlenex has joined #bitcoin-core-dev
269 2020-08-12T12:58:38  *** TheHoliestRoger_ is now known as TheHoliestRoger
270 2020-08-12T13:00:37  *** Pavlenex has quit IRC
271 2020-08-12T13:00:48  *** promag has joined #bitcoin-core-dev
272 2020-08-12T13:04:49  *** promag_ has joined #bitcoin-core-dev
273 2020-08-12T13:05:37  *** promag has quit IRC
274 2020-08-12T13:06:21  *** arowser_ has quit IRC
275 2020-08-12T13:06:41  *** arowser_ has joined #bitcoin-core-dev
276 2020-08-12T13:07:14  *** arowser_ has quit IRC
277 2020-08-12T13:07:34  *** arowser_ has joined #bitcoin-core-dev
278 2020-08-12T13:07:40  <wumpus> troygiorshev: yes and no: the fuzz tests that would be always built are shims and not actually useful for fuzzing, it's just to make sure there's 100% compiler coverage
279 2020-08-12T13:08:12  *** arowser_ has quit IRC
280 2020-08-12T13:08:52  *** arowser_ has joined #bitcoin-core-dev
281 2020-08-12T13:09:12  *** arowser_ has quit IRC
282 2020-08-12T13:09:14  *** promag_ has quit IRC
283 2020-08-12T13:09:30  *** arowser_ has joined #bitcoin-core-dev
284 2020-08-12T13:10:21  *** arowser_ has quit IRC
285 2020-08-12T13:10:49  *** arowser_ has joined #bitcoin-core-dev
286 2020-08-12T13:12:16  *** arowser_ has quit IRC
287 2020-08-12T13:12:57  *** arowser_ has joined #bitcoin-core-dev
288 2020-08-12T13:13:11  *** arowser_ has quit IRC
289 2020-08-12T13:13:36  *** arowser_ has joined #bitcoin-core-dev
290 2020-08-12T13:13:51  <troygiorshev> wumpus: you're right, thx
291 2020-08-12T13:19:13  *** arowser_ has quit IRC
292 2020-08-12T13:19:36  *** davec has joined #bitcoin-core-dev
293 2020-08-12T13:19:38  *** arowser_ has joined #bitcoin-core-dev
294 2020-08-12T13:23:40  *** bitcoin-git has joined #bitcoin-core-dev
295 2020-08-12T13:23:40  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ce3bdd0ed1bb...bd00d3b1f203
296 2020-08-12T13:23:42  <bitcoin-git> bitcoin/master f26502e John Newbery: [addrman] Specify max addresses and pct when calling GetAddresses()
297 2020-08-12T13:23:43  <bitcoin-git> bitcoin/master ae8051b John Newbery: [test] Test that getnodeaddresses() can return all known addresses
298 2020-08-12T13:23:43  <bitcoin-git> bitcoin/master 37a480e John Newbery: [net] Add addpeeraddress RPC method
299 2020-08-12T13:23:44  *** bitcoin-git has left #bitcoin-core-dev
300 2020-08-12T13:24:00  *** bitcoin-git has joined #bitcoin-core-dev
301 2020-08-12T13:24:00  <bitcoin-git> [bitcoin] laanwj merged pull request #19658: [rpc] Allow RPC to fetch all addrman records and add records to addrman (master...2020-07-addrman-get) https://github.com/bitcoin/bitcoin/pull/19658
302 2020-08-12T13:24:01  *** bitcoin-git has left #bitcoin-core-dev
303 2020-08-12T13:24:11  *** andreacab has joined #bitcoin-core-dev
304 2020-08-12T13:26:24  *** andreacab has quit IRC
305 2020-08-12T13:32:27  *** lliehu has quit IRC
306 2020-08-12T13:43:25  *** Guyver2_ has joined #bitcoin-core-dev
307 2020-08-12T13:46:16  *** Guyver2 has quit IRC
308 2020-08-12T13:46:16  *** Guyver2_ is now known as Guyver2
309 2020-08-12T13:46:37  *** mdunnio has joined #bitcoin-core-dev
310 2020-08-12T13:47:59  *** Guyver2_ has joined #bitcoin-core-dev
311 2020-08-12T13:49:40  *** Chris_Stewart_5 has quit IRC
312 2020-08-12T13:50:48  *** Guyver2 has quit IRC
313 2020-08-12T13:51:45  *** Mikaku1 has joined #bitcoin-core-dev
314 2020-08-12T13:55:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
315 2020-08-12T13:59:32  *** mdunnio has quit IRC
316 2020-08-12T13:59:46  *** mdunnio has joined #bitcoin-core-dev
317 2020-08-12T14:11:57  *** Pavlenex has joined #bitcoin-core-dev
318 2020-08-12T14:15:48  *** b10c__ has joined #bitcoin-core-dev
319 2020-08-12T14:17:03  *** b10c_ has quit IRC
320 2020-08-12T14:20:11  *** bitcoin-git has joined #bitcoin-core-dev
321 2020-08-12T14:20:11  <bitcoin-git> [bitcoin] vasild opened pull request #19705: Shrink CAddress from 48 to 40 bytes on x64 (master...shrink_caddress) https://github.com/bitcoin/bitcoin/pull/19705
322 2020-08-12T14:20:13  *** bitcoin-git has left #bitcoin-core-dev
323 2020-08-12T14:23:53  *** Pavlenex has quit IRC
324 2020-08-12T14:24:15  *** Pavlenex has joined #bitcoin-core-dev
325 2020-08-12T14:28:49  *** b10c has quit IRC
326 2020-08-12T14:31:17  *** jonatack has joined #bitcoin-core-dev
327 2020-08-12T14:32:14  *** arowser_ has quit IRC
328 2020-08-12T14:32:54  *** arowser_ has joined #bitcoin-core-dev
329 2020-08-12T14:36:29  *** jonatack has quit IRC
330 2020-08-12T14:40:09  *** jonatack has joined #bitcoin-core-dev
331 2020-08-12T14:41:00  *** Chris_Stewart_5 has quit IRC
332 2020-08-12T14:44:32  *** bitcoin-git has joined #bitcoin-core-dev
333 2020-08-12T14:44:33  <bitcoin-git> [bitcoin] theStack opened pull request #19706: refactor: make EncodeBase58{Check} consume Spans (master...20200810-util-make-base58encode-consume-spans) https://github.com/bitcoin/bitcoin/pull/19706
334 2020-08-12T14:44:34  *** bitcoin-git has left #bitcoin-core-dev
335 2020-08-12T14:45:17  *** arowser_ has quit IRC
336 2020-08-12T14:45:45  *** arowser_ has joined #bitcoin-core-dev
337 2020-08-12T14:45:51  *** Chris_Stewart_5 has joined #bitcoin-core-dev
338 2020-08-12T14:46:16  *** arowser_ has quit IRC
339 2020-08-12T14:46:52  *** arowser_ has joined #bitcoin-core-dev
340 2020-08-12T15:00:02  *** Mikaku1 has quit IRC
341 2020-08-12T15:11:45  *** EagleTM has quit IRC
342 2020-08-12T15:15:00  *** jonatack has quit IRC
343 2020-08-12T15:15:23  *** PaulTroo_ has joined #bitcoin-core-dev
344 2020-08-12T15:17:17  *** Davterra has quit IRC
345 2020-08-12T15:18:05  *** PaulTro__ has quit IRC
346 2020-08-12T15:20:51  *** Davterra has joined #bitcoin-core-dev
347 2020-08-12T15:26:32  <jamesob> fwiw going to take some time this weekend to get the next assumeutxo PR filed, which will be the (unused) process for snapshot activation. main bottleneck is that I've gotta write some decent unittests, which will take a few hours.
348 2020-08-12T15:29:21  *** jeremyrubin has joined #bitcoin-core-dev
349 2020-08-12T15:29:25  *** davec has quit IRC
350 2020-08-12T15:30:01  *** kristapsk_ has quit IRC
351 2020-08-12T15:30:25  *** Davterra has quit IRC
352 2020-08-12T15:32:04  *** Deacyde has quit IRC
353 2020-08-12T15:37:10  *** Mercury_Vapor has quit IRC
354 2020-08-12T15:38:25  *** davec has joined #bitcoin-core-dev
355 2020-08-12T15:40:46  *** Mercury_Vapor has joined #bitcoin-core-dev
356 2020-08-12T15:41:11  *** Mercury_Vapor has joined #bitcoin-core-dev
357 2020-08-12T15:41:27  *** jonatack has joined #bitcoin-core-dev
358 2020-08-12T15:48:50  *** davec has quit IRC
359 2020-08-12T15:50:16  *** davec has joined #bitcoin-core-dev
360 2020-08-12T15:50:37  *** sipsorcery has quit IRC
361 2020-08-12T15:53:57  *** jb55 has joined #bitcoin-core-dev
362 2020-08-12T15:55:08  *** amcrae1 has joined #bitcoin-core-dev
363 2020-08-12T16:01:27  *** Pavlenex has quit IRC
364 2020-08-12T16:01:33  *** troygiorshev has quit IRC
365 2020-08-12T16:06:34  *** sipsorcery has joined #bitcoin-core-dev
366 2020-08-12T16:12:46  *** troygiorshev has joined #bitcoin-core-dev
367 2020-08-12T16:12:53  *** baldur has quit IRC
368 2020-08-12T16:18:09  *** Pavlenex has joined #bitcoin-core-dev
369 2020-08-12T16:25:22  *** baldur has joined #bitcoin-core-dev
370 2020-08-12T16:31:15  *** arowser_ has quit IRC
371 2020-08-12T16:31:43  *** arowser_ has joined #bitcoin-core-dev
372 2020-08-12T16:31:46  *** bitcoin-git has joined #bitcoin-core-dev
373 2020-08-12T16:31:46  <bitcoin-git> [bitcoin] achow101 closed pull request #19653: wallet: Replace -zapwallettxes with zapwallettxes RPC (master...zapwallettxes-rpc) https://github.com/bitcoin/bitcoin/pull/19653
374 2020-08-12T16:31:55  *** bitcoin-git has left #bitcoin-core-dev
375 2020-08-12T16:32:03  <willcl_ark>  troygiorshev: I did make a bit of progress on #19388 but could not get the linking working correctly at the end. If you have any ideas on this, my branch is here: https://github.com/willcl-ark/bitcoin/tree/default_fuzz_tests
376 2020-08-12T16:32:04  <gribble> https://github.com/bitcoin/bitcoin/issues/19388 | Build fuzz tests by default · Issue #19388 · bitcoin/bitcoin · GitHub
377 2020-08-12T16:33:49  <troygiorshev> willcl_ark: thanks for the link.  build stuff is definitely something I'm weak on, but if I spend a day figuring it out I'll give that a look!
378 2020-08-12T16:35:04  *** Guyver2__ has joined #bitcoin-core-dev
379 2020-08-12T16:37:26  *** Guyver2_ has quit IRC
380 2020-08-12T16:49:27  *** tripleslash has joined #bitcoin-core-dev
381 2020-08-12T16:49:57  *** Pavlenex has quit IRC
382 2020-08-12T16:52:33  *** Chris_Stewart_5 has quit IRC
383 2020-08-12T16:52:40  *** gzhao408 has joined #bitcoin-core-dev
384 2020-08-12T16:57:42  *** Chris_Stewart_5 has joined #bitcoin-core-dev
385 2020-08-12T16:59:10  *** Guyver2_ has joined #bitcoin-core-dev
386 2020-08-12T17:01:23  *** lightlike has joined #bitcoin-core-dev
387 2020-08-12T17:01:31  *** mrostecki has joined #bitcoin-core-dev
388 2020-08-12T17:02:01  *** Guyver2__ has quit IRC
389 2020-08-12T17:05:39  <nehan> "< wumpus> this is why we need actual maintainers and not a merge-bot :-)" <-- wait wumpus isn't a bot?
390 2020-08-12T17:11:49  *** Highway62 has joined #bitcoin-core-dev
391 2020-08-12T17:12:14  *** Highway61 has quit IRC
392 2020-08-12T17:12:14  *** Highway62 is now known as Highway61
393 2020-08-12T17:14:35  *** pinheadmz has quit IRC
394 2020-08-12T17:24:40  *** PaulTroo_ has quit IRC
395 2020-08-12T17:26:19  *** EagleTM has joined #bitcoin-core-dev
396 2020-08-12T17:27:16  *** Chris_Stewart_5 has quit IRC
397 2020-08-12T17:28:44  *** Highway61 has quit IRC
398 2020-08-12T17:28:46  *** mrostecki has quit IRC
399 2020-08-12T17:29:58  *** bitcoin-git has joined #bitcoin-core-dev
400 2020-08-12T17:29:59  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bd00d3b1f203...13c4635a3ecf
401 2020-08-12T17:29:59  <bitcoin-git> bitcoin/master a51d0ad Fabian Jahr: rpc: Improve addnode remove command error message
402 2020-08-12T17:30:00  <bitcoin-git> bitcoin/master 13c4635 Wladimir J. van der Laan: Merge #19696: rpc: Fix addnode remove command error
403 2020-08-12T17:30:02  *** bitcoin-git has left #bitcoin-core-dev
404 2020-08-12T17:30:19  *** bitcoin-git has joined #bitcoin-core-dev
405 2020-08-12T17:30:19  <bitcoin-git> [bitcoin] laanwj merged pull request #19696: rpc: Fix addnode remove command error (master...rpc_net_tests) https://github.com/bitcoin/bitcoin/pull/19696
406 2020-08-12T17:30:31  *** bitcoin-git has left #bitcoin-core-dev
407 2020-08-12T17:32:08  *** arowser_ has quit IRC
408 2020-08-12T17:32:32  *** arowser_ has joined #bitcoin-core-dev
409 2020-08-12T17:33:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
410 2020-08-12T18:00:01  *** amcrae1 has quit IRC
411 2020-08-12T18:02:17  *** EagleTM has quit IRC
412 2020-08-12T18:02:53  *** sipsorcery has quit IRC
413 2020-08-12T18:06:43  *** gzhao408 has quit IRC
414 2020-08-12T18:07:58  *** Pavlenex has joined #bitcoin-core-dev
415 2020-08-12T18:12:41  *** Landryl3 has joined #bitcoin-core-dev
416 2020-08-12T18:12:57  *** Galvas_ has joined #bitcoin-core-dev
417 2020-08-12T18:13:02  *** GoldmanSats_ has joined #bitcoin-core-dev
418 2020-08-12T18:13:06  *** hsmiths_ has joined #bitcoin-core-dev
419 2020-08-12T18:13:06  *** jkczyz_ has joined #bitcoin-core-dev
420 2020-08-12T18:13:06  *** ajonas_ has joined #bitcoin-core-dev
421 2020-08-12T18:13:21  *** Pavlenex has quit IRC
422 2020-08-12T18:13:28  *** bosma_ has joined #bitcoin-core-dev
423 2020-08-12T18:20:07  *** meshcoll- has joined #bitcoin-core-dev
424 2020-08-12T18:20:35  *** thunderbiscuit[m has quit IRC
425 2020-08-12T18:20:36  *** TheFuzzStone[m] has quit IRC
426 2020-08-12T18:20:37  *** Galvas has quit IRC
427 2020-08-12T18:20:37  *** GoldmanSats has quit IRC
428 2020-08-12T18:20:37  *** meshcollider has quit IRC
429 2020-08-12T18:20:37  *** bosma has quit IRC
430 2020-08-12T18:20:37  *** hsmiths has quit IRC
431 2020-08-12T18:20:37  *** ajonas has quit IRC
432 2020-08-12T18:20:37  *** Landryl has quit IRC
433 2020-08-12T18:20:37  *** jkczyz has quit IRC
434 2020-08-12T18:20:37  *** Landryl3 is now known as Landryl
435 2020-08-12T18:20:37  *** hsmiths_ is now known as hsmiths
436 2020-08-12T18:20:37  *** jkczyz_ is now known as jkczyz
437 2020-08-12T18:20:38  *** Galvas_ is now known as Galvas
438 2020-08-12T18:20:40  *** bosma_ is now known as bosma
439 2020-08-12T18:21:39  *** icota[m] has quit IRC
440 2020-08-12T18:27:03  *** thunderbiscuit[m has joined #bitcoin-core-dev
441 2020-08-12T18:31:04  *** pinheadmz has joined #bitcoin-core-dev
442 2020-08-12T18:38:46  *** PaulTroo_ has joined #bitcoin-core-dev
443 2020-08-12T18:42:29  *** Davterra has joined #bitcoin-core-dev
444 2020-08-12T18:48:14  *** go121212 has quit IRC
445 2020-08-12T18:48:41  *** kyprizel has joined #bitcoin-core-dev
446 2020-08-12T18:49:24  *** EagleTM has joined #bitcoin-core-dev
447 2020-08-12T18:49:28  *** icota[m] has joined #bitcoin-core-dev
448 2020-08-12T18:49:29  *** TheFuzzStone[m] has joined #bitcoin-core-dev
449 2020-08-12T18:57:16  *** sipsorcery has joined #bitcoin-core-dev
450 2020-08-12T18:59:56  *** PaulTro__ has joined #bitcoin-core-dev
451 2020-08-12T19:03:06  *** PaulTroo_ has quit IRC
452 2020-08-12T19:10:10  <wumpus> nehan: shhh that's supposed to be secret
453 2020-08-12T19:25:03  <michaelfolkson> If we were going to down the road of quantifying it, it would be a reputation score for each reviewer based on various metrics e.g. bugs found in past, code reviews that led to material changes in the code other than nits, number of PRs reviewed, understanding displayed in the past on the part of the codebase they are reviewing.
454 2020-08-12T19:25:25  <michaelfolkson> Obivuosly we won't go down that road but highlights why simple ACK counts aren't sufficient
455 2020-08-12T19:31:47  *** Guyver2_ has quit IRC
456 2020-08-12T19:34:43  *** Talkless has quit IRC
457 2020-08-12T19:35:48  <michaelfolkson> The only downside to beginners posting comments about testing etc that I see is GitHub hides large swathes of comments (Marco has mentioned this before). I don't see any harm otherwise when the maintainers can just ignore them.
458 2020-08-12T19:36:54  <michaelfolkson> Assuming we all understand that one ACK can be much more valuable than another ACK
459 2020-08-12T19:37:06  *** pinheadmz has quit IRC
460 2020-08-12T19:38:45  *** T3 has joined #bitcoin-core-dev
461 2020-08-12T19:43:41  <sipa> an "expand all" button on github pages would be really useful
462 2020-08-12T19:44:03  <sipa> it's a pain to go through the history of big PRs as an author to see if you've addressed everything
463 2020-08-12T19:47:43  <michaelfolkson> Something like this https://github.com/isaacs/github/issues/1190#issuecomment-367607027
464 2020-08-12T19:48:17  <michaelfolkson> It must be a commonly requested feature
465 2020-08-12T19:52:17  <wumpus> michaelfolkson: maybe, the thing is, as soon as you quantify it, people will try to game it
466 2020-08-12T19:52:50  <michaelfolkson> It wasn't a serious suggestion. Just a thought exercise ;)
467 2020-08-12T19:53:51  <michaelfolkson> In reality the discretion of maintainers is the best option of many worse options
468 2020-08-12T19:56:02  <sipa> goodhart's law
469 2020-08-12T20:05:45  <luke-jr> sipa: at least a few times, I didn't even realise I was missing the comments :/
470 2020-08-12T20:09:45  *** owowo has quit IRC
471 2020-08-12T20:14:45  <wumpus> michaelfolkson: but yes it's annoying that github hides comments, like at some point they made the website too heavy for some browsers then they started hiding comments to compensate for that, if it was just dumb HTML there'd be no problem
472 2020-08-12T20:14:55  *** owowo has joined #bitcoin-core-dev
473 2020-08-12T20:14:55  *** owowo has joined #bitcoin-core-dev
474 2020-08-12T20:15:10  <sipa> i'm ok even with if hiding stuff by default
475 2020-08-12T20:15:22  <wumpus> or even a forum-like "page 1 of N" interface would be better than this
476 2020-08-12T20:15:26  <sipa> but clicking to expand everything can take ages
477 2020-08-12T20:16:36  <wumpus> yes, when you expand everything it becomes really slow
478 2020-08-12T20:16:59  <wumpus> there's probably 40MB of javascript running in the background
479 2020-08-12T20:17:57  *** pinheadmz has joined #bitcoin-core-dev
480 2020-08-12T20:19:06  * sipa , remembering spendong 4 hours downloading several megabytes internet explorer when he first got internet..
481 2020-08-12T20:21:42  *** meshcoll- has quit IRC
482 2020-08-12T20:22:07  *** meshcollider has joined #bitcoin-core-dev
483 2020-08-12T20:22:48  *** bitcoin-git has joined #bitcoin-core-dev
484 2020-08-12T20:22:48  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/13c4635a3ecf...038a04eb80a5
485 2020-08-12T20:22:49  <bitcoin-git> bitcoin/master c71bdf9 Hennadii Stepanov: build, test: Add support for llvm-cov
486 2020-08-12T20:22:49  <bitcoin-git> bitcoin/master 8ebc050 Hennadii Stepanov: build: Add missed fuzz_filtered.info to COVERAGE_INFO
487 2020-08-12T20:22:50  <bitcoin-git> bitcoin/master 75f9659 Hennadii Stepanov: build: Add missed fuzz.coverage/ directory to .gitignore
488 2020-08-12T20:22:59  *** bitcoin-git has left #bitcoin-core-dev
489 2020-08-12T20:23:12  *** bitcoin-git has joined #bitcoin-core-dev
490 2020-08-12T20:23:13  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19688: build: Add support for llvm-cov (master...200808-lcov) https://github.com/bitcoin/bitcoin/pull/19688
491 2020-08-12T20:23:14  *** bitcoin-git has left #bitcoin-core-dev
492 2020-08-12T20:25:26  *** mol has quit IRC
493 2020-08-12T20:26:21  *** mol has joined #bitcoin-core-dev
494 2020-08-12T20:42:03  *** PaulTro__ has quit IRC
495 2020-08-12T20:42:26  *** Davterra has quit IRC
496 2020-08-12T20:42:51  *** Davterra has joined #bitcoin-core-dev
497 2020-08-12T20:51:53  *** dergoegge has joined #bitcoin-core-dev
498 2020-08-12T20:55:03  *** proofofkeags has joined #bitcoin-core-dev
499 2020-08-12T21:00:02  *** kyprizel has quit IRC
500 2020-08-12T21:04:26  *** Mario35Carroll has joined #bitcoin-core-dev
501 2020-08-12T21:05:18  *** go1111111 has joined #bitcoin-core-dev
502 2020-08-12T21:20:09  *** kaimi1 has joined #bitcoin-core-dev
503 2020-08-12T21:32:40  *** vincenzopalazzo has quit IRC
504 2020-08-12T21:38:45  *** fox2p has quit IRC
505 2020-08-12T21:39:58  *** fox2p has joined #bitcoin-core-dev
506 2020-08-12T21:53:56  *** EagleTM has quit IRC
507 2020-08-12T22:09:36  *** tryphe has joined #bitcoin-core-dev
508 2020-08-12T22:11:56  *** lightlike has quit IRC
509 2020-08-12T22:12:39  *** Mario35Carroll has quit IRC
510 2020-08-12T22:21:34  *** mdunnio has quit IRC
511 2020-08-12T22:24:32  *** AaronvanW has joined #bitcoin-core-dev
512 2020-08-12T22:31:35  *** mrostecki has joined #bitcoin-core-dev
513 2020-08-12T22:53:03  *** proofofkeags has quit IRC
514 2020-08-12T22:53:05  *** marcoagner has quit IRC
515 2020-08-12T22:58:43  *** vasild has quit IRC
516 2020-08-12T23:00:35  *** vasild has joined #bitcoin-core-dev
517 2020-08-12T23:00:52  *** reallll is now known as belcher
518 2020-08-12T23:01:46  *** mdunnio has joined #bitcoin-core-dev
519 2020-08-12T23:06:35  *** mdunnio has quit IRC
520 2020-08-12T23:14:30  *** Highway61 has joined #bitcoin-core-dev
521 2020-08-12T23:39:43  *** Davterra has quit IRC
522 2020-08-12T23:40:44  *** T3 has quit IRC
523 2020-08-12T23:49:45  *** sipsorcery has quit IRC
524 2020-08-12T23:51:39  *** mrostecki has quit IRC
525 2020-08-12T23:52:46  <fanquake> wumpus sipa: I've also been trying to make the point to GH https://0bin.net/paste/jzVybfePdQQQgBcs#Y2Vh1PlrS2WQBeT8TRJPJPfaOlIgcsR53q1iHk+AW2l
526 2020-08-12T23:53:26  <fanquake> Obviously still not complaining loud enough