1 2020-08-13T00:00:01  *** kaimi1 has quit IRC
  2 2020-08-13T00:03:09  *** jarthur_ has joined #bitcoin-core-dev
  3 2020-08-13T00:06:16  *** jarthur has quit IRC
  4 2020-08-13T00:11:26  *** gzhao408 has joined #bitcoin-core-dev
  5 2020-08-13T00:15:26  *** gzhao408 has quit IRC
  6 2020-08-13T00:21:53  *** bitcoin-git has joined #bitcoin-core-dev
  7 2020-08-13T00:21:54  <bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/038a04eb80a5...8a85377cd0b6
  8 2020-08-13T00:21:55  <bitcoin-git> bitcoin/master 4638224 Andrew Chow: Add psbtbumpfee RPC
  9 2020-08-13T00:21:55  <bitcoin-git> bitcoin/master 431071c Andrew Chow: Hide bumpfee's psbt creation behavior behind -deprecatedrpc
 10 2020-08-13T00:21:56  <bitcoin-git> bitcoin/master 79d6332 Andrew Chow: moveonly: Fix indentation in bumpfee RPC
 11 2020-08-13T00:21:58  *** bitcoin-git has left #bitcoin-core-dev
 12 2020-08-13T00:22:05  *** RISCi_ATOM1 has joined #bitcoin-core-dev
 13 2020-08-13T00:22:52  *** bitcoin-git has joined #bitcoin-core-dev
 14 2020-08-13T00:22:52  <bitcoin-git> [bitcoin] meshcollider merged pull request #18654: rpc: separate bumpfee's psbt creation function into psbtbumpfee (master...psbtbumpfee) https://github.com/bitcoin/bitcoin/pull/18654
 15 2020-08-13T00:22:53  *** bitcoin-git has left #bitcoin-core-dev
 16 2020-08-13T00:37:35  *** ajonas_ has quit IRC
 17 2020-08-13T00:38:07  *** ajonas has joined #bitcoin-core-dev
 18 2020-08-13T00:42:28  *** mdunnio has joined #bitcoin-core-dev
 19 2020-08-13T00:50:47  *** jarthur_ has quit IRC
 20 2020-08-13T00:52:46  *** Davterra has joined #bitcoin-core-dev
 21 2020-08-13T01:11:44  *** frogar has quit IRC
 22 2020-08-13T01:12:03  *** frogar has joined #bitcoin-core-dev
 23 2020-08-13T01:21:07  *** stevenroose has quit IRC
 24 2020-08-13T01:25:05  *** stevenroose has joined #bitcoin-core-dev
 25 2020-08-13T01:34:14  *** troygiorshev has quit IRC
 26 2020-08-13T01:39:06  *** arowser_ has quit IRC
 27 2020-08-13T01:39:49  *** arowser_ has joined #bitcoin-core-dev
 28 2020-08-13T01:40:48  *** troygiorshev has joined #bitcoin-core-dev
 29 2020-08-13T01:42:37  *** mdunnio has quit IRC
 30 2020-08-13T01:44:11  *** arowser_ has quit IRC
 31 2020-08-13T01:50:42  *** arowser_ has joined #bitcoin-core-dev
 32 2020-08-13T02:03:10  *** arowser_ has quit IRC
 33 2020-08-13T02:04:21  *** arowser_ has joined #bitcoin-core-dev
 34 2020-08-13T02:10:54  *** arowser_ has quit IRC
 35 2020-08-13T02:11:11  *** watersnake1 has joined #bitcoin-core-dev
 36 2020-08-13T02:14:35  *** arowser_ has joined #bitcoin-core-dev
 37 2020-08-13T02:17:51  *** watersnake1 has quit IRC
 38 2020-08-13T02:18:20  *** watersnake1 has joined #bitcoin-core-dev
 39 2020-08-13T02:19:56  *** mdunnio has joined #bitcoin-core-dev
 40 2020-08-13T02:21:14  *** watersnake1 has quit IRC
 41 2020-08-13T02:24:52  *** mdunnio has quit IRC
 42 2020-08-13T02:24:57  *** AaronvanW has quit IRC
 43 2020-08-13T02:26:59  *** arowser_ has quit IRC
 44 2020-08-13T02:39:17  *** arowser_ has joined #bitcoin-core-dev
 45 2020-08-13T02:49:10  *** bitdex has joined #bitcoin-core-dev
 46 2020-08-13T02:58:08  *** AaronvanW has joined #bitcoin-core-dev
 47 2020-08-13T03:00:02  *** RISCi_ATOM1 has quit IRC
 48 2020-08-13T03:02:35  *** AaronvanW has quit IRC
 49 2020-08-13T03:12:13  *** arowser_ has quit IRC
 50 2020-08-13T03:12:33  *** arowser_ has joined #bitcoin-core-dev
 51 2020-08-13T03:16:50  *** Highway61 has quit IRC
 52 2020-08-13T03:17:16  *** Highway61 has joined #bitcoin-core-dev
 53 2020-08-13T03:19:26  *** justanotheruser has quit IRC
 54 2020-08-13T03:21:34  *** mdrjr1 has joined #bitcoin-core-dev
 55 2020-08-13T03:41:25  *** troygiorshev has quit IRC
 56 2020-08-13T03:43:38  *** Highway61 has quit IRC
 57 2020-08-13T03:46:24  *** arowser_ has quit IRC
 58 2020-08-13T03:46:38  *** justanotheruser has joined #bitcoin-core-dev
 59 2020-08-13T03:52:57  *** arowser_ has joined #bitcoin-core-dev
 60 2020-08-13T04:18:25  *** jarthur has joined #bitcoin-core-dev
 61 2020-08-13T04:27:09  *** jarthur has quit IRC
 62 2020-08-13T04:43:20  *** AaronvanW has joined #bitcoin-core-dev
 63 2020-08-13T04:46:25  *** PaulTroo_ has joined #bitcoin-core-dev
 64 2020-08-13T04:51:00  *** PaulTroo_ has quit IRC
 65 2020-08-13T04:59:46  *** waldoirc has joined #bitcoin-core-dev
 66 2020-08-13T05:05:06  *** shesek has quit IRC
 67 2020-08-13T05:09:25  *** davec has quit IRC
 68 2020-08-13T05:12:11  *** Mercury_Vapor has quit IRC
 69 2020-08-13T05:16:43  *** AaronvanW has quit IRC
 70 2020-08-13T05:28:46  *** mdunnio has joined #bitcoin-core-dev
 71 2020-08-13T05:29:12  *** EagleTM has joined #bitcoin-core-dev
 72 2020-08-13T05:33:35  *** mdunnio has quit IRC
 73 2020-08-13T05:34:51  *** T3 has joined #bitcoin-core-dev
 74 2020-08-13T05:39:44  <wumpus> fanquake: thanks
 75 2020-08-13T05:44:12  *** arowser_ has quit IRC
 76 2020-08-13T05:44:29  *** arowser_ has joined #bitcoin-core-dev
 77 2020-08-13T06:00:01  *** mdrjr1 has quit IRC
 78 2020-08-13T06:00:48  *** proofofkeags has joined #bitcoin-core-dev
 79 2020-08-13T06:05:14  *** arowser_ has quit IRC
 80 2020-08-13T06:05:33  *** arowser_ has joined #bitcoin-core-dev
 81 2020-08-13T06:20:07  *** directhex1 has joined #bitcoin-core-dev
 82 2020-08-13T06:24:10  *** arowser_ has quit IRC
 83 2020-08-13T06:24:29  *** arowser_ has joined #bitcoin-core-dev
 84 2020-08-13T06:28:29  *** AaronvanW has joined #bitcoin-core-dev
 85 2020-08-13T06:33:13  *** PaulTroo_ has joined #bitcoin-core-dev
 86 2020-08-13T06:38:25  *** Mercury_Vapor has joined #bitcoin-core-dev
 87 2020-08-13T06:38:27  *** sipsorcery has joined #bitcoin-core-dev
 88 2020-08-13T06:53:14  *** trash_mapache has joined #bitcoin-core-dev
 89 2020-08-13T06:54:07  *** Talkless has joined #bitcoin-core-dev
 90 2020-08-13T07:00:41  *** AaronvanW has quit IRC
 91 2020-08-13T07:01:14  *** marcoagner has joined #bitcoin-core-dev
 92 2020-08-13T07:02:08  *** bitcoin-git has joined #bitcoin-core-dev
 93 2020-08-13T07:02:09  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19707: net: Remove unused conn_type default arg in OpenNetworkConnection (master...1908-netDefault) https://github.com/bitcoin/bitcoin/pull/19707
 94 2020-08-13T07:02:10  *** bitcoin-git has left #bitcoin-core-dev
 95 2020-08-13T07:09:01  *** trash_mapache has quit IRC
 96 2020-08-13T07:13:17  *** andreacab has joined #bitcoin-core-dev
 97 2020-08-13T07:13:44  *** bitcoin-git has joined #bitcoin-core-dev
 98 2020-08-13T07:13:44  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16548: Make the global flag *fDiscover* an instance variable of CConnman (master...bitcoin_issue_14210) https://github.com/bitcoin/bitcoin/pull/16548
 99 2020-08-13T07:13:45  *** bitcoin-git has left #bitcoin-core-dev
100 2020-08-13T07:14:38  *** andreacab has quit IRC
101 2020-08-13T07:15:00  *** proofofkeags has quit IRC
102 2020-08-13T07:15:28  *** bitcoin-git has joined #bitcoin-core-dev
103 2020-08-13T07:15:28  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13360: [Policy] Reject SIGHASH_SINGLE with output out of bound (master...insecure_single) https://github.com/bitcoin/bitcoin/pull/13360
104 2020-08-13T07:15:29  *** bitcoin-git has left #bitcoin-core-dev
105 2020-08-13T07:25:53  *** jonatack has quit IRC
106 2020-08-13T07:33:12  *** arowser_ has quit IRC
107 2020-08-13T07:33:40  *** arowser_ has joined #bitcoin-core-dev
108 2020-08-13T07:36:56  *** davec has joined #bitcoin-core-dev
109 2020-08-13T07:39:53  *** Davterra has quit IRC
110 2020-08-13T07:40:26  *** Davterra has joined #bitcoin-core-dev
111 2020-08-13T07:44:13  *** vincenzopalazzo has joined #bitcoin-core-dev
112 2020-08-13T07:50:03  *** ghost43_ has quit IRC
113 2020-08-13T07:51:08  *** ghost43 has joined #bitcoin-core-dev
114 2020-08-13T08:07:58  *** jonatack has joined #bitcoin-core-dev
115 2020-08-13T08:16:13  *** AaronvanW has joined #bitcoin-core-dev
116 2020-08-13T08:30:49  *** arowser_ has quit IRC
117 2020-08-13T08:37:48  *** arowser_ has joined #bitcoin-core-dev
118 2020-08-13T08:39:10  *** bitcoin-git has joined #bitcoin-core-dev
119 2020-08-13T08:39:10  <bitcoin-git> [bitcoin] jonasschnelli pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/8a85377cd0b6...1052b09031c6
120 2020-08-13T08:39:11  <bitcoin-git> bitcoin/master 25e1d0b Jonas Schnelli: RPCConsole, take initial chaintip data as parameter
121 2020-08-13T08:39:11  <bitcoin-git> bitcoin/master b354a14 Jonas Schnelli: Add BlockAndHeaderTipInfo to the node interface/appInit
122 2020-08-13T08:39:12  <bitcoin-git> bitcoin/master d42cb79 Jonas Schnelli: Optionally populate BlockAndHeaderTipInfo during AppInitMain
123 2020-08-13T08:39:13  *** bitcoin-git has left #bitcoin-core-dev
124 2020-08-13T08:40:00  *** bitcoin-git has joined #bitcoin-core-dev
125 2020-08-13T08:40:00  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #19011: Reduce cs_main lock accumulation during GUI startup (master...2020/05/guilocks) https://github.com/bitcoin/bitcoin/pull/19011
126 2020-08-13T08:40:01  *** bitcoin-git has left #bitcoin-core-dev
127 2020-08-13T08:40:13  *** arowser_ has quit IRC
128 2020-08-13T08:40:33  *** arowser_ has joined #bitcoin-core-dev
129 2020-08-13T08:41:16  *** arowser_ has quit IRC
130 2020-08-13T08:41:43  *** arowser_ has joined #bitcoin-core-dev
131 2020-08-13T08:43:13  *** proofofkeags has joined #bitcoin-core-dev
132 2020-08-13T08:48:35  *** proofofkeags has quit IRC
133 2020-08-13T09:00:01  *** directhex1 has quit IRC
134 2020-08-13T09:18:50  *** AaronvanW has quit IRC
135 2020-08-13T09:32:00  *** proofofkeags has joined #bitcoin-core-dev
136 2020-08-13T09:34:19  *** AaronvanW has joined #bitcoin-core-dev
137 2020-08-13T09:34:59  *** Davterra has quit IRC
138 2020-08-13T09:35:56  *** Davterra has joined #bitcoin-core-dev
139 2020-08-13T09:40:38  *** proofofkeags has quit IRC
140 2020-08-13T09:44:29  *** jonatack has quit IRC
141 2020-08-13T09:48:55  *** belcher has quit IRC
142 2020-08-13T09:49:01  *** belcher_ has joined #bitcoin-core-dev
143 2020-08-13T09:49:38  *** Davterra has quit IRC
144 2020-08-13T09:50:42  *** Davterra has joined #bitcoin-core-dev
145 2020-08-13T09:54:53  *** vBm1 has joined #bitcoin-core-dev
146 2020-08-13T10:03:20  *** Phoebe89Zulauf has joined #bitcoin-core-dev
147 2020-08-13T10:08:19  *** luke-jr has quit IRC
148 2020-08-13T10:10:41  *** luke-jr has joined #bitcoin-core-dev
149 2020-08-13T10:10:55  *** Phoebe89Zulauf has quit IRC
150 2020-08-13T10:13:41  *** bitcoin-git has joined #bitcoin-core-dev
151 2020-08-13T10:13:42  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1052b09031c6...6757b3ac8f67
152 2020-08-13T10:13:42  <bitcoin-git> bitcoin/master c133cdc Adam Stein: Cap listsinceblock target_confirmations param
153 2020-08-13T10:13:43  <bitcoin-git> bitcoin/master 6757b3a Wladimir J. van der Laan: Merge #19655: rpc: Catch listsinceblock target_confirmations exceeding blo...
154 2020-08-13T10:13:44  *** bitcoin-git has left #bitcoin-core-dev
155 2020-08-13T10:14:01  *** bitcoin-git has joined #bitcoin-core-dev
156 2020-08-13T10:14:02  <bitcoin-git> [bitcoin] laanwj merged pull request #19655: rpc: Catch listsinceblock target_confirmations exceeding block count (master...listsinceblock_rpc) https://github.com/bitcoin/bitcoin/pull/19655
157 2020-08-13T10:14:04  *** bitcoin-git has left #bitcoin-core-dev
158 2020-08-13T10:33:40  *** proofofkeags has joined #bitcoin-core-dev
159 2020-08-13T10:38:59  *** proofofkeags has quit IRC
160 2020-08-13T10:40:05  *** jonatack has joined #bitcoin-core-dev
161 2020-08-13T10:41:00  *** T3 has quit IRC
162 2020-08-13T10:41:17  *** T3 has joined #bitcoin-core-dev
163 2020-08-13T10:42:29  *** Pavlenex has joined #bitcoin-core-dev
164 2020-08-13T10:44:21  *** Pavlenex has quit IRC
165 2020-08-13T10:50:58  *** Pavlenex has joined #bitcoin-core-dev
166 2020-08-13T10:54:45  *** Davterra has quit IRC
167 2020-08-13T10:55:44  *** vasild_ has joined #bitcoin-core-dev
168 2020-08-13T10:55:45  *** Davterra has joined #bitcoin-core-dev
169 2020-08-13T10:58:43  *** vasild has quit IRC
170 2020-08-13T10:58:44  *** vasild_ is now known as vasild
171 2020-08-13T11:02:10  *** mrostecki has joined #bitcoin-core-dev
172 2020-08-13T11:14:20  *** shesek has joined #bitcoin-core-dev
173 2020-08-13T11:14:20  *** shesek has joined #bitcoin-core-dev
174 2020-08-13T11:26:02  *** troygiorshev has joined #bitcoin-core-dev
175 2020-08-13T11:26:03  *** sipsorcery has quit IRC
176 2020-08-13T11:34:26  *** bitcoin-git has joined #bitcoin-core-dev
177 2020-08-13T11:34:27  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #19707: net: Remove unused conn_type default arg in OpenNetworkConnection (master...1908-netDefault) https://github.com/bitcoin/bitcoin/pull/19707
178 2020-08-13T11:34:27  *** bitcoin-git has left #bitcoin-core-dev
179 2020-08-13T11:42:11  *** arowser_ has quit IRC
180 2020-08-13T11:42:30  *** arowser_ has joined #bitcoin-core-dev
181 2020-08-13T11:52:27  *** vBm1 has quit IRC
182 2020-08-13T11:55:35  *** troygiorshev has quit IRC
183 2020-08-13T11:55:51  *** troygiorshev has joined #bitcoin-core-dev
184 2020-08-13T11:56:17  *** arowser_ has quit IRC
185 2020-08-13T11:57:31  *** sipsorcery has joined #bitcoin-core-dev
186 2020-08-13T11:58:26  *** arowser_ has joined #bitcoin-core-dev
187 2020-08-13T12:09:44  *** Davterra has quit IRC
188 2020-08-13T12:09:56  *** Davterra has joined #bitcoin-core-dev
189 2020-08-13T12:20:16  *** tadeo has joined #bitcoin-core-dev
190 2020-08-13T12:20:39  *** proofofkeags has joined #bitcoin-core-dev
191 2020-08-13T12:24:48  *** Davterra has quit IRC
192 2020-08-13T12:25:08  *** arowser_ has quit IRC
193 2020-08-13T12:25:28  *** proofofkeags has quit IRC
194 2020-08-13T12:25:43  *** Davterra has joined #bitcoin-core-dev
195 2020-08-13T12:27:03  *** arowser_ has joined #bitcoin-core-dev
196 2020-08-13T12:31:10  *** face has joined #bitcoin-core-dev
197 2020-08-13T12:33:38  *** sipsorcery has quit IRC
198 2020-08-13T12:35:01  *** Davterra has quit IRC
199 2020-08-13T12:35:56  *** Davterra has joined #bitcoin-core-dev
200 2020-08-13T12:42:33  *** Guyver2 has joined #bitcoin-core-dev
201 2020-08-13T12:44:23  *** Davterra has quit IRC
202 2020-08-13T12:45:01  *** Davterra has joined #bitcoin-core-dev
203 2020-08-13T12:49:03  *** mrostecki has quit IRC
204 2020-08-13T12:50:16  *** sipsorcery has joined #bitcoin-core-dev
205 2020-08-13T13:00:05  *** Davterra has quit IRC
206 2020-08-13T13:00:25  *** Highway61 has joined #bitcoin-core-dev
207 2020-08-13T13:00:52  *** Davterra has joined #bitcoin-core-dev
208 2020-08-13T13:06:22  *** arowser_ has quit IRC
209 2020-08-13T13:06:50  *** arowser_ has joined #bitcoin-core-dev
210 2020-08-13T13:07:13  *** arowser_ has quit IRC
211 2020-08-13T13:07:33  *** arowser_ has joined #bitcoin-core-dev
212 2020-08-13T13:08:17  *** arowser_ has quit IRC
213 2020-08-13T13:08:45  *** arowser_ has joined #bitcoin-core-dev
214 2020-08-13T13:09:05  *** MDrollette has quit IRC
215 2020-08-13T13:09:15  *** arowser_ has quit IRC
216 2020-08-13T13:14:17  *** mdrollette has joined #bitcoin-core-dev
217 2020-08-13T13:15:18  *** arowser_ has joined #bitcoin-core-dev
218 2020-08-13T13:16:04  *** proofofkeags has joined #bitcoin-core-dev
219 2020-08-13T13:18:44  *** shesek has quit IRC
220 2020-08-13T13:21:22  *** gzhao408 has joined #bitcoin-core-dev
221 2020-08-13T13:23:16  *** Guyver2_ has joined #bitcoin-core-dev
222 2020-08-13T13:23:35  *** EagleTM has quit IRC
223 2020-08-13T13:26:20  *** Guyver2 has quit IRC
224 2020-08-13T13:31:15  *** bitcoin-git has joined #bitcoin-core-dev
225 2020-08-13T13:31:15  <bitcoin-git> [bitcoin] hebasto opened pull request #19709: test: Fix 'make cov' with clang (master...200813-lcov) https://github.com/bitcoin/bitcoin/pull/19709
226 2020-08-13T13:31:16  *** bitcoin-git has left #bitcoin-core-dev
227 2020-08-13T13:37:48  *** luke-jr has quit IRC
228 2020-08-13T13:38:10  *** luke-jr has joined #bitcoin-core-dev
229 2020-08-13T13:44:28  *** proofofkeags has quit IRC
230 2020-08-13T13:44:43  *** proofofkeags has joined #bitcoin-core-dev
231 2020-08-13T13:45:05  *** bitdex_ has joined #bitcoin-core-dev
232 2020-08-13T13:45:18  *** bitcoin-git has joined #bitcoin-core-dev
233 2020-08-13T13:45:19  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/6757b3ac8f67...b4d0366b47dd
234 2020-08-13T13:45:20  <bitcoin-git> bitcoin/master b3fbc94 John Newbery: Apply cfilters review fixups
235 2020-08-13T13:45:21  <bitcoin-git> bitcoin/master 132b30d Jim Posen: [net] Signal NODE_COMPACT_FILTERS if we're serving compact filters.
236 2020-08-13T13:45:22  <bitcoin-git> bitcoin/master f5c003d Jim Posen: [test] Add test for NODE_COMPACT_FILTER.
237 2020-08-13T13:45:24  *** bitcoin-git has left #bitcoin-core-dev
238 2020-08-13T13:46:03  *** bitcoin-git has joined #bitcoin-core-dev
239 2020-08-13T13:46:03  <bitcoin-git> [bitcoin] laanwj merged pull request #19070: p2p: Signal support for compact block filters with NODE_COMPACT_FILTERS (master...2020-05-node-compact-filters) https://github.com/bitcoin/bitcoin/pull/19070
240 2020-08-13T13:46:04  *** bitcoin-git has left #bitcoin-core-dev
241 2020-08-13T13:48:03  *** bitdex has quit IRC
242 2020-08-13T13:51:18  *** mrostecki has joined #bitcoin-core-dev
243 2020-08-13T13:55:01  *** mdunnio has joined #bitcoin-core-dev
244 2020-08-13T13:59:25  *** vincenzopalazzo has quit IRC
245 2020-08-13T14:12:20  *** arowser_ has quit IRC
246 2020-08-13T14:12:49  *** arowser_ has joined #bitcoin-core-dev
247 2020-08-13T14:14:52  *** vincenzopalazzo has joined #bitcoin-core-dev
248 2020-08-13T14:15:32  *** bitdex_ has quit IRC
249 2020-08-13T14:18:16  *** mrostecki has quit IRC
250 2020-08-13T14:23:25  *** EagleTM has joined #bitcoin-core-dev
251 2020-08-13T14:26:20  *** bitcoin-git has joined #bitcoin-core-dev
252 2020-08-13T14:26:21  <bitcoin-git> [bitcoin] hebasto opened pull request #19710: bench: Prevent thread oversubscription and decreases the variance of result values (master...200813-var) https://github.com/bitcoin/bitcoin/pull/19710
253 2020-08-13T14:26:22  *** bitcoin-git has left #bitcoin-core-dev
254 2020-08-13T14:27:36  *** bitcoin-git has joined #bitcoin-core-dev
255 2020-08-13T14:27:36  <bitcoin-git> [bitcoin] jnewbery closed pull request #18876: [WIP] Serve BIP 157 compact filters (master...pr16442.3) https://github.com/bitcoin/bitcoin/pull/18876
256 2020-08-13T14:27:47  *** bitcoin-git has left #bitcoin-core-dev
257 2020-08-13T14:32:37  *** arowser_ has quit IRC
258 2020-08-13T14:33:39  *** Davterra has quit IRC
259 2020-08-13T14:33:57  *** arowser_ has joined #bitcoin-core-dev
260 2020-08-13T14:38:00  *** bizmindx has joined #bitcoin-core-dev
261 2020-08-13T14:53:29  *** nickbtc63 has joined #bitcoin-core-dev
262 2020-08-13T14:57:37  *** nickbtc63 has quit IRC
263 2020-08-13T14:59:26  *** arowser_ has quit IRC
264 2020-08-13T14:59:45  *** arowser_ has joined #bitcoin-core-dev
265 2020-08-13T15:00:02  *** tadeo has quit IRC
266 2020-08-13T15:00:34  *** bizmindx has quit IRC
267 2020-08-13T15:01:12  *** platesondeck has joined #bitcoin-core-dev
268 2020-08-13T15:04:51  *** platesondeck has quit IRC
269 2020-08-13T15:05:00  *** palazzovincenzo has joined #bitcoin-core-dev
270 2020-08-13T15:07:23  *** vincenzopalazzo has quit IRC
271 2020-08-13T15:09:09  *** proofofkeags has quit IRC
272 2020-08-13T15:16:46  *** dviola has quit IRC
273 2020-08-13T15:17:34  *** dviola has joined #bitcoin-core-dev
274 2020-08-13T15:17:47  *** proofofkeags has joined #bitcoin-core-dev
275 2020-08-13T15:18:38  *** waldoirc_ has joined #bitcoin-core-dev
276 2020-08-13T15:19:01  *** waldoirc_ has joined #bitcoin-core-dev
277 2020-08-13T15:19:29  *** waldoirc_ has joined #bitcoin-core-dev
278 2020-08-13T15:19:55  *** waldoirc_ has joined #bitcoin-core-dev
279 2020-08-13T15:20:22  *** waldoirc_ has joined #bitcoin-core-dev
280 2020-08-13T15:21:45  *** waldoirc has quit IRC
281 2020-08-13T15:22:24  *** pav5088 has joined #bitcoin-core-dev
282 2020-08-13T15:22:48  <fjahr> #19528 seems RFM
283 2020-08-13T15:22:50  <gribble> https://github.com/bitcoin/bitcoin/issues/19528 | rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc) by MarcoFalke · Pull Request #19528 · bitcoin/bitcoin · GitHub
284 2020-08-13T15:27:02  *** proofofkeags has quit IRC
285 2020-08-13T15:59:55  *** Pavlenex has quit IRC
286 2020-08-13T16:04:27  *** Pavlenex has joined #bitcoin-core-dev
287 2020-08-13T16:12:24  *** arowser_ has quit IRC
288 2020-08-13T16:12:52  *** arowser_ has joined #bitcoin-core-dev
289 2020-08-13T16:16:32  *** Davterra has joined #bitcoin-core-dev
290 2020-08-13T16:19:33  *** bitcoin-git has joined #bitcoin-core-dev
291 2020-08-13T16:19:34  <bitcoin-git> [bitcoin] hebasto closed pull request #19064: refactor: Cleanup thread ctor calls (master...200524-bind) https://github.com/bitcoin/bitcoin/pull/19064
292 2020-08-13T16:19:35  *** bitcoin-git has left #bitcoin-core-dev
293 2020-08-13T16:19:54  *** bitcoin-git has joined #bitcoin-core-dev
294 2020-08-13T16:19:54  <bitcoin-git> [bitcoin] hebasto reopened pull request #19064: refactor: Cleanup thread ctor calls (master...200524-bind) https://github.com/bitcoin/bitcoin/pull/19064
295 2020-08-13T16:19:55  *** bitcoin-git has left #bitcoin-core-dev
296 2020-08-13T16:22:58  *** alko89 has quit IRC
297 2020-08-13T16:24:39  <fjahr> re loading all GH comments: I remember having that discussion here as well back then (probably when fanquake made the comment). There is a browser extension that offers that functionality and it worked well but seemed stupid to keep it just for that and some of the other functionality is annoying: https://github.com/sindresorhus/refined-github
298 2020-08-13T16:24:45  <fjahr> If you are really desperate you may paste this into your js console: https://gist.github.com/fjahr/bfaf119dddae37c490a4949e956b3b7a It works for me.
299 2020-08-13T16:26:23  <achow101> there's no way to turn off the annoying features?
300 2020-08-13T16:27:40  <luke-jr> I wonder if there's a non-browser GH open source app
301 2020-08-13T16:27:52  <fjahr> achow101: i didn't look into it that deeply but maybe (https://github.com/sindresorhus/refined-github#customization). I just try to keep my use of extensions at a minimum.
302 2020-08-13T16:28:01  <luke-jr> maybe it could even work with GitLab too so someday we can get off GitHub :P
303 2020-08-13T16:28:51  <achow101> luke-jr: there's a github android app now. I don't know if it's open source
304 2020-08-13T16:29:47  <luke-jr> I mean Qt or such
305 2020-08-13T16:29:47  <achow101> fjahr: seems like you can turn on and off features
306 2020-08-13T16:30:39  <achow101> luke-jr: they have an open source desktop app for windows and mac
307 2020-08-13T16:30:52  <achow101> electron based though, so bleh
308 2020-08-13T16:31:05  <fjahr> achow101: yeah, I don't remember seeing that, so maybe worth another try
309 2020-08-13T16:34:09  *** proofofkeags has joined #bitcoin-core-dev
310 2020-08-13T16:35:12  *** proofofkeags has quit IRC
311 2020-08-13T16:36:43  <luke-jr> achow101: that's just a browser wrapper afaik
312 2020-08-13T16:39:25  *** sipsorcery has quit IRC
313 2020-08-13T16:42:19  *** alko89 has joined #bitcoin-core-dev
314 2020-08-13T16:43:39  *** PaulTroo_ has quit IRC
315 2020-08-13T16:44:16  *** sipsorcery has joined #bitcoin-core-dev
316 2020-08-13T16:46:42  *** shesek has joined #bitcoin-core-dev
317 2020-08-13T16:46:42  *** shesek has quit IRC
318 2020-08-13T16:46:42  *** shesek has joined #bitcoin-core-dev
319 2020-08-13T16:53:08  *** mr_burdell_ has joined #bitcoin-core-dev
320 2020-08-13T16:53:15  *** PaulTroo_ has joined #bitcoin-core-dev
321 2020-08-13T16:53:17  *** mr_burdell has quit IRC
322 2020-08-13T17:11:42  *** justanotheruser has quit IRC
323 2020-08-13T17:26:35  *** Talkless has quit IRC
324 2020-08-13T17:27:30  *** Talkless has joined #bitcoin-core-dev
325 2020-08-13T17:28:06  *** justanotheruser has joined #bitcoin-core-dev
326 2020-08-13T17:50:18  *** Highway62 has joined #bitcoin-core-dev
327 2020-08-13T17:50:40  *** Highway61 has quit IRC
328 2020-08-13T17:50:40  *** Highway62 is now known as Highway61
329 2020-08-13T17:52:06  *** bitcoin-git has joined #bitcoin-core-dev
330 2020-08-13T17:52:07  <bitcoin-git> [bitcoin] Crypt-iQ opened pull request #19713: fuzz: fix -fsanitize=integer complaints (master...fuzz_supp_0813) https://github.com/bitcoin/bitcoin/pull/19713
331 2020-08-13T17:52:08  *** bitcoin-git has left #bitcoin-core-dev
332 2020-08-13T17:52:22  <jeremyrubin> btw interesting article for the rust folks https://people.gnome.org/~federico/blog/rust-stable-abi.html
333 2020-08-13T17:53:18  <jeremyrubin> elichai2: luke-jr michaelfolkson
334 2020-08-13T17:55:16  *** lightlike has joined #bitcoin-core-dev
335 2020-08-13T18:00:02  *** pav5088 has quit IRC
336 2020-08-13T18:05:11  *** mdunnio has quit IRC
337 2020-08-13T18:08:12  <luke-jr> jeremyrubin: tl;dr: no solutions
338 2020-08-13T18:08:54  *** mol_ has joined #bitcoin-core-dev
339 2020-08-13T18:11:56  *** mol has quit IRC
340 2020-08-13T18:14:38  *** dviola has left #bitcoin-core-dev
341 2020-08-13T18:15:01  *** dviola has joined #bitcoin-core-dev
342 2020-08-13T18:17:16  *** mdunnio has joined #bitcoin-core-dev
343 2020-08-13T18:21:23  *** [RuCTFE]tswr has joined #bitcoin-core-dev
344 2020-08-13T18:47:47  <michaelfolkson> tl;dr Rust does not have a stable ABI
345 2020-08-13T18:49:12  <michaelfolkson> .. but we can override this
346 2020-08-13T18:49:18  <luke-jr> frankly it'd probably be good enough if they simply limit ABI breakage to minor (major?) version bumps
347 2020-08-13T18:49:27  <luke-jr> so you could dynamic link stuff so long as you kept the same compiler
348 2020-08-13T18:49:41  <luke-jr> michaelfolkson: having to annotate every interface in code isn't a solution
349 2020-08-13T18:50:09  <luke-jr> especially when it's losing features (eg, Rust's decision to sort fields a certain optimal way)
350 2020-08-13T18:51:31  <luke-jr> the template/generic point does seem fundamentally unsolvable, though
351 2020-08-13T18:53:30  <luke-jr> a real world point on the topic: it's frustrating when Chromium releases new security fixes, and I have to forego having a browser for 48 hours while the entire thing recompiles.. if it was using proper shared libraries, I could just rebuild the affected one(s) and go.
352 2020-08-13T18:54:03  <luke-jr> (Chromium isn't Rust, but this is a static compiling/linking issue, not a Rust issue specifically)
353 2020-08-13T18:57:16  *** chjj has quit IRC
354 2020-08-13T18:58:37  *** chjj has joined #bitcoin-core-dev
355 2020-08-13T19:00:07  <wumpus> #startmeeting
356 2020-08-13T19:00:07  <lightningbot> Meeting started Thu Aug 13 19:00:07 2020 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
357 2020-08-13T19:00:07  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
358 2020-08-13T19:00:11  <jnewbery> hi
359 2020-08-13T19:00:18  <jonasschnelli> Hi
360 2020-08-13T19:00:19  <troygiorshev> hi
361 2020-08-13T19:00:20  <hebasto> hi
362 2020-08-13T19:00:36  <luke-jr> hi
363 2020-08-13T19:00:42  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
364 2020-08-13T19:00:44  <wumpus> amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2
365 2020-08-13T19:00:51  <sipsorcery> hi
366 2020-08-13T19:00:55  <achow101> hi
367 2020-08-13T19:00:59  <jamesob> hi
368 2020-08-13T19:01:06  <aj> hi
369 2020-08-13T19:01:09  <fjahr> hi
370 2020-08-13T19:01:11  <wumpus> one proposed topic in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt: Can we recreate bitcoin-core/gui (Luke-jr)
371 2020-08-13T19:01:19  <wumpus> any last minute topic proposals?
372 2020-08-13T19:01:33  <jeremyrubin> hi
373 2020-08-13T19:01:37  <ajonas> hi
374 2020-08-13T19:01:43  <sipa> hi
375 2020-08-13T19:02:15  <wumpus> #topic High priority for review
376 2020-08-13T19:02:31  <wumpus> https://github.com/bitcoin/bitcoin/projects/8   10 blockers, 1 bugfix, 3 chasing conept
377 2020-08-13T19:02:44  <jonatack> hi
378 2020-08-13T19:02:55  <wumpus> anything to add/remove or that is probably ready for merge?
379 2020-08-13T19:03:03  <luke-jr> …
380 2020-08-13T19:03:27  <jonatack> i'd like to nominate #19628 for blockers
381 2020-08-13T19:03:29  <gribble> https://github.com/bitcoin/bitcoin/issues/19628 | net: change CNetAddr::ip to have flexible size by vasild · Pull Request #19628 · bitcoin/bitcoin · GitHub
382 2020-08-13T19:03:32  <wumpus> luke-jr: ?
383 2020-08-13T19:04:08  *** luke-jr has quit IRC
384 2020-08-13T19:04:29  *** luke-jr has joined #bitcoin-core-dev
385 2020-08-13T19:04:36  <wumpus> jonatack: added
386 2020-08-13T19:05:28  <jnewbery> #11082 is the only one that needs rebase. There was discussion last week about whether it was even needed anymore now that we have the settings file
387 2020-08-13T19:05:30  <gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
388 2020-08-13T19:06:05  <wumpus> let's remove it for now
389 2020-08-13T19:06:57  *** Pavlenex has quit IRC
390 2020-08-13T19:07:04  <wumpus> I see the other ones were rebased, great
391 2020-08-13T19:08:09  <wumpus> ok, that concludes the topic if no one else has suggestions
392 2020-08-13T19:08:46  <wumpus> #topic Can we recreate bitcoin-core/gui (Luke-jr)
393 2020-08-13T19:09:08  *** Highway62 has joined #bitcoin-core-dev
394 2020-08-13T19:09:10  *** Highway61 has quit IRC
395 2020-08-13T19:09:11  *** Highway62 is now known as Highway61
396 2020-08-13T19:09:11  <luke-jr> sorry, my IRC flaked out (I saw nothing for 5 minutes)
397 2020-08-13T19:09:12  <wumpus> I'd personally rather not, just now that all kinds of issues and PRs were moved there
398 2020-08-13T19:09:49  <jeremyrubin> To be clear
399 2020-08-13T19:09:53  <jeremyrubin> This is for a repo
400 2020-08-13T19:09:56  <michaelfolkson> What was the motivation for wanting this? Sorry missing context
401 2020-08-13T19:10:01  *** kristapsk has joined #bitcoin-core-dev
402 2020-08-13T19:10:02  <jeremyrubin> not for the actual QT impl
403 2020-08-13T19:10:22  *** luke-jr_ has joined #bitcoin-core-dev
404 2020-08-13T19:10:24  <luke-jr_> Can we recreate bitcoin-core/gui so GitHub will let us do PRs from the same <user>/bitcoin forks instead of making a new remote for everyone?
405 2020-08-13T19:10:24  <wumpus> he wants to inherit it from bitcoin/bitcoin I think instead of having it as completely disparate repo
406 2020-08-13T19:10:29  <luke-jr_> Or Maybe our contacts at GitHub can just link it?
407 2020-08-13T19:10:30  <wumpus> I'm not convinced
408 2020-08-13T19:10:46  <luke-jr_> As things are, every dev needs to create a new fork to make PRs on it
409 2020-08-13T19:11:08  <achow101> I'm not sure that's possible by ourselves
410 2020-08-13T19:11:12  <wumpus> yes, that is true, though if they drift further apart in the future, that's what you'll need to do anyway
411 2020-08-13T19:11:26  <achow101> we may need to ask github support to do that
412 2020-08-13T19:11:27  <luke-jr_> achow101: we could delete, refork, and rename; but probably better if GitHub just links it
413 2020-08-13T19:11:30  <hebasto> hope, that gui repo would be interested for just created designers community.
414 2020-08-13T19:11:39  <jeremyrubin> michaelfolkson: I think it was to allow more focus on the gui work in the gui subrepo
415 2020-08-13T19:11:48  <jnewbery> wumpus: if you push a branch to <developer>/bitcoin , then you can't open a PR against bitcoin-core/gui because they don't share a common fork in gitub
416 2020-08-13T19:12:01  <wumpus> right now they're basically the same, but it's not clear that will always be the case, e.g. after process separation there might be repo separation as well
417 2020-08-13T19:12:02  <jeremyrubin> oops I hit enter late XD
418 2020-08-13T19:12:13  <jnewbery> if we delete bitcoin-core/gui and then recreate it as a fork of bitcoin/bitcoin, you'd be able to
419 2020-08-13T19:12:27  <luke-jr_> I suppose if the thought is to remove core code from /gui, and remove GUI from the core codebase, then it makes sense to leave it alone..
420 2020-08-13T19:12:31  <wumpus> then again if a lot of people feel like it would be easier if it's a bitcoin/bitcoin fork we could try asking github
421 2020-08-13T19:12:37  <jonatack> I agree that it's annoying friction, and things seems quiet in GUI-land.
422 2020-08-13T19:13:10  <luke-jr_> but I think we've been planning that for years, and progress is slow
423 2020-08-13T19:13:16  <wumpus> deleting the repo right now sounds like a bad plan to me, just now that eerything was set up there
424 2020-08-13T19:13:45  <wumpus> might as well move things back to the main repo and delete it and give up on the idea then
425 2020-08-13T19:13:56  <luke-jr_> also, while it used to be possible to have multiple forks under the same org (so bitcoin-core/gui and bitcoin-core/foobar), GitHub seems to have removed that possibility too
426 2020-08-13T19:14:07  <jnewbery> wumpus: I don't think so
427 2020-08-13T19:14:42  <jnewbery> just because things aren't perfect the first time doesn't mean you should give up on the idea
428 2020-08-13T19:14:44  <wumpus> luke-jr_: that seems another issue, would make it imopssible to move bitcoin itself there
429 2020-08-13T19:14:53  <luke-jr_> wumpus: right, that's my concern with that
430 2020-08-13T19:14:59  *** owowo has quit IRC
431 2020-08-13T19:15:16  <wumpus> jnewbery: it's just that it's not clear that the idea will work at all, causing the people that spent lots of time movign issues around extra work by doing it again seems terrible
432 2020-08-13T19:15:34  <michaelfolkson> It seems to me that the experiment has been very short. I will try to find out if there is genuine interest in contributing, reviewing on that Bitcoin Design Slack
433 2020-08-13T19:15:35  <wumpus> fanquake is not here but I think he'd agree
434 2020-08-13T19:15:44  <jeremyrubin> Maybe a magic friend at github can help us add a feature for this?
435 2020-08-13T19:16:09  <aj> yeah, isn't at least asking someone at github to tweak the database worthwhile?
436 2020-08-13T19:16:10  <hebasto> michaelfolkson: great!
437 2020-08-13T19:16:18  <wumpus> also some GUI people have created issues there, would you have them make them again?
438 2020-08-13T19:16:34  <wumpus> it just seems nasty to me, sorry
439 2020-08-13T19:16:40  <jnewbery> aj: yes. I think moneyball and fanquake are the most likely to know someone at github
440 2020-08-13T19:16:42  <luke-jr_> wumpus: I agree recreating is probably a bad approach, but IF we wanted to do it, better sooner than later
441 2020-08-13T19:17:13  <michaelfolkson> The motivations for it were attracting more contributors/reviewers and reducing noise for those not interested in GUI. I think the rationale made sense and it hasn't been given enough time at this stage
442 2020-08-13T19:17:17  <luke-jr_> probably the best approach would be to allow PRs across code "networks"
443 2020-08-13T19:17:29  <luke-jr_> if GitHub could add that, it'd be nice
444 2020-08-13T19:17:34  <wumpus> michaelfolkson: I agree
445 2020-08-13T19:18:19  <jeremyrubin> Let's ask github if they can tweak it first before doing anything?
446 2020-08-13T19:18:23  <wumpus> I don't actually want to give up the idea, just don't want to take drastic measures like that
447 2020-08-13T19:18:26  <luke-jr> jeremyrubin: +1
448 2020-08-13T19:18:27  <sipa> i certainly like it, it means i can mute the gui PR mails/notofications :)
449 2020-08-13T19:18:36  <luke-jr> sipa: well, procmail can do that much :P
450 2020-08-13T19:18:49  <wumpus> sipa: wait, you can't do that now?
451 2020-08-13T19:19:08  <moneyball> let's see if fanquake will follow-up with github as he's had the most recent contact with them. if not, i am happy to
452 2020-08-13T19:19:13  <wumpus> how does it make a difference for notifications?
453 2020-08-13T19:19:25  <sipa> wumpus: i can do that since the gui repo is split up
454 2020-08-13T19:19:27  <ajonas> michaelfolkson: there are designers interested in the slack group. I put them in touch with hebasto, but they are looking for other devs to connect with.
455 2020-08-13T19:19:31  <wumpus> sipa: ohh right
456 2020-08-13T19:19:32  <luke-jr> wumpus: sipa means not giving up the idea; it's the same whether the repos are linked or not AFAIK
457 2020-08-13T19:19:40  <sipa> wumpus: sorry, i was talking about the split itself; not the recreatio
458 2020-08-13T19:19:51  <wumpus> yes, makes sense then
459 2020-08-13T19:19:56  *** luke-jr_ has quit IRC
460 2020-08-13T19:20:05  <michaelfolkson> ajonas: We set up a separate Slack channel and have notifications set up from GitHub
461 2020-08-13T19:20:06  <luke-jr> (still here)
462 2020-08-13T19:20:44  <jeremyrubin> Are there other topics? moneyball's suggestion sounds like a concrete next step and revisit next week if no word back
463 2020-08-13T19:20:54  <wumpus> I don't think there are any other topics
464 2020-08-13T19:21:24  *** owowo has joined #bitcoin-core-dev
465 2020-08-13T19:21:34  <wumpus> unless anyone has one now
466 2020-08-13T19:21:46  <jnewbery> I have a quick proposed topic
467 2020-08-13T19:22:01  <jnewbery> moving functions in net_processing into PeerLogicValidation
468 2020-08-13T19:22:18  <jeremyrubin> is there a relevant PR?
469 2020-08-13T19:22:31  <wumpus> #topic Moving functions from net_processing to PeerLogicValidation (jnewbery)
470 2020-08-13T19:22:34  * luke-jr wishes C++ allowed for private methods to not be in the header
471 2020-08-13T19:22:36  <jnewbery> currently, most of the logic and much of the state in net_processing is static functions and globals
472 2020-08-13T19:22:44  <jeremyrubin> #19704
473 2020-08-13T19:22:45  <gribble> https://github.com/bitcoin/bitcoin/issues/19704 | Net processing: move ProcessMessage() to PeerLogicValidation by jnewbery · Pull Request #19704 · bitcoin/bitcoin · GitHub
474 2020-08-13T19:23:13  <jnewbery> on a recent PR of mine, several reviewers suggested making new state a member of PLV rather than a global
475 2020-08-13T19:23:28  <jnewbery> doing so would involve moving almost all of net_processing into PLV
476 2020-08-13T19:23:41  <jnewbery> is that a sensible thing to do, or do people have strong objections to that?
477 2020-08-13T19:23:46  <aj> luke-jr: you can get most of the way by moving the private members into a friend class
478 2020-08-13T19:23:52  <jamesob> doesn't sound worth the churn unless there are big benefits to fuzzing/testability
479 2020-08-13T19:24:39  <wumpus> luke-jr: the usual way to do that is a private implementation class (pimpl) pattern
480 2020-08-13T19:24:58  <luke-jr> yes, just feels ugly
481 2020-08-13T19:25:07  <jnewbery> MarcoFalke sdaftuar and theuni were the reviewers who suggested this
482 2020-08-13T19:25:54  <wumpus> luke-jr: maybe, but a lot of software e.g. qt does it everywhere
483 2020-08-13T19:25:58  <luke-jr> to be clear, I don't object to doing this, just find C++ a bit annoying in this regard
484 2020-08-13T19:26:59  <jnewbery> jamesob: I think removing globals and better encapsulation benefits testability, no?
485 2020-08-13T19:27:01  <wumpus> I'm not sure really it's worth changing around just for code organization, there's nothing wrong with functinos
486 2020-08-13T19:27:08  <wumpus> not everythign has to be an object or a method
487 2020-08-13T19:27:52  <jamesob> jnewbery: yeah I agree if what we're talking about is replacing global state with something that's more tightly scoped, but if it's mostly a matter of functions vs. methods I think the difference is pretty negligible. but haven't looked at it in a while...
488 2020-08-13T19:28:08  <wumpus> agree wrt global state
489 2020-08-13T19:28:24  <jamesob> it'd be nice if people could motivate changes like these with large draft branches that demonstrate better testability
490 2020-08-13T19:28:30  <jnewbery> I'm not so interested in opinions like "I'm not sure if it's worth it". More looking for "this is a bad idea and we do it this way because..."
491 2020-08-13T19:28:41  <jnewbery> (if you're not sure it's worth it, just don't review it)
492 2020-08-13T19:29:13  <wumpus> okay sorry...
493 2020-08-13T19:29:35  <jeremyrubin> It sounds like these changes are requested by reviewers already of other work that is made better by it, right jnewbery
494 2020-08-13T19:29:36  <wumpus> will not give my oopinion on this again
495 2020-08-13T19:29:48  <jamesob> wumpus: that was probably mostly directed at me
496 2020-08-13T19:29:52  <jnewbery> jeremyrubin: exactly
497 2020-08-13T19:31:14  <cfields> jnewbery: I didn't look too deeply into it when I +1'd. I certainly didn't realize it'd be a big change.
498 2020-08-13T19:32:09  <cfields> I figured it made sense logically to be there, but yeah, if it means moving everything in, that wouldn't make much sense.
499 2020-08-13T19:32:14  <jeremyrubin> jnewbery: do you feel it's blocking for the other work?
500 2020-08-13T19:32:31  <aj> "not worth it -> don't review" seems like a bad idea?
501 2020-08-13T19:32:55  <jnewbery> it's not blocking. I can abandon it.
502 2020-08-13T19:33:25  <jnewbery> It just seems like it's a better design and allows better testing
503 2020-08-13T19:33:31  <aj> just seems like it'd result in only interested people review, lots of shallow acks, stuff gets merged without deep review
504 2020-08-13T19:33:33  <michaelfolkson> I know video calls (especially when livestreamed, transcribed) aren't for everyone. But if anyone wants to chat Signet this is scheduled for next Wednesday: https://www.meetup.com/BitDevsLDN/events/272121581/
505 2020-08-13T19:33:56  <luke-jr> aj: that already happens I think
506 2020-08-13T19:34:24  <luke-jr> aj: though usually the result is more of "not enough reviews to get merged"
507 2020-08-13T19:34:27  <aj> jnewbery: (agree it's a better design, not sure it's worth it, think doing tx relay overhaul and separating that chunk of code into a separate file might be a start)
508 2020-08-13T19:34:36  *** Pedromvpg has joined #bitcoin-core-dev
509 2020-08-13T19:35:32  <jonatack> jnewbery: i don't know how much work it entails, but sometimes seeing the actual code helps to resolve these questions, as well as looking at if it's a priority worth attempting to do so before writing the code
510 2020-08-13T19:35:32  <jeremyrubin> jnewbery: I'd like to see how it interacts with turning the individual handlers into functions as well. I could see it being good or bad for that.
511 2020-08-13T19:35:48  <jnewbery> aj: that seems tangentially related
512 2020-08-13T19:37:07  <jnewbery> jonatack: 19704 is the first step
513 2020-08-13T19:37:15  <jeremyrubin> jnewbery: it seems this would make it easier to do that right? Less argument passing all over
514 2020-08-13T19:37:27  <jeremyrubin> But then those funcs would also have to methods on the class
515 2020-08-13T19:37:40  <jeremyrubin> So maybe might make sense to encapsulate it in a separate class?
516 2020-08-13T19:37:56  <jnewbery> yes, instead of every function in net_processing having 10 arguments for passing params and connman and banman and ....., they're methods
517 2020-08-13T19:38:00  <cfields> jnewbery: as a concrete answer: it makes sense to me as part of an effort to encapsulate and enhance what an instance of plv can do by itself, primarily for testing.
518 2020-08-13T19:38:26  <jnewbery> cfields: that's how I feel too, which is why I went ahead after you, Marco and Suhas suggested it
519 2020-08-13T19:38:29  <cfields> but absent that greater effort, it doesn't do much good.
520 2020-08-13T19:38:45  <jnewbery> The reason I raised it here was to poll if there was a good reason that it's the way it is now
521 2020-08-13T19:38:54  <dongcarl> cfields: is there a particular test you have in mind that this would enable?
522 2020-08-13T19:38:59  <jeremyrubin> I think it sounds like a general "we're slow to make changes, so this won't have impact because we won't do the follow up for a while"
523 2020-08-13T19:39:11  <jeremyrubin> But at some point we need to make a step
524 2020-08-13T19:39:24  <jeremyrubin> dongcarl: imagine writing individual unit tests for message handlers
525 2020-08-13T19:39:39  <jnewbery> jeremyrubin: +1. We've got to do something eventually instead of always saying that things don't seem worth it
526 2020-08-13T19:39:40  <cfields> dongcarl: I've always, for ex, wanted to be able to run instances of our net/net_processing against themselves.
527 2020-08-13T19:40:06  <jamesob> I think in general for issues like these, someone should come up with a branch that implements (i) the necessary changes and (ii) the new tests that we'd like to be able to do. seeing the tests motivates the changes.
528 2020-08-13T19:40:16  <cfields> (that was the primary goal with CConnman, which never fully worked out :( )
529 2020-08-13T19:40:39  <jeremyrubin> I think there's a balance to that. If the work is huge like this, it sounds like setting jnewbery up for rebase hell
530 2020-08-13T19:40:46  <jnewbery> jamesob: I'm not looking for motivation. I'm looking for anti-motivation, ie is there a strong reason not to do it
531 2020-08-13T19:41:10  <jamesob> the strong motivation not to do it would be a continuation of death-by-a-thousand-small-refactorings going on in the repo
532 2020-08-13T19:41:16  <aj> jnewbery: "we've got to do something" -- work on the things that are clearly worth it?
533 2020-08-13T19:41:19  <jeremyrubin> jnewbery: I think you're inadvdertently asking people what color the shed should be :P
534 2020-08-13T19:41:44  <jnewbery> aj: I think better encapsulated code is worth it
535 2020-08-13T19:41:48  <cfields> jnewbery: I think this was actually the intention for PLV.
536 2020-08-13T19:42:18  <jnewbery> cfields: ah. That makes sense. I haven't looked at the history.
537 2020-08-13T19:42:52  <sipa> is the question if those fields should move into PLV at all, or if they that should happen now?
538 2020-08-13T19:43:07  <jeremyrubin> BTW here's a concrete motivation: Makes it easier to do individual function handlers. Function handlers can be dispatched in O(1), we currently do O(N) string matches to process a message. Concrete motivation for this step in that direction.
539 2020-08-13T19:43:13  <sipa> i think my answers are (1) yes (2) don't care
540 2020-08-13T19:43:35  <jnewbery> The question is "Is there a good reason _not_ to move these functions and data into PLV?"
541 2020-08-13T19:44:08  <jnewbery> If the answer is 'no', then I'll proceed. If the answer is 'yes', then I'll stop.
542 2020-08-13T19:44:13  <jonatack> jnewbery: it doesn't look like a slog to review. more a question of priority and opportunity cost. review pings are piling up atm.
543 2020-08-13T19:44:27  <jeremyrubin> I don't have any.
544 2020-08-13T19:44:36  <jeremyrubin> (objections or reasons not to)
545 2020-08-13T19:44:55  <jeremyrubin> I think jnewbery is only interested in technical objections.
546 2020-08-13T19:45:07  <jeremyrubin> He has 4 strong reviewers who will spend time on it.
547 2020-08-13T19:45:13  <jnewbery> jeremyrubin: I also like individual function handlers. Smaller chunks of code are easier to review/understand and hide less bugs.
548 2020-08-13T19:45:22  <jnewbery> but that wasn't really my main motivation here
549 2020-08-13T19:45:31  <jnewbery> (also easier to test)
550 2020-08-13T19:45:36  <jeremyrubin> But it's a question of if anyone has any technical problems with this move, e.g., conflicting work
551 2020-08-13T19:45:49  <cfields> jnewbery: only one I can think of is: it may reveal a tangled mess that takes more effort than expected to untangle. But you kinda have to work through it to determine that.
552 2020-08-13T19:46:09  <jamesob> moving big swathes of code creates rebase burden for everyone
553 2020-08-13T19:46:19  <jnewbery> cfields: working through a tangled mess is good work. I've done it before :)
554 2020-08-13T19:46:50  <luke-jr> rebase burden will happen no matter what PRs do it
555 2020-08-13T19:47:18  <luke-jr> helpful refactors may reduce it in the long run though
556 2020-08-13T19:47:26  <jnewbery> better encapsulated code is good medicine: more rebase pain now, for much less rebase pain forever after it's done
557 2020-08-13T19:47:33  <luke-jr> ^
558 2020-08-13T19:48:12  <jnewbery> I didn't expect this topic to be so heated :)
559 2020-08-13T19:48:28  <jeremyrubin> jnewbery: new around here are ya?
560 2020-08-13T19:48:29  <jnewbery> It sounds like there aren't any fundamental objections
561 2020-08-13T19:48:45  <sipa> i think it only looks that way because the people here aren't familiar with the concrete implications
562 2020-08-13T19:48:54  <sipa> so we have to talk in generalities
563 2020-08-13T19:49:08  <sipa> it's probably best left to discussion on the PR?
564 2020-08-13T19:49:28  <jnewbery> sipa: yes. For specifics we can use the PR.
565 2020-08-13T19:49:50  <jnewbery> just wanted to make sure there were no high-level reasons why we shouldn't even consider it
566 2020-08-13T19:50:27  <jeremyrubin> Any other 'quick' topics :)
567 2020-08-13T19:51:04  <jamesob> haha
568 2020-08-13T19:51:55  <luke-jr> lol
569 2020-08-13T19:53:03  <wumpus> #endmeeting
570 2020-08-13T19:53:03  <lightningbot> Meeting ended Thu Aug 13 19:53:03 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
571 2020-08-13T19:53:03  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-13-19.00.html
572 2020-08-13T19:53:03  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-13-19.00.txt
573 2020-08-13T19:53:03  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-13-19.00.log.html
574 2020-08-13T19:53:32  <sipa> lunch?
575 2020-08-13T19:53:41  <luke-jr> more like dinner
576 2020-08-13T19:54:03  <dongcarl> tea time!
577 2020-08-13T19:54:08  <jamesob> luke-jr: what, do you go to bed around 7pm?
578 2020-08-13T19:54:34  <jonatack> jnewbery: in the absence of strong reasons against, the code looks ~ok to me
579 2020-08-13T19:54:38  <sipa> dongcarl: havin a yasmine tea at this exact moment
580 2020-08-13T19:54:40  <jonatack> jamesob: i do
581 2020-08-13T19:54:40  <luke-jr> jamesob: I don't eat dinner in bed
582 2020-08-13T19:54:54  <jnewbery> jonatack: thanks :)
583 2020-08-13T19:54:56  <jamesob> I'm envious
584 2020-08-13T19:55:30  <dongcarl> sipa: Out of red bull?
585 2020-08-13T19:55:45  * dongcarl ducks
586 2020-08-13T19:56:23  <sipa> dongcarl: nope.
587 2020-08-13T19:59:18  *** gzhao408 has quit IRC
588 2020-08-13T20:00:55  *** Guyver2_ has quit IRC
589 2020-08-13T20:01:42  *** Talkless has quit IRC
590 2020-08-13T20:09:56  *** sipsorcery has quit IRC
591 2020-08-13T20:10:39  *** sipsorcery has joined #bitcoin-core-dev
592 2020-08-13T20:12:13  *** Highway61 has quit IRC
593 2020-08-13T20:17:51  *** watersnake1 has joined #bitcoin-core-dev
594 2020-08-13T20:25:13  *** paracyst has quit IRC
595 2020-08-13T20:26:08  *** paracyst has joined #bitcoin-core-dev
596 2020-08-13T21:00:01  *** [RuCTFE]tswr has quit IRC
597 2020-08-13T21:02:26  *** lightlike has quit IRC
598 2020-08-13T21:14:42  *** EagleTM has quit IRC
599 2020-08-13T21:21:49  *** SukhE1 has joined #bitcoin-core-dev
600 2020-08-13T21:25:10  *** arowser_ has quit IRC
601 2020-08-13T21:27:14  *** arowser_ has joined #bitcoin-core-dev
602 2020-08-13T21:30:06  *** Chris_Stewart_5 has quit IRC
603 2020-08-13T21:36:53  *** PaulTroo_ has quit IRC
604 2020-08-13T21:58:40  *** bitcoin-git has joined #bitcoin-core-dev
605 2020-08-13T21:58:40  <bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4d0366b47dd...609ce2d0da49
606 2020-08-13T21:58:40  <bitcoin-git> bitcoin/master f110b7c Sebastian Falbesoner: rpc: document returned error fields as optional if applicable
607 2020-08-13T21:58:42  <bitcoin-git> bitcoin/master 609ce2d Samuel Dobson: Merge #19644: rpc: document returned error fields as optional if applicabl...
608 2020-08-13T21:58:43  *** bitcoin-git has left #bitcoin-core-dev
609 2020-08-13T21:59:00  *** bitcoin-git has joined #bitcoin-core-dev
610 2020-08-13T21:59:00  <bitcoin-git> [bitcoin] meshcollider merged pull request #19644: rpc: document returned error fields as optional if applicable (master...20200802-rpc-document_errors_fields_as_optional) https://github.com/bitcoin/bitcoin/pull/19644
611 2020-08-13T21:59:02  *** bitcoin-git has left #bitcoin-core-dev
612 2020-08-13T22:05:16  *** norou has joined #bitcoin-core-dev
613 2020-08-13T22:11:01  *** Chris_Stewart_5 has joined #bitcoin-core-dev
614 2020-08-13T22:18:38  *** marcoagner has quit IRC
615 2020-08-13T22:32:02  *** sipsorcery has quit IRC
616 2020-08-13T22:39:56  *** sipsorcery has joined #bitcoin-core-dev
617 2020-08-13T22:40:34  *** mdunnio has quit IRC
618 2020-08-13T22:49:26  *** gzhao408 has joined #bitcoin-core-dev
619 2020-08-13T22:55:45  *** vasild_ has joined #bitcoin-core-dev
620 2020-08-13T22:59:03  *** vasild has quit IRC
621 2020-08-13T22:59:04  *** vasild_ is now known as vasild
622 2020-08-13T23:06:05  *** infernix has quit IRC
623 2020-08-13T23:13:13  *** Highway61 has joined #bitcoin-core-dev
624 2020-08-13T23:14:06  *** norou has quit IRC
625 2020-08-13T23:14:24  *** sipsorcery has quit IRC
626 2020-08-13T23:17:10  *** gzhao408 has quit IRC
627 2020-08-13T23:17:51  *** sipsorcery has joined #bitcoin-core-dev
628 2020-08-13T23:20:41  *** arowser_ has quit IRC
629 2020-08-13T23:21:47  *** arowser_ has joined #bitcoin-core-dev
630 2020-08-13T23:32:11  *** T3 has quit IRC
631 2020-08-13T23:54:12  *** sipsorcery has quit IRC