1 2020-08-17T00:00:02  *** ndrst1 has quit IRC
  2 2020-08-17T00:02:46  <achow101> luke-jr: it didn't?
  3 2020-08-17T00:03:10  <achow101> I thought signrawtransaction* always signed stuff if it had the necessary info, however it was provided
  4 2020-08-17T00:03:33  *** bitcoin-git has joined #bitcoin-core-dev
  5 2020-08-17T00:03:33  <bitcoin-git> [bitcoin] theStack opened pull request #19739: refactor: remove c-string interfaces for DecodeBase58{Check} (master...20200811-util-remove-cstring-decodebase58) https://github.com/bitcoin/bitcoin/pull/19739
  6 2020-08-17T00:03:34  *** bitcoin-git has left #bitcoin-core-dev
  7 2020-08-17T00:05:36  *** dgenr8 has joined #bitcoin-core-dev
  8 2020-08-17T00:06:07  *** PaulTroo_ has joined #bitcoin-core-dev
  9 2020-08-17T00:07:13  *** bitcoin-git has joined #bitcoin-core-dev
 10 2020-08-17T00:07:14  <bitcoin-git> [bitcoin] promag closed pull request #15204: gui: Add Open External Wallet action (master...2019-01-openexternalwallet) https://github.com/bitcoin/bitcoin/pull/15204
 11 2020-08-17T00:07:15  *** bitcoin-git has left #bitcoin-core-dev
 12 2020-08-17T00:10:57  *** dgenr8 has quit IRC
 13 2020-08-17T00:11:28  *** PaulTroo_ has quit IRC
 14 2020-08-17T00:12:07  <luke-jr> achow101: well, if I backport #17204, the test fails apparently because of this
 15 2020-08-17T00:12:09  <gribble> https://github.com/bitcoin/bitcoin/issues/17204 | wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (sipa) by meshcollider · Pull Request #17204 · bitcoin/bitcoin · GitHub
 16 2020-08-17T00:17:54  <achow101> luke-jr: interesting, I'll have a look
 17 2020-08-17T00:20:45  *** Klox04 has joined #bitcoin-core-dev
 18 2020-08-17T00:21:37  <achow101> luke-jr: my expectation is that 0.20 and earlier would attempt to sign non-wallet inputs and fail silently. Now what's happening is that it's attempting to sign but failing loudly
 19 2020-08-17T00:22:18  *** binbasti has joined #bitcoin-core-dev
 20 2020-08-17T00:22:42  *** mr_burdell_ has quit IRC
 21 2020-08-17T00:23:45  *** dgenr8 has joined #bitcoin-core-dev
 22 2020-08-17T00:28:43  *** mdunnio has joined #bitcoin-core-dev
 23 2020-08-17T00:34:16  *** proofofkeags has joined #bitcoin-core-dev
 24 2020-08-17T00:34:39  <achow101> erm got that backwards
 25 2020-08-17T00:43:14  *** proofofkeags has quit IRC
 26 2020-08-17T00:50:29  <luke-jr> achow101: master is succeeding..
 27 2020-08-17T00:50:59  <achow101> this is looking more like a bug in 0.20 to me rather than a bug in master
 28 2020-08-17T00:55:57  <achow101> luke-jr: the test passes on 0.19
 29 2020-08-17T00:58:26  *** justanotheruser has quit IRC
 30 2020-08-17T01:00:17  *** dgenr8 has quit IRC
 31 2020-08-17T01:07:13  <luke-jr> XD
 32 2020-08-17T01:08:02  <sipa> it was my expectectation too that that should work
 33 2020-08-17T01:08:26  <sipa> if yiu agree to signing a tx, there is no reason why you wouldn't sign it for all inputs/keys that you can
 34 2020-08-17T01:10:42  <luke-jr> achow101: did you bisect it already?
 35 2020-08-17T01:12:35  *** dgenr8 has joined #bitcoin-core-dev
 36 2020-08-17T01:13:29  <achow101> luke-jr: no, but I don't need to
 37 2020-08-17T01:14:02  <achow101> I already know what introduced the bug
 38 2020-08-17T01:14:13  <luke-jr> ?
 39 2020-08-17T01:15:45  <achow101> #18115
 40 2020-08-17T01:15:49  <gribble> https://github.com/bitcoin/bitcoin/issues/18115 | wallet: Pass in transactions and messages for signing instead of exporting the private keys by achow101 · Pull Request #18115 · bitcoin/bitcoin · GitHub
 41 2020-08-17T01:16:22  *** justanotheruser has joined #bitcoin-core-dev
 42 2020-08-17T01:17:00  *** troygiorshev has quit IRC
 43 2020-08-17T01:17:15  <sipa> so, is there a simple backport we could use in 0.20.2 ?
 44 2020-08-17T01:17:29  <achow101> pretty sure no
 45 2020-08-17T01:17:50  <sipa> a less than simple one? that doesn't involve all of descriptor wallets...?
 46 2020-08-17T01:18:25  <achow101> I don't think there's a commit we can directly backport
 47 2020-08-17T01:18:33  <achow101> but it shouldn't be hard to write a fix
 48 2020-08-17T01:18:38  <sipa> ok
 49 2020-08-17T01:19:12  <sipa> i don't think this is all that worrisome, though it's good practice to fix discovered issues
 50 2020-08-17T01:19:13  *** dgenr8 has quit IRC
 51 2020-08-17T01:20:12  <luke-jr> especially while 0.20 is our latest
 52 2020-08-17T01:20:41  <instagibbs> it's conceivable you'd want to not necessarily sign all inputs in a tx(payjoin is an example) but you'd want a specific api to exclude inputs
 53 2020-08-17T01:20:56  <instagibbs> not important to discussion per se, just saying
 54 2020-08-17T01:21:11  *** arowser has quit IRC
 55 2020-08-17T01:21:19  <sipa> instagibbs: yes, agree, though that's a much more specialized situation
 56 2020-08-17T01:21:27  <instagibbs> agreed!
 57 2020-08-17T01:21:50  <luke-jr> probably just a PSBT use case though?
 58 2020-08-17T01:21:59  *** arowser has joined #bitcoin-core-dev
 59 2020-08-17T01:22:27  <instagibbs> anyways, not really something pertaining to this issue
 60 2020-08-17T01:22:29  <luke-jr> achow101: if it's trivial to fix correctly, I'd like to include it in Knots 0.20.1 if possible
 61 2020-08-17T01:28:31  *** proofofkeags has joined #bitcoin-core-dev
 62 2020-08-17T01:28:41  *** mdunnio has quit IRC
 63 2020-08-17T01:31:44  *** dgenr8 has joined #bitcoin-core-dev
 64 2020-08-17T01:36:48  *** proofofkeags has quit IRC
 65 2020-08-17T01:39:36  *** bitcoin-git has joined #bitcoin-core-dev
 66 2020-08-17T01:39:37  <bitcoin-git> [bitcoin] achow101 opened pull request #19740: [0.20] wallet: Simplify and fix CWallet::SignTransaction (0.20...backport-17204-fix) https://github.com/bitcoin/bitcoin/pull/19740
 67 2020-08-17T01:39:41  <achow101> luke-jr: ^ Turns out copy and paste from master works
 68 2020-08-17T01:39:49  *** bitcoin-git has left #bitcoin-core-dev
 69 2020-08-17T01:39:58  <luke-jr> XD
 70 2020-08-17T01:41:50  <luke-jr> achow101: is it really safe to drop all the error checking there?
 71 2020-08-17T01:43:23  <achow101> I think so. See  #19568. The errors should already be coming from the called functions
 72 2020-08-17T01:43:25  <gribble> https://github.com/bitcoin/bitcoin/issues/19568 | Wallet should not override signing errors by fjahr · Pull Request #19568 · bitcoin/bitcoin · GitHub
 73 2020-08-17T01:44:02  *** gzhao408 has quit IRC
 74 2020-08-17T01:45:28  <achow101> Don't think that has changed in master
 75 2020-08-17T01:45:44  <luke-jr> oh, right, I remember that PR
 76 2020-08-17T01:47:02  *** Eagle[TM] has joined #bitcoin-core-dev
 77 2020-08-17T01:49:35  *** EagleTM has quit IRC
 78 2020-08-17T01:53:11  *** arowser has quit IRC
 79 2020-08-17T01:53:33  *** dgenr8 has quit IRC
 80 2020-08-17T01:54:14  *** arowser has joined #bitcoin-core-dev
 81 2020-08-17T02:04:52  *** mdunnio has joined #bitcoin-core-dev
 82 2020-08-17T02:04:55  *** dgenr8 has joined #bitcoin-core-dev
 83 2020-08-17T02:06:59  *** arowser has quit IRC
 84 2020-08-17T02:08:05  *** arowser has joined #bitcoin-core-dev
 85 2020-08-17T02:08:15  *** raddar has joined #bitcoin-core-dev
 86 2020-08-17T02:09:45  *** mdunnio has quit IRC
 87 2020-08-17T02:14:10  *** arowser has quit IRC
 88 2020-08-17T02:17:50  *** arowser has joined #bitcoin-core-dev
 89 2020-08-17T02:19:52  *** dgenr8 has quit IRC
 90 2020-08-17T02:20:23  *** melande has quit IRC
 91 2020-08-17T02:28:22  *** arowser has quit IRC
 92 2020-08-17T02:29:49  *** raddar has quit IRC
 93 2020-08-17T02:30:44  *** arowser has joined #bitcoin-core-dev
 94 2020-08-17T02:31:39  *** dviola has left #bitcoin-core-dev
 95 2020-08-17T02:32:14  *** dgenr8 has joined #bitcoin-core-dev
 96 2020-08-17T02:33:45  *** Klox04 has quit IRC
 97 2020-08-17T02:38:10  *** melande has joined #bitcoin-core-dev
 98 2020-08-17T02:44:06  *** dgenr8 has quit IRC
 99 2020-08-17T02:44:14  *** arowser has quit IRC
100 2020-08-17T02:46:19  *** arowser has joined #bitcoin-core-dev
101 2020-08-17T02:51:43  *** Davterra has joined #bitcoin-core-dev
102 2020-08-17T02:55:53  *** dgenr8 has joined #bitcoin-core-dev
103 2020-08-17T03:00:02  *** binbasti has quit IRC
104 2020-08-17T03:00:25  *** dviola has joined #bitcoin-core-dev
105 2020-08-17T03:07:43  *** dgenr8 has quit IRC
106 2020-08-17T03:11:16  *** arowser has quit IRC
107 2020-08-17T03:12:02  *** arowser has joined #bitcoin-core-dev
108 2020-08-17T03:20:13  *** dgenr8 has joined #bitcoin-core-dev
109 2020-08-17T03:22:08  *** ggainey has joined #bitcoin-core-dev
110 2020-08-17T03:30:41  *** melande has quit IRC
111 2020-08-17T03:35:21  *** melande has joined #bitcoin-core-dev
112 2020-08-17T03:35:42  *** dgenr8 has quit IRC
113 2020-08-17T03:48:17  *** dgenr8 has joined #bitcoin-core-dev
114 2020-08-17T03:51:39  *** asoltys has quit IRC
115 2020-08-17T03:54:57  *** dgenr8 has quit IRC
116 2020-08-17T04:02:31  *** dviola has quit IRC
117 2020-08-17T04:04:57  *** dviola has joined #bitcoin-core-dev
118 2020-08-17T04:07:46  *** dgenr8 has joined #bitcoin-core-dev
119 2020-08-17T04:12:42  *** proofofkeags has joined #bitcoin-core-dev
120 2020-08-17T04:18:25  *** proofofkeags has quit IRC
121 2020-08-17T04:19:40  *** bitcoin-git has joined #bitcoin-core-dev
122 2020-08-17T04:19:41  <bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ffad34816722...c831e105c567
123 2020-08-17T04:19:41  <bitcoin-git> bitcoin/master b82067b Karl-Johan Alm: wallet: try -avoidpartialspends mode and use its result if fees are below ...
124 2020-08-17T04:19:42  <bitcoin-git> bitcoin/master 7f13dfb Karl-Johan Alm: test: test the implicit avoid partial spends functionality
125 2020-08-17T04:19:43  <bitcoin-git> bitcoin/master c831e10 Samuel Dobson: Merge #14582: wallet: always do avoid partial spends if fees are within a ...
126 2020-08-17T04:19:44  *** bitcoin-git has left #bitcoin-core-dev
127 2020-08-17T04:21:30  *** bitcoin-git has joined #bitcoin-core-dev
128 2020-08-17T04:21:30  <bitcoin-git> [bitcoin] meshcollider merged pull request #14582: wallet: always do avoid partial spends if fees are within a specified range (master...181026-try-avoidpartialspends) https://github.com/bitcoin/bitcoin/pull/14582
129 2020-08-17T04:21:43  *** bitcoin-git has left #bitcoin-core-dev
130 2020-08-17T04:21:58  *** melande has quit IRC
131 2020-08-17T04:22:46  *** melande has joined #bitcoin-core-dev
132 2020-08-17T04:29:42  *** dgenr8 has quit IRC
133 2020-08-17T04:30:22  *** proofofkeags has joined #bitcoin-core-dev
134 2020-08-17T04:34:44  *** proofofkeags has quit IRC
135 2020-08-17T04:40:37  *** dviola has left #bitcoin-core-dev
136 2020-08-17T04:40:57  *** dviola has joined #bitcoin-core-dev
137 2020-08-17T04:42:03  *** dgenr8 has joined #bitcoin-core-dev
138 2020-08-17T04:54:27  *** dgenr8 has quit IRC
139 2020-08-17T05:02:36  *** melande has quit IRC
140 2020-08-17T05:03:44  *** melande has joined #bitcoin-core-dev
141 2020-08-17T05:07:10  *** dgenr8 has joined #bitcoin-core-dev
142 2020-08-17T05:12:52  *** dgenr8 has quit IRC
143 2020-08-17T05:25:06  *** dgenr8 has joined #bitcoin-core-dev
144 2020-08-17T05:27:36  *** melande has quit IRC
145 2020-08-17T05:27:56  *** manantial has joined #bitcoin-core-dev
146 2020-08-17T05:28:45  *** melande has joined #bitcoin-core-dev
147 2020-08-17T05:31:12  *** dgenr8 has quit IRC
148 2020-08-17T05:40:51  *** manantial has quit IRC
149 2020-08-17T05:42:45  *** jonatack has quit IRC
150 2020-08-17T05:43:47  *** proofofkeags has joined #bitcoin-core-dev
151 2020-08-17T05:43:47  *** dgenr8 has joined #bitcoin-core-dev
152 2020-08-17T05:44:53  *** bitcoin-git has joined #bitcoin-core-dev
153 2020-08-17T05:44:53  <bitcoin-git> [bitcoin] kallewoof opened pull request #19743: -maxapsfee follow-up (master...20200817-maxapsfee-followup) https://github.com/bitcoin/bitcoin/pull/19743
154 2020-08-17T05:44:55  *** bitcoin-git has left #bitcoin-core-dev
155 2020-08-17T05:48:05  *** proofofkeags has quit IRC
156 2020-08-17T05:54:08  *** dgenr8 has quit IRC
157 2020-08-17T05:55:27  *** ggainey has quit IRC
158 2020-08-17T05:59:40  *** proofofkeags has joined #bitcoin-core-dev
159 2020-08-17T06:00:22  *** PaulTroo_ has joined #bitcoin-core-dev
160 2020-08-17T06:04:16  *** proofofkeags has quit IRC
161 2020-08-17T06:07:02  *** dgenr8 has joined #bitcoin-core-dev
162 2020-08-17T06:13:32  *** dgenr8 has quit IRC
163 2020-08-17T06:22:23  *** jungnam has joined #bitcoin-core-dev
164 2020-08-17T06:23:37  *** dviola has quit IRC
165 2020-08-17T06:25:00  *** dviola has joined #bitcoin-core-dev
166 2020-08-17T06:26:05  *** dgenr8 has joined #bitcoin-core-dev
167 2020-08-17T06:37:16  *** jonatack has joined #bitcoin-core-dev
168 2020-08-17T06:47:03  *** dgenr8 has quit IRC
169 2020-08-17T06:53:10  *** Guyver2 has joined #bitcoin-core-dev
170 2020-08-17T06:55:21  *** IPGlider has quit IRC
171 2020-08-17T06:55:25  *** Livestradamus has quit IRC
172 2020-08-17T06:59:48  *** dgenr8 has joined #bitcoin-core-dev
173 2020-08-17T07:05:37  *** jonatack has quit IRC
174 2020-08-17T07:06:52  *** dgenr8 has quit IRC
175 2020-08-17T07:07:16  *** marcoagner has joined #bitcoin-core-dev
176 2020-08-17T07:08:00  *** opsec_x12 has joined #bitcoin-core-dev
177 2020-08-17T07:16:35  *** jonatack has joined #bitcoin-core-dev
178 2020-08-17T07:19:45  *** dgenr8 has joined #bitcoin-core-dev
179 2020-08-17T07:27:02  *** dgenr8 has quit IRC
180 2020-08-17T07:30:54  *** TheHoliestRoger has quit IRC
181 2020-08-17T07:31:59  *** TheHoliestRoger has joined #bitcoin-core-dev
182 2020-08-17T07:36:53  *** mrostecki has joined #bitcoin-core-dev
183 2020-08-17T07:39:37  *** dgenr8 has joined #bitcoin-core-dev
184 2020-08-17T07:41:36  *** andreacab has joined #bitcoin-core-dev
185 2020-08-17T07:44:43  *** mrostecki has quit IRC
186 2020-08-17T07:45:37  *** justanotheruser has quit IRC
187 2020-08-17T07:45:57  *** dgenr8 has quit IRC
188 2020-08-17T07:46:04  *** andreacab has quit IRC
189 2020-08-17T07:46:19  *** _flow_ has quit IRC
190 2020-08-17T07:46:31  *** andreacab has joined #bitcoin-core-dev
191 2020-08-17T07:47:29  *** andreaca_ has joined #bitcoin-core-dev
192 2020-08-17T07:48:25  *** kljasdfvv has joined #bitcoin-core-dev
193 2020-08-17T07:50:54  *** andreacab has quit IRC
194 2020-08-17T07:51:26  *** Talkless has joined #bitcoin-core-dev
195 2020-08-17T07:52:54  *** _flow_ has joined #bitcoin-core-dev
196 2020-08-17T07:54:23  *** andreaca_ has quit IRC
197 2020-08-17T07:54:56  *** andreacab has joined #bitcoin-core-dev
198 2020-08-17T07:58:43  *** dgenr8 has joined #bitcoin-core-dev
199 2020-08-17T08:13:23  *** andreacab has quit IRC
200 2020-08-17T08:14:59  *** Pavlenex has joined #bitcoin-core-dev
201 2020-08-17T08:24:04  *** dgenr8 has quit IRC
202 2020-08-17T08:34:42  *** andreaca_ has joined #bitcoin-core-dev
203 2020-08-17T08:35:57  *** dgenr8 has joined #bitcoin-core-dev
204 2020-08-17T08:40:32  *** dgenr8 has quit IRC
205 2020-08-17T08:53:08  *** dgenr8 has joined #bitcoin-core-dev
206 2020-08-17T08:56:09  *** bitcoin-git has joined #bitcoin-core-dev
207 2020-08-17T08:56:09  <bitcoin-git> [bitcoin] hebasto opened pull request #19745: build: Drop back compatibility code for 32-bit x86 Linux binaries (master...200817-i686) https://github.com/bitcoin/bitcoin/pull/19745
208 2020-08-17T08:56:10  *** bitcoin-git has left #bitcoin-core-dev
209 2020-08-17T09:00:01  *** jungnam has quit IRC
210 2020-08-17T09:05:50  *** jonatack has quit IRC
211 2020-08-17T09:09:23  *** dgenr8 has quit IRC
212 2020-08-17T09:09:56  *** NicolasDorier has quit IRC
213 2020-08-17T09:10:08  *** hebasto has quit IRC
214 2020-08-17T09:10:21  *** endogenic has quit IRC
215 2020-08-17T09:10:21  *** CodeShark___ has quit IRC
216 2020-08-17T09:10:39  *** mmitech__ has quit IRC
217 2020-08-17T09:10:58  *** digi_james has quit IRC
218 2020-08-17T09:11:16  *** mariorz has quit IRC
219 2020-08-17T09:12:53  *** fjahr has quit IRC
220 2020-08-17T09:13:17  *** mrostecki has joined #bitcoin-core-dev
221 2020-08-17T09:14:22  *** mrostecki has quit IRC
222 2020-08-17T09:14:33  *** mrostecki has joined #bitcoin-core-dev
223 2020-08-17T09:15:13  *** hebasto has joined #bitcoin-core-dev
224 2020-08-17T09:15:16  *** NicolasDorier has joined #bitcoin-core-dev
225 2020-08-17T09:17:22  *** fjahr has joined #bitcoin-core-dev
226 2020-08-17T09:17:22  *** Tralfaz has joined #bitcoin-core-dev
227 2020-08-17T09:17:50  *** digi_james has joined #bitcoin-core-dev
228 2020-08-17T09:17:53  *** mmitech__ has joined #bitcoin-core-dev
229 2020-08-17T09:18:09  *** Pavlenex has joined #bitcoin-core-dev
230 2020-08-17T09:18:26  *** mariorz has joined #bitcoin-core-dev
231 2020-08-17T09:19:55  *** Davterra has quit IRC
232 2020-08-17T09:20:57  *** feb has joined #bitcoin-core-dev
233 2020-08-17T09:21:42  *** dgenr8 has joined #bitcoin-core-dev
234 2020-08-17T09:21:48  *** Davterra has joined #bitcoin-core-dev
235 2020-08-17T09:22:14  *** endogenic has joined #bitcoin-core-dev
236 2020-08-17T09:23:22  *** Pavlenex has quit IRC
237 2020-08-17T09:23:46  *** CodeShark___ has joined #bitcoin-core-dev
238 2020-08-17T09:24:29  *** Tralfaz has quit IRC
239 2020-08-17T09:28:27  *** bitcoin-git has joined #bitcoin-core-dev
240 2020-08-17T09:28:27  <bitcoin-git> [bitcoin] hebasto closed pull request #19745: build: Drop back compatibility code for 32-bit x86 Linux binaries (master...200817-i686) https://github.com/bitcoin/bitcoin/pull/19745
241 2020-08-17T09:28:29  *** bitcoin-git has left #bitcoin-core-dev
242 2020-08-17T09:29:46  *** dgenr8 has quit IRC
243 2020-08-17T09:39:24  *** Tennis has joined #bitcoin-core-dev
244 2020-08-17T09:39:31  *** jonatack has joined #bitcoin-core-dev
245 2020-08-17T09:41:25  *** dgenr8 has joined #bitcoin-core-dev
246 2020-08-17T09:42:00  *** andreacab has joined #bitcoin-core-dev
247 2020-08-17T09:44:45  *** andreaca_ has quit IRC
248 2020-08-17T09:44:59  *** AaronvanW has joined #bitcoin-core-dev
249 2020-08-17T09:47:00  *** Guyver2_ has joined #bitcoin-core-dev
250 2020-08-17T09:49:50  *** dgenr8 has quit IRC
251 2020-08-17T09:50:02  *** Guyver2 has quit IRC
252 2020-08-17T09:50:13  *** Highway61 has joined #bitcoin-core-dev
253 2020-08-17T09:51:13  *** Pavlenex has joined #bitcoin-core-dev
254 2020-08-17T09:54:48  *** Pavlenex has joined #bitcoin-core-dev
255 2020-08-17T09:57:08  *** bitcoin-git has joined #bitcoin-core-dev
256 2020-08-17T09:57:09  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19746: ci: Move valgrind fuzzer to cirrus (master...2008-ciValgrind) https://github.com/bitcoin/bitcoin/pull/19746
257 2020-08-17T09:57:10  *** bitcoin-git has left #bitcoin-core-dev
258 2020-08-17T10:01:30  *** dgenr8 has joined #bitcoin-core-dev
259 2020-08-17T10:08:53  *** Livestradamus has joined #bitcoin-core-dev
260 2020-08-17T10:12:22  *** Tralfaz has joined #bitcoin-core-dev
261 2020-08-17T10:13:04  *** Pavlenex has joined #bitcoin-core-dev
262 2020-08-17T10:13:36  *** dgenr8 has quit IRC
263 2020-08-17T10:14:52  *** Davterra has quit IRC
264 2020-08-17T10:16:44  *** Davterra has joined #bitcoin-core-dev
265 2020-08-17T10:17:01  *** andreacab has quit IRC
266 2020-08-17T10:17:25  *** mrostecki_ has joined #bitcoin-core-dev
267 2020-08-17T10:17:26  *** Guyver2__ has joined #bitcoin-core-dev
268 2020-08-17T10:17:54  *** mrostecki has quit IRC
269 2020-08-17T10:17:54  *** andreacab has joined #bitcoin-core-dev
270 2020-08-17T10:18:24  *** Norwood2Runte has joined #bitcoin-core-dev
271 2020-08-17T10:19:50  *** Tralfaz has quit IRC
272 2020-08-17T10:20:01  *** Guyver2_ has quit IRC
273 2020-08-17T10:25:01  *** andreacab has quit IRC
274 2020-08-17T10:25:33  *** dgenr8 has joined #bitcoin-core-dev
275 2020-08-17T10:25:53  *** andreacab has joined #bitcoin-core-dev
276 2020-08-17T10:29:36  *** andreacab has quit IRC
277 2020-08-17T10:29:42  *** andreacab has joined #bitcoin-core-dev
278 2020-08-17T10:31:11  *** jonatack has quit IRC
279 2020-08-17T10:31:52  *** PaulTro__ has joined #bitcoin-core-dev
280 2020-08-17T10:33:47  *** PaulTroo_ has quit IRC
281 2020-08-17T10:34:07  *** andreacab has quit IRC
282 2020-08-17T10:34:16  *** andreacab has joined #bitcoin-core-dev
283 2020-08-17T10:34:17  *** dgenr8 has quit IRC
284 2020-08-17T10:37:22  *** Tralfaz has joined #bitcoin-core-dev
285 2020-08-17T10:40:06  *** Davterra has quit IRC
286 2020-08-17T10:40:07  *** Pavlenex has quit IRC
287 2020-08-17T10:41:27  *** Davterra has joined #bitcoin-core-dev
288 2020-08-17T10:44:08  *** andreacab has quit IRC
289 2020-08-17T10:44:37  *** Tralfaz has quit IRC
290 2020-08-17T10:44:38  *** andreacab has joined #bitcoin-core-dev
291 2020-08-17T10:46:33  *** dgenr8 has joined #bitcoin-core-dev
292 2020-08-17T10:47:30  *** andreacab has quit IRC
293 2020-08-17T10:47:38  *** andreacab has joined #bitcoin-core-dev
294 2020-08-17T10:49:02  *** bitcoin-git has joined #bitcoin-core-dev
295 2020-08-17T10:49:03  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c831e105c567...1bc8e8eae2dc
296 2020-08-17T10:49:03  <bitcoin-git> bitcoin/master 7668db3 Marcin Jachymiak: Move only: Move CDiskTxPos to its own file
297 2020-08-17T10:49:04  <bitcoin-git> bitcoin/master 1bc8e8e MarcoFalke: Merge #19734: Move CDiskTxPos to its own file
298 2020-08-17T10:49:05  *** bitcoin-git has left #bitcoin-core-dev
299 2020-08-17T10:49:22  *** bitcoin-git has joined #bitcoin-core-dev
300 2020-08-17T10:49:23  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19734: Move CDiskTxPos to its own file (master...move-disktxpos) https://github.com/bitcoin/bitcoin/pull/19734
301 2020-08-17T10:49:24  *** bitcoin-git has left #bitcoin-core-dev
302 2020-08-17T10:51:28  *** dgenr8 has quit IRC
303 2020-08-17T10:52:21  *** Highway61 has quit IRC
304 2020-08-17T10:55:42  *** vasild_ has joined #bitcoin-core-dev
305 2020-08-17T10:55:56  *** Highway61 has joined #bitcoin-core-dev
306 2020-08-17T10:56:23  *** Chris_Stewart_5 has joined #bitcoin-core-dev
307 2020-08-17T10:58:43  *** vasild has quit IRC
308 2020-08-17T10:58:45  *** vasild_ is now known as vasild
309 2020-08-17T11:04:18  *** dgenr8 has joined #bitcoin-core-dev
310 2020-08-17T11:04:40  *** Highway61 has quit IRC
311 2020-08-17T11:16:44  *** andreacab has quit IRC
312 2020-08-17T11:17:35  *** andreacab has joined #bitcoin-core-dev
313 2020-08-17T11:18:52  *** dgenr8 has quit IRC
314 2020-08-17T11:22:13  *** andreacab has quit IRC
315 2020-08-17T11:22:42  *** bitcoin-git has joined #bitcoin-core-dev
316 2020-08-17T11:22:42  <bitcoin-git> [bitcoin] S3RK closed pull request #19384: test: speed up functional tests (master...test_speed_up) https://github.com/bitcoin/bitcoin/pull/19384
317 2020-08-17T11:22:43  *** bitcoin-git has left #bitcoin-core-dev
318 2020-08-17T11:27:22  *** Tralfaz has joined #bitcoin-core-dev
319 2020-08-17T11:30:10  *** Davterra has quit IRC
320 2020-08-17T11:30:35  *** Pavlenex has joined #bitcoin-core-dev
321 2020-08-17T11:31:42  *** dgenr8 has joined #bitcoin-core-dev
322 2020-08-17T11:31:44  *** Davterra has joined #bitcoin-core-dev
323 2020-08-17T11:33:44  *** Pavlenex has quit IRC
324 2020-08-17T11:34:20  *** Tralfaz has quit IRC
325 2020-08-17T11:34:45  *** Highway61 has joined #bitcoin-core-dev
326 2020-08-17T11:38:51  *** dgenr8 has quit IRC
327 2020-08-17T11:43:50  *** bitcoin-git has joined #bitcoin-core-dev
328 2020-08-17T11:43:51  <bitcoin-git> [bitcoin] S3RK opened pull request #19747: wallet: restore condition for HD chain split upgrade (master...wallet_upgrade_fix) https://github.com/bitcoin/bitcoin/pull/19747
329 2020-08-17T11:43:52  *** bitcoin-git has left #bitcoin-core-dev
330 2020-08-17T11:47:09  *** troygiorshev has joined #bitcoin-core-dev
331 2020-08-17T11:50:27  *** dgenr8 has joined #bitcoin-core-dev
332 2020-08-17T11:53:49  *** jonatack has joined #bitcoin-core-dev
333 2020-08-17T11:55:19  *** andreacab has joined #bitcoin-core-dev
334 2020-08-17T11:58:48  *** Guyver2_ has joined #bitcoin-core-dev
335 2020-08-17T11:58:58  *** Highway61 has quit IRC
336 2020-08-17T12:00:01  *** feb has quit IRC
337 2020-08-17T12:02:01  *** Guyver2__ has quit IRC
338 2020-08-17T12:08:35  *** Norwood2Runte has quit IRC
339 2020-08-17T12:10:48  *** dgenr8 has quit IRC
340 2020-08-17T12:13:15  *** dviola has left #bitcoin-core-dev
341 2020-08-17T12:13:36  *** dviola has joined #bitcoin-core-dev
342 2020-08-17T12:17:12  *** andreacab has quit IRC
343 2020-08-17T12:19:52  *** jeremyrubin has quit IRC
344 2020-08-17T12:21:50  *** forcer1 has joined #bitcoin-core-dev
345 2020-08-17T12:23:17  *** dgenr8 has joined #bitcoin-core-dev
346 2020-08-17T12:25:10  *** Guyver2__ has joined #bitcoin-core-dev
347 2020-08-17T12:25:26  *** andreacab has joined #bitcoin-core-dev
348 2020-08-17T12:27:00  *** Guyver2_ has quit IRC
349 2020-08-17T12:29:27  *** dgenr8 has quit IRC
350 2020-08-17T12:31:02  *** andreacab has quit IRC
351 2020-08-17T12:34:05  *** davec has quit IRC
352 2020-08-17T12:37:21  *** Tralfaz has joined #bitcoin-core-dev
353 2020-08-17T12:39:52  *** Davterra has quit IRC
354 2020-08-17T12:42:13  *** dgenr8 has joined #bitcoin-core-dev
355 2020-08-17T12:45:43  *** fox2p has quit IRC
356 2020-08-17T12:46:23  *** Davterra has joined #bitcoin-core-dev
357 2020-08-17T12:49:50  *** Tralfaz has quit IRC
358 2020-08-17T12:52:32  *** dgenr8 has quit IRC
359 2020-08-17T12:54:23  *** Guyver2__ has quit IRC
360 2020-08-17T12:54:55  *** gzhao408 has joined #bitcoin-core-dev
361 2020-08-17T12:59:29  *** owowo has quit IRC
362 2020-08-17T13:00:00  *** owowo has joined #bitcoin-core-dev
363 2020-08-17T13:02:43  *** Murch has quit IRC
364 2020-08-17T13:05:02  *** dgenr8 has joined #bitcoin-core-dev
365 2020-08-17T13:08:28  *** arowser has quit IRC
366 2020-08-17T13:09:11  *** arowser has joined #bitcoin-core-dev
367 2020-08-17T13:09:24  *** arowser has quit IRC
368 2020-08-17T13:10:08  *** arowser has joined #bitcoin-core-dev
369 2020-08-17T13:10:20  *** davec has joined #bitcoin-core-dev
370 2020-08-17T13:12:16  *** dgenr8 has quit IRC
371 2020-08-17T13:12:16  *** arowser has quit IRC
372 2020-08-17T13:13:05  *** arowser has joined #bitcoin-core-dev
373 2020-08-17T13:13:12  *** arowser has quit IRC
374 2020-08-17T13:13:56  *** arowser has joined #bitcoin-core-dev
375 2020-08-17T13:17:51  *** davec has quit IRC
376 2020-08-17T13:25:06  *** dgenr8 has joined #bitcoin-core-dev
377 2020-08-17T13:30:23  *** bitdex has quit IRC
378 2020-08-17T13:31:02  *** dgenr8 has quit IRC
379 2020-08-17T13:33:10  *** mrostecki_ has quit IRC
380 2020-08-17T13:33:23  *** mrostecki has joined #bitcoin-core-dev
381 2020-08-17T13:36:24  *** fearbeag has joined #bitcoin-core-dev
382 2020-08-17T13:36:52  *** Tralfaz has joined #bitcoin-core-dev
383 2020-08-17T13:39:21  *** andreacab has joined #bitcoin-core-dev
384 2020-08-17T13:39:23  *** Davterra has quit IRC
385 2020-08-17T13:43:34  *** dgenr8 has joined #bitcoin-core-dev
386 2020-08-17T13:44:05  *** andreacab has quit IRC
387 2020-08-17T13:45:40  *** proofofkeags has joined #bitcoin-core-dev
388 2020-08-17T13:46:59  *** Davterra has joined #bitcoin-core-dev
389 2020-08-17T13:49:05  *** Tralfaz has quit IRC
390 2020-08-17T13:49:23  *** dgenr8 has quit IRC
391 2020-08-17T13:52:36  *** watersnake1 has joined #bitcoin-core-dev
392 2020-08-17T13:55:04  *** Guyver2 has joined #bitcoin-core-dev
393 2020-08-17T13:55:22  *** watersnake1 has quit IRC
394 2020-08-17T14:00:28  *** tryphe_ has joined #bitcoin-core-dev
395 2020-08-17T14:00:44  *** mdunnio has joined #bitcoin-core-dev
396 2020-08-17T14:00:59  *** davec has joined #bitcoin-core-dev
397 2020-08-17T14:02:14  *** dgenr8 has joined #bitcoin-core-dev
398 2020-08-17T14:03:25  *** tryphe has quit IRC
399 2020-08-17T14:04:11  *** troygiorshev has quit IRC
400 2020-08-17T14:05:02  *** watersnake1 has joined #bitcoin-core-dev
401 2020-08-17T14:10:07  *** dgenr8 has quit IRC
402 2020-08-17T14:13:32  *** mdunnio has quit IRC
403 2020-08-17T14:13:47  *** mdunnio has joined #bitcoin-core-dev
404 2020-08-17T14:15:21  *** Tralfaz has joined #bitcoin-core-dev
405 2020-08-17T14:15:58  *** zndtoshi has joined #bitcoin-core-dev
406 2020-08-17T14:16:14  *** troygiorshev has joined #bitcoin-core-dev
407 2020-08-17T14:16:23  *** arowser has quit IRC
408 2020-08-17T14:17:09  *** arowser has joined #bitcoin-core-dev
409 2020-08-17T14:17:50  *** Davterra has quit IRC
410 2020-08-17T14:19:02  *** rh0nj has quit IRC
411 2020-08-17T14:19:56  *** troygior1hev has joined #bitcoin-core-dev
412 2020-08-17T14:20:26  *** troygior1hev has quit IRC
413 2020-08-17T14:20:47  *** troygior1hev has joined #bitcoin-core-dev
414 2020-08-17T14:21:49  *** troygiorshev has quit IRC
415 2020-08-17T14:21:55  *** troygior1hev has quit IRC
416 2020-08-17T14:22:07  *** rh0nj has joined #bitcoin-core-dev
417 2020-08-17T14:22:37  *** dgenr8 has joined #bitcoin-core-dev
418 2020-08-17T14:43:09  *** satwo has joined #bitcoin-core-dev
419 2020-08-17T14:45:57  *** dgenr8 has quit IRC
420 2020-08-17T14:48:45  *** proofofkeags has quit IRC
421 2020-08-17T14:52:17  *** jb55 has quit IRC
422 2020-08-17T14:52:48  *** jb55 has joined #bitcoin-core-dev
423 2020-08-17T14:52:55  *** andreacab has joined #bitcoin-core-dev
424 2020-08-17T14:55:52  *** jb55 has quit IRC
425 2020-08-17T14:56:04  *** zndtoshi has quit IRC
426 2020-08-17T14:56:20  *** jb55 has joined #bitcoin-core-dev
427 2020-08-17T14:57:38  *** andreacab has quit IRC
428 2020-08-17T14:58:45  *** dgenr8 has joined #bitcoin-core-dev
429 2020-08-17T15:00:02  *** forcer1 has quit IRC
430 2020-08-17T15:04:07  *** dgenr8 has quit IRC
431 2020-08-17T15:04:34  *** tryphe_ has quit IRC
432 2020-08-17T15:05:22  *** tryphe_ has joined #bitcoin-core-dev
433 2020-08-17T15:05:52  *** Pavlenex has joined #bitcoin-core-dev
434 2020-08-17T15:17:49  *** dgenr8 has joined #bitcoin-core-dev
435 2020-08-17T15:22:25  *** kpyke has joined #bitcoin-core-dev
436 2020-08-17T15:26:00  *** Tralfaz has quit IRC
437 2020-08-17T15:27:29  *** Tralfaz has joined #bitcoin-core-dev
438 2020-08-17T15:31:01  *** andreacab has joined #bitcoin-core-dev
439 2020-08-17T15:32:56  *** Davterra has joined #bitcoin-core-dev
440 2020-08-17T15:32:57  *** dgenr8 has quit IRC
441 2020-08-17T15:34:07  *** weedcoder has joined #bitcoin-core-dev
442 2020-08-17T15:34:35  *** Tralfaz has quit IRC
443 2020-08-17T15:35:05  *** weedcoder has quit IRC
444 2020-08-17T15:35:13  *** weedcoder has joined #bitcoin-core-dev
445 2020-08-17T15:35:33  *** andreacab has quit IRC
446 2020-08-17T15:35:40  *** Tralfaz has joined #bitcoin-core-dev
447 2020-08-17T15:35:59  *** weedcoder has quit IRC
448 2020-08-17T15:38:45  *** mol has quit IRC
449 2020-08-17T15:39:40  *** Davterra has quit IRC
450 2020-08-17T15:43:06  *** weedcoder has joined #bitcoin-core-dev
451 2020-08-17T15:45:36  *** dgenr8 has joined #bitcoin-core-dev
452 2020-08-17T15:50:19  *** alko has quit IRC
453 2020-08-17T15:51:27  *** bitcoin-git has joined #bitcoin-core-dev
454 2020-08-17T15:51:28  <bitcoin-git> [bitcoin] theStack opened pull request #19750: refactor: remove unused c-string variant of atoi64() (master...20200817-util-remove-unused_cstr_atoi64) https://github.com/bitcoin/bitcoin/pull/19750
455 2020-08-17T15:51:28  *** bitcoin-git has left #bitcoin-core-dev
456 2020-08-17T15:51:53  *** dgenr8 has quit IRC
457 2020-08-17T15:53:17  *** Davterra has joined #bitcoin-core-dev
458 2020-08-17T15:55:06  *** Tralfaz has quit IRC
459 2020-08-17T15:55:40  *** Tralfaz has joined #bitcoin-core-dev
460 2020-08-17T15:56:42  *** satwo has quit IRC
461 2020-08-17T16:00:15  *** Davterra has quit IRC
462 2020-08-17T16:04:14  *** dgenr8 has joined #bitcoin-core-dev
463 2020-08-17T16:07:35  *** proofofkeags has joined #bitcoin-core-dev
464 2020-08-17T16:11:53  *** proofofkeags has quit IRC
465 2020-08-17T16:12:04  *** gzhao408 has quit IRC
466 2020-08-17T16:14:21  *** ghost1 has joined #bitcoin-core-dev
467 2020-08-17T16:14:35  *** mol has joined #bitcoin-core-dev
468 2020-08-17T16:16:20  *** roconnor has joined #bitcoin-core-dev
469 2020-08-17T16:16:42  *** dgenr8 has quit IRC
470 2020-08-17T16:20:26  *** jeremyrubin has joined #bitcoin-core-dev
471 2020-08-17T16:23:20  *** proofofkeags has joined #bitcoin-core-dev
472 2020-08-17T16:23:20  *** arowser has quit IRC
473 2020-08-17T16:24:09  *** arowser has joined #bitcoin-core-dev
474 2020-08-17T16:27:38  *** belcher has joined #bitcoin-core-dev
475 2020-08-17T16:27:46  *** proofofkeags has quit IRC
476 2020-08-17T16:29:06  *** dgenr8 has joined #bitcoin-core-dev
477 2020-08-17T16:38:34  *** PaulTro__ has quit IRC
478 2020-08-17T16:41:05  *** andreacab has joined #bitcoin-core-dev
479 2020-08-17T16:41:28  *** dgenr8 has quit IRC
480 2020-08-17T16:45:51  *** andreacab has quit IRC
481 2020-08-17T16:54:14  *** dgenr8 has joined #bitcoin-core-dev
482 2020-08-17T16:55:03  * luke-jr wonders if he needs to pivot PPC64 support to Knots-only :/
483 2020-08-17T16:55:38  *** mrostecki has quit IRC
484 2020-08-17T16:57:48  <sipa> why?
485 2020-08-17T16:58:32  <luke-jr> sipa: nobody's reviewing it, and as it stands, I'm having to build Qt separately for Core and Knots since PPC64 requires upstream libpng :/
486 2020-08-17T16:59:00  <luke-jr> (it needs rebase yet again, but it didn't get any activity after the last rebase either)
487 2020-08-17T16:59:20  <sipa> who else here has power9 hardware?
488 2020-08-17T16:59:35  <sipa> there are a few at least, afaik
489 2020-08-17T17:00:05  <luke-jr> not sure
490 2020-08-17T17:00:07  *** dgenr8 has quit IRC
491 2020-08-17T17:00:22  <luke-jr> gmaxwell I think did, but isn't here these days :x
492 2020-08-17T17:00:58  <sipa> bluematt, sdaftuar, ...
493 2020-08-17T17:00:59  * luke-jr ponders if splitting up the libpng change would be more reviewable for now
494 2020-08-17T17:01:14  <sipa> maybe midnight ?
495 2020-08-17T17:02:18  *** adiabat has quit IRC
496 2020-08-17T17:12:20  * luke-jr rebases it again for now
497 2020-08-17T17:12:45  *** dgenr8 has joined #bitcoin-core-dev
498 2020-08-17T17:13:56  *** thomasb06 has joined #bitcoin-core-dev
499 2020-08-17T17:19:08  *** thomasb06 has quit IRC
500 2020-08-17T17:21:27  *** pinheadmz has quit IRC
501 2020-08-17T17:22:48  *** alko89 has quit IRC
502 2020-08-17T17:22:54  *** zndtoshi has joined #bitcoin-core-dev
503 2020-08-17T17:23:02  *** justanotheruser has joined #bitcoin-core-dev
504 2020-08-17T17:23:22  *** andreacab has joined #bitcoin-core-dev
505 2020-08-17T17:24:32  *** bitcoin-git has joined #bitcoin-core-dev
506 2020-08-17T17:24:32  <bitcoin-git> [bitcoin] luke-jr opened pull request #19751: depends: Split libpng out of Qt (master...depends_libpng) https://github.com/bitcoin/bitcoin/pull/19751
507 2020-08-17T17:24:33  *** bitcoin-git has left #bitcoin-core-dev
508 2020-08-17T17:28:17  *** andreacab has quit IRC
509 2020-08-17T17:32:20  *** Tennis has quit IRC
510 2020-08-17T17:39:53  *** dongcarl has quit IRC
511 2020-08-17T17:40:09  *** dongcarl has joined #bitcoin-core-dev
512 2020-08-17T17:41:30  *** Tralfaz has quit IRC
513 2020-08-17T17:45:52  <amiti> just want to highlight for anyone who might not have seen yet- as of #19316 "oneshots" have been renamed to "addr fetch" connections
514 2020-08-17T17:45:56  <gribble> https://github.com/bitcoin/bitcoin/issues/19316 | [net] Cleanup logic around connection types by amitiuttarwar · Pull Request #19316 · bitcoin/bitcoin · GitHub
515 2020-08-17T17:46:45  *** Tralfaz has joined #bitcoin-core-dev
516 2020-08-17T17:48:50  *** Pavlenex has quit IRC
517 2020-08-17T17:55:31  *** dongcarl has quit IRC
518 2020-08-17T17:55:47  *** dongcarl has joined #bitcoin-core-dev
519 2020-08-17T17:56:43  *** Tralfaz has quit IRC
520 2020-08-17T17:59:22  *** Davterra has joined #bitcoin-core-dev
521 2020-08-17T18:00:01  *** kpyke has quit IRC
522 2020-08-17T18:10:56  *** dongcarl has quit IRC
523 2020-08-17T18:11:12  *** dongcarl has joined #bitcoin-core-dev
524 2020-08-17T18:13:30  *** mol_ has joined #bitcoin-core-dev
525 2020-08-17T18:16:02  *** mol has quit IRC
526 2020-08-17T18:19:31  *** bitcoin-git has joined #bitcoin-core-dev
527 2020-08-17T18:19:31  <bitcoin-git> [bitcoin] slmtpz opened pull request #19752: test: Update wait_until usage in tests not to use the one from utils (master...master) https://github.com/bitcoin/bitcoin/pull/19752
528 2020-08-17T18:19:33  *** bitcoin-git has left #bitcoin-core-dev
529 2020-08-17T18:21:52  *** tflgen2 has joined #bitcoin-core-dev
530 2020-08-17T18:26:24  *** dongcarl has quit IRC
531 2020-08-17T18:26:39  *** dongcarl has joined #bitcoin-core-dev
532 2020-08-17T18:26:45  *** adiabat has joined #bitcoin-core-dev
533 2020-08-17T18:33:03  <achow101> Why are there both RemoveWallet and UnloadWallet? It seems like unloadwallet calls both, but the GUI only calls RemoveWallet?
534 2020-08-17T18:33:20  <achow101> Can these be consolidated?
535 2020-08-17T18:41:45  *** dongcarl has quit IRC
536 2020-08-17T18:42:01  *** dongcarl has joined #bitcoin-core-dev
537 2020-08-17T18:56:11  *** troygiorshev has joined #bitcoin-core-dev
538 2020-08-17T18:58:39  *** alko89 has joined #bitcoin-core-dev
539 2020-08-17T19:01:28  *** bitcoin-git has joined #bitcoin-core-dev
540 2020-08-17T19:01:28  <bitcoin-git> [bitcoin] troygiorshev opened pull request #19753: p2p: fix recentRejects filling bug (master...2020-08-clean-tx-processing) https://github.com/bitcoin/bitcoin/pull/19753
541 2020-08-17T19:01:29  *** bitcoin-git has left #bitcoin-core-dev
542 2020-08-17T19:06:43  *** belcher has quit IRC
543 2020-08-17T19:10:03  *** Dean_Guss has joined #bitcoin-core-dev
544 2020-08-17T19:10:10  *** DeanWeen has quit IRC
545 2020-08-17T19:27:03  *** PaulTroo_ has joined #bitcoin-core-dev
546 2020-08-17T19:45:02  *** bitcoin-git has joined #bitcoin-core-dev
547 2020-08-17T19:45:02  <bitcoin-git> [bitcoin] achow101 opened pull request #19754: wallet: Move UpdateWalletSetting to wallet module and use from GUI interface (master...load-on-start-gui) https://github.com/bitcoin/bitcoin/pull/19754
548 2020-08-17T19:45:13  *** bitcoin-git has left #bitcoin-core-dev
549 2020-08-17T20:07:54  *** nullptr| has quit IRC
550 2020-08-17T20:07:56  *** Murch has joined #bitcoin-core-dev
551 2020-08-17T20:08:38  *** Talkless has quit IRC
552 2020-08-17T20:09:00  *** nullptr| has joined #bitcoin-core-dev
553 2020-08-17T20:10:45  <ryanofsky> difference between gui and rpc unloading sequences is that gui sequence is nonblocking while rpc blocks, but that code is a mess
554 2020-08-17T20:11:57  <ryanofsky> i started changes to clean it up https://github.com/ryanofsky/bitcoin/commits/pr/path.1, #19619 came out of that
555 2020-08-17T20:12:01  <gribble> https://github.com/bitcoin/bitcoin/issues/19619 | Remove wallet.dat path handling from wallet.cpp, rpcwallet.cpp by ryanofsky · Pull Request #19619 · bitcoin/bitcoin · GitHub
556 2020-08-17T20:13:57  *** Guyver2_ has joined #bitcoin-core-dev
557 2020-08-17T20:15:04  *** Guyver2 has quit IRC
558 2020-08-17T20:28:16  *** Guyver2_ has quit IRC
559 2020-08-17T20:28:35  *** mrostecki has joined #bitcoin-core-dev
560 2020-08-17T20:32:46  *** pinheadmz has joined #bitcoin-core-dev
561 2020-08-17T20:35:16  *** owowo has quit IRC
562 2020-08-17T20:39:48  *** owowo has joined #bitcoin-core-dev
563 2020-08-17T21:00:02  *** tflgen2 has quit IRC
564 2020-08-17T21:06:42  *** PaulTroo_ has quit IRC
565 2020-08-17T21:07:11  *** Sample-dev has joined #bitcoin-core-dev
566 2020-08-17T21:08:57  *** Sample-dev has quit IRC
567 2020-08-17T21:09:39  *** dongcarl has quit IRC
568 2020-08-17T21:09:54  *** dongcarl has joined #bitcoin-core-dev
569 2020-08-17T21:22:25  *** hari has joined #bitcoin-core-dev
570 2020-08-17T21:22:27  *** hari is now known as Guest25230
571 2020-08-17T21:25:25  *** dongcarl has quit IRC
572 2020-08-17T21:25:41  *** dongcarl has joined #bitcoin-core-dev
573 2020-08-17T21:40:40  *** dongcarl has quit IRC
574 2020-08-17T21:40:56  *** dongcarl has joined #bitcoin-core-dev
575 2020-08-17T21:48:13  *** marcoagner has quit IRC
576 2020-08-17T21:55:53  *** dongcarl has quit IRC
577 2020-08-17T21:56:08  *** dongcarl has joined #bitcoin-core-dev
578 2020-08-17T22:02:31  *** luke-jr has quit IRC
579 2020-08-17T22:02:57  *** luke-jr has joined #bitcoin-core-dev
580 2020-08-17T22:11:09  *** dongcarl has quit IRC
581 2020-08-17T22:11:24  *** dongcarl has joined #bitcoin-core-dev
582 2020-08-17T22:26:12  *** dongcarl has quit IRC
583 2020-08-17T22:26:13  *** mdunnio has quit IRC
584 2020-08-17T22:26:27  *** dongcarl has joined #bitcoin-core-dev
585 2020-08-17T22:41:40  *** dongcarl has quit IRC
586 2020-08-17T22:41:55  *** dongcarl has joined #bitcoin-core-dev
587 2020-08-17T22:48:41  *** watersnake1 has quit IRC
588 2020-08-17T22:55:46  *** vasild_ has joined #bitcoin-core-dev
589 2020-08-17T22:57:01  *** dongcarl has quit IRC
590 2020-08-17T22:57:17  *** dongcarl has joined #bitcoin-core-dev
591 2020-08-17T22:58:43  *** vasild has quit IRC
592 2020-08-17T22:58:44  *** vasild_ is now known as vasild
593 2020-08-17T23:00:13  *** Eagle[TM] has quit IRC
594 2020-08-17T23:12:27  *** dongcarl has quit IRC
595 2020-08-17T23:12:42  *** dongcarl has joined #bitcoin-core-dev
596 2020-08-17T23:16:37  *** weedcoder has quit IRC
597 2020-08-17T23:19:01  *** nullptr_ has joined #bitcoin-core-dev
598 2020-08-17T23:21:13  *** nullptr| has quit IRC
599 2020-08-17T23:27:37  *** dongcarl has quit IRC
600 2020-08-17T23:27:52  *** dongcarl has joined #bitcoin-core-dev
601 2020-08-17T23:37:06  *** troygiorshev has quit IRC
602 2020-08-17T23:41:21  *** Evel-Knievel has quit IRC
603 2020-08-17T23:42:05  *** Evel-Knievel has joined #bitcoin-core-dev
604 2020-08-17T23:42:45  *** dongcarl has quit IRC
605 2020-08-17T23:43:00  *** dongcarl has joined #bitcoin-core-dev
606 2020-08-17T23:51:00  <sipa> achow101: any idea how i can resolve this bdb error?
607 2020-08-17T23:51:00  <sipa> BDB0552 Page 0: last_pgno is not correct: 272 != 287
608 2020-08-17T23:51:01  <sipa> wallet.dat: BDB0090 DB_VERIFY_BAD: Database verification failed
609 2020-08-17T23:51:07  <sipa> when starting bitcoind?
610 2020-08-17T23:51:46  <achow101> Sounds like part of the database is missing
611 2020-08-17T23:52:31  <sipa> all my wallet files have this
612 2020-08-17T23:52:49  <sipa> if i stop loading one, the next one gives that error
613 2020-08-17T23:54:33  <achow101> Huh.
614 2020-08-17T23:55:07  <achow101> Same mismatching last_pgno or different numbers?
615 2020-08-17T23:55:36  <sipa> i just ran db_dump | db_load on all of them
616 2020-08-17T23:55:37  <sipa> now it works
617 2020-08-17T23:56:33  <achow101> were these copied from another system?
618 2020-08-17T23:56:36  <sipa> nope
619 2020-08-17T23:56:42  <achow101> just randomly happened today?
620 2020-08-17T23:56:53  <sipa> yes, they worked 3 days ago
621 2020-08-17T23:56:59  <sipa> i may have recompiled in between
622 2020-08-17T23:57:30  <sipa> i know this isn't a useful bug report, as i don't know what commit exactly i was using before
623 2020-08-17T23:58:01  <sipa> it may also have been an unclean shutdown
624 2020-08-17T23:58:03  *** dongcarl has quit IRC
625 2020-08-17T23:58:18  *** dongcarl has joined #bitcoin-core-dev
626 2020-08-17T23:58:46  <sipa> actually, pretty sure it was an unclean shutdown, i'm also getting "Rolling forward" messages now
627 2020-08-17T23:58:56  <achow101> So that particular error is that the metadata says there are 287 pages, but the actual number of pages was 272
628 2020-08-17T23:59:14  <achow101> if you had an unclean shutdown, then it seems reasonable that the metadata could have been updated but not the file itself
629 2020-08-17T23:59:33  <achow101> *metadata meaning the metadata page of the file
630 2020-08-17T23:59:41  *** justanotheruser has quit IRC
631 2020-08-17T23:59:55  * sipa is scared of bdb...