1 2020-09-07T00:00:02  *** greylica has quit IRC
  2 2020-09-07T00:05:49  *** melande1 has quit IRC
  3 2020-09-07T00:06:11  *** melande1 has joined #bitcoin-core-dev
  4 2020-09-07T00:11:15  *** davterra has joined #bitcoin-core-dev
  5 2020-09-07T00:21:27  *** davec has quit IRC
  6 2020-09-07T00:21:55  *** davec has joined #bitcoin-core-dev
  7 2020-09-07T00:22:07  *** ChrisMarquardt has joined #bitcoin-core-dev
  8 2020-09-07T00:22:51  *** dhruvm_ has left #bitcoin-core-dev
  9 2020-09-07T00:27:49  *** melande1 has quit IRC
 10 2020-09-07T00:28:12  *** melande1 has joined #bitcoin-core-dev
 11 2020-09-07T00:29:45  *** dhruvm has quit IRC
 12 2020-09-07T00:52:47  *** davec has quit IRC
 13 2020-09-07T00:53:05  *** davec has joined #bitcoin-core-dev
 14 2020-09-07T01:05:23  *** Eagle[TM] has joined #bitcoin-core-dev
 15 2020-09-07T01:06:45  *** dhruvm has joined #bitcoin-core-dev
 16 2020-09-07T01:06:59  *** EagleTM has quit IRC
 17 2020-09-07T01:10:12  *** melande2 has joined #bitcoin-core-dev
 18 2020-09-07T01:10:29  *** melande1 has quit IRC
 19 2020-09-07T01:12:48  *** melande2 has quit IRC
 20 2020-09-07T01:13:10  *** melande2 has joined #bitcoin-core-dev
 21 2020-09-07T01:46:23  <yanmaani> will that kill the db4 dependency?
 22 2020-09-07T01:48:24  <sipa> no
 23 2020-09-07T01:48:38  <sipa> maybe in a few years, but we need to remain compatible with old wallet files
 24 2020-09-07T01:49:15  <yanmaani> ah, and I guess there's no such thing as a import-only db4 hollowed out shell
 25 2020-09-07T01:50:23  <sipa> even if there was, we couldn't use it
 26 2020-09-07T01:50:32  <sipa> people downgrade after upgrading sometimes
 27 2020-09-07T01:51:29  <sipa> it's of course hard to guarantee that being possible arbitrarily long, but 1 or 2 major versions at least makes sense (which matches our support window)
 28 2020-09-07T01:52:39  <yanmaani> But will new wallets from here on out be made using sqlite?
 29 2020-09-07T01:55:58  *** helo has quit IRC
 30 2020-09-07T02:24:02  *** arowser has joined #bitcoin-core-dev
 31 2020-09-07T02:29:05  *** arowser has quit IRC
 32 2020-09-07T02:29:25  *** arowser has joined #bitcoin-core-dev
 33 2020-09-07T02:33:33  *** bitcoin-git has joined #bitcoin-core-dev
 34 2020-09-07T02:33:33  <bitcoin-git> [bitcoin] grubles opened pull request #19903: Update build-openbsd.md with GUI support (master...update-openbsd-build-instructions) https://github.com/bitcoin/bitcoin/pull/19903
 35 2020-09-07T02:33:34  *** bitcoin-git has left #bitcoin-core-dev
 36 2020-09-07T02:34:14  <luke-jr> I think I prefer bdb over sqlite
 37 2020-09-07T02:40:30  <yanmaani> how come?
 38 2020-09-07T02:40:53  <yanmaani> also, why isn't bdb4.8 in the tree, but leveldb is?
 39 2020-09-07T02:41:23  <sipa> leveldb is consensus critical
 40 2020-09-07T02:42:40  <sipa> though for release builds it doesn't really matter, gitian uses pinned versions of all dependencies
 41 2020-09-07T02:44:13  <luke-jr> yanmaani: bdb is time-proven to work reliably and simpler I think
 42 2020-09-07T02:44:26  <luke-jr> yanmaani: sqlite brings nothing much to the table IMO, and it's closed development
 43 2020-09-07T02:44:31  * sipa could not disagree more
 44 2020-09-07T02:44:42  <sipa> bdb reliable? simple?
 45 2020-09-07T02:44:56  <luke-jr> sipa: when was the last time someone had a wallet lost due to bdb?
 46 2020-09-07T02:45:34  <luke-jr> and simplicity is compared to sqlite: there isn't a whole SQL layer involved
 47 2020-09-07T02:45:35  <sipa> luke-jr: me, very recently, after an unclean shutdown... thankfully one without any coins in it
 48 2020-09-07T02:45:39  <luke-jr> sipa: !
 49 2020-09-07T02:45:42  <luke-jr> sipa: 4.8?
 50 2020-09-07T02:45:47  <sipa> 5.3
 51 2020-09-07T02:45:50  <luke-jr> hmm
 52 2020-09-07T02:46:26  <sipa> yes, i agree something like sqlite without the sql layer would be even better
 53 2020-09-07T02:46:32  <sipa> but sqlite is incredibly well tested
 54 2020-09-07T02:46:49  <sipa> so that's a feature i'm happy to take along, we can just ignore it
 55 2020-09-07T02:47:05  <luke-jr> can we?
 56 2020-09-07T02:47:21  <luke-jr> at the very least we need to figure out safe escaping of stuff (though I suspect sqlite includes that)
 57 2020-09-07T02:47:29  <sipa> no, prepared statements
 58 2020-09-07T02:47:40  <luke-jr> anyway, time will show if sqlite works well
 59 2020-09-07T02:47:44  <sipa> you pass in the data as arguments, rather than serialized as strings
 60 2020-09-07T02:48:08  <luke-jr> sipa: I thought that just let sqlite turn them into strings?
 61 2020-09-07T02:48:55  <luke-jr> but I haven't read sqlite code lately so maybe I'm outdated
 62 2020-09-07T02:50:31  <sipa> luke-jr: i suspect no conversion to string and back is done, but i don't think it matters... regardless of what it does, it means we don't need to deal with the complexity of it
 63 2020-09-07T02:50:35  <yanmaani> sqlite is extremely well tested
 64 2020-09-07T02:50:49  *** go11111111111 has joined #bitcoin-core-dev
 65 2020-09-07T02:50:53  <yanmaani> IIRC, it uses int representations internally for ints
 66 2020-09-07T02:51:11  <sipa> well we'd pass everything as byte arrays
 67 2020-09-07T02:51:43  <yanmaani> It's not so big, and I think you can use compile flags to gut the SQL engine by some fraction
 68 2020-09-07T02:52:54  <yanmaani> If you're looking to switch database though, why specifically sqlite, and not say lmdb? Or leveldb?
 69 2020-09-07T02:53:23  *** go121212 has quit IRC
 70 2020-09-07T02:53:31  <sipa> yanmaani: https://github.com/bitcoin/bitcoin/issues/18916#issuecomment-670696563
 71 2020-09-07T02:55:41  <yanmaani> Are wallets big?
 72 2020-09-07T02:55:53  <yanmaani> In terms of file size
 73 2020-09-07T02:55:58  <luke-jr> or we can go the KDE route and use MySQL
 74 2020-09-07T02:56:07  <sipa> luke-jr: aaaargh
 75 2020-09-07T02:56:08  <sipa> :)
 76 2020-09-07T02:56:10  <yanmaani> [screams internally]
 77 2020-09-07T02:56:12  <luke-jr> wait, let's stick to sqlite and just use MySQL for the cache
 78 2020-09-07T02:56:20  <yanmaani> [screams externally]
 79 2020-09-07T02:56:21  <luke-jr> (KDE literally uses MySQL for caches)
 80 2020-09-07T02:56:39  <sipa> yanmaani: 100s of KB to megabytes, typically
 81 2020-09-07T02:56:49  <yanmaani> can't you just use both?
 82 2020-09-07T02:57:06  <yanmaani> That would have pretty much all the desiderata
 83 2020-09-07T02:57:08  <sipa> both what?
 84 2020-09-07T02:57:12  <luke-jr> keys in bdb and metadata in sqlite?
 85 2020-09-07T02:57:12  <yanmaani> databases
 86 2020-09-07T02:57:13  <yanmaani> at once
 87 2020-09-07T02:57:23  <sipa> both what?
 88 2020-09-07T02:57:25  <yanmaani> * Reliable - SQLite is reliable
 89 2020-09-07T02:57:27  <sipa> what are the two options
 90 2020-09-07T02:57:28  <yanmaani> Both databases
 91 2020-09-07T02:57:34  <sipa> sqlite and ...?
 92 2020-09-07T02:57:38  <yanmaani> Both SQLite and BDB4.8 for wallet storage
 93 2020-09-07T02:57:45  <sipa> w t f would you want that
 94 2020-09-07T02:57:48  <luke-jr> lol
 95 2020-09-07T02:57:49  <yanmaani> Lots of reasons
 96 2020-09-07T02:57:55  <sipa> worst of all worlds
 97 2020-09-07T02:57:58  <yanmaani> upgrades are seamless - old versions just disregard the sqlite files
 98 2020-09-07T02:58:06  <yanmaani> downgrades are seamless too
 99 2020-09-07T02:58:23  <yanmaani> the reliability is sqlite's, of course, since those would be used as master by newer versions
100 2020-09-07T02:58:28  <yanmaani> so you'd have full ACID
101 2020-09-07T02:58:28  <sipa> i'm not sure what you're suggesting
102 2020-09-07T02:58:37  <yanmaani> you get a shorter time to tear out db4
103 2020-09-07T02:58:45  <sipa> if what you mean is use bdb for old wallets and sqlite for new ones... that's what the PR does
104 2020-09-07T02:59:04  <yanmaani> You use both databases (SQLite3 and BDB4.8) at once. You do not have any internal distinction between "new" and "old" wallets.
105 2020-09-07T02:59:12  <sipa> ...
106 2020-09-07T02:59:15  <sipa> wtf does that mean
107 2020-09-07T02:59:22  <yanmaani> Whenever you open a BDB-only wallet file, it automatically creates a corresponding sqlite wallet
108 2020-09-07T02:59:30  <yanmaani> When you create a new wallet, it creates a sqlite and a bdb wallet
109 2020-09-07T02:59:31  <sipa> good lord
110 2020-09-07T02:59:37  <yanmaani> No, this has lots of good properties!
111 2020-09-07T02:59:41  * luke-jr backs away slowly
112 2020-09-07T02:59:43  <sipa> go away, please
113 2020-09-07T02:59:52  <yanmaani> So, first off, you get the nice properties of SQLite.
114 2020-09-07T03:00:01  *** ChrisMarquardt has quit IRC
115 2020-09-07T03:00:02  <sipa> ...
116 2020-09-07T03:00:03  <yanmaani> You wouldn't have the data problems that bdb has. If BDB crashes, too bad, who cares.
117 2020-09-07T03:00:11  <yanmaani> But the old versions can still read the BDB version of the database.
118 2020-09-07T03:00:20  <sipa> whyyyyyyy
119 2020-09-07T03:00:28  <luke-jr> so you basically mean switch to sqlite, but keep a BDB copy updated in case of sudden urge to downgrade?
120 2020-09-07T03:00:29  <yanmaani> The code complexity is about the same.
121 2020-09-07T03:00:39  <yanmaani> luke-jr: Yes. Because then you can tear out db4 faster.
122 2020-09-07T03:00:46  <sipa> i wish you good luck
123 2020-09-07T03:00:49  <luke-jr> I don't think that follows
124 2020-09-07T03:00:52  <yanmaani> If you do this, then everyone switches to the new version, there will be a sqlite file.
125 2020-09-07T03:01:03  <yanmaani> Unless they migrate from v_nosqlite to v_onlysqlite directly
126 2020-09-07T03:01:11  <luke-jr> hmm
127 2020-09-07T03:01:13  <sipa> all the management issues get multiplied
128 2020-09-07T03:01:22  <sipa> what if files are out of sync?
129 2020-09-07T03:01:22  <yanmaani> as long as they migrate through one of the intermediate sqlite versions, there will be a sqlite wallet created
130 2020-09-07T03:01:33  <sipa> what if people migrated one, but not the other, from one system to another?
131 2020-09-07T03:01:44  <yanmaani> How would you migrate only one of them?
132 2020-09-07T03:01:47  <yanmaani> If there's only one file, use that
133 2020-09-07T03:01:51  <sipa> users are stupid
134 2020-09-07T03:02:12  <sipa> if every user was a system administrator, BDB would be an awesome choice
135 2020-09-07T03:02:12  <yanmaani> If there's two files, load both and take the one last modified
136 2020-09-07T03:02:15  <sipa> that's what it's designed for
137 2020-09-07T03:02:22  <sipa> but users aren't
138 2020-09-07T03:02:35  <yanmaani> If the users only copy one database file, there's no problem though
139 2020-09-07T03:03:00  <sipa> seriously, i can't comprehend how you think that makes anything better
140 2020-09-07T03:03:11  <yanmaani> It makes cross-version migration more seamless
141 2020-09-07T03:03:14  <sipa> all the issues with the mental overhead of understanding what a wallet is get worse
142 2020-09-07T03:03:39  <yanmaani> a wallet is the wallet_dat/ folder
143 2020-09-07T03:03:52  <sipa> that's specifially what we should get rid of
144 2020-09-07T03:03:56  <sipa> among other things
145 2020-09-07T03:04:05  <yanmaani> Yes, when db4 is retired you can get rid of it
146 2020-09-07T03:04:09  <yanmaani> and return to wallet.dat(sqlite)
147 2020-09-07T03:04:14  <sipa> yay, great
148 2020-09-07T03:04:27  <yanmaani> But with this approach, you'll never have the problem of "user installed sqlite version but didn't upgrade his wallet"
149 2020-09-07T03:04:33  <sipa> i don't see how making our database a frankenstein-monster-of-bdb-and-sqlite helps with that
150 2020-09-07T03:04:35  <yanmaani> because wallet upgrades will be done transparently in the background
151 2020-09-07T03:05:03  <yanmaani> because it's only temporary - once everyone has upgraded, you can rip out db4 entirely
152 2020-09-07T03:05:13  <sipa> no you can't
153 2020-09-07T03:05:21  <sipa> backups need to keep working
154 2020-09-07T03:05:24  <sipa> even years old ones
155 2020-09-07T03:05:37  <yanmaani> With "old wallet" and "new wallet", if you're to rip out db4, users will at some point in time have to convert them
156 2020-09-07T03:05:51  <sipa> yes
157 2020-09-07T03:06:01  <yanmaani> can't they just be asked to download an old version? But yes, that's a good point otherwise
158 2020-09-07T03:06:04  <sipa> but i don't see how doing what you suggests allows doing this any earlier
159 2020-09-07T03:06:16  <yanmaani> In my model, users would never have to upgrade formats manually
160 2020-09-07T03:06:24  <yanmaani> first they have db4-only wallets
161 2020-09-07T03:06:31  <yanmaani> then they have db4+sqlite wallets
162 2020-09-07T03:06:44  <yanmaani> then db4 is dropped, and they have <garbage>+sqlite wallets
163 2020-09-07T03:06:51  <yanmaani> the conversion would be done silently and transparently to the user
164 2020-09-07T03:06:56  <sipa> i really really don't see the advantage
165 2020-09-07T03:07:05  <sipa> even ignoring all the disadvantages
166 2020-09-07T03:07:18  <yanmaani> easier migration process, no need for users to make the effort of upgrading wallet from sqlite to db4
167 2020-09-07T03:07:53  <sipa> unless they missed the window during which versions with mixed support existed
168 2020-09-07T03:08:18  <yanmaani> yeah, but that's still much less user effort isn't it?
169 2020-09-07T03:08:45  <sipa> eh
170 2020-09-07T03:08:56  <sipa> it's something that i expect will happen in 5 years or so
171 2020-09-07T03:08:59  <sipa> maybe more
172 2020-09-07T03:09:39  <sipa> i'm more concerned about things working in the next release than what happens then
173 2020-09-07T03:09:40  <yanmaani> You might also just say "we're done with db4, if you load a db4 wallet you will be given the option to convert or exit, you can't just load it"
174 2020-09-07T03:10:08  <yanmaani> whenever you get fed up with it
175 2020-09-07T03:10:15  <sipa> and i really don't want to think about all the things that can go wrong with duplicated bdb+sqlite wallets
176 2020-09-07T03:10:18  <yanmaani> Will you be using sqlite's encryption layer too?
177 2020-09-07T03:10:36  <sipa> look at the PR, i'm not the author :)
178 2020-09-07T03:10:39  <sipa> i don't think so
179 2020-09-07T03:15:16  *** gribble has quit IRC
180 2020-09-07T03:30:52  *** gribble has joined #bitcoin-core-dev
181 2020-09-07T03:37:07  *** arowser has quit IRC
182 2020-09-07T03:37:26  *** arowser has joined #bitcoin-core-dev
183 2020-09-07T03:50:08  *** arowser has quit IRC
184 2020-09-07T03:50:27  *** arowser has joined #bitcoin-core-dev
185 2020-09-07T03:55:11  *** them_ has joined #bitcoin-core-dev
186 2020-09-07T03:57:38  *** bitcoin-git has joined #bitcoin-core-dev
187 2020-09-07T03:57:38  <bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/56d47e19edca...78cb45d72251
188 2020-09-07T03:57:39  <bitcoin-git> bitcoin/master abac436 João Barbosa: wallet: Avoid multiple BerkeleyBatch in DelAddressBook
189 2020-09-07T03:57:39  <bitcoin-git> bitcoin/master 78cb45d Samuel Dobson: Merge #19738: wallet: Avoid multiple BerkeleyBatch in DelAddressBook
190 2020-09-07T03:57:41  *** bitcoin-git has left #bitcoin-core-dev
191 2020-09-07T03:57:58  *** bitcoin-git has joined #bitcoin-core-dev
192 2020-09-07T03:57:58  <bitcoin-git> [bitcoin] meshcollider merged pull request #19738: wallet: Avoid multiple BerkeleyBatch in DelAddressBook (master...2020-08-deladdressbook) https://github.com/bitcoin/bitcoin/pull/19738
193 2020-09-07T03:57:59  *** bitcoin-git has left #bitcoin-core-dev
194 2020-09-07T04:03:48  <meshcollider> yanmaani: no, not using their encryption stuff
195 2020-09-07T04:15:46  *** TheHoliestRoger has quit IRC
196 2020-09-07T04:17:33  *** shesek has quit IRC
197 2020-09-07T04:18:07  *** TheHoliestRoger has joined #bitcoin-core-dev
198 2020-09-07T04:28:11  *** justanotheruser has quit IRC
199 2020-09-07T04:32:20  *** flag has quit IRC
200 2020-09-07T04:38:31  <achow101> sipa, yanmaani: armory does something like that. they use some custom binary format that isn't super upgradeable. So to migrate to the new storage method, they make a copy of the wallet in the new storage
201 2020-09-07T04:38:58  *** flag has joined #bitcoin-core-dev
202 2020-09-07T04:39:31  <achow101> yanmaani: migrating a bdb wallet to sqlite could be done without bdb. The database structure is known, so it wouldn't be too hard to write something that just deserializes the database to fetch the records, then writes them to a new sqlite wallet
203 2020-09-07T04:47:37  *** DeanWeen has quit IRC
204 2020-09-07T04:47:42  *** Dean_Guss has joined #bitcoin-core-dev
205 2020-09-07T04:53:00  *** proofofkeags has quit IRC
206 2020-09-07T04:56:19  *** AaronvanW has quit IRC
207 2020-09-07T05:06:01  *** wumpus has quit IRC
208 2020-09-07T05:28:11  *** justanotheruser has joined #bitcoin-core-dev
209 2020-09-07T05:34:58  *** AaronvanW has joined #bitcoin-core-dev
210 2020-09-07T05:36:49  *** arowser has quit IRC
211 2020-09-07T05:39:26  *** arowser has joined #bitcoin-core-dev
212 2020-09-07T05:39:44  *** AaronvanW has quit IRC
213 2020-09-07T05:47:11  *** bitcoin-git has joined #bitcoin-core-dev
214 2020-09-07T05:47:11  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19905: Remove dead CheckForkWarningConditionsOnNewFork (master...2009-noFork) https://github.com/bitcoin/bitcoin/pull/19905
215 2020-09-07T05:47:12  *** bitcoin-git has left #bitcoin-core-dev
216 2020-09-07T05:56:17  *** bosch has joined #bitcoin-core-dev
217 2020-09-07T05:58:22  *** AaronvanW has joined #bitcoin-core-dev
218 2020-09-07T05:58:38  *** andreacab has joined #bitcoin-core-dev
219 2020-09-07T06:00:01  *** them_ has quit IRC
220 2020-09-07T06:14:42  *** justanotheruser has quit IRC
221 2020-09-07T06:17:35  *** Victor_sueca has joined #bitcoin-core-dev
222 2020-09-07T06:20:49  *** Victorsueca has quit IRC
223 2020-09-07T06:21:40  *** andreacab has quit IRC
224 2020-09-07T06:21:58  *** OldMiner has joined #bitcoin-core-dev
225 2020-09-07T06:22:06  *** andreacab has joined #bitcoin-core-dev
226 2020-09-07T06:23:05  *** Victorsueca has joined #bitcoin-core-dev
227 2020-09-07T06:23:34  *** andreacab has quit IRC
228 2020-09-07T06:23:40  *** andreacab has joined #bitcoin-core-dev
229 2020-09-07T06:23:56  *** Victor_sueca has quit IRC
230 2020-09-07T06:29:45  *** OldMiner has quit IRC
231 2020-09-07T06:45:28  *** Mercury_Vapor has quit IRC
232 2020-09-07T06:45:55  *** Mercury_Vapor has joined #bitcoin-core-dev
233 2020-09-07T06:51:08  *** promag has joined #bitcoin-core-dev
234 2020-09-07T06:55:49  *** promag has quit IRC
235 2020-09-07T06:57:30  *** Hellaenergy has joined #bitcoin-core-dev
236 2020-09-07T07:03:12  *** bosch has quit IRC
237 2020-09-07T07:10:05  *** arowser has quit IRC
238 2020-09-07T07:10:26  *** arowser has joined #bitcoin-core-dev
239 2020-09-07T07:11:45  <vasild> sipa: https://github.com/bitcoin/bitcoin/pull/19728#pullrequestreview-469679233 "Why not treat all addresses equally (ie relay always to 2 nodes, even addresses from unreachable networks)?"
240 2020-09-07T07:14:05  *** arowser has quit IRC
241 2020-09-07T07:14:25  *** arowser has joined #bitcoin-core-dev
242 2020-09-07T07:15:53  *** andreacab has quit IRC
243 2020-09-07T07:17:58  <sipa> vasild: maybe that's what will be needed, but i'd like to retain the existing behavior of primarily relaying reachable addresses
244 2020-09-07T07:18:05  *** andreacab has joined #bitcoin-core-dev
245 2020-09-07T07:18:14  <sipa> so that ipv6 nodes find eachother preferentially etc
246 2020-09-07T07:18:36  <vasild> ack
247 2020-09-07T07:23:13  *** andreacab has quit IRC
248 2020-09-07T07:27:38  *** belcher_ has joined #bitcoin-core-dev
249 2020-09-07T07:27:56  *** marcoagner has joined #bitcoin-core-dev
250 2020-09-07T07:29:04  *** Eagle[TM] has quit IRC
251 2020-09-07T07:30:41  *** EagleTM has joined #bitcoin-core-dev
252 2020-09-07T07:31:22  *** belcher has quit IRC
253 2020-09-07T07:33:00  *** andreacab has joined #bitcoin-core-dev
254 2020-09-07T07:48:36  *** kljasdfvv has joined #bitcoin-core-dev
255 2020-09-07T07:52:13  *** bitcoin-git has joined #bitcoin-core-dev
256 2020-09-07T07:52:13  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/78cb45d72251...07087051afe9
257 2020-09-07T07:52:14  <bitcoin-git> bitcoin/master eeee110 MarcoFalke: Remove mempool global from init
258 2020-09-07T07:52:14  <bitcoin-git> bitcoin/master fa0359c MarcoFalke: Remove mempool global from p2p
259 2020-09-07T07:52:15  <bitcoin-git> bitcoin/master fafb381 MarcoFalke: Remove mempool global
260 2020-09-07T07:52:25  *** bitcoin-git has left #bitcoin-core-dev
261 2020-09-07T07:52:43  *** bitcoin-git has joined #bitcoin-core-dev
262 2020-09-07T07:52:44  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19556: Remove mempool global (master...Mf1808-txpoolGlobal) https://github.com/bitcoin/bitcoin/pull/19556
263 2020-09-07T07:52:45  *** bitcoin-git has left #bitcoin-core-dev
264 2020-09-07T08:03:19  *** promag has joined #bitcoin-core-dev
265 2020-09-07T08:04:47  *** promag has quit IRC
266 2020-09-07T08:05:04  *** promag has joined #bitcoin-core-dev
267 2020-09-07T08:20:51  *** andreacab has quit IRC
268 2020-09-07T08:21:19  *** andreacab has joined #bitcoin-core-dev
269 2020-09-07T08:24:07  *** promag has quit IRC
270 2020-09-07T08:24:34  *** andreacab has quit IRC
271 2020-09-07T08:24:40  *** andreacab has joined #bitcoin-core-dev
272 2020-09-07T08:24:48  *** promag has joined #bitcoin-core-dev
273 2020-09-07T08:26:57  *** promag has quit IRC
274 2020-09-07T08:29:22  *** promag has joined #bitcoin-core-dev
275 2020-09-07T08:32:16  *** promag has quit IRC
276 2020-09-07T08:36:05  *** arowser has quit IRC
277 2020-09-07T08:36:25  *** arowser has joined #bitcoin-core-dev
278 2020-09-07T08:52:28  *** jonatack has quit IRC
279 2020-09-07T09:00:02  *** Hellaenergy has quit IRC
280 2020-09-07T09:00:05  *** icota[m] has quit IRC
281 2020-09-07T09:00:36  *** mekster has quit IRC
282 2020-09-07T09:06:21  *** palazzovincenzo has joined #bitcoin-core-dev
283 2020-09-07T09:07:22  *** palazzovincenzo has quit IRC
284 2020-09-07T09:08:45  *** vincenzopalazzo has quit IRC
285 2020-09-07T09:14:56  *** andreacab has quit IRC
286 2020-09-07T09:21:41  *** tlyu has joined #bitcoin-core-dev
287 2020-09-07T09:22:42  *** EagleTM has quit IRC
288 2020-09-07T09:36:44  *** davec has quit IRC
289 2020-09-07T09:38:22  *** mrostecki has joined #bitcoin-core-dev
290 2020-09-07T09:40:32  *** davec has joined #bitcoin-core-dev
291 2020-09-07T09:42:11  *** promag has joined #bitcoin-core-dev
292 2020-09-07T09:50:43  *** mekster has joined #bitcoin-core-dev
293 2020-09-07T09:52:11  *** davec has quit IRC
294 2020-09-07T09:52:31  *** promag has quit IRC
295 2020-09-07T09:56:00  *** davec has joined #bitcoin-core-dev
296 2020-09-07T09:57:15  *** andreacab has joined #bitcoin-core-dev
297 2020-09-07T10:00:28  *** promag has joined #bitcoin-core-dev
298 2020-09-07T10:01:24  <jnewbery> Great stuff Marco. Really good to see progress being made there. Thanks for getting it done.
299 2020-09-07T10:01:30  *** andreacab has quit IRC
300 2020-09-07T10:02:15  *** promag has quit IRC
301 2020-09-07T10:08:44  *** promag has joined #bitcoin-core-dev
302 2020-09-07T10:10:13  *** bitcoin-git has joined #bitcoin-core-dev
303 2020-09-07T10:10:13  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/07087051afe9...25839661305e
304 2020-09-07T10:10:14  <bitcoin-git> bitcoin/master 46d955d Jeremy Rubin: Remove mapLinks in favor of entry inlined structs with iterator type erasu...
305 2020-09-07T10:10:15  <bitcoin-git> bitcoin/master 296be8f Jeremy Rubin: Get rid of unused functions CTxMemPool::GetMemPoolChildren, CTxMemPool::Ge...
306 2020-09-07T10:10:15  <bitcoin-git> bitcoin/master 2583966 MarcoFalke: Merge #19478: Remove CTxMempool::mapLinks data structure member
307 2020-09-07T10:10:17  *** bitcoin-git has left #bitcoin-core-dev
308 2020-09-07T10:10:43  *** bitcoin-git has joined #bitcoin-core-dev
309 2020-09-07T10:10:44  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19478: Remove CTxMempool::mapLinks data structure member (master...epoch-mempool-clean-split-3) https://github.com/bitcoin/bitcoin/pull/19478
310 2020-09-07T10:10:44  *** bitcoin-git has left #bitcoin-core-dev
311 2020-09-07T10:16:10  *** andreacab has joined #bitcoin-core-dev
312 2020-09-07T10:18:23  *** Keely73Feil has joined #bitcoin-core-dev
313 2020-09-07T10:22:33  *** andreacab has quit IRC
314 2020-09-07T10:23:01  *** andreacab has joined #bitcoin-core-dev
315 2020-09-07T10:23:37  *** jonatack has joined #bitcoin-core-dev
316 2020-09-07T10:27:17  *** andreacab has quit IRC
317 2020-09-07T10:31:48  *** andreacab has joined #bitcoin-core-dev
318 2020-09-07T10:38:11  *** promag has quit IRC
319 2020-09-07T10:42:13  *** bitcoin-git has joined #bitcoin-core-dev
320 2020-09-07T10:42:13  <bitcoin-git> [bitcoin] naumenkogs opened pull request #19906: Bugfix: don't make collision from "tried" a feeler  (master...2020-09-feeler-no-collisions) https://github.com/bitcoin/bitcoin/pull/19906
321 2020-09-07T10:42:16  *** bitcoin-git has left #bitcoin-core-dev
322 2020-09-07T10:43:42  *** promag has joined #bitcoin-core-dev
323 2020-09-07T10:56:00  *** promag has quit IRC
324 2020-09-07T10:56:27  *** worc3131 has joined #bitcoin-core-dev
325 2020-09-07T10:59:03  *** vasild has quit IRC
326 2020-09-07T11:03:48  *** promag has joined #bitcoin-core-dev
327 2020-09-07T11:05:31  *** promag has quit IRC
328 2020-09-07T11:06:07  *** vasild has joined #bitcoin-core-dev
329 2020-09-07T11:11:45  *** promag has joined #bitcoin-core-dev
330 2020-09-07T11:16:17  *** andreacab has quit IRC
331 2020-09-07T11:16:50  *** andreacab has joined #bitcoin-core-dev
332 2020-09-07T11:18:05  *** arowser has quit IRC
333 2020-09-07T11:18:25  *** arowser has joined #bitcoin-core-dev
334 2020-09-07T11:21:16  *** andreacab has quit IRC
335 2020-09-07T11:26:03  *** gzhao408 has joined #bitcoin-core-dev
336 2020-09-07T11:28:19  *** andreacab has joined #bitcoin-core-dev
337 2020-09-07T11:31:43  *** andreacab has quit IRC
338 2020-09-07T11:32:11  *** andreacab has joined #bitcoin-core-dev
339 2020-09-07T11:33:27  *** andreaca_ has joined #bitcoin-core-dev
340 2020-09-07T11:36:36  *** andreaca_ has quit IRC
341 2020-09-07T11:36:40  *** andreacab has quit IRC
342 2020-09-07T11:37:03  *** andreacab has joined #bitcoin-core-dev
343 2020-09-07T11:41:19  *** andreacab has quit IRC
344 2020-09-07T11:42:03  *** sipa has quit IRC
345 2020-09-07T11:49:11  *** sipa has joined #bitcoin-core-dev
346 2020-09-07T11:53:57  *** promag has quit IRC
347 2020-09-07T11:56:46  *** EagleTM has joined #bitcoin-core-dev
348 2020-09-07T12:00:01  *** tlyu has quit IRC
349 2020-09-07T12:17:03  *** bitcoin-git has joined #bitcoin-core-dev
350 2020-09-07T12:17:03  <bitcoin-git> [bitcoin] dr-orlovsky opened pull request #19907: util: add psbt combiner role (master...feat/psbt-combiner) https://github.com/bitcoin/bitcoin/pull/19907
351 2020-09-07T12:17:04  *** bitcoin-git has left #bitcoin-core-dev
352 2020-09-07T12:20:40  *** I440r has joined #bitcoin-core-dev
353 2020-09-07T12:25:48  *** Keely73Feil has quit IRC
354 2020-09-07T12:33:22  *** Highway61 has joined #bitcoin-core-dev
355 2020-09-07T12:37:01  *** jonatack has quit IRC
356 2020-09-07T12:39:38  *** Guyver2 has joined #bitcoin-core-dev
357 2020-09-07T12:57:08  *** promag has joined #bitcoin-core-dev
358 2020-09-07T12:58:05  *** arowser has quit IRC
359 2020-09-07T12:58:25  *** arowser has joined #bitcoin-core-dev
360 2020-09-07T12:58:45  <yanmaani> achow101: If that's the case then maybe you could do it like: have a bdb database, open it, move all the stuff into a sqlite database
361 2020-09-07T12:59:02  <yanmaani> on a clean shutdown, copy the data back into bdb, sync, exit
362 2020-09-07T12:59:10  <yanmaani> (and remove sqlite)
363 2020-09-07T12:59:18  <yanmaani> on a dirty shutdown, sqlite will still persist
364 2020-09-07T13:01:34  *** promag has quit IRC
365 2020-09-07T13:04:05  *** arowser has quit IRC
366 2020-09-07T13:04:26  *** arowser has joined #bitcoin-core-dev
367 2020-09-07T13:05:05  *** arowser has quit IRC
368 2020-09-07T13:05:25  *** arowser has joined #bitcoin-core-dev
369 2020-09-07T13:05:31  *** Highway61 has quit IRC
370 2020-09-07T13:06:05  *** arowser has quit IRC
371 2020-09-07T13:06:25  *** arowser has joined #bitcoin-core-dev
372 2020-09-07T13:09:05  *** arowser has quit IRC
373 2020-09-07T13:09:25  *** arowser has joined #bitcoin-core-dev
374 2020-09-07T13:10:06  *** arowser has quit IRC
375 2020-09-07T13:10:25  *** arowser has joined #bitcoin-core-dev
376 2020-09-07T13:11:05  *** arowser has quit IRC
377 2020-09-07T13:11:28  *** arowser has joined #bitcoin-core-dev
378 2020-09-07T13:13:05  *** arowser has quit IRC
379 2020-09-07T13:13:25  *** arowser has joined #bitcoin-core-dev
380 2020-09-07T13:14:05  *** arowser has quit IRC
381 2020-09-07T13:14:24  *** arowser has joined #bitcoin-core-dev
382 2020-09-07T13:16:49  *** bzb has joined #bitcoin-core-dev
383 2020-09-07T13:22:41  *** davec has quit IRC
384 2020-09-07T13:26:04  *** EagleTM has quit IRC
385 2020-09-07T13:26:20  *** davec has joined #bitcoin-core-dev
386 2020-09-07T13:28:34  *** Highway61 has joined #bitcoin-core-dev
387 2020-09-07T13:32:54  *** Highway61 has quit IRC
388 2020-09-07T13:36:16  *** Fitti has joined #bitcoin-core-dev
389 2020-09-07T13:38:58  *** Fitti has quit IRC
390 2020-09-07T13:58:04  *** arowser has quit IRC
391 2020-09-07T13:58:47  *** arowser has joined #bitcoin-core-dev
392 2020-09-07T14:00:31  *** mdunnio has joined #bitcoin-core-dev
393 2020-09-07T14:14:00  *** bzb has quit IRC
394 2020-09-07T14:16:55  *** AaronvanW has quit IRC
395 2020-09-07T14:18:44  *** tralfaz has joined #bitcoin-core-dev
396 2020-09-07T14:19:43  *** davterra has quit IRC
397 2020-09-07T14:28:05  *** arowser has quit IRC
398 2020-09-07T14:28:25  *** arowser has joined #bitcoin-core-dev
399 2020-09-07T14:29:40  *** EagleTM has joined #bitcoin-core-dev
400 2020-09-07T14:30:07  *** arowser has quit IRC
401 2020-09-07T14:30:26  *** arowser has joined #bitcoin-core-dev
402 2020-09-07T14:46:32  *** bitcoin-git has joined #bitcoin-core-dev
403 2020-09-07T14:46:32  <bitcoin-git> [bitcoin] naumenkogs closed pull request #19906: Bugfix: don't make collision from "tried" a feeler  (master...2020-09-feeler-no-collisions) https://github.com/bitcoin/bitcoin/pull/19906
404 2020-09-07T14:46:33  *** bitcoin-git has left #bitcoin-core-dev
405 2020-09-07T14:46:52  *** bitcoin-git has joined #bitcoin-core-dev
406 2020-09-07T14:46:52  <bitcoin-git> [bitcoin] naumenkogs reopened pull request #19906: Bugfix: don't make collision from "tried" a feeler  (master...2020-09-feeler-no-collisions) https://github.com/bitcoin/bitcoin/pull/19906
407 2020-09-07T14:46:53  *** bitcoin-git has left #bitcoin-core-dev
408 2020-09-07T14:48:57  *** bitcoin-git has joined #bitcoin-core-dev
409 2020-09-07T14:48:57  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19909: txmempool: Remove unused clear() member function (master...2009-noTxpoolClear) https://github.com/bitcoin/bitcoin/pull/19909
410 2020-09-07T14:48:58  *** bitcoin-git has left #bitcoin-core-dev
411 2020-09-07T14:55:28  *** AaronvanW has joined #bitcoin-core-dev
412 2020-09-07T14:58:44  *** Highway61 has joined #bitcoin-core-dev
413 2020-09-07T14:59:45  *** AaronvanW has quit IRC
414 2020-09-07T15:00:02  *** I440r has quit IRC
415 2020-09-07T15:01:01  *** Highway61 has quit IRC
416 2020-09-07T15:02:00  *** Highway61 has joined #bitcoin-core-dev
417 2020-09-07T15:03:34  *** Highway61 has quit IRC
418 2020-09-07T15:04:25  *** mdunnio has quit IRC
419 2020-09-07T15:08:13  *** shesek has joined #bitcoin-core-dev
420 2020-09-07T15:08:13  *** shesek has joined #bitcoin-core-dev
421 2020-09-07T15:10:33  *** Highway61 has joined #bitcoin-core-dev
422 2020-09-07T15:24:05  *** arowser has quit IRC
423 2020-09-07T15:24:23  *** arowser has joined #bitcoin-core-dev
424 2020-09-07T15:25:04  *** jonatack has joined #bitcoin-core-dev
425 2020-09-07T15:26:44  *** justanotheruser has joined #bitcoin-core-dev
426 2020-09-07T15:28:05  *** arowser has quit IRC
427 2020-09-07T15:28:47  *** arowser has joined #bitcoin-core-dev
428 2020-09-07T15:29:40  *** spinza has quit IRC
429 2020-09-07T15:40:45  *** AaronvanW has joined #bitcoin-core-dev
430 2020-09-07T15:49:39  <achow101> yanmaani: copying everything back into bdb is way harder than just reading data from it
431 2020-09-07T15:49:51  *** andreacab has joined #bitcoin-core-dev
432 2020-09-07T15:51:43  *** grubles has joined #bitcoin-core-dev
433 2020-09-07T15:52:40  *** spinza has joined #bitcoin-core-dev
434 2020-09-07T15:56:38  *** sankarshan1 has joined #bitcoin-core-dev
435 2020-09-07T16:00:05  *** andreacab has quit IRC
436 2020-09-07T16:06:47  *** tralfaz is now known as Davterra
437 2020-09-07T16:12:35  *** bitcoin-git has joined #bitcoin-core-dev
438 2020-09-07T16:12:37  <bitcoin-git> [bitcoin] MarcoFalke pushed 11 commits to master: https://github.com/bitcoin/bitcoin/compare/25839661305e...147d50d63e07
439 2020-09-07T16:12:37  <bitcoin-git> bitcoin/master 824bbd1 John Newbery: [move only] Collect all private members of PeerLogicValidation together
440 2020-09-07T16:12:38  <bitcoin-git> bitcoin/master 2297b26 John Newbery: [net_processing] Pass chainparams to PeerLogicValidation constructor
441 2020-09-07T16:12:39  <bitcoin-git> bitcoin/master 58bd369 John Newbery: scripted-diff: [net processing] Rename PeerLogicValidation to PeerManager
442 2020-09-07T16:12:41  *** bitcoin-git has left #bitcoin-core-dev
443 2020-09-07T16:12:44  *** Talkless has joined #bitcoin-core-dev
444 2020-09-07T16:12:55  *** bitcoin-git has joined #bitcoin-core-dev
445 2020-09-07T16:12:55  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19791: [net processing] Move Misbehaving() to PeerManager (master...2020-08-misbehaving-in-plv) https://github.com/bitcoin/bitcoin/pull/19791
446 2020-09-07T16:12:56  *** bitcoin-git has left #bitcoin-core-dev
447 2020-09-07T16:13:32  *** justanotheruser has quit IRC
448 2020-09-07T16:21:12  *** mrostecki_ has joined #bitcoin-core-dev
449 2020-09-07T16:21:45  *** mdunnio has joined #bitcoin-core-dev
450 2020-09-07T16:23:05  *** arowser has quit IRC
451 2020-09-07T16:23:23  *** mrostecki has quit IRC
452 2020-09-07T16:23:26  *** arowser has joined #bitcoin-core-dev
453 2020-09-07T16:24:34  <luke-jr> achow101: btw, have you looked into if sqlite ever leaves stale/deleted data in db files?
454 2020-09-07T16:25:22  <achow101> luke-jr: it does, but there's an option that can be enabled to overwrite the data
455 2020-09-07T16:25:41  <luke-jr> cool
456 2020-09-07T16:25:49  <achow101> that operation can also be done as a one time thing. IIRC I have set it to do that after encrypting
457 2020-09-07T16:33:52  <phantomcircuit> achow101, you going to use wal or no?
458 2020-09-07T16:33:58  <achow101> phantomcircuit: no
459 2020-09-07T16:34:15  <achow101> wal is the cause of a bunch of bdb issues
460 2020-09-07T16:34:34  <phantomcircuit> yeah
461 2020-09-07T16:34:54  <phantomcircuit> it's why there's flush's everywhere and those do i think 3 fsync each call
462 2020-09-07T16:35:28  <achow101> yeah, the PR explicitly disables wal too
463 2020-09-07T16:37:26  <phantomcircuit> achow101, should set application_id as well
464 2020-09-07T16:37:49  <achow101> hmm
465 2020-09-07T16:37:55  <achow101> I suppose so
466 2020-09-07T16:42:05  *** arowser has quit IRC
467 2020-09-07T16:42:46  *** arowser has joined #bitcoin-core-dev
468 2020-09-07T16:48:47  <phantomcircuit> achow101, is there manual vacuum being done? i dont see it
469 2020-09-07T16:49:09  <achow101> It's in the Rewrite() function
470 2020-09-07T16:52:54  <phantomcircuit> also need to set checkpoint_fullfsync if you want real fsync on osx
471 2020-09-07T16:53:17  <phantomcircuit> wait no you want fullfsync
472 2020-09-07T16:55:22  <achow101> You should leave comments on the PR
473 2020-09-07T17:01:04  *** promag has joined #bitcoin-core-dev
474 2020-09-07T17:05:26  <phantomcircuit> achow101, btw i think sqlite in it's normal, non wal operation does create a separate journal file, but only for the time between the transaction commit and the fsync completing
475 2020-09-07T17:05:37  *** promag has quit IRC
476 2020-09-07T17:05:53  <achow101> phantomcircuit: yes, but it deletes it later
477 2020-09-07T17:06:03  <achow101> everything still ends up in the database file after the write
478 2020-09-07T17:06:09  <phantomcircuit> yeah immediately after the fsync completes
479 2020-09-07T17:06:59  <phantomcircuit> achow101, did you consider opening the file with an exclusive lock?
480 2020-09-07T17:07:01  *** justanotheruser has joined #bitcoin-core-dev
481 2020-09-07T17:07:50  <achow101> yes, but we already lock the .walletlock file in the directory so I don't think it's needed
482 2020-09-07T17:07:58  <phantomcircuit> im writting a comment on the pr with some of this stuff btw
483 2020-09-07T17:10:08  <phantomcircuit> achow101, also i notice that you implemented EraseKey which is called by nothing
484 2020-09-07T17:10:40  <achow101> eh? Isn't it called by EraseIC?
485 2020-09-07T17:12:44  <phantomcircuit> achow101, once again github search lies to me
486 2020-09-07T17:12:59  <achow101> lol
487 2020-09-07T17:13:06  <phantomcircuit> it feels like an elastic search cluster that's missing a server constantly
488 2020-09-07T17:13:15  <phantomcircuit> (i think it's literally that, but azure)
489 2020-09-07T17:17:47  *** bitcoin-git has joined #bitcoin-core-dev
490 2020-09-07T17:17:47  <bitcoin-git> [bitcoin] jnewbery opened pull request #19910: net processing: Move peer_map to PeerManager (master...2020-08-peer-plv2) https://github.com/bitcoin/bitcoin/pull/19910
491 2020-09-07T17:17:57  *** bitcoin-git has left #bitcoin-core-dev
492 2020-09-07T17:21:44  *** mdunnio has quit IRC
493 2020-09-07T17:23:39  *** kristapsk has joined #bitcoin-core-dev
494 2020-09-07T17:26:45  *** lightlike has joined #bitcoin-core-dev
495 2020-09-07T17:54:14  *** mdunnio has joined #bitcoin-core-dev
496 2020-09-07T17:58:03  *** sr_gi has quit IRC
497 2020-09-07T17:58:25  *** mdunnio has quit IRC
498 2020-09-07T18:00:02  *** sankarshan1 has quit IRC
499 2020-09-07T18:19:54  *** gribble has quit IRC
500 2020-09-07T18:21:24  *** andreacab has joined #bitcoin-core-dev
501 2020-09-07T18:22:24  *** neutraltc has joined #bitcoin-core-dev
502 2020-09-07T18:25:35  *** davec has quit IRC
503 2020-09-07T18:32:04  *** filchef has joined #bitcoin-core-dev
504 2020-09-07T18:33:48  *** gribble has joined #bitcoin-core-dev
505 2020-09-07T18:38:15  *** davec has joined #bitcoin-core-dev
506 2020-09-07T18:40:48  *** valwal_ has quit IRC
507 2020-09-07T18:43:49  *** t420babe has quit IRC
508 2020-09-07T18:43:49  *** dongcarl has quit IRC
509 2020-09-07T18:48:39  *** EagleTM has quit IRC
510 2020-09-07T18:51:48  *** EagleTM has joined #bitcoin-core-dev
511 2020-09-07T18:55:50  *** andreacab has quit IRC
512 2020-09-07T18:56:19  *** andreacab has joined #bitcoin-core-dev
513 2020-09-07T19:01:06  *** andreacab has quit IRC
514 2020-09-07T19:08:49  *** luke has joined #bitcoin-core-dev
515 2020-09-07T19:10:36  *** vincenzopalazzo has joined #bitcoin-core-dev
516 2020-09-07T19:11:31  *** Talkless has quit IRC
517 2020-09-07T19:12:38  *** Victorsueca has joined #bitcoin-core-dev
518 2020-09-07T19:24:35  *** luke has quit IRC
519 2020-09-07T19:26:54  *** luke has joined #bitcoin-core-dev
520 2020-09-07T19:30:28  *** mdunnio has joined #bitcoin-core-dev
521 2020-09-07T19:33:05  *** bitcoin-git has joined #bitcoin-core-dev
522 2020-09-07T19:33:06  <bitcoin-git> [bitcoin] narula opened pull request #19911: net: guard vRecvGetData with cs_vRecv and orphan_work_set with g_cs_orphans (master...cs_vRecv) https://github.com/bitcoin/bitcoin/pull/19911
523 2020-09-07T19:33:07  *** bitcoin-git has left #bitcoin-core-dev
524 2020-09-07T19:35:19  *** mdunnio has quit IRC
525 2020-09-07T19:35:35  *** braydonf has quit IRC
526 2020-09-07T19:36:12  *** braydonf has joined #bitcoin-core-dev
527 2020-09-07T19:48:03  *** ariard_ is now known as ariard
528 2020-09-07T20:10:08  *** EagleTM has quit IRC
529 2020-09-07T20:21:02  *** luke has quit IRC
530 2020-09-07T20:34:16  *** proofofkeags has joined #bitcoin-core-dev
531 2020-09-07T20:34:38  <jnewbery> hi folks. Reminder that tomorrow at 15:00 UTC is the next p2p meeting. We have one proposed topic so far: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#8-sept-2020
532 2020-09-07T20:34:41  <gribble> https://github.com/bitcoin/bitcoin/issues/8 | RPC command to sign text with wallet private key · Issue #8 · bitcoin/bitcoin · GitHub
533 2020-09-07T20:34:58  <jnewbery> Feel free to add proposed topics to the wiki
534 2020-09-07T20:36:29  *** CubicEarth has quit IRC
535 2020-09-07T20:37:26  *** CubicEarth has joined #bitcoin-core-dev
536 2020-09-07T20:51:49  *** owowo has quit IRC
537 2020-09-07T20:52:56  *** melande2 is now known as melande
538 2020-09-07T20:56:24  *** owowo has joined #bitcoin-core-dev
539 2020-09-07T20:57:25  *** Guyver2 has quit IRC
540 2020-09-07T21:00:01  *** neutraltc has quit IRC
541 2020-09-07T21:03:09  *** Victor_sueca has joined #bitcoin-core-dev
542 2020-09-07T21:05:45  *** Victorsueca has quit IRC
543 2020-09-07T21:06:33  *** owowo has quit IRC
544 2020-09-07T21:06:55  *** owowo has joined #bitcoin-core-dev
545 2020-09-07T21:22:07  *** AIM` has joined #bitcoin-core-dev
546 2020-09-07T21:29:11  *** kristapsk has quit IRC
547 2020-09-07T21:29:43  *** kristapsk has joined #bitcoin-core-dev
548 2020-09-07T21:32:29  *** justanotheruser has quit IRC
549 2020-09-07T21:32:44  *** kristapsk has quit IRC
550 2020-09-07T21:35:30  *** kristapsk has joined #bitcoin-core-dev
551 2020-09-07T21:40:28  *** Dean_Guss has quit IRC
552 2020-09-07T21:40:51  *** Dean_Guss has joined #bitcoin-core-dev
553 2020-09-07T21:42:47  *** dhruvm has quit IRC
554 2020-09-07T21:45:09  *** dhruvm has joined #bitcoin-core-dev
555 2020-09-07T21:50:44  *** justanotheruser has joined #bitcoin-core-dev
556 2020-09-07T21:53:49  *** Dean_Guss has quit IRC
557 2020-09-07T21:54:12  *** Dean_Guss has joined #bitcoin-core-dev
558 2020-09-07T22:00:26  *** bitcoin-git has joined #bitcoin-core-dev
559 2020-09-07T22:00:26  <bitcoin-git> [bitcoin] hebasto opened pull request #19913: refactor: Drop unused `UniqueLock(Mutex*, ...)` constructor in sync.h (master...200907-sync) https://github.com/bitcoin/bitcoin/pull/19913
560 2020-09-07T22:00:27  *** bitcoin-git has left #bitcoin-core-dev
561 2020-09-07T22:01:10  *** kristapsk has quit IRC
562 2020-09-07T22:01:32  *** kristapsk has joined #bitcoin-core-dev
563 2020-09-07T22:10:55  *** dviola has quit IRC
564 2020-09-07T22:12:29  *** dviola has joined #bitcoin-core-dev
565 2020-09-07T22:14:37  *** isis has quit IRC
566 2020-09-07T22:15:54  *** isis has joined #bitcoin-core-dev
567 2020-09-07T22:59:03  *** vasild has quit IRC
568 2020-09-07T23:06:09  *** vasild has joined #bitcoin-core-dev
569 2020-09-07T23:15:47  *** rh0nj has quit IRC
570 2020-09-07T23:15:55  *** braydonf has quit IRC
571 2020-09-07T23:16:07  *** rh0nj has joined #bitcoin-core-dev
572 2020-09-07T23:16:25  *** braydonf has joined #bitcoin-core-dev
573 2020-09-07T23:30:00  *** marcoagner has quit IRC
574 2020-09-07T23:31:50  *** sipa has quit IRC
575 2020-09-07T23:36:18  *** lightlike has quit IRC
576 2020-09-07T23:36:24  *** Victor_sueca has quit IRC
577 2020-09-07T23:37:04  *** sipa has joined #bitcoin-core-dev
578 2020-09-07T23:54:40  *** nsh has quit IRC
579 2020-09-07T23:55:40  *** promag has joined #bitcoin-core-dev
580 2020-09-07T23:58:22  *** nsh has joined #bitcoin-core-dev
581 2020-09-07T23:59:45  *** promag has quit IRC