1 2020-09-09T00:00:01  *** Voker571 has quit IRC
  2 2020-09-09T00:00:32  *** davterra has quit IRC
  3 2020-09-09T00:01:00  *** davterra has joined #bitcoin-core-dev
  4 2020-09-09T00:01:25  *** go121212 has joined #bitcoin-core-dev
  5 2020-09-09T00:03:02  *** mrostecki has joined #bitcoin-core-dev
  6 2020-09-09T00:03:54  *** go11111111111 has quit IRC
  7 2020-09-09T00:06:29  *** mdunnio has quit IRC
  8 2020-09-09T00:06:34  *** Tennis has quit IRC
  9 2020-09-09T00:12:32  *** promag_ has joined #bitcoin-core-dev
 10 2020-09-09T00:13:38  *** Tennis has joined #bitcoin-core-dev
 11 2020-09-09T00:17:19  *** promag_ has quit IRC
 12 2020-09-09T00:22:21  *** Rennex1 has joined #bitcoin-core-dev
 13 2020-09-09T00:27:11  *** gribble has quit IRC
 14 2020-09-09T00:35:16  *** mrostecki has quit IRC
 15 2020-09-09T00:36:43  *** morcos has quit IRC
 16 2020-09-09T00:37:06  *** morcos has joined #bitcoin-core-dev
 17 2020-09-09T00:40:46  *** mdunnio has joined #bitcoin-core-dev
 18 2020-09-09T00:41:40  *** gribble has joined #bitcoin-core-dev
 19 2020-09-09T00:42:05  *** worc3131 has quit IRC
 20 2020-09-09T00:45:43  *** mdunnio has quit IRC
 21 2020-09-09T00:45:49  *** justanotheruser has quit IRC
 22 2020-09-09T00:46:25  *** worc3131 has joined #bitcoin-core-dev
 23 2020-09-09T00:51:26  *** justanotheruser has joined #bitcoin-core-dev
 24 2020-09-09T00:53:06  *** justanotheruser has quit IRC
 25 2020-09-09T01:00:24  *** morcos has quit IRC
 26 2020-09-09T01:01:13  *** morcos has joined #bitcoin-core-dev
 27 2020-09-09T01:12:23  *** afk11 has quit IRC
 28 2020-09-09T01:12:35  *** justanotheruser has joined #bitcoin-core-dev
 29 2020-09-09T01:14:53  *** afk11 has joined #bitcoin-core-dev
 30 2020-09-09T01:15:04  *** arowser has quit IRC
 31 2020-09-09T01:15:29  *** arowser has joined #bitcoin-core-dev
 32 2020-09-09T01:18:36  *** mdunnio has joined #bitcoin-core-dev
 33 2020-09-09T01:18:54  *** AaronvanW has joined #bitcoin-core-dev
 34 2020-09-09T01:23:25  *** mdunnio has quit IRC
 35 2020-09-09T01:24:03  *** sipsorcery has quit IRC
 36 2020-09-09T01:25:26  *** v14 has joined #bitcoin-core-dev
 37 2020-09-09T01:35:00  *** kristapsk has quit IRC
 38 2020-09-09T01:35:28  *** kristapsk has joined #bitcoin-core-dev
 39 2020-09-09T01:39:43  *** morcos has quit IRC
 40 2020-09-09T01:40:54  *** morcos has joined #bitcoin-core-dev
 41 2020-09-09T01:49:59  *** proofofkeags has quit IRC
 42 2020-09-09T01:50:20  *** AaronvanW has quit IRC
 43 2020-09-09T01:53:00  *** v14 has quit IRC
 44 2020-09-09T01:54:05  *** arowser has quit IRC
 45 2020-09-09T01:54:26  *** arowser has joined #bitcoin-core-dev
 46 2020-09-09T01:58:23  *** andreacab has joined #bitcoin-core-dev
 47 2020-09-09T01:58:23  *** morcos has quit IRC
 48 2020-09-09T02:02:51  *** andreacab has quit IRC
 49 2020-09-09T02:03:41  *** morcos has joined #bitcoin-core-dev
 50 2020-09-09T02:06:05  *** arowser has quit IRC
 51 2020-09-09T02:06:25  *** arowser has joined #bitcoin-core-dev
 52 2020-09-09T02:28:12  *** promag_ has joined #bitcoin-core-dev
 53 2020-09-09T02:32:39  *** promag_ has quit IRC
 54 2020-09-09T02:39:24  *** vhuffst has joined #bitcoin-core-dev
 55 2020-09-09T02:40:35  *** isis is now known as isis_
 56 2020-09-09T02:40:44  *** vhuffst has quit IRC
 57 2020-09-09T02:41:59  *** bitcoin-git has joined #bitcoin-core-dev
 58 2020-09-09T02:41:59  <bitcoin-git> [bitcoin] sipa closed pull request #19695: [do not merge] Test impact of secp256k1 endianness detection change (master...202008_test_appveyer_secp256k1) https://github.com/bitcoin/bitcoin/pull/19695
 59 2020-09-09T02:42:00  *** bitcoin-git has left #bitcoin-core-dev
 60 2020-09-09T02:57:32  *** tryphe_ has quit IRC
 61 2020-09-09T02:57:42  *** tryphe_ has joined #bitcoin-core-dev
 62 2020-09-09T03:00:01  *** Rennex1 has quit IRC
 63 2020-09-09T03:04:50  *** go11111111111 has joined #bitcoin-core-dev
 64 2020-09-09T03:04:57  *** go121212 has quit IRC
 65 2020-09-09T03:06:21  *** go121212 has joined #bitcoin-core-dev
 66 2020-09-09T03:09:45  *** go11111111111 has quit IRC
 67 2020-09-09T03:11:03  *** opsec_x122 is now known as opsec_x12
 68 2020-09-09T03:16:24  *** tryphe_ has quit IRC
 69 2020-09-09T03:16:28  *** tryphe has joined #bitcoin-core-dev
 70 2020-09-09T03:19:32  *** mdunnio has joined #bitcoin-core-dev
 71 2020-09-09T03:21:54  *** midnightmagic has joined #bitcoin-core-dev
 72 2020-09-09T03:22:18  *** midnightmagic is now known as Guest32689
 73 2020-09-09T03:23:54  *** mdunnio has quit IRC
 74 2020-09-09T03:30:22  *** Dean_Guss has quit IRC
 75 2020-09-09T03:30:46  *** Dean_Guss has joined #bitcoin-core-dev
 76 2020-09-09T03:32:04  *** arowser has quit IRC
 77 2020-09-09T03:32:23  *** arowser has joined #bitcoin-core-dev
 78 2020-09-09T03:47:31  *** AaronvanW has joined #bitcoin-core-dev
 79 2020-09-09T03:56:38  *** mekster6 has joined #bitcoin-core-dev
 80 2020-09-09T03:57:56  *** Evel-Knievel has quit IRC
 81 2020-09-09T03:57:59  *** sr_gi has quit IRC
 82 2020-09-09T03:58:00  *** sr_gi6 has joined #bitcoin-core-dev
 83 2020-09-09T03:58:02  *** TheHoliestRoger has quit IRC
 84 2020-09-09T03:58:28  *** mekster has quit IRC
 85 2020-09-09T03:58:29  *** mekster6 is now known as mekster
 86 2020-09-09T03:58:41  *** Evel-Knievel has joined #bitcoin-core-dev
 87 2020-09-09T03:59:10  *** proofofkeags has joined #bitcoin-core-dev
 88 2020-09-09T03:59:18  *** TheHoliestRoger has joined #bitcoin-core-dev
 89 2020-09-09T04:19:41  *** promag_ has joined #bitcoin-core-dev
 90 2020-09-09T04:20:32  *** AaronvanW has quit IRC
 91 2020-09-09T04:24:01  *** promag_ has quit IRC
 92 2020-09-09T04:34:23  *** melande has quit IRC
 93 2020-09-09T04:37:00  *** melande has joined #bitcoin-core-dev
 94 2020-09-09T04:53:50  *** tralfaz has joined #bitcoin-core-dev
 95 2020-09-09T04:53:58  *** davterra has quit IRC
 96 2020-09-09T05:11:55  *** melande has quit IRC
 97 2020-09-09T05:12:20  *** melande has joined #bitcoin-core-dev
 98 2020-09-09T05:15:54  *** tralfaz has quit IRC
 99 2020-09-09T05:16:40  *** davterra has joined #bitcoin-core-dev
100 2020-09-09T05:20:23  *** mdunnio has joined #bitcoin-core-dev
101 2020-09-09T05:24:53  *** pinheadmz has quit IRC
102 2020-09-09T05:25:19  *** mdunnio has quit IRC
103 2020-09-09T05:26:14  *** andreacab has joined #bitcoin-core-dev
104 2020-09-09T05:30:46  *** andreacab has quit IRC
105 2020-09-09T05:30:58  *** melande has quit IRC
106 2020-09-09T05:31:19  *** melande has joined #bitcoin-core-dev
107 2020-09-09T05:32:03  *** promag_ has joined #bitcoin-core-dev
108 2020-09-09T05:36:49  *** promag_ has quit IRC
109 2020-09-09T05:44:32  *** Dean_Guss has quit IRC
110 2020-09-09T05:45:09  *** Dean_Guss has joined #bitcoin-core-dev
111 2020-09-09T06:00:01  *** Guest32689 has quit IRC
112 2020-09-09T06:01:25  *** Dean_Guss has quit IRC
113 2020-09-09T06:02:41  *** Dean_Guss has joined #bitcoin-core-dev
114 2020-09-09T06:06:54  *** melande has quit IRC
115 2020-09-09T06:07:19  *** melande has joined #bitcoin-core-dev
116 2020-09-09T06:17:05  *** arowser has quit IRC
117 2020-09-09T06:17:17  *** AaronvanW has joined #bitcoin-core-dev
118 2020-09-09T06:17:24  *** arowser has joined #bitcoin-core-dev
119 2020-09-09T06:21:45  *** whartung1 has joined #bitcoin-core-dev
120 2020-09-09T06:30:02  *** Pavlenex has joined #bitcoin-core-dev
121 2020-09-09T06:30:31  <vasild> Next step to TORv3 is at #19845, waiting for some reviewers to shoot it down :)
122 2020-09-09T06:30:39  <gribble> https://github.com/bitcoin/bitcoin/issues/19845 | net: CNetAddr: add support to (un)serialize as ADDRv2 by vasild · Pull Request #19845 · bitcoin/bitcoin · GitHub
123 2020-09-09T06:34:54  <jonatack> 👍
124 2020-09-09T06:38:24  *** Guyver2 has joined #bitcoin-core-dev
125 2020-09-09T06:39:05  *** arowser has quit IRC
126 2020-09-09T06:39:25  *** arowser has joined #bitcoin-core-dev
127 2020-09-09T06:41:44  *** jonatack has quit IRC
128 2020-09-09T06:46:07  *** andreacab has joined #bitcoin-core-dev
129 2020-09-09T06:49:34  *** harrigan has joined #bitcoin-core-dev
130 2020-09-09T06:49:36  *** Pavlenex has quit IRC
131 2020-09-09T06:50:09  *** AaronvanW has quit IRC
132 2020-09-09T06:54:06  *** Pavlenex has joined #bitcoin-core-dev
133 2020-09-09T06:54:35  *** promag_ has joined #bitcoin-core-dev
134 2020-09-09T06:56:18  *** harrigan has quit IRC
135 2020-09-09T06:56:56  *** harrigan has joined #bitcoin-core-dev
136 2020-09-09T06:59:37  *** Pavlenex has quit IRC
137 2020-09-09T07:00:31  *** Pavlenex has joined #bitcoin-core-dev
138 2020-09-09T07:03:53  *** promag_ has quit IRC
139 2020-09-09T07:04:19  *** promag has quit IRC
140 2020-09-09T07:07:29  *** promag_ has joined #bitcoin-core-dev
141 2020-09-09T07:09:14  *** bitcoin-git has joined #bitcoin-core-dev
142 2020-09-09T07:09:14  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4f229d8904f8...564e1ab0f3dc
143 2020-09-09T07:09:15  <bitcoin-git> bitcoin/master fa39c62 MarcoFalke: test: inline hashToHex
144 2020-09-09T07:09:15  <bitcoin-git> bitcoin/master fa188c9 MarcoFalke: test: Use MiniWalet in p2p_feefilter
145 2020-09-09T07:09:16  <bitcoin-git> bitcoin/master 564e1ab MarcoFalke: Merge #19800: test: Mockwallet
146 2020-09-09T07:09:18  *** bitcoin-git has left #bitcoin-core-dev
147 2020-09-09T07:09:34  *** bitcoin-git has joined #bitcoin-core-dev
148 2020-09-09T07:09:34  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19800: test: Mockwallet (master...2008-testMiniWallet) https://github.com/bitcoin/bitcoin/pull/19800
149 2020-09-09T07:09:36  *** bitcoin-git has left #bitcoin-core-dev
150 2020-09-09T07:10:16  *** andreacab has quit IRC
151 2020-09-09T07:11:47  *** promag_ has quit IRC
152 2020-09-09T07:12:46  *** marcoagner has joined #bitcoin-core-dev
153 2020-09-09T07:14:19  *** sipsorcery has joined #bitcoin-core-dev
154 2020-09-09T07:16:02  *** andreacab has joined #bitcoin-core-dev
155 2020-09-09T07:16:45  *** andreacab has joined #bitcoin-core-dev
156 2020-09-09T07:21:03  *** sipa has quit IRC
157 2020-09-09T07:21:04  *** mdunnio has joined #bitcoin-core-dev
158 2020-09-09T07:25:55  *** mdunnio has quit IRC
159 2020-09-09T07:26:50  *** sipa has joined #bitcoin-core-dev
160 2020-09-09T07:27:55  *** melande has quit IRC
161 2020-09-09T07:28:02  *** belcher_ has joined #bitcoin-core-dev
162 2020-09-09T07:28:23  *** melande has joined #bitcoin-core-dev
163 2020-09-09T07:29:06  *** andreacab has quit IRC
164 2020-09-09T07:29:36  *** andreacab has joined #bitcoin-core-dev
165 2020-09-09T07:30:17  *** jonatack has joined #bitcoin-core-dev
166 2020-09-09T07:31:14  *** belcher has quit IRC
167 2020-09-09T07:32:55  *** andreaca_ has joined #bitcoin-core-dev
168 2020-09-09T07:33:55  *** andreacab has quit IRC
169 2020-09-09T07:33:57  *** promag has joined #bitcoin-core-dev
170 2020-09-09T07:34:49  *** jonatack has quit IRC
171 2020-09-09T07:35:14  *** melande has quit IRC
172 2020-09-09T07:35:19  *** melande1 has joined #bitcoin-core-dev
173 2020-09-09T07:36:05  *** arowser has quit IRC
174 2020-09-09T07:36:24  *** arowser has joined #bitcoin-core-dev
175 2020-09-09T07:36:35  *** jonatack has joined #bitcoin-core-dev
176 2020-09-09T07:38:37  *** promag has quit IRC
177 2020-09-09T07:53:42  *** promag has joined #bitcoin-core-dev
178 2020-09-09T07:53:45  *** promag_ has joined #bitcoin-core-dev
179 2020-09-09T07:56:06  *** EagleTM has joined #bitcoin-core-dev
180 2020-09-09T07:58:55  <jonasschnelli> How is the process of merging "back" the state from the GUI repository? Is there a planed timeframe? Will there just be one PR to the main repository that includes all changes (like a backport PR)? Is that process documented already?
181 2020-09-09T07:58:58  <jonasschnelli> ^ MarcoFalke
182 2020-09-09T08:00:58  *** melande1 has quit IRC
183 2020-09-09T08:01:24  *** melande1 has joined #bitcoin-core-dev
184 2020-09-09T08:04:27  *** andreaca_ has quit IRC
185 2020-09-09T08:04:54  *** andreacab has joined #bitcoin-core-dev
186 2020-09-09T08:06:17  <promag> jonasschnelli: +1
187 2020-09-09T08:08:46  *** andreaca_ has joined #bitcoin-core-dev
188 2020-09-09T08:08:58  *** andreacab has quit IRC
189 2020-09-09T08:10:35  *** promag has quit IRC
190 2020-09-09T08:14:42  *** promag has joined #bitcoin-core-dev
191 2020-09-09T08:23:00  *** melande1 has quit IRC
192 2020-09-09T08:23:22  *** melande1 has joined #bitcoin-core-dev
193 2020-09-09T08:27:26  *** andreaca_ has quit IRC
194 2020-09-09T08:27:34  <jnewbery> #proposed meeting topic: stategies for removing recursive locking in the mempool (https://github.com/bitcoin/bitcoin/pull/19872#issuecomment-688852261)
195 2020-09-09T08:27:34  *** andreacab has joined #bitcoin-core-dev
196 2020-09-09T08:30:17  *** andreacab has quit IRC
197 2020-09-09T08:30:43  *** andreacab has joined #bitcoin-core-dev
198 2020-09-09T08:30:57  *** AaronvanW has joined #bitcoin-core-dev
199 2020-09-09T08:35:11  *** andreacab has quit IRC
200 2020-09-09T08:36:53  *** AaronvanW has quit IRC
201 2020-09-09T08:37:13  *** AaronvanW has joined #bitcoin-core-dev
202 2020-09-09T08:38:02  *** andreacab has joined #bitcoin-core-dev
203 2020-09-09T08:44:08  *** bitcoin-git has joined #bitcoin-core-dev
204 2020-09-09T08:44:08  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19922: test: Run rpc_txoutproof.py even with wallet disabled (master...2009-testMoreMiniWallet) https://github.com/bitcoin/bitcoin/pull/19922
205 2020-09-09T08:44:09  *** bitcoin-git has left #bitcoin-core-dev
206 2020-09-09T08:50:20  *** promag has quit IRC
207 2020-09-09T08:50:56  *** promag has joined #bitcoin-core-dev
208 2020-09-09T08:51:50  *** promag has quit IRC
209 2020-09-09T08:52:07  *** promag has joined #bitcoin-core-dev
210 2020-09-09T08:54:59  *** someone235 has joined #bitcoin-core-dev
211 2020-09-09T08:55:05  *** arowser has quit IRC
212 2020-09-09T08:55:24  *** arowser has joined #bitcoin-core-dev
213 2020-09-09T09:00:02  *** whartung1 has quit IRC
214 2020-09-09T09:00:25  *** afk11 has quit IRC
215 2020-09-09T09:00:56  *** afk11 has joined #bitcoin-core-dev
216 2020-09-09T09:04:57  *** Pavlenex has quit IRC
217 2020-09-09T09:15:25  *** promag has quit IRC
218 2020-09-09T09:15:51  *** andreacab has quit IRC
219 2020-09-09T09:16:18  *** andreacab has joined #bitcoin-core-dev
220 2020-09-09T09:16:40  *** promag has joined #bitcoin-core-dev
221 2020-09-09T09:20:41  *** andreacab has quit IRC
222 2020-09-09T09:21:57  *** mdunnio has joined #bitcoin-core-dev
223 2020-09-09T09:22:21  *** kaimi1 has joined #bitcoin-core-dev
224 2020-09-09T09:24:57  *** melande1 has quit IRC
225 2020-09-09T09:25:21  *** melande1 has joined #bitcoin-core-dev
226 2020-09-09T09:26:37  *** mdunnio has quit IRC
227 2020-09-09T09:30:02  *** AaronvanW has quit IRC
228 2020-09-09T09:31:39  *** andreacab has joined #bitcoin-core-dev
229 2020-09-09T09:31:56  *** melande1 has quit IRC
230 2020-09-09T09:32:25  *** melande1 has joined #bitcoin-core-dev
231 2020-09-09T09:42:30  *** promag has quit IRC
232 2020-09-09T09:54:21  *** provoostenator has quit IRC
233 2020-09-09T09:56:41  *** mrostecki has joined #bitcoin-core-dev
234 2020-09-09T10:02:56  *** melande1 has quit IRC
235 2020-09-09T10:04:17  *** melande1 has joined #bitcoin-core-dev
236 2020-09-09T10:07:56  *** AaronvanW has joined #bitcoin-core-dev
237 2020-09-09T10:11:00  *** andreacab has quit IRC
238 2020-09-09T10:11:28  *** andreacab has joined #bitcoin-core-dev
239 2020-09-09T10:12:35  *** AaronvanW has quit IRC
240 2020-09-09T10:13:25  *** EagleTM has quit IRC
241 2020-09-09T10:15:49  *** jonatack has quit IRC
242 2020-09-09T10:16:07  *** andreacab has quit IRC
243 2020-09-09T10:18:28  *** Emily79Grady has joined #bitcoin-core-dev
244 2020-09-09T10:28:05  *** arowser has quit IRC
245 2020-09-09T10:28:26  *** arowser has joined #bitcoin-core-dev
246 2020-09-09T10:29:01  *** melande1 has quit IRC
247 2020-09-09T10:29:25  *** melande1 has joined #bitcoin-core-dev
248 2020-09-09T10:30:41  *** promag has joined #bitcoin-core-dev
249 2020-09-09T10:32:26  *** promag has quit IRC
250 2020-09-09T10:39:18  *** promag has joined #bitcoin-core-dev
251 2020-09-09T10:39:20  <promag> jnewbery: +1
252 2020-09-09T10:39:39  *** promag_ has quit IRC
253 2020-09-09T10:41:57  *** brianhoffman has quit IRC
254 2020-09-09T10:42:13  *** brianhoffman has joined #bitcoin-core-dev
255 2020-09-09T10:42:38  *** Emily79Grady has quit IRC
256 2020-09-09T10:43:27  *** AaronvanW has joined #bitcoin-core-dev
257 2020-09-09T10:44:19  *** promag has quit IRC
258 2020-09-09T10:48:29  *** promag has joined #bitcoin-core-dev
259 2020-09-09T10:59:23  *** vasild has quit IRC
260 2020-09-09T10:59:48  *** promag_ has joined #bitcoin-core-dev
261 2020-09-09T11:01:28  *** vasild has joined #bitcoin-core-dev
262 2020-09-09T11:07:43  <elichai2> MarcoFalke: I can't manage to reproduce the error in #19920, instead I'm getting a really weird bug without the full details, any idea why? (I'm getting this: https://pastebin.com/raw/MBzJ0ixB)
263 2020-09-09T11:07:47  <gribble> https://github.com/bitcoin/bitcoin/issues/19920 | test: Fuzzing siphash against reference implementation [Request for feedback] by elichai · Pull Request #19920 · bitcoin/bitcoin · GitHub
264 2020-09-09T11:08:39  *** promag has quit IRC
265 2020-09-09T11:08:40  *** melande1 is now known as melande
266 2020-09-09T11:14:19  *** EagleTM has joined #bitcoin-core-dev
267 2020-09-09T11:15:54  *** melande has quit IRC
268 2020-09-09T11:16:23  *** melande has joined #bitcoin-core-dev
269 2020-09-09T11:16:55  <elichai2> found the bug :) you're not allowed to do `&*it` on null 😅
270 2020-09-09T11:16:56  *** AaronvanW has quit IRC
271 2020-09-09T11:18:20  *** worc3131 has quit IRC
272 2020-09-09T11:18:23  *** melande has quit IRC
273 2020-09-09T11:19:38  *** worc3131 has joined #bitcoin-core-dev
274 2020-09-09T11:22:52  *** mdunnio has joined #bitcoin-core-dev
275 2020-09-09T11:23:02  *** melande has joined #bitcoin-core-dev
276 2020-09-09T11:24:10  *** ghost43 has quit IRC
277 2020-09-09T11:24:39  *** ghost43 has joined #bitcoin-core-dev
278 2020-09-09T11:25:44  *** melande has quit IRC
279 2020-09-09T11:26:10  *** melande has joined #bitcoin-core-dev
280 2020-09-09T11:27:35  *** mdunnio has quit IRC
281 2020-09-09T11:48:05  *** arowser has quit IRC
282 2020-09-09T11:48:48  *** arowser has joined #bitcoin-core-dev
283 2020-09-09T11:49:54  *** promag_ has quit IRC
284 2020-09-09T11:53:05  *** EagleTM has quit IRC
285 2020-09-09T12:00:02  *** kaimi1 has quit IRC
286 2020-09-09T12:02:59  *** melande has quit IRC
287 2020-09-09T12:03:30  *** melande has joined #bitcoin-core-dev
288 2020-09-09T12:04:51  *** jonatack has joined #bitcoin-core-dev
289 2020-09-09T12:05:49  *** opsec_x12 has quit IRC
290 2020-09-09T12:06:14  *** opsec_x12 has joined #bitcoin-core-dev
291 2020-09-09T12:20:41  *** Eric3 has quit IRC
292 2020-09-09T12:21:27  *** Jamalaka1 has joined #bitcoin-core-dev
293 2020-09-09T12:21:42  *** ExEric3 has joined #bitcoin-core-dev
294 2020-09-09T12:27:35  *** Highway61 has joined #bitcoin-core-dev
295 2020-09-09T12:29:58  *** melande has quit IRC
296 2020-09-09T12:33:58  *** andreacab has joined #bitcoin-core-dev
297 2020-09-09T12:34:14  *** melande has joined #bitcoin-core-dev
298 2020-09-09T12:38:44  *** promag has joined #bitcoin-core-dev
299 2020-09-09T12:43:11  *** promag has quit IRC
300 2020-09-09T12:49:01  *** twistedline_ has quit IRC
301 2020-09-09T12:49:19  *** twistedline_ has joined #bitcoin-core-dev
302 2020-09-09T12:55:51  *** vasild has quit IRC
303 2020-09-09T12:56:08  *** vasild has joined #bitcoin-core-dev
304 2020-09-09T13:02:22  *** andreacab has quit IRC
305 2020-09-09T13:04:18  *** vasild has quit IRC
306 2020-09-09T13:04:35  *** vasild has joined #bitcoin-core-dev
307 2020-09-09T13:05:05  *** arowser has quit IRC
308 2020-09-09T13:05:46  *** arowser has joined #bitcoin-core-dev
309 2020-09-09T13:06:05  *** arowser has quit IRC
310 2020-09-09T13:06:25  *** arowser has joined #bitcoin-core-dev
311 2020-09-09T13:07:07  *** andreacab has joined #bitcoin-core-dev
312 2020-09-09T13:08:04  *** arowser has quit IRC
313 2020-09-09T13:08:25  *** arowser has joined #bitcoin-core-dev
314 2020-09-09T13:10:05  *** arowser has quit IRC
315 2020-09-09T13:10:48  *** arowser has joined #bitcoin-core-dev
316 2020-09-09T13:11:05  *** arowser has quit IRC
317 2020-09-09T13:11:21  *** andreacab has quit IRC
318 2020-09-09T13:11:25  *** arowser has joined #bitcoin-core-dev
319 2020-09-09T13:12:05  *** arowser has quit IRC
320 2020-09-09T13:12:26  *** arowser has joined #bitcoin-core-dev
321 2020-09-09T13:12:41  *** nim87 has joined #bitcoin-core-dev
322 2020-09-09T13:13:05  *** arowser has quit IRC
323 2020-09-09T13:13:27  *** arowser has joined #bitcoin-core-dev
324 2020-09-09T13:14:03  *** AaronvanW has joined #bitcoin-core-dev
325 2020-09-09T13:14:06  *** arowser has quit IRC
326 2020-09-09T13:14:27  *** arowser has joined #bitcoin-core-dev
327 2020-09-09T13:16:12  *** promag has joined #bitcoin-core-dev
328 2020-09-09T13:16:28  *** promag has quit IRC
329 2020-09-09T13:16:42  *** promag has joined #bitcoin-core-dev
330 2020-09-09T13:23:50  *** mdunnio has joined #bitcoin-core-dev
331 2020-09-09T13:28:30  *** mdunnio has quit IRC
332 2020-09-09T13:39:30  *** nim87 has quit IRC
333 2020-09-09T13:41:06  *** arowser has quit IRC
334 2020-09-09T13:41:27  *** arowser has joined #bitcoin-core-dev
335 2020-09-09T13:42:43  *** melande has quit IRC
336 2020-09-09T13:43:05  *** arowser has quit IRC
337 2020-09-09T13:43:25  *** arowser has joined #bitcoin-core-dev
338 2020-09-09T13:44:33  *** mdunnio has joined #bitcoin-core-dev
339 2020-09-09T13:44:33  *** andreacab has joined #bitcoin-core-dev
340 2020-09-09T13:45:11  *** melande has joined #bitcoin-core-dev
341 2020-09-09T13:46:18  *** AaronvanW has quit IRC
342 2020-09-09T13:49:19  *** andreacab has quit IRC
343 2020-09-09T13:51:51  *** AaronvanW has joined #bitcoin-core-dev
344 2020-09-09T13:56:05  *** arowser has quit IRC
345 2020-09-09T13:56:47  *** arowser has joined #bitcoin-core-dev
346 2020-09-09T14:02:58  *** melande has quit IRC
347 2020-09-09T14:07:18  *** melande has joined #bitcoin-core-dev
348 2020-09-09T14:09:35  *** mrostecki has quit IRC
349 2020-09-09T14:10:11  *** mrostecki has joined #bitcoin-core-dev
350 2020-09-09T14:13:56  *** melande has quit IRC
351 2020-09-09T14:17:56  *** melande has joined #bitcoin-core-dev
352 2020-09-09T14:19:04  *** arowser has quit IRC
353 2020-09-09T14:19:26  *** arowser has joined #bitcoin-core-dev
354 2020-09-09T14:25:05  *** proofofkeags has quit IRC
355 2020-09-09T14:25:19  *** bitcoin-git has joined #bitcoin-core-dev
356 2020-09-09T14:25:19  <bitcoin-git> [bitcoin] hebasto opened pull request #19926: gui: Add Tor icon (master...200909-tor) https://github.com/bitcoin/bitcoin/pull/19926
357 2020-09-09T14:25:20  *** bitcoin-git has left #bitcoin-core-dev
358 2020-09-09T14:39:56  *** pinheadmz has joined #bitcoin-core-dev
359 2020-09-09T14:56:54  *** mol_ has quit IRC
360 2020-09-09T14:57:23  *** mol_ has joined #bitcoin-core-dev
361 2020-09-09T15:00:01  *** Jamalaka1 has quit IRC
362 2020-09-09T15:01:11  *** jonatack has quit IRC
363 2020-09-09T15:04:28  *** jonatack has joined #bitcoin-core-dev
364 2020-09-09T15:05:43  *** morcos has quit IRC
365 2020-09-09T15:06:52  *** proofofkeags has joined #bitcoin-core-dev
366 2020-09-09T15:11:03  *** morcos has joined #bitcoin-core-dev
367 2020-09-09T15:16:07  *** melande has quit IRC
368 2020-09-09T15:16:19  *** melande has joined #bitcoin-core-dev
369 2020-09-09T15:16:58  *** melande has quit IRC
370 2020-09-09T15:17:22  *** melande has joined #bitcoin-core-dev
371 2020-09-09T15:17:43  *** Talkless has joined #bitcoin-core-dev
372 2020-09-09T15:21:01  *** ggainey1 has joined #bitcoin-core-dev
373 2020-09-09T15:31:21  *** andreacab has joined #bitcoin-core-dev
374 2020-09-09T15:35:33  *** andreacab has quit IRC
375 2020-09-09T15:45:52  *** owowo has quit IRC
376 2020-09-09T15:50:46  *** owowo has joined #bitcoin-core-dev
377 2020-09-09T15:57:35  *** AaronvanW has quit IRC
378 2020-09-09T16:02:57  *** melande has quit IRC
379 2020-09-09T16:03:21  *** melande has joined #bitcoin-core-dev
380 2020-09-09T16:11:10  *** andreacab has joined #bitcoin-core-dev
381 2020-09-09T16:12:05  *** arowser has quit IRC
382 2020-09-09T16:12:24  *** arowser has joined #bitcoin-core-dev
383 2020-09-09T16:14:00  *** AaronvanW has joined #bitcoin-core-dev
384 2020-09-09T16:15:34  *** andreacab has quit IRC
385 2020-09-09T16:19:59  *** melande has quit IRC
386 2020-09-09T16:20:20  *** melande has joined #bitcoin-core-dev
387 2020-09-09T16:34:42  *** gzhao408 has joined #bitcoin-core-dev
388 2020-09-09T16:57:31  *** MrPaz has joined #bitcoin-core-dev
389 2020-09-09T17:00:34  *** b10c has joined #bitcoin-core-dev
390 2020-09-09T17:04:20  *** melande1 has joined #bitcoin-core-dev
391 2020-09-09T17:04:42  *** melande has quit IRC
392 2020-09-09T17:08:20  *** bitcoin-git has joined #bitcoin-core-dev
393 2020-09-09T17:08:20  <bitcoin-git> [bitcoin] dongcarl opened pull request #19927: validation: Reduce direct g_chainman usage (master...2020-09-reduce-g_chainman-usage) https://github.com/bitcoin/bitcoin/pull/19927
394 2020-09-09T17:08:21  *** bitcoin-git has left #bitcoin-core-dev
395 2020-09-09T17:10:33  *** filchef has joined #bitcoin-core-dev
396 2020-09-09T17:12:24  *** AaronvanW has quit IRC
397 2020-09-09T17:15:09  *** lightlike has joined #bitcoin-core-dev
398 2020-09-09T17:20:53  <ariard> jonasschnelli: just replied on bip324, AFAICT real-or-random and I favor MACing the length a la noise, even if as Lloyd is pointing we don't a concrete exploitation of it
399 2020-09-09T17:23:54  *** owowo has quit IRC
400 2020-09-09T17:27:01  <achow101> jonasschnelli: IIRC PRs merged to the GUI repo are also pushed to the main repo simultaneously
401 2020-09-09T17:28:54  *** owowo has joined #bitcoin-core-dev
402 2020-09-09T17:33:48  *** AaronvanW has joined #bitcoin-core-dev
403 2020-09-09T17:42:55  *** melande1 has quit IRC
404 2020-09-09T17:43:25  *** melande1 has joined #bitcoin-core-dev
405 2020-09-09T18:00:03  *** ggainey1 has quit IRC
406 2020-09-09T18:02:34  *** andreacab has joined #bitcoin-core-dev
407 2020-09-09T18:03:55  *** melande1 has quit IRC
408 2020-09-09T18:04:19  *** melande1 has joined #bitcoin-core-dev
409 2020-09-09T18:05:23  *** melande1 has joined #bitcoin-core-dev
410 2020-09-09T18:20:18  *** b10c has quit IRC
411 2020-09-09T18:20:38  *** b10c has joined #bitcoin-core-dev
412 2020-09-09T18:20:50  *** ThunderChicken1 has joined #bitcoin-core-dev
413 2020-09-09T18:34:47  *** jb55 has quit IRC
414 2020-09-09T18:35:17  *** jb55 has joined #bitcoin-core-dev
415 2020-09-09T18:50:22  *** b10c has quit IRC
416 2020-09-09T18:57:35  <luke-jr> wtf :/ https://github.com/bitcoin/bitcoin/issues/19928
417 2020-09-09T19:00:12  <achow101> luke-jr: O.o
418 2020-09-09T19:00:47  <achow101> the filenames are hardcoded...
419 2020-09-09T19:00:54  *** tryphe has quit IRC
420 2020-09-09T19:01:42  *** tryphe has joined #bitcoin-core-dev
421 2020-09-09T19:02:00  <luke-jr> achow101: isn't this the directory name, actually?
422 2020-09-09T19:02:42  <achow101> https://twitter.com/2btc10000pizzas/status/1303767335258542085 would indicate it effects the wallet.dat file
423 2020-09-09T19:03:01  *** worc3131 has quit IRC
424 2020-09-09T19:03:17  <achow101> although the previous tweet also suggests the directory name
425 2020-09-09T19:03:33  <luke-jr> ackup.dat doesn't
426 2020-09-09T19:03:49  *** bitcoin-git has joined #bitcoin-core-dev
427 2020-09-09T19:03:49  <bitcoin-git> [bitcoin] vasild opened pull request #19929: sync: use proper TSA attributes (master...use_proper_tsa_attributes) https://github.com/bitcoin/bitcoin/pull/19929
428 2020-09-09T19:03:50  *** bitcoin-git has left #bitcoin-core-dev
429 2020-09-09T19:04:15  *** worc3131 has joined #bitcoin-core-dev
430 2020-09-09T19:04:16  <achow101> right
431 2020-09-09T19:04:34  <achow101> allet.dat does but maybe he specified wallet.dat and not just ""
432 2020-09-09T19:04:45  <achow101> so that would mean it's a wallet name handling thing
433 2020-09-09T19:04:50  <luke-jr> "" is never on disk :p
434 2020-09-09T19:05:18  <luke-jr> you saw that apparently the actual on-disk filenames are being renamed, right?
435 2020-09-09T19:05:31  <achow101> yes
436 2020-09-09T19:05:33  <luke-jr> I'm not 100% sure they know what they're talking about in that regard, but it's weird
437 2020-09-09T19:06:03  <gwillen> off the top of my head, one way to eat the first character of a path component would be issues with quoting and backslash as a path separator on Windows
438 2020-09-09T19:06:12  <luke-jr> hmm
439 2020-09-09T19:07:05  *** melande1 has quit IRC
440 2020-09-09T19:07:17  <luke-jr> "It would have been Gentoo Linux with the wallet files on an NTFS partition." lol totally unexpected
441 2020-09-09T19:07:19  *** melande1 has joined #bitcoin-core-dev
442 2020-09-09T19:07:25  <luke-jr> I doubt the other guy has the same setup tho
443 2020-09-09T19:07:30  <gwillen> iiiiiinteresting
444 2020-09-09T19:07:54  <gwillen> could be an issue in the NTFS driver, that thing was always marked 'experimental'
445 2020-09-09T19:07:58  *** Talkless has quit IRC
446 2020-09-09T19:08:10  <luke-jr> what's the chance the other guy had Linux+NTFS tho
447 2020-09-09T19:08:12  <achow101> luke-jr: yeah, other guy is Win 10
448 2020-09-09T19:08:27  <achow101> could be a NTFS issue
449 2020-09-09T19:09:39  <luke-jr> seems unlikely
450 2020-09-09T19:09:59  <luke-jr> it's not like Windows and Linux share the same NTFS code
451 2020-09-09T19:10:07  <achow101> if he only see the problem on knots, then we could probably find the problem by looking at the diff?
452 2020-09-09T19:10:29  <luke-jr> achow101: the second guy had it on Core
453 2020-09-09T19:10:35  <luke-jr> I think
454 2020-09-09T19:10:41  <gwillen> any chance the win 10 guy is using WSL or something weird like that?
455 2020-09-09T19:11:34  <luke-jr> maybe if the Linux guy was using Captive NTFS.. he did say it was a long time ago
456 2020-09-09T19:12:15  <gwillen> in that case why doesn't every windows user see it, though
457 2020-09-09T19:12:27  <luke-jr> even the same user couldn't reproduce :/
458 2020-09-09T19:16:06  *** melande1 has quit IRC
459 2020-09-09T19:16:20  *** melande1 has joined #bitcoin-core-dev
460 2020-09-09T19:18:06  *** jb55 has quit IRC
461 2020-09-09T19:19:03  *** b10c has joined #bitcoin-core-dev
462 2020-09-09T19:24:52  *** davterra has quit IRC
463 2020-09-09T19:25:28  *** davterra has joined #bitcoin-core-dev
464 2020-09-09T19:31:21  *** mrostecki has quit IRC
465 2020-09-09T19:34:22  *** filchef has quit IRC
466 2020-09-09T19:35:41  *** mrostecki has joined #bitcoin-core-dev
467 2020-09-09T19:58:47  <phantomcircuit> anybody know how many transaction outputs are in the chain? (not utxo, txo)
468 2020-09-09T20:00:41  *** arowser has quit IRC
469 2020-09-09T20:00:52  <sipa> years ago it was half a billion iirc
470 2020-09-09T20:00:57  *** arowser has joined #bitcoin-core-dev
471 2020-09-09T20:06:42  *** Guyver2 has quit IRC
472 2020-09-09T20:07:09  *** andreacab has quit IRC
473 2020-09-09T20:08:55  *** Guest82 has joined #bitcoin-core-dev
474 2020-09-09T20:10:32  *** Guest82 has left #bitcoin-core-dev
475 2020-09-09T20:10:57  *** melande1 has quit IRC
476 2020-09-09T20:11:32  *** melande1 has joined #bitcoin-core-dev
477 2020-09-09T20:12:36  *** andreacab has joined #bitcoin-core-dev
478 2020-09-09T20:16:57  *** andreacab has quit IRC
479 2020-09-09T20:18:27  *** ThunderChicken1 has quit IRC
480 2020-09-09T20:18:32  <andytoshi> i have a simple script i used for my mimblewimble presentation, i can get this number in a couple hours
481 2020-09-09T20:18:50  <andytoshi> it seems to be taking 2-3 seconds per 100 blocks to scan, i don't remember it being so slow
482 2020-09-09T20:23:23  *** kristapsk has quit IRC
483 2020-09-09T20:28:07  *** Deacyde has quit IRC
484 2020-09-09T20:30:06  *** blardo has joined #bitcoin-core-dev
485 2020-09-09T20:32:58  *** melande1 has quit IRC
486 2020-09-09T20:33:20  *** melande1 has joined #bitcoin-core-dev
487 2020-09-09T20:36:50  <phantomcircuit> andytoshi, i've rigged up rescanblockchain to tell me
488 2020-09-09T21:00:01  *** blardo has quit IRC
489 2020-09-09T21:00:05  <andytoshi> ok cool. i had rigged the `getblock` rpc to dump the number of txouts per block and was using bash from there, but this is pretty brutal ... in the 40 minutes since i last spoke i'm up to block 200k. so it'll finish tonight :P
490 2020-09-09T21:00:51  <sipa> andytoshi: it may not... there are barely any transactions before 200k i think
491 2020-09-09T21:00:57  *** melande1 has quit IRC
492 2020-09-09T21:01:18  *** melande1 has joined #bitcoin-core-dev
493 2020-09-09T21:02:02  <aj> maybe update the coin stats index from #19521 and use that?
494 2020-09-09T21:02:06  <andytoshi> hmm, so, i definitely did this in fall 2016 for scaling bitcoin milan and it only took a few hours
495 2020-09-09T21:02:13  <andytoshi> i guess it's been 4 years :P
496 2020-09-09T21:02:16  <gribble> https://github.com/bitcoin/bitcoin/issues/19521 | Coinstats Index (without UTXO set hash) by fjahr · Pull Request #19521 · bitcoin/bitcoin · GitHub
497 2020-09-09T21:03:11  <aj> andytoshi: (maybe rusty's bitcoin-iterate is faster?)
498 2020-09-09T21:04:17  <sipa> 7316308 transactions up to block 200000
499 2020-09-09T21:04:40  <sipa> out of 566745810 in total
500 2020-09-09T21:05:09  <sipa> phantomcircuit: given that there have been more transactions now than my claimed earlier historical number for the total txouts, you can safely disregard it
501 2020-09-09T21:05:15  <yanmaani> luke-jr: Maybe worth adding a check for it?
502 2020-09-09T21:05:28  <yanmaani> "if wallet.dat doesn't exist and allet.dat does, show a message box"
503 2020-09-09T21:06:29  <yanmaani> "Hi, a very rare bug has occured. We would be happy if you could email us at asd@asd.com and tell us what filesystem drivers you're using. To fix it, open that folder and rename allet.dat again."
504 2020-09-09T21:06:39  <yanmaani> bit hacky though
505 2020-09-09T21:07:57  *** promag has quit IRC
506 2020-09-09T21:08:21  *** promag has joined #bitcoin-core-dev
507 2020-09-09T21:11:59  <phantomcircuit> i think we've regressed on IBD somewhere, i have a server that's comically overpowered and there doesn't seem to be anything that's bottlenecking
508 2020-09-09T21:13:24  <phantomcircuit> running steady at about 100mbps cpu and disk basically idle on a 1gbps connection
509 2020-09-09T21:14:15  <sipa> phantomcircuit: do you have good peers to sync from?
510 2020-09-09T21:14:56  <sipa> the stalling detection logic can kick out the worst peers, but whether you get actually good ones can be hit or miss
511 2020-09-09T21:18:34  <yanmaani> what's usually the bottleneck for IBD? DB sync?
512 2020-09-09T21:18:57  *** melande1 has quit IRC
513 2020-09-09T21:19:10  <aj> phantomcircuit: i often find i'm stuck on block X from a slow peer, while the other peers are on block X+500 or so
514 2020-09-09T21:19:20  *** melande1 has joined #bitcoin-core-dev
515 2020-09-09T21:20:23  <sipa> yanmaani: depends... with lots of cache it's either network or (in-memory) utxo datastructure maintenance; with low cache it can be disk I/O
516 2020-09-09T21:20:52  <phantomcircuit> sipa, it must be the eviction logic cause im sure it would otherwise be network limited
517 2020-09-09T21:21:33  *** maurits1 has joined #bitcoin-core-dev
518 2020-09-09T21:21:40  <yanmaani> how much disk I/O do you need? It's just 300gb or so right?
519 2020-09-09T21:22:02  <aj> yanmaani: disk io is mostly updating the utxo set, which is mitigated by cache
520 2020-09-09T21:22:19  <yanmaani> Can't you disable disk IO during IBD for utxo set?
521 2020-09-09T21:22:33  <sipa> yanmaani: yes, by making your cache big enough for the entire utxo set :)
522 2020-09-09T21:22:53  <sipa> which is 8 GB or so
523 2020-09-09T21:23:06  <yanmaani> No I mean can't you turn off DB sync and so?
524 2020-09-09T21:23:14  <yanmaani> Or will it just need to spill to disk regardless?
525 2020-09-09T21:23:29  <sipa> well the UTXOs need to be stored somewhere!
526 2020-09-09T21:23:37  <sipa> how will you validate transactions otherwise?
527 2020-09-09T21:23:42  <yanmaani> yeah, but there's no need to sync the database
528 2020-09-09T21:23:54  <yanmaani> You can have MongoDB tier safety
529 2020-09-09T21:24:02  <yanmaani> (during IBD)
530 2020-09-09T21:24:05  <aj> you have to have a database, it can be in memory or on disk; if it's in memory, it's in cache
531 2020-09-09T21:24:19  <sipa> if you set the cache big enough to keep the entire utxo set in memory, there will be no database I/O whatsoever during IBD
532 2020-09-09T21:24:47  <sipa> and it'll be flushed once at the end
533 2020-09-09T21:24:58  *** andreacab has joined #bitcoin-core-dev
534 2020-09-09T21:26:37  *** Dean_Guss has quit IRC
535 2020-09-09T21:27:01  *** Dean_Guss has joined #bitcoin-core-dev
536 2020-09-09T21:29:45  *** andreacab has quit IRC
537 2020-09-09T21:31:25  *** brianhoffman has quit IRC
538 2020-09-09T21:31:47  *** b10c has quit IRC
539 2020-09-09T21:35:18  <phantomcircuit> yanmaani, if you set the dbcache high enough you will only write to disk once when you shutdown the node
540 2020-09-09T21:37:13  <yanmaani> If I set it say 99% of the way, will I notice a sharp slowdown, or is it smart enough to cache as much as possible?
541 2020-09-09T21:39:22  <sipa> it's a sawtooth function; our cache is kind of a weird mix between a buffer and a cache
542 2020-09-09T21:39:34  <sipa> once it fills up, it's written entirely to disk, and cleared
543 2020-09-09T21:40:05  <sipa> (the reason for this is an unusual design that lets us remove entries from the cache if they're created and deleted between flushes, without them ever hitting disk)
544 2020-09-09T21:40:45  <sipa> and at least years ago, we tried several alternative designs that kept some part in memory when flushing, but this turned out to be always worse
545 2020-09-09T21:40:56  <yanmaani> And I'm guessing the database is being interacted with by fwrite() rather than mmap
546 2020-09-09T21:41:11  <sipa> it's leveldb
547 2020-09-09T21:41:39  <sipa> so whatever leveldb uses, which is a mix (iirc it's all fwrite on 32-bit platforms, and a combination of fwrite and mmap on 64-bit ones)
548 2020-09-09T21:41:50  <yanmaani> So it's leveldb but with a custom cache?
549 2020-09-09T21:42:14  <sipa> it's probably better to call it an in-memory database, backed by an on-disk leveldb database
550 2020-09-09T21:42:38  <sipa> leveldb has its own caching too
551 2020-09-09T21:43:19  <yanmaani> wouldn't a file-backed mmap be better?
552 2020-09-09T21:43:28  <yanmaani> it's like malloc but with explicit swap handled by the OS
553 2020-09-09T21:43:51  <sipa> you're welcome to try, but we're really talking about different layers
554 2020-09-09T21:44:17  <sipa> the on-disk caching layer is a byte array
555 2020-09-09T21:44:28  <yanmaani> No, I mean isntead of the RAM blob being used for in-ram caching
556 2020-09-09T21:44:38  <sipa> there is no RAM blob
557 2020-09-09T21:44:52  <sipa> there is an in-memory database, with expanded, efficient, data structures
558 2020-09-09T21:44:56  <sipa> not serialized bytes
559 2020-09-09T21:45:06  <yanmaani> Isn't the in-memory database in RAM????
560 2020-09-09T21:45:14  <sipa> yes, but it's not a blob
561 2020-09-09T21:45:17  <sipa> no need to yell
562 2020-09-09T21:45:27  <yanmaani> It's several mallocs?
563 2020-09-09T21:45:31  <sipa> yes
564 2020-09-09T21:46:08  <yanmaani> so, wouldn't it make more sense to replace them with backed mmaps that you never flush? Then the OS would have a lot more liberty to optimize
565 2020-09-09T21:46:14  <yanmaani> than if you force it into RAM
566 2020-09-09T21:46:20  <sipa> seriouysly, you're welcome to try
567 2020-09-09T21:46:29  <sipa> i've spent months on optizing that stuff
568 2020-09-09T21:47:02  <sipa> it's a highly unusual design, but yes, based on the experiments we did back then, it works very well
569 2020-09-09T21:47:09  <yanmaani> huh
570 2020-09-09T21:48:15  <sipa> the unusual part is that the UTXOs really have a create-lookuponce-deleteimmediate cycle
571 2020-09-09T21:48:19  <sipa> which is very strange for databases
572 2020-09-09T21:48:50  <sipa> usual things aren't designed to take advantage of the degree to which looked up entries are immediately deleted
573 2020-09-09T21:49:58  <sipa> (and they'll instead create some sort of log that contains the creation and deletion, which still get written to disk at flush time)
574 2020-09-09T21:50:02  *** kristapsk has joined #bitcoin-core-dev
575 2020-09-09T21:50:29  <sipa> by having an allocation per entry, you can just throw it away instantly when spent, and forget about its existence entirely
576 2020-09-09T21:51:17  <sipa> if you have a few hundred MB or more of cache, it means most UTXOs never hit disk at all
577 2020-09-09T21:52:05  <yanmaani> Wouldn't mmaps do this nearly as efficiently? Or is the OS too eager to flush changes?
578 2020-09-09T21:52:16  <sipa> sigh
579 2020-09-09T21:52:32  <sipa> you're talking about a different layer
580 2020-09-09T21:52:47  <yanmaani> No, I mean that the malloc is replaced by a mmap
581 2020-09-09T21:53:03  <yanmaani> And the mmap'd file is then treated like a RAM buffer of 8 GB
582 2020-09-09T21:53:06  <sipa> then you'd get inconsistent state on disk in case of a crash
583 2020-09-09T21:53:14  <yanmaani> Yeah, is that a problem?
584 2020-09-09T21:53:19  <sipa> yes
585 2020-09-09T21:53:24  <yanmaani> Can't you just remove the UTXO state in case of a crash?
586 2020-09-09T21:53:29  <yanmaani> at least during IBD
587 2020-09-09T21:53:32  <sipa> and sync from scratch? :o
588 2020-09-09T21:53:42  <yanmaani> if you make it fast enough it should be a gain on net
589 2020-09-09T21:53:57  <yanmaani> and dropping ACID guarantees and giving it the MongoDB treatment seems like it would make things faster
590 2020-09-09T21:53:59  <sipa> in pruned mode, you'd need to start over redownloading even
591 2020-09-09T21:54:16  <yanmaani> yeah, that's true. For pruned mode, you'd need to make sure it was synced properly.
592 2020-09-09T21:54:58  <yanmaani> Although if you're substituting malloc() for mmap() of a temporary file, isn't the persistence as good? "The synced stuff stays, the stuff in RAM doesn't"
593 2020-09-09T21:55:31  <sipa> there is no guarantee that mmap flushing happens in the same order as writes
594 2020-09-09T21:55:38  <sipa> is there?
595 2020-09-09T21:57:58  <yanmaani> no
596 2020-09-09T21:58:04  <yanmaani> if it crashes, your mmap will be garbage
597 2020-09-09T21:58:14  <yanmaani> but if you're using it to substitute malloc it should be fine
598 2020-09-09T21:58:22  <yanmaani> since there's no expectation malloc persists on crash
599 2020-09-09T21:58:34  <sipa> ah, i see
600 2020-09-09T22:01:36  <sipa> what advantages would this have? if used with the same cache size as you'd use now, it wouldn't be any faster or have other advantages i think
601 2020-09-09T22:02:03  <sipa> it'd permit you to make a cache larger than your ram, which may or may not be better
602 2020-09-09T22:02:11  <sipa> depending on how fast disk is etc
603 2020-09-09T22:02:39  <yanmaani> If used with the same cache size as you have now, it's roughly identical, but uses less RAM/is more fair
604 2020-09-09T22:02:51  *** lightlike has quit IRC
605 2020-09-09T22:02:51  <yanmaani> (OS can swap it out as it needs if there's a deficit of RAM)
606 2020-09-09T22:02:57  <yanmaani> if used with the max cache size*
607 2020-09-09T22:03:09  <sipa> that assumes the OS can predict better what's useful to have cached
608 2020-09-09T22:03:26  <yanmaani> it has some caching algorithm on a block level, yes
609 2020-09-09T22:03:45  <yanmaani> and users who are using zram/zswap will benefit from compression
610 2020-09-09T22:03:57  *** melande1 has quit IRC
611 2020-09-09T22:03:57  <yanmaani> it'll avoid sync disk writes in the cases where cache is too small
612 2020-09-09T22:03:58  <sipa> sure, but it doesn't know for example that after deleting some UTXO entry it's no longer useful to keep it around
613 2020-09-09T22:04:23  <yanmaani> after deleting the utxo entry, the ram is filled with something else surely?
614 2020-09-09T22:04:40  <yanmaani> (or it's never touched again, in which case the OS won't give it a very high priority)
615 2020-09-09T22:04:42  <sipa> at some point, sure
616 2020-09-09T22:04:44  *** melande1 has joined #bitcoin-core-dev
617 2020-09-09T22:05:07  <sipa> anyway, you're welcome to try and benchmark :)
618 2020-09-09T22:06:33  <yanmaani> yeah. Where is the cache?
619 2020-09-09T22:06:36  <yanmaani> i.e. what file
620 2020-09-09T22:06:45  <yanmaani> is it src/index/*/
621 2020-09-09T22:07:03  <sipa> CCoinsViewCache in src/coins.h
622 2020-09-09T22:09:58  <yanmaani> right, thanks!
623 2020-09-09T22:13:21  <luke-jr> mallocs can get swapped out too..
624 2020-09-09T22:13:54  <yanmaani> Only if you have swap enabled
625 2020-09-09T22:13:59  <yanmaani> Otherwise it'll go straight to thrashing
626 2020-09-09T22:14:13  <yanmaani> With a file-backed mmap, it can flush the pages to disk without consuming your swap
627 2020-09-09T22:14:41  <sipa> yanmaani: it would add I/O though, because the OS will start writing dirty pages from the mmap to disk, and then you'll read them again and write them again when flushing to the "real" database on disk
628 2020-09-09T22:14:59  <sipa> though that wouldn't be I/O on the critical latency path
629 2020-09-09T22:15:07  *** jb55 has joined #bitcoin-core-dev
630 2020-09-09T22:15:27  *** mdunnio has quit IRC
631 2020-09-09T22:16:50  <yanmaani> yes, but so does normal thrashing
632 2020-09-09T22:17:25  <sipa> if the cache is so large that it gets swapped out to disk, you're better off picking a smaller cache
633 2020-09-09T22:17:27  <luke-jr> yanmaani: did you see my recent PR?
634 2020-09-09T22:17:48  <yanmaani> there's two options with malloc: either swap (if that's enabled), or thrashing (swap out libc). With mmap, you can also flush it
635 2020-09-09T22:17:57  *** tryphe_ has joined #bitcoin-core-dev
636 2020-09-09T22:18:02  <yanmaani> sipa: not necessarily - it might figure out which bits aren't so useful, and swap out those, for a net gain
637 2020-09-09T22:18:05  <luke-jr> #19873
638 2020-09-09T22:18:07  <gribble> https://github.com/bitcoin/bitcoin/issues/19873 | [WIP] Flush dbcache early if system is under memory pressure by luke-jr · Pull Request #19873 · bitcoin/bitcoin · GitHub
639 2020-09-09T22:19:01  <yanmaani> That might also work. I don't know which approach is better.
640 2020-09-09T22:19:03  <sipa> yanmaani: given that every piece of data in the cache is accessed exactly once - when it's spent, i don't see how the OS could predict what is useful and what isn't
641 2020-09-09T22:19:31  <yanmaani> I suppose I'll have to benchmark it
642 2020-09-09T22:19:43  <sipa> yeah, it'd be interesting to know
643 2020-09-09T22:19:43  *** tryphe has quit IRC
644 2020-09-09T22:19:55  <sipa> you'll need some mmap-backed allocator i guess
645 2020-09-09T22:20:08  <luke-jr> I think a more likely improvement would be to flag cache entries rather than delete them, when writing to db
646 2020-09-09T22:20:33  <sipa> luke-jr: ?
647 2020-09-09T22:20:38  <yanmaani> I wonder if it'd make more sense to write everything to DB and have it in some extremely lax sync mode
648 2020-09-09T22:20:46  <yanmaani> so, take out the cache, and set the DB to MongoDB mode
649 2020-09-09T22:20:49  <luke-jr> sipa: after flushing changes to db, keep them in memory in case they're read soon
650 2020-09-09T22:20:57  <yanmaani> write during IBD, then flush when synced
651 2020-09-09T22:20:59  <sipa> luke-jr: i tried that
652 2020-09-09T22:20:59  <luke-jr> flag them so you know they don't need to be written anymore
653 2020-09-09T22:21:22  <luke-jr> sipa: why didn't it work?
654 2020-09-09T22:21:34  <sipa> luke-jr: at least a few years ago, it will never a win; the reason is that there is less memory available to exploit the "newly created entries that get deleted before ever hitting disk"
655 2020-09-09T22:22:08  <luke-jr> sipa: you'd delete the flagged entries when you need more space?
656 2020-09-09T22:22:39  <sipa> luke-jr: yes, i believe i tried something like that
657 2020-09-09T22:22:58  <luke-jr> I don't see how this can be a lose :/
658 2020-09-09T22:23:19  <sipa> where the flushing is done in two tiers; in one, you'd flush everything, but keep the most recently created half around
659 2020-09-09T22:23:35  <sipa> and in the second tier, when the memory is full, delete all non-dirty entries
660 2020-09-09T22:23:51  <sipa> luke-jr: because of extra CPU to walk the cache and find things to delete
661 2020-09-09T22:24:00  *** melande1 has quit IRC
662 2020-09-09T22:24:11  <luke-jr> std::move it to a second cache? :x
663 2020-09-09T22:24:42  <sipa> there are definitely more combinations that could be tried, not claiming it's a certain loss
664 2020-09-09T22:24:51  <sipa> but after trying half a dozen things, i think it was time to give up :)
665 2020-09-09T22:25:03  <sipa> it may also depend on relative speeds of RAM/CPU/disk
666 2020-09-09T22:25:28  <sipa> this was also pre-pertxout that was added in 0.15; that may have changed things
667 2020-09-09T22:25:46  <luke-jr> hmm
668 2020-09-09T22:25:54  *** melande1 has joined #bitcoin-core-dev
669 2020-09-09T22:26:13  <sipa> i did have a design a few years ago that i'd like to get back to at some point, which would permit flushing in the background without invalidating on-disk cache
670 2020-09-09T22:26:19  <phantomcircuit> sipa, nvm for some reason my gateway<->modem was in 100 not 1000
671 2020-09-09T22:26:21  <phantomcircuit> <.<
672 2020-09-09T22:26:22  <phantomcircuit> >.>
673 2020-09-09T22:26:22  <sipa> eh, on-disk storage
674 2020-09-09T22:26:42  <luke-jr> hmmmm
675 2020-09-09T22:27:00  <sipa> so you could be continuously writing the oldest entries, outside of the latency critical path
676 2020-09-09T22:27:19  <sipa> though it'd need extra memory to keep things ordered
677 2020-09-09T22:27:44  <yanmaani> Is std::unordered_map really the fastest in-memory kv store around?
678 2020-09-09T22:27:49  <sipa> it's nontrivial to make it work correctly with reorgs etc though, but not impossible, if i remember
679 2020-09-09T22:28:43  <sipa> yanmaani: it's not
680 2020-09-09T22:29:50  <yanmaani> But it's advantageous for some other reason? Or is it just being used for some small part?
681 2020-09-09T22:31:40  <sipa> i think people have tried some variations
682 2020-09-09T22:32:00  <sipa> the biggest differency would come from using different allocation strategies, i think
683 2020-09-09T22:32:14  <sipa> this was tried before though: https://github.com/bitcoin/bitcoin/pull/16801
684 2020-09-09T22:32:17  <sipa> #16801
685 2020-09-09T22:32:19  <gribble> https://github.com/bitcoin/bitcoin/issues/16801 | faster & less memory for sync: bulk pool allocator for node based containers by martinus · Pull Request #16801 · bitcoin/bitcoin · GitHub
686 2020-09-09T22:32:48  <achow101> how do I make a const unsigned char* into a span?
687 2020-09-09T22:33:08  <sipa> achow101: do you have its length?
688 2020-09-09T22:33:13  <achow101> yes
689 2020-09-09T22:33:27  <sipa> Span<const unsigned char>(ptr, len) should work
690 2020-09-09T22:33:53  <achow101> ah, thanks
691 2020-09-09T22:34:11  <sipa> post c++17 we can add type inference, and you can use Span(ptr, len)
692 2020-09-09T22:34:14  *** kristapsk has quit IRC
693 2020-09-09T22:34:34  <luke-jr> doesn't C++17 include std::span anyway? :P
694 2020-09-09T22:34:36  *** kristapsk has joined #bitcoin-core-dev
695 2020-09-09T22:34:44  <sipa> luke-jr: no, that's only in c++20
696 2020-09-09T22:34:54  <sipa> achow101: if you're passing to a function that takes a Span<const unsigned char> already, you can use fn({ptr, len})
697 2020-09-09T22:34:57  <luke-jr> oh :x
698 2020-09-09T22:35:11  <achow101> sipa: even better
699 2020-09-09T22:35:21  <sipa> or {beginptr, endptr}
700 2020-09-09T22:43:54  *** sr_gi6 has quit IRC
701 2020-09-09T22:44:02  <jb55> is there something in 0.20.0 -> 0.20.1 that would cause it to redownload the blockchain? trying to figure out why it's doing that after I upgraded my kernel+bitcoin. no configs changed ...
702 2020-09-09T22:44:23  *** sr_gi has joined #bitcoin-core-dev
703 2020-09-09T22:44:26  <jb55> maybe this ? https://jb55.com/s/a8e916c5b6f0404b.txt
704 2020-09-09T22:46:55  <sipa> jb55: there shouldn't be any changes relates to that in minor releases
705 2020-09-09T22:47:06  <phantomcircuit> sipa, can confirm i am dumb
706 2020-09-09T22:47:09  <jb55> hmm yeah I figured, maybe weird io issue
707 2020-09-09T22:49:23  *** vasild has quit IRC
708 2020-09-09T22:50:22  *** jb55 has quit IRC
709 2020-09-09T22:50:54  *** jb55 has joined #bitcoin-core-dev
710 2020-09-09T22:52:11  *** wullon587 has quit IRC
711 2020-09-09T22:55:34  *** mdunnio has joined #bitcoin-core-dev
712 2020-09-09T22:55:57  *** gzhao408 has quit IRC
713 2020-09-09T22:58:14  *** justanotheruser has quit IRC
714 2020-09-09T23:00:41  *** mdunnio has quit IRC
715 2020-09-09T23:09:54  *** proofofkeags has quit IRC
716 2020-09-09T23:11:39  *** proofofkeags has joined #bitcoin-core-dev
717 2020-09-09T23:13:50  *** sipa has quit IRC
718 2020-09-09T23:16:30  *** sipa has joined #bitcoin-core-dev
719 2020-09-09T23:19:14  *** proofofkeags has quit IRC
720 2020-09-09T23:20:31  *** promag has quit IRC
721 2020-09-09T23:26:28  *** andreacab has joined #bitcoin-core-dev
722 2020-09-09T23:28:59  *** melande1 has quit IRC
723 2020-09-09T23:29:19  *** melande1 has joined #bitcoin-core-dev
724 2020-09-09T23:31:21  *** andreacab has quit IRC
725 2020-09-09T23:31:34  *** promag has joined #bitcoin-core-dev
726 2020-09-09T23:41:58  *** melande1 has quit IRC
727 2020-09-09T23:42:24  *** melande1 has joined #bitcoin-core-dev
728 2020-09-09T23:57:57  *** promag has quit IRC
729 2020-09-09T23:57:59  *** marcoagner has quit IRC