1 2020-09-25T00:00:02  *** patryk has quit IRC
  2 2020-09-25T00:00:35  *** DeanGuss has quit IRC
  3 2020-09-25T00:06:17  *** DeanGuss has joined #bitcoin-core-dev
  4 2020-09-25T00:11:47  *** Cory has quit IRC
  5 2020-09-25T00:18:32  *** Cory has joined #bitcoin-core-dev
  6 2020-09-25T00:21:40  *** zerstoerer has joined #bitcoin-core-dev
  7 2020-09-25T00:24:00  *** syperf has joined #bitcoin-core-dev
  8 2020-09-25T00:31:48  *** AaronvanW has quit IRC
  9 2020-09-25T00:36:36  *** syperf has quit IRC
 10 2020-09-25T01:07:45  *** Emcy has quit IRC
 11 2020-09-25T01:07:57  *** Emcy_ has joined #bitcoin-core-dev
 12 2020-09-25T01:09:21  *** AaronvanW has joined #bitcoin-core-dev
 13 2020-09-25T01:14:46  *** AaronvanW has quit IRC
 14 2020-09-25T01:16:50  *** AaronvanW has joined #bitcoin-core-dev
 15 2020-09-25T01:21:15  *** instagibbs has quit IRC
 16 2020-09-25T01:22:01  *** instagibbs has joined #bitcoin-core-dev
 17 2020-09-25T01:26:00  *** promag_ has joined #bitcoin-core-dev
 18 2020-09-25T01:26:00  *** promag has quit IRC
 19 2020-09-25T01:38:22  <roconnor> I managed to rebuild my desktop with gcc 8.  elichai2 let me know how it goes with clang.  I'm worried a lot of packages won't build.
 20 2020-09-25T01:39:16  <roconnor> luke-jr: real_or_random showed me a link to https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/builtins.c;h=eb662112b32e5ad377d2a865d9977c64dc12cc93;hb=eb662112b32e5ad377d2a865d9977c64dc12cc93#l539 earlier which looked horrifying because it looks like the bug might have affected it.
 21 2020-09-25T01:39:45  <roconnor> and it is used in string_length, which is used in c_strlen, which is something that is possibly related to the bug itself.
 22 2020-09-25T01:40:09  <roconnor> that all said, sipa seems to have noticed that memcmp being compared with 0 doesn't seem to tickle this bug.
 23 2020-09-25T01:40:23  <roconnor> which explains to me how it is possible that not every single piece of software is broken.
 24 2020-09-25T01:40:37  <roconnor> I expect memcmp is very often compared with 0.
 25 2020-09-25T01:41:05  <sipa> having read the code: that's exactly it
 26 2020-09-25T01:41:25  <roconnor> oh you understand the gcc code and the bug?
 27 2020-09-25T01:42:27  *** EagleTM has joined #bitcoin-core-dev
 28 2020-09-25T01:42:47  <sipa> not the bug
 29 2020-09-25T01:43:25  *** Eagle[TM] has quit IRC
 30 2020-09-25T01:43:42  <sipa> but there is a flag passed to expand_builtin_memcmp for the case where the sign of the return value of memcmp doesn't matter (for == and != cases)
 31 2020-09-25T01:43:45  <luke-jr> roconnor: why wouldn't anything build? O.o
 32 2020-09-25T01:43:46  <sipa> which has a separate code path
 33 2020-09-25T01:44:39  <luke-jr> sipa: is the fix then "fixing" things that aren't broken?
 34 2020-09-25T01:46:29  <sipa> luke-jr: no?
 35 2020-09-25T01:47:49  <roconnor> luke-jr: you mean with clang?  I sort of expect a handful of packages to use gcc specfic features.
 36 2020-09-25T01:47:52  <roconnor> But what do I know.
 37 2020-09-25T01:56:03  <roconnor> I'll give building everything with clang a try and see how it goes.
 38 2020-09-25T01:57:10  *** Zhonghua has joined #bitcoin-core-dev
 39 2020-09-25T01:59:08  *** MrPaz has quit IRC
 40 2020-09-25T01:59:40  <luke-jr> oh, I meant GCC 8
 41 2020-09-25T02:00:15  *** kexkey has joined #bitcoin-core-dev
 42 2020-09-25T02:02:01  *** S3RK has joined #bitcoin-core-dev
 43 2020-09-25T02:02:52  <roconnor> luke-jr: appstreamer-qt added a -Wno-error=deprecated-copy flag which doesn't exist on GCC 8.
 44 2020-09-25T02:03:05  <roconnor> luke-jr: and nix3.0pre seems to have gone all in on C++20 features.
 45 2020-09-25T02:03:41  <luke-jr> surprised Nix lets you change the compiler just like that in the first place :o
 46 2020-09-25T02:03:54  <roconnor> what do you mean?
 47 2020-09-25T02:04:03  <luke-jr> well, Guix was refusing to let me use my existing system compiler to bootstrap
 48 2020-09-25T02:04:24  <sipa> does the linux kernel use any memcmp?
 49 2020-09-25T02:04:31  <roconnor> also llvm 9.0.1 seems to have a test case that fails when built with gcc 8.  that ones seems weird.
 50 2020-09-25T02:04:34  <luke-jr> sipa: yes, even __builtin_memcmp :/
 51 2020-09-25T02:04:50  <luke-jr> sipa: I'm afraid to build with my hacked GCC 9.3
 52 2020-09-25T02:05:13  <luke-jr> (in case it depends on the builtin for cases where there's no libc)
 53 2020-09-25T02:07:42  *** AaronvanW has quit IRC
 54 2020-09-25T02:08:17  <roconnor> luke-jr: https://gist.github.com/roconnor/2b8e22e829ed80088ed6690cc3c7f3a8 is my nix overlay that is sufficent to purge gcc 9 from my system.
 55 2020-09-25T02:09:33  <fanquake> MarcoFalke: FYI the bot seems to have run out of disk: https://github.com/bitcoin/bitcoin/pull/19868#issuecomment-698680164
 56 2020-09-25T02:09:37  <roconnor> But I think I want to try again with a bug patched version of gcc 10.
 57 2020-09-25T02:13:42  <roconnor> luke-jr: in an ideal world the overly would just be gcc = self.gcc8.  But unfortunately it isn't quite as easy as it should be.  I need to switch gfortan which openblas uses, and this weird gccFun thing seems to be requires to build nix itself with gcc 8, etc.
 58 2020-09-25T02:37:32  *** lizhonghua_ has joined #bitcoin-core-dev
 59 2020-09-25T02:39:17  *** justanotheruser has quit IRC
 60 2020-09-25T02:41:06  *** davterra has joined #bitcoin-core-dev
 61 2020-09-25T02:49:20  *** lizhonghua_ has quit IRC
 62 2020-09-25T02:56:19  *** lizhonghua__ has joined #bitcoin-core-dev
 63 2020-09-25T03:00:02  *** zerstoerer has quit IRC
 64 2020-09-25T03:05:46  *** S3RK has quit IRC
 65 2020-09-25T03:06:53  *** Zhonghua has quit IRC
 66 2020-09-25T03:15:24  *** justanotheruser has joined #bitcoin-core-dev
 67 2020-09-25T03:17:40  *** GankMove has joined #bitcoin-core-dev
 68 2020-09-25T03:20:14  *** Highway62 has joined #bitcoin-core-dev
 69 2020-09-25T03:20:19  *** Highway61 has quit IRC
 70 2020-09-25T03:20:19  *** Highway62 is now known as Highway61
 71 2020-09-25T03:22:34  *** bpalmer1 has joined #bitcoin-core-dev
 72 2020-09-25T03:22:59  *** GankMove- has joined #bitcoin-core-dev
 73 2020-09-25T03:23:42  *** GankMove has quit IRC
 74 2020-09-25T03:23:43  *** GankMove- has quit IRC
 75 2020-09-25T03:26:53  *** niftynei has quit IRC
 76 2020-09-25T03:27:09  *** niftynei has joined #bitcoin-core-dev
 77 2020-09-25T03:34:57  *** justan0theruser has joined #bitcoin-core-dev
 78 2020-09-25T03:36:42  *** justanotheruser has quit IRC
 79 2020-09-25T03:52:13  *** tralfaz has joined #bitcoin-core-dev
 80 2020-09-25T03:53:01  *** davterra has quit IRC
 81 2020-09-25T03:53:08  *** tralfaz is now known as davterra
 82 2020-09-25T04:03:58  *** lizhonghua_ has joined #bitcoin-core-dev
 83 2020-09-25T04:04:28  *** AaronvanW has joined #bitcoin-core-dev
 84 2020-09-25T04:06:12  *** lizhonghua__ has quit IRC
 85 2020-09-25T04:13:16  *** promag has joined #bitcoin-core-dev
 86 2020-09-25T04:13:16  *** promag_ has quit IRC
 87 2020-09-25T04:16:22  *** S3RK has joined #bitcoin-core-dev
 88 2020-09-25T04:22:09  *** promag has quit IRC
 89 2020-09-25T04:22:22  *** promag has joined #bitcoin-core-dev
 90 2020-09-25T04:22:43  *** S3RK has quit IRC
 91 2020-09-25T04:26:37  *** promag_ has joined #bitcoin-core-dev
 92 2020-09-25T04:27:09  *** promag_ has quit IRC
 93 2020-09-25T04:28:17  *** promag_ has joined #bitcoin-core-dev
 94 2020-09-25T04:28:58  *** promag has quit IRC
 95 2020-09-25T04:36:45  *** AaronvanW has quit IRC
 96 2020-09-25T04:37:28  *** jonatack has quit IRC
 97 2020-09-25T04:50:20  *** S3RK has joined #bitcoin-core-dev
 98 2020-09-25T04:57:31  *** S3RK_ has joined #bitcoin-core-dev
 99 2020-09-25T05:00:25  *** S3RK has quit IRC
100 2020-09-25T05:04:16  *** S3RK_ has quit IRC
101 2020-09-25T05:04:29  *** S3RK has joined #bitcoin-core-dev
102 2020-09-25T05:11:55  *** proofofkeags has quit IRC
103 2020-09-25T05:15:08  *** andreacab has joined #bitcoin-core-dev
104 2020-09-25T05:17:27  *** bpalmer1 has quit IRC
105 2020-09-25T05:18:10  *** andreacab has quit IRC
106 2020-09-25T05:18:36  *** andreacab has joined #bitcoin-core-dev
107 2020-09-25T05:25:13  *** andreacab has quit IRC
108 2020-09-25T05:32:47  *** schmichael1 has joined #bitcoin-core-dev
109 2020-09-25T05:39:40  *** S3RK has quit IRC
110 2020-09-25T05:40:07  *** S3RK has joined #bitcoin-core-dev
111 2020-09-25T05:49:38  *** Victorsueca has joined #bitcoin-core-dev
112 2020-09-25T05:53:29  *** S3RK has quit IRC
113 2020-09-25T05:53:57  *** S3RK has joined #bitcoin-core-dev
114 2020-09-25T05:55:16  *** andreacab has joined #bitcoin-core-dev
115 2020-09-25T05:55:26  *** S3RK has joined #bitcoin-core-dev
116 2020-09-25T05:55:33  *** justan0theruser has quit IRC
117 2020-09-25T06:00:01  *** schmichael1 has quit IRC
118 2020-09-25T06:01:00  *** braydonf has quit IRC
119 2020-09-25T06:01:26  *** braydonf has joined #bitcoin-core-dev
120 2020-09-25T06:16:48  *** Victorsueca has quit IRC
121 2020-09-25T06:20:35  *** tool8 has joined #bitcoin-core-dev
122 2020-09-25T06:23:44  *** Victorsueca has joined #bitcoin-core-dev
123 2020-09-25T06:28:47  *** Victorsueca has quit IRC
124 2020-09-25T06:34:30  *** AaronvanW has joined #bitcoin-core-dev
125 2020-09-25T06:40:47  *** lizhonghua_ has quit IRC
126 2020-09-25T06:43:01  *** Zhonghua has joined #bitcoin-core-dev
127 2020-09-25T06:44:10  *** andreacab has quit IRC
128 2020-09-25T06:44:16  *** andreacab has joined #bitcoin-core-dev
129 2020-09-25T07:03:13  *** Zhonghua has quit IRC
130 2020-09-25T07:03:30  *** Zhonghua has joined #bitcoin-core-dev
131 2020-09-25T07:04:56  *** balbirs has quit IRC
132 2020-09-25T07:05:41  *** balbirs has joined #bitcoin-core-dev
133 2020-09-25T07:07:52  *** AaronvanW has quit IRC
134 2020-09-25T07:10:03  *** yanmaani has quit IRC
135 2020-09-25T07:12:44  *** lizhonghua_ has joined #bitcoin-core-dev
136 2020-09-25T07:13:01  *** Zhonghua has quit IRC
137 2020-09-25T07:13:41  *** andreacab has quit IRC
138 2020-09-25T07:14:07  *** andreacab has joined #bitcoin-core-dev
139 2020-09-25T07:18:07  *** lizhonghua_ has quit IRC
140 2020-09-25T07:18:35  *** andreacab has quit IRC
141 2020-09-25T07:19:29  *** kristapsk has quit IRC
142 2020-09-25T07:20:03  *** marcoagner has joined #bitcoin-core-dev
143 2020-09-25T07:20:50  *** Zhonghua has joined #bitcoin-core-dev
144 2020-09-25T07:23:16  *** S3RK has quit IRC
145 2020-09-25T07:23:45  *** S3RK has joined #bitcoin-core-dev
146 2020-09-25T07:24:46  *** tralfaz has joined #bitcoin-core-dev
147 2020-09-25T07:25:14  *** S3RK has joined #bitcoin-core-dev
148 2020-09-25T07:26:05  *** yanmaani has joined #bitcoin-core-dev
149 2020-09-25T07:26:51  *** davterra has quit IRC
150 2020-09-25T07:29:01  *** bitcoin-git has joined #bitcoin-core-dev
151 2020-09-25T07:29:01  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20012: rpc: Remove duplicate name and argNames from CRPCCommand (master...2009-rpcCheckMapping) https://github.com/bitcoin/bitcoin/pull/20012
152 2020-09-25T07:29:01  *** bitcoin-git has left #bitcoin-core-dev
153 2020-09-25T07:33:33  *** andreacab has joined #bitcoin-core-dev
154 2020-09-25T07:35:02  *** Zhonghua has quit IRC
155 2020-09-25T07:36:40  *** lizhonghua_ has joined #bitcoin-core-dev
156 2020-09-25T07:46:57  *** S3RK has quit IRC
157 2020-09-25T07:47:06  *** S3RK has joined #bitcoin-core-dev
158 2020-09-25T07:48:25  *** marcoagner has quit IRC
159 2020-09-25T07:51:12  *** kljasdfvv has quit IRC
160 2020-09-25T07:52:56  *** kljasdfvv has joined #bitcoin-core-dev
161 2020-09-25T07:53:26  *** andreacab has quit IRC
162 2020-09-25T07:53:49  *** andreacab has joined #bitcoin-core-dev
163 2020-09-25T07:56:32  *** promag_ has quit IRC
164 2020-09-25T07:56:47  *** promag has joined #bitcoin-core-dev
165 2020-09-25T07:57:54  *** andreacab has quit IRC
166 2020-09-25T07:58:20  *** andreacab has joined #bitcoin-core-dev
167 2020-09-25T07:59:55  *** andreacab has quit IRC
168 2020-09-25T08:00:03  *** andreacab has joined #bitcoin-core-dev
169 2020-09-25T08:06:14  *** Highway61 has quit IRC
170 2020-09-25T08:18:57  *** bitcoin-git has joined #bitcoin-core-dev
171 2020-09-25T08:18:57  <bitcoin-git> [bitcoin] kallewoof opened pull request #20013: rpc: normalize parameter names (master...202009-rpc-normalize) https://github.com/bitcoin/bitcoin/pull/20013
172 2020-09-25T08:18:58  *** bitcoin-git has left #bitcoin-core-dev
173 2020-09-25T08:20:21  *** andreacab has quit IRC
174 2020-09-25T08:20:47  *** andreacab has joined #bitcoin-core-dev
175 2020-09-25T08:25:43  *** andreacab has quit IRC
176 2020-09-25T08:26:07  *** lizhonghua__ has joined #bitcoin-core-dev
177 2020-09-25T08:26:22  *** lizhonghua_ has quit IRC
178 2020-09-25T08:26:25  *** bitcoin-git has joined #bitcoin-core-dev
179 2020-09-25T08:26:26  <bitcoin-git> [bitcoin] kallewoof closed pull request #19957: rpc: alias helper (master...202009-rpc-alias) https://github.com/bitcoin/bitcoin/pull/19957
180 2020-09-25T08:26:26  *** bitcoin-git has left #bitcoin-core-dev
181 2020-09-25T08:33:31  *** andreacab has joined #bitcoin-core-dev
182 2020-09-25T08:35:07  *** lizhonghua__ has quit IRC
183 2020-09-25T08:39:34  *** Zhonghua has joined #bitcoin-core-dev
184 2020-09-25T08:41:01  *** andreacab has quit IRC
185 2020-09-25T08:42:10  *** mrostecki has joined #bitcoin-core-dev
186 2020-09-25T08:48:05  *** ghost43 has quit IRC
187 2020-09-25T08:48:25  *** ghost43 has joined #bitcoin-core-dev
188 2020-09-25T08:52:30  *** AaronvanW has joined #bitcoin-core-dev
189 2020-09-25T08:54:05  *** andreacab has joined #bitcoin-core-dev
190 2020-09-25T08:54:23  *** S3RK has quit IRC
191 2020-09-25T08:54:54  *** S3RK has joined #bitcoin-core-dev
192 2020-09-25T08:55:41  *** andreacab has quit IRC
193 2020-09-25T08:56:49  *** GankMove has joined #bitcoin-core-dev
194 2020-09-25T08:56:54  *** GankMove- has joined #bitcoin-core-dev
195 2020-09-25T08:59:37  *** Zhonghua has quit IRC
196 2020-09-25T09:00:02  *** tool8 has quit IRC
197 2020-09-25T09:00:17  *** andreacab has joined #bitcoin-core-dev
198 2020-09-25T09:00:31  *** Zhonghua has joined #bitcoin-core-dev
199 2020-09-25T09:04:06  *** mrostecki has joined #bitcoin-core-dev
200 2020-09-25T09:04:40  *** kexkey has quit IRC
201 2020-09-25T09:04:42  *** vasild has quit IRC
202 2020-09-25T09:06:09  *** S3RK has quit IRC
203 2020-09-25T09:06:36  *** S3RK has joined #bitcoin-core-dev
204 2020-09-25T09:09:57  *** vasild has joined #bitcoin-core-dev
205 2020-09-25T09:11:29  *** AaronvanW has quit IRC
206 2020-09-25T09:11:47  *** AaronvanW has joined #bitcoin-core-dev
207 2020-09-25T09:13:37  *** Zhonghua has quit IRC
208 2020-09-25T09:18:08  *** lizhonghua_ has joined #bitcoin-core-dev
209 2020-09-25T09:19:45  *** S3RK has quit IRC
210 2020-09-25T09:20:13  *** S3RK has joined #bitcoin-core-dev
211 2020-09-25T09:22:03  *** vladan1 has joined #bitcoin-core-dev
212 2020-09-25T09:23:32  *** lizhonghua_ has quit IRC
213 2020-09-25T09:23:51  *** Zhonghua has joined #bitcoin-core-dev
214 2020-09-25T09:25:47  *** andreacab has quit IRC
215 2020-09-25T09:26:14  *** andreacab has joined #bitcoin-core-dev
216 2020-09-25T09:30:16  *** promag has quit IRC
217 2020-09-25T09:30:32  *** andreacab has quit IRC
218 2020-09-25T09:30:48  *** promag has joined #bitcoin-core-dev
219 2020-09-25T09:32:01  *** andreacab has joined #bitcoin-core-dev
220 2020-09-25T09:39:32  *** kristapsk has joined #bitcoin-core-dev
221 2020-09-25T09:51:24  *** promag has quit IRC
222 2020-09-25T09:51:42  *** promag has joined #bitcoin-core-dev
223 2020-09-25T09:54:05  *** GankMove has quit IRC
224 2020-09-25T09:54:28  *** GankMove has joined #bitcoin-core-dev
225 2020-09-25T09:54:30  *** jonatack has joined #bitcoin-core-dev
226 2020-09-25T09:54:33  *** GankMove- has joined #bitcoin-core-dev
227 2020-09-25T09:54:44  *** GankMove has quit IRC
228 2020-09-25T09:58:44  *** GankMove- has quit IRC
229 2020-09-25T10:01:54  *** S3RK has quit IRC
230 2020-09-25T10:02:04  *** S3RK has joined #bitcoin-core-dev
231 2020-09-25T10:10:03  *** vasild has quit IRC
232 2020-09-25T10:12:08  *** vasild has joined #bitcoin-core-dev
233 2020-09-25T10:18:19  *** Imelda77Turcotte has joined #bitcoin-core-dev
234 2020-09-25T10:18:45  *** jonatack has quit IRC
235 2020-09-25T10:19:40  *** jonatack has joined #bitcoin-core-dev
236 2020-09-25T10:28:55  *** andreacab has quit IRC
237 2020-09-25T10:29:21  *** andreacab has joined #bitcoin-core-dev
238 2020-09-25T10:29:50  *** andreaca_ has joined #bitcoin-core-dev
239 2020-09-25T10:30:11  *** Imelda77Turcotte has quit IRC
240 2020-09-25T10:32:31  *** S3RK has quit IRC
241 2020-09-25T10:34:17  *** andreacab has quit IRC
242 2020-09-25T10:34:55  *** andreaca_ has quit IRC
243 2020-09-25T10:34:56  *** S3RK has joined #bitcoin-core-dev
244 2020-09-25T10:35:26  *** S3RK has joined #bitcoin-core-dev
245 2020-09-25T10:36:54  *** sr_gi has quit IRC
246 2020-09-25T10:37:21  *** sr_gi has joined #bitcoin-core-dev
247 2020-09-25T11:01:00  *** alko89 has quit IRC
248 2020-09-25T11:01:16  *** alko89 has joined #bitcoin-core-dev
249 2020-09-25T11:07:50  *** andreacab has joined #bitcoin-core-dev
250 2020-09-25T11:08:59  *** adiabat has quit IRC
251 2020-09-25T11:11:47  <hebasto> jonasschnelli: fanquake: begging review for https://github.com/bitcoin-core/gui/pull/46
252 2020-09-25T11:13:13  *** S3RK has quit IRC
253 2020-09-25T11:13:28  *** andreacab has quit IRC
254 2020-09-25T11:16:30  *** Chris_Stewart_5 has joined #bitcoin-core-dev
255 2020-09-25T11:27:44  *** filchef has joined #bitcoin-core-dev
256 2020-09-25T11:31:17  *** promag has quit IRC
257 2020-09-25T11:32:18  *** promag has joined #bitcoin-core-dev
258 2020-09-25T11:40:51  *** Zhonghua has quit IRC
259 2020-09-25T11:41:16  *** Zhonghua has joined #bitcoin-core-dev
260 2020-09-25T11:47:28  *** promag has quit IRC
261 2020-09-25T11:47:45  *** promag has joined #bitcoin-core-dev
262 2020-09-25T11:51:55  *** tralfaz has quit IRC
263 2020-09-25T11:52:19  *** tralfaz has joined #bitcoin-core-dev
264 2020-09-25T11:55:10  *** filchef has quit IRC
265 2020-09-25T12:00:01  *** vladan1 has quit IRC
266 2020-09-25T12:08:21  <elichai2> roconnor: what distribution do you use? I'm with archlinux and I don't know how to even start with "rebuilding" almost everything is prebuilt, and the kernel itself is prebuilt+signed (for the whole EFI security stuff)
267 2020-09-25T12:08:39  <elichai2> roconnor: god that link looks terrifying
268 2020-09-25T12:09:51  *** Guyver2 has joined #bitcoin-core-dev
269 2020-09-25T12:10:29  *** EagleTM has quit IRC
270 2020-09-25T12:10:30  *** promag has quit IRC
271 2020-09-25T12:11:30  *** promag has joined #bitcoin-core-dev
272 2020-09-25T12:20:01  *** bitcoin-git has joined #bitcoin-core-dev
273 2020-09-25T12:20:02  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/1b313cacc99a...78f912c9010f
274 2020-09-25T12:20:03  <bitcoin-git> bitcoin/master 784f757 gzhao408: [refactor] clarify tests by referencing p2p objects directly
275 2020-09-25T12:20:04  <bitcoin-git> bitcoin/master 7a0de46 gzhao408: [doc] sample code for test framework p2p objects
276 2020-09-25T12:20:04  <bitcoin-git> bitcoin/master 549d30f gzhao408: scripted-diff: replace p2p with p2ps[0] in p2p_invalid_tx
277 2020-09-25T12:20:06  *** bitcoin-git has left #bitcoin-core-dev
278 2020-09-25T12:20:25  *** bitcoin-git has joined #bitcoin-core-dev
279 2020-09-25T12:20:25  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19804: test/refactor: reference p2p objects explicitly and remove confusing Test_Node.p2p property (master...test-p2p-property) https://github.com/bitcoin/bitcoin/pull/19804
280 2020-09-25T12:20:26  *** bitcoin-git has left #bitcoin-core-dev
281 2020-09-25T12:21:05  *** The20YearIRCloud has joined #bitcoin-core-dev
282 2020-09-25T12:25:27  *** The20YearIRCloud has quit IRC
283 2020-09-25T12:27:45  *** bitcoin-git has joined #bitcoin-core-dev
284 2020-09-25T12:27:45  <bitcoin-git> [bitcoin] hebasto opened pull request #20014: doc: Mention signet in -help output (master...200925-signet) https://github.com/bitcoin/bitcoin/pull/20014
285 2020-09-25T12:27:46  *** bitcoin-git has left #bitcoin-core-dev
286 2020-09-25T12:35:43  *** S3RK has joined #bitcoin-core-dev
287 2020-09-25T12:40:27  *** S3RK has quit IRC
288 2020-09-25T12:43:15  *** promag has quit IRC
289 2020-09-25T12:43:28  *** promag has joined #bitcoin-core-dev
290 2020-09-25T12:45:16  *** Highway61 has joined #bitcoin-core-dev
291 2020-09-25T12:47:17  *** bitcoin-git has joined #bitcoin-core-dev
292 2020-09-25T12:47:18  <bitcoin-git> [bitcoin] gr0kchain opened pull request #20015: doc: Added default signet config for linearize script (master...master) https://github.com/bitcoin/bitcoin/pull/20015
293 2020-09-25T12:47:18  *** bitcoin-git has left #bitcoin-core-dev
294 2020-09-25T12:52:17  *** promag has quit IRC
295 2020-09-25T12:53:04  *** promag has joined #bitcoin-core-dev
296 2020-09-25T12:56:07  *** rc_423 has joined #bitcoin-core-dev
297 2020-09-25T12:56:23  *** Waithamai has joined #bitcoin-core-dev
298 2020-09-25T12:56:37  *** Waithamai is now known as Guest83434
299 2020-09-25T13:13:52  *** promag has quit IRC
300 2020-09-25T13:14:10  *** promag has joined #bitcoin-core-dev
301 2020-09-25T13:16:36  <luke-jr> elichai2: he uses Nix
302 2020-09-25T13:22:45  *** aqua42 has quit IRC
303 2020-09-25T13:23:06  *** aqua42 has joined #bitcoin-core-dev
304 2020-09-25T13:25:59  *** ExEric3 has quit IRC
305 2020-09-25T13:26:47  *** ExEric3 has joined #bitcoin-core-dev
306 2020-09-25T13:28:48  <roconnor> elichai2: what looks terrifying?
307 2020-09-25T13:31:21  *** justanotheruser has joined #bitcoin-core-dev
308 2020-09-25T13:35:14  *** promag has quit IRC
309 2020-09-25T13:39:34  <elichai2> https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/builtins.c;h=eb662112b32e5ad377d2a865d9977c64dc12cc93;hb=eb662112b32e5ad377d2a865d9977c64dc12cc93#l539
310 2020-09-25T13:44:24  <roconnor> well, turns out it is effectively comparing the memcpy result with 0, so it sould be unaffected by the bug I guess.
311 2020-09-25T14:06:34  *** jonatack has quit IRC
312 2020-09-25T14:12:40  *** tralfaz is now known as davterra
313 2020-09-25T14:19:24  *** S3RK has joined #bitcoin-core-dev
314 2020-09-25T14:24:18  *** S3RK has quit IRC
315 2020-09-25T14:30:46  *** promag has joined #bitcoin-core-dev
316 2020-09-25T14:39:13  *** andreacab has joined #bitcoin-core-dev
317 2020-09-25T14:41:55  *** kexkey has joined #bitcoin-core-dev
318 2020-09-25T14:42:55  *** Chris_Stewart_5 has quit IRC
319 2020-09-25T14:43:49  *** andreacab has quit IRC
320 2020-09-25T14:47:52  *** Chris_Stewart_5 has joined #bitcoin-core-dev
321 2020-09-25T14:55:21  *** Mercury_Vapor has quit IRC
322 2020-09-25T14:55:44  *** Mercury_Vapor has joined #bitcoin-core-dev
323 2020-09-25T14:57:52  *** mrostecki has quit IRC
324 2020-09-25T14:58:09  *** mrostecki has joined #bitcoin-core-dev
325 2020-09-25T15:00:02  *** Guest83434 has quit IRC
326 2020-09-25T15:11:53  *** bitcoin-git has joined #bitcoin-core-dev
327 2020-09-25T15:11:53  <bitcoin-git> [bitcoin] ajtowns opened pull request #20016: uint256: 1 is a constant (master...202009-uint256_1) https://github.com/bitcoin/bitcoin/pull/20016
328 2020-09-25T15:11:54  *** bitcoin-git has left #bitcoin-core-dev
329 2020-09-25T15:21:30  *** Talkless has joined #bitcoin-core-dev
330 2020-09-25T15:22:11  *** MacYET2 has joined #bitcoin-core-dev
331 2020-09-25T15:35:16  *** Chris_Stewart_5 has quit IRC
332 2020-09-25T15:39:29  *** Chris_Stewart_5 has joined #bitcoin-core-dev
333 2020-09-25T15:49:21  *** Highway61 has quit IRC
334 2020-09-25T15:49:50  *** Highway61 has joined #bitcoin-core-dev
335 2020-09-25T15:53:10  *** ghost43 has quit IRC
336 2020-09-25T15:53:25  *** ghost43_ has joined #bitcoin-core-dev
337 2020-09-25T15:57:03  *** mrostecki has quit IRC
338 2020-09-25T15:57:34  *** alko89 has quit IRC
339 2020-09-25T16:01:30  *** Talkless has quit IRC
340 2020-09-25T16:01:42  *** gloriazhao has joined #bitcoin-core-dev
341 2020-09-25T16:07:56  *** promag has quit IRC
342 2020-09-25T16:09:00  *** promag has joined #bitcoin-core-dev
343 2020-09-25T16:29:22  *** face_ has quit IRC
344 2020-09-25T16:37:13  *** mrostecki has joined #bitcoin-core-dev
345 2020-09-25T16:48:52  *** Chris_Stewart_5 has quit IRC
346 2020-09-25T16:50:46  *** jonatack has joined #bitcoin-core-dev
347 2020-09-25T16:54:36  *** achow101 has quit IRC
348 2020-09-25T16:54:40  *** S3RK has joined #bitcoin-core-dev
349 2020-09-25T16:56:09  *** alko89 has joined #bitcoin-core-dev
350 2020-09-25T16:56:26  *** Chris_Stewart_5 has joined #bitcoin-core-dev
351 2020-09-25T16:56:33  *** achow101 has joined #bitcoin-core-dev
352 2020-09-25T16:58:29  *** achow101 has quit IRC
353 2020-09-25T16:59:16  *** S3RK has quit IRC
354 2020-09-25T17:00:01  *** achow101 has joined #bitcoin-core-dev
355 2020-09-25T17:12:41  *** proofofkeags has joined #bitcoin-core-dev
356 2020-09-25T17:18:24  *** promag has quit IRC
357 2020-09-25T17:18:40  *** promag has joined #bitcoin-core-dev
358 2020-09-25T17:34:03  *** andreacab has joined #bitcoin-core-dev
359 2020-09-25T17:35:25  *** achow101 has quit IRC
360 2020-09-25T17:35:57  *** achow101 has joined #bitcoin-core-dev
361 2020-09-25T17:37:19  *** Chris_Stewart_5 has quit IRC
362 2020-09-25T17:37:38  *** promag has quit IRC
363 2020-09-25T17:38:22  *** promag has joined #bitcoin-core-dev
364 2020-09-25T17:38:52  *** promag has joined #bitcoin-core-dev
365 2020-09-25T17:42:17  *** andreacab has quit IRC
366 2020-09-25T17:42:43  *** andreacab has joined #bitcoin-core-dev
367 2020-09-25T17:47:29  *** andreacab has quit IRC
368 2020-09-25T17:48:39  *** Chris_Stewart_5 has joined #bitcoin-core-dev
369 2020-09-25T17:53:39  *** achow101 has quit IRC
370 2020-09-25T17:53:50  *** achow101 has joined #bitcoin-core-dev
371 2020-09-25T18:00:02  *** MacYET2 has quit IRC
372 2020-09-25T18:21:56  *** andreacab has joined #bitcoin-core-dev
373 2020-09-25T18:21:58  *** grafa has joined #bitcoin-core-dev
374 2020-09-25T18:22:13  *** jonatack has quit IRC
375 2020-09-25T18:26:45  *** andreacab has quit IRC
376 2020-09-25T18:32:21  *** davterra has quit IRC
377 2020-09-25T18:42:44  *** GankMove has joined #bitcoin-core-dev
378 2020-09-25T18:45:00  *** davterra has joined #bitcoin-core-dev
379 2020-09-25T18:55:07  *** bitcoin-git has joined #bitcoin-core-dev
380 2020-09-25T18:55:07  <bitcoin-git> [bitcoin] promag opened pull request #20017: rpc: Add RPCContext (master...2020-09-rpcontext) https://github.com/bitcoin/bitcoin/pull/20017
381 2020-09-25T18:55:07  *** bitcoin-git has left #bitcoin-core-dev
382 2020-09-25T18:55:43  *** mrostecki has quit IRC
383 2020-09-25T18:56:47  *** andreacab has joined #bitcoin-core-dev
384 2020-09-25T19:00:20  <achow101> anyone around for the wallet meeting have something to discuss?
385 2020-09-25T19:01:12  <fjahr> Sort of but no topics and on the go
386 2020-09-25T19:01:47  *** jonatack has joined #bitcoin-core-dev
387 2020-09-25T19:01:53  <achow101> all i've got is that i'd like to shill for #19077
388 2020-09-25T19:01:55  <gribble> https://github.com/bitcoin/bitcoin/issues/19077 | wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets by achow101 · Pull Request #19077 · bitcoin/bitcoin · GitHub
389 2020-09-25T19:02:00  <achow101> i'll trade for reviews on that
390 2020-09-25T19:02:09  <jonatack> hi
391 2020-09-25T19:02:12  *** andreacab has quit IRC
392 2020-09-25T19:02:34  <fjahr> Yeah, already working on that :)
393 2020-09-25T19:02:58  *** ghost43_ has quit IRC
394 2020-09-25T19:03:18  *** ghost43 has joined #bitcoin-core-dev
395 2020-09-25T19:05:31  <jonatack> Sorry, I missed the start. What would be the biggest wallet prios to try for before Oct 15 FF.
396 2020-09-25T19:05:46  <jonatack> #16546?
397 2020-09-25T19:05:49  <gribble> https://github.com/bitcoin/bitcoin/issues/16546 | External signer support - Wallet Box edition by Sjors · Pull Request #16546 · bitcoin/bitcoin · GitHub
398 2020-09-25T19:06:00  <jonatack> Sqlite3?
399 2020-09-25T19:06:31  <achow101> sqlite is one I'd like
400 2020-09-25T19:07:00  <achow101> I think external signer support should wait one release to let descriptor wallets get a release first
401 2020-09-25T19:07:37  <achow101> #18836 too, but that could also be considered a bug fix
402 2020-09-25T19:07:40  <gribble> https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 · Pull Request #18836 · bitcoin/bitcoin · GitHub
403 2020-09-25T19:08:21  <jonatack> ty achow101. WDYT, can we try for fjahr and sipa's coinstats work (unsure if this counts as wallet)?
404 2020-09-25T19:09:18  *** promag has quit IRC
405 2020-09-25T19:09:19  <achow101> jonatack: not wallet, but I can take a look
406 2020-09-25T19:09:34  <luke-jr> achow101: have you looked any into the PSBT side of the GCC bug?
407 2020-09-25T19:09:44  <achow101> luke-jr: nope
408 2020-09-25T19:09:48  <achow101> should I
409 2020-09-25T19:09:52  <luke-jr> not sure
410 2020-09-25T19:10:02  <luke-jr> it's only within deserialisation
411 2020-09-25T19:10:08  <sipa> luke-jr: my current thinking is that it is not affected
412 2020-09-25T19:10:17  *** promag has joined #bitcoin-core-dev
413 2020-09-25T19:10:20  <luke-jr> sipa: well, the fixed GCC is definitely producing different code
414 2020-09-25T19:10:34  <sipa> the code may have changed as a result of the bug fix, but that doesn't mean that in this case the old code was wrong
415 2020-09-25T19:10:40  <sipa> i'll look in more detail today
416 2020-09-25T19:10:56  <achow101> i would guess that std::map uses std::lexicographic_compare and that might be why it shows up
417 2020-09-25T19:11:11  <luke-jr> hmm
418 2020-09-25T19:11:15  <achow101> for std::vector<unsigned char> as the key
419 2020-09-25T19:12:41  <achow101> but that would only effect how things are stored by std::map internally, so I think that would be fine?
420 2020-09-25T19:13:06  <sipa> it could in theory mean things can't be found or so
421 2020-09-25T19:13:46  <sipa> actually, the keys never have a 0 byte in them, right?
422 2020-09-25T19:13:57  <achow101> they can
423 2020-09-25T19:14:02  <sipa> and those that do aren't from constants
424 2020-09-25T19:14:24  <sipa> e.g. a prefix + hash could have a 0 byte in the hash, but the hash is not a constant
425 2020-09-25T19:14:37  <achow101> there's a 0 type but i don't know if they would end up in the memcmp
426 2020-09-25T19:14:45  <achow101> I would expect no
427 2020-09-25T19:15:18  <luke-jr> could it ever have any security implications though?
428 2020-09-25T19:16:31  <sipa> achow101: the problem is that in some cases the memcmp "stops" at the first zero byte
429 2020-09-25T19:16:51  <sipa> so the null key in PSBT which is just a zero byte and nothing else would be unaffected
430 2020-09-25T19:17:04  <achow101> right
431 2020-09-25T19:38:44  *** Talkless has joined #bitcoin-core-dev
432 2020-09-25T19:42:42  *** bitcoin-git has joined #bitcoin-core-dev
433 2020-09-25T19:42:43  <bitcoin-git> [bitcoin] dhruv opened pull request #20018: p2p: ProcessAddrFetch(-seednode) is unnecessary if -connect is specified (master...seednode-not-needed-with-connect) https://github.com/bitcoin/bitcoin/pull/20018
434 2020-09-25T19:42:44  *** bitcoin-git has left #bitcoin-core-dev
435 2020-09-25T19:51:54  *** Chris_Stewart_5 has quit IRC
436 2020-09-25T19:52:41  *** bitcoin-git has joined #bitcoin-core-dev
437 2020-09-25T19:52:41  <bitcoin-git> [bitcoin] dongcarl opened pull request #20019: depends: Properly pass $PATH to configure and pin (master...2020-09-resolve-PATH-prepending-madness) https://github.com/bitcoin/bitcoin/pull/20019
438 2020-09-25T19:52:44  *** bitcoin-git has left #bitcoin-core-dev
439 2020-09-25T19:55:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
440 2020-09-25T20:01:51  *** jonatack has quit IRC
441 2020-09-25T20:10:15  *** jonatack has joined #bitcoin-core-dev
442 2020-09-25T20:30:01  *** S3RK has joined #bitcoin-core-dev
443 2020-09-25T20:34:20  *** S3RK has quit IRC
444 2020-09-25T20:34:51  *** filchef has joined #bitcoin-core-dev
445 2020-09-25T20:37:24  *** promag has quit IRC
446 2020-09-25T20:37:40  *** promag has joined #bitcoin-core-dev
447 2020-09-25T20:39:29  *** Talkless has quit IRC
448 2020-09-25T20:47:55  *** Guyver2 has quit IRC
449 2020-09-25T20:47:55  *** promag has quit IRC
450 2020-09-25T20:48:52  *** promag has joined #bitcoin-core-dev
451 2020-09-25T20:52:59  *** Chris_Stewart_5 has quit IRC
452 2020-09-25T20:55:14  *** Chris_Stewart_5 has joined #bitcoin-core-dev
453 2020-09-25T20:59:08  *** andreacab has joined #bitcoin-core-dev
454 2020-09-25T21:00:01  *** grafa has quit IRC
455 2020-09-25T21:01:28  *** promag_ has joined #bitcoin-core-dev
456 2020-09-25T21:01:29  *** promag has quit IRC
457 2020-09-25T21:06:59  *** andreacab has quit IRC
458 2020-09-25T21:28:00  *** promag_ has quit IRC
459 2020-09-25T21:56:44  *** aj1 has joined #bitcoin-core-dev
460 2020-09-25T21:58:58  *** luke has joined #bitcoin-core-dev
461 2020-09-25T22:05:36  *** promag has joined #bitcoin-core-dev
462 2020-09-25T22:08:02  *** promag has quit IRC
463 2020-09-25T22:10:43  *** vasild has quit IRC
464 2020-09-25T22:12:01  *** vasild has joined #bitcoin-core-dev
465 2020-09-25T22:16:12  *** luke has quit IRC
466 2020-09-25T23:14:35  *** promag has joined #bitcoin-core-dev
467 2020-09-25T23:50:00  *** proofofkeags has quit IRC