1 2020-09-29T00:00:01  *** omega8cc has quit IRC
  2 2020-09-29T00:08:48  <luke-jr> https://drewdevault.com/2020/08/27/Microsoft-plays-their-hand.html
  3 2020-09-29T00:17:40  *** promag has joined #bitcoin-core-dev
  4 2020-09-29T00:22:03  *** landonf1 has joined #bitcoin-core-dev
  5 2020-09-29T00:22:19  *** promag has quit IRC
  6 2020-09-29T00:41:37  *** S3RK has joined #bitcoin-core-dev
  7 2020-09-29T00:48:03  *** ghost43 has quit IRC
  8 2020-09-29T00:48:45  *** ghost43 has joined #bitcoin-core-dev
  9 2020-09-29T00:52:35  *** S3RK has quit IRC
 10 2020-09-29T00:53:23  *** mrostecki has quit IRC
 11 2020-09-29T01:00:42  *** vasild has quit IRC
 12 2020-09-29T01:00:54  *** vasild has joined #bitcoin-core-dev
 13 2020-09-29T01:04:18  *** johnzweng has quit IRC
 14 2020-09-29T01:08:11  *** davterra has quit IRC
 15 2020-09-29T01:36:01  *** justanotheruser has joined #bitcoin-core-dev
 16 2020-09-29T01:36:38  *** promag has joined #bitcoin-core-dev
 17 2020-09-29T01:37:07  *** justan0theruser has quit IRC
 18 2020-09-29T01:38:13  *** johnzweng has joined #bitcoin-core-dev
 19 2020-09-29T01:38:52  *** promag has quit IRC
 20 2020-09-29T01:40:55  *** kristapsk has quit IRC
 21 2020-09-29T01:42:07  *** kristapsk has joined #bitcoin-core-dev
 22 2020-09-29T01:50:58  *** S3RK has joined #bitcoin-core-dev
 23 2020-09-29T01:55:52  *** S3RK has quit IRC
 24 2020-09-29T01:58:32  *** johnzweng has quit IRC
 25 2020-09-29T02:08:07  *** justanotheruser has quit IRC
 26 2020-09-29T02:08:33  *** kristapsk has quit IRC
 27 2020-09-29T02:10:12  *** justanotheruser has joined #bitcoin-core-dev
 28 2020-09-29T02:17:11  <midnight> luke-jr: Strongly recommend not visiting that site without VPN or Tor.
 29 2020-09-29T02:18:37  <luke-jr> midnight: eh?
 30 2020-09-29T02:19:17  <midnight> ... that site. Unless I'm mistaking who that is, strongly recommend you don't visit it withut a VPN or Tor.
 31 2020-09-29T02:20:01  *** alko89 has quit IRC
 32 2020-09-29T02:20:08  <luke-jr> no JS on it.. and content looks reasonable O.o
 33 2020-09-29T02:20:37  <midnight> Yep, I know.
 34 2020-09-29T02:21:51  *** alko89 has joined #bitcoin-core-dev
 35 2020-09-29T02:26:38  *** Highway61 has joined #bitcoin-core-dev
 36 2020-09-29T02:28:24  *** kristapsk has joined #bitcoin-core-dev
 37 2020-09-29T02:29:18  *** roconnor has quit IRC
 38 2020-09-29T02:30:56  *** Highway61 has quit IRC
 39 2020-09-29T02:35:47  *** johnzweng has joined #bitcoin-core-dev
 40 2020-09-29T02:39:44  *** IPGlider has quit IRC
 41 2020-09-29T02:41:54  *** Livestradamus has quit IRC
 42 2020-09-29T02:45:03  *** Livestradamus has joined #bitcoin-core-dev
 43 2020-09-29T02:46:04  *** IPGlider has joined #bitcoin-core-dev
 44 2020-09-29T02:54:10  *** davterra has joined #bitcoin-core-dev
 45 2020-09-29T02:56:21  *** afk11 has quit IRC
 46 2020-09-29T02:56:43  *** afk11 has joined #bitcoin-core-dev
 47 2020-09-29T03:00:01  *** landonf1 has quit IRC
 48 2020-09-29T03:01:19  *** andreacab has joined #bitcoin-core-dev
 49 2020-09-29T03:06:03  *** andreacab has quit IRC
 50 2020-09-29T03:08:13  *** Highway61 has joined #bitcoin-core-dev
 51 2020-09-29T03:09:41  *** roconnor has joined #bitcoin-core-dev
 52 2020-09-29T03:12:39  *** Highway61 has quit IRC
 53 2020-09-29T03:12:50  *** S3RK has joined #bitcoin-core-dev
 54 2020-09-29T03:18:32  *** kristapsk has quit IRC
 55 2020-09-29T03:19:11  *** Highway61 has joined #bitcoin-core-dev
 56 2020-09-29T03:22:21  *** Windurr has joined #bitcoin-core-dev
 57 2020-09-29T03:33:49  *** promag has joined #bitcoin-core-dev
 58 2020-09-29T03:38:32  *** promag has quit IRC
 59 2020-09-29T03:40:00  *** jb55 has quit IRC
 60 2020-09-29T03:46:40  <aj> sipa: i think https://github.com/bitcoin/bitcoin/pull/19988#discussion_r494725595 is resolved?
 61 2020-09-29T03:57:25  <sipa> aj: you can resolve, i think :)
 62 2020-09-29T04:01:03  <aj> sipa: yep, just checking you didn't leave it open for some reason i missed
 63 2020-09-29T04:25:04  *** johnzweng has quit IRC
 64 2020-09-29T04:54:56  *** johnzweng has joined #bitcoin-core-dev
 65 2020-09-29T05:16:30  *** justanotheruser has quit IRC
 66 2020-09-29T05:17:22  *** Windurr has quit IRC
 67 2020-09-29T05:28:37  *** doitux|mob has joined #bitcoin-core-dev
 68 2020-09-29T05:34:25  *** andreacab has joined #bitcoin-core-dev
 69 2020-09-29T05:38:10  *** Highway61 has quit IRC
 70 2020-09-29T05:47:00  *** Highway61 has joined #bitcoin-core-dev
 71 2020-09-29T05:54:50  *** S3RK has quit IRC
 72 2020-09-29T05:55:19  *** S3RK has joined #bitcoin-core-dev
 73 2020-09-29T06:00:02  *** doitux|mob has quit IRC
 74 2020-09-29T06:00:59  *** S3RK has quit IRC
 75 2020-09-29T06:02:03  *** EagleTM has joined #bitcoin-core-dev
 76 2020-09-29T06:04:58  *** bitcoin-git has joined #bitcoin-core-dev
 77 2020-09-29T06:04:59  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/655937ebcbf6...5db44c740ebd
 78 2020-09-29T06:04:59  <bitcoin-git> bitcoin/master b3972bc Hennadii Stepanov: doc: Mention signet in -help output
 79 2020-09-29T06:05:00  <bitcoin-git> bitcoin/master 5db44c7 fanquake: Merge #20014: doc: Mention signet in -help output
 80 2020-09-29T06:05:01  *** bitcoin-git has left #bitcoin-core-dev
 81 2020-09-29T06:05:19  *** bitcoin-git has joined #bitcoin-core-dev
 82 2020-09-29T06:05:20  <bitcoin-git> [bitcoin] fanquake merged pull request #20014: doc: Mention signet in -help output (master...200925-signet) https://github.com/bitcoin/bitcoin/pull/20014
 83 2020-09-29T06:05:21  *** bitcoin-git has left #bitcoin-core-dev
 84 2020-09-29T06:11:11  *** justanotheruser has joined #bitcoin-core-dev
 85 2020-09-29T06:17:31  *** shesek has joined #bitcoin-core-dev
 86 2020-09-29T06:17:31  *** shesek has joined #bitcoin-core-dev
 87 2020-09-29T06:22:18  *** zigapeda1 has joined #bitcoin-core-dev
 88 2020-09-29T06:33:10  *** bitcoin-git has joined #bitcoin-core-dev
 89 2020-09-29T06:33:10  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5db44c740ebd...7ea649946daa
 90 2020-09-29T06:33:11  <bitcoin-git> bitcoin/master fae243f MarcoFalke: test: Remove confusing cast to same type (int to int)
 91 2020-09-29T06:33:11  <bitcoin-git> bitcoin/master faa94cb MarcoFalke: test: Check that invalid peer traffic is accounted for
 92 2020-09-29T06:33:12  <bitcoin-git> bitcoin/master 7ea6499 fanquake: Merge #20028: test: Check that invalid peer traffic is accounted for
 93 2020-09-29T06:33:13  *** bitcoin-git has left #bitcoin-core-dev
 94 2020-09-29T06:33:30  *** bitcoin-git has joined #bitcoin-core-dev
 95 2020-09-29T06:33:30  <bitcoin-git> [bitcoin] fanquake merged pull request #20028: test: Check that invalid peer traffic is accounted for (master...2009-testInvalidTraffic) https://github.com/bitcoin/bitcoin/pull/20028
 96 2020-09-29T06:33:30  *** bitcoin-git has left #bitcoin-core-dev
 97 2020-09-29T06:36:34  *** S3RK has joined #bitcoin-core-dev
 98 2020-09-29T06:39:40  *** bitcoin-git has joined #bitcoin-core-dev
 99 2020-09-29T06:39:40  <bitcoin-git> [bitcoin] fanquake closed pull request #14729: correct -onion default to -proxy behavior (master...qubenix-proxyfix) https://github.com/bitcoin/bitcoin/pull/14729
100 2020-09-29T06:39:41  *** bitcoin-git has left #bitcoin-core-dev
101 2020-09-29T06:41:29  *** S3RK has quit IRC
102 2020-09-29T06:45:05  *** Klox048 has quit IRC
103 2020-09-29T06:48:42  *** Klox048 has joined #bitcoin-core-dev
104 2020-09-29T06:48:45  *** jeremyrubin has quit IRC
105 2020-09-29T06:55:00  *** johnzwen_ has joined #bitcoin-core-dev
106 2020-09-29T06:57:47  *** jonatack has quit IRC
107 2020-09-29T06:58:05  *** johnzweng has quit IRC
108 2020-09-29T07:08:19  *** zigapeda1 has quit IRC
109 2020-09-29T07:13:34  *** S3RK has joined #bitcoin-core-dev
110 2020-09-29T07:14:59  *** bitcoin-git has joined #bitcoin-core-dev
111 2020-09-29T07:14:59  <bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/7ea649946daa...e36aa351a31c
112 2020-09-29T07:15:00  <bitcoin-git> bitcoin/master efc9b85 Sjors Provoost: Mark send RPC experimental
113 2020-09-29T07:15:00  <bitcoin-git> bitcoin/master 0fc1c68 Sjors Provoost: [rpc] send: fix parsing replaceable option
114 2020-09-29T07:15:00  <bitcoin-git> bitcoin/master d813d26 Sjors Provoost: [rpc] send: various touch-ups
115 2020-09-29T07:15:01  *** bitcoin-git has left #bitcoin-core-dev
116 2020-09-29T07:15:07  *** Guyver2 has joined #bitcoin-core-dev
117 2020-09-29T07:15:19  *** bitcoin-git has joined #bitcoin-core-dev
118 2020-09-29T07:15:19  <bitcoin-git> [bitcoin] fanquake merged pull request #19969: Send RPC bug fix and touch-ups (master...2020/09/send_touchups) https://github.com/bitcoin/bitcoin/pull/19969
119 2020-09-29T07:15:20  *** bitcoin-git has left #bitcoin-core-dev
120 2020-09-29T07:16:21  *** Livestradamus has quit IRC
121 2020-09-29T07:16:45  *** Livestradamus has joined #bitcoin-core-dev
122 2020-09-29T07:18:25  *** roconnor has quit IRC
123 2020-09-29T07:21:01  *** marcoagner has joined #bitcoin-core-dev
124 2020-09-29T07:23:58  *** kristapsk has joined #bitcoin-core-dev
125 2020-09-29T07:27:34  *** UltimateNate has joined #bitcoin-core-dev
126 2020-09-29T07:35:14  *** promag has joined #bitcoin-core-dev
127 2020-09-29T07:35:15  *** jonatack has joined #bitcoin-core-dev
128 2020-09-29T07:36:23  *** kristapsk has quit IRC
129 2020-09-29T07:39:47  *** promag has quit IRC
130 2020-09-29T07:48:38  *** IGHOR has quit IRC
131 2020-09-29T07:49:30  *** kristapsk has joined #bitcoin-core-dev
132 2020-09-29T07:52:49  *** andreacab has joined #bitcoin-core-dev
133 2020-09-29T08:03:18  *** promag has joined #bitcoin-core-dev
134 2020-09-29T08:10:20  *** kristapsk has quit IRC
135 2020-09-29T08:10:39  *** kristapsk has joined #bitcoin-core-dev
136 2020-09-29T08:15:19  *** bitcoin-git has joined #bitcoin-core-dev
137 2020-09-29T08:15:20  <bitcoin-git> [bitcoin] fanquake pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/e36aa351a31c...6af9b31bfc6d
138 2020-09-29T08:15:21  <bitcoin-git> bitcoin/master 2716647 Troy Giorshev: Give V1TransportDeserializer an m_node_id member
139 2020-09-29T08:15:22  <bitcoin-git> bitcoin/master 890b1d7 Troy Giorshev: Move checksum check from net_processing to net
140 2020-09-29T08:15:23  <bitcoin-git> bitcoin/master 1ca20c1 Troy Giorshev: Add doxygen comment for ReceiveMsgBytes
141 2020-09-29T08:15:24  *** bitcoin-git has left #bitcoin-core-dev
142 2020-09-29T08:16:20  *** bitcoin-git has joined #bitcoin-core-dev
143 2020-09-29T08:16:20  <bitcoin-git> [bitcoin] fanquake merged pull request #19107: p2p: Move all header verification into the network layer, extend logging (master...p2p-refactor-header) https://github.com/bitcoin/bitcoin/pull/19107
144 2020-09-29T08:16:21  *** bitcoin-git has left #bitcoin-core-dev
145 2020-09-29T08:20:34  *** promag has quit IRC
146 2020-09-29T08:28:38  *** S3RK has quit IRC
147 2020-09-29T08:29:06  *** S3RK has joined #bitcoin-core-dev
148 2020-09-29T08:32:55  *** sr_gi has quit IRC
149 2020-09-29T08:33:05  *** S3RK has quit IRC
150 2020-09-29T08:33:24  *** sr_gi has joined #bitcoin-core-dev
151 2020-09-29T08:35:54  *** bitcoin-git has joined #bitcoin-core-dev
152 2020-09-29T08:35:56  <bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/6af9b31bfc6d...ec9b4492eba5
153 2020-09-29T08:35:57  <bitcoin-git> bitcoin/master dba8196 Antoine Poinsot: policy/fees: correct decay explanation comments
154 2020-09-29T08:35:57  <bitcoin-git> bitcoin/master 5b8cb35 Antoine Poinsot: policy/fee: remove requireGreater parameter in EstimateMedianVal()
155 2020-09-29T08:35:58  <bitcoin-git> bitcoin/master 569d92a Antoine Poinsot: policy/fees: small readability improvements
156 2020-09-29T08:36:00  *** bitcoin-git has left #bitcoin-core-dev
157 2020-09-29T08:36:24  *** bitcoin-git has joined #bitcoin-core-dev
158 2020-09-29T08:36:25  <bitcoin-git> [bitcoin] fanquake merged pull request #19630: Cleanup fee estimation code (master...20/07/refactor_feeest_code) https://github.com/bitcoin/bitcoin/pull/19630
159 2020-09-29T08:36:26  *** bitcoin-git has left #bitcoin-core-dev
160 2020-09-29T08:40:17  *** S3RK has joined #bitcoin-core-dev
161 2020-09-29T08:47:34  *** mrostecki has joined #bitcoin-core-dev
162 2020-09-29T08:53:45  *** bitcoin-git has joined #bitcoin-core-dev
163 2020-09-29T08:53:45  <bitcoin-git> [bitcoin] vasild closed pull request #19031: Implement ADDRv2 support (part of BIP155) (master...addrv2) https://github.com/bitcoin/bitcoin/pull/19031
164 2020-09-29T08:53:46  *** bitcoin-git has left #bitcoin-core-dev
165 2020-09-29T09:00:01  *** UltimateNate has quit IRC
166 2020-09-29T09:01:20  *** bitcoin-git has joined #bitcoin-core-dev
167 2020-09-29T09:01:20  <bitcoin-git> [bitcoin] jnewbery closed pull request #17566: Switch to weight units for all feerates computation (master...feerate_in_weight) https://github.com/bitcoin/bitcoin/pull/17566
168 2020-09-29T09:01:21  *** bitcoin-git has left #bitcoin-core-dev
169 2020-09-29T09:01:40  *** bitcoin-git has joined #bitcoin-core-dev
170 2020-09-29T09:01:40  <bitcoin-git> [bitcoin] darosior closed pull request #16890: rpc: Don't allow to 'estimatesmartfee' in blocksonly mode (master...estimatesmartfee_blockonly) https://github.com/bitcoin/bitcoin/pull/16890
171 2020-09-29T09:01:41  *** bitcoin-git has left #bitcoin-core-dev
172 2020-09-29T09:04:49  *** S3RK has quit IRC
173 2020-09-29T09:05:26  *** S3RK has joined #bitcoin-core-dev
174 2020-09-29T09:06:11  *** mrostecki has quit IRC
175 2020-09-29T09:07:12  *** Guyver2_ has joined #bitcoin-core-dev
176 2020-09-29T09:08:51  *** mrostecki has joined #bitcoin-core-dev
177 2020-09-29T09:09:28  *** Guyver2 has quit IRC
178 2020-09-29T09:09:41  *** AaronvanW has joined #bitcoin-core-dev
179 2020-09-29T09:09:53  *** S3RK has quit IRC
180 2020-09-29T09:10:20  *** EagleTM has quit IRC
181 2020-09-29T09:11:19  *** AaronvanW has quit IRC
182 2020-09-29T09:12:06  *** kristapsk has quit IRC
183 2020-09-29T09:15:11  *** AaronvanW has joined #bitcoin-core-dev
184 2020-09-29T09:17:56  *** andreacab has quit IRC
185 2020-09-29T09:18:22  *** andreacab has joined #bitcoin-core-dev
186 2020-09-29T09:21:49  *** andreaca_ has joined #bitcoin-core-dev
187 2020-09-29T09:21:54  *** ariel_ has joined #bitcoin-core-dev
188 2020-09-29T09:22:27  *** andreacab has quit IRC
189 2020-09-29T09:28:19  *** Highway61 has quit IRC
190 2020-09-29T09:28:27  *** S3RK has joined #bitcoin-core-dev
191 2020-09-29T09:29:43  *** ghost43 has quit IRC
192 2020-09-29T09:29:53  *** andreaca_ has quit IRC
193 2020-09-29T09:30:21  *** andreacab has joined #bitcoin-core-dev
194 2020-09-29T09:30:38  *** jonasschnelli has quit IRC
195 2020-09-29T09:30:43  *** niska has quit IRC
196 2020-09-29T09:31:23  *** vasild has quit IRC
197 2020-09-29T09:31:26  *** davterra has quit IRC
198 2020-09-29T09:31:48  *** vasild has joined #bitcoin-core-dev
199 2020-09-29T09:32:07  *** ghost43 has joined #bitcoin-core-dev
200 2020-09-29T09:33:09  *** jonasschnelli has joined #bitcoin-core-dev
201 2020-09-29T09:34:43  *** andreacab has quit IRC
202 2020-09-29T09:38:49  *** niska has joined #bitcoin-core-dev
203 2020-09-29T09:40:55  *** S3RK has quit IRC
204 2020-09-29T09:41:22  *** S3RK has joined #bitcoin-core-dev
205 2020-09-29T09:45:32  *** EagleTM has joined #bitcoin-core-dev
206 2020-09-29T09:45:49  *** S3RK has quit IRC
207 2020-09-29T09:46:24  *** johnzweng has joined #bitcoin-core-dev
208 2020-09-29T09:49:45  *** johnzwen_ has quit IRC
209 2020-09-29T09:50:50  *** sparkp1ug has joined #bitcoin-core-dev
210 2020-09-29T09:56:06  *** Tennis has joined #bitcoin-core-dev
211 2020-09-29T09:57:57  *** Highway61 has joined #bitcoin-core-dev
212 2020-09-29T09:58:37  *** jonatack has quit IRC
213 2020-09-29T10:01:27  *** Highway61 has quit IRC
214 2020-09-29T10:03:03  *** ghost43 has quit IRC
215 2020-09-29T10:03:19  *** johnzwen_ has joined #bitcoin-core-dev
216 2020-09-29T10:06:25  *** johnzweng has quit IRC
217 2020-09-29T10:07:30  *** ghost43 has joined #bitcoin-core-dev
218 2020-09-29T10:09:29  *** S3RK has joined #bitcoin-core-dev
219 2020-09-29T10:10:43  *** vasild has quit IRC
220 2020-09-29T10:12:06  *** andreacab has joined #bitcoin-core-dev
221 2020-09-29T10:12:34  *** vasild has joined #bitcoin-core-dev
222 2020-09-29T10:13:43  *** S3RK has quit IRC
223 2020-09-29T10:16:06  *** bitcoin-git has joined #bitcoin-core-dev
224 2020-09-29T10:16:07  <bitcoin-git> [bitcoin] vasild opened pull request #20033: style: minor improvements as a followup to #19845 (master...nits_followup_to_19845) https://github.com/bitcoin/bitcoin/pull/20033
225 2020-09-29T10:16:07  *** bitcoin-git has left #bitcoin-core-dev
226 2020-09-29T10:20:59  *** Milo35Erdman has joined #bitcoin-core-dev
227 2020-09-29T10:31:59  *** S3RK has joined #bitcoin-core-dev
228 2020-09-29T10:39:46  *** bitcoin-git has joined #bitcoin-core-dev
229 2020-09-29T10:39:47  <bitcoin-git> [bitcoin] jnewbery closed pull request #15206: Immediately disconnect on invalid net message checksum (master...2019/01/netmsg_2) https://github.com/bitcoin/bitcoin/pull/15206
230 2020-09-29T10:39:47  *** bitcoin-git has left #bitcoin-core-dev
231 2020-09-29T10:40:11  *** bitcoin-git has joined #bitcoin-core-dev
232 2020-09-29T10:40:12  <bitcoin-git> [bitcoin] jnewbery closed pull request #15197: Refactor and slightly stricter p2p message processing (master...2019/01/netmsg_1) https://github.com/bitcoin/bitcoin/pull/15197
233 2020-09-29T10:40:13  *** bitcoin-git has left #bitcoin-core-dev
234 2020-09-29T10:40:57  *** Highway61 has joined #bitcoin-core-dev
235 2020-09-29T10:48:03  *** sparkp1ug has quit IRC
236 2020-09-29T10:51:55  *** Highway61 has quit IRC
237 2020-09-29T10:55:29  *** promag has joined #bitcoin-core-dev
238 2020-09-29T10:55:31  *** Highway61 has joined #bitcoin-core-dev
239 2020-09-29T10:55:36  *** promag has quit IRC
240 2020-09-29T10:56:56  *** Highway61 has quit IRC
241 2020-09-29T10:57:33  *** Milo35Erdman has quit IRC
242 2020-09-29T10:57:57  *** mekster has quit IRC
243 2020-09-29T10:58:13  *** mekster has joined #bitcoin-core-dev
244 2020-09-29T10:58:36  *** andreacab has quit IRC
245 2020-09-29T10:58:40  *** mekster has joined #bitcoin-core-dev
246 2020-09-29T10:59:04  *** andreacab has joined #bitcoin-core-dev
247 2020-09-29T11:01:36  *** bitcoin-git has joined #bitcoin-core-dev
248 2020-09-29T11:01:36  <bitcoin-git> [bitcoin] ryanofsky opened pull request #20034: test: Get rid of default wallet hacks (master...pr/defw) https://github.com/bitcoin/bitcoin/pull/20034
249 2020-09-29T11:01:37  *** bitcoin-git has left #bitcoin-core-dev
250 2020-09-29T11:03:58  *** andreacab has quit IRC
251 2020-09-29T11:25:17  *** S3RK has quit IRC
252 2020-09-29T12:00:02  *** ariel_ has quit IRC
253 2020-09-29T12:06:15  *** sparkp1ug has joined #bitcoin-core-dev
254 2020-09-29T12:08:23  *** sparkplug has joined #bitcoin-core-dev
255 2020-09-29T12:11:13  <vasild> hebasto: I am looking at https://github.com/bitcoin/bitcoin/pull/19991#discussion_r495073463 -- that wouldn't allow to configure the two things independently.
256 2020-09-29T12:11:28  *** sparkp1ug has quit IRC
257 2020-09-29T12:12:23  <vasild> I think we should allow for "auto create tor service: yes/no" and independently of that "do extra bind and consider incoming connections to that as incoming tor: bind_addr:bind_port"
258 2020-09-29T12:13:43  <vasild> so that it is possible to configure all 4 possibilities: auto create+extra bind, auto create+no extra bind, no auto create+extra bind, no auto create+no extra bind
259 2020-09-29T12:17:37  *** dr-orlovsky has quit IRC
260 2020-09-29T12:18:08  *** dr-orlovsky has joined #bitcoin-core-dev
261 2020-09-29T12:21:55  *** flukiluke1 has joined #bitcoin-core-dev
262 2020-09-29T12:32:45  *** sparkplug_ has joined #bitcoin-core-dev
263 2020-09-29T12:35:06  *** sparkp1ug has joined #bitcoin-core-dev
264 2020-09-29T12:35:07  *** sparkplug has quit IRC
265 2020-09-29T12:38:01  *** bitcoin-git has joined #bitcoin-core-dev
266 2020-09-29T12:38:01  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20035: signet: Fix uninitialized read in validation (master...2009-signetUninitRead) https://github.com/bitcoin/bitcoin/pull/20035
267 2020-09-29T12:38:02  *** bitcoin-git has left #bitcoin-core-dev
268 2020-09-29T12:41:39  *** bitcoin-git has joined #bitcoin-core-dev
269 2020-09-29T12:41:39  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ec9b4492eba5...d82b2c6e65ff
270 2020-09-29T12:41:40  <bitcoin-git> bitcoin/master 62dba96 nthumann: log: print unexpected version warning in validation log category
271 2020-09-29T12:41:41  <bitcoin-git> bitcoin/master d82b2c6 fanquake: Merge #19898: log: print unexpected version warning in validation log cate...
272 2020-09-29T12:41:42  *** bitcoin-git has left #bitcoin-core-dev
273 2020-09-29T12:41:59  *** bitcoin-git has joined #bitcoin-core-dev
274 2020-09-29T12:41:59  <bitcoin-git> [bitcoin] fanquake merged pull request #19898: log: print unexpected version warning in validation log category (master...log-fix-unexpected-version) https://github.com/bitcoin/bitcoin/pull/19898
275 2020-09-29T12:42:00  *** bitcoin-git has left #bitcoin-core-dev
276 2020-09-29T12:42:22  *** EagleTM has quit IRC
277 2020-09-29T12:45:04  *** jasan has joined #bitcoin-core-dev
278 2020-09-29T13:05:21  *** bitcoin-git has joined #bitcoin-core-dev
279 2020-09-29T13:05:21  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20036: signet: Add assumed values for default signet (master...2009-signetAssumed) https://github.com/bitcoin/bitcoin/pull/20036
280 2020-09-29T13:05:22  *** bitcoin-git has left #bitcoin-core-dev
281 2020-09-29T13:13:49  *** jonatack has joined #bitcoin-core-dev
282 2020-09-29T13:16:22  <Bullit> What happened last thing it said at 33% block load ¨i´ll warn you again¨ then Bitcoin Core QT Shutdown during start up full chain is running again on laptop, please don´t make me a node see my energydrink company
283 2020-09-29T13:18:01  *** bitcoin-git has joined #bitcoin-core-dev
284 2020-09-29T13:18:01  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d82b2c6e65ff...8aa617896139
285 2020-09-29T13:18:01  <bitcoin-git> bitcoin/master 9b4fa0a practicalswift: net: Print error message if -proxy is specified without arguments (instead...
286 2020-09-29T13:18:02  <bitcoin-git> bitcoin/master 8aa6178 Wladimir J. van der Laan: Merge #20003: net: Exit with error message if -proxy is specified without ...
287 2020-09-29T13:18:03  *** bitcoin-git has left #bitcoin-core-dev
288 2020-09-29T13:18:20  *** bitcoin-git has joined #bitcoin-core-dev
289 2020-09-29T13:18:20  <bitcoin-git> [bitcoin] laanwj merged pull request #20003: net: Exit with error message if -proxy is specified without arguments (instead of continuing without proxy server) (master...error-on-empty-proxy) https://github.com/bitcoin/bitcoin/pull/20003
290 2020-09-29T13:18:21  *** bitcoin-git has left #bitcoin-core-dev
291 2020-09-29T13:23:16  *** Tennis has quit IRC
292 2020-09-29T13:24:06  *** roconnor has joined #bitcoin-core-dev
293 2020-09-29T13:24:45  *** luke_ has joined #bitcoin-core-dev
294 2020-09-29T13:25:25  *** bitcoin-git has joined #bitcoin-core-dev
295 2020-09-29T13:25:25  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8aa617896139...9e6f56f6ea0f
296 2020-09-29T13:25:25  <bitcoin-git> bitcoin/master f22d6a1 practicalswift: log: Remove static log message "Initializing chainstate Chainstate [ibd] @...
297 2020-09-29T13:25:26  <bitcoin-git> bitcoin/master 9e6f56f Wladimir J. van der Laan: Merge #19984: log: Remove static log message "Initializing chainstate Chai...
298 2020-09-29T13:25:35  *** bitcoin-git has left #bitcoin-core-dev
299 2020-09-29T13:25:49  *** bitcoin-git has joined #bitcoin-core-dev
300 2020-09-29T13:25:49  <bitcoin-git> [bitcoin] laanwj merged pull request #19984: log: Remove static log message "Initializing chainstate Chainstate [ibd] @ height -1 (null)" (master...logging-should-not-be-static-department) https://github.com/bitcoin/bitcoin/pull/19984
301 2020-09-29T13:25:50  *** bitcoin-git has left #bitcoin-core-dev
302 2020-09-29T13:31:04  *** Aaronvan_ has joined #bitcoin-core-dev
303 2020-09-29T13:33:37  *** AaronvanW has quit IRC
304 2020-09-29T13:37:20  *** Guyver2_ has quit IRC
305 2020-09-29T14:02:10  *** davterra has joined #bitcoin-core-dev
306 2020-09-29T14:03:14  *** IGHOR has joined #bitcoin-core-dev
307 2020-09-29T14:05:46  *** Guyver2 has joined #bitcoin-core-dev
308 2020-09-29T14:12:29  *** kexkey has joined #bitcoin-core-dev
309 2020-09-29T14:13:15  *** luke_ has quit IRC
310 2020-09-29T14:14:20  *** johnzwen_ has quit IRC
311 2020-09-29T14:14:59  *** andreacab has joined #bitcoin-core-dev
312 2020-09-29T14:18:48  *** sparkplug has joined #bitcoin-core-dev
313 2020-09-29T14:23:17  <wumpus> the signet default network onion seed seems to be offline (ntv3mtqw5wt63red.onion:38333)
314 2020-09-29T14:25:30  <hebasto> vasild: agree
315 2020-09-29T14:26:11  *** sparkp1ug has quit IRC
316 2020-09-29T14:26:18  *** sparkplug has quit IRC
317 2020-09-29T14:26:22  *** sparkplug_ has quit IRC
318 2020-09-29T14:26:31  *** promag has joined #bitcoin-core-dev
319 2020-09-29T14:28:42  *** sparkp1ug has joined #bitcoin-core-dev
320 2020-09-29T14:28:47  *** sparkplug has joined #bitcoin-core-dev
321 2020-09-29T14:28:55  *** sparkplug_ has joined #bitcoin-core-dev
322 2020-09-29T14:31:53  *** jonatack has quit IRC
323 2020-09-29T14:32:24  *** jonatack has joined #bitcoin-core-dev
324 2020-09-29T14:32:57  <wumpus> kallewoof ^^
325 2020-09-29T14:33:44  <kallewoof> wumpus: huh. ping provoostenator as he's running it
326 2020-09-29T14:36:29  *** S3RK has joined #bitcoin-core-dev
327 2020-09-29T14:38:59  *** bitcoin-git has joined #bitcoin-core-dev
328 2020-09-29T14:38:59  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9e6f56f6ea0f...de4b7f25acef
329 2020-09-29T14:39:00  <bitcoin-git> bitcoin/master 8a4dcda gr0kchain: doc: Added default signet config for linearize script
330 2020-09-29T14:39:00  <bitcoin-git> bitcoin/master de4b7f2 Wladimir J. van der Laan: Merge #20015: doc: Added default signet config for linearize script
331 2020-09-29T14:39:02  *** bitcoin-git has left #bitcoin-core-dev
332 2020-09-29T14:39:19  *** bitcoin-git has joined #bitcoin-core-dev
333 2020-09-29T14:39:19  <bitcoin-git> [bitcoin] laanwj merged pull request #20015: doc: Added default signet config for linearize script (master...master) https://github.com/bitcoin/bitcoin/pull/20015
334 2020-09-29T14:39:20  *** bitcoin-git has left #bitcoin-core-dev
335 2020-09-29T14:40:51  <wumpus> kallewoof: ohh whoops I didn't know that
336 2020-09-29T14:41:49  *** S3RK has quit IRC
337 2020-09-29T14:46:08  <kallewoof> wumpus: i will set up an onion seed on my side as well to make it a bit more stable
338 2020-09-29T14:47:48  *** promag has quit IRC
339 2020-09-29T14:48:06  *** johnzweng has joined #bitcoin-core-dev
340 2020-09-29T14:48:25  <wumpus> having at least two would be nice, I noticed because I tried to use signet on a onlynet=onion node :)
341 2020-09-29T14:48:53  <kallewoof> wumpus: yeah, didn't really cover that very well. :P
342 2020-09-29T15:00:01  *** flukiluke1 has quit IRC
343 2020-09-29T15:00:40  *** promag has joined #bitcoin-core-dev
344 2020-09-29T15:01:45  <roconnor> luke-jr: I found 10 lines of miscompiled code on my desktop system. You can read my report @ http://r6.ca/blog/20200929T023701Z.html
345 2020-09-29T15:02:07  *** promag has quit IRC
346 2020-09-29T15:04:33  *** luke has joined #bitcoin-core-dev
347 2020-09-29T15:13:07  <luke-jr> roconnor: you don't use Twitter, do you? (if you do, I'll retweet it)
348 2020-09-29T15:17:13  *** andreacab has quit IRC
349 2020-09-29T15:17:38  *** andreacab has joined #bitcoin-core-dev
350 2020-09-29T15:18:54  <roconnor> I don't use twitter.
351 2020-09-29T15:19:02  <roconnor> you can share it however you like.
352 2020-09-29T15:20:58  <jonatack> very helpful report roconnor, thank you
353 2020-09-29T15:21:10  *** zpao has joined #bitcoin-core-dev
354 2020-09-29T15:21:47  *** andreacab has quit IRC
355 2020-09-29T15:23:27  *** Asbestos_Vapor has joined #bitcoin-core-dev
356 2020-09-29T15:23:47  <luke-jr> indeed, thanks
357 2020-09-29T15:25:07  *** luke has quit IRC
358 2020-09-29T15:26:30  <luke-jr> annoyingly, icu is commonly static linked I think
359 2020-09-29T15:26:37  *** Mercury_Vapor has quit IRC
360 2020-09-29T15:26:57  <luke-jr> possibly into Bitcoin-Qt too, though I can't see any way one would exploit this
361 2020-09-29T15:31:49  <wumpus> going to test with both #19954 and #19991, surprisingly it's a clean merge
362 2020-09-29T15:31:52  <gribble> https://github.com/bitcoin/bitcoin/issues/19954 | tor: complete the TORv3 implementation by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
363 2020-09-29T15:31:55  <gribble> https://github.com/bitcoin/bitcoin/issues/19991 | net: Use alternative port for incoming Tor connections by hebasto · Pull Request #19991 · bitcoin/bitcoin · GitHub
364 2020-09-29T15:50:20  *** jb55 has joined #bitcoin-core-dev
365 2020-09-29T16:01:05  *** proofofkeags has joined #bitcoin-core-dev
366 2020-09-29T16:07:28  *** jeremyrubin has joined #bitcoin-core-dev
367 2020-09-29T16:08:03  *** luke has joined #bitcoin-core-dev
368 2020-09-29T16:12:31  *** andreacab has joined #bitcoin-core-dev
369 2020-09-29T16:14:59  *** luke has quit IRC
370 2020-09-29T16:15:53  *** Talkless has joined #bitcoin-core-dev
371 2020-09-29T16:25:36  *** andreacab has quit IRC
372 2020-09-29T16:25:45  *** andreacab has joined #bitcoin-core-dev
373 2020-09-29T16:27:15  *** andreacab has quit IRC
374 2020-09-29T16:27:41  *** andreacab has joined #bitcoin-core-dev
375 2020-09-29T16:31:47  *** andreacab has quit IRC
376 2020-09-29T17:13:01  *** jasan has quit IRC
377 2020-09-29T17:25:09  *** owowo has quit IRC
378 2020-09-29T17:29:41  *** owowo has joined #bitcoin-core-dev
379 2020-09-29T17:33:11  *** spinza has quit IRC
380 2020-09-29T17:34:23  *** spinza has joined #bitcoin-core-dev
381 2020-09-29T17:35:06  *** jb55 has quit IRC
382 2020-09-29T17:36:47  *** gertjaap_ has quit IRC
383 2020-09-29T17:36:47  *** jkczyz has quit IRC
384 2020-09-29T17:37:05  *** elichai2 has quit IRC
385 2020-09-29T17:37:06  *** felixweis has quit IRC
386 2020-09-29T17:37:09  *** Galvas has quit IRC
387 2020-09-29T17:37:12  *** Lexyon____ has quit IRC
388 2020-09-29T17:37:12  *** robot-dreams has quit IRC
389 2020-09-29T17:37:12  *** fanquake has quit IRC
390 2020-09-29T17:37:12  *** jamesob has quit IRC
391 2020-09-29T17:37:12  *** rodarmor has quit IRC
392 2020-09-29T17:37:25  *** schmidty has quit IRC
393 2020-09-29T17:37:25  *** nejon has quit IRC
394 2020-09-29T17:37:27  *** Isthmus has quit IRC
395 2020-09-29T17:37:31  *** vfP56jSe has quit IRC
396 2020-09-29T17:37:43  *** RubenSomsen has quit IRC
397 2020-09-29T17:37:43  *** jakesyl has quit IRC
398 2020-09-29T17:37:45  *** prusnak has quit IRC
399 2020-09-29T17:37:46  *** dergoegge has quit IRC
400 2020-09-29T17:37:47  *** corollari__ has quit IRC
401 2020-09-29T17:37:47  *** moneyball has quit IRC
402 2020-09-29T17:38:02  *** fjahr has quit IRC
403 2020-09-29T17:38:07  *** amiti has quit IRC
404 2020-09-29T17:38:07  *** NicolasDorier has quit IRC
405 2020-09-29T17:38:09  *** ccook has quit IRC
406 2020-09-29T17:38:16  *** arik__ has quit IRC
407 2020-09-29T17:38:16  *** hugohn has quit IRC
408 2020-09-29T17:38:18  *** michagogo has quit IRC
409 2020-09-29T17:38:27  *** digi_james has quit IRC
410 2020-09-29T17:38:30  *** hebasto has quit IRC
411 2020-09-29T17:38:35  *** ahmed_ has quit IRC
412 2020-09-29T17:38:37  *** noganoo has quit IRC
413 2020-09-29T17:38:47  *** gloriazhao has quit IRC
414 2020-09-29T17:38:47  *** mariorz has quit IRC
415 2020-09-29T17:38:53  *** mmitech___ has quit IRC
416 2020-09-29T17:38:53  *** GoldmanSats__ has quit IRC
417 2020-09-29T17:38:53  *** hsmiths has quit IRC
418 2020-09-29T17:38:53  *** dburkett has quit IRC
419 2020-09-29T17:38:53  *** ajonas has quit IRC
420 2020-09-29T17:38:54  *** wallet42__ has quit IRC
421 2020-09-29T17:39:12  *** pierre_rochard has quit IRC
422 2020-09-29T17:39:25  *** drbrule has quit IRC
423 2020-09-29T17:39:25  *** endogenic has quit IRC
424 2020-09-29T17:42:39  *** andreacab has joined #bitcoin-core-dev
425 2020-09-29T17:43:45  *** andreacab has quit IRC
426 2020-09-29T17:44:11  *** andreacab has joined #bitcoin-core-dev
427 2020-09-29T17:44:58  *** kristapsk has joined #bitcoin-core-dev
428 2020-09-29T17:47:48  *** NicolasDorier has joined #bitcoin-core-dev
429 2020-09-29T17:47:53  *** arik__ has joined #bitcoin-core-dev
430 2020-09-29T17:47:58  *** mmitech___ has joined #bitcoin-core-dev
431 2020-09-29T17:48:07  *** andreacab has quit IRC
432 2020-09-29T17:48:10  *** gloriazhao has joined #bitcoin-core-dev
433 2020-09-29T17:48:28  *** endogenic has joined #bitcoin-core-dev
434 2020-09-29T17:48:32  *** hugohn has joined #bitcoin-core-dev
435 2020-09-29T17:48:54  *** drbrule has joined #bitcoin-core-dev
436 2020-09-29T17:49:03  *** ajonas has joined #bitcoin-core-dev
437 2020-09-29T17:49:04  *** hebasto has joined #bitcoin-core-dev
438 2020-09-29T17:49:14  *** wallet42__ has joined #bitcoin-core-dev
439 2020-09-29T17:49:20  *** mariorz has joined #bitcoin-core-dev
440 2020-09-29T17:49:26  *** dergoegge has joined #bitcoin-core-dev
441 2020-09-29T17:49:28  *** Lexyon____ has joined #bitcoin-core-dev
442 2020-09-29T17:49:29  *** moneyball has joined #bitcoin-core-dev
443 2020-09-29T17:49:44  *** nejon has joined #bitcoin-core-dev
444 2020-09-29T17:49:59  *** vfP56jSe has joined #bitcoin-core-dev
445 2020-09-29T17:50:05  *** fjahr has joined #bitcoin-core-dev
446 2020-09-29T17:50:15  *** Galvas has joined #bitcoin-core-dev
447 2020-09-29T17:50:20  *** prusnak has joined #bitcoin-core-dev
448 2020-09-29T17:50:24  *** ccook has joined #bitcoin-core-dev
449 2020-09-29T17:50:34  *** digi_james has joined #bitcoin-core-dev
450 2020-09-29T17:54:06  *** schmidty has joined #bitcoin-core-dev
451 2020-09-29T17:54:22  *** jkczyz has joined #bitcoin-core-dev
452 2020-09-29T17:54:28  *** corollari__ has joined #bitcoin-core-dev
453 2020-09-29T17:54:29  *** fanquake has joined #bitcoin-core-dev
454 2020-09-29T17:54:29  *** noganoo has joined #bitcoin-core-dev
455 2020-09-29T17:54:45  *** pierre_rochard has joined #bitcoin-core-dev
456 2020-09-29T17:55:08  *** ahmed_ has joined #bitcoin-core-dev
457 2020-09-29T17:55:23  *** Guyver2_ has joined #bitcoin-core-dev
458 2020-09-29T17:57:39  *** GoldmanSats__ has joined #bitcoin-core-dev
459 2020-09-29T17:58:10  *** Guyver2 has quit IRC
460 2020-09-29T17:58:29  *** felixweis has joined #bitcoin-core-dev
461 2020-09-29T17:59:43  *** dburkett has joined #bitcoin-core-dev
462 2020-09-29T18:00:01  *** zpao has quit IRC
463 2020-09-29T18:00:18  *** hsmiths has joined #bitcoin-core-dev
464 2020-09-29T18:00:22  *** robot-dreams has joined #bitcoin-core-dev
465 2020-09-29T18:00:59  *** michagogo has joined #bitcoin-core-dev
466 2020-09-29T18:04:41  *** amiti has joined #bitcoin-core-dev
467 2020-09-29T18:05:04  *** gertjaap_ has joined #bitcoin-core-dev
468 2020-09-29T18:05:20  *** Isthmus has joined #bitcoin-core-dev
469 2020-09-29T18:05:21  *** elichai2 has joined #bitcoin-core-dev
470 2020-09-29T18:07:11  *** bitcoin-git has joined #bitcoin-core-dev
471 2020-09-29T18:07:12  <bitcoin-git> [bitcoin] prayank23 opened pull request #20039: test: Convert amounts from float to decimal (master...floatdecimal) https://github.com/bitcoin/bitcoin/pull/20039
472 2020-09-29T18:07:13  *** bitcoin-git has left #bitcoin-core-dev
473 2020-09-29T18:08:51  *** rodarmor has joined #bitcoin-core-dev
474 2020-09-29T18:10:35  *** RubenSomsen has joined #bitcoin-core-dev
475 2020-09-29T18:11:15  *** Guyver2__ has joined #bitcoin-core-dev
476 2020-09-29T18:12:19  *** jamesob has joined #bitcoin-core-dev
477 2020-09-29T18:14:01  *** Guyver2_ has quit IRC
478 2020-09-29T18:14:59  *** kristapsk has quit IRC
479 2020-09-29T18:21:32  *** jakesyl has joined #bitcoin-core-dev
480 2020-09-29T18:22:14  *** ajpiano1 has joined #bitcoin-core-dev
481 2020-09-29T18:27:03  *** johnzweng has quit IRC
482 2020-09-29T18:29:58  *** mekster has joined #bitcoin-core-dev
483 2020-09-29T18:36:22  *** sparkplug_ has quit IRC
484 2020-09-29T18:37:12  *** sparkp1ug has quit IRC
485 2020-09-29T18:37:21  *** sparkplug has quit IRC
486 2020-09-29T18:38:43  *** sparkp1ug has joined #bitcoin-core-dev
487 2020-09-29T18:38:50  *** sparkplug has joined #bitcoin-core-dev
488 2020-09-29T18:39:10  *** sparkplug_ has joined #bitcoin-core-dev
489 2020-09-29T18:39:25  *** troygiorshev has joined #bitcoin-core-dev
490 2020-09-29T18:47:12  *** bitcoin-git has joined #bitcoin-core-dev
491 2020-09-29T18:47:12  <bitcoin-git> [bitcoin] achow101 opened pull request #20040: wallet: Refactor OutputGroups to handle fees and spending eligibility on insert (master...inner-groupoutputs) https://github.com/bitcoin/bitcoin/pull/20040
492 2020-09-29T18:47:13  *** bitcoin-git has left #bitcoin-core-dev
493 2020-09-29T18:56:23  *** mol has quit IRC
494 2020-09-29T19:03:55  *** mol has joined #bitcoin-core-dev
495 2020-09-29T19:03:56  *** fearbeag has quit IRC
496 2020-09-29T19:05:45  *** johnzweng has joined #bitcoin-core-dev
497 2020-09-29T19:06:26  *** elichai2 has quit IRC
498 2020-09-29T19:07:02  *** elichai2 has joined #bitcoin-core-dev
499 2020-09-29T19:18:41  *** kristapsk has joined #bitcoin-core-dev
500 2020-09-29T19:24:29  *** Talkless has quit IRC
501 2020-09-29T19:34:07  *** jonatack has quit IRC
502 2020-09-29T19:37:29  *** jonatack has joined #bitcoin-core-dev
503 2020-09-29T19:40:37  *** luke has joined #bitcoin-core-dev
504 2020-09-29T19:44:06  <roconnor> luke-jr: yeah, the icu thing seems fairly benign.  There are no unicode versions below 1.0.0.0, so I don't know how you would coax a problem out of the versionFilter.
505 2020-09-29T19:44:41  <roconnor> luke-jr: I think I saw the icu code crop up about 3 times.
506 2020-09-29T19:47:19  *** pinheadmz has joined #bitcoin-core-dev
507 2020-09-29T19:55:20  *** johnzweng has quit IRC
508 2020-09-29T20:03:51  *** rc_423 has joined #bitcoin-core-dev
509 2020-09-29T20:08:46  *** Guyver2_ has joined #bitcoin-core-dev
510 2020-09-29T20:09:23  *** rc_423 has quit IRC
511 2020-09-29T20:09:57  *** rc_423 has joined #bitcoin-core-dev
512 2020-09-29T20:10:12  *** Guyver2__ has quit IRC
513 2020-09-29T20:13:02  *** rc_423 has quit IRC
514 2020-09-29T20:17:54  *** troygiorshev has quit IRC
515 2020-09-29T20:18:31  *** ajpiano1 has quit IRC
516 2020-09-29T20:26:00  <dburkett> I understand (somewhat) the hesitation to refactor the code to add a little modularity, but there seems to be quite a bit of low-hanging fruit that routinely gets passed up.
517 2020-09-29T20:26:56  <dburkett> Here's a quick example: https://github.com/bitcoin/bitcoin/blob/d82b2c6e65ff1ade508e2e8abeb07d0ff37e09c4/src/validation.cpp#L1128-L1238 doesn't seem to be related to validation at all, and looks like an obvious candidate to move to some sort of BlockStore class or codefile.
518 2020-09-29T20:27:51  <dburkett> Do we avoid this kind of refactoring due simply to a lack of resources? Or is there some other reasoning that I'm missing?
519 2020-09-29T20:27:52  *** johnzweng has joined #bitcoin-core-dev
520 2020-09-29T20:32:39  *** Voker571 has joined #bitcoin-core-dev
521 2020-09-29T20:39:34  <sipa> dburkett: these are functions that are already only used from within validation.cpp, so i don't think there is particularly much to gain in modularity from moving them elsewhere
522 2020-09-29T20:40:13  <sipa> not saying it wouldn't be cleaner, but refactorings cost review time (and can be frustrating when people aren't excited enough to spend much time on it) - especially for things close to validation
523 2020-09-29T20:40:26  <luke-jr> dburkett: something like https://github.com/bitcoin/bitcoin/pull/771 ?
524 2020-09-29T20:40:54  <luke-jr> and in addition to sipa's points, it also adds rebase time to other PRs
525 2020-09-29T20:41:16  <dburkett> It feels like we would have benefits in not only readability, but also testability if we componentize things like that.
526 2020-09-29T20:42:06  <luke-jr> dburkett: I'm not saying there aren't benefits
527 2020-09-29T20:42:37  <sipa> dburkett: yeah, no objection there - but everything has costs too
528 2020-09-29T20:43:16  <luke-jr> if there was one perfect person just refactoring trusted to not break anything, it'd be easy to just get it done
529 2020-09-29T20:43:26  <dburkett> luke-jr: yes, something much like that
530 2020-09-29T20:43:27  <luke-jr> but even without malice, people can make mistakes, so everything needs review
531 2020-09-29T20:44:08  <sipa> luke-jr: cblockstore was arguably much more of what is now validationinterface, just not including the actual storage of blocks :)
532 2020-09-29T20:44:54  <luke-jr> sipa: I couldn't think of a better match :P
533 2020-09-29T20:45:21  <sipa> but sure, as evidence that people have tried this before, in various levels of ambitiousness
534 2020-09-29T20:45:22  <dburkett> sipa: I completely understand everything has costs. I guess my question is, if I did small, careful, and targeted refactoring like this, do you think it's something that would provide enough benefit to others to get the necessary review?
535 2020-09-29T20:45:39  <sipa> dburkett: it would be very low on my personal priority list
536 2020-09-29T20:45:46  <sipa> i can't speak about others'
537 2020-09-29T20:46:07  <sipa> but making it small and targetted is certainly easier
538 2020-09-29T20:46:53  <sipa> i don't mean to discourage you, though!
539 2020-09-29T20:47:26  <dburkett> Gotcha. Thanks for the honesty. Bitcoin development has often scared myself and many others away in the past due to the lack of readability and organization of the code.
540 2020-09-29T20:48:04  <sipa> dburkett: it depends on the kind of refactor, but many "innocent" refactors in the past have made things much harder to find for me
541 2020-09-29T20:48:37  <sipa> this is especially true for things that started with a nice ambitious goal, but only ever got partially completed, leaving things in a less consistent state than they were before
542 2020-09-29T20:48:41  <dburkett> But having smaller components to reason about and work on in isolation helps improve that. I may take a stab at some of the smaller refactoring to see how it goes
543 2020-09-29T20:50:08  <jonatack> dburkett: speaking personally, when deciding between (a) proposing changes, and (b) reviewing important open proposals that have been sitting for months or years due to lack of review, the truth is that few to no cases of (a) add as much value as doing (b)
544 2020-09-29T20:50:25  <luke-jr> maybe have the end goal completed, but PR part at a time?
545 2020-09-29T20:50:36  <jonatack> so it's all relative...question of prorities and opportunity cost
546 2020-09-29T20:50:44  <luke-jr> jonatack: good point
547 2020-09-29T20:50:48  <dburkett> luke-jr: seems like a solid approach
548 2020-09-29T20:51:11  <luke-jr> dburkett: in addition to resolving bottlenecks, review also helps you learn the code ;)
549 2020-09-29T20:52:23  *** ghost43 has quit IRC
550 2020-09-29T20:52:44  <dburkett> jonatack: I completely understand, though I think a lot of the more experienced devs like yourself downplay the difficulty of learning such a large and complex codebase, which could contribute to why we struggle to get reviewers. Every change to a 3000 line file just seems so intimidating to those not intimately familiar with it lol
551 2020-09-29T20:53:23  <jonatack> dburkett: i consider myself a new dev here :)
552 2020-09-29T20:53:25  *** Guyver2_ has quit IRC
553 2020-09-29T20:53:47  <luke-jr> XD
554 2020-09-29T20:53:54  *** ghost43 has joined #bitcoin-core-dev
555 2020-09-29T20:54:33  <sipa> dburkett: i'm no reference in this context, but i tend to find a project with hundreds of small files far more intimidating than one big one
556 2020-09-29T20:54:44  <sipa> i can't explain why
557 2020-09-29T20:54:56  <dburkett> btw, I do have a reasonable grasp on the code, only because I invested the significant time to learn it. I agree review helps learn it as well. I'm merely sharing my experiences from my own time learning the code.
558 2020-09-29T20:55:59  <sipa> i guess it all has to do with structure; you could have a clusterfuck of small files, or a clusterfuck of a large file, and either can have very unclear responsibilities/structure
559 2020-09-29T20:56:32  <sipa> but needing to look through many files, not knowing what they may do, just feels scarier to me than one big thing to read through :)
560 2020-09-29T20:56:41  <dburkett> sipa: I will speculate that it's because you're an old-time Linux hacker (not calling you old), rather than a modern corporate dev. There's certainly advantages to each approach, and both can be taken too far.
561 2020-09-29T20:56:44  <luke-jr> https://cmpwn.com/@sir/104949263468735420 free Talos II being offered for cost of shipping, looks like to whomever can propose the best use they'd put it to
562 2020-09-29T20:57:01  <sipa> dburkett: i never contributed to open source before bitcoin
563 2020-09-29T20:57:13  <luke-jr> :o
564 2020-09-29T20:57:19  <dburkett> Then I don't know :)
565 2020-09-29T20:57:24  <sipa> at least not in any meaningful capacity
566 2020-09-29T20:58:15  <sipa> dburkett: and at university everything was java, with a huge "many tiny classes, each in one file!" mantra - which i think is horrible
567 2020-09-29T20:58:38  <luke-jr> sipa: sometimes I think the file list and/or opening more files is more annoying than just searchign in an already open/visible file
568 2020-09-29T20:58:49  <sipa> luke-jr: yes!
569 2020-09-29T20:59:53  <dburkett> But the bouncing around in the same file makes it harder to keep tabs open with specific functions you're investigating. I totally get the sentiment though, and agree it can be taken too far
570 2020-09-29T21:00:02  *** Voker571 has quit IRC
571 2020-09-29T21:00:19  <sipa> "tabs" ?
572 2020-09-29T21:00:21  <luke-jr> dburkett: Kate at least has bookmarks
573 2020-09-29T21:00:31  *** grubles has left #bitcoin-core-dev
574 2020-09-29T21:01:08  <luke-jr> which is another case many files can be a nightmare: which file had the bookmark I want? :P
575 2020-09-29T21:01:09  <dburkett> In a modern IDE- remember this is 2020 :)
576 2020-09-29T21:01:28  <sipa> hmm, haven't used IDEs in years
577 2020-09-29T21:01:31  <luke-jr> how modern is an IDE without bookmarks? :P
578 2020-09-29T21:01:54  <sipa> i did for java, and used eclipse-cdt for a C project a decade ago or so
579 2020-09-29T21:02:26  <sipa> but i find i'm much more efficient working with 2-3 terminal windows with text editors
580 2020-09-29T21:04:40  <dburkett> IDEs have bookmarks, but they're less natural than opening separate files and navigating between them. I believe my questions have been answered by this dialog though. It's a difference purely in style between the vim hackers and modern IDE devs. It's a gap that won't be easy to bridge.
581 2020-09-29T21:05:47  <sipa> dburkett: to be clear, none of this has any bearing on wanting to separate out logically separate parts of the code to be physically separate as well (whether that means a separate file, another directory, ...)
582 2020-09-29T21:06:39  <sipa> but i do object to a blanket "smaller files better" view ;)
583 2020-09-29T21:07:32  *** luke has quit IRC
584 2020-09-29T21:08:48  *** sparkp1ug has quit IRC
585 2020-09-29T21:08:51  *** johnzweng has quit IRC
586 2020-09-29T21:09:22  <dburkett> Whether smaller files are "better" or not, I think it's reasonable to argue that small files are generally safer, and result in easier to maintain APIs. Though definitely any mantra can be taken too far, as the java folks have shown :)
587 2020-09-29T21:09:55  <sipa> yeah
588 2020-09-29T21:10:01  <sipa> and personal preferences will differ
589 2020-09-29T21:10:33  <dburkett> Anyhow, thanks for the discussion. It's valuable to hear about everyone's personal opinions and reasoning. It'll help guide my small, targeted attempts at refactoring.
590 2020-09-29T21:10:37  <sipa> dburkett: i think smaller well-defined interfaces are generally better - and if a single file is a single interface, perhaps
591 2020-09-29T21:11:01  <sipa> but in C++ it's not hard to fall into an anti-pattern where a single interface is defined by multiple files
592 2020-09-29T21:11:07  *** sparkplug has quit IRC
593 2020-09-29T21:11:26  *** sparkplug has joined #bitcoin-core-dev
594 2020-09-29T21:11:51  <dburkett> Yes, perhaps the difference in our thinking is only in our opinions about how many interfaces belong in a single file. I'll buy that physical structure is very much a personal preference, while logical structure has more universal rights and wrongs.
595 2020-09-29T21:13:04  <sipa> i also think (and this may be controversial, so certainly not going to push it onto anything), that you can have a single file that contains a series of well-documented interfaces (with comments saying "first define the low-level data structures used:" "here is some of the computational stuff" "here is the main interface implementation"), if those preliminary things are only used by what follows in
596 2020-09-29T21:13:05  <dburkett> sipa: I've not come across many examples where a single interface spans multiple files, but I don't doubt that there are many examples out there. I agree that is not great at all.
597 2020-09-29T21:13:10  <sipa> the same file
598 2020-09-29T21:13:52  <sipa> it prevents littering the directory structure with extra files that are private to one concept anyway
599 2020-09-29T21:14:22  <dburkett> So you're talking about file-scope data structures and interfaces in a cpp file that you're not exposing in a header. I definitely understand that pattern.
600 2020-09-29T21:14:59  <sipa> yeah
601 2020-09-29T21:15:33  <dburkett> When it becomes too burdensome, a directory or separate lib or something becomes more important. But if not taken too far, that's a pattern I often follow myself.
602 2020-09-29T21:43:01  *** johnzweng has joined #bitcoin-core-dev
603 2020-09-29T21:46:52  *** luke-jr has quit IRC
604 2020-09-29T21:52:07  *** endogenic has quit IRC
605 2020-09-29T21:52:39  *** jamesob has quit IRC
606 2020-09-29T21:52:45  *** digi_james has quit IRC
607 2020-09-29T21:52:45  *** hebasto has quit IRC
608 2020-09-29T21:52:45  *** ajonas has quit IRC
609 2020-09-29T21:52:57  *** rodarmor has quit IRC
610 2020-09-29T21:52:57  *** hsmiths has quit IRC
611 2020-09-29T21:53:10  *** robot-dreams has quit IRC
612 2020-09-29T21:53:10  *** felixweis has quit IRC
613 2020-09-29T21:53:13  *** mariorz has quit IRC
614 2020-09-29T21:53:13  *** mmitech___ has quit IRC
615 2020-09-29T21:53:23  *** prusnak has quit IRC
616 2020-09-29T21:53:27  *** dergoegge has quit IRC
617 2020-09-29T21:53:32  *** jakesyl has quit IRC
618 2020-09-29T21:53:32  *** RubenSomsen has quit IRC
619 2020-09-29T21:53:41  *** dburkett has quit IRC
620 2020-09-29T21:53:47  *** elichai2 has quit IRC
621 2020-09-29T21:53:48  *** wallet42__ has quit IRC
622 2020-09-29T21:53:48  *** hugohn has quit IRC
623 2020-09-29T21:53:51  *** endogenic has joined #bitcoin-core-dev
624 2020-09-29T21:54:00  *** GoldmanSats__ has quit IRC
625 2020-09-29T21:54:01  *** nejon has quit IRC
626 2020-09-29T21:54:01  *** drbrule has quit IRC
627 2020-09-29T21:54:16  *** hebasto has joined #bitcoin-core-dev
628 2020-09-29T21:54:23  *** Galvas has quit IRC
629 2020-09-29T21:54:23  *** fjahr has quit IRC
630 2020-09-29T21:54:23  *** gloriazhao has quit IRC
631 2020-09-29T21:54:39  *** ccook has quit IRC
632 2020-09-29T21:54:39  *** vfP56jSe has quit IRC
633 2020-09-29T21:54:42  *** michagogo has quit IRC
634 2020-09-29T21:55:02  *** dergoegge has joined #bitcoin-core-dev
635 2020-09-29T21:55:33  *** prusnak has joined #bitcoin-core-dev
636 2020-09-29T21:55:33  *** vfP56jSe has joined #bitcoin-core-dev
637 2020-09-29T21:55:39  *** digi_james has joined #bitcoin-core-dev
638 2020-09-29T21:55:44  *** rodarmor has joined #bitcoin-core-dev
639 2020-09-29T21:55:45  *** wallet42__ has joined #bitcoin-core-dev
640 2020-09-29T21:55:50  *** elichai2 has joined #bitcoin-core-dev
641 2020-09-29T21:55:52  *** fjahr has joined #bitcoin-core-dev
642 2020-09-29T21:55:53  *** mmitech___ has joined #bitcoin-core-dev
643 2020-09-29T21:55:58  *** dburkett has joined #bitcoin-core-dev
644 2020-09-29T21:55:58  *** jakesyl has joined #bitcoin-core-dev
645 2020-09-29T21:56:02  *** ccook has joined #bitcoin-core-dev
646 2020-09-29T21:56:08  *** jamesob has joined #bitcoin-core-dev
647 2020-09-29T21:56:09  *** RubenSomsen has joined #bitcoin-core-dev
648 2020-09-29T21:56:17  *** mariorz has joined #bitcoin-core-dev
649 2020-09-29T21:56:22  *** hsmiths has joined #bitcoin-core-dev
650 2020-09-29T21:56:26  *** ajonas has joined #bitcoin-core-dev
651 2020-09-29T21:56:38  *** robot-dreams has joined #bitcoin-core-dev
652 2020-09-29T21:56:38  *** drbrule has joined #bitcoin-core-dev
653 2020-09-29T21:57:00  *** Galvas has joined #bitcoin-core-dev
654 2020-09-29T21:57:00  *** GoldmanSats__ has joined #bitcoin-core-dev
655 2020-09-29T21:57:16  *** nejon has joined #bitcoin-core-dev
656 2020-09-29T21:57:27  *** felixweis has joined #bitcoin-core-dev
657 2020-09-29T21:58:04  *** michagogo has joined #bitcoin-core-dev
658 2020-09-29T21:59:10  *** hugohn has joined #bitcoin-core-dev
659 2020-09-29T22:03:40  *** johnzweng has quit IRC
660 2020-09-29T22:05:16  *** luke-jr has joined #bitcoin-core-dev
661 2020-09-29T22:08:20  *** sparkplug_ has left #bitcoin-core-dev
662 2020-09-29T22:10:23  *** vasild has quit IRC
663 2020-09-29T22:12:18  *** vasild has joined #bitcoin-core-dev
664 2020-09-29T22:12:49  *** sparkp1ug has joined #bitcoin-core-dev
665 2020-09-29T22:13:46  *** luke-jr has quit IRC
666 2020-09-29T22:13:47  *** sparkp1ug has quit IRC
667 2020-09-29T22:21:49  *** sparkplug has quit IRC
668 2020-09-29T22:25:47  *** marcoagner has quit IRC
669 2020-09-29T22:40:42  *** johnzweng has joined #bitcoin-core-dev
670 2020-09-29T22:54:11  *** Aaronvan_ has quit IRC
671 2020-09-29T22:59:46  *** aj1 has joined #bitcoin-core-dev
672 2020-09-29T23:25:28  *** johnzweng has quit IRC
673 2020-09-29T23:57:41  *** johnzweng has joined #bitcoin-core-dev