12020-10-02T00:00:01 *** Dimlock has quit IRC
22020-10-02T00:00:08 *** DeanGuss has quit IRC
32020-10-02T00:05:25 *** DeanGuss has joined #bitcoin-core-dev
42020-10-02T00:05:51 *** ahmed_ has joined #bitcoin-core-dev
52020-10-02T00:05:51 *** felixweis has joined #bitcoin-core-dev
62020-10-02T00:05:51 *** fjahr has joined #bitcoin-core-dev
72020-10-02T00:05:53 *** DeanGuss has quit IRC
82020-10-02T00:06:16 *** DeanGuss has joined #bitcoin-core-dev
92020-10-02T00:19:23 *** mrostecki has quit IRC
102020-10-02T00:22:13 *** DuncanT1 has joined #bitcoin-core-dev
112020-10-02T00:40:22 *** S3RK has joined #bitcoin-core-dev
122020-10-02T00:44:47 *** S3RK has quit IRC
132020-10-02T00:45:51 *** AaronvanW has quit IRC
142020-10-02T00:46:34 *** AaronvanW has joined #bitcoin-core-dev
152020-10-02T00:56:39 *** S3RK has joined #bitcoin-core-dev
162020-10-02T01:25:09 *** AaronvanW has quit IRC
172020-10-02T01:34:25 *** EagleTM has joined #bitcoin-core-dev
182020-10-02T01:35:47 *** Eagle[TM] has quit IRC
192020-10-02T01:51:03 *** vasild has quit IRC
202020-10-02T01:52:58 *** vasild has joined #bitcoin-core-dev
212020-10-02T01:55:34 *** TallTim has joined #bitcoin-core-dev
222020-10-02T02:04:11 *** AaronvanW has joined #bitcoin-core-dev
232020-10-02T02:04:35 *** promag has quit IRC
242020-10-02T02:09:07 *** justanotheruser has quit IRC
252020-10-02T02:09:22 *** AaronvanW has quit IRC
262020-10-02T02:23:56 *** jb55 has quit IRC
272020-10-02T02:24:24 *** jb55 has joined #bitcoin-core-dev
282020-10-02T02:28:40 *** justanotheruser has joined #bitcoin-core-dev
292020-10-02T02:33:22 *** shesek has joined #bitcoin-core-dev
302020-10-02T02:33:22 *** shesek has joined #bitcoin-core-dev
312020-10-02T03:00:01 *** DuncanT1 has quit IRC
322020-10-02T03:06:39 *** justanotheruser has quit IRC
332020-10-02T03:20:52 *** justanotheruser has joined #bitcoin-core-dev
342020-10-02T03:21:09 *** felixweis has quit IRC
352020-10-02T03:21:09 *** ahmed_ has quit IRC
362020-10-02T03:21:09 *** fjahr has quit IRC
372020-10-02T03:21:10 *** sr_gi has quit IRC
382020-10-02T03:21:27 *** espadrine has joined #bitcoin-core-dev
392020-10-02T03:21:44 *** sr_gi has joined #bitcoin-core-dev
402020-10-02T03:32:07 *** Ga1aCt1Cz00 has quit IRC
412020-10-02T03:32:09 *** promag has joined #bitcoin-core-dev
422020-10-02T03:32:30 *** Ga1aCt1Cz00 has joined #bitcoin-core-dev
432020-10-02T03:42:01 *** promag_ has joined #bitcoin-core-dev
442020-10-02T03:42:01 *** promag has quit IRC
452020-10-02T03:43:02 *** Emcy_ has quit IRC
462020-10-02T03:45:34 *** opsec_x122 has joined #bitcoin-core-dev
472020-10-02T03:46:55 *** Emcy has joined #bitcoin-core-dev
482020-10-02T03:48:03 *** promag has joined #bitcoin-core-dev
492020-10-02T03:48:04 *** promag_ has quit IRC
502020-10-02T03:48:50 *** opsec_x12 has quit IRC
512020-10-02T03:49:03 *** ahmed_ has joined #bitcoin-core-dev
522020-10-02T03:49:03 *** felixweis has joined #bitcoin-core-dev
532020-10-02T03:49:03 *** fjahr has joined #bitcoin-core-dev
542020-10-02T04:02:55 *** cato_ has quit IRC
552020-10-02T04:03:08 *** cato_ has joined #bitcoin-core-dev
562020-10-02T04:03:11 *** promag has quit IRC
572020-10-02T04:03:23 *** promag has joined #bitcoin-core-dev
582020-10-02T04:06:09 *** AaronvanW has joined #bitcoin-core-dev
592020-10-02T04:07:42 *** promag has quit IRC
602020-10-02T04:08:24 *** promag has joined #bitcoin-core-dev
612020-10-02T04:09:04 *** bitcoin-git has joined #bitcoin-core-dev
622020-10-02T04:09:04 <bitcoin-git> [bitcoin] robot-dreams closed pull request #19968: doc: make it easier to work out size of bloom filter (master...bloom-doc) https://github.com/bitcoin/bitcoin/pull/19968
632020-10-02T04:09:06 *** bitcoin-git has left #bitcoin-core-dev
642020-10-02T04:09:39 *** bitcoin-git has joined #bitcoin-core-dev
652020-10-02T04:09:39 <bitcoin-git> [bitcoin] robot-dreams reopened pull request #19968: doc: make it easier to work out size of bloom filter (master...bloom-doc) https://github.com/bitcoin/bitcoin/pull/19968
662020-10-02T04:09:40 *** bitcoin-git has left #bitcoin-core-dev
672020-10-02T04:13:14 *** sdaftuar has quit IRC
682020-10-02T04:14:01 *** sdaftuar has joined #bitcoin-core-dev
692020-10-02T04:17:09 *** bitcoin-git has joined #bitcoin-core-dev
702020-10-02T04:17:10 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a0185d90a7f2...69a73803dfb2
712020-10-02T04:17:10 <bitcoin-git> bitcoin/master 598e3b1 Wladimir J. van der Laan: tx: Update transifex slug for 0.21
722020-10-02T04:17:11 <bitcoin-git> bitcoin/master 7532c9a Wladimir J. van der Laan: qt: Periodic translations update
732020-10-02T04:17:11 <bitcoin-git> bitcoin/master 69a7380 fanquake: Merge #20058: Update transifex slug for 0.21
742020-10-02T04:17:13 *** bitcoin-git has left #bitcoin-core-dev
752020-10-02T04:17:29 *** bitcoin-git has joined #bitcoin-core-dev
762020-10-02T04:17:29 <bitcoin-git> [bitcoin] fanquake merged pull request #20058: Update transifex slug for 0.21 (master...2020_10_transifex_slug) https://github.com/bitcoin/bitcoin/pull/20058
772020-10-02T04:17:30 *** bitcoin-git has left #bitcoin-core-dev
782020-10-02T04:19:34 *** S3RK has quit IRC
792020-10-02T04:20:01 *** S3RK has joined #bitcoin-core-dev
802020-10-02T04:23:58 *** hugohn has quit IRC
812020-10-02T04:24:09 *** hugohn has joined #bitcoin-core-dev
822020-10-02T04:24:18 *** S3RK has quit IRC
832020-10-02T04:29:04 *** ghost43 has quit IRC
842020-10-02T04:29:51 *** ghost43 has joined #bitcoin-core-dev
852020-10-02T04:32:42 *** mekster has quit IRC
862020-10-02T04:33:17 *** mekster has joined #bitcoin-core-dev
872020-10-02T04:38:58 *** bitcoin-git has joined #bitcoin-core-dev
882020-10-02T04:38:58 <bitcoin-git> [bitcoin] fanquake opened pull request #20060: refactor: fix -Wbraced-scalar-init warning in validation tests (master...braces_scalar_init) https://github.com/bitcoin/bitcoin/pull/20060
892020-10-02T04:38:59 *** bitcoin-git has left #bitcoin-core-dev
902020-10-02T04:39:31 *** AaronvanW has quit IRC
912020-10-02T04:42:08 *** S3RK has joined #bitcoin-core-dev
922020-10-02T04:57:54 *** proofofkeags has quit IRC
932020-10-02T05:00:43 *** ghost43 has quit IRC
942020-10-02T05:01:38 *** ghost43 has joined #bitcoin-core-dev
952020-10-02T05:08:44 *** ohsoclean has joined #bitcoin-core-dev
962020-10-02T05:22:18 *** braydonf has quit IRC
972020-10-02T05:22:41 *** braydonf has joined #bitcoin-core-dev
982020-10-02T05:23:59 *** promag has quit IRC
992020-10-02T05:24:15 *** promag has joined #bitcoin-core-dev
1002020-10-02T05:26:52 *** Asbestos_Vapor has quit IRC
1012020-10-02T05:28:37 *** ohsoclean has left #bitcoin-core-dev
1022020-10-02T05:28:48 *** promag has quit IRC
1032020-10-02T05:29:21 *** promag has joined #bitcoin-core-dev
1042020-10-02T05:31:13 *** Mercury_Vapor has joined #bitcoin-core-dev
1052020-10-02T05:54:13 *** S3RK has quit IRC
1062020-10-02T06:00:02 *** espadrine has quit IRC
1072020-10-02T06:21:08 *** AIM has joined #bitcoin-core-dev
1082020-10-02T06:36:53 *** AaronvanW has joined #bitcoin-core-dev
1092020-10-02T06:39:18 *** ctrlbreak_MAD has joined #bitcoin-core-dev
1102020-10-02T06:39:46 *** bitcoin-git has joined #bitcoin-core-dev
1112020-10-02T06:39:46 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/69a73803dfb2...a6a993a888f5
1122020-10-02T06:39:47 <bitcoin-git> bitcoin/master 82b70f1 fanquake: refactor: fix -Wbraced-scalar-init warning in validation tests
1132020-10-02T06:39:48 <bitcoin-git> bitcoin/master a6a993a MarcoFalke: Merge #20060: refactor: fix -Wbraced-scalar-init warning in validation tes...
1142020-10-02T06:39:51 *** bitcoin-git has left #bitcoin-core-dev
1152020-10-02T06:40:06 *** bitcoin-git has joined #bitcoin-core-dev
1162020-10-02T06:40:06 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20060: refactor: fix -Wbraced-scalar-init warning in validation tests (master...braces_scalar_init) https://github.com/bitcoin/bitcoin/pull/20060
1172020-10-02T06:40:10 *** bitcoin-git has left #bitcoin-core-dev
1182020-10-02T06:42:48 *** ctrlbreak has quit IRC
1192020-10-02T06:49:41 *** S3RK has joined #bitcoin-core-dev
1202020-10-02T06:54:26 *** S3RK has quit IRC
1212020-10-02T06:58:06 *** S3RK has joined #bitcoin-core-dev
1222020-10-02T06:58:57 *** cltrbreak_MAD2 has joined #bitcoin-core-dev
1232020-10-02T07:02:01 *** ctrlbreak_MAD has quit IRC
1242020-10-02T07:04:26 *** promag has quit IRC
1252020-10-02T07:05:07 *** promag has joined #bitcoin-core-dev
1262020-10-02T07:05:19 *** bitcoin-git has joined #bitcoin-core-dev
1272020-10-02T07:05:19 <bitcoin-git> [bitcoin] fanquake reopened pull request #20055: rpc: Set HTTP Content-Type in bitcoin-cli (master...2020_10_cli_contenttype) https://github.com/bitcoin/bitcoin/pull/20055
1282020-10-02T07:05:20 *** bitcoin-git has left #bitcoin-core-dev
1292020-10-02T07:09:18 *** AaronvanW has quit IRC
1302020-10-02T07:10:12 *** promag_ has joined #bitcoin-core-dev
1312020-10-02T07:10:13 *** promag has quit IRC
1322020-10-02T07:11:38 *** promag_ has quit IRC
1332020-10-02T07:12:18 *** promag has joined #bitcoin-core-dev
1342020-10-02T07:19:46 *** promag_ has joined #bitcoin-core-dev
1352020-10-02T07:19:47 *** promag has quit IRC
1362020-10-02T07:25:47 *** bitcoin-git has joined #bitcoin-core-dev
1372020-10-02T07:25:48 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a6a993a888f5...60ec57b3d73e
1382020-10-02T07:25:49 <bitcoin-git> bitcoin/master 7eab781 Wladimir J. van der Laan: rpc: Set HTTP Content-Type in bitcoin-cli
1392020-10-02T07:25:49 <bitcoin-git> bitcoin/master 60ec57b fanquake: Merge #20055: rpc: Set HTTP Content-Type in bitcoin-cli
1402020-10-02T07:25:52 *** bitcoin-git has left #bitcoin-core-dev
1412020-10-02T07:26:08 *** bitcoin-git has joined #bitcoin-core-dev
1422020-10-02T07:26:08 <bitcoin-git> [bitcoin] fanquake merged pull request #20055: rpc: Set HTTP Content-Type in bitcoin-cli (master...2020_10_cli_contenttype) https://github.com/bitcoin/bitcoin/pull/20055
1432020-10-02T07:26:09 *** bitcoin-git has left #bitcoin-core-dev
1442020-10-02T07:42:04 *** promag_ has quit IRC
1452020-10-02T07:42:20 *** promag has joined #bitcoin-core-dev
1462020-10-02T07:49:18 *** andreacab has joined #bitcoin-core-dev
1472020-10-02T08:13:07 *** jonatack has quit IRC
1482020-10-02T08:24:14 *** promag has quit IRC
1492020-10-02T08:24:50 *** promag has joined #bitcoin-core-dev
1502020-10-02T08:26:26 *** S3RK has quit IRC
1512020-10-02T08:31:20 *** promag has quit IRC
1522020-10-02T08:31:35 *** promag has joined #bitcoin-core-dev
1532020-10-02T08:40:28 *** andreacab has quit IRC
1542020-10-02T08:41:11 *** andreacab has joined #bitcoin-core-dev
1552020-10-02T08:49:47 *** justanotheruser has quit IRC
1562020-10-02T08:50:20 *** rc_423 has joined #bitcoin-core-dev
1572020-10-02T08:51:26 *** jonatack has joined #bitcoin-core-dev
1582020-10-02T08:55:11 *** andreacab has quit IRC
1592020-10-02T08:55:38 *** andreacab has joined #bitcoin-core-dev
1602020-10-02T08:59:49 *** S3RK has joined #bitcoin-core-dev
1612020-10-02T08:59:55 *** andreacab has quit IRC
1622020-10-02T09:00:02 *** AIM has quit IRC
1632020-10-02T09:00:55 *** AaronvanW has joined #bitcoin-core-dev
1642020-10-02T09:05:01 *** kexkey has quit IRC
1652020-10-02T09:08:06 *** S3RK has quit IRC
1662020-10-02T09:08:16 *** S3RK has joined #bitcoin-core-dev
1672020-10-02T09:10:25 *** andreacab has joined #bitcoin-core-dev
1682020-10-02T09:11:27 *** andreacab has quit IRC
1692020-10-02T09:11:53 *** andreacab has joined #bitcoin-core-dev
1702020-10-02T09:15:25 <vasild> it just occurred to me that when -bind=127.0.0.1:1234 is specified (port is present, no -port= is given), then GetListenPort() will wrongly return 8333
1712020-10-02T09:16:07 *** andreacab has quit IRC
1722020-10-02T09:16:25 <vasild> in this case nobody is listening on 8333, but we do AddLocal() and tor's ADD_ONION with 8333
1732020-10-02T09:16:28 <hebasto> vasild: on master?
1742020-10-02T09:16:33 <vasild> yes, on master
1752020-10-02T09:18:08 <sipa> vasild: just because the port part of -bind is ignored?
1762020-10-02T09:18:39 <vasild> sipa: ignored by GetListenPort(), but not by the binding code which will actually correctly bind to 1234
1772020-10-02T09:19:11 *** Snowstormer has joined #bitcoin-core-dev
1782020-10-02T09:20:53 <vasild> ok, AddLocal() will do nothing with 127.0.0.1, but same applies for a routable address, e.g. --bind=15.16.17.18:1234 will advertise himself to peers as 15.16.17.18:8333 where nobody is listening
1792020-10-02T09:22:23 <vasild> bitcoind --bind=127.0.0.1:1234
1802020-10-02T09:22:24 <vasild> ...
1812020-10-02T09:22:27 <vasild> 2020-10-02T09:13:44Z tor: Got service ID izwdtn2vqpviyyqmhopz5yxstnq62vlhzpbcx5oexjoo4lf2bhwxulqd, advertising service izwdtn2vqpviyyqmhopz5yxstnq62vlhzpbcx5oexjoo4lf2bhwxulqd.onion:8333
1822020-10-02T09:22:31 <vasild> 2020-10-02T09:13:44Z AddLocal(izwdtn2vqpviyyqmhopz5yxstnq62vlhzpbcx5oexjoo4lf2bhwxulqd.onion:8333,4)
1832020-10-02T09:32:22 *** gleb has quit IRC
1842020-10-02T09:32:49 *** gleb has joined #bitcoin-core-dev
1852020-10-02T09:41:21 *** AaronvanW has quit IRC
1862020-10-02T09:41:40 *** AaronvanW has joined #bitcoin-core-dev
1872020-10-02T10:01:51 <wumpus> yes, i think the thing is that -port is a leftover from when it was only possible to bind to one address, when you bind to a series of addresses there is no "GetListenPort" but multiple so the concept doesn't make that much sense
1882020-10-02T10:02:20 <wumpus> as i understand it it's kind of a default
1892020-10-02T10:10:23 *** vasild has quit IRC
1902020-10-02T10:12:27 *** vasild has joined #bitcoin-core-dev
1912020-10-02T10:16:22 *** jonatack has quit IRC
1922020-10-02T10:18:27 *** Sebastian26Herma has joined #bitcoin-core-dev
1932020-10-02T10:26:04 <wumpus> but it's definitely possible something goes wrong with advertising those; it's *very* uncommon to listen on non-standard ports, let alone multiple different ports, wouldn't imagine it's a very well tested scenario
1942020-10-02T10:42:21 <hebasto> windows shutdown issue #20052 seems being resolved
1952020-10-02T10:42:23 <gribble> https://github.com/bitcoin/bitcoin/issues/20052 | Doesnt shut down cleanly on Windows · Issue #20052 · bitcoin/bitcoin · GitHub
1962020-10-02T10:45:34 *** S3RK has quit IRC
1972020-10-02T10:47:53 <wumpus> hebasto: great! i think the remaining question is 'can we do anything to make it work for shutdown /s', or is it some kind of forced emergency shutdown that intentionally bypasses running applications
1982020-10-02T10:48:25 <wumpus> in any case good to know it isn't a regression!
1992020-10-02T10:48:48 *** promag has quit IRC
2002020-10-02T10:49:22 <hebasto> `shutdown /s` warns user rather apps :)
2012020-10-02T10:49:31 *** promag has joined #bitcoin-core-dev
2022020-10-02T10:49:46 <wumpus> oh!
2032020-10-02T10:51:55 *** S3RK has joined #bitcoin-core-dev
2042020-10-02T10:55:41 <wumpus> in that case I agree the issue is resolved
2052020-10-02T11:00:31 <hebasto> wumpus: begging for re-reviewing #19991
2062020-10-02T11:00:34 <gribble> https://github.com/bitcoin/bitcoin/issues/19991 | net: Use alternative port for incoming Tor connections by hebasto · Pull Request #19991 · bitcoin/bitcoin · GitHub
2072020-10-02T11:02:59 *** owowo has quit IRC
2082020-10-02T11:03:16 <wumpus> hebasto: will do
2092020-10-02T11:03:26 *** elichai2 has quit IRC
2102020-10-02T11:04:48 <hebasto> wumpus: many thanks!
2112020-10-02T11:05:26 *** andreacab has joined #bitcoin-core-dev
2122020-10-02T11:07:34 *** S3RK has quit IRC
2132020-10-02T11:07:52 *** owowo has joined #bitcoin-core-dev
2142020-10-02T11:08:02 *** S3RK has joined #bitcoin-core-dev
2152020-10-02T11:08:44 *** Sebastian26Herma has quit IRC
2162020-10-02T11:12:11 *** S3RK has quit IRC
2172020-10-02T11:12:21 *** S3RK has joined #bitcoin-core-dev
2182020-10-02T11:16:49 *** side^effects has joined #bitcoin-core-dev
2192020-10-02T11:18:28 *** side^effects has quit IRC
2202020-10-02T11:18:35 *** S3RK has quit IRC
2212020-10-02T11:37:49 *** jonatack has joined #bitcoin-core-dev
2222020-10-02T11:38:17 *** bitcoin-git has joined #bitcoin-core-dev
2232020-10-02T11:38:18 <bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/60ec57b3d73e...df2129a2349b
2242020-10-02T11:38:19 <bitcoin-git> bitcoin/master b3273cf Hennadii Stepanov: net: Use network byte order for in_addr.s_addr
2252020-10-02T11:38:20 <bitcoin-git> bitcoin/master a5266d4 Hennadii Stepanov: net: Add alternative port for onion service
2262020-10-02T11:38:21 <bitcoin-git> bitcoin/master fdd3ae4 Hennadii Stepanov: net, refactor: Refactor CBaseChainParams::RPCPort function
2272020-10-02T11:38:22 *** bitcoin-git has left #bitcoin-core-dev
2282020-10-02T11:38:37 *** bitcoin-git has joined #bitcoin-core-dev
2292020-10-02T11:38:37 <bitcoin-git> [bitcoin] laanwj merged pull request #19991: net: Use alternative port for incoming Tor connections (master...200922-tor) https://github.com/bitcoin/bitcoin/pull/19991
2302020-10-02T11:38:38 *** bitcoin-git has left #bitcoin-core-dev
2312020-10-02T11:39:33 <hebasto> wumpus: ^ thank you!
2322020-10-02T11:42:14 *** jonatack has quit IRC
2332020-10-02T11:44:00 *** jonatack has joined #bitcoin-core-dev
2342020-10-02T11:44:22 <wumpus> thank you for working on it, it has been on my list for so long
2352020-10-02T11:48:24 <wumpus> soo next up #19954 :-)
2362020-10-02T11:48:27 <gribble> https://github.com/bitcoin/bitcoin/issues/19954 | tor: complete the TORv3 implementation by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
2372020-10-02T11:49:26 <wumpus> (no, it's not rfm yet, but getting close)
2382020-10-02T11:50:37 <hebasto> #19998 is also related :)
2392020-10-02T11:50:39 <gribble> https://github.com/bitcoin/bitcoin/issues/19998 | net: Add CNode::ConnectedThroughNetwork member function by hebasto · Pull Request #19998 · bitcoin/bitcoin · GitHub
2402020-10-02T11:57:29 *** watchtower has joined #bitcoin-core-dev
2412020-10-02T11:58:38 *** mrostecki has joined #bitcoin-core-dev
2422020-10-02T12:00:01 *** Snowstormer has quit IRC
2432020-10-02T12:09:26 *** bitcoin-git has joined #bitcoin-core-dev
2442020-10-02T12:09:26 <bitcoin-git> [bitcoin] jonatack closed pull request #19951: net, test: CNetAddr scoped ipv6 test coverage, rename scopeId to m_scope_id (master...CNetAddr-scoped-ipv6-unit-tests-docs-and-rename-scopeId-to-m_scope_id) https://github.com/bitcoin/bitcoin/pull/19951
2452020-10-02T12:09:34 *** bitcoin-git has left #bitcoin-core-dev
2462020-10-02T12:09:50 *** bitcoin-git has joined #bitcoin-core-dev
2472020-10-02T12:09:50 <bitcoin-git> [bitcoin] jonatack closed pull request #19720: test: bip157 p2p_blockfilters configuration options (master...bip157-blockfilters-tests) https://github.com/bitcoin/bitcoin/pull/19720
2482020-10-02T12:09:52 *** bitcoin-git has left #bitcoin-core-dev
2492020-10-02T12:21:30 *** phyll1s_work has joined #bitcoin-core-dev
2502020-10-02T12:25:46 *** andreacab has quit IRC
2512020-10-02T12:26:12 <wumpus> jonatack: https://github.com/bitcoin/bitcoin/pull/19991#issuecomment-702690380 oh sorry for that I'll take a look at those then
2522020-10-02T12:26:12 *** andreacab has joined #bitcoin-core-dev
2532020-10-02T12:30:30 <jonatack> wu
2542020-10-02T12:30:57 *** andreacab has quit IRC
2552020-10-02T12:31:03 <jonatack> wumpus: no worries, i agree with moving things forward
2562020-10-02T12:40:37 *** Guyver2 has joined #bitcoin-core-dev
2572020-10-02T12:53:27 *** andreacab has joined #bitcoin-core-dev
2582020-10-02T12:56:23 *** pinheadmz has quit IRC
2592020-10-02T13:02:37 *** pinheadmz has joined #bitcoin-core-dev
2602020-10-02T13:18:54 *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
2612020-10-02T13:24:59 *** da39a3ee5e6b4b0d has quit IRC
2622020-10-02T13:33:28 *** justanotheruser has joined #bitcoin-core-dev
2632020-10-02T13:38:23 *** filchef has joined #bitcoin-core-dev
2642020-10-02T13:38:54 <wumpus> jonatack: I can't find any test coverage PRs by you
2652020-10-02T13:53:43 <wumpus> (I only checked the open ones)
2662020-10-02T13:53:50 *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
2672020-10-02T13:57:48 *** promag has quit IRC
2682020-10-02T13:58:05 *** promag has joined #bitcoin-core-dev
2692020-10-02T14:02:21 *** andreacab has quit IRC
2702020-10-02T14:02:48 *** andreacab has joined #bitcoin-core-dev
2712020-10-02T14:07:18 *** andreacab has quit IRC
2722020-10-02T14:08:52 <MarcoFalke> ugh designated initializers is C++20 :(
2732020-10-02T14:09:30 * MarcoFalke remind me 2023
2742020-10-02T14:10:00 <wumpus> darn
2752020-10-02T14:17:19 *** andreacab has joined #bitcoin-core-dev
2762020-10-02T14:21:49 *** Guyver2_ has joined #bitcoin-core-dev
2772020-10-02T14:24:16 *** bitcoin-git has joined #bitcoin-core-dev
2782020-10-02T14:24:16 <bitcoin-git> [bitcoin] jonatack reopened pull request #19951: net, test: CNetAddr scoped ipv6 test coverage, rename scopeId to m_scope_id (master...CNetAddr-scoped-ipv6-unit-tests-docs-and-rename-scopeId-to-m_scope_id) https://github.com/bitcoin/bitcoin/pull/19951
2792020-10-02T14:24:17 *** bitcoin-git has left #bitcoin-core-dev
2802020-10-02T14:25:56 *** Guyver2 has quit IRC
2812020-10-02T14:27:34 *** wallet42__ has quit IRC
2822020-10-02T14:29:04 *** wallet42__ has joined #bitcoin-core-dev
2832020-10-02T14:29:57 *** sethrogers23[m] has quit IRC
2842020-10-02T14:30:23 *** sethrogers23[m] has joined #bitcoin-core-dev
2852020-10-02T14:34:56 <ariard> #19871 might be rfm, it's a doc-fix, has 2 ACKs and all tests okay
2862020-10-02T14:34:58 <gribble> https://github.com/bitcoin/bitcoin/issues/19871 | doc: Clarify scope of eviction protection of outbound block-relay peers by ariard · Pull Request #19871 · bitcoin/bitcoin · GitHub
2872020-10-02T14:36:04 <wumpus> ariard: thanks, will take a look
2882020-10-02T14:37:19 <ariard> thanks you
2892020-10-02T14:40:24 *** ahmed__ has joined #bitcoin-core-dev
2902020-10-02T14:40:33 *** felixweis has quit IRC
2912020-10-02T14:40:33 *** ahmed_ has quit IRC
2922020-10-02T14:40:33 *** fjahr has quit IRC
2932020-10-02T14:40:39 *** ahmed__ is now known as ahmed_
2942020-10-02T14:40:55 *** felixweis has joined #bitcoin-core-dev
2952020-10-02T14:40:55 *** fjahr has joined #bitcoin-core-dev
2962020-10-02T14:42:33 *** arik__ has quit IRC
2972020-10-02T14:42:44 <vasild> gleb: sipa: what is your opinion on https://github.com/bitcoin/bitcoin/pull/19043#issuecomment-702740744 ? Short story - currently we relay routable addresses (reachable or not) and add to addrman reachable addresses (routable or not) (huh!?). Should we do the same with I2P addresses in 0.21? They will be routable and not reachable.
2982020-10-02T14:43:12 *** bitcoin-git has joined #bitcoin-core-dev
2992020-10-02T14:43:13 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/df2129a2349b...597488d37c9c
3002020-10-02T14:43:13 <bitcoin-git> bitcoin/master ac71fe9 Antoine Riard: [doc] Clarify scope of eviction protection of outbound block-relay peers
3012020-10-02T14:43:14 <bitcoin-git> bitcoin/master d769254 Antoine Riard: [doc] Clarify semantic of peer's m_protect w.r.t to outbound eviction logi...
3022020-10-02T14:43:15 <bitcoin-git> bitcoin/master 597488d Wladimir J. van der Laan: Merge #19871: doc: Clarify scope of eviction protection of outbound block-...
3032020-10-02T14:43:16 *** bitcoin-git has left #bitcoin-core-dev
3042020-10-02T14:43:56 *** gloriazhao has quit IRC
3052020-10-02T14:45:16 *** gloriazhao has joined #bitcoin-core-dev
3062020-10-02T14:45:22 *** arik__ has joined #bitcoin-core-dev
3072020-10-02T14:46:46 *** fjahr has quit IRC
3082020-10-02T14:47:14 <vasild> gleb: sipa: wrong url, correct one: https://github.com/bitcoin/bitcoin/pull/19954#issuecomment-701307791
3092020-10-02T14:48:42 *** kexkey has joined #bitcoin-core-dev
3102020-10-02T14:49:22 *** fjahr has joined #bitcoin-core-dev
3112020-10-02T14:50:23 *** felixweis has quit IRC
3122020-10-02T14:53:32 *** felixweis has joined #bitcoin-core-dev
3132020-10-02T15:00:02 *** phyll1s_work has quit IRC
3142020-10-02T15:06:04 *** Talkless has joined #bitcoin-core-dev
3152020-10-02T15:07:11 *** Talkless has quit IRC
3162020-10-02T15:07:46 *** bitcoin-git has joined #bitcoin-core-dev
3172020-10-02T15:07:46 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/597488d37c9c...d9935222d53a
3182020-10-02T15:07:47 <bitcoin-git> bitcoin/master 5cb5fd3 Jon Atack: test: add test coverage for CNetAddr ipv6 scoped addresses
3192020-10-02T15:07:47 <bitcoin-git> bitcoin/master f36887f Jon Atack: net: rename CNetAddr scopeId to m_scope_id, improve code doc
3202020-10-02T15:07:48 <bitcoin-git> bitcoin/master d993522 Wladimir J. van der Laan: Merge #19951: net, test: CNetAddr scoped ipv6 test coverage, rename scope...
3212020-10-02T15:07:49 *** bitcoin-git has left #bitcoin-core-dev
3222020-10-02T15:08:06 *** bitcoin-git has joined #bitcoin-core-dev
3232020-10-02T15:08:06 <bitcoin-git> [bitcoin] laanwj merged pull request #19951: net, test: CNetAddr scoped ipv6 test coverage, rename scopeId to m_scope_id (master...CNetAddr-scoped-ipv6-unit-tests-docs-and-rename-scopeId-to-m_scope_id) https://github.com/bitcoin/bitcoin/pull/19951
3242020-10-02T15:08:07 *** bitcoin-git has left #bitcoin-core-dev
3252020-10-02T15:09:12 *** bitcoin-git has joined #bitcoin-core-dev
3262020-10-02T15:09:13 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d9935222d53a...171cd05ae341
3272020-10-02T15:09:14 <bitcoin-git> bitcoin/master ed3acda Russell Yanofsky: test, refactor: add default_wallet_name and wallet_data_filename variables...
3282020-10-02T15:09:14 <bitcoin-git> bitcoin/master c1585bc Russell Yanofsky: test: Get rid of default wallet hacks
3292020-10-02T15:09:15 <bitcoin-git> bitcoin/master 171cd05 MarcoFalke: Merge #20034: test: Get rid of default wallet hacks
3302020-10-02T15:09:17 *** bitcoin-git has left #bitcoin-core-dev
3312020-10-02T15:09:31 *** bitcoin-git has joined #bitcoin-core-dev
3322020-10-02T15:09:31 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20034: test: Get rid of default wallet hacks (master...pr/defw) https://github.com/bitcoin/bitcoin/pull/20034
3332020-10-02T15:09:32 *** bitcoin-git has left #bitcoin-core-dev
3342020-10-02T15:22:00 *** yost3d has joined #bitcoin-core-dev
3352020-10-02T15:26:25 *** justanotheruser has quit IRC
3362020-10-02T15:27:45 *** bitcoin-git has joined #bitcoin-core-dev
3372020-10-02T15:27:46 <bitcoin-git> [bitcoin] MDrollette closed pull request #19043: torcontrol: add -tortarget config (master...tor-hidden-target) https://github.com/bitcoin/bitcoin/pull/19043
3382020-10-02T15:27:47 *** bitcoin-git has left #bitcoin-core-dev
3392020-10-02T15:28:21 *** proofofkeags has joined #bitcoin-core-dev
3402020-10-02T15:31:09 *** alko89 has quit IRC
3412020-10-02T15:31:57 *** alko89 has joined #bitcoin-core-dev
3422020-10-02T15:35:18 *** andreacab has quit IRC
3432020-10-02T15:36:12 *** andreacab has joined #bitcoin-core-dev
3442020-10-02T15:40:25 *** andreacab has quit IRC
3452020-10-02T15:42:56 *** kljasdfvv has quit IRC
3462020-10-02T15:43:17 *** andreacab has joined #bitcoin-core-dev
3472020-10-02T15:44:15 *** andreacab has quit IRC
3482020-10-02T15:44:21 *** andreaca_ has joined #bitcoin-core-dev
3492020-10-02T15:48:43 *** mrostecki has quit IRC
3502020-10-02T15:58:29 *** da39a3ee5e6b4b0d has quit IRC
3512020-10-02T16:04:47 *** andreaca_ has quit IRC
3522020-10-02T16:05:14 *** andreacab has joined #bitcoin-core-dev
3532020-10-02T16:06:12 *** andreacab has joined #bitcoin-core-dev
3542020-10-02T16:09:19 *** promag has quit IRC
3552020-10-02T16:10:01 *** promag has joined #bitcoin-core-dev
3562020-10-02T16:21:06 *** andreacab has quit IRC
3572020-10-02T16:21:33 *** andreacab has joined #bitcoin-core-dev
3582020-10-02T16:22:56 <hebasto> AppVeyor fails with "error MSB3073"
3592020-10-02T16:23:54 *** andreaca_ has joined #bitcoin-core-dev
3602020-10-02T16:25:26 *** andreaca_ has quit IRC
3612020-10-02T16:25:55 *** andreacab has quit IRC
3622020-10-02T16:25:58 *** andreaca_ has joined #bitcoin-core-dev
3632020-10-02T16:26:11 <instagibbs> hebasto, github deemed a money service business, sad
3642020-10-02T16:26:15 *** Guyver2__ has joined #bitcoin-core-dev
3652020-10-02T16:27:26 <hebasto> there was a recent change that could be related #19960
3662020-10-02T16:27:29 <gribble> https://github.com/bitcoin/bitcoin/issues/19960 | build: The vcpkg tool has introduced a proper way to use manifests by sipsorcery · Pull Request #19960 · bitcoin/bitcoin · GitHub
3672020-10-02T16:29:37 *** Guyver2_ has quit IRC
3682020-10-02T16:42:48 *** andreaca_ has quit IRC
3692020-10-02T16:45:12 *** andreacab has joined #bitcoin-core-dev
3702020-10-02T16:52:10 *** Mercury_Vapor has quit IRC
3712020-10-02T16:52:35 *** jb55 has quit IRC
3722020-10-02T16:56:42 *** Mercury_Vapor has joined #bitcoin-core-dev
3732020-10-02T17:03:13 *** owowo has quit IRC
3742020-10-02T17:03:28 *** owowo has joined #bitcoin-core-dev
3752020-10-02T17:03:49 *** worc3131 has joined #bitcoin-core-dev
3762020-10-02T17:11:11 <dhruvm> Is there any downside to disabling DNS seeds(it is only soft disabled today) altogether when a node is using -connect?
3772020-10-02T17:11:26 *** jb55 has joined #bitcoin-core-dev
3782020-10-02T17:12:33 <dhruvm> So if the user specifies `-connect -dnsseed=1`, the dns seeds are still exercised but addrman will not be used.
3792020-10-02T17:12:59 *** andreacab has quit IRC
3802020-10-02T17:13:25 *** andreacab has joined #bitcoin-core-dev
3812020-10-02T17:17:27 *** andreacab has quit IRC
3822020-10-02T17:20:21 *** andreacab has joined #bitcoin-core-dev
3832020-10-02T17:27:05 *** andreacab has quit IRC
3842020-10-02T17:27:31 *** andreacab has joined #bitcoin-core-dev
3852020-10-02T17:27:42 *** andreacab has joined #bitcoin-core-dev
3862020-10-02T17:32:59 *** andreacab has quit IRC
3872020-10-02T17:33:25 *** andreacab has joined #bitcoin-core-dev
3882020-10-02T17:36:35 *** andreacab has quit IRC
3892020-10-02T17:36:41 *** andreacab has joined #bitcoin-core-dev
3902020-10-02T17:47:50 *** jb55 has quit IRC
3912020-10-02T17:50:38 *** andreacab has quit IRC
3922020-10-02T17:51:04 *** andreacab has joined #bitcoin-core-dev
3932020-10-02T17:54:55 *** promag has quit IRC
3942020-10-02T17:55:12 *** promag has joined #bitcoin-core-dev
3952020-10-02T17:55:26 *** andreacab has quit IRC
3962020-10-02T17:59:51 *** promag has quit IRC
3972020-10-02T18:00:02 *** yost3d has quit IRC
3982020-10-02T18:00:29 *** promag has joined #bitcoin-core-dev
3992020-10-02T18:11:51 *** andreacab has joined #bitcoin-core-dev
4002020-10-02T18:22:47 *** ThunderChicken1 has joined #bitcoin-core-dev
4012020-10-02T18:26:35 *** bitdex has joined #bitcoin-core-dev
4022020-10-02T18:32:22 <wumpus> true, but there's probably a zillion different combinations of options that don't make, or don't seem to make sense, I don't think there's any reason to prevent a user from doing that if they really want to. As you say the default is already to disable it...
4032020-10-02T18:35:09 *** bitdex has quit IRC
4042020-10-02T18:41:32 <dhruvm> wumpus: ok, thanks
4052020-10-02T18:43:30 *** andreacab has quit IRC
4062020-10-02T18:45:39 *** andreacab has joined #bitcoin-core-dev
4072020-10-02T18:50:19 *** andreacab has quit IRC
4082020-10-02T18:50:55 *** andreacab has joined #bitcoin-core-dev
4092020-10-02T19:03:44 *** andreacab has quit IRC
4102020-10-02T19:04:10 *** andreacab has joined #bitcoin-core-dev
4112020-10-02T19:05:08 *** andreaca_ has joined #bitcoin-core-dev
4122020-10-02T19:06:56 *** andreaca_ has quit IRC
4132020-10-02T19:07:22 *** andreaca_ has joined #bitcoin-core-dev
4142020-10-02T19:08:38 *** andreacab has quit IRC
4152020-10-02T19:11:44 *** andreaca_ has quit IRC
4162020-10-02T19:12:45 *** andreacab has joined #bitcoin-core-dev
4172020-10-02T19:14:09 *** andreacab has quit IRC
4182020-10-02T19:19:05 *** braydonf has quit IRC
4192020-10-02T19:19:32 *** braydonf has joined #bitcoin-core-dev
4202020-10-02T19:21:11 *** andreacab has joined #bitcoin-core-dev
4212020-10-02T19:21:18 *** andreacab has joined #bitcoin-core-dev
4222020-10-02T19:29:24 *** andreacab has quit IRC
4232020-10-02T19:29:50 *** andreacab has joined #bitcoin-core-dev
4242020-10-02T19:33:55 *** andreacab has quit IRC
4252020-10-02T19:36:28 *** jb55 has joined #bitcoin-core-dev
4262020-10-02T19:55:27 *** opsec_x123 has joined #bitcoin-core-dev
4272020-10-02T19:55:51 *** Asbestos_Vapor has joined #bitcoin-core-dev
4282020-10-02T19:56:14 *** Klox0480 has joined #bitcoin-core-dev
4292020-10-02T19:56:23 *** Klox048 has quit IRC
4302020-10-02T19:56:58 <amiti> wumpus: you think its valuable to keep kinda-nonsensical combinations of init options around for users incase they _really_ want to? I tend towards valuing simplification / usability. ofc whether or not its a worthwhile PR to propose is a separate question.
4312020-10-02T19:57:03 <amiti> I personally feel like it'd be nice to move towards simplifying options for node operators as we make other changes over time
4322020-10-02T19:57:05 *** dergoegge has quit IRC
4332020-10-02T19:57:05 *** hebasto has quit IRC
4342020-10-02T19:57:05 *** fanquake has quit IRC
4352020-10-02T19:57:15 *** dergoegge has joined #bitcoin-core-dev
4362020-10-02T19:57:31 *** hebasto has joined #bitcoin-core-dev
4372020-10-02T19:57:33 *** fanquake has joined #bitcoin-core-dev
4382020-10-02T19:58:05 *** Mercury_Vapor has quit IRC
4392020-10-02T19:58:25 *** opsec_x122 has quit IRC
4402020-10-02T19:58:30 *** jb55 has quit IRC
4412020-10-02T20:42:20 <instagibbs> amiti, most people run defaults, for those who want to twiddle, we should let them unless it's an inherently dangerous combination?
4422020-10-02T20:42:40 <instagibbs> sensible defaults are another argument, but if users are explicitly asking for it...
4432020-10-02T20:45:55 *** filchef has quit IRC
4442020-10-02T20:56:53 *** promag has quit IRC
4452020-10-02T20:57:09 *** promag has joined #bitcoin-core-dev
4462020-10-02T21:00:02 *** ThunderChicken1 has quit IRC
4472020-10-02T21:00:56 *** jb55 has joined #bitcoin-core-dev
4482020-10-02T21:06:16 *** andreacab has joined #bitcoin-core-dev
4492020-10-02T21:10:26 *** andreacab has quit IRC
4502020-10-02T21:13:37 *** kristapsk has quit IRC
4512020-10-02T21:15:50 *** Guyver2_ has joined #bitcoin-core-dev
4522020-10-02T21:18:11 <fjahr> Brief note that there is a new label called "Good first review" now. Rationale can be found in the corresponding issue: #19941
4532020-10-02T21:18:12 <gribble> https://github.com/bitcoin/bitcoin/issues/19941 | "Good First Review" label · Issue #19941 · bitcoin/bitcoin · GitHub
4542020-10-02T21:18:28 *** Guyver2__ has quit IRC
4552020-10-02T21:21:23 *** srimech1 has joined #bitcoin-core-dev
4562020-10-02T21:28:18 *** owowo has quit IRC
4572020-10-02T21:32:56 *** owowo has joined #bitcoin-core-dev
4582020-10-02T21:34:50 <dhruvm> instagibbs: does allowing for combinations that do not make sense leave room for users accidentally misunderstanding how the cli flags work?
4592020-10-02T22:08:35 *** Guyver2_ has quit IRC
4602020-10-02T22:10:23 *** vasild has quit IRC
4612020-10-02T22:12:02 *** andreacab has joined #bitcoin-core-dev
4622020-10-02T22:12:13 *** vasild has joined #bitcoin-core-dev
4632020-10-02T22:25:30 *** bitcoin-git has joined #bitcoin-core-dev
4642020-10-02T22:25:30 <bitcoin-git> [bitcoin] fjahr opened pull request #20064: RPC: remove dublicate line in getblock help (master...getblock_help) https://github.com/bitcoin/bitcoin/pull/20064
4652020-10-02T22:25:30 *** bitcoin-git has left #bitcoin-core-dev
4662020-10-02T22:28:40 *** Talkless has joined #bitcoin-core-dev
4672020-10-02T22:32:26 *** andreacab has quit IRC
4682020-10-02T22:45:30 *** Talkless has quit IRC
4692020-10-02T22:48:00 *** jb55 has quit IRC
4702020-10-02T22:48:27 *** jb55 has joined #bitcoin-core-dev
4712020-10-02T22:59:22 *** kristapsk has joined #bitcoin-core-dev
4722020-10-02T23:02:39 <luke-jr> fjahr: good idea.
4732020-10-02T23:03:21 <fjahr> luke-jr: thanks :)
4742020-10-02T23:31:02 *** davterra has quit IRC
4752020-10-02T23:33:04 *** davterra has joined #bitcoin-core-dev
4762020-10-02T23:46:50 *** justanotheruser has joined #bitcoin-core-dev
4772020-10-02T23:48:50 *** mrostecki has joined #bitcoin-core-dev