1 2020-10-05T00:00:02  *** Hellaenergy has quit IRC
  2 2020-10-05T00:00:41  *** promag_ has quit IRC
  3 2020-10-05T00:01:43  *** davterra has quit IRC
  4 2020-10-05T00:21:58  *** Kampala has joined #bitcoin-core-dev
  5 2020-10-05T00:55:03  *** mrostecki has quit IRC
  6 2020-10-05T01:00:38  *** Mercury_Vapor has joined #bitcoin-core-dev
  7 2020-10-05T01:10:12  *** rc_423 has quit IRC
  8 2020-10-05T01:10:37  *** rc_423 has joined #bitcoin-core-dev
  9 2020-10-05T01:27:41  *** gloriazhao has quit IRC
 10 2020-10-05T01:27:58  *** sr_gi has quit IRC
 11 2020-10-05T01:28:20  *** sr_gi has joined #bitcoin-core-dev
 12 2020-10-05T01:30:40  *** Eagle[TM] has joined #bitcoin-core-dev
 13 2020-10-05T01:30:55  *** EagleTM has quit IRC
 14 2020-10-05T01:40:53  *** bitcoin-git has joined #bitcoin-core-dev
 15 2020-10-05T01:40:54  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cce151317909...dde104963b3b
 16 2020-10-05T01:40:54  <bitcoin-git> bitcoin/master 1885ad3 Fabian Jahr: RPC: remove duplicate line in getblock help
 17 2020-10-05T01:40:55  <bitcoin-git> bitcoin/master dde1049 fanquake: Merge #20064: RPC: remove duplicate line in getblock help
 18 2020-10-05T01:40:56  *** bitcoin-git has left #bitcoin-core-dev
 19 2020-10-05T01:41:13  *** bitcoin-git has joined #bitcoin-core-dev
 20 2020-10-05T01:41:14  <bitcoin-git> [bitcoin] fanquake merged pull request #20064: RPC: remove duplicate line in getblock help (master...getblock_help) https://github.com/bitcoin/bitcoin/pull/20064
 21 2020-10-05T01:41:14  *** bitcoin-git has left #bitcoin-core-dev
 22 2020-10-05T01:41:44  *** bitcoin-git has joined #bitcoin-core-dev
 23 2020-10-05T01:41:44  <bitcoin-git> [bitcoin] EthanHeilman opened pull request #20082: refactor: Minor refactor of RandAddSeedPerfmon + comments (master...perfmon) https://github.com/bitcoin/bitcoin/pull/20082
 24 2020-10-05T01:41:45  *** bitcoin-git has left #bitcoin-core-dev
 25 2020-10-05T01:50:07  <fanquake> luke-jr: looks like your DNS seed is down?
 26 2020-10-05T01:52:59  * luke-jr checks
 27 2020-10-05T01:54:08  <luke-jr> yep, should be back up when it's done loading the data file
 28 2020-10-05T02:15:57  *** justanotheruser has quit IRC
 29 2020-10-05T02:48:17  *** Dean_Guss has joined #bitcoin-core-dev
 30 2020-10-05T03:00:01  *** Kampala has quit IRC
 31 2020-10-05T03:00:41  *** mekster has joined #bitcoin-core-dev
 32 2020-10-05T03:14:18  *** davterra has joined #bitcoin-core-dev
 33 2020-10-05T03:21:59  *** tekojo has joined #bitcoin-core-dev
 34 2020-10-05T03:26:05  *** TheHoliestRoger has quit IRC
 35 2020-10-05T03:26:56  *** TheHoliestRoger has joined #bitcoin-core-dev
 36 2020-10-05T03:42:23  *** kristapsk has quit IRC
 37 2020-10-05T03:42:37  *** kristapsk has joined #bitcoin-core-dev
 38 2020-10-05T03:59:26  *** mol_ has joined #bitcoin-core-dev
 39 2020-10-05T04:03:26  *** mol has quit IRC
 40 2020-10-05T04:08:11  *** mol has joined #bitcoin-core-dev
 41 2020-10-05T04:10:44  *** mol_ has quit IRC
 42 2020-10-05T04:13:51  *** mol_ has joined #bitcoin-core-dev
 43 2020-10-05T04:17:09  *** mol has quit IRC
 44 2020-10-05T04:19:38  *** mol has joined #bitcoin-core-dev
 45 2020-10-05T04:21:49  *** mol_ has quit IRC
 46 2020-10-05T04:47:17  *** opsec_x12 has quit IRC
 47 2020-10-05T04:47:50  *** S3RK has joined #bitcoin-core-dev
 48 2020-10-05T04:52:03  *** S3RK_ has joined #bitcoin-core-dev
 49 2020-10-05T04:52:03  *** S3RK has quit IRC
 50 2020-10-05T04:58:00  *** S3RK_ has quit IRC
 51 2020-10-05T04:58:10  *** S3RK has joined #bitcoin-core-dev
 52 2020-10-05T05:02:23  *** kristapsk has quit IRC
 53 2020-10-05T05:22:54  *** nanotube has quit IRC
 54 2020-10-05T05:34:46  *** opsec_x12 has joined #bitcoin-core-dev
 55 2020-10-05T05:34:46  *** nanotube has joined #bitcoin-core-dev
 56 2020-10-05T05:37:57  *** sr_gi has quit IRC
 57 2020-10-05T05:38:32  *** sr_gi has joined #bitcoin-core-dev
 58 2020-10-05T06:00:02  *** tekojo has quit IRC
 59 2020-10-05T06:07:34  *** S3RK has quit IRC
 60 2020-10-05T06:08:01  *** S3RK has joined #bitcoin-core-dev
 61 2020-10-05T06:12:40  *** S3RK has quit IRC
 62 2020-10-05T06:22:12  *** nico1 has joined #bitcoin-core-dev
 63 2020-10-05T06:27:55  *** go121212 has joined #bitcoin-core-dev
 64 2020-10-05T06:30:44  *** go11111111111 has quit IRC
 65 2020-10-05T06:35:47  *** mol has quit IRC
 66 2020-10-05T07:11:26  *** S3RK has joined #bitcoin-core-dev
 67 2020-10-05T07:24:24  *** S3RK has quit IRC
 68 2020-10-05T07:32:07  *** S3RK has joined #bitcoin-core-dev
 69 2020-10-05T07:33:08  *** jonatack has quit IRC
 70 2020-10-05T07:33:27  *** andreacab has joined #bitcoin-core-dev
 71 2020-10-05T07:46:48  *** bitcoin-git has joined #bitcoin-core-dev
 72 2020-10-05T07:46:49  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dde104963b3b...875e1ccc9fe0
 73 2020-10-05T07:46:50  <bitcoin-git> bitcoin/master 64bc5ef Oliver Gugger: test: Assert PSBT change type
 74 2020-10-05T07:46:51  <bitcoin-git> bitcoin/master a56e9f5 Oliver Gugger: test: Assert exclusive PSBT funding options
 75 2020-10-05T07:46:52  <bitcoin-git> bitcoin/master 875e1cc MarcoFalke: Merge #19947: Test: Cover "change_type" option of "walletcreatefundedpsbt"...
 76 2020-10-05T07:46:53  *** bitcoin-git has left #bitcoin-core-dev
 77 2020-10-05T07:47:08  *** bitcoin-git has joined #bitcoin-core-dev
 78 2020-10-05T07:47:08  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19947: Test: Cover "change_type" option of "walletcreatefundedpsbt" RPC (master...psbt-test) https://github.com/bitcoin/bitcoin/pull/19947
 79 2020-10-05T07:47:09  *** bitcoin-git has left #bitcoin-core-dev
 80 2020-10-05T07:54:44  *** ghost43 has quit IRC
 81 2020-10-05T07:55:40  *** ghost43 has joined #bitcoin-core-dev
 82 2020-10-05T07:58:22  *** kljasdfvv has joined #bitcoin-core-dev
 83 2020-10-05T07:58:49  *** andreacab has quit IRC
 84 2020-10-05T07:59:02  *** andreacab has joined #bitcoin-core-dev
 85 2020-10-05T07:59:56  *** mrostecki has joined #bitcoin-core-dev
 86 2020-10-05T08:26:27  *** mrostecki has quit IRC
 87 2020-10-05T08:28:55  *** mrostecki has joined #bitcoin-core-dev
 88 2020-10-05T08:35:52  *** belcher_ has joined #bitcoin-core-dev
 89 2020-10-05T08:38:52  *** belcher has quit IRC
 90 2020-10-05T08:40:42  *** mol has joined #bitcoin-core-dev
 91 2020-10-05T08:41:48  *** S3RK has quit IRC
 92 2020-10-05T08:42:42  *** jonatack has joined #bitcoin-core-dev
 93 2020-10-05T08:43:56  *** nico1 has quit IRC
 94 2020-10-05T08:44:01  *** S3RK has joined #bitcoin-core-dev
 95 2020-10-05T08:49:01  *** S3RK has quit IRC
 96 2020-10-05T08:54:30  *** belcher_ is now known as belcher
 97 2020-10-05T09:04:25  *** kexkey has quit IRC
 98 2020-10-05T09:08:52  *** andreacab has quit IRC
 99 2020-10-05T09:09:18  *** andreacab has joined #bitcoin-core-dev
100 2020-10-05T09:12:20  *** promag_ has joined #bitcoin-core-dev
101 2020-10-05T09:12:49  *** mol has quit IRC
102 2020-10-05T09:12:54  *** promag has quit IRC
103 2020-10-05T09:13:03  *** Klox04809 has joined #bitcoin-core-dev
104 2020-10-05T09:13:06  *** promag has joined #bitcoin-core-dev
105 2020-10-05T09:14:42  *** Klox0480 has quit IRC
106 2020-10-05T09:15:12  *** promag_ has quit IRC
107 2020-10-05T09:17:45  *** andreacab has quit IRC
108 2020-10-05T09:19:56  *** qapla_org has joined #bitcoin-core-dev
109 2020-10-05T09:24:17  *** andreacab has joined #bitcoin-core-dev
110 2020-10-05T09:24:39  *** S3RK has joined #bitcoin-core-dev
111 2020-10-05T09:26:27  *** promag has quit IRC
112 2020-10-05T09:27:00  *** promag has joined #bitcoin-core-dev
113 2020-10-05T09:30:32  *** S3RK has quit IRC
114 2020-10-05T09:38:18  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
115 2020-10-05T09:48:10  *** da39a3ee5e6b4b0d has quit IRC
116 2020-10-05T09:48:10  *** sr_gi has quit IRC
117 2020-10-05T09:48:45  *** sr_gi has joined #bitcoin-core-dev
118 2020-10-05T09:56:34  *** elichai2 has joined #bitcoin-core-dev
119 2020-10-05T09:57:37  *** S3RK has joined #bitcoin-core-dev
120 2020-10-05T10:09:25  *** S3RK has quit IRC
121 2020-10-05T10:09:34  *** S3RK has joined #bitcoin-core-dev
122 2020-10-05T10:10:03  *** vasild has quit IRC
123 2020-10-05T10:12:24  *** vasild has joined #bitcoin-core-dev
124 2020-10-05T10:15:08  *** AaronvanW has joined #bitcoin-core-dev
125 2020-10-05T10:17:20  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
126 2020-10-05T10:18:26  *** Erich29Shields has joined #bitcoin-core-dev
127 2020-10-05T10:23:45  *** jonatack has quit IRC
128 2020-10-05T10:29:18  *** andreacab has quit IRC
129 2020-10-05T10:31:31  *** andreacab has joined #bitcoin-core-dev
130 2020-10-05T10:35:47  *** andreacab has quit IRC
131 2020-10-05T10:37:15  *** da39a3ee5e6b4b0d has quit IRC
132 2020-10-05T10:50:56  *** davterra has quit IRC
133 2020-10-05T10:51:21  *** davterra has joined #bitcoin-core-dev
134 2020-10-05T10:54:49  *** andreacab has joined #bitcoin-core-dev
135 2020-10-05T11:15:38  *** Erich29Shields has quit IRC
136 2020-10-05T11:17:23  *** jonatack has joined #bitcoin-core-dev
137 2020-10-05T11:22:11  *** mrostecki_ has joined #bitcoin-core-dev
138 2020-10-05T11:22:12  *** jonatack has quit IRC
139 2020-10-05T11:23:43  *** mrostecki has quit IRC
140 2020-10-05T11:28:01  *** andreacab has quit IRC
141 2020-10-05T11:28:09  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
142 2020-10-05T11:28:10  *** andreacab has joined #bitcoin-core-dev
143 2020-10-05T11:41:24  *** S3RK has quit IRC
144 2020-10-05T11:41:59  *** S3RK has joined #bitcoin-core-dev
145 2020-10-05T11:48:35  *** S3RK has quit IRC
146 2020-10-05T11:50:22  *** andreacab has quit IRC
147 2020-10-05T11:50:50  *** andreacab has joined #bitcoin-core-dev
148 2020-10-05T11:55:38  *** andreacab has quit IRC
149 2020-10-05T12:00:02  *** qapla_org has quit IRC
150 2020-10-05T12:05:56  *** vadorovsky__ has joined #bitcoin-core-dev
151 2020-10-05T12:06:43  *** mrostecki_ has quit IRC
152 2020-10-05T12:09:43  *** justanotheruser has joined #bitcoin-core-dev
153 2020-10-05T12:20:47  *** justanotheruser has quit IRC
154 2020-10-05T12:22:06  *** luka has joined #bitcoin-core-dev
155 2020-10-05T12:22:12  *** luka is now known as Guest4175
156 2020-10-05T12:25:08  *** Guyver2 has joined #bitcoin-core-dev
157 2020-10-05T12:27:08  *** S3RK has joined #bitcoin-core-dev
158 2020-10-05T12:31:05  *** S3RK has quit IRC
159 2020-10-05T12:32:15  *** mol has joined #bitcoin-core-dev
160 2020-10-05T12:55:16  *** jonatack has joined #bitcoin-core-dev
161 2020-10-05T12:58:37  *** andreacab has joined #bitcoin-core-dev
162 2020-10-05T12:58:56  *** mol has quit IRC
163 2020-10-05T13:03:48  *** andreacab has quit IRC
164 2020-10-05T13:07:34  *** andreacab has joined #bitcoin-core-dev
165 2020-10-05T13:15:05  *** Eagle[TM] has quit IRC
166 2020-10-05T13:17:56  *** justanotheruser has joined #bitcoin-core-dev
167 2020-10-05T13:18:17  *** cato_ has left #bitcoin-core-dev
168 2020-10-05T13:33:04  <aj> sipa: is your txrequest corpus uploaded anywhere?
169 2020-10-05T13:38:47  *** andreacab has quit IRC
170 2020-10-05T13:39:39  *** ares_ has joined #bitcoin-core-dev
171 2020-10-05T13:43:10  *** mol has joined #bitcoin-core-dev
172 2020-10-05T13:44:16  *** belcher has quit IRC
173 2020-10-05T13:44:26  *** nullptr| has quit IRC
174 2020-10-05T13:45:50  *** nullptr| has joined #bitcoin-core-dev
175 2020-10-05T14:19:14  *** davterra has quit IRC
176 2020-10-05T14:22:02  *** kexkey has joined #bitcoin-core-dev
177 2020-10-05T14:33:15  *** kristapsk has joined #bitcoin-core-dev
178 2020-10-05T14:42:51  *** kristapsk has quit IRC
179 2020-10-05T14:49:25  *** balbirs has quit IRC
180 2020-10-05T14:51:50  <hebasto> doing final testing of #19954; please connect to my node at d6jwdcoo2l3gbjps6asgg4nhp2gn5oao3wj333o43ssqnjaliehytfad.onion:8333
181 2020-10-05T14:51:53  <gribble> https://github.com/bitcoin/bitcoin/issues/19954 | tor: complete the TORv3 implementation by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
182 2020-10-05T14:56:23  * hebasto +1 inbound connection. Thanks!
183 2020-10-05T14:58:14  *** kristapsk has joined #bitcoin-core-dev
184 2020-10-05T14:58:17  *** proofofkeags has quit IRC
185 2020-10-05T15:00:01  *** Guest4175 has quit IRC
186 2020-10-05T15:01:41  *** gloriazhao has joined #bitcoin-core-dev
187 2020-10-05T15:04:55  *** S3RK has joined #bitcoin-core-dev
188 2020-10-05T15:09:25  *** S3RK has quit IRC
189 2020-10-05T15:15:26  *** bitcoin-git has joined #bitcoin-core-dev
190 2020-10-05T15:15:26  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20083: p2p: Disconnect, not discourage, misbehaving NODE_BLOOM peers (master...2010-p2pBloomPeer) https://github.com/bitcoin/bitcoin/pull/20083
191 2020-10-05T15:15:28  *** bitcoin-git has left #bitcoin-core-dev
192 2020-10-05T15:15:55  *** davterra has joined #bitcoin-core-dev
193 2020-10-05T15:20:25  *** clintbellanger has joined #bitcoin-core-dev
194 2020-10-05T15:31:05  <jonatack> hebasto: connected
195 2020-10-05T15:31:38  <hebasto> jonatack: ty
196 2020-10-05T15:40:00  *** mol_ has joined #bitcoin-core-dev
197 2020-10-05T15:40:09  *** wraithm_ has quit IRC
198 2020-10-05T15:42:32  *** mol has quit IRC
199 2020-10-05T15:45:12  *** wraithm has joined #bitcoin-core-dev
200 2020-10-05T15:48:41  *** EagleTM has joined #bitcoin-core-dev
201 2020-10-05T16:14:02  *** da39a3ee5e6b4b0d has quit IRC
202 2020-10-05T16:14:24  *** bitcoin-git has joined #bitcoin-core-dev
203 2020-10-05T16:14:24  <bitcoin-git> [bitcoin] Rav3nPL opened pull request #20086: Update CONTRIBUTING.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20086
204 2020-10-05T16:14:25  *** bitcoin-git has left #bitcoin-core-dev
205 2020-10-05T16:21:39  *** Talkless has joined #bitcoin-core-dev
206 2020-10-05T16:26:45  <sipa> should we disable appveyor?
207 2020-10-05T16:26:56  <sipa> aj: no, i can
208 2020-10-05T16:33:26  *** balbirs has joined #bitcoin-core-dev
209 2020-10-05T16:51:49  <sipa> aj: http://bitcoin.sipa.be/txrequest.tgz
210 2020-10-05T17:18:20  *** promag_ has joined #bitcoin-core-dev
211 2020-10-05T17:19:19  *** proofofkeags has joined #bitcoin-core-dev
212 2020-10-05T17:21:38  <wumpus> well, if we can't fix it...
213 2020-10-05T17:24:52  <wumpus> I think disabling it temporarily makes sense
214 2020-10-05T17:25:48  *** promag has quit IRC
215 2020-10-05T17:26:00  *** promag has joined #bitcoin-core-dev
216 2020-10-05T17:28:03  *** vadorovsky__ has quit IRC
217 2020-10-05T17:32:57  *** andreacab has joined #bitcoin-core-dev
218 2020-10-05T17:33:09  *** bitcoin-git has joined #bitcoin-core-dev
219 2020-10-05T17:33:09  <bitcoin-git> [bitcoin] promag closed pull request #19476: rpc: Add mempoolchanges (master...2020-07-rpc-mempoolchanges) https://github.com/bitcoin/bitcoin/pull/19476
220 2020-10-05T17:33:10  *** bitcoin-git has left #bitcoin-core-dev
221 2020-10-05T17:37:24  *** promag has quit IRC
222 2020-10-05T17:38:18  *** promag has joined #bitcoin-core-dev
223 2020-10-05T17:45:22  *** andreacab has quit IRC
224 2020-10-05T17:45:48  *** andreacab has joined #bitcoin-core-dev
225 2020-10-05T17:47:31  *** andreaca_ has joined #bitcoin-core-dev
226 2020-10-05T17:49:55  <aj> sipa: re: #20005 would just adding an autoconf snippet and failing before even trying to build if the bug is present be simpler than trying to get a reliable workaround?
227 2020-10-05T17:49:57  <gribble> https://github.com/bitcoin/bitcoin/issues/20005 | memcmp with constants that contain zero bytes are broken in GCC · Issue #20005 · bitcoin/bitcoin · GitHub
228 2020-10-05T17:50:02  *** andreacab has quit IRC
229 2020-10-05T17:51:40  <sipa> aj: unfortunately i fear that that may mean that people either stop building their own bitcoind, or get accustomed to a --ignore-compiler-bugs flag
230 2020-10-05T17:51:50  <sipa> because a large number of current distributions ship a broken gcc
231 2020-10-05T17:52:00  *** andreaca_ has quit IRC
232 2020-10-05T17:52:28  *** andreacab has joined #bitcoin-core-dev
233 2020-10-05T17:53:21  *** proofofkeags_ has joined #bitcoin-core-dev
234 2020-10-05T17:54:22  <aj> sipa: debian stable's gcc is 8.3 which is too old i think?? have fedora/rhel/ubuntu not done emergency patches?
235 2020-10-05T17:54:45  <sipa> aj: there are _no_ GCC releases with the fix
236 2020-10-05T17:55:20  <aj> sipa: the bug's only in gcc 9 and 10, isn't it?
237 2020-10-05T17:55:24  <sipa> yes
238 2020-10-05T17:55:34  <sipa> but all most recent 9.x and 10.x are vulnerable
239 2020-10-05T17:56:12  *** proofofkeags has quit IRC
240 2020-10-05T17:56:21  *** andreaca_ has joined #bitcoin-core-dev
241 2020-10-05T17:57:18  *** andreacab has quit IRC
242 2020-10-05T18:00:02  *** clintbellanger has quit IRC
243 2020-10-05T18:01:56  <sipa> wumpus: i've disabled the appveyor webhook; it's useless currently
244 2020-10-05T18:03:12  *** andreaca_ has quit IRC
245 2020-10-05T18:03:38  *** andreacab has joined #bitcoin-core-dev
246 2020-10-05T18:04:19  <aj> https://bugs.launchpad.net/ubuntu/+source/gcc-9/+bug/1879481 is the tracking bug for updating ubuntu focal, i think. i'm not seeing a specific bug for the issue on launchpad; likely worth filing one
247 2020-10-05T18:05:02  *** andreaca_ has joined #bitcoin-core-dev
248 2020-10-05T18:05:25  *** bitcoin-git has joined #bitcoin-core-dev
249 2020-10-05T18:05:25  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #20067: refactor: remove use of boost::algorithm::replace_first (master...20201003-get-rid-of-boost-replace_first) https://github.com/bitcoin/bitcoin/pull/20067
250 2020-10-05T18:05:26  *** bitcoin-git has left #bitcoin-core-dev
251 2020-10-05T18:05:45  *** bitcoin-git has joined #bitcoin-core-dev
252 2020-10-05T18:05:45  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #20067: refactor: remove use of boost::algorithm::replace_first (master...20201003-get-rid-of-boost-replace_first) https://github.com/bitcoin/bitcoin/pull/20067
253 2020-10-05T18:05:46  *** bitcoin-git has left #bitcoin-core-dev
254 2020-10-05T18:06:25  <wumpus> sipa: thanks!
255 2020-10-05T18:06:38  <wumpus> sipa: that's great, didn't know it could be done without a change to the repository
256 2020-10-05T18:07:26  <sipa> wumpus: i hope it works
257 2020-10-05T18:07:37  <wumpus> I'm honestly not sure anymore whether we should do anything at all, in regard to the gcc bug
258 2020-10-05T18:07:47  *** andreacab has quit IRC
259 2020-10-05T18:08:16  <sipa> wumpus: agree... it's a lot less scary than we first thought, though the concern about introducing new something that is affected by it remains
260 2020-10-05T18:08:20  <wumpus> testing has shown it doesn't affect our consensus code, that was a potential reason to panic
261 2020-10-05T18:08:33  <sipa> it doesn't affect anything, actually
262 2020-10-05T18:08:39  <wumpus> right
263 2020-10-05T18:08:42  <sipa> (in the 0.20.1 codebase)
264 2020-10-05T18:09:30  <wumpus> we probably should keep paying attention, or even have an automated test for code that is affected, but it's not enough reason to refuse to build outright or such I mean
265 2020-10-05T18:09:49  <sipa> agree, i think refusing to build is too big a stick
266 2020-10-05T18:10:10  <wumpus> (I initially wanted that, but it seems to be much less bad than initially thought)
267 2020-10-05T18:10:27  <aj> (i dunno, if distros haven't patched already, someone needs to get a bigger stick...)
268 2020-10-05T18:10:45  <wumpus> they definitely won't patch because of anything we do
269 2020-10-05T18:12:39  <wumpus> I mwan, for example, last time I tried to get a miniupnp remote code exploit fixed in ubuntu it took a direct example of an exploit to get them to fix it quickly... "it doesn't build bitcoin anymore" is not likely to convince anyone
270 2020-10-05T18:12:58  *** andreaca_ has quit IRC
271 2020-10-05T18:13:24  *** andreacab has joined #bitcoin-core-dev
272 2020-10-05T18:14:03  *** andreaca_ has joined #bitcoin-core-dev
273 2020-10-05T18:14:27  <wumpus> I wish someone found an example of the bug actually causing an exploitable security somewhere (and published it ofc)
274 2020-10-05T18:14:50  *** promag_ has quit IRC
275 2020-10-05T18:14:56  <luke-jr> wumpus: it seems very unlikely
276 2020-10-05T18:15:17  <luke-jr> wumpus: roconnor rebuilt his entire system and nothing stood out like that iirc
277 2020-10-05T18:15:55  <wumpus> luke-jr: yes I think too that it's unlikely (but also unlikely roconner had every possible remote service installed :-) )
278 2020-10-05T18:16:03  <luke-jr> heh
279 2020-10-05T18:16:15  *** andreaca_ has quit IRC
280 2020-10-05T18:16:41  *** andreaca_ has joined #bitcoin-core-dev
281 2020-10-05T18:17:25  *** andreacab has quit IRC
282 2020-10-05T18:19:02  <aj> doesn't seem like anyone's filed a bug for rhel/fedora, debian or ubuntu
283 2020-10-05T18:20:33  <wumpus> that's very much worth doing if not
284 2020-10-05T18:20:48  <luke-jr> lol
285 2020-10-05T18:20:56  *** andreaca_ has quit IRC
286 2020-10-05T18:22:17  <luke-jr> I don't see one on Gentoo's either
287 2020-10-05T18:22:27  <luke-jr> could they be security-hidden?
288 2020-10-05T18:23:07  <aj> seems unlikely given the gcc bug's been public for months?
289 2020-10-05T18:23:48  <wumpus> it's almost like we're the only ones worrying about this, or yeah, that the bugs are hidden, but that would most probably mean someone did find a serious exploit making use of it
290 2020-10-05T18:24:08  *** andreacab has joined #bitcoin-core-dev
291 2020-10-05T18:24:32  <wumpus> it's sometimes hard to distinguish "no one cares" from "everyone is panicking in secret"
292 2020-10-05T18:25:45  <wumpus> ... though you'd kind of expect swifter action in that case
293 2020-10-05T18:26:41  <sipa> i don't have the impression anyone is panicking in secret
294 2020-10-05T18:27:01  * luke-jr opens https://bugs.gentoo.org/746749
295 2020-10-05T18:27:09  <sipa> or panicking at all... if people were, there would be distro packages with gcc patched
296 2020-10-05T18:27:23  <luke-jr> and a GCC 9 backport :P
297 2020-10-05T18:27:52  <wumpus> sipa: I agree
298 2020-10-05T18:28:09  *** andreacab has quit IRC
299 2020-10-05T18:28:14  <sipa> the fix is known, it's in the master branch, and it applies cleanly to GCC 9 and 10 releases, IIRC
300 2020-10-05T18:28:36  *** andreacab has joined #bitcoin-core-dev
301 2020-10-05T18:30:27  *** roconnor has joined #bitcoin-core-dev
302 2020-10-05T18:31:20  *** bitcoin-git has joined #bitcoin-core-dev
303 2020-10-05T18:31:20  <bitcoin-git> [bitcoin] laanwj closed pull request #20086: Fix MD linting in CONTRIBUTING.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20086
304 2020-10-05T18:31:29  *** bitcoin-git has left #bitcoin-core-dev
305 2020-10-05T18:31:42  <roconnor> Someone contacted me and is attempting to rebuild "all of" the packages in Nix with the gcc bug detection patch.
306 2020-10-05T18:32:09  <luke-jr> sipa: it doesn't even come close to cleanly applying to GCC 9 - I couldn't rebase it without doubt
307 2020-10-05T18:32:31  <sipa> luke-jr: oh, i'm misinformed then
308 2020-10-05T18:32:46  <sipa> roconnor: nice
309 2020-10-05T18:32:50  <luke-jr> sipa: my solution was to neuter the builtin memcmp entirely
310 2020-10-05T18:32:55  *** andreacab has quit IRC
311 2020-10-05T18:33:23  <wumpus> roconnor: now that's an interesting experiment
312 2020-10-05T18:37:39  *** andreacab has joined #bitcoin-core-dev
313 2020-10-05T18:40:36  *** andreacab has quit IRC
314 2020-10-05T18:41:02  *** andreacab has joined #bitcoin-core-dev
315 2020-10-05T18:45:35  *** S3RK has joined #bitcoin-core-dev
316 2020-10-05T18:45:51  *** andreacab has quit IRC
317 2020-10-05T18:46:50  *** andreacab has joined #bitcoin-core-dev
318 2020-10-05T18:49:59  *** S3RK has quit IRC
319 2020-10-05T18:50:21  *** andreacab has joined #bitcoin-core-dev
320 2020-10-05T18:54:44  *** promag_ has joined #bitcoin-core-dev
321 2020-10-05T18:54:48  *** andreacab has quit IRC
322 2020-10-05T18:57:56  *** Guest75545 has joined #bitcoin-core-dev
323 2020-10-05T18:59:07  *** promag_ has quit IRC
324 2020-10-05T19:04:56  *** kristapsk_ has joined #bitcoin-core-dev
325 2020-10-05T19:05:51  *** kristapsk has quit IRC
326 2020-10-05T19:07:04  *** bitcoin-git has joined #bitcoin-core-dev
327 2020-10-05T19:07:04  <bitcoin-git> [bitcoin] practicalswift opened pull request #20089: validation: Increase robustness when loading malformed mempool.dat files (LoadMempool) (master...load-mempool-robustness) https://github.com/bitcoin/bitcoin/pull/20089
328 2020-10-05T19:07:05  *** bitcoin-git has left #bitcoin-core-dev
329 2020-10-05T19:10:34  *** alko89 has quit IRC
330 2020-10-05T19:10:43  *** alko89 has joined #bitcoin-core-dev
331 2020-10-05T19:13:32  *** tyler has joined #bitcoin-core-dev
332 2020-10-05T19:14:29  *** varioust has joined #bitcoin-core-dev
333 2020-10-05T19:15:08  *** Eagle[TM] has joined #bitcoin-core-dev
334 2020-10-05T19:17:01  *** EagleTM has quit IRC
335 2020-10-05T19:18:14  *** Talkless has quit IRC
336 2020-10-05T19:23:54  *** pinheadmz has quit IRC
337 2020-10-05T19:24:11  *** pinheadm_ has joined #bitcoin-core-dev
338 2020-10-05T19:57:15  *** varioust_ has joined #bitcoin-core-dev
339 2020-10-05T19:58:35  *** varioust has quit IRC
340 2020-10-05T19:58:35  *** varioust_ is now known as varioust
341 2020-10-05T19:59:53  *** promag_ has joined #bitcoin-core-dev
342 2020-10-05T20:04:04  *** mrostecki has joined #bitcoin-core-dev
343 2020-10-05T20:04:11  *** pinheadm_ has quit IRC
344 2020-10-05T20:04:28  *** pinheadmz has joined #bitcoin-core-dev
345 2020-10-05T20:10:27  *** kristapsk_ has quit IRC
346 2020-10-05T20:10:29  *** kristapsk___ has joined #bitcoin-core-dev
347 2020-10-05T20:10:58  *** promag has quit IRC
348 2020-10-05T20:11:10  *** promag has joined #bitcoin-core-dev
349 2020-10-05T20:12:29  *** Guyver2 has quit IRC
350 2020-10-05T20:15:45  *** promag has quit IRC
351 2020-10-05T20:16:27  *** promag has joined #bitcoin-core-dev
352 2020-10-05T20:19:48  *** jkczyz_ has joined #bitcoin-core-dev
353 2020-10-05T20:20:28  *** drbrule_ has joined #bitcoin-core-dev
354 2020-10-05T20:21:12  *** real_or_- has joined #bitcoin-core-dev
355 2020-10-05T20:23:20  *** b10c_ has joined #bitcoin-core-dev
356 2020-10-05T20:25:52  *** real_or_random has quit IRC
357 2020-10-05T20:25:52  *** Evel-Knievel has quit IRC
358 2020-10-05T20:25:52  *** jkczyz has quit IRC
359 2020-10-05T20:25:52  *** moneyball has quit IRC
360 2020-10-05T20:25:52  *** drbrule has quit IRC
361 2020-10-05T20:25:53  *** b10c has quit IRC
362 2020-10-05T20:25:53  *** hebasto has quit IRC
363 2020-10-05T20:25:54  *** midnight has quit IRC
364 2020-10-05T20:25:54  *** nothingmuch has quit IRC
365 2020-10-05T20:25:55  *** _flow_ has quit IRC
366 2020-10-05T20:25:56  *** drbrule_ is now known as drbrule
367 2020-10-05T20:25:56  *** jkczyz_ is now known as jkczyz
368 2020-10-05T20:26:02  *** somethinglittle has joined #bitcoin-core-dev
369 2020-10-05T20:26:17  *** Evel-Knievel has joined #bitcoin-core-dev
370 2020-10-05T20:27:28  *** hebasto_ has joined #bitcoin-core-dev
371 2020-10-05T20:27:28  *** moneyball__ has joined #bitcoin-core-dev
372 2020-10-05T20:27:28  *** moneyball__ has quit IRC
373 2020-10-05T20:27:29  *** moneyball__ has joined #bitcoin-core-dev
374 2020-10-05T20:27:29  *** hebasto_ has quit IRC
375 2020-10-05T20:27:29  *** hebasto_ has joined #bitcoin-core-dev
376 2020-10-05T20:27:48  *** _flow_ has joined #bitcoin-core-dev
377 2020-10-05T20:28:06  *** midnight has joined #bitcoin-core-dev
378 2020-10-05T20:39:56  *** troygiorshev has quit IRC
379 2020-10-05T20:41:14  *** proofofkeags_ has quit IRC
380 2020-10-05T20:41:39  *** proofofkeags has joined #bitcoin-core-dev
381 2020-10-05T20:42:26  *** justanotheruser has quit IRC
382 2020-10-05T20:45:31  *** somethinglittle is now known as nothingmuch
383 2020-10-05T20:45:50  *** justanotheruser has joined #bitcoin-core-dev
384 2020-10-05T20:48:51  *** proofofkeags_ has joined #bitcoin-core-dev
385 2020-10-05T20:49:15  <aj> sipa: doesn't InsecureRandBits(n) give a value in [ 0, 1<<(n+1) ) ? or was i talking max, while you were talking average?
386 2020-10-05T20:50:30  <sipa> aj: no, in range [0...(1<<n)-1]
387 2020-10-05T20:51:14  *** andreacab has joined #bitcoin-core-dev
388 2020-10-05T20:51:32  *** proofofkeags has quit IRC
389 2020-10-05T20:52:52  *** bitcoin-git has joined #bitcoin-core-dev
390 2020-10-05T20:52:53  <bitcoin-git> [bitcoin] amitiuttarwar opened pull request #20090: [doc] Tiny followups to new getpeerinfo connection type field  (master...2020-09-getpeerinfo-conn-type-release-notes) https://github.com/bitcoin/bitcoin/pull/20090
391 2020-10-05T20:53:04  *** bitcoin-git has left #bitcoin-core-dev
392 2020-10-05T20:53:10  *** promag_ has quit IRC
393 2020-10-05T20:53:36  <aj> sipa: oh, i can't add up! neat!
394 2020-10-05T20:54:06  <sipa> (InsecureRandBits(n) >> n) should always be 0
395 2020-10-05T20:55:03  <sipa> aj: the random interface is modeled after python's fwiw, see https://docs.python.org/3/library/random.html#random.getrandbits e.g.
396 2020-10-05T20:56:19  *** andreacab has quit IRC
397 2020-10-05T20:56:23  *** promag_ has joined #bitcoin-core-dev
398 2020-10-05T20:56:45  *** andreacab has joined #bitcoin-core-dev
399 2020-10-05T20:58:43  *** justan0theruser has joined #bitcoin-core-dev
400 2020-10-05T20:59:25  <aj> sipa: my stumbling block was not realising 1<<n wasn't n for n in 0,1,2 i think
401 2020-10-05T20:59:45  <sipa> ah
402 2020-10-05T20:59:53  <sipa> exponents are hard
403 2020-10-05T21:00:01  *** Guest75545 has quit IRC
404 2020-10-05T21:00:28  *** justanotheruser has quit IRC
405 2020-10-05T21:00:39  *** promag_ has quit IRC
406 2020-10-05T21:02:18  *** promag_ has joined #bitcoin-core-dev
407 2020-10-05T21:02:18  *** andreacab has quit IRC
408 2020-10-05T21:02:49  *** proofofkeags__ has joined #bitcoin-core-dev
409 2020-10-05T21:02:51  *** andreacab has joined #bitcoin-core-dev
410 2020-10-05T21:05:15  *** proofofkeags_ has quit IRC
411 2020-10-05T21:08:59  *** andreacab has quit IRC
412 2020-10-05T21:09:55  *** varioust has quit IRC
413 2020-10-05T21:16:28  *** proofofkeags__ has quit IRC
414 2020-10-05T21:16:51  *** proofofkeags__ has joined #bitcoin-core-dev
415 2020-10-05T21:21:15  *** jesusabdullah has joined #bitcoin-core-dev
416 2020-10-05T21:27:35  *** tralfaz has joined #bitcoin-core-dev
417 2020-10-05T21:29:43  *** davterra has quit IRC
418 2020-10-05T21:30:39  *** promag_ has quit IRC
419 2020-10-05T21:35:30  <roconnor> sipa: I didn't get any memcmp warning when compiling 875e1ccc9fe01e026e564dfd39a64d9a4b332a89.
420 2020-10-05T21:35:45  *** andreacab has joined #bitcoin-core-dev
421 2020-10-05T21:36:27  <sipa> roconnor: awesome, thank you
422 2020-10-05T21:37:09  *** promag_ has joined #bitcoin-core-dev
423 2020-10-05T21:38:52  *** promag_ has quit IRC
424 2020-10-05T21:42:11  *** promag_ has joined #bitcoin-core-dev
425 2020-10-05T21:43:34  <sipa> aj: a much longer term solution to the "time going backwards" thing... we really shouldn't using a system clock for these things
426 2020-10-05T21:44:19  <sipa> all of the GetTime*() functions deal with the same clock currently, but there are two distinct use cases for them, and C++(11) conveniently has a clock for each
427 2020-10-05T21:46:15  <sipa> most clock uses (except those used in block or wallet transaction timestamps) should really be using std::chrono::steady_clock, which can't be converted to real-world clock values, but is sufficient for "X time in the future" decisions
428 2020-10-05T21:46:29  <sipa> and the other ones should be using std::chrono::system_clock
429 2020-10-05T21:47:07  *** andreacab has quit IRC
430 2020-10-05T21:49:39  *** promag_ has quit IRC
431 2020-10-05T21:50:44  *** Addie83Larson has joined #bitcoin-core-dev
432 2020-10-05T22:10:23  *** vasild has quit IRC
433 2020-10-05T22:11:03  *** GankMove has quit IRC
434 2020-10-05T22:11:08  <aj> sipa: yeah. i tried switching a bunch of net.h to time_point's once, but got stymied by it not working with atomic.
435 2020-10-05T22:12:15  *** vasild has joined #bitcoin-core-dev
436 2020-10-05T22:13:41  <sipa> oh it doesn't
437 2020-10-05T22:13:44  <sipa> that's annoying
438 2020-10-05T22:13:59  <aj> sipa: might be fixed with c++14 or 17, i don't remember the details
439 2020-10-05T22:14:57  <aj> sipa: it was something that needed a noexcept but didn't have one or something
440 2020-10-05T22:16:07  *** hugohn has quit IRC
441 2020-10-05T22:17:23  *** jamesob has quit IRC
442 2020-10-05T22:17:33  *** jamesob has joined #bitcoin-core-dev
443 2020-10-05T22:17:33  <aj> sipa: i believe my thought was that we could have a mockable_clock, and then have typechecking for which times were mockable and which ones weren't
444 2020-10-05T22:18:00  <sipa> aj: i think we should have no non-mockable times :)
445 2020-10-05T22:18:30  <aj> sipa: hmm, i think the select() delays are better off non-mockable
446 2020-10-05T22:19:17  *** hugohn has joined #bitcoin-core-dev
447 2020-10-05T22:19:28  <sipa> aj: hmm, right
448 2020-10-05T22:19:43  <sipa> those should be rare though,i think
449 2020-10-05T22:21:39  <aj> sipa: yeah, hopefully
450 2020-10-05T22:22:35  *** andreacab has joined #bitcoin-core-dev
451 2020-10-05T22:23:54  <sipa> i guess we'd want 3 clocks:
452 2020-10-05T22:24:11  <sipa> * nonmockable, a steady clock for select() & co
453 2020-10-05T22:24:30  <sipa> * adjusted, a system clock with network-data based corrections
454 2020-10-05T22:24:55  <sipa> * timings, a steady but mockable clock
455 2020-10-05T22:25:14  <sipa> do we need a system clock that's non-adjusted anywhere?
456 2020-10-05T22:27:31  *** andreacab has quit IRC
457 2020-10-05T22:27:38  *** mol_ has quit IRC
458 2020-10-05T22:28:10  <aj> when we have mocked time, the logs include the system time without adjusting it?
459 2020-10-05T22:29:00  <sipa> it logs both
460 2020-10-05T22:29:27  <sipa> [$real_time] (mocked: $mocked_time) ...
461 2020-10-05T22:29:29  <aj> right, non-adjusted system time and mocktime
462 2020-10-05T22:29:37  <aj> is adjusted system time okay there?
463 2020-10-05T22:30:31  <sipa> ah, i see
464 2020-10-05T22:30:59  <sipa> right, logs may wan5 to report real real non-adjusted system time... but those are also not things stored in variables or so
465 2020-10-05T22:31:09  <aj> yep
466 2020-10-05T22:31:12  *** promag has quit IRC
467 2020-10-05T22:31:28  *** promag has joined #bitcoin-core-dev
468 2020-10-05T22:33:12  <sipa> also creating an atomic_time_point should be easy
469 2020-10-05T22:33:30  <sipa> just store an atomic duration, and convert from_to time_point at store/load time
470 2020-10-05T22:37:11  *** mol has joined #bitcoin-core-dev
471 2020-10-05T22:37:50  <aj> yeah, looks like i tried pretty much that
472 2020-10-05T22:39:16  <aj> https://github.com/ajtowns/bitcoin/commits/201908-systime
473 2020-10-05T22:40:27  <sipa> aj: right
474 2020-10-05T22:40:45  <sipa> probably best to first clean up as much as we can with just durations first
475 2020-10-05T22:43:08  <aj> sipa: yep
476 2020-10-05T22:46:25  *** Addie83Larson has quit IRC
477 2020-10-05T22:47:20  *** S3RK has joined #bitcoin-core-dev
478 2020-10-05T22:52:20  *** S3RK has quit IRC
479 2020-10-05T23:05:33  *** mol_ has joined #bitcoin-core-dev
480 2020-10-05T23:08:43  *** mol has quit IRC