1 2020-10-07T00:00:01  *** yar1 has quit IRC
  2 2020-10-07T00:00:26  *** Dean_Guss has quit IRC
  3 2020-10-07T00:05:42  *** DeanGuss has joined #bitcoin-core-dev
  4 2020-10-07T00:12:51  *** TeaBear has quit IRC
  5 2020-10-07T00:17:18  *** justanotheruser has quit IRC
  6 2020-10-07T00:21:33  *** kpyke has joined #bitcoin-core-dev
  7 2020-10-07T00:21:55  *** AaronvanW has quit IRC
  8 2020-10-07T00:36:00  *** S3RK has joined #bitcoin-core-dev
  9 2020-10-07T00:37:43  *** DeanGuss has quit IRC
 10 2020-10-07T00:47:18  *** varioust has joined #bitcoin-core-dev
 11 2020-10-07T00:50:47  *** S3RK has quit IRC
 12 2020-10-07T00:52:47  *** justanotheruser has joined #bitcoin-core-dev
 13 2020-10-07T01:01:17  *** AaronvanW has joined #bitcoin-core-dev
 14 2020-10-07T01:06:10  *** AaronvanW has quit IRC
 15 2020-10-07T01:07:47  *** Mercury_Vapor has quit IRC
 16 2020-10-07T01:13:44  *** varioust has quit IRC
 17 2020-10-07T01:31:24  *** troygiorshev has joined #bitcoin-core-dev
 18 2020-10-07T01:45:28  *** AaronvanW has joined #bitcoin-core-dev
 19 2020-10-07T01:52:00  *** tralfaz has joined #bitcoin-core-dev
 20 2020-10-07T01:54:43  *** davterra has quit IRC
 21 2020-10-07T01:56:34  *** tralfaz is now known as davterra
 22 2020-10-07T02:18:53  *** AaronvanW has quit IRC
 23 2020-10-07T02:22:32  *** varioust has joined #bitcoin-core-dev
 24 2020-10-07T02:28:02  *** DeanGuss has joined #bitcoin-core-dev
 25 2020-10-07T02:52:25  *** varioust has quit IRC
 26 2020-10-07T02:59:07  *** bitcoin-git has joined #bitcoin-core-dev
 27 2020-10-07T02:59:09  <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/d8cd7b137fb0...db88db47278d
 28 2020-10-07T02:59:09  <bitcoin-git> bitcoin/master 8f1290c gzhao408: [rpc/node] check for high fee before ATMP in clients
 29 2020-10-07T02:59:10  <bitcoin-git> bitcoin/master 932564b gzhao408: scripted-diff: update max-fee-exceeded error message to include RPC
 30 2020-10-07T02:59:11  <bitcoin-git> bitcoin/master b048b27 John Newbery: [validation] Remove absurdfee from accepttomempool
 31 2020-10-07T02:59:13  *** bitcoin-git has left #bitcoin-core-dev
 32 2020-10-07T02:59:57  *** bitcoin-git has joined #bitcoin-core-dev
 33 2020-10-07T02:59:57  <bitcoin-git> [bitcoin] fanquake merged pull request #19339: validation: re-delegate absurd fee checking from mempool to clients (master...mempool-remove-absurdfee) https://github.com/bitcoin/bitcoin/pull/19339
 34 2020-10-07T02:59:59  *** bitcoin-git has left #bitcoin-core-dev
 35 2020-10-07T03:00:02  *** kpyke has quit IRC
 36 2020-10-07T03:44:50  *** S3RK has joined #bitcoin-core-dev
 37 2020-10-07T03:57:28  *** tralfaz has joined #bitcoin-core-dev
 38 2020-10-07T03:59:43  *** davterra has quit IRC
 39 2020-10-07T04:08:49  *** tralfaz is now known as davterra
 40 2020-10-07T04:16:17  *** AaronvanW has joined #bitcoin-core-dev
 41 2020-10-07T04:18:28  *** cltrbreak_MAD2 has joined #bitcoin-core-dev
 42 2020-10-07T04:21:33  *** ctrlbreak_MAD has quit IRC
 43 2020-10-07T04:28:00  *** Frost has joined #bitcoin-core-dev
 44 2020-10-07T04:49:06  *** AaronvanW has quit IRC
 45 2020-10-07T04:57:07  *** da39a3ee5e6b4b0d has quit IRC
 46 2020-10-07T04:58:49  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
 47 2020-10-07T05:17:32  *** Frost has quit IRC
 48 2020-10-07T05:33:54  *** alorente has joined #bitcoin-core-dev
 49 2020-10-07T05:36:19  *** S3RK has quit IRC
 50 2020-10-07T05:47:56  *** justanotheruser has quit IRC
 51 2020-10-07T06:00:01  *** alorente has quit IRC
 52 2020-10-07T06:10:53  *** S3RK has joined #bitcoin-core-dev
 53 2020-10-07T06:14:17  *** afk11 has quit IRC
 54 2020-10-07T06:14:17  *** sipa has quit IRC
 55 2020-10-07T06:14:17  *** braydonf has quit IRC
 56 2020-10-07T06:14:18  *** ghost43 has quit IRC
 57 2020-10-07T06:14:18  *** yanmaani has quit IRC
 58 2020-10-07T06:14:18  *** vasild has quit IRC
 59 2020-10-07T06:14:18  *** DeanGuss has quit IRC
 60 2020-10-07T06:14:18  *** ares_ has quit IRC
 61 2020-10-07T06:14:18  *** sdaftuar has quit IRC
 62 2020-10-07T06:14:18  *** morcos has quit IRC
 63 2020-10-07T06:14:18  *** k3tan has quit IRC
 64 2020-10-07T06:14:19  *** jb55 has quit IRC
 65 2020-10-07T06:14:38  *** vasild has joined #bitcoin-core-dev
 66 2020-10-07T06:14:39  *** DeanGuss has joined #bitcoin-core-dev
 67 2020-10-07T06:14:48  *** sdaftuar has joined #bitcoin-core-dev
 68 2020-10-07T06:14:49  *** jb55 has joined #bitcoin-core-dev
 69 2020-10-07T06:15:02  *** k3tan has joined #bitcoin-core-dev
 70 2020-10-07T06:15:03  *** braydonf has joined #bitcoin-core-dev
 71 2020-10-07T06:15:04  *** afk11 has joined #bitcoin-core-dev
 72 2020-10-07T06:15:34  *** morcos has joined #bitcoin-core-dev
 73 2020-10-07T06:17:18  *** yanmaani has joined #bitcoin-core-dev
 74 2020-10-07T06:18:35  *** ghost43 has joined #bitcoin-core-dev
 75 2020-10-07T06:19:29  *** sipa has joined #bitcoin-core-dev
 76 2020-10-07T06:19:32  *** ares_ has joined #bitcoin-core-dev
 77 2020-10-07T06:22:00  *** Andy2011Zoe has joined #bitcoin-core-dev
 78 2020-10-07T06:24:49  *** S3RK has quit IRC
 79 2020-10-07T06:26:46  *** EagleTM has joined #bitcoin-core-dev
 80 2020-10-07T06:33:33  *** S3RK has joined #bitcoin-core-dev
 81 2020-10-07T06:41:54  *** S3RK has quit IRC
 82 2020-10-07T06:45:52  *** AaronvanW has joined #bitcoin-core-dev
 83 2020-10-07T07:04:22  *** sdaftuar has quit IRC
 84 2020-10-07T07:04:42  *** sdaftuar has joined #bitcoin-core-dev
 85 2020-10-07T07:06:44  *** cornfeedhobo has quit IRC
 86 2020-10-07T07:13:03  *** spinza has quit IRC
 87 2020-10-07T07:14:27  *** Guyver2 has joined #bitcoin-core-dev
 88 2020-10-07T07:15:21  *** spinza has joined #bitcoin-core-dev
 89 2020-10-07T07:15:38  *** PaulTroo_ has joined #bitcoin-core-dev
 90 2020-10-07T07:18:16  *** AaronvanW has quit IRC
 91 2020-10-07T07:18:48  *** S3RK has joined #bitcoin-core-dev
 92 2020-10-07T07:19:53  *** mol_ has joined #bitcoin-core-dev
 93 2020-10-07T07:23:10  *** mol has quit IRC
 94 2020-10-07T07:27:14  *** PaulTroo_ has quit IRC
 95 2020-10-07T07:33:52  *** bitcoin-git has joined #bitcoin-core-dev
 96 2020-10-07T07:33:52  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/db88db47278d...283a73d7eaea
 97 2020-10-07T07:33:52  <bitcoin-git> bitcoin/master d103484 Hennadii Stepanov: util: Do not use gArgs global in ArgsManager member functions
 98 2020-10-07T07:33:53  <bitcoin-git> bitcoin/master 283a73d MarcoFalke: Merge #20092: util: Do not use gArgs global in ArgsManager member function...
 99 2020-10-07T07:33:54  *** bitcoin-git has left #bitcoin-core-dev
100 2020-10-07T07:34:11  *** bitcoin-git has joined #bitcoin-core-dev
101 2020-10-07T07:34:11  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20092: util: Do not use gArgs global in ArgsManager member functions (master...201006-gargs) https://github.com/bitcoin/bitcoin/pull/20092
102 2020-10-07T07:34:12  *** bitcoin-git has left #bitcoin-core-dev
103 2020-10-07T07:38:25  *** BGL has quit IRC
104 2020-10-07T07:41:40  *** promag has joined #bitcoin-core-dev
105 2020-10-07T07:42:08  <wumpus> aj: would it make sense to maintain that project board as part of the bitcoin/bitcoin repo? or do you prefer hosting it on your own repo
106 2020-10-07T07:42:58  <wumpus> (fwiw: I just closed the ancient "P2P refactor" project)
107 2020-10-07T07:43:23  *** promag has quit IRC
108 2020-10-07T07:45:03  *** afk11 has quit IRC
109 2020-10-07T07:45:39  *** promag has joined #bitcoin-core-dev
110 2020-10-07T07:46:15  <wumpus> great job in any case it's good to have an overview
111 2020-10-07T07:46:30  *** Guyver2 has quit IRC
112 2020-10-07T07:46:56  *** afk11 has joined #bitcoin-core-dev
113 2020-10-07T07:47:27  *** Guyver2 has joined #bitcoin-core-dev
114 2020-10-07T07:53:46  *** promag_ has joined #bitcoin-core-dev
115 2020-10-07T07:53:46  *** promag has quit IRC
116 2020-10-07T08:13:14  *** cornfeedhobo has joined #bitcoin-core-dev
117 2020-10-07T08:27:21  *** tralfaz has joined #bitcoin-core-dev
118 2020-10-07T08:27:35  *** davterra has quit IRC
119 2020-10-07T08:30:49  *** AaronvanW has joined #bitcoin-core-dev
120 2020-10-07T08:35:54  *** belcher_ has joined #bitcoin-core-dev
121 2020-10-07T08:37:53  *** AaronvanW has quit IRC
122 2020-10-07T08:38:11  *** AaronvanW has joined #bitcoin-core-dev
123 2020-10-07T08:39:38  *** belcher has quit IRC
124 2020-10-07T08:55:29  *** CubicEarth has quit IRC
125 2020-10-07T08:56:07  *** jonatack has quit IRC
126 2020-10-07T09:00:01  *** Andy2011Zoe has quit IRC
127 2020-10-07T09:04:39  *** kexkey has quit IRC
128 2020-10-07T09:09:21  *** CubicEarth has joined #bitcoin-core-dev
129 2020-10-07T09:13:16  *** afk11 has quit IRC
130 2020-10-07T09:13:43  *** afk11 has joined #bitcoin-core-dev
131 2020-10-07T09:22:14  *** ToBeFree has joined #bitcoin-core-dev
132 2020-10-07T09:22:36  *** ToBeFree is now known as Guest19382
133 2020-10-07T09:27:27  *** promag_ has quit IRC
134 2020-10-07T09:29:03  *** AaronvanW has quit IRC
135 2020-10-07T09:31:24  *** jonatack has joined #bitcoin-core-dev
136 2020-10-07T09:33:14  *** promag has joined #bitcoin-core-dev
137 2020-10-07T09:36:58  *** andreacab has joined #bitcoin-core-dev
138 2020-10-07T09:42:22  *** EagleTM has quit IRC
139 2020-10-07T09:42:25  *** CubicEarth has quit IRC
140 2020-10-07T09:44:34  *** promag has quit IRC
141 2020-10-07T09:45:18  *** da39a3ee5e6b4b0d has quit IRC
142 2020-10-07T09:45:57  *** andreacab has quit IRC
143 2020-10-07T09:46:23  *** andreacab has joined #bitcoin-core-dev
144 2020-10-07T09:46:23  *** sr_gi has quit IRC
145 2020-10-07T09:47:01  *** sr_gi has joined #bitcoin-core-dev
146 2020-10-07T09:50:27  *** andreacab has quit IRC
147 2020-10-07T09:52:02  *** BGL has joined #bitcoin-core-dev
148 2020-10-07T10:03:37  *** belcher_ has quit IRC
149 2020-10-07T10:06:07  *** belcher_ has joined #bitcoin-core-dev
150 2020-10-07T10:09:25  *** belcher_ is now known as belcher
151 2020-10-07T10:10:41  *** S3RK has quit IRC
152 2020-10-07T10:10:43  *** vasild has quit IRC
153 2020-10-07T10:10:57  *** S3RK has joined #bitcoin-core-dev
154 2020-10-07T10:12:06  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
155 2020-10-07T10:12:42  *** vasild has joined #bitcoin-core-dev
156 2020-10-07T10:14:01  *** S3RK has quit IRC
157 2020-10-07T10:18:35  *** Ardella31Botsfor has joined #bitcoin-core-dev
158 2020-10-07T10:22:33  *** CubicEarth has joined #bitcoin-core-dev
159 2020-10-07T10:23:27  *** Ardella31Botsfor has quit IRC
160 2020-10-07T10:26:06  *** andreacab has joined #bitcoin-core-dev
161 2020-10-07T10:28:19  *** promag has joined #bitcoin-core-dev
162 2020-10-07T10:36:49  *** da39a3ee5e6b4b0d has quit IRC
163 2020-10-07T10:37:56  *** S3RK has joined #bitcoin-core-dev
164 2020-10-07T10:41:25  *** andreacab has quit IRC
165 2020-10-07T10:43:18  *** promag has quit IRC
166 2020-10-07T10:45:16  *** promag has joined #bitcoin-core-dev
167 2020-10-07T10:48:07  *** andreacab has joined #bitcoin-core-dev
168 2020-10-07T10:49:37  *** promag has quit IRC
169 2020-10-07T10:51:06  *** AaronvanW has joined #bitcoin-core-dev
170 2020-10-07T10:52:02  *** rc_423 has quit IRC
171 2020-10-07T10:53:37  *** rc_423 has joined #bitcoin-core-dev
172 2020-10-07T11:15:03  *** andreacab has quit IRC
173 2020-10-07T11:15:33  *** andreacab has joined #bitcoin-core-dev
174 2020-10-07T11:19:11  *** shesek has joined #bitcoin-core-dev
175 2020-10-07T11:19:11  *** shesek has joined #bitcoin-core-dev
176 2020-10-07T11:19:56  *** andreacab has quit IRC
177 2020-10-07T11:21:50  *** AaronvanW has quit IRC
178 2020-10-07T11:29:36  *** S3RK has quit IRC
179 2020-10-07T11:30:23  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
180 2020-10-07T11:30:34  *** S3RK has joined #bitcoin-core-dev
181 2020-10-07T11:36:18  *** EagleTM has joined #bitcoin-core-dev
182 2020-10-07T11:40:47  *** S3RK has quit IRC
183 2020-10-07T11:44:58  *** jonatack has quit IRC
184 2020-10-07T11:53:10  *** andreacab has joined #bitcoin-core-dev
185 2020-10-07T11:58:30  *** tryphe_ is now known as tryphe
186 2020-10-07T12:00:02  *** Guest19382 has quit IRC
187 2020-10-07T12:07:15  *** andreacab has quit IRC
188 2020-10-07T12:11:21  *** Mercury_Vapor has joined #bitcoin-core-dev
189 2020-10-07T12:20:17  *** ferringb has joined #bitcoin-core-dev
190 2020-10-07T12:21:39  *** bitcoin-git has joined #bitcoin-core-dev
191 2020-10-07T12:21:39  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20097: fuzz: Version handshake (master...2010-fuzzHandshake) https://github.com/bitcoin/bitcoin/pull/20097
192 2020-10-07T12:21:39  *** bitcoin-git has left #bitcoin-core-dev
193 2020-10-07T12:33:54  *** crtn32002[m] has quit IRC
194 2020-10-07T12:34:00  *** icota[m]1 has quit IRC
195 2020-10-07T12:34:06  *** tianshi[m] has quit IRC
196 2020-10-07T12:34:14  *** RaphalBentgeac[m has quit IRC
197 2020-10-07T12:34:16  *** kyoo[m] has quit IRC
198 2020-10-07T12:34:17  *** Pasta[m] has quit IRC
199 2020-10-07T12:34:17  *** snowkeld[m] has quit IRC
200 2020-10-07T12:34:17  *** sethrogers23[m] has quit IRC
201 2020-10-07T12:37:49  *** Guyver2 has quit IRC
202 2020-10-07T12:41:29  *** tianshi[m] has joined #bitcoin-core-dev
203 2020-10-07T12:42:18  *** EagleTM has quit IRC
204 2020-10-07T12:51:11  *** andreacab has joined #bitcoin-core-dev
205 2020-10-07T12:55:05  <vasild> hebasto: I dont think there would be any benefit of sending the sendaddrv2 message before verack (right now in #19954 we send it after verack)
206 2020-10-07T12:55:08  <gribble> https://github.com/bitcoin/bitcoin/issues/19954 | tor: complete the TORv3 implementation by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
207 2020-10-07T12:56:29  <vasild> there would be benefit if we send it before the version message (:-O) because then in the version message we could encode the addrMe and addrYou in the new format thus they can be e.g. torv3 addresses
208 2020-10-07T12:59:56  *** S3RK has joined #bitcoin-core-dev
209 2020-10-07T13:00:40  <hebasto> am I wrong considering the window between version and verack as the main venue for adding new feature negotiation now / in the future?
210 2020-10-07T13:00:52  *** icota[m] has joined #bitcoin-core-dev
211 2020-10-07T13:00:53  *** rcrtn32002[m] has joined #bitcoin-core-dev
212 2020-10-07T13:00:53  *** TheFuzzStone[m] has joined #bitcoin-core-dev
213 2020-10-07T13:00:53  *** sethrogers23[m] has joined #bitcoin-core-dev
214 2020-10-07T13:00:53  *** kyoo[m] has joined #bitcoin-core-dev
215 2020-10-07T13:00:53  *** snowkeld[m] has joined #bitcoin-core-dev
216 2020-10-07T13:01:00  *** RaphalBentgeac[m has joined #bitcoin-core-dev
217 2020-10-07T13:01:00  *** Pasta[m] has joined #bitcoin-core-dev
218 2020-10-07T13:01:14  <vasild> Also, if we push now a new message before verack, even though #19723 is merged, about 70% of the peers will misbehave us because they dont run the latest version
219 2020-10-07T13:01:16  <gribble> https://github.com/bitcoin/bitcoin/issues/19723 | Ignore unknown messages before VERACK by sdaftuar · Pull Request #19723 · bitcoin/bitcoin · GitHub
220 2020-10-07T13:01:28  <hebasto> correct
221 2020-10-07T13:01:51  <vasild> I think "now" is too early :)
222 2020-10-07T13:03:00  <vasild> but for sendaddrv2 in particular it does not make a difference whether it is before or after verack
223 2020-10-07T13:03:52  *** tryphe_ has joined #bitcoin-core-dev
224 2020-10-07T13:04:00  *** sethrogers23[m] has quit IRC
225 2020-10-07T13:04:00  *** TheFuzzStone[m] has quit IRC
226 2020-10-07T13:04:00  *** da39a3ee5e6b4b0d has quit IRC
227 2020-10-07T13:04:00  *** gribble has quit IRC
228 2020-10-07T13:04:00  *** tryphe has quit IRC
229 2020-10-07T13:04:00  *** alko89 has quit IRC
230 2020-10-07T13:04:00  *** dergoegge has quit IRC
231 2020-10-07T13:04:00  *** hsmiths has quit IRC
232 2020-10-07T13:04:00  *** mariorz has quit IRC
233 2020-10-07T13:04:00  *** noganoo has quit IRC
234 2020-10-07T13:04:00  *** kallewoof has quit IRC
235 2020-10-07T13:04:14  *** tryphe_ is now known as tryphe
236 2020-10-07T13:04:16  *** alko89 has joined #bitcoin-core-dev
237 2020-10-07T13:04:58  *** S3RK has quit IRC
238 2020-10-07T13:05:25  *** sethrogers23[m] has joined #bitcoin-core-dev
239 2020-10-07T13:06:10  *** bsm117532 has quit IRC
240 2020-10-07T13:06:18  *** TheFuzzStone[m] has joined #bitcoin-core-dev
241 2020-10-07T13:08:52  *** bsm117532 has joined #bitcoin-core-dev
242 2020-10-07T13:09:22  *** dergoegge has joined #bitcoin-core-dev
243 2020-10-07T13:09:23  *** hsmiths has joined #bitcoin-core-dev
244 2020-10-07T13:09:23  *** mariorz has joined #bitcoin-core-dev
245 2020-10-07T13:09:23  *** noganoo has joined #bitcoin-core-dev
246 2020-10-07T13:09:23  *** kallewoof has joined #bitcoin-core-dev
247 2020-10-07T13:10:11  *** gribble has joined #bitcoin-core-dev
248 2020-10-07T13:13:15  *** varioust has joined #bitcoin-core-dev
249 2020-10-07T13:18:53  *** AaronvanW has joined #bitcoin-core-dev
250 2020-10-07T13:32:13  *** filchef has joined #bitcoin-core-dev
251 2020-10-07T13:33:43  *** tralfaz is now known as davterra
252 2020-10-07T13:36:14  *** andreacab has quit IRC
253 2020-10-07T13:37:04  *** andreacab has joined #bitcoin-core-dev
254 2020-10-07T13:38:53  *** jonatack has joined #bitcoin-core-dev
255 2020-10-07T13:45:25  *** andreacab has quit IRC
256 2020-10-07T13:52:20  *** AaronvanW has quit IRC
257 2020-10-07T13:52:35  *** worc3131 has quit IRC
258 2020-10-07T13:53:28  *** ferringb has quit IRC
259 2020-10-07T13:53:52  *** worc3131 has joined #bitcoin-core-dev
260 2020-10-07T14:04:16  *** shesek has quit IRC
261 2020-10-07T14:11:16  <hebasto> debian has gcc 10.2 now; is it patched already?
262 2020-10-07T14:14:53  *** icota[m] has quit IRC
263 2020-10-07T14:19:31  <luke-jr> "Correct handling of constant representations containing embedded nuls."
264 2020-10-07T14:19:35  <luke-jr> check changelog for that
265 2020-10-07T14:20:59  <luke-jr> hmm, changelog looks useless
266 2020-10-07T14:22:20  <luke-jr> hebasto: no, it looks like it's not fixed in 10.2.0
267 2020-10-07T14:23:02  <luke-jr> if inline_expand_builtin_.*cmp finds inline_expand_builtin_string_cmp, it's broken; if inline_expand_builtin_bytecmp, it's fixed
268 2020-10-07T14:23:09  <luke-jr> (unless Debian patched it some other way)
269 2020-10-07T14:26:41  <hebasto> luke-jr: thanks
270 2020-10-07T14:28:24  *** Guyver2 has joined #bitcoin-core-dev
271 2020-10-07T14:32:12  *** AaronvanW has joined #bitcoin-core-dev
272 2020-10-07T14:32:17  *** justanotheruser has joined #bitcoin-core-dev
273 2020-10-07T14:36:03  *** jfredett has joined #bitcoin-core-dev
274 2020-10-07T14:47:44  *** EagleTM has joined #bitcoin-core-dev
275 2020-10-07T14:53:27  *** andreacab has joined #bitcoin-core-dev
276 2020-10-07T15:00:01  *** jfredett has quit IRC
277 2020-10-07T15:00:40  *** andreacab has quit IRC
278 2020-10-07T15:01:08  *** andreacab has joined #bitcoin-core-dev
279 2020-10-07T15:08:03  *** andreacab has quit IRC
280 2020-10-07T15:12:36  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
281 2020-10-07T15:20:17  *** hggdh1 has joined #bitcoin-core-dev
282 2020-10-07T15:36:03  *** andreacab has joined #bitcoin-core-dev
283 2020-10-07T15:43:13  *** andreacab has quit IRC
284 2020-10-07T15:44:33  *** Talkless has joined #bitcoin-core-dev
285 2020-10-07T15:58:19  *** AaronvanW has quit IRC
286 2020-10-07T15:59:17  *** da39a3ee5e6b4b0d has quit IRC
287 2020-10-07T16:09:52  *** DeanGuss has quit IRC
288 2020-10-07T16:10:14  *** DeanGuss has joined #bitcoin-core-dev
289 2020-10-07T16:31:11  *** filchef has quit IRC
290 2020-10-07T16:31:18  *** AaronvanW has joined #bitcoin-core-dev
291 2020-10-07T16:35:45  *** AaronvanW has quit IRC
292 2020-10-07T16:43:04  <achow101> ryanofsky: would you like to have a dicussion about wallet.dat vs wallet.sqlite?
293 2020-10-07T16:45:47  <luke-jr> IMO the latter is better, since users shouldn't be messing with wallet internal files, and backupwallet lets the user specify any extension anyway
294 2020-10-07T16:46:42  <achow101> luke-jr: but there's a lot of tooling and documentation that refer to the wallet.dat file
295 2020-10-07T16:47:10  <luke-jr> achow101: and users can still call their backups wallet.dat
296 2020-10-07T16:47:15  <achow101> also, I'm concerned that a downgrade would result in a new wallet.dat being created which would not be good
297 2020-10-07T16:47:21  <achow101> I should probably test that..
298 2020-10-07T16:47:32  <luke-jr> hmm
299 2020-10-07T16:47:48  <achow101> luke-jr: right, but if they have a script backing up "wallet.dat", then it wouldn't work anymore
300 2020-10-07T16:48:32  <luke-jr> achow101: yes it would
301 2020-10-07T16:48:45  <luke-jr> you could *never* copy the original wallet.dat directly
302 2020-10-07T16:48:49  <luke-jr> only via backupwallet RPC
303 2020-10-07T16:48:54  <luke-jr> which lets them specify any filename
304 2020-10-07T16:49:02  <achow101> ???
305 2020-10-07T16:49:09  <achow101> you just go into the datadir and copy the file
306 2020-10-07T16:49:23  <luke-jr> no, that's not a supported method to backup and can result in corrupt backups
307 2020-10-07T16:49:32  <achow101> sure, but that doesn't mean people don't do it
308 2020-10-07T16:49:39  <luke-jr> sounds like a reason to break it
309 2020-10-07T16:50:34  <luke-jr> better to get an error on upgrade, than find out later your backups were corrupt
310 2020-10-07T16:50:43  <luke-jr> otoh, sqlite might not have the same corruption issue.. so..
311 2020-10-07T16:50:51  <achow101> likewise there may be a restore script that operates on wallet.dat files
312 2020-10-07T16:51:34  <achow101> also, backupwallet allowing you to specify an extension may interact poorly with this
313 2020-10-07T16:52:23  <luke-jr> true, we don't have a sane recover-from-backup
314 2020-10-07T16:52:48  <achow101> actually it probably doesn't since we do look for the file magic to deterine type, not the filename
315 2020-10-07T16:53:55  <sipa> luke-jr: backing uo wallet.dat by copying after a clean shutdown is soemthing i'd consider supported
316 2020-10-07T16:54:18  *** pergaminho has joined #bitcoin-core-dev
317 2020-10-07T16:55:07  *** lightlike has joined #bitcoin-core-dev
318 2020-10-07T16:57:19  *** andreacab has joined #bitcoin-core-dev
319 2020-10-07T17:00:31  <achow101> it's also a lot more common for people to suggest copying the wallet.dat file for backups rather than using the backupwallet rpc
320 2020-10-07T17:00:55  <achow101> it's probably easier for people to understand file copying than it is for them to understand rpcs
321 2020-10-07T17:00:56  *** dhruvm has joined #bitcoin-core-dev
322 2020-10-07T17:01:52  *** andreacab has quit IRC
323 2020-10-07T17:06:54  *** AaronvanW has joined #bitcoin-core-dev
324 2020-10-07T17:10:27  <phantomcircuit> luke-jr, unfortunately lots of people just copy the wallet.dat directly cause terrible tutorials
325 2020-10-07T17:17:44  *** ares_ has quit IRC
326 2020-10-07T17:17:53  *** ares_ has joined #bitcoin-core-dev
327 2020-10-07T17:18:58  <luke-jr> again, those are reasons to break such bad scripts/advice ;)
328 2020-10-07T17:19:31  <luke-jr> backward compatibility, and guides to restoring wallets, are the reasons I see to leave .dat
329 2020-10-07T17:20:52  *** ares_ has quit IRC
330 2020-10-07T17:22:58  *** ares_ has joined #bitcoin-core-dev
331 2020-10-07T17:31:56  *** Klox04809 has quit IRC
332 2020-10-07T17:32:39  *** Klox04809 has joined #bitcoin-core-dev
333 2020-10-07T17:39:05  *** Klox04809 has quit IRC
334 2020-10-07T17:40:13  *** AaronvanW has quit IRC
335 2020-10-07T17:43:19  *** Klox04809 has joined #bitcoin-core-dev
336 2020-10-07T17:45:36  *** promag has joined #bitcoin-core-dev
337 2020-10-07T17:48:07  *** worc3131 has quit IRC
338 2020-10-07T17:51:37  *** AaronvanW has joined #bitcoin-core-dev
339 2020-10-07T17:54:14  *** andreacab has joined #bitcoin-core-dev
340 2020-10-07T17:58:58  *** worc3131 has joined #bitcoin-core-dev
341 2020-10-07T17:59:23  *** andreacab has quit IRC
342 2020-10-07T18:00:01  *** hggdh1 has quit IRC
343 2020-10-07T18:12:18  *** lightlike has quit IRC
344 2020-10-07T18:13:47  *** worc3131 has quit IRC
345 2020-10-07T18:14:53  *** worc3131 has joined #bitcoin-core-dev
346 2020-10-07T18:15:37  *** promag has quit IRC
347 2020-10-07T18:15:47  *** S3RK has joined #bitcoin-core-dev
348 2020-10-07T18:20:21  *** KuluBot has joined #bitcoin-core-dev
349 2020-10-07T18:21:40  *** S3RK has quit IRC
350 2020-10-07T18:58:33  *** Talkless has quit IRC
351 2020-10-07T18:59:25  *** varioust has quit IRC
352 2020-10-07T18:59:46  *** pinheadmz has quit IRC
353 2020-10-07T19:19:03  *** pinheadmz has joined #bitcoin-core-dev
354 2020-10-07T19:27:01  <achow101> it seems like at least 0.19 and 0.20 expect a wallet.dat file in an existing dir for a wallet, so renaming to wallet.sqlite wouldn't silently fail on a downgrade
355 2020-10-07T19:33:29  *** mol_ has quit IRC
356 2020-10-07T19:48:11  <sipa> achow101: what happens if you have an sqlite wallet.dat and run an old version? will it try to do salvage/recover somehow?
357 2020-10-07T19:48:15  <sipa> or suggest to
358 2020-10-07T19:48:28  <achow101> sipa: no, it errors saying it isn' a bdb file
359 2020-10-07T19:48:40  <achow101> it checks the file magic before attempting to do anything to it
360 2020-10-07T19:48:45  <sipa> ok
361 2020-10-07T19:55:33  *** andreacab has joined #bitcoin-core-dev
362 2020-10-07T19:59:47  *** andreacab has quit IRC
363 2020-10-07T20:00:54  *** davterra has quit IRC
364 2020-10-07T20:01:24  *** davterra has joined #bitcoin-core-dev
365 2020-10-07T20:12:08  <achow101> hmm, actually it seems like we do actually attempt to salvage them, but bdb should be doing nothing because its the wrong magic
366 2020-10-07T20:12:09  *** sr_gi has quit IRC
367 2020-10-07T20:12:41  *** sr_gi has joined #bitcoin-core-dev
368 2020-10-07T20:18:41  *** Guyver2 has quit IRC
369 2020-10-07T20:22:27  <achow101> mmm, but wait, there's more, if the wallet is specified as a config option, 0.20 will make the wallet.dat file if it doesn't exist
370 2020-10-07T20:23:31  *** k3tan has quit IRC
371 2020-10-07T20:24:10  *** k3tan has joined #bitcoin-core-dev
372 2020-10-07T20:28:24  *** brianhoffman_ has joined #bitcoin-core-dev
373 2020-10-07T20:30:57  *** pinheadm_ has joined #bitcoin-core-dev
374 2020-10-07T20:31:02  *** brianhoffman has quit IRC
375 2020-10-07T20:31:20  *** brianhoffman_ is now known as brianhoffman
376 2020-10-07T20:31:31  *** TallTim has quit IRC
377 2020-10-07T20:31:46  *** pinheadmz has quit IRC
378 2020-10-07T20:31:52  *** andreacab has joined #bitcoin-core-dev
379 2020-10-07T20:32:02  *** andreacab has quit IRC
380 2020-10-07T20:32:37  *** andreacab has joined #bitcoin-core-dev
381 2020-10-07T20:33:25  *** a5m0 has quit IRC
382 2020-10-07T20:34:43  *** a5m0 has joined #bitcoin-core-dev
383 2020-10-07T20:35:57  *** mol has joined #bitcoin-core-dev
384 2020-10-07T20:36:47  *** andreacab has quit IRC
385 2020-10-07T20:44:31  *** andreacab has joined #bitcoin-core-dev
386 2020-10-07T20:48:55  *** TallTim has joined #bitcoin-core-dev
387 2020-10-07T20:49:07  *** andreacab has quit IRC
388 2020-10-07T21:00:02  *** KuluBot has quit IRC
389 2020-10-07T21:06:36  *** promag has joined #bitcoin-core-dev
390 2020-10-07T21:11:10  *** promag has quit IRC
391 2020-10-07T21:14:04  *** jb55 has quit IRC
392 2020-10-07T21:14:30  *** jb55 has joined #bitcoin-core-dev
393 2020-10-07T21:15:01  *** cornfeedhobo has quit IRC
394 2020-10-07T21:18:00  *** pergaminho has quit IRC
395 2020-10-07T21:20:54  *** kristapsk has joined #bitcoin-core-dev
396 2020-10-07T21:21:28  *** Barras2 has joined #bitcoin-core-dev
397 2020-10-07T21:23:33  *** cornfeedhobo has joined #bitcoin-core-dev
398 2020-10-07T21:24:25  *** andreacab has joined #bitcoin-core-dev
399 2020-10-07T21:29:56  *** andreacab has quit IRC
400 2020-10-07T21:30:02  *** andreacab has joined #bitcoin-core-dev
401 2020-10-07T21:32:56  *** andreacab has quit IRC
402 2020-10-07T21:33:57  *** andreacab has joined #bitcoin-core-dev
403 2020-10-07T21:38:53  *** andreacab has quit IRC
404 2020-10-07T21:42:47  *** worc3131 has quit IRC
405 2020-10-07T21:43:36  *** worc3131 has joined #bitcoin-core-dev
406 2020-10-07T22:04:02  *** jrawsthorne has quit IRC
407 2020-10-07T22:04:13  *** jrawsthorne has joined #bitcoin-core-dev
408 2020-10-07T22:06:25  *** ariard has quit IRC
409 2020-10-07T22:07:17  *** ariard has joined #bitcoin-core-dev
410 2020-10-07T22:08:50  <sanket1729> How do I get my tests written in script_tests.cpp into script_test.json.gen?
411 2020-10-07T22:09:29  <sanket1729> script_test.json looks auto-generated.
412 2020-10-07T22:10:13  <sipa> // Uncomment if you want to output updated JSON tests.
413 2020-10-07T22:10:18  <sipa> // #define UPDATE_JSON_TESTS
414 2020-10-07T22:10:43  *** vasild has quit IRC
415 2020-10-07T22:11:08  <sanket1729> Thanks.
416 2020-10-07T22:12:17  *** andreacab has joined #bitcoin-core-dev
417 2020-10-07T22:12:17  *** vasild has joined #bitcoin-core-dev
418 2020-10-07T22:17:09  *** andreacab has quit IRC
419 2020-10-07T22:19:23  *** S3RK has joined #bitcoin-core-dev
420 2020-10-07T22:20:24  *** go121212 has joined #bitcoin-core-dev
421 2020-10-07T22:23:08  *** go11111111111 has quit IRC
422 2020-10-07T22:23:49  *** S3RK has quit IRC
423 2020-10-07T22:57:56  <gwillen> I am concerned that #20051 is a sign of things to come, I think the "no loaded wallet" error message needs to clearly spell out the fact that default wallet creation was deprecated and you should call createwallet
424 2020-10-07T22:57:57  <gribble> https://github.com/bitcoin/bitcoin/issues/20051 | wallet method is disabled because no wallet is loaded · Issue #20051 · bitcoin/bitcoin · GitHub
425 2020-10-07T22:58:22  <gwillen> (by 'things to come' I just mean 'once this gets released, a ton of people are going to be confused by the breakage)
426 2020-10-07T22:58:42  <achow101> The error message could be written better
427 2020-10-07T22:59:08  <gwillen> I don't know how long RPC error messages are allowed to get, in terms of explanations or pointers to documentation
428 2020-10-07T23:01:50  <sipa> at least this long: "Using bumpfee with wallets that have private keys disabled is deprecated. Use psbtbumpfee instead or restart bitcoind with -deprecatedrpc=bumpfee. This functionality will be removed in 0.22"
429 2020-10-07T23:03:20  <gwillen> this is possibly too long: "Wallet RPCs are disabled because no wallet is loaded. (NOTE: Bitcoin Core no longer creates a default wallet automatically. Load a wallet using `loadwallet`, or by running bitcoind with `-wallet`; or create a wallet with `createwallet`.)"
430 2020-10-07T23:03:57  <gwillen> but that would spell out the general options. (Alternatively, replace the last bit with a link to documentation, if there's a stable link that would work.)
431 2020-10-07T23:04:41  <gwillen> alternatively, is there any precedent for having "help foo" entries where foo is not an RPC? If so, we could refer people to "help default_wallet_deprecation" or so.
432 2020-10-07T23:07:18  *** shesek has joined #bitcoin-core-dev
433 2020-10-07T23:09:12  <achow101> I think it's fine to just say what people can do
434 2020-10-07T23:09:21  <achow101> Maybe link to release notes if necessary
435 2020-10-07T23:13:50  *** pinheadm_ has quit IRC
436 2020-10-07T23:15:15  *** pinheadmz has joined #bitcoin-core-dev
437 2020-10-07T23:23:23  *** ares_ has quit IRC
438 2020-10-07T23:25:29  *** ares_ has joined #bitcoin-core-dev
439 2020-10-07T23:43:55  *** pinheadmz has quit IRC
440 2020-10-07T23:44:47  *** pinheadmz has joined #bitcoin-core-dev
441 2020-10-07T23:48:54  *** pinheadmz has quit IRC
442 2020-10-07T23:50:23  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
443 2020-10-07T23:55:56  *** pinheadmz has joined #bitcoin-core-dev
444 2020-10-07T23:57:39  *** pinheadmz has quit IRC