1 2020-10-08T00:00:25  *** DeanGuss has quit IRC
  2 2020-10-08T00:02:02  *** kristapsk has quit IRC
  3 2020-10-08T00:02:35  *** Barras2 has quit IRC
  4 2020-10-08T00:02:49  *** kristapsk has joined #bitcoin-core-dev
  5 2020-10-08T00:05:50  *** DeanGuss has joined #bitcoin-core-dev
  6 2020-10-08T00:06:11  *** pinheadmz has joined #bitcoin-core-dev
  7 2020-10-08T00:14:38  *** pinheadmz has quit IRC
  8 2020-10-08T00:21:16  *** lugosi1 has joined #bitcoin-core-dev
  9 2020-10-08T00:29:20  *** pinheadmz has joined #bitcoin-core-dev
 10 2020-10-08T00:30:11  *** bitcoin-git has joined #bitcoin-core-dev
 11 2020-10-08T00:30:11  <bitcoin-git> [bitcoin] sanket1729 opened pull request #20100: split policy/error consensus codes for CLEANSTACK, MINAMALIF (master...minimal_if) https://github.com/bitcoin/bitcoin/pull/20100
 12 2020-10-08T00:30:12  *** bitcoin-git has left #bitcoin-core-dev
 13 2020-10-08T00:48:15  *** davec has quit IRC
 14 2020-10-08T00:48:37  *** S3RK has joined #bitcoin-core-dev
 15 2020-10-08T00:53:44  *** davec has joined #bitcoin-core-dev
 16 2020-10-08T01:00:49  *** AaronvanW has quit IRC
 17 2020-10-08T01:04:33  *** S3RK has quit IRC
 18 2020-10-08T01:05:07  *** pinheadmz has quit IRC
 19 2020-10-08T01:17:28  *** tralfaz has joined #bitcoin-core-dev
 20 2020-10-08T01:20:23  *** davterra has quit IRC
 21 2020-10-08T01:20:40  *** tralfaz is now known as davterra
 22 2020-10-08T01:21:56  *** mol_ has joined #bitcoin-core-dev
 23 2020-10-08T01:25:25  *** mol has quit IRC
 24 2020-10-08T01:27:43  *** Eagle[TM] has joined #bitcoin-core-dev
 25 2020-10-08T01:28:49  *** EagleTM has quit IRC
 26 2020-10-08T01:35:53  *** AaronvanW has joined #bitcoin-core-dev
 27 2020-10-08T01:38:24  *** dr-orlovsky has quit IRC
 28 2020-10-08T01:39:12  *** bitcoin-git has joined #bitcoin-core-dev
 29 2020-10-08T01:39:12  <bitcoin-git> [bitcoin] achow101 opened pull request #20101: rpc: change no wallet loaded message to be clearer (master...better-no-wallet-error) https://github.com/bitcoin/bitcoin/pull/20101
 30 2020-10-08T01:39:13  *** bitcoin-git has left #bitcoin-core-dev
 31 2020-10-08T01:39:21  <achow101> gwillen: ^
 32 2020-10-08T01:40:25  *** AaronvanW has quit IRC
 33 2020-10-08T01:43:10  *** pinheadmz has joined #bitcoin-core-dev
 34 2020-10-08T02:05:14  *** kristapsk has quit IRC
 35 2020-10-08T02:06:51  *** kristapsk has joined #bitcoin-core-dev
 36 2020-10-08T02:11:23  *** AaronvanW has joined #bitcoin-core-dev
 37 2020-10-08T02:13:50  *** andreacab has joined #bitcoin-core-dev
 38 2020-10-08T02:18:27  *** andreacab has quit IRC
 39 2020-10-08T02:35:38  *** rc_423 has quit IRC
 40 2020-10-08T02:36:21  *** rc_423 has joined #bitcoin-core-dev
 41 2020-10-08T02:44:32  *** AaronvanW has quit IRC
 42 2020-10-08T02:47:28  *** pinheadmz has quit IRC
 43 2020-10-08T02:49:19  *** pinheadmz has joined #bitcoin-core-dev
 44 2020-10-08T03:00:02  *** lugosi1 has quit IRC
 45 2020-10-08T03:12:46  *** tralfaz has joined #bitcoin-core-dev
 46 2020-10-08T03:12:54  *** davterra has quit IRC
 47 2020-10-08T03:13:02  *** tralfaz is now known as davterra
 48 2020-10-08T03:25:55  *** justanotheruser has quit IRC
 49 2020-10-08T03:26:27  *** pinheadmz has quit IRC
 50 2020-10-08T03:41:39  *** proofofkeags has quit IRC
 51 2020-10-08T03:42:30  *** justanotheruser has joined #bitcoin-core-dev
 52 2020-10-08T03:43:21  *** pinheadmz has joined #bitcoin-core-dev
 53 2020-10-08T03:55:02  *** xPaw1 has joined #bitcoin-core-dev
 54 2020-10-08T03:55:33  *** da39a3ee5e6b4b0d has quit IRC
 55 2020-10-08T04:06:03  *** S3RK has joined #bitcoin-core-dev
 56 2020-10-08T04:20:12  *** rjected_ has quit IRC
 57 2020-10-08T04:23:07  *** justanotheruser has quit IRC
 58 2020-10-08T04:30:51  *** dermoth has quit IRC
 59 2020-10-08T04:31:14  *** dermoth has joined #bitcoin-core-dev
 60 2020-10-08T04:34:04  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
 61 2020-10-08T04:41:11  *** AaronvanW has joined #bitcoin-core-dev
 62 2020-10-08T04:43:31  *** S3RK has quit IRC
 63 2020-10-08T04:50:29  *** S3RK has joined #bitcoin-core-dev
 64 2020-10-08T04:54:48  *** brianhoffman_ has joined #bitcoin-core-dev
 65 2020-10-08T04:56:10  *** brianhoffman has quit IRC
 66 2020-10-08T04:56:11  *** brianhoffman_ is now known as brianhoffman
 67 2020-10-08T04:57:25  *** molz_ has joined #bitcoin-core-dev
 68 2020-10-08T05:00:41  *** mol_ has quit IRC
 69 2020-10-08T05:10:06  *** mol has joined #bitcoin-core-dev
 70 2020-10-08T05:12:44  *** molz_ has quit IRC
 71 2020-10-08T05:14:29  *** AaronvanW has quit IRC
 72 2020-10-08T05:14:38  *** mol has quit IRC
 73 2020-10-08T05:15:24  *** GankMove has joined #bitcoin-core-dev
 74 2020-10-08T05:52:46  *** S3RK has quit IRC
 75 2020-10-08T06:00:02  *** xPaw1 has quit IRC
 76 2020-10-08T06:07:35  *** tralfaz has joined #bitcoin-core-dev
 77 2020-10-08T06:09:43  *** davterra has quit IRC
 78 2020-10-08T06:15:29  *** andreacab has joined #bitcoin-core-dev
 79 2020-10-08T06:19:47  *** andreacab has quit IRC
 80 2020-10-08T06:21:23  *** leoburd has joined #bitcoin-core-dev
 81 2020-10-08T06:35:29  *** kyoo[m] has quit IRC
 82 2020-10-08T06:35:33  *** snowkeld[m] has quit IRC
 83 2020-10-08T06:35:35  *** RaphalBentgeac[m has quit IRC
 84 2020-10-08T06:35:44  *** Pasta[m] has quit IRC
 85 2020-10-08T06:35:53  *** rcrtn32002[m] has quit IRC
 86 2020-10-08T06:35:55  *** sethrogers23[m] has quit IRC
 87 2020-10-08T06:35:55  *** TheFuzzStone[m] has quit IRC
 88 2020-10-08T06:35:56  *** tianshi[m] has quit IRC
 89 2020-10-08T06:40:56  *** Guyver2 has joined #bitcoin-core-dev
 90 2020-10-08T06:42:31  *** icota[m] has joined #bitcoin-core-dev
 91 2020-10-08T06:45:51  *** andreacab has joined #bitcoin-core-dev
 92 2020-10-08T07:00:11  *** sethrogers23[m] has joined #bitcoin-core-dev
 93 2020-10-08T07:00:11  *** TheFuzzStone[m] has joined #bitcoin-core-dev
 94 2020-10-08T07:00:12  *** rcrtn32002[m] has joined #bitcoin-core-dev
 95 2020-10-08T07:00:12  *** snowkeld[m] has joined #bitcoin-core-dev
 96 2020-10-08T07:00:12  *** kyoo[m] has joined #bitcoin-core-dev
 97 2020-10-08T07:00:13  *** icota[m] has left #bitcoin-core-dev
 98 2020-10-08T07:00:17  *** tianshi[m] has joined #bitcoin-core-dev
 99 2020-10-08T07:00:17  *** RaphalBentgeac[m has joined #bitcoin-core-dev
100 2020-10-08T07:00:18  *** Pasta[m] has joined #bitcoin-core-dev
101 2020-10-08T07:11:53  *** AaronvanW has joined #bitcoin-core-dev
102 2020-10-08T07:30:20  *** S3RK has joined #bitcoin-core-dev
103 2020-10-08T07:31:47  *** andreacab has quit IRC
104 2020-10-08T07:31:54  *** andreacab has joined #bitcoin-core-dev
105 2020-10-08T07:32:17  *** DeanGuss has quit IRC
106 2020-10-08T07:32:40  *** DeanGuss has joined #bitcoin-core-dev
107 2020-10-08T07:33:00  *** RaphalBentgeac[m has quit IRC
108 2020-10-08T07:33:01  *** sethrogers23[m] has quit IRC
109 2020-10-08T07:33:01  *** leoburd has quit IRC
110 2020-10-08T07:33:01  *** jonatack has quit IRC
111 2020-10-08T07:33:01  *** dergoegge has quit IRC
112 2020-10-08T07:33:01  *** hsmiths has quit IRC
113 2020-10-08T07:33:01  *** mariorz has quit IRC
114 2020-10-08T07:33:01  *** noganoo has quit IRC
115 2020-10-08T07:33:01  *** kallewoof has quit IRC
116 2020-10-08T07:34:44  *** emzy_ has joined #bitcoin-core-dev
117 2020-10-08T07:37:04  *** RaphalBentgeac[m has joined #bitcoin-core-dev
118 2020-10-08T07:37:35  *** sethrogers23[m] has joined #bitcoin-core-dev
119 2020-10-08T07:38:32  *** dergoegge has joined #bitcoin-core-dev
120 2020-10-08T07:38:32  *** hsmiths has joined #bitcoin-core-dev
121 2020-10-08T07:38:32  *** mariorz has joined #bitcoin-core-dev
122 2020-10-08T07:38:32  *** noganoo has joined #bitcoin-core-dev
123 2020-10-08T07:38:32  *** kallewoof has joined #bitcoin-core-dev
124 2020-10-08T07:44:24  *** AaronvanW has quit IRC
125 2020-10-08T07:44:58  *** andreacab has quit IRC
126 2020-10-08T07:45:24  *** andreacab has joined #bitcoin-core-dev
127 2020-10-08T07:46:55  *** mol has joined #bitcoin-core-dev
128 2020-10-08T07:50:19  *** andreacab has quit IRC
129 2020-10-08T07:54:10  *** andreacab has joined #bitcoin-core-dev
130 2020-10-08T07:55:52  *** andreacab has quit IRC
131 2020-10-08T07:58:03  *** andreacab has joined #bitcoin-core-dev
132 2020-10-08T08:05:35  *** Pavlenex has joined #bitcoin-core-dev
133 2020-10-08T08:09:25  *** jonatack has joined #bitcoin-core-dev
134 2020-10-08T08:10:20  *** promag has joined #bitcoin-core-dev
135 2020-10-08T08:10:31  *** Pavlenex has quit IRC
136 2020-10-08T08:25:14  *** Harekiet1 has joined #bitcoin-core-dev
137 2020-10-08T08:29:05  *** Pavlenex has joined #bitcoin-core-dev
138 2020-10-08T08:31:26  *** AaronvanW has joined #bitcoin-core-dev
139 2020-10-08T08:33:43  *** da39a3ee5e6b4b0d has quit IRC
140 2020-10-08T08:34:22  *** promag has quit IRC
141 2020-10-08T08:34:54  *** mrostecki has joined #bitcoin-core-dev
142 2020-10-08T08:35:01  <wumpus> the release notes should not be considered documentation, and it's good if the program is self-contained, I'd greatly prefer linking to some actual documentation instead-like the help text of options or other RPC calls
143 2020-10-08T08:35:06  *** rc_423 has quit IRC
144 2020-10-08T08:35:14  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
145 2020-10-08T08:35:28  *** Pavlenex has joined #bitcoin-core-dev
146 2020-10-08T08:35:57  *** promag has joined #bitcoin-core-dev
147 2020-10-08T08:36:02  *** rc_423 has joined #bitcoin-core-dev
148 2020-10-08T08:37:20  *** S3RK has quit IRC
149 2020-10-08T08:37:43  *** promag has quit IRC
150 2020-10-08T08:40:25  *** da39a3ee5e6b4b0d has quit IRC
151 2020-10-08T08:45:14  *** S3RK has joined #bitcoin-core-dev
152 2020-10-08T08:52:25  *** Pavlenex has quit IRC
153 2020-10-08T08:54:22  *** opsec_x12 has quit IRC
154 2020-10-08T08:54:49  *** opsec_x12 has joined #bitcoin-core-dev
155 2020-10-08T09:00:02  *** Harekiet1 has quit IRC
156 2020-10-08T09:03:03  *** Pavlenex has joined #bitcoin-core-dev
157 2020-10-08T09:15:15  *** belcher has quit IRC
158 2020-10-08T09:15:38  *** AaronvanW has quit IRC
159 2020-10-08T09:16:35  *** AaronvanW has joined #bitcoin-core-dev
160 2020-10-08T09:20:17  *** AaronvanW has quit IRC
161 2020-10-08T09:20:35  *** AaronvanW has joined #bitcoin-core-dev
162 2020-10-08T09:22:12  *** sirkitree has joined #bitcoin-core-dev
163 2020-10-08T09:24:27  *** belcher has joined #bitcoin-core-dev
164 2020-10-08T09:27:42  *** belcher_ has joined #bitcoin-core-dev
165 2020-10-08T09:28:18  *** belcher has quit IRC
166 2020-10-08T09:40:22  *** Pavlenex has quit IRC
167 2020-10-08T09:40:32  *** bitcoin-git has joined #bitcoin-core-dev
168 2020-10-08T09:40:33  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/283a73d7eaea...9dd4de2832e2
169 2020-10-08T09:40:33  <bitcoin-git> bitcoin/master ec3916f Pieter Wuille: Use mockable time everywhere in net_processing
170 2020-10-08T09:40:34  <bitcoin-git> bitcoin/master b6834e3 Pieter Wuille: Avoid 'timing mishap' warnings when mocking
171 2020-10-08T09:40:34  <bitcoin-git> bitcoin/master 9dd4de2 MarcoFalke: Merge #20027: Use mockable time everywhere in net_processing
172 2020-10-08T09:40:36  *** bitcoin-git has left #bitcoin-core-dev
173 2020-10-08T09:40:52  *** bitcoin-git has joined #bitcoin-core-dev
174 2020-10-08T09:40:52  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20027: Use mockable time everywhere in net_processing (master...202009_mockable_netproc) https://github.com/bitcoin/bitcoin/pull/20027
175 2020-10-08T09:40:53  *** bitcoin-git has left #bitcoin-core-dev
176 2020-10-08T09:45:50  *** andreacab has quit IRC
177 2020-10-08T09:46:18  *** andreacab has joined #bitcoin-core-dev
178 2020-10-08T09:46:56  *** Pavlenex has joined #bitcoin-core-dev
179 2020-10-08T09:49:30  *** Pavlenex has quit IRC
180 2020-10-08T09:50:58  *** andreacab has quit IRC
181 2020-10-08T09:51:02  *** andreaca_ has joined #bitcoin-core-dev
182 2020-10-08T09:55:55  *** jonatack has quit IRC
183 2020-10-08T10:00:16  *** dermoth has quit IRC
184 2020-10-08T10:06:25  *** belcher has joined #bitcoin-core-dev
185 2020-10-08T10:09:08  *** belcher_ has quit IRC
186 2020-10-08T10:10:23  *** vasild has quit IRC
187 2020-10-08T10:12:17  *** dermoth has joined #bitcoin-core-dev
188 2020-10-08T10:12:18  *** vasild has joined #bitcoin-core-dev
189 2020-10-08T10:13:48  *** bitcoin-git has joined #bitcoin-core-dev
190 2020-10-08T10:13:48  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20103: test: Enable mocktime RPC for all test chains (master...2010-testMockAllChains) https://github.com/bitcoin/bitcoin/pull/20103
191 2020-10-08T10:13:49  *** bitcoin-git has left #bitcoin-core-dev
192 2020-10-08T10:16:33  *** vincenzopalazzo has joined #bitcoin-core-dev
193 2020-10-08T10:18:25  *** Elenor20Ziemann has joined #bitcoin-core-dev
194 2020-10-08T10:21:04  *** andreaca_ has quit IRC
195 2020-10-08T10:21:30  *** andreacab has joined #bitcoin-core-dev
196 2020-10-08T10:23:02  *** andreaca_ has joined #bitcoin-core-dev
197 2020-10-08T10:25:27  *** andreacab has quit IRC
198 2020-10-08T10:33:55  *** andreaca_ has quit IRC
199 2020-10-08T10:34:47  *** andreacab has joined #bitcoin-core-dev
200 2020-10-08T10:35:17  *** kallewoof has quit IRC
201 2020-10-08T10:35:24  *** kallewoof has joined #bitcoin-core-dev
202 2020-10-08T10:36:00  *** emzy_ has quit IRC
203 2020-10-08T10:36:00  *** Pavlenex has joined #bitcoin-core-dev
204 2020-10-08T10:36:48  *** kallewoof has quit IRC
205 2020-10-08T10:36:50  *** kallewoof_ has joined #bitcoin-core-dev
206 2020-10-08T10:37:31  *** worc3131 has quit IRC
207 2020-10-08T10:38:15  *** Pavlenex has quit IRC
208 2020-10-08T10:39:23  *** andreacab has quit IRC
209 2020-10-08T10:40:43  *** sdaftuar has quit IRC
210 2020-10-08T10:42:40  *** S3RK has quit IRC
211 2020-10-08T10:42:55  *** S3RK has joined #bitcoin-core-dev
212 2020-10-08T10:44:18  *** sdaftuar has joined #bitcoin-core-dev
213 2020-10-08T10:49:45  <wumpus> but no, there is no precedent for help options that are not RPC, and I'm not sure that's a good idea to introduce, it feels to me a kind of cluttery to use RPC help for that, it does reveal our lack of a more general user documentation. As a workaround isn't there some existing RPC where is would be appropriate?
214 2020-10-08T10:49:51  <wumpus> to be honest I think that error message is OK
215 2020-10-08T10:50:17  <wumpus> it's long but it actually tells something useful
216 2020-10-08T10:55:11  *** mrostecki has quit IRC
217 2020-10-08T10:58:20  *** mrostecki has joined #bitcoin-core-dev
218 2020-10-08T11:14:39  *** andreacab has joined #bitcoin-core-dev
219 2020-10-08T11:17:08  *** andreacab has quit IRC
220 2020-10-08T11:17:14  *** andreacab has joined #bitcoin-core-dev
221 2020-10-08T11:19:22  *** bitcoin-git has joined #bitcoin-core-dev
222 2020-10-08T11:19:22  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9dd4de2832e2...b337bd7bc087
223 2020-10-08T11:19:22  *** andreacab has quit IRC
224 2020-10-08T11:19:23  <bitcoin-git> bitcoin/master fae7a1c MarcoFalke: fuzz: Configure check for main function
225 2020-10-08T11:19:23  <bitcoin-git> bitcoin/master b337bd7 MarcoFalke: Merge #20065: fuzz: Configure check for main function
226 2020-10-08T11:19:25  *** bitcoin-git has left #bitcoin-core-dev
227 2020-10-08T11:19:42  *** bitcoin-git has joined #bitcoin-core-dev
228 2020-10-08T11:19:42  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20065: fuzz: Configure check for main function (master...2010-fuzzMainConfig) https://github.com/bitcoin/bitcoin/pull/20065
229 2020-10-08T11:19:44  *** bitcoin-git has left #bitcoin-core-dev
230 2020-10-08T11:20:02  *** bitcoin-git has joined #bitcoin-core-dev
231 2020-10-08T11:20:02  <bitcoin-git> [bitcoin] jnewbery opened pull request #20105: [net] Remove CombinerAll (master...2020-10-remove-combiner-all) https://github.com/bitcoin/bitcoin/pull/20105
232 2020-10-08T11:20:03  *** bitcoin-git has left #bitcoin-core-dev
233 2020-10-08T11:20:15  *** andreacab has joined #bitcoin-core-dev
234 2020-10-08T11:20:50  *** andreacab has joined #bitcoin-core-dev
235 2020-10-08T11:21:26  *** promag has joined #bitcoin-core-dev
236 2020-10-08T11:25:43  *** S3RK has quit IRC
237 2020-10-08T11:26:08  *** promag has quit IRC
238 2020-10-08T11:26:55  *** andreacab has quit IRC
239 2020-10-08T11:31:12  *** roconnor has joined #bitcoin-core-dev
240 2020-10-08T11:35:31  *** jeremyrubin has quit IRC
241 2020-10-08T11:43:48  *** mrostecki has quit IRC
242 2020-10-08T11:44:09  *** mrostecki has joined #bitcoin-core-dev
243 2020-10-08T11:54:06  *** S3RK has joined #bitcoin-core-dev
244 2020-10-08T11:55:20  *** andreacab has joined #bitcoin-core-dev
245 2020-10-08T11:58:44  *** S3RK has quit IRC
246 2020-10-08T12:00:02  *** sirkitree has quit IRC
247 2020-10-08T12:00:29  *** andreacab has quit IRC
248 2020-10-08T12:21:35  *** dr-orlovsky has joined #bitcoin-core-dev
249 2020-10-08T12:22:02  *** Lthere has joined #bitcoin-core-dev
250 2020-10-08T12:23:21  *** mrostecki has quit IRC
251 2020-10-08T12:25:28  <hebasto> for those who could be interested in Qt code -- https://github.com/users/hebasto/projects/1
252 2020-10-08T12:26:05  *** sdaftuar has quit IRC
253 2020-10-08T12:26:28  *** sdaftuar has joined #bitcoin-core-dev
254 2020-10-08T12:27:56  *** andreacab has joined #bitcoin-core-dev
255 2020-10-08T12:32:47  *** andreacab has quit IRC
256 2020-10-08T12:41:21  *** promag has joined #bitcoin-core-dev
257 2020-10-08T12:45:49  *** promag has quit IRC
258 2020-10-08T12:50:28  *** Elenor20Ziemann has quit IRC
259 2020-10-08T12:54:06  *** bitcoin-git has joined #bitcoin-core-dev
260 2020-10-08T12:54:06  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20106: cirrus: Use kvm to avoid spurious CI failures in the default virtualization cluster (master...2010-ciOtherVirt) https://github.com/bitcoin/bitcoin/pull/20106
261 2020-10-08T12:54:06  *** sr_gi has quit IRC
262 2020-10-08T12:54:07  *** bitcoin-git has left #bitcoin-core-dev
263 2020-10-08T12:54:45  *** sr_gi has joined #bitcoin-core-dev
264 2020-10-08T12:57:02  *** tralfaz is now known as davterra
265 2020-10-08T13:00:12  *** kallewoof_ has left #bitcoin-core-dev
266 2020-10-08T13:00:56  *** kallewoof has joined #bitcoin-core-dev
267 2020-10-08T13:02:40  <sdaftuar> rt
268 2020-10-08T13:03:35  * sdaftuar notes that could have been worse
269 2020-10-08T13:08:58  *** bitcoin-git has joined #bitcoin-core-dev
270 2020-10-08T13:08:59  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b337bd7bc087...392c6f4fb253
271 2020-10-08T13:08:59  <bitcoin-git> bitcoin/master 907f142 Andrew Chow: rpc: change no wallet loaded message to be clearer
272 2020-10-08T13:09:00  <bitcoin-git> bitcoin/master 392c6f4 MarcoFalke: Merge #20101: rpc: change no wallet loaded message to be clearer
273 2020-10-08T13:09:02  *** bitcoin-git has left #bitcoin-core-dev
274 2020-10-08T13:09:18  *** bitcoin-git has joined #bitcoin-core-dev
275 2020-10-08T13:09:18  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20101: rpc: change no wallet loaded message to be clearer (master...better-no-wallet-error) https://github.com/bitcoin/bitcoin/pull/20101
276 2020-10-08T13:09:24  *** bitcoin-git has left #bitcoin-core-dev
277 2020-10-08T13:12:18  *** bitcoin-git has joined #bitcoin-core-dev
278 2020-10-08T13:12:18  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20107: doc: Collect release-notes snippets (master...2010-docRelSnip) https://github.com/bitcoin/bitcoin/pull/20107
279 2020-10-08T13:12:20  *** bitcoin-git has left #bitcoin-core-dev
280 2020-10-08T13:22:23  *** yanmaani has quit IRC
281 2020-10-08T13:35:27  *** yanmaani has joined #bitcoin-core-dev
282 2020-10-08T13:43:24  *** mrostecki has joined #bitcoin-core-dev
283 2020-10-08T13:45:34  *** andreacab has joined #bitcoin-core-dev
284 2020-10-08T13:46:15  *** andreaca_ has joined #bitcoin-core-dev
285 2020-10-08T13:47:49  *** roconnor has quit IRC
286 2020-10-08T13:50:08  *** andreacab has quit IRC
287 2020-10-08T13:54:18  *** kexkey has joined #bitcoin-core-dev
288 2020-10-08T13:55:46  *** andreaca_ has quit IRC
289 2020-10-08T13:56:12  *** andreacab has joined #bitcoin-core-dev
290 2020-10-08T14:00:27  *** andreacab has quit IRC
291 2020-10-08T14:09:23  *** mrostecki has quit IRC
292 2020-10-08T14:11:27  *** dr-orlovsky has quit IRC
293 2020-10-08T14:12:44  *** dr-orlovsky has joined #bitcoin-core-dev
294 2020-10-08T14:30:00  *** S3RK has joined #bitcoin-core-dev
295 2020-10-08T14:32:36  *** proofofkeags has joined #bitcoin-core-dev
296 2020-10-08T14:34:05  *** S3RK has quit IRC
297 2020-10-08T14:44:43  *** k3tan has quit IRC
298 2020-10-08T14:45:04  *** justanotheruser has joined #bitcoin-core-dev
299 2020-10-08T14:46:12  *** k3tan has joined #bitcoin-core-dev
300 2020-10-08T15:00:02  *** Lthere has quit IRC
301 2020-10-08T15:22:00  *** zacts has joined #bitcoin-core-dev
302 2020-10-08T15:22:24  *** zacts is now known as Guest4550
303 2020-10-08T15:35:45  *** proofofkeags has quit IRC
304 2020-10-08T15:36:48  <dongcarl> vasild, sipa: I might be misremembering, but I recall having a discussion about the versionspace of serializers/unserializers and how we should separate them for different types?
305 2020-10-08T15:38:00  <dongcarl> Oh I see that's still being worked on in #19503
306 2020-10-08T15:38:04  <gribble> https://github.com/bitcoin/bitcoin/issues/19503 | Add parameter feature to serialization and use it for CAddress by sipa · Pull Request #19503 · bitcoin/bitcoin · GitHub
307 2020-10-08T15:41:34  *** jeremyrubin has joined #bitcoin-core-dev
308 2020-10-08T15:44:09  <vasild> yeah
309 2020-10-08T15:50:07  *** ghost43 has quit IRC
310 2020-10-08T15:50:26  *** ghost43 has joined #bitcoin-core-dev
311 2020-10-08T15:52:25  *** jonatack has joined #bitcoin-core-dev
312 2020-10-08T15:53:49  <sipa> dongcarl: yeah, but i didn't want to hold up torv3 stuff with that
313 2020-10-08T15:53:59  <sipa> so i hacen't pushed for it further
314 2020-10-08T15:54:20  <dongcarl> Makes sense!
315 2020-10-08T15:57:16  *** palazzovincenzo has joined #bitcoin-core-dev
316 2020-10-08T16:00:00  *** vincenzopalazzo has quit IRC
317 2020-10-08T16:00:06  *** andreacab has joined #bitcoin-core-dev
318 2020-10-08T16:03:50  *** proofofkeags has joined #bitcoin-core-dev
319 2020-10-08T16:06:00  *** proofofkeags has quit IRC
320 2020-10-08T16:09:13  *** vincenzopalazzo has joined #bitcoin-core-dev
321 2020-10-08T16:13:21  *** andreacab has quit IRC
322 2020-10-08T16:13:49  *** andreacab has joined #bitcoin-core-dev
323 2020-10-08T16:18:18  *** andreacab has quit IRC
324 2020-10-08T16:18:47  *** Guest4550 has quit IRC
325 2020-10-08T16:26:17  *** Talkless has joined #bitcoin-core-dev
326 2020-10-08T16:33:52  *** icota[m] has joined #bitcoin-core-dev
327 2020-10-08T16:37:35  *** Ga1aCt1Cz00_ has joined #bitcoin-core-dev
328 2020-10-08T16:41:41  *** Ga1aCt1Cz00 has quit IRC
329 2020-10-08T16:58:04  *** hari1 has joined #bitcoin-core-dev
330 2020-10-08T17:07:08  <wumpus> #19503 and TorV3 would be an interesting combination, but yes I don't think they should hold up each other
331 2020-10-08T17:07:11  <gribble> https://github.com/bitcoin/bitcoin/issues/19503 | Add parameter feature to serialization and use it for CAddress by sipa · Pull Request #19503 · bitcoin/bitcoin · GitHub
332 2020-10-08T17:33:49  *** filchef has joined #bitcoin-core-dev
333 2020-10-08T17:49:42  *** andreacab has joined #bitcoin-core-dev
334 2020-10-08T18:00:02  *** hari1 has quit IRC
335 2020-10-08T18:22:09  *** variable has joined #bitcoin-core-dev
336 2020-10-08T18:22:11  *** variable is now known as Guest36719
337 2020-10-08T18:33:30  *** andreacab has quit IRC
338 2020-10-08T18:33:57  *** andreacab has joined #bitcoin-core-dev
339 2020-10-08T18:38:18  *** andreacab has quit IRC
340 2020-10-08T18:42:53  *** bitcoin-git has joined #bitcoin-core-dev
341 2020-10-08T18:42:54  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/392c6f4fb253...d9de00b3e067
342 2020-10-08T18:42:54  <bitcoin-git> bitcoin/master 1afcd41 John Newbery: [net] Remove CombinerAll
343 2020-10-08T18:42:55  <bitcoin-git> bitcoin/master d9de00b Wladimir J. van der Laan: Merge #20105: [net] Remove CombinerAll
344 2020-10-08T18:42:57  *** bitcoin-git has left #bitcoin-core-dev
345 2020-10-08T18:43:13  *** bitcoin-git has joined #bitcoin-core-dev
346 2020-10-08T18:43:13  <bitcoin-git> [bitcoin] laanwj merged pull request #20105: [net] Remove CombinerAll (master...2020-10-remove-combiner-all) https://github.com/bitcoin/bitcoin/pull/20105
347 2020-10-08T18:43:14  *** bitcoin-git has left #bitcoin-core-dev
348 2020-10-08T18:45:30  *** vincenzopalazzo has quit IRC
349 2020-10-08T18:57:38  *** S3RK has joined #bitcoin-core-dev
350 2020-10-08T18:58:44  *** jonasschnelli has quit IRC
351 2020-10-08T18:58:45  *** jonasschnelli has joined #bitcoin-core-dev
352 2020-10-08T19:01:35  <aj> meeting?
353 2020-10-08T19:01:37  <jnewbery> e
354 2020-10-08T19:02:11  <sipa> hi
355 2020-10-08T19:02:14  <jonasschnelli> hi
356 2020-10-08T19:02:24  *** S3RK has quit IRC
357 2020-10-08T19:02:29  *** andreacab has joined #bitcoin-core-dev
358 2020-10-08T19:02:35  <wumpus> #startmeeting
359 2020-10-08T19:02:35  <lightningbot> Meeting started Thu Oct  8 19:02:35 2020 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
360 2020-10-08T19:02:35  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
361 2020-10-08T19:02:37  <jnewbery> hi
362 2020-10-08T19:02:40  <hebasto> hi
363 2020-10-08T19:02:52  <aj> hiiii
364 2020-10-08T19:02:55  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
365 2020-10-08T19:02:57  <wumpus> amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2
366 2020-10-08T19:03:04  <meshcollider> hi
367 2020-10-08T19:03:13  <jonatack> ciao
368 2020-10-08T19:03:27  <luke-jr> hi
369 2020-10-08T19:04:15  <wumpus> FWIW: the 0.21 feature freeze is in a week, it probably makes more sense to discuss what is tagged for the 0.21 milestone as high priority for review at this point
370 2020-10-08T19:04:25  <wumpus> this is https://github.com/bitcoin/bitcoin/milestone/45
371 2020-10-08T19:06:05  <sipa> that's a long list
372 2020-10-08T19:06:12  <wumpus> it looks like no other topics have been proposed for this week
373 2020-10-08T19:06:15  <jonasschnelli> How is the merge back of the GUI repository handled? MarcoFalke?
374 2020-10-08T19:06:19  <wumpus> yes, it's also likely outdated
375 2020-10-08T19:06:22  <jonasschnelli> (Regarding freeze)
376 2020-10-08T19:06:37  <wumpus> which makes it good to go over it I suppose
377 2020-10-08T19:06:55  <vasild> hi
378 2020-10-08T19:07:30  <wumpus> and at least two of the issues are simply 'follow release process'
379 2020-10-08T19:07:38  <sipa> i think #19954 is pretty much done
380 2020-10-08T19:07:41  <gribble> https://github.com/bitcoin/bitcoin/issues/19954 | tor: complete the TORv3 implementation by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
381 2020-10-08T19:07:56  <wumpus> yes
382 2020-10-08T19:08:08  <hebasto> #18077 and #18710 could be moved to 0.22
383 2020-10-08T19:08:10  <gribble> https://github.com/bitcoin/bitcoin/issues/18077 | net: Add NAT-PMP port forwarding support by hebasto · Pull Request #18077 · bitcoin/bitcoin · GitHub
384 2020-10-08T19:08:13  <gribble> https://github.com/bitcoin/bitcoin/issues/18710 | Add local thread pool to CCheckQueue by hebasto · Pull Request #18710 · bitcoin/bitcoin · GitHub
385 2020-10-08T19:08:28  <wumpus> hebasto: ok, thanks
386 2020-10-08T19:08:38  <aj> #19543 doesn't have an associated PR yet?
387 2020-10-08T19:08:40  <gribble> https://github.com/bitcoin/bitcoin/issues/19543 | Normalize fee units for RPC ("BTC/kB" and "sat/B) · Issue #19543 · bitcoin/bitcoin · GitHub
388 2020-10-08T19:08:42  <nehan> 5
389 2020-10-08T19:09:00  <nehan> (typo)
390 2020-10-08T19:09:04  <jonatack> i've been focusing on #19953 the past day or so as it seems to be the highest priority along with tor v3
391 2020-10-08T19:09:07  <gribble> https://github.com/bitcoin/bitcoin/issues/19953 | Implement BIP 340-342 validation (Schnorr/taproot/tapscript) by sipa · Pull Request #19953 · bitcoin/bitcoin · GitHub
392 2020-10-08T19:09:39  <jonatack> aj: i planned to do #19543 after FF as it's a bugfix
393 2020-10-08T19:09:40  <gribble> https://github.com/bitcoin/bitcoin/issues/19543 | Normalize fee units for RPC ("BTC/kB" and "sat/B) · Issue #19543 · bitcoin/bitcoin · GitHub
394 2020-10-08T19:09:51  <hebasto> two drafts also could be moved?
395 2020-10-08T19:09:53  <sipa> all todos are done for taproot, including the json tests in the qa-assets repo
396 2020-10-08T19:09:59  <wumpus> jonatack: so that one needs 0.21 milestone?
397 2020-10-08T19:10:16  <wumpus> aj: seems like it, but also seems not urgent for 0.21?
398 2020-10-08T19:11:04  <wumpus> aj: oh "This needs to happen before the next major release. Otherwise, it will be a breaking change."
399 2020-10-08T19:11:05  *** vasild has quit IRC
400 2020-10-08T19:11:06  *** vasild_ has joined #bitcoin-core-dev
401 2020-10-08T19:11:09  <aj> wumpus: yeah
402 2020-10-08T19:11:12  <wumpus> ping MarcoFalke
403 2020-10-08T19:11:12  *** vasild_ is now known as vasild
404 2020-10-08T19:11:28  <sipa> wumpus: i'd very much like to get taproot in 0.21, as the alternative (i expect) is that we'll want it early in 0.22 anyway, which will just complicate backports
405 2020-10-08T19:11:51  <sipa> (the code, not activation obviously)
406 2020-10-08T19:12:03  <wumpus> hebasto: done
407 2020-10-08T19:12:14  <wumpus> sipa: agree!
408 2020-10-08T19:12:48  <jonatack> +1
409 2020-10-08T19:13:59  <meshcollider> I feel like we should really push for #19077 if possible just to have it in the same version as descriptor wallets like we discussed
410 2020-10-08T19:14:02  <gribble> https://github.com/bitcoin/bitcoin/issues/19077 | wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets by achow101 · Pull Request #19077 · bitcoin/bitcoin · GitHub
411 2020-10-08T19:14:09  <meshcollider> But it's a big PR
412 2020-10-08T19:14:28  <sipa> i haven't paid attention to the PR itself, but it seems it's been making lots of progress lately, including review
413 2020-10-08T19:14:45  <meshcollider> Yeah it's had a decent amount of review already so it's not infeasible
414 2020-10-08T19:15:05  <sipa> i know wumpus had reservations about having it in 0.21
415 2020-10-08T19:15:24  <wumpus> looks like we're starting to run into issues building bdb 4.8 on some platforms at least: #19411
416 2020-10-08T19:15:26  <gribble> https://github.com/bitcoin/bitcoin/issues/19411 | Unable to build BDB 4.8 on macOS Big Sur beta or Xcode 12.0 · Issue #19411 · bitcoin/bitcoin · GitHub
417 2020-10-08T19:16:01  <wumpus> sipa: yes, it seems fairly risky to introduce a new wallet database format (which is used by default) in something last minute
418 2020-10-08T19:16:03  <sipa> --with-incompatible-bdb lalala
419 2020-10-08T19:16:23  <achow101> wumpus: it's only used by descriptor wallets which we already have marked as "experimental"
420 2020-10-08T19:16:35  <wumpus> achow101: they're not created by default for new users?
421 2020-10-08T19:16:39  <achow101> no
422 2020-10-08T19:16:41  <wumpus> in that case I"m oay with it
423 2020-10-08T19:17:02  <sipa> ah, descriptor wallets are not default for new wallets?
424 2020-10-08T19:17:07  <achow101> not yet
425 2020-10-08T19:17:25  <sipa> that's perhaps the best of both worlds... get descriptor wallets and sqlite in 0.21, but neither is default
426 2020-10-08T19:17:37  <wumpus> if it's opt-in I see no problem
427 2020-10-08T19:18:27  <achow101> if descriptor wallets were the default, a lot of tests would be failing :p
428 2020-10-08T19:20:46  <wumpus> wrt #20005 I'm not convinced we should do anything for it, the particular issue doesn't affect anything in our project and clearly in the longer run it's better left solved upstream
429 2020-10-08T19:20:47  <gribble> https://github.com/bitcoin/bitcoin/issues/20005 | memcmp with constants that contain zero bytes are broken in GCC · Issue #20005 · bitcoin/bitcoin · GitHub
430 2020-10-08T19:21:36  *** Talkless has quit IRC
431 2020-10-08T19:21:54  <sipa> agree
432 2020-10-08T19:22:11  <sipa> it's good to continue discussing the options, but i don't think there is urgency
433 2020-10-08T19:22:22  <wumpus> sure, but removing the milestone then
434 2020-10-08T19:22:22  <sipa> we're not using gcc 9 or gcc 10 for releases either, i believe?
435 2020-10-08T19:23:17  <wumpus> no, 8 at most
436 2020-10-08T19:23:41  <hebasto> 7.4 for linux x86_64
437 2020-10-08T19:25:24  <wumpus> yes, correct
438 2020-10-08T19:25:35  *** Pavlenex has joined #bitcoin-core-dev
439 2020-10-08T19:25:42  <wumpus> otherwise there's agreement what is on the milestone right now?
440 2020-10-08T19:26:48  <sipa> not everything will make it, but sure
441 2020-10-08T19:27:11  <sipa> i'm also hoping for 19988
442 2020-10-08T19:27:23  <sipa> given the amount of review it's had the past days
443 2020-10-08T19:27:58  <jnewbery> I think 19988 is ready. It has three or four recent ACKs now
444 2020-10-08T19:28:22  <meshcollider> #19988
445 2020-10-08T19:28:25  <gribble> https://github.com/bitcoin/bitcoin/issues/19988 | Overhaul transaction request logic by sipa · Pull Request #19988 · bitcoin/bitcoin · GitHub
446 2020-10-08T19:29:03  <sipa> 50% test code :)
447 2020-10-08T19:29:20  <wumpus> added to milestone anyway
448 2020-10-08T19:29:25  <sipa> thanks!
449 2020-10-08T19:30:44  <sipa> unrelated: i've noticed that sometimes clicking "show resolved" on github expands everything, and sometimes not
450 2020-10-08T19:30:57  <sipa> does anyone else have this, or know how it's caused?
451 2020-10-08T19:30:58  <achow101> #16463 could be removed from the milestone I guess
452 2020-10-08T19:31:01  <gribble> https://github.com/bitcoin/bitcoin/issues/16463 | [BIP 174] Implement serialization support for GLOBAL_XPUB field. by achow101 · Pull Request #16463 · bitcoin/bitcoin · GitHub
453 2020-10-08T19:31:31  <wumpus> ok done
454 2020-10-08T19:32:41  <wumpus> any other topics for today?
455 2020-10-08T19:33:03  <jnewbery> I have a question about c++17
456 2020-10-08T19:33:42  <aj> wumpus: you pinged about moving https://github.com/users/ajtowns/projects/1 under bitcoin/ ; happy to, might be nice to move the automation into drahtbot at the same time
457 2020-10-08T19:34:04  <jnewbery> we're planning to move to c++17 (remove c++11 compat) in v0.21: https://github.com/bitcoin/bitcoin/issues/16684
458 2020-10-08T19:34:18  <wumpus> no, in 0.22 right?
459 2020-10-08T19:34:33  <wumpus> 0.21 introduces c++17 compilation by default
460 2020-10-08T19:34:36  <jnewbery> oops sorry, yes v0.22
461 2020-10-08T19:34:47  <wumpus> 0.22 is c++17 only
462 2020-10-08T19:34:49  <wumpus> okay
463 2020-10-08T19:35:04  *** andreacab has quit IRC
464 2020-10-08T19:35:04  <jnewbery> so after v0.21 branch we're theoretically free to use c++17 features throughout the codebase
465 2020-10-08T19:35:05  *** Eagle[TM] has quit IRC
466 2020-10-08T19:35:11  <wumpus> yes
467 2020-10-08T19:35:29  *** andreacab has joined #bitcoin-core-dev
468 2020-10-08T19:35:29  <jnewbery> My question was whether it makes sense to try to keep c++11 compatability for consensus code for longer
469 2020-10-08T19:35:40  <wumpus> for new code definitely, as for c++11, please don't file PRs to convert all old code at once
470 2020-10-08T19:35:49  <wumpus> for the sake of doing so
471 2020-10-08T19:36:09  <wumpus> there's no *need* for any compatibility with c++11 anymore
472 2020-10-08T19:36:12  <jnewbery> ie use c++17 features in net processing/wallet/etc, but try to keep consensus code on c++11 for longer
473 2020-10-08T19:36:59  <jnewbery> given that apparently compilers have bugs it might make sense to be more conservative with upgrading to the latest features in consensus
474 2020-10-08T19:37:06  <wumpus> I think that will make things really complicated, even defining what is 'consensus code' is pretty hard right now
475 2020-10-08T19:37:12  <jnewbery> but it's just a half-baked thought
476 2020-10-08T19:37:41  <jnewbery> wumpus: right. It'd be nice if that separation were clearer
477 2020-10-08T19:37:46  <wumpus> or do you only mean 'what is part of libconsensus'
478 2020-10-08T19:38:01  <wumpus> dongcarl's libbitcoinkernel is a nice idea but it's only an idea right now
479 2020-10-08T19:38:21  *** Pavlenex1 has joined #bitcoin-core-dev
480 2020-10-08T19:38:50  <aj> libbitcoinkernel? no hits on google
481 2020-10-08T19:38:51  <wumpus> yes, it'd be nice but definitely not around the corner, I don't think it's in any shape to make C++ version depend on it
482 2020-10-08T19:39:12  <wumpus> agree with regard to bugs though
483 2020-10-08T19:39:16  <sipa> almost all of C++17 is in GCC 7, and all of it is in GCC 8
484 2020-10-08T19:39:18  <wumpus> everything is broken let' go shopping
485 2020-10-08T19:39:50  <sipa> so i'd agree as far as being conservative w.r.t. C++ features in consensus-critical code, but i don't think that's necessarily a new idea
486 2020-10-08T19:39:56  <sipa> we always want to be conservative there
487 2020-10-08T19:40:15  <sipa> i don't think we need a "this subset of the code must remain c++11 compatible" rule
488 2020-10-08T19:40:17  *** andreacab has quit IRC
489 2020-10-08T19:40:29  <sipa> whether enforced or not
490 2020-10-08T19:40:44  <wumpus> I really thin kwe should make one decision for the entire codebase
491 2020-10-08T19:40:53  <sipa> agree
492 2020-10-08T19:41:07  <wumpus> if the recent discovery means that new versions of C++ are unsafe, that means, let's just give up on C++17 for now
493 2020-10-08T19:41:17  <sipa> i don't think so
494 2020-10-08T19:41:24  <wumpus> I don't particularly want the P2P code to be unsafe either
495 2020-10-08T19:41:27  *** Pavlenex has quit IRC
496 2020-10-08T19:41:27  *** Pavlenex1 is now known as Pavlenex
497 2020-10-08T19:41:31  <sipa> it's a bug in a C89 feature FFS
498 2020-10-08T19:41:34  <jnewbery> sipa: does it make sense to codify what you mean by 'conservative w.r.t c++ features in consensus-critical code'?
499 2020-10-08T19:42:00  <wumpus> we don't have suffiient separateion of consensus-critical code from anything
500 2020-10-08T19:42:03  <wumpus> we need to have that, sure
501 2020-10-08T19:42:32  <wumpus> but it's more than you'd expect if you include util and compat and other indirect dependencies
502 2020-10-08T19:42:58  <sipa> jnewbery: yeah, i'm trying to think what that would mean
503 2020-10-08T19:43:01  <sipa> it's just a thought
504 2020-10-08T19:43:26  <wumpus> honestly I think this is completely seperate from the c++17 question
505 2020-10-08T19:43:32  <sipa> yes, agree
506 2020-10-08T19:43:36  <wumpus> yes, it would be good to isolate the consensus code
507 2020-10-08T19:43:54  <wumpus> then again this was a project since, 2012 or so...
508 2020-10-08T19:44:19  *** EagleTM has joined #bitcoin-core-dev
509 2020-10-08T19:44:25  <wumpus> also: leveldb is part of consensus
510 2020-10-08T19:44:29  <sipa> i think the question for C++17 or not just depends on whether we expect build environments that people will want to use for 0.22 support it sufficiently or not
511 2020-10-08T19:45:00  <wumpus> it's not like you can build the consensus code separately anyway
512 2020-10-08T19:45:16  <sipa> indeed
513 2020-10-08T19:45:38  <sipa> we *could* say that libconsensus needs to remain C++11 buildable - but i don't think there is much of a reason for that
514 2020-10-08T19:46:05  <wumpus> I don't think so either
515 2020-10-08T19:46:33  <wumpus> c++17 is already three years old anyway and most c++ compilers implemented it, or features from it, before that
516 2020-10-08T19:46:46  <wumpus> it's not that we're super fast in adopting new c++ standards
517 2020-10-08T19:46:48  <sipa> so let's discuss this after 0.21 branch off, whether we think requiring a C++17 build environment will be a problem by the time 0.22 gets released
518 2020-10-08T19:47:07  <sipa> indeed
519 2020-10-08T19:47:08  <jnewbery> sipa: +1
520 2020-10-08T19:47:32  <jonatack> to summarize, if I may: before feature freeze in one week, please review 19953 (BIPs 340-342), 19954 (tor v3), 19988 (tx relay logic), and 19077 (sqlite wallet)
521 2020-10-08T19:47:40  <wumpus> seems deviating from our plan here on last minute does need a very good reason though
522 2020-10-08T19:47:52  <jnewbery> I am interested in how we judge 'conservative w.r.t c++ features', but not necessarily now
523 2020-10-08T19:48:33  <sipa> wumpus: yeah
524 2020-10-08T19:48:34  <wumpus> I think we need to be conservative in making changes to the consensus code, not so much specifically regarding c++ features
525 2020-10-08T19:48:39  <aj> jnewbery: i think that was just a subset of "conservative in general"
526 2020-10-08T19:48:54  <wumpus> right
527 2020-10-08T19:49:15  <wumpus> which was also my first reply, don't change code for c++17 for the sake of using c++17
528 2020-10-08T19:49:21  <sipa> and perhaps avoid features that reviewers may not be very familiar with - which is correlated but not the same as recently-introduced language features
529 2020-10-08T19:49:49  <wumpus> any other topics?
530 2020-10-08T19:50:51  <sipa> jonatack: +1
531 2020-10-08T19:51:43  *** Pavlenex1 has joined #bitcoin-core-dev
532 2020-10-08T19:52:11  <wumpus> honestly I'd feel a lot better if we had focused on isolating the consensus-critical code a long time ago, seems like something people like to talk about but it never really panned out yet
533 2020-10-08T19:52:30  <sipa> wumpus: it's... hard
534 2020-10-08T19:52:47  *** Pavlenex has quit IRC
535 2020-10-08T19:52:47  *** Pavlenex1 is now known as Pavlenex
536 2020-10-08T19:52:52  <wumpus> sipa: yes :/
537 2020-10-08T19:52:56  <wumpus> jonatack: agree!
538 2020-10-08T19:54:09  <jnewbery> wumpus: we're moving in that direction ... slowly. #20049 and #20050 are next
539 2020-10-08T19:54:09  <wumpus> sipa: it's hard but maybe one of the things remaining that's really worth doing
540 2020-10-08T19:54:10  <gribble> https://github.com/bitcoin/bitcoin/issues/20049 | De-globalizing ChainstateManager · Issue #20049 · bitcoin/bitcoin · GitHub
541 2020-10-08T19:54:12  <gribble> https://github.com/bitcoin/bitcoin/issues/20050 | validation: Prune (in)direct g_chainman usage related to ::LookupBlockIndex (bundle 1) by dongcarl · Pull Request #20050 · bitcoin/bitcoin · GitHub
542 2020-10-08T19:54:50  <wumpus> jnewbery: I guess the main problem is that isolating the consensus code means changes to the consensus code which is a risk in itself so hard to do
543 2020-10-08T19:55:44  <wumpus> jnewbery: but good to know!
544 2020-10-08T19:55:48  <aj> wumpus: also that we want to switch between non-consensus and consensus code efficiently in lots of places
545 2020-10-08T19:56:34  <sipa> yes, and given previous attempts at refactoring out consensus code ended us more than once is a worse half-baked state, it's harder to get reviewer enthousiasm for such changes
546 2020-10-08T19:56:50  <wumpus> aj: yes defining an interface that makes sens in itself but doesn't make things a lot slower is another thing
547 2020-10-08T19:57:03  <dongcarl> Definitely non-zero risks, which is why the focus should be on doing it incrementally, and testing it continuously :-)
548 2020-10-08T19:57:20  *** EagleTM has quit IRC
549 2020-10-08T19:57:36  <wumpus> definitely more interestedi n it than discussions about the icon color though :-)
550 2020-10-08T19:57:45  <dongcarl> Hehe
551 2020-10-08T19:57:47  <sipa> haha
552 2020-10-08T19:57:50  <jonatack> hehe
553 2020-10-08T19:57:54  <sipa> it is as BIP42 predicted
554 2020-10-08T19:58:09  <sipa> "Prominent among them is the discussion on what to call 1 billion Bitcoin, which symbol color to use for it, and when wallet clients should switch to it by default. "
555 2020-10-08T19:58:33  <wumpus> heh!
556 2020-10-08T19:59:20  <wumpus> #endmeeting
557 2020-10-08T19:59:20  <lightningbot> Meeting ended Thu Oct  8 19:59:20 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
558 2020-10-08T19:59:20  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-08-19.02.html
559 2020-10-08T19:59:20  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-08-19.02.txt
560 2020-10-08T19:59:20  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-08-19.02.log.html
561 2020-10-08T19:59:37  <achow101> time to add "prophet" to sipa's resume
562 2020-10-08T20:02:13  <sipa> aj: fwiw, 19988 now has "time going backwards" unit tests
563 2020-10-08T20:16:42  *** Guyver2 has quit IRC
564 2020-10-08T20:22:19  *** filchef has quit IRC
565 2020-10-08T20:39:37  <vasild> CAddress::unser: time=1601829922, services=134218813, addr=62.107.200.30:8333
566 2020-10-08T20:39:56  <vasild> CAddress::unser: time=1600339981, services=134217741, addr=akinbo7tlegsnsxn.onion:8333
567 2020-10-08T20:40:31  <vasild> jonatack: wumpus: so...
568 2020-10-08T20:41:05  <vasild> in the network there are some peers with services=unusually high value
569 2020-10-08T20:42:08  <sipa> that's 0x0800000d
570 2020-10-08T20:42:14  <vasild> they get in via p2p gossip into addrman without causing problems
571 2020-10-08T20:42:16  <vasild> sipa: right
572 2020-10-08T20:43:18  <vasild> using addrv1
573 2020-10-08T20:44:03  <vasild> then addrman saves it on disk just fine in V3_BIP155 format using READWRITE(COMPACTSIZE(services_tmp))
574 2020-10-08T20:44:44  <vasild> however, on read back from disk it bricks because ReadCompactSize() contains this at the end:
575 2020-10-08T20:44:53  <vasild>     if (nSizeRet > (uint64_t)MAX_SIZE)
576 2020-10-08T20:44:54  <vasild>         throw std::ios_base::failure("ReadCompactSize(): size too large");
577 2020-10-08T20:45:18  <vasild> and MAX_SIZE is quite low value 0x02000000
578 2020-10-08T20:45:47  <vasild> I wondered before wtf is that limit but decided it is harmless
579 2020-10-08T20:46:15  <sipa> vasild: ehhhh
580 2020-10-08T20:46:28  <sipa> this means we need to bypass that limit when deserializing addrv2
581 2020-10-08T20:46:46  <vasild> so WriteCompactSize() can write >0x02000000 but ReadCompactSize() cannot read it back :-X
582 2020-10-08T20:46:48  *** balbirs has quit IRC
583 2020-10-08T20:47:32  *** balbirs has joined #bitcoin-core-dev
584 2020-10-08T20:47:46  <sipa> vasild: it's a protection for the case where CompactSize format is used to actually encode a size
585 2020-10-08T20:47:50  <sipa> and not just a number
586 2020-10-08T20:48:19  <sipa> add a bool to ReadCompactSize to determine whether the limit is enforced or not?
587 2020-10-08T20:49:17  <sipa> i guess we overlooked that in bip152, where it's also not used as a size, but restricted to pretty small numbers
588 2020-10-08T20:49:35  <sipa> let me know if you need help with serialization framework stuff
589 2020-10-08T20:50:25  <pinheadmz> where can i find the current version of bitcoin core in the source code? wihtout using git
590 2020-10-08T20:50:52  <sipa> clientversion.h
591 2020-10-08T20:51:01  <pinheadmz> (sorry meant for pr-reviews-club) thanks sipa
592 2020-10-08T20:51:10  <vasild> hmm
593 2020-10-08T20:51:54  <sipa> ah, it's in config/bitcoin-config.h now
594 2020-10-08T20:52:04  <sipa> which may be generated by somwthing else still
595 2020-10-08T20:52:22  <sipa> version numbers are aoways a mess, due to attempts to aboid having it in dozens of places
596 2020-10-08T20:52:46  <pinheadmz> yeah thats why i expected there to be one source of truth that gets copioed arond
597 2020-10-08T20:53:09  <sipa> it's in configure.ac i think
598 2020-10-08T20:53:19  <sipa> top of the file
599 2020-10-08T20:53:33  <pinheadmz> aha yes, this is what im looking for gracias
600 2020-10-08T20:53:36  <vasild> sipa: how would we pass a bool parameter to ReadCompactSize() from               READWRITE(COMPACTSIZE(services_tmp));
601 2020-10-08T20:54:21  <sipa> vasild: you can add template parameters to the compactsize wrapper
602 2020-10-08T20:54:22  <vasild> inroduce READWRITE(COMPACTSIZE_UNBOUNDED(services_tmp))
603 2020-10-08T20:54:23  <vasild> ?
604 2020-10-08T20:54:29  <sipa> i can do that also
605 2020-10-08T20:54:38  <sipa> though i'll be busy the next hour or so
606 2020-10-08T20:55:11  <vasild> I am too sleepy, going to bed now, glad I nailed this down
607 2020-10-08T20:55:19  <vasild> (the problem, not the solution)
608 2020-10-08T20:56:17  * vasild bb in 9-10h
609 2020-10-08T20:56:19  <jonatack> vasild: nice! sleepy here too, but it looks like that would explain what we are seeing. back on it tomorrow -- goodnight!
610 2020-10-08T20:56:38  <vasild> jonatack: yeah, your disk is not corrupted! :-)
611 2020-10-08T20:56:52  <sipa> vasild: what timezone are you in?
612 2020-10-08T20:57:05  <vasild> UTC+2, it is 22:57 here
613 2020-10-08T20:57:09  <jonatack> i suspect it's 2300
614 2020-10-08T20:57:25  <vasild> sipa: you?
615 2020-10-08T20:58:05  <sipa> vasild: UTC-7
616 2020-10-08T20:58:32  <vasild> almost on the other side of the world :)
617 2020-10-08T20:58:33  <sipa> lots of october 8th left for me
618 2020-10-08T20:58:34  <jonatack> oh not in nyc then
619 2020-10-08T20:58:38  <sipa> jonatack: not yet
620 2020-10-08T21:00:01  *** Guest36719 has quit IRC
621 2020-10-08T21:00:02  * vasild zZzZ
622 2020-10-08T21:14:27  *** justanotheruser has quit IRC
623 2020-10-08T21:16:57  *** EagleTM has joined #bitcoin-core-dev
624 2020-10-08T21:20:11  *** EagleTM has quit IRC
625 2020-10-08T21:20:35  *** EagleTM has joined #bitcoin-core-dev
626 2020-10-08T21:22:28  *** dorena has joined #bitcoin-core-dev
627 2020-10-08T21:22:55  *** proofofkeags has joined #bitcoin-core-dev
628 2020-10-08T21:23:00  *** proofofkeags_ has joined #bitcoin-core-dev
629 2020-10-08T21:23:36  *** Pavlenex has quit IRC
630 2020-10-08T21:25:59  *** EagleTM has quit IRC
631 2020-10-08T21:26:08  *** bitcoin-git has joined #bitcoin-core-dev
632 2020-10-08T21:26:08  <bitcoin-git> [bitcoin] glozow opened pull request #20109: Release notes and followups from 19339 (master...docs-absurdfee) https://github.com/bitcoin/bitcoin/pull/20109
633 2020-10-08T21:26:09  *** bitcoin-git has left #bitcoin-core-dev
634 2020-10-08T21:26:24  *** EagleTM has joined #bitcoin-core-dev
635 2020-10-08T21:27:01  *** rh0nj has quit IRC
636 2020-10-08T21:28:07  *** rh0nj has joined #bitcoin-core-dev
637 2020-10-08T21:44:30  *** justanotheruser has joined #bitcoin-core-dev
638 2020-10-08T21:45:47  *** EagleTM has quit IRC
639 2020-10-08T21:46:10  *** EagleTM has joined #bitcoin-core-dev
640 2020-10-08T21:49:12  *** EagleTM has quit IRC
641 2020-10-08T21:49:38  *** EagleTM has joined #bitcoin-core-dev
642 2020-10-08T21:50:29  *** worc3131 has joined #bitcoin-core-dev
643 2020-10-08T21:58:47  *** EagleTM has quit IRC
644 2020-10-08T21:59:12  *** EagleTM has joined #bitcoin-core-dev
645 2020-10-08T22:06:35  *** worc3131 has quit IRC
646 2020-10-08T22:11:03  *** vasild has quit IRC
647 2020-10-08T22:11:15  *** EagleTM has quit IRC
648 2020-10-08T22:11:28  *** vasild has joined #bitcoin-core-dev
649 2020-10-08T22:11:39  *** EagleTM has joined #bitcoin-core-dev
650 2020-10-08T22:14:56  *** EagleTM has quit IRC
651 2020-10-08T22:15:20  *** EagleTM has joined #bitcoin-core-dev
652 2020-10-08T22:22:50  *** EagleTM has quit IRC
653 2020-10-08T22:23:13  *** EagleTM has joined #bitcoin-core-dev
654 2020-10-08T22:26:15  *** EagleTM has quit IRC
655 2020-10-08T22:26:38  *** EagleTM has joined #bitcoin-core-dev
656 2020-10-08T22:30:39  *** rc_423 has quit IRC
657 2020-10-08T22:31:04  *** rc_423 has joined #bitcoin-core-dev
658 2020-10-08T22:34:17  *** EagleTM has quit IRC
659 2020-10-08T22:34:40  *** EagleTM has joined #bitcoin-core-dev
660 2020-10-08T22:59:09  *** S3RK has joined #bitcoin-core-dev
661 2020-10-08T23:03:25  *** S3RK has quit IRC
662 2020-10-08T23:04:33  *** EagleTM has quit IRC
663 2020-10-08T23:04:55  *** EagleTM has joined #bitcoin-core-dev
664 2020-10-08T23:09:27  *** provoostenator has quit IRC
665 2020-10-08T23:10:59  *** provoostenator has joined #bitcoin-core-dev
666 2020-10-08T23:24:03  *** davterra has quit IRC
667 2020-10-08T23:24:14  *** EagleTM has quit IRC
668 2020-10-08T23:52:25  *** mol_ has joined #bitcoin-core-dev
669 2020-10-08T23:55:04  *** mol has quit IRC