1 2020-10-09T00:00:01  *** dorena has quit IRC
  2 2020-10-09T00:00:24  *** DeanGuss has quit IRC
  3 2020-10-09T00:05:43  *** DeanGuss has joined #bitcoin-core-dev
  4 2020-10-09T00:10:49  *** davterra has joined #bitcoin-core-dev
  5 2020-10-09T00:16:16  *** AaronvanW has quit IRC
  6 2020-10-09T00:18:04  *** diogorsergio has quit IRC
  7 2020-10-09T00:18:30  *** proofofkeags_ has quit IRC
  8 2020-10-09T00:18:30  *** proofofkeags has quit IRC
  9 2020-10-09T00:21:03  *** Wolfy87 has joined #bitcoin-core-dev
 10 2020-10-09T00:21:57  *** molz_ has joined #bitcoin-core-dev
 11 2020-10-09T00:24:31  *** bjkkkk has joined #bitcoin-core-dev
 12 2020-10-09T00:25:24  *** mol_ has quit IRC
 13 2020-10-09T00:27:13  *** rc_423 has quit IRC
 14 2020-10-09T00:28:20  *** rc_423 has joined #bitcoin-core-dev
 15 2020-10-09T00:40:35  *** placa has joined #bitcoin-core-dev
 16 2020-10-09T00:44:40  *** bjkkkk has quit IRC
 17 2020-10-09T00:46:12  *** S3RK has joined #bitcoin-core-dev
 18 2020-10-09T00:53:40  *** AaronvanW has joined #bitcoin-core-dev
 19 2020-10-09T00:58:07  *** AaronvanW has quit IRC
 20 2020-10-09T01:01:49  *** S3RK has quit IRC
 21 2020-10-09T01:05:08  *** diogorsergio has joined #bitcoin-core-dev
 22 2020-10-09T01:11:54  *** nick108 has joined #bitcoin-core-dev
 23 2020-10-09T01:23:50  *** nick108 has quit IRC
 24 2020-10-09T01:25:28  *** sr_gi has quit IRC
 25 2020-10-09T01:26:07  *** sr_gi has joined #bitcoin-core-dev
 26 2020-10-09T01:26:28  *** pinheadmz has quit IRC
 27 2020-10-09T01:33:26  *** pinheadmz has joined #bitcoin-core-dev
 28 2020-10-09T01:53:22  *** pinheadmz has quit IRC
 29 2020-10-09T01:59:51  *** pinheadmz has joined #bitcoin-core-dev
 30 2020-10-09T02:07:46  *** proofofkeags_ has joined #bitcoin-core-dev
 31 2020-10-09T02:07:46  *** proofofkeags has joined #bitcoin-core-dev
 32 2020-10-09T02:09:58  *** AaronvanW has joined #bitcoin-core-dev
 33 2020-10-09T02:15:04  *** AaronvanW has quit IRC
 34 2020-10-09T02:21:47  *** pinheadmz has quit IRC
 35 2020-10-09T02:43:35  *** AaronvanW has joined #bitcoin-core-dev
 36 2020-10-09T02:47:47  *** AaronvanW has quit IRC
 37 2020-10-09T03:00:01  *** Wolfy87 has quit IRC
 38 2020-10-09T03:15:44  *** proofofkeags_ has quit IRC
 39 2020-10-09T03:15:44  *** proofofkeags has quit IRC
 40 2020-10-09T03:16:52  *** AaronvanW has joined #bitcoin-core-dev
 41 2020-10-09T03:20:59  *** AaronvanW has quit IRC
 42 2020-10-09T03:21:55  *** jpcw1 has joined #bitcoin-core-dev
 43 2020-10-09T03:28:04  <sipa> vasild: https://github.com/sipa/bitcoin/commits/202010_compactsize_bound
 44 2020-10-09T03:28:26  <sipa> use with Using<CompactSizeFormatter<false>>(obj) instead of COMPACTSIZE(obj)
 45 2020-10-09T03:51:57  *** AaronvanW has joined #bitcoin-core-dev
 46 2020-10-09T03:56:37  *** AaronvanW has quit IRC
 47 2020-10-09T04:17:51  *** S3RK has joined #bitcoin-core-dev
 48 2020-10-09T04:20:42  *** S3RK has quit IRC
 49 2020-10-09T04:22:25  *** S3RK has joined #bitcoin-core-dev
 50 2020-10-09T04:25:28  *** AaronvanW has joined #bitcoin-core-dev
 51 2020-10-09T04:27:15  *** S3RK has quit IRC
 52 2020-10-09T04:30:30  *** AaronvanW has quit IRC
 53 2020-10-09T04:56:02  *** S3RK has joined #bitcoin-core-dev
 54 2020-10-09T05:01:58  *** AaronvanW has joined #bitcoin-core-dev
 55 2020-10-09T05:03:05  *** mol_ has joined #bitcoin-core-dev
 56 2020-10-09T05:05:59  *** molz_ has quit IRC
 57 2020-10-09T05:06:05  *** AaronvanW has quit IRC
 58 2020-10-09T05:30:52  *** S3RK has quit IRC
 59 2020-10-09T05:33:21  <hebasto> sipa: re "it's a protection for the case where CompactSize format is used to actually encode a size" in which cases? (`MAX_SIZE = 0x02000000` seems undocumented in the code)
 60 2020-10-09T05:38:58  <hebasto> it was added with alert system in 401926283a200994ecd7df8eae8ced8e0b067c46
 61 2020-10-09T05:39:06  <hebasto> right?
 62 2020-10-09T05:42:24  *** AaronvanW has joined #bitcoin-core-dev
 63 2020-10-09T05:42:33  <hebasto> as alert system has been removed could we just revert back s/MAX_SIZE/INT_MAX/ ?
 64 2020-10-09T05:44:26  *** placa has quit IRC
 65 2020-10-09T05:47:08  *** AaronvanW has quit IRC
 66 2020-10-09T05:55:25  <sipa> hebasto: most satoshi commits were aggregates of a bunch of unrelated things
 67 2020-10-09T05:55:41  <sipa> MAX_SIZE is the maximum size of serialized objects, 32 MiB
 68 2020-10-09T05:56:22  <hebasto> I see. Thanks!
 69 2020-10-09T06:00:02  *** jpcw1 has quit IRC
 70 2020-10-09T06:00:39  <hebasto> sipa: do you think that `TxRequestTracker::CountCandidates` is really required to be a part of `TxRequestTracker` public interface?
 71 2020-10-09T06:02:03  *** kristapsk has quit IRC
 72 2020-10-09T06:03:36  <sipa> hebasto: it makes testing easier
 73 2020-10-09T06:03:45  <sipa> but apart from that, it's unneeded - for now at least
 74 2020-10-09T06:03:55  <sipa> it could be used as part of an overload check later
 75 2020-10-09T06:11:24  *** brianhoffman has quit IRC
 76 2020-10-09T06:11:30  *** brianhoffman_ has joined #bitcoin-core-dev
 77 2020-10-09T06:19:53  *** AaronvanW has joined #bitcoin-core-dev
 78 2020-10-09T06:22:09  *** BartK has joined #bitcoin-core-dev
 79 2020-10-09T06:24:10  *** AaronvanW has quit IRC
 80 2020-10-09T06:40:41  *** molz_ has joined #bitcoin-core-dev
 81 2020-10-09T06:43:59  *** mol_ has quit IRC
 82 2020-10-09T06:44:18  *** andreacab has joined #bitcoin-core-dev
 83 2020-10-09T06:44:58  *** S3RK has joined #bitcoin-core-dev
 84 2020-10-09T06:46:28  *** bitcoin-git has joined #bitcoin-core-dev
 85 2020-10-09T06:46:28  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d9de00b3e067...380705ef4f00
 86 2020-10-09T06:46:28  <bitcoin-git> bitcoin/master faf2999 MarcoFalke: cirrus: Use kvm to avoid spurious CI failures in the default virtualizatio...
 87 2020-10-09T06:46:29  <bitcoin-git> bitcoin/master 380705e MarcoFalke: Merge #20106: cirrus: Use kvm to avoid spurious CI failures in the default...
 88 2020-10-09T06:46:30  *** bitcoin-git has left #bitcoin-core-dev
 89 2020-10-09T06:46:48  *** bitcoin-git has joined #bitcoin-core-dev
 90 2020-10-09T06:46:48  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20106: cirrus: Use kvm to avoid spurious CI failures in the default virtualization cluster (master...2010-ciOtherVirt) https://github.com/bitcoin/bitcoin/pull/20106
 91 2020-10-09T06:46:49  *** bitcoin-git has left #bitcoin-core-dev
 92 2020-10-09T06:57:34  *** AaronvanW has joined #bitcoin-core-dev
 93 2020-10-09T06:59:13  *** jonatack has quit IRC
 94 2020-10-09T07:01:56  *** AaronvanW has quit IRC
 95 2020-10-09T07:14:52  *** bitcoin-git has joined #bitcoin-core-dev
 96 2020-10-09T07:14:53  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #20103: test: Enable mocktime RPC for all test chains (master...2010-testMockAllChains) https://github.com/bitcoin/bitcoin/pull/20103
 97 2020-10-09T07:14:53  <vasild> hi
 98 2020-10-09T07:15:01  *** bitcoin-git has left #bitcoin-core-dev
 99 2020-10-09T07:17:08  *** bitcoin-git has joined #bitcoin-core-dev
100 2020-10-09T07:17:08  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20112: test: Speed up wallet_resendwallettransactions with mockscheduler RPC (master...2010-testFasterMock) https://github.com/bitcoin/bitcoin/pull/20112
101 2020-10-09T07:17:09  *** bitcoin-git has left #bitcoin-core-dev
102 2020-10-09T07:18:10  <sipa> vasild: morning
103 2020-10-09T07:18:31  <vasild> evening :)
104 2020-10-09T07:18:33  <vasild> (for you)
105 2020-10-09T07:19:23  <vasild> is it on purpose that WriteCompactSize() can write big numbers, but ReadCompactSize() cannot read them?
106 2020-10-09T07:22:12  <sipa> vasild: i think in the compactsize-is-only-for-sizes setting we used to have, the issue just didn't occur
107 2020-10-09T07:22:32  <sipa> as it's not possible to have such a big object to begin with
108 2020-10-09T07:22:54  <vasild> yeah, so writecompactsize was never called with big numbers
109 2020-10-09T07:23:02  <sipa> indeed
110 2020-10-09T07:23:17  <sipa> (and the usage in bip152 is restricted to 16-bit numbers, which obviously won't have any problems)
111 2020-10-09T07:23:22  <vasild> I will steal that commit https://github.com/sipa/bitcoin/commit/6edfab492aa67e421af556728c1b8b4d17826b80
112 2020-10-09T07:27:34  <vasild> I am just curous - any idea what are those high service flags 0x800043d and 0x800000d that cannot be a result of bitwise-or-ing NODE_* flags?
113 2020-10-09T07:27:59  <vasild> of course any peer is free to claim whatever they want in their service flags, including 0xfffff...
114 2020-10-09T07:28:14  <sipa> some high bits are used for private extensions
115 2020-10-09T07:28:18  <sipa> not sure what this is
116 2020-10-09T07:28:41  <vasild> ok
117 2020-10-09T07:29:07  <hebasto> sipa: good idea to rename CompactSize
118 2020-10-09T07:29:26  <sipa> vasild: what software/user agent reports these?
119 2020-10-09T07:29:58  <vasild> I did not record that
120 2020-10-09T07:30:30  <vasild> just added printf() in CAddress::unserialize to see what is coming in from the network
121 2020-10-09T07:32:25  *** AaronvanW has joined #bitcoin-core-dev
122 2020-10-09T07:34:50  <vasild> now I did -addnode= to see the user agent
123 2020-10-09T07:34:59  <sipa> they're uninteresting
124 2020-10-09T07:35:06  <sipa> my dns seed crawler sees them too
125 2020-10-09T07:35:20  <sipa> but they're from a variaety of innocently-loking user agents
126 2020-10-09T07:35:32  <vasild> but now getnetworkinfo shows
127 2020-10-09T07:35:36  <vasild>     "addr": "",
128 2020-10-09T07:35:40  <vasild>     "services": "000000000000040d",
129 2020-10-09T07:35:44  <vasild> :-O
130 2020-10-09T07:35:47  <sipa> hmm
131 2020-10-09T07:35:50  *** jonatack has joined #bitcoin-core-dev
132 2020-10-09T07:35:57  <vasild> yeah, and innocent     "subver": "/Satoshi:0.20.1/",
133 2020-10-09T07:36:06  <sipa> are they being rumoured with this bit set... but then not reported in the version message?
134 2020-10-09T07:36:59  <hebasto> could this hurt the network?
135 2020-10-09T07:37:00  *** AaronvanW has quit IRC
136 2020-10-09T07:38:11  <vasild> sipa: must be that or something else I am missing
137 2020-10-09T07:38:14  <sipa> i don't think so
138 2020-10-09T07:38:15  <vasild> I just saw:
139 2020-10-09T07:38:16  <vasild> CAddress::unser: time=1602210665, services=67109901, addr=
140 2020-10-09T07:38:19  <vasild> from my printf
141 2020-10-09T07:38:40  <vasild> shutdown, restart with -addnode=
142 2020-10-09T07:38:56  <vasild> and getpeerinfo:     "addr": "",
143 2020-10-09T07:39:00  <vasild>     "services": "000000000000000d",
144 2020-10-09T07:40:10  <vasild> we don't do any "filter away any unknown service bits before displaying in getpeerinfo, right?
145 2020-10-09T07:41:02  *** Pavlenex has joined #bitcoin-core-dev
146 2020-10-09T07:41:26  <sipa> vasild: i don't think so
147 2020-10-09T07:43:23  <vasild> just for reference, here is my dummy printf() in CAddress unserialize: https://bpa.st/JYYA
148 2020-10-09T07:45:45  <sipa> looks right
149 2020-10-09T07:48:28  <vasild> ok, assuming they get gossiped with the flags but are later not present in the version message when we actually connect
150 2020-10-09T07:49:26  <sipa> perhaps some broken software is relaying them with that bit set
151 2020-10-09T07:50:04  <vasild> wumpus: just to confirm - yes, 0.20 would start on a 0.21-modified-peers.dat as if that file was not present, I also think it is ok. Except the obscure/scary deserialize error messages
152 2020-10-09T07:50:51  <sipa> perhaps we can give a nicer error message in the future for upgrades
153 2020-10-09T07:50:56  <sipa> but for old software it's too late
154 2020-10-09T07:50:57  <vasild> given I will be modifying #19954 I will add one line at the start of unserialize to check if the version is too high
155 2020-10-09T07:51:00  <gribble> https://github.com/bitcoin/bitcoin/issues/19954 | tor: complete the TORv3 implementation by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
156 2020-10-09T07:51:02  <vasild> exactly
157 2020-10-09T07:51:59  <vasild> and print something like "detected file format of peers.dat from the future: 4, I can only understand up to 3, starting operation as if peers.dat is empty"
158 2020-10-09T07:52:40  <hebasto> sipa: if their software is broken should we discourage those peers?
159 2020-10-09T07:54:45  *** S3RK has quit IRC
160 2020-10-09T07:55:21  *** andreacab has quit IRC
161 2020-10-09T07:55:27  <vasild> maybe a honest/legit/unbroken peer is just relaying some shi^H^Hstuff that was given to him by a broken/malicious guy
162 2020-10-09T07:55:47  *** andreacab has joined #bitcoin-core-dev
163 2020-10-09T07:56:01  <vasild> we don't want to flag the legit peer as misbehaving
164 2020-10-09T07:56:07  <hebasto> right
165 2020-10-09T07:56:40  *** andreacab has quit IRC
166 2020-10-09T07:56:45  <vasild> or also those high service bits could have some purpose, I guess, it is not certain that they are due to broken or malicious software
167 2020-10-09T07:56:48  *** andreacab has joined #bitcoin-core-dev
168 2020-10-09T07:57:17  * hebasto "hidden service" :D
169 2020-10-09T07:58:01  <vasild> did somebody develop a decentralized instant message chat application using bitcoin p2p network, sneaking the data via the service bits?
170 2020-10-09T07:59:07  <MarcoFalke> it would be good to log the peer that sent the high bits
171 2020-10-09T07:59:24  <sipa> MarcoFalke: unfortunately, they're most likely not the ones who introduced it
172 2020-10-09T08:00:39  <vasild> what happens if a node receives via gossip the same address:port but with different service bits?
173 2020-10-09T08:01:01  <MarcoFalke> does addrman correct the service bits when a version msg is received?
174 2020-10-09T08:01:14  <vasild> that too!
175 2020-10-09T08:01:34  <sipa> they get OR'ed together
176 2020-10-09T08:01:43  <sipa> but i hope that on an actual connection, it's overwritten
177 2020-10-09T08:02:06  *** Pavlenex has quit IRC
178 2020-10-09T08:02:46  <vasild> they get OR'ed :( so a node cannot correct his by re-advertising it regularly. Once somebody adds some high bits to his addr:port, it is over.
179 2020-10-09T08:02:57  <sipa> we should fix that
180 2020-10-09T08:03:09  <sipa> whatever we receive from the node itself should be written exactly into addrman
181 2020-10-09T08:03:12  <vasild> change to "newer one overwrites old one"?
182 2020-10-09T08:03:28  <sipa> i think OR'ing makes sense for rumoured addr messages
183 2020-10-09T08:04:02  <vasild> I agree that if we connect directly then whatever the peer says is to overwrite the other stuff
184 2020-10-09T08:04:10  <sipa> but if we receive information from the IP itself (on an outgoing connection), it should overwrite
185 2020-10-09T08:04:38  *** AaronvanW has joined #bitcoin-core-dev
186 2020-10-09T08:04:38  *** S3RK has joined #bitcoin-core-dev
187 2020-10-09T08:09:09  *** AaronvanW has quit IRC
188 2020-10-09T08:13:13  <jonatack> catching up with the discussion... yes, the issue I reported is the DB:deserialise error messages and peers.dat being recreated; bitcoind operates fine otherwise. We can't fix the older software, but we can communicate the situation clearly to users (and hopefully fix it henceforth).
189 2020-10-09T08:16:35  <wumpus> sipa: it's more of a warning message anyway isn't it, people that don't regaularly check the log won't even notice it
190 2020-10-09T08:16:51  <wumpus> vasild: thanks for confirming, I think there's no problem in that case at all
191 2020-10-09T08:17:39  <wumpus> if you say "error" I was expecting some kind of emergency shutdown, that *would* be scary, it simply saying that it's unable to load the file and start from scratch isn't scary as such
192 2020-10-09T08:18:32  <vasild> y
193 2020-10-09T08:18:36  <jonatack> well, anyone who greps the past log for errors will see
194 2020-10-09T08:18:37  <jonatack> ERROR: DeserializeDB: Deserialize or I/O error - ReadCompactSize(): size too large: iostream error
195 2020-10-09T08:18:53  <jonatack> Invalid or missing peers.dat; recreating
196 2020-10-09T08:19:00  <wumpus> yes
197 2020-10-09T08:19:09  <vasild> I though jonatack's disk has developed bad sectors :-D
198 2020-10-09T08:19:20  <jonatack> that allcaps screaming ERROR is a bit worrisome :D
199 2020-10-09T08:19:21  <vasild> thought
200 2020-10-09T08:19:24  <wumpus> I agree it could have been avoided with a version marker
201 2020-10-09T08:20:16  <wumpus> jonatack: that's nothing, those errors used to appear for malformed incoming *network packets*
202 2020-10-09T08:20:21  <wumpus> ERRORS i mean
203 2020-10-09T08:21:07  <wumpus> debug.log used to be one big file full of screaming :)
204 2020-10-09T08:21:16  <jonatack> hehe
205 2020-10-09T08:21:39  <jonatack> the halloween release
206 2020-10-09T08:22:40  <wumpus> change the bitcoin logo for a 🎃
207 2020-10-09T08:23:28  *** Pavlenex has joined #bitcoin-core-dev
208 2020-10-09T08:23:30  <jonatack> fewer color change proposals :)
209 2020-10-09T08:25:32  <fanquake> orange.bikeshed.com
210 2020-10-09T08:32:49  *** worc3131 has joined #bitcoin-core-dev
211 2020-10-09T08:39:06  *** andreacab has quit IRC
212 2020-10-09T08:39:33  *** andreacab has joined #bitcoin-core-dev
213 2020-10-09T08:42:58  *** AaronvanW has joined #bitcoin-core-dev
214 2020-10-09T08:43:06  *** Klox048093 has joined #bitcoin-core-dev
215 2020-10-09T08:43:06  *** worc3131 has quit IRC
216 2020-10-09T08:44:04  *** Klox04809 has quit IRC
217 2020-10-09T08:47:34  *** AaronvanW has quit IRC
218 2020-10-09T08:49:25  *** andreacab has quit IRC
219 2020-10-09T08:55:26  *** andreacab has joined #bitcoin-core-dev
220 2020-10-09T08:55:55  *** andreaca_ has joined #bitcoin-core-dev
221 2020-10-09T09:00:02  *** BartK has quit IRC
222 2020-10-09T09:00:40  *** AaronvanW has joined #bitcoin-core-dev
223 2020-10-09T09:03:47  <vasild> jonatack: https://github.com/bitcoin/bitcoin/pull/19954#discussion_r502280047 "I test if my suggestions compile before making them"... and I did not test that it does not compile before I replied :-/
224 2020-10-09T09:04:14  <vasild> I guess it compiles because stream is a pointer which remains unmodified (the pointer itself) after the call to stream->ignore()
225 2020-10-09T09:04:25  *** kexkey has quit IRC
226 2020-10-09T09:04:58  <vasild> but anyway, semantically we do modify the state of the stream by the ignore() call, so I dont think it should be tagged with const
227 2020-10-09T09:06:14  *** andreaca_ has quit IRC
228 2020-10-09T09:06:40  *** andreacab has joined #bitcoin-core-dev
229 2020-10-09T09:08:04  *** andreaca_ has joined #bitcoin-core-dev
230 2020-10-09T09:10:47  *** andreacab has quit IRC
231 2020-10-09T09:21:05  *** tw1sted1 has joined #bitcoin-core-dev
232 2020-10-09T09:22:35  *** andreaca_ has quit IRC
233 2020-10-09T09:24:20  *** andreacab has joined #bitcoin-core-dev
234 2020-10-09T09:26:38  *** andreacab has quit IRC
235 2020-10-09T09:27:06  *** andreacab has joined #bitcoin-core-dev
236 2020-10-09T09:27:13  *** mrostecki has joined #bitcoin-core-dev
237 2020-10-09T09:29:23  *** Pavlenex has quit IRC
238 2020-10-09T09:31:23  *** andreacab has quit IRC
239 2020-10-09T09:33:18  <jonatack> vasild: no worries, it's an edge case question, was just to learn
240 2020-10-09T09:35:39  <vasild> jonatack: my reasoning is "if a method changes the object in a way that can be observed from outside, then it should not be const"
241 2020-10-09T09:37:20  *** AaronvanW has quit IRC
242 2020-10-09T09:37:38  *** AaronvanW has joined #bitcoin-core-dev
243 2020-10-09T09:39:18  *** andreacab has joined #bitcoin-core-dev
244 2020-10-09T09:39:59  <jonatack> right. looking at it led me to https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#con2-by-default-make-member-functions-const and http://www.cplusplus.com/forum/general/12087/
245 2020-10-09T09:40:07  <jonatack> am re-reviewing 19954
246 2020-10-09T09:44:57  *** mrostecki has quit IRC
247 2020-10-09T09:46:45  *** sr_gi has quit IRC
248 2020-10-09T09:47:32  *** sr_gi has joined #bitcoin-core-dev
249 2020-10-09T09:52:14  *** tw1sted1 has quit IRC
250 2020-10-09T10:00:11  <jonatack> vasild: nice, in my testing the patch has fixed the DB deserialize errors and peers.dat messages
251 2020-10-09T10:01:11  <vasild> \o/
252 2020-10-09T10:03:07  *** bitcoin-git has joined #bitcoin-core-dev
253 2020-10-09T10:03:07  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/380705ef4f00...6854dbdc88d7
254 2020-10-09T10:03:08  <bitcoin-git> bitcoin/master 2dc79c4 Hennadii Stepanov: doc: Update and improve files.md
255 2020-10-09T10:03:08  <bitcoin-git> bitcoin/master 6854dbd fanquake: Merge #20076: doc: Update and improve files.md
256 2020-10-09T10:03:19  *** bitcoin-git has left #bitcoin-core-dev
257 2020-10-09T10:03:36  *** bitcoin-git has joined #bitcoin-core-dev
258 2020-10-09T10:03:37  <bitcoin-git> [bitcoin] fanquake merged pull request #20076: doc: Update and improve files.md (master...201004-files) https://github.com/bitcoin/bitcoin/pull/20076
259 2020-10-09T10:03:48  *** bitcoin-git has left #bitcoin-core-dev
260 2020-10-09T10:05:41  *** belcher_ has joined #bitcoin-core-dev
261 2020-10-09T10:05:53  <jonatack> vasild: restarting on, say, 0.18.1, I see "ERROR: DeserializeDB: Deserialize or I/O error - CAutoFile::read: end of file: iostream error" and "Invalid or missing peers.dat; recreating", as we mention in the new release notes, but not on 19954 after `cp onion_private_key onion_v3_private_key`
262 2020-10-09T10:06:26  <jonatack> \o/ indeed :)
263 2020-10-09T10:08:07  *** belcher has quit IRC
264 2020-10-09T10:08:41  *** bitcoin-git has joined #bitcoin-core-dev
265 2020-10-09T10:08:42  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6854dbdc88d7...12a1c3ad1a43
266 2020-10-09T10:08:43  <bitcoin-git> bitcoin/master 99992e7 MarcoFalke: doc: Collect release-notes snippets
267 2020-10-09T10:08:43  <bitcoin-git> bitcoin/master faa0847 MarcoFalke: doc: Add release notes for #20101
268 2020-10-09T10:08:44  <bitcoin-git> bitcoin/master 12a1c3a fanquake: Merge #20107: doc: Collect release-notes snippets
269 2020-10-09T10:08:45  *** bitcoin-git has left #bitcoin-core-dev
270 2020-10-09T10:09:01  *** bitcoin-git has joined #bitcoin-core-dev
271 2020-10-09T10:09:02  <bitcoin-git> [bitcoin] fanquake merged pull request #20107: doc: Collect release-notes snippets (master...2010-docRelSnip) https://github.com/bitcoin/bitcoin/pull/20107
272 2020-10-09T10:09:03  *** bitcoin-git has left #bitcoin-core-dev
273 2020-10-09T10:10:23  *** vasild has quit IRC
274 2020-10-09T10:12:21  *** vasild has joined #bitcoin-core-dev
275 2020-10-09T10:13:48  *** shesek has quit IRC
276 2020-10-09T10:18:29  *** Imogene64Boyer has joined #bitcoin-core-dev
277 2020-10-09T10:20:36  *** andreacab has quit IRC
278 2020-10-09T10:21:04  *** andreacab has joined #bitcoin-core-dev
279 2020-10-09T10:25:37  *** andreacab has quit IRC
280 2020-10-09T10:27:39  *** ericholscher has joined #bitcoin-core-dev
281 2020-10-09T10:28:04  *** promag has joined #bitcoin-core-dev
282 2020-10-09T10:44:14  *** promag has quit IRC
283 2020-10-09T10:45:46  *** Imogene64Boyer has quit IRC
284 2020-10-09T10:45:58  *** promag has joined #bitcoin-core-dev
285 2020-10-09T10:46:00  *** andreacab has joined #bitcoin-core-dev
286 2020-10-09T10:49:33  *** andreacab has quit IRC
287 2020-10-09T10:49:59  *** andreacab has joined #bitcoin-core-dev
288 2020-10-09T10:55:02  *** mrostecki has joined #bitcoin-core-dev
289 2020-10-09T10:56:56  *** andreacab has quit IRC
290 2020-10-09T10:58:41  *** andreacab has joined #bitcoin-core-dev
291 2020-10-09T11:02:25  *** kyoo[m] has quit IRC
292 2020-10-09T11:02:27  *** TheFuzzStone[m] has quit IRC
293 2020-10-09T11:02:34  *** sethrogers23[m] has quit IRC
294 2020-10-09T11:02:36  *** tianshi[m] has quit IRC
295 2020-10-09T11:02:46  *** rcrtn32002[m] has quit IRC
296 2020-10-09T11:02:46  *** snowkeld[m] has quit IRC
297 2020-10-09T11:02:49  *** RaphalBentgeac[m has quit IRC
298 2020-10-09T11:02:50  *** Pasta[m] has quit IRC
299 2020-10-09T11:02:51  *** icota[m] has quit IRC
300 2020-10-09T11:06:01  *** rh0nj has quit IRC
301 2020-10-09T11:07:09  *** rh0nj has joined #bitcoin-core-dev
302 2020-10-09T11:09:35  *** kristapsk has joined #bitcoin-core-dev
303 2020-10-09T11:09:45  *** rcrtn32002[m] has joined #bitcoin-core-dev
304 2020-10-09T11:12:43  *** TallTim has quit IRC
305 2020-10-09T11:22:38  *** andreacab has quit IRC
306 2020-10-09T11:23:04  *** andreacab has joined #bitcoin-core-dev
307 2020-10-09T11:26:51  *** snowkeld[m] has joined #bitcoin-core-dev
308 2020-10-09T11:26:51  *** TheFuzzStone[m] has joined #bitcoin-core-dev
309 2020-10-09T11:26:52  *** icota[m] has joined #bitcoin-core-dev
310 2020-10-09T11:26:52  *** Pasta[m] has joined #bitcoin-core-dev
311 2020-10-09T11:26:52  *** kyoo[m] has joined #bitcoin-core-dev
312 2020-10-09T11:26:52  *** sethrogers23[m] has joined #bitcoin-core-dev
313 2020-10-09T11:26:58  *** tianshi[m] has joined #bitcoin-core-dev
314 2020-10-09T11:26:58  *** RaphalBentgeac[m has joined #bitcoin-core-dev
315 2020-10-09T11:27:07  *** andreacab has quit IRC
316 2020-10-09T11:27:14  *** vincenzopalazzo has joined #bitcoin-core-dev
317 2020-10-09T11:30:52  *** jonatack has quit IRC
318 2020-10-09T11:32:37  *** andreacab has joined #bitcoin-core-dev
319 2020-10-09T11:34:00  *** opsec_x122 has joined #bitcoin-core-dev
320 2020-10-09T11:34:26  *** ericholscher has quit IRC
321 2020-10-09T11:34:26  *** jeremyrubin has quit IRC
322 2020-10-09T11:34:26  *** opsec_x12 has quit IRC
323 2020-10-09T11:34:26  *** dergoegge has quit IRC
324 2020-10-09T11:34:26  *** hsmiths has quit IRC
325 2020-10-09T11:34:26  *** mariorz has quit IRC
326 2020-10-09T11:34:26  *** noganoo has quit IRC
327 2020-10-09T11:36:53  *** EagleTM has joined #bitcoin-core-dev
328 2020-10-09T11:39:55  *** EagleTM has quit IRC
329 2020-10-09T11:40:12  *** jeremyrubin has joined #bitcoin-core-dev
330 2020-10-09T11:40:13  *** dergoegge has joined #bitcoin-core-dev
331 2020-10-09T11:40:13  *** hsmiths has joined #bitcoin-core-dev
332 2020-10-09T11:40:13  *** mariorz has joined #bitcoin-core-dev
333 2020-10-09T11:40:13  *** noganoo has joined #bitcoin-core-dev
334 2020-10-09T11:40:25  *** EagleTM has joined #bitcoin-core-dev
335 2020-10-09T11:40:54  *** S3RK has quit IRC
336 2020-10-09T11:41:49  *** S3RK has joined #bitcoin-core-dev
337 2020-10-09T11:42:38  *** opsec_x122 is now known as opsec_x12
338 2020-10-09T11:44:17  *** andreacab has quit IRC
339 2020-10-09T11:46:05  *** S3RK has quit IRC
340 2020-10-09T11:46:54  *** promag has quit IRC
341 2020-10-09T11:47:50  *** promag has joined #bitcoin-core-dev
342 2020-10-09T11:49:06  *** EagleTM has quit IRC
343 2020-10-09T11:49:32  *** EagleTM has joined #bitcoin-core-dev
344 2020-10-09T11:52:05  *** promag has quit IRC
345 2020-10-09T11:52:34  *** EagleTM has quit IRC
346 2020-10-09T11:52:58  *** EagleTM has joined #bitcoin-core-dev
347 2020-10-09T11:53:23  *** mrostecki has quit IRC
348 2020-10-09T11:57:15  *** EagleTM has quit IRC
349 2020-10-09T11:57:38  *** EagleTM has joined #bitcoin-core-dev
350 2020-10-09T11:59:56  *** Victorsueca has joined #bitcoin-core-dev
351 2020-10-09T12:03:09  *** EagleTM has quit IRC
352 2020-10-09T12:03:33  *** EagleTM has joined #bitcoin-core-dev
353 2020-10-09T12:21:05  *** dholbach has joined #bitcoin-core-dev
354 2020-10-09T12:21:41  *** pinheadmz has joined #bitcoin-core-dev
355 2020-10-09T12:26:24  *** setpill has joined #bitcoin-core-dev
356 2020-10-09T12:26:51  *** promag has joined #bitcoin-core-dev
357 2020-10-09T12:27:26  *** EagleTM has quit IRC
358 2020-10-09T12:27:48  *** EagleTM has joined #bitcoin-core-dev
359 2020-10-09T12:31:05  *** promag has quit IRC
360 2020-10-09T12:33:07  *** jonatack has joined #bitcoin-core-dev
361 2020-10-09T12:36:07  *** EagleTM has quit IRC
362 2020-10-09T12:36:33  *** EagleTM has joined #bitcoin-core-dev
363 2020-10-09T12:37:40  *** Guyver2 has joined #bitcoin-core-dev
364 2020-10-09T12:40:01  *** EagleTM has quit IRC
365 2020-10-09T12:40:28  *** EagleTM has joined #bitcoin-core-dev
366 2020-10-09T12:45:28  *** gloriazhao has quit IRC
367 2020-10-09T12:49:08  *** S3RK has joined #bitcoin-core-dev
368 2020-10-09T12:53:23  *** S3RK has quit IRC
369 2020-10-09T12:54:11  *** EagleTM has quit IRC
370 2020-10-09T12:54:38  *** EagleTM has joined #bitcoin-core-dev
371 2020-10-09T12:59:52  *** EagleTM has quit IRC
372 2020-10-09T13:00:15  *** EagleTM has joined #bitcoin-core-dev
373 2020-10-09T13:07:12  *** molz_ has quit IRC
374 2020-10-09T13:09:12  <achow101> #proposedwalletmeetingtopic: wallet.dat vs wallet.sqlite
375 2020-10-09T13:11:25  *** Eagle[TM] has joined #bitcoin-core-dev
376 2020-10-09T13:11:59  *** EagleTM has quit IRC
377 2020-10-09T13:16:11  *** Eagle[TM] has quit IRC
378 2020-10-09T13:18:15  *** mol has joined #bitcoin-core-dev
379 2020-10-09T13:30:16  *** S3RK has joined #bitcoin-core-dev
380 2020-10-09T13:34:50  *** Klox0480931 has joined #bitcoin-core-dev
381 2020-10-09T13:35:10  *** S3RK has quit IRC
382 2020-10-09T13:35:34  *** Klox048093 has quit IRC
383 2020-10-09T13:36:33  <hebasto> gh silently fails to "Load more..." of "52 hidden items" on #19988 (
384 2020-10-09T13:36:37  <gribble> https://github.com/bitcoin/bitcoin/issues/19988 | Overhaul transaction request logic by sipa · Pull Request #19988 · bitcoin/bitcoin · GitHub
385 2020-10-09T14:01:46  *** setpill has quit IRC
386 2020-10-09T14:01:58  *** mol_ has joined #bitcoin-core-dev
387 2020-10-09T14:05:27  *** mol has quit IRC
388 2020-10-09T14:06:20  *** molz_ has joined #bitcoin-core-dev
389 2020-10-09T14:07:58  *** mol has joined #bitcoin-core-dev
390 2020-10-09T14:09:19  *** mol_ has quit IRC
391 2020-10-09T14:11:16  *** molz_ has quit IRC
392 2020-10-09T14:29:34  <jonatack> hebasto: saw the same yesterday, i gave up trying to see the discussion :/
393 2020-10-09T14:36:57  *** andreacab has joined #bitcoin-core-dev
394 2020-10-09T14:37:39  *** luke-jr has quit IRC
395 2020-10-09T14:39:55  *** luke-jr has joined #bitcoin-core-dev
396 2020-10-09T14:40:27  *** andreacab has quit IRC
397 2020-10-09T14:40:43  *** andreacab has joined #bitcoin-core-dev
398 2020-10-09T15:00:02  *** dholbach has quit IRC
399 2020-10-09T15:01:33  *** kexkey has joined #bitcoin-core-dev
400 2020-10-09T15:03:13  *** andreacab has quit IRC
401 2020-10-09T15:03:39  *** andreacab has joined #bitcoin-core-dev
402 2020-10-09T15:05:20  *** andreaca_ has joined #bitcoin-core-dev
403 2020-10-09T15:06:09  *** jonatack has quit IRC
404 2020-10-09T15:07:11  *** Talkless has joined #bitcoin-core-dev
405 2020-10-09T15:07:58  *** andreacab has quit IRC
406 2020-10-09T15:10:55  *** luke-jr has quit IRC
407 2020-10-09T15:10:57  <vasild> gh censorship!
408 2020-10-09T15:11:14  *** jonatack has joined #bitcoin-core-dev
409 2020-10-09T15:12:20  *** kristapsk has quit IRC
410 2020-10-09T15:18:03  <michaelfolkson> I don't see how Core is still managed on GitHub in 10 years personally. But will be a massive headache whenever it does move. Ideally done when things are quiet (not with a potential soft fork on the horizon)
411 2020-10-09T15:19:00  *** luke-jr has joined #bitcoin-core-dev
412 2020-10-09T15:25:25  *** luke-jr has quit IRC
413 2020-10-09T15:26:49  *** luke-jr has joined #bitcoin-core-dev
414 2020-10-09T15:33:58  <jonatack> ISTM that GitHub is now starting to hide ACKs and re-ACKs as "one similar comment"
415 2020-10-09T15:38:13  *** owowo has quit IRC
416 2020-10-09T15:39:10  *** owowo has joined #bitcoin-core-dev
417 2020-10-09T15:39:48  *** andreaca_ has quit IRC
418 2020-10-09T15:40:16  *** andreacab has joined #bitcoin-core-dev
419 2020-10-09T15:43:58  *** Talkless has quit IRC
420 2020-10-09T15:44:29  *** Talkless has joined #bitcoin-core-dev
421 2020-10-09T15:44:42  *** andreacab has quit IRC
422 2020-10-09T15:49:45  *** Pavlenex has joined #bitcoin-core-dev
423 2020-10-09T15:55:56  *** kers has joined #bitcoin-core-dev
424 2020-10-09T15:56:23  *** vincenzopalazzo has quit IRC
425 2020-10-09T15:59:51  <wumpus> I'm not sure moving is that much of a headache, many projects have done this, it's just that the only thing after github that makes sense is self-hosting something like gitlab or gitea, which has quite a lot issues of its own, e.g. who hosts the instance
426 2020-10-09T16:02:17  <wumpus> I have a weird issue on my freebsd node: it kept making outgoing connections at a rate of ~2 per second, the whole log is full of it, and it wasn't accepting any new blocks. I hope it's not a problem with the TorV3 PR.
427 2020-10-09T16:03:07  *** luke-jr has quit IRC
428 2020-10-09T16:03:12  <wumpus> also, it segfaulted on shutdown (I can't reproduce this, unfortunately, so don't have a traceback)
429 2020-10-09T16:03:15  *** proofofkeags_ has joined #bitcoin-core-dev
430 2020-10-09T16:03:15  *** proofofkeags has joined #bitcoin-core-dev
431 2020-10-09T16:03:53  *** Talkless has quit IRC
432 2020-10-09T16:06:24  *** luke-jr has joined #bitcoin-core-dev
433 2020-10-09T16:09:15  *** mol_ has joined #bitcoin-core-dev
434 2020-10-09T16:10:20  *** mol has quit IRC
435 2020-10-09T16:12:46  <sipa> wumpus: ugh
436 2020-10-09T16:14:00  <wumpus> 2020-10-09T15:06:40Z New outbound peer connected: version: 70015, blocks=651964, peer=1018923 (full-relay)
437 2020-10-09T16:14:20  <wumpus> that peer id says enough I think
438 2020-10-09T16:15:50  <jonatack> wumpus: huh. i have not been seeing that issue with 19954 (on debian)
439 2020-10-09T16:15:54  <wumpus> it's not happening on my other TorV3 node though so there's no clear correlation
440 2020-10-09T16:16:19  <wumpus> jonatack: right, it might be a local issue for that node
441 2020-10-09T16:16:28  <wumpus> currently building plain master
442 2020-10-09T16:19:25  *** luke-jr has quit IRC
443 2020-10-09T16:24:10  *** S3RK has joined #bitcoin-core-dev
444 2020-10-09T16:25:52  *** luke-jr has joined #bitcoin-core-dev
445 2020-10-09T16:28:37  *** S3RK has quit IRC
446 2020-10-09T16:31:28  *** roconnor has joined #bitcoin-core-dev
447 2020-10-09T16:32:53  <luke-jr> wumpus: I'm not sure self-hosting is really an improvement over GitHub, aside from the platform presumably being free software
448 2020-10-09T16:33:08  <luke-jr> the goal is probably a decentralised system, but that doesn't exist yet afaik
449 2020-10-09T16:34:13  <vasild> there were some attempts to make decentralized alternative of github
450 2020-10-09T16:34:20  <wumpus> luke-jr: it's an improvement in that we'd have direct control over the software, so it can't say, start hiding consecutive ACKs behind our back
451 2020-10-09T16:34:29  <vasild> wumpus: I have this sysctl on fbsd: kern.corefile=/coredumps/%U.%N.%P.core
452 2020-10-09T16:35:02  <wumpus> vasild: good idea
453 2020-10-09T16:35:21  <vasild> and /coredumps has 1777 perms so that anybody can plant files in it
454 2020-10-09T16:35:26  <luke-jr> wumpus: whoever is hosting can, whether that's GitHub or ⁇?
455 2020-10-09T16:35:59  <wumpus> luke-jr: sure, but if it's one of us they're likely going to be more recentive to these kind of complaints than a big corporation
456 2020-10-09T16:36:06  <vasild> ulimit -c is "unlimited" but I don't think I configured that myself, maybe it is the default
457 2020-10-09T16:36:11  *** shesek has joined #bitcoin-core-dev
458 2020-10-09T16:36:11  *** shesek has joined #bitcoin-core-dev
459 2020-10-09T16:37:21  <wumpus> same here, it even said in dmesg that it had dumped core but couldn't find the core file
460 2020-10-09T16:37:42  <sipa> it dumped Core
461 2020-10-09T16:37:52  <luke-jr> they tend to be big files
462 2020-10-09T16:38:09  <vasild> does bitcoind change the working directory at startup? to ~/.bitcoin? or to the root /?
463 2020-10-09T16:38:10  <wumpus> sipa: heh
464 2020-10-09T16:38:23  <wumpus> vasild: no, it doesn't
465 2020-10-09T16:38:41  <wumpus> thinking of it, probably daemonize() does though
466 2020-10-09T16:38:48  <vasild> so the core should probably in the current directory where you started it
467 2020-10-09T16:38:54  <luke-jr> I know Linux is capable of dumping core into a gdb process directly
468 2020-10-09T16:39:55  <wumpus> yes, daemon() changes the working directory to /, it has no write access there, so I guess it just lost it
469 2020-10-09T16:43:46  <wumpus> I've set vasild's sysctl parameter now so next time it should go to /coredumps/
470 2020-10-09T16:44:41  <vasild> mkdir /coredumps && chmod 1777 /coredumps
471 2020-10-09T16:45:08  <sipa> comic relief: https://twitter.com/real_or_random/status/1314596135395262467
472 2020-10-09T16:45:16  <vasild> remember to rm /coredumps/* periodically because it grows and grows over time ;)
473 2020-10-09T16:46:32  *** andreacab has joined #bitcoin-core-dev
474 2020-10-09T16:47:36  *** EagleTM has joined #bitcoin-core-dev
475 2020-10-09T16:47:37  <vasild> wumpus: but if dmesg says something like "pid 94776 (conftest), jid 0, uid 0: exited on signal 11 (core dumped)
476 2020-10-09T16:47:55  <vasild> with "(core dumped)" at the end then it must be somewhere
477 2020-10-09T16:49:37  *** andreacab has quit IRC
478 2020-10-09T16:50:03  *** andreacab has joined #bitcoin-core-dev
479 2020-10-09T16:52:59  *** EagleTM has quit IRC
480 2020-10-09T16:53:07  <wumpus> vasild: I couldn't find it at least, but, I 'make clean'ed so deleted the binary by now so I guess there's no point even if I still found it
481 2020-10-09T16:53:25  *** EagleTM has joined #bitcoin-core-dev
482 2020-10-09T16:53:33  *** cryptapus has quit IRC
483 2020-10-09T16:54:21  <luke-jr> hmm
484 2020-10-09T16:54:33  *** andreacab has quit IRC
485 2020-10-09T16:54:39  <luke-jr> does C undefined behaviour extend to compile time?
486 2020-10-09T16:54:56  <luke-jr> can the compiler explode the system when you try to compile it?
487 2020-10-09T16:55:00  <sipa> luke-jr: no
488 2020-10-09T16:55:16  <sipa> (afaik)
489 2020-10-09T16:56:33  <wumpus> don't give compiler authors any ideas
490 2020-10-09T16:58:07  <luke-jr> nuts, could have submitted a patch to GCC to erase everything when it encounters mem*
491 2020-10-09T16:58:10  <luke-jr> XD
492 2020-10-09T16:58:39  <luke-jr> wumpus: hey, at least I didn't suggest telemetrics on UB?
493 2020-10-09T17:00:52  *** EagleTM has quit IRC
494 2020-10-09T17:01:20  <wumpus> the most disappointing thing about the whole C UB sitution is how little, historically, C compilers have attempted to detect and reject it, I mean if mem* is only reserved for system functions, fair enough, but make it an error or warning.
495 2020-10-09T17:01:56  <wumpus> but no they really like their random explosions :)
496 2020-10-09T17:02:17  *** cryptapus has joined #bitcoin-core-dev
497 2020-10-09T17:04:04  <sipa> the reason i suspect is that they don't want programs to misbehave if memslartbartfast suddenly becomes a new standard library function in C2043, and your code is already using it
498 2020-10-09T17:06:58  <luke-jr> they probably would prefer a C22 compiler is C99-compatible too
499 2020-10-09T17:07:20  <luke-jr> by making mem* UB, a C22 memfoo doesn't break C99 code
500 2020-10-09T17:08:41  <luke-jr> (same thing, but from another angle)
501 2020-10-09T17:09:07  <sipa> i guess a better alternative would be to have a way for the STL to declare "reserved but unused" name patterns to the compiler, so it can error if you use a reserved name, rather than needing to resort to the super-heavy "UB" hammer
502 2020-10-09T17:09:41  <wumpus> looks like I have the same problem again after merging 19954: my node keeps making outgoing connections, but never gets any blocks
503 2020-10-09T17:10:32  <sipa> hmm
504 2020-10-09T17:10:35  <sipa> this looks familiar
505 2020-10-09T17:10:36  <wumpus> somehow it's dropping all outgoing connections immediately, it stays at 1-3
506 2020-10-09T17:10:55  <sipa> Murch: do you remember someone on bitcoin SE complaining about similar behavior?
507 2020-10-09T17:10:56  <wumpus> it does succesfully accept incoming connections but that doesn't help
508 2020-10-09T17:11:24  <luke-jr> wumpus: to clarify, you mean without 19954 it was okay?
509 2020-10-09T17:11:36  <wumpus> luke-jr: yes, without that it seemed to be okay
510 2020-10-09T17:11:43  <wumpus> it did receive a few blocks
511 2020-10-09T17:12:23  <wumpus> but no crash at shutdown this time
512 2020-10-09T17:13:02  <wumpus> but it does look like 19954 is the problem, will try again without that
513 2020-10-09T17:13:35  <sipa> oh, ok
514 2020-10-09T17:13:45  <sipa> in that case what i remember seeing must have been unrelated
515 2020-10-09T17:13:56  <wumpus> probably, unless this triggers a similar condition
516 2020-10-09T17:14:09  <wumpus> I did already try deleting peers.dat
517 2020-10-09T17:16:47  <achow101> anyone ever see "corrupted size vs. prev_size in fastbins" on stderr before? it's showing up on a change to sqlite wallet that I'm working on
518 2020-10-09T17:18:00  <sipa> achow101: i wouldn't know what prev_size or fastbins are
519 2020-10-09T17:18:14  <wumpus> googling it, it's a glibc heap corruption error
520 2020-10-09T17:18:22  <achow101> it seems to be coming out of libc
521 2020-10-09T17:18:46  *** cryptapus has quit IRC
522 2020-10-09T17:18:56  <wumpus> but to answer your questino, no, I've never seen it
523 2020-10-09T17:19:02  *** cryptapus has joined #bitcoin-core-dev
524 2020-10-09T17:19:11  <achow101> great..
525 2020-10-09T17:19:13  <luke-jr> valgrind it
526 2020-10-09T17:20:18  <achow101> good idea
527 2020-10-09T17:23:48  *** mdunnio has joined #bitcoin-core-dev
528 2020-10-09T17:28:34  <roconnor> very early on, the glasgow haskell compiler had an infamous bug where it would delete the source file if you tried to compile it and it had a type error.
529 2020-10-09T17:28:51  *** mdunnio has quit IRC
530 2020-10-09T17:29:27  *** mdunnio has joined #bitcoin-core-dev
531 2020-10-09T17:32:01  <luke-jr> XD
532 2020-10-09T17:37:33  <sipa> roconnor: type errors are *really* frowned upon
533 2020-10-09T17:41:17  <achow101> ah, I had a double free
534 2020-10-09T17:43:01  <sipa> achow101: see youtube link above
535 2020-10-09T17:44:21  <achow101> heh
536 2020-10-09T17:49:45  *** cryptapus has quit IRC
537 2020-10-09T17:51:46  *** cryptapus has joined #bitcoin-core-dev
538 2020-10-09T17:51:47  *** cryptapus has quit IRC
539 2020-10-09T17:51:47  *** cryptapus has joined #bitcoin-core-dev
540 2020-10-09T17:59:56  *** filchef has joined #bitcoin-core-dev
541 2020-10-09T18:00:01  *** kers has quit IRC
542 2020-10-09T18:04:27  *** jonatack has quit IRC
543 2020-10-09T18:05:20  *** jonatack has joined #bitcoin-core-dev
544 2020-10-09T18:22:14  *** ButterflyOfFire has joined #bitcoin-core-dev
545 2020-10-09T18:27:54  *** GankMove has quit IRC
546 2020-10-09T18:31:34  *** owowo has quit IRC
547 2020-10-09T18:34:53  <wumpus> gah, the peer keeps disconnectiong outgoing connections without logging the reason at all (even with debug=net)
548 2020-10-09T18:35:15  <sipa> wumpus: and just with #19954 ?
549 2020-10-09T18:35:18  <gribble> https://github.com/bitcoin/bitcoin/issues/19954 | tor: complete the TORv3 implementation by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
550 2020-10-09T18:35:50  <wumpus> sipa: yes
551 2020-10-09T18:35:59  <wumpus> without it, it makes outgoing connections succesfully
552 2020-10-09T18:36:55  <sipa> bizarre, and ungood
553 2020-10-09T18:37:26  *** owowo has joined #bitcoin-core-dev
554 2020-10-09T18:38:21  *** Pavlenex has quit IRC
555 2020-10-09T18:40:39  <Murch> sipa: I don't remember any recent posts to that effect.
556 2020-10-09T18:44:57  <wumpus> curiously it even happens with listen=0
557 2020-10-09T18:46:47  <wumpus> well maybe not so curiously because it's about outgoing connections but at least it's not the tor bind stuff itself that interferes
558 2020-10-09T18:47:44  *** ares_ has quit IRC
559 2020-10-09T18:50:39  <jonatack> wumpus: when did the issue start? since the latest 19954 pushes?
560 2020-10-09T18:51:42  <wumpus> jonatack: I think so, do we have a previous version of the PR somewhere?
561 2020-10-09T18:51:57  <wumpus> I'm pretty sure this node was running with TORv3 succesfully at some point
562 2020-10-09T18:52:54  <wumpus> will try to bisect the commits
563 2020-10-09T18:53:21  <jonatack> there were a couple of important changes this week: on tuesday and today, iirc
564 2020-10-09T18:53:56  <wumpus> first I'll try testing the branch itself instead of the branch merged on top of master
565 2020-10-09T18:54:51  <wumpus> to rule out a silent merge conflict
566 2020-10-09T18:56:18  *** Pavlenex has joined #bitcoin-core-dev
567 2020-10-09T18:57:00  *** bitcoin-git has joined #bitcoin-core-dev
568 2020-10-09T18:57:01  <bitcoin-git> [bitcoin] jonatack opened pull request #20115: cli: -netinfo quick updates/fixups and release note (master...netinfo-fixups) https://github.com/bitcoin/bitcoin/pull/20115
569 2020-10-09T18:57:02  *** bitcoin-git has left #bitcoin-core-dev
570 2020-10-09T19:00:07  <meshcollider> #startmeeting
571 2020-10-09T19:00:07  <lightningbot> Meeting started Fri Oct  9 19:00:07 2020 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
572 2020-10-09T19:00:07  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
573 2020-10-09T19:00:14  <achow101> hi\
574 2020-10-09T19:00:24  <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr
575 2020-10-09T19:00:24  <meshcollider> jeremyrubin emilengler jonatack hebasto jb55 kvaciral ariard digi_james amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2
576 2020-10-09T19:00:31  <jonatack> hi
577 2020-10-09T19:00:49  <hebasto> hi
578 2020-10-09T19:00:55  <meshcollider> 2:09 AM <achow101> #proposedwalletmeetingtopic: wallet.dat vs wallet.sqlite
579 2020-10-09T19:01:26  <meshcollider> #topic wallet.dat vs wallet.sqlite
580 2020-10-09T19:01:50  <achow101> for sqlite wallets, there's been an ongoing question of whether the sqlite wallet files should be named wallet.dat or wallet.sqlite
581 2020-10-09T19:02:52  <hebasto> what are pros and cons of each approach?
582 2020-10-09T19:03:12  <achow101> the PR currently implements wallet.dat. ryanofsky has been arguing for wallet.sqlite in his review comments
583 2020-10-09T19:03:19  <achow101> i wanted to hear what everyone else thinks
584 2020-10-09T19:03:42  <Murch> hello
585 2020-10-09T19:03:47  <hebasto> I've just started to review that pr, so have no opinion
586 2020-10-09T19:03:50  <achow101> for wallet.dat, the arguments are to maintain backwards compatibility with external documentation and tooling, as well as not causing a problem with a specific downgrade scenario
587 2020-10-09T19:04:44  <meshcollider> Yeah calling it wallet.dat has the advantage that automatic backup scripts, etc. will continue working fine, and also that users are already conditioned to protecting wallet.dat files
588 2020-10-09T19:04:56  <achow101> for wallet.sqlite, it's a clearer naming convention, follows sqlite naming convention, and can't be confused with bdb
589 2020-10-09T19:05:38  <jonatack> hm, good arguments for both
590 2020-10-09T19:05:41  <achow101> wallet.sqlite also avoids a different set of compatibility prolems
591 2020-10-09T19:05:47  <sipa> yeah, i'm very much in the middle
592 2020-10-09T19:06:08  <sipa> some of the naming conventions and expectations around them were already broken when we moved to per-wallet directories
593 2020-10-09T19:06:20  <sipa> and i don't recall that causing many issues for users
594 2020-10-09T19:06:35  <achow101> relevant commens. for wallet.dat: https://github.com/bitcoin/bitcoin/pull/19077#issuecomment-705180018 for wallet.sqlite: https://github.com/bitcoin/bitcoin/pull/19077#pullrequestreview-504980287
595 2020-10-09T19:06:43  <sipa> though, the specific "wallet.dat must be protected with your life" filename convention remained
596 2020-10-09T19:06:50  <luke-jr> meshcollider: it is already wrong and risks corruption to copy wallet.dat directly
597 2020-10-09T19:06:57  <fjahr> hi
598 2020-10-09T19:07:00  <hebasto> if users adopted per-wallet dir, we could expect such adoption for .sqlite
599 2020-10-09T19:07:03  <sipa> luke-jr: it doesn't if you do it while bitcoind is shut down
600 2020-10-09T19:07:14  <meshcollider> luke-jr: that doesn't stop users doing it
601 2020-10-09T19:07:24  <luke-jr> meshcollider: breaking such scripts would be an advantage to renaming
602 2020-10-09T19:07:37  <sipa> luke-jr: i couldn't disagree more with that
603 2020-10-09T19:07:39  <luke-jr> a possible issue is restoring though
604 2020-10-09T19:07:56  <achow101> luke-jr: but breaking such scripts would probably result in backups not being made, which is dangerous
605 2020-10-09T19:07:58  *** ares_ has joined #bitcoin-core-dev
606 2020-10-09T19:08:11  <luke-jr> achow101: most likely would result in errors instead of possibly-corrupt backups
607 2020-10-09T19:08:17  <achow101> I would be surprised if said scripts failed in a way that was obvious to the person running it
608 2020-10-09T19:08:21  <luke-jr> O.o
609 2020-10-09T19:08:26  <sipa> luke-jr: i agree that we should discourage bad practice, but (a) not by making decisions that can actually cause people to lose money and (b) i disagree this is unsupported - it's only supported when bitcoind is not running though
610 2020-10-09T19:08:28  <meshcollider> And there are also other tools I imagine, not just backup scripts, which look for wallet.dat by default
611 2020-10-09T19:08:34  <luke-jr> if a cronjob fails, typically you get an email
612 2020-10-09T19:09:00  <luke-jr> sipa: at least some versions would reuslt in corruption even if bitcoind exited cleanly
613 2020-10-09T19:09:07  <achow101> luke-jr: fwiw I have a system backup cronjob and I don't know when/if it fails until I check the logs, and that happens maybe once every 6 months
614 2020-10-09T19:09:09  <sipa> how so?
615 2020-10-09T19:09:17  <luke-jr> sipa: we used to not flush/close the db
616 2020-10-09T19:09:32  <luke-jr> achow101: you should fix that :p
617 2020-10-09T19:09:47  <sipa> luke-jr: i believe that was very briefly the case, in ancient times
618 2020-10-09T19:09:50  <achow101> luke-jr: right, but that's an example of a backup script failing and the user not knowing
619 2020-10-09T19:10:05  <luke-jr> I suppose people doing backups wrong, are also likely to do error notifications wrong
620 2020-10-09T19:10:33  <sipa> people will do lots of things wrong
621 2020-10-09T19:10:43  <sipa> doesn't mean we shouldn't do a best effort to avoid them losing money
622 2020-10-09T19:10:55  <luke-jr> but wallet.dat are currently in a dedicated directory
623 2020-10-09T19:11:00  <luke-jr> there's no need for that for sqlite, right?
624 2020-10-09T19:11:10  <sipa> that's a good question
625 2020-10-09T19:11:34  <achow101> luke-jr: yes, but I think it would be more confusing to users if we stopped doing that
626 2020-10-09T19:11:42  <sipa> hmm
627 2020-10-09T19:11:49  <jonatack> modulo the risk of users losing money if renamed, a risk i don't feel competent to evaluate, i tend to agree with ryanofsky's arguments
628 2020-10-09T19:12:09  <sipa> to me, that'd be one of the advantages of sqlite... not needing a directory for every wallet anymore
629 2020-10-09T19:12:51  <luke-jr> btw, even if it's wallet.sqlite, it's not like we're renaming without the user knowing
630 2020-10-09T19:13:15  <luke-jr> wouldn't you expect anyone setting up a backup script to check that it works when they create the wallet, at least once? :P
631 2020-10-09T19:13:20  <achow101> luke-jr: not necessarily. they'd need to read the release notes, and who the hell does that?
632 2020-10-09T19:13:47  <luke-jr> achow101: you're seriously suggesting automatically transforming BDB to sqlite?
633 2020-10-09T19:14:04  <luke-jr> without user interaction?
634 2020-10-09T19:14:15  <achow101> luke-jr: there's no transformation
635 2020-10-09T19:14:31  <achow101> what I mean is that sqlite would be default for descriptor wallets, but the only way you would know that is to read the release notes
636 2020-10-09T19:14:32  <luke-jr> ok, so wallet.dat would remain wallet.dat even if new wallets are wallet.sqlite…
637 2020-10-09T19:14:51  <achow101> existing wallets are unaffected
638 2020-10-09T19:15:17  <luke-jr> so the only way someone should lose data is if they never check for a successful backup ever..
639 2020-10-09T19:15:31  <achow101> sipa: I suppose that getting rid of the wallet directory thing would solve both of these problems
640 2020-10-09T19:15:33  <luke-jr> or  maybe are backing up numerous wallets and expect newly created ones automatically included
641 2020-10-09T19:16:57  <achow101> luke-jr: when we get around to implementing bdb to sqlite migration, there could be problems there with the rename
642 2020-10-09T19:17:18  <luke-jr> achow101: but we get the chance to tell users when they opt into it
643 2020-10-09T19:17:23  <achow101> true
644 2020-10-09T19:17:46  <luke-jr> a reason not to rename: acting on file extensions has been kindof deprecated for a long time?
645 2020-10-09T19:18:46  <achow101> there's also the problems with restoring, and that one downgrade case where a new wallet.dat is made
646 2020-10-09T19:19:43  <meshcollider> IMO we should get rid of individual directories for sqlite, I don't think that would be confusing
647 2020-10-09T19:21:29  <achow101> meshcollider: that still has the backup and restore problems, although not the downgrade one if we name the file as the wallet name
648 2020-10-09T19:26:25  <achow101> any other comments on this topic?
649 2020-10-09T19:27:13  <meshcollider> Did this help make a decision ;)
650 2020-10-09T19:27:28  <achow101> not really
651 2020-10-09T19:27:33  <fjahr> I'm undecided as well, sorry
652 2020-10-09T19:28:14  <achow101> I'll experiment with a no wallet directory approach and see how big the diff is
653 2020-10-09T19:28:25  <meshcollider> Yeah that sounds good
654 2020-10-09T19:28:27  <meshcollider> Any other topics then?
655 2020-10-09T19:29:56  <jonatack> fjahr: at some point, sometime, we should maybe discuss #18418
656 2020-10-09T19:29:58  <gribble> https://github.com/bitcoin/bitcoin/issues/18418 | wallet: Increase OUTPUT_GROUP_MAX_ENTRIES to 100 by fjahr · Pull Request #18418 · bitcoin/bitcoin · GitHub
657 2020-10-09T19:30:15  <jonatack> perhaps Murch can look at it
658 2020-10-09T19:30:43  <jonatack> (just a thought, no need to duscuss now)
659 2020-10-09T19:30:55  <fjahr> Yeah, thanks, I guess at the moment nobody has time but maybe in 2 weeks
660 2020-10-09T19:32:30  <meshcollider> Ok let's discuss it next time then :)
661 2020-10-09T19:32:38  <meshcollider> #endmeeting
662 2020-10-09T19:32:38  <lightningbot> Meeting ended Fri Oct  9 19:32:38 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
663 2020-10-09T19:32:38  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-09-19.00.html
664 2020-10-09T19:32:38  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-09-19.00.txt
665 2020-10-09T19:32:38  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-09-19.00.log.html
666 2020-10-09T19:32:44  <jonatack> o/
667 2020-10-09T19:32:45  <meshcollider> Thanks all
668 2020-10-09T19:33:06  <meshcollider> \o
669 2020-10-09T19:37:57  *** Pavlenex has quit IRC
670 2020-10-09T19:58:17  <luke-jr> btw, I wonder if creating a wallet is really the right response to not finding one named :P
671 2020-10-09T20:02:10  <roconnor> In a different program I complained where running an obviously read-only operation would create a new file if the required file didn't exist.
672 2020-10-09T20:02:26  <achow101> luke-jr: it definitely isn't and we should remove that behavior
673 2020-10-09T20:06:08  *** tripleslash has quit IRC
674 2020-10-09T20:06:17  *** [\\\] has joined #bitcoin-core-dev
675 2020-10-09T20:25:12  *** kristapsk has joined #bitcoin-core-dev
676 2020-10-09T20:25:57  *** S3RK has joined #bitcoin-core-dev
677 2020-10-09T20:30:35  *** S3RK has quit IRC
678 2020-10-09T20:31:47  *** Guyver2_ has joined #bitcoin-core-dev
679 2020-10-09T20:34:08  *** Guyver2 has quit IRC
680 2020-10-09T21:00:02  *** ButterflyOfFire has quit IRC
681 2020-10-09T21:02:19  *** filchef has quit IRC
682 2020-10-09T21:03:02  *** Guyver2_ has quit IRC
683 2020-10-09T21:05:05  *** Victorsueca has quit IRC
684 2020-10-09T21:21:25  *** wright has joined #bitcoin-core-dev
685 2020-10-09T21:31:53  *** brianhoffman has joined #bitcoin-core-dev
686 2020-10-09T21:32:30  *** brianhoffman_ has quit IRC
687 2020-10-09T21:37:23  *** k3tan has quit IRC
688 2020-10-09T21:41:42  *** k3tan has joined #bitcoin-core-dev
689 2020-10-09T21:54:43  *** Talkless has joined #bitcoin-core-dev
690 2020-10-09T22:10:43  *** vasild has quit IRC
691 2020-10-09T22:12:17  *** vasild has joined #bitcoin-core-dev
692 2020-10-09T22:20:11  *** tryphe has quit IRC
693 2020-10-09T22:20:57  *** tryphe has joined #bitcoin-core-dev
694 2020-10-09T22:21:35  <sipa> wumpus: any progress?
695 2020-10-09T22:51:45  *** mdunnio has quit IRC
696 2020-10-09T22:56:42  *** mdunnio has joined #bitcoin-core-dev
697 2020-10-09T22:59:22  *** S3RK has joined #bitcoin-core-dev
698 2020-10-09T23:02:01  *** mdunnio has quit IRC
699 2020-10-09T23:04:19  *** S3RK has quit IRC
700 2020-10-09T23:05:38  *** Talkless has quit IRC
701 2020-10-09T23:09:49  *** mol_ has quit IRC
702 2020-10-09T23:23:41  *** mol has joined #bitcoin-core-dev
703 2020-10-09T23:34:04  *** mdunnio has joined #bitcoin-core-dev
704 2020-10-09T23:34:13  *** mol has quit IRC
705 2020-10-09T23:39:22  *** mdunnio has quit IRC
706 2020-10-09T23:47:14  *** mol has joined #bitcoin-core-dev
707 2020-10-09T23:47:46  *** pinheadmz has quit IRC
708 2020-10-09T23:52:03  *** pinheadmz has joined #bitcoin-core-dev
709 2020-10-09T23:58:36  *** pinheadmz has quit IRC