1 2020-10-12T00:00:02  *** openstackstatus1 has quit IRC
  2 2020-10-12T00:00:10  *** DeanGuss has quit IRC
  3 2020-10-12T00:02:08  <sipa> achow101: have you tried creating a wallet with the latest sqlite, and then opening it with a verdion that uses an older one?
  4 2020-10-12T00:02:31  <sipa> or is that exactly what you're tesfing here
  5 2020-10-12T00:02:51  <achow101> sipa: that's exactly what I did
  6 2020-10-12T00:03:02  <achow101> (as well as run all functional tests)
  7 2020-10-12T00:03:12  <sipa> cool
  8 2020-10-12T00:04:59  *** DeanGuss has joined #bitcoin-core-dev
  9 2020-10-12T00:05:45  <luke-jr> what if new sqlite exits uncleanly?
 10 2020-10-12T00:09:40  <achow101> luke-jr: I'd guess that it'd work fine, but I'm not sure how to test that
 11 2020-10-12T00:09:52  <achow101> i'd have to kill bitcoind in the middle of a write somehow
 12 2020-10-12T00:10:37  <luke-jr> gdb breakpoint and the kill command? <.<
 13 2020-10-12T00:11:02  <achow101> hmm, ok..
 14 2020-10-12T00:31:43  *** shaunsun has joined #bitcoin-core-dev
 15 2020-10-12T00:32:54  *** shaunsun_ has joined #bitcoin-core-dev
 16 2020-10-12T00:36:39  *** shaunsun has quit IRC
 17 2020-10-12T00:38:43  <achow101> luke-jr: handles it just fine
 18 2020-10-12T00:39:25  *** S3RK has joined #bitcoin-core-dev
 19 2020-10-12T00:39:58  <luke-jr> +1
 20 2020-10-12T00:46:45  *** S3RK has quit IRC
 21 2020-10-12T00:46:46  *** promag has quit IRC
 22 2020-10-12T00:52:59  *** shaunsun_ has quit IRC
 23 2020-10-12T00:55:20  *** Guest92188 has joined #bitcoin-core-dev
 24 2020-10-12T01:02:35  *** TheHoliestRoger has quit IRC
 25 2020-10-12T01:04:50  *** TheHoliestRoger has joined #bitcoin-core-dev
 26 2020-10-12T01:07:13  *** Mercury_Vapor has quit IRC
 27 2020-10-12T01:09:05  *** kexkey has joined #bitcoin-core-dev
 28 2020-10-12T01:11:50  *** isis is now known as isis_
 29 2020-10-12T01:21:16  *** S3RK has joined #bitcoin-core-dev
 30 2020-10-12T01:24:41  *** da39a3ee5e6b4b0d has quit IRC
 31 2020-10-12T02:03:16  *** justanotheruser has joined #bitcoin-core-dev
 32 2020-10-12T02:06:15  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
 33 2020-10-12T02:14:06  *** mdunnio has joined #bitcoin-core-dev
 34 2020-10-12T02:18:39  *** mdunnio has quit IRC
 35 2020-10-12T02:20:01  *** mdunnio has joined #bitcoin-core-dev
 36 2020-10-12T02:24:20  *** mdunnio has quit IRC
 37 2020-10-12T02:31:05  *** proofofkeags_ has quit IRC
 38 2020-10-12T02:31:05  *** proofofkeags has quit IRC
 39 2020-10-12T02:41:33  *** CubicEarth has quit IRC
 40 2020-10-12T02:45:27  *** CubicEarth has joined #bitcoin-core-dev
 41 2020-10-12T02:48:46  *** proofofkeags_ has joined #bitcoin-core-dev
 42 2020-10-12T02:48:46  *** proofofkeags has joined #bitcoin-core-dev
 43 2020-10-12T02:59:42  *** mdunnio has joined #bitcoin-core-dev
 44 2020-10-12T03:00:02  *** Guest92188 has quit IRC
 45 2020-10-12T03:04:07  *** mdunnio has quit IRC
 46 2020-10-12T03:19:26  *** proofofkeags_ has quit IRC
 47 2020-10-12T03:19:27  *** proofofkeags has quit IRC
 48 2020-10-12T03:56:02  *** larsivi has joined #bitcoin-core-dev
 49 2020-10-12T04:31:26  *** justanotheruser has quit IRC
 50 2020-10-12T05:08:28  *** justanotheruser has joined #bitcoin-core-dev
 51 2020-10-12T05:52:22  <hebasto> ja: #13478 is linked to #20104 as it is the recent discussion about minimum Qt version, and it lists arguments that should be considered in upcoming discussion
 52 2020-10-12T05:52:24  <gribble> https://github.com/bitcoin/bitcoin/issues/13478 | [RFC] gui: Minimum required Qt5 · Issue #13478 · bitcoin/bitcoin · GitHub
 53 2020-10-12T05:52:25  <gribble> https://github.com/bitcoin/bitcoin/issues/20104 | [RFC] qt: Minimum required Qt5 · Issue #20104 · bitcoin/bitcoin · GitHub
 54 2020-10-12T05:52:50  *** mrostecki has joined #bitcoin-core-dev
 55 2020-10-12T06:00:01  *** larsivi has quit IRC
 56 2020-10-12T06:06:42  *** rdbell has joined #bitcoin-core-dev
 57 2020-10-12T06:22:15  *** nandub has joined #bitcoin-core-dev
 58 2020-10-12T06:30:43  *** davterra has quit IRC
 59 2020-10-12T06:31:17  *** gribble has quit IRC
 60 2020-10-12T06:41:31  *** andreacab has joined #bitcoin-core-dev
 61 2020-10-12T06:44:40  *** gribble has joined #bitcoin-core-dev
 62 2020-10-12T06:52:06  *** rdbell has quit IRC
 63 2020-10-12T07:03:23  *** mdunnio has joined #bitcoin-core-dev
 64 2020-10-12T07:05:04  *** gleb has joined #bitcoin-core-dev
 65 2020-10-12T07:07:31  <hebasto> achow101: https://sqlite.org/src/info/fda22108 looks scary, should we bump minimum sqlite up to 3.18.1 ?
 66 2020-10-12T07:07:48  *** mdunnio has quit IRC
 67 2020-10-12T07:15:10  *** Pavlenex has joined #bitcoin-core-dev
 68 2020-10-12T07:22:35  <vasild> "test/test_bitcoin: export of symbol in6addr_loopback not allowed"
 69 2020-10-12T07:22:36  *** andreacab has quit IRC
 70 2020-10-12T07:22:37  <vasild> hmm
 71 2020-10-12T07:23:02  *** andreacab has joined #bitcoin-core-dev
 72 2020-10-12T07:27:06  *** andreacab has quit IRC
 73 2020-10-12T07:32:41  *** S3RK has quit IRC
 74 2020-10-12T07:44:28  *** nandub has quit IRC
 75 2020-10-12T07:48:16  *** bitcoin-git has joined #bitcoin-core-dev
 76 2020-10-12T07:48:17  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0b2abaa666d6...af22322dab1a
 77 2020-10-12T07:48:17  <bitcoin-git> bitcoin/master 79f3d9b Pieter Wuille: Mention BIP155 in doc/bips.md
 78 2020-10-12T07:48:18  <bitcoin-git> bitcoin/master 56f9dba Pieter Wuille: Only relay IPv4, IPv6, Tor addresses
 79 2020-10-12T07:48:18  <bitcoin-git> bitcoin/master af22322 fanquake: Merge #20119: BIP155 follow-ups
 80 2020-10-12T07:48:20  *** bitcoin-git has left #bitcoin-core-dev
 81 2020-10-12T07:48:36  *** bitcoin-git has joined #bitcoin-core-dev
 82 2020-10-12T07:48:36  <bitcoin-git> [bitcoin] fanquake merged pull request #20119: BIP155 follow-ups (master...202010_bip155_followup) https://github.com/bitcoin/bitcoin/pull/20119
 83 2020-10-12T07:48:45  *** bitcoin-git has left #bitcoin-core-dev
 84 2020-10-12T07:56:01  *** promag has joined #bitcoin-core-dev
 85 2020-10-12T08:00:00  *** promag has quit IRC
 86 2020-10-12T08:00:15  *** promag has joined #bitcoin-core-dev
 87 2020-10-12T08:02:16  *** blardo has joined #bitcoin-core-dev
 88 2020-10-12T08:02:47  *** Guyver2 has joined #bitcoin-core-dev
 89 2020-10-12T08:04:03  *** andreacab has joined #bitcoin-core-dev
 90 2020-10-12T08:10:07  *** S3RK has joined #bitcoin-core-dev
 91 2020-10-12T08:10:07  *** andreacab has quit IRC
 92 2020-10-12T08:15:44  *** S3RK has quit IRC
 93 2020-10-12T08:18:26  *** kljasdfvv has joined #bitcoin-core-dev
 94 2020-10-12T08:21:46  <vasild> sipa:
 95 2020-10-12T08:21:48  <vasild> -        CService(CNetAddr(in6addr_loopback), 0 /* port */),
 96 2020-10-12T08:21:48  <vasild> +        CService(CNetAddr(in6_addr(IN6ADDR_LOOPBACK_INIT)), 0 /* port */),
 97 2020-10-12T08:21:56  <vasild> this should fix it
 98 2020-10-12T08:25:36  <sipa> vasild: that also works, i guess
 99 2020-10-12T08:26:07  <vasild> I don't fully understand this check, why don't we want to export any symbols?
100 2020-10-12T08:26:36  <vasild> I mean - I can't judge if the above is better than adding in6addr_loopback to the list of exceptions
101 2020-10-12T08:27:41  *** promag_ has joined #bitcoin-core-dev
102 2020-10-12T08:28:30  *** promag has quit IRC
103 2020-10-12T08:28:59  *** bitcoin-git has joined #bitcoin-core-dev
104 2020-10-12T08:28:59  <bitcoin-git> [bitcoin] vasild opened pull request #20129: tests: don't export in6addr_loopback (master...fix_export_of_in6addr_loopback) https://github.com/bitcoin/bitcoin/pull/20129
105 2020-10-12T08:29:01  *** bitcoin-git has left #bitcoin-core-dev
106 2020-10-12T08:29:09  <vasild> anyway - opened a PR, lets figure it out there
107 2020-10-12T08:31:44  <sipa> vasild: added in #4089
108 2020-10-12T08:31:45  <gribble> https://github.com/bitcoin/bitcoin/issues/4089 | devtools: add script to check symbols from Linux gitian executables by laanwj · Pull Request #4089 · bitcoin/bitcoin · GitHub
109 2020-10-12T08:34:22  *** promag_ has quit IRC
110 2020-10-12T08:35:48  <vasild> "This makes sure they are still compatible with the minimum supported Linux distribution versions."
111 2020-10-12T08:37:07  <sipa> yeah, if we'd accidentally introduce a dependency on a symbol that's only available in a recent glibc for example, you can't run the binary on old systems
112 2020-10-12T08:39:44  <vasild> I see
113 2020-10-12T08:47:16  *** promag has joined #bitcoin-core-dev
114 2020-10-12T08:51:19  *** jonatack has quit IRC
115 2020-10-12T08:53:33  *** isis_ is now known as isis
116 2020-10-12T08:54:58  *** promag has quit IRC
117 2020-10-12T09:00:01  *** blardo has quit IRC
118 2020-10-12T09:04:53  *** kexkey has quit IRC
119 2020-10-12T09:05:15  *** S3RK has joined #bitcoin-core-dev
120 2020-10-12T09:09:46  *** andreacab has joined #bitcoin-core-dev
121 2020-10-12T09:09:49  *** go11111111111 has joined #bitcoin-core-dev
122 2020-10-12T09:12:23  *** go121212 has quit IRC
123 2020-10-12T09:14:43  *** andreacab has quit IRC
124 2020-10-12T09:20:14  <kallewoof> sipa: maybe you realized, but you did s/fSuccess/fuccess/.
125 2020-10-12T09:21:41  *** DarTar has joined #bitcoin-core-dev
126 2020-10-12T09:22:40  <sipa> kallewoof: i guess there will be an "Updates 2020/10/12" in that case :)
127 2020-10-12T09:22:54  <sipa> i shouldn't be making these changes at 2:24 am
128 2020-10-12T09:23:01  <kallewoof> haha
129 2020-10-12T09:23:22  <sipa> wait
130 2020-10-12T09:23:32  <sipa> of course i was just testing if anyone was paying attention!
131 2020-10-12T09:27:05  *** glozow has quit IRC
132 2020-10-12T09:35:31  *** jonatack has joined #bitcoin-core-dev
133 2020-10-12T09:52:48  *** jonatack has quit IRC
134 2020-10-12T10:10:23  *** vasild has quit IRC
135 2020-10-12T10:12:22  *** vasild has joined #bitcoin-core-dev
136 2020-10-12T10:14:11  *** shesek has quit IRC
137 2020-10-12T10:18:22  *** Lillian89Heathco has joined #bitcoin-core-dev
138 2020-10-12T10:27:08  *** andreacab has joined #bitcoin-core-dev
139 2020-10-12T10:28:18  *** Lillian89Heathco has quit IRC
140 2020-10-12T10:31:59  *** andreacab has quit IRC
141 2020-10-12T10:36:19  *** davterra has joined #bitcoin-core-dev
142 2020-10-12T10:38:02  *** promag has joined #bitcoin-core-dev
143 2020-10-12T10:43:41  *** da39a3ee5e6b4b0d has quit IRC
144 2020-10-12T10:46:22  *** andreacab has joined #bitcoin-core-dev
145 2020-10-12T10:53:10  *** bitcoin-git has joined #bitcoin-core-dev
146 2020-10-12T10:53:11  <bitcoin-git> [bitcoin] S3RK opened pull request #20130: Wallet: remove db mode string (master...wallet_remove_mode_3) https://github.com/bitcoin/bitcoin/pull/20130
147 2020-10-12T10:53:12  *** bitcoin-git has left #bitcoin-core-dev
148 2020-10-12T10:54:55  *** S3RK has quit IRC
149 2020-10-12T11:07:47  *** S3RK has joined #bitcoin-core-dev
150 2020-10-12T11:12:20  *** promag has quit IRC
151 2020-10-12T11:12:36  *** bitcoin-git has joined #bitcoin-core-dev
152 2020-10-12T11:12:36  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20131: test: Remove unused nVersion=1 in p2p tests (master...2010-testnVersion) https://github.com/bitcoin/bitcoin/pull/20131
153 2020-10-12T11:12:38  *** bitcoin-git has left #bitcoin-core-dev
154 2020-10-12T11:15:11  *** Pavlenex has quit IRC
155 2020-10-12T11:21:02  *** S3RK has quit IRC
156 2020-10-12T11:21:32  *** S3RK has joined #bitcoin-core-dev
157 2020-10-12T11:22:36  *** S3RK has joined #bitcoin-core-dev
158 2020-10-12T11:23:41  *** bitcoin-git has joined #bitcoin-core-dev
159 2020-10-12T11:23:41  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #20097: fuzz: Version handshake (master...2010-fuzzHandshake) https://github.com/bitcoin/bitcoin/pull/20097
160 2020-10-12T11:23:42  *** bitcoin-git has left #bitcoin-core-dev
161 2020-10-12T11:24:36  *** promag has joined #bitcoin-core-dev
162 2020-10-12T11:28:38  *** promag has quit IRC
163 2020-10-12T11:29:31  *** ghost43 has quit IRC
164 2020-10-12T11:29:51  *** ghost43 has joined #bitcoin-core-dev
165 2020-10-12T11:40:23  *** neo_1 has quit IRC
166 2020-10-12T11:40:51  *** jonatack has joined #bitcoin-core-dev
167 2020-10-12T11:42:04  *** S3RK has quit IRC
168 2020-10-12T11:42:40  *** S3RK has joined #bitcoin-core-dev
169 2020-10-12T11:43:20  <jonatack> there are now "73 hidden items" in #19988 that can no longer be loaded (the link does nothing) :/
170 2020-10-12T11:43:24  <gribble> https://github.com/bitcoin/bitcoin/issues/19988 | Overhaul transaction request logic by sipa · Pull Request #19988 · bitcoin/bitcoin · GitHub
171 2020-10-12T11:47:08  *** S3RK has quit IRC
172 2020-10-12T11:48:22  *** jonatack has quit IRC
173 2020-10-12T11:49:12  *** andreacab has quit IRC
174 2020-10-12T11:49:45  *** promag has joined #bitcoin-core-dev
175 2020-10-12T11:50:38  *** jonatack has joined #bitcoin-core-dev
176 2020-10-12T11:52:27  *** DarTar has quit IRC
177 2020-10-12T11:52:30  *** mrostecki has quit IRC
178 2020-10-12T11:54:25  *** promag has quit IRC
179 2020-10-12T11:54:50  *** mdunnio has joined #bitcoin-core-dev
180 2020-10-12T11:58:01  *** shaunsun_ has joined #bitcoin-core-dev
181 2020-10-12T11:59:25  *** shaunsun__ has joined #bitcoin-core-dev
182 2020-10-12T11:59:27  *** mdunnio has quit IRC
183 2020-10-12T12:01:14  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
184 2020-10-12T12:02:05  *** Mercury_Vapor has joined #bitcoin-core-dev
185 2020-10-12T12:02:39  *** shaunsun_ has quit IRC
186 2020-10-12T12:12:45  <willcl_ark> jonatack: seems like their gateway 502's when trying to load the comments, at the URL in this paste: https://0bin.net/paste/8-ysvxxl#vimu92Oplo3sSYaKT4n9EHDzDBE-Y2Daf1qUlblgunA
187 2020-10-12T12:14:55  <jonatack> willcl_ark: indeed, it's been the case for a few days now, only the number of hidden comments keeps growing. i'm reviewing without the discussion.
188 2020-10-12T12:15:16  <jonatack> hebasto mentioned it as well last week
189 2020-10-12T12:15:18  *** S3RK has joined #bitcoin-core-dev
190 2020-10-12T12:20:09  *** S3RK has quit IRC
191 2020-10-12T12:21:27  <willcl_ark> jonatack: ah I see.  How irritating for review.
192 2020-10-12T12:23:23  *** mdunnio has joined #bitcoin-core-dev
193 2020-10-12T12:23:44  *** andreacab has joined #bitcoin-core-dev
194 2020-10-12T12:24:29  *** S3RK has joined #bitcoin-core-dev
195 2020-10-12T12:27:18  *** jcoe has joined #bitcoin-core-dev
196 2020-10-12T12:27:55  *** mdunnio has quit IRC
197 2020-10-12T12:28:05  *** jcoe has quit IRC
198 2020-10-12T12:28:31  *** andreacab has quit IRC
199 2020-10-12T12:40:06  *** S3RK has quit IRC
200 2020-10-12T12:41:26  *** S3RK has joined #bitcoin-core-dev
201 2020-10-12T12:45:45  *** S3RK has quit IRC
202 2020-10-12T12:46:56  *** S3RK has joined #bitcoin-core-dev
203 2020-10-12T12:46:59  *** shaunsun__ has quit IRC
204 2020-10-12T12:51:48  *** shaunsun has joined #bitcoin-core-dev
205 2020-10-12T12:56:05  *** S3RK has quit IRC
206 2020-10-12T13:26:35  <wumpus> that's *really* bad
207 2020-10-12T13:26:54  <wumpus> did anyone report this to github yet? we can't keep using the platform if this is the case
208 2020-10-12T13:27:07  *** kees1 has joined #bitcoin-core-dev
209 2020-10-12T13:27:18  *** andreacab has joined #bitcoin-core-dev
210 2020-10-12T13:31:50  <jonatack> wumpus: it looks like fanquake reported it 2-3 days ago: http://www.erisian.com.au/bitcoin-core-dev/log-2020-10-10.html#l-42
211 2020-10-12T13:31:51  *** andreacab has quit IRC
212 2020-10-12T13:34:35  *** andreacab has joined #bitcoin-core-dev
213 2020-10-12T13:40:25  <fanquake> I have reported it to GitHub, and followed up with an employee today.
214 2020-10-12T13:42:55  <michaelfolkson> Anyone know if GitLab suffers from this problem (hidden comments)? This specific bug should be resolved but they never get round to addressing the terrible hidden comments UX either
215 2020-10-12T13:43:10  <michaelfolkson> I've never used GitLab
216 2020-10-12T13:43:47  <luke-jr> sipa: imports vs exports?
217 2020-10-12T13:44:12  *** andreacab has quit IRC
218 2020-10-12T13:44:33  *** andreacab has joined #bitcoin-core-dev
219 2020-10-12T13:45:08  <luke-jr> michaelfolkson: I have a GitLab repo that exceeded an arbitrary repo size limit years ago; opened an issue on their tracker, no response; pokes on Twitter, was told they'd look at it, still no response.. years later
220 2020-10-12T13:45:37  <michaelfolkson> Fair enough. So that wouldn't improve the situation
221 2020-10-12T13:45:52  *** mdunnio has joined #bitcoin-core-dev
222 2020-10-12T13:46:02  <luke-jr> well, no idea if they have this issue, but it seems getting support is at least not likely
223 2020-10-12T13:46:17  <hebasto> could gh cli show all comments?
224 2020-10-12T13:46:53  <luke-jr> lol mishmash     License:             MIT Apache-2.0 BSD BSD-2 MPL-2.0
225 2020-10-12T13:48:11  *** andreacab has quit IRC
226 2020-10-12T13:48:37  *** andreacab has joined #bitcoin-core-dev
227 2020-10-12T13:48:55  <michaelfolkson> Linus quote from Working in Public book. GitHub is "fine for hosting, but the pull requests and the online commit editing are just pure garbage" :) Old quote though
228 2020-10-12T13:53:23  *** andreacab has quit IRC
229 2020-10-12T13:56:49  <michaelfolkson> hebasto: I don't think any of the gh cli commands are related to viewing PR comments https://cli.github.com/manual/gh_pr
230 2020-10-12T13:58:18  <hebasto> michaelfolkson: so it's useless for that
231 2020-10-12T13:59:39  <michaelfolkson> I think so. At least from looking at the docs. They seem to pushing a workflow where you approve the PR using the CLI but where discussion and review is done outside of the PR
232 2020-10-12T14:04:48  *** mdunnio has quit IRC
233 2020-10-12T14:05:01  *** mdunnio has joined #bitcoin-core-dev
234 2020-10-12T14:05:18  <michaelfolkson> https://docs.github.com/en/free-pro-team@latest/rest/guides/working-with-comments
235 2020-10-12T14:08:00  <jonatack> hebasto: i use gh cli a little and keep updating it, but the features added so far aren't what i'm hoping for. no getting the comments yet.
236 2020-10-12T14:08:20  <jonatack> michaelfolkson: exactly
237 2020-10-12T14:08:40  *** pescador has joined #bitcoin-core-dev
238 2020-10-12T14:10:58  <jonatack> michaelfolkson: the globocorps and startup missions i was on until late 2018 used gitlab and mattermost instead of github and slack, which i was happy about, and we didn't have any issues at all -- i definitely preferred gitlab
239 2020-10-12T14:11:46  <jonatack> s/used/mostly used/
240 2020-10-12T14:12:28  <jonatack> michaelfolkson: but iirc the idea was to move away from any centralised service, if a migration were to happen
241 2020-10-12T14:14:42  <michaelfolkson> Right. GitHub seems to be deteriorating to me. Often happens post acquisition by megacorp.
242 2020-10-12T14:20:12  *** davterra has quit IRC
243 2020-10-12T14:20:29  *** davterra has joined #bitcoin-core-dev
244 2020-10-12T14:25:23  *** davterra has quit IRC
245 2020-10-12T14:25:44  <wumpus> michaelfolkson: gitlab seems to handle things fine, e.g. freedesktop uses their own gitlab instance to host some active high-profile projects such as Mesa, no big issues from what i know
246 2020-10-12T14:28:01  <michaelfolkson> Maybe I should try it if I am going to have an informed view rather than a speculative view...
247 2020-10-12T14:28:07  <wumpus> they were also really, really careful to transition from olle mailinglist-based FOSS development, they never trusted github
248 2020-10-12T14:29:06  <wumpus> (possibly because of Linus' opinion as you quoted :-) )
249 2020-10-12T14:32:12  *** luke-jr has quit IRC
250 2020-10-12T14:33:31  <wumpus> jonatack: being able to see the diff in-line *with reviewer comments* in the terminal would be a great cli feature, wish it could do that
251 2020-10-12T14:33:55  <wumpus> would save me a lot of switching between browser and terminal
252 2020-10-12T14:34:15  <jonatack> yesss this is what i was hoping gh cli would add
253 2020-10-12T14:35:28  <jonatack> whoever the PM is who is driving their features roadmap has very different priorities than ours
254 2020-10-12T14:37:06  *** S3RK has joined #bitcoin-core-dev
255 2020-10-12T14:37:54  *** Pavlenex has joined #bitcoin-core-dev
256 2020-10-12T14:38:42  <achow101> hebasto: I don't think that's a problem for us. we don't use replace or auto-vacuumed databases
257 2020-10-12T14:38:56  *** luke-jr has joined #bitcoin-core-dev
258 2020-10-12T14:43:29  *** davterra has joined #bitcoin-core-dev
259 2020-10-12T14:43:41  *** mdunnio has quit IRC
260 2020-10-12T14:44:18  *** mdunnio has joined #bitcoin-core-dev
261 2020-10-12T14:45:09  *** S3RK has quit IRC
262 2020-10-12T14:51:18  *** pescador has quit IRC
263 2020-10-12T14:53:49  <luke-jr> is there a way we can more strongly mark #18818 as a blocker? let's not forget part was backported to 0.20 …
264 2020-10-12T14:53:52  <gribble> https://github.com/bitcoin/bitcoin/issues/18818 | Fix release tarball generated by gitian by luke-jr · Pull Request #18818 · bitcoin/bitcoin · GitHub
265 2020-10-12T15:00:02  *** kees1 has quit IRC
266 2020-10-12T15:00:49  *** shesek has joined #bitcoin-core-dev
267 2020-10-12T15:01:19  *** ghost43 has quit IRC
268 2020-10-12T15:01:38  *** ghost43 has joined #bitcoin-core-dev
269 2020-10-12T15:01:44  *** joerodgers has joined #bitcoin-core-dev
270 2020-10-12T15:05:29  *** promag has joined #bitcoin-core-dev
271 2020-10-12T15:06:17  <promag> achow101: feel free to cherry pick, otherwise I'll update it only after yours is merged #20125
272 2020-10-12T15:06:19  <gribble> https://github.com/bitcoin/bitcoin/issues/20125 | rpc, wallet: Expose database format in getwalletinfo by promag · Pull Request #20125 · bitcoin/bitcoin · GitHub
273 2020-10-12T15:21:38  *** S3RK has joined #bitcoin-core-dev
274 2020-10-12T15:21:44  *** jhf has joined #bitcoin-core-dev
275 2020-10-12T15:24:04  *** mol has quit IRC
276 2020-10-12T15:24:12  *** joerodgers has quit IRC
277 2020-10-12T15:26:14  *** S3RK has quit IRC
278 2020-10-12T15:29:01  *** justanotheruser has quit IRC
279 2020-10-12T15:29:15  *** da39a3ee5e6b4b0d has quit IRC
280 2020-10-12T15:33:28  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
281 2020-10-12T15:35:56  *** Pavlenex has quit IRC
282 2020-10-12T15:38:41  <hebasto> achow101: thanks
283 2020-10-12T15:40:03  *** mol has joined #bitcoin-core-dev
284 2020-10-12T15:53:51  *** Pavlenex has joined #bitcoin-core-dev
285 2020-10-12T15:57:20  *** cltrbreak_MAD2 is now known as ctrlbreak
286 2020-10-12T16:02:42  *** promag has quit IRC
287 2020-10-12T16:03:15  *** promag has joined #bitcoin-core-dev
288 2020-10-12T16:04:37  *** promag has quit IRC
289 2020-10-12T16:04:50  *** promag has joined #bitcoin-core-dev
290 2020-10-12T16:07:33  *** Talkless has joined #bitcoin-core-dev
291 2020-10-12T16:10:24  *** promag has quit IRC
292 2020-10-12T16:11:00  *** promag has joined #bitcoin-core-dev
293 2020-10-12T16:14:02  *** proofofkeags_ has joined #bitcoin-core-dev
294 2020-10-12T16:14:02  *** proofofkeags has joined #bitcoin-core-dev
295 2020-10-12T16:15:18  *** proofofkeags_ has quit IRC
296 2020-10-12T16:15:19  *** proofofkeags has quit IRC
297 2020-10-12T16:15:45  *** proofofkeags has joined #bitcoin-core-dev
298 2020-10-12T16:15:45  *** proofofkeags_ has joined #bitcoin-core-dev
299 2020-10-12T16:19:56  *** kristapsk has joined #bitcoin-core-dev
300 2020-10-12T16:21:13  *** proofofkeags__ has joined #bitcoin-core-dev
301 2020-10-12T16:21:13  *** justanotheruser has joined #bitcoin-core-dev
302 2020-10-12T16:23:25  *** proofofkeags has quit IRC
303 2020-10-12T16:23:25  *** proofofkeags_ has quit IRC
304 2020-10-12T16:24:32  *** proofofkeags has joined #bitcoin-core-dev
305 2020-10-12T16:39:44  *** Pavlenex has quit IRC
306 2020-10-12T16:41:54  *** bitcoin-git has joined #bitcoin-core-dev
307 2020-10-12T16:41:54  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/af22322dab1a...f79a4a895279
308 2020-10-12T16:41:54  <bitcoin-git> bitcoin/master d4dde24 Hennadii Stepanov: net: Add CNode::m_inbound_onion data member
309 2020-10-12T16:41:55  <bitcoin-git> bitcoin/master 49fba9c Hennadii Stepanov: net: Add CNode::ConnectedThroughNetwork member function
310 2020-10-12T16:41:55  <bitcoin-git> bitcoin/master 3984b78 Hennadii Stepanov: test: Add tests for CNode::ConnectedThroughNetwork
311 2020-10-12T16:41:56  *** bitcoin-git has left #bitcoin-core-dev
312 2020-10-12T16:42:14  *** bitcoin-git has joined #bitcoin-core-dev
313 2020-10-12T16:42:14  <bitcoin-git> [bitcoin] laanwj merged pull request #19998: net: Add CNode::ConnectedThroughNetwork member function (master...200922-istor) https://github.com/bitcoin/bitcoin/pull/19998
314 2020-10-12T16:42:15  *** bitcoin-git has left #bitcoin-core-dev
315 2020-10-12T16:46:50  <luke-jr> jonatack: meshcollider: if you have a moment to re-ACK #19502 we can get it in :P
316 2020-10-12T16:46:52  <gribble> https://github.com/bitcoin/bitcoin/issues/19502 | Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks by luke-jr · Pull Request #19502 · bitcoin/bitcoin · GitHub
317 2020-10-12T17:09:38  *** promag_ has joined #bitcoin-core-dev
318 2020-10-12T17:14:37  *** joerodgers has joined #bitcoin-core-dev
319 2020-10-12T17:17:57  *** andreacab has joined #bitcoin-core-dev
320 2020-10-12T17:24:43  *** yanmaani has quit IRC
321 2020-10-12T17:30:21  *** promag_ has quit IRC
322 2020-10-12T17:34:01  *** yanmaani has joined #bitcoin-core-dev
323 2020-10-12T17:34:15  *** promag_ has joined #bitcoin-core-dev
324 2020-10-12T17:34:19  *** luke-jr has quit IRC
325 2020-10-12T17:36:19  *** Pavlenex has joined #bitcoin-core-dev
326 2020-10-12T17:36:44  *** luke-jr has joined #bitcoin-core-dev
327 2020-10-12T17:38:30  *** andreacab has quit IRC
328 2020-10-12T17:39:07  *** andreacab has joined #bitcoin-core-dev
329 2020-10-12T17:40:27  *** andreaca_ has joined #bitcoin-core-dev
330 2020-10-12T17:41:07  *** mol has quit IRC
331 2020-10-12T17:42:30  *** promag_ has quit IRC
332 2020-10-12T17:43:29  *** andreacab has quit IRC
333 2020-10-12T17:50:34  *** mol has joined #bitcoin-core-dev
334 2020-10-12T17:56:18  *** S3RK has joined #bitcoin-core-dev
335 2020-10-12T18:00:01  *** jhf has quit IRC
336 2020-10-12T18:00:40  *** S3RK has quit IRC
337 2020-10-12T18:01:43  *** andreaca_ has quit IRC
338 2020-10-12T18:01:52  *** andreacab has joined #bitcoin-core-dev
339 2020-10-12T18:05:46  *** andreacab has quit IRC
340 2020-10-12T18:06:12  *** andreacab has joined #bitcoin-core-dev
341 2020-10-12T18:08:56  *** pescador has joined #bitcoin-core-dev
342 2020-10-12T18:08:57  *** pescador has joined #bitcoin-core-dev
343 2020-10-12T18:10:21  *** andreacab has quit IRC
344 2020-10-12T18:14:40  *** promag has quit IRC
345 2020-10-12T18:14:55  *** promag has joined #bitcoin-core-dev
346 2020-10-12T18:16:41  *** filchef has joined #bitcoin-core-dev
347 2020-10-12T18:18:24  *** owowo has quit IRC
348 2020-10-12T18:20:01  *** promag has quit IRC
349 2020-10-12T18:20:42  *** promag has joined #bitcoin-core-dev
350 2020-10-12T18:23:01  *** owowo has joined #bitcoin-core-dev
351 2020-10-12T18:23:02  *** owowo has joined #bitcoin-core-dev
352 2020-10-12T18:25:22  <sipa> luke-jr: imports vs exports?
353 2020-10-12T18:25:39  *** promag has quit IRC
354 2020-10-12T18:25:53  *** promag has joined #bitcoin-core-dev
355 2020-10-12T18:30:37  *** promag has quit IRC
356 2020-10-12T18:31:10  *** promag has joined #bitcoin-core-dev
357 2020-10-12T18:37:09  *** justanotheruser has quit IRC
358 2020-10-12T18:43:05  *** Pavlenex has quit IRC
359 2020-10-12T18:44:13  *** mekster has quit IRC
360 2020-10-12T18:44:26  *** mekster has joined #bitcoin-core-dev
361 2020-10-12T18:48:48  *** Pavlenex has joined #bitcoin-core-dev
362 2020-10-12T18:52:34  *** Pavlenex1 has joined #bitcoin-core-dev
363 2020-10-12T18:54:33  *** Pavlenex1 has quit IRC
364 2020-10-12T18:55:36  *** Pavlenex1 has joined #bitcoin-core-dev
365 2020-10-12T18:56:14  *** Pavlenex has quit IRC
366 2020-10-12T18:56:14  *** Pavlenex1 is now known as Pavlenex
367 2020-10-12T18:57:08  *** dwfreed1 has joined #bitcoin-core-dev
368 2020-10-12T18:59:41  *** Pavlenex has quit IRC
369 2020-10-12T19:02:05  *** reallll has joined #bitcoin-core-dev
370 2020-10-12T19:04:24  *** belcher_ has quit IRC
371 2020-10-12T19:06:16  *** Talkless has quit IRC
372 2020-10-12T19:06:24  *** reallll is now known as belcher
373 2020-10-12T19:08:45  <MarcoFalke> I guess we could have moved the gui monotree to gitlab for comparison
374 2020-10-12T19:09:13  <MarcoFalke> Downside would be that all gui ppl need to create another account for review/pulls
375 2020-10-12T19:11:39  <sipa> MarcoFalke: if we need to move, i'd suggest moving everything
376 2020-10-12T19:11:46  <sipa> having split environments is even more annoying
377 2020-10-12T19:13:27  <MarcoFalke> Moving everything will be so much pain that not seeing review comments on a few prs seems almost acceptable
378 2020-10-12T19:13:44  <sipa> yes
379 2020-10-12T19:14:09  <sipa> that doesn't mean it's not something we should consider if problems linger\
380 2020-10-12T19:16:10  *** kyoo[m] has quit IRC
381 2020-10-12T19:16:11  *** TheFuzzStone[m] has quit IRC
382 2020-10-12T19:16:11  *** Pasta[m] has quit IRC
383 2020-10-12T19:16:11  *** rcrtn32002[m] has quit IRC
384 2020-10-12T19:16:21  *** awesome_doge1 has quit IRC
385 2020-10-12T19:16:22  *** tianshi[m] has quit IRC
386 2020-10-12T19:16:24  *** sethrogers23[m] has quit IRC
387 2020-10-12T19:16:25  *** snowkeld[m] has quit IRC
388 2020-10-12T19:16:27  *** icota[m] has quit IRC
389 2020-10-12T19:16:33  *** RaphalBentgeac[m has quit IRC
390 2020-10-12T19:19:26  *** belcher_ has joined #bitcoin-core-dev
391 2020-10-12T19:20:30  *** go121212 has joined #bitcoin-core-dev
392 2020-10-12T19:21:43  *** belcher has quit IRC
393 2020-10-12T19:22:41  *** go11111111111 has quit IRC
394 2020-10-12T19:24:01  *** awesome_doge has joined #bitcoin-core-dev
395 2020-10-12T19:31:15  *** Pavlenex has joined #bitcoin-core-dev
396 2020-10-12T19:31:26  *** andreacab has joined #bitcoin-core-dev
397 2020-10-12T19:38:45  *** rcrtn32002[m] has joined #bitcoin-core-dev
398 2020-10-12T19:38:46  *** TheFuzzStone[m] has joined #bitcoin-core-dev
399 2020-10-12T19:38:46  *** sethrogers23[m] has joined #bitcoin-core-dev
400 2020-10-12T19:38:46  *** kyoo[m] has joined #bitcoin-core-dev
401 2020-10-12T19:38:46  *** icota[m] has joined #bitcoin-core-dev
402 2020-10-12T19:38:46  *** snowkeld[m] has joined #bitcoin-core-dev
403 2020-10-12T19:38:52  *** tianshi[m] has joined #bitcoin-core-dev
404 2020-10-12T19:38:53  *** RaphalBentgeac[m has joined #bitcoin-core-dev
405 2020-10-12T19:38:53  *** Pasta[m] has joined #bitcoin-core-dev
406 2020-10-12T19:41:47  <luke-jr> MarcoFalke: even on GtiHub, everyone has to create another repo…
407 2020-10-12T19:56:08  *** promag_ has joined #bitcoin-core-dev
408 2020-10-12T19:56:09  *** andreacab has quit IRC
409 2020-10-12T19:59:51  *** pinheadmz has quit IRC
410 2020-10-12T20:00:42  *** pinheadmz has joined #bitcoin-core-dev
411 2020-10-12T20:02:55  <aj> looks like the api still works fwiw. http://azure.erisian.com.au/~aj/tmp/19988_COMMENTS.txt
412 2020-10-12T20:03:33  <aj> generated by -- for a in `seq 1 18`; do curl -s https://api.github.com/repos/bitcoin/bitcoin/pulls/19988/comments?page=$a >19988_comments.$a; echo $a; done    and   for a in `seq 1 18`; do curl -s https://api.github.com/repos/bitcoin/bitcoin/pulls/19988/comments?page=$a >19988_comments.$a; echo $a; done
413 2020-10-12T20:03:49  <aj> err
414 2020-10-12T20:04:03  <aj> generated by -- for a in `seq 1 18`; do curl -s https://api.github.com/repos/bitcoin/bitcoin/pulls/19988/comments?page=$a >19988_comments.$a; echo $a; done    and   cat 19988_comments.? 19988_comments.?? | jq -r '.[] | (.user.login + " " + .path + ":" + ((.line//.original_line | tostring) // empty) + "   " + (.created_at), .body, "--------------------------")' > 19988_COMMENTS.txt
415 2020-10-12T20:10:17  *** Guyver2 has quit IRC
416 2020-10-12T20:11:03  *** kristapsk has quit IRC
417 2020-10-12T20:11:27  *** kristapsk has joined #bitcoin-core-dev
418 2020-10-12T20:12:16  <sipa> aj: the "octodroid" android app also still works on it, though slowly
419 2020-10-12T20:17:58  *** jonatack has quit IRC
420 2020-10-12T20:19:02  <aj> sipa: does that mean giving your github pw to a thid party app dev?
421 2020-10-12T20:20:20  <sipa> aj: it's open source, and *obviously* i reviewed the code and compiled it myself before using *cough*
422 2020-10-12T20:20:29  *** jonatack has joined #bitcoin-core-dev
423 2020-10-12T20:20:35  <jonatack> aj: grazie mille for http://azure.erisian.com.au/~aj/tmp/19988_COMMENTS.txt
424 2020-10-12T20:27:12  *** bitcoin-git has joined #bitcoin-core-dev
425 2020-10-12T20:27:13  <bitcoin-git> [bitcoin] practicalswift opened pull request #20137: tests: Update UBSan suppressions file with suppressions needed for clang 12 (current trunk) (master...clang-12-ubsan-suppressions) https://github.com/bitcoin/bitcoin/pull/20137
426 2020-10-12T20:27:13  *** bitcoin-git has left #bitcoin-core-dev
427 2020-10-12T20:28:50  *** promag_ has quit IRC
428 2020-10-12T20:37:32  <luke-jr> sipa: ah, but did you compile your compiler yourself? ;)
429 2020-10-12T20:38:08  <luke-jr> I guess step 1 to migrating to a decentralised system would be to write a nice GUI app for GitHub's API?
430 2020-10-12T20:38:21  <luke-jr> (not Android because who wants to dev on their phone? XD)
431 2020-10-12T20:38:51  *** diogorsergio has quit IRC
432 2020-10-12T20:43:22  *** bitcoin-git has joined #bitcoin-core-dev
433 2020-10-12T20:43:22  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20138: net: Assume that SetCommonVersion is called at most once per peer (master...2010-netVersionOnlyOnce) https://github.com/bitcoin/bitcoin/pull/20138
434 2020-10-12T20:43:23  *** bitcoin-git has left #bitcoin-core-dev
435 2020-10-12T20:49:08  *** luke-jr has quit IRC
436 2020-10-12T20:49:57  *** promag_ has joined #bitcoin-core-dev
437 2020-10-12T20:51:32  <MarcoFalke> Ugh, is there any reason why GitHub would delete whole issues? #17298 is gone
438 2020-10-12T20:51:33  <gribble> https://github.com/bitcoin/bitcoin/issues/17298 | HTTP Error 404: Not Found
439 2020-10-12T20:53:52  *** luke-jr has joined #bitcoin-core-dev
440 2020-10-12T20:55:12  <aj> MarcoFalke: yikes
441 2020-10-12T20:56:04  <gwillen> what issue was it?
442 2020-10-12T20:56:23  <fjahr> What was it? Definitely admins can delete issues but I wouldn't know why github would do it on it's own.
443 2020-10-12T20:56:50  <gwillen> are you sure it existed? (and is whatever you thought it was?)
444 2020-10-12T20:56:51  <MarcoFalke> sometimes spam is deleted, I think
445 2020-10-12T20:56:54  <gwillen> I can't find any reference to it
446 2020-10-12T20:57:46  <sipa> i can't find any reference to it either
447 2020-10-12T20:58:01  <fjahr> Yeah, maybe that's what happened, spam issue was deleted by an admin
448 2020-10-12T21:00:01  *** dwfreed1 has quit IRC
449 2020-10-12T21:02:30  *** filchef has quit IRC
450 2020-10-12T21:07:36  *** bitcoin-git has joined #bitcoin-core-dev
451 2020-10-12T21:07:36  <bitcoin-git> [bitcoin] stackman27 opened pull request #20139: Removed unused warning and formatted RPC result (master...upgradewallet_rpc_cleanup) https://github.com/bitcoin/bitcoin/pull/20139
452 2020-10-12T21:07:37  *** bitcoin-git has left #bitcoin-core-dev
453 2020-10-12T21:08:26  <aj> "MinGW Runtime Assertion - Assertion failed! (#17298)"
454 2020-10-12T21:08:26  <gribble> https://github.com/bitcoin/bitcoin/issues/17298 | HTTP Error 404: Not Found
455 2020-10-12T21:10:10  <aj> closed by the submitter 31st oct 2019, doesn't seem at all spammy
456 2020-10-12T21:10:37  <gwillen> one thing I notice is that its title is identical to the title of an older issue
457 2020-10-12T21:10:52  <gwillen> which makes me wonder if github did some kind of erroneous database cleanup or something, although that would be crazy
458 2020-10-12T21:11:03  <sipa> i can't imagine that i would have deleted this issue; i can't speak for other maintainers
459 2020-10-12T21:11:16  <gwillen> (the older issue is #11812)
460 2020-10-12T21:11:17  <gribble> https://github.com/bitcoin/bitcoin/issues/11812 | MinGW Runtime Assertion - Assertion failed! · Issue #11812 · bitcoin/bitcoin · GitHub
461 2020-10-12T21:11:35  <gwillen> (I am taking aj's word for the contents of the newer issue since I can't see it -- I guess you had the page saved or something?)
462 2020-10-12T21:11:49  <sipa> i have the old issue in my email
463 2020-10-12T21:11:56  <sipa> yes, it's what aj says
464 2020-10-12T21:11:59  <aj> gwillen: no it was when i was getting emails for everything
465 2020-10-12T21:12:40  <sipa> SMTP notification is best notification
466 2020-10-12T21:15:49  <MarcoFalke> The GitHub database optimization sounds plausible (and horrible)
467 2020-10-12T21:16:11  <sipa> fanquake: do you have any insight?
468 2020-10-12T21:17:42  <MarcoFalke> I've seen this happen at least three times. I can look up all the issues that were deleted, if needed.
469 2020-10-12T21:21:13  <aj> https://api.github.com/repos/bitcoin/bitcoin/issues/17298/comments
470 2020-10-12T21:21:18  <aj>  ^-- works
471 2020-10-12T21:22:01  *** CrystalNice has joined #bitcoin-core-dev
472 2020-10-12T21:22:30  <sipa> heh, so if it was deleted it's certainly not well deleted
473 2020-10-12T21:22:49  <gwillen> the /events endpoints also still works, and the /labels endpoint gives an ... interesting failure (https://api.github.com/repos/bitcoin/bitcoin/issues/17298/labels)
474 2020-10-12T21:23:37  <gwillen> it seems like the issue is labelled with a dangling label... I wonder if that's related to it being missing.
475 2020-10-12T21:23:38  <sipa> can we try creating an issue and actually maintainer-deleting it, to see if the api result is identical?
476 2020-10-12T21:23:52  <sipa> if not, it's more evidence of a screwup on github's side we should report
477 2020-10-12T21:25:27  <aj> https://github.com/ajtowns/test-repo/issues/9
478 2020-10-12T21:25:33  <aj> is what i get when i delete an issue; not a 404
479 2020-10-12T21:26:00  <aj> and comments go away
480 2020-10-12T21:27:56  *** bitcoin-git has joined #bitcoin-core-dev
481 2020-10-12T21:27:56  <bitcoin-git> [bitcoin] sipa opened pull request #20140: Restore compatibility with old CSubNet serialization (master...202010_subnet_ser_compact) https://github.com/bitcoin/bitcoin/pull/20140
482 2020-10-12T21:27:57  *** bitcoin-git has left #bitcoin-core-dev
483 2020-10-12T21:30:36  <sipa> aj: definitely looks like a github issue...
484 2020-10-12T21:31:02  <sipa> MarcoFalke: we should report this
485 2020-10-12T21:32:04  <achow101> can confirm, doesn't look like spam
486 2020-10-12T21:35:27  <gwillen> hmmm, none of the submitter's comments seem to appear in /comments
487 2020-10-12T21:35:29  <luke-jr> aj: test the dangling label theory?
488 2020-10-12T21:35:57  <gwillen> I think I was mistaken about the dangling label, I think the ID it's complaining about is the issue itself
489 2020-10-12T21:36:21  <gwillen> (github uses numeric IDs for the REST API, but string IDs for the graphQL API)
490 2020-10-12T21:37:17  <gwillen> who was the submitter of the bug? I see a reply to a user named "StevenLee-CG" -- was that the submitter? That account doesn't seem to exist.
491 2020-10-12T21:37:29  <gwillen> Which makes me wonder if what happened was they deleted the account, with prejudice, and all associated objects, or something.
492 2020-10-12T21:39:59  <sipa> that seems plausible
493 2020-10-12T21:40:09  <gwillen> seems kind of rude.
494 2020-10-12T21:41:23  <sipa> aj: so your suggestion is removing the final commit from #19988 ?
495 2020-10-12T21:41:27  <gribble> https://github.com/bitcoin/bitcoin/issues/19988 | Overhaul transaction request logic by sipa · Pull Request #19988 · bitcoin/bitcoin · GitHub
496 2020-10-12T21:42:00  <aj> luke-jr: https://api.github.com/repos/ajtowns/test-repo/issues/10/labels  previously returned a "bug" label, after issue deletion just "Not found"
497 2020-10-12T21:42:20  *** jesseposner has joined #bitcoin-core-dev
498 2020-10-12T21:42:24  <luke-jr> aj: I mean make an issue, give it a label, then delete the label
499 2020-10-12T21:42:40  <luke-jr> but gwillen thinks it's not an issue, so..
500 2020-10-12T21:43:11  <aj> sipa: moving that commit to a separate PR maybe? are there any benefits to that patch other than simplifying/deleting code?
501 2020-10-12T21:43:15  <achow101> gwillen: when a user deletes their account, the issue should go to the "ghost" account
502 2020-10-12T21:43:27  <gwillen> I don't think this was a voluntary deletion
503 2020-10-12T21:43:49  <gwillen> I think this was some kind of aggressive admin deletion, like "account deleted for being a spammer" or for copyright violation or something
504 2020-10-12T21:44:27  <gwillen> otherwise it would be weird for it to leave the database in an inconsistent state like this (although ... that's weird anyway, and perhaps their code is just bad)
505 2020-10-12T21:44:49  <achow101> gwillen: perhaps. the user doesn't seem like a spammer though
506 2020-10-12T21:45:17  <gwillen> do we have an example of a comment or issue filed by a subsequently-deleted user?
507 2020-10-12T21:45:25  <sipa> aj: timing going backwards significantly seems like a problem in both variants really
508 2020-10-12T21:45:34  <sipa> aj: and the only real solution is using a steady clock
509 2020-10-12T21:46:21  <sipa> i'd say the code is a bit simpler now with the "now-monotonization" in it, and people have already looked at it
510 2020-10-12T21:46:24  <sipa> so i'd rather keep it
511 2020-10-12T21:46:39  <aj> sipa: in the original code it just means some announcements sit around until time catches up (in DELAYED or in REQUESTED if a notfound/tx doesn't come in) which doesn't seem a big deal?
512 2020-10-12T21:47:27  <sipa> or all timeout instantly
513 2020-10-12T21:47:33  <sipa> when it jumps forward
514 2020-10-12T21:48:23  <aj> sipa: right, that's jumping forward. but it only means the single thing that's "next" will get queued up, which seems fine?
515 2020-10-12T21:48:23  <sipa> i guess my comment is more about time jumping, not so much the backwards aspect of it
516 2020-10-12T21:48:51  <sipa> hmm, true
517 2020-10-12T21:49:12  <sipa> jnewbery: here?
518 2020-10-12T21:49:58  <aj> sipa: (hidden motivation is that i don't want to re-review all the original code to update my ack while knowing that it's about to be removed and the logic switched around in the last commit)
519 2020-10-12T21:50:41  <sipa> ok that's fair
520 2020-10-12T21:58:22  *** S3RK has joined #bitcoin-core-dev
521 2020-10-12T22:00:50  *** go11111111111 has joined #bitcoin-core-dev
522 2020-10-12T22:02:44  *** glozow has joined #bitcoin-core-dev
523 2020-10-12T22:02:51  *** S3RK has quit IRC
524 2020-10-12T22:03:42  *** go121212 has quit IRC
525 2020-10-12T22:04:18  <jnewbery> sipa: hi
526 2020-10-12T22:04:52  <sipa> jnewbery: i'm inclined to just remove the monotonic time last commit based on aj's comments above
527 2020-10-12T22:04:58  <sipa> wdyt?
528 2020-10-12T22:05:28  <jnewbery> fine by me. I have no strong opinion. I ACKed it before, I ACKed it after
529 2020-10-12T22:06:34  <jnewbery> I would like to freeze the PR soon and get it merged (as I'm sure you would). Seems ready, and any loose ends can be tidied up after feature freeze
530 2020-10-12T22:06:54  <sipa> jnewbery: regarding the invariants (but this is for a future PR), if TxRequestTracker maintains its own time (which it can do even if backward/forward at both allowed), then it's indeed possible to just enforce the invariants all the time with no real API complication
531 2020-10-12T22:07:11  <sipa> so i like that idea
532 2020-10-12T22:10:23  *** vasild has quit IRC
533 2020-10-12T22:11:56  <jnewbery> sipa: yeah, the only thing I think we might need to be careful about is whether that increases to cost of ReceivedInv() and RequestedTx() in the worst case, and whether that can be exploited
534 2020-10-12T22:12:00  <jnewbery> but I think it's ok
535 2020-10-12T22:12:31  *** vasild has joined #bitcoin-core-dev
536 2020-10-12T22:17:51  *** lukedashjr has joined #bitcoin-core-dev
537 2020-10-12T22:19:25  *** luke-jr has quit IRC
538 2020-10-12T22:21:59  *** lukedashjr is now known as luke-jr
539 2020-10-12T22:23:22  *** mdunnio has quit IRC
540 2020-10-12T22:30:30  <fanquake> sipa: unsure. I can bring it up with GitHub if someone hasn’t already
541 2020-10-12T22:37:41  *** Pavlenex has quit IRC
542 2020-10-12T22:42:16  *** justanotheruser has joined #bitcoin-core-dev
543 2020-10-12T22:56:43  *** promag has quit IRC
544 2020-10-12T22:56:56  *** promag has joined #bitcoin-core-dev
545 2020-10-12T23:01:32  *** promag has quit IRC
546 2020-10-12T23:02:06  *** promag has joined #bitcoin-core-dev
547 2020-10-12T23:03:51  *** mdunnio has joined #bitcoin-core-dev
548 2020-10-12T23:04:17  *** promag has quit IRC
549 2020-10-12T23:04:31  *** promag has joined #bitcoin-core-dev
550 2020-10-12T23:07:34  <sipa> vasild: see https://github.com/bitcoin/bitcoin/pull/20140
551 2020-10-12T23:08:43  *** mdunnio has quit IRC
552 2020-10-12T23:09:18  *** promag has quit IRC
553 2020-10-12T23:09:50  *** promag has joined #bitcoin-core-dev
554 2020-10-12T23:14:32  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
555 2020-10-12T23:16:45  *** da39a3ee5e6b4b0d has quit IRC
556 2020-10-12T23:20:33  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
557 2020-10-12T23:21:38  *** da39a3ee5e6b4b0d has quit IRC
558 2020-10-12T23:33:41  *** luke-jr has quit IRC
559 2020-10-12T23:34:12  *** luke-jr has joined #bitcoin-core-dev
560 2020-10-12T23:37:05  *** shaunsun_ has joined #bitcoin-core-dev
561 2020-10-12T23:39:44  *** shaunsun has quit IRC
562 2020-10-12T23:43:39  *** promag has quit IRC
563 2020-10-12T23:43:56  *** promag has joined #bitcoin-core-dev
564 2020-10-12T23:47:21  *** promag_ has quit IRC
565 2020-10-12T23:48:11  *** shaunsun__ has joined #bitcoin-core-dev
566 2020-10-12T23:48:41  *** promag has quit IRC
567 2020-10-12T23:49:22  *** promag has joined #bitcoin-core-dev
568 2020-10-12T23:50:39  *** shaunsun_ has quit IRC
569 2020-10-12T23:52:06  *** shaunsun_ has joined #bitcoin-core-dev
570 2020-10-12T23:55:10  *** shaunsun__ has quit IRC
571 2020-10-12T23:59:05  *** shaunsun_ has quit IRC