1 2020-11-30T00:04:22  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.161.165> has joined #bitcoin-core-dev
  2 2020-11-30T00:10:19  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
  3 2020-11-30T00:11:40  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
  4 2020-11-30T00:16:20  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Remote host closed the connection)
  5 2020-11-30T00:19:51  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
  6 2020-11-30T00:32:56  *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has quit IRC (Ping timeout: 240 seconds)
  7 2020-11-30T00:57:54  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
  8 2020-11-30T00:58:07  *** eugene-ff <eugene-ff!~eugene_ff@2604:2000:1383:472b:74fb:214:d521:e2ea> has joined #bitcoin-core-dev
  9 2020-11-30T00:58:38  *** eugene-ff <eugene-ff!~eugene_ff@2604:2000:1383:472b:74fb:214:d521:e2ea> has quit IRC (Client Quit)
 10 2020-11-30T01:01:01  *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has joined #bitcoin-core-dev
 11 2020-11-30T01:08:00  *** seanicided <seanicided!~sseanicid@23.154.160.165> has joined #bitcoin-core-dev
 12 2020-11-30T01:10:28  *** seanicided <seanicided!~sseanicid@23.154.160.165> has quit IRC (Client Quit)
 13 2020-11-30T01:10:40  *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has quit IRC (Ping timeout: 256 seconds)
 14 2020-11-30T01:12:38  *** promag_ <promag_!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
 15 2020-11-30T01:16:18  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.161.165> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 16 2020-11-30T01:17:42  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
 17 2020-11-30T01:18:38  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
 18 2020-11-30T01:22:29  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
 19 2020-11-30T01:26:55  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.161.165> has joined #bitcoin-core-dev
 20 2020-11-30T01:28:13  *** reallll <reallll!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
 21 2020-11-30T01:28:22  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 272 seconds)
 22 2020-11-30T01:38:23  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
 23 2020-11-30T01:40:31  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
 24 2020-11-30T01:41:57  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Remote host closed the connection)
 25 2020-11-30T01:43:54  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
 26 2020-11-30T01:52:30  *** Stephenmac98 <Stephenmac98!~Stephen@2603-6080-2340-023b-ad12-5f31-bfa3-e43d.res6.spectrum.com> has joined #bitcoin-core-dev
 27 2020-11-30T02:01:57  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
 28 2020-11-30T02:04:31  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 246 seconds)
 29 2020-11-30T02:13:14  *** shesek <shesek!~shesek@164.90.217.137> has joined #bitcoin-core-dev
 30 2020-11-30T02:21:12  *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has joined #bitcoin-core-dev
 31 2020-11-30T02:30:33  *** Stephenmac98 <Stephenmac98!~Stephen@2603-6080-2340-023b-ad12-5f31-bfa3-e43d.res6.spectrum.com> has quit IRC (Quit: Leaving)
 32 2020-11-30T03:00:13  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
 33 2020-11-30T03:01:27  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has quit IRC (Read error: Connection reset by peer)
 34 2020-11-30T03:02:16  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 240 seconds)
 35 2020-11-30T03:09:20  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
 36 2020-11-30T03:45:27  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.161.165> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 37 2020-11-30T04:02:29  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Remote host closed the connection)
 38 2020-11-30T04:02:40  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
 39 2020-11-30T04:16:01  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.161.165> has joined #bitcoin-core-dev
 40 2020-11-30T04:24:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 41 2020-11-30T04:24:05  <bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/7ae86b3c6845...2e1336dbfe8a
 42 2020-11-30T04:24:05  <bitcoin-git> bitcoin/master 2dde557 fanquake: depends: build bdb with -std=c++17
 43 2020-11-30T04:24:06  <bitcoin-git> bitcoin/master 2374f2f fanquake: depends: build Boost with -std=c++17
 44 2020-11-30T04:24:06  <bitcoin-git> bitcoin/master e2c5006 fanquake: depends: build zeromq with -std=c++17
 45 2020-11-30T04:24:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 46 2020-11-30T04:24:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 47 2020-11-30T04:24:25  <bitcoin-git> [bitcoin] fanquake merged pull request #20471: build: use C++17 in depends (master...depends_c++17) https://github.com/bitcoin/bitcoin/pull/20471
 48 2020-11-30T04:24:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 49 2020-11-30T04:24:39  *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has quit IRC (Read error: Connection reset by peer)
 50 2020-11-30T04:25:29  *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has joined #bitcoin-core-dev
 51 2020-11-30T04:51:17  *** brycec1 <brycec1!~brycec@195.140.213.38> has quit IRC (Remote host closed the connection)
 52 2020-11-30T05:11:45  *** TRB1431 <TRB1431!~TRB143@84.39.117.57> has joined #bitcoin-core-dev
 53 2020-11-30T05:26:11  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
 54 2020-11-30T05:28:03  *** achow101 <achow101!~achow101@unaffiliated/achow101> has quit IRC (Quit: Bye)
 55 2020-11-30T05:28:13  *** achow101 <achow101!~achow101@unaffiliated/achow101> has joined #bitcoin-core-dev
 56 2020-11-30T05:31:01  *** achow101 <achow101!~achow101@unaffiliated/achow101> has quit IRC (Client Quit)
 57 2020-11-30T05:31:11  *** achow101 <achow101!~achow101@unaffiliated/achow101> has joined #bitcoin-core-dev
 58 2020-11-30T05:50:51  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Remote host closed the connection)
 59 2020-11-30T06:04:27  *** TRB1431 <TRB1431!~TRB143@84.39.117.57> has quit IRC (Remote host closed the connection)
 60 2020-11-30T06:05:08  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
 61 2020-11-30T06:09:52  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 256 seconds)
 62 2020-11-30T06:15:27  *** Trixar_za <Trixar_za!~Trixar_za@185.163.110.116> has joined #bitcoin-core-dev
 63 2020-11-30T06:42:56  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
 64 2020-11-30T06:52:09  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
 65 2020-11-30T06:55:03  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
 66 2020-11-30T06:57:01  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
 67 2020-11-30T07:50:37  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
 68 2020-11-30T08:11:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 69 2020-11-30T08:11:13  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2e1336dbfe8a...817aeca57a4c
 70 2020-11-30T08:11:13  <bitcoin-git> bitcoin/master 830ddf4 Hennadii Stepanov: Drop noop gcc version checks
 71 2020-11-30T08:11:14  <bitcoin-git> bitcoin/master 817aeca fanquake: Merge #20491: refactor: Drop noop gcc version checks
 72 2020-11-30T08:11:16  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 73 2020-11-30T08:11:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 74 2020-11-30T08:11:32  <bitcoin-git> [bitcoin] fanquake merged pull request #20491: refactor: Drop noop gcc version checks (master...201125-gcc) https://github.com/bitcoin/bitcoin/pull/20491
 75 2020-11-30T08:11:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 76 2020-11-30T08:17:09  *** Zack72 <Zack72!58f3467e@88.243.70.126> has joined #bitcoin-core-dev
 77 2020-11-30T08:19:56  *** Pavlenex <Pavlenex!~Thunderbi@178.220.103.52> has joined #bitcoin-core-dev
 78 2020-11-30T08:22:45  *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has quit IRC (Ping timeout: 240 seconds)
 79 2020-11-30T08:25:21  *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has joined #bitcoin-core-dev
 80 2020-11-30T08:28:59  *** Zack72 <Zack72!58f3467e@88.243.70.126> has quit IRC (Remote host closed the connection)
 81 2020-11-30T08:38:26  *** someone235 <someone235!uid419897@gateway/web/irccloud.com/x-xrruhlejkwndamue> has joined #bitcoin-core-dev
 82 2020-11-30T08:51:32  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
 83 2020-11-30T09:09:46  <willcl_ark> luke-jr: I've been trying out ripgrep recently. It can handle multiple directories and seems to be pretty fast.  e.g.  `rg CTxDestination bitcoin*` will search all directories in current dir starting with bitcoin.
 84 2020-11-30T09:14:19  <willcl_ark> There's also an interesting writeup of a 'speedtest' here FYI https://blog.burntsushi.net/ripgrep/
 85 2020-11-30T09:14:57  <sipa> i've never had a situation where "git grep" in the bitcoin repo wasn't fast enough
 86 2020-11-30T09:24:14  *** reallll is now known as belcher
 87 2020-11-30T09:32:18  <willcl_ark> Agreed. I imagined Luke might be trying to grep bitcoin and bitcoin-gui repos at the same time, and using some small script to bolt together two git searches? Not familiar with git-grep-all tbh :)
 88 2020-11-30T09:35:27  *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has quit IRC (Quit: Find me in #TheHolyRoger or https://theholyroger.com)
 89 2020-11-30T09:40:54  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 260 seconds)
 90 2020-11-30T09:41:15  *** gleb <gleb!~gleb@178.150.137.228> has quit IRC (Quit: Ping timeout (120 seconds))
 91 2020-11-30T09:41:41  *** gleb <gleb!~gleb@178.150.137.228> has joined #bitcoin-core-dev
 92 2020-11-30T09:43:34  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Remote host closed the connection)
 93 2020-11-30T09:47:09  *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has joined #bitcoin-core-dev
 94 2020-11-30T09:59:05  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
 95 2020-11-30T10:03:16  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.161.165> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 96 2020-11-30T10:08:26  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 256 seconds)
 97 2020-11-30T10:08:26  *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
 98 2020-11-30T10:08:56  *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
 99 2020-11-30T10:33:52  *** bosch-0 <bosch-0!uid472282@gateway/web/irccloud.com/x-dsrkxgksxcxzzvbo> has joined #bitcoin-core-dev
100 2020-11-30T10:36:31  *** Kiminuo <Kiminuo!~mix@141.98.103.172> has joined #bitcoin-core-dev
101 2020-11-30T10:41:47  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
102 2020-11-30T10:43:24  *** Pavlenex1 <Pavlenex1!~Thunderbi@141.98.103.251> has joined #bitcoin-core-dev
103 2020-11-30T10:46:20  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 272 seconds)
104 2020-11-30T10:46:36  *** Pavlenex <Pavlenex!~Thunderbi@178.220.103.52> has quit IRC (Ping timeout: 240 seconds)
105 2020-11-30T10:46:36  *** Pavlenex1 is now known as Pavlenex
106 2020-11-30T11:09:49  *** iamgr00t <iamgr00t!~iamgr00t@unaffiliated/iamgr00t> has joined #bitcoin-core-dev
107 2020-11-30T11:14:37  *** filchef <filchef!~filchef@212.104.97.177> has joined #bitcoin-core-dev
108 2020-11-30T11:18:31  *** Jeffrey4Casper <Jeffrey4Casper!~Jeffrey4C@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
109 2020-11-30T11:22:40  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
110 2020-11-30T11:25:55  *** Jeffrey4Casper <Jeffrey4Casper!~Jeffrey4C@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 265 seconds)
111 2020-11-30T11:28:59  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
112 2020-11-30T11:33:36  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 260 seconds)
113 2020-11-30T11:46:09  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
114 2020-11-30T11:49:18  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 256 seconds)
115 2020-11-30T12:04:36  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 240 seconds)
116 2020-11-30T12:25:32  *** Trixar_za <Trixar_za!~Trixar_za@185.163.110.116> has quit IRC (Remote host closed the connection)
117 2020-11-30T12:27:20  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.161.165> has joined #bitcoin-core-dev
118 2020-11-30T12:54:21  *** eugene-ff <eugene-ff!~eugene_ff@2604:2000:1383:472b:a0ea:5202:fc81:f7d7> has joined #bitcoin-core-dev
119 2020-11-30T13:05:22  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Remote host closed the connection)
120 2020-11-30T13:05:45  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
121 2020-11-30T13:07:40  *** eugene-ff <eugene-ff!~eugene_ff@2604:2000:1383:472b:a0ea:5202:fc81:f7d7> has quit IRC ()
122 2020-11-30T13:09:23  *** eugene-ff <eugene-ff!~eugene_ff@2604:2000:1383:472b:a0ea:5202:fc81:f7d7> has joined #bitcoin-core-dev
123 2020-11-30T13:12:11  *** eugene-ff <eugene-ff!~eugene_ff@2604:2000:1383:472b:a0ea:5202:fc81:f7d7> has quit IRC (Client Quit)
124 2020-11-30T13:18:09  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.161.165> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
125 2020-11-30T13:18:35  *** aGHz_nfb <aGHz_nfb!~aGHz_nfb@185.163.110.116> has joined #bitcoin-core-dev
126 2020-11-30T13:26:22  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
127 2020-11-30T13:27:03  *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Ping timeout: 240 seconds)
128 2020-11-30T13:28:29  *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
129 2020-11-30T13:30:49  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 264 seconds)
130 2020-11-30T13:35:24  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
131 2020-11-30T13:38:43  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
132 2020-11-30T13:38:44  *** vasild_ is now known as vasild
133 2020-11-30T13:50:41  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.161.165> has joined #bitcoin-core-dev
134 2020-11-30T13:57:43  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
135 2020-11-30T14:00:20  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
136 2020-11-30T14:01:24  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
137 2020-11-30T14:03:09  *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
138 2020-11-30T14:03:19  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
139 2020-11-30T14:18:41  *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
140 2020-11-30T14:19:06  *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
141 2020-11-30T14:21:20  <luke-jr> willcl_ark: git-grep-all searches all objects in the repo
142 2020-11-30T14:21:26  <luke-jr> sipa: ^
143 2020-11-30T14:23:38  *** bosch-0 <bosch-0!uid472282@gateway/web/irccloud.com/x-dsrkxgksxcxzzvbo> has quit IRC (Quit: Connection closed for inactivity)
144 2020-11-30T14:42:29  <willcl_ark> Ah I see luke-jr, thanks. Then ripgrep will not be able to help you as it can't search all repo objects.
145 2020-11-30T14:44:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
146 2020-11-30T14:44:52  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/817aeca57a4c...81d5af42f4db
147 2020-11-30T14:44:52  <bitcoin-git> bitcoin/master 4848e71 practicalswift: scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD
148 2020-11-30T14:44:53  <bitcoin-git> bitcoin/master 79bff8e practicalswift: Remove NODISCARD
149 2020-11-30T14:44:54  <bitcoin-git> bitcoin/master 81d5af4 MarcoFalke: Merge #20499: Remove obsolete NODISCARD ifdef forest. Use [[nodiscard]] (C...
150 2020-11-30T14:44:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
151 2020-11-30T14:45:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
152 2020-11-30T14:45:11  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20499: Remove obsolete NODISCARD ifdef forest. Use [[nodiscard]] (C++17).  (master...remove-nodiscard-cruft) https://github.com/bitcoin/bitcoin/pull/20499
153 2020-11-30T14:45:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
154 2020-11-30T14:54:21  *** promag_ <promag_!~promag@188.250.84.129> has joined #bitcoin-core-dev
155 2020-11-30T15:01:04  *** sturles <sturles!~sturles@unaffiliated/sturles> has quit IRC (Remote host closed the connection)
156 2020-11-30T15:02:35  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Remote host closed the connection)
157 2020-11-30T15:02:54  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
158 2020-11-30T15:03:05  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.161.165> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
159 2020-11-30T15:07:18  *** queip is now known as CobraKai
160 2020-11-30T15:07:35  *** CobraKai is now known as queip
161 2020-11-30T15:08:07  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has quit IRC (Read error: Connection reset by peer)
162 2020-11-30T15:13:54  *** miketwen_ <miketwen_!~miketwent@ec2-35-172-206-57.compute-1.amazonaws.com> has joined #bitcoin-core-dev
163 2020-11-30T15:17:37  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 264 seconds)
164 2020-11-30T15:19:26  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
165 2020-11-30T15:23:21  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
166 2020-11-30T15:30:54  *** Kiminuo <Kiminuo!~mix@141.98.103.172> has quit IRC (Ping timeout: 260 seconds)
167 2020-11-30T15:33:52  *** kexkey <kexkey!~kexkey@static-198-54-132-105.cust.tzulo.com> has joined #bitcoin-core-dev
168 2020-11-30T15:59:12  *** queip <queip!~queip@unaffiliated/rezurus> has quit IRC (Ping timeout: 272 seconds)
169 2020-11-30T15:59:26  *** miketwen_ <miketwen_!~miketwent@ec2-35-172-206-57.compute-1.amazonaws.com> has quit IRC (Remote host closed the connection)
170 2020-11-30T16:03:55  *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has quit IRC (Quit: Pavlenex)
171 2020-11-30T16:09:37  *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has joined #bitcoin-core-dev
172 2020-11-30T16:15:20  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Remote host closed the connection)
173 2020-11-30T16:18:17  *** miketwenty1 <miketwenty1!~miketwent@ec2-52-207-61-44.compute-1.amazonaws.com> has joined #bitcoin-core-dev
174 2020-11-30T16:20:46  <hebasto> sipa: does your ip address crawler see tor v3 addresses in the main network due to rc2 has been published last week?
175 2020-11-30T16:26:21  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
176 2020-11-30T16:27:44  *** queip <queip!~queip@unaffiliated/rezurus> has joined #bitcoin-core-dev
177 2020-11-30T16:28:50  *** [\\\] is now known as tripleslash
178 2020-11-30T16:36:04  *** Dakata <Dakata!25c9d7ee@aftr-37-201-215-238.unity-media.net> has joined #bitcoin-core-dev
179 2020-11-30T16:37:08  *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has quit IRC (Quit: Pavlenex)
180 2020-11-30T16:39:46  *** Dakata <Dakata!25c9d7ee@aftr-37-201-215-238.unity-media.net> has quit IRC (Remote host closed the connection)
181 2020-11-30T16:39:50  *** kristapsk_ is now known as kristapsk
182 2020-11-30T16:45:46  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
183 2020-11-30T16:59:37  *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has joined #bitcoin-core-dev
184 2020-11-30T17:10:27  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC ()
185 2020-11-30T17:21:23  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
186 2020-11-30T17:23:08  <sipa> hebasto: no
187 2020-11-30T17:23:20  <sipa> hebasto: PRs welcome
188 2020-11-30T17:24:17  <hebasto> sipa: thanks
189 2020-11-30T17:26:10  <sipa> oh wait
190 2020-11-30T17:26:27  <sipa> it can't even expose them over DNS
191 2020-11-30T17:26:32  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
192 2020-11-30T17:27:09  <hebasto> DNS restrictions?
193 2020-11-30T17:29:20  <sipa> well there is no space for onion addresses in IPv6
194 2020-11-30T17:29:24  <sipa> *v3
195 2020-11-30T17:30:37  <luke-jr> TXT?
196 2020-11-30T17:34:18  <luke-jr> SRV might be a good fit actually
197 2020-11-30T17:35:34  <luke-jr> or URI record
198 2020-11-30T17:36:22  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
199 2020-11-30T17:36:46  <pinheadmz> lightning uses SRV in bolt 10: https://github.com/lightningnetwork/lightning-rfc/blob/master/10-dns-bootstrap.md#examples
200 2020-11-30T17:36:47  <pinheadmz> pretty clever
201 2020-11-30T17:40:05  <sipa> can standard resolvers query SRV records?
202 2020-11-30T17:41:41  *** lightlike <lightlike!~lightlike@p200300c7ef177a00b8e983ade8f2d04e.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
203 2020-11-30T17:44:04  <pinheadmz> what do you mean? the rfc is 20 years old, i think if the nameserver has an SRV record you can dig it
204 2020-11-30T17:44:09  <pinheadmz> trying to find a live example
205 2020-11-30T17:45:13  <pinheadmz> actually the exmple in bolt 10 works
206 2020-11-30T17:45:13  <pinheadmz>  dig lseed.bitcoinstats.com SRV
207 2020-11-30T17:45:23  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
208 2020-11-30T17:47:12  *** jbarcelo <jbarcelo!43daf305@67.218.243.5> has joined #bitcoin-core-dev
209 2020-11-30T17:47:28  <sipa> pinheadmz: i mean, you can't just use getaddrinfo to retrieve it, can you?
210 2020-11-30T17:47:37  *** molz_ <molz_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 264 seconds)
211 2020-11-30T17:47:42  <sipa> you actually need a DNS client library
212 2020-11-30T17:48:29  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
213 2020-11-30T17:50:38  <pinheadmz> ah i see
214 2020-11-30T17:52:21  *** Kiminuo <Kiminuo!~mix@141.98.103.172> has joined #bitcoin-core-dev
215 2020-11-30T17:52:43  *** Guyver2_ is now known as Guyver2
216 2020-11-30T18:02:17  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
217 2020-11-30T18:02:29  *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has quit IRC (Quit: Pavlenex)
218 2020-11-30T18:02:34  <luke-jr> well, presuambly we're not using getaddrinfo with Tor
219 2020-11-30T18:02:42  <luke-jr> so the real question is if Tor can do it ;)
220 2020-11-30T18:04:38  <sipa> we don't use DNS at all over Tor
221 2020-11-30T18:05:51  <luke-jr> …wasn't that the topic?
222 2020-11-30T18:06:16  <sipa> instead we use getaddr peers (just connect by name to a DNS seed, using the P2P protocol, do a getaddr, and wait for an addr response)
223 2020-11-30T18:06:56  <sipa> luke-jr: what currently works for torv2 but not torv3 is learning about them over IPv4/IPv6 from seed nodes
224 2020-11-30T18:09:10  <sipa> but maybe that's not all that important a use case
225 2020-11-30T18:10:22  <pinheadmz> sipa when we use DNS seeds, we don't make a DNS request to the seed?
226 2020-11-30T18:10:34  <sipa> pinheadmz: no, we *resolve* the seed
227 2020-11-30T18:10:42  <sipa> and it resolves to one or more IP addresses
228 2020-11-30T18:11:18  <pinheadmz> ah, TIL so there is no `dig bitcoin.sipa.de` or whatever. I always thought we use A records from the seed to bootstrap
229 2020-11-30T18:11:18  <sipa> doing so likely makes your OS's/ISP's resolver connect to the DNS seed server, but that's transparent from bitcoin core's perspective
230 2020-11-30T18:11:58  <sipa> all it sees is looking up a name, and getting IP addresses back, using your OS's name resolving functionality
231 2020-11-30T18:14:06  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Read error: Connection reset by peer)
232 2020-11-30T18:14:57  <pinheadmz> actually im not getting anything from seed.bitcoin.sipa.be but I am from `dig dnsseed.bluematt.me`
233 2020-11-30T18:15:21  <pinheadmz> so when we bootstrap we use DNS to get a bunch of A records, then add those IPs to addrman and start connecting
234 2020-11-30T18:15:30  <sipa> yeah
235 2020-11-30T18:15:57  <sipa> but from bitcoin core's perspective there is no such thing as A or AAAA or CNAME or whatever records or DNS involved
236 2020-11-30T18:16:06  <pinheadmz> yeah
237 2020-11-30T18:16:07  <sipa> it asks for a name, and get IPv4 and IPv6 addresses back from the OS
238 2020-11-30T18:16:15  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
239 2020-11-30T18:16:27  <sipa> they could be coming from your local /etc/hosts file instead
240 2020-11-30T18:17:41  *** proofofkeags <proofofkeags!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has joined #bitcoin-core-dev
241 2020-11-30T18:18:28  <pinheadmz> but over tor we connect directly to the "seed" and do a getaddr
242 2020-11-30T18:18:45  *** user___ <user___!~user@mail.deeplinkmedia.com> has quit IRC (Ping timeout: 240 seconds)
243 2020-11-30T18:19:44  <sipa> yes, because you can't do DNS resolving over Tor (that'd require a DNS implementation in bitcoin core, and route it over tor)
244 2020-11-30T18:20:23  <sipa> instead we just "connect" to the seed, which makes the Tor exit node do the resolving - *not* tell us the result of that resolving - but instead forwarding our connection to it
245 2020-11-30T18:21:33  <pinheadmz> oh I see, so it still may not be the full node at bitcoin.sipa.be that we conenct to, but any one of the nodes returned in A records to the exit node, which thinks we are just resolving a single service by name
246 2020-11-30T18:21:48  <sipa> seed.bitcoin.sipa.be may not even *have* a full node
247 2020-11-30T18:21:55  <pinheadmz> gotcha
248 2020-11-30T18:22:39  <sipa> or maybe it's more accurate to say it "has" many full nodes, namely all the IPs it resolves to
249 2020-11-30T18:22:56  <sipa> but none of them are particularly likely to be operated by the operator of the DNS seed itself
250 2020-11-30T18:27:24  *** dviola <dviola!~diego@unaffiliated/dviola> has quit IRC (Ping timeout: 272 seconds)
251 2020-11-30T18:29:45  *** davterra <davterra!~davterra@68.235.43.102> has quit IRC (Remote host closed the connection)
252 2020-11-30T18:38:22  *** jbarcelo <jbarcelo!43daf305@67.218.243.5> has quit IRC (Remote host closed the connection)
253 2020-11-30T18:44:17  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
254 2020-11-30T18:46:25  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Ping timeout: 240 seconds)
255 2020-11-30T18:48:36  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
256 2020-11-30T19:44:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
257 2020-11-30T19:44:12  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20535: test: Fix intermittent feature_taproot issue (master...2011-testTapInt) https://github.com/bitcoin/bitcoin/pull/20535
258 2020-11-30T19:44:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
259 2020-11-30T19:47:06  *** davterra <davterra!~davterra@68.235.43.102> has joined #bitcoin-core-dev
260 2020-11-30T19:57:47  <phantomcircuit> sipa, because they don't fit in ipv6 records i don't think there's anyway to return them that will be cached by intermediate servers, which is probably what really matters
261 2020-11-30T19:58:02  <phantomcircuit> otherwise could just use the bootstrap peer mechanism
262 2020-11-30T20:00:56  <sipa> phantomcircuit: right
263 2020-11-30T20:11:54  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
264 2020-11-30T20:15:23  *** user____ <user____!~user@mail.deeplinkmedia.com> has joined #bitcoin-core-dev
265 2020-11-30T20:44:10  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 246 seconds)
266 2020-11-30T20:45:18  *** promag_ <promag_!~promag@188.250.84.129> has quit IRC ()
267 2020-11-30T20:49:19  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has joined #bitcoin-core-dev
268 2020-11-30T21:24:17  *** Chris_Stewart_5 <Chris_Stewart_5!~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383> has quit IRC (Ping timeout: 265 seconds)
269 2020-11-30T21:31:20  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
270 2020-11-30T21:32:03  *** Chris_Stewart_5 <Chris_Stewart_5!~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383> has joined #bitcoin-core-dev
271 2020-11-30T21:35:23  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
272 2020-11-30T21:39:49  *** Kiminuo <Kiminuo!~mix@141.98.103.172> has quit IRC (Ping timeout: 264 seconds)
273 2020-11-30T21:40:35  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
274 2020-11-30T21:49:20  *** shesek <shesek!~shesek@164.90.217.137> has joined #bitcoin-core-dev
275 2020-11-30T21:49:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
276 2020-11-30T21:49:44  <bitcoin-git> [bitcoin] achow101 opened pull request #20536: wallet: Error with "Transaction too large" if the funded tx will end up being too large after signing (master...fundtx-error-large-tx) https://github.com/bitcoin/bitcoin/pull/20536
277 2020-11-30T21:49:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
278 2020-11-30T21:57:17  *** HELPME1245a <HELPME1245a!~jg@89.249.64.220> has joined #bitcoin-core-dev
279 2020-11-30T21:58:25  *** HELPME1245a <HELPME1245a!~jg@89.249.64.220> has quit IRC (Max SendQ exceeded)
280 2020-11-30T21:58:48  *** HELPME1245a <HELPME1245a!~jg@89.249.64.220> has joined #bitcoin-core-dev
281 2020-11-30T21:58:49  *** HELPME1245a <HELPME1245a!~jg@89.249.64.220> has quit IRC (Max SendQ exceeded)
282 2020-11-30T21:59:08  *** HELPME1245a <HELPME1245a!~jg@89.249.64.220> has joined #bitcoin-core-dev
283 2020-11-30T21:59:09  *** HELPME1245a <HELPME1245a!~jg@89.249.64.220> has quit IRC (Max SendQ exceeded)
284 2020-11-30T21:59:33  *** HELPME1245a <HELPME1245a!~jg@89.249.64.220> has joined #bitcoin-core-dev
285 2020-11-30T21:59:34  *** HELPME1245a <HELPME1245a!~jg@89.249.64.220> has quit IRC (Max SendQ exceeded)
286 2020-11-30T21:59:54  *** HELPME1245a <HELPME1245a!~jg@89.249.64.220> has joined #bitcoin-core-dev
287 2020-11-30T22:00:07  *** HELPME1245a <HELPME1245a!~jg@89.249.64.220> has quit IRC (Max SendQ exceeded)
288 2020-11-30T22:00:28  *** HELPME1245a <HELPME1245a!~jg@89.249.64.220> has joined #bitcoin-core-dev
289 2020-11-30T22:13:12  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Ping timeout: 256 seconds)
290 2020-11-30T22:19:21  *** HELPME1245a <HELPME1245a!~jg@89.249.64.220> has quit IRC (Quit: Leaving)
291 2020-11-30T22:24:13  *** filchef <filchef!~filchef@212.104.97.177> has quit IRC (Read error: Connection reset by peer)
292 2020-11-30T22:25:53  *** nckx is now known as ncksneekx
293 2020-11-30T22:26:03  *** ncksneekx is now known as nckx
294 2020-11-30T22:37:24  *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has joined #bitcoin-core-dev
295 2020-11-30T22:37:58  *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has quit IRC (Client Quit)
296 2020-11-30T22:38:51  *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
297 2020-11-30T22:39:25  *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
298 2020-11-30T22:44:32  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
299 2020-11-30T22:45:43  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
300 2020-11-30T22:45:44  *** vasild_ is now known as vasild
301 2020-11-30T23:04:33  *** ctrlbreak <ctrlbreak!~ctrlbreak@159.2.182.106> has quit IRC (Read error: Connection reset by peer)
302 2020-11-30T23:05:00  *** ctrlbreak <ctrlbreak!~ctrlbreak@159.2.182.106> has joined #bitcoin-core-dev
303 2020-11-30T23:07:25  *** Klox04809318631 <Klox04809318631!~Klox@c-24-1-131-19.hsd1.il.comcast.net> has quit IRC (Ping timeout: 240 seconds)
304 2020-11-30T23:09:04  *** Klox04809318631 <Klox04809318631!~Klox@c-24-1-131-19.hsd1.il.comcast.net> has joined #bitcoin-core-dev
305 2020-11-30T23:11:44  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
306 2020-11-30T23:11:45  *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
307 2020-11-30T23:12:11  *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
308 2020-11-30T23:23:17  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
309 2020-11-30T23:24:35  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
310 2020-11-30T23:28:01  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 265 seconds)
311 2020-11-30T23:35:56  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 256 seconds)
312 2020-11-30T23:39:51  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Read error: Connection reset by peer)
313 2020-11-30T23:47:25  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
314 2020-11-30T23:53:20  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev