1 2020-12-04T00:01:02  *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-suaydrfreocgdkkl> has quit IRC (Quit: Connection closed for inactivity)
  2 2020-12-04T00:02:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
  3 2020-12-04T00:02:25  <bitcoin-git> [bitcoin] BlockMechanic opened pull request #20565: Android : Ensure pic build for bdb (master...fix-bdb-android) https://github.com/bitcoin/bitcoin/pull/20565
  4 2020-12-04T00:02:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
  5 2020-12-04T00:09:17  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
  6 2020-12-04T00:12:17  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:a1c2:b119:a4c8:3942:7eb> has joined #bitcoin-core-dev
  7 2020-12-04T00:41:18  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 260 seconds)
  8 2020-12-04T00:43:39  *** proofofkeags <proofofkeags!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has quit IRC (Remote host closed the connection)
  9 2020-12-04T00:44:04  *** proofofkeags <proofofkeags!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has joined #bitcoin-core-dev
 10 2020-12-04T00:56:57  *** amiti <amiti!sid373138@gateway/web/irccloud.com/x-ivprtaazvjpsstjf> has quit IRC (Ping timeout: 244 seconds)
 11 2020-12-04T00:56:57  *** valwal_ <valwal_!sid334773@gateway/web/irccloud.com/x-qlebbpueqzhclgdu> has quit IRC (Ping timeout: 244 seconds)
 12 2020-12-04T00:57:45  *** troygiorshev <troygiorshev!~troygiors@d67-193-140-136.home3.cgocable.net> has quit IRC (Quit: leaving)
 13 2020-12-04T00:57:59  *** michagogo <michagogo!sid14316@wikia/Michagogo> has quit IRC (Ping timeout: 244 seconds)
 14 2020-12-04T00:58:18  *** amiti <amiti!sid373138@gateway/web/irccloud.com/x-ayunlkaefenrhtuj> has joined #bitcoin-core-dev
 15 2020-12-04T00:58:21  *** valwal_ <valwal_!sid334773@gateway/web/irccloud.com/x-xpdkkmqnrtcjkded> has joined #bitcoin-core-dev
 16 2020-12-04T00:59:01  *** michagogo <michagogo!sid14316@wikia/Michagogo> has joined #bitcoin-core-dev
 17 2020-12-04T00:59:30  *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Read error: Connection reset by peer)
 18 2020-12-04T00:59:33  *** Emcy_ <Emcy_!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
 19 2020-12-04T01:09:52  *** proofofkeags <proofofkeags!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has quit IRC (Ping timeout: 246 seconds)
 20 2020-12-04T01:10:40  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
 21 2020-12-04T01:12:53  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC ()
 22 2020-12-04T01:56:47  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
 23 2020-12-04T02:09:29  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
 24 2020-12-04T02:10:46  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 246 seconds)
 25 2020-12-04T02:15:40  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:a1c2:b119:a4c8:3942:7eb> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 26 2020-12-04T02:17:50  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@> has joined #bitcoin-core-dev
 27 2020-12-04T02:36:04  *** freeyao <freeyao!ac69eb05@> has joined #bitcoin-core-dev
 28 2020-12-04T02:36:29  *** freeyao <freeyao!ac69eb05@> has quit IRC (Remote host closed the connection)
 29 2020-12-04T02:42:59  *** promag <promag!~promag@> has joined #bitcoin-core-dev
 30 2020-12-04T03:00:53  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
 31 2020-12-04T03:03:22  *** pinheadm_ <pinheadm_!~pinheadmz@> has joined #bitcoin-core-dev
 32 2020-12-04T03:05:52  *** pinheadmz <pinheadmz!~pinheadmz@> has quit IRC (Ping timeout: 256 seconds)
 33 2020-12-04T03:06:36  *** pinheadmz <pinheadmz!~pinheadmz@> has joined #bitcoin-core-dev
 34 2020-12-04T03:09:50  *** pinheadm_ <pinheadm_!~pinheadmz@> has quit IRC (Ping timeout: 256 seconds)
 35 2020-12-04T03:31:27  *** pinheadmz <pinheadmz!~pinheadmz@> has quit IRC (Quit: pinheadmz)
 36 2020-12-04T03:35:09  *** pinheadmz <pinheadmz!~pinheadmz@> has joined #bitcoin-core-dev
 37 2020-12-04T03:58:59  *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
 38 2020-12-04T04:10:01  *** pinheadmz <pinheadmz!~pinheadmz@> has quit IRC (Quit: pinheadmz)
 39 2020-12-04T04:12:03  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
 40 2020-12-04T04:23:46  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
 41 2020-12-04T04:24:13  <andytoshi> how does travis know the subtree remotes? if i try to run the ci/test/06_script.sh script locally i get a bunch of errors like
 42 2020-12-04T04:24:16  <andytoshi> subtree commit 3967d96bf184519eb98b766af665b4d4b072563e unavailable: cannot compare. Did you add and fetch the remote?
 43 2020-12-04T04:24:32  <andytoshi> and i see some manual instructions in the README for how to add these remotes
 44 2020-12-04T04:24:40  <andytoshi> but i don't understand how travis is doing it
 45 2020-12-04T04:32:23  <fanquake> some sort of black magic
 46 2020-12-04T04:32:48  <fanquake> unclear to me as well after a quick look in ci/
 47 2020-12-04T04:32:50  <fanquake> MarcoFalke can probably enlighten us
 48 2020-12-04T04:33:32  <sipa> does travis even check the remotes?
 49 2020-12-04T04:34:33  <fanquake> it's  running the subtree checker against all the subtrees, which should require fetching the remotes
 50 2020-12-04T04:36:34  <sipa> sure, but if it doesn"t have the remotes it succeeds with a warning
 51 2020-12-04T04:42:26  <achow101> travis doesn't seem to have those remotes
 52 2020-12-04T04:42:50  <achow101> the most recent job has the same error, but the script doesn't fail so the job doesn't fail
 53 2020-12-04T04:47:26  <sipa> yes, it only does the local check iirc
 54 2020-12-04T04:48:32  <andytoshi> ah cool, i am no longer confused then :)
 55 2020-12-04T04:51:50  <sipa>  that script should probablybtake a cmdline argument to decide whether to do the remote check
 56 2020-12-04T05:02:47  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
 57 2020-12-04T05:08:21  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 58 2020-12-04T05:23:56  *** cltrbreak_MAD2 <cltrbreak_MAD2!~ctrlbreak@> has joined #bitcoin-core-dev
 59 2020-12-04T05:26:14  *** pinheadmz <pinheadmz!~pinheadmz@> has joined #bitcoin-core-dev
 60 2020-12-04T05:26:46  *** ctrlbreak_MAD <ctrlbreak_MAD!~ctrlbreak@> has quit IRC (Ping timeout: 246 seconds)
 61 2020-12-04T05:27:32  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 256 seconds)
 62 2020-12-04T05:27:49  <fanquake> could be done while it's ported to cirrus
 63 2020-12-04T06:10:48  *** mdrjr1 <mdrjr1!~mdrjr@> has quit IRC (Remote host closed the connection)
 64 2020-12-04T06:27:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 65 2020-12-04T06:27:00  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a0489f3472f3...e2ae6a2befad
 66 2020-12-04T06:27:00  <bitcoin-git> bitcoin/master 2f6fe4e Hennadii Stepanov: ci: Build with --enable-werror by default, and document exceptions
 67 2020-12-04T06:27:01  <bitcoin-git> bitcoin/master e2ae6a2 MarcoFalke: Merge #20182: ci: Build with --enable-werror by default, and document exce...
 68 2020-12-04T06:27:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 69 2020-12-04T06:27:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 70 2020-12-04T06:27:19  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20182: ci: Build with --enable-werror by default, and document exceptions (master...201018-error) https://github.com/bitcoin/bitcoin/pull/20182
 71 2020-12-04T06:27:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 72 2020-12-04T06:31:27  *** popey1 <popey1!~popey@> has joined #bitcoin-core-dev
 73 2020-12-04T06:50:31  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@> has joined #bitcoin-core-dev
 74 2020-12-04T07:20:33  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
 75 2020-12-04T07:23:04  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 260 seconds)
 76 2020-12-04T07:23:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 77 2020-12-04T07:23:41  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20566: refactor: Use C++17 std::array where possible (master...2012-array) https://github.com/bitcoin/bitcoin/pull/20566
 78 2020-12-04T07:23:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 79 2020-12-04T07:41:26  <wumpus> andytoshi: it doesn't really know, there's a manual fetch of all the repositories in there IIRC< it spooked me too once
 80 2020-12-04T07:43:02  <wumpus> or no there isn't, I don't really know
 81 2020-12-04T07:44:17  <wumpus> but I ran into some issues when I had to use a non-standard subtree for some temporary patches / experimentation in a PR (for a leveldb update)
 82 2020-12-04T07:45:16  <wumpus> https://github.com/bitcoin/bitcoin/pull/17398#issuecomment-552811611
 83 2020-12-04T07:50:58  <wumpus> on one hand I'm happy no longer being the only person running into this, on the other it would be good if it had better documentation
 84 2020-12-04T07:52:38  <wumpus> err wait the 'error' exit has a positive exit status, riight
 85 2020-12-04T08:07:26  *** promag <promag!~promag@> has joined #bitcoin-core-dev
 86 2020-12-04T08:07:40  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
 87 2020-12-04T08:08:38  <wumpus> I'll add an argument to the script instead
 88 2020-12-04T08:10:28  <wumpus> and help
 89 2020-12-04T08:14:26  <sipa>  great
 90 2020-12-04T08:23:49  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 91 2020-12-04T08:33:13  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 264 seconds)
 92 2020-12-04T08:39:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 93 2020-12-04T08:39:58  <bitcoin-git> [bitcoin] laanwj opened pull request #20567: test: Add option to git-subtree-check to do full check, add help (master...2020_12_subtree_check) https://github.com/bitcoin/bitcoin/pull/20567
 94 2020-12-04T08:39:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 95 2020-12-04T08:41:23  *** promag <promag!~promag@> has joined #bitcoin-core-dev
 96 2020-12-04T08:44:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 97 2020-12-04T08:44:30  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20568: rpc: Use FeeModes doc helper in estimatesmartfee (master...2012-rpcDocFee) https://github.com/bitcoin/bitcoin/pull/20568
 98 2020-12-04T08:44:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 99 2020-12-04T08:48:08  *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has quit IRC (Remote host closed the connection)
100 2020-12-04T08:50:36  *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
101 2020-12-04T08:51:58  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th> has joined #bitcoin-core-dev
102 2020-12-04T08:57:12  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
103 2020-12-04T09:01:06  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th> has joined #bitcoin-core-dev
104 2020-12-04T09:01:27  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
105 2020-12-04T09:04:58  <promag> MarcoFalke: why just those 2 cases in #20566?
106 2020-12-04T09:05:00  <gribble> https://github.com/bitcoin/bitcoin/issues/20566 | refactor: Use C++17 std::array where possible by MarcoFalke · Pull Request #20566 · bitcoin/bitcoin · GitHub
107 2020-12-04T09:08:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
108 2020-12-04T09:08:48  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e2ae6a2befad...257cf05f9b84
109 2020-12-04T09:08:48  <bitcoin-git> bitcoin/master d3ef947 Hennadii Stepanov: build: Check that Homebrew's berkeley-db4 package is actually installed
110 2020-12-04T09:08:48  <bitcoin-git> bitcoin/master 257cf05 Jonas Schnelli: Merge #20563: build: Check that Homebrew's berkeley-db4 package is actuall...
111 2020-12-04T09:08:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
112 2020-12-04T09:09:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
113 2020-12-04T09:09:08  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #20563: build: Check that Homebrew's berkeley-db4 package is actually installed (master...201203-bdb) https://github.com/bitcoin/bitcoin/pull/20563
114 2020-12-04T09:09:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
115 2020-12-04T09:09:10  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
116 2020-12-04T09:19:55  <wumpus> oh no did we break appveyor
117 2020-12-04T09:20:08  <fanquake> 😿
118 2020-12-04T09:30:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
119 2020-12-04T09:30:37  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20569: test: Fix intermittent wallet_multiwallet issue with got_loading_error (master...2012-testWalletInt) https://github.com/bitcoin/bitcoin/pull/20569
120 2020-12-04T09:30:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
121 2020-12-04T09:37:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
122 2020-12-04T09:37:16  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/257cf05f9b84...ca759bc743c9
123 2020-12-04T09:37:17  <bitcoin-git> bitcoin/master 86e6add Adam Jonas: doc: rename CODEOWNERS to REVIEWERS
124 2020-12-04T09:37:18  <bitcoin-git> bitcoin/master ca759bc Wladimir J. van der Laan: Merge #20200: doc: rename CODEOWNERS to REVIEWERS
125 2020-12-04T09:37:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
126 2020-12-04T09:37:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
127 2020-12-04T09:37:36  <bitcoin-git> [bitcoin] laanwj merged pull request #20200: doc: rename CODEOWNERS to REVIEWERS (master...102020-fix-codeowners) https://github.com/bitcoin/bitcoin/pull/20200
128 2020-12-04T09:37:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
129 2020-12-04T09:41:52  <MarcoFalke> promag: Only const arrays can make use of C++17 std::array
130 2020-12-04T09:42:15  <promag> MarcoFalke: I've added a comment there
131 2020-12-04T09:45:04  <MarcoFalke> is appveyor broken again? Can't be
132 2020-12-04T09:45:37  <hebasto> current https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/36658306 seems going ok
133 2020-12-04T09:46:48  <wumpus> but it fails on #20567, which makes no sense as that script isn't run by appveyor
134 2020-12-04T09:46:49  <gribble> https://github.com/bitcoin/bitcoin/issues/20567 | test: Add option to git-subtree-check to do full check, add help by laanwj · Pull Request #20567 · bitcoin/bitcoin · GitHub
135 2020-12-04T09:47:57  <MarcoFalke> how is it possible that appveryor breaks our config every 12 days
136 2020-12-04T09:57:34  <hebasto> could 20567 appveyor failure be spontaneous? re-run?
137 2020-12-04T09:57:59  <MarcoFalke> hebasto: happening on all other builds as well, starting from now
138 2020-12-04T09:58:37  <MarcoFalke> hm https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/36658306 did just pass
139 2020-12-04T09:58:55  <hebasto> ^ exactly
140 2020-12-04T09:59:49  <wumpus> nice https://github.com/bitcoin/bitcoin/pull/20567#issuecomment-738686199
141 2020-12-04T10:05:03  *** kexkey <kexkey!~kexkey@static-198-54-132-121.cust.tzulo.com> has quit IRC (Ping timeout: 260 seconds)
142 2020-12-04T10:07:19  <jonasschnelli> fanquake: I think you can un-draft https://github.com/bitcoin/bitcoin/pull/19817
143 2020-12-04T10:09:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
144 2020-12-04T10:09:57  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ca759bc743c9...dca80ffb45fc
145 2020-12-04T10:09:58  <bitcoin-git> bitcoin/master fa86156 practicalswift: util: Allow Assert(...) to be used in all contexts
146 2020-12-04T10:09:59  <bitcoin-git> bitcoin/master fac5efe MarcoFalke: util: Add Assume() identity function
147 2020-12-04T10:09:59  <bitcoin-git> bitcoin/master faa0585 MarcoFalke: util: Remove probably misleading TODO
148 2020-12-04T10:10:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
149 2020-12-04T10:10:16  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
150 2020-12-04T10:10:16  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20255: util: Add Assume() identity function (master...2010-assume) https://github.com/bitcoin/bitcoin/pull/20255
151 2020-12-04T10:10:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
152 2020-12-04T10:18:37  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
153 2020-12-04T10:37:04  <wumpus> why is all the addrv2 discussion happening last minute between rcs
154 2020-12-04T10:41:08  <jnewbery> there were lots of very large features merged just before feature freeze, so it's maybe not surprising that issues are being found now
155 2020-12-04T10:42:27  <wumpus> my first public draft was apparently june 1, 2018, I posted it to the mailing list feb 18, 2019 (there we no replies at all), I created the PR for the BIPs repository on feb 27, 2019, it was merged jul 23, 2019. Vasild picked up the implementation april this year, and quite quickly had a working implementation (though some other detailed were still ironed out). It was discussed in
156 2020-12-04T10:42:29  <wumpus> meetings multiple times.
157 2020-12-04T10:42:35  <wumpus> does any of this feel rushed to you
158 2020-12-04T10:42:55  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th> has joined #bitcoin-core-dev
159 2020-12-04T10:43:44  <wumpus> I am still struggling to find out what I did wrong for even such a relatively straightforward proposal
160 2020-12-04T10:46:50  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Quit: Pavlenex)
161 2020-12-04T10:46:58  <wumpus> I don't think people are exagerrating when they claim it has become almost imposible to make changes to bitcoin, even non-consensus, maybe this is a good thing! I don't know
162 2020-12-04T10:47:24  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
163 2020-12-04T10:51:01  <wumpus> but it's too frustrating for me personally and I don't think I'll be working on BIPs again
164 2020-12-04T10:51:28  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Client Quit)
165 2020-12-04T10:53:19  <wumpus> it wasn't even controversial in any way
166 2020-12-04T10:54:43  <vasild> indeed, why was this brought up now? the btcd issue for disconnecting was opened in btcd's repo 20+ days ago
167 2020-12-04T10:55:06  <wumpus> nor even a new idea! people had been talking about a new address mechanism for years before that, I mainly collected some ideas people already had
168 2020-12-04T10:55:20  <wumpus> and wrote them down
169 2020-12-04T10:56:39  <vasild> what about releasing 0.21 as is and _considering_ #20564 for 0.21.1 based on reception of 0.21?
170 2020-12-04T10:56:41  <gribble> https://github.com/bitcoin/bitcoin/issues/20564 | Dont send sendaddrv2 to pre-70016 software by sipa · Pull Request #20564 · bitcoin/bitcoin · GitHub
171 2020-12-04T11:01:01  <vasild> wumpus: ^
172 2020-12-04T11:02:54  <wumpus> vasild: well, it being a temporary workaround it should probably be merged quickly
173 2020-12-04T11:03:37  <wumpus> sipa's change is very low risk in itself
174 2020-12-04T11:04:18  <vasild> I agree it is low risk and can be merged quickly, but I dont see it being temporary.
175 2020-12-04T11:04:32  <wumpus> what people are (rightly) being worried about is the implications of this behavior
176 2020-12-04T11:04:36  <wumpus> yes
177 2020-12-04T11:07:20  <vasild> so we have team1 insisting that new messages should come with a protocol bump and impl1 should disconnect when it sees unknown message, team2 thinks it is ok to just ignore unknown messages.
178 2020-12-04T11:08:13  <vasild> if team1 still insists and team2 follows suit, I don't see team1 changing their mind...
179 2020-12-04T11:09:05  <wumpus> I don't agree at all that ignoring unknown messages is a DoS vector, if you want to DoS it's better to use a known message type that consumes resources
180 2020-12-04T11:09:30  <vasild> right
181 2020-12-04T11:09:33  <wumpus> or that has a large response for a small message
182 2020-12-04T11:10:04  <wumpus> just flooding a host is uninteresting and possible in so many ways
183 2020-12-04T11:12:38  <vasild> That is kind of obvious, but apparently not for everybody. My worry with 20564 is that it is going to reaffirm "new messages come with protocol bump"
184 2020-12-04T11:13:53  <wumpus> and while I do agree the P2P code could use some more anti-DoS measures this is not one
185 2020-12-04T11:13:55  <wumpus> right
186 2020-12-04T11:18:08  <wumpus> vasild: maybe, though at least everyone in the PR agrees that it's a one time thing -- this says nothign about signaling to other implementations of course
187 2020-12-04T11:18:38  <vasild> :)
188 2020-12-04T11:20:43  *** Ruben41Heaney <Ruben41Heaney!~Ruben41He@static.> has joined #bitcoin-core-dev
189 2020-12-04T11:27:28  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
190 2020-12-04T11:30:46  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 246 seconds)
191 2020-12-04T11:32:47  *** Ruben41Heaney <Ruben41Heaney!~Ruben41He@static.> has quit IRC (Ping timeout: 260 seconds)
192 2020-12-04T11:36:54  *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Remote host closed the connection)
193 2020-12-04T11:37:59  *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
194 2020-12-04T11:39:48  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
195 2020-12-04T11:40:34  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
196 2020-12-04T12:01:48  <jonasschnelli> <wumpus> my first public draft was apparently june 1, 2018, I posted it to the mailing list feb 18, 2019 (there we no replies at all), I created the PR for the BIPs repository on feb 27, 2019, it was merged jul 23, 2019. Vasild picked up the implementation april this year, and quite quickly had a working implementation (though some other detailed were still ironed out). [...]
197 2020-12-04T12:02:05  <jonasschnelli> This is my main concern... fixing this quietly.
198 2020-12-04T12:03:04  <jonasschnelli> It might lead to more reluctant testing and lesser interest to read BIPs more carefully
199 2020-12-04T12:06:02  <wumpus> ... even less interest and we might as well puglish BIPs directly into the arctic code vault
200 2020-12-04T12:09:23  *** sr_gi <sr_gi!~sr_gi@> has quit IRC (Read error: Connection reset by peer)
201 2020-12-04T12:09:41  *** sr_gi <sr_gi!~sr_gi@> has joined #bitcoin-core-dev
202 2020-12-04T12:14:45  <wumpus> but I agree, the whole BIP process is there to standardize the bitcoin protocols, to coordinate between implementations, that's the point
203 2020-12-04T12:17:24  <wumpus> well, it also helps coordinate between bitcoin core developers on a more conceptual level than implementation details, but that discussion happened on the BIP repo PRs, not on the mailing list
204 2020-12-04T12:19:24  <wumpus> e.g. https://github.com/bitcoin/bips/pull/766 had some of the most fruitful discussion
205 2020-12-04T12:20:32  *** kinlo <kinlo!~peter@unaffiliated/kinlo> has quit IRC (Ping timeout: 260 seconds)
206 2020-12-04T12:21:57  <wumpus> maybe it should have been on the mailing list but I'm not sure most of the people commenting there are even subscribed there, not least because a lot of people consider mailing lists an awful communication medium
207 2020-12-04T12:22:27  *** kinlo <kinlo!~peter@unaffiliated/kinlo> has joined #bitcoin-core-dev
208 2020-12-04T12:25:27  *** popey1 <popey1!~popey@> has quit IRC (Remote host closed the connection)
209 2020-12-04T12:30:07  *** darkspadez|lapto <darkspadez|lapto!~darkspade@> has joined #bitcoin-core-dev
210 2020-12-04T12:37:04  <wumpus> it's also perfectly normal to find and fix issues in rcs at the implementation level, what is weird here is that BIP-level conceptual issues are raised now
211 2020-12-04T12:38:10  <harding> FWIW, addrv2 was covered by the Optech newsletter six times total, three times this year.  https://bitcoinops.org/en/topics/addr-v2/  We also directly covered sdaftuar's March 2020 mailing list post about using new messages for feature negotiation with the call to action, "Daftuar is seeking feedback from maintainers of full nodes about whether the insertion of negotiation messages would cause any problems. If you’re aware of any
212 2020-12-04T12:38:10  <harding>  problems, please reply to the thread."  http://bitcoinops.org/en/newsletters/2020/03/04/#improving-feature-negotiation-between-full-nodes-at-startup   Later (August), about the new wtxidrelay message, we wrote, "This behavior is already implemented in an unreleased development version of Bitcoin Core. If the maintainers of other implementations, or anyone else, opposes this change, please respond to the mailing list thread."
213 2020-12-04T12:38:10  <harding> https://bitcoinops.org/en/newsletters/2020/08/19/#proposed-bip-for-p2p-protocol-feature-negotiation
214 2020-12-04T12:38:42  <wumpus> harding: oh wow thanks for weighing in, I even forgot about that
215 2020-12-04T12:42:03  <jonatack> Yes, it's not like we weren't publishing repeatedly about BIP 155 addrv2 arriving and testing, tweeting about it numerous times, people responding enthusiastically, etc.
216 2020-12-04T12:43:27  <jonatack> also 2 review club sessions about it, one of which was covered with a monthly Optech feature writeup and quiz
217 2020-12-04T12:44:27  <jonatack> I guess it's human nature to wait until things are really impending though
218 2020-12-04T12:49:29  <jonatack> https://bitcoincore.reviews/19031 on 2020-07-15
219 2020-12-04T12:49:56  <wumpus> it became a little more pressing with the Tor announcement that v2 was deprecated, but even then it was never hurried or rushed imo
220 2020-12-04T12:50:01  <jonatack> https://bitcoincore.reviews/19845 on 2020-09-16 (the day after tor deprecated v2)
221 2020-12-04T12:51:24  <jonatack> https://bitcoinops.org/en/topics/addr-v2 -> 3 posts in 2019, 3 posts in 2020 as harding wrote
222 2020-12-04T12:52:31  <vasild> I opened https://github.com/btcsuite/btcd/pull/1671 to ignore unknown p2p messages in btcd
223 2020-12-04T12:52:54  <jonatack> vasild: good idea
224 2020-12-04T12:53:17  <wumpus> yes, good idea
225 2020-12-04T12:57:30  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
226 2020-12-04T12:58:39  <vasild> they can probably rewrite the patch in a better way technically, but the point is how it will be received
227 2020-12-04T13:00:56  <wumpus> right
228 2020-12-04T13:06:22  *** Bullit <Bullit!~Bullit01@042-236-158-163.dynamic.caiway.nl> has quit IRC (Read error: Connection reset by peer)
229 2020-12-04T13:08:23  <vasild> btw, the freebsd port upgrade from 0.20.1 to 0.21.0rc2 was rejected by its maintainer, who does not want to track RCs: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251453
230 2020-12-04T13:19:06  <jonasschnelli> I don't get this... configure.ac sets AC_SUBST(HAVE_WEAK_GETAUXVAL), this means it will not get evaluated in #if defined(HAVE_STRONG_GETAUXVAL) || defined(HAVE_WEAK_GETAUXVAL), right?
231 2020-12-04T13:20:43  <jonasschnelli> (without setting CPPFLAGS to -DHAVE_WEAK_GETAUXVAL=@HAVE_WEAK_GETAUXVAL@)
232 2020-12-04T13:24:08  <jonasschnelli> There is no AC_DEFINE for HAVE_WEAK_GETAUXVAL but randomenv.cpp is evaluating it. My guess is that getauxval will never be used in randomenv.cpp.
233 2020-12-04T13:27:14  <sdaftuar> wumpus: just to share my opinion -- the issue in my mind is that this is a surprise to anyone that we implemented a feature that will cause existing software to disconnect us. i think it shouldn't have been a surprise to us, because every time this topic comes up on the mailing list, there is opposition to the idea of sending unknown messages without a protocol bump (as i rediscovered in august)
234 2020-12-04T13:27:57  <sdaftuar> i know this BIP was advertised in several places, but the updated draft of it was never sent to the -dev list after the negotiation changed; so i think that's something that would have brought this to light to everyone sooner
235 2020-12-04T13:28:26  <sdaftuar> at any rate, i'm not trying to advocate that we necessarily change our feature negotiation. i know lots of other people ahve strong views on it, and i don't myself
236 2020-12-04T13:29:00  <sdaftuar> i just think that we should all be aware that this is an area where people disagree, and our communication should reflect that by making it clear what our software will do
237 2020-12-04T13:29:45  <sdaftuar> (anyway, i also did basically zero work to help addrv2 make it this far, so thank you to everyone who has worked on it! i hope my words don't come across as criticism of the overall effort)
238 2020-12-04T13:30:27  *** darkspadez|lapto <darkspadez|lapto!~darkspade@> has quit IRC (Remote host closed the connection)
239 2020-12-04T13:30:44  <wumpus> I didn't bother with them ailing list anymore because the first time it got exactly zero engagement
240 2020-12-04T13:31:01  <sdaftuar> wumpus: yeah i have encountered that myself in the past too :(
241 2020-12-04T13:31:09  <wumpus> I don't personally expecti t would have been different when sending it a second time but feel free to disagree
242 2020-12-04T13:31:28  <wumpus> okay :/ yes I can only imagine how difficult it is to make say, consensus changes
243 2020-12-04T13:31:58  <wumpus> if even seomthing like this...
244 2020-12-04T13:32:36  <sdaftuar> my thought is that even if people don't engage, by sending it to the mailing list (which has historically been our place of publication of protocol changes) it shifts the burden to others to read, respond, or object
245 2020-12-04T13:34:27  *** forcer1 <forcer1!~forcer@> has joined #bitcoin-core-dev
246 2020-12-04T13:35:25  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
247 2020-12-04T13:35:26  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
248 2020-12-04T13:35:26  *** vasild_ is now known as vasild
249 2020-12-04T13:36:38  <MarcoFalke> it is impossible to know how much reading engagement a post has received if the majority of subscribers are readers
250 2020-12-04T13:36:57  <MarcoFalke> s/if/because/
251 2020-12-04T13:38:22  <wumpus> sure...
252 2020-12-04T13:40:23  *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
253 2020-12-04T13:40:42  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
254 2020-12-04T13:40:42  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has quit IRC (Client Quit)
255 2020-12-04T13:46:15  <wumpus> it was kind of demotivating for a while in itself though
256 2020-12-04T13:47:38  <kanzure> what is the mechanism by which ignoring an unknown message causes a DoS problem?
257 2020-12-04T13:47:50  <sdaftuar> the great question :)
258 2020-12-04T13:49:43  <wumpus> disconnecting literally generates more traffic than ignoring the message
259 2020-12-04T13:51:09  <kanzure> MarcoFalke: readers also can't be determined on a github pull request or issue comment.
260 2020-12-04T13:51:31  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
261 2020-12-04T13:52:06  <MarcoFalke> wumpus: I think it was an oversight of the btcd devs
262 2020-12-04T13:52:46  <MarcoFalke> The first comment says "Thanks for reporting this! The easiest way to resolve this is to permit unknown messages rather than disconnecting as we do now"
263 2020-12-04T13:53:31  <MarcoFalke> Maybe the btcd devs wouldn't have noticed even if the bip was sent to the mailing list
264 2020-12-04T13:54:34  <MarcoFalke> it is easy to forget details of how the p2p protocol is implemented (or even how it changed in the past)
265 2020-12-04T13:56:30  <MarcoFalke> code/bip review can never catch all issues upfront. They come up when implementing or running tests on real networks
266 2020-12-04T13:58:50  <MarcoFalke> we are the first ones to implement the bip, so no one else had the chance to spot bugs while implementing
267 2020-12-04T14:14:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
268 2020-12-04T14:14:30  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dca80ffb45fc...9601c0d7aab7
269 2020-12-04T14:14:31  <bitcoin-git> bitcoin/master e373959 Block Mechanic: Android : Ensure pic build for bdb
270 2020-12-04T14:14:31  <bitcoin-git> bitcoin/master 9601c0d fanquake: Merge #20565: Android : Ensure pic build for bdb
271 2020-12-04T14:14:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
272 2020-12-04T14:14:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
273 2020-12-04T14:14:49  <bitcoin-git> [bitcoin] fanquake merged pull request #20565: Android : Ensure pic build for bdb (master...fix-bdb-android) https://github.com/bitcoin/bitcoin/pull/20565
274 2020-12-04T14:14:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
275 2020-12-04T14:18:24  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th> has joined #bitcoin-core-dev
276 2020-12-04T14:18:40  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 272 seconds)
277 2020-12-04T14:21:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
278 2020-12-04T14:21:20  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9601c0d7aab7...c1604483d34f
279 2020-12-04T14:21:21  <bitcoin-git> bitcoin/master fac7ab1 MarcoFalke: refactor: Use C++17 std::array where possible
280 2020-12-04T14:21:21  <bitcoin-git> bitcoin/master c160448 MarcoFalke: Merge #20566: refactor: Use C++17 std::array where possible
281 2020-12-04T14:21:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
282 2020-12-04T14:21:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
283 2020-12-04T14:21:40  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20566: refactor: Use C++17 std::array where possible (master...2012-array) https://github.com/bitcoin/bitcoin/pull/20566
284 2020-12-04T14:21:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
285 2020-12-04T14:27:25  *** dviola <dviola!~diego@unaffiliated/dviola> has quit IRC (Ping timeout: 256 seconds)
286 2020-12-04T14:32:23  *** Guyver2_ <Guyver2_!~Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
287 2020-12-04T14:35:30  *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 256 seconds)
288 2020-12-04T14:46:38  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Quit: Pavlenex)
289 2020-12-04T15:01:32  *** dviola <dviola!~diego@> has joined #bitcoin-core-dev
290 2020-12-04T15:05:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
291 2020-12-04T15:05:51  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c1604483d34f...751ffaabad82
292 2020-12-04T15:05:52  <bitcoin-git> bitcoin/master 773c42b Andrew Chow: tests: Test that a fully signed tx given to signrawtx is unchanged
293 2020-12-04T15:05:53  <bitcoin-git> bitcoin/master 751ffaa MarcoFalke: Merge #20562: tests: Test that a fully signed tx given to signrawtx is unc...
294 2020-12-04T15:05:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
295 2020-12-04T15:06:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
296 2020-12-04T15:06:11  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20562: tests: Test that a fully signed tx given to signrawtx is unchanged (master...test-signraw-fullysigned) https://github.com/bitcoin/bitcoin/pull/20562
297 2020-12-04T15:06:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
298 2020-12-04T15:21:49  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 256 seconds)
299 2020-12-04T15:31:13  *** virtu_ <virtu_!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
300 2020-12-04T15:32:03  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Ping timeout: 240 seconds)
301 2020-12-04T15:33:41  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
302 2020-12-04T15:43:40  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th> has quit IRC (Read error: Connection reset by peer)
303 2020-12-04T15:51:37  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
304 2020-12-04T15:53:16  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 240 seconds)
305 2020-12-04T15:58:18  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
306 2020-12-04T15:59:42  *** pergaminho <pergaminho!~Cleber@> has joined #bitcoin-core-dev
307 2020-12-04T16:05:53  *** reallll <reallll!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
308 2020-12-04T16:09:30  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 272 seconds)
309 2020-12-04T16:09:52  *** Provostro <Provostro!~Pvo@> has joined #bitcoin-core-dev
310 2020-12-04T16:15:09  *** Klox04809318631 <Klox04809318631!~Klox@c-24-1-131-19.hsd1.il.comcast.net> has joined #bitcoin-core-dev
311 2020-12-04T16:15:28  <Provostro> Hi I asked about LedgerX and they told me to come here and speak with Kanzure
312 2020-12-04T16:15:33  <Provostro> I was checking it out, but it seems like a scam.
313 2020-12-04T16:15:38  <Provostro> the order books are scammy
314 2020-12-04T16:15:42  <Provostro> kanzure, are you running a scam?
315 2020-12-04T16:16:21  <Provostro> !tlast
316 2020-12-04T16:16:21  <gribble> 18856.24
317 2020-12-04T16:17:51  <luke-jr> Provostro: this channel is for Bitcoin Core development, not for speaking with specific people about other topics
318 2020-12-04T16:17:53  <Provostro> I'd like to settle matter amicably, thats why i came to you to ask.
319 2020-12-04T16:18:07  <Provostro> TO please stop running your scam, or pay me 100 btc.
320 2020-12-04T16:18:22  <luke-jr> Provostro: /query kanzure
321 2020-12-04T16:20:12  <Provostro> luke-jr, ok i typed that, now what?
322 2020-12-04T16:20:31  <luke-jr> use that tab to talk privately with him
323 2020-12-04T16:20:42  <Provostro> i like to do it publicly so the whole world knows who's a scammer
324 2020-12-04T16:20:49  <luke-jr> well it's not welcome here
325 2020-12-04T16:20:49  <Provostro> do you hagve an issue with that?
326 2020-12-04T16:21:53  *** openoms_ <openoms_!~quassel@> has quit IRC (Ping timeout: 256 seconds)
327 2020-12-04T16:23:49  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
328 2020-12-04T16:24:25  <Provostro> luke-jr, perhaps you too are a scammer in on the scam?
329 2020-12-04T16:25:05  *** ChanServ sets mode: +o luke-jr
330 2020-12-04T16:25:13  *** luke-jr sets mode: +q Provostro!*@*
331 2020-12-04T16:25:21  *** luke-jr sets mode: -o luke-jr
332 2020-12-04T16:26:44  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
333 2020-12-04T16:26:58  *** openoms <openoms!~quassel@> has joined #bitcoin-core-dev
334 2020-12-04T16:29:17  *** Zenton <Zenton!~user@unaffiliated/vicenteh> has quit IRC (Read error: Connection reset by peer)
335 2020-12-04T16:29:36  *** Zenton <Zenton!~user@unaffiliated/vicenteh> has joined #bitcoin-core-dev
336 2020-12-04T16:30:38  *** reallll is now known as belcher
337 2020-12-04T16:50:08  *** tryphe_ <tryphe_!~tryphe@unaffiliated/tryphe> has joined #bitcoin-core-dev
338 2020-12-04T16:50:21  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
339 2020-12-04T16:52:45  *** tryphe <tryphe!~tryphe@unaffiliated/tryphe> has quit IRC (Ping timeout: 240 seconds)
340 2020-12-04T16:54:31  *** promag <promag!~promag@> has joined #bitcoin-core-dev
341 2020-12-04T16:55:57  *** jessepos_ <jessepos_!~jp@2600:380:c010:4d5b:595a:9185:2152:9cb8> has joined #bitcoin-core-dev
342 2020-12-04T16:57:13  *** jessepos_ <jessepos_!~jp@2600:380:c010:4d5b:595a:9185:2152:9cb8> has quit IRC (Client Quit)
343 2020-12-04T16:57:39  *** jessepos_ <jessepos_!~jp@2600:380:c010:4d5b:595a:9185:2152:9cb8> has joined #bitcoin-core-dev
344 2020-12-04T16:57:40  *** kexkey <kexkey!~kexkey@static-198-54-132-173.cust.tzulo.com> has joined #bitcoin-core-dev
345 2020-12-04T16:58:48  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Quit: Pavlenex)
346 2020-12-04T17:00:02  *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:21a3:28f3:d78:7f10> has quit IRC (Ping timeout: 264 seconds)
347 2020-12-04T17:05:36  *** proofofkeags <proofofkeags!~proofofke@174-16-212-53.hlrn.qwest.net> has joined #bitcoin-core-dev
348 2020-12-04T17:14:43  *** kexkey <kexkey!~kexkey@static-198-54-132-173.cust.tzulo.com> has quit IRC (Quit: Do, don't don't)
349 2020-12-04T17:21:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
350 2020-12-04T17:21:50  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/68bd88597a79...aa4b8ebfecdd
351 2020-12-04T17:21:50  <bitcoin-git> bitcoin/0.21 54e1edc Jon Atack: Allow zero-fee fundrawtxn and walletcreatefundedpsbt calls
352 2020-12-04T17:21:51  <bitcoin-git> bitcoin/0.21 6e4969f Jon Atack: Update feeRate (BTC/kvB) to fee_rate (sat/vB) in wallet_bumpfee
353 2020-12-04T17:21:52  <bitcoin-git> bitcoin/0.21 6313362 Jon Atack: Use the correct incremental fee constant in bumpfee help
354 2020-12-04T17:21:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
355 2020-12-04T17:23:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
356 2020-12-04T17:23:05  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20510: [backport] wallet: allow zero-fee fundrawtransaction/walletcreatefundedpsbt and other fixes (0.21...backport-fee_rate-follow-ups) https://github.com/bitcoin/bitcoin/pull/20510
357 2020-12-04T17:23:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
358 2020-12-04T17:24:31  *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:888:c250:4010:2f1e> has joined #bitcoin-core-dev
359 2020-12-04T17:26:53  *** kljasdfvv <kljasdfvv!~flack@p200300d46f24de00448d0b09d893fcb7.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
360 2020-12-04T17:28:04  *** jessepos_ <jessepos_!~jp@2600:380:c010:4d5b:595a:9185:2152:9cb8> has quit IRC (Ping timeout: 240 seconds)
361 2020-12-04T17:34:22  <andytoshi> i have another CI question .. if i do bash -c 'set -e; source ./ci/lint/06_script.sh ' locally it bombs out with
362 2020-12-04T17:34:25  <andytoshi> test/functional/test_runner.py:42: error: Module has no attribute "getwindowsversion"
363 2020-12-04T17:34:30  <andytoshi> presumably because i am not on windows
364 2020-12-04T17:34:40  <andytoshi> is there a good way to deal with this
365 2020-12-04T17:35:26  <sipa> ci/test_run_all.sh:set -o errexit; source ./ci/test/06_script_a.sh
366 2020-12-04T17:35:28  <sipa> is that it?
367 2020-12-04T17:35:34  <sipa> set -o errexit?
368 2020-12-04T17:35:40  <sipa> oh, nvm, this is python
369 2020-12-04T17:42:44  <andytoshi> yeah it's running the python linter
370 2020-12-04T17:43:21  <andytoshi> the line i got is `set -o errexit; source ./ci/lint/06_script.sh` which is directly in .travis.yml
371 2020-12-04T17:50:50  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
372 2020-12-04T18:03:49  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 264 seconds)
373 2020-12-04T18:06:18  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
374 2020-12-04T18:17:36  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 240 seconds)
375 2020-12-04T18:20:00  <MarcoFalke> andytoshi: You'll need to run the scripts in order, as they "pollute" the environment with variables
376 2020-12-04T18:20:15  <MarcoFalke> s/in order/in the same bash/
377 2020-12-04T18:20:57  <MarcoFalke> cp ./ci/test_run_all.sh ./ci/lint_run_all.sh && vim ./ci/lint_run_all.sh
378 2020-12-04T18:21:13  <MarcoFalke> and then edit the file to run the same stuff that travis.yml runs
379 2020-12-04T18:21:19  <andytoshi> i don't have apt and stuff
380 2020-12-04T18:21:23  <andytoshi> i can't run the install scripts
381 2020-12-04T18:21:43  <MarcoFalke> oh, the linters only run on ubuntu. I don't think they are tested on other operating systems
382 2020-12-04T18:21:58  <andytoshi> as it happens, they pass on arch with very little modification
383 2020-12-04T18:22:52  <andytoshi> just that it doesn't really check submodules (this is still a pass :)) and the one python issue which I'll try to PR to add a mypy whitelist to
384 2020-12-04T18:22:58  <andytoshi> about sys.getwindowsversion not existing
385 2020-12-04T18:26:14  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
386 2020-12-04T18:26:35  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Client Quit)
387 2020-12-04T18:26:38  *** dviola <dviola!~diego@> has left #bitcoin-core-dev
388 2020-12-04T18:27:52  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
389 2020-12-04T18:28:33  *** jbarcelo <jbarcelo!43daf305@> has joined #bitcoin-core-dev
390 2020-12-04T18:31:36  *** openoms <openoms!~quassel@> has quit IRC (Ping timeout: 240 seconds)
391 2020-12-04T18:32:07  <wumpus> i don't get it, sys.getwindowsversion doesn't exist on ubuntu either
392 2020-12-04T18:32:25  *** openoms <openoms!~quassel@> has joined #bitcoin-core-dev
393 2020-12-04T18:33:45  <MarcoFalke> that part of the code is only executed when "os.name == 'nt'"
394 2020-12-04T18:33:58  <wumpus> that makes sense
395 2020-12-04T18:33:59  <andytoshi> yeah, it's just mypy that's complaining
396 2020-12-04T18:34:03  <andytoshi> it's not an actual problem
397 2020-12-04T18:34:31  <andytoshi> there are already mypy whitelists near that line related to windows stuff, i think this might've just been overlooked...but i'm surprissed that travis is ok with it
398 2020-12-04T18:35:48  *** virtu_ is now known as virtu
399 2020-12-04T18:38:14  *** dviola <dviola!~diego@unaffiliated/dviola> has joined #bitcoin-core-dev
400 2020-12-04T18:41:11  <jonatack> andytoshi: possibly fixed by #20240?
401 2020-12-04T18:41:13  <gribble> https://github.com/bitcoin/bitcoin/issues/20240 | script: fix linter error in test runner by jonatack · Pull Request #20240 · bitcoin/bitcoin · GitHub
402 2020-12-04T18:43:17  <andytoshi> jonatack: yeah i think so, though i don't really understand why your fix works
403 2020-12-04T18:43:25  <jonatack> it fixes error: Module has no attribute "getwindowsversion" for me since several months
404 2020-12-04T18:43:40  <andytoshi> what is mypy looking at that it thinks getwindowsversion is used by the original code, but not your new code?
405 2020-12-04T18:44:19  <andytoshi> is it just smart enough to understand `sys.platform` check but not smart enough to understand the `os.name` check?
406 2020-12-04T18:44:46  <jonatack> idk, i've been waiting for someone else to hit the same issue
407 2020-12-04T18:45:05  <jonatack> but it works :shrugs:
408 2020-12-04T18:45:08  <andytoshi> heh, well, here i am, and my solution was to just add a `# type: ignore` on the offending line
409 2020-12-04T18:46:16  <sipa> https://github.com/python/mypy/issues/8547
410 2020-12-04T18:46:26  <sipa> using sys.platform is understood by mypy
411 2020-12-04T18:46:49  <jonatack> andytoshi: yup, that works too: if os.name != 'nt' or sys.getwindowsversion() >= (10, 0, 14393):  # type: ignore
412 2020-12-04T18:47:19  <andytoshi> nice sipa
413 2020-12-04T18:47:35  <andytoshi> so jonatack as i commented on your PR, there are a bunch of existing #type : ignore that you can probably drop
414 2020-12-04T18:47:40  <andytoshi> though we'd need a windows tester to be sure
415 2020-12-04T18:48:49  *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Ping timeout: 264 seconds)
416 2020-12-04T18:49:30  *** twistedline <twistedline!~twisted@c-68-33-78-41.hsd1.md.comcast.net> has joined #bitcoin-core-dev
417 2020-12-04T18:51:07  <jonatack> thanks sipa and andytoshi for the info. if no one looks at it before tomorrow i'll look into it.
418 2020-12-04T18:51:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
419 2020-12-04T18:51:33  <bitcoin-git> [bitcoin] OliverPetrovic opened pull request #20570: Logo added to the readme file. (master...master) https://github.com/bitcoin/bitcoin/pull/20570
420 2020-12-04T18:51:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
421 2020-12-04T18:55:33  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Quit: Gone frying asparagus or my Windows had a BSOD)
422 2020-12-04T19:00:28  <achow101> wallet meeting?
423 2020-12-04T19:01:22  *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Remote host closed the connection)
424 2020-12-04T19:01:29  <achow101> #startmeeting
425 2020-12-04T19:01:30  <core-meetingbot> Meeting started Fri Dec  4 19:01:29 2020 UTC.  The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
426 2020-12-04T19:01:30  <core-meetingbot> Available commands: action commands idea info link nick
427 2020-12-04T19:01:40  *** twistedline <twistedline!~twisted@c-68-33-78-41.hsd1.md.comcast.net> has joined #bitcoin-core-dev
428 2020-12-04T19:01:51  <emzy> hi
429 2020-12-04T19:01:56  <fjahr> hi
430 2020-12-04T19:01:57  <jonatack> hi
431 2020-12-04T19:01:59  <achow101> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr jeremyrubin emilengler jonatack hebasto
432 2020-12-04T19:02:00  <achow101>  jb55 kvaciral ariard digi_james amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai
433 2020-12-04T19:02:15  <achow101> any topics?
434 2020-12-04T19:03:47  <achow101> #topic wallet high priority for review
435 2020-12-04T19:03:47  <core-meetingbot> topic: wallet high priority for review
436 2020-12-04T19:04:09  <achow101> any wallet prs for high priority to add/remove/discuss?
437 2020-12-04T19:04:15  <jonatack> pls review minor bugfix #20546
438 2020-12-04T19:04:18  <gribble> https://github.com/bitcoin/bitcoin/issues/20546 | wallet: check for non-representable CFeeRates (0-0.0009 sat/vB) by jonatack · Pull Request #20546 · bitcoin/bitcoin · GitHub
439 2020-12-04T19:04:21  *** twistedline_ <twistedline_!~twisted@c-68-33-78-41.hsd1.md.comcast.net> has joined #bitcoin-core-dev
440 2020-12-04T19:05:03  <achow101> jonatack: is that for 0.21?
441 2020-12-04T19:05:05  <jonatack> also found another bug in the send rpc; unlike the other rpcs, the fee rate cannot be passed as a string, only a number. Opening a fix today.
442 2020-12-04T19:05:31  <jonatack> achow101: idk if it's a backport-worthy bug, up to others i guess
443 2020-12-04T19:06:19  <provoostenator> (hi)
444 2020-12-04T19:06:34  <provoostenator> It's marked experimental
445 2020-12-04T19:06:49  <provoostenator> So I guess it depends on how annoyhing it is in practice
446 2020-12-04T19:06:56  *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Ping timeout: 256 seconds)
447 2020-12-04T19:06:56  <jonatack> achow101: the fix in both cases is simple, the work is mostly writing good test coverage
448 2020-12-04T19:08:17  <achow101> doesn't seem backport worthy, but no strong opinion on that
449 2020-12-04T19:08:28  <jonatack> provoostenator: the help says it's an amount (string or number), and the fix is one line, but not up to me
450 2020-12-04T19:08:29  <achow101> not the first time we've had a known issues section in the release notes
451 2020-12-04T19:08:45  <kanzure> andytoshi: you can use import importlib; importlib.find_spec("somethingwindowsonly") and another function i forget.
452 2020-12-04T19:09:12  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
453 2020-12-04T19:09:35  <provoostenator> Well we probalby get another RC regardless because of a sendaddrv2 compatiblity issue with btcd
454 2020-12-04T19:10:02  <jonatack> yess i'll just PR it and let ppl decide
455 2020-12-04T19:10:06  <luke-jr> need another RC for the already merged stuff anyway
456 2020-12-04T19:11:42  <jonatack> fjahr: i plan to review #19055 when i'm done with all the fee rate things
457 2020-12-04T19:11:46  <gribble> https://github.com/bitcoin/bitcoin/issues/19055 | Add MuHash3072 implementation by fjahr · Pull Request #19055 · bitcoin/bitcoin · GitHub
458 2020-12-04T19:11:48  <jonatack> as you've updated it
459 2020-12-04T19:11:55  <fjahr> thanks
460 2020-12-04T19:12:03  *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Ping timeout: 240 seconds)
461 2020-12-04T19:12:35  *** jbarcelo <jbarcelo!43daf305@> has quit IRC (Ping timeout: 245 seconds)
462 2020-12-04T19:12:46  <provoostenator> I'm currently writing a PR for Specter to use descriptor wallets, so hopefully I don't encounter anything shocking on the core side.
463 2020-12-04T19:13:01  <provoostenator> So far it works really well
464 2020-12-04T19:13:02  <Murch> Hi
465 2020-12-04T19:13:39  <provoostenator> It's annoying that getwalletinfo returns 3000 for keypool size
466 2020-12-04T19:13:49  <achow101> it's not wrong though
467 2020-12-04T19:13:52  <provoostenator> Although it's true,
468 2020-12-04T19:14:00  <provoostenator> No, but it would be nice get 1000 somewhere as well
469 2020-12-04T19:14:13  <provoostenator> Because I don't want to rely on having 3 types of addresses
470 2020-12-04T19:14:24  *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
471 2020-12-04T19:14:32  <provoostenator> Need that number in order to pick a sane "range" param for importdescriptors
472 2020-12-04T19:14:40  <provoostenator> Which doesn't have a default afaik
473 2020-12-04T19:14:53  <achow101> just only support one address type then
474 2020-12-04T19:15:14  <luke-jr> yeah, descriptor wallets don't need to have all the other types do they?
475 2020-12-04T19:15:28  <provoostenator> That's not the issue.  It's just that you can't know -keypoolsize
476 2020-12-04T19:15:34  <provoostenator> Unless you parse bitcoin.conf
477 2020-12-04T19:16:04  <achow101> since each spkm reports its own keypoolsize, getwalletinfo could be more granular there
478 2020-12-04T19:16:07  <provoostenator> The range param for importdescriptors isn't super useful anyway
479 2020-12-04T19:16:10  <achow101> just some output stuff, not particularly hard
480 2020-12-04T19:17:02  <provoostenator> Would be nice if the range param defaulted to -keypoolsize so you can omit it.
481 2020-12-04T19:17:47  <achow101> i think it does?
482 2020-12-04T19:20:03  <achow101> anything else?
483 2020-12-04T19:21:39  *** troygiorshev <troygiorshev!~troygiors@d67-193-140-136.home3.cgocable.net> has joined #bitcoin-core-dev
484 2020-12-04T19:23:24  <achow101> #endmeeting
485 2020-12-04T19:23:25  <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
486 2020-12-04T19:23:25  <core-meetingbot> Meeting ended Fri Dec  4 19:23:24 2020 UTC.
487 2020-12-04T19:23:25  <core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-12-04-19.01.moin.txt
488 2020-12-04T19:23:42  * luke-jr peers at topic being in there
489 2020-12-04T19:23:47  <jonatack> provoostenator: they should call it spectre like in the old bond films
490 2020-12-04T19:24:14  <luke-jr> reminder that "Spectre" is a current-day series of vulnerabilities..
491 2020-12-04T19:24:21  <achow101> depends on whether you're british or american
492 2020-12-04T19:25:04  *** twistedline_ <twistedline_!~twisted@c-68-33-78-41.hsd1.md.comcast.net> has quit IRC (Ping timeout: 256 seconds)
493 2020-12-04T19:25:33  <fjahr> the latest one was also also called spectre and it wasn't that great sooo... :)
494 2020-12-04T19:30:43  <provoostenator> achow101: ah you're right, range can be ommited.
495 2020-12-04T19:37:18  *** openoms <openoms!~quassel@> has quit IRC (Ping timeout: 256 seconds)
496 2020-12-04T19:38:18  *** openoms <openoms!~quassel@> has joined #bitcoin-core-dev
497 2020-12-04T19:40:37  <sipa> phantomcircuit or anyone else: you still have a large number of testnet coins?
498 2020-12-04T19:41:35  <luke-jr> sipa: hi
499 2020-12-04T19:41:56  <luke-jr> i herd u want TNBTC?
500 2020-12-04T19:42:03  <luke-jr> how many & address?
501 2020-12-04T19:42:07  <sipa> someone from bitgo is asking for some amount to test with
502 2020-12-04T19:42:32  <sipa> ok, getting address
503 2020-12-04T19:44:05  <phantomcircuit> sipa, i gave mine to matt
504 2020-12-04T19:44:27  <phantomcircuit> either he gave them away or he's the testnet king
505 2020-12-04T19:44:46  <sipa> ha
506 2020-12-04T19:45:33  <gwillen> last christmas, I gave you my testnet coins, but the very next day, you gave them away
507 2020-12-04T19:46:02  <luke-jr> hmm, testnet isn't letting me run it :x
508 2020-12-04T19:46:17  <sipa> well, if anyone has some: 2N9KJZrryXJh26jqpX7cxHM7facYcSZrEFp
509 2020-12-04T19:46:23  <achow101> sipa: how many?
510 2020-12-04T19:46:32  <luke-jr> gwillen: are you implying bluematt isn't special?
511 2020-12-04T19:46:53  <sipa> achow101: how many you have? :)
512 2020-12-04T19:47:04  <achow101> several thousand
513 2020-12-04T19:47:53  <gwillen> luke-jr: I would never
514 2020-12-04T19:48:18  <sipa> gwillen: ok, you get a pass, it's december alright
515 2020-12-04T19:48:30  <achow101> sipa: 6eb56f123eb1753fe6d74f5ce177c51eb99687afb34d70f72f598a1c85835bec
516 2020-12-04T19:49:02  <sipa> achow101: thanks!
517 2020-12-04T19:49:16  <gwillen> sipa: christmas music is allowed at any point after American Thanksgiving, I didn't make the rules
518 2020-12-04T19:49:19  <sipa> gwillen: and i haven't heard any christmas songs yet this year for some reason
519 2020-12-04T19:49:25  <luke-jr> gwillen: that's not the rules
520 2020-12-04T19:49:33  <luke-jr> gwillen: Christmas music may begin on Christmas Day
521 2020-12-04T19:50:03  <gwillen> you've failed to account for the effects of Christmas Creep, at this point you're lucky if it doesn't start right after Halloween
522 2020-12-04T19:50:09  <achow101> luke-jr: begin or only on?
523 2020-12-04T19:50:41  <luke-jr> achow101: well, Christmas is 40 days so
524 2020-12-04T19:51:11  <luke-jr> Dec 25-Feb 2
525 2020-12-04T19:51:15  <gwillen> actually I'm surprised you wouldn't allow for Christmas music starting during Advent
526 2020-12-04T19:51:37  <luke-jr> Advent is supposed to be penetential
527 2020-12-04T19:51:50  <gwillen> exactly, that's when the suffering should begin
528 2020-12-04T19:51:56  <luke-jr> lol
529 2020-12-04T19:54:57  *** Provostro <Provostro!~Pvo@> has left #bitcoin-core-dev
530 2020-12-04T20:34:41  *** pergaminho <pergaminho!~Cleber@> has quit IRC (Quit: Saindo)
531 2020-12-04T20:35:29  *** twistedline <twistedline!~twisted@c-73-200-216-219.hsd1.dc.comcast.net> has joined #bitcoin-core-dev
532 2020-12-04T20:43:50  *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Ping timeout: 256 seconds)
533 2020-12-04T20:46:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
534 2020-12-04T20:46:48  <bitcoin-git> [bitcoin] hebasto opened pull request #20571: refactor: Use deduction guide for std::array<uint8_t, N> (master...201204-u8) https://github.com/bitcoin/bitcoin/pull/20571
535 2020-12-04T20:46:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
536 2020-12-04T20:48:16  *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has joined #bitcoin-core-dev
537 2020-12-04T20:49:54  *** davterra <davterra!~davterra@static-198-54-131-92.cust.tzulo.com> has quit IRC (Quit: Leaving)
538 2020-12-04T20:57:33  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
539 2020-12-04T21:03:52  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 265 seconds)
540 2020-12-04T21:13:24  *** forcer1 <forcer1!~forcer@> has quit IRC (Remote host closed the connection)
541 2020-12-04T21:20:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
542 2020-12-04T21:20:38  <bitcoin-git> [bitcoin] hebasto opened pull request #20572: ci: Adjust Cirrus CI task names (follow up) (master...201204-cirrus) https://github.com/bitcoin/bitcoin/pull/20572
543 2020-12-04T21:20:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
544 2020-12-04T21:20:57  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
545 2020-12-04T21:32:57  *** Harekiet1 <Harekiet1!~Harekiet@> has joined #bitcoin-core-dev
546 2020-12-04T21:35:37  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
547 2020-12-04T21:36:56  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 272 seconds)
548 2020-12-04T21:38:56  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
549 2020-12-04T21:52:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
550 2020-12-04T21:52:39  <bitcoin-git> [bitcoin] jonatack opened pull request #20573: wallet, bugfix: allow send with string fee_rate amounts (master...send-allow-feerates-as-strings) https://github.com/bitcoin/bitcoin/pull/20573
551 2020-12-04T21:52:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
552 2020-12-04T21:59:43  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
553 2020-12-04T22:18:06  *** dviola <dviola!~diego@unaffiliated/dviola> has quit IRC (Ping timeout: 272 seconds)
554 2020-12-04T22:28:57  *** filchef <filchef!~filchef@> has joined #bitcoin-core-dev
555 2020-12-04T22:29:40  *** filchef <filchef!~filchef@> has quit IRC (Client Quit)
556 2020-12-04T22:31:14  *** dviola <dviola!~diego@> has joined #bitcoin-core-dev
557 2020-12-04T22:33:11  *** miketwenty1 <miketwenty1!~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com> has quit IRC (Ping timeout: 272 seconds)
558 2020-12-04T22:34:26  *** dviola <dviola!~diego@> has left #bitcoin-core-dev
559 2020-12-04T22:36:34  *** Guyver2_ <Guyver2_!~Guyver@guyver2.xs4all.nl> has quit IRC (Remote host closed the connection)
560 2020-12-04T22:52:42  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
561 2020-12-04T23:00:05  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
562 2020-12-04T23:03:23  *** twistedline_ <twistedline_!~twisted@c-73-200-216-219.hsd1.dc.comcast.net> has joined #bitcoin-core-dev
563 2020-12-04T23:06:02  *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Ping timeout: 260 seconds)
564 2020-12-04T23:21:49  *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has joined #bitcoin-core-dev
565 2020-12-04T23:23:16  *** twistedline_ <twistedline_!~twisted@c-73-200-216-219.hsd1.dc.comcast.net> has quit IRC (Ping timeout: 240 seconds)
566 2020-12-04T23:27:25  *** miketwenty1 <miketwenty1!~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com> has joined #bitcoin-core-dev
567 2020-12-04T23:28:40  *** miketwenty1 <miketwenty1!~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com> has quit IRC (Remote host closed the connection)
568 2020-12-04T23:29:30  *** miketwenty1 <miketwenty1!~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com> has joined #bitcoin-core-dev
569 2020-12-04T23:44:00  *** dviola <dviola!~diego@unaffiliated/dviola> has joined #bitcoin-core-dev
570 2020-12-04T23:49:31  *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
571 2020-12-04T23:49:45  *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
572 2020-12-04T23:57:23  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has quit IRC (Ping timeout: 240 seconds)