1 2020-12-07T00:00:27  *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
  2 2020-12-07T00:09:35  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185> has joined #bitcoin-core-dev
  3 2020-12-07T00:19:50  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has quit IRC (Remote host closed the connection)
  4 2020-12-07T00:20:06  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
  5 2020-12-07T01:12:14  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 256 seconds)
  6 2020-12-07T01:19:32  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 260 seconds)
  7 2020-12-07T01:35:35  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
  8 2020-12-07T01:35:36  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
  9 2020-12-07T01:35:39  *** vasild_ is now known as vasild
 10 2020-12-07T01:39:02  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC ()
 11 2020-12-07T01:42:54  *** chip-XXI <chip-XXI!~multimedi@pop.92-184-104-60.mobile.abo.orange.fr> has joined #bitcoin-core-dev
 12 2020-12-07T01:51:34  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
 13 2020-12-07T01:52:12  *** jarolrod <jarolrod!uid475272@gateway/web/irccloud.com/x-jyjckbpmmlrppool> has quit IRC (Quit: Connection closed for inactivity)
 14 2020-12-07T02:14:14  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
 15 2020-12-07T02:14:37  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
 16 2020-12-07T02:18:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 17 2020-12-07T02:18:02  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/64156ad4d1f5...cef2efafcecc
 18 2020-12-07T02:18:02  <bitcoin-git> bitcoin/master cb0b712 Sebastian Falbesoner: doc: libbitcoinconsensus: add missing error code description, fix NBitcoin...
 19 2020-12-07T02:18:03  <bitcoin-git> bitcoin/master cef2efa fanquake: Merge #20577: doc: libconsensus: add missing error code description, fix N...
 20 2020-12-07T02:18:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 21 2020-12-07T02:18:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 22 2020-12-07T02:18:22  <bitcoin-git> [bitcoin] fanquake merged pull request #20577: doc: libconsensus: add missing error code description, fix NBitcoin link (master...201212-doc-libbitcoinconsensus-fixes) https://github.com/bitcoin/bitcoin/pull/20577
 23 2020-12-07T02:18:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 24 2020-12-07T02:19:41  *** chip-XXI <chip-XXI!~multimedi@pop.92-184-104-60.mobile.abo.orange.fr> has quit IRC (Ping timeout: 272 seconds)
 25 2020-12-07T03:03:44  *** chjj_ <chjj_!~chjj@unaffiliated/chjj> has joined #bitcoin-core-dev
 26 2020-12-07T03:04:09  *** chjj_ <chjj_!~chjj@unaffiliated/chjj> has quit IRC (Client Quit)
 27 2020-12-07T03:12:50  *** lukedashjr <lukedashjr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
 28 2020-12-07T03:16:42  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Ping timeout: 265 seconds)
 29 2020-12-07T03:17:07  *** luke-jr- <luke-jr-!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
 30 2020-12-07T03:18:25  *** lukedashjr <lukedashjr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Ping timeout: 240 seconds)
 31 2020-12-07T03:21:36  *** luke-jr- is now known as luke-jr
 32 2020-12-07T04:21:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 33 2020-12-07T04:21:10  <bitcoin-git> [bitcoin] wodry opened pull request #20587: [doc] Tidy up Tor doc (more stringent) (master...patch-2) https://github.com/bitcoin/bitcoin/pull/20587
 34 2020-12-07T04:21:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 35 2020-12-07T04:22:04  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Ping timeout: 256 seconds)
 36 2020-12-07T05:07:11  *** shesek <shesek!~shesek@164.90.217.137> has joined #bitcoin-core-dev
 37 2020-12-07T05:13:26  *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-zmhtltxvadylbjzw> has quit IRC (Quit: Connection closed for inactivity)
 38 2020-12-07T05:26:44  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
 39 2020-12-07T05:48:39  *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has quit IRC (Quit: Find me in #TheHolyRoger or https://theholyroger.com)
 40 2020-12-07T05:50:56  *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has joined #bitcoin-core-dev
 41 2020-12-07T06:49:52  *** openoms <openoms!~quassel@91.132.136.76> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
 42 2020-12-07T06:50:18  *** openoms <openoms!~quassel@91.132.136.76> has joined #bitcoin-core-dev
 43 2020-12-07T07:15:54  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
 44 2020-12-07T07:34:28  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 45 2020-12-07T07:34:30  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/cef2efafcecc...d0ca394596cf
 46 2020-12-07T07:34:31  <bitcoin-git> bitcoin/master 5bab08d Wladimir J. van der Laan: contrib: Add test for ELF symbol-check
 47 2020-12-07T07:34:32  <bitcoin-git> bitcoin/master ed1bbce fanquake: contrib: add MACHO tests to symbol-check tests
 48 2020-12-07T07:34:33  <bitcoin-git> bitcoin/master d0ca394 fanquake: Merge #20476: contrib: Add test for ELF symbol-check
 49 2020-12-07T07:34:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 50 2020-12-07T07:34:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 51 2020-12-07T07:34:49  <bitcoin-git> [bitcoin] fanquake merged pull request #20476: contrib: Add test for ELF symbol-check (master...2020_11_test_symbol_check) https://github.com/bitcoin/bitcoin/pull/20476
 52 2020-12-07T07:34:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 53 2020-12-07T08:10:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 54 2020-12-07T08:10:21  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d0ca394596cf...1a04f45fe967
 55 2020-12-07T08:10:21  <bitcoin-git> bitcoin/master 1816327 Hennadii Stepanov: p2p: Put disconnecting logs into BCLog::NET category
 56 2020-12-07T08:10:22  <bitcoin-git> bitcoin/master 1a04f45 MarcoFalke: Merge #19832: p2p: Put disconnecting logs into BCLog::NET category
 57 2020-12-07T08:10:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 58 2020-12-07T08:10:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 59 2020-12-07T08:10:41  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19832: p2p: Put disconnecting logs into BCLog::NET category (master...200829-log) https://github.com/bitcoin/bitcoin/pull/19832
 60 2020-12-07T08:10:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 61 2020-12-07T08:15:18  *** warren <warren!~warren@fedora/wombat/warren> has quit IRC (Ping timeout: 256 seconds)
 62 2020-12-07T08:17:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 63 2020-12-07T08:17:46  <bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1a04f45fe967...eab63b971d5f
 64 2020-12-07T08:17:46  <bitcoin-git> bitcoin/master 73dc19a João Barbosa: rpc, refactor: Avoid duplicate set lookup in gettxoutproof
 65 2020-12-07T08:17:47  <bitcoin-git> bitcoin/master 52fc399 João Barbosa: rpc: Reject empty txids in gettxoutproof
 66 2020-12-07T08:17:47  <bitcoin-git> bitcoin/master eab63b9 Jonas Schnelli: Merge #19847: rpc, refactor: Avoid duplicate set lookup in gettxoutproof
 67 2020-12-07T08:17:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 68 2020-12-07T08:18:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 69 2020-12-07T08:18:05  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #19847: rpc, refactor: Avoid duplicate set lookup in gettxoutproof (master...2020-08-gettxoutproof) https://github.com/bitcoin/bitcoin/pull/19847
 70 2020-12-07T08:18:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 71 2020-12-07T08:20:02  *** warren <warren!~warren@fedora/wombat/warren> has joined #bitcoin-core-dev
 72 2020-12-07T08:27:25  *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
 73 2020-12-07T08:28:07  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 246 seconds)
 74 2020-12-07T08:36:27  *** ironmarx <ironmarx!~ironmarx@178.239.168.171> has quit IRC (Remote host closed the connection)
 75 2020-12-07T09:04:13  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 76 2020-12-07T09:09:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 77 2020-12-07T09:09:51  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/eab63b971d5f...31438cc8184f
 78 2020-12-07T09:09:52  <bitcoin-git> bitcoin/master c23f6f8 Jonas Schnelli: Add depends qt fix for ARM macs
 79 2020-12-07T09:09:52  <bitcoin-git> bitcoin/master 31438cc Wladimir J. van der Laan: Merge #20482: Add depends qt fix for ARM macs
 80 2020-12-07T09:09:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 81 2020-12-07T09:10:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 82 2020-12-07T09:10:11  <bitcoin-git> [bitcoin] laanwj merged pull request #20482: Add depends qt fix for ARM macs (master...2020/11/qt_mac_arm) https://github.com/bitcoin/bitcoin/pull/20482
 83 2020-12-07T09:10:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 84 2020-12-07T09:44:56  *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has joined #bitcoin-core-dev
 85 2020-12-07T09:51:56  *** dviola <dviola!~diego@unaffiliated/dviola> has quit IRC (Quit: WeeChat 2.9)
 86 2020-12-07T09:52:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 87 2020-12-07T09:52:23  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/31438cc8184f...f3e17686b37a
 88 2020-12-07T09:52:24  <bitcoin-git> bitcoin/master 6690adb Tyler Chambers: Warn when binaries are built from a dirty branch.
 89 2020-12-07T09:52:25  <bitcoin-git> bitcoin/master f3e1768 Wladimir J. van der Laan: Merge #20468: build: warn when generating man pages for binaries built fro...
 90 2020-12-07T09:52:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 91 2020-12-07T09:52:43  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 92 2020-12-07T09:52:43  <bitcoin-git> [bitcoin] laanwj merged pull request #20468: build: warn when generating man pages for binaries built from a dirty branch (master...fix-20412) https://github.com/bitcoin/bitcoin/pull/20468
 93 2020-12-07T09:52:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 94 2020-12-07T09:58:18  *** schulzemic <schulzemic!ada@gateway/vpn/mullvad/schulzemic> has joined #bitcoin-core-dev
 95 2020-12-07T10:04:48  *** kexkey <kexkey!~kexkey@static-198-54-132-157.cust.tzulo.com> has quit IRC (Ping timeout: 260 seconds)
 96 2020-12-07T10:07:14  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has quit IRC (Remote host closed the connection)
 97 2020-12-07T10:07:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 98 2020-12-07T10:07:31  <bitcoin-git> [bitcoin] laanwj closed pull request #20434: contrib: Parse ELF directly for symbol and security checks (master...2020_11_pixie) https://github.com/bitcoin/bitcoin/pull/20434
 99 2020-12-07T10:07:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
100 2020-12-07T10:07:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
101 2020-12-07T10:07:51  <bitcoin-git> [bitcoin] laanwj reopened pull request #20434: contrib: Parse ELF directly for symbol and security checks (master...2020_11_pixie) https://github.com/bitcoin/bitcoin/pull/20434
102 2020-12-07T10:07:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
103 2020-12-07T10:17:32  <elichai2> hebasto: are you going to port `std::to_array`?
104 2020-12-07T10:18:45  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
105 2020-12-07T10:19:10  *** greypw <greypw!~greypw@unaffiliated/greypw> has quit IRC (Quit: I'll be back!)
106 2020-12-07T10:20:36  *** greypw <greypw!~greypw@unaffiliated/greypw> has joined #bitcoin-core-dev
107 2020-12-07T10:21:42  *** greypw <greypw!~greypw@unaffiliated/greypw> has quit IRC (Client Quit)
108 2020-12-07T10:23:13  *** greypw <greypw!~greypw@unaffiliated/greypw> has joined #bitcoin-core-dev
109 2020-12-07T10:23:48  <theStack> pp
110 2020-12-07T10:24:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
111 2020-12-07T10:24:46  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20588: Remove unused and confusing CTransaction constructor (master...2012-txConstructor) https://github.com/bitcoin/bitcoin/pull/20588
112 2020-12-07T10:24:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
113 2020-12-07T10:34:44  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185> has joined #bitcoin-core-dev
114 2020-12-07T10:44:23  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Ping timeout: 240 seconds)
115 2020-12-07T10:46:55  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
116 2020-12-07T10:51:25  <wumpus> nice
117 2020-12-07T10:57:59  <hebasto> elichai2: no
118 2020-12-07T11:01:46  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
119 2020-12-07T11:18:30  *** Dorothea44Rice <Dorothea44Rice!~Dorothea4@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
120 2020-12-07T11:23:33  *** Dorothea44Rice <Dorothea44Rice!~Dorothea4@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 260 seconds)
121 2020-12-07T11:25:21  *** joelklabo <joelklabo!~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net> has quit IRC (Read error: Connection reset by peer)
122 2020-12-07T11:27:50  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185> has joined #bitcoin-core-dev
123 2020-12-07T11:46:28  *** nkuttler <nkuttler!~nkuttler@unaffiliated/nkuttler> has quit IRC (Quit: K-Lined)
124 2020-12-07T11:47:25  *** nkuttler <nkuttler!~nkuttler@unaffiliated/nkuttler> has joined #bitcoin-core-dev
125 2020-12-07T11:48:59  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
126 2020-12-07T11:50:24  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185> has joined #bitcoin-core-dev
127 2020-12-07T11:51:21  *** schulzemic <schulzemic!ada@gateway/vpn/mullvad/schulzemic> has quit IRC (Quit: Konversation terminated!)
128 2020-12-07T11:51:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
129 2020-12-07T11:51:31  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f3e17686b37a...00f4dcd5520e
130 2020-12-07T11:51:31  <bitcoin-git> bitcoin/master fa0f415 MarcoFalke: net: Assume that SetCommonVersion is called at most once per peer
131 2020-12-07T11:51:32  <bitcoin-git> bitcoin/master 00f4dcd MarcoFalke: Merge #20138: net: Assume that SetCommonVersion is called at most once per...
132 2020-12-07T11:51:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
133 2020-12-07T11:51:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
134 2020-12-07T11:51:50  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20138: net: Assume that SetCommonVersion is called at most once per peer (master...2010-netVersionOnlyOnce) https://github.com/bitcoin/bitcoin/pull/20138
135 2020-12-07T11:51:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
136 2020-12-07T11:59:29  *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has quit IRC (Quit: Pavlenex)
137 2020-12-07T12:02:16  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
138 2020-12-07T12:02:18  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/00f4dcd5520e...03b1db611495
139 2020-12-07T12:02:18  <bitcoin-git> bitcoin/master 03bfeee Antoine Poinsot: interface: remove unused estimateSmartFee method from node
140 2020-12-07T12:02:19  <bitcoin-git> bitcoin/master 86ff2cf Antoine Poinsot: Remove the remaining fee estimation globals
141 2020-12-07T12:02:20  <bitcoin-git> bitcoin/master e8ea6ad Antoine Poinsot: init: don't create a CBlockPolicyEstimator if we don't relay transactions
142 2020-12-07T12:02:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
143 2020-12-07T12:02:35  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
144 2020-12-07T12:02:35  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18766: Disable fee estimation in blocksonly mode (by removing the fee estimates global) (master...disable_feeest_blocksonly) https://github.com/bitcoin/bitcoin/pull/18766
145 2020-12-07T12:02:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
146 2020-12-07T12:29:40  <hebasto> jonasschnelli: https://bitcoinbuilds.org/ reports about two builds for the same master head. Is it intended?
147 2020-12-07T12:40:02  *** Pavlenex <Pavlenex!~Thunderbi@185.244.212.67> has joined #bitcoin-core-dev
148 2020-12-07T12:41:28  *** kljasdfvv <kljasdfvv!~flack@p200300d46f24de007f9b1b51e45d0773.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
149 2020-12-07T12:44:37  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
150 2020-12-07T12:50:18  *** Pavlenex <Pavlenex!~Thunderbi@185.244.212.67> has quit IRC (Quit: Pavlenex)
151 2020-12-07T12:51:16  <jonasschnelli> hebasto: yes. For now.
152 2020-12-07T12:51:22  <jonasschnelli> one is the GUI repo one the main
153 2020-12-07T12:51:38  <jonasschnelli> It's currently like this because the GUI repo has bitcoinbuilds integerated
154 2020-12-07T12:51:58  <jonasschnelli> But I will fix this soon
155 2020-12-07T12:56:28  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
156 2020-12-07T13:04:50  *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-yslbdkfqtjhgwjcu> has quit IRC (Ping timeout: 264 seconds)
157 2020-12-07T13:05:01  *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-ulqcremawialdixq> has joined #bitcoin-core-dev
158 2020-12-07T13:05:47  *** kwm <kwm!~kwm@185.204.1.185> has joined #bitcoin-core-dev
159 2020-12-07T13:10:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
160 2020-12-07T13:10:31  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/03b1db611495...5c4911e7e752
161 2020-12-07T13:10:31  <bitcoin-git> bitcoin/master fa8abdc MarcoFalke: rpc: Use FeeModes doc helper in estimatesmartfee
162 2020-12-07T13:10:32  <bitcoin-git> bitcoin/master 5c4911e Wladimir J. van der Laan: Merge #20568: doc: Use FeeModes doc helper in estimatesmartfee
163 2020-12-07T13:10:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
164 2020-12-07T13:10:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
165 2020-12-07T13:10:50  <bitcoin-git> [bitcoin] laanwj merged pull request #20568: doc: Use FeeModes doc helper in estimatesmartfee (master...2012-rpcDocFee) https://github.com/bitcoin/bitcoin/pull/20568
166 2020-12-07T13:10:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
167 2020-12-07T13:10:56  *** dviola <dviola!~diego@unaffiliated/dviola> has joined #bitcoin-core-dev
168 2020-12-07T13:14:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
169 2020-12-07T13:14:20  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20589: log: Clarify that failure to read/write fee_estimates.dat is non-fatal (master...2012-logFeeest) https://github.com/bitcoin/bitcoin/pull/20589
170 2020-12-07T13:14:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
171 2020-12-07T13:26:26  *** Zenton <Zenton!~user@unaffiliated/vicenteh> has quit IRC (Read error: Connection reset by peer)
172 2020-12-07T13:28:55  *** Zenton <Zenton!~user@unaffiliated/vicenteh> has joined #bitcoin-core-dev
173 2020-12-07T13:34:21  *** Zenton <Zenton!~user@unaffiliated/vicenteh> has quit IRC (Read error: Connection reset by peer)
174 2020-12-07T13:34:38  *** Zenton <Zenton!~user@unaffiliated/vicenteh> has joined #bitcoin-core-dev
175 2020-12-07T13:35:34  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
176 2020-12-07T13:35:35  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
177 2020-12-07T13:35:38  *** vasild_ is now known as vasild
178 2020-12-07T13:37:00  *** jonasschnelli <jonasschnelli!~jonasschn@unaffiliated/jonasschnelli> has quit IRC (Quit: ZNC - http://znc.in)
179 2020-12-07T13:37:02  *** core-meetingbot <core-meetingbot!~meetingbo@2a01:4f9:2a:2510::2> has quit IRC (Remote host closed the connection)
180 2020-12-07T13:58:33  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
181 2020-12-07T14:18:13  *** davec <davec!~davec@072-183-054-196.res.spectrum.com> has quit IRC (Ping timeout: 264 seconds)
182 2020-12-07T14:44:12  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185> has joined #bitcoin-core-dev
183 2020-12-07T14:49:48  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
184 2020-12-07T14:52:12  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 256 seconds)
185 2020-12-07T14:55:05  *** chip-XXI <chip-XXI!~multimedi@pop.92-184-116-43.mobile.abo.orange.fr> has joined #bitcoin-core-dev
186 2020-12-07T15:01:47  *** miketwenty1 <miketwenty1!~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com> has joined #bitcoin-core-dev
187 2020-12-07T15:10:29  *** miketwen_ <miketwen_!~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com> has joined #bitcoin-core-dev
188 2020-12-07T15:14:34  *** miketwenty1 <miketwenty1!~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com> has quit IRC (Ping timeout: 260 seconds)
189 2020-12-07T15:16:01  *** Pavlenex <Pavlenex!~Thunderbi@185.244.212.67> has joined #bitcoin-core-dev
190 2020-12-07T15:20:15  <vasild> sipa: wumpus: wrt sending sendaddrv2 and the difference between the code and the BIP, I opened https://github.com/bitcoin/bips/pull/1043 to change the BIP.
191 2020-12-07T15:20:59  <vasild> maybe changing the code to conform to the BIP also makes sense (except maybe it is too late in rc cycle)
192 2020-12-07T15:22:15  *** Deacyde <Deacyde!~Deacyde@unaffiliated/deacyde> has quit IRC (Quit: May the Shwartz be with you)
193 2020-12-07T15:26:54  *** greypw <greypw!~greypw@unaffiliated/greypw> has quit IRC (Quit: I'll be back!)
194 2020-12-07T15:28:35  *** greypw <greypw!~greypw@unaffiliated/greypw> has joined #bitcoin-core-dev
195 2020-12-07T15:31:56  <wumpus> vasild: thanks, yes, that probably makes most sense
196 2020-12-07T15:35:41  <vasild> Lets pick a random number N between 10 and 50 and send sendaddrv2 after receiving N messages from the peer.
197 2020-12-07T15:37:21  <wumpus> maybe send it out of band by entangling a qubit
198 2020-12-07T15:38:20  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:a9cd:5081:c991:1e35:d185> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
199 2020-12-07T15:38:32  <vasild> :-D
200 2020-12-07T15:39:35  <wumpus> in a way I like signaling the different extensions in the same way, instead of setting on a different one for each one which seems like a jumble
201 2020-12-07T15:40:24  <wumpus> that said this yea shouldn't have come up so late
202 2020-12-07T15:42:18  <vasild> wumpus: what about doing that in 0.21.1?
203 2020-12-07T15:42:53  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
204 2020-12-07T15:42:57  <wumpus> right now, addrv2 is is no releases, so we can still change everything, once it's in 0.21.0 release, compatibility is an issu
205 2020-12-07T15:43:31  <vasild> 0.21.0 <-> 0.21.1 would work just fine
206 2020-12-07T15:43:54  <vasild> I mean - it really does not matter when sendaddrv2 is being sent and anything would work
207 2020-12-07T15:44:34  <wumpus> that's good
208 2020-12-07T15:45:45  <vasild> right now bitcoin core is the only implementation that exists, I guess. I would be a problem if another implementation arrives that expects sendaddrv2 at a certain time and is upset otherwise
209 2020-12-07T15:46:13  <vasild> (unnecessary strict)
210 2020-12-07T15:47:59  <vasild> What about changing the BIP to "sendaddrv2 can be sent at any time"?
211 2020-12-07T15:48:19  <wumpus> I prefer being specific in the BIP
212 2020-12-07T15:48:26  <wumpus> and possible more lenient in the implementation
213 2020-12-07T15:48:31  <vasild> ok
214 2020-12-07T15:49:36  <wumpus> I also think that establishing this during some negotiation phase is a good idea, instead of it being possible to switch it any time during a connection
215 2020-12-07T15:51:04  <vasild> it just does not make sense to flip it after exchanging 47 messages
216 2020-12-07T15:52:46  *** ostgote <ostgote!52a4b46b@107.180.164.82.customer.cdi.no> has joined #bitcoin-core-dev
217 2020-12-07T15:59:24  *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Quit: Leaving)
218 2020-12-07T15:59:55  *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
219 2020-12-07T16:00:19  *** roconnor <roconnor!~roconnor@host-45-58-200-239.dyn.295.ca> has joined #bitcoin-core-dev
220 2020-12-07T16:06:06  *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
221 2020-12-07T16:08:39  *** kexkey <kexkey!~kexkey@static-198-54-132-157.cust.tzulo.com> has joined #bitcoin-core-dev
222 2020-12-07T16:09:05  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 240 seconds)
223 2020-12-07T16:13:30  *** belcher_ is now known as belcher
224 2020-12-07T16:13:37  <wumpus> it doesn't, but if it's specified in the BIP that it's not allowed then implementations don't have to take it into account, which might allow for optimizations that wouldn't be possible if it's possible to switch at any time
225 2020-12-07T16:14:14  *** ostgote <ostgote!52a4b46b@107.180.164.82.customer.cdi.no> has quit IRC (Ping timeout: 245 seconds)
226 2020-12-07T16:14:42  *** proofofkeags <proofofkeags!~proofofke@174-16-212-53.hlrn.qwest.net> has quit IRC (Ping timeout: 256 seconds)
227 2020-12-07T16:22:49  <wumpus> also, it makes it possible to recognize peers that don't support addrv2 for sure, e.g. for a future time where addrv1 becomes phased out
228 2020-12-07T16:25:28  <vasild> right
229 2020-12-07T16:27:29  <vasild> actually, if we want to recognize peers that don't support addrv2 we must mandate that sendaddrv2 is sent before sending some message X, so that we would know that if we receive X from the peer without sendaddrv2 before that, then that peer does not support it
230 2020-12-07T16:31:05  <vasild> I guess that is an extra argument to do it before sending verack (like wtxidrelay)
231 2020-12-07T16:39:50  <MarcoFalke> Looks like we'll need to work on other bugfixes #20579 , so I'd also argue to move sendaddrv2 to pre-verack
232 2020-12-07T16:39:51  <gribble> https://github.com/bitcoin/bitcoin/issues/20579 | invalid transaction decoding · Issue #20579 · bitcoin/bitcoin · GitHub
233 2020-12-07T16:45:21  *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
234 2020-12-07T16:47:59  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 272 seconds)
235 2020-12-07T16:53:05  *** chip-XXI <chip-XXI!~multimedi@pop.92-184-116-43.mobile.abo.orange.fr> has quit IRC (Ping timeout: 240 seconds)
236 2020-12-07T16:53:55  <sipa> wumpus: want me to change my PR to send sendaddrv2 before sending verack?
237 2020-12-07T16:55:16  *** belcher_ is now known as belcher
238 2020-12-07T17:02:07  <wumpus> sipa: thanks, yes imo
239 2020-12-07T17:08:57  <vasild> updated https://github.com/bitcoin/bips/pull/1043 - "send sendaddrv2 berfore sending verack"
240 2020-12-07T17:12:25  <vasild> woho! managed to connect two nodes via i2p and they both see their i2p addresses: https://bpa.st/RK3Q
241 2020-12-07T17:13:10  <wumpus> vasild: that's awesome! i should install i2p some time and join in the experiments
242 2020-12-07T17:14:06  <sipa> vasild: very nice
243 2020-12-07T17:17:57  <vasild> unlike tor we can see who is connecting to us, and while it is cheap to generate i2p addresses and banning i2p bad actors makes little sense (because they can generate new address) -- we are sure that the guy connecting to us has the private key that corresponds to that address
244 2020-12-07T17:18:38  <vasild> ie no stealing of addresses
245 2020-12-07T17:18:40  *** jarolrod <jarolrod!uid475272@gateway/web/irccloud.com/x-mkskgzjzxiflwrdp> has joined #bitcoin-core-dev
246 2020-12-07T17:22:35  *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-ismhzanbxqycgvwi> has joined #bitcoin-core-dev
247 2020-12-07T17:31:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
248 2020-12-07T17:31:31  <bitcoin-git> [bitcoin] BitcoinTsunami opened pull request #20591: wallet, bugfix: fix ComputeTimeSmart function during rescanning process. fixes #20181 (master...fix-computetimesmart) https://github.com/bitcoin/bitcoin/pull/20591
249 2020-12-07T17:31:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
250 2020-12-07T17:35:04  *** molz_ <molz_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
251 2020-12-07T17:37:41  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 260 seconds)
252 2020-12-07T17:43:07  <jonatack> vasild: i have i2p running (and sent a patch a while back in your PR to update -netinfo for it), lmk if you want to try to connect to each other
253 2020-12-07T17:48:34  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC ()
254 2020-12-07T17:49:34  *** Pavlenex <Pavlenex!~Thunderbi@185.244.212.67> has quit IRC (Quit: Pavlenex)
255 2020-12-07T17:50:28  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
256 2020-12-07T17:53:16  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
257 2020-12-07T17:54:00  *** davec <davec!~davec@072-183-054-196.res.spectrum.com> has joined #bitcoin-core-dev
258 2020-12-07T18:14:01  *** kabaum <kabaum!~kabaum@h-13-35.A163.priv.bahnhof.se> has quit IRC (Ping timeout: 246 seconds)
259 2020-12-07T18:26:14  <jnewbery> vasild wumpus: someone should send an update to the mailing list to notify people that the BIP is being changed. I'm happy to do that, but I don't want to step on your toes if you'd prefer to do it yourselves. Let me know which you'd prefer.
260 2020-12-07T18:26:24  <sdaftuar> sipa: if we're going to receive a sendaddrv2 before verack, can we delay advertising our local address until after receiving verack as well?  that would be nice to have in 0.20 to help with torv3 address propagation, though we may have so many obstacles on that front that perhaps not required
261 2020-12-07T18:27:07  *** kabaum <kabaum!~kabaum@h-13-35.A163.priv.bahnhof.se> has joined #bitcoin-core-dev
262 2020-12-07T18:28:11  <sdaftuar> the issue i've observed right now is that my torv3 node often sends its initial address advertisement before receiving a sendaddrv2, which means the initial self-advertisement is lost serialization fails, and it can be days before the bloom filter rolls over so that we can try again
263 2020-12-07T18:28:40  <sdaftuar> when serialization fails*
264 2020-12-07T18:28:42  <sipa> sdaftuar: hmm, i see no downside really, except changing more at the last minute
265 2020-12-07T18:28:51  <sipa> i'll open a PR; it's useful even if it doesn't go into 0.21
266 2020-12-07T18:28:57  <sdaftuar> thanks!
267 2020-12-07T18:29:38  <jnewbery> sdaftuar: I don't see any problem with sending our self-announcement after receiving the verack. Seems like a good change
268 2020-12-07T18:30:22  <wumpus> jnewbery: I'm ok with you doing that thanks
269 2020-12-07T18:31:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
270 2020-12-07T18:31:02  <bitcoin-git> [bitcoin] jonatack opened pull request #20592: p2p:  update wtxidrelay documentation per BIP339 (master...update-wtxid-documentation-per-BIP339) https://github.com/bitcoin/bitcoin/pull/20592
271 2020-12-07T18:31:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
272 2020-12-07T18:31:56  <jnewbery> I think sending the getaddr should also be sent after receiving the verack
273 2020-12-07T18:32:32  <sdaftuar> i think it just needs to be sent after sending our own verack?
274 2020-12-07T18:33:10  <sdaftuar> doesn't matter whether a peer sends us a sendaddrv2 or not, i mean
275 2020-12-07T18:33:10  <jnewbery> Indeed, but keeping that functionality together as a block seems easiest
276 2020-12-07T18:33:13  <sipa> indeed; i think we should just make sure it arrives at the receiver after our potential sendadrv2
277 2020-12-07T18:33:26  <sdaftuar> Indeed!
278 2020-12-07T18:33:42  <jnewbery> ha
279 2020-12-07T18:44:34  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 260 seconds)
280 2020-12-07T18:49:12  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has joined #bitcoin-core-dev
281 2020-12-07T19:02:28  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
282 2020-12-07T19:03:02  *** Pavlenex <Pavlenex!~Thunderbi@185.244.212.67> has joined #bitcoin-core-dev
283 2020-12-07T19:03:25  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
284 2020-12-07T19:06:54  <wumpus> yes
285 2020-12-07T19:15:02  *** kabaum <kabaum!~kabaum@h-13-35.A163.priv.bahnhof.se> has quit IRC (Ping timeout: 272 seconds)
286 2020-12-07T19:17:18  *** Pavlenex <Pavlenex!~Thunderbi@185.244.212.67> has quit IRC (Quit: Pavlenex)
287 2020-12-07T19:20:02  <sipa> sdaftuar: i don't think any code changes are needed; SendMessages (which handles both local address announcement and actual sending out of the addr messages) doesn't run until fSuccessfullyConnected is true
288 2020-12-07T19:21:00  <sipa> which means it can only run after verack is received
289 2020-12-07T19:22:57  <sdaftuar> Oh, right!
290 2020-12-07T19:23:00  <sdaftuar> nice
291 2020-12-07T19:23:13  <sdaftuar> thanks for checking that
292 2020-12-07T19:24:31  <sipa> i started adding "if (pto->fSuccessfullyConnected) {" in a few places, and then noticed the function starts with "if (!pto->fSuccessfullyConnected) return true;"
293 2020-12-07T19:25:11  <sdaftuar> i kept getting confused that PushAddress doesn't actually cause an addr message to go out immediately
294 2020-12-07T19:25:12  *** Pavlenex <Pavlenex!~Thunderbi@185.244.212.67> has joined #bitcoin-core-dev
295 2020-12-07T19:26:23  <sdaftuar> so i was thinking we needed to move the code in our ::VERSION handler to wait to invoke that until after verack, but there is indeed no need to do so
296 2020-12-07T19:27:28  <sipa> oh wait
297 2020-12-07T19:27:37  <sipa> there is a PushAddress in the version handling too
298 2020-12-07T19:27:41  <sdaftuar> yes that's fine though
299 2020-12-07T19:27:43  <sipa> that needs changing
300 2020-12-07T19:27:50  <sdaftuar> as all it does is queue up an addr to go out later
301 2020-12-07T19:27:55  <sdaftuar> in SendMessages, as you point out
302 2020-12-07T19:28:07  <sipa> no, because PushAddress itself will filter the addr if it's not v1 compatible
303 2020-12-07T19:28:16  <sdaftuar> no, that happens in serialization, i'm pretty sure
304 2020-12-07T19:29:02  *** Pavlenex <Pavlenex!~Thunderbi@185.244.212.67> has quit IRC (Client Quit)
305 2020-12-07T19:29:05  <sdaftuar> oh!
306 2020-12-07T19:29:10  <sdaftuar> i missed the if at the top of that function
307 2020-12-07T19:29:16  <sdaftuar> you are right
308 2020-12-07T19:29:29  <sipa> lol
309 2020-12-07T19:30:07  <sipa> is it even useful to do local addr announcement inside version handling?
310 2020-12-07T19:30:22  <sipa> the SendMessages code will do it automatically
311 2020-12-07T19:30:22  <sdaftuar> i had a question for you along those lines!
312 2020-12-07T19:30:39  <sdaftuar> it looked to me like there was special code designed to figure out which "local" address to use, that is different from AdvertiseLocal
313 2020-12-07T19:30:44  <sdaftuar> and i wondered whether that was important
314 2020-12-07T19:31:23  <sdaftuar> otherwise, it seems redundant with the initial AdvertiseLocal we do the firs ttime we run SendMessages for a peer
315 2020-12-07T19:31:38  <sdaftuar> (because we initialize the first local advertisement time to 0, i think)
316 2020-12-07T19:32:06  <sipa> there are some differences between the two
317 2020-12-07T19:33:07  <sipa> but the initial version-based local addr relay doesn't set m_next_local_addr_send
318 2020-12-07T19:33:24  <sdaftuar> right, so we invoke AdvertiseLocal immediately anyway
319 2020-12-07T19:33:37  <sipa> so from reading the code, i would think that most normal connections will get the local addr twice
320 2020-12-07T19:33:37  <sdaftuar> which might advertise a different address, but i don't know the circumstances that would happen
321 2020-12-07T19:33:43  <sdaftuar> no, because of the bloom filter
322 2020-12-07T19:33:45  <sipa> oh, it'll be deduplicated i guess
323 2020-12-07T19:34:20  <sipa> it also meams that addr relay of torv3 will mostly work without code changes
324 2020-12-07T19:34:29  <sdaftuar> the first will get squelched, and the second will work?
325 2020-12-07T19:34:34  <sipa> yeah
326 2020-12-07T19:34:49  <sipa> at least under the conditions that the SendMessages one triggers
327 2020-12-07T19:35:26  <sdaftuar> that does seem to be true.  pretty gross though!
328 2020-12-07T19:35:48  <sdaftuar> that does make the change for 0.21 to move this to pre-verack to be extra good i think
329 2020-12-07T19:36:00  <sipa> indeed
330 2020-12-07T19:38:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
331 2020-12-07T19:38:33  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5c4911e7e752...d38feb6134e2
332 2020-12-07T19:38:33  <bitcoin-git> bitcoin/master fa275e1 MarcoFalke: test: Fix intermittent feature_taproot issue
333 2020-12-07T19:38:34  <bitcoin-git> bitcoin/master d38feb6 Wladimir J. van der Laan: Merge #20535: test: Fix intermittent feature_taproot issue
334 2020-12-07T19:38:35  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
335 2020-12-07T19:38:52  <sipa> for a future change we may want to look at merging these two local addr announcement code paths
336 2020-12-07T19:38:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
337 2020-12-07T19:38:53  <bitcoin-git> [bitcoin] laanwj merged pull request #20535: test: Fix intermittent feature_taproot issue (master...2011-testTapInt) https://github.com/bitcoin/bitcoin/pull/20535
338 2020-12-07T19:38:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
339 2020-12-07T19:39:00  <sdaftuar> sipa: agreed
340 2020-12-07T19:41:48  <sipa> hmm, GETADDR wipes the vAddrToSend list
341 2020-12-07T19:42:10  <sipa> so if that arrives at the wrong time, our self-announcement would be dropped?
342 2020-12-07T19:43:16  *** jonasschnelli <jonasschnelli!~jonasschn@static.239.36.216.95.clients.your-server.de> has joined #bitcoin-core-dev
343 2020-12-07T19:47:57  <sdaftuar> that's only an issue for inbound peers right?
344 2020-12-07T19:48:09  <sdaftuar> and we wouldn't push our address to them anyway in the version handler
345 2020-12-07T19:49:21  <sipa> ah, good point
346 2020-12-07T19:51:46  *** molz_ <molz_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 272 seconds)
347 2020-12-07T19:55:23  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
348 2020-12-07T20:01:43  *** kabaum <kabaum!~kabaum@h-13-35.A163.priv.bahnhof.se> has joined #bitcoin-core-dev
349 2020-12-07T20:06:20  <jonasschnelli> wumpus: I tried to update the crc32c subtree but it looks like our subtree has a commit unknown to upstream (https://github.com/bitcoin/bitcoin/commit/2e1819311a59fb5cb26e3ca50a510bfe01358350)
350 2020-12-07T20:06:45  <jonasschnelli> (I'd like to update it due to apple arm support commit)
351 2020-12-07T20:08:31  *** jonasschnelli <jonasschnelli!~jonasschn@unaffiliated/jonasschnelli> has quit IRC (Quit: ZNC - http://znc.in)
352 2020-12-07T20:08:31  <sipa> jonasschnelli: looking
353 2020-12-07T20:08:43  *** jonasschnelli <jonasschnelli!~jonasschn@static.239.36.216.95.clients.your-server.de> has joined #bitcoin-core-dev
354 2020-12-07T20:09:14  *** jonasschnelli <jonasschnelli!~jonasschn@unaffiliated/jonasschnelli> has quit IRC (Remote host closed the connection)
355 2020-12-07T20:09:41  <sipa> oh that was the initial subtree
356 2020-12-07T20:10:13  <wumpus> it's not https://github.com/bitcoin-core/crc32c ?
357 2020-12-07T20:10:38  <sipa> oh!
358 2020-12-07T20:10:42  *** jonasschnelli <jonasschnelli!~jonasschn@static.239.36.216.95.clients.your-server.de> has joined #bitcoin-core-dev
359 2020-12-07T20:11:03  <sipa> yes, it is
360 2020-12-07T20:12:11  <wumpus> (there's some commit in there to prevent subtreeing a whole bunch of google test stuff and such)
361 2020-12-07T20:12:53  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
362 2020-12-07T20:13:37  <wumpus> jonasschnelli: I think you missed it, see https://github.com/bitcoin-core/crc32c
363 2020-12-07T20:14:14  <sipa> it merges cleanly with google crc32c master, if you ignore the files we deleted in our local copy
364 2020-12-07T20:14:14  <jonasschnelli> wumpus: ah.. I didn't know we have a fork... was looking at google/crc32c
365 2020-12-07T20:14:40  <sipa> jonasschnelli: i can update if you want
366 2020-12-07T20:14:46  <jonasschnelli> plz.
367 2020-12-07T20:14:52  *** Guyver2_ is now known as Guyver2
368 2020-12-07T20:14:53  <jonasschnelli> Your commit/PR is also missing in master
369 2020-12-07T20:15:19  <wumpus> which one?
370 2020-12-07T20:15:29  <jonasschnelli> I'm mostly interested in the latest commit (https://github.com/google/crc32c)
371 2020-12-07T20:15:37  <jonasschnelli> wumpus: https://github.com/google/crc32c/commit/2e97ab26b1321b655d29c5d1d4b9e9055ff7543f
372 2020-12-07T20:15:53  <sipa> jonasschnelli: we use the "bitcoin-fork" branch i think
373 2020-12-07T20:16:14  <wumpus> I doubt these changes would be merged upstream
374 2020-12-07T20:16:51  *** davterra <davterra!~davterra@static-198-54-131-92.cust.tzulo.com> has quit IRC (Remote host closed the connection)
375 2020-12-07T20:16:57  <jonasschnelli> I only saw that sipas "Fix (unused) ReadUint64LE for BE machines (#41)" is newer than our latest crc32c subtree
376 2020-12-07T20:17:00  <gribble> https://github.com/bitcoin/bitcoin/issues/41 | Display version in help by mhanne · Pull Request #41 · bitcoin/bitcoin · GitHub
377 2020-12-07T20:17:03  <wumpus> yes, bitcoin-fork is the branch we use
378 2020-12-07T20:18:07  *** Pavlenex <Pavlenex!~Thunderbi@185.244.212.67> has joined #bitcoin-core-dev
379 2020-12-07T20:18:19  <jonasschnelli> Related to that though different: I think commit https://github.com/bitcoin/bitcoin/commit/330cb33985d0ce97c20f4a0f0bbda0fbffe098d4 did had no effect
380 2020-12-07T20:18:24  <jonasschnelli> (no-one spotted it though)
381 2020-12-07T20:19:05  <wumpus> heh sipa committed to upstream crc32s but not to our fork
382 2020-12-07T20:19:19  <jonasschnelli> heh
383 2020-12-07T20:19:40  <wumpus> jonasschnelli: it had no effect? not even for uclibc?
384 2020-12-07T20:19:42  <jonasschnelli> he betrayed us
385 2020-12-07T20:19:57  <jonasschnelli> wumpus: I don't think so
386 2020-12-07T20:20:17  <jonasschnelli> Because of a missing AC_DEFINE for HAVE_STRONG_GETAUXVAL
387 2020-12-07T20:20:24  <wumpus> I'm really confused now, the change makes sense though in itself I think
388 2020-12-07T20:20:28  <jonasschnelli> We only set it as CPPFLAG for the crc32 code
389 2020-12-07T20:20:51  <jonasschnelli> The change makes sense,... but I would really wonder if that would work
390 2020-12-07T20:20:51  *** davterra <davterra!~davterra@static-198-54-131-92.cust.tzulo.com> has joined #bitcoin-core-dev
391 2020-12-07T20:20:54  <wumpus> better to check presence of specific checks than __linux__
392 2020-12-07T20:21:14  <sipa> https://github.com/bitcoin-core/crc32c/pull/1
393 2020-12-07T20:21:22  <wumpus> I couldn't check, I guess that's the problem with obscure platforms
394 2020-12-07T20:21:40  <jonasschnelli> indeed
395 2020-12-07T20:21:50  <sipa> 12:19:05 < wumpus> heh sipa committed to upstream crc32s but not to our fork   <-  where did i commit?
396 2020-12-07T20:22:08  <sipa> jonasschnelli: plz test if it actually works with bitcoin core before acking :)
397 2020-12-07T20:22:10  <sipa> it's untested
398 2020-12-07T20:22:22  <jonasschnelli> its just the fork! ;)
399 2020-12-07T20:22:34  <wumpus> https://github.com/bitcoin-core/crc32c/pull/1/commits/2e97ab26b1321b655d29c5d1d4b9e9055ff7543f
400 2020-12-07T20:22:35  <jonasschnelli> I'll test the PR you'll do on the main repository. :)
401 2020-12-07T20:23:40  <sipa> oh, lol
402 2020-12-07T20:44:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
403 2020-12-07T20:44:52  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #20594: Fix getauxval calls in randomenv.cpp (master...2020/12/getauxval) https://github.com/bitcoin/bitcoin/pull/20594
404 2020-12-07T20:44:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
405 2020-12-07T20:56:45  <sipa> jonasschnelli: have you verified that it's actually using crc hardware accel?
406 2020-12-07T20:57:37  <jonasschnelli> I saw that it uses the codepath defined in crc32c_arm64.cc
407 2020-12-07T20:57:57  <sipa> iok, great
408 2020-12-07T20:58:17  <jonasschnelli> I also wrote a similar patch before I figured out someone wrote that already upstream
409 2020-12-07T21:04:49  <wumpus> i'm really confused by #20594
410 2020-12-07T21:04:51  <gribble> https://github.com/bitcoin/bitcoin/issues/20594 | Fix getauxval calls in randomenv.cpp by jonasschnelli · Pull Request #20594 · bitcoin/bitcoin · GitHub
411 2020-12-07T21:05:28  <wumpus> i mean usually you check that some feature is available *or* that you're compiling for the OS that the feature is on
412 2020-12-07T21:05:35  <wumpus> now you're doing both!
413 2020-12-07T21:05:53  <jonasschnelli> yeah.. I see.
414 2020-12-07T21:06:03  <wumpus> i feel that's wrong, you shouldn't even detect getauxval on macos
415 2020-12-07T21:06:04  <jonasschnelli> wumpus: the problem is the weak-link check...
416 2020-12-07T21:06:10  <jonasschnelli> I probably have to fix that.
417 2020-12-07T21:06:36  <jonasschnelli> But how would you fix that when weak-linking on macOS works (nature of weak linking)
418 2020-12-07T21:06:48  <wumpus> i think that would be possible, though agree that weak-linking makes checking difficult
419 2020-12-07T21:06:50  <wumpus> yes
420 2020-12-07T21:07:15  <jonasschnelli> I think at least the weak linking symbol HAVE_WEAK_GETAUXVAL needs a && __linux__
421 2020-12-07T21:07:29  <wumpus> you could move the __linux__ to the weak check in configure.ac
422 2020-12-07T21:07:31  <wumpus> yes
423 2020-12-07T21:07:39  <jonasschnelli> indeed. That would be cleaner
424 2020-12-07T21:07:44  <wumpus> android has __linux__ right?
425 2020-12-07T21:07:48  <jonasschnelli> AFAIK
426 2020-12-07T21:07:52  <wumpus> (fwiw the weak check is there for android)
427 2020-12-07T21:08:12  <wumpus> pretty sure too
428 2020-12-07T21:08:25  <jonasschnelli> Yes. That part was added for android
429 2020-12-07T21:10:59  <wumpus> for the strong check it shouldn't matter, though it's interesting that it seems to be specialized to ARM
430 2020-12-07T21:11:51  <wumpus> getauxval(AT_HWCAP) doesn't really need arm_acle.h nor arm_neon.h, it's also a thing on many other architectures such as RISC-V
431 2020-12-07T21:12:02  <wumpus> but that's out of scope for your fix I guess
432 2020-12-07T21:12:39  <wumpus> it's not relevant to us as long as we're not using special instruction sets onthose platforms
433 2020-12-07T21:12:42  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has quit IRC (Read error: Connection reset by peer)
434 2020-12-07T21:13:39  <jonasschnelli> wumpus: It looks like they using getauxval to detect whether the intrinsics are supported.
435 2020-12-07T21:14:32  <wumpus> that makes sense
436 2020-12-07T21:15:00  <wumpus> the meaning of bits in getauxval(AT_HWCAP) is specific per CPU architecture
437 2020-12-07T21:15:59  <wumpus> it's a nice way to detect if certain instruction sets are supported, better than say—the brute force way of trying then catching SIGILL
438 2020-12-07T21:16:41  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
439 2020-12-07T21:17:03  <wumpus> (which more or less works, is used by openssl, but is especially annoying when running a binary in a debugger, it will always trap on that)
440 2020-12-07T21:18:01  <wumpus> (and then people report that as the problem instead of the real issue)
441 2020-12-07T21:18:03  <jonasschnelli> wumpus: why doesn't __get_cpuid work in this case?
442 2020-12-07T21:18:10  <jonasschnelli> like with sse4.2
443 2020-12-07T21:18:30  <wumpus> that only exists on i?86 and x86_64
444 2020-12-07T21:18:38  <jonasschnelli> ah... I see.
445 2020-12-07T21:18:58  <wumpus> no other architecture has that information available to user space from the CPU directly
446 2020-12-07T21:19:00  <sipa> cpuid also doesn't tell you whether support in enabled for certain CPU features, only if it's present
447 2020-12-07T21:19:31  <wumpus> right
448 2020-12-07T21:19:35  <jonasschnelli> #20594 should now be cleaner
449 2020-12-07T21:19:39  <sipa> AVX2 for example requires the OS to have enabled support (as it needs to save/restore the extra registers)
450 2020-12-07T21:20:18  <gribble> https://github.com/bitcoin/bitcoin/issues/20594 | Fix getauxval calls in randomenv.cpp by jonasschnelli · Pull Request #20594 · bitcoin/bitcoin · GitHub
451 2020-12-07T21:21:57  <wumpus> jonasschnelli: lgtm now
452 2020-12-07T21:23:31  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
453 2020-12-07T21:33:42  <wumpus> sipa: TIL
454 2020-12-07T21:35:00  <wumpus> I wonder if x86 has HWCAPS bits as well, I guess it does
455 2020-12-07T21:36:13  <sipa> wumpus: see src/crypto/sha256.cpp's AVXEnabled()
456 2020-12-07T21:36:51  <wumpus> only HWCAP2_RING3MWAIT it seems nothing relevant?
457 2020-12-07T21:38:21  <jnewbery> sipa sdaftuar: you may want to review #19843
458 2020-12-07T21:38:25  <gribble> https://github.com/bitcoin/bitcoin/issues/19843 | Refactoring and minor improvement for self-advertisements by naumenkogs · Pull Request #19843 · bitcoin/bitcoin · GitHub
459 2020-12-07T21:39:42  <wumpus> sipa: xgetbv, ok, yes wouldn't have guessed that
460 2020-12-07T22:02:44  *** awesome_doge <awesome_doge!awesome-do@gateway/shell/matrix.org/x-dxfxpyarvwwbfbqj> has quit IRC (*.net *.split)
461 2020-12-07T22:02:45  *** midnight <midnight!~midnight@unaffiliated/midnightmagic> has quit IRC (*.net *.split)
462 2020-12-07T22:02:45  *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:919a:9c07:5dbc:913c> has quit IRC (*.net *.split)
463 2020-12-07T22:02:45  *** dergoegge <dergoegge!sid453889@gateway/web/irccloud.com/x-aqetkmfnbzcrxxzk> has quit IRC (*.net *.split)
464 2020-12-07T22:06:22  *** chip-XXI <chip-XXI!~multimedi@pop.92-184-104-195.mobile.abo.orange.fr> has joined #bitcoin-core-dev
465 2020-12-07T22:06:58  *** chip-XXI <chip-XXI!~multimedi@pop.92-184-104-195.mobile.abo.orange.fr> has quit IRC (Remote host closed the connection)
466 2020-12-07T22:23:55  *** midnight <midnight!~midnight@unaffiliated/midnightmagic> has joined #bitcoin-core-dev
467 2020-12-07T22:25:03  *** einyx <einyx!einyx@fsf/member/einyx> has quit IRC (Ping timeout: 260 seconds)
468 2020-12-07T22:25:19  *** einyx <einyx!einyx@fsf/member/einyx> has joined #bitcoin-core-dev
469 2020-12-07T22:26:09  *** kwm <kwm!~kwm@185.204.1.185> has quit IRC (Remote host closed the connection)
470 2020-12-07T22:30:12  *** dergoegge <dergoegge!sid453889@gateway/web/irccloud.com/x-cpuxjdlyceersvau> has joined #bitcoin-core-dev
471 2020-12-07T22:30:57  *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:1401:d5c:a187:3181> has joined #bitcoin-core-dev
472 2020-12-07T22:33:13  *** awesome_doge <awesome_doge!awesome-do@gateway/shell/matrix.org/x-witaeypfsoxnjlkc> has joined #bitcoin-core-dev
473 2020-12-07T22:39:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
474 2020-12-07T22:39:59  <bitcoin-git> [bitcoin] sipa opened pull request #20595: Improve heuristic hex decoding (master...202012_fancy_tx_hex_decode) https://github.com/bitcoin/bitcoin/pull/20595
475 2020-12-07T22:40:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
476 2020-12-07T22:46:15  *** jaekwon <jaekwon!~jaekwon@185.163.110.125> has joined #bitcoin-core-dev
477 2020-12-07T22:51:31  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 272 seconds)
478 2020-12-07T22:59:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
479 2020-12-07T22:59:09  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d38feb6134e2...1a9fa4c5ba27
480 2020-12-07T22:59:09  <bitcoin-git> bitcoin/master 65273fa Suhas Daftuar: Clear m_addr_known before our periodic self-advertisement
481 2020-12-07T22:59:10  <bitcoin-git> bitcoin/master 1a9fa4c Wladimir J. van der Laan: Merge #20561: p2p: periodically clear m_addr_known
482 2020-12-07T22:59:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
483 2020-12-07T22:59:28  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
484 2020-12-07T22:59:28  <bitcoin-git> [bitcoin] laanwj merged pull request #20561: p2p: periodically clear m_addr_known (master...2020-12-moar-addrz) https://github.com/bitcoin/bitcoin/pull/20561
485 2020-12-07T22:59:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
486 2020-12-07T23:10:06  <hebasto> what if p2p protocol will  have a new rule -- "during handshaking, i.e. before verack, unknown messages from peers are allowed without subsequent sender peer disconnection"; it will allow feature negotiation. Another new rule -- "node is free in its behaviour in case of receiving unknown message after verack, i.e. it can drop message and/or disconnect peer". This suggestion seem a good tradeoff with other
487 2020-12-07T23:10:06  <hebasto> implementations with a strong basement for future features.
488 2020-12-07T23:13:39  <sipa> hebasto: i think you're preaching to the choir here
489 2020-12-07T23:13:57  <sipa> the opposition to that idea was on the bitcoin-dev mailing list
490 2020-12-07T23:14:30  <wumpus> you're definitely preaching to the choire here, I haven't heard any objection to 'allowing' unknown messages at all here
491 2020-12-07T23:16:49  <wumpus> the title 'heuristic hex decoding' sounded really weird to me
492 2020-12-07T23:17:10  <sipa> wumpus: any suggestion?
493 2020-12-07T23:17:30  <wumpus> sipa: I don't mean I have a problem with it, it just sounded funny
494 2020-12-07T23:17:45  <sipa> ah, ok
495 2020-12-07T23:19:01  <wumpus> I guess because it was not immediately clear to me it was about transactions
496 2020-12-07T23:20:09  <wumpus> yes better :)
497 2020-12-07T23:21:24  <hebasto> sipa> Pieter Wuille hebasto: 01:13:58 the opposition to that idea was on the bitcoin-dev mailing list -- mind point out?
498 2020-12-07T23:22:39  <sipa> hebasto: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2020-August/018084.html and the whole thread that follows
499 2020-12-07T23:22:49  <hebasto> thanks!
500 2020-12-07T23:23:30  <hebasto> oh, I've read that many times :)
501 2020-12-07T23:23:43  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
502 2020-12-07T23:24:24  <hebasto> maybe, should read it again
503 2020-12-07T23:36:12  *** nullptr| <nullptr|!~nullptr|@ip-94-112-13-119.net.upcbroadband.cz> has quit IRC (Ping timeout: 256 seconds)
504 2020-12-07T23:37:48  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
505 2020-12-07T23:51:23  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
506 2020-12-07T23:56:55  <sipa> jnewbery, sdaftuar: so it seems we currently send our own address (a) once, for outbound non-blockonly connections (b) periodically for non-blockonly connections after IBD is done