1 2020-12-10T00:01:10  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has joined #bitcoin-core-dev
  2 2020-12-10T00:16:30  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
  3 2020-12-10T00:30:23  *** milky1 <milky1!~milky@> has quit IRC (Remote host closed the connection)
  4 2020-12-10T00:41:03  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Ping timeout: 240 seconds)
  5 2020-12-10T00:43:08  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
  6 2020-12-10T00:50:10  *** queip <queip!~queip@unaffiliated/rezurus> has quit IRC (Ping timeout: 256 seconds)
  7 2020-12-10T00:51:05  *** dachary1 <dachary1!~dachary@> has joined #bitcoin-core-dev
  8 2020-12-10T01:09:39  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
  9 2020-12-10T01:28:29  <wumpus> why does fuzzing disable all other targets?
 10 2020-12-10T01:28:53  <wumpus> if it's a matter of compile flags we could only pass those for the fuzzing binaries i suppose?
 11 2020-12-10T01:30:03  <sipa> wumpus: every object has to be compiled with fuzzing enabled
 12 2020-12-10T01:30:13  <sipa> if you do, nothing but the fuzz binary makes any sense
 13 2020-12-10T01:30:56  <sipa> i have a separate worktree for fuzz builds
 14 2020-12-10T01:31:08  <sipa> because it's so exclusive with everything else
 15 2020-12-10T01:31:34  <sipa> (it needs a separate ./configure)
 16 2020-12-10T01:33:14  <wumpus> sipa: hmm we could compile every object twice in that case i guess
 17 2020-12-10T01:33:19  <sipa> i asked cfields before if it was possible to have a separate target for every object with fuzzing enabled
 18 2020-12-10T01:33:23  <sipa> but he said it was hard
 19 2020-12-10T01:33:47  <wumpus> that would make sense, i mean this keeps coming up
 20 2020-12-10T01:34:26  <sipa> my biggest gripe with the fuzz builds is that it's impossible to even do any compilation of the fuzz code without a separate configure step
 21 2020-12-10T01:34:46  <sipa> after merging them all in one binary it'd be easy to permit building the fuzz binary without fuzzing enabled, though
 22 2020-12-10T01:34:49  <wumpus> making say the fuzz objects .fuzz.o would also prevent them accidentally being linked into a non-fuzz binary (or the other wayr around)
 23 2020-12-10T01:35:44  <wumpus> yes, that might help
 24 2020-12-10T01:35:48  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
 25 2020-12-10T01:35:49  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
 26 2020-12-10T01:35:52  *** vasild_ is now known as vasild
 27 2020-12-10T01:37:02  *** jarolrod <jarolrod!uid475272@gateway/web/irccloud.com/x-zdbkvysnmfxkmryf> has joined #bitcoin-core-dev
 28 2020-12-10T01:39:56  *** sr_gi <sr_gi!~sr_gi@> has quit IRC (Read error: Connection reset by peer)
 29 2020-12-10T01:40:25  *** sr_gi <sr_gi!~sr_gi@> has joined #bitcoin-core-dev
 30 2020-12-10T01:41:41  <sipa> it'd be great if we could have a .fuzz.o for everything
 31 2020-12-10T01:41:48  <sipa> not sure how much work it is
 32 2020-12-10T01:43:44  <wumpus> i trust cfields is right that this is hard to realize with auto* build system for some reason
 33 2020-12-10T01:49:16  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
 34 2020-12-10T01:49:21  <sipa> we could even make a "dummy" fuzz binary when building without fuzzing that can only run existing seeds through the fuzz tests
 35 2020-12-10T01:49:50  <sipa> which would mean you can do the CI fuzz things without separate build
 36 2020-12-10T01:50:42  *** queip <queip!~queip@unaffiliated/rezurus> has joined #bitcoin-core-dev
 37 2020-12-10T01:52:43  <aj> sipa: ooo! that's a good idea!
 38 2020-12-10T01:54:51  * sipa suggests calling it phonyfuzz
 39 2020-12-10T01:54:57  <aj> phuzz
 40 2020-12-10T01:54:58  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 260 seconds)
 41 2020-12-10T01:55:15  <aj> faux+fuzz=fauzz?
 42 2020-12-10T01:55:22  <fanquake> .PHONY
 43 2020-12-10T02:05:11  *** miketwenty1 <miketwenty1!~miketwent@> has joined #bitcoin-core-dev
 44 2020-12-10T02:06:45  <wumpus> let's try to merge #20560 soon then
 45 2020-12-10T02:06:47  <gribble> https://github.com/bitcoin/bitcoin/issues/20560 | fuzz: Link all targets once by MarcoFalke · Pull Request #20560 · bitcoin/bitcoin · GitHub
 46 2020-12-10T02:08:05  *** miketwe__ <miketwe__!~miketwent@ec2-18-205-136-236.compute-1.amazonaws.com> has quit IRC (Ping timeout: 240 seconds)
 47 2020-12-10T02:11:07  *** miketwen_ <miketwen_!~miketwent@ec2-34-202-224-110.compute-1.amazonaws.com> has joined #bitcoin-core-dev
 48 2020-12-10T02:11:25  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
 49 2020-12-10T02:14:16  *** miketwenty1 <miketwenty1!~miketwent@> has quit IRC (Ping timeout: 240 seconds)
 50 2020-12-10T02:17:25  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 240 seconds)
 51 2020-12-10T02:19:24  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has joined #bitcoin-core-dev
 52 2020-12-10T02:23:55  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
 53 2020-12-10T02:30:07  *** miketwenty1 <miketwenty1!~miketwent@> has joined #bitcoin-core-dev
 54 2020-12-10T02:30:45  *** miketwen_ <miketwen_!~miketwent@ec2-34-202-224-110.compute-1.amazonaws.com> has quit IRC (Read error: Connection reset by peer)
 55 2020-12-10T02:31:18  *** miketwen_ <miketwen_!~miketwent@ec2-34-202-224-110.compute-1.amazonaws.com> has joined #bitcoin-core-dev
 56 2020-12-10T02:35:01  *** miketwenty1 <miketwenty1!~miketwent@> has quit IRC (Ping timeout: 264 seconds)
 57 2020-12-10T02:44:19  *** miketwenty1 <miketwenty1!~miketwent@> has joined #bitcoin-core-dev
 58 2020-12-10T02:47:37  *** miketwen_ <miketwen_!~miketwent@ec2-34-202-224-110.compute-1.amazonaws.com> has quit IRC (Ping timeout: 264 seconds)
 59 2020-12-10T02:56:12  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 256 seconds)
 60 2020-12-10T03:12:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 61 2020-12-10T03:12:34  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0038ce97584f...17918a987aee
 62 2020-12-10T03:12:34  <bitcoin-git> bitcoin/master 7d0271b Russell Yanofsky: depends: Set CMAKE_INSTALL_RPATH for native packages
 63 2020-12-10T03:12:35  <bitcoin-git> bitcoin/master 17918a9 fanquake: Merge #20046: depends: Set CMAKE_INSTALL_RPATH for native packages
 64 2020-12-10T03:12:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 65 2020-12-10T03:13:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 66 2020-12-10T03:13:03  <bitcoin-git> [bitcoin] fanquake merged pull request #20046: depends: Set CMAKE_INSTALL_RPATH for native packages (master...pr/ipc-rpath) https://github.com/bitcoin/bitcoin/pull/20046
 67 2020-12-10T03:13:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 68 2020-12-10T03:28:45  *** samuel-pedraza <samuel-pedraza!47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.> has joined #bitcoin-core-dev
 69 2020-12-10T03:30:42  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 258 seconds)
 70 2020-12-10T03:33:58  *** dermoth_ <dermoth_!~dermoth@unaffiliated/dermoth> has joined #bitcoin-core-dev
 71 2020-12-10T03:34:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 72 2020-12-10T03:34:13  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/17918a987aee...054710615c5e
 73 2020-12-10T03:34:13  <bitcoin-git> bitcoin/master ae9b489 fanquake: contrib: add symbol check test for PE
 74 2020-12-10T03:34:14  <bitcoin-git> bitcoin/master 0547106 fanquake: Merge #20608: contrib: add symbol check test for PE binaries
 75 2020-12-10T03:34:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 76 2020-12-10T03:34:18  *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has quit IRC (Disconnected by services)
 77 2020-12-10T03:34:20  *** dermoth_ is now known as dermoth
 78 2020-12-10T03:34:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 79 2020-12-10T03:34:33  <bitcoin-git> [bitcoin] fanquake merged pull request #20608: contrib: add symbol check test for PE binaries (master...symbol_check_test_pe) https://github.com/bitcoin/bitcoin/pull/20608
 80 2020-12-10T03:34:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 81 2020-12-10T03:35:02  *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
 82 2020-12-10T04:54:04  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
 83 2020-12-10T04:59:37  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 264 seconds)
 84 2020-12-10T04:59:50  *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
 85 2020-12-10T05:16:26  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 86 2020-12-10T05:22:44  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has joined #bitcoin-core-dev
 87 2020-12-10T05:26:41  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has quit IRC (Client Quit)
 88 2020-12-10T05:26:42  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 256 seconds)
 89 2020-12-10T05:29:21  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
 90 2020-12-10T05:48:52  *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
 91 2020-12-10T06:10:43  *** jkczyz <jkczyz!sid419941@gateway/web/irccloud.com/x-ibaprrhpcssnfiuj> has quit IRC (Read error: Connection reset by peer)
 92 2020-12-10T06:10:54  *** jkczyz <jkczyz!sid419941@gateway/web/irccloud.com/x-iecubrfqgzplxinh> has joined #bitcoin-core-dev
 93 2020-12-10T06:11:20  *** dburkett <dburkett!sid411344@gateway/web/irccloud.com/x-jsncuetqmrckjftg> has quit IRC (Read error: Connection reset by peer)
 94 2020-12-10T06:11:22  *** ahmed_ <ahmed_!sid14086@gateway/web/irccloud.com/x-pookjqmmhysqtsxx> has quit IRC (Ping timeout: 268 seconds)
 95 2020-12-10T06:11:22  *** moneyball <moneyball!sid299869@gateway/web/irccloud.com/x-wjkdiocnrkijgqvm> has quit IRC (Ping timeout: 268 seconds)
 96 2020-12-10T06:11:29  *** dburkett <dburkett!sid411344@gateway/web/irccloud.com/x-tkxwhnhavbsakwkd> has joined #bitcoin-core-dev
 97 2020-12-10T06:11:30  *** Galvas <Galvas!sid459296@gateway/web/irccloud.com/x-xysgxmoclwsvmqxp> has quit IRC (Read error: Connection reset by peer)
 98 2020-12-10T06:11:39  *** bosma <bosma!sid103570@gateway/web/irccloud.com/x-pkpfwlunsrhdoepd> has quit IRC (Read error: Connection reset by peer)
 99 2020-12-10T06:11:40  *** moneyball <moneyball!sid299869@gateway/web/irccloud.com/x-rochyfnjwpmypxlr> has joined #bitcoin-core-dev
100 2020-12-10T06:11:40  *** Galvas <Galvas!sid459296@gateway/web/irccloud.com/x-bwbwszkdaytmfgex> has joined #bitcoin-core-dev
101 2020-12-10T06:11:54  *** bosma <bosma!sid103570@gateway/web/irccloud.com/x-itslqunxawvbudln> has joined #bitcoin-core-dev
102 2020-12-10T06:12:18  *** ahmed_ <ahmed_!sid14086@gateway/web/irccloud.com/x-jtijyzavnpaqnvsx> has joined #bitcoin-core-dev
103 2020-12-10T06:15:02  *** twistedline__ <twistedline__!~twisted@2601:14d:8500:a77d:2985:36c3:6c1f:47b8> has joined #bitcoin-core-dev
104 2020-12-10T06:16:00  *** twistedline_ <twistedline_!~twisted@c-73-200-216-219.hsd1.dc.comcast.net> has quit IRC (Ping timeout: 272 seconds)
105 2020-12-10T06:28:41  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@> has joined #bitcoin-core-dev
106 2020-12-10T06:31:55  *** mrostecki <mrostecki!mrostecki@nat/suse/x-oplejjvnaxzshynh> has quit IRC (Quit: WeeChat 1.8)
107 2020-12-10T06:32:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
108 2020-12-10T06:32:04  <bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/054710615c5e...f5b2ea3e5918
109 2020-12-10T06:32:05  <bitcoin-git> bitcoin/master 5805b82 John Newbery: [net processing] Move PushNodeVersion into PeerManager
110 2020-12-10T06:32:05  <bitcoin-git> bitcoin/master f3f61d0 John Newbery: [net processing] Add IgnoresIncomingTxs() function to PeerManager
111 2020-12-10T06:32:06  <bitcoin-git> bitcoin/master 4d510aa John Newbery: [init] Use MakeUnique<> to construct peerman
112 2020-12-10T06:32:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
113 2020-12-10T06:32:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
114 2020-12-10T06:32:23  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20217: net: Remove g_relay_txes (master...2020-10-remove-grelaytxes) https://github.com/bitcoin/bitcoin/pull/20217
115 2020-12-10T06:32:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
116 2020-12-10T06:39:20  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
117 2020-12-10T06:44:47  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
118 2020-12-10T06:53:55  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Quit: Pavlenex)
119 2020-12-10T06:54:33  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
120 2020-12-10T07:02:41  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Quit: Pavlenex)
121 2020-12-10T07:23:52  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
122 2020-12-10T07:27:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
123 2020-12-10T07:27:30  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/f5b2ea3e5918...22f13c1e088e
124 2020-12-10T07:27:30  <bitcoin-git> bitcoin/master 30bc8fa Sebastian Falbesoner: net: save high-bandwidth mode states in CNodeStats
125 2020-12-10T07:27:31  <bitcoin-git> bitcoin/master a7ed00f Sebastian Falbesoner: rpc: expose high-bandwidth mode states via getpeerinfo
126 2020-12-10T07:27:31  <bitcoin-git> bitcoin/master dab6583 Sebastian Falbesoner: doc: release note for new getpeerinfo fields "bip152_hb_{from,to}"
127 2020-12-10T07:27:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
128 2020-12-10T07:27:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
129 2020-12-10T07:27:49  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19776: net, rpc: expose high bandwidth mode state via getpeerinfo (master...20200821-rpc-expose-high-handwidth-mode-state-via-getpeerinfo) https://github.com/bitcoin/bitcoin/pull/19776
130 2020-12-10T07:27:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
131 2020-12-10T07:28:38  *** gleb <gleb!~gleb@> has quit IRC (Ping timeout: 260 seconds)
132 2020-12-10T07:33:36  *** samuel-pedraza <samuel-pedraza!47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.> has quit IRC (Ping timeout: 240 seconds)
133 2020-12-10T07:36:06  *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Read error: Connection reset by peer)
134 2020-12-10T07:39:10  *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
135 2020-12-10T07:48:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
136 2020-12-10T07:48:45  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/22f13c1e088e...38176dc66523
137 2020-12-10T07:48:46  <bitcoin-git> bitcoin/master ce207d6 Jon Atack: wallet, bugfix: allow send to take string fee rate values
138 2020-12-10T07:48:46  <bitcoin-git> bitcoin/master 6fa72ce Jon Atack: test: add coverage for passing fee rate as a string
139 2020-12-10T07:48:47  <bitcoin-git> bitcoin/master 38176dc MarcoFalke: Merge #20573: wallet, bugfix: allow send with string fee_rate amounts
140 2020-12-10T07:48:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
141 2020-12-10T07:49:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
142 2020-12-10T07:49:05  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20573: wallet, bugfix: allow send with string fee_rate amounts (master...send-allow-feerates-as-strings) https://github.com/bitcoin/bitcoin/pull/20573
143 2020-12-10T07:49:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
144 2020-12-10T07:56:38  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 260 seconds)
145 2020-12-10T07:58:20  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
146 2020-12-10T08:01:09  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
147 2020-12-10T08:03:10  <az0re> What is the proper way to get the amount of a CTxIn?
148 2020-12-10T08:05:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
149 2020-12-10T08:05:29  <bitcoin-git> [bitcoin] jarolrod opened pull request #20610: doc: update for NetBSD 9.1, add GUI Build Instructions (master...netbsd-docs) https://github.com/bitcoin/bitcoin/pull/20610
150 2020-12-10T08:05:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
151 2020-12-10T08:08:03  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Ping timeout: 240 seconds)
152 2020-12-10T08:13:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
153 2020-12-10T08:13:47  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/38176dc66523...c8fdbb46bd92
154 2020-12-10T08:13:47  <bitcoin-git> bitcoin/master 904d875 Andrew Poelstra: configure: output notice that test binary is disabled by fuzzing
155 2020-12-10T08:13:48  <bitcoin-git> bitcoin/master c8fdbb4 MarcoFalke: Merge #20609: configure: output notice that test binary is disabled by fuz...
156 2020-12-10T08:13:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
157 2020-12-10T08:14:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
158 2020-12-10T08:14:07  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20609: configure: output notice that test binary is disabled by fuzzing (master...2020-12--fuzz-config-output) https://github.com/bitcoin/bitcoin/pull/20609
159 2020-12-10T08:14:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
160 2020-12-10T08:40:29  <jonasschnelli> curios to know: why do we have nPruneAfterHeight (a minimum height for pruning)?
161 2020-12-10T08:40:46  *** miketwenty1 <miketwenty1!~miketwent@> has quit IRC (Remote host closed the connection)
162 2020-12-10T08:45:46  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
163 2020-12-10T08:48:46  <az0re> Alternatively, how should I get a CTxOut from a COutPoint (e.g., from CTxIn::prevout)?
164 2020-12-10T08:51:30  *** dachary1 <dachary1!~dachary@> has quit IRC (Ping timeout: 256 seconds)
165 2020-12-10T08:56:55  *** instagibbs <instagibbs!~greg@061093103011.ctinets.com> has quit IRC (Ping timeout: 258 seconds)
166 2020-12-10T08:58:03  <sipa> az0re: look it up in the UTXO set
167 2020-12-10T08:58:56  <az0re> ELI5 please :)
168 2020-12-10T08:59:16  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Quit: Pavlenex)
169 2020-12-10T08:59:41  <az0re> To be more specific, how best to do it from within validation.cpp?
170 2020-12-10T09:00:14  <az0re> (I am new to the Bitcoin codebase and would appreciate some tips on the most relevant data structures)
171 2020-12-10T09:00:57  *** instagibbs <instagibbs!~greg@061093103011.ctinets.com> has joined #bitcoin-core-dev
172 2020-12-10T09:03:03  *** jonatack <jonatack!~jon@> has quit IRC (Remote host closed the connection)
173 2020-12-10T09:03:16  <aj> az0re: there's a "gettxout" rpc call, you could look at how it's implemented in rpc/blockchain.cpp; or similar for "getrawtransaction" if you want to lookup the blockchain rather than the utxo set
174 2020-12-10T09:03:47  <az0re> OK roger that I'll check them out
175 2020-12-10T09:03:48  <az0re> Thanks
176 2020-12-10T09:04:23  *** jonatack <jonatack!~jon@> has joined #bitcoin-core-dev
177 2020-12-10T09:07:42  <az0re> Actually I think Consensus::CheckTxInputs() did the trick for me.  Looks like I need a CCoinsViewCache, then get a Coin from it with CCoinsViewCache::AccessCoin(), and can get the CTxOut from Coin::out
178 2020-12-10T09:09:50  <sipa> az0re: yeah, pretty much
179 2020-12-10T09:10:02  <sipa> where to get that cache depends on the context
180 2020-12-10T09:10:24  <sipa> if you need to include mempool UTXOs as well it's a bitndifferent
181 2020-12-10T09:11:41  <az0re> Hmmm...
182 2020-12-10T09:12:55  <sipa> the gettxout RPC supports both with and without mempool
183 2020-12-10T09:13:01  <sipa> so you can use that as an example
184 2020-12-10T09:13:24  *** ctrlbreak <ctrlbreak!~ctrlbreak@> has quit IRC (Ping timeout: 258 seconds)
185 2020-12-10T09:13:28  *** alorente <alorente!~alorente@s91904426.blix.com> has joined #bitcoin-core-dev
186 2020-12-10T09:16:31  *** miketwenty1 <miketwenty1!~miketwent@> has joined #bitcoin-core-dev
187 2020-12-10T09:20:45  *** miketwenty1 <miketwenty1!~miketwent@> has quit IRC (Ping timeout: 240 seconds)
188 2020-12-10T09:23:10  <az0re> I see, thanks
189 2020-12-10T09:23:11  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
190 2020-12-10T09:25:20  *** mrostecki <mrostecki!mrostecki@nat/suse/x-wasokcvpgafclwxo> has joined #bitcoin-core-dev
191 2020-12-10T09:45:40  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
192 2020-12-10T09:47:29  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
193 2020-12-10T09:51:53  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has joined #bitcoin-core-dev
194 2020-12-10T09:56:23  <jonasschnelli> MarcoFalke: functional tests: when calling assert_start_raises_init_error, the node checks for a few seconds for an RPC connection (bitcoind started, waiting for RPC to come up). Would it be possible to detect a shutdown and init error rather then polling RPC?
195 2020-12-10T09:56:31  <jonasschnelli> (would save some seconds)
196 2020-12-10T10:04:46  *** kexkey <kexkey!~kexkey@static-198-54-132-157.cust.tzulo.com> has quit IRC (Ping timeout: 258 seconds)
197 2020-12-10T10:06:04  <wumpus> it's definitely possible to detect with subprocess that the child processes exited
198 2020-12-10T10:07:14  <wumpus> or wait for it to exit, even with a timeout
199 2020-12-10T10:16:22  <jonasschnelli> hmm... our testframework calls "if self.process.poll() is not None:"... I guess that should detect the halted process
200 2020-12-10T10:16:32  <jonasschnelli> (but it doesn't)
201 2020-12-10T10:16:45  *** miketwenty1 <miketwenty1!~miketwent@> has joined #bitcoin-core-dev
202 2020-12-10T10:16:47  <jonasschnelli> or it does but the timeout is too large
203 2020-12-10T10:17:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
204 2020-12-10T10:17:00  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20611: Move TX_MAX_STANDARD_VERSION to policy (master...2012-mvTxStandardVersion) https://github.com/bitcoin/bitcoin/pull/20611
205 2020-12-10T10:17:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
206 2020-12-10T10:17:17  <jonasschnelli> it's a race
207 2020-12-10T10:18:51  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
208 2020-12-10T10:19:40  <wumpus> dunno--fwiw there's .poll() which polls if the process is still running and .wait(timeout) that waits
209 2020-12-10T10:21:06  *** miketwenty1 <miketwenty1!~miketwent@> has quit IRC (Ping timeout: 265 seconds)
210 2020-12-10T10:21:15  <wumpus> the preferable thing, if no RPC interaction is neccesary, would be to wait, no need for periodic polling
211 2020-12-10T10:22:43  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
212 2020-12-10T10:22:44  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c8fdbb46bd92...eb53c03b3680
213 2020-12-10T10:22:45  <bitcoin-git> bitcoin/master 39c42c4 Pieter Wuille: Improve heuristic hex transaction decoding
214 2020-12-10T10:22:46  <bitcoin-git> bitcoin/master 0f949cd Pieter Wuille: Add regression test for incorrect decoding
215 2020-12-10T10:22:46  <bitcoin-git> bitcoin/master eb53c03 Wladimir J. van der Laan: Merge #20595: Improve heuristic hex transaction decoding
216 2020-12-10T10:22:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
217 2020-12-10T10:23:01  <wumpus> when any kind of RPC interaction is necessary there's no other option than to poll until it becomes available, there's no way to asynchronously be notified that 'RPC is up'
218 2020-12-10T10:23:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
219 2020-12-10T10:23:03  <bitcoin-git> [bitcoin] laanwj merged pull request #20595: Improve heuristic hex transaction decoding (master...202012_fancy_tx_hex_decode) https://github.com/bitcoin/bitcoin/pull/20595
220 2020-12-10T10:23:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
221 2020-12-10T10:23:29  <wumpus> (maybe there should be)
222 2020-12-10T10:23:59  <wumpus> although honestly I have no idea how to fit that best into the POSIX process model
223 2020-12-10T10:25:47  <wumpus> hm I guess bitcoind could print some token to stdout / stderr that is detected by the connected parent process and taken as signal that RPC is running
224 2020-12-10T10:26:40  <wumpus> alternatively it'd be possible to pass, say, in an additional file descriptor for signaling but that probably gets too fiddly
225 2020-12-10T10:29:42  *** promag_ is now known as promag
226 2020-12-10T10:29:47  <promag> fanquake: ping?
227 2020-12-10T10:29:51  <MarcoFalke> jonasschnelli: removing the rpc polling from assert_start_raises_init_error is a good idea
228 2020-12-10T10:30:06  <MarcoFalke> we have intermittent issues due to that
229 2020-12-10T10:30:32  <fanquake> promag: hi
230 2020-12-10T10:30:35  <MarcoFalke> removing rpc from the equation should make everything more stable, but I am not sure how easy it is to implement
231 2020-12-10T10:30:36  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
232 2020-12-10T10:30:58  <MarcoFalke> if `assert_start_raises_init_error` fails, you'll have to use the rpc to use "stop"
233 2020-12-10T10:31:04  <jonasschnelli> MarcoFalke: Agree. Though I'm not touching it for now. Happy if someone wants to take a closer look.
234 2020-12-10T10:31:12  <MarcoFalke> or are the nodes shut down with SIGKILL? I don't remember
235 2020-12-10T10:31:35  <promag> fanquake: I have an issue, not sure how to proceed. see https://github.com/icota/bitcoin/commit/683710e072eb90296ae5a57f53bce7cac799fc41
236 2020-12-10T10:31:38  <jonasschnelli> I don't think that we test for SIGKILL
237 2020-12-10T10:31:47  <promag> fanquake: I'll comment there
238 2020-12-10T10:32:55  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has joined #bitcoin-core-dev
239 2020-12-10T10:33:35  <MarcoFalke> Everything ready for rc3?
240 2020-12-10T10:34:08  <MarcoFalke> Who is doing the backports? Happy to do them if no one is working on it yet
241 2020-12-10T10:34:15  <MarcoFalke> fanquake: wumpus: ^
242 2020-12-10T10:34:53  <fanquake> MarcoFalke: I was just waiting for the last few merges. Happy for you to do if you want. I’m afk for an hour or so
243 2020-12-10T10:35:02  <fanquake> Promag: thanks, I’ll take a look tonight
244 2020-12-10T10:39:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
245 2020-12-10T10:39:04  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20612: [0.21] final rc3 backports (0.21...2012-finalRc3Backports) https://github.com/bitcoin/bitcoin/pull/20612
246 2020-12-10T10:39:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
247 2020-12-10T10:39:06  <MarcoFalke> done ^
248 2020-12-10T10:45:49  *** jarolrod <jarolrod!uid475272@gateway/web/irccloud.com/x-zdbkvysnmfxkmryf> has quit IRC (Quit: Connection closed for inactivity)
249 2020-12-10T10:48:56  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 240 seconds)
250 2020-12-10T10:54:33  <wumpus> MarcoFalke: I think we don't use the signals in the RPC tests because windows; I guess though it could start polling RPC only after the process didn't shut down as expected after a certain timeout
251 2020-12-10T10:54:42  <wumpus> MarcoFalke: thanks
252 2020-12-10T10:57:52  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
253 2020-12-10T11:01:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
254 2020-12-10T11:01:03  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/eb53c03b3680...dcff2ee1fbf4
255 2020-12-10T11:01:03  <bitcoin-git> bitcoin/master faefa5d MarcoFalke: log: Clarify that failure to write fee_estimates.dat is non-fatal
256 2020-12-10T11:01:04  <bitcoin-git> bitcoin/master fa0d835 MarcoFalke: log: Clarify that failure to read fee_estimates.dat is non-fatal
257 2020-12-10T11:01:05  <bitcoin-git> bitcoin/master dcff2ee Wladimir J. van der Laan: Merge #20589: log: Clarify that failure to read/write fee_estimates.dat is...
258 2020-12-10T11:01:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
259 2020-12-10T11:01:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
260 2020-12-10T11:01:22  <bitcoin-git> [bitcoin] laanwj merged pull request #20589: log: Clarify that failure to read/write fee_estimates.dat is non-fatal (master...2012-logFeeest) https://github.com/bitcoin/bitcoin/pull/20589
261 2020-12-10T11:01:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
262 2020-12-10T11:03:34  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
263 2020-12-10T11:03:46  <hebasto> promag: did you try https://github.com/icota/bitcoin/commit/683710e072eb90296ae5a57f53bce7cac799fc41#commitcomment-44988208 ?
264 2020-12-10T11:05:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
265 2020-12-10T11:05:10  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dcff2ee1fbf4...e20b488395c1
266 2020-12-10T11:05:11  <bitcoin-git> bitcoin/master 34c80d9 Wladimir J. van der Laan: test: Add option to git-subtree-check to do full check, add help
267 2020-12-10T11:05:12  <bitcoin-git> bitcoin/master e20b488 Wladimir J. van der Laan: Merge #20567: test: Add option to git-subtree-check to do full check, add ...
268 2020-12-10T11:05:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
269 2020-12-10T11:05:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
270 2020-12-10T11:05:30  <bitcoin-git> [bitcoin] laanwj merged pull request #20567: test: Add option to git-subtree-check to do full check, add help (master...2020_12_subtree_check) https://github.com/bitcoin/bitcoin/pull/20567
271 2020-12-10T11:05:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
272 2020-12-10T11:05:55  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
273 2020-12-10T11:09:40  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has joined #bitcoin-core-dev
274 2020-12-10T11:10:40  <promag> hebasto: thanks, will try it
275 2020-12-10T11:14:04  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has quit IRC (Client Quit)
276 2020-12-10T11:31:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
277 2020-12-10T11:31:00  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20613: test: Use Popen.wait instead of RPC in assert_start_raises_init_error (master...2012-testFastFailInitError) https://github.com/bitcoin/bitcoin/pull/20613
278 2020-12-10T11:31:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
279 2020-12-10T11:31:51  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has quit IRC (Remote host closed the connection)
280 2020-12-10T11:40:09  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
281 2020-12-10T11:44:44  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
282 2020-12-10T11:54:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
283 2020-12-10T11:54:36  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e20b488395c1...8e1f9d62731c
284 2020-12-10T11:54:37  <bitcoin-git> bitcoin/master 206f74e João Barbosa: Support make src/bitcoin-node and src/bitcoin-gui
285 2020-12-10T11:54:37  <bitcoin-git> bitcoin/master 8e1f9d6 Wladimir J. van der Laan: Merge #20549: Support make src/bitcoin-node and src/bitcoin-gui
286 2020-12-10T11:54:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
287 2020-12-10T11:54:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
288 2020-12-10T11:54:56  <bitcoin-git> [bitcoin] laanwj merged pull request #20549: Support make src/bitcoin-node and src/bitcoin-gui (master...2020-12-make-bitcoin-node) https://github.com/bitcoin/bitcoin/pull/20549
289 2020-12-10T11:54:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
290 2020-12-10T11:56:04  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has quit IRC (Remote host closed the connection)
291 2020-12-10T11:56:22  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
292 2020-12-10T12:03:03  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
293 2020-12-10T12:03:48  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Quit: Pavlenex)
294 2020-12-10T12:19:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
295 2020-12-10T12:19:12  <bitcoin-git> [bitcoin] jonasschnelli pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8e1f9d62731c...86f20071931b
296 2020-12-10T12:19:12  <bitcoin-git> bitcoin/master c96d1f6 Hennadii Stepanov: build, refactor: Check that Homebrew's qt5 package is actually installed
297 2020-12-10T12:19:13  <bitcoin-git> bitcoin/master ee7b84e Hennadii Stepanov: build: Use Homebrew's sqlite package if it is available
298 2020-12-10T12:19:14  <bitcoin-git> bitcoin/master c932e0d Hennadii Stepanov: doc: Update wallet database installation guide for macOS
299 2020-12-10T12:19:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
300 2020-12-10T12:19:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
301 2020-12-10T12:19:41  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #20527: build: Do not ignore Homebrew's SQLite on macOS (master...201129-sqlite) https://github.com/bitcoin/bitcoin/pull/20527
302 2020-12-10T12:19:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
303 2020-12-10T12:23:37  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
304 2020-12-10T12:36:03  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has quit IRC (Remote host closed the connection)
305 2020-12-10T12:38:10  *** ctrlbreak <ctrlbreak!~ctrlbreak@> has joined #bitcoin-core-dev
306 2020-12-10T12:48:15  *** Pavlenex1 <Pavlenex1!~Thunderbi@> has joined #bitcoin-core-dev
307 2020-12-10T12:49:56  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Ping timeout: 240 seconds)
308 2020-12-10T12:49:56  *** Pavlenex1 is now known as Pavlenex
309 2020-12-10T12:53:20  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
310 2020-12-10T13:04:29  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Quit: Pavlenex)
311 2020-12-10T13:10:57  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@> has joined #bitcoin-core-dev
312 2020-12-10T13:11:33  <hebasto> promag: the combined branch for qml static builds https://github.com/hebasto/bitcoin/commits/201210-qml
313 2020-12-10T13:15:02  *** pergaminho <pergaminho!~Cleber@> has joined #bitcoin-core-dev
314 2020-12-10T13:26:36  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
315 2020-12-10T13:28:56  *** openoms <openoms!~quassel@> has quit IRC (Ping timeout: 256 seconds)
316 2020-12-10T13:33:33  *** openoms <openoms!~quassel@> has joined #bitcoin-core-dev
317 2020-12-10T13:35:46  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
318 2020-12-10T13:35:47  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
319 2020-12-10T13:35:47  *** vasild_ is now known as vasild
320 2020-12-10T13:39:00  <sdaftuar> MarcoFalke: can you tell me your thoughts on how close #19858 is to be merged? 3 PRs that conflict with it have been merged since it was acked 4 times, so i'm trying to rebase and get re-review before this happens again
321 2020-12-10T13:39:04  <gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
322 2020-12-10T13:40:21  <sdaftuar> but if it will be a while i can hold off on pestering people
323 2020-12-10T13:40:52  <MarcoFalke> sdaftuar: I explictly held back on merging the conflicting prs. I simply didn't get the notification last night from GitHub that you rebased it
324 2020-12-10T13:41:08  <sdaftuar> ah, thanks for the effort
325 2020-12-10T13:41:21  <sdaftuar> so i should go ahead then with my rebase and re-pester plan
326 2020-12-10T13:41:36  <MarcoFalke> Yes, I think the re-ACKs shouldn't be too difficult
327 2020-12-10T13:41:55  <MarcoFalke> Not sure why no one has re-ACKed it in the last 9 days
328 2020-12-10T13:42:01  <sdaftuar> gleb reacked last night
329 2020-12-10T13:42:05  <sdaftuar> or this morning i guess
330 2020-12-10T13:45:06  <sdaftuar> MarcoFalke: if you do think it close, would you mind commenting on the PR that you think it would be ready for merge once it gets some re-acks?  so that other reviewers know their time will be well spent getting it across the finihs line
331 2020-12-10T13:45:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
332 2020-12-10T13:45:19  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/86f20071931b...b76abae387b9
333 2020-12-10T13:45:19  <bitcoin-git> bitcoin/master 32045bb wodry: [doc] Tidy up Tor doc (more stringent)
334 2020-12-10T13:45:20  <bitcoin-git> bitcoin/master b76abae Wladimir J. van der Laan: Merge #20587: [doc] Tidy up Tor doc (more stringent)
335 2020-12-10T13:45:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
336 2020-12-10T13:45:25  <sdaftuar> (after i rbease and repush anyway)
337 2020-12-10T13:45:27  <MarcoFalke> sdaftuar: Ok, I'll leave a comment
338 2020-12-10T13:45:31  <sdaftuar> thank you!
339 2020-12-10T13:45:43  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
340 2020-12-10T13:45:43  <bitcoin-git> [bitcoin] laanwj merged pull request #20587: [doc] Tidy up Tor doc (more stringent) (master...patch-2) https://github.com/bitcoin/bitcoin/pull/20587
341 2020-12-10T13:45:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
342 2020-12-10T13:48:55  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
343 2020-12-10T13:49:29  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo)
344 2020-12-10T13:51:01  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
345 2020-12-10T13:51:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
346 2020-12-10T13:51:12  <bitcoin-git> [bitcoin] Sjors opened pull request #20614: util: RunCommandParseJSON followups (master...2020/12/build-aux) https://github.com/bitcoin/bitcoin/pull/20614
347 2020-12-10T13:51:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
348 2020-12-10T13:53:32  *** alorente <alorente!~alorente@s91904426.blix.com> has quit IRC (Remote host closed the connection)
349 2020-12-10T13:55:44  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@> has joined #bitcoin-core-dev
350 2020-12-10T14:02:17  *** v4hn <v4hn!~v4hn@> has joined #bitcoin-core-dev
351 2020-12-10T14:07:24  *** roconnor <roconnor!~roconnor@host-45-58-200-239.dyn.295.ca> has joined #bitcoin-core-dev
352 2020-12-10T14:07:48  <promag> hebasto: does the branch work for you?
353 2020-12-10T14:09:10  <hebasto> promag: `make -C depends qt HOST=x86_64-apple-darwin18` ends with `Caching qt...` that means ok. Have you a problem with it?
354 2020-12-10T14:10:47  <promag> did it build qt quick controls?
355 2020-12-10T14:11:38  *** sr_gi <sr_gi!~sr_gi@> has quit IRC (Read error: Connection reset by peer)
356 2020-12-10T14:12:11  *** sr_gi <sr_gi!~sr_gi@> has joined #bitcoin-core-dev
357 2020-12-10T14:13:00  <hebasto> checking...
358 2020-12-10T14:13:49  <queip> the "score" field in getnetworkinfo, what does it actually mean? we are confused about it trying to provide support to user in #bitcoin .  Could RPC help xxx command include short explanation for the outputed JSON fields for most commands?
359 2020-12-10T14:14:58  <promag> hebasto: do you have qml/QtQuick/Controls.2 dir in the build dir?
360 2020-12-10T14:16:09  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
361 2020-12-10T14:18:21  *** miketwenty1 <miketwenty1!~miketwent@> has joined #bitcoin-core-dev
362 2020-12-10T14:19:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
363 2020-12-10T14:19:32  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20615: cirrus: Schedule one task with paid credits for faster CI feedback (master...2012-ciFasterFeedback) https://github.com/bitcoin/bitcoin/pull/20615
364 2020-12-10T14:19:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
365 2020-12-10T14:23:15  *** miketwenty1 <miketwenty1!~miketwent@> has quit IRC (Ping timeout: 265 seconds)
366 2020-12-10T14:26:46  <hebasto> promag: sorry (took my wrong branch), missed staging commands, updating...
367 2020-12-10T14:33:05  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
368 2020-12-10T14:33:07  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Read error: Connection reset by peer)
369 2020-12-10T14:33:25  <hebasto> promag: please check updated branch
370 2020-12-10T14:33:30  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
371 2020-12-10T14:33:35  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
372 2020-12-10T14:36:29  <hebasto> promag: I think `libqtquick2plugin.a` is that what we want, right?
373 2020-12-10T14:38:47  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
374 2020-12-10T14:39:22  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
375 2020-12-10T14:40:40  <hebasto> also built `libQt5Quick.a` `libQt5Qml.a`
376 2020-12-10T14:43:37  <promag> I think its missing qt quick controls lib
377 2020-12-10T14:45:13  <promag> hebasto: the thing is we must run qmake on qtquickcontrols after qtquick install
378 2020-12-10T14:46:41  *** miketwenty1 <miketwenty1!~miketwent@> has joined #bitcoin-core-dev
379 2020-12-10T14:50:26  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
380 2020-12-10T14:50:56  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 240 seconds)
381 2020-12-10T14:53:06  <hebasto> hmm, why `make -C depends HOST=x86_64-apple-darwin18` (in my branch) ends without any problem with all required static libraries built?
382 2020-12-10T14:53:42  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 265 seconds)
383 2020-12-10T14:54:37  *** molz_ <molz_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
384 2020-12-10T14:54:44  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Ping timeout: 256 seconds)
385 2020-12-10T14:57:58  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 256 seconds)
386 2020-12-10T14:59:46  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
387 2020-12-10T14:59:53  <promag> hebasto: not sure, but the suspect is "../qtbase/bin/qmake qtquickcontrols2.pro -o Makefile"
388 2020-12-10T15:00:19  <promag> that qmake doesn't find qtquick
389 2020-12-10T15:02:07  <sdaftuar> vasild: i am trying to restart the appveyor test in #19763, but i think maybe someone cancelled the build? i'm a bit confused
390 2020-12-10T15:02:09  <gribble> https://github.com/bitcoin/bitcoin/issues/19763 | net: dont try to relay to the address originator by vasild · Pull Request #19763 · bitcoin/bitcoin · GitHub
391 2020-12-10T15:03:04  <vasild> I did not cancel it, maybe it got confused somehow by my push of a previous commit?
392 2020-12-10T15:03:14  <hebasto> promag: for  which platform are you trying to build depends?
393 2020-12-10T15:03:26  <sdaftuar> i will try again
394 2020-12-10T15:03:52  <promag> hebasto: for my host, macos
395 2020-12-10T15:04:19  <hebasto> which macos version?
396 2020-12-10T15:08:28  *** peterrizzo_ <peterrizzo_!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
397 2020-12-10T15:09:19  <sdaftuar> vasild: ok i'm out of my depth on trying to get the appveyor or cirrus-ci builds to re-run
398 2020-12-10T15:12:22  <vasild> sdaftuar: if nothing else works, I can always make some minor whitespace change and re-push, but lets wait for all to complete first and see if somebody will have a better idea
399 2020-12-10T15:13:15  <sdaftuar> yeah, sounds good
400 2020-12-10T15:15:50  *** davterra <davterra!~davterra@static-198-54-131-156.cust.tzulo.com> has quit IRC (Quit: Leaving)
401 2020-12-10T15:22:24  *** peterrizzo_ <peterrizzo_!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo_)
402 2020-12-10T15:31:55  <promag> hebasto: Some of the required modules (qtHaveModule(quick)) are not available. \n Skipped.
403 2020-12-10T15:35:15  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
404 2020-12-10T15:35:16  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
405 2020-12-10T15:35:34  <hebasto> promag: thanks! I see this message on Big Sur.
406 2020-12-10T15:36:04  <promag> not on linux?
407 2020-12-10T15:39:26  <hebasto> on linux too ((
408 2020-12-10T15:41:25  <promag> ok good, at least we are on the same page :D
409 2020-12-10T15:41:51  *** miketwenty1 <miketwenty1!~miketwent@> has quit IRC (Remote host closed the connection)
410 2020-12-10T15:42:07  *** miketwenty1 <miketwenty1!~miketwent@> has joined #bitcoin-core-dev
411 2020-12-10T15:45:17  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
412 2020-12-10T15:46:10  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
413 2020-12-10T15:48:00  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 256 seconds)
414 2020-12-10T15:48:06  *** miketwen_ <miketwen_!~miketwent@ec2-34-202-224-110.compute-1.amazonaws.com> has joined #bitcoin-core-dev
415 2020-12-10T15:50:32  <promag> fanquake: cfields: do you see problems using qt single archive instead of separate modules?
416 2020-12-10T15:50:55  *** miketwenty1 <miketwenty1!~miketwent@> has quit IRC (Ping timeout: 246 seconds)
417 2020-12-10T15:51:14  <promag> download a bigger archive VS more complicated build script
418 2020-12-10T16:06:03  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC ()
419 2020-12-10T16:12:14  <ariard> sdaftuar: jonatack and I just re-ack #19858 but please ping again if there is a new rebase to deal with it, this PR has been in limbo for too long :)
420 2020-12-10T16:12:18  <gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
421 2020-12-10T16:13:29  <sdaftuar> ariard: thank you!
422 2020-12-10T16:15:03  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Ping timeout: 260 seconds)
423 2020-12-10T16:25:36  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
424 2020-12-10T16:25:48  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
425 2020-12-10T16:29:06  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Quit: Pavlenex)
426 2020-12-10T16:34:10  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
427 2020-12-10T16:34:45  *** kexkey <kexkey!~kexkey@static-198-54-132-141.cust.tzulo.com> has joined #bitcoin-core-dev
428 2020-12-10T16:36:41  <jonatack> I don't recall being able to restart appveyor, it always seemed more like a "game over, re-push to replay" thing. The cirrus builds can be restarted...ISTM they restart on their own after a while (unsure)
429 2020-12-10T16:39:58  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Quit: Pavlenex)
430 2020-12-10T16:42:23  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
431 2020-12-10T16:43:43  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
432 2020-12-10T16:46:02  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
433 2020-12-10T17:04:49  *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:1401:d5c:a187:3181> has quit IRC (Remote host closed the connection)
434 2020-12-10T17:08:35  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Remote host closed the connection)
435 2020-12-10T17:13:45  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
436 2020-12-10T17:33:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
437 2020-12-10T17:33:44  <bitcoin-git> [bitcoin] lontivero opened pull request #20616: Check CJDNS address is valid (master...validate-cjdns-addresses) https://github.com/bitcoin/bitcoin/pull/20616
438 2020-12-10T17:33:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
439 2020-12-10T17:34:03  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
440 2020-12-10T17:35:10  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
441 2020-12-10T17:41:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
442 2020-12-10T17:41:17  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b76abae387b9...da957cd62ecc
443 2020-12-10T17:41:17  <bitcoin-git> bitcoin/master fa918dd MarcoFalke: test: Use Popen.wait instead of RPC in assert_start_raises_init_error
444 2020-12-10T17:41:18  <bitcoin-git> bitcoin/master da957cd MarcoFalke: Merge #20613: test: Use Popen.wait instead of RPC in assert_start_raises_i...
445 2020-12-10T17:41:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
446 2020-12-10T17:41:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
447 2020-12-10T17:41:32  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20613: test: Use Popen.wait instead of RPC in assert_start_raises_init_error (master...2012-testFastFailInitError) https://github.com/bitcoin/bitcoin/pull/20613
448 2020-12-10T17:41:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
449 2020-12-10T17:42:48  *** pergaminho <pergaminho!~Cleber@> has quit IRC (Quit: Saindo)
450 2020-12-10T17:46:30  *** proofofkeags <proofofkeags!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has joined #bitcoin-core-dev
451 2020-12-10T17:46:36  *** kvaciral <kvaciral!~kvaciral@> has joined #bitcoin-core-dev
452 2020-12-10T17:58:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
453 2020-12-10T17:58:10  <bitcoin-git> [bitcoin] ariard opened pull request #20617: p2p: Remove m_is_manual_connection from CNodeState (master...2020-12-remove-is-manual-connection) https://github.com/bitcoin/bitcoin/pull/20617
454 2020-12-10T17:58:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
455 2020-12-10T18:19:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
456 2020-12-10T18:19:21  <bitcoin-git> [bitcoin] laanwj pushed 12 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/aa4b8ebfecdd...3fee499bc3af
457 2020-12-10T18:19:22  <bitcoin-git> bitcoin/0.21 9e80688 Pieter Wuille: Don't send 'sendaddrv2' to pre-70016 software
458 2020-12-10T18:19:23  <bitcoin-git> bitcoin/0.21 bead935 Pieter Wuille: Send and require SENDADDRV2 before VERACK
459 2020-12-10T18:19:24  <bitcoin-git> bitcoin/0.21 06c8423 Jon Atack: wallet, bugfix: allow send to take string fee rate values
460 2020-12-10T18:19:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
461 2020-12-10T18:19:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
462 2020-12-10T18:19:44  <bitcoin-git> [bitcoin] laanwj merged pull request #20612: [0.21] final rc3 backports (0.21...2012-finalRc3Backports) https://github.com/bitcoin/bitcoin/pull/20612
463 2020-12-10T18:19:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
464 2020-12-10T18:21:05  <MarcoFalke> \o/
465 2020-12-10T18:21:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
466 2020-12-10T18:21:29  <bitcoin-git> [bitcoin] hebasto closed pull request #19882: depends: Export variables from make to environment explicitly (master...200905-build) https://github.com/bitcoin/bitcoin/pull/19882
467 2020-12-10T18:21:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
468 2020-12-10T18:21:44  *** sr_gi <sr_gi!~sr_gi@> has quit IRC (Read error: Connection reset by peer)
469 2020-12-10T18:22:04  <sipa> are they (final rc3) backports, or final (rc3) backports?
470 2020-12-10T18:22:25  *** sr_gi <sr_gi!~sr_gi@> has joined #bitcoin-core-dev
471 2020-12-10T18:22:59  <MarcoFalke> hopefully both
472 2020-12-10T18:23:24  *** Guyver2_ is now known as Guyver2
473 2020-12-10T18:26:12  <luke-jr> XD
474 2020-12-10T18:33:55  <wumpus> i deleted the en_GB translation on transifex; it contained all kinds of junk, e.g. a pasted shell transcript, some French messages, and so on. Besides that it seems kind of pointless in the first place.
475 2020-12-10T18:35:14  <wumpus> sipa: final for rc3 at least, i plan to tag rc3 soon after
476 2020-12-10T18:45:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
477 2020-12-10T18:45:12  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/3fee499bc3af...e6d0fa3ef6f6
478 2020-12-10T18:45:12  <bitcoin-git> bitcoin/0.21 e6d0fa3 Wladimir J. van der Laan: gui: pre-rc3 translations update
479 2020-12-10T18:45:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
480 2020-12-10T18:46:06  <wumpus> no manual page changes and no English translation changes this time
481 2020-12-10T18:46:23  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
482 2020-12-10T18:56:56  *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-eaaqhhyeagrjdhwm> has joined #bitcoin-core-dev
483 2020-12-10T19:01:00  <hebasto> meeting?
484 2020-12-10T19:01:24  <luke-jr> ..
485 2020-12-10T19:02:02  <wumpus> #startmeeting
486 2020-12-10T19:02:15  <jnewbery> hi
487 2020-12-10T19:02:19  <achow101> hi
488 2020-12-10T19:02:21  <hebasto> hi
489 2020-12-10T19:02:21  <kanzure> hi
490 2020-12-10T19:02:26  <wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
491 2020-12-10T19:02:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
492 2020-12-10T19:02:27  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/e6d0fa3ef6f6...9ae536d3684e
493 2020-12-10T19:02:27  <bitcoin-git> bitcoin/0.21 9ae536d Wladimir J. van der Laan: build: Bump RC to rc3
494 2020-12-10T19:02:28  <wumpus> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus
495 2020-12-10T19:02:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
496 2020-12-10T19:02:45  <promag> hi
497 2020-12-10T19:02:48  <wumpus> no proposed topics for this week on http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
498 2020-12-10T19:02:49  <jb55> hi
499 2020-12-10T19:02:59  <wumpus> does anyone have last minute things they'd like to discuss?
500 2020-12-10T19:03:15  <Murch> hi
501 2020-12-10T19:03:38  <michaelfolkson> hi
502 2020-12-10T19:03:43  <jonasschnelli> hi
503 2020-12-10T19:03:43  <Murch> I'm sure achow101 would love if someone besides be would take a glance at #20040
504 2020-12-10T19:03:46  <gribble> https://github.com/bitcoin/bitcoin/issues/20040 | wallet: Refactor OutputGroups to handle fees and spending eligibility on grouping by achow101 · Pull Request #20040 · bitcoin/bitcoin · GitHub
505 2020-12-10T19:04:03  <Murch> *besides me
506 2020-12-10T19:04:07  <jonatack> hi
507 2020-12-10T19:04:12  <wumpus> is already in the high prioroty for review
508 2020-12-10T19:04:14  *** jarolrod <jarolrod!uid475272@gateway/web/irccloud.com/x-oeyqoxzpfotwpgrr> has joined #bitcoin-core-dev
509 2020-12-10T19:04:24  <wumpus> #topic High priority for review
510 2020-12-10T19:04:56  <jonatack> Murch: +1
511 2020-12-10T19:04:57  <wumpus> https://github.com/bitcoin/bitcoin/projects/8
512 2020-12-10T19:05:12  <wumpus> anything to add/remove or that is ready for merge?
513 2020-12-10T19:05:31  <MarcoFalke> anything holding back a 0.19 and 0.20 release?
514 2020-12-10T19:05:38  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
515 2020-12-10T19:05:42  <wumpus> FWIW I added #19858
516 2020-12-10T19:05:47  <gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
517 2020-12-10T19:06:03  <achow101> MarcoFalke: still waiting for #19740 for 0.20
518 2020-12-10T19:06:05  <gribble> https://github.com/bitcoin/bitcoin/issues/19740 | [0.20] wallet: Simplify and fix CWallet::SignTransaction by achow101 · Pull Request #19740 · bitcoin/bitcoin · GitHub
519 2020-12-10T19:06:22  <sdaftuar> wumpus: thanks!
520 2020-12-10T19:06:53  <jonatack> maybe #20546 for me
521 2020-12-10T19:06:56  <gribble> https://github.com/bitcoin/bitcoin/issues/20546 | policy, wallet, refactor: check for non-representable CFeeRates by jonatack · Pull Request #20546 · bitcoin/bitcoin · GitHub
522 2020-12-10T19:07:12  <MarcoFalke> achow101: merged
523 2020-12-10T19:07:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
524 2020-12-10T19:07:14  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/75bf23d8613a...953dddbd2058
525 2020-12-10T19:07:14  <bitcoin-git> bitcoin/0.20 2d48d7d Andrew Chow: Simplify and fix CWallet::SignTransaction
526 2020-12-10T19:07:15  <bitcoin-git> bitcoin/0.20 6a326cf Andrew Chow: tests: Test that a fully signed tx given to signrawtx is unchanged
527 2020-12-10T19:07:16  <bitcoin-git> bitcoin/0.20 953dddb MarcoFalke: Merge #19740: [0.20] wallet: Simplify and fix CWallet::SignTransaction
528 2020-12-10T19:07:17  <MarcoFalke> thanks for the test btw
529 2020-12-10T19:07:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
530 2020-12-10T19:07:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
531 2020-12-10T19:07:32  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19740: [0.20] wallet: Simplify and fix CWallet::SignTransaction (0.20...backport-17204-fix) https://github.com/bitcoin/bitcoin/pull/19740
532 2020-12-10T19:07:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
533 2020-12-10T19:07:43  <wumpus> jonatack: added
534 2020-12-10T19:07:59  <jonatack> wumpus: merci
535 2020-12-10T19:08:55  <wumpus> no idea about 0.19 and 0.20, but I'll tag 0.21.0rc3 after the meeting
536 2020-12-10T19:10:26  <wumpus> if the other branches are ready for tagging just say so
537 2020-12-10T19:12:04  <wumpus> okay, any other topics?
538 2020-12-10T19:12:17  <wumpus> seems to be a short meeting
539 2020-12-10T19:12:39  <sipa> 21 million decananoversions!
540 2020-12-10T19:13:08  <wumpus> hehe, a new version unit
541 2020-12-10T19:13:32  <sipa> 21M versionsats?
542 2020-12-10T19:13:56  <wumpus> better than versionbits *ducks*
543 2020-12-10T19:14:06  <sipa> hahaha
544 2020-12-10T19:14:10  <wumpus> #endmeeting
545 2020-12-10T19:14:10  <luke-jr> wut
546 2020-12-10T19:14:32  <jonatack> :D
547 2020-12-10T19:14:49  * Murch watches joke pass over his head
548 2020-12-10T19:14:51  <MarcoFalke> wumpus: yes, I think 0.19 and 0.20 are ready for tag as well
549 2020-12-10T19:15:04  <aj> 100 versionsats per versionbit then?
550 2020-12-10T19:15:08  <wumpus> seems the bot wandered off again
551 2020-12-10T19:15:30  <jonasschnelli> My fault...
552 2020-12-10T19:15:56  <wumpus> Murch: yes a bit of a inside joke there was some discussion about bitcoin units again on twitter
553 2020-12-10T19:16:45  <jonatack> we start using sats, suddenly there's a push for bits
554 2020-12-10T19:16:58  *** core-meetingbot <core-meetingbot!~meetingbo@2a01:4f9:2a:2510::2> has joined #bitcoin-core-dev
555 2020-12-10T19:16:59  <Murch> Must have missed it ^^
556 2020-12-10T19:17:12  <jonasschnelli> ping core-meetingbot
557 2020-12-10T19:18:30  <luke-jr> jonatack: not for feerate I think?
558 2020-12-10T19:19:26  <sipa> i missed that push too; i just found it funny due to name confusion with BIP9's versionbits
559 2020-12-10T19:19:42  <jonatack> luke-jr: i don't think so? Murch: easy to miss, bits means a few other things already
560 2020-12-10T19:19:44  <wumpus> MarcoFalke: ok!
561 2020-12-10T19:19:59  <Murch> luke-jr: Can't wait for bits per kilovirtualbyte :~
562 2020-12-10T19:20:10  <Murch> or bits per kilosipa
563 2020-12-10T19:20:12  <Murch> haha
564 2020-12-10T19:20:33  <Murch> jonatack: That's my biggest gripe with it
565 2020-12-10T19:23:47  <jonasschnelli> ping core-meetingbot
566 2020-12-10T19:24:50  <sipa> bad bot
567 2020-12-10T19:25:24  <jonasschnelli> wait wait
568 2020-12-10T19:25:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
569 2020-12-10T19:25:39  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/5baaea4410a1...5f2f304cbec9
570 2020-12-10T19:25:39  <bitcoin-git> bitcoin/0.19 5f2f304 Wladimir J. van der Laan: build: Bump version to 0.19.2rc1
571 2020-12-10T19:25:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
572 2020-12-10T19:25:47  <jonasschnelli> now
573 2020-12-10T19:25:49  <jonasschnelli> ping core-meetingbot
574 2020-12-10T19:25:57  * jonasschnelli hmm...
575 2020-12-10T19:26:15  <jonasschnelli> #startmeeting
576 2020-12-10T19:26:15  <core-meetingbot> Meeting started Thu Dec 10 19:26:15 2020 UTC.  The chair is jonasschnelli. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
577 2020-12-10T19:26:15  <core-meetingbot> Available commands: action commands idea info link nick
578 2020-12-10T19:26:18  <jonasschnelli> #endmeeting
579 2020-12-10T19:26:19  <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
580 2020-12-10T19:26:19  <core-meetingbot> Meeting ended Thu Dec 10 19:26:18 2020 UTC.
581 2020-12-10T19:26:19  <core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-12-10-19.26.moin.txt
582 2020-12-10T19:26:24  * jonasschnelli fixed...
583 2020-12-10T19:26:27  <promag> achow101: regarding https://bitcoin.stackexchange.com/questions/54230/any-plans-for-bitcoin-core-app-to-integrate-hardware-wallet-support#comment95782_54618  how would bitcoin core support hww in android for instance?
584 2020-12-10T19:27:13  <achow101> promag: no idea
585 2020-12-10T19:27:15  <jonasschnelli> sorry... the bots server had to restart recently and did not automatically identify via NickServ. That's why it was muted.
586 2020-12-10T19:27:26  <wumpus> jonasschnelli: thanks!
587 2020-12-10T19:27:41  <jonasschnelli> The todays meeting was though recorded: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-12-04-19.01.moin.txt
588 2020-12-10T19:27:45  <jonasschnelli> (the bot was just muted)
589 2020-12-10T19:27:48  <wumpus> jonasschnelli: oh good!
590 2020-12-10T19:27:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
591 2020-12-10T19:27:54  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.20: https://github.com/bitcoin/bitcoin/compare/953dddbd2058...2808593b7c8c
592 2020-12-10T19:27:54  <bitcoin-git> bitcoin/0.20 2808593 Wladimir J. van der Laan: build: Bump version to 0.20.2rc1
593 2020-12-10T19:27:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
594 2020-12-10T19:28:16  <jonasschnelli> ahm... wait. No. It wasn't
595 2020-12-10T19:28:25  <jonasschnelli> That was last weeks.
596 2020-12-10T19:28:57  <jonasschnelli> shouldn't happen again
597 2020-12-10T19:29:16  <wumpus> promag: depends on how the wallet connects to the host I suppose? host USB is supported on some android devices (since 3.1, I see)
598 2020-12-10T19:29:43  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Ping timeout: 240 seconds)
599 2020-12-10T19:30:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
600 2020-12-10T19:30:57  <bitcoin-git> [bitcoin] laanwj pushed tag v0.21.0rc3: https://github.com/bitcoin/bitcoin/compare/v0.21.0rc3
601 2020-12-10T19:30:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
602 2020-12-10T19:31:10  <wumpus> ^^
603 2020-12-10T19:32:04  <achow101> yay 3 things to build
604 2020-12-10T19:32:29  <wumpus> triple-combo tag (but for 0.20 and 0.19 I still have to do manual page updates and translations)
605 2020-12-10T19:32:50  <wumpus> that was a no-op for 0.21 this rc
606 2020-12-10T19:33:17  <wumpus> well the translations wasn't
607 2020-12-10T19:36:26  *** core-meetingbot <core-meetingbot!~meetingbo@2a01:4f9:2a:2510::2> has quit IRC (Quit: 2019.02.23)
608 2020-12-10T19:36:47  *** core-meetingbot <core-meetingbot!~meetingbo@2a01:4f9:2a:2510::2> has joined #bitcoin-core-dev
609 2020-12-10T19:37:00  <sipa> i've been out of the loop for gitian building for a few years, but have a good setup now
610 2020-12-10T19:37:12  <sipa> where do i start? i'm on ubuntu
611 2020-12-10T19:37:47  <jonasschnelli> sipa: https://github.com/bitcoin-core/docs/blob/master/gitian-building/gitian-building-setup-gitian-debian.md
612 2020-12-10T19:38:24  <jonasschnelli> then probably: ./gitian-build.py --setup (see https://github.com/bitcoin-core/docs/blob/master/gitian-building.md)
613 2020-12-10T19:39:07  <luke-jr> :o
614 2020-12-10T19:40:03  <sipa> so i'd create a debian VM, and run gitian inside that (with LXC?)
615 2020-12-10T19:41:08  <wumpus> that's what i have
616 2020-12-10T19:41:43  <sipa> ok
617 2020-12-10T19:42:10  <jonatack> https://github.com/jonatack/bitcoin-development/blob/master/gitian-building.md
618 2020-12-10T19:42:14  <jonasschnelli> sipa: I run LXC directly on a physical debian host
619 2020-12-10T19:42:24  <jonasschnelli> (I guess you can do the same with ubuntu?)
620 2020-12-10T19:42:40  <wumpus> if you already run debian you could skip the outer VM, but, I generally don't want to pollute the physical host with all kind of stuff
621 2020-12-10T19:43:03  <jonasschnelli> Yes. Agree that this makes sense.
622 2020-12-10T19:43:41  <sipa> i assume you can do the gpg signing outside the VM?
623 2020-12-10T19:43:45  <wumpus>  (though LXC isn't that bad)
624 2020-12-10T19:43:49  <wumpus> yes
625 2020-12-10T19:44:57  <jonasschnelli> sipa: yes. I also GPG sign "outside"
626 2020-12-10T19:45:13  <jonasschnelli> (on a different computer)
627 2020-12-10T19:45:16  <wumpus> I have my own script to fetch the assert files from the VM and sign them with (w  gpg2 --detach-sign), don't know if there's a standard way to do it nowadays
628 2020-12-10T19:45:43  <sipa> how much disk space would you need for the VM?
629 2020-12-10T19:45:57  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
630 2020-12-10T19:46:23  <jonasschnelli> 15G Aug 11 08:51 base-bionic-amd64
631 2020-12-10T19:46:34  <jonasschnelli> + some small stuff
632 2020-12-10T19:46:42  <sipa> cool
633 2020-12-10T19:46:57  <wumpus> it needs to write the output somewhere too but yes
634 2020-12-10T19:47:36  <jonasschnelli> You'll also need the macOS SDK (grab it from bitcoincore.org, check the travis files for the URL)
635 2020-12-10T19:47:47  <wumpus> I assigned 40GB to it
636 2020-12-10T19:48:28  <hebasto> sipa: https://bitcoincore.org/depends-sources/sdks/Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers.tar.gz
637 2020-12-10T19:48:51  <wumpus> it's preferable to extract the SDK using the instructions from an actual Apple download, especially if you have a mac yourself, but yeah most people simply grab it
638 2020-12-10T19:49:51  <sipa> i don't have any apple hardware
639 2020-12-10T19:49:59  <sipa> but you can do the extraction from linux, right?
640 2020-12-10T19:50:12  <jonasschnelli> I think you can
641 2020-12-10T19:50:37  <jonasschnelli> https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/README.md#sdk-extraction
642 2020-12-10T19:50:50  <jonasschnelli> you need an Apple ID though. :)
643 2020-12-10T19:51:22  <luke-jr> sipa: you may want more than 15 GB for caches
644 2020-12-10T19:51:27  <luke-jr> unless you wipe them
645 2020-12-10T19:52:03  <sipa> ok, gave it 50 G
646 2020-12-10T19:52:09  <luke-jr> I have 16 GB of caches alone XD
647 2020-12-10T19:52:47  <wumpus> definitely if you keep the caches for old branches around
648 2020-12-10T19:53:08  <luke-jr> hebasto: it's not technically legal for us to distribute that btw
649 2020-12-10T19:53:50  <wumpus> FWIW I usually delete the caches for every major/minor release, building the depends takes somewhat longer but it's rare enough, and there are some other steps that take a long time too
650 2020-12-10T19:54:39  <wumpus> and it wouldn't be the first time that solves a determinism issue
651 2020-12-10T19:54:45  *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has quit IRC (Ping timeout: 240 seconds)
652 2020-12-10T19:56:29  <jonasschnelli> bb8c59034420709cdbae2e47ec1a1dce03c68ab4142ff3b67a23c415e6557be1  bitcoin-0.21.0rc3-osx-unsigned.dmg
653 2020-12-10T19:56:32  <wumpus> it's especially for the linux build that caching really helps, qt for all those platforms
654 2020-12-10T19:57:23  <luke-jr> jonasschnelli: wow fast
655 2020-12-10T19:58:02  <jonasschnelli> luke-jr: macOS builds are fast (my script does that first): https://bitcoin.jonasschnelli.ch/gitian/build/358
656 2020-12-10T20:00:00  <luke-jr> i c
657 2020-12-10T20:00:11  <luke-jr> I think mine does Windows, Linux, macOS
658 2020-12-10T20:00:28  * luke-jr wonders if we ought to s/osx/macos/
659 2020-12-10T20:00:38  <luke-jr> or even just mac
660 2020-12-10T20:00:54  <sipa> especially with the latest release being XI and not X anymore
661 2020-12-10T20:00:55  <jonasschnelli> luke-jr: I looked into it. But I guess it's not really worth it.
662 2020-12-10T20:01:13  <jonasschnelli> sipa: its 10.16 and 11 (internally!)
663 2020-12-10T20:01:23  <sipa> jonasschnelli: i know
664 2020-12-10T20:01:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
665 2020-12-10T20:01:41  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/2808593b7c8c...a4bc4c1f79d7
666 2020-12-10T20:01:41  <bitcoin-git> bitcoin/0.20 98c9d79 Wladimir J. van der Laan: gui: Pre-rc1 translations update
667 2020-12-10T20:01:42  <bitcoin-git> bitcoin/0.20 a4bc4c1 Wladimir J. van der Laan: doc: Update manual pages pre-rc1
668 2020-12-10T20:01:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
669 2020-12-10T20:03:07  <wumpus> luke-jr: renaming files is kind of annoying, as the file names are hardcoded in all kinds of places and scripts, also not sure it's worth it for something that doesn't generate any ambiguity
670 2020-12-10T20:06:39  <sipa> jonasschnelli: i created an apple id, but it says i'm not allowed to download the xcode files
671 2020-12-10T20:07:15  *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
672 2020-12-10T20:07:17  <jonasschnelli> sipa: have you used the link from the docs?
673 2020-12-10T20:07:23  <jonasschnelli> I guess that one is old/invalid
674 2020-12-10T20:07:41  <jonasschnelli> Maybe go here: https://developer.apple.com/download/more/
675 2020-12-10T20:07:53  <jonasschnelli> (maybe directly here: https://download.developer.apple.com/Developer_Tools/Xcode_12.2/Xcode_12.2.xip)
676 2020-12-10T20:08:04  <sipa> is it ok to use a later version?
677 2020-12-10T20:08:05  <jonasschnelli> oh.. wait. you need to older version
678 2020-12-10T20:08:34  <jonasschnelli> maybe that one: https://download.developer.apple.com/Developer_Tools/Xcode_11.3.1/Xcode_11.3.1.xip?
679 2020-12-10T20:08:55  <jonasschnelli> (download works for me)
680 2020-12-10T20:10:01  <sipa> i need to sign up for the developer program
681 2020-12-10T20:10:06  <sipa> which is $99 a year
682 2020-12-10T20:10:08  <sipa> ??
683 2020-12-10T20:10:55  <achow101> sipa: it shouldn't be required, but I don't remember which links to go to
684 2020-12-10T20:11:06  <jonasschnelli> No. You don't need that
685 2020-12-10T20:11:18  <jonasschnelli> You only need the 99$ programm if you want to deploy apps
686 2020-12-10T20:11:57  <jonasschnelli> sipa: just click harder,... you'll find it
687 2020-12-10T20:12:28  <sipa> Sorry, you cannot view this page.
688 2020-12-10T20:12:33  <sipa> he Apple ID you signed in with does not have permission to view this page.
689 2020-12-10T20:12:38  <sipa> If you’re currently a member of the Apple Developer Program, you or your Account Holder may need to update your account by agreeing to the latest license agreement in order to access this page. To view your current membership status and benefits, visit your account.
690 2020-12-10T20:13:29  <jonasschnelli> sipa: let me try to create a new account..
691 2020-12-10T20:13:38  <jonasschnelli> Have you verified your email and all that stuff?
692 2020-12-10T20:13:50  <sipa> https://developer.apple.com/services-account/download?path=/Developer_Tools/Xcode_11.3.1/Xcode_11.3.1.xip
693 2020-12-10T20:13:53  <sipa> that works!
694 2020-12-10T20:15:03  *** kexkey_ <kexkey_!~kexkey@static-198-54-132-93.cust.tzulo.com> has joined #bitcoin-core-dev
695 2020-12-10T20:16:52  <jonasschnelli> sipa: Yes. Should work. I just created a new account.
696 2020-12-10T20:16:53  <jonasschnelli> works
697 2020-12-10T20:17:00  <jonasschnelli> You may need to agree to some terms etc.
698 2020-12-10T20:17:36  *** kexkey <kexkey!~kexkey@static-198-54-132-141.cust.tzulo.com> has quit IRC (Ping timeout: 240 seconds)
699 2020-12-10T20:17:54  <wumpus> let's update the URL in the doc
700 2020-12-10T20:18:23  <sipa> jonasschnelli: it's downloading, and i didn't do anything else :)
701 2020-12-10T20:19:15  <luke-jr> yeah.. I had to jump through some hoops to find it too
702 2020-12-10T20:20:19  <jonasschnelli> I guess that doc is outdated? https://github.com/bitcoin-core/docs/blob/master/gitian-building/gitian-building-mac-os-sdk.md
703 2020-12-10T20:21:19  <jonasschnelli> The link should still be valid: https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/README.md#sdk-extraction
704 2020-12-10T20:21:35  <jonasschnelli> I guess you'll get a 403 if you are not logged in our haven't accepted the terms, etc.
705 2020-12-10T20:21:49  <achow101> I think you need to already be logged in for the link to work
706 2020-12-10T20:21:55  <sipa> jonasschnelli: yeah the link there works
707 2020-12-10T20:22:00  <sipa> the previous one you gave didn't
708 2020-12-10T20:22:08  <jonasschnelli> its the same. :)
709 2020-12-10T20:22:10  <jonatack> "if it doesn't work, just click harder" :D ...that should go in the doc
710 2020-12-10T20:22:12  <jonasschnelli> I just dbl-checked
711 2020-12-10T20:22:27  <sipa> no it isn't
712 2020-12-10T20:22:29  <jonasschnelli> jonasschnelli: hah
713 2020-12-10T20:22:36  <sipa> https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/README.md#sdk-extraction has the wrong URL
714 2020-12-10T20:22:42  <sipa> https://github.com/bitcoin-core/docs/blob/master/gitian-building/gitian-building-mac-os-sdk.md has the right one
715 2020-12-10T20:22:51  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
716 2020-12-10T20:23:05  <sipa> they're literally not the same URL
717 2020-12-10T20:23:16  <achow101> sipa: the one in contrib/macdeploy works for me if I'm already logged in
718 2020-12-10T20:23:23  <sipa> i'm logged in
719 2020-12-10T20:23:33  <achow101> it's also the link that you get from the website and search for the sdk manually
720 2020-12-10T20:24:01  <sipa> wait
721 2020-12-10T20:24:04  <sipa> now the other one works too
722 2020-12-10T20:24:08  <sipa> ok, i give up!
723 2020-12-10T20:24:08  <jonasschnelli> sipa: the one you wrote last (gitian-building-mac-os-sdk.md) is outdated IMO
724 2020-12-10T20:24:15  <jonasschnelli> As I said. Click harder. :)
725 2020-12-10T20:24:26  <jonasschnelli> jonatack: heh.. :)
726 2020-12-10T20:24:33  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
727 2020-12-10T20:24:42  <sipa> my conspiracy theory is that the first URL starts working as soon as you try the second one
728 2020-12-10T20:24:49  *** gleb <gleb!~gleb@> has joined #bitcoin-core-dev
729 2020-12-10T20:25:28  <achow101> it's never easy with apple stuff
730 2020-12-10T20:25:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
731 2020-12-10T20:25:30  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/5f2f304cbec9...e301a9fde351
732 2020-12-10T20:25:30  <bitcoin-git> bitcoin/0.19 f8d2a04 Wladimir J. van der Laan: gui: Pre-rc1 translations update
733 2020-12-10T20:25:31  <bitcoin-git> bitcoin/0.19 e301a9f Wladimir J. van der Laan: doc: Pre-rc1 manual pages update
734 2020-12-10T20:25:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
735 2020-12-10T20:26:25  <jamesob> Argh, missed the meeting again.
736 2020-12-10T20:26:50  <gleb> jamesob: same here, just managed to join :)
737 2020-12-10T20:26:53  <jamesob> Can I review/merge beg for #19806? This one's been hanging out for a while
738 2020-12-10T20:26:59  <gribble> https://github.com/bitcoin/bitcoin/issues/19806 | validation: UTXO snapshot activation by jamesob · Pull Request #19806 · bitcoin/bitcoin · GitHub
739 2020-12-10T20:27:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
740 2020-12-10T20:27:19  <bitcoin-git> [bitcoin] laanwj pushed tag v0.19.2rc1: https://github.com/bitcoin/bitcoin/compare/v0.19.2rc1
741 2020-12-10T20:27:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
742 2020-12-10T20:27:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
743 2020-12-10T20:27:50  <bitcoin-git> [bitcoin] laanwj pushed tag v0.20.2rc1: https://github.com/bitcoin/bitcoin/compare/v0.20.2rc1
744 2020-12-10T20:27:51  <jamesob> gleb: timezones man, they're rough
745 2020-12-10T20:27:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
746 2020-12-10T20:29:31  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
747 2020-12-10T20:29:47  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
748 2020-12-10T20:30:59  <wumpus> now everyone can build their favorite branch
749 2020-12-10T20:31:36  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
750 2020-12-10T20:32:52  <achow101> I sure hope we don't have any non-determinism
751 2020-12-10T20:34:47  <wumpus> if so, especially for 0.19, deciding to forego the gitian build at all would be a valid choice
752 2020-12-10T20:35:48  <wumpus> the current (possibly final) state of the branch is tagged, that was kind of the point, people can build it from source if they want
753 2020-12-10T20:43:05  <jonasschnelli> achow101: 0.21.0rc3 macOS sigs are up (hash matches with yours and hebasto's): https://github.com/bitcoin-core/bitcoin-detached-sigs/tree/0.21
754 2020-12-10T20:50:30  *** zakkdev <zakkdev!~textual@> has joined #bitcoin-core-dev
755 2020-12-10T20:52:35  <achow101> waiting for one more windows sig
756 2020-12-10T20:53:21  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
757 2020-12-10T20:53:32  <jonasschnelli> achow101: https://bitcoin.jonasschnelli.ch/gitian/build/358
758 2020-12-10T20:53:41  <jonasschnelli> (commit soon as linux is done)
759 2020-12-10T20:53:58  <jonasschnelli> e72a9059a206a822fc02d7d304992a23acb9355fbf7b3b94353839075532bd5f  bitcoin-0.21.0rc3-win-unsigned.tar.gz
760 2020-12-10T21:00:43  *** proofofkeags_ <proofofkeags_!~proofofke@2601:280:c280:e500:105f:32aa:c59e:2130> has joined #bitcoin-core-dev
761 2020-12-10T21:03:05  *** proofofkeags <proofofkeags!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has quit IRC (Ping timeout: 240 seconds)
762 2020-12-10T21:10:57  <achow101> gitian builders: 0.21.0rc3 sigs are up
763 2020-12-10T21:18:16  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
764 2020-12-10T21:18:21  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo)
765 2020-12-10T21:18:30  <luke-jr> achow101: why? those sigs aren't supposed to be created until 3 gitian builds match
766 2020-12-10T21:18:43  <luke-jr> right now there's ZERO in the repo..
767 2020-12-10T21:18:46  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
768 2020-12-10T21:20:08  <luke-jr> where are you guys seeing sigs? :/
769 2020-12-10T21:20:25  <hebasto> luke-jr: https://github.com/bitcoin-core/bitcoin-detached-sigs/tree/0.21
770 2020-12-10T21:20:37  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 264 seconds)
771 2020-12-10T21:20:54  <luke-jr> hebasto: right, those aren't supposed to exist until there are 3 matching gitian sigs
772 2020-12-10T21:21:08  <luke-jr> but the gitian.sigs repo is empty afaict
773 2020-12-10T21:21:17  <luke-jr> (well, empty of rc3)
774 2020-12-10T21:21:40  *** chri_eb <chri_eb!~chris@gateway/tor-sasl/chrieb/x-28824719> has joined #bitcoin-core-dev
775 2020-12-10T21:22:09  <hebasto> yes, repo is empty; but hashes from achow101 jonasschnelli and me are the same, right?
776 2020-12-10T21:22:23  <achow101> luke-jr: prs are there
777 2020-12-10T21:22:26  <luke-jr> can't verify without the PGP sigs on them
778 2020-12-10T21:22:28  <luke-jr> achow101: ah
779 2020-12-10T21:22:38  <hebasto> luke-jr: right
780 2020-12-10T21:24:37  <luke-jr> only see achow101 and hebasto?
781 2020-12-10T21:25:56  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo)
782 2020-12-10T21:26:12  <achow101> luke-jr: jonasschnelli results are at https://bitcoin.jonasschnelli.ch/gitian/build/358
783 2020-12-10T21:26:12  *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-eaaqhhyeagrjdhwm> has quit IRC (Quit: Connection closed for inactivity)
784 2020-12-10T21:26:23  *** peterrizzo_ <peterrizzo_!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
785 2020-12-10T21:27:12  <luke-jr> not signed
786 2020-12-10T21:27:27  <luke-jr> oh,. they are
787 2020-12-10T21:27:45  <luke-jr> gotta scroll down
788 2020-12-10T21:28:47  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
789 2020-12-10T21:43:43  <wumpus> pushed sigs too
790 2020-12-10T21:44:18  <sipa> building!
791 2020-12-10T21:45:21  <luke-jr> mine is on riscv, so almost done
792 2020-12-10T21:45:29  <luke-jr> (turns out my order is win, osx, linux)
793 2020-12-10T21:50:05  *** v4hn <v4hn!~v4hn@> has quit IRC (Remote host closed the connection)
794 2020-12-10T21:58:02  *** JackSparrow <JackSparrow!~JackSparr@s91904426.blix.com> has joined #bitcoin-core-dev
795 2020-12-10T22:01:51  <theStack> fwiw, the contrib/gitian-build.py script with docker worked like a charm for me, no need for a vm
796 2020-12-10T22:02:43  *** proofofkeags__ <proofofkeags__!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has joined #bitcoin-core-dev
797 2020-12-10T22:05:22  *** proofofkeags_ <proofofkeags_!~proofofke@2601:280:c280:e500:105f:32aa:c59e:2130> has quit IRC (Ping timeout: 260 seconds)
798 2020-12-10T22:13:59  *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:4ca5:5aef:8068:2da7> has joined #bitcoin-core-dev
799 2020-12-10T22:23:47  *** zakkdev <zakkdev!~textual@> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
800 2020-12-10T22:24:27  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Read error: Connection reset by peer)
801 2020-12-10T22:24:51  *** TheRec <TheRec!~toto@drupal.org/user/146860/view> has quit IRC ()
802 2020-12-10T22:27:03  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Ping timeout: 240 seconds)
803 2020-12-10T22:27:28  *** btc_thc <btc_thc!annalee@kosher.marriageiguana.com> has quit IRC (Ping timeout: 246 seconds)
804 2020-12-10T22:29:21  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
805 2020-12-10T22:29:39  *** btc_thc <btc_thc!annalee@kosher.marriageiguana.com> has joined #bitcoin-core-dev
806 2020-12-10T22:31:12  *** proofofkeags_ <proofofkeags_!~proofofke@2601:280:c280:e500:1901:898e:ac68:17ca> has joined #bitcoin-core-dev
807 2020-12-10T22:32:37  *** proofofkeags__ <proofofkeags__!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has quit IRC (Read error: Connection reset by peer)
808 2020-12-10T22:33:44  *** proofofkeags__ <proofofkeags__!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has joined #bitcoin-core-dev
809 2020-12-10T22:35:37  *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
810 2020-12-10T22:36:06  *** proofofkeags_ <proofofkeags_!~proofofke@2601:280:c280:e500:1901:898e:ac68:17ca> has quit IRC (Ping timeout: 258 seconds)
811 2020-12-10T22:38:43  *** TheRec <TheRec!~toto@drupal.org/user/146860/view> has joined #bitcoin-core-dev
812 2020-12-10T22:50:46  *** kvaciral <kvaciral!~kvaciral@> has quit IRC (Quit: Lost terminal)
813 2020-12-10T23:03:58  *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
814 2020-12-10T23:04:20  *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
815 2020-12-10T23:04:21  <luke-jr> theStack: docker IS a VM…
816 2020-12-10T23:05:14  <sipa> luke-jr: i think he means he didn't need yet another VM around it
817 2020-12-10T23:08:25  *** jonatack <jonatack!~jon@> has quit IRC (Ping timeout: 246 seconds)
818 2020-12-10T23:09:44  *** jonatack <jonatack!~jon@> has joined #bitcoin-core-dev
819 2020-12-10T23:12:13  *** esotericnonsense <esotericnonsense!~esotericn@unaffiliated/esotericnonsense> has quit IRC (Ping timeout: 264 seconds)
820 2020-12-10T23:19:17  *** kristapsk_ <kristapsk_!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
821 2020-12-10T23:19:38  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
822 2020-12-10T23:24:20  *** esotericnonsense <esotericnonsense!~esotericn@unaffiliated/esotericnonsense> has joined #bitcoin-core-dev
823 2020-12-10T23:24:50  *** kristapsk___ <kristapsk___!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
824 2020-12-10T23:25:13  *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has joined #bitcoin-core-dev
825 2020-12-10T23:25:31  *** kristapsk_ <kristapsk_!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
826 2020-12-10T23:25:48  *** twistedline__ <twistedline__!~twisted@2601:14d:8500:a77d:2985:36c3:6c1f:47b8> has quit IRC (Read error: Connection reset by peer)
827 2020-12-10T23:30:08  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has quit IRC (Remote host closed the connection)
828 2020-12-10T23:30:11  *** proofofkeags_ <proofofkeags_!~proofofke@2601:280:c280:e500:7f46:e633:cdc5:9df4> has joined #bitcoin-core-dev
829 2020-12-10T23:30:24  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has joined #bitcoin-core-dev
830 2020-12-10T23:30:33  *** kristapsk___ <kristapsk___!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
831 2020-12-10T23:30:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
832 2020-12-10T23:30:44  <bitcoin-git> [gui] luke-jr opened pull request #149: Intro: Have user choose assumevalid (master...intro_assumevalid) https://github.com/bitcoin-core/gui/pull/149
833 2020-12-10T23:30:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
834 2020-12-10T23:30:53  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has quit IRC (Remote host closed the connection)
835 2020-12-10T23:31:53  <luke-jr> hebasto: promag: care to re-review https://github.com/bitcoin-core/gui/pull/125 - 2 ACKs, would be nice to get it in so I can move on to https://github.com/bitcoin-core/gui/pull/149 :P
836 2020-12-10T23:32:53  *** proofofkeags__ <proofofkeags__!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has quit IRC (Ping timeout: 260 seconds)
837 2020-12-10T23:34:15  *** jonatack <jonatack!~jon@> has quit IRC (Quit: jonatack)
838 2020-12-10T23:36:51  <theStack> luke-jr: not really, it shares the kernel with the host
839 2020-12-10T23:37:02  *** proofofkeags_ <proofofkeags_!~proofofke@2601:280:c280:e500:7f46:e633:cdc5:9df4> has quit IRC (Remote host closed the connection)
840 2020-12-10T23:40:26  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has joined #bitcoin-core-dev
841 2020-12-10T23:42:53  *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Read error: Connection reset by peer)
842 2020-12-10T23:43:08  *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has joined #bitcoin-core-dev
843 2020-12-10T23:46:55  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 246 seconds)
844 2020-12-10T23:48:04  *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
845 2020-12-10T23:48:38  <sipa> ok, i have the unsigned binaries, they match
846 2020-12-10T23:49:22  <sipa> i'm running gitian-build.py --sign now, but it seems it's building the linux binaries again?
847 2020-12-10T23:54:16  <sipa> oh, i'm silly
848 2020-12-10T23:54:18  *** jonatack <jonatack!~jon@> has joined #bitcoin-core-dev
849 2020-12-10T23:55:21  <sipa> -b == --build
850 2020-12-10T23:57:07  <luke-jr> theStack: so do many VMs
851 2020-12-10T23:57:24  <luke-jr> sipa: lol
852 2020-12-10T23:57:27  *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Remote host closed the connection)
853 2020-12-10T23:57:53  *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has joined #bitcoin-core-dev
854 2020-12-10T23:58:20  <theStack> luke-jr: there are tons of articles explaining the differences between containers and vms... feel free to redefine terms for yourself though
855 2020-12-10T23:59:51  *** jonatack <jonatack!~jon@> has quit IRC (Ping timeout: 260 seconds)