12020-12-10T00:01:10  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has joined #bitcoin-core-dev
  22020-12-10T00:16:30  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
  32020-12-10T00:30:23  *** milky1 <milky1!~milky@185.163.110.125> has quit IRC (Remote host closed the connection)
  42020-12-10T00:41:03  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Ping timeout: 240 seconds)
  52020-12-10T00:43:08  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
  62020-12-10T00:50:10  *** queip <queip!~queip@unaffiliated/rezurus> has quit IRC (Ping timeout: 256 seconds)
  72020-12-10T00:51:05  *** dachary1 <dachary1!~dachary@217.146.82.202> has joined #bitcoin-core-dev
  82020-12-10T01:09:39  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
  92020-12-10T01:28:29  <wumpus> why does fuzzing disable all other targets?
 102020-12-10T01:28:53  <wumpus> if it's a matter of compile flags we could only pass those for the fuzzing binaries i suppose?
 112020-12-10T01:30:03  <sipa> wumpus: every object has to be compiled with fuzzing enabled
 122020-12-10T01:30:13  <sipa> if you do, nothing but the fuzz binary makes any sense
 132020-12-10T01:30:56  <sipa> i have a separate worktree for fuzz builds
 142020-12-10T01:31:08  <sipa> because it's so exclusive with everything else
 152020-12-10T01:31:34  <sipa> (it needs a separate ./configure)
 162020-12-10T01:33:14  <wumpus> sipa: hmm we could compile every object twice in that case i guess
 172020-12-10T01:33:19  <sipa> i asked cfields before if it was possible to have a separate target for every object with fuzzing enabled
 182020-12-10T01:33:23  <sipa> but he said it was hard
 192020-12-10T01:33:47  <wumpus> that would make sense, i mean this keeps coming up
 202020-12-10T01:34:26  <sipa> my biggest gripe with the fuzz builds is that it's impossible to even do any compilation of the fuzz code without a separate configure step
 212020-12-10T01:34:46  <sipa> after merging them all in one binary it'd be easy to permit building the fuzz binary without fuzzing enabled, though
 222020-12-10T01:34:49  <wumpus> making say the fuzz objects .fuzz.o would also prevent them accidentally being linked into a non-fuzz binary (or the other wayr around)
 232020-12-10T01:35:44  <wumpus> yes, that might help
 242020-12-10T01:35:48  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
 252020-12-10T01:35:49  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
 262020-12-10T01:35:52  *** vasild_ is now known as vasild
 272020-12-10T01:37:02  *** jarolrod <jarolrod!uid475272@gateway/web/irccloud.com/x-zdbkvysnmfxkmryf> has joined #bitcoin-core-dev
 282020-12-10T01:39:56  *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
 292020-12-10T01:40:25  *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
 302020-12-10T01:41:41  <sipa> it'd be great if we could have a .fuzz.o for everything
 312020-12-10T01:41:48  <sipa> not sure how much work it is
 322020-12-10T01:43:44  <wumpus> i trust cfields is right that this is hard to realize with auto* build system for some reason
 332020-12-10T01:49:16  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
 342020-12-10T01:49:21  <sipa> we could even make a "dummy" fuzz binary when building without fuzzing that can only run existing seeds through the fuzz tests
 352020-12-10T01:49:50  <sipa> which would mean you can do the CI fuzz things without separate build
 362020-12-10T01:50:42  *** queip <queip!~queip@unaffiliated/rezurus> has joined #bitcoin-core-dev
 372020-12-10T01:52:43  <aj> sipa: ooo! that's a good idea!
 382020-12-10T01:54:51  * sipa suggests calling it phonyfuzz
 392020-12-10T01:54:57  <aj> phuzz
 402020-12-10T01:54:58  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 260 seconds)
 412020-12-10T01:55:15  <aj> faux+fuzz=fauzz?
 422020-12-10T01:55:22  <fanquake> .PHONY
 432020-12-10T02:05:11  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
 442020-12-10T02:06:45  <wumpus> let's try to merge #20560 soon then
 452020-12-10T02:06:47  <gribble> https://github.com/bitcoin/bitcoin/issues/20560 | fuzz: Link all targets once by MarcoFalke · Pull Request #20560 · bitcoin/bitcoin · GitHub
 462020-12-10T02:08:05  *** miketwe__ <miketwe__!~miketwent@ec2-18-205-136-236.compute-1.amazonaws.com> has quit IRC (Ping timeout: 240 seconds)
 472020-12-10T02:11:07  *** miketwen_ <miketwen_!~miketwent@ec2-34-202-224-110.compute-1.amazonaws.com> has joined #bitcoin-core-dev
 482020-12-10T02:11:25  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
 492020-12-10T02:14:16  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 240 seconds)
 502020-12-10T02:17:25  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 240 seconds)
 512020-12-10T02:19:24  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has joined #bitcoin-core-dev
 522020-12-10T02:23:55  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
 532020-12-10T02:30:07  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
 542020-12-10T02:30:45  *** miketwen_ <miketwen_!~miketwent@ec2-34-202-224-110.compute-1.amazonaws.com> has quit IRC (Read error: Connection reset by peer)
 552020-12-10T02:31:18  *** miketwen_ <miketwen_!~miketwent@ec2-34-202-224-110.compute-1.amazonaws.com> has joined #bitcoin-core-dev
 562020-12-10T02:35:01  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 264 seconds)
 572020-12-10T02:44:19  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
 582020-12-10T02:47:37  *** miketwen_ <miketwen_!~miketwent@ec2-34-202-224-110.compute-1.amazonaws.com> has quit IRC (Ping timeout: 264 seconds)
 592020-12-10T02:56:12  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 256 seconds)
 602020-12-10T03:12:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 612020-12-10T03:12:34  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0038ce97584f...17918a987aee
 622020-12-10T03:12:34  <bitcoin-git> bitcoin/master 7d0271b Russell Yanofsky: depends: Set CMAKE_INSTALL_RPATH for native packages
 632020-12-10T03:12:35  <bitcoin-git> bitcoin/master 17918a9 fanquake: Merge #20046: depends: Set CMAKE_INSTALL_RPATH for native packages
 642020-12-10T03:12:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 652020-12-10T03:13:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 662020-12-10T03:13:03  <bitcoin-git> [bitcoin] fanquake merged pull request #20046: depends: Set CMAKE_INSTALL_RPATH for native packages (master...pr/ipc-rpath) https://github.com/bitcoin/bitcoin/pull/20046
 672020-12-10T03:13:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 682020-12-10T03:28:45  *** samuel-pedraza <samuel-pedraza!47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.71.237.175.243> has joined #bitcoin-core-dev
 692020-12-10T03:30:42  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 258 seconds)
 702020-12-10T03:33:58  *** dermoth_ <dermoth_!~dermoth@unaffiliated/dermoth> has joined #bitcoin-core-dev
 712020-12-10T03:34:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 722020-12-10T03:34:13  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/17918a987aee...054710615c5e
 732020-12-10T03:34:13  <bitcoin-git> bitcoin/master ae9b489 fanquake: contrib: add symbol check test for PE
 742020-12-10T03:34:14  <bitcoin-git> bitcoin/master 0547106 fanquake: Merge #20608: contrib: add symbol check test for PE binaries
 752020-12-10T03:34:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 762020-12-10T03:34:18  *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has quit IRC (Disconnected by services)
 772020-12-10T03:34:20  *** dermoth_ is now known as dermoth
 782020-12-10T03:34:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 792020-12-10T03:34:33  <bitcoin-git> [bitcoin] fanquake merged pull request #20608: contrib: add symbol check test for PE binaries (master...symbol_check_test_pe) https://github.com/bitcoin/bitcoin/pull/20608
 802020-12-10T03:34:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 812020-12-10T03:35:02  *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
 822020-12-10T04:54:04  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
 832020-12-10T04:59:37  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 264 seconds)
 842020-12-10T04:59:50  *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
 852020-12-10T05:16:26  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 862020-12-10T05:22:44  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has joined #bitcoin-core-dev
 872020-12-10T05:26:41  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has quit IRC (Client Quit)
 882020-12-10T05:26:42  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 256 seconds)
 892020-12-10T05:29:21  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
 902020-12-10T05:48:52  *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
 912020-12-10T06:10:43  *** jkczyz <jkczyz!sid419941@gateway/web/irccloud.com/x-ibaprrhpcssnfiuj> has quit IRC (Read error: Connection reset by peer)
 922020-12-10T06:10:54  *** jkczyz <jkczyz!sid419941@gateway/web/irccloud.com/x-iecubrfqgzplxinh> has joined #bitcoin-core-dev
 932020-12-10T06:11:20  *** dburkett <dburkett!sid411344@gateway/web/irccloud.com/x-jsncuetqmrckjftg> has quit IRC (Read error: Connection reset by peer)
 942020-12-10T06:11:22  *** ahmed_ <ahmed_!sid14086@gateway/web/irccloud.com/x-pookjqmmhysqtsxx> has quit IRC (Ping timeout: 268 seconds)
 952020-12-10T06:11:22  *** moneyball <moneyball!sid299869@gateway/web/irccloud.com/x-wjkdiocnrkijgqvm> has quit IRC (Ping timeout: 268 seconds)
 962020-12-10T06:11:29  *** dburkett <dburkett!sid411344@gateway/web/irccloud.com/x-tkxwhnhavbsakwkd> has joined #bitcoin-core-dev
 972020-12-10T06:11:30  *** Galvas <Galvas!sid459296@gateway/web/irccloud.com/x-xysgxmoclwsvmqxp> has quit IRC (Read error: Connection reset by peer)
 982020-12-10T06:11:39  *** bosma <bosma!sid103570@gateway/web/irccloud.com/x-pkpfwlunsrhdoepd> has quit IRC (Read error: Connection reset by peer)
 992020-12-10T06:11:40  *** moneyball <moneyball!sid299869@gateway/web/irccloud.com/x-rochyfnjwpmypxlr> has joined #bitcoin-core-dev
1002020-12-10T06:11:40  *** Galvas <Galvas!sid459296@gateway/web/irccloud.com/x-bwbwszkdaytmfgex> has joined #bitcoin-core-dev
1012020-12-10T06:11:54  *** bosma <bosma!sid103570@gateway/web/irccloud.com/x-itslqunxawvbudln> has joined #bitcoin-core-dev
1022020-12-10T06:12:18  *** ahmed_ <ahmed_!sid14086@gateway/web/irccloud.com/x-jtijyzavnpaqnvsx> has joined #bitcoin-core-dev
1032020-12-10T06:15:02  *** twistedline__ <twistedline__!~twisted@2601:14d:8500:a77d:2985:36c3:6c1f:47b8> has joined #bitcoin-core-dev
1042020-12-10T06:16:00  *** twistedline_ <twistedline_!~twisted@c-73-200-216-219.hsd1.dc.comcast.net> has quit IRC (Ping timeout: 272 seconds)
1052020-12-10T06:28:41  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.29.209> has joined #bitcoin-core-dev
1062020-12-10T06:31:55  *** mrostecki <mrostecki!mrostecki@nat/suse/x-oplejjvnaxzshynh> has quit IRC (Quit: WeeChat 1.8)
1072020-12-10T06:32:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1082020-12-10T06:32:04  <bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/054710615c5e...f5b2ea3e5918
1092020-12-10T06:32:05  <bitcoin-git> bitcoin/master 5805b82 John Newbery: [net processing] Move PushNodeVersion into PeerManager
1102020-12-10T06:32:05  <bitcoin-git> bitcoin/master f3f61d0 John Newbery: [net processing] Add IgnoresIncomingTxs() function to PeerManager
1112020-12-10T06:32:06  <bitcoin-git> bitcoin/master 4d510aa John Newbery: [init] Use MakeUnique<> to construct peerman
1122020-12-10T06:32:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1132020-12-10T06:32:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1142020-12-10T06:32:23  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20217: net: Remove g_relay_txes (master...2020-10-remove-grelaytxes) https://github.com/bitcoin/bitcoin/pull/20217
1152020-12-10T06:32:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1162020-12-10T06:39:20  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
1172020-12-10T06:44:47  *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has joined #bitcoin-core-dev
1182020-12-10T06:53:55  *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has quit IRC (Quit: Pavlenex)
1192020-12-10T06:54:33  *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has joined #bitcoin-core-dev
1202020-12-10T07:02:41  *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has quit IRC (Quit: Pavlenex)
1212020-12-10T07:23:52  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1222020-12-10T07:27:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1232020-12-10T07:27:30  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/f5b2ea3e5918...22f13c1e088e
1242020-12-10T07:27:30  <bitcoin-git> bitcoin/master 30bc8fa Sebastian Falbesoner: net: save high-bandwidth mode states in CNodeStats
1252020-12-10T07:27:31  <bitcoin-git> bitcoin/master a7ed00f Sebastian Falbesoner: rpc: expose high-bandwidth mode states via getpeerinfo
1262020-12-10T07:27:31  <bitcoin-git> bitcoin/master dab6583 Sebastian Falbesoner: doc: release note for new getpeerinfo fields "bip152_hb_{from,to}"
1272020-12-10T07:27:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1282020-12-10T07:27:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1292020-12-10T07:27:49  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19776: net, rpc: expose high bandwidth mode state via getpeerinfo (master...20200821-rpc-expose-high-handwidth-mode-state-via-getpeerinfo) https://github.com/bitcoin/bitcoin/pull/19776
1302020-12-10T07:27:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1312020-12-10T07:28:38  *** gleb <gleb!~gleb@178.150.137.228> has quit IRC (Ping timeout: 260 seconds)
1322020-12-10T07:33:36  *** samuel-pedraza <samuel-pedraza!47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.71.237.175.243> has quit IRC (Ping timeout: 240 seconds)
1332020-12-10T07:36:06  *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Read error: Connection reset by peer)
1342020-12-10T07:39:10  *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
1352020-12-10T07:48:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1362020-12-10T07:48:45  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/22f13c1e088e...38176dc66523
1372020-12-10T07:48:46  <bitcoin-git> bitcoin/master ce207d6 Jon Atack: wallet, bugfix: allow send to take string fee rate values
1382020-12-10T07:48:46  <bitcoin-git> bitcoin/master 6fa72ce Jon Atack: test: add coverage for passing fee rate as a string
1392020-12-10T07:48:47  <bitcoin-git> bitcoin/master 38176dc MarcoFalke: Merge #20573: wallet, bugfix: allow send with string fee_rate amounts
1402020-12-10T07:48:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1412020-12-10T07:49:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1422020-12-10T07:49:05  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20573: wallet, bugfix: allow send with string fee_rate amounts (master...send-allow-feerates-as-strings) https://github.com/bitcoin/bitcoin/pull/20573
1432020-12-10T07:49:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1442020-12-10T07:56:38  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 260 seconds)
1452020-12-10T07:58:20  *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has joined #bitcoin-core-dev
1462020-12-10T08:01:09  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
1472020-12-10T08:03:10  <az0re> What is the proper way to get the amount of a CTxIn?
1482020-12-10T08:05:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1492020-12-10T08:05:29  <bitcoin-git> [bitcoin] jarolrod opened pull request #20610: doc: update for NetBSD 9.1, add GUI Build Instructions (master...netbsd-docs) https://github.com/bitcoin/bitcoin/pull/20610
1502020-12-10T08:05:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1512020-12-10T08:08:03  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Ping timeout: 240 seconds)
1522020-12-10T08:13:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1532020-12-10T08:13:47  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/38176dc66523...c8fdbb46bd92
1542020-12-10T08:13:47  <bitcoin-git> bitcoin/master 904d875 Andrew Poelstra: configure: output notice that test binary is disabled by fuzzing
1552020-12-10T08:13:48  <bitcoin-git> bitcoin/master c8fdbb4 MarcoFalke: Merge #20609: configure: output notice that test binary is disabled by fuz...
1562020-12-10T08:13:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1572020-12-10T08:14:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1582020-12-10T08:14:07  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20609: configure: output notice that test binary is disabled by fuzzing (master...2020-12--fuzz-config-output) https://github.com/bitcoin/bitcoin/pull/20609
1592020-12-10T08:14:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1602020-12-10T08:40:29  <jonasschnelli> curios to know: why do we have nPruneAfterHeight (a minimum height for pruning)?
1612020-12-10T08:40:46  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Remote host closed the connection)
1622020-12-10T08:45:46  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
1632020-12-10T08:48:46  <az0re> Alternatively, how should I get a CTxOut from a COutPoint (e.g., from CTxIn::prevout)?
1642020-12-10T08:51:30  *** dachary1 <dachary1!~dachary@217.146.82.202> has quit IRC (Ping timeout: 256 seconds)
1652020-12-10T08:56:55  *** instagibbs <instagibbs!~greg@061093103011.ctinets.com> has quit IRC (Ping timeout: 258 seconds)
1662020-12-10T08:58:03  <sipa> az0re: look it up in the UTXO set
1672020-12-10T08:58:56  <az0re> ELI5 please :)
1682020-12-10T08:59:16  *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has quit IRC (Quit: Pavlenex)
1692020-12-10T08:59:41  <az0re> To be more specific, how best to do it from within validation.cpp?
1702020-12-10T09:00:14  <az0re> (I am new to the Bitcoin codebase and would appreciate some tips on the most relevant data structures)
1712020-12-10T09:00:57  *** instagibbs <instagibbs!~greg@061093103011.ctinets.com> has joined #bitcoin-core-dev
1722020-12-10T09:03:03  *** jonatack <jonatack!~jon@109.232.227.138> has quit IRC (Remote host closed the connection)
1732020-12-10T09:03:16  <aj> az0re: there's a "gettxout" rpc call, you could look at how it's implemented in rpc/blockchain.cpp; or similar for "getrawtransaction" if you want to lookup the blockchain rather than the utxo set
1742020-12-10T09:03:47  <az0re> OK roger that I'll check them out
1752020-12-10T09:03:48  <az0re> Thanks
1762020-12-10T09:04:23  *** jonatack <jonatack!~jon@109.232.227.138> has joined #bitcoin-core-dev
1772020-12-10T09:07:42  <az0re> Actually I think Consensus::CheckTxInputs() did the trick for me.  Looks like I need a CCoinsViewCache, then get a Coin from it with CCoinsViewCache::AccessCoin(), and can get the CTxOut from Coin::out
1782020-12-10T09:09:50  <sipa> az0re: yeah, pretty much
1792020-12-10T09:10:02  <sipa> where to get that cache depends on the context
1802020-12-10T09:10:24  <sipa> if you need to include mempool UTXOs as well it's a bitndifferent
1812020-12-10T09:11:41  <az0re> Hmmm...
1822020-12-10T09:12:55  <sipa> the gettxout RPC supports both with and without mempool
1832020-12-10T09:13:01  <sipa> so you can use that as an example
1842020-12-10T09:13:24  *** ctrlbreak <ctrlbreak!~ctrlbreak@159.2.165.130> has quit IRC (Ping timeout: 258 seconds)
1852020-12-10T09:13:28  *** alorente <alorente!~alorente@s91904426.blix.com> has joined #bitcoin-core-dev
1862020-12-10T09:16:31  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
1872020-12-10T09:20:45  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 240 seconds)
1882020-12-10T09:23:10  <az0re> I see, thanks
1892020-12-10T09:23:11  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1902020-12-10T09:25:20  *** mrostecki <mrostecki!mrostecki@nat/suse/x-wasokcvpgafclwxo> has joined #bitcoin-core-dev
1912020-12-10T09:45:40  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1922020-12-10T09:47:29  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.29.209> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
1932020-12-10T09:51:53  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has joined #bitcoin-core-dev
1942020-12-10T09:56:23  <jonasschnelli> MarcoFalke: functional tests: when calling assert_start_raises_init_error, the node checks for a few seconds for an RPC connection (bitcoind started, waiting for RPC to come up). Would it be possible to detect a shutdown and init error rather then polling RPC?
1952020-12-10T09:56:31  <jonasschnelli> (would save some seconds)
1962020-12-10T10:04:46  *** kexkey <kexkey!~kexkey@static-198-54-132-157.cust.tzulo.com> has quit IRC (Ping timeout: 258 seconds)
1972020-12-10T10:06:04  <wumpus> it's definitely possible to detect with subprocess that the child processes exited
1982020-12-10T10:07:14  <wumpus> or wait for it to exit, even with a timeout
1992020-12-10T10:16:22  <jonasschnelli> hmm... our testframework calls "if self.process.poll() is not None:"... I guess that should detect the halted process
2002020-12-10T10:16:32  <jonasschnelli> (but it doesn't)
2012020-12-10T10:16:45  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
2022020-12-10T10:16:47  <jonasschnelli> or it does but the timeout is too large
2032020-12-10T10:17:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2042020-12-10T10:17:00  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20611: Move TX_MAX_STANDARD_VERSION to policy (master...2012-mvTxStandardVersion) https://github.com/bitcoin/bitcoin/pull/20611
2052020-12-10T10:17:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2062020-12-10T10:17:17  <jonasschnelli> it's a race
2072020-12-10T10:18:51  *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has joined #bitcoin-core-dev
2082020-12-10T10:19:40  <wumpus> dunno--fwiw there's .poll() which polls if the process is still running and .wait(timeout) that waits
2092020-12-10T10:21:06  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 265 seconds)
2102020-12-10T10:21:15  <wumpus> the preferable thing, if no RPC interaction is neccesary, would be to wait, no need for periodic polling
2112020-12-10T10:22:43  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2122020-12-10T10:22:44  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c8fdbb46bd92...eb53c03b3680
2132020-12-10T10:22:45  <bitcoin-git> bitcoin/master 39c42c4 Pieter Wuille: Improve heuristic hex transaction decoding
2142020-12-10T10:22:46  <bitcoin-git> bitcoin/master 0f949cd Pieter Wuille: Add regression test for incorrect decoding
2152020-12-10T10:22:46  <bitcoin-git> bitcoin/master eb53c03 Wladimir J. van der Laan: Merge #20595: Improve heuristic hex transaction decoding
2162020-12-10T10:22:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2172020-12-10T10:23:01  <wumpus> when any kind of RPC interaction is necessary there's no other option than to poll until it becomes available, there's no way to asynchronously be notified that 'RPC is up'
2182020-12-10T10:23:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2192020-12-10T10:23:03  <bitcoin-git> [bitcoin] laanwj merged pull request #20595: Improve heuristic hex transaction decoding (master...202012_fancy_tx_hex_decode) https://github.com/bitcoin/bitcoin/pull/20595
2202020-12-10T10:23:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2212020-12-10T10:23:29  <wumpus> (maybe there should be)
2222020-12-10T10:23:59  <wumpus> although honestly I have no idea how to fit that best into the POSIX process model
2232020-12-10T10:25:47  <wumpus> hm I guess bitcoind could print some token to stdout / stderr that is detected by the connected parent process and taken as signal that RPC is running
2242020-12-10T10:26:40  <wumpus> alternatively it'd be possible to pass, say, in an additional file descriptor for signaling but that probably gets too fiddly
2252020-12-10T10:29:42  *** promag_ is now known as promag
2262020-12-10T10:29:47  <promag> fanquake: ping?
2272020-12-10T10:29:51  <MarcoFalke> jonasschnelli: removing the rpc polling from assert_start_raises_init_error is a good idea
2282020-12-10T10:30:06  <MarcoFalke> we have intermittent issues due to that
2292020-12-10T10:30:32  <fanquake> promag: hi
2302020-12-10T10:30:35  <MarcoFalke> removing rpc from the equation should make everything more stable, but I am not sure how easy it is to implement
2312020-12-10T10:30:36  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
2322020-12-10T10:30:58  <MarcoFalke> if `assert_start_raises_init_error` fails, you'll have to use the rpc to use "stop"
2332020-12-10T10:31:04  <jonasschnelli> MarcoFalke: Agree. Though I'm not touching it for now. Happy if someone wants to take a closer look.
2342020-12-10T10:31:12  <MarcoFalke> or are the nodes shut down with SIGKILL? I don't remember
2352020-12-10T10:31:35  <promag> fanquake: I have an issue, not sure how to proceed. see https://github.com/icota/bitcoin/commit/683710e072eb90296ae5a57f53bce7cac799fc41
2362020-12-10T10:31:38  <jonasschnelli> I don't think that we test for SIGKILL
2372020-12-10T10:31:47  <promag> fanquake: I'll comment there
2382020-12-10T10:32:55  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has joined #bitcoin-core-dev
2392020-12-10T10:33:35  <MarcoFalke> Everything ready for rc3?
2402020-12-10T10:34:08  <MarcoFalke> Who is doing the backports? Happy to do them if no one is working on it yet
2412020-12-10T10:34:15  <MarcoFalke> fanquake: wumpus: ^
2422020-12-10T10:34:53  <fanquake> MarcoFalke: I was just waiting for the last few merges. Happy for you to do if you want. I’m afk for an hour or so
2432020-12-10T10:35:02  <fanquake> Promag: thanks, I’ll take a look tonight
2442020-12-10T10:39:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2452020-12-10T10:39:04  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20612: [0.21] final rc3 backports (0.21...2012-finalRc3Backports) https://github.com/bitcoin/bitcoin/pull/20612
2462020-12-10T10:39:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2472020-12-10T10:39:06  <MarcoFalke> done ^
2482020-12-10T10:45:49  *** jarolrod <jarolrod!uid475272@gateway/web/irccloud.com/x-zdbkvysnmfxkmryf> has quit IRC (Quit: Connection closed for inactivity)
2492020-12-10T10:48:56  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 240 seconds)
2502020-12-10T10:54:33  <wumpus> MarcoFalke: I think we don't use the signals in the RPC tests because windows; I guess though it could start polling RPC only after the process didn't shut down as expected after a certain timeout
2512020-12-10T10:54:42  <wumpus> MarcoFalke: thanks
2522020-12-10T10:57:52  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
2532020-12-10T11:01:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2542020-12-10T11:01:03  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/eb53c03b3680...dcff2ee1fbf4
2552020-12-10T11:01:03  <bitcoin-git> bitcoin/master faefa5d MarcoFalke: log: Clarify that failure to write fee_estimates.dat is non-fatal
2562020-12-10T11:01:04  <bitcoin-git> bitcoin/master fa0d835 MarcoFalke: log: Clarify that failure to read fee_estimates.dat is non-fatal
2572020-12-10T11:01:05  <bitcoin-git> bitcoin/master dcff2ee Wladimir J. van der Laan: Merge #20589: log: Clarify that failure to read/write fee_estimates.dat is...
2582020-12-10T11:01:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2592020-12-10T11:01:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2602020-12-10T11:01:22  <bitcoin-git> [bitcoin] laanwj merged pull request #20589: log: Clarify that failure to read/write fee_estimates.dat is non-fatal (master...2012-logFeeest) https://github.com/bitcoin/bitcoin/pull/20589
2612020-12-10T11:01:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2622020-12-10T11:03:34  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
2632020-12-10T11:03:46  <hebasto> promag: did you try https://github.com/icota/bitcoin/commit/683710e072eb90296ae5a57f53bce7cac799fc41#commitcomment-44988208 ?
2642020-12-10T11:05:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2652020-12-10T11:05:10  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dcff2ee1fbf4...e20b488395c1
2662020-12-10T11:05:11  <bitcoin-git> bitcoin/master 34c80d9 Wladimir J. van der Laan: test: Add option to git-subtree-check to do full check, add help
2672020-12-10T11:05:12  <bitcoin-git> bitcoin/master e20b488 Wladimir J. van der Laan: Merge #20567: test: Add option to git-subtree-check to do full check, add ...
2682020-12-10T11:05:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2692020-12-10T11:05:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2702020-12-10T11:05:30  <bitcoin-git> [bitcoin] laanwj merged pull request #20567: test: Add option to git-subtree-check to do full check, add help (master...2020_12_subtree_check) https://github.com/bitcoin/bitcoin/pull/20567
2712020-12-10T11:05:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2722020-12-10T11:05:55  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
2732020-12-10T11:09:40  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has joined #bitcoin-core-dev
2742020-12-10T11:10:40  <promag> hebasto: thanks, will try it
2752020-12-10T11:14:04  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has quit IRC (Client Quit)
2762020-12-10T11:31:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2772020-12-10T11:31:00  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20613: test: Use Popen.wait instead of RPC in assert_start_raises_init_error (master...2012-testFastFailInitError) https://github.com/bitcoin/bitcoin/pull/20613
2782020-12-10T11:31:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2792020-12-10T11:31:51  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has quit IRC (Remote host closed the connection)
2802020-12-10T11:40:09  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
2812020-12-10T11:44:44  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
2822020-12-10T11:54:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2832020-12-10T11:54:36  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e20b488395c1...8e1f9d62731c
2842020-12-10T11:54:37  <bitcoin-git> bitcoin/master 206f74e João Barbosa: Support make src/bitcoin-node and src/bitcoin-gui
2852020-12-10T11:54:37  <bitcoin-git> bitcoin/master 8e1f9d6 Wladimir J. van der Laan: Merge #20549: Support make src/bitcoin-node and src/bitcoin-gui
2862020-12-10T11:54:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2872020-12-10T11:54:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2882020-12-10T11:54:56  <bitcoin-git> [bitcoin] laanwj merged pull request #20549: Support make src/bitcoin-node and src/bitcoin-gui (master...2020-12-make-bitcoin-node) https://github.com/bitcoin/bitcoin/pull/20549
2892020-12-10T11:54:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2902020-12-10T11:56:04  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has quit IRC (Remote host closed the connection)
2912020-12-10T11:56:22  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
2922020-12-10T12:03:03  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
2932020-12-10T12:03:48  *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has quit IRC (Quit: Pavlenex)
2942020-12-10T12:19:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2952020-12-10T12:19:12  <bitcoin-git> [bitcoin] jonasschnelli pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8e1f9d62731c...86f20071931b
2962020-12-10T12:19:12  <bitcoin-git> bitcoin/master c96d1f6 Hennadii Stepanov: build, refactor: Check that Homebrew's qt5 package is actually installed
2972020-12-10T12:19:13  <bitcoin-git> bitcoin/master ee7b84e Hennadii Stepanov: build: Use Homebrew's sqlite package if it is available
2982020-12-10T12:19:14  <bitcoin-git> bitcoin/master c932e0d Hennadii Stepanov: doc: Update wallet database installation guide for macOS
2992020-12-10T12:19:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3002020-12-10T12:19:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3012020-12-10T12:19:41  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #20527: build: Do not ignore Homebrew's SQLite on macOS (master...201129-sqlite) https://github.com/bitcoin/bitcoin/pull/20527
3022020-12-10T12:19:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3032020-12-10T12:23:37  *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has joined #bitcoin-core-dev
3042020-12-10T12:36:03  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has quit IRC (Remote host closed the connection)
3052020-12-10T12:38:10  *** ctrlbreak <ctrlbreak!~ctrlbreak@159.2.165.130> has joined #bitcoin-core-dev
3062020-12-10T12:48:15  *** Pavlenex1 <Pavlenex1!~Thunderbi@185.244.212.67> has joined #bitcoin-core-dev
3072020-12-10T12:49:56  *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has quit IRC (Ping timeout: 240 seconds)
3082020-12-10T12:49:56  *** Pavlenex1 is now known as Pavlenex
3092020-12-10T12:53:20  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
3102020-12-10T13:04:29  *** Pavlenex <Pavlenex!~Thunderbi@185.244.212.67> has quit IRC (Quit: Pavlenex)
3112020-12-10T13:10:57  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.29.209> has joined #bitcoin-core-dev
3122020-12-10T13:11:33  <hebasto> promag: the combined branch for qml static builds https://github.com/hebasto/bitcoin/commits/201210-qml
3132020-12-10T13:15:02  *** pergaminho <pergaminho!~Cleber@189.26.121.248> has joined #bitcoin-core-dev
3142020-12-10T13:26:36  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
3152020-12-10T13:28:56  *** openoms <openoms!~quassel@91.132.136.76> has quit IRC (Ping timeout: 256 seconds)
3162020-12-10T13:33:33  *** openoms <openoms!~quassel@91.132.136.76> has joined #bitcoin-core-dev
3172020-12-10T13:35:46  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
3182020-12-10T13:35:47  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
3192020-12-10T13:35:47  *** vasild_ is now known as vasild
3202020-12-10T13:39:00  <sdaftuar> MarcoFalke: can you tell me your thoughts on how close #19858 is to be merged? 3 PRs that conflict with it have been merged since it was acked 4 times, so i'm trying to rebase and get re-review before this happens again
3212020-12-10T13:39:04  <gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
3222020-12-10T13:40:21  <sdaftuar> but if it will be a while i can hold off on pestering people
3232020-12-10T13:40:52  <MarcoFalke> sdaftuar: I explictly held back on merging the conflicting prs. I simply didn't get the notification last night from GitHub that you rebased it
3242020-12-10T13:41:08  <sdaftuar> ah, thanks for the effort
3252020-12-10T13:41:21  <sdaftuar> so i should go ahead then with my rebase and re-pester plan
3262020-12-10T13:41:36  <MarcoFalke> Yes, I think the re-ACKs shouldn't be too difficult
3272020-12-10T13:41:55  <MarcoFalke> Not sure why no one has re-ACKed it in the last 9 days
3282020-12-10T13:42:01  <sdaftuar> gleb reacked last night
3292020-12-10T13:42:05  <sdaftuar> or this morning i guess
3302020-12-10T13:45:06  <sdaftuar> MarcoFalke: if you do think it close, would you mind commenting on the PR that you think it would be ready for merge once it gets some re-acks?  so that other reviewers know their time will be well spent getting it across the finihs line
3312020-12-10T13:45:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3322020-12-10T13:45:19  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/86f20071931b...b76abae387b9
3332020-12-10T13:45:19  <bitcoin-git> bitcoin/master 32045bb wodry: [doc] Tidy up Tor doc (more stringent)
3342020-12-10T13:45:20  <bitcoin-git> bitcoin/master b76abae Wladimir J. van der Laan: Merge #20587: [doc] Tidy up Tor doc (more stringent)
3352020-12-10T13:45:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3362020-12-10T13:45:25  <sdaftuar> (after i rbease and repush anyway)
3372020-12-10T13:45:27  <MarcoFalke> sdaftuar: Ok, I'll leave a comment
3382020-12-10T13:45:31  <sdaftuar> thank you!
3392020-12-10T13:45:43  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3402020-12-10T13:45:43  <bitcoin-git> [bitcoin] laanwj merged pull request #20587: [doc] Tidy up Tor doc (more stringent) (master...patch-2) https://github.com/bitcoin/bitcoin/pull/20587
3412020-12-10T13:45:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3422020-12-10T13:48:55  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.29.209> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
3432020-12-10T13:49:29  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo)
3442020-12-10T13:51:01  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
3452020-12-10T13:51:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3462020-12-10T13:51:12  <bitcoin-git> [bitcoin] Sjors opened pull request #20614: util: RunCommandParseJSON followups (master...2020/12/build-aux) https://github.com/bitcoin/bitcoin/pull/20614
3472020-12-10T13:51:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3482020-12-10T13:53:32  *** alorente <alorente!~alorente@s91904426.blix.com> has quit IRC (Remote host closed the connection)
3492020-12-10T13:55:44  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.29.209> has joined #bitcoin-core-dev
3502020-12-10T14:02:17  *** v4hn <v4hn!~v4hn@178.162.212.214> has joined #bitcoin-core-dev
3512020-12-10T14:07:24  *** roconnor <roconnor!~roconnor@host-45-58-200-239.dyn.295.ca> has joined #bitcoin-core-dev
3522020-12-10T14:07:48  <promag> hebasto: does the branch work for you?
3532020-12-10T14:09:10  <hebasto> promag: `make -C depends qt HOST=x86_64-apple-darwin18` ends with `Caching qt...` that means ok. Have you a problem with it?
3542020-12-10T14:10:47  <promag> did it build qt quick controls?
3552020-12-10T14:11:38  *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
3562020-12-10T14:12:11  *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
3572020-12-10T14:13:00  <hebasto> checking...
3582020-12-10T14:13:49  <queip> the "score" field in getnetworkinfo, what does it actually mean? we are confused about it trying to provide support to user in #bitcoin .  Could RPC help xxx command include short explanation for the outputed JSON fields for most commands?
3592020-12-10T14:14:58  <promag> hebasto: do you have qml/QtQuick/Controls.2 dir in the build dir?
3602020-12-10T14:16:09  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
3612020-12-10T14:18:21  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
3622020-12-10T14:19:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3632020-12-10T14:19:32  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20615: cirrus: Schedule one task with paid credits for faster CI feedback (master...2012-ciFasterFeedback) https://github.com/bitcoin/bitcoin/pull/20615
3642020-12-10T14:19:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3652020-12-10T14:23:15  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 265 seconds)
3662020-12-10T14:26:46  <hebasto> promag: sorry (took my wrong branch), missed staging commands, updating...
3672020-12-10T14:33:05  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
3682020-12-10T14:33:07  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Read error: Connection reset by peer)
3692020-12-10T14:33:25  <hebasto> promag: please check updated branch
3702020-12-10T14:33:30  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
3712020-12-10T14:33:35  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
3722020-12-10T14:36:29  <hebasto> promag: I think `libqtquick2plugin.a` is that what we want, right?
3732020-12-10T14:38:47  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
3742020-12-10T14:39:22  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
3752020-12-10T14:40:40  <hebasto> also built `libQt5Quick.a` `libQt5Qml.a`
3762020-12-10T14:43:37  <promag> I think its missing qt quick controls lib
3772020-12-10T14:45:13  <promag> hebasto: the thing is we must run qmake on qtquickcontrols after qtquick install
3782020-12-10T14:46:41  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
3792020-12-10T14:50:26  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
3802020-12-10T14:50:56  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 240 seconds)
3812020-12-10T14:53:06  <hebasto> hmm, why `make -C depends HOST=x86_64-apple-darwin18` (in my branch) ends without any problem with all required static libraries built?
3822020-12-10T14:53:42  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 265 seconds)
3832020-12-10T14:54:37  *** molz_ <molz_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
3842020-12-10T14:54:44  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Ping timeout: 256 seconds)
3852020-12-10T14:57:58  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 256 seconds)
3862020-12-10T14:59:46  *** Pavlenex <Pavlenex!~Thunderbi@185.244.212.67> has joined #bitcoin-core-dev
3872020-12-10T14:59:53  <promag> hebasto: not sure, but the suspect is "../qtbase/bin/qmake qtquickcontrols2.pro -o Makefile"
3882020-12-10T15:00:19  <promag> that qmake doesn't find qtquick
3892020-12-10T15:02:07  <sdaftuar> vasild: i am trying to restart the appveyor test in #19763, but i think maybe someone cancelled the build? i'm a bit confused
3902020-12-10T15:02:09  <gribble> https://github.com/bitcoin/bitcoin/issues/19763 | net: dont try to relay to the address originator by vasild · Pull Request #19763 · bitcoin/bitcoin · GitHub
3912020-12-10T15:03:04  <vasild> I did not cancel it, maybe it got confused somehow by my push of a previous commit?
3922020-12-10T15:03:14  <hebasto> promag: for  which platform are you trying to build depends?
3932020-12-10T15:03:26  <sdaftuar> i will try again
3942020-12-10T15:03:52  <promag> hebasto: for my host, macos
3952020-12-10T15:04:19  <hebasto> which macos version?
3962020-12-10T15:08:28  *** peterrizzo_ <peterrizzo_!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
3972020-12-10T15:09:19  <sdaftuar> vasild: ok i'm out of my depth on trying to get the appveyor or cirrus-ci builds to re-run
3982020-12-10T15:12:22  <vasild> sdaftuar: if nothing else works, I can always make some minor whitespace change and re-push, but lets wait for all to complete first and see if somebody will have a better idea
3992020-12-10T15:13:15  <sdaftuar> yeah, sounds good
4002020-12-10T15:15:50  *** davterra <davterra!~davterra@static-198-54-131-156.cust.tzulo.com> has quit IRC (Quit: Leaving)
4012020-12-10T15:22:24  *** peterrizzo_ <peterrizzo_!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo_)
4022020-12-10T15:31:55  <promag> hebasto: Some of the required modules (qtHaveModule(quick)) are not available. \n Skipped.
4032020-12-10T15:35:15  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
4042020-12-10T15:35:16  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
4052020-12-10T15:35:34  <hebasto> promag: thanks! I see this message on Big Sur.
4062020-12-10T15:36:04  <promag> not on linux?
4072020-12-10T15:39:26  <hebasto> on linux too ((
4082020-12-10T15:41:25  <promag> ok good, at least we are on the same page :D
4092020-12-10T15:41:51  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Remote host closed the connection)
4102020-12-10T15:42:07  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
4112020-12-10T15:45:17  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
4122020-12-10T15:46:10  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.29.209> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
4132020-12-10T15:48:00  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 256 seconds)
4142020-12-10T15:48:06  *** miketwen_ <miketwen_!~miketwent@ec2-34-202-224-110.compute-1.amazonaws.com> has joined #bitcoin-core-dev
4152020-12-10T15:50:32  <promag> fanquake: cfields: do you see problems using qt single archive instead of separate modules?
4162020-12-10T15:50:55  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 246 seconds)
4172020-12-10T15:51:14  <promag> download a bigger archive VS more complicated build script
4182020-12-10T16:06:03  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC ()
4192020-12-10T16:12:14  <ariard> sdaftuar: jonatack and I just re-ack #19858 but please ping again if there is a new rebase to deal with it, this PR has been in limbo for too long :)
4202020-12-10T16:12:18  <gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
4212020-12-10T16:13:29  <sdaftuar> ariard: thank you!
4222020-12-10T16:15:03  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Ping timeout: 260 seconds)
4232020-12-10T16:25:36  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
4242020-12-10T16:25:48  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
4252020-12-10T16:29:06  *** Pavlenex <Pavlenex!~Thunderbi@185.244.212.67> has quit IRC (Quit: Pavlenex)
4262020-12-10T16:34:10  *** Pavlenex <Pavlenex!~Thunderbi@185.244.212.67> has joined #bitcoin-core-dev
4272020-12-10T16:34:45  *** kexkey <kexkey!~kexkey@static-198-54-132-141.cust.tzulo.com> has joined #bitcoin-core-dev
4282020-12-10T16:36:41  <jonatack> I don't recall being able to restart appveyor, it always seemed more like a "game over, re-push to replay" thing. The cirrus builds can be restarted...ISTM they restart on their own after a while (unsure)
4292020-12-10T16:39:58  *** Pavlenex <Pavlenex!~Thunderbi@185.244.212.67> has quit IRC (Quit: Pavlenex)
4302020-12-10T16:42:23  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
4312020-12-10T16:43:43  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
4322020-12-10T16:46:02  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
4332020-12-10T17:04:49  *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:1401:d5c:a187:3181> has quit IRC (Remote host closed the connection)
4342020-12-10T17:08:35  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Remote host closed the connection)
4352020-12-10T17:13:45  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
4362020-12-10T17:33:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4372020-12-10T17:33:44  <bitcoin-git> [bitcoin] lontivero opened pull request #20616: Check CJDNS address is valid (master...validate-cjdns-addresses) https://github.com/bitcoin/bitcoin/pull/20616
4382020-12-10T17:33:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4392020-12-10T17:34:03  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
4402020-12-10T17:35:10  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
4412020-12-10T17:41:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4422020-12-10T17:41:17  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b76abae387b9...da957cd62ecc
4432020-12-10T17:41:17  <bitcoin-git> bitcoin/master fa918dd MarcoFalke: test: Use Popen.wait instead of RPC in assert_start_raises_init_error
4442020-12-10T17:41:18  <bitcoin-git> bitcoin/master da957cd MarcoFalke: Merge #20613: test: Use Popen.wait instead of RPC in assert_start_raises_i...
4452020-12-10T17:41:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4462020-12-10T17:41:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4472020-12-10T17:41:32  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20613: test: Use Popen.wait instead of RPC in assert_start_raises_init_error (master...2012-testFastFailInitError) https://github.com/bitcoin/bitcoin/pull/20613
4482020-12-10T17:41:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4492020-12-10T17:42:48  *** pergaminho <pergaminho!~Cleber@189.26.121.248> has quit IRC (Quit: Saindo)
4502020-12-10T17:46:30  *** proofofkeags <proofofkeags!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has joined #bitcoin-core-dev
4512020-12-10T17:46:36  *** kvaciral <kvaciral!~kvaciral@212.8.251.11> has joined #bitcoin-core-dev
4522020-12-10T17:58:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4532020-12-10T17:58:10  <bitcoin-git> [bitcoin] ariard opened pull request #20617: p2p: Remove m_is_manual_connection from CNodeState (master...2020-12-remove-is-manual-connection) https://github.com/bitcoin/bitcoin/pull/20617
4542020-12-10T17:58:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4552020-12-10T18:19:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4562020-12-10T18:19:21  <bitcoin-git> [bitcoin] laanwj pushed 12 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/aa4b8ebfecdd...3fee499bc3af
4572020-12-10T18:19:22  <bitcoin-git> bitcoin/0.21 9e80688 Pieter Wuille: Don't send 'sendaddrv2' to pre-70016 software
4582020-12-10T18:19:23  <bitcoin-git> bitcoin/0.21 bead935 Pieter Wuille: Send and require SENDADDRV2 before VERACK
4592020-12-10T18:19:24  <bitcoin-git> bitcoin/0.21 06c8423 Jon Atack: wallet, bugfix: allow send to take string fee rate values
4602020-12-10T18:19:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4612020-12-10T18:19:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4622020-12-10T18:19:44  <bitcoin-git> [bitcoin] laanwj merged pull request #20612: [0.21] final rc3 backports (0.21...2012-finalRc3Backports) https://github.com/bitcoin/bitcoin/pull/20612
4632020-12-10T18:19:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4642020-12-10T18:21:05  <MarcoFalke> \o/
4652020-12-10T18:21:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4662020-12-10T18:21:29  <bitcoin-git> [bitcoin] hebasto closed pull request #19882: depends: Export variables from make to environment explicitly (master...200905-build) https://github.com/bitcoin/bitcoin/pull/19882
4672020-12-10T18:21:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4682020-12-10T18:21:44  *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
4692020-12-10T18:22:04  <sipa> are they (final rc3) backports, or final (rc3) backports?
4702020-12-10T18:22:25  *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
4712020-12-10T18:22:59  <MarcoFalke> hopefully both
4722020-12-10T18:23:24  *** Guyver2_ is now known as Guyver2
4732020-12-10T18:26:12  <luke-jr> XD
4742020-12-10T18:33:55  <wumpus> i deleted the en_GB translation on transifex; it contained all kinds of junk, e.g. a pasted shell transcript, some French messages, and so on. Besides that it seems kind of pointless in the first place.
4752020-12-10T18:35:14  <wumpus> sipa: final for rc3 at least, i plan to tag rc3 soon after
4762020-12-10T18:45:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4772020-12-10T18:45:12  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/3fee499bc3af...e6d0fa3ef6f6
4782020-12-10T18:45:12  <bitcoin-git> bitcoin/0.21 e6d0fa3 Wladimir J. van der Laan: gui: pre-rc3 translations update
4792020-12-10T18:45:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4802020-12-10T18:46:06  <wumpus> no manual page changes and no English translation changes this time
4812020-12-10T18:46:23  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
4822020-12-10T18:56:56  *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-eaaqhhyeagrjdhwm> has joined #bitcoin-core-dev
4832020-12-10T19:01:00  <hebasto> meeting?
4842020-12-10T19:01:24  <luke-jr> ..
4852020-12-10T19:02:02  <wumpus> #startmeeting
4862020-12-10T19:02:15  <jnewbery> hi
4872020-12-10T19:02:19  <achow101> hi
4882020-12-10T19:02:21  <hebasto> hi
4892020-12-10T19:02:21  <kanzure> hi
4902020-12-10T19:02:26  <wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
4912020-12-10T19:02:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4922020-12-10T19:02:27  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/e6d0fa3ef6f6...9ae536d3684e
4932020-12-10T19:02:27  <bitcoin-git> bitcoin/0.21 9ae536d Wladimir J. van der Laan: build: Bump RC to rc3
4942020-12-10T19:02:28  <wumpus> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus
4952020-12-10T19:02:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4962020-12-10T19:02:45  <promag> hi
4972020-12-10T19:02:48  <wumpus> no proposed topics for this week on http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
4982020-12-10T19:02:49  <jb55> hi
4992020-12-10T19:02:59  <wumpus> does anyone have last minute things they'd like to discuss?
5002020-12-10T19:03:15  <Murch> hi
5012020-12-10T19:03:38  <michaelfolkson> hi
5022020-12-10T19:03:43  <jonasschnelli> hi
5032020-12-10T19:03:43  <Murch> I'm sure achow101 would love if someone besides be would take a glance at #20040
5042020-12-10T19:03:46  <gribble> https://github.com/bitcoin/bitcoin/issues/20040 | wallet: Refactor OutputGroups to handle fees and spending eligibility on grouping by achow101 · Pull Request #20040 · bitcoin/bitcoin · GitHub
5052020-12-10T19:04:03  <Murch> *besides me
5062020-12-10T19:04:07  <jonatack> hi
5072020-12-10T19:04:12  <wumpus> is already in the high prioroty for review
5082020-12-10T19:04:14  *** jarolrod <jarolrod!uid475272@gateway/web/irccloud.com/x-oeyqoxzpfotwpgrr> has joined #bitcoin-core-dev
5092020-12-10T19:04:24  <wumpus> #topic High priority for review
5102020-12-10T19:04:56  <jonatack> Murch: +1
5112020-12-10T19:04:57  <wumpus> https://github.com/bitcoin/bitcoin/projects/8
5122020-12-10T19:05:12  <wumpus> anything to add/remove or that is ready for merge?
5132020-12-10T19:05:31  <MarcoFalke> anything holding back a 0.19 and 0.20 release?
5142020-12-10T19:05:38  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
5152020-12-10T19:05:42  <wumpus> FWIW I added #19858
5162020-12-10T19:05:47  <gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
5172020-12-10T19:06:03  <achow101> MarcoFalke: still waiting for #19740 for 0.20
5182020-12-10T19:06:05  <gribble> https://github.com/bitcoin/bitcoin/issues/19740 | [0.20] wallet: Simplify and fix CWallet::SignTransaction by achow101 · Pull Request #19740 · bitcoin/bitcoin · GitHub
5192020-12-10T19:06:22  <sdaftuar> wumpus: thanks!
5202020-12-10T19:06:53  <jonatack> maybe #20546 for me
5212020-12-10T19:06:56  <gribble> https://github.com/bitcoin/bitcoin/issues/20546 | policy, wallet, refactor: check for non-representable CFeeRates by jonatack · Pull Request #20546 · bitcoin/bitcoin · GitHub
5222020-12-10T19:07:12  <MarcoFalke> achow101: merged
5232020-12-10T19:07:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5242020-12-10T19:07:14  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/75bf23d8613a...953dddbd2058
5252020-12-10T19:07:14  <bitcoin-git> bitcoin/0.20 2d48d7d Andrew Chow: Simplify and fix CWallet::SignTransaction
5262020-12-10T19:07:15  <bitcoin-git> bitcoin/0.20 6a326cf Andrew Chow: tests: Test that a fully signed tx given to signrawtx is unchanged
5272020-12-10T19:07:16  <bitcoin-git> bitcoin/0.20 953dddb MarcoFalke: Merge #19740: [0.20] wallet: Simplify and fix CWallet::SignTransaction
5282020-12-10T19:07:17  <MarcoFalke> thanks for the test btw
5292020-12-10T19:07:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5302020-12-10T19:07:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5312020-12-10T19:07:32  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19740: [0.20] wallet: Simplify and fix CWallet::SignTransaction (0.20...backport-17204-fix) https://github.com/bitcoin/bitcoin/pull/19740
5322020-12-10T19:07:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5332020-12-10T19:07:43  <wumpus> jonatack: added
5342020-12-10T19:07:59  <jonatack> wumpus: merci
5352020-12-10T19:08:55  <wumpus> no idea about 0.19 and 0.20, but I'll tag 0.21.0rc3 after the meeting
5362020-12-10T19:10:26  <wumpus> if the other branches are ready for tagging just say so
5372020-12-10T19:12:04  <wumpus> okay, any other topics?
5382020-12-10T19:12:17  <wumpus> seems to be a short meeting
5392020-12-10T19:12:39  <sipa> 21 million decananoversions!
5402020-12-10T19:13:08  <wumpus> hehe, a new version unit
5412020-12-10T19:13:32  <sipa> 21M versionsats?
5422020-12-10T19:13:56  <wumpus> better than versionbits *ducks*
5432020-12-10T19:14:06  <sipa> hahaha
5442020-12-10T19:14:10  <wumpus> #endmeeting
5452020-12-10T19:14:10  <luke-jr> wut
5462020-12-10T19:14:32  <jonatack> :D
5472020-12-10T19:14:49  * Murch watches joke pass over his head
5482020-12-10T19:14:51  <MarcoFalke> wumpus: yes, I think 0.19 and 0.20 are ready for tag as well
5492020-12-10T19:15:04  <aj> 100 versionsats per versionbit then?
5502020-12-10T19:15:08  <wumpus> seems the bot wandered off again
5512020-12-10T19:15:30  <jonasschnelli> My fault...
5522020-12-10T19:15:56  <wumpus> Murch: yes a bit of a inside joke there was some discussion about bitcoin units again on twitter
5532020-12-10T19:16:45  <jonatack> we start using sats, suddenly there's a push for bits
5542020-12-10T19:16:58  *** core-meetingbot <core-meetingbot!~meetingbo@2a01:4f9:2a:2510::2> has joined #bitcoin-core-dev
5552020-12-10T19:16:59  <Murch> Must have missed it ^^
5562020-12-10T19:17:12  <jonasschnelli> ping core-meetingbot
5572020-12-10T19:18:30  <luke-jr> jonatack: not for feerate I think?
5582020-12-10T19:19:26  <sipa> i missed that push too; i just found it funny due to name confusion with BIP9's versionbits
5592020-12-10T19:19:42  <jonatack> luke-jr: i don't think so? Murch: easy to miss, bits means a few other things already
5602020-12-10T19:19:44  <wumpus> MarcoFalke: ok!
5612020-12-10T19:19:59  <Murch> luke-jr: Can't wait for bits per kilovirtualbyte :~
5622020-12-10T19:20:10  <Murch> or bits per kilosipa
5632020-12-10T19:20:12  <Murch> haha
5642020-12-10T19:20:33  <Murch> jonatack: That's my biggest gripe with it
5652020-12-10T19:23:47  <jonasschnelli> ping core-meetingbot
5662020-12-10T19:24:50  <sipa> bad bot
5672020-12-10T19:25:24  <jonasschnelli> wait wait
5682020-12-10T19:25:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5692020-12-10T19:25:39  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/5baaea4410a1...5f2f304cbec9
5702020-12-10T19:25:39  <bitcoin-git> bitcoin/0.19 5f2f304 Wladimir J. van der Laan: build: Bump version to 0.19.2rc1
5712020-12-10T19:25:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5722020-12-10T19:25:47  <jonasschnelli> now
5732020-12-10T19:25:49  <jonasschnelli> ping core-meetingbot
5742020-12-10T19:25:57  * jonasschnelli hmm...
5752020-12-10T19:26:15  <jonasschnelli> #startmeeting
5762020-12-10T19:26:15  <core-meetingbot> Meeting started Thu Dec 10 19:26:15 2020 UTC.  The chair is jonasschnelli. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
5772020-12-10T19:26:15  <core-meetingbot> Available commands: action commands idea info link nick
5782020-12-10T19:26:18  <jonasschnelli> #endmeeting
5792020-12-10T19:26:19  <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
5802020-12-10T19:26:19  <core-meetingbot> Meeting ended Thu Dec 10 19:26:18 2020 UTC.
5812020-12-10T19:26:19  <core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-12-10-19.26.moin.txt
5822020-12-10T19:26:24  * jonasschnelli fixed...
5832020-12-10T19:26:27  <promag> achow101: regarding https://bitcoin.stackexchange.com/questions/54230/any-plans-for-bitcoin-core-app-to-integrate-hardware-wallet-support#comment95782_54618  how would bitcoin core support hww in android for instance?
5842020-12-10T19:27:13  <achow101> promag: no idea
5852020-12-10T19:27:15  <jonasschnelli> sorry... the bots server had to restart recently and did not automatically identify via NickServ. That's why it was muted.
5862020-12-10T19:27:26  <wumpus> jonasschnelli: thanks!
5872020-12-10T19:27:41  <jonasschnelli> The todays meeting was though recorded: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-12-04-19.01.moin.txt
5882020-12-10T19:27:45  <jonasschnelli> (the bot was just muted)
5892020-12-10T19:27:48  <wumpus> jonasschnelli: oh good!
5902020-12-10T19:27:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5912020-12-10T19:27:54  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.20: https://github.com/bitcoin/bitcoin/compare/953dddbd2058...2808593b7c8c
5922020-12-10T19:27:54  <bitcoin-git> bitcoin/0.20 2808593 Wladimir J. van der Laan: build: Bump version to 0.20.2rc1
5932020-12-10T19:27:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5942020-12-10T19:28:16  <jonasschnelli> ahm... wait. No. It wasn't
5952020-12-10T19:28:25  <jonasschnelli> That was last weeks.
5962020-12-10T19:28:57  <jonasschnelli> shouldn't happen again
5972020-12-10T19:29:16  <wumpus> promag: depends on how the wallet connects to the host I suppose? host USB is supported on some android devices (since 3.1, I see)
5982020-12-10T19:29:43  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Ping timeout: 240 seconds)
5992020-12-10T19:30:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6002020-12-10T19:30:57  <bitcoin-git> [bitcoin] laanwj pushed tag v0.21.0rc3: https://github.com/bitcoin/bitcoin/compare/v0.21.0rc3
6012020-12-10T19:30:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6022020-12-10T19:31:10  <wumpus> ^^
6032020-12-10T19:32:04  <achow101> yay 3 things to build
6042020-12-10T19:32:29  <wumpus> triple-combo tag (but for 0.20 and 0.19 I still have to do manual page updates and translations)
6052020-12-10T19:32:50  <wumpus> that was a no-op for 0.21 this rc
6062020-12-10T19:33:17  <wumpus> well the translations wasn't
6072020-12-10T19:36:26  *** core-meetingbot <core-meetingbot!~meetingbo@2a01:4f9:2a:2510::2> has quit IRC (Quit: 2019.02.23)
6082020-12-10T19:36:47  *** core-meetingbot <core-meetingbot!~meetingbo@2a01:4f9:2a:2510::2> has joined #bitcoin-core-dev
6092020-12-10T19:37:00  <sipa> i've been out of the loop for gitian building for a few years, but have a good setup now
6102020-12-10T19:37:12  <sipa> where do i start? i'm on ubuntu
6112020-12-10T19:37:47  <jonasschnelli> sipa: https://github.com/bitcoin-core/docs/blob/master/gitian-building/gitian-building-setup-gitian-debian.md
6122020-12-10T19:38:24  <jonasschnelli> then probably: ./gitian-build.py --setup (see https://github.com/bitcoin-core/docs/blob/master/gitian-building.md)
6132020-12-10T19:39:07  <luke-jr> :o
6142020-12-10T19:40:03  <sipa> so i'd create a debian VM, and run gitian inside that (with LXC?)
6152020-12-10T19:41:08  <wumpus> that's what i have
6162020-12-10T19:41:43  <sipa> ok
6172020-12-10T19:42:10  <jonatack> https://github.com/jonatack/bitcoin-development/blob/master/gitian-building.md
6182020-12-10T19:42:14  <jonasschnelli> sipa: I run LXC directly on a physical debian host
6192020-12-10T19:42:24  <jonasschnelli> (I guess you can do the same with ubuntu?)
6202020-12-10T19:42:40  <wumpus> if you already run debian you could skip the outer VM, but, I generally don't want to pollute the physical host with all kind of stuff
6212020-12-10T19:43:03  <jonasschnelli> Yes. Agree that this makes sense.
6222020-12-10T19:43:41  <sipa> i assume you can do the gpg signing outside the VM?
6232020-12-10T19:43:45  <wumpus>  (though LXC isn't that bad)
6242020-12-10T19:43:49  <wumpus> yes
6252020-12-10T19:44:57  <jonasschnelli> sipa: yes. I also GPG sign "outside"
6262020-12-10T19:45:13  <jonasschnelli> (on a different computer)
6272020-12-10T19:45:16  <wumpus> I have my own script to fetch the assert files from the VM and sign them with (w  gpg2 --detach-sign), don't know if there's a standard way to do it nowadays
6282020-12-10T19:45:43  <sipa> how much disk space would you need for the VM?
6292020-12-10T19:45:57  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
6302020-12-10T19:46:23  <jonasschnelli> 15G Aug 11 08:51 base-bionic-amd64
6312020-12-10T19:46:34  <jonasschnelli> + some small stuff
6322020-12-10T19:46:42  <sipa> cool
6332020-12-10T19:46:57  <wumpus> it needs to write the output somewhere too but yes
6342020-12-10T19:47:36  <jonasschnelli> You'll also need the macOS SDK (grab it from bitcoincore.org, check the travis files for the URL)
6352020-12-10T19:47:47  <wumpus> I assigned 40GB to it
6362020-12-10T19:48:28  <hebasto> sipa: https://bitcoincore.org/depends-sources/sdks/Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers.tar.gz
6372020-12-10T19:48:51  <wumpus> it's preferable to extract the SDK using the instructions from an actual Apple download, especially if you have a mac yourself, but yeah most people simply grab it
6382020-12-10T19:49:51  <sipa> i don't have any apple hardware
6392020-12-10T19:49:59  <sipa> but you can do the extraction from linux, right?
6402020-12-10T19:50:12  <jonasschnelli> I think you can
6412020-12-10T19:50:37  <jonasschnelli> https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/README.md#sdk-extraction
6422020-12-10T19:50:50  <jonasschnelli> you need an Apple ID though. :)
6432020-12-10T19:51:22  <luke-jr> sipa: you may want more than 15 GB for caches
6442020-12-10T19:51:27  <luke-jr> unless you wipe them
6452020-12-10T19:52:03  <sipa> ok, gave it 50 G
6462020-12-10T19:52:09  <luke-jr> I have 16 GB of caches alone XD
6472020-12-10T19:52:47  <wumpus> definitely if you keep the caches for old branches around
6482020-12-10T19:53:08  <luke-jr> hebasto: it's not technically legal for us to distribute that btw
6492020-12-10T19:53:50  <wumpus> FWIW I usually delete the caches for every major/minor release, building the depends takes somewhat longer but it's rare enough, and there are some other steps that take a long time too
6502020-12-10T19:54:39  <wumpus> and it wouldn't be the first time that solves a determinism issue
6512020-12-10T19:54:45  *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has quit IRC (Ping timeout: 240 seconds)
6522020-12-10T19:56:29  <jonasschnelli> bb8c59034420709cdbae2e47ec1a1dce03c68ab4142ff3b67a23c415e6557be1  bitcoin-0.21.0rc3-osx-unsigned.dmg
6532020-12-10T19:56:32  <wumpus> it's especially for the linux build that caching really helps, qt for all those platforms
6542020-12-10T19:57:23  <luke-jr> jonasschnelli: wow fast
6552020-12-10T19:58:02  <jonasschnelli> luke-jr: macOS builds are fast (my script does that first): https://bitcoin.jonasschnelli.ch/gitian/build/358
6562020-12-10T20:00:00  <luke-jr> i c
6572020-12-10T20:00:11  <luke-jr> I think mine does Windows, Linux, macOS
6582020-12-10T20:00:28  * luke-jr wonders if we ought to s/osx/macos/
6592020-12-10T20:00:38  <luke-jr> or even just mac
6602020-12-10T20:00:54  <sipa> especially with the latest release being XI and not X anymore
6612020-12-10T20:00:55  <jonasschnelli> luke-jr: I looked into it. But I guess it's not really worth it.
6622020-12-10T20:01:13  <jonasschnelli> sipa: its 10.16 and 11 (internally!)
6632020-12-10T20:01:23  <sipa> jonasschnelli: i know
6642020-12-10T20:01:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6652020-12-10T20:01:41  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/2808593b7c8c...a4bc4c1f79d7
6662020-12-10T20:01:41  <bitcoin-git> bitcoin/0.20 98c9d79 Wladimir J. van der Laan: gui: Pre-rc1 translations update
6672020-12-10T20:01:42  <bitcoin-git> bitcoin/0.20 a4bc4c1 Wladimir J. van der Laan: doc: Update manual pages pre-rc1
6682020-12-10T20:01:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6692020-12-10T20:03:07  <wumpus> luke-jr: renaming files is kind of annoying, as the file names are hardcoded in all kinds of places and scripts, also not sure it's worth it for something that doesn't generate any ambiguity
6702020-12-10T20:06:39  <sipa> jonasschnelli: i created an apple id, but it says i'm not allowed to download the xcode files
6712020-12-10T20:07:15  *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
6722020-12-10T20:07:17  <jonasschnelli> sipa: have you used the link from the docs?
6732020-12-10T20:07:23  <jonasschnelli> I guess that one is old/invalid
6742020-12-10T20:07:41  <jonasschnelli> Maybe go here: https://developer.apple.com/download/more/
6752020-12-10T20:07:53  <jonasschnelli> (maybe directly here: https://download.developer.apple.com/Developer_Tools/Xcode_12.2/Xcode_12.2.xip)
6762020-12-10T20:08:04  <sipa> is it ok to use a later version?
6772020-12-10T20:08:05  <jonasschnelli> oh.. wait. you need to older version
6782020-12-10T20:08:34  <jonasschnelli> maybe that one: https://download.developer.apple.com/Developer_Tools/Xcode_11.3.1/Xcode_11.3.1.xip?
6792020-12-10T20:08:55  <jonasschnelli> (download works for me)
6802020-12-10T20:10:01  <sipa> i need to sign up for the developer program
6812020-12-10T20:10:06  <sipa> which is $99 a year
6822020-12-10T20:10:08  <sipa> ??
6832020-12-10T20:10:55  <achow101> sipa: it shouldn't be required, but I don't remember which links to go to
6842020-12-10T20:11:06  <jonasschnelli> No. You don't need that
6852020-12-10T20:11:18  <jonasschnelli> You only need the 99$ programm if you want to deploy apps
6862020-12-10T20:11:57  <jonasschnelli> sipa: just click harder,... you'll find it
6872020-12-10T20:12:28  <sipa> Sorry, you cannot view this page.
6882020-12-10T20:12:33  <sipa> he Apple ID you signed in with does not have permission to view this page.
6892020-12-10T20:12:38  <sipa> If you’re currently a member of the Apple Developer Program, you or your Account Holder may need to update your account by agreeing to the latest license agreement in order to access this page. To view your current membership status and benefits, visit your account.
6902020-12-10T20:13:29  <jonasschnelli> sipa: let me try to create a new account..
6912020-12-10T20:13:38  <jonasschnelli> Have you verified your email and all that stuff?
6922020-12-10T20:13:50  <sipa> https://developer.apple.com/services-account/download?path=/Developer_Tools/Xcode_11.3.1/Xcode_11.3.1.xip
6932020-12-10T20:13:53  <sipa> that works!
6942020-12-10T20:15:03  *** kexkey_ <kexkey_!~kexkey@static-198-54-132-93.cust.tzulo.com> has joined #bitcoin-core-dev
6952020-12-10T20:16:52  <jonasschnelli> sipa: Yes. Should work. I just created a new account.
6962020-12-10T20:16:53  <jonasschnelli> works
6972020-12-10T20:17:00  <jonasschnelli> You may need to agree to some terms etc.
6982020-12-10T20:17:36  *** kexkey <kexkey!~kexkey@static-198-54-132-141.cust.tzulo.com> has quit IRC (Ping timeout: 240 seconds)
6992020-12-10T20:17:54  <wumpus> let's update the URL in the doc
7002020-12-10T20:18:23  <sipa> jonasschnelli: it's downloading, and i didn't do anything else :)
7012020-12-10T20:19:15  <luke-jr> yeah.. I had to jump through some hoops to find it too
7022020-12-10T20:20:19  <jonasschnelli> I guess that doc is outdated? https://github.com/bitcoin-core/docs/blob/master/gitian-building/gitian-building-mac-os-sdk.md
7032020-12-10T20:21:19  <jonasschnelli> The link should still be valid: https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/README.md#sdk-extraction
7042020-12-10T20:21:35  <jonasschnelli> I guess you'll get a 403 if you are not logged in our haven't accepted the terms, etc.
7052020-12-10T20:21:49  <achow101> I think you need to already be logged in for the link to work
7062020-12-10T20:21:55  <sipa> jonasschnelli: yeah the link there works
7072020-12-10T20:22:00  <sipa> the previous one you gave didn't
7082020-12-10T20:22:08  <jonasschnelli> its the same. :)
7092020-12-10T20:22:10  <jonatack> "if it doesn't work, just click harder" :D ...that should go in the doc
7102020-12-10T20:22:12  <jonasschnelli> I just dbl-checked
7112020-12-10T20:22:27  <sipa> no it isn't
7122020-12-10T20:22:29  <jonasschnelli> jonasschnelli: hah
7132020-12-10T20:22:36  <sipa> https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/README.md#sdk-extraction has the wrong URL
7142020-12-10T20:22:42  <sipa> https://github.com/bitcoin-core/docs/blob/master/gitian-building/gitian-building-mac-os-sdk.md has the right one
7152020-12-10T20:22:51  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
7162020-12-10T20:23:05  <sipa> they're literally not the same URL
7172020-12-10T20:23:16  <achow101> sipa: the one in contrib/macdeploy works for me if I'm already logged in
7182020-12-10T20:23:23  <sipa> i'm logged in
7192020-12-10T20:23:33  <achow101> it's also the link that you get from the website and search for the sdk manually
7202020-12-10T20:24:01  <sipa> wait
7212020-12-10T20:24:04  <sipa> now the other one works too
7222020-12-10T20:24:08  <sipa> ok, i give up!
7232020-12-10T20:24:08  <jonasschnelli> sipa: the one you wrote last (gitian-building-mac-os-sdk.md) is outdated IMO
7242020-12-10T20:24:15  <jonasschnelli> As I said. Click harder. :)
7252020-12-10T20:24:26  <jonasschnelli> jonatack: heh.. :)
7262020-12-10T20:24:33  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
7272020-12-10T20:24:42  <sipa> my conspiracy theory is that the first URL starts working as soon as you try the second one
7282020-12-10T20:24:49  *** gleb <gleb!~gleb@178.150.137.228> has joined #bitcoin-core-dev
7292020-12-10T20:25:28  <achow101> it's never easy with apple stuff
7302020-12-10T20:25:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
7312020-12-10T20:25:30  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/5f2f304cbec9...e301a9fde351
7322020-12-10T20:25:30  <bitcoin-git> bitcoin/0.19 f8d2a04 Wladimir J. van der Laan: gui: Pre-rc1 translations update
7332020-12-10T20:25:31  <bitcoin-git> bitcoin/0.19 e301a9f Wladimir J. van der Laan: doc: Pre-rc1 manual pages update
7342020-12-10T20:25:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
7352020-12-10T20:26:25  <jamesob> Argh, missed the meeting again.
7362020-12-10T20:26:50  <gleb> jamesob: same here, just managed to join :)
7372020-12-10T20:26:53  <jamesob> Can I review/merge beg for #19806? This one's been hanging out for a while
7382020-12-10T20:26:59  <gribble> https://github.com/bitcoin/bitcoin/issues/19806 | validation: UTXO snapshot activation by jamesob · Pull Request #19806 · bitcoin/bitcoin · GitHub
7392020-12-10T20:27:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
7402020-12-10T20:27:19  <bitcoin-git> [bitcoin] laanwj pushed tag v0.19.2rc1: https://github.com/bitcoin/bitcoin/compare/v0.19.2rc1
7412020-12-10T20:27:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
7422020-12-10T20:27:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
7432020-12-10T20:27:50  <bitcoin-git> [bitcoin] laanwj pushed tag v0.20.2rc1: https://github.com/bitcoin/bitcoin/compare/v0.20.2rc1
7442020-12-10T20:27:51  <jamesob> gleb: timezones man, they're rough
7452020-12-10T20:27:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
7462020-12-10T20:29:31  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
7472020-12-10T20:29:47  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
7482020-12-10T20:30:59  <wumpus> now everyone can build their favorite branch
7492020-12-10T20:31:36  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
7502020-12-10T20:32:52  <achow101> I sure hope we don't have any non-determinism
7512020-12-10T20:34:47  <wumpus> if so, especially for 0.19, deciding to forego the gitian build at all would be a valid choice
7522020-12-10T20:35:48  <wumpus> the current (possibly final) state of the branch is tagged, that was kind of the point, people can build it from source if they want
7532020-12-10T20:43:05  <jonasschnelli> achow101: 0.21.0rc3 macOS sigs are up (hash matches with yours and hebasto's): https://github.com/bitcoin-core/bitcoin-detached-sigs/tree/0.21
7542020-12-10T20:50:30  *** zakkdev <zakkdev!~textual@89.107.6.72> has joined #bitcoin-core-dev
7552020-12-10T20:52:35  <achow101> waiting for one more windows sig
7562020-12-10T20:53:21  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
7572020-12-10T20:53:32  <jonasschnelli> achow101: https://bitcoin.jonasschnelli.ch/gitian/build/358
7582020-12-10T20:53:41  <jonasschnelli> (commit soon as linux is done)
7592020-12-10T20:53:58  <jonasschnelli> e72a9059a206a822fc02d7d304992a23acb9355fbf7b3b94353839075532bd5f  bitcoin-0.21.0rc3-win-unsigned.tar.gz
7602020-12-10T21:00:43  *** proofofkeags_ <proofofkeags_!~proofofke@2601:280:c280:e500:105f:32aa:c59e:2130> has joined #bitcoin-core-dev
7612020-12-10T21:03:05  *** proofofkeags <proofofkeags!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has quit IRC (Ping timeout: 240 seconds)
7622020-12-10T21:10:57  <achow101> gitian builders: 0.21.0rc3 sigs are up
7632020-12-10T21:18:16  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
7642020-12-10T21:18:21  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo)
7652020-12-10T21:18:30  <luke-jr> achow101: why? those sigs aren't supposed to be created until 3 gitian builds match
7662020-12-10T21:18:43  <luke-jr> right now there's ZERO in the repo..
7672020-12-10T21:18:46  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
7682020-12-10T21:20:08  <luke-jr> where are you guys seeing sigs? :/
7692020-12-10T21:20:25  <hebasto> luke-jr: https://github.com/bitcoin-core/bitcoin-detached-sigs/tree/0.21
7702020-12-10T21:20:37  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 264 seconds)
7712020-12-10T21:20:54  <luke-jr> hebasto: right, those aren't supposed to exist until there are 3 matching gitian sigs
7722020-12-10T21:21:08  <luke-jr> but the gitian.sigs repo is empty afaict
7732020-12-10T21:21:17  <luke-jr> (well, empty of rc3)
7742020-12-10T21:21:40  *** chri_eb <chri_eb!~chris@gateway/tor-sasl/chrieb/x-28824719> has joined #bitcoin-core-dev
7752020-12-10T21:22:09  <hebasto> yes, repo is empty; but hashes from achow101 jonasschnelli and me are the same, right?
7762020-12-10T21:22:23  <achow101> luke-jr: prs are there
7772020-12-10T21:22:26  <luke-jr> can't verify without the PGP sigs on them
7782020-12-10T21:22:28  <luke-jr> achow101: ah
7792020-12-10T21:22:38  <hebasto> luke-jr: right
7802020-12-10T21:24:37  <luke-jr> only see achow101 and hebasto?
7812020-12-10T21:25:56  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo)
7822020-12-10T21:26:12  <achow101> luke-jr: jonasschnelli results are at https://bitcoin.jonasschnelli.ch/gitian/build/358
7832020-12-10T21:26:12  *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-eaaqhhyeagrjdhwm> has quit IRC (Quit: Connection closed for inactivity)
7842020-12-10T21:26:23  *** peterrizzo_ <peterrizzo_!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
7852020-12-10T21:27:12  <luke-jr> not signed
7862020-12-10T21:27:27  <luke-jr> oh,. they are
7872020-12-10T21:27:45  <luke-jr> gotta scroll down
7882020-12-10T21:28:47  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
7892020-12-10T21:43:43  <wumpus> pushed sigs too
7902020-12-10T21:44:18  <sipa> building!
7912020-12-10T21:45:21  <luke-jr> mine is on riscv, so almost done
7922020-12-10T21:45:29  <luke-jr> (turns out my order is win, osx, linux)
7932020-12-10T21:50:05  *** v4hn <v4hn!~v4hn@178.162.212.214> has quit IRC (Remote host closed the connection)
7942020-12-10T21:58:02  *** JackSparrow <JackSparrow!~JackSparr@s91904426.blix.com> has joined #bitcoin-core-dev
7952020-12-10T22:01:51  <theStack> fwiw, the contrib/gitian-build.py script with docker worked like a charm for me, no need for a vm
7962020-12-10T22:02:43  *** proofofkeags__ <proofofkeags__!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has joined #bitcoin-core-dev
7972020-12-10T22:05:22  *** proofofkeags_ <proofofkeags_!~proofofke@2601:280:c280:e500:105f:32aa:c59e:2130> has quit IRC (Ping timeout: 260 seconds)
7982020-12-10T22:13:59  *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:4ca5:5aef:8068:2da7> has joined #bitcoin-core-dev
7992020-12-10T22:23:47  *** zakkdev <zakkdev!~textual@89.107.6.72> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
8002020-12-10T22:24:27  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Read error: Connection reset by peer)
8012020-12-10T22:24:51  *** TheRec <TheRec!~toto@drupal.org/user/146860/view> has quit IRC ()
8022020-12-10T22:27:03  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Ping timeout: 240 seconds)
8032020-12-10T22:27:28  *** btc_thc <btc_thc!annalee@kosher.marriageiguana.com> has quit IRC (Ping timeout: 246 seconds)
8042020-12-10T22:29:21  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
8052020-12-10T22:29:39  *** btc_thc <btc_thc!annalee@kosher.marriageiguana.com> has joined #bitcoin-core-dev
8062020-12-10T22:31:12  *** proofofkeags_ <proofofkeags_!~proofofke@2601:280:c280:e500:1901:898e:ac68:17ca> has joined #bitcoin-core-dev
8072020-12-10T22:32:37  *** proofofkeags__ <proofofkeags__!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has quit IRC (Read error: Connection reset by peer)
8082020-12-10T22:33:44  *** proofofkeags__ <proofofkeags__!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has joined #bitcoin-core-dev
8092020-12-10T22:35:37  *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
8102020-12-10T22:36:06  *** proofofkeags_ <proofofkeags_!~proofofke@2601:280:c280:e500:1901:898e:ac68:17ca> has quit IRC (Ping timeout: 258 seconds)
8112020-12-10T22:38:43  *** TheRec <TheRec!~toto@drupal.org/user/146860/view> has joined #bitcoin-core-dev
8122020-12-10T22:50:46  *** kvaciral <kvaciral!~kvaciral@212.8.251.11> has quit IRC (Quit: Lost terminal)
8132020-12-10T23:03:58  *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
8142020-12-10T23:04:20  *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
8152020-12-10T23:04:21  <luke-jr> theStack: docker IS a VM…
8162020-12-10T23:05:14  <sipa> luke-jr: i think he means he didn't need yet another VM around it
8172020-12-10T23:08:25  *** jonatack <jonatack!~jon@109.232.227.138> has quit IRC (Ping timeout: 246 seconds)
8182020-12-10T23:09:44  *** jonatack <jonatack!~jon@213.152.186.24> has joined #bitcoin-core-dev
8192020-12-10T23:12:13  *** esotericnonsense <esotericnonsense!~esotericn@unaffiliated/esotericnonsense> has quit IRC (Ping timeout: 264 seconds)
8202020-12-10T23:19:17  *** kristapsk_ <kristapsk_!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
8212020-12-10T23:19:38  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
8222020-12-10T23:24:20  *** esotericnonsense <esotericnonsense!~esotericn@unaffiliated/esotericnonsense> has joined #bitcoin-core-dev
8232020-12-10T23:24:50  *** kristapsk___ <kristapsk___!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
8242020-12-10T23:25:13  *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has joined #bitcoin-core-dev
8252020-12-10T23:25:31  *** kristapsk_ <kristapsk_!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
8262020-12-10T23:25:48  *** twistedline__ <twistedline__!~twisted@2601:14d:8500:a77d:2985:36c3:6c1f:47b8> has quit IRC (Read error: Connection reset by peer)
8272020-12-10T23:30:08  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has quit IRC (Remote host closed the connection)
8282020-12-10T23:30:11  *** proofofkeags_ <proofofkeags_!~proofofke@2601:280:c280:e500:7f46:e633:cdc5:9df4> has joined #bitcoin-core-dev
8292020-12-10T23:30:24  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has joined #bitcoin-core-dev
8302020-12-10T23:30:33  *** kristapsk___ <kristapsk___!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
8312020-12-10T23:30:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
8322020-12-10T23:30:44  <bitcoin-git> [gui] luke-jr opened pull request #149: Intro: Have user choose assumevalid (master...intro_assumevalid) https://github.com/bitcoin-core/gui/pull/149
8332020-12-10T23:30:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
8342020-12-10T23:30:53  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has quit IRC (Remote host closed the connection)
8352020-12-10T23:31:53  <luke-jr> hebasto: promag: care to re-review https://github.com/bitcoin-core/gui/pull/125 - 2 ACKs, would be nice to get it in so I can move on to https://github.com/bitcoin-core/gui/pull/149 :P
8362020-12-10T23:32:53  *** proofofkeags__ <proofofkeags__!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has quit IRC (Ping timeout: 260 seconds)
8372020-12-10T23:34:15  *** jonatack <jonatack!~jon@213.152.186.24> has quit IRC (Quit: jonatack)
8382020-12-10T23:36:51  <theStack> luke-jr: not really, it shares the kernel with the host
8392020-12-10T23:37:02  *** proofofkeags_ <proofofkeags_!~proofofke@2601:280:c280:e500:7f46:e633:cdc5:9df4> has quit IRC (Remote host closed the connection)
8402020-12-10T23:40:26  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has joined #bitcoin-core-dev
8412020-12-10T23:42:53  *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Read error: Connection reset by peer)
8422020-12-10T23:43:08  *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has joined #bitcoin-core-dev
8432020-12-10T23:46:55  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 246 seconds)
8442020-12-10T23:48:04  *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
8452020-12-10T23:48:38  <sipa> ok, i have the unsigned binaries, they match
8462020-12-10T23:49:22  <sipa> i'm running gitian-build.py --sign now, but it seems it's building the linux binaries again?
8472020-12-10T23:54:16  <sipa> oh, i'm silly
8482020-12-10T23:54:18  *** jonatack <jonatack!~jon@88.124.242.136> has joined #bitcoin-core-dev
8492020-12-10T23:55:21  <sipa> -b == --build
8502020-12-10T23:57:07  <luke-jr> theStack: so do many VMs
8512020-12-10T23:57:24  <luke-jr> sipa: lol
8522020-12-10T23:57:27  *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Remote host closed the connection)
8532020-12-10T23:57:53  *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has joined #bitcoin-core-dev
8542020-12-10T23:58:20  <theStack> luke-jr: there are tons of articles explaining the differences between containers and vms... feel free to redefine terms for yourself though
8552020-12-10T23:59:51  *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Ping timeout: 260 seconds)