1 2020-12-14T00:07:07  <achow101> ok, I think my pr works now
  2 2020-12-14T00:07:24  <achow101> I was able to do the whole macOS build and sign process and got valid binaries out the other end
  3 2020-12-14T00:07:31  <achow101> will check sipa's pr now
  4 2020-12-14T00:14:47  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
  5 2020-12-14T00:14:52  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Remote host closed the connection)
  6 2020-12-14T00:15:08  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
  7 2020-12-14T00:19:00  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Remote host closed the connection)
  8 2020-12-14T00:21:23  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Ping timeout: 240 seconds)
  9 2020-12-14T00:23:45  *** CubicEarth <CubicEarth!~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net> has quit IRC (Read error: Connection reset by peer)
 10 2020-12-14T00:23:48  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
 11 2020-12-14T00:27:23  *** CubicEarth <CubicEarth!~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net> has joined #bitcoin-core-dev
 12 2020-12-14T00:31:22  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has joined #bitcoin-core-dev
 13 2020-12-14T00:43:19  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
 14 2020-12-14T00:49:04  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
 15 2020-12-14T00:50:14  *** aisak <aisak!be4a1432@190.74.20.50> has joined #bitcoin-core-dev
 16 2020-12-14T01:05:27  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
 17 2020-12-14T01:14:21  <achow101> sipa: 3021d9722182e2dfdcd29b1dec11514d66f3e566d5ae505d69c2c68b21f68a27  bitcoin-a4118c6e200e-osx-unsigned.tar.gz match?
 18 2020-12-14T01:18:10  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 256 seconds)
 19 2020-12-14T01:19:13  <sipa> achow101: match
 20 2020-12-14T01:19:37  <achow101> vmsize 0x0000000000083000
 21 2020-12-14T01:19:40  <achow101> no good I think
 22 2020-12-14T01:19:51  <sipa> achow101: that's expected
 23 2020-12-14T01:20:05  <achow101> how so?
 24 2020-12-14T01:20:09  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 25 2020-12-14T01:20:09  <sipa> it'll be corrected at signature-attach time, not before
 26 2020-12-14T01:20:16  <achow101> yes, this is post signing
 27 2020-12-14T01:20:19  <sipa> oh
 28 2020-12-14T01:20:20  <sipa> :(
 29 2020-12-14T01:20:25  <sipa> wth
 30 2020-12-14T01:20:28  <achow101> pre-signing is vmsize 0x0000000000043428
 31 2020-12-14T01:20:36  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
 32 2020-12-14T01:21:06  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 258 seconds)
 33 2020-12-14T01:21:50  <achow101> our validation script correctly fails it too
 34 2020-12-14T01:23:03  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
 35 2020-12-14T01:24:23  <sipa> bizarre
 36 2020-12-14T01:27:37  <fanquake> the saga continues
 37 2020-12-14T01:28:12  <achow101> at least the bogus sig trick works
 38 2020-12-14T01:28:28  *** aisak <aisak!be4a1432@190.74.20.50> has quit IRC (Remote host closed the connection)
 39 2020-12-14T01:28:49  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
 40 2020-12-14T01:33:49  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 264 seconds)
 41 2020-12-14T01:35:30  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has joined #bitcoin-core-dev
 42 2020-12-14T01:36:15  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
 43 2020-12-14T01:36:16  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
 44 2020-12-14T01:36:16  *** vasild_ is now known as vasild
 45 2020-12-14T01:44:45  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Quit: Leaving)
 46 2020-12-14T01:44:48  <sipa> achow101: i can't comprehend how it *did* round to 0x1000, but not 0x2000
 47 2020-12-14T01:45:06  <sipa> the constant 0x1000 should exist anymore in any of the used code
 48 2020-12-14T01:45:37  <sipa> is it possible it used a cached codesign_allocate from a previous build?
 49 2020-12-14T01:48:16  <achow101> I don't think so
 50 2020-12-14T01:48:32  <achow101> I definitely cleared the cache
 51 2020-12-14T01:52:21  <achow101> the vmsize is also wildly off. it should've been 0x7b000
 52 2020-12-14T01:52:53  <achow101> I thought maybe it had accidentally used my hack, but the unsigned was correct and the tarball matches yourss
 53 2020-12-14T01:53:50  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
 54 2020-12-14T01:54:31  <sipa> ok, perhaps changing this constant affects far more
 55 2020-12-14T01:54:49  <sipa> still doesn't explain why the number isn't a multiple of 0x2000, though
 56 2020-12-14T01:54:56  <sipa> i don't see how that's possible
 57 2020-12-14T01:57:49  <sipa> achow101: do you have the unsigned Bitcoin-Qt binary somewhere?
 58 2020-12-14T01:58:09  <achow101> yeah, do you need it?
 59 2020-12-14T01:58:28  <sipa> oh, i guess i have it too!
 60 2020-12-14T01:59:54  <achow101> I would expect so, since you did the gitian build
 61 2020-12-14T02:00:18  <sipa> yeah, i do
 62 2020-12-14T02:01:16  <sipa> any way to see the vmsize from linux?
 63 2020-12-14T02:01:37  <achow101> native_cctools also has otool
 64 2020-12-14T02:01:52  <achow101> it'll be x86_64-apple-darwin-otool
 65 2020-12-14T02:02:03  <achow101> it'll be x86_64-apple-darwin-otool -l Bitcoin-Qt
 66 2020-12-14T02:03:21  <sipa> what's the sig size?
 67 2020-12-14T02:04:52  <achow101> 224592
 68 2020-12-14T02:05:25  <sipa> unsigned:
 69 2020-12-14T02:05:26  <sipa>   segname __LINKEDIT
 70 2020-12-14T02:05:26  <sipa>    vmaddr 0x00000001018fa000
 71 2020-12-14T02:05:27  <sipa>    vmsize 0x0000000000043428
 72 2020-12-14T02:05:39  <sipa> i run:
 73 2020-12-14T02:05:42  <sipa> $ ./codesign_allocate -i dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt -a x86_64 224592 -o out
 74 2020-12-14T02:06:12  <sipa> output:
 75 2020-12-14T02:06:13  <sipa>   segname __LINKEDIT
 76 2020-12-14T02:06:13  <sipa>    vmaddr 0x00000001018fa000
 77 2020-12-14T02:06:14  <sipa>    vmsize 0x000000000007c000
 78 2020-12-14T02:06:38  <achow101> hmmm
 79 2020-12-14T02:06:42  <achow101> ???????
 80 2020-12-14T02:07:04  <sipa> this is using the codesign_allocate tool in my gitian build output
 81 2020-12-14T02:07:14  <achow101> I guess I have an unclean environment
 82 2020-12-14T02:08:13  <achow101> oh, it must be grabbing the wrong unsigned tarball
 83 2020-12-14T02:08:40  *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has joined #bitcoin-core-dev
 84 2020-12-14T02:15:11  <achow101> I can't get it to make the correct size
 85 2020-12-14T02:16:03  <sipa> how are you invoking gitian-build.py ?
 86 2020-12-14T02:16:15  <achow101> i'm using gbuild directly
 87 2020-12-14T02:16:25  <achow101> https://drive.google.com/file/d/1xFdpQoAKHNG9eC6Jw5rY7gzIwb7rgR-q/view?usp=sharing is the sig tarball if you want to try
 88 2020-12-14T02:17:22  <achow101> I'll try applying it manually
 89 2020-12-14T02:20:38  <sipa> my best guess is thah somehow it's using the wrong bitcoin-osx-unsigned.tar.gz
 90 2020-12-14T02:22:32  <achow101> running it locally instead of gitian definintely does the right thing
 91 2020-12-14T02:23:09  <achow101> and it is valid
 92 2020-12-14T02:25:46  *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has quit IRC (Ping timeout: 256 seconds)
 93 2020-12-14T02:31:44  *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has joined #bitcoin-core-dev
 94 2020-12-14T02:33:00  <achow101> ok, I got it working, it is valid now
 95 2020-12-14T02:33:15  <achow101> it was the filenames...
 96 2020-12-14T02:35:35  <sipa> 2 hardest problems in computer science: concurrency, off by one errors, and naming stuff
 97 2020-12-14T02:35:50  <achow101> heh
 98 2020-12-14T02:37:06  *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has quit IRC (Ping timeout: 256 seconds)
 99 2020-12-14T02:37:44  *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has joined #bitcoin-core-dev
100 2020-12-14T02:38:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
101 2020-12-14T02:38:05  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ade38b6ee8f9...25bc840e038f
102 2020-12-14T02:38:05  <bitcoin-git> bitcoin/master a33442f Antoine Riard: Remove m_is_manual_connection from CNodeState
103 2020-12-14T02:38:06  <bitcoin-git> bitcoin/master 25bc840 fanquake: Merge #20617: p2p: Remove m_is_manual_connection from CNodeState
104 2020-12-14T02:38:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
105 2020-12-14T02:38:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
106 2020-12-14T02:38:24  <bitcoin-git> [bitcoin] fanquake merged pull request #20617: p2p: Remove m_is_manual_connection from CNodeState (master...2020-12-remove-is-manual-connection) https://github.com/bitcoin/bitcoin/pull/20617
107 2020-12-14T02:38:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
108 2020-12-14T02:41:05  *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has quit IRC (Remote host closed the connection)
109 2020-12-14T02:41:31  *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has joined #bitcoin-core-dev
110 2020-12-14T02:42:47  <fanquake> Given the state of the last few PRs, looks like Appveyor is broken? I'm seeing:
111 2020-12-14T02:42:50  <fanquake> EXEC : error : Building package openssl-windows:x64-windows-static failed with: BUILD_FAILED ...
112 2020-12-14T02:46:35  *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has quit IRC (Ping timeout: 258 seconds)
113 2020-12-14T02:52:59  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
114 2020-12-14T03:02:30  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
115 2020-12-14T03:07:26  *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has joined #bitcoin-core-dev
116 2020-12-14T03:11:43  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
117 2020-12-14T03:12:23  *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has quit IRC (Ping timeout: 260 seconds)
118 2020-12-14T03:15:49  *** dviola <dviola!~diego@unaffiliated/dviola> has quit IRC (Quit: WeeChat 2.9)
119 2020-12-14T03:17:03  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
120 2020-12-14T03:30:27  <luke-jr> appveyor always broken..?
121 2020-12-14T04:15:32  *** tralfaz <tralfaz!~davterra@gateway/tor-sasl/tralfaz> has quit IRC (Quit: Leaving)
122 2020-12-14T04:42:23  *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
123 2020-12-14T04:51:58  *** jessepos_ <jessepos_!~jp@2601:643:8980:bfd2:447f:3dcb:9ae8:5b10> has joined #bitcoin-core-dev
124 2020-12-14T04:55:22  *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:3c52:ceaf:5e03:1c52> has quit IRC (Ping timeout: 260 seconds)
125 2020-12-14T04:56:47  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Remote host closed the connection)
126 2020-12-14T04:59:14  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Quit: Leaving)
127 2020-12-14T05:23:10  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
128 2020-12-14T05:36:49  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 264 seconds)
129 2020-12-14T06:09:37  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
130 2020-12-14T06:09:57  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
131 2020-12-14T06:20:46  *** vanaltj1 <vanaltj1!~vanaltj@84.39.117.57> has joined #bitcoin-core-dev
132 2020-12-14T06:53:15  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has joined #bitcoin-core-dev
133 2020-12-14T07:06:49  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 264 seconds)
134 2020-12-14T07:15:31  *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:3cdc:b002:cf8:d4b2> has joined #bitcoin-core-dev
135 2020-12-14T07:19:27  *** jessepos_ <jessepos_!~jp@2601:643:8980:bfd2:447f:3dcb:9ae8:5b10> has quit IRC (Ping timeout: 260 seconds)
136 2020-12-14T07:29:14  *** tlev <tlev!~tlev@li120-195.members.linode.com> has quit IRC (Quit: Ping timeout (120 seconds))
137 2020-12-14T07:29:28  *** tlev <tlev!~tlev@li120-195.members.linode.com> has joined #bitcoin-core-dev
138 2020-12-14T07:33:30  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has quit IRC (Remote host closed the connection)
139 2020-12-14T07:33:47  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
140 2020-12-14T07:37:48  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
141 2020-12-14T07:39:47  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has joined #bitcoin-core-dev
142 2020-12-14T08:14:05  *** jessepos_ <jessepos_!~jp@2601:643:8980:bfd2:3cdc:b002:cf8:d4b2> has joined #bitcoin-core-dev
143 2020-12-14T08:15:27  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has quit IRC (Ping timeout: 260 seconds)
144 2020-12-14T08:15:27  *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:3cdc:b002:cf8:d4b2> has quit IRC (Ping timeout: 260 seconds)
145 2020-12-14T08:16:02  *** sirpesto <sirpesto!sirpestoma@gateway/shell/matrix.org/x-owmmtitoawaupjmk> has quit IRC (Ping timeout: 260 seconds)
146 2020-12-14T08:16:34  *** icota[m] <icota[m]!icotamatri@gateway/shell/matrix.org/x-rnuqoxaxpepnbgsa> has joined #bitcoin-core-dev
147 2020-12-14T08:16:54  *** vanaltj1 <vanaltj1!~vanaltj@84.39.117.57> has quit IRC (*.net *.split)
148 2020-12-14T08:16:54  *** jonatack <jonatack!~jon@134.19.179.139> has quit IRC (*.net *.split)
149 2020-12-14T08:16:54  *** promag_ <promag_!~promag@188.250.84.129> has quit IRC (*.net *.split)
150 2020-12-14T08:16:54  *** adiabat <adiabat!~adiabat@63.209.32.102> has quit IRC (*.net *.split)
151 2020-12-14T08:16:55  *** darosior <darosior!~darosior@194.36.189.246> has quit IRC (*.net *.split)
152 2020-12-14T08:16:55  *** dr-orlovsky <dr-orlovsky!~dr-orlovs@31.14.40.19> has quit IRC (*.net *.split)
153 2020-12-14T08:16:55  *** btc_thc <btc_thc!annalee@kosher.marriageiguana.com> has quit IRC (*.net *.split)
154 2020-12-14T08:16:55  *** gleb <gleb!~gleb@178.150.137.228> has quit IRC (*.net *.split)
155 2020-12-14T08:16:55  *** nullptr| <nullptr|!~nullptr|@ip-94-112-13-119.net.upcbroadband.cz> has quit IRC (*.net *.split)
156 2020-12-14T08:16:55  *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-ulqcremawialdixq> has quit IRC (*.net *.split)
157 2020-12-14T08:16:56  *** cfields <cfields!~cfields@unaffiliated/cfields> has quit IRC (*.net *.split)
158 2020-12-14T08:16:56  *** rabidus <rabidus!~rabidus@dsl-olubng12-54fa0c-1.dhcp.inet.fi> has quit IRC (*.net *.split)
159 2020-12-14T08:16:56  *** wxss <wxss!~user@mail.deeplinkmedia.com> has quit IRC (*.net *.split)
160 2020-12-14T08:16:57  *** pingwindyktator <pingwindyktator!~pingwindy@pingwindyktator.me> has quit IRC (*.net *.split)
161 2020-12-14T08:17:20  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has joined #bitcoin-core-dev
162 2020-12-14T08:17:38  *** sirpesto <sirpesto!sirpestoma@gateway/shell/matrix.org/x-dllbxpcyqshawxcr> has joined #bitcoin-core-dev
163 2020-12-14T08:19:25  *** wraithm <wraithm!~wraithm@unaffiliated/wraithm> has quit IRC (Ping timeout: 264 seconds)
164 2020-12-14T08:22:19  *** vanaltj1 <vanaltj1!~vanaltj@84.39.117.57> has joined #bitcoin-core-dev
165 2020-12-14T08:22:19  *** jonatack <jonatack!~jon@134.19.179.139> has joined #bitcoin-core-dev
166 2020-12-14T08:22:19  *** promag_ <promag_!~promag@188.250.84.129> has joined #bitcoin-core-dev
167 2020-12-14T08:22:19  *** adiabat <adiabat!~adiabat@63.209.32.102> has joined #bitcoin-core-dev
168 2020-12-14T08:22:19  *** darosior <darosior!~darosior@194.36.189.246> has joined #bitcoin-core-dev
169 2020-12-14T08:22:19  *** dr-orlovsky <dr-orlovsky!~dr-orlovs@31.14.40.19> has joined #bitcoin-core-dev
170 2020-12-14T08:22:19  *** btc_thc <btc_thc!annalee@kosher.marriageiguana.com> has joined #bitcoin-core-dev
171 2020-12-14T08:22:19  *** gleb <gleb!~gleb@178.150.137.228> has joined #bitcoin-core-dev
172 2020-12-14T08:22:19  *** nullptr| <nullptr|!~nullptr|@ip-94-112-13-119.net.upcbroadband.cz> has joined #bitcoin-core-dev
173 2020-12-14T08:22:19  *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-ulqcremawialdixq> has joined #bitcoin-core-dev
174 2020-12-14T08:22:19  *** cfields <cfields!~cfields@unaffiliated/cfields> has joined #bitcoin-core-dev
175 2020-12-14T08:22:19  *** rabidus <rabidus!~rabidus@dsl-olubng12-54fa0c-1.dhcp.inet.fi> has joined #bitcoin-core-dev
176 2020-12-14T08:22:19  *** wxss <wxss!~user@mail.deeplinkmedia.com> has joined #bitcoin-core-dev
177 2020-12-14T08:22:19  *** pingwindyktator <pingwindyktator!~pingwindy@pingwindyktator.me> has joined #bitcoin-core-dev
178 2020-12-14T08:22:29  *** wraithm <wraithm!~wraithm@unaffiliated/wraithm> has joined #bitcoin-core-dev
179 2020-12-14T08:37:03  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Ping timeout: 240 seconds)
180 2020-12-14T08:43:00  *** hidrodo <hidrodo!76c811dd@118.200.17.221> has joined #bitcoin-core-dev
181 2020-12-14T08:47:39  *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has joined #bitcoin-core-dev
182 2020-12-14T08:49:13  *** hidrodo <hidrodo!76c811dd@118.200.17.221> has quit IRC (Remote host closed the connection)
183 2020-12-14T08:54:41  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
184 2020-12-14T09:10:17  *** tralfaz <tralfaz!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
185 2020-12-14T09:10:43  *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has quit IRC (Ping timeout: 240 seconds)
186 2020-12-14T09:22:10  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
187 2020-12-14T09:22:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
188 2020-12-14T09:22:34  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20648: chainparams: Add default fixed seeds for signet (master...2012-chainFixedSeedsSignet) https://github.com/bitcoin/bitcoin/pull/20648
189 2020-12-14T09:22:35  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
190 2020-12-14T09:32:25  *** kljasdfvv <kljasdfvv!~flack@p200300d46f24de00c295a82d97bf2816.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
191 2020-12-14T09:34:42  *** kljasdfvv <kljasdfvv!~flack@p200300d46f24de00c295a82d97bf2816.dip0.t-ipconnect.de> has quit IRC (Client Quit)
192 2020-12-14T09:36:28  *** kljasdfvv <kljasdfvv!~flack@p200300d46f24de00a3ce7892b0332293.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
193 2020-12-14T09:38:29  <wumpus> achow101: nice!
194 2020-12-14T09:40:37  *** kabaum <kabaum!~kabaum@h-13-35.A163.priv.bahnhof.se> has joined #bitcoin-core-dev
195 2020-12-14T09:47:09  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 265 seconds)
196 2020-12-14T09:51:56  <jonatack> yes, seeing the same appveyor issue
197 2020-12-14T09:55:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
198 2020-12-14T09:55:24  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/25bc840e038f...096bd374da28
199 2020-12-14T09:55:25  <bitcoin-git> bitcoin/master 4b7b58b Jon Atack: Update net_processing WTXID documentation per BIP339
200 2020-12-14T09:55:25  <bitcoin-git> bitcoin/master 096bd37 MarcoFalke: Merge #20592: doc: update wtxidrelay documentation per BIP339
201 2020-12-14T09:55:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
202 2020-12-14T09:55:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
203 2020-12-14T09:55:44  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20592: doc: update wtxidrelay documentation per BIP339 (master...update-wtxid-documentation-per-BIP339) https://github.com/bitcoin/bitcoin/pull/20592
204 2020-12-14T09:55:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
205 2020-12-14T09:57:28  *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has quit IRC (Quit: Find me in #TheHolyRoger or https://theholyroger.com)
206 2020-12-14T09:58:14  *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has joined #bitcoin-core-dev
207 2020-12-14T10:03:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
208 2020-12-14T10:03:45  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/096bd374da28...eec9366f7dd6
209 2020-12-14T10:03:45  <bitcoin-git> bitcoin/master 8b57013 John Newbery: [net processing] Remove nStartingHeight check from block relay
210 2020-12-14T10:03:46  <bitcoin-git> bitcoin/master 94d2cc3 John Newbery: [net processing] Remove unnecesary nNewHeight variable in UpdatedBlockTip()
211 2020-12-14T10:03:47  <bitcoin-git> bitcoin/master f636008 John Newbery: [net processing] Clarify UpdatedBlockTip()
212 2020-12-14T10:03:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
213 2020-12-14T10:04:14  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
214 2020-12-14T10:04:14  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20624: net processing: Remove nStartingHeight check from block relay (master...2020-12-remove-starting-height) https://github.com/bitcoin/bitcoin/pull/20624
215 2020-12-14T10:04:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
216 2020-12-14T10:16:59  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
217 2020-12-14T10:17:05  <aj> really? proposed on friday, merged on monday?
218 2020-12-14T10:23:31  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has quit IRC (Remote host closed the connection)
219 2020-12-14T10:24:28  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
220 2020-12-14T11:00:58  *** potato <potato!~Thunderbi@240d:1a:3d4:7d00:902d:8574:a5b7:8124> has joined #bitcoin-core-dev
221 2020-12-14T11:16:02  *** davec <davec!~davec@072-183-054-196.res.spectrum.com> has quit IRC (Ping timeout: 260 seconds)
222 2020-12-14T11:16:38  *** davec <davec!~davec@072-183-054-196.res.spectrum.com> has joined #bitcoin-core-dev
223 2020-12-14T11:18:28  *** Estel51Heidenrei <Estel51Heidenrei!~Estel51He@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
224 2020-12-14T11:18:45  <wumpus> that *is* really fast for a (non-trivial) P2P change
225 2020-12-14T11:19:49  <wumpus> especially over a december weekend where everyone was occupied with macos signing
226 2020-12-14T11:20:27  <wumpus> (pretty sure it's correct but we should be careful)
227 2020-12-14T11:23:18  *** Estel51Heidenrei <Estel51Heidenrei!~Estel51He@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 256 seconds)
228 2020-12-14T11:26:23  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
229 2020-12-14T11:26:46  *** davec <davec!~davec@072-183-054-196.res.spectrum.com> has quit IRC (Ping timeout: 256 seconds)
230 2020-12-14T11:27:02  *** davec <davec!~davec@072-183-054-196.res.spectrum.com> has joined #bitcoin-core-dev
231 2020-12-14T11:28:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
232 2020-12-14T11:28:07  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20649: refactor: Remove nMyStartingHeight from CNode/Connman (master...2012-netNoMyHeight) https://github.com/bitcoin/bitcoin/pull/20649
233 2020-12-14T11:28:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
234 2020-12-14T11:28:52  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
235 2020-12-14T11:29:24  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
236 2020-12-14T11:30:32  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
237 2020-12-14T11:42:23  *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Ping timeout: 240 seconds)
238 2020-12-14T11:43:59  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
239 2020-12-14T11:45:57  *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has quit IRC (Quit: Leaving)
240 2020-12-14T11:55:22  *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has quit IRC (Remote host closed the connection)
241 2020-12-14T11:57:27  *** vanaltj1 <vanaltj1!~vanaltj@84.39.117.57> has quit IRC (Remote host closed the connection)
242 2020-12-14T12:00:09  *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
243 2020-12-14T12:15:49  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
244 2020-12-14T12:18:47  *** kro[au] <kro[au]!~kroau]@s91904426.blix.com> has joined #bitcoin-core-dev
245 2020-12-14T12:22:03  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
246 2020-12-14T12:22:29  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
247 2020-12-14T12:23:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
248 2020-12-14T12:23:08  <bitcoin-git> [bitcoin] hebasto opened pull request #20650: depends: Drop workaround for a fixed bug in Qt build system (master...201214-xcb) https://github.com/bitcoin/bitcoin/pull/20650
249 2020-12-14T12:23:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
250 2020-12-14T12:23:32  *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has joined #bitcoin-core-dev
251 2020-12-14T12:31:23  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
252 2020-12-14T12:36:10  *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has quit IRC (Remote host closed the connection)
253 2020-12-14T12:36:32  *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has joined #bitcoin-core-dev
254 2020-12-14T12:36:36  *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has quit IRC (Client Quit)
255 2020-12-14T12:37:33  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
256 2020-12-14T12:40:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
257 2020-12-14T12:40:14  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/eec9366f7dd6...b103fdcb3bf4
258 2020-12-14T12:40:15  <bitcoin-git> bitcoin/master 7fabe0f Vasil Dimov: net: don't relay to the address' originator
259 2020-12-14T12:40:16  <bitcoin-git> bitcoin/master b103fdc MarcoFalke: Merge #19763: net: don't try to relay to the address' originator
260 2020-12-14T12:40:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
261 2020-12-14T12:40:25  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has joined #bitcoin-core-dev
262 2020-12-14T12:40:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
263 2020-12-14T12:40:34  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19763: net: don't try to relay to the address' originator (master...only_relay_to_unaware) https://github.com/bitcoin/bitcoin/pull/19763
264 2020-12-14T12:40:35  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
265 2020-12-14T12:47:05  *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has joined #bitcoin-core-dev
266 2020-12-14T12:48:27  *** davec <davec!~davec@072-183-054-196.res.spectrum.com> has quit IRC (Ping timeout: 260 seconds)
267 2020-12-14T12:48:41  *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has quit IRC (Client Quit)
268 2020-12-14T12:50:37  *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has joined #bitcoin-core-dev
269 2020-12-14T12:53:44  *** davec <davec!~davec@072-183-054-196.res.spectrum.com> has joined #bitcoin-core-dev
270 2020-12-14T13:01:56  *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has joined #bitcoin-core-dev
271 2020-12-14T13:01:58  *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has quit IRC (Client Quit)
272 2020-12-14T13:03:54  *** tralfaz is now known as davterra
273 2020-12-14T13:07:42  *** dermoth_ <dermoth_!~dermoth@unaffiliated/dermoth> has joined #bitcoin-core-dev
274 2020-12-14T13:07:42  *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has quit IRC (Disconnected by services)
275 2020-12-14T13:08:00  *** dermoth_ is now known as dermoth
276 2020-12-14T13:22:46  *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has joined #bitcoin-core-dev
277 2020-12-14T13:22:48  *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has quit IRC (Client Quit)
278 2020-12-14T13:25:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
279 2020-12-14T13:25:18  <bitcoin-git> [bitcoin] jnewbery opened pull request #20651: net: Make p2p recv buffer timeout 20 minutes for all peers (master...2020-12-recv-buffer-timeout) https://github.com/bitcoin/bitcoin/pull/20651
280 2020-12-14T13:25:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
281 2020-12-14T13:36:12  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
282 2020-12-14T13:36:13  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
283 2020-12-14T13:36:14  *** vasild_ is now known as vasild
284 2020-12-14T13:37:35  *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has joined #bitcoin-core-dev
285 2020-12-14T13:37:42  *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has quit IRC (Client Quit)
286 2020-12-14T13:40:52  *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has joined #bitcoin-core-dev
287 2020-12-14T13:41:09  *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has quit IRC (Client Quit)
288 2020-12-14T13:43:08  *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:7d7e:ee39:a576:2c3c> has joined #bitcoin-core-dev
289 2020-12-14T13:46:41  *** jessepos_ <jessepos_!~jp@2601:643:8980:bfd2:3cdc:b002:cf8:d4b2> has quit IRC (Ping timeout: 258 seconds)
290 2020-12-14T13:48:38  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
291 2020-12-14T13:53:32  *** kro[au] <kro[au]!~kroau]@s91904426.blix.com> has quit IRC (Remote host closed the connection)
292 2020-12-14T13:54:52  *** jessepos_ <jessepos_!~jp@2601:643:8980:bfd2:98c1:5a96:a9af:37d1> has joined #bitcoin-core-dev
293 2020-12-14T13:55:08  *** Nolar <Nolar!~Nolar@178.162.209.171> has joined #bitcoin-core-dev
294 2020-12-14T13:55:43  <provoostenator> I assume there will be an rc4 to deal with the non-determinism macOS nightmare? So no point in me signing rc3?
295 2020-12-14T13:58:27  *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:7d7e:ee39:a576:2c3c> has quit IRC (Ping timeout: 260 seconds)
296 2020-12-14T14:08:31  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has joined #bitcoin-core-dev
297 2020-12-14T14:09:21  <jonasschnelli> provoostenator: yes.
298 2020-12-14T14:09:40  <jonasschnelli> provoostenator: I mean you can still sing the windows build... but the macOS is useless
299 2020-12-14T14:19:03  *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
300 2020-12-14T14:34:23  *** lontivero <lontivero!~lontivero@186.183.50.53> has joined #bitcoin-core-dev
301 2020-12-14T14:36:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
302 2020-12-14T14:36:32  <bitcoin-git> [bitcoin] gbizzotto opened pull request #20652: Designer fees when coin control is enabled: (master...master) https://github.com/bitcoin/bitcoin/pull/20652
303 2020-12-14T14:36:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
304 2020-12-14T14:37:15  *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has joined #bitcoin-core-dev
305 2020-12-14T14:37:41  *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has quit IRC (Client Quit)
306 2020-12-14T14:42:08  *** pinheadm_ <pinheadm_!~pinheadmz@71.190.30.138> has joined #bitcoin-core-dev
307 2020-12-14T14:45:07  *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has quit IRC (Ping timeout: 260 seconds)
308 2020-12-14T14:50:48  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
309 2020-12-14T14:53:20  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has joined #bitcoin-core-dev
310 2020-12-14T14:54:52  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
311 2020-12-14T14:55:29  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
312 2020-12-14T15:00:52  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has quit IRC (Ping timeout: 260 seconds)
313 2020-12-14T15:01:34  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
314 2020-12-14T15:21:23  *** miketwen_ <miketwen_!~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com> has joined #bitcoin-core-dev
315 2020-12-14T15:25:16  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 256 seconds)
316 2020-12-14T15:27:08  <wumpus> it's certain that there will be a rc4, that said, if you're going to sign rc3 or not is up to you
317 2020-12-14T15:27:39  <wumpus> it's still worth testing rc3 for other things, besides the macos determinism change i do not expect many differences
318 2020-12-14T15:30:42  <provoostenator> The determinism thing relates only to the signed binary,  or also to the unsiged?
319 2020-12-14T15:30:58  <provoostenator> (code signed)
320 2020-12-14T15:32:01  <wumpus> sorry, it's not a determinism problem this time, it's a "broken code signature" problem, and it applies only to the codesigned build
321 2020-12-14T15:34:07  <wumpus> the -unsigned macos build should be fine
322 2020-12-14T15:35:26  <provoostenator> Ok, I managed to get a different unsigned build with #20638, so I'll build rc3 as well to see what's going on
323 2020-12-14T15:35:28  <gribble> https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
324 2020-12-14T15:40:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
325 2020-12-14T15:40:32  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #20652: Designer fees when coin control is enabled (master...master) https://github.com/bitcoin/bitcoin/pull/20652
326 2020-12-14T15:40:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
327 2020-12-14T15:40:44  <ariard> I proposed the following topic for tmrw p2p meeting : "Review of the P2P Review Process" : https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings
328 2020-12-14T15:41:17  <ariard> it's end of year and it can be cool to reflect on the last 12 months of p2p PRs, what we can learn from :)
329 2020-12-14T15:41:43  <ariard> feel free to add more example PRs, the ones I picked up were mostly on the number of comments
330 2020-12-14T15:46:16  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 265 seconds)
331 2020-12-14T15:50:53  <luke-jr> I wonder if there should be a "Backported" label to make it easier to look for missing backports (MarcoFalke, thoughts?)
332 2020-12-14T15:52:47  <wumpus> please not another backport related label :-)
333 2020-12-14T15:54:06  <luke-jr> <.<
334 2020-12-14T15:54:49  <wumpus> I mean it's a little bit more work but you could look in the history of the PR whether it's been backported, or was ever to be backported, to the branch you're interested in
335 2020-12-14T15:55:31  <wumpus> ariard: good idea
336 2020-12-14T15:56:48  <luke-jr> is there a motive behind #20599 ?
337 2020-12-14T15:56:51  <gribble> https://github.com/bitcoin/bitcoin/issues/20599 | net processing: Tolerate sendheaders and sendcmpct messages before verack by jnewbery · Pull Request #20599 · bitcoin/bitcoin · GitHub
338 2020-12-14T15:57:11  <luke-jr> wumpus: my thought is to list all merged PRs minus backported ones
339 2020-12-14T15:57:22  *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
340 2020-12-14T15:58:39  <luke-jr> + a filter for bugfixes, it'd be pretty clean/easy actually
341 2020-12-14T15:58:46  <wumpus> FWIW you could do this with a script, looking at commit metadata on the branches
342 2020-12-14T15:59:09  <luke-jr> maybe, but a github link would be easier/nicer :P
343 2020-12-14T15:59:12  <wumpus> it's more thorough than a tag that people might forget or not
344 2020-12-14T15:59:20  <wumpus> also it's *per branch*
345 2020-12-14T16:00:16  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 240 seconds)
346 2020-12-14T16:00:50  <wumpus> luke-jr: yes, to make it (on the very long term) possible move all protocol negotiation to that phase
347 2020-12-14T16:01:49  *** belcher_ is now known as belcher
348 2020-12-14T16:09:27  *** StopAndDecrypt <StopAndDecrypt!~StopAndDe@unaffiliated/stopanddecrypt> has joined #bitcoin-core-dev
349 2020-12-14T16:10:44  <jonatack> ariard: i wonder if long-term contributors think the review bottleneck has improved over the past year...i'm too close to be objective but not sure that it has
350 2020-12-14T16:11:07  <jonatack> s/review/review and testing/
351 2020-12-14T16:12:56  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
352 2020-12-14T16:13:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
353 2020-12-14T16:13:55  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b103fdcb3bf4...fff7d056a92f
354 2020-12-14T16:13:55  <bitcoin-git> bitcoin/master b316dcb John Newbery: [net processing] Tolerate sendheaders and sendcmpct messages before verack...
355 2020-12-14T16:13:56  <bitcoin-git> bitcoin/master fff7d05 MarcoFalke: Merge #20599: net processing: Tolerate sendheaders and sendcmpct messages ...
356 2020-12-14T16:13:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
357 2020-12-14T16:14:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
358 2020-12-14T16:14:10  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20599: net processing: Tolerate sendheaders and sendcmpct messages before verack (master...2020-12-tolerate-early-send-messages) https://github.com/bitcoin/bitcoin/pull/20599
359 2020-12-14T16:14:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
360 2020-12-14T16:17:10  <luke-jr> jonatack: IMO I'm also too close (and haven't even tried to look at it objectively), but I also think it hasn't improved
361 2020-12-14T16:23:34  *** joelklabo <joelklabo!~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
362 2020-12-14T16:34:42  <achow101> provoostenator: can you provide the bitcoin-7f9d623e0210-osx-unsigned.tar.gz for your build of #20638?
363 2020-12-14T16:34:44  <gribble> https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
364 2020-12-14T16:35:33  <achow101> also, did you build 7f9d623 or the merge with master?
365 2020-12-14T16:38:23  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
366 2020-12-14T16:45:17  <provoostenator> achow101: I'll try to drop it somewhere.  I built the commit
367 2020-12-14T16:45:21  <provoostenator> (the branch)
368 2020-12-14T16:51:14  <ariard> jonatack: how would you qualify such improvements? for really good reasons, it's a hard question, you have to consider we've all different priorities :)
369 2020-12-14T16:59:39  <achow101> provoostenator: can you rebuild with a clean cache? it seems like the qt nondeterminism issue we fixed for rc2. did you perhaps do a gitian build on master earlier?
370 2020-12-14T16:59:56  <provoostenator> Remind me how to nuke cache?
371 2020-12-14T17:00:08  <provoostenator> Last thing I built before this was rc2
372 2020-12-14T17:00:13  <provoostenator> I never built rc3
373 2020-12-14T17:00:22  <provoostenator> (although I just did, but will do that again later, with a fresh cache)
374 2020-12-14T17:00:26  <jonatack> rm -r cache
375 2020-12-14T17:00:27  <jonatack> ?
376 2020-12-14T17:00:30  <achow101> if you did a master build before that, it would use the master cache
377 2020-12-14T17:00:32  <jonatack> make -C ../bitcoin/depends download SOURCES_PATH=`pwd`/cache/common
378 2020-12-14T17:00:46  <achow101> rm -rf gitian-builder/cache/bitcoin-core-osx-22/
379 2020-12-14T17:00:56  <jonatack> in gitian-builder
380 2020-12-14T17:01:22  <jonatack> achow101: oh just the one, ok
381 2020-12-14T17:01:27  <achow101> or if you want to nuke the entire cache, rm -r gitian-builder/cache
382 2020-12-14T17:01:36  <provoostenator> I janked the whole cache, building your branch again now
383 2020-12-14T17:01:54  <provoostenator> I prefer nuking cache over carefully salvaging it
384 2020-12-14T17:02:01  <jonatack> heh
385 2020-12-14T17:02:40  *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has joined #bitcoin-core-dev
386 2020-12-14T17:03:51  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
387 2020-12-14T17:08:46  *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has quit IRC (Quit: Pavlenex)
388 2020-12-14T17:08:54  *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has quit IRC (Remote host closed the connection)
389 2020-12-14T17:18:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
390 2020-12-14T17:18:31  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20653: doc: Move add relay comment in net to correct place (master...2012-docNetAddrRelay) https://github.com/bitcoin/bitcoin/pull/20653
391 2020-12-14T17:18:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
392 2020-12-14T17:22:43  <wumpus> luke-jr: i'm not sure how to interpret your comment on #20605, are there any cases in which you see the code is unsafe on windows?
393 2020-12-14T17:22:46  <gribble> https://github.com/bitcoin/bitcoin/issues/20605 | init: Signal-safe instant shutdown by laanwj · Pull Request #20605 · bitcoin/bitcoin · GitHub
394 2020-12-14T17:24:11  *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Remote host closed the connection)
395 2020-12-14T17:24:45  *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
396 2020-12-14T17:32:42  <luke-jr> wumpus: I don't know how Windows signals work, but there are definitely signals..
397 2020-12-14T17:32:55  <wumpus> if so, is there any way to a similar thing to the pipe trick, if not we need to keep the polling loop on windows
398 2020-12-14T17:34:05  <wumpus> I'm fine with that tbh, though it would have been nice to use a proper condition variable at least on one os
399 2020-12-14T17:34:38  <luke-jr> https://docs.microsoft.com/en-us/windows/win32/api/namedpipeapi/nf-namedpipeapi-createpipe exists, but again, I don't know if we need it
400 2020-12-14T17:35:31  <wumpus> I'm sure it exists
401 2020-12-14T17:35:41  <sipa> https://docs.microsoft.com/en-us/previous-versions/xdkz3x12(v=vs.140)
402 2020-12-14T17:36:04  <wumpus> the question is, is the solution wit ha condition variable safe, the pipe trick itself is very much a UNIX specitic thing and makes no sense *as it is* on win32
403 2020-12-14T17:36:41  <wumpus> I think I prefer changing the PR to keep using the poll loop on windows, I dont' know enough about that OS to be sure of this
404 2020-12-14T17:37:06  <wumpus> or maybe just close the PR maybe it's not relevant at all I dunno
405 2020-12-14T17:38:08  <provoostenator> achow101: nuked cache, ran the build again, same result
406 2020-12-14T17:38:13  <sipa> wumpus: so i'm confused in my link whether Win32 refers to just 32-bit windows
407 2020-12-14T17:38:16  <sipa> or all windows
408 2020-12-14T17:38:17  <provoostenator> Do I also need to replace the SDK?
409 2020-12-14T17:38:31  <sipa> because it says it invokes the signal handler in a new thread
410 2020-12-14T17:38:52  <wumpus> sipa: I don't know either
411 2020-12-14T17:39:00  <achow101> provoostenator: shouldn't be necessary. I'll dig a bit further then
412 2020-12-14T17:39:18  <achow101> but it doesn't seem like the issue is with the changes in the pr since it's all in the middle of the binary
413 2020-12-14T17:40:06  <provoostenator> I'll push my rc3 as well
414 2020-12-14T17:40:55  <luke-jr> sipa: it sounds like that's not even applicable to the signal() call
415 2020-12-14T17:41:23  <luke-jr> sipa: as I read it, you can't use signal() for SIGINT  because SIGINT is supposed to get its own thread (implying signal() doesn't do own thread)
416 2020-12-14T17:42:21  <sipa> luke-jr: yes
417 2020-12-14T17:42:48  <wumpus> we don't *use* signal() on windows though
418 2020-12-14T17:43:18  <wumpus> so it shouldn't affect safety in our case because it doesn't call RequestShutdown
419 2020-12-14T17:43:29  <sipa> wumpus: oh!
420 2020-12-14T17:43:33  <sipa> there is an equivalent to catch interrupt signals for console applications, though
421 2020-12-14T17:43:38  <sipa> we just don't?
422 2020-12-14T17:43:51  <wumpus> there's a call to SetConsoleCtrlHandler
423 2020-12-14T17:43:57  <wumpus> I have no idea what that does
424 2020-12-14T17:43:58  <sipa> ah
425 2020-12-14T17:45:16  <provoostenator> My rc3 checksums for macOS are pretty much the same as other contributors.
426 2020-12-14T17:45:18  <wumpus> it does a Sleep(INFINITE) after calling StartShutdown so it seems to be different from a UNIX signal
427 2020-12-14T17:45:20  <sipa> https://docs.microsoft.com/en-us/windows/console/console-control-handlers
428 2020-12-14T17:45:25  <sipa> wumpus: separate thread
429 2020-12-14T17:45:27  <sipa> we're good
430 2020-12-14T17:45:40  *** Sebimot0 <Sebimot0!~tom@230.15.195.173.client.static.strong-in52.as13926.net> has joined #bitcoin-core-dev
431 2020-12-14T17:45:53  <wumpus> yes, a separate thread should be safe, that's exactly what a condition variable is supposed tobe about
432 2020-12-14T17:46:06  <sipa> indeed
433 2020-12-14T17:46:50  <wumpus> thanks for looking that up
434 2020-12-14T17:47:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
435 2020-12-14T17:47:57  <bitcoin-git> [bitcoin] laanwj reopened pull request #20605: init: Signal-safe instant shutdown (master...2020_12_instant_shutdown) https://github.com/bitcoin/bitcoin/pull/20605
436 2020-12-14T17:47:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
437 2020-12-14T17:49:47  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Read error: Connection reset by peer)
438 2020-12-14T17:50:10  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
439 2020-12-14T17:51:53  *** kexkey <kexkey!~kexkey@static-198-54-132-174.cust.tzulo.com> has joined #bitcoin-core-dev
440 2020-12-14T17:54:27  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
441 2020-12-14T17:57:16  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
442 2020-12-14T18:08:50  <achow101> provoostenator: I've seen this non-determinism before. It has something to do with version numbers. I forget how (if) that was resolved though... I think it might be another instance of the clang 8 bug
443 2020-12-14T18:12:56  *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has joined #bitcoin-core-dev
444 2020-12-14T18:13:16  *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has quit IRC (Client Quit)
445 2020-12-14T18:14:27  <wumpus> if it's another instance of the clang 8 bug, I'd really suggest to switch compilers this time
446 2020-12-14T18:15:08  <wumpus> this bug-already fixed in upstream relaases-has given us enough work
447 2020-12-14T18:16:29  <achow101> I found it: http://gnusha.org/bitcoin-core-dev/2020-11-24.log at 17:04
448 2020-12-14T18:16:36  <achow101> was not resolved
449 2020-12-14T18:16:52  <achow101> but it's something in master, not 0.21 afaict
450 2020-12-14T18:17:30  *** jessepos_ <jessepos_!~jp@2601:643:8980:bfd2:98c1:5a96:a9af:37d1> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
451 2020-12-14T18:17:54  *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:98c1:5a96:a9af:37d1> has joined #bitcoin-core-dev
452 2020-12-14T18:18:33  <achow101> actually no, that time was a backport to 0.21 ... not sure, but it seems much less likely to trigger
453 2020-12-14T18:32:30  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 256 seconds)
454 2020-12-14T18:36:57  <wumpus> what differs in the version string?
455 2020-12-14T18:37:08  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has joined #bitcoin-core-dev
456 2020-12-14T18:45:08  *** jonatack <jonatack!~jon@134.19.179.139> has quit IRC (Quit: jonatack)
457 2020-12-14T18:49:21  <achow101> I think it's in a string formatter
458 2020-12-14T18:50:04  <wumpus> oh different code to generate the same output
459 2020-12-14T18:50:12  <achow101> yeah
460 2020-12-14T18:51:30  <achow101> it seems to have the same characteristics as the clang 8 issue in qt, so I think it's the same problem
461 2020-12-14T18:52:14  *** jonatack <jonatack!~jon@88.124.242.136> has joined #bitcoin-core-dev
462 2020-12-14T18:57:49  *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Ping timeout: 264 seconds)
463 2020-12-14T18:58:36  *** jonatack <jonatack!~jon@134.19.179.195> has joined #bitcoin-core-dev
464 2020-12-14T19:04:25  <wumpus> it's rarer though, if it happens only for provoostenator :)
465 2020-12-14T19:04:36  <achow101> it happened to me, once
466 2020-12-14T19:05:01  <wumpus> he rebuilt with cleared cache and got the same, what's the random chance of that
467 2020-12-14T19:06:04  <wumpus> anyhow we really need to get rid of clang 8
468 2020-12-14T19:09:34  *** filchef <filchef!~filchef@89.253.179.83> has joined #bitcoin-core-dev
469 2020-12-14T19:10:56  <provoostenator> Make Clang 9 again?
470 2020-12-14T19:12:57  <luke-jr> til bitcoin-qt has 195 threads
471 2020-12-14T19:13:07  <sipa> wut
472 2020-12-14T19:13:32  <luke-jr> I think mostly llvmpipe to be fair
473 2020-12-14T19:13:53  <luke-jr> no, that only accounts for 64 of them :x
474 2020-12-14T19:14:54  <luke-jr> most look like https://dpaste.com/GDP5JUSZH
475 2020-12-14T19:18:55  <wumpus> if only we had that kind of parallelism :p
476 2020-12-14T19:20:43  <wumpus> how many cores/hardware threads does your CPU have? i think at least llvmpipe creates a thread for every one
477 2020-12-14T19:21:31  <luke-jr> 64
478 2020-12-14T19:23:54  <wumpus> par is limited to 15
479 2020-12-14T19:24:14  <wumpus> how many threads does bitcoind have there?
480 2020-12-14T19:24:31  <luke-jr> ?
481 2020-12-14T19:24:48  <wumpus> MAX_SCRIPTCHECK_THREADS = 15
482 2020-12-14T19:25:03  <luke-jr> I didn't change it
483 2020-12-14T19:25:35  <wumpus> as far as i know that's the only variable number of threads scaled to cores, all the other ones are only based on configuration settings
484 2020-12-14T19:26:13  <luke-jr> oh well :/
485 2020-12-14T19:26:30  <luke-jr> is there a reason we prefer Freedesktop notifications over QSystemTray?
486 2020-12-14T19:26:58  <wumpus> would be interesting to do a "info threads all" (or whatever the exact command is) in gdb
487 2020-12-14T19:27:04  <luke-jr> the latter seems more ideal - not only is it platform-neutral, but it also presumably ties the notification to the icon
488 2020-12-14T19:27:20  <luke-jr> Invalid thread ID: all
489 2020-12-14T19:28:01  <wumpus> at the time it didn't work anymore for some desktops, static qt was unable to get notifications to ubuntu unity because it required a special plugin which wasn't available there
490 2020-12-14T19:28:18  <wumpus> of course, unity is dead now, i have no clue how it's handled in gnome3 etc
491 2020-12-14T19:29:24  <luke-jr> and it didn't fallback?
492 2020-12-14T19:29:33  <wumpus> if notifications through qsystemtray work okay across linux desktop environments now that's be nice
493 2020-12-14T19:29:37  <luke-jr> if(_trayIcon && _trayIcon->supportsMessages())
494 2020-12-14T19:29:55  <luke-jr> I'm poking at this because I realised 90% of my startup wait is on a timeout of the FDO thing
495 2020-12-14T19:30:42  <luke-jr> https://luke.dashjr.org/tmp/code/ita.xz has full backtraces of all my threads during splash fwiw
496 2020-12-14T19:34:38  <wumpus> i'm sure it was some really annoying problem, e.g. it claimed to support it but just ignored them then
497 2020-12-14T19:35:09  <luke-jr> >_<
498 2020-12-14T19:36:16  <wumpus> we've had many of those problems, if you're going to implement it differently it'll require a lot of testing (of the gitian-built binaries) across distros to be sure
499 2020-12-14T19:36:44  <luke-jr> what if I just add a guinotify=qsystemtray option or soemthing?
500 2020-12-14T19:36:57  <wumpus> bah, that doesn't seem worth a configuration option
501 2020-12-14T19:37:18  <wumpus> it's very much out of scope of the project, this is something that needs to be gotten right automatically
502 2020-12-14T19:38:19  <luke-jr> it's automatic, but QDBus takes like 20 seconds to timeout :/
503 2020-12-14T19:38:23  <wumpus> if we can drop the custom dbus code that'd be great but i'm sure i wrote it for a good reason at the time
504 2020-12-14T19:38:48  <luke-jr> and it doesn't look like there's a way to change the timeout in our code
505 2020-12-14T19:38:49  <wumpus> but that's what, half a decade ago?
506 2020-12-14T19:39:17  <luke-jr> shrug
507 2020-12-14T19:39:18  <wumpus> many new qt versions since, and as said, unity is dead
508 2020-12-14T19:41:02  <wumpus> and ideally notifications is something that gets handlded correctly by qt, that's why we use an abstraction like qt
509 2020-12-14T19:41:33  <luke-jr> but requires lots of testing = likely to get stuck in review limbo forever :/
510 2020-12-14T19:41:59  <wumpus> otoh deleting code usually gets people enthousiatic
511 2020-12-14T19:51:26  <wumpus> just don't add any regular expressions :-)
512 2020-12-14T19:52:58  <luke-jr> ☹
513 2020-12-14T19:53:12  <luke-jr> I was going to reimplement Notificator in Perl tho
514 2020-12-14T19:56:40  <luke-jr> wumpus: Unity doesn't seem to be dead :/
515 2020-12-14T19:57:15  <luke-jr> if someone wants to PR it, https://github.com/bitcoin-core/gui/compare/master…luke-jr:drop_dbus?expand=1
516 2020-12-14T19:57:26  <luke-jr> not sure I care enough to deal with it
517 2020-12-14T19:58:44  <wumpus> it's dead enough for me
518 2020-12-14T19:59:13  <wumpus> I don't particularly care either it's you who brought it up
519 2020-12-14T20:03:07  *** jarolrod <jarolrod!uid475272@gateway/web/irccloud.com/x-oeyqoxzpfotwpgrr> has quit IRC (Ping timeout: 258 seconds)
520 2020-12-14T20:03:39  *** robot-dreams <robot-dreams!sid463268@gateway/web/irccloud.com/x-cndlteukbokvnpjt> has quit IRC (Ping timeout: 264 seconds)
521 2020-12-14T20:03:48  *** digi_james <digi_james!sid281632@gateway/web/irccloud.com/x-vjrjbdfohnkqvcae> has quit IRC (Read error: Connection reset by peer)
522 2020-12-14T20:03:49  *** endogenic <endogenic!sid145991@gateway/web/irccloud.com/x-rttmqpakeqwugsxe> has quit IRC (Ping timeout: 272 seconds)
523 2020-12-14T20:04:09  *** digi_james <digi_james!sid281632@gateway/web/irccloud.com/x-ckjfcboybjfhlvon> has joined #bitcoin-core-dev
524 2020-12-14T20:04:13  *** jarolrod <jarolrod!uid475272@gateway/web/irccloud.com/x-gbmckvtqrpvteemn> has joined #bitcoin-core-dev
525 2020-12-14T20:04:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
526 2020-12-14T20:04:18  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fff7d056a92f...94a9cd25fd17
527 2020-12-14T20:04:18  <bitcoin-git> bitcoin/master 41a413b Jonas Schnelli: Define correct symbols for getauxval
528 2020-12-14T20:04:19  <bitcoin-git> bitcoin/master 836a3dc Jonas Schnelli: Avoid weak-linked getauxval support on non-linux platforms (like macOS)
529 2020-12-14T20:04:19  <bitcoin-git> bitcoin/master 94a9cd2 Wladimir J. van der Laan: Merge #20594: Fix getauxval calls in randomenv.cpp
530 2020-12-14T20:04:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
531 2020-12-14T20:04:27  *** mariorz <mariorz!sid490@gateway/web/irccloud.com/x-pajtjpcktkebvwdf> has quit IRC (Ping timeout: 272 seconds)
532 2020-12-14T20:04:35  *** endogenic <endogenic!sid145991@gateway/web/irccloud.com/x-mljoynrkytaqlzva> has joined #bitcoin-core-dev
533 2020-12-14T20:04:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
534 2020-12-14T20:04:37  <bitcoin-git> [bitcoin] laanwj merged pull request #20594: Fix getauxval calls in randomenv.cpp (master...2020/12/getauxval) https://github.com/bitcoin/bitcoin/pull/20594
535 2020-12-14T20:04:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
536 2020-12-14T20:04:53  *** robot-dreams <robot-dreams!sid463268@gateway/web/irccloud.com/x-fpkuvfihnixtfrzh> has joined #bitcoin-core-dev
537 2020-12-14T20:04:53  *** mariorz <mariorz!sid490@gateway/web/irccloud.com/x-dmlbtukjehcjydsc> has joined #bitcoin-core-dev
538 2020-12-14T20:06:01  <wumpus> luke-jr: i don't get it why is dbus timing out for you in the first place? i'd expect it'd either make a connection (if the socket is available, available through the environment or throuh some X hack) or not
539 2020-12-14T20:08:02  <wumpus> dbus is a local socket so it has no reason at all to time out
540 2020-12-14T20:17:59  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
541 2020-12-14T20:21:05  *** lontivero <lontivero!~lontivero@186.183.50.53> has quit IRC (Ping timeout: 240 seconds)
542 2020-12-14T20:24:36  <luke-jr> wumpus: my development user has no access to my notifications
543 2020-12-14T20:24:52  <luke-jr> the timeout is internal to dbus
544 2020-12-14T20:24:57  <luke-jr> I don't know how it works
545 2020-12-14T20:26:58  <andytoshi> is it considered a problem that `getblockcount` sometimes returns a blockheight before all the BlockConnected signals have been processed? i assume not, such is the nature of signals
546 2020-12-14T20:27:00  <wumpus> it seems to me like there is some problem in the stack there; flatpak and such can also selectively reject dbus acces, it should be possible to reject access without causing applicatons to spend time timing out
547 2020-12-14T20:27:47  <andytoshi> but it can mean that you `generate` 100 blocks then try to spend a coin and find that you can't, because `getblockcount` says you have 101 blocks but the wallet doesn't know yet
548 2020-12-14T20:28:33  <luke-jr> wumpus: regardless, tiemout appears to be the default behaviour
549 2020-12-14T20:28:36  <wumpus> andytoshi: there's generally no guarantee there, the RPC tests do some tricks there IIRC
550 2020-12-14T20:28:49  <andytoshi> ok, cool, i'll study the existing tests
551 2020-12-14T20:28:51  <wumpus> luke-jr: definitely an upstream problem though
552 2020-12-14T20:29:12  <wumpus> we don't do anything partcularly complex or special
553 2020-12-14T20:29:45  <sipa> andytoshi: tests synchronize by sending a ping and waiting for a pong
554 2020-12-14T20:29:54  <andytoshi> sipa: i only have one node here
555 2020-12-14T20:31:35  *** shesek <shesek!~shesek@unaffiliated/shesek> has joined #bitcoin-core-dev
556 2020-12-14T20:32:06  <andytoshi> this is really hard to trigger, you have to generate and then immediately try to send coins (to a fixed address, even calling getnewaddress() is enough delay that you no longer see the race)
557 2020-12-14T20:32:13  <sipa> andytoshi: the python code tests have a full p2p implementation
558 2020-12-14T20:32:55  <wumpus> "syncwithvalidationinterfacequeue" RPC maybe?
559 2020-12-14T20:33:05  <andytoshi> but for example, the taproot tests call `self.nodes[1].generate(101)` immediately followed by `self.test_spenders(self.nodes[1], ...`
560 2020-12-14T20:33:06  <sipa> ah yes, that works too
561 2020-12-14T20:33:22  <andytoshi> and i -think- this is ok because you call some other RPCs before doing any coin selection
562 2020-12-14T20:33:24  <wumpus> it's some kind of barrier no idea if it's the right one
563 2020-12-14T20:33:24  <sipa> andytoshi: those are all RPC calls which are fully synchronous
564 2020-12-14T20:33:51  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
565 2020-12-14T20:34:04  <sipa> andytoshi: it's only a problem if you mix RPC calls with p2p interaction that an RPC may not reflect a P2P messsge that was already sent
566 2020-12-14T20:34:13  <andytoshi> they're not, you can call `generate(101)` and then immediately `getblockcount` and it won't reflect the new blockcount
567 2020-12-14T20:34:30  <sipa> really?
568 2020-12-14T20:34:46  <sipa> on the same node?
569 2020-12-14T20:34:53  <andytoshi> one moment, let me confirm that this isn't something crazy and elements-specific. but yes
570 2020-12-14T20:35:56  <sipa> generate doesn't exist anymore iirc; it's generatetoaddress etc
571 2020-12-14T20:36:20  <andytoshi> yeah, but the funcitonal tests have a generate method which internally calls generatetoaddress
572 2020-12-14T20:36:24  <andytoshi> on a fresh getnewaddress
573 2020-12-14T20:37:27  <sipa> ok
574 2020-12-14T20:38:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
575 2020-12-14T20:38:44  <bitcoin-git> [gui] luke-jr opened pull request #152: GUI: Initialise DBus notifications in another thread (master...gui_notify_setup_bg) https://github.com/bitcoin-core/gui/pull/152
576 2020-12-14T20:38:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
577 2020-12-14T20:38:50  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC ()
578 2020-12-14T20:38:52  <andytoshi> ah i'm wrong, generatetoaddress and getblockcount are consistent
579 2020-12-14T20:39:17  <andytoshi> but generatetoaddress followed by an immediate spend may not be (coin selection may fail, as the wallet has not yet received the BlockConnected signal)
580 2020-12-14T20:43:08  <sipa> try syncwithvalidationinterfacequeue probably works
581 2020-12-14T20:44:01  <andytoshi> (you can repro by adding `self.nodes[0].generate(101)` and `self.nodes[0].getnewaddress()` to the CLTV test, say, or anything with only one node, then looking at the logs, you will see intermittently that the `getnewaddress` is received before the final block is connected)
582 2020-12-14T20:44:06  <andytoshi> ok thanks
583 2020-12-14T20:44:39  <andytoshi> i didn't know about this RPC, i think it's exactly what i watn
584 2020-12-14T20:44:44  <andytoshi> sorry for tech support spamming
585 2020-12-14T20:51:57  <jonatack> probably not relevant but -generate is back, as client-side cli only, not rpc
586 2020-12-14T20:52:21  <jonatack> as a replacement for the former generate rpc
587 2020-12-14T20:53:26  *** potato <potato!~Thunderbi@240d:1a:3d4:7d00:902d:8574:a5b7:8124> has quit IRC (Ping timeout: 264 seconds)
588 2020-12-14T20:59:42  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
589 2020-12-14T21:01:39  <andytoshi> oh, that's good to know. though i'm fine using generatetoaddress
590 2020-12-14T21:02:12  <andytoshi> the discrepancy was just between `getblockcount` and the wallet view. i wonder if `getblockcount` should call SyncWithValidationInterfaceQueue()
591 2020-12-14T21:03:26  <sipa> i think a better long-term approach is giving the wallet its own getblockcount and related RPCs
592 2020-12-14T21:03:34  *** molz_ <molz_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
593 2020-12-14T21:03:52  <andytoshi> ah, yeah, i think that'd be cleaner and more performant
594 2020-12-14T21:05:50  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
595 2020-12-14T21:06:38  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 256 seconds)
596 2020-12-14T21:07:09  *** alko89 <alko89!~alko89@unaffiliated/alko89> has quit IRC (Quit: ZNC 1.7.5 - https://znc.in)
597 2020-12-14T21:08:32  *** molz_ <molz_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 272 seconds)
598 2020-12-14T21:09:50  *** alko89 <alko89!~alko89@unaffiliated/alko89> has joined #bitcoin-core-dev
599 2020-12-14T21:14:54  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Ping timeout: 256 seconds)
600 2020-12-14T21:27:48  *** alko89 <alko89!~alko89@unaffiliated/alko89> has quit IRC (Quit: ZNC 1.7.5 - https://znc.in)
601 2020-12-14T21:29:59  *** alko89 <alko89!~alko89@unaffiliated/alko89> has joined #bitcoin-core-dev
602 2020-12-14T21:34:50  *** alko89 <alko89!~alko89@unaffiliated/alko89> has quit IRC (Client Quit)
603 2020-12-14T21:38:01  *** alko89 <alko89!~alko89@unaffiliated/alko89> has joined #bitcoin-core-dev
604 2020-12-14T21:46:51  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
605 2020-12-14T21:51:34  *** miketwen_ <miketwen_!~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com> has quit IRC ()
606 2020-12-14T21:56:09  <wumpus> yes, that would make sense
607 2020-12-14T21:58:27  <wumpus> the node methods shouldn't depend on being synchronized with the wallet, but the wallet already needs to keep track of where it is in regard to synchronization with the node so exposing that in a RPC would make sense
608 2020-12-14T22:02:01  <wumpus> each wallet separately in case of multiple wallets
609 2020-12-14T22:03:57  *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
610 2020-12-14T22:06:43  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
611 2020-12-14T22:07:25  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 264 seconds)
612 2020-12-14T22:07:52  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
613 2020-12-14T22:10:59  *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
614 2020-12-14T22:11:02  *** Nolar <Nolar!~Nolar@178.162.209.171> has quit IRC (Remote host closed the connection)
615 2020-12-14T22:14:03  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Ping timeout: 240 seconds)
616 2020-12-14T22:14:58  <wumpus> these things mostly come up for the tests
617 2020-12-14T22:15:22  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
618 2020-12-14T22:22:43  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
619 2020-12-14T22:26:43  *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Ping timeout: 240 seconds)
620 2020-12-14T22:30:06  *** Guest7389 <Guest7389!~uptime@84.39.117.57> has joined #bitcoin-core-dev
621 2020-12-14T22:30:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
622 2020-12-14T22:30:24  <bitcoin-git> [bitcoin] dhruv opened pull request #20656: testing linting travis -> cirrus (master...travis-to-cirrus) https://github.com/bitcoin/bitcoin/pull/20656
623 2020-12-14T22:30:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
624 2020-12-14T22:32:32  *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
625 2020-12-14T22:32:56  *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
626 2020-12-14T22:33:15  <wumpus> luke-jr: any idea what QThreadPoolThread is? you have 64 of those too apparently
627 2020-12-14T22:33:50  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
628 2020-12-14T22:37:55  <wumpus> so 64 for mesa, 64 for qthreadpool, 15 for script validation makes 143 of 195, ~15 normal bitcoind threads, still missing about 40 but getting closer
629 2020-12-14T22:38:33  *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has joined #bitcoin-core-dev
630 2020-12-14T22:41:58  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 260 seconds)
631 2020-12-14T22:44:45  *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has quit IRC (Remote host closed the connection)
632 2020-12-14T22:49:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
633 2020-12-14T22:49:49  <bitcoin-git> [bitcoin] dhruv closed pull request #20656: testing linting travis -> cirrus (master...travis-to-cirrus) https://github.com/bitcoin/bitcoin/pull/20656
634 2020-12-14T22:49:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
635 2020-12-14T23:01:23  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has quit IRC (Ping timeout: 240 seconds)
636 2020-12-14T23:06:37  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
637 2020-12-14T23:11:25  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 240 seconds)
638 2020-12-14T23:11:30  <luke-jr> wumpus: no idea :/
639 2020-12-14T23:15:36  *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Ping timeout: 240 seconds)
640 2020-12-14T23:21:39  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
641 2020-12-14T23:38:36  *** joelklabo <joelklabo!~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: My iMac has gone to sleep. ZZZzzz…)
642 2020-12-14T23:54:04  *** joelklabo <joelklabo!~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev