1 2020-12-17T00:08:41  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Read error: Connection reset by peer)
  2 2020-12-17T00:11:53  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Read error: Connection reset by peer)
  3 2020-12-17T00:17:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
  4 2020-12-17T00:17:52  <bitcoin-git> [bitcoin] sh-abhi opened pull request #20678: Add on autoconf as a dependency when building on macOS (master...autoconf-dependency) https://github.com/bitcoin/bitcoin/pull/20678
  5 2020-12-17T00:17:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
  6 2020-12-17T00:29:09  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 268 seconds)
  7 2020-12-17T00:29:23  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
  8 2020-12-17T00:34:15  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo)
  9 2020-12-17T00:41:55  <jeremyrubin> sipa: andytoshi: I think it was just something about having templates declared in the header, and defined in the .cpp and not explicitly specialized was making this specific clang unhappy. Other versions seem to resolve it ok... so not sure what's up w/ that.
 10 2020-12-17T00:42:26  <jeremyrubin> for now I guess problem solved
 11 2020-12-17T00:50:59  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:313a:ef0a:c021:651e> has joined #bitcoin-core-dev
 12 2020-12-17T01:01:38  *** jesseposner <jesseposner!~jp@2601:645:200:162f:6076:878b:f936:e5fc> has joined #bitcoin-core-dev
 13 2020-12-17T01:03:47  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
 14 2020-12-17T01:03:49  *** jesseposner <jesseposner!~jp@2601:645:200:162f:6076:878b:f936:e5fc> has quit IRC (Client Quit)
 15 2020-12-17T01:04:14  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
 16 2020-12-17T01:08:47  *** lontivero <lontivero!~lontivero@> has joined #bitcoin-core-dev
 17 2020-12-17T01:09:31  *** Highway61 <Highway61!~Thunderbi@unaffiliated/highway61> has quit IRC (Remote host closed the connection)
 18 2020-12-17T01:16:29  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 19 2020-12-17T01:24:50  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:313a:ef0a:c021:651e> has quit IRC (*.net *.split)
 20 2020-12-17T01:24:51  *** hhghhkqweaeasd <hhghhkqweaeasd!~flack@p200300d46f24de0023b487635c149e9b.dip0.t-ipconnect.de> has quit IRC (*.net *.split)
 21 2020-12-17T01:24:52  *** infernix <infernix!~nix@unaffiliated/infernix> has quit IRC (*.net *.split)
 22 2020-12-17T01:24:52  *** amiti <amiti!sid373138@gateway/web/irccloud.com/x-ayunlkaefenrhtuj> has quit IRC (*.net *.split)
 23 2020-12-17T01:24:52  *** valwal_ <valwal_!sid334773@gateway/web/irccloud.com/x-xpdkkmqnrtcjkded> has quit IRC (*.net *.split)
 24 2020-12-17T01:24:52  *** Murch <Murch!murch@2a01:4f8:141:1272::2> has quit IRC (*.net *.split)
 25 2020-12-17T01:24:52  *** achow101 <achow101!~achow101@unaffiliated/achow101> has quit IRC (*.net *.split)
 26 2020-12-17T01:24:52  *** helo <helo!~helo@unaffiliated/helo> has quit IRC (*.net *.split)
 27 2020-12-17T01:24:52  *** phantomcircuit <phantomcircuit!~phantomci@2604:a880:1:20::f2:c001> has quit IRC (*.net *.split)
 28 2020-12-17T01:24:52  *** noganoo <noganoo!sid146237@gateway/web/irccloud.com/x-jiqyxyrhvhhqazvk> has quit IRC (*.net *.split)
 29 2020-12-17T01:24:53  *** mmitech___ <mmitech___!sid446259@gateway/web/irccloud.com/x-ideapfjkegfyrwja> has quit IRC (*.net *.split)
 30 2020-12-17T01:24:53  *** RubenSomsen <RubenSomsen!sid301948@gateway/web/irccloud.com/x-xiafkyvtjtuehoop> has quit IRC (*.net *.split)
 31 2020-12-17T01:24:53  *** ccook <ccook!sid271969@gateway/web/irccloud.com/x-mqvxcsnxamgitclb> has quit IRC (*.net *.split)
 32 2020-12-17T01:24:53  *** takinbo <takinbo!~takinbo@unaffiliated/takinbo> has quit IRC (*.net *.split)
 33 2020-12-17T01:24:53  *** michaelfolkson <michaelfolkson!~michaelfo@2a03:b0c0:1:e0::23d:d001> has quit IRC (*.net *.split)
 34 2020-12-17T01:24:53  *** windsok <windsok!~windsok@unaffiliated/windsok> has quit IRC (*.net *.split)
 35 2020-12-17T01:24:53  *** real_or_random <real_or_random!~real_or_r@2a02:c207:3002:7468::1> has quit IRC (*.net *.split)
 36 2020-12-17T01:30:10  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:313a:ef0a:c021:651e> has joined #bitcoin-core-dev
 37 2020-12-17T01:30:10  *** hhghhkqweaeasd <hhghhkqweaeasd!~flack@p200300d46f24de0023b487635c149e9b.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
 38 2020-12-17T01:30:10  *** infernix <infernix!~nix@unaffiliated/infernix> has joined #bitcoin-core-dev
 39 2020-12-17T01:30:10  *** valwal_ <valwal_!sid334773@gateway/web/irccloud.com/x-xpdkkmqnrtcjkded> has joined #bitcoin-core-dev
 40 2020-12-17T01:30:10  *** amiti <amiti!sid373138@gateway/web/irccloud.com/x-ayunlkaefenrhtuj> has joined #bitcoin-core-dev
 41 2020-12-17T01:30:10  *** Murch <Murch!murch@2a01:4f8:141:1272::2> has joined #bitcoin-core-dev
 42 2020-12-17T01:30:10  *** achow101 <achow101!~achow101@unaffiliated/achow101> has joined #bitcoin-core-dev
 43 2020-12-17T01:30:10  *** helo <helo!~helo@unaffiliated/helo> has joined #bitcoin-core-dev
 44 2020-12-17T01:30:10  *** phantomcircuit <phantomcircuit!~phantomci@2604:a880:1:20::f2:c001> has joined #bitcoin-core-dev
 45 2020-12-17T01:30:10  *** noganoo <noganoo!sid146237@gateway/web/irccloud.com/x-jiqyxyrhvhhqazvk> has joined #bitcoin-core-dev
 46 2020-12-17T01:30:10  *** mmitech___ <mmitech___!sid446259@gateway/web/irccloud.com/x-ideapfjkegfyrwja> has joined #bitcoin-core-dev
 47 2020-12-17T01:30:10  *** RubenSomsen <RubenSomsen!sid301948@gateway/web/irccloud.com/x-xiafkyvtjtuehoop> has joined #bitcoin-core-dev
 48 2020-12-17T01:30:10  *** ccook <ccook!sid271969@gateway/web/irccloud.com/x-mqvxcsnxamgitclb> has joined #bitcoin-core-dev
 49 2020-12-17T01:30:10  *** takinbo <takinbo!~takinbo@unaffiliated/takinbo> has joined #bitcoin-core-dev
 50 2020-12-17T01:30:10  *** michaelfolkson <michaelfolkson!~michaelfo@2a03:b0c0:1:e0::23d:d001> has joined #bitcoin-core-dev
 51 2020-12-17T01:30:10  *** windsok <windsok!~windsok@unaffiliated/windsok> has joined #bitcoin-core-dev
 52 2020-12-17T01:30:10  *** real_or_random <real_or_random!~real_or_r@2a02:c207:3002:7468::1> has joined #bitcoin-core-dev
 53 2020-12-17T01:33:20  *** instagibbs <instagibbs!~greg@061093103011.ctinets.com> has quit IRC (Ping timeout: 256 seconds)
 54 2020-12-17T01:36:20  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
 55 2020-12-17T01:36:21  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
 56 2020-12-17T01:36:23  *** vasild_ is now known as vasild
 57 2020-12-17T01:38:28  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Quit: Leaving)
 58 2020-12-17T01:44:02  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Quit: Leaving)
 59 2020-12-17T01:52:52  *** potato <potato!~Thunderbi@240d:1a:3d4:7d00:e8f9:dc3f:1a8d:3976> has joined #bitcoin-core-dev
 60 2020-12-17T01:55:42  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
 61 2020-12-17T01:58:00  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
 62 2020-12-17T01:58:46  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 63 2020-12-17T02:26:02  <dhruvm> CI re-run please? https://cirrus-ci.com/task/5046307649748992
 64 2020-12-17T02:51:28  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
 65 2020-12-17T02:52:31  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 246 seconds)
 66 2020-12-17T02:54:06  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
 67 2020-12-17T03:01:30  *** jesseposner <jesseposner!~jp@2601:645:200:162f:a05d:e05c:c95e:bea7> has joined #bitcoin-core-dev
 68 2020-12-17T03:03:02  *** pinheadmz <pinheadmz!~pinheadmz@> has quit IRC (Quit: pinheadmz)
 69 2020-12-17T03:07:03  *** pinheadmz <pinheadmz!~pinheadmz@> has joined #bitcoin-core-dev
 70 2020-12-17T03:09:04  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:313a:ef0a:c021:651e> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 71 2020-12-17T03:11:29  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:bc4d:596d:63fe:f2dd> has joined #bitcoin-core-dev
 72 2020-12-17T03:21:17  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:bc4d:596d:63fe:f2dd> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 73 2020-12-17T03:23:44  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:bc4d:596d:63fe:f2dd> has joined #bitcoin-core-dev
 74 2020-12-17T03:46:34  *** pinheadmz <pinheadmz!~pinheadmz@> has quit IRC (Read error: Connection reset by peer)
 75 2020-12-17T03:49:17  *** pinheadmz <pinheadmz!~pinheadmz@> has joined #bitcoin-core-dev
 76 2020-12-17T03:53:16  *** davterra <davterra!~davterra@> has quit IRC (Ping timeout: 268 seconds)
 77 2020-12-17T03:55:03  *** onokatio <onokatio!~Thunderbi@> has joined #bitcoin-core-dev
 78 2020-12-17T03:55:38  *** onokatio <onokatio!~Thunderbi@> has quit IRC (Client Quit)
 79 2020-12-17T04:17:32  *** hirish <hirish!~hirish@ip85.ip-137-74-20.eu> has joined #bitcoin-core-dev
 80 2020-12-17T04:18:14  *** hirish_ <hirish_!~hirish@ip85.ip-137-74-20.eu> has quit IRC (Ping timeout: 256 seconds)
 81 2020-12-17T04:21:43  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:bc4d:596d:63fe:f2dd> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
 82 2020-12-17T04:37:59  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:c08f:f3d8:5294:ef76> has joined #bitcoin-core-dev
 83 2020-12-17T04:54:04  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
 84 2020-12-17T05:17:12  *** Guest98077 <Guest98077!~meoblast0@> has quit IRC (Remote host closed the connection)
 85 2020-12-17T05:19:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 86 2020-12-17T05:19:12  <bitcoin-git> [bitcoin] fanquake closed pull request #20504: build: use more legible (q)make commands in qt package (master...legible_qt_config_cmds) https://github.com/bitcoin/bitcoin/pull/20504
 87 2020-12-17T05:19:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 88 2020-12-17T05:30:10  *** miketwenty1 <miketwenty1!~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com> has quit IRC (Remote host closed the connection)
 89 2020-12-17T05:34:43  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
 90 2020-12-17T05:36:48  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 91 2020-12-17T05:37:20  *** Guest60747 <Guest60747!~geekosaur@> has joined #bitcoin-core-dev
 92 2020-12-17T05:38:03  <fanquake> It's strange how people fight against dropping support for versions of macOS (at the potential detriment of the rest of the project), while at the same time seemingly have no issue with dropping support for versions of operating systems that are almost certainly used by more Bitcoin Core users, and/or are supported for far longer into the future.
 93 2020-12-17T05:39:27  <gwillen> I assume people mostly fight in favor of supporting OSes they use themselves
 94 2020-12-17T05:39:52  <gwillen> I don't know how far back with go with macOS, but e.g. I'm on 10.14.6, so if that got dropped I basically couldn't use or work on the project anymore
 95 2020-12-17T05:40:09  <sipa> fanquake: which one are people discussing dropping?
 96 2020-12-17T05:40:43  <fanquake> sipa: https://github.com/bitcoin/bitcoin/issues/20627#issuecomment-747216439 moving to using Qt 6 would drop support for Windows 7 & 8.x, as well as Ubuntu 18.04.
 97 2020-12-17T05:42:56  <sipa> fanquake: i thought it was just a suggested or build dependency
 98 2020-12-17T05:43:30  <sipa> if it breaks window 8 / ubuntu 18.04 that seems like a no go
 99 2020-12-17T05:43:40  <sipa> could we use qt6 for osx, and qt5 for the rest?
100 2020-12-17T05:43:53  <sipa> *macos
101 2020-12-17T05:45:34  <gwillen> it seems that dongcarl doesn't think it would break those platforms, judging from his comment -- it seems like there is some question as to what exactly Qt6 claims to support / actually supports
102 2020-12-17T05:46:15  <fanquake> sipa: as far as I know those are runtime requirements
103 2020-12-17T05:46:37  <sipa> well we'd need to know
104 2020-12-17T05:46:46  <fanquake> Me and Carl also discussed in the builds channel this morning
105 2020-12-17T05:50:07  <sipa> if it's easy for source to be compatible with both it may make sense to use qt6 on macos depends builds, and qt5 for others
106 2020-12-17T05:52:49  <luke-jr> well we need to support building with Qt5 anyway
107 2020-12-17T05:53:03  <luke-jr> it'll be a while before distros deploy Qt6
108 2020-12-17T05:56:13  <dhruvm> May I request a CI re-run? https://cirrus-ci.com/task/5046307649748992
109 2020-12-17T05:56:35  <dhruvm> (If there's another easier than to ask here, please let me know)
110 2020-12-17T05:56:47  <dhruvm> *another easier way
111 2020-12-17T05:56:53  <sipa> done
112 2020-12-17T05:57:08  <sipa> not sure what's needed to give people permission to restart cirrus
113 2020-12-17T05:57:39  <fanquake> Not even sure if I can restart Cirrus at the moment 😅
114 2020-12-17T05:57:49  *** lontivero <lontivero!~lontivero@> has quit IRC (Ping timeout: 264 seconds)
115 2020-12-17T05:58:04  <dhruvm> I am in the right place then :D
116 2020-12-17T06:00:43  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Ping timeout: 240 seconds)
117 2020-12-17T06:03:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
118 2020-12-17T06:03:32  <bitcoin-git> [bitcoin] fanquake closed pull request #20600: Depends : Qt Use Top-Level Structure (master...add-qml-depends) https://github.com/bitcoin/bitcoin/pull/20600
119 2020-12-17T06:03:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
120 2020-12-17T06:04:27  *** Guest60747 <Guest60747!~geekosaur@> has quit IRC (Remote host closed the connection)
121 2020-12-17T06:10:06  *** Guest58575 <Guest58575!~ds@> has joined #bitcoin-core-dev
122 2020-12-17T06:11:18  *** IGHOR <IGHOR!~quassel@> has quit IRC (Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.)
123 2020-12-17T06:19:57  *** IGHOR <IGHOR!~quassel@> has joined #bitcoin-core-dev
124 2020-12-17T06:28:06  *** mrostecki <mrostecki!mrostecki@nat/suse/x-wasokcvpgafclwxo> has quit IRC (Quit: WeeChat 1.8)
125 2020-12-17T06:43:01  <MarcoFalke> I think to reset Cirrus CI, you'd need to be added to the Bitcoin Core project and then authed on Cirrus via GitHub
126 2020-12-17T07:06:26  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:c08f:f3d8:5294:ef76> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
127 2020-12-17T07:12:27  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
128 2020-12-17T07:13:06  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
129 2020-12-17T07:15:43  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
130 2020-12-17T07:16:03  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
131 2020-12-17T07:17:01  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
132 2020-12-17T07:17:07  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
133 2020-12-17T07:20:31  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@> has joined #bitcoin-core-dev
134 2020-12-17T07:24:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
135 2020-12-17T07:24:01  <bitcoin-git> [bitcoin] rex4539 opened pull request #20679: Fix insecure links (master...https) https://github.com/bitcoin/bitcoin/pull/20679
136 2020-12-17T07:24:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
137 2020-12-17T07:24:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
138 2020-12-17T07:24:56  <bitcoin-git> [bitcoin] fanquake closed pull request #20679: Fix insecure links (master...https) https://github.com/bitcoin/bitcoin/pull/20679
139 2020-12-17T07:24:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
140 2020-12-17T07:36:43  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
141 2020-12-17T07:36:44  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
142 2020-12-17T07:37:32  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
143 2020-12-17T07:37:37  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
144 2020-12-17T07:45:28  *** Mercury_Vapor <Mercury_Vapor!~Mercury_V@174-082-166-092.res.spectrum.com> has quit IRC (Read error: Connection reset by peer)
145 2020-12-17T07:46:38  *** Mercury_Vapor <Mercury_Vapor!~Mercury_V@174-082-166-092.res.spectrum.com> has joined #bitcoin-core-dev
146 2020-12-17T08:05:32  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
147 2020-12-17T08:06:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
148 2020-12-17T08:06:42  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1811e488d53b...6f2ca726ce2e
149 2020-12-17T08:06:43  <bitcoin-git> bitcoin/master 739d390 Dhruv Mehta: ci: Move linter task to cirrus
150 2020-12-17T08:06:43  <bitcoin-git> bitcoin/master 4045a67 Dhruv Mehta: ci: Use cpu=1 for linter
151 2020-12-17T08:06:44  <bitcoin-git> bitcoin/master 6f2ca72 MarcoFalke: Merge #20658: ci: Move linter task to cirrus
152 2020-12-17T08:06:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
153 2020-12-17T08:07:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
154 2020-12-17T08:07:02  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20658: ci: Move linter task to cirrus (master...linter-on-cirrus) https://github.com/bitcoin/bitcoin/pull/20658
155 2020-12-17T08:07:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
156 2020-12-17T08:28:21  <jonasschnelli> sipa: ChaCha20::Crypt is the same if I do ChaCha20::Keystream and then manually xor the message with the keystream? I somehow are confused about x0 ^= ReadLE32(m + 0); (since this writes back to the state?)
157 2020-12-17T08:29:13  <jonasschnelli> I debugged it and it is indeed the same just the x0 ^= confuses me
158 2020-12-17T08:31:37  <sipa> yes
159 2020-12-17T08:35:14  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
160 2020-12-17T08:35:14  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20680: ci: Only use credits for pull requests to the main repo (master...2012-ciCredits) https://github.com/bitcoin/bitcoin/pull/20680
161 2020-12-17T08:35:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
162 2020-12-17T08:54:14  *** instagibbs <instagibbs!~greg@061093103011.ctinets.com> has joined #bitcoin-core-dev
163 2020-12-17T08:55:30  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
164 2020-12-17T09:01:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
165 2020-12-17T09:01:39  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6f2ca726ce2e...8452f922d211
166 2020-12-17T09:01:40  <bitcoin-git> bitcoin/master 5c3eaf9 Fabian Jahr: doc: Add warnings for http interfaces limitations
167 2020-12-17T09:01:40  <bitcoin-git> bitcoin/master 8452f92 MarcoFalke: Merge #19050: doc: Add warning for rest interface limitation
168 2020-12-17T09:01:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
169 2020-12-17T09:01:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
170 2020-12-17T09:01:59  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19050: doc: Add warning for rest interface limitation (master...rest_fd) https://github.com/bitcoin/bitcoin/pull/19050
171 2020-12-17T09:02:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
172 2020-12-17T09:13:43  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Ping timeout: 240 seconds)
173 2020-12-17T09:13:51  *** muoitran <muoitran!76c811dd@> has joined #bitcoin-core-dev
174 2020-12-17T09:21:38  *** muoitran <muoitran!76c811dd@> has quit IRC (Remote host closed the connection)
175 2020-12-17T09:24:07  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
176 2020-12-17T09:26:50  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
177 2020-12-17T09:33:18  *** raf <raf!d203558e@> has joined #bitcoin-core-dev
178 2020-12-17T09:33:39  *** raf <raf!d203558e@> has quit IRC (Remote host closed the connection)
179 2020-12-17T09:40:53  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
180 2020-12-17T09:42:25  *** RusAlex <RusAlex!~Chel@unaffiliated/rusalex> has quit IRC (Ping timeout: 240 seconds)
181 2020-12-17T09:42:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
182 2020-12-17T09:42:54  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8452f922d211...83abd6b126c2
183 2020-12-17T09:42:55  <bitcoin-git> bitcoin/master facf5e3 MarcoFalke: ci: Only use credits for pull requests to the main repo
184 2020-12-17T09:42:55  <bitcoin-git> bitcoin/master 83abd6b MarcoFalke: Merge #20680: ci: Only use credits for pull requests to the main repo
185 2020-12-17T09:42:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
186 2020-12-17T09:43:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
187 2020-12-17T09:43:13  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20680: ci: Only use credits for pull requests to the main repo (master...2012-ciCredits) https://github.com/bitcoin/bitcoin/pull/20680
188 2020-12-17T09:43:14  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
189 2020-12-17T09:43:41  *** RusAlex <RusAlex!~Chel@unaffiliated/rusalex> has joined #bitcoin-core-dev
190 2020-12-17T09:54:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
191 2020-12-17T09:54:44  <bitcoin-git> [gui] MarcoFalke merged pull request #153: Define MAX_DIGITS_BTC for magic number in BitcoinUnits::format (master...const_max_digits) https://github.com/bitcoin-core/gui/pull/153
192 2020-12-17T09:54:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
193 2020-12-17T09:55:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
194 2020-12-17T09:55:04  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/83abd6b126c2...d0e76b5050a2
195 2020-12-17T09:55:04  <bitcoin-git> bitcoin/master 198fff8 Luke Dashjr: GUI: Define MAX_DIGITS_BTC for magic number in BitcoinUnits::format
196 2020-12-17T09:55:05  <bitcoin-git> bitcoin/master d0e76b5 MarcoFalke: Merge bitcoin-core/gui#153: Define MAX_DIGITS_BTC for magic number in Bitc...
197 2020-12-17T09:55:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
198 2020-12-17T09:59:53  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Quit: Pavlenex)
199 2020-12-17T10:05:07  *** kexkey <kexkey!~kexkey@static-198-54-132-94.cust.tzulo.com> has quit IRC (Ping timeout: 268 seconds)
200 2020-12-17T10:11:48  <wumpus> MarcoFalke: i think we should leave it for 0.21.1
201 2020-12-17T10:11:59  <wumpus> MarcoFalke: focus on what is really critical for 0.21.0 and just get it out of the door
202 2020-12-17T10:13:51  <wumpus> if it's a regression it needs to be fixed in a rc, otherwise let's make it wait for 0.21.1
203 2020-12-17T10:23:50  <wumpus> regarding Qt5 and Qt6 i think we should aim to be compatible with both in the forseeable future
204 2020-12-17T10:24:42  <hebasto> as Qt4 and Qt5 were?
205 2020-12-17T10:24:44  <wumpus> the transition period for Qt4/Qt5 was pretty long as well and I don't expect it to be different this time. I don't know how difficult this is in practice though.
206 2020-12-17T10:24:47  <wumpus> correct!
207 2020-12-17T10:31:32  *** queip <queip!~queip@unaffiliated/rezurus> has quit IRC (Ping timeout: 260 seconds)
208 2020-12-17T10:34:05  <wumpus> please, if you write md documents (especially install instructions) keep them readable in the terminal; preferably don't use HTML, "Dependency Options" in depends/README.md is hard to read when viewing it in "less" or "vim"
209 2020-12-17T10:37:19  *** potato <potato!~Thunderbi@240d:1a:3d4:7d00:e8f9:dc3f:1a8d:3976> has quit IRC (Quit: potato)
210 2020-12-17T10:40:04  *** miketwenty1 <miketwenty1!~miketwent@> has joined #bitcoin-core-dev
211 2020-12-17T10:40:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
212 2020-12-17T10:40:49  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/d0e76b5050a2...7ef6b1c51d4a
213 2020-12-17T10:40:49  <bitcoin-git> bitcoin/master e1765d8 Jon Atack: doc: update tor.md address examples from onion v2 to v3
214 2020-12-17T10:40:50  <bitcoin-git> bitcoin/master dc8a591 Jon Atack: doc: add tor.md section on how to get tor info via bitcoind
215 2020-12-17T10:40:50  <bitcoin-git> bitcoin/master a34eceb Jon Atack: doc: update -externalip documentation in tor.md
216 2020-12-17T10:40:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
217 2020-12-17T10:41:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
218 2020-12-17T10:41:09  <bitcoin-git> [bitcoin] laanwj merged pull request #19961: doc: tor.md updates (master...update-tor-md) https://github.com/bitcoin/bitcoin/pull/19961
219 2020-12-17T10:41:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
220 2020-12-17T10:42:01  <wumpus> going to file a PR to reformat it
221 2020-12-17T10:43:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
222 2020-12-17T10:43:52  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #20083: p2p: Disconnect, not discourage, misbehaving NODE_BLOOM peers (master...2010-p2pBloomPeer) https://github.com/bitcoin/bitcoin/pull/20083
223 2020-12-17T10:43:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
224 2020-12-17T10:44:38  *** miketwenty1 <miketwenty1!~miketwent@> has quit IRC (Ping timeout: 260 seconds)
225 2020-12-17T10:50:19  *** queip <queip!~queip@unaffiliated/rezurus> has joined #bitcoin-core-dev
226 2020-12-17T10:53:13  *** mrostecki <mrostecki!mrostecki@nat/suse/x-rgficojmxnxsfgtc> has joined #bitcoin-core-dev
227 2020-12-17T10:53:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
228 2020-12-17T10:53:47  <bitcoin-git> [bitcoin] laanwj opened pull request #20681: doc: Convert depends options list from html to markdown (master...2020_12_dependdoc) https://github.com/bitcoin/bitcoin/pull/20681
229 2020-12-17T10:53:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
230 2020-12-17T11:00:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
231 2020-12-17T11:00:29  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7ef6b1c51d4a...f0913f2f950c
232 2020-12-17T11:00:30  <bitcoin-git> bitcoin/master 0c41c10 Suhas Daftuar: doc: Remove shouty enums in net_processing comments
233 2020-12-17T11:00:30  <bitcoin-git> bitcoin/master f0913f2 Wladimir J. van der Laan: Merge #20677: doc: Remove shouty enums in net_processing comments
234 2020-12-17T11:00:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
235 2020-12-17T11:00:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
236 2020-12-17T11:00:48  <bitcoin-git> [bitcoin] laanwj merged pull request #20677: doc: Remove shouty enums in net_processing comments (master...2020-12-remove-shouty-enums) https://github.com/bitcoin/bitcoin/pull/20677
237 2020-12-17T11:00:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
238 2020-12-17T11:03:09  *** miketwenty1 <miketwenty1!~miketwent@> has joined #bitcoin-core-dev
239 2020-12-17T11:03:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
240 2020-12-17T11:03:57  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20682: ci: Install missing lint packages (master...2012-testDel) https://github.com/bitcoin/bitcoin/pull/20682
241 2020-12-17T11:03:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
242 2020-12-17T11:07:10  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
243 2020-12-17T11:07:21  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:4940:8dd3:7c10:4404> has joined #bitcoin-core-dev
244 2020-12-17T11:08:01  *** miketwenty1 <miketwenty1!~miketwent@> has quit IRC (Ping timeout: 268 seconds)
245 2020-12-17T11:10:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
246 2020-12-17T11:10:47  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f0913f2f950c...cfbfd389f6dd
247 2020-12-17T11:10:47  <bitcoin-git> bitcoin/master 010eed3 Adam Jonas: doc: warn that incoming conns are unlikely when not using default ports
248 2020-12-17T11:10:48  <bitcoin-git> bitcoin/master cfbfd38 Wladimir J. van der Laan: Merge #20668: doc: warn that incoming conns are unlikely when not using de...
249 2020-12-17T11:10:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
250 2020-12-17T11:11:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
251 2020-12-17T11:11:07  <bitcoin-git> [bitcoin] laanwj merged pull request #20668: doc: warn that incoming conns are unlikely when not using default ports (master...121520-non-standard-port-doc) https://github.com/bitcoin/bitcoin/pull/20668
252 2020-12-17T11:11:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
253 2020-12-17T11:14:09  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Quit: Pavlenex)
254 2020-12-17T11:14:09  *** promag <promag!~promag@> has quit IRC (Read error: Connection reset by peer)
255 2020-12-17T11:14:17  *** promag <promag!~promag@> has joined #bitcoin-core-dev
256 2020-12-17T11:18:33  *** Della9Cole <Della9Cole!~Della9Col@static.> has joined #bitcoin-core-dev
257 2020-12-17T11:23:34  *** Della9Cole <Della9Cole!~Della9Col@static.> has quit IRC (Ping timeout: 256 seconds)
258 2020-12-17T11:35:55  *** vincenzopalazzo <vincenzopalazzo!~vincent@2001:b07:6474:9d49:7de2:ea26:22ca:4ba0> has joined #bitcoin-core-dev
259 2020-12-17T11:55:26  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
260 2020-12-17T11:56:17  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
261 2020-12-17T11:57:03  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Read error: Connection reset by peer)
262 2020-12-17T12:01:35  *** davterra <davterra!~davterra@> has joined #bitcoin-core-dev
263 2020-12-17T12:02:22  *** davterra <davterra!~davterra@> has quit IRC (Client Quit)
264 2020-12-17T12:02:42  *** davterra <davterra!~davterra@> has joined #bitcoin-core-dev
265 2020-12-17T12:03:57  *** davterra <davterra!~davterra@> has quit IRC (Remote host closed the connection)
266 2020-12-17T12:05:02  *** davterra <davterra!~davterra@> has joined #bitcoin-core-dev
267 2020-12-17T12:05:57  *** davterra <davterra!~davterra@> has quit IRC (Remote host closed the connection)
268 2020-12-17T12:10:02  *** davterra <davterra!~davterra@> has joined #bitcoin-core-dev
269 2020-12-17T12:11:29  *** davterra <davterra!~davterra@> has quit IRC (Remote host closed the connection)
270 2020-12-17T12:11:54  *** davterra <davterra!~davterra@> has joined #bitcoin-core-dev
271 2020-12-17T12:12:46  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 268 seconds)
272 2020-12-17T12:14:48  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
273 2020-12-17T12:16:44  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
274 2020-12-17T12:17:29  *** davterra <davterra!~davterra@> has quit IRC (Remote host closed the connection)
275 2020-12-17T12:25:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
276 2020-12-17T12:25:04  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20683: test: Fix restart node race (master...2012-testNodeStart) https://github.com/bitcoin/bitcoin/pull/20683
277 2020-12-17T12:25:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
278 2020-12-17T12:28:39  <MarcoFalke> Makefile.am:335: warning: .INTERMEDIATE was already defined in condition !BUILD_DARWIN, which is included in condition TRUE ...
279 2020-12-17T12:28:47  <MarcoFalke> looks like a new warning
280 2020-12-17T12:29:33  <hebasto> MarcoFalke: ^ testing a fix already
281 2020-12-17T12:30:20  <wumpus> haven't seen it yet but that doesn't sound good
282 2020-12-17T12:30:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
283 2020-12-17T12:30:48  <bitcoin-git> [bitcoin] hebasto opened pull request #20684: build: Define .INTERMEDIATE target once only (master...201217-target) https://github.com/bitcoin/bitcoin/pull/20684
284 2020-12-17T12:30:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
285 2020-12-17T12:33:58  *** davterra <davterra!~davterra@> has joined #bitcoin-core-dev
286 2020-12-17T12:36:02  *** davterra <davterra!~davterra@> has quit IRC (Remote host closed the connection)
287 2020-12-17T12:45:59  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo)
288 2020-12-17T12:49:04  <hebasto> wumpus: i'm confused by your https://github.com/bitcoin/bitcoin/pull/20678#issuecomment-747406247 -- did you ack for explicit mention of autoconf?
289 2020-12-17T12:49:51  <jonasschnelli> Yeah. I guess wumpus ACK was slipped in too fast
290 2020-12-17T12:49:54  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
291 2020-12-17T12:49:56  *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
292 2020-12-17T12:50:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
293 2020-12-17T12:50:13  <bitcoin-git> [bitcoin] vasild opened pull request #20685: Add I2P support using I2P SAM (master...i2p_sam) https://github.com/bitcoin/bitcoin/pull/20685
294 2020-12-17T12:50:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
295 2020-12-17T12:51:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
296 2020-12-17T12:51:08  <bitcoin-git> [bitcoin] vasild closed pull request #20254: Add I2P support using statically configured destinations (master...i2p_static) https://github.com/bitcoin/bitcoin/pull/20254
297 2020-12-17T12:51:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
298 2020-12-17T12:56:03  <wumpus> hebasto: wait, I misunderstood your commen
299 2020-12-17T12:56:41  <hebasto> wumpus: sorry for my misleading comment
300 2020-12-17T12:56:57  <wumpus> np, thanks for mentioning it here, retracted my ACK
301 2020-12-17T12:59:52  *** Legousk <Legousk!~Henkie@178-84-68-9.dynamic.upc.nl> has joined #bitcoin-core-dev
302 2020-12-17T13:00:54  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:4940:8dd3:7c10:4404> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
303 2020-12-17T13:09:17  *** sr_gi <sr_gi!~sr_gi@> has quit IRC (Read error: Connection reset by peer)
304 2020-12-17T13:09:46  *** sr_gi <sr_gi!~sr_gi@> has joined #bitcoin-core-dev
305 2020-12-17T13:17:33  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
306 2020-12-17T13:25:23  *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has quit IRC (Ping timeout: 240 seconds)
307 2020-12-17T13:33:10  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:4940:8dd3:7c10:4404> has joined #bitcoin-core-dev
308 2020-12-17T13:36:10  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
309 2020-12-17T13:36:11  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
310 2020-12-17T13:36:11  *** vasild_ is now known as vasild
311 2020-12-17T13:37:18  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:4940:8dd3:7c10:4404> has quit IRC (Client Quit)
312 2020-12-17T13:38:03  *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
313 2020-12-17T13:44:36  *** molz_ <molz_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
314 2020-12-17T13:46:34  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:4940:8dd3:7c10:4404> has joined #bitcoin-core-dev
315 2020-12-17T13:48:04  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 256 seconds)
316 2020-12-17T13:49:23  *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has quit IRC (Ping timeout: 240 seconds)
317 2020-12-17T13:51:44  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
318 2020-12-17T13:52:56  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
319 2020-12-17T13:53:17  *** instagibbs <instagibbs!~greg@061093103011.ctinets.com> has quit IRC (Ping timeout: 268 seconds)
320 2020-12-17T13:55:08  *** molz_ <molz_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 268 seconds)
321 2020-12-17T13:56:13  <hebasto> wumpus: MarcoFalke: please remove spam https://github.com/bitcoin/bitcoin/pull/20658#issuecomment-747452862
322 2020-12-17T13:56:22  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 268 seconds)
323 2020-12-17T13:59:23  <wumpus> hebasto: done
324 2020-12-17T13:59:29  *** instagibbs <instagibbs!~greg@061093103011.ctinets.com> has joined #bitcoin-core-dev
325 2020-12-17T14:02:39  *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
326 2020-12-17T14:06:31  <hebasto> wumpus: thanks
327 2020-12-17T14:06:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
328 2020-12-17T14:06:57  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cfbfd389f6dd...af4ce674dafa
329 2020-12-17T14:06:58  <bitcoin-git> bitcoin/master cc3044c pox: fix misleading comment about call to non-existing function
330 2020-12-17T14:06:58  <bitcoin-git> bitcoin/master af4ce67 Wladimir J. van der Laan: Merge #20635: fix misleading comment about call to non-existing function
331 2020-12-17T14:07:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
332 2020-12-17T14:07:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
333 2020-12-17T14:07:19  <bitcoin-git> [bitcoin] laanwj merged pull request #20635: fix misleading comment about call to non-existing function (master...master) https://github.com/bitcoin/bitcoin/pull/20635
334 2020-12-17T14:07:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
335 2020-12-17T14:14:43  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
336 2020-12-17T14:19:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
337 2020-12-17T14:19:55  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/af4ce674dafa...143bd108ed66
338 2020-12-17T14:19:56  <bitcoin-git> bitcoin/master e1e7a90 Andrew Chow: wallettool: Add dump command
339 2020-12-17T14:19:57  <bitcoin-git> bitcoin/master a88c320 Andrew Chow: wallettool: Add createfromdump command
340 2020-12-17T14:19:58  <bitcoin-git> bitcoin/master 23cac24 Andrew Chow: tests: Test bitcoin-wallet dump and createfromdump
341 2020-12-17T14:19:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
342 2020-12-17T14:20:14  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
343 2020-12-17T14:20:14  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19137: wallettool: Add dump and createfromdump commands (master...dumpwalletrecords) https://github.com/bitcoin/bitcoin/pull/19137
344 2020-12-17T14:20:16  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
345 2020-12-17T14:23:15  *** lontivero <lontivero!~lontivero@> has joined #bitcoin-core-dev
346 2020-12-17T14:24:03  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
347 2020-12-17T14:26:29  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
348 2020-12-17T14:38:58  *** miketwenty1 <miketwenty1!~miketwent@> has joined #bitcoin-core-dev
349 2020-12-17T14:41:17  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
350 2020-12-17T14:41:24  <wumpus> I'm testing #18077, I have NAT-PMP enabled on my router but get "natpmp: The gateway does not support NAT-PMP."
351 2020-12-17T14:41:28  <gribble> https://github.com/bitcoin/bitcoin/issues/18077 | net: Add NAT-PMP port forwarding support by hebasto · Pull Request #18077 · bitcoin/bitcoin · GitHub
352 2020-12-17T14:41:37  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo)
353 2020-12-17T14:42:25  <hebasto> which router?
354 2020-12-17T14:42:37  <wumpus> my policy allows mapping high ports 1024-65535, denies the rest, but this should be enough for bitcoin
355 2020-12-17T14:42:43  <wumpus> Turris Omnia
356 2020-12-17T14:42:49  <wumpus> openWRT-ish
357 2020-12-17T14:43:13  <hebasto> what in openwrt log?
358 2020-12-17T14:43:25  *** miketwenty1 <miketwenty1!~miketwent@> has quit IRC (Ping timeout: 264 seconds)
359 2020-12-17T14:45:06  <wumpus> I don't see anything related in the log, will try if I can enable verbose logging somehow
360 2020-12-17T14:46:37  <wumpus> OOHH never mind I think I have it
361 2020-12-17T14:46:40  *** miketwenty1 <miketwenty1!~miketwent@> has joined #bitcoin-core-dev
362 2020-12-17T14:47:01  <hebasto> natpmp connection?
363 2020-12-17T14:49:32  <jonasschnelli> Review bag for https://github.com/bitcoin/bitcoin/pull/20273 (concept ACK/NACK). Helps me to decide if I should drag that PR along. I really like the functionality of nested commands in CLI.
364 2020-12-17T14:50:21  <wumpus> unfortunately still not, but found one setting that was blocking it from working
365 2020-12-17T14:50:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
366 2020-12-17T14:50:26  <bitcoin-git> [gui] goums opened pull request #154: qt: Colorize icons on macOS for Dark mode support (master...macos_color_icons) https://github.com/bitcoin-core/gui/pull/154
367 2020-12-17T14:50:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
368 2020-12-17T14:54:01  <wumpus> in any case it's probably not a problem with your code; i don't see anything upnp related in the log, for some reason it doesn't seem to be launching
369 2020-12-17T15:02:43  *** miketwenty1 <miketwenty1!~miketwent@> has quit IRC (Remote host closed the connection)
370 2020-12-17T15:03:27  *** miketwenty1 <miketwenty1!~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com> has joined #bitcoin-core-dev
371 2020-12-17T15:05:59  <wumpus> was this problem: https://forum.turris.cz/t/upnp-server-not-running/9544/2
372 2020-12-17T15:06:36  <wumpus> 2020-12-17T15:06:10Z natpmp: Port mapping successful. External address = x.x.x.x:18444
373 2020-12-17T15:06:39  <wumpus> nice!
374 2020-12-17T15:07:56  <hebasto> \o/
375 2020-12-17T15:08:46  <vasild> what a strange address, is this some porn site?
376 2020-12-17T15:11:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
377 2020-12-17T15:11:22  <bitcoin-git> [bitcoin] lontivero closed pull request #20662: Allow setting I2P addresses (master...set-i2p) https://github.com/bitcoin/bitcoin/pull/20662
378 2020-12-17T15:11:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
379 2020-12-17T15:14:22  <wumpus> heh :)
380 2020-12-17T15:16:16  *** lontivero <lontivero!~lontivero@> has quit IRC (Ping timeout: 240 seconds)
381 2020-12-17T15:22:27  <wumpus> besides the router issue I first had -nolisten enabled, so it was forwarding the port but it wasn't actually open :-)
382 2020-12-17T15:29:55  *** lontivero <lontivero!~lontivero@> has joined #bitcoin-core-dev
383 2020-12-17T15:45:54  <wumpus> it's slightly unexpected that natpmp.h doesn't have constants for OK return values so we need to use hardcoded magic values like '12'
384 2020-12-17T15:45:59  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:4940:8dd3:7c10:4404> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
385 2020-12-17T15:57:33  *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
386 2020-12-17T16:01:05  *** molz_ <molz_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
387 2020-12-17T16:01:25  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 264 seconds)
388 2020-12-17T16:01:50  *** kexkey <kexkey!~kexkey@static-198-54-132-110.cust.tzulo.com> has joined #bitcoin-core-dev
389 2020-12-17T16:04:38  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 268 seconds)
390 2020-12-17T16:04:55  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
391 2020-12-17T16:20:45  *** miketwenty1 <miketwenty1!~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com> has quit IRC (Remote host closed the connection)
392 2020-12-17T16:22:53  *** miketwen_ <miketwen_!~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com> has joined #bitcoin-core-dev
393 2020-12-17T16:31:31  <wumpus> #proposedmeetingtopic rc4 status, macos codesigning fix
394 2020-12-17T16:31:44  *** proofofkeags <proofofkeags!~proofofke@174-16-212-53.hlrn.qwest.net> has quit IRC (Ping timeout: 260 seconds)
395 2020-12-17T16:32:30  <wumpus> #proposedmeetingtopic no meetings 2020-12-24 & 2020-12-31
396 2020-12-17T16:39:17  <vasild> https://calendar.google.com/calendar/u/0/embed?src=11pqvdgpd99nlibf9ba861vu8s@group.calendar.google.com&ctz=Europe/Vienna -- this shows p2p meeting on Dec 29, needs to be updated (but I cant)
397 2020-12-17T16:39:26  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
398 2020-12-17T16:52:55  <dhruvm> I am trying to run a full node with everything else blocked using iptables: https://pastebin.com/rre3eQQR With that setup, bitcoind is not able to establish any peers (10k+ in peers.dat). What am I missing?
399 2020-12-17T16:56:42  *** miketwen_ <miketwen_!~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com> has quit IRC (Remote host closed the connection)
400 2020-12-17T17:11:46  *** miketwenty1 <miketwenty1!~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com> has joined #bitcoin-core-dev
401 2020-12-17T17:13:01  <wumpus> vasild: is that my calender? will take a look
402 2020-12-17T17:13:52  <vasild> wumpus: I don't know, it is linked from here: https://bitcoincore.org/en/meetings/ "Meeting times are also listed on this Google calendar"
403 2020-12-17T17:15:23  <wumpus> vasild: i've deleted it
404 2020-12-17T17:16:01  <vasild> Thanks!
405 2020-12-17T17:16:03  <wumpus> there's still a bitcoin core wallet meeting on jan 1, probably also not going to be?
406 2020-12-17T17:16:49  <vasild> yeah :)
407 2020-12-17T17:25:36  *** Kade20Goldner <Kade20Goldner!~Kade20Gol@static.> has joined #bitcoin-core-dev
408 2020-12-17T17:30:20  *** Kade20Goldner <Kade20Goldner!~Kade20Gol@static.> has quit IRC (Ping timeout: 256 seconds)
409 2020-12-17T17:37:29  *** belcher_ is now known as belcher
410 2020-12-17T17:37:57  *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
411 2020-12-17T17:46:30  *** Guest58575 <Guest58575!~ds@> has quit IRC (Remote host closed the connection)
412 2020-12-17T17:50:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
413 2020-12-17T17:50:07  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/143bd108ed66...190d3d8a75d2
414 2020-12-17T17:50:07  <bitcoin-git> bitcoin/master 7b6887e Wladimir J. van der Laan: doc: Convert depends options list from html to markdown
415 2020-12-17T17:50:08  <bitcoin-git> bitcoin/master 190d3d8 Wladimir J. van der Laan: Merge #20681: doc: Convert depends options list from html to markdown
416 2020-12-17T17:50:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
417 2020-12-17T17:50:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
418 2020-12-17T17:50:26  <bitcoin-git> [bitcoin] laanwj merged pull request #20681: doc: Convert depends options list from html to markdown (master...2020_12_dependdoc) https://github.com/bitcoin/bitcoin/pull/20681
419 2020-12-17T17:50:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
420 2020-12-17T17:56:54  *** lontivero <lontivero!~lontivero@> has quit IRC (Ping timeout: 260 seconds)
421 2020-12-17T18:00:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
422 2020-12-17T18:00:10  <bitcoin-git> [bitcoin] sdaftuar closed pull request #20676: Replace m_tx_relay/nullptr checks in net_processing.cpp (master...2020-12-refactor-m_tx_relay) https://github.com/bitcoin/bitcoin/pull/20676
423 2020-12-17T18:00:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
424 2020-12-17T18:07:03  *** pleia21 <pleia21!~pleia2@> has joined #bitcoin-core-dev
425 2020-12-17T18:07:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
426 2020-12-17T18:07:24  <bitcoin-git> [bitcoin] jonatack opened pull request #20686: fuzz, refactor: replace CNode code with fuzz/util.h::ConsumeNode() (master...net-fuzzer-ConsumeNode) https://github.com/bitcoin/bitcoin/pull/20686
427 2020-12-17T18:07:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
428 2020-12-17T18:14:56  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
429 2020-12-17T18:15:41  *** miketwen_ <miketwen_!~miketwent@> has joined #bitcoin-core-dev
430 2020-12-17T18:16:44  *** jrawsthorne <jrawsthorne!~jrawsthor@static.> has quit IRC (Read error: Connection reset by peer)
431 2020-12-17T18:17:45  *** jrawsthorne <jrawsthorne!~jrawsthor@static.> has joined #bitcoin-core-dev
432 2020-12-17T18:18:28  *** miketwe__ <miketwe__!~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com> has joined #bitcoin-core-dev
433 2020-12-17T18:18:28  *** jrawsthorne <jrawsthorne!~jrawsthor@static.> has quit IRC (Read error: Connection reset by peer)
434 2020-12-17T18:18:45  *** miketwenty1 <miketwenty1!~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com> has quit IRC (Ping timeout: 240 seconds)
435 2020-12-17T18:19:30  *** jrawsthorne <jrawsthorne!~jrawsthor@static.> has joined #bitcoin-core-dev
436 2020-12-17T18:21:23  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
437 2020-12-17T18:21:59  *** miketwen_ <miketwen_!~miketwent@> has quit IRC (Ping timeout: 260 seconds)
438 2020-12-17T18:26:14  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Quit: Pavlenex)
439 2020-12-17T18:29:33  *** jrawsthorne <jrawsthorne!~jrawsthor@static.> has quit IRC (Ping timeout: 260 seconds)
440 2020-12-17T18:30:17  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
441 2020-12-17T18:31:20  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Client Quit)
442 2020-12-17T18:36:15  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
443 2020-12-17T18:37:40  *** lontivero <lontivero!~lontivero@> has joined #bitcoin-core-dev
444 2020-12-17T18:40:58  *** dkrm <dkrm!~dkrm@2001:41d0:8:3f7b::1> has quit IRC (Remote host closed the connection)
445 2020-12-17T18:41:34  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Quit: Pavlenex)
446 2020-12-17T18:41:56  *** dkrm <dkrm!~dkrm@2001:41d0:8:3f7b::1> has joined #bitcoin-core-dev
447 2020-12-17T18:43:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
448 2020-12-17T18:43:15  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20687: wallet: Add missing check for -descriptors wallet tool option (master...2012-walletToolSqlite) https://github.com/bitcoin/bitcoin/pull/20687
449 2020-12-17T18:43:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
450 2020-12-17T18:44:58  *** lontivero <lontivero!~lontivero@> has quit IRC (Ping timeout: 268 seconds)
451 2020-12-17T18:48:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
452 2020-12-17T18:48:37  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/190d3d8a75d2...b7136c11ab64
453 2020-12-17T18:48:37  <bitcoin-git> bitcoin/master 23d8f34 Jon Atack: fuzz: replace CNode code with fuzz/util.h::ConsumeNode()
454 2020-12-17T18:48:38  <bitcoin-git> bitcoin/master b7136c1 MarcoFalke: Merge #20686: fuzz, refactor: replace CNode code with fuzz/util.h::Consume...
455 2020-12-17T18:48:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
456 2020-12-17T18:48:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
457 2020-12-17T18:48:57  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20686: fuzz, refactor: replace CNode code with fuzz/util.h::ConsumeNode() (master...net-fuzzer-ConsumeNode) https://github.com/bitcoin/bitcoin/pull/20686
458 2020-12-17T18:48:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
459 2020-12-17T18:52:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
460 2020-12-17T18:52:52  <bitcoin-git> [bitcoin] mjdietzx opened pull request #20688: test: run mempool_compatibility.py even with wallet disabled (master...mempool-compatibility-to-miniwallet) https://github.com/bitcoin/bitcoin/pull/20688
461 2020-12-17T18:52:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
462 2020-12-17T18:58:06  *** larryruane_ <larryruane_!uid473749@gateway/web/irccloud.com/x-jmnycirzwyuntfua> has joined #bitcoin-core-dev
463 2020-12-17T19:00:21  <wumpus> #startmeeting
464 2020-12-17T19:00:22  <core-meetingbot> Meeting started Thu Dec 17 19:00:21 2020 UTC.  The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
465 2020-12-17T19:00:22  <core-meetingbot> Available commands: action commands idea info link nick
466 2020-12-17T19:00:26  <jonasschnelli> hi
467 2020-12-17T19:00:29  <hebasto> hi
468 2020-12-17T19:00:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
469 2020-12-17T19:00:31  <bitcoin-git> [bitcoin] theStack opened pull request #20689: contrib: replace binary verification script verify.sh with python rewrite (master...202012-contrib-replace-verify-binaries-script-with-python) https://github.com/bitcoin/bitcoin/pull/20689
470 2020-12-17T19:00:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
471 2020-12-17T19:00:47  <wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
472 2020-12-17T19:00:49  <wumpus> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus
473 2020-12-17T19:00:54  <jonatack> hi
474 2020-12-17T19:00:55  <sdaftuar> hi
475 2020-12-17T19:00:56  <achow101> hi
476 2020-12-17T19:01:02  <provoostenator> hi
477 2020-12-17T19:01:05  <fjahr> hi
478 2020-12-17T19:01:21  <jamesob> hi
479 2020-12-17T19:01:29  <wumpus> one proposed meeting for this week: rc4 status, macos codesigning fix (wumpus)
480 2020-12-17T19:01:45  *** jrawsthorne <jrawsthorne!~jrawsthor@static.> has joined #bitcoin-core-dev
481 2020-12-17T19:02:22  <wumpus> the other is more a PSA: i don't think it makes sense to do meetings 2020-12-24 & 2020-12-31, so the next one will be in 2021!
482 2020-12-17T19:02:48  <jonasschnelli> agree
483 2020-12-17T19:02:53  <meshcollider> hi
484 2020-12-17T19:02:53  <achow101> ack
485 2020-12-17T19:03:06  <wumpus> #topic High priority for review
486 2020-12-17T19:03:06  <core-meetingbot> topic: High priority for review
487 2020-12-17T19:03:13  <sipa> hi
488 2020-12-17T19:03:14  <jonasschnelli> I have added #15946
489 2020-12-17T19:03:17  <gribble> https://github.com/bitcoin/bitcoin/issues/15946 | Allow maintaining the blockfilterindex when using prune by jonasschnelli · Pull Request #15946 · bitcoin/bitcoin · GitHub
490 2020-12-17T19:03:20  <jonasschnelli> (to hiprio)
491 2020-12-17T19:03:26  <wumpus> https://github.com/bitcoin/bitcoin/projects/8  10 blockers, 2 chasing concept ACK
492 2020-12-17T19:03:39  <wumpus> jonasschnelli: ok
493 2020-12-17T19:04:23  <wumpus> otherwise, anything to add/remove or that is ready for merge?
494 2020-12-17T19:04:28  <jonatack> can drop #20546, i'll likely break it down into smaller ones
495 2020-12-17T19:04:31  <gribble> https://github.com/bitcoin/bitcoin/issues/20546 | policy, wallet, refactor: check for non-representable CFeeRates by jonatack · Pull Request #20546 · bitcoin/bitcoin · GitHub
496 2020-12-17T19:04:36  <jonasschnelli> #15946 is basically an lnd stopper for pruned peers
497 2020-12-17T19:04:38  <gribble> https://github.com/bitcoin/bitcoin/issues/15946 | Allow maintaining the blockfilterindex when using prune by jonasschnelli · Pull Request #15946 · bitcoin/bitcoin · GitHub
498 2020-12-17T19:06:07  <dongcarl> hi
499 2020-12-17T19:06:08  *** lontivero <lontivero!~lontivero@> has joined #bitcoin-core-dev
500 2020-12-17T19:06:08  <wumpus> jonasschnelli: ok, removed
501 2020-12-17T19:06:20  <jonatack> jamesob: fjahr: reviewing your hi-prios atm
502 2020-12-17T19:06:21  <wumpus> I mean jonatack*
503 2020-12-17T19:06:42  <sdaftuar> #14053 -- is that still chasing concept ACK? i haven't followed the discussion but i htink it's been in that state for a long time
504 2020-12-17T19:06:44  *** jrawsthorne <jrawsthorne!~jrawsthor@static.> has quit IRC (Quit: ZNC 1.8.1 - https://znc.in)
505 2020-12-17T19:06:46  <gribble> https://github.com/bitcoin/bitcoin/issues/14053 | Add address-based index (attempt 4?) by marcinja · Pull Request #14053 · bitcoin/bitcoin · GitHub
506 2020-12-17T19:07:23  <wumpus> I think we can drop that
507 2020-12-17T19:09:41  *** jrawsthorne <jrawsthorne!~jrawsthor@static.> has joined #bitcoin-core-dev
508 2020-12-17T19:09:41  <wumpus> there's no discussion there by any actual contributors to the project
509 2020-12-17T19:09:52  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo)
510 2020-12-17T19:09:55  <sdaftuar> it seems it had many concept acks early on (2 years ago)
511 2020-12-17T19:10:10  <fjahr> it has a lot of interest from the wider community
512 2020-12-17T19:10:39  <jonatack> iirc it's desired by the community but unsustainable long-term (haven't looked in a long time but we did a review club on it)
513 2020-12-17T19:10:41  <wumpus> I still think an address index over the entire block chain is bad idea and becomes a worse idea the more the thing grows, software that relies on that is broken
514 2020-12-17T19:10:46  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 246 seconds)
515 2020-12-17T19:11:05  <sdaftuar> i thought it was just an index on the utxo set.  it's indexing the whole blockchain?
516 2020-12-17T19:11:10  <sipa> yes
517 2020-12-17T19:11:26  <sdaftuar> ohh i see
518 2020-12-17T19:11:28  <wumpus> it's the whole block chain I think? utxo index would make more sense to me
519 2020-12-17T19:11:32  <fjahr> If people are against it, they should NACK it
520 2020-12-17T19:11:47  <jonasschnelli> the eralier attemps where just for the utxo set, right?
521 2020-12-17T19:11:59  <wumpus> fjahr: I have nacked similar things for years, if people keep digigng it up I lose the energy for that
522 2020-12-17T19:12:03  <jonasschnelli> a complete index seems out of scope IMO
523 2020-12-17T19:13:14  <jonatack> i soft-nacked it https://github.com/bitcoin/bitcoin/pull/14053#pullrequestreview-340041837
524 2020-12-17T19:13:19  <wumpus> yes, there have been attemps for indexes over only the UTXO set, but they didn't make it in either for some reason (dunno why, maybe the author just gave up)
525 2020-12-17T19:13:37  <sipa> it's a difficult question... (IMO) people shouldn't be building infrastructure that relies on having such an index, but if they're going to do it anyway, it's perhaps not any worse to have in bitcoin core
526 2020-12-17T19:13:41  <MarcoFalke> It is no worse than -txindex
527 2020-12-17T19:13:49  <sipa> txindex is terrible too
528 2020-12-17T19:13:54  <sipa> but we can't just drop it
529 2020-12-17T19:14:00  <wumpus> yes, it's just as worse as txindex
530 2020-12-17T19:14:07  <fjahr> wumpus: understandable, maybe there should be some kind of "permanent concept NACK" if enough people agree so nobody puts effort into putting into core anymore, maybe there is a way there for a project that works closely with core
531 2020-12-17T19:14:27  <aj> isn't that just a good reason for both addrindex and txindex to be optional and default off?
532 2020-12-17T19:14:40  <wumpus> fjahr: I mean I have no interest in blocking something if people really want it, but I'm not going to be part of it
533 2020-12-17T19:14:54  <wumpus> fjahr: and apparently a lot of contributors think like that
534 2020-12-17T19:14:57  <jonasschnelli> #20664 is something that allows (very) slow address scanning at a fraction of disk space
535 2020-12-17T19:14:58  <gribble> https://github.com/bitcoin/bitcoin/issues/20664 | Add scanblockfilters RPC call by jonasschnelli · Pull Request #20664 · bitcoin/bitcoin · GitHub
536 2020-12-17T19:15:04  <jonasschnelli> (with blockfilters)
537 2020-12-17T19:15:26  <sipa> aj: yeah, maybe
538 2020-12-17T19:15:41  <MarcoFalke> I won't use addrindex myself, but the whole point of ./src/indexes/ was to make it easier to add (crappy) indexes
539 2020-12-17T19:15:43  <sipa> it's not like our resistance (or reluctance) to add something like that has stopped people from using it
540 2020-12-17T19:16:19  <jonasschnelli> Sure. But there are dedicated projects like Electrs doing it on a pretty good level
541 2020-12-17T19:16:27  <sipa> yes
542 2020-12-17T19:16:31  <jonasschnelli> Which is basically project modularization
543 2020-12-17T19:16:39  <jonasschnelli> They can use their optimized DB (rocksDB in that case)
544 2020-12-17T19:16:43  <wumpus> yeah https://github.com/bitcoin/bitcoin/pull/14053#issuecomment-744015971
545 2020-12-17T19:16:52  <sipa> MarcoFalke does have a point
546 2020-12-17T19:17:05  <jonasschnelli> If we are going to merge it, people will build on top of it and maintenance/traffic goes into our project
547 2020-12-17T19:17:06  <wumpus> no need to compete with dedicated projects whose whole point is to optimize this
548 2020-12-17T19:17:08  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
549 2020-12-17T19:17:15  <wumpus> bitcoin core is not a blob that needs to absorb the entire bitcoin ecosystem
550 2020-12-17T19:17:23  <MarcoFalke> It would be nice if indexes could be attached to bitcoin core at runtime (external modules), but we are not there yet
551 2020-12-17T19:17:35  <wumpus> jonasschnelli: indeed
552 2020-12-17T19:17:35  <jonasschnelli> Adding a complete address index is against the project modularization.
553 2020-12-17T19:17:43  <wumpus> it's scope creep
554 2020-12-17T19:17:49  <jonasschnelli> I think adding more interfaces to allow "better" interaction would be the way to go
555 2020-12-17T19:17:52  <sipa> at least the argument of it being invasive validation code changes doesn't apply anymore
556 2020-12-17T19:17:53  <wumpus> and there are already solutions for it
557 2020-12-17T19:18:19  <MarcoFalke> bitcoin-tx is scope creep as well (playing devils advocate)
558 2020-12-17T19:18:22  <wumpus> MarcoFalke: well, external programs exist for it, it's supposedly possible
559 2020-12-17T19:18:32  <jonasschnelli> I also see (and feel) the point that it would be "handy" to have it "in one box". But long term, it might a bad idea
560 2020-12-17T19:18:48  <MarcoFalke> https://github.com/bitcoin-core/btcdeb is also scope creep
561 2020-12-17T19:19:00  <wumpus> well then people could make a bitcoin core + electrs bundle, for example
562 2020-12-17T19:19:24  <wumpus> there's lots of systems like docker that allow shipping multiple software that works together in one box
563 2020-12-17T19:19:32  <sipa> my primary objection is "nobody should be using this"
564 2020-12-17T19:19:56  *** molz_ <molz_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 265 seconds)
565 2020-12-17T19:20:00  <wumpus> MarcoFalke: that's literally a separate repository though :)
566 2020-12-17T19:20:06  <sipa> but if people are going to use this anyway, and it can be added without being too invasive, and being optional... from a code maintenance perspective i don't have that much problems with it
567 2020-12-17T19:20:17  <jonasschnelli> I guess there are reasons to use it,... if your backend servers hundreds of wallets and if you want instance seed-backup restores
568 2020-12-17T19:20:26  <MarcoFalke> It is still a repo in our org ;)
569 2020-12-17T19:20:27  <jonasschnelli> *instant
570 2020-12-17T19:20:36  <wumpus> MarcoFalke: I don't have a problem with it being in the org
571 2020-12-17T19:20:45  <jonasschnelli> Yes.
572 2020-12-17T19:20:49  <wumpus> just not everything needs to be part of the bitcoin core repostiory
573 2020-12-17T19:21:01  <jonasschnelli> The address index could be outside our repo and I think it would be fine
574 2020-12-17T19:21:26  <jonasschnelli> Maybe similar like the guy... but ideally process separated from the beginning.
575 2020-12-17T19:21:28  <jonasschnelli> *GUI
576 2020-12-17T19:21:46  <wumpus> let's fork electrs into bitcoin-core then :)
577 2020-12-17T19:21:55  <jonasschnelli> :/
578 2020-12-17T19:22:38  <aj> txindex is slightly helpful for speeding up our own RPCs (getrawtransaction), i don't think there's a similar rationale for needing an integrated addrindex?
579 2020-12-17T19:23:35  <sipa> getrawtransactionsbyaddress, an RPC that very unhelpfully always reports the "RPC does not exist" error right now
580 2020-12-17T19:24:19  <MarcoFalke> how does txindex speed things up?
581 2020-12-17T19:24:22  <jonasschnelli> why is an index for the utxo set not enoght?
582 2020-12-17T19:24:41  <jonasschnelli> If you want the spent history, use blockfilters
583 2020-12-17T19:26:34  <sipa> i commented
584 2020-12-17T19:27:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
585 2020-12-17T19:27:01  <bitcoin-git> [bitcoin] sdaftuar opened pull request #20690: Clean up logging of outbound connection type (master...2020-12-clean-up-outbound-logging) https://github.com/bitcoin/bitcoin/pull/20690
586 2020-12-17T19:27:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
587 2020-12-17T19:27:08  <aj> MarcoFalke: compared to looping over every historical block and checking blockfilters, it's O(log(txs)) vs O(blocks)
588 2020-12-17T19:27:14  <wumpus> it will just be the same discussion again that's been done many times over the years i expect
589 2020-12-17T19:28:25  <jamesob> jonatack: thanks!
590 2020-12-17T19:28:38  <jamesob> I have some feedback from wumpus to address I think
591 2020-12-17T19:28:46  <fjahr> jonasschnelli: I think such a combo is worth exploring
592 2020-12-17T19:29:12  <jonasschnelli> fjahr: look at #20664 (for performance analysis)
593 2020-12-17T19:29:14  <gribble> https://github.com/bitcoin/bitcoin/issues/20664 | Add scanblockfilters RPC call by jonasschnelli · Pull Request #20664 · bitcoin/bitcoin · GitHub
594 2020-12-17T19:29:33  <sipa> so when rc4 topic?
595 2020-12-17T19:29:47  <fjahr> jonasschnelli: will do
596 2020-12-17T19:30:42  <wumpus> #topic rc4 status, macos codesigning fix (wumpus)
597 2020-12-17T19:30:42  <core-meetingbot> topic: rc4 status, macos codesigning fix (wumpus)
598 2020-12-17T19:31:13  <wumpus> I saw there are two parellel workarounds for the rc3 macos signing issue
599 2020-12-17T19:31:23  <sipa> so we have two possible (temporary?) fixes for macos codesigning, #20638 and #20644
600 2020-12-17T19:31:25  <gribble> https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
601 2020-12-17T19:31:27  <gribble> https://github.com/bitcoin/bitcoin/issues/20644 | Add patch to make codesign_allocate compatible with Apples by sipa · Pull Request #20644 · bitcoin/bitcoin · GitHub
602 2020-12-17T19:31:27  <wumpus> we'll probably want to choose one
603 2020-12-17T19:31:32  <sipa> i think both are fine
604 2020-12-17T19:31:56  <sipa> and if achow101's python codesigner works, all of this will be obsolete
605 2020-12-17T19:32:04  <sipa> s/if/when/ - no pressure
606 2020-12-17T19:32:11  <jonasschnelli> heh
607 2020-12-17T19:32:14  <wumpus> but that's more of a long-run solution
608 2020-12-17T19:32:17  <achow101> it's coming along slowly
609 2020-12-17T19:32:35  <jonasschnelli> achow101: no pressure,.. but will it be ready for an rc4? :)
610 2020-12-17T19:32:52  <achow101> I might have a PoC tomorrow
611 2020-12-17T19:33:05  <jonasschnelli> Maybe for 0.21 we should use the existing solutions and use 0.22 (+backport) for achow101 signing tool
612 2020-12-17T19:33:18  <wumpus> I don't think it's a good idea to introduce something like that between rcs
613 2020-12-17T19:33:18  <sipa> yeah, not really relevant in this discussion; we can just pick one; my PR makes our codesign compatible with Apple's (to the extent that we know, but it can always change); achow's works around the issue (by predicting some things the Apple code will do)
614 2020-12-17T19:33:21  <sipa> jonasschnelli: seems reasonable
615 2020-12-17T19:33:42  <wumpus> unless there is no other workable option, of course
616 2020-12-17T19:33:43  <jonasschnelli> sipa's PR is an easier fix and maybe less risky?
617 2020-12-17T19:33:51  <jonasschnelli> (if we going to drop it anyways)
618 2020-12-17T19:34:08  <achow101> I think sipa's PR potentially has other side effects that we haven't discovered
619 2020-12-17T19:34:21  <sipa> well, the signature validates
620 2020-12-17T19:34:23  <achow101> since it modifies cctools and we use more than just codesign_allocate in it
621 2020-12-17T19:34:32  <jonasschnelli> sipa: it only needs to work for rc4 and final release
622 2020-12-17T19:34:34  <sipa> hmm, do we?
623 2020-12-17T19:34:41  <jonasschnelli> (oh... and maybe for 0.20.2)
624 2020-12-17T19:34:47  <sipa> what else from cctools do we use?
625 2020-12-17T19:35:55  <achow101> pagestuff, but it doesn't seem to be effected
626 2020-12-17T19:35:56  <dongcarl> I believe we use it as our binutils
627 2020-12-17T19:36:03  <dongcarl> For macOS targets
628 2020-12-17T19:36:03  <sipa> the changed function only affects codesign_allocate, lipo, bitcode_strip, and segedit
629 2020-12-17T19:36:06  <achow101> I thought we used some of the tools for building but I'm not sure
630 2020-12-17T19:36:40  <sipa> anyway, no strong feelings
631 2020-12-17T19:36:40  <dongcarl> I don't think we use any of the other ones sipa just listed, need to double check tho
632 2020-12-17T19:36:43  <sipa> and no point spending much time on this
633 2020-12-17T19:37:19  <achow101> well, at least during testing we didn't find any other problems, so it's probably fine
634 2020-12-17T19:39:37  <wumpus> ok
635 2020-12-17T19:39:56  <jonasschnelli> I propose to merge #20644 and do rc4 and 0.20.2rc1. Then wait for achow101 signing tool to have a stable long term fix
636 2020-12-17T19:39:58  <gribble> https://github.com/bitcoin/bitcoin/issues/20644 | Add patch to make codesign_allocate compatible with Apples by sipa · Pull Request #20644 · bitcoin/bitcoin · GitHub
637 2020-12-17T19:40:08  <jonasschnelli> (then revert 20644)
638 2020-12-17T19:40:14  <wumpus> so let's try merging sipa's patch and do rc4, if that runs into unexpected issues, try the other one?
639 2020-12-17T19:40:22  <jonasschnelli> sure
640 2020-12-17T19:40:26  <achow101> ack
641 2020-12-17T19:40:27  <jonasschnelli> ack
642 2020-12-17T19:40:32  <sipa> also #20646 in rc4 or not?
643 2020-12-17T19:40:34  <gribble> https://github.com/bitcoin/bitcoin/issues/20646 | p2p: ignore post-verack sendaddrv2 instead of disconnecting by jonatack · Pull Request #20646 · bitcoin/bitcoin · GitHub
644 2020-12-17T19:40:44  <sipa> as pointed out, it makes little sense if it doesn't go in 0.21
645 2020-12-17T19:40:55  <wumpus> sipa: I don't think people even agree about doing it
646 2020-12-17T19:41:44  *** proofofkeags <proofofkeags!~proofofke@2601:280:c280:e500:7ed6:f476:4ff8:2b87> has joined #bitcoin-core-dev
647 2020-12-17T19:42:05  <sipa> yeah
648 2020-12-17T19:42:12  <aj> it has three acks and a +/- 0?
649 2020-12-17T19:42:51  <wumpus> my ACK is more of a 'I don't disagree with doing this and the code change looks correct'
650 2020-12-17T19:43:00  *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
651 2020-12-17T19:44:29  <luke-jr> .
652 2020-12-17T19:45:37  <MarcoFalke> ...
653 2020-12-17T19:45:53  <aj> i don't think i have anything to add that's not already in the pr
654 2020-12-17T19:46:03  <wumpus> same
655 2020-12-17T19:46:13  <MarcoFalke> someone should flip a coin
656 2020-12-17T19:46:31  <wumpus> if we're not sure it's better to err on the side of not making a code change
657 2020-12-17T19:47:35  <aj> Jackielove4u spend 2h the other night debugging test failures because of it, likewise it broke syncing signet, i don't really see why this is a coin toss
658 2020-12-17T19:47:41  <wumpus> especially if it's a merge-and-rush-into-rc4-last-minute thing
659 2020-12-17T19:48:38  <sipa> aj: ah, other report of someone hit by it?
660 2020-12-17T19:49:07  <aj> sipa: had bitcoin-qt and bitcoind refusing to connect, didn't realise bitcoin-qt was still rc2
661 2020-12-17T19:49:17  <jonatack> i'm ambivalent, but it seems safer to ignore instead of disconnect if we're in doubt. the signet thing, and also a year ago we had to pull a release
662 2020-12-17T19:49:17  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
663 2020-12-17T19:49:55  <jonatack> and anything else we haven't hit related to it
664 2020-12-17T19:50:21  <wumpus> 0.21.0 has had many of those 'we need to decide this last minute' and it doesn't make me comfortable
665 2020-12-17T19:50:25  <MarcoFalke> The signet sync is already fixed, so merging the pull won't change that
666 2020-12-17T19:50:33  <jonatack> wumpus: i empathize
667 2020-12-17T19:50:52  <aj> wumpus: there were a lot of big merges just before freeze
668 2020-12-17T19:51:30  <wumpus> MarcoFalke: great!
669 2020-12-17T19:51:45  <luke-jr> maybe we need more time between freeze and rc1? (though I dislike the duration)
670 2020-12-17T19:52:00  <luke-jr> perhaps branch at freeze and tag rc1 weeks afterward?
671 2020-12-17T19:52:12  <wumpus> that's just more backporting work
672 2020-12-17T19:52:20  <MarcoFalke> luke-jr: That'd mean too much work backporting
673 2020-12-17T19:52:23  <jonasschnelli> luke-jr: most stuff appears in rcs.. :/
674 2020-12-17T19:52:45  <MarcoFalke> Also, most rc issues are build system issues
675 2020-12-17T19:52:57  <wumpus> jonasschnelli: bugs appearing and fixed in rcs is completely normal and expected, what bothers me is these kind of last minute protocol handling changes
676 2020-12-17T19:53:05  <MarcoFalke> So you won't find them before the tag
677 2020-12-17T19:53:09  <jonasschnelli> wumpus: indeed.
678 2020-12-17T19:53:19  <jonasschnelli> Although, ignoring them is also no option
679 2020-12-17T19:53:38  <wumpus> jonasschnelli: well if MarcoFalke says the signet sync issue is fixed
680 2020-12-17T19:53:41  <jonasschnelli> MarcoFalke: good point
681 2020-12-17T19:53:56  <sipa> well it's fixed for people who update
682 2020-12-17T19:54:03  <sipa> no?
683 2020-12-17T19:54:09  <sipa> that was already the case
684 2020-12-17T19:54:37  <aj> the original issue was people running rc3 couldn't sync from the non-tor seed node
685 2020-12-17T19:54:42  <MarcoFalke> sipa: The seed node was on rc2, so a user updating to rc3 *broke* it
686 2020-12-17T19:54:53  <sipa> ah i see
687 2020-12-17T19:54:59  <sipa> ok, fair point
688 2020-12-17T19:55:07  <MarcoFalke> *pre-rc2 (not sure if it was actually rc2)
689 2020-12-17T19:55:08  <aj> that node is now updated, so now anyone running rc2 and earlier can't sync from it instead
690 2020-12-17T19:55:29  <MarcoFalke> aj: Correct
691 2020-12-17T19:55:43  <aj> i think the seed node was a previous version of #19937
692 2020-12-17T19:55:46  <gribble> https://github.com/bitcoin/bitcoin/issues/19937 | signet mining utility by ajtowns · Pull Request #19937 · bitcoin/bitcoin · GitHub
693 2020-12-17T19:55:48  <sipa> so it's not really signet-specific anymore... the question is just whether gratuitous disconnection of existing old nodes is worth slightly better observability of people implementing the protocol incorrectly
694 2020-12-17T19:55:54  <MarcoFalke> aj: Though, that seems like a feature (telling people to upgrade from non-supported versions)
695 2020-12-17T19:56:20  <wumpus> there isn't any released node that will be disconnected right?
696 2020-12-17T19:56:20  <aj> MarcoFalke: telling people to upgrade sure, but this is just "it fails for no apparent reason"
697 2020-12-17T19:56:29  <sipa> wumpus: correct
698 2020-12-17T19:57:07  <wumpus> I mean if you implement the ignoring someone might spent hours debugging why addrv2 doesn't work
699 2020-12-17T19:57:10  <sipa> it was affecting signet disproportionally because of course all signet nodes were running pre-release code
700 2020-12-17T19:57:24  <wumpus> sometimes I wish we still had the reject message
701 2020-12-17T19:57:47  <MarcoFalke> the reject message was replaced by -debug=net
702 2020-12-17T19:58:01  <wumpus> it could send an error to the peer before disconnecting, or in general when not accepting it
703 2020-12-17T19:58:03  <sipa> wumpus: maybe, but if they're trying to make it work is "why am i getting addr and not addrv2?" really that different from "why am i being disconnected?"
704 2020-12-17T19:58:14  <aj> it would have been nice if there was this much resistance to #20564 :-/
705 2020-12-17T19:58:18  <gribble> https://github.com/bitcoin/bitcoin/issues/20564 | Dont send sendaddrv2 to pre-70016 software, and send before verack by sipa · Pull Request #20564 · bitcoin/bitcoin · GitHub
706 2020-12-17T19:58:52  <sipa> aj: later and later in the process, more and more resistance...
707 2020-12-17T19:58:54  <wumpus> aj: that was also a reluctant ACK for me
708 2020-12-17T19:58:57  <luke-jr> aj: test != mainnet
709 2020-12-17T20:00:07  <wumpus> but that was about mainnet software, and actual releases of alternative clients
710 2020-12-17T20:00:14  <aj> sipa: pretty easy to have a BCLog::NET debug message of either "Ignoring SENDADDRV2 received after VERACK" or "SENDADDRV2 received after VERACK; disconnecting" -- we have neither of those atm, also for WTXIRELAY
711 2020-12-17T20:00:36  <sipa> aj: yeah, that would be a good idea
712 2020-12-17T20:00:44  <wumpus> yes, would make sense to add that
713 2020-12-17T20:01:27  <aj> i have a patch to add it, but was waiting for the sendaddrv2 to get fixed (or, i guess, nacked)
714 2020-12-17T20:02:10  <wumpus> it's time to end the meeting
715 2020-12-17T20:02:11  <jonatack> disconnection was added pretty late in the 20564 review process
716 2020-12-17T20:02:29  <aj> luke-jr: i guess i don't really agree. the whole point of a test net is to catch breakage first; if you catch breakage on the testnet and then go "oh, it's just broken on the testnet, it'll be fine on mainnet" that kind of defeats the purpose imo
717 2020-12-17T20:02:32  <jonatack> (i didn't disagree with it, just observing)
718 2020-12-17T20:03:03  <wumpus> #endmeeting
719 2020-12-17T20:03:03  <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
720 2020-12-17T20:03:03  <core-meetingbot> Meeting ended Thu Dec 17 20:03:03 2020 UTC.
721 2020-12-17T20:03:03  <core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-12-17-19.00.moin.txt
722 2020-12-17T20:03:14  <jonasschnelli> \o
723 2020-12-17T20:03:22  <luke-jr> aj: not when the breakage is triaged to not affect mainnet
724 2020-12-17T20:03:56  <aj> luke-jr: Jackiewhatever's problems were on mainnet, aiui
725 2020-12-17T20:03:56  <sipa> it affects mainnet in exactly the same way, just proportionally less badly
726 2020-12-17T20:04:05  <wumpus> i honestly don't know either but changing the behavior from disconnect to ignore for a temporary signet issue which is already fixed just feels redundant to me, I agree with jnewbery there
727 2020-12-17T20:04:29  <wumpus> it's not even a temporary workaround
728 2020-12-17T20:04:56  <MarcoFalke> jup, this would be permanent
729 2020-12-17T20:04:57  <MarcoFalke> [20:55] <sipa> so it's not really signet-specific anymore... the question is just whether gratuitous disconnection of existing old nodes is worth slightly better observability of people implementing the protocol incorrectly
730 2020-12-17T20:04:58  <jonatack> wumpus: right, it's not about fixing signet, nor temporary
731 2020-12-17T20:05:11  <aj> why would it be permanent?
732 2020-12-17T20:05:44  <aj> if disconnecting now is okay, ignoring now and disconnecting in the future is also okay
733 2020-12-17T20:05:54  <wumpus> so in the long term observability of implementing the protocol incorrectly is probably the more important concern
734 2020-12-17T20:06:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
735 2020-12-17T20:06:31  <bitcoin-git> [bitcoin] hebasto opened pull request #20691: ci, doc: Travis CI features and mentions cleanup (master...201217-travis) https://github.com/bitcoin/bitcoin/pull/20691
736 2020-12-17T20:06:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
737 2020-12-17T20:08:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
738 2020-12-17T20:08:01  <bitcoin-git> [bitcoin] hebasto closed pull request #20357: ci: Use travis_fold on Travis CI only (master...201109-travis) https://github.com/bitcoin/bitcoin/pull/20357
739 2020-12-17T20:08:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
740 2020-12-17T20:08:29  <aj> wumpus: logging that you're ignoring the message because it's out of order seems to capture that?
741 2020-12-17T20:09:29  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Read error: Connection reset by peer)
742 2020-12-17T20:09:41  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
743 2020-12-17T20:09:49  <jonatack> aj: yes, i like that
744 2020-12-17T20:10:05  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
745 2020-12-17T20:11:47  <wumpus> aj: yes, though less clearly, the peer being disconnected would prompt an investigation immediately
746 2020-12-17T20:12:18  <wumpus> I agree it needs to be logged whether disconnecting or not
747 2020-12-17T20:13:49  <aj> wumpus: i'm not sure that's true; there's plenty of old nodes on mainnet that the peer would connect to; if you're paying enough attention to realise you're not connected to any 0.21 nodes, you're probably also paying enough attention to realise you're not getting any addrv2 info
748 2020-12-17T20:15:04  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
749 2020-12-17T20:15:08  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
750 2020-12-17T20:15:16  <wumpus> there's also the consistency argument, why would wtxid disconnect you but not sendaddrv2
751 2020-12-17T20:16:13  <wumpus> the main reason that I was in favor of changing sendaddrv2 to be sent between version and verack in the first place is because it could be handled the same as other messages
752 2020-12-17T20:17:10  <aj> wumpus: because wtxid's spec didn't change the way sendaddrv2 did
753 2020-12-17T20:17:36  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Client Quit)
754 2020-12-17T20:17:41  <wumpus> bitcoin core is clearly the only client implementing sendaddrv2
755 2020-12-17T20:17:49  <aj> wumpus: wtxid gets to do it because there was no cost and a slight benefit; sendaddrv2 has a slight cost so shouldn't
756 2020-12-17T20:18:03  <wumpus> for now at least
757 2020-12-17T20:18:21  <sipa> there is another difference: ignoring a sendaddrv2 doesn't violate the BIP; ignoring a wtxidrelay does
758 2020-12-17T20:18:40  <aj> wumpus: though i'd much rather wtxid not do it either if the alternative is "it's okay to break our own software if it didn't make it into a release"
759 2020-12-17T20:19:25  <wumpus> so there was no reason changing the spec was problematic, if it was, then we wouldn't haev done the last minute change in the first place, and heck may be that would have been better, I'm so tired ofthis
760 2020-12-17T20:21:16  <wumpus> sendaddrv2 was only (in the old version) in the master and a pre-release for a short time, if that means we need to support that implemenation forever that would be kind of bad
761 2020-12-17T20:22:45  <aj> the PR already isn't supporting it, it's just not disconnecting it either
762 2020-12-17T20:23:53  <MarcoFalke> aj: If it is not permanent, how would you decide when to revert it back to disconnect?
763 2020-12-17T20:23:57  <aj> you could add an `if (GetTime() > 1623961389) fDisconnect = true;` now if you wanted, or add it back later. but the benefit of disconnecting versus just putting a log message seems super trivial
764 2020-12-17T20:24:08  <Jackielove4u> aj: 21:03:56 <aj> luke-jr: Jackiewhatever's problems were on mainnet, aiui
765 2020-12-17T20:24:09  <Jackielove4u> my problems were on mainnet AND testnet
766 2020-12-17T20:24:41  <Jackielove4u> however we can drop that PR
767 2020-12-17T20:24:47  <luke-jr> we ignore other invalid messages, I'm not sure why it's preferable to disconnect this one
768 2020-12-17T20:25:43  <aj> MarcoFalke: i'd guess when 0.21.1 is out and there are almost no 0.20.99 and perhaps 21.99 nodes on the network for objective measures; 6-12 months after the last unreleased code that used it for hand-wavey
769 2020-12-17T20:25:56  <Jackielove4u> wumpus: 20:56:20 <wumpus> there isn't any released node that will be disconnected right?
770 2020-12-17T20:25:56  <Jackielove4u> this is correct
771 2020-12-17T20:27:04  <aj> MarcoFalke: if it was timebased you could make that decision today by sticking the GetTime() comparison in, but i don't see any reason why you'd need to make that decision now
772 2020-12-17T20:29:06  <wumpus> jonasschnelli: it looks like you added #15946 to high prio for review but didn't move it to any column, I guess it should be in "blockers"?
773 2020-12-17T20:29:08  <gribble> https://github.com/bitcoin/bitcoin/issues/15946 | Allow maintaining the blockfilterindex when using prune by jonasschnelli · Pull Request #15946 · bitcoin/bitcoin · GitHub
774 2020-12-17T20:29:30  <jonasschnelli> oh. yes
775 2020-12-17T20:29:50  <wumpus> ok done
776 2020-12-17T20:29:57  <jonasschnelli> thanks!
777 2020-12-17T20:31:12  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
778 2020-12-17T20:34:36  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 256 seconds)
779 2020-12-17T20:35:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
780 2020-12-17T20:35:09  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b7136c11ab64...816314ef0f7b
781 2020-12-17T20:35:10  <bitcoin-git> bitcoin/master a4118c6 Pieter Wuille: Add patch to make codesign_allocate compatible with Apple's
782 2020-12-17T20:35:10  <bitcoin-git> bitcoin/master 816314e Wladimir J. van der Laan: Merge #20644: Add patch to make codesign_allocate compatible with Apple's
783 2020-12-17T20:35:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
784 2020-12-17T20:35:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
785 2020-12-17T20:35:24  <bitcoin-git> [bitcoin] laanwj merged pull request #20644: Add patch to make codesign_allocate compatible with Apple's (master...202012_codesign_allocate_segalign) https://github.com/bitcoin/bitcoin/pull/20644
786 2020-12-17T20:35:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
787 2020-12-17T20:36:43  *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has quit IRC (Ping timeout: 240 seconds)
788 2020-12-17T20:39:45  *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
789 2020-12-17T20:41:13  <MarcoFalke> Backported that to #20669
790 2020-12-17T20:41:15  <gribble> https://github.com/bitcoin/bitcoin/issues/20669 | [0.21] final rc4 backports by MarcoFalke · Pull Request #20669 · bitcoin/bitcoin · GitHub
791 2020-12-17T20:44:41  <wumpus> thanks so all that blocks rc4 is a decision on #20646 now
792 2020-12-17T20:44:44  <gribble> https://github.com/bitcoin/bitcoin/issues/20646 | p2p: ignore post-verack sendaddrv2 instead of disconnecting by jonatack · Pull Request #20646 · bitcoin/bitcoin · GitHub
793 2020-12-17T20:45:55  *** Pavlenex <Pavlenex!~Thunderbi@> has joined #bitcoin-core-dev
794 2020-12-17T20:46:23  <jonatack> gah, i'm really sorry
795 2020-12-17T20:46:30  * jonatack contemplates moving to siberia
796 2020-12-17T20:46:37  *** Pavlenex <Pavlenex!~Thunderbi@> has quit IRC (Client Quit)
797 2020-12-17T20:47:10  <aj> jonatack: afaik, they have irc and access to github in siberia
798 2020-12-17T20:47:26  <wumpus> heh i feel the same way often
799 2020-12-17T20:48:31  <jonatack> heh, teheran then
800 2020-12-17T20:49:28  <sipa> joking aside, going on vacation to places without decent internet access has helped me relax...
801 2020-12-17T20:51:44  <hebasto> some places in Siberia were science centers...
802 2020-12-17T20:54:06  <jonatack> hebasto: i spent a winter in (near) siberia actually, the former prisoners were the intelligentsia of the day
803 2020-12-17T20:54:39  <sipa> jonatack: cool (literally and figuratively)
804 2020-12-17T20:54:46  <jonatack> was in the area between perm, magnitogorsk, yekaterinburg & irkutsk
805 2020-12-17T20:55:32  <hebasto> it's quite a big region
806 2020-12-17T20:55:50  <jonatack> yes
807 2020-12-17T20:56:13  <jonatack> (if we add aj's logging, 20646 isn't the last PR)
808 2020-12-17T20:56:13  <sipa> jonatack: i know some of those names from the boardgame "risk"!
809 2020-12-17T20:57:04  <jonatack> sipa: maybe next coredev?
810 2020-12-17T20:57:15  <hebasto> hehe
811 2020-12-17T20:57:50  <sipa> jonatack: ehm... perm <-> irkutsk is 3000 km
812 2020-12-17T20:57:58  <sipa> do i have that right?
813 2020-12-17T20:58:50  *** Legousk <Legousk!~Henkie@178-84-68-9.dynamic.upc.nl> has quit IRC (Ping timeout: 264 seconds)
814 2020-12-17T20:59:05  <hebasto> sipa: correct
815 2020-12-17T20:59:14  <jonatack> right, perm isn't siberia yet...yeah it's big, flying between the cities the tupolevs took off and landed in a foot of snow, the pilots flew wearing only socks, shoes off in the cockpit
816 2020-12-17T20:59:27  <wumpus> jonatack: fine with including that but in contrast to 20644, logging isn't urgent to get into a rc
817 2020-12-17T20:59:48  <wumpus> 20646
818 2020-12-17T21:00:07  <aj> logging's useful for master, not rc
819 2020-12-17T21:00:42  <sipa> yeah, someone testing protocol support against bitcoin core will likely use master anyway
820 2020-12-17T21:00:59  <sipa> or the latest release at least; not random old nodes on the network
821 2020-12-17T21:03:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
822 2020-12-17T21:03:29  <bitcoin-git> [bitcoin] mjdietzx opened pull request #20692: test: run mempool_resurrect.py even with wallet disabled (master...mempool-resurrect-to-miniwallet) https://github.com/bitcoin/bitcoin/pull/20692
823 2020-12-17T21:03:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
824 2020-12-17T21:13:31  <jonatack> makes sense
825 2020-12-17T21:20:12  *** lontivero <lontivero!~lontivero@> has quit IRC (Read error: Connection reset by peer)
826 2020-12-17T21:24:43  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Ping timeout: 240 seconds)
827 2020-12-17T21:26:56  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
828 2020-12-17T21:49:33  *** b10c <b10c!~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a> has joined #bitcoin-core-dev
829 2020-12-17T22:01:07  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
830 2020-12-17T22:26:17  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Quit: Leaving)
831 2020-12-17T22:31:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
832 2020-12-17T22:31:33  <bitcoin-git> [bitcoin] glowang closed pull request #19297: [test] WIP: rewrite generate() in test_node to gain determinism in test data (master...2020/05/21/rewrite_generate_in_testnode) https://github.com/bitcoin/bitcoin/pull/19297
833 2020-12-17T22:31:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
834 2020-12-17T22:47:58  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 260 seconds)
835 2020-12-17T23:04:38  *** lontivero <lontivero!~lontivero@> has joined #bitcoin-core-dev
836 2020-12-17T23:05:04  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
837 2020-12-17T23:24:40  *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has quit IRC (Quit: No Ping reply in 180 seconds.)
838 2020-12-17T23:26:26  *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has joined #bitcoin-core-dev
839 2020-12-17T23:27:56  *** miketwe__ <miketwe__!~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com> has quit IRC (Remote host closed the connection)
840 2020-12-17T23:37:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
841 2020-12-17T23:37:04  <bitcoin-git> [gui] hebasto opened pull request #155: Fix checkbox layout in Create Wallet dialog (master...201218-i3) https://github.com/bitcoin-core/gui/pull/155
842 2020-12-17T23:37:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
843 2020-12-17T23:37:36  *** miketwenty1 <miketwenty1!~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com> has joined #bitcoin-core-dev
844 2020-12-17T23:41:47  <jeremyrubin> if anyone is curious to mess around, I put a CTV + Taproot signet up
845 2020-12-17T23:41:59  <jeremyrubin> signetchallenge=512102946e8ba8eca597194e7ed90377d9bbebc5d17a9609ab3e35e706612ee882759351ae
846 2020-12-17T23:42:08  <jeremyrubin> addnode "onetry"
847 2020-12-17T23:42:22  <jeremyrubin> fork: https://github.com/JeremyRubin/bitcoin/tree/checktemplateverify-signet
848 2020-12-17T23:42:53  <jeremyrubin> you shouldn't need the fork running to connect i think?
849 2020-12-17T23:43:20  *** viraltaco_ <viraltaco_!~taco@unaffiliated/d-b/x-8688605> has joined #bitcoin-core-dev
850 2020-12-17T23:43:36  <viraltaco_> Hi
851 2020-12-17T23:44:13  <viraltaco_> Does anyone know why the mempool is so large and the fees so high (Pretty sure those two events are correlated)
852 2020-12-17T23:44:17  *** pleia21 <pleia21!~pleia2@> has quit IRC (Remote host closed the connection)
853 2020-12-17T23:44:50  *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has quit IRC (Quit: No Ping reply in 180 seconds.)
854 2020-12-17T23:45:38  <viraltaco_> Did Segwit fail? :( should we use BSV? (jk)
855 2020-12-17T23:45:53  <jeremyrubin> viraltaco_: prolly wrong chan to discuss this in?
856 2020-12-17T23:46:06  *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has joined #bitcoin-core-dev
857 2020-12-17T23:46:55  <jeremyrubin> afaict fees don't seem crazy rn tho?
858 2020-12-17T23:47:06  <viraltaco_> Well, I don't know. This is really a question about how transactions are handled.
859 2020-12-17T23:47:23  <viraltaco_> They're not that high, but the mempool keeps growing :(
860 2020-12-17T23:47:34  <sipa> #bitcoin please