1 2020-12-23T00:02:36  *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-mfttzpvimjezxnps> has joined #bitcoin-core-dev
  2 2020-12-23T00:07:26  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
  3 2020-12-23T00:09:58  <sipa> justinmoon: sorry, no experience with docker
  4 2020-12-23T00:11:56  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 240 seconds)
  5 2020-12-23T00:13:08  *** filchef <filchef!~filchef@> has quit IRC (Read error: Connection reset by peer)
  6 2020-12-23T00:14:55  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
  7 2020-12-23T00:15:43  *** ghost43_ <ghost43_!~daer@gateway/tor-sasl/daer> has quit IRC (Ping timeout: 240 seconds)
  8 2020-12-23T00:18:07  <jonatack> justinmoon: https://github.com/jonatack/bitcoin-development/blob/master/gitian-building.md
  9 2020-12-23T00:18:45  <jonatack> (it's docker-based)
 10 2020-12-23T00:19:16  <phantomcircuit> MarcoFalke, btw https://github.com/bitcoin-core/qa-assets/pull/37
 11 2020-12-23T00:19:20  <phantomcircuit> that's actually merged
 12 2020-12-23T00:41:47  <justinmoon> jonatack: perfect, thanks
 13 2020-12-23T00:51:13  *** jonatack <jonatack!~jon@> has quit IRC (Ping timeout: 264 seconds)
 14 2020-12-23T00:53:08  *** jonatack <jonatack!~jon@> has joined #bitcoin-core-dev
 15 2020-12-23T00:57:17  *** jesseposner <jesseposner!~jp@2601:645:200:162f:da9:1617:a616:f7bc> has quit IRC (Ping timeout: 260 seconds)
 16 2020-12-23T00:57:25  *** jessepos_ <jessepos_!~jp@c-73-15-111-74.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
 17 2020-12-23T01:04:08  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
 18 2020-12-23T01:28:16  *** miketwen_ <miketwen_!~miketwent@ec2-54-235-98-1.compute-1.amazonaws.com> has quit IRC (Ping timeout: 246 seconds)
 19 2020-12-23T01:36:16  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
 20 2020-12-23T01:36:17  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
 21 2020-12-23T01:36:19  *** vasild_ is now known as vasild
 22 2020-12-23T01:37:40  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 256 seconds)
 23 2020-12-23T01:48:30  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 24 2020-12-23T01:59:40  *** roconnor <roconnor!~roconnor@host-45-78-199-13.dyn.295.ca> has joined #bitcoin-core-dev
 25 2020-12-23T02:27:37  *** instagibbs <instagibbs!~greg@061093103011.ctinets.com> has joined #bitcoin-core-dev
 26 2020-12-23T02:28:49  *** instagibbs <instagibbs!~greg@061093103011.ctinets.com> has quit IRC (Client Quit)
 27 2020-12-23T02:36:20  *** StopAndDecrypt <StopAndDecrypt!~StopAndDe@unaffiliated/stopanddecrypt> has quit IRC (Remote host closed the connection)
 28 2020-12-23T03:07:22  *** jessepos_ <jessepos_!~jp@c-73-15-111-74.hsd1.ca.comcast.net> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
 29 2020-12-23T03:07:45  *** jesseposner <jesseposner!~jp@2601:645:200:162f:1507:39f0:b918:b6c4> has joined #bitcoin-core-dev
 30 2020-12-23T03:18:58  *** brimstone1 <brimstone1!~brimstone@> has quit IRC (Remote host closed the connection)
 31 2020-12-23T03:34:43  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
 32 2020-12-23T04:07:16  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 256 seconds)
 33 2020-12-23T04:13:14  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 34 2020-12-23T04:13:14  <bitcoin-git> [bitcoin] pstratem opened pull request #20751: [fuzzing] Use subprocess.Popen call directly, remove use of thread pool. (master...2020-12-22-fuzz-test-runner) https://github.com/bitcoin/bitcoin/pull/20751
 35 2020-12-23T04:13:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 36 2020-12-23T04:46:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 37 2020-12-23T04:46:11  <bitcoin-git> [bitcoin] pstratem opened pull request #20752: [fuzzer] generate new seeds in an infinite loop with random parameters (master...2020-12-fuzz-test-runner-infinite-generate) https://github.com/bitcoin/bitcoin/pull/20752
 38 2020-12-23T04:46:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 39 2020-12-23T04:48:03  *** sr_gi <sr_gi!~sr_gi@> has quit IRC (Read error: Connection reset by peer)
 40 2020-12-23T04:48:42  *** sr_gi <sr_gi!~sr_gi@> has joined #bitcoin-core-dev
 41 2020-12-23T04:53:19  <phantomcircuit> sipa, ^ those seem to work nicely
 42 2020-12-23T04:57:02  <sipa> mutate_depth uniformly up to 15, wow
 43 2020-12-23T04:57:21  <sipa> i haven't experimented with that, but assumed that the default of 5 was pretty good
 44 2020-12-23T04:59:15  <sipa> phantomcircuit: i believe it also makes sense to vary the -max_len parameter
 45 2020-12-23T04:59:30  <sipa> giving proportionally more time to short inputs seems to help
 46 2020-12-23T05:00:43  <phantomcircuit> sipa, there's already a strong bias towards smaller inputs with another parameter which is uhhh
 47 2020-12-23T05:01:01  <phantomcircuit> len_control
 48 2020-12-23T05:03:46  <phantomcircuit> i might need to upstream to clang a change to the max_total_time behaviour, for process_message even with 300 seconds it exits after like 100 tests
 49 2020-12-23T05:04:23  <sipa> phantomcircuit: another possibility is just not starting with the full corpus, but just a random subset of limited size
 50 2020-12-23T05:06:04  <sipa> phantomcircuit: the len_control isn't useful for us i think... yes, you want short and long, but you don't want that within one run... we run so long that hopefully there is good coverage on all lengths already
 51 2020-12-23T05:06:36  <phantomcircuit> oh i forgot to add a sleep to the loop
 52 2020-12-23T05:06:37  <phantomcircuit> heh
 53 2020-12-23T05:07:13  <phantomcircuit> sipa, right so random max_len between like 100 and 4,000,000 ?
 54 2020-12-23T05:07:24  <sipa> by default max_len is 4096
 55 2020-12-23T05:07:41  <sipa> and len_control is on
 56 2020-12-23T05:07:43  <phantomcircuit> uh no by default it guesses based on the corpus
 57 2020-12-23T05:07:57  <phantomcircuit> which for process_message ends up being >1MiB
 58 2020-12-23T05:07:58  <sipa> oh, ok, but if the corpus has nothing big, it's set to 4096 afaik
 59 2020-12-23T05:08:20  <phantomcircuit> INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 1007323 bytes
 60 2020-12-23T05:08:48  <sipa> longer term i think we want an absolutely max_len configured for every target
 61 2020-12-23T05:08:52  <phantomcircuit> it's based on what's n the corpus and afaict the only way for it to grow is to have lots of things which are near the max and restart the process
 62 2020-12-23T05:09:01  <phantomcircuit> it'll then guess that max_len should be longer and bump it
 63 2020-12-23T05:19:57  <phantomcircuit> sipa, yeah agree, i suggested upto 4MiB since that's the largest valid network message, i think?
 64 2020-12-23T05:27:47  <sipa> but fuzzing with such large inputs is super slow
 65 2020-12-23T05:28:48  <sipa> so i think you want the max_len parameter exponentially distributed between say 64 and 4096 for most targets, and maybe forna few exceptions with a higher max
 66 2020-12-23T05:35:49  <phantomcircuit> 2 ** random.randint(1,12)
 67 2020-12-23T05:35:52  <phantomcircuit> maybe?
 68 2020-12-23T05:35:59  <phantomcircuit> actually that starts too small
 69 2020-12-23T05:36:12  <phantomcircuit> 2 ** random.randint(6,12)
 70 2020-12-23T05:40:02  <sipa> math.round(2.0 ** random.uniform(6.0, 12.0)) ?
 71 2020-12-23T05:41:19  <phantomcircuit> does the max length need to be uniformly within the range?
 72 2020-12-23T05:42:13  <phantomcircuit> maybe just powers of 2 is ok?
 73 2020-12-23T05:46:11  <sipa> that's not uniform
 74 2020-12-23T05:47:37  <phantomcircuit> sipa, ?
 75 2020-12-23T05:50:12  *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-mfttzpvimjezxnps> has quit IRC (Quit: Connection closed for inactivity)
 76 2020-12-23T05:50:52  <sipa> 2**random.uniform is exponential, not uniform
 77 2020-12-23T05:56:28  <phantomcircuit> sipa, oh no i mean like instead of powers of 2 that will also be values inbetween
 78 2020-12-23T05:56:37  <phantomcircuit> it's still distributed exponentially
 79 2020-12-23T05:59:18  <sipa> yeah, why restrict to just powers of 2? :)
 80 2020-12-23T05:59:26  <sipa> (no strong opinion, i'm sure it's all fine)
 81 2020-12-23T06:02:10  <phantomcircuit> btw the largest corpus i have is now for the bloom_filter and asmap tests which is interesting
 82 2020-12-23T06:02:34  <phantomcircuit> i think the process message one just explodes trying to load it's corpus actually
 83 2020-12-23T06:03:14  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
 84 2020-12-23T06:04:18  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
 85 2020-12-23T06:37:40  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 246 seconds)
 86 2020-12-23T06:41:16  <phantomcircuit> sipa, yeah i tried specifying -runs instead of -max_total_time and im running into the problem i thought i would
 87 2020-12-23T06:41:33  <phantomcircuit> all the processes are now expensive things to run cause they sort of clog up the works
 88 2020-12-23T07:04:03  *** jessepos_ <jessepos_!~jp@2601:645:200:162f:b9d5:4819:405c:7ac5> has joined #bitcoin-core-dev
 89 2020-12-23T07:06:13  *** jesseposner <jesseposner!~jp@2601:645:200:162f:1507:39f0:b918:b6c4> has quit IRC (Ping timeout: 258 seconds)
 90 2020-12-23T07:37:43  *** gleb <gleb!~gleb@> has quit IRC (Ping timeout: 260 seconds)
 91 2020-12-23T07:54:30  *** dgenr8 <dgenr8!~dgenr8@unaffiliated/dgenr8> has quit IRC (Ping timeout: 268 seconds)
 92 2020-12-23T08:06:47  *** dgenr8 <dgenr8!~dgenr8@unaffiliated/dgenr8> has joined #bitcoin-core-dev
 93 2020-12-23T08:13:58  *** zeromus1 <zeromus1!~zeromus@> has joined #bitcoin-core-dev
 94 2020-12-23T08:26:40  *** jessepos_ <jessepos_!~jp@2601:645:200:162f:b9d5:4819:405c:7ac5> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
 95 2020-12-23T08:27:05  *** jesseposner <jesseposner!~jp@2601:645:200:162f:b9d5:4819:405c:7ac5> has joined #bitcoin-core-dev
 96 2020-12-23T08:27:57  <jonasschnelli> what is the reason to extend the fuzzer seeds? Catching more potential issues?
 97 2020-12-23T08:30:20  <sipa> jonasschnelli: that's literally what fuzzing is
 98 2020-12-23T08:30:25  <sipa> finding more seeds
 99 2020-12-23T08:30:59  <sipa> finding more inputs that cover more code, or more potential issues
100 2020-12-23T08:31:07  <jonasschnelli> I think my understanding of fuzzing is weak... I need to read more about it first
101 2020-12-23T08:31:32  <jonasschnelli> I always thought its running a random stream against all possible APIs for a very long time
102 2020-12-23T08:32:27  <sipa> every fuzz target is a function that takes a byte array, and uses it to decide what things to call
103 2020-12-23T08:32:40  <sipa> some targets just call functions, and don't do anything elae
104 2020-12-23T08:33:13  <jonasschnelli> okay. I get that.
105 2020-12-23T08:33:15  <sipa> others have full simulators of what the expected behaviour is going to be and compares with it
106 2020-12-23T08:33:28  <sipa> fuzzing is finding those input byte arrays, called seeds
107 2020-12-23T08:33:47  <sipa> it does that by applying random mutations to existing seeds
108 2020-12-23T08:33:59  <sipa> or trying new things
109 2020-12-23T08:35:09  <sipa> when people spend CPU time fuzzing, the output is finding more seeds, because it somehow found something that appears either more interesting than all seeds there were before, or because it does the same but with a smaller seed
110 2020-12-23T08:35:22  <jonasschnelli> so the seeds are actually not a random-stream-seeds that is used for pure fuzzing of a function(or API)? They decide what to call?
111 2020-12-23T08:35:25  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
112 2020-12-23T08:35:41  <sipa> that's right, they are the exact input fed to the fuzz target
113 2020-12-23T08:36:31  <sipa> our CI infrastructure also runs these seeds as part of the tests, but without trying to generate more
114 2020-12-23T08:36:48  <jonasschnelli> you wrote "more interesting",.. does the fuzz target track to code paths (or percentage) beeing used?
115 2020-12-23T08:36:54  <sipa> yes
116 2020-12-23T08:36:56  <sipa> and more
117 2020-12-23T08:37:08  <jonasschnelli> I see
118 2020-12-23T08:37:22  <sipa> it has counters for various things; code blocks, branches, ..
119 2020-12-23T08:37:56  <sipa> if you run in -use_value_profile mode it counts specific values seen in comparisons too
120 2020-12-23T08:37:56  <jonasschnelli> so one can say there are "better" and "weaker" seeds?
121 2020-12-23T08:38:10  <sipa> it"s the combimed corpus that matters
122 2020-12-23T08:38:29  <sipa> but the goal is ultimately finding a small combined corpus with maximal coverage
123 2020-12-23T08:38:44  <jonasschnelli> the more counters a seed hits the better,.. but overall, you want all "counter" to be hit by a range of seeds?
124 2020-12-23T08:38:55  <sipa> right
125 2020-12-23T08:39:05  <jonasschnelli> thanks. TIL
126 2020-12-23T08:39:28  *** dviola <dviola!~diego@> has left #bitcoin-core-dev
127 2020-12-23T08:39:35  <sipa> it's annoying that you need a separate build/configure foe it
128 2020-12-23T08:39:44  <sipa> i have a separate worktree for that
129 2020-12-23T08:40:06  <sipa> it's fun to play with
130 2020-12-23T08:40:12  <jonasschnelli> Yes. That's the reason why I haven't looked closer into it. :)
131 2020-12-23T08:40:28  <sipa> just follow doc/fuzzing.md
132 2020-12-23T08:40:37  <jonasschnelli> will do
133 2020-12-23T08:40:54  <sipa> we have a test/fuzz/test_runner.py that lets you more easily do larger scale testing
134 2020-12-23T08:41:17  <sipa> but just running a fuzzer directly will prpbably be more informative
135 2020-12-23T08:41:57  <sipa> just compile with --with-sanitizers=fuzzer --enable-fuzz, and run e.g. FUZZ=asmap src/test/fuzz/fuzz
136 2020-12-23T08:42:13  *** dviola <dviola!~diego@unaffiliated/dviola> has joined #bitcoin-core-dev
137 2020-12-23T08:42:31  <jonasschnelli> ok
138 2020-12-23T08:42:37  <sipa> it'll test you when it finds new inputs, and some metrics about coverage
139 2020-12-23T08:42:54  <sipa> you need to specify a dir name to leg it save its seeds
140 2020-12-23T08:43:28  <sipa> *let
141 2020-12-23T08:44:16  <sipa> *tell
142 2020-12-23T08:47:04  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
143 2020-12-23T08:58:25  *** kexkey <kexkey!~kexkey@static-198-54-132-154.cust.tzulo.com> has quit IRC (Read error: Connection reset by peer)
144 2020-12-23T08:58:25  *** sr_gi <sr_gi!~sr_gi@> has quit IRC (Read error: Connection reset by peer)
145 2020-12-23T08:58:49  *** brianhoffman <brianhoffman!~brianhoff@pool-71-191-34-154.washdc.fios.verizon.net> has quit IRC (Read error: Connection reset by peer)
146 2020-12-23T08:58:53  *** sr_gi <sr_gi!~sr_gi@> has joined #bitcoin-core-dev
147 2020-12-23T08:59:10  *** brianhoffman <brianhoffman!~brianhoff@pool-71-191-34-154.washdc.fios.verizon.net> has joined #bitcoin-core-dev
148 2020-12-23T08:59:50  *** tlev <tlev!~tlev@li120-195.members.linode.com> has joined #bitcoin-core-dev
149 2020-12-23T09:02:47  *** tlev1 <tlev1!~tlev@li120-195.members.linode.com> has quit IRC (Ping timeout: 265 seconds)
150 2020-12-23T09:07:49  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 246 seconds)
151 2020-12-23T09:10:05  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
152 2020-12-23T09:21:04  *** shesek <shesek!~shesek@> has joined #bitcoin-core-dev
153 2020-12-23T09:28:23  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
154 2020-12-23T09:31:23  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
155 2020-12-23T09:45:16  *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Ping timeout: 240 seconds)
156 2020-12-23T09:47:37  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 264 seconds)
157 2020-12-23T09:57:02  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:d16a:4949:3622:4cc0> has quit IRC (Ping timeout: 264 seconds)
158 2020-12-23T10:05:20  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 272 seconds)
159 2020-12-23T10:29:23  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
160 2020-12-23T10:31:22  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
161 2020-12-23T10:33:29  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Client Quit)
162 2020-12-23T10:38:32  *** justan0theruser <justan0theruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 268 seconds)
163 2020-12-23T10:44:05  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 240 seconds)
164 2020-12-23T11:11:55  *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
165 2020-12-23T11:17:37  *** rmstar <rmstar!~rmstar@> has joined #bitcoin-core-dev
166 2020-12-23T11:18:37  *** Santa41Langosh <Santa41Langosh!~Santa41La@static.> has joined #bitcoin-core-dev
167 2020-12-23T11:23:24  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
168 2020-12-23T11:23:32  *** Santa41Langosh <Santa41Langosh!~Santa41La@static.> has quit IRC (Ping timeout: 256 seconds)
169 2020-12-23T11:34:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
170 2020-12-23T11:34:41  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/98de9eb1aa84...e669c3156ff8
171 2020-12-23T11:34:42  <bitcoin-git> bitcoin/master fa957f8 MarcoFalke: test: Add race:SendZmqMessage tsan suppression
172 2020-12-23T11:34:42  <bitcoin-git> bitcoin/master e669c31 MarcoFalke: Merge #20748: test: Add race:SendZmqMessage tsan suppression
173 2020-12-23T11:34:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
174 2020-12-23T11:34:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
175 2020-12-23T11:34:56  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20748: test: Add race:SendZmqMessage tsan suppression (master...2012-ciSuppZmq) https://github.com/bitcoin/bitcoin/pull/20748
176 2020-12-23T11:34:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
177 2020-12-23T11:36:00  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 265 seconds)
178 2020-12-23T11:37:40  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
179 2020-12-23T11:45:28  *** justan0theruser <justan0theruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
180 2020-12-23T11:57:27  *** zeromus1 <zeromus1!~zeromus@> has quit IRC (Remote host closed the connection)
181 2020-12-23T12:08:53  *** pergaminho <pergaminho!~Cleber@> has joined #bitcoin-core-dev
182 2020-12-23T12:09:13  *** sr_gi <sr_gi!~sr_gi@> has quit IRC (Ping timeout: 264 seconds)
183 2020-12-23T12:24:20  *** vosechu <vosechu!~vosechu@> has joined #bitcoin-core-dev
184 2020-12-23T12:36:25  *** jonatack <jonatack!~jon@> has quit IRC (Ping timeout: 240 seconds)
185 2020-12-23T13:32:56  *** justan0theruser <justan0theruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 240 seconds)
186 2020-12-23T13:36:17  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
187 2020-12-23T13:36:18  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
188 2020-12-23T13:36:18  *** vasild_ is now known as vasild
189 2020-12-23T13:37:11  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
190 2020-12-23T13:54:25  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Read error: Connection reset by peer)
191 2020-12-23T13:54:55  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
192 2020-12-23T13:57:36  *** molz_ <molz_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
193 2020-12-23T14:05:47  *** miketwenty1 <miketwenty1!~miketwent@> has joined #bitcoin-core-dev
194 2020-12-23T14:31:30  *** gleb <gleb!~gleb@> has joined #bitcoin-core-dev
195 2020-12-23T14:35:15  *** joerodgers <joerodgers!joerodgers@gateway/vpn/mullvad/joerodgers/x-62861712> has joined #bitcoin-core-dev
196 2020-12-23T14:39:28  *** joerodgers <joerodgers!joerodgers@gateway/vpn/mullvad/joerodgers/x-62861712> has quit IRC (Client Quit)
197 2020-12-23T14:54:09  *** jonatack <jonatack!~jon@> has joined #bitcoin-core-dev
198 2020-12-23T14:54:24  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
199 2020-12-23T14:58:31  *** jonatack <jonatack!~jon@> has quit IRC (Ping timeout: 246 seconds)
200 2020-12-23T14:58:58  *** jonatack <jonatack!~jon@> has joined #bitcoin-core-dev
201 2020-12-23T14:59:12  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 272 seconds)
202 2020-12-23T15:11:46  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
203 2020-12-23T15:13:56  *** udecker <udecker!~udecker@> has quit IRC (Quit: udecker)
204 2020-12-23T15:17:07  *** pmuens <pmuens!5fde1c8f@aftr-95-222-28-143.unity-media.net> has joined #bitcoin-core-dev
205 2020-12-23T15:20:32  *** pmuens <pmuens!5fde1c8f@aftr-95-222-28-143.unity-media.net> has left #bitcoin-core-dev
206 2020-12-23T15:27:30  *** miketwen_ <miketwen_!~miketwent@ec2-54-235-98-1.compute-1.amazonaws.com> has joined #bitcoin-core-dev
207 2020-12-23T15:30:56  *** miketwenty1 <miketwenty1!~miketwent@> has quit IRC (Ping timeout: 240 seconds)
208 2020-12-23T15:33:56  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 240 seconds)
209 2020-12-23T15:58:02  *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
210 2020-12-23T16:00:06  *** awesome_doge <awesome_doge!awesome-do@gateway/shell/matrix.org/x-rnzdvvnshecmqbvf> has quit IRC (Quit: Idle for 30+ days)
211 2020-12-23T16:01:10  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 246 seconds)
212 2020-12-23T16:01:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
213 2020-12-23T16:01:45  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20753: rpc: Allow to ignore specific policy reject reasons (master...2012-policyRpcIgnore) https://github.com/bitcoin/bitcoin/pull/20753
214 2020-12-23T16:01:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
215 2020-12-23T16:03:26  *** belcher_ is now known as belcher
216 2020-12-23T16:08:26  *** Zenton <Zenton!~user@unaffiliated/vicenteh> has quit IRC (Read error: Connection reset by peer)
217 2020-12-23T16:19:24  *** Zenton <Zenton!~user@unaffiliated/vicenteh> has joined #bitcoin-core-dev
218 2020-12-23T16:31:49  *** IGHOR <IGHOR!~quassel@> has quit IRC (Quit: No Ping reply in 180 seconds.)
219 2020-12-23T16:33:06  *** IGHOR <IGHOR!~quassel@> has joined #bitcoin-core-dev
220 2020-12-23T16:34:22  *** kristapsk_ <kristapsk_!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
221 2020-12-23T16:34:57  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
222 2020-12-23T16:37:38  *** DeanWeen <DeanWeen!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
223 2020-12-23T16:38:25  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
224 2020-12-23T16:45:19  *** Mercury_Vapor <Mercury_Vapor!~Mercury_V@174-082-166-092.res.spectrum.com> has joined #bitcoin-core-dev
225 2020-12-23T16:47:45  *** Chlorine_Vapor <Chlorine_Vapor!~Mercury_V@174-082-166-092.res.spectrum.com> has quit IRC (Ping timeout: 265 seconds)
226 2020-12-23T17:05:05  <luke-jr> MarcoFalke: you know #7533 is still maintained, right? could just reopen that..
227 2020-12-23T17:05:07  <gribble> https://github.com/bitcoin/bitcoin/issues/7533 | RPC: sendrawtransaction: Allow the user to ignore/override specific rejections by luke-jr · Pull Request #7533 · bitcoin/bitcoin · GitHub
228 2020-12-23T17:13:32  *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-ulfmeztuqwvevqbn> has joined #bitcoin-core-dev
229 2020-12-23T17:20:05  <MarcoFalke> luke-jr: Sure, happy to repoen
230 2020-12-23T17:20:29  <MarcoFalke> It was tagged "up for grabs", so I implemented a minimal patch that still achieves a goal
231 2020-12-23T17:21:00  <MarcoFalke> you can rebase on top of mine, if you want
232 2020-12-23T17:23:03  <luke-jr> MarcoFalke: at this point, I guess it might be more productive if I just review yours and get that in first
233 2020-12-23T17:25:18  <luke-jr> just seemed strange to go about it that way *shrug*
234 2020-12-23T17:26:52  <MarcoFalke> Yeah, I wasn't aware that 7533 is still maintained
235 2020-12-23T17:33:21  <luke-jr> ah
236 2020-12-23T17:45:56  <miketwen_> looking for some clarity here.. smartfee estimator is used by default for bitcoin node correct? if you are not synced with the blockchain it will use fallbackfee if enabled. correct? In terms of priority or the decision tree I'm wondering how this relates with paytxfee..  and then I would guess settxfee would be the same logic as paytxfee but replace paytxfee?
237 2020-12-23T17:49:40  *** miketwen_ is now known as miketwenty1
238 2020-12-23T17:51:54  <jonatack> miketwenty1: right, settxfee overrides (global) -paytxfee setting
239 2020-12-23T17:52:36  *** Mercury_Vapor <Mercury_Vapor!~Mercury_V@174-082-166-092.res.spectrum.com> has quit IRC (Ping timeout: 240 seconds)
240 2020-12-23T17:53:03  <jonatack> settxfee is per-wallet
241 2020-12-23T17:53:27  <miketwenty1> settxfee overrides smartfee estimate?
242 2020-12-23T17:53:41  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:d16a:4949:3622:4cc0> has joined #bitcoin-core-dev
243 2020-12-23T17:56:00  <jonatack> miketwenty1: yes iirc, see: ./src/bitcoin-cli help settxfee
244 2020-12-23T17:57:38  <miketwenty1> jonatack: there are many flags for targets / fees and such.. has anyone made a diagram or decision tree on what takes priority over what by any chance?
245 2020-12-23T17:57:55  <miketwenty1> in terms of what fee gets paid for a tx
246 2020-12-23T17:59:46  *** pergaminho <pergaminho!~Cleber@> has quit IRC (Quit: Saindo)
247 2020-12-23T17:59:51  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
248 2020-12-23T18:04:04  <jonatack> miketwenty1: i agree that it's a bit confusing. if you want to set an explicit fee rate, know that in 0.21 and master it is now possible to pass the fee rate (not absolute fee, but the fee rate) in sat/vB with all of the various send commands (fee_rate param, see the rpc help)
249 2020-12-23T18:05:01  *** sishir <sishir!465dca45@cpe-70-93-202-69.natsow.res.rr.com> has joined #bitcoin-core-dev
250 2020-12-23T18:05:12  *** sishir <sishir!465dca45@cpe-70-93-202-69.natsow.res.rr.com> has quit IRC (Remote host closed the connection)
251 2020-12-23T18:05:14  <jonatack> miketwenty1: i've noted your suggestion to clarify this somewhere, thanks
252 2020-12-23T18:25:40  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
253 2020-12-23T18:34:14  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
254 2020-12-23T18:34:32  *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has quit IRC (Ping timeout: 272 seconds)
255 2020-12-23T18:34:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
256 2020-12-23T18:34:57  <bitcoin-git> [bitcoin] amitiuttarwar opened pull request #20755: [rpc] Remove deprecated fields from getpeerinfo (master...2020-12-getpeerinfo-deprecate) https://github.com/bitcoin/bitcoin/pull/20755
257 2020-12-23T18:34:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
258 2020-12-23T18:36:35  *** Mercury_Vapor <Mercury_Vapor!~Mercury_V@174-082-158-108.res.spectrum.com> has joined #bitcoin-core-dev
259 2020-12-23T18:53:49  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
260 2020-12-23T18:56:02  *** xs1 <xs1!55677ca3@> has joined #bitcoin-core-dev
261 2020-12-23T18:56:46  *** xs1 <xs1!55677ca3@> has quit IRC (Remote host closed the connection)
262 2020-12-23T18:57:53  <jonatack> miketwenty1: i've begun improving the settxfee help and (new rpc) setfeerate help in #20391 and will look at updating both helps with more info
263 2020-12-23T18:57:57  <gribble> https://github.com/bitcoin/bitcoin/issues/20391 | wallet: introduce setfeerate (an improved settxfee, in sat/vB) by jonatack · Pull Request #20391 · bitcoin/bitcoin · GitHub
264 2020-12-23T18:59:17  <jonatack> and will do the same for estimatesmartfee and the (new rpc) estimatefeerate helps (the new RPCs are in sat/vB)
265 2020-12-23T19:01:06  <jonatack> and work to make these RPCs more user-friendly and reassuring to use
266 2020-12-23T19:27:00  *** promag_ <promag_!~promag@> has quit IRC (Remote host closed the connection)
267 2020-12-23T19:27:32  *** promag <promag!~promag@> has joined #bitcoin-core-dev
268 2020-12-23T19:49:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
269 2020-12-23T19:49:03  <bitcoin-git> [bitcoin] amitiuttarwar opened pull request #20756: [doc] Add missing field (permissions) to the getpeerinfo help (master...2020-12-getpeerinfo-permissions) https://github.com/bitcoin/bitcoin/pull/20756
270 2020-12-23T19:49:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
271 2020-12-23T19:58:50  <justinmoon> FYI: jonatack's docker-based gitian guide (https://github.com/jonatack/bitcoin-development/blob/master/gitian-building.md) is much easier to follow than the official virtualbox-based docs (https://github.com/bitcoin-core/docs)
272 2020-12-23T20:06:06  <jonatack> thanks! it's based on fanquake's guide
273 2020-12-23T20:22:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
274 2020-12-23T20:22:23  <bitcoin-git> [gui] hebasto opened pull request #161: Rework RPCConsole::banSelectedNode function (master...201223-ban) https://github.com/bitcoin-core/gui/pull/161
275 2020-12-23T20:22:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
276 2020-12-23T20:22:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
277 2020-12-23T20:22:49  <bitcoin-git> [bitcoin] jonatack opened pull request #20757: doc: tor.md and -onlynet helpupdate -onlynet help in src/init.cpp (master...tor-md-doc-updates) https://github.com/bitcoin/bitcoin/pull/20757
278 2020-12-23T20:22:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
279 2020-12-23T20:23:48  <jonatack> ^ when github opens the pull before you finished typing the title
280 2020-12-23T20:48:29  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
281 2020-12-23T20:52:39  *** jesseposner <jesseposner!~jp@2601:645:200:162f:b9d5:4819:405c:7ac5> has quit IRC (Quit: My Mac Mini has gone to sleep. ZZZzzz…)
282 2020-12-23T21:01:19  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
283 2020-12-23T21:01:22  *** vosechu <vosechu!~vosechu@> has quit IRC (Remote host closed the connection)
284 2020-12-23T21:01:34  *** promag <promag!~promag@> has joined #bitcoin-core-dev
285 2020-12-23T21:05:02  *** rh0nj <rh0nj!~rh0nj@> has quit IRC (Remote host closed the connection)
286 2020-12-23T21:05:49  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
287 2020-12-23T21:06:08  *** rh0nj <rh0nj!~rh0nj@> has joined #bitcoin-core-dev
288 2020-12-23T21:06:29  *** promag <promag!~promag@> has joined #bitcoin-core-dev
289 2020-12-23T21:11:32  *** TheV01d <TheV01d!thev01d@2001:19c0:1:801:851:ff00:1:6> has quit IRC (Ping timeout: 246 seconds)
290 2020-12-23T21:11:48  *** thrasher` <thrasher`!~thrasher@> has quit IRC (Ping timeout: 256 seconds)
291 2020-12-23T21:12:00  *** TheV01d <TheV01d!thev01d@2001:19c0:1:801:851:ff00:1:6> has joined #bitcoin-core-dev
292 2020-12-23T21:13:49  *** thrasher` <thrasher`!~thrasher@> has joined #bitcoin-core-dev
293 2020-12-23T21:21:06  *** vladan1 <vladan1!~vladan@> has joined #bitcoin-core-dev
294 2020-12-23T21:24:06  *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has joined #bitcoin-core-dev
295 2020-12-23T21:25:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
296 2020-12-23T21:25:38  <bitcoin-git> [bitcoin] ajtowns opened pull request #20758: net-processing refactoring -- lose globals, move implementation details from .h to .cpp (master...202012-netproc-refactor) https://github.com/bitcoin/bitcoin/pull/20758
297 2020-12-23T21:25:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
298 2020-12-23T21:59:01  *** mdrollette <mdrollette!~mdrollett@cpe-70-123-125-237.tx.res.rr.com> has quit IRC (Quit: bye)
299 2020-12-23T22:15:15  *** pbarry_ <pbarry_!~textual@2601:644:8b00:3800:f098:86ee:2e57:2479> has joined #bitcoin-core-dev
300 2020-12-23T22:17:40  *** Asbestos_Vapor <Asbestos_Vapor!~Mercury_V@174-082-158-108.res.spectrum.com> has joined #bitcoin-core-dev
301 2020-12-23T22:19:10  *** Mercury_Vapor <Mercury_Vapor!~Mercury_V@174-082-158-108.res.spectrum.com> has quit IRC (Ping timeout: 246 seconds)
302 2020-12-23T22:24:08  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
303 2020-12-23T22:24:38  *** pbarry_ <pbarry_!~textual@2601:644:8b00:3800:f098:86ee:2e57:2479> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
304 2020-12-23T22:25:02  *** Lightsword <Lightsword!~Lightswor@2604:a880:1:20::1d3:9001> has joined #bitcoin-core-dev
305 2020-12-23T22:27:29  *** Lightsword <Lightsword!~Lightswor@2604:a880:1:20::1d3:9001> has quit IRC (Client Quit)
306 2020-12-23T22:28:33  *** pbarry_ <pbarry_!~textual@2601:644:8b00:3800:f098:86ee:2e57:2479> has joined #bitcoin-core-dev
307 2020-12-23T22:29:37  *** Lightsword <Lightsword!~Lightswor@2604:a880:1:20::1d3:9001> has joined #bitcoin-core-dev
308 2020-12-23T22:32:13  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
309 2020-12-23T23:02:22  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
310 2020-12-23T23:32:04  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
311 2020-12-23T23:33:43  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
312 2020-12-23T23:33:57  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
313 2020-12-23T23:35:52  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Remote host closed the connection)
314 2020-12-23T23:39:02  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
315 2020-12-23T23:46:43  *** pbarry_ <pbarry_!~textual@2601:644:8b00:3800:f098:86ee:2e57:2479> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
316 2020-12-23T23:51:56  *** pbarry_ <pbarry_!~textual@2601:644:8b00:3800:f098:86ee:2e57:2479> has joined #bitcoin-core-dev