1 2021-01-03T00:00:59  *** ccdle12 <ccdle12!~ccdle12@gateway/tor-sasl/ccdle12> has joined #bitcoin-core-dev
  2 2021-01-03T00:34:39  *** Johnny10 <Johnny10!2e07f79b@46.7.247.155> has joined #bitcoin-core-dev
  3 2021-01-03T00:35:27  *** Johnny10 <Johnny10!2e07f79b@46.7.247.155> has left #bitcoin-core-dev
  4 2021-01-03T00:37:40  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
  5 2021-01-03T00:40:23  *** ccdle12 <ccdle12!~ccdle12@gateway/tor-sasl/ccdle12> has quit IRC (Ping timeout: 240 seconds)
  6 2021-01-03T00:51:05  *** lightlike <lightlike!~lightlike@p200300c7ef39ff00a985b2151ad7bc60.dip0.t-ipconnect.de> has quit IRC (Quit: Leaving)
  7 2021-01-03T00:51:15  *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
  8 2021-01-03T00:51:51  *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
  9 2021-01-03T00:56:52  *** Zenton <Zenton!~user@unaffiliated/vicenteh> has quit IRC (Ping timeout: 272 seconds)
 10 2021-01-03T00:58:24  *** ccdle12 <ccdle12!~ccdle12@gateway/tor-sasl/ccdle12> has joined #bitcoin-core-dev
 11 2021-01-03T00:58:25  *** Zenton <Zenton!~user@unaffiliated/vicenteh> has joined #bitcoin-core-dev
 12 2021-01-03T01:03:15  *** tlev9 <tlev9!~tlev@li120-195.members.linode.com> has joined #bitcoin-core-dev
 13 2021-01-03T01:03:16  *** tlev <tlev!~tlev@li120-195.members.linode.com> has quit IRC (Read error: Connection reset by peer)
 14 2021-01-03T01:03:17  *** tlev9 is now known as tlev
 15 2021-01-03T01:03:47  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
 16 2021-01-03T01:03:50  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 264 seconds)
 17 2021-01-03T01:06:15  *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-krcbvlexiytkhjit> has quit IRC (*.net *.split)
 18 2021-01-03T01:06:37  *** esotericnonsense <esotericnonsense!~esotericn@unaffiliated/esotericnonsense> has quit IRC (*.net *.split)
 19 2021-01-03T01:06:37  *** nkuttler <nkuttler!~nkuttler@unaffiliated/nkuttler> has quit IRC (*.net *.split)
 20 2021-01-03T01:06:37  *** berndj <berndj!~berndj@ns2.linksynergy.co.za> has quit IRC (*.net *.split)
 21 2021-01-03T01:06:37  *** exhoplex <exhoplex!~echo@139.180.133.130> has quit IRC (*.net *.split)
 22 2021-01-03T01:06:37  *** niftynei <niftynei!~niftynei@104.131.77.55> has quit IRC (*.net *.split)
 23 2021-01-03T01:06:37  *** comboy <comboy!~quassel@tesuji.pl> has quit IRC (*.net *.split)
 24 2021-01-03T01:06:37  *** asukan <asukan!~quassel@ec2-35-180-180-58.eu-west-3.compute.amazonaws.com> has quit IRC (*.net *.split)
 25 2021-01-03T01:06:37  *** lio17 <lio17!~lio17@80.ip-145-239-89.eu> has quit IRC (*.net *.split)
 26 2021-01-03T01:06:37  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has joined #bitcoin-core-dev
 27 2021-01-03T01:08:02  *** esotericnonsense <esotericnonsense!~esotericn@unaffiliated/esotericnonsense> has joined #bitcoin-core-dev
 28 2021-01-03T01:08:02  *** nkuttler <nkuttler!~nkuttler@unaffiliated/nkuttler> has joined #bitcoin-core-dev
 29 2021-01-03T01:09:26  *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-krcbvlexiytkhjit> has joined #bitcoin-core-dev
 30 2021-01-03T01:09:26  *** berndj <berndj!~berndj@ns2.linksynergy.co.za> has joined #bitcoin-core-dev
 31 2021-01-03T01:09:26  *** exhoplex <exhoplex!~echo@139.180.133.130> has joined #bitcoin-core-dev
 32 2021-01-03T01:09:26  *** niftynei <niftynei!~niftynei@104.131.77.55> has joined #bitcoin-core-dev
 33 2021-01-03T01:09:26  *** comboy <comboy!~quassel@tesuji.pl> has joined #bitcoin-core-dev
 34 2021-01-03T01:09:26  *** asukan <asukan!~quassel@ec2-35-180-180-58.eu-west-3.compute.amazonaws.com> has joined #bitcoin-core-dev
 35 2021-01-03T01:09:26  *** lio17 <lio17!~lio17@80.ip-145-239-89.eu> has joined #bitcoin-core-dev
 36 2021-01-03T01:10:01  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 246 seconds)
 37 2021-01-03T01:10:10  *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-krcbvlexiytkhjit> has quit IRC (Ping timeout: 249 seconds)
 38 2021-01-03T01:11:22  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has joined #bitcoin-core-dev
 39 2021-01-03T01:12:24  *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-ouuqpqzypguzxydq> has joined #bitcoin-core-dev
 40 2021-01-03T01:13:03  <luke-jr> #20741 looks ready for merge
 41 2021-01-03T01:13:05  <gribble> https://github.com/bitcoin/bitcoin/issues/20741 | doc: Update Secure string handling by prayank23 · Pull Request #20741 · bitcoin/bitcoin · GitHub
 42 2021-01-03T01:13:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 43 2021-01-03T01:13:12  <bitcoin-git> [bitcoin] eilx2 opened pull request #20832: rpc: Better error messages for invalid addresses (master...master) https://github.com/bitcoin/bitcoin/pull/20832
 44 2021-01-03T01:13:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 45 2021-01-03T01:15:09  *** ccdle12 <ccdle12!~ccdle12@gateway/tor-sasl/ccdle12> has quit IRC (Remote host closed the connection)
 46 2021-01-03T01:33:49  *** andytoshi <andytoshi!~apoelstra@wpsoftware.net> has joined #bitcoin-core-dev
 47 2021-01-03T01:34:39  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
 48 2021-01-03T01:35:58  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
 49 2021-01-03T01:36:45  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
 50 2021-01-03T01:36:45  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
 51 2021-01-03T01:36:47  *** vasild_ is now known as vasild
 52 2021-01-03T01:37:04  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
 53 2021-01-03T01:38:30  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
 54 2021-01-03T02:13:40  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 55 2021-01-03T02:13:58  <aj> sipa: if you're around and bored, did you want to give a hot take on the new top commit (marked DRAFT) on #19438 ?
 56 2021-01-03T02:14:00  <gribble> https://github.com/bitcoin/bitcoin/issues/19438 | Introduce deploymentstatus by ajtowns · Pull Request #19438 · bitcoin/bitcoin · GitHub
 57 2021-01-03T02:14:23  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
 58 2021-01-03T02:18:50  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
 59 2021-01-03T02:19:17  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
 60 2021-01-03T02:32:34  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
 61 2021-01-03T02:33:03  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 260 seconds)
 62 2021-01-03T02:38:57  *** lightningbot <lightningbot!lightningb@cerulean.erisian.com.au> has joined #bitcoin-core-dev
 63 2021-01-03T02:39:18  *** andytosh1 <andytosh1!~apoelstra@wpsoftware.net> has joined #bitcoin-core-dev
 64 2021-01-03T02:39:29  *** rc_423_ <rc_423_!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
 65 2021-01-03T02:42:40  *** niftynei_ <niftynei_!~niftynei@104.131.77.55> has joined #bitcoin-core-dev
 66 2021-01-03T02:43:52  *** andytoshi <andytoshi!~apoelstra@unaffiliated/andytoshi> has quit IRC (*.net *.split)
 67 2021-01-03T02:43:52  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (*.net *.split)
 68 2021-01-03T02:43:52  *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (*.net *.split)
 69 2021-01-03T02:43:53  *** queip <queip!~queip@unaffiliated/rezurus> has quit IRC (*.net *.split)
 70 2021-01-03T02:43:53  *** spinza <spinza!~spin@102.132.245.16> has quit IRC (*.net *.split)
 71 2021-01-03T02:43:54  *** MickSaunders <MickSaunders!~michael@193.105.188.215> has quit IRC (*.net *.split)
 72 2021-01-03T02:43:54  *** Anduck <Anduck!~anduck@unaffiliated/anduck> has quit IRC (*.net *.split)
 73 2021-01-03T02:43:54  *** rabidus_ <rabidus_!~rabidus@dsl-olubng12-54fa17-92.dhcp.inet.fi> has quit IRC (*.net *.split)
 74 2021-01-03T02:43:54  *** romanz <romanz!~romanz@93.123.196.104.bc.googleusercontent.com> has quit IRC (*.net *.split)
 75 2021-01-03T02:43:54  *** Nebraskka <Nebraskka!~Nebraskka@51.83.249.56> has quit IRC (*.net *.split)
 76 2021-01-03T02:43:54  *** so <so!~so@unaffiliated/so> has quit IRC (*.net *.split)
 77 2021-01-03T02:43:54  *** adam3us <adam3us!~adam3us@unaffiliated/adam3us> has quit IRC (*.net *.split)
 78 2021-01-03T02:43:54  *** m1rror5 <m1rror5!~cataly5m@static.65.177.203.116.clients.your-server.de> has quit IRC (*.net *.split)
 79 2021-01-03T02:43:55  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (*.net *.split)
 80 2021-01-03T02:43:56  *** berndj <berndj!~berndj@ns2.linksynergy.co.za> has quit IRC (*.net *.split)
 81 2021-01-03T02:43:56  *** exhoplex <exhoplex!~echo@139.180.133.130> has quit IRC (*.net *.split)
 82 2021-01-03T02:43:56  *** niftynei <niftynei!~niftynei@104.131.77.55> has quit IRC (*.net *.split)
 83 2021-01-03T02:43:56  *** comboy <comboy!~quassel@tesuji.pl> has quit IRC (*.net *.split)
 84 2021-01-03T02:43:56  *** asukan <asukan!~quassel@ec2-35-180-180-58.eu-west-3.compute.amazonaws.com> has quit IRC (*.net *.split)
 85 2021-01-03T02:43:56  *** lio17 <lio17!~lio17@80.ip-145-239-89.eu> has quit IRC (*.net *.split)
 86 2021-01-03T02:43:56  *** berndj-blackout is now known as berndj
 87 2021-01-03T02:43:57  *** queip_ is now known as queip
 88 2021-01-03T02:44:09  *** rc_423_ <rc_423_!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
 89 2021-01-03T02:44:10  *** exhoplex <exhoplex!~echo@139.180.133.130> has joined #bitcoin-core-dev
 90 2021-01-03T02:44:16  *** Anduck <Anduck!~anduck@unaffiliated/anduck> has joined #bitcoin-core-dev
 91 2021-01-03T02:44:26  *** MickSaunders <MickSaunders!~michael@193.105.188.215> has joined #bitcoin-core-dev
 92 2021-01-03T02:44:28  *** lio17 <lio17!~lio17@80.ip-145-239-89.eu> has joined #bitcoin-core-dev
 93 2021-01-03T02:44:42  *** rc_423_ <rc_423_!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
 94 2021-01-03T02:46:25  <sipa> aj: the goal is better compile-time guarantees you're not mixing things up?
 95 2021-01-03T02:47:45  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
 96 2021-01-03T02:49:40  *** shesek <shesek!~shesek@164.90.217.137> has joined #bitcoin-core-dev
 97 2021-01-03T02:56:23  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Quit: Leaving)
 98 2021-01-03T02:59:33  *** so <so!~so@unaffiliated/so> has joined #bitcoin-core-dev
 99 2021-01-03T03:11:29  *** windsok <windsok!~windsok@unaffiliated/windsok> has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
100 2021-01-03T03:12:29  *** windsok <windsok!~windsok@unaffiliated/windsok> has joined #bitcoin-core-dev
101 2021-01-03T03:16:34  *** rc_423_ <rc_423_!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
102 2021-01-03T03:17:29  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
103 2021-01-03T03:20:19  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has joined #bitcoin-core-dev
104 2021-01-03T03:20:23  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
105 2021-01-03T03:27:11  <dhruvm> Does anyone use the YouCompleteMe vim plugin for Bitcoin Core and have a .ycm_extra_conf.py they can share?
106 2021-01-03T03:29:38  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
107 2021-01-03T03:31:11  *** paanir <paanir!49aadbbf@c-73-170-219-191.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
108 2021-01-03T03:31:32  *** paanir <paanir!49aadbbf@c-73-170-219-191.hsd1.ca.comcast.net> has quit IRC (Remote host closed the connection)
109 2021-01-03T03:36:05  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
110 2021-01-03T03:40:19  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
111 2021-01-03T03:56:39  *** zestymug <zestymug!djkoolmatr@gateway/shell/matrix.org/x-mtpsyaqhrusbkbpu> has joined #bitcoin-core-dev
112 2021-01-03T04:06:56  *** zestymug <zestymug!djkoolmatr@gateway/shell/matrix.org/x-mtpsyaqhrusbkbpu> has left #bitcoin-core-dev ("User left")
113 2021-01-03T04:50:43  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has quit IRC (Ping timeout: 240 seconds)
114 2021-01-03T04:56:50  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has joined #bitcoin-core-dev
115 2021-01-03T04:59:38  <aj> sipa: hmm, sounds like leave it as inline functions and don't template then
116 2021-01-03T04:59:54  <aj> sipa: (staring at it more doesn't seem to be helping)
117 2021-01-03T05:16:48  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
118 2021-01-03T05:55:27  *** Implant1 <Implant1!~Implant@195.140.213.38> has quit IRC (Remote host closed the connection)
119 2021-01-03T07:16:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
120 2021-01-03T07:16:46  <bitcoin-git> [bitcoin] glozow opened pull request #20833: rpc/validation: enable packages through testmempoolaccept (master...package-testmempoolaccept) https://github.com/bitcoin/bitcoin/pull/20833
121 2021-01-03T07:16:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
122 2021-01-03T07:17:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
123 2021-01-03T07:17:37  <bitcoin-git> [bitcoin] glozow opened pull request #20834: cleanup: remove CheckInputsFromMempoolAndCache (master...2021-01-validation-cleanup) https://github.com/bitcoin/bitcoin/pull/20834
124 2021-01-03T07:17:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
125 2021-01-03T07:40:16  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
126 2021-01-03T07:40:16  <bitcoin-git> [bitcoin] ppyordanov opened pull request #20835: doc: Corrected Typos in Documentation (master...documentation-fix-typos) https://github.com/bitcoin/bitcoin/pull/20835
127 2021-01-03T07:40:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
128 2021-01-03T07:41:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
129 2021-01-03T07:41:36  <bitcoin-git> [bitcoin] ppyordanov opened pull request #20836: doc: Corrected Typos in Documentation (master...doc-fix-typos) https://github.com/bitcoin/bitcoin/pull/20836
130 2021-01-03T07:41:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
131 2021-01-03T07:41:42  *** andy1221 <andy1221!7085fb5e@112.133.251.94> has joined #bitcoin-core-dev
132 2021-01-03T07:41:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
133 2021-01-03T07:41:56  <bitcoin-git> [bitcoin] ppyordanov closed pull request #20835: doc: Corrected Typos in Documentation (master...documentation-fix-typos) https://github.com/bitcoin/bitcoin/pull/20835
134 2021-01-03T07:41:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
135 2021-01-03T07:47:08  *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
136 2021-01-03T07:47:20  *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
137 2021-01-03T07:47:44  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
138 2021-01-03T07:51:20  *** andy1221 <andy1221!7085fb5e@112.133.251.94> has quit IRC (Ping timeout: 245 seconds)
139 2021-01-03T08:17:34  *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
140 2021-01-03T08:18:04  <wumpus> provoostenator: i don't know, but we can't postpone rc4 indefinitely on it
141 2021-01-03T08:18:43  <wumpus> we could have some release out and have something for people to test for weeks now, but the discussion on those takes indefinitely
142 2021-01-03T08:22:39  <sipa> let's just get rc4 out
143 2021-01-03T08:24:14  <aj> wumpus: if it's not going in, nack it as not being important enough a fix to justify a change? (if it is important enough to justify a change, merging it seems obvious?)
144 2021-01-03T08:25:34  <aj> wumpus: (i think it's important enough; but obviously lots of people are dubious, and if someone has to make a call, might as well be a maintainer?)
145 2021-01-03T09:17:54  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has joined #bitcoin-core-dev
146 2021-01-03T09:36:33  <wumpus> aj: I have already given my opinion on it
147 2021-01-03T09:36:44  <wumpus> I don't necesaarily want to push that
148 2021-01-03T09:39:33  <wumpus> but yes I think the change is unnecessary
149 2021-01-03T09:40:42  <wumpus> and in that case it's probably better to err on the side of not doing it, that said, if this blocks the release forever it'd be kind of sad
150 2021-01-03T09:45:41  <wumpus> I really think it's time to do the rc
151 2021-01-03T09:47:09  <wumpus> looking at #18947, 0.21 has slipped exactly a month now
152 2021-01-03T09:47:10  <gribble> https://github.com/bitcoin/bitcoin/issues/18947 | Release schedule for 0.21.0 · Issue #18947 · bitcoin/bitcoin · GitHub
153 2021-01-03T09:47:17  <wumpus> this is fairly normal
154 2021-01-03T09:48:21  <wumpus> i'm not sure this should delay the 0.22.0 release schedule as well
155 2021-01-03T10:03:28  <aj> wumpus: hmm, i appreciate the "I don't necessarily want to push that" but I also feel like "I think the change is unnecessary" should be more of a nack (concept nack? -0.5? im-not-merging-but-someone-else-might?) than a "~0" and a "review ACK"? it seems like everyone's waiting for someone else to nack it so they don't have to?
156 2021-01-03T10:03:36  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Read error: Connection reset by peer)
157 2021-01-03T10:04:54  *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
158 2021-01-03T10:16:46  <wumpus> "review ACK" means i think the code is correct in doing what it is stated to do
159 2021-01-03T10:17:50  <wumpus> as for #20648, it can wait
160 2021-01-03T10:17:52  <gribble> https://github.com/bitcoin/bitcoin/issues/20648 | chainparams: Add default fixed seeds for signet by MarcoFalke · Pull Request #20648 · bitcoin/bitcoin · GitHub
161 2021-01-03T10:24:01  *** RootDet <RootDet!~Rootdet@unaffiliated/rootdet> has joined #bitcoin-core-dev
162 2021-01-03T10:24:11  *** RootDet <RootDet!~Rootdet@unaffiliated/rootdet> has left #bitcoin-core-dev
163 2021-01-03T10:32:52  *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Ping timeout: 260 seconds)
164 2021-01-03T10:34:58  *** jonatack <jonatack!~jon@88.124.242.136> has joined #bitcoin-core-dev
165 2021-01-03T10:35:12  *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Client Quit)
166 2021-01-03T10:35:51  <wumpus> thinking of it somewhat more, I don't think minor signet-specific issues like this should really hold up a release
167 2021-01-03T10:49:18  *** jonatack <jonatack!~jon@88.124.242.136> has joined #bitcoin-core-dev
168 2021-01-03T10:52:54  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
169 2021-01-03T10:57:54  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has joined #bitcoin-core-dev
170 2021-01-03T10:57:58  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has quit IRC (Client Quit)
171 2021-01-03T11:00:13  *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Ping timeout: 264 seconds)
172 2021-01-03T11:01:44  *** jonatack <jonatack!~jon@213.152.162.99> has joined #bitcoin-core-dev
173 2021-01-03T11:15:23  *** jonatack <jonatack!~jon@213.152.162.99> has quit IRC (Quit: jonatack)
174 2021-01-03T11:15:41  *** jonatack <jonatack!~jon@213.152.162.99> has joined #bitcoin-core-dev
175 2021-01-03T11:18:46  *** Garth63Schuster <Garth63Schuster!~Garth63Sc@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
176 2021-01-03T11:30:27  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has joined #bitcoin-core-dev
177 2021-01-03T11:39:41  <fanquake> agree
178 2021-01-03T11:45:58  *** ccdle12 <ccdle12!~ccdle12@243.222.90.149.rev.vodafone.pt> has joined #bitcoin-core-dev
179 2021-01-03T11:49:50  *** ccdle12 <ccdle12!~ccdle12@243.222.90.149.rev.vodafone.pt> has quit IRC (Client Quit)
180 2021-01-03T11:55:15  *** schulzemic <schulzemic!~ada@193.27.14.104> has joined #bitcoin-core-dev
181 2021-01-03T12:18:44  *** Matt_P <Matt_P!~Matt_P@185.204.1.185> has joined #bitcoin-core-dev
182 2021-01-03T12:21:21  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
183 2021-01-03T12:22:01  *** Garth63Schuster <Garth63Schuster!~Garth63Sc@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 246 seconds)
184 2021-01-03T12:24:01  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
185 2021-01-03T12:26:42  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 256 seconds)
186 2021-01-03T12:28:16  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
187 2021-01-03T12:42:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
188 2021-01-03T12:42:51  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/ac125e960f31...93ce429f0e6a
189 2021-01-03T12:42:51  <bitcoin-git> bitcoin/0.21 93ce429 Wladimir J. van der Laan: qt: Pre-rc4 translations update
190 2021-01-03T12:42:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
191 2021-01-03T12:43:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
192 2021-01-03T12:43:52  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/93ce429f0e6a...212525337eda
193 2021-01-03T12:43:52  <bitcoin-git> bitcoin/0.21 2125253 Wladimir J. van der Laan: build: Bump RC to rc4
194 2021-01-03T12:43:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
195 2021-01-03T12:49:30  *** Talkless <Talkless!~Talkless@m90-135-158-94.cust.tele2.lt> has joined #bitcoin-core-dev
196 2021-01-03T13:01:07  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has joined #bitcoin-core-dev
197 2021-01-03T13:03:04  *** worc3131 <worc3131!~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20> has joined #bitcoin-core-dev
198 2021-01-03T13:06:03  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Ping timeout: 240 seconds)
199 2021-01-03T13:14:01  *** davterra <davterra!~davterra@86.106.143.77> has joined #bitcoin-core-dev
200 2021-01-03T13:23:27  *** Talkless <Talkless!~Talkless@m90-135-158-94.cust.tele2.lt> has quit IRC (Quit: Konversation terminated!)
201 2021-01-03T13:25:03  *** worc3131 <worc3131!~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20> has quit IRC (Ping timeout: 258 seconds)
202 2021-01-03T13:28:44  *** davterra <davterra!~davterra@86.106.143.77> has quit IRC (Ping timeout: 260 seconds)
203 2021-01-03T13:31:17  *** schulzemic <schulzemic!~ada@193.27.14.104> has quit IRC (Quit: Konversation terminated!)
204 2021-01-03T13:34:35  *** davterra <davterra!~davterra@23.226.131.131> has joined #bitcoin-core-dev
205 2021-01-03T13:40:23  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
206 2021-01-03T13:42:28  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
207 2021-01-03T14:11:12  <michaelfolkson> I'm thinking of making it clearer in the fuzzing docs that fuzzing beginners should start with libFuzzer based on these Google recommendations https://github.com/google/fuzzing/blob/master/docs/intro-to-fuzzing.md#fuzzing-tools
208 2021-01-03T14:11:39  <michaelfolkson> Does anyone do any fuzzing currently with Honggfuzz, AFL?
209 2021-01-03T14:12:14  <michaelfolkson> Apparently AFL isn't well maintained according to that Google doc
210 2021-01-03T14:13:14  <michaelfolkson> I guess libFuzzer being first in our fuzzing doc is a subtle recommendation by itself https://github.com/bitcoin/bitcoin/blob/master/doc/fuzzing.md
211 2021-01-03T14:13:26  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
212 2021-01-03T14:23:05  *** worc3131 <worc3131!~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20> has joined #bitcoin-core-dev
213 2021-01-03T14:35:41  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
214 2021-01-03T14:37:17  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
215 2021-01-03T14:44:54  *** rex4539 <rex4539!~rex4539@8.40.29.14> has joined #bitcoin-core-dev
216 2021-01-03T14:57:11  *** rex4539 <rex4539!~rex4539@8.40.29.14> has quit IRC ()
217 2021-01-03T15:10:03  <MarcoFalke> ACK on rc4 tag
218 2021-01-03T15:10:41  <MarcoFalke> #20648 isn't meant for rc4 and it only has one explict review ACK
219 2021-01-03T15:10:43  <gribble> https://github.com/bitcoin/bitcoin/issues/20648 | chainparams: Add default fixed seeds for signet by MarcoFalke · Pull Request #20648 · bitcoin/bitcoin · GitHub
220 2021-01-03T15:19:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
221 2021-01-03T15:19:02  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/212525337eda...e6ad8a6220bf
222 2021-01-03T15:19:02  <bitcoin-git> bitcoin/0.21 e6ad8a6 Wladimir J. van der Laan: doc: Generate manual pages for 0.21.0rc4
223 2021-01-03T15:19:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
224 2021-01-03T15:48:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
225 2021-01-03T15:48:36  <bitcoin-git> [bitcoin] laanwj pushed tag v0.21.0rc4: https://github.com/bitcoin/bitcoin/compare/v0.21.0rc4
226 2021-01-03T15:48:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
227 2021-01-03T15:49:13  <wumpus> ^^
228 2021-01-03T16:00:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
229 2021-01-03T16:00:57  <bitcoin-git> [bitcoin] jonatack closed pull request #20723: p2p: improve logging in EvictExtraOutboundPeers() (master...improve-EvictExtraOutboundPeers-logging) https://github.com/bitcoin/bitcoin/pull/20723
230 2021-01-03T16:00:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
231 2021-01-03T16:02:21  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Remote host closed the connection)
232 2021-01-03T16:02:22  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Read error: Connection reset by peer)
233 2021-01-03T16:02:22  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Read error: Connection reset by peer)
234 2021-01-03T16:02:22  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has quit IRC (Read error: Connection reset by peer)
235 2021-01-03T16:02:22  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has quit IRC (Write error: Connection reset by peer)
236 2021-01-03T16:02:22  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Write error: Connection reset by peer)
237 2021-01-03T16:02:22  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has quit IRC (Read error: Connection reset by peer)
238 2021-01-03T16:05:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
239 2021-01-03T16:05:36  <bitcoin-git> [bitcoin] jonatack closed pull request #20546: policy, wallet, refactor: check for non-representable CFeeRates (master...non-representable-CFeeRate-check) https://github.com/bitcoin/bitcoin/pull/20546
240 2021-01-03T16:05:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
241 2021-01-03T16:07:45  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has joined #bitcoin-core-dev
242 2021-01-03T16:08:03  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
243 2021-01-03T16:08:12  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
244 2021-01-03T16:08:13  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
245 2021-01-03T16:08:21  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
246 2021-01-03T16:09:07  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
247 2021-01-03T16:11:43  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
248 2021-01-03T16:12:34  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
249 2021-01-03T16:18:41  <michaelfolkson> You're not making it easy to get quick Concept ACKs jonatack with descriptions like "following up on #19858 (comment)." and not making it clear what is covered by the PR and what is covered by the series of PRs
250 2021-01-03T16:18:44  <gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
251 2021-01-03T16:19:24  <michaelfolkson> Easy to give a quick Concept ACK when the description is better quality
252 2021-01-03T16:19:36  <michaelfolkson> Otherwise needs some digging on behalf of the reviewer
253 2021-01-03T16:21:05  <michaelfolkson> PR #20546 has a good PR description
254 2021-01-03T16:21:07  <gribble> https://github.com/bitcoin/bitcoin/issues/20546 | policy, wallet, refactor: check for non-representable CFeeRates by jonatack · Pull Request #20546 · bitcoin/bitcoin · GitHub
255 2021-01-03T16:28:58  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
256 2021-01-03T16:30:35  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
257 2021-01-03T16:30:35  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20839: fuzz: Avoid extraneous copy of input data, using Span<> (master...2101-fuzzSpan) https://github.com/bitcoin/bitcoin/pull/20839
258 2021-01-03T16:30:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
259 2021-01-03T16:41:52  *** davterra <davterra!~davterra@23.226.131.131> has quit IRC (Remote host closed the connection)
260 2021-01-03T16:42:24  *** davterra <davterra!~davterra@23.226.131.131> has joined #bitcoin-core-dev
261 2021-01-03T16:42:42  *** davterra <davterra!~davterra@23.226.131.131> has quit IRC (Read error: Connection reset by peer)
262 2021-01-03T16:52:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
263 2021-01-03T16:52:36  <bitcoin-git> [bitcoin] ppyordanov closed pull request #20836: doc: Corrected Typos in Documentation (master...doc-fix-typos) https://github.com/bitcoin/bitcoin/pull/20836
264 2021-01-03T16:52:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
265 2021-01-03T16:52:43  <jonatack> idk if the pull descriptions are the issue. i stand by the work and am sad to close, but better to work on things reviewers are enthusiastic about...you do the work because you believe in it; after that you turn it over to reviewers and it's up to them.
266 2021-01-03T16:53:52  <jonatack> there's a book about it, "review is a harsh mistress" (heinlein, 1966 :))
267 2021-01-03T16:54:00  <michaelfolkson> Well I'm telling you at least from my perspective a good PR description makes a Concept ACK very quick and easy :)
268 2021-01-03T16:55:42  <michaelfolkson> The more digging required, the more friction and the unlikelier it is to get quick Concept ACKs. That's my hypothesis anyway
269 2021-01-03T16:58:44  <jonatack> michaelfolkson: hm, with the title "p2p: improve logging in EvictExtraOutboundPeers" and the diff being only 9 lines, i reckoned more description wasn't required on that one
270 2021-01-03T16:59:28  <jonatack> maybe could have added more though, idk
271 2021-01-03T16:59:44  <jonatack> onward and upward
272 2021-01-03T17:03:00  <michaelfolkson> It is the problem it is solving rather than the solution only being 9 lines
273 2021-01-03T17:10:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
274 2021-01-03T17:10:11  <bitcoin-git> [bitcoin] ppyordanov reopened pull request #20836: doc: Corrected Typos in Documentation (master...doc-fix-typos) https://github.com/bitcoin/bitcoin/pull/20836
275 2021-01-03T17:10:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
276 2021-01-03T17:24:20  *** andytosh1 is now known as andytoshi
277 2021-01-03T17:26:03  *** brianhoffman <brianhoffman!~brianhoff@pool-151-200-246-97.washdc.fios.verizon.net> has left #bitcoin-core-dev
278 2021-01-03T17:28:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
279 2021-01-03T17:28:57  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9c3765ad7cee...6e70674cda65
280 2021-01-03T17:28:57  <bitcoin-git> bitcoin/master 0dade91 fanquake: fuzz: remove no-longer-necessary packages from fuzzbuzz config
281 2021-01-03T17:28:58  <bitcoin-git> bitcoin/master 6e70674 MarcoFalke: Merge #20781: fuzz: remove no-longer-necessary packages from fuzzbuzz conf...
282 2021-01-03T17:28:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
283 2021-01-03T17:29:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
284 2021-01-03T17:29:17  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20781: fuzz: remove no-longer-necessary packages from fuzzbuzz config (master...cleanup_fuzzbuzz) https://github.com/bitcoin/bitcoin/pull/20781
285 2021-01-03T17:29:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
286 2021-01-03T17:30:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
287 2021-01-03T17:30:27  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6e70674cda65...2dab2d239a47
288 2021-01-03T17:30:28  <bitcoin-git> bitcoin/master efaf80e Michael Dietz: fuzz: check that certain script TxoutType are nonstandard
289 2021-01-03T17:30:28  <bitcoin-git> bitcoin/master 2dab2d2 MarcoFalke: Merge #20765: fuzz: check that certain script TxoutType are nonstandard
290 2021-01-03T17:30:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
291 2021-01-03T17:30:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
292 2021-01-03T17:30:47  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20765: fuzz: check that certain script TxoutType are nonstandard (master...test-fuzz-is-nonstandard) https://github.com/bitcoin/bitcoin/pull/20765
293 2021-01-03T17:30:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
294 2021-01-03T17:54:49  *** alko89 <alko89!~alko89@unaffiliated/alko89> has quit IRC (Quit: ZNC 1.7.5 - https://znc.in)
295 2021-01-03T17:59:44  *** alko89 <alko89!~alko89@unaffiliated/alko89> has joined #bitcoin-core-dev
296 2021-01-03T18:00:22  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Remote host closed the connection)
297 2021-01-03T18:00:29  *** davterra <davterra!~davterra@23.226.131.131> has joined #bitcoin-core-dev
298 2021-01-03T18:00:33  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
299 2021-01-03T18:07:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
300 2021-01-03T18:07:57  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2dab2d239a47...9a2400b57558
301 2021-01-03T18:07:58  <bitcoin-git> bitcoin/master fad140e MarcoFalke: test: Set correct nValue for multi-op-return policy check
302 2021-01-03T18:07:58  <bitcoin-git> bitcoin/master 9a2400b MarcoFalke: Merge #20760: test: Set correct nValue for multi-op-return policy check
303 2021-01-03T18:08:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
304 2021-01-03T18:08:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
305 2021-01-03T18:08:17  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20760: test: Set correct nValue for multi-op-return policy check (master...2012-testNValue) https://github.com/bitcoin/bitcoin/pull/20760
306 2021-01-03T18:08:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
307 2021-01-03T18:20:07  *** unauvum <unauvum!~unauvum@134.122.10.34> has joined #bitcoin-core-dev
308 2021-01-03T18:32:19  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has joined #bitcoin-core-dev
309 2021-01-03T18:41:12  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
310 2021-01-03T18:41:37  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
311 2021-01-03T18:42:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
312 2021-01-03T18:42:06  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #20800: Revert "Don't send 'sendaddrv2' to pre-70016 software" (master...2012-netRevertSendaddrv2Workaround) https://github.com/bitcoin/bitcoin/pull/20800
313 2021-01-03T18:42:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
314 2021-01-03T18:45:22  *** worc3131 <worc3131!~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20> has quit IRC (Remote host closed the connection)
315 2021-01-03T18:52:30  *** virtu_ <virtu_!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
316 2021-01-03T18:52:49  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Remote host closed the connection)
317 2021-01-03T18:52:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
318 2021-01-03T18:52:51  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16398: rpc: testmempoolaccept for list of transactions (master...Mf1807-txpoolStacked) https://github.com/bitcoin/bitcoin/pull/16398
319 2021-01-03T18:52:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
320 2021-01-03T18:53:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
321 2021-01-03T18:53:11  <bitcoin-git> [bitcoin] jonatack closed pull request #20483: wallet: deprecate feeRate in fundrawtransaction/walletcreatefundedpsbt (master...deprecate-feeRate-options) https://github.com/bitcoin/bitcoin/pull/20483
322 2021-01-03T18:53:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
323 2021-01-03T18:56:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
324 2021-01-03T18:56:06  <bitcoin-git> [bitcoin] jonatack closed pull request #20240: script: fix linter error in test runner (master...fix-python-linter-error) https://github.com/bitcoin/bitcoin/pull/20240
325 2021-01-03T18:56:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
326 2021-01-03T18:57:51  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
327 2021-01-03T19:00:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
328 2021-01-03T19:00:46  <bitcoin-git> [gui] hebasto opened pull request #176: Fix TxViewDelegate layout (master...210103-delegate) https://github.com/bitcoin-core/gui/pull/176
329 2021-01-03T19:00:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
330 2021-01-03T19:03:50  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
331 2021-01-03T19:04:20  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
332 2021-01-03T19:10:55  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
333 2021-01-03T19:15:40  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
334 2021-01-03T19:24:49  *** heyitsrama <heyitsrama!~heyitsram@c-24-6-105-253.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
335 2021-01-03T19:27:13  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 264 seconds)
336 2021-01-03T19:27:52  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
337 2021-01-03T19:45:25  *** filchef <filchef!~filchef@89.253.179.83> has joined #bitcoin-core-dev
338 2021-01-03T19:51:28  *** df3fjf <df3fjf!~df3fjf@gateway/tor-sasl/jd3i33j> has joined #bitcoin-core-dev
339 2021-01-03T19:58:57  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has quit IRC (Ping timeout: 260 seconds)
340 2021-01-03T20:01:34  *** df3fjf <df3fjf!~df3fjf@gateway/tor-sasl/jd3i33j> has quit IRC (Quit: leaving)
341 2021-01-03T20:06:56  *** heyitsrama <heyitsrama!~heyitsram@c-24-6-105-253.hsd1.ca.comcast.net> has quit IRC (Remote host closed the connection)
342 2021-01-03T20:07:41  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
343 2021-01-03T20:16:08  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
344 2021-01-03T20:24:36  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
345 2021-01-03T20:29:57  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
346 2021-01-03T20:44:35  <andytoshi> is there a way to call `getblock` and not receive witness data? would a PR to add this be accepted?
347 2021-01-03T20:47:27  <luke-jr> the RPC? there probably shouldn't be
348 2021-01-03T20:47:35  <sipa> you can run with -rpcserialversion=0 if you really need to
349 2021-01-03T20:53:37  *** samuel-pedraza <samuel-pedraza!47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.71.237.175.243> has joined #bitcoin-core-dev
350 2021-01-03T21:07:56  <andytoshi> oh that's a neat trick sipa, i might do that
351 2021-01-03T21:08:05  <andytoshi> ok luke-jr if there's gonna be opposition i won't bother
352 2021-01-03T21:08:17  <andytoshi> but it kinda annoying to haul all that witness data around if i'm not even gonna use it
353 2021-01-03T21:09:11  <luke-jr> andytoshi: why haul it? just strip at your first hop?
354 2021-01-03T21:09:25  <luke-jr> or rather, why get the raw block at all if you don't want that? :P
355 2021-01-03T21:11:17  <andytoshi> luke-jr: i am the first hop, i'm pulling this data over localhost into an indexer, which is just scanning for TXOs that it cares about
356 2021-01-03T21:11:20  <andytoshi> and inputs
357 2021-01-03T21:11:50  <andytoshi> i guess if i were to drop the witness data at parse-time in the indexer, the perf hit from that would probabyl not be measurable
358 2021-01-03T21:12:09  <luke-jr> right, I would expect that's the case
359 2021-01-03T21:12:24  <luke-jr> libblkmaker has some cheap code to drop it IIRC
360 2021-01-03T21:12:47  <andytoshi> thanks, i'll check it out
361 2021-01-03T21:14:40  <phantomcircuit> andytoshi, add an rpc to use the block filters on a set of elements?
362 2021-01-03T21:14:52  <luke-jr> someone has a PR for that already
363 2021-01-03T21:15:13  <luke-jr> seems like it'd be less efficient tho
364 2021-01-03T21:15:49  <andytoshi> luke-jr: i think it would be more efficient than what i'm doing -- i'm asking Core to serialize whole blocks, send it to a nother process, and then i'm filtering there ... if i could ask Core to just do the filtering that should be way faster
365 2021-01-03T21:16:12  <andytoshi> i'll track down that PR and test it
366 2021-01-03T21:17:24  <luke-jr> #20664
367 2021-01-03T21:17:27  <gribble> https://github.com/bitcoin/bitcoin/issues/20664 | Add scanblockfilters RPC call by jonasschnelli · Pull Request #20664 · bitcoin/bitcoin · GitHub
368 2021-01-03T21:22:36  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
369 2021-01-03T21:23:17  *** ovovo <ovovo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 260 seconds)
370 2021-01-03T21:27:54  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has joined #bitcoin-core-dev
371 2021-01-03T21:35:12  <andytoshi> thanks! yeah this looks like exactly what i want
372 2021-01-03T21:36:09  <phantomcircuit> luke-jr, unfortunately that's going to be using the existing block filters, which means recalculating the hash for each block
373 2021-01-03T21:36:30  <luke-jr> phantomcircuit: ?
374 2021-01-03T21:37:27  <sipa> phantomcircuit: not really an issue if you're only ever going to scan the last few blocks
375 2021-01-03T21:38:37  <phantomcircuit> sipa, i mean andytoshi's original approach isn't really either
376 2021-01-03T21:54:25  *** tralfaz <tralfaz!~davterra@23.226.131.132> has joined #bitcoin-core-dev
377 2021-01-03T21:57:04  *** davterra <davterra!~davterra@23.226.131.131> has quit IRC (Ping timeout: 246 seconds)
378 2021-01-03T21:59:46  *** davterra <davterra!~davterra@23.226.131.131> has joined #bitcoin-core-dev
379 2021-01-03T21:59:49  *** tralfaz <tralfaz!~davterra@23.226.131.132> has quit IRC (Read error: Connection reset by peer)
380 2021-01-03T22:01:16  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Ping timeout: 246 seconds)
381 2021-01-03T22:02:24  *** filchef <filchef!~filchef@89.253.179.83> has quit IRC (Read error: Connection reset by peer)
382 2021-01-03T22:20:50  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
383 2021-01-03T22:22:01  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
384 2021-01-03T22:22:37  *** Matt_P <Matt_P!~Matt_P@185.204.1.185> has quit IRC (Remote host closed the connection)
385 2021-01-03T22:22:50  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
386 2021-01-03T22:23:39  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
387 2021-01-03T22:25:38  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
388 2021-01-03T22:26:34  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
389 2021-01-03T22:28:38  *** tralfaz <tralfaz!~davterra@23.226.131.131> has joined #bitcoin-core-dev
390 2021-01-03T22:29:43  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
391 2021-01-03T22:31:06  *** davterra <davterra!~davterra@23.226.131.131> has quit IRC (Ping timeout: 256 seconds)
392 2021-01-03T22:31:27  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
393 2021-01-03T22:35:46  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has joined #bitcoin-core-dev
394 2021-01-03T22:42:42  *** greylica <greylica!~greylica@139.28.218.148> has joined #bitcoin-core-dev
395 2021-01-03T23:20:40  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
396 2021-01-03T23:23:04  *** user__ <user__!~davterra@ool-2f14817b.dyn.optonline.net> has joined #bitcoin-core-dev
397 2021-01-03T23:24:43  *** davterra <davterra!~davterra@23.226.131.131> has joined #bitcoin-core-dev
398 2021-01-03T23:25:35  *** tralfaz <tralfaz!~davterra@23.226.131.131> has quit IRC (Ping timeout: 256 seconds)
399 2021-01-03T23:28:04  *** user__ <user__!~davterra@ool-2f14817b.dyn.optonline.net> has quit IRC (Ping timeout: 272 seconds)
400 2021-01-03T23:29:06  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
401 2021-01-03T23:51:54  *** tralfaz <tralfaz!~davterra@23.226.131.155> has joined #bitcoin-core-dev
402 2021-01-03T23:54:40  *** davterra <davterra!~davterra@23.226.131.131> has quit IRC (Ping timeout: 272 seconds)