1 2021-01-05T00:03:31  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
  2 2021-01-05T00:06:00  *** IGHOR <IGHOR!~quassel@> has quit IRC (Read error: No route to host)
  3 2021-01-05T00:08:09  *** randy-waterhouse <randy-waterhouse!~kiwigb@> has quit IRC (Quit: Leaving.)
  4 2021-01-05T00:10:08  *** IGHOR <IGHOR!~quassel@> has joined #bitcoin-core-dev
  5 2021-01-05T00:25:47  *** jespada <jespada!~jespada@> has quit IRC (Ping timeout: 272 seconds)
  6 2021-01-05T00:27:40  *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has quit IRC (Quit: ZNC 1.7.5 - https://znc.in)
  7 2021-01-05T00:28:17  *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has joined #bitcoin-core-dev
  8 2021-01-05T00:28:31  *** jespada <jespada!~jespada@> has joined #bitcoin-core-dev
  9 2021-01-05T00:39:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 10 2021-01-05T00:39:00  <bitcoin-git> [bitcoin] sipa opened pull request #20855: Revert "Add patch to make codesign_allocate compatible with Apple's" (master...202101_revert_codesign_allocate_hack) https://github.com/bitcoin/bitcoin/pull/20855
 11 2021-01-05T00:39:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 12 2021-01-05T00:40:06  <achow101> gitian builders: 0.19.2rc1 sigs pushed
 13 2021-01-05T00:45:04  *** dviola <dviola!~diego@unaffiliated/dviola> has quit IRC (Quit: WeeChat 3.0)
 14 2021-01-05T00:45:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 15 2021-01-05T00:45:26  <bitcoin-git> [bitcoin] fanquake closed pull request #20739: [0.19] final rc2 backports (0.19...2012-19rc2) https://github.com/bitcoin/bitcoin/pull/20739
 16 2021-01-05T00:45:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 17 2021-01-05T00:53:18  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 256 seconds)
 18 2021-01-05T01:09:30  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408> has joined #bitcoin-core-dev
 19 2021-01-05T01:10:51  <fanquake> achow101: MISMATCH
 20 2021-01-05T01:11:02  <achow101> god damnit
 21 2021-01-05T01:11:20  <achow101> where?
 22 2021-01-05T01:11:50  <fanquake> macOS 0.19.2rc1
 23 2021-01-05T01:12:02  <fanquake> 07672b57e4d8adb438e9dc33a180dd062afb6b260077f9a991645ce7b397dd6b  bitcoin-osx-signed.dmg
 24 2021-01-05T01:12:02  <fanquake> 3fef8ec626dfdd719ce265c279c25cc92c927aa2f11d4bc93cefd480f085cb5a  bitcoin-osx-signed.dmg
 25 2021-01-05T01:12:35  <sipa> how dis possible
 26 2021-01-05T01:12:47  <sipa> the unsigned step matches?
 27 2021-01-05T01:13:28  <achow101> The one that MacOS likes the signature for is the correct one
 28 2021-01-05T01:16:18  <achow101> https://github.com/achow101/bitcoin/releases/tag/v0.19.2rc1 has all of my results if you want to dig
 29 2021-01-05T01:27:22  <fanquake> just rebuilding
 30 2021-01-05T01:27:28  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
 31 2021-01-05T01:28:21  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
 32 2021-01-05T01:36:41  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
 33 2021-01-05T01:36:42  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
 34 2021-01-05T01:36:44  *** vasild_ is now known as vasild
 35 2021-01-05T01:40:14  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 36 2021-01-05T01:40:14  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bc8ada1c1534...8b6acaca2ff7
 37 2021-01-05T01:40:15  <bitcoin-git> bitcoin/master 729e1d1 Sebastian Falbesoner: Add gitian PGP key for theStack
 38 2021-01-05T01:40:15  <bitcoin-git> bitcoin/master 8b6acac fanquake: Merge #20848: Add gitian PGP key for theStack
 39 2021-01-05T01:40:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 40 2021-01-05T01:40:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 41 2021-01-05T01:40:34  <bitcoin-git> [bitcoin] fanquake merged pull request #20848: Add gitian PGP key for theStack (master...add_gitian_pgp_key_for_theStack) https://github.com/bitcoin/bitcoin/pull/20848
 42 2021-01-05T01:40:35  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 43 2021-01-05T01:47:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 44 2021-01-05T01:47:08  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8b6acaca2ff7...8d6715666d24
 45 2021-01-05T01:47:09  <bitcoin-git> bitcoin/master 50a6f8f benthecarman: Add benthecarman to keys.txt
 46 2021-01-05T01:47:09  <bitcoin-git> bitcoin/master 8d67156 fanquake: Merge #20846: Add benthecarman to keys.txt
 47 2021-01-05T01:47:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 48 2021-01-05T01:47:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 49 2021-01-05T01:47:27  <bitcoin-git> [bitcoin] fanquake merged pull request #20846: Add benthecarman to keys.txt (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20846
 50 2021-01-05T01:47:28  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 51 2021-01-05T01:55:57  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 260 seconds)
 52 2021-01-05T02:01:23  *** DeadWeen <DeadWeen!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
 53 2021-01-05T02:01:47  *** DeadWeen <DeadWeen!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
 54 2021-01-05T02:11:15  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Quit: Leaving)
 55 2021-01-05T02:12:49  *** davterra <davterra!~davterra@> has quit IRC (Remote host closed the connection)
 56 2021-01-05T02:13:07  <fanquake> achow101: all good after a rebuild. I must have had a bad input sitting around or something. .dmg mounts, app launches fine etc.
 57 2021-01-05T02:13:22  <achow101> phew
 58 2021-01-05T02:18:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 59 2021-01-05T02:18:50  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8d6715666d24...ff6adac5f461
 60 2021-01-05T02:18:51  <bitcoin-git> bitcoin/master d825a39 Antoine Poinsot: gitian-keys: add darosior's key
 61 2021-01-05T02:18:52  <bitcoin-git> bitcoin/master ff6adac fanquake: Merge #20847: gitian-keys: add darosior's key
 62 2021-01-05T02:18:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 63 2021-01-05T02:19:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 64 2021-01-05T02:19:09  <bitcoin-git> [bitcoin] fanquake merged pull request #20847: gitian-keys: add darosior's key (master...darosior_gpg_key) https://github.com/bitcoin/bitcoin/pull/20847
 65 2021-01-05T02:19:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 66 2021-01-05T02:20:20  *** DeadWeen <DeadWeen!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
 67 2021-01-05T02:20:49  *** DeadWeen <DeadWeen!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
 68 2021-01-05T02:22:34  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
 69 2021-01-05T02:27:56  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
 70 2021-01-05T02:30:50  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
 71 2021-01-05T02:32:04  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 246 seconds)
 72 2021-01-05T02:35:57  *** IGHOR <IGHOR!~quassel@> has quit IRC (Read error: No route to host)
 73 2021-01-05T02:39:32  *** IGHOR <IGHOR!~quassel@> has joined #bitcoin-core-dev
 74 2021-01-05T02:53:24  *** unauvum <unauvum!~unauvum@> has quit IRC (Ping timeout: 260 seconds)
 75 2021-01-05T02:57:11  *** unauvum <unauvum!~unauvum@> has joined #bitcoin-core-dev
 76 2021-01-05T03:22:03  *** leoburd <leoburd!~leoburd@> has quit IRC (Remote host closed the connection)
 77 2021-01-05T03:25:46  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 78 2021-01-05T03:41:53  *** hoobop1 <hoobop1!~hoobop@s91904426.blix.com> has joined #bitcoin-core-dev
 79 2021-01-05T05:06:52  <jonasschnelli> 0.20.2rc1 macOS signatures are invalid (local test)
 80 2021-01-05T05:10:43  * sipa erupts in an apple-demon dispelling chant
 81 2021-01-05T05:16:53  <sipa> pom pom pom pom pom
 82 2021-01-05T05:17:34  <jonasschnelli> 0.20.2rc2 attaching the signature with codesign_allocate WITH sipas patch works
 83 2021-01-05T05:18:03  <jonasschnelli> so apple has not fixed it...
 84 2021-01-05T05:18:16  <jonasschnelli> trying now with a signatue done on macOS 10.12
 85 2021-01-05T05:22:27  <jonasschnelli> wild thought: what if we instead of detaching and attaching the macOS sig, we stuff the complete signed binary through the "signer" gitian step and just verify nothing else expect the signature has changed? lame?
 86 2021-01-05T05:24:20  <sipa> that requires a way to remove the signature, and get back to the original unsigned binary
 87 2021-01-05T05:24:38  <sipa> i don't know if there is a reliable way of doing so, and if there is... it still needs codesign_allocate
 88 2021-01-05T05:25:18  <jonasschnelli> sipa: something like hashing the binary "up to the signature"?
 89 2021-01-05T05:26:09  <sipa> yes, but it hashes the binary _after_ running codesign_allocate
 90 2021-01-05T05:27:10  <sipa> which modifies loading instructions in the binary... not something you can easily ignore
 91 2021-01-05T05:27:11  <jonasschnelli> sipa: my idea was to just use pagestuff to get the signature position, then hash the signed binary (without the signature) and hash the unsigned binary and compare
 92 2021-01-05T05:27:23  <jonasschnelli> sipa: yes.. I think that won't work
 93 2021-01-05T05:27:25  <sipa> that won't work
 94 2021-01-05T05:27:36  <sipa> you need to hash the unsigned binary _after_ codesign_allocate
 95 2021-01-05T05:27:49  <jonasschnelli> bah
 96 2021-01-05T05:28:02  <sipa> which gets us back to square one, because the whole problem is recreating the same codesign_allocate step at attaching time
 97 2021-01-05T05:28:12  <jonasschnelli> jup
 98 2021-01-05T05:31:33  <jonasschnelli> testing 0.20.2rc1 now with achow101's signer
 99 2021-01-05T05:32:28  <jonasschnelli> works
100 2021-01-05T05:32:40  <jonasschnelli> I'm just going to push that signature
101 2021-01-05T05:44:33  <jonasschnelli> gitian builders: 0.20.2rc1 sigs pushed
102 2021-01-05T05:46:31  <jonasschnelli> current state: 0.19.2rc1 and 0.20.2rc1 are signed (with achow101's tool), 0.21.0rc4 can't be signed deterministically (needs revert of sipas patch)
103 2021-01-05T05:49:38  <jonasschnelli> achow101: I think compiling codesign_allocate for macOS should be easy, I just compiled out depends package native_cctools locally on my mac (https://github.com/tpoechtrager/cctools-port/)
104 2021-01-05T05:51:12  <jonasschnelli> I think we just need to crosscompile that package as well and extract the codesign_allocate and place it in the tarball (and modify the detach-sig-create script to make use of it [as well as required the signapple changes])
105 2021-01-05T05:51:41  <jonasschnelli> probably name it x86_64-apple-darwin11-codesign_allocate
106 2021-01-05T05:52:18  <sipa> yeah, i think that's pretty much it
107 2021-01-05T05:54:54  <achow101> I haven't figured out how to cross compile cctools
108 2021-01-05T05:55:09  <achow101> but that may be because my knowledge of build systems is slightly lacking
109 2021-01-05T05:55:20  <jonasschnelli> achow101: https://github.com/tpoechtrager/cctools-port/#install-cctools-and-ld64
110 2021-01-05T05:55:32  <jonasschnelli> I'll give it a try later
111 2021-01-05T05:55:56  <achow101> I tried it and got a linux binary out ...
112 2021-01-05T05:56:34  <sipa> i think you can summon some knowledge about cross compilation here
113 2021-01-05T05:56:40  <sipa> let me try
114 2021-01-05T05:57:01  <sipa> *dongcarl*
115 2021-01-05T05:59:17  <achow101> codesign_allocate can remove a signature, but it doesn't reduce the vmsize so it's unhelpful
116 2021-01-05T06:02:42  <jonasschnelli> since only the macOS signer needs the codesign_allocate, we could also place a quick build script into the tarball (fetch the cctools/libtapi, compile)
117 2021-01-05T06:02:57  <jonasschnelli> (might be the cleaner solution and doesn't delay the dependency build)
118 2021-01-05T06:10:02  <aj> sipa: (a cross compiler you say? that's what you get when you have too many syntax errors right?)
119 2021-01-05T06:17:58  *** DeadWeen <DeadWeen!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
120 2021-01-05T06:47:06  *** sr_gi <sr_gi!~sr_gi@> has quit IRC (Read error: Connection reset by peer)
121 2021-01-05T06:47:29  *** sr_gi <sr_gi!~sr_gi@> has joined #bitcoin-core-dev
122 2021-01-05T06:52:22  <achow101> I wonder if there's some way to add a detached sig to the OS detached sigs db at install time
123 2021-01-05T06:53:03  <achow101> then we wouldn't have to attach the sig to the binary, just make the installer thing put the sig in the right place on the os for us
124 2021-01-05T06:54:35  <achow101> too bad a dmg isn't actually an installer
125 2021-01-05T06:59:52  *** Cory <Cory!~Cory@unaffiliated/cory> has quit IRC (Read error: Connection reset by peer)
126 2021-01-05T07:05:24  <jonasschnelli> achow101: that would require a custom script (installer) which would require a codesignature as well.
127 2021-01-05T07:05:58  <jonasschnelli> achow101: do you see any downsides in just using your tool?
128 2021-01-05T07:08:36  *** ghost43_ <ghost43_!~daer@gateway/tor-sasl/daer> has quit IRC (Remote host closed the connection)
129 2021-01-05T07:08:54  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
130 2021-01-05T07:09:38  *** Cory <Cory!~Cory@unaffiliated/cory> has joined #bitcoin-core-dev
131 2021-01-05T07:17:50  <achow101> The downside is that I have to maintain it lol
132 2021-01-05T07:29:19  <jonasschnelli> achow101: good point. :)
133 2021-01-05T07:37:56  *** DeadWeen <DeadWeen!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
134 2021-01-05T07:47:36  <sipa> it's not like apple ever changes anything about their codesignijg infrastructure, right? ;)
135 2021-01-05T07:53:18  <jonasschnelli> well...
136 2021-01-05T07:56:30  <jonasschnelli> is Apples codesign using apples /usr/bin/codesign_allocate or does it handle the allocation internally?
137 2021-01-05T07:57:49  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
138 2021-01-05T08:00:18  <sipa> jonasschnelli: does it matter?
139 2021-01-05T08:00:50  <sipa> the documentation says it can use an alternative allocate binary, but it has to be signed by apple
140 2021-01-05T08:00:56  <jonasschnelli> sipa: maybe we can "patch" (tell it) it to use the self compiled cctools codesign_allocate
141 2021-01-05T08:02:13  <sipa> if their whole codesigning infrastructure is worth anything, that should be impossible ;)
142 2021-01-05T08:03:27  <sipa> jonasschnelli: have you already published a signature somewhere created using signapple?
143 2021-01-05T08:04:07  <jonasschnelli> sipa: https://bitcoin.jonasschnelli.ch/valid_0.21.0rc4_sig_signapple.zip
144 2021-01-05T08:04:59  <sipa> jonasschnelli: that means we no longer need to worry about a bug in signapple that leaks your private key
145 2021-01-05T08:05:02  <sipa> ;)
146 2021-01-05T08:05:03  *** DeadWeen <DeadWeen!~dean@gateway/tor-sasl/deanguss> has quit IRC (Ping timeout: 240 seconds)
147 2021-01-05T08:05:10  <sipa> (if it did, it's too late)
148 2021-01-05T08:05:49  <jonasschnelli> sipa: go. Take my 0.00032524 BTC!
149 2021-01-05T08:06:07  <sipa> i mean the codesigning private key
150 2021-01-05T08:06:17  <jonasschnelli> oh.. well.. that is worth nothing. :)
151 2021-01-05T08:06:40  <sipa> oh!
152 2021-01-05T08:06:47  <sipa> well if you could just publish it, that'd save us a lot of trouble
153 2021-01-05T08:06:58  <jonasschnelli> why?
154 2021-01-05T08:07:09  <jonasschnelli> people would still need to sign
155 2021-01-05T08:07:17  <sipa> could be integrated into gitian
156 2021-01-05T08:07:24  <sipa> in a single phase, even
157 2021-01-05T08:07:29  *** DeadWeen <DeadWeen!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
158 2021-01-05T08:07:57  <jonasschnelli> hmm... we could share it among gitian signers.
159 2021-01-05T08:08:11  <sipa> tiny downside... anyone could sign binaries pretending to be bitcoin core
160 2021-01-05T08:08:48  <jonasschnelli> sipa: the thing is, no-one does verify the signature's origin
161 2021-01-05T08:09:02  <sipa> what do you mean?
162 2021-01-05T08:09:12  <jonasschnelli> the private key is property of "Bitcoin Core Code Signing Association" (this is no joke).
163 2021-01-05T08:09:55  <jonasschnelli> Users just care about a valid signature. Anyone can register at apple, get a valid signing key and sign a mallicious bitcoin core binary.
164 2021-01-05T08:10:26  <sipa> it'd get reported, and eventually revoked, i would imagine
165 2021-01-05T08:10:49  <jonasschnelli> That could be.. yes. But after all keys have been uploaded to the attackes server.
166 2021-01-05T08:11:04  <sipa> but fair point, we (and users) don't actually care about the identity associated with the key
167 2021-01-05T08:11:11  <sipa> just that somebody somewhere has a key
168 2021-01-05T08:11:24  <sipa> and unfortunately, the ability to not lose that key means we can't publish it
169 2021-01-05T08:11:33  <jonasschnelli> I guess there are other keys floating around in the dark-net (valid signing keys)
170 2021-01-05T08:11:56  <jonasschnelli> publishing will lead to missues for other things and a potential revoke by apple
171 2021-01-05T08:12:06  <sipa> yes, that's what i mean
172 2021-01-05T08:12:09  <jonasschnelli> So the secrecy of the key matters,.. but not the identity
173 2021-01-05T08:12:14  <sipa> yup
174 2021-01-05T08:12:53  <jonasschnelli> and... if the signing would happen within gitian... not sure if it would be secure _and_ deterministic
175 2021-01-05T08:13:05  <sipa> i was being sarcastic
176 2021-01-05T08:13:11  <sipa> of course we can't sign inside gitian
177 2021-01-05T08:13:13  <jonasschnelli> got me
178 2021-01-05T08:13:30  <jonasschnelli> i feel like an Asperger sometimes.
179 2021-01-05T08:13:40  <sipa> i was trying to prove the point that the key does have value, even if it's not a BTC amount :)
180 2021-01-05T08:13:54  <jonasschnelli> You did.
181 2021-01-05T08:14:04  <sipa> sorry, this stuff doesn't come across well in textual form always
182 2021-01-05T08:14:12  <jonasschnelli> heh.. all good
183 2021-01-05T08:15:16  <wumpus> heh :)
184 2021-01-05T08:33:08  *** aqquadro <aqquadro!02ee6c29@unaffiliated/aqquadro> has joined #bitcoin-core-dev
185 2021-01-05T08:37:44  <aqquadro> hi, reading the op codes list seems there isn't op codes able to verify signatures on arbitrary payload without concat it to output and inputs. I understand right? Thank you very much
186 2021-01-05T08:40:32  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
187 2021-01-05T08:41:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
188 2021-01-05T08:41:40  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ff6adac5f461...b40254b2327b
189 2021-01-05T08:41:40  <bitcoin-git> bitcoin/master a0eb4c5 Pieter Wuille: Revert "Add patch to make codesign_allocate compatible with Apple's"
190 2021-01-05T08:41:41  <bitcoin-git> bitcoin/master b40254b MarcoFalke: Merge #20855: Revert "Add patch to make codesign_allocate compatible with ...
191 2021-01-05T08:41:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
192 2021-01-05T08:42:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
193 2021-01-05T08:42:00  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20855: Revert "Add patch to make codesign_allocate compatible with Apple's" (master...202101_revert_codesign_allocate_hack) https://github.com/bitcoin/bitcoin/pull/20855
194 2021-01-05T08:42:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
195 2021-01-05T08:47:11  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
196 2021-01-05T09:11:50  <wumpus> should we merge #20850 and tag rc5 asap?
197 2021-01-05T09:11:52  <gribble> https://github.com/bitcoin/bitcoin/issues/20850 | [0.21] final rc5 backports by MarcoFalke · Pull Request #20850 · bitcoin/bitcoin · GitHub
198 2021-01-05T09:12:06  <fanquake> yea
199 2021-01-05T09:12:13  <MarcoFalke> Probably good to see if the mac signature works
200 2021-01-05T09:12:38  <MarcoFalke> Has there been a single rc with the mac signature?
201 2021-01-05T09:13:01  <MarcoFalke> (I don't remember when it started breaking)
202 2021-01-05T09:20:54  *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f24de0069ca0c30b273dc7a.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
203 2021-01-05T09:21:03  <sipa> it started breaking with rc3 iurc
204 2021-01-05T09:21:05  <sipa> iirv
205 2021-01-05T09:21:07  <sipa> iirc
206 2021-01-05T09:24:48  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
207 2021-01-05T09:36:49  *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
208 2021-01-05T09:44:36  <wumpus> yes, rc3 is what i remember too
209 2021-01-05T09:58:22  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has quit IRC (Ping timeout: 260 seconds)
210 2021-01-05T10:05:07  *** kexkey <kexkey!~kexkey@static-198-54-132-155.cust.tzulo.com> has quit IRC (Ping timeout: 265 seconds)
211 2021-01-05T10:05:36  *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
212 2021-01-05T10:07:32  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 265 seconds)
213 2021-01-05T10:10:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
214 2021-01-05T10:10:07  <bitcoin-git> [bitcoin] PiRK opened pull request #20857: update docstring in feature_csv_activation.py to account for 17921 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20857
215 2021-01-05T10:10:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
216 2021-01-05T10:22:16  *** hoobop1 <hoobop1!~hoobop@s91904426.blix.com> has quit IRC (Remote host closed the connection)
217 2021-01-05T10:31:40  *** alko89 <alko89!~alko89@unaffiliated/alko89> has quit IRC (Quit: ZNC 1.8.2 - https://znc.in)
218 2021-01-05T10:33:27  *** alko89 <alko89!~alko89@unaffiliated/alko89> has joined #bitcoin-core-dev
219 2021-01-05T10:41:13  *** cassier <cassier!~cassier@> has joined #bitcoin-core-dev
220 2021-01-05T10:50:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
221 2021-01-05T10:50:01  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b40254b2327b...c37600777eea
222 2021-01-05T10:50:01  <bitcoin-git> bitcoin/master 7ff0535 Amiti Uttarwar: [mempool] Remove error suppression on upgrade
223 2021-01-05T10:50:02  <bitcoin-git> bitcoin/master c376007 MarcoFalke: Merge #20854: [mempool] Remove unnecessary try-block
224 2021-01-05T10:50:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
225 2021-01-05T10:50:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
226 2021-01-05T10:50:20  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20854: [mempool] Remove unnecessary try-block (master...2021-01-load-mempool-cleanup) https://github.com/bitcoin/bitcoin/pull/20854
227 2021-01-05T10:50:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
228 2021-01-05T10:51:43  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
229 2021-01-05T10:53:34  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
230 2021-01-05T10:55:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
231 2021-01-05T10:55:16  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c37600777eea...34322b7f5cbd
232 2021-01-05T10:55:16  <bitcoin-git> bitcoin/master e864084 Sawyer Billings: doc: Use https URLs where possible
233 2021-01-05T10:55:17  <bitcoin-git> bitcoin/master 1112035 Ikko Ashimine: doc: fix various typos
234 2021-01-05T10:55:17  <bitcoin-git> bitcoin/master 34322b7 MarcoFalke: Merge #20842: docs: consolidate typo & url fixing
235 2021-01-05T10:55:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
236 2021-01-05T10:55:35  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
237 2021-01-05T10:55:35  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20842: docs: consolidate typo & url fixing (master...consolidate_typo_fixing) https://github.com/bitcoin/bitcoin/pull/20842
238 2021-01-05T10:55:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
239 2021-01-05T11:08:01  *** so <so!~so@unaffiliated/so> has quit IRC (Ping timeout: 264 seconds)
240 2021-01-05T11:08:35  *** openoms_ <openoms_!~quassel@> has joined #bitcoin-core-dev
241 2021-01-05T11:09:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
242 2021-01-05T11:09:16  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/34322b7f5cbd...fafd725a7c6c
243 2021-01-05T11:09:17  <bitcoin-git> bitcoin/master ed69213 Zero: build: enable unused member function diagnostic
244 2021-01-05T11:09:17  <bitcoin-git> bitcoin/master 819d03b Zero: refactor: took out unused member functions
245 2021-01-05T11:09:17  <bitcoin-git> bitcoin/master fafd725 MarcoFalke: Merge #19846: build: enable unused member function diagnostic
246 2021-01-05T11:09:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
247 2021-01-05T11:11:28  *** openoms <openoms!~quassel@> has quit IRC (Ping timeout: 256 seconds)
248 2021-01-05T11:17:57  *** so <so!~so@unaffiliated/so> has joined #bitcoin-core-dev
249 2021-01-05T11:18:31  *** Destinee36Schuli <Destinee36Schuli!~Destinee3@static.> has joined #bitcoin-core-dev
250 2021-01-05T11:22:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
251 2021-01-05T11:22:02  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fafd725a7c6c...417f95fa453d
252 2021-01-05T11:22:02  <bitcoin-git> bitcoin/master 0e51a35 Hennadii Stepanov: refactor: Use Mutex type for some mutexes in CNode class
253 2021-01-05T11:22:03  <bitcoin-git> bitcoin/master 417f95f MarcoFalke: Merge #19915: p2p, refactor: Use Mutex type for some mutexes in CNode clas...
254 2021-01-05T11:22:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
255 2021-01-05T11:22:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
256 2021-01-05T11:22:22  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19915: p2p, refactor: Use Mutex type for some mutexes in CNode class (master...200908-netmx) https://github.com/bitcoin/bitcoin/pull/19915
257 2021-01-05T11:22:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
258 2021-01-05T11:52:27  *** cassier <cassier!~cassier@> has quit IRC (Remote host closed the connection)
259 2021-01-05T12:15:31  *** Destinee36Schuli <Destinee36Schuli!~Destinee3@static.> has quit IRC (Ping timeout: 256 seconds)
260 2021-01-05T12:16:36  <jonatack> vasild: MarcoFalke: how are you testing #20849 and #20852 manually... disconnecting outbound onion peers with rpc disconnectnode works for me in both pulls but also on master
261 2021-01-05T12:16:38  <gribble> https://github.com/bitcoin/bitcoin/issues/20849 | net: disconnect peers by address without using a subnet by vasild · Pull Request #20849 · bitcoin/bitcoin · GitHub
262 2021-01-05T12:16:39  <gribble> https://github.com/bitcoin/bitcoin/issues/20852 | net: allow CSubNet of non-IP networks by vasild · Pull Request #20852 · bitcoin/bitcoin · GitHub
263 2021-01-05T12:17:17  <jonatack> e.g. i haven't actually reproduced the issue
264 2021-01-05T12:21:20  <MarcoFalke> the rpc works by node id, no?
265 2021-01-05T12:21:44  * MarcoFalke afk
266 2021-01-05T12:22:31  *** belcher_ is now known as belcher
267 2021-01-05T12:24:46  <vasild> I did not test it
268 2021-01-05T12:25:43  <vasild> lets devise something...
269 2021-01-05T12:25:52  <jonatack> i tested it with the address
270 2021-01-05T12:26:14  <jonatack> while watching -netinfo 4
271 2021-01-05T12:30:18  <jonatack> with some added custom logging, and it's not hitting the changed code... afk, look more later
272 2021-01-05T12:30:19  <vasild> "rpc setban", if given something that does not contain "/" will ban/disconnect by address
273 2021-01-05T12:34:51  <jonatack> maybe the functional rpc_setban or p2p_disconnect_ban tests could use a little more coverage
274 2021-01-05T12:43:49  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
275 2021-01-05T12:51:36  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
276 2021-01-05T13:10:37  *** solirc <solirc!~solirc@> has joined #bitcoin-core-dev
277 2021-01-05T13:27:12  *** jespada <jespada!~jespada@> has quit IRC (Ping timeout: 260 seconds)
278 2021-01-05T13:29:56  *** jespada <jespada!~jespada@> has joined #bitcoin-core-dev
279 2021-01-05T13:36:41  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
280 2021-01-05T13:36:42  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
281 2021-01-05T13:36:45  *** vasild_ is now known as vasild
282 2021-01-05T13:43:26  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
283 2021-01-05T13:57:59  *** pinheadm_ <pinheadm_!~pinheadmz@> has quit IRC (Quit: pinheadm_)
284 2021-01-05T13:58:36  *** pinheadmz <pinheadmz!~pinheadmz@> has joined #bitcoin-core-dev
285 2021-01-05T14:18:18  *** sr_gi <sr_gi!~sr_gi@> has quit IRC (Quit: The Lounge - https://thelounge.chat)
286 2021-01-05T14:24:43  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
287 2021-01-05T14:24:44  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/e6ad8a6220bf...6e28714da357
288 2021-01-05T14:24:44  <bitcoin-git> bitcoin/0.21 3308718 Pieter Wuille: Revert "Add patch to make codesign_allocate compatible with Apple's"
289 2021-01-05T14:24:44  <bitcoin-git> bitcoin/0.21 6e28714 Wladimir J. van der Laan: Merge #20850: [0.21] final rc5 backports
290 2021-01-05T14:24:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
291 2021-01-05T14:25:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
292 2021-01-05T14:25:03  <bitcoin-git> [bitcoin] laanwj merged pull request #20850: [0.21] final rc5 backports (0.21...2101-21rc5) https://github.com/bitcoin/bitcoin/pull/20850
293 2021-01-05T14:25:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
294 2021-01-05T14:26:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
295 2021-01-05T14:26:43  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/6e28714da357...4e7b4ce7eb17
296 2021-01-05T14:26:43  <bitcoin-git> bitcoin/0.21 4e7b4ce Wladimir J. van der Laan: build: Bump RC to rc5
297 2021-01-05T14:26:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
298 2021-01-05T14:45:38  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 264 seconds)
299 2021-01-05T14:46:00  *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
300 2021-01-05T14:46:23  *** DeadWeen <DeadWeen!~dean@gateway/tor-sasl/deanguss> has quit IRC (Ping timeout: 240 seconds)
301 2021-01-05T14:57:37  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has quit IRC (Remote host closed the connection)
302 2021-01-05T15:02:12  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
303 2021-01-05T15:03:35  *** Nebraskka_ <Nebraskka_!~Nebraskka@> has quit IRC (Quit: Good day old chaps)
304 2021-01-05T15:04:28  *** Nebraskka <Nebraskka!~Nebraskka@> has joined #bitcoin-core-dev
305 2021-01-05T15:05:47  *** lightlike <lightlike!~lightlike@p200300c7ef1d9b00481bd2d83e623161.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
306 2021-01-05T15:06:39  <dongcarl> achow101, sipa: Sorry missed the convo ytd, lmk if I can still be of assistance
307 2021-01-05T15:08:01  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
308 2021-01-05T15:11:33  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Ping timeout: 265 seconds)
309 2021-01-05T15:19:45  *** MrSquanchee <MrSquanchee!uid421192@gateway/web/irccloud.com/x-yqpslvoomgtehmbg> has joined #bitcoin-core-dev
310 2021-01-05T15:36:14  *** stevesjustbrowsi <stevesjustbrowsi!46bdea9e@ip70-189-234-158.lv.lv.cox.net> has joined #bitcoin-core-dev
311 2021-01-05T15:38:53  *** StopAndDecrypt <StopAndDecrypt!~StopAndDe@unaffiliated/stopanddecrypt> has joined #bitcoin-core-dev
312 2021-01-05T15:38:55  *** stevesjustbrowsi <stevesjustbrowsi!46bdea9e@ip70-189-234-158.lv.lv.cox.net> has quit IRC (Remote host closed the connection)
313 2021-01-05T15:39:43  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
314 2021-01-05T15:43:35  *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f24de0069ca0c30b273dc7a.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
315 2021-01-05T15:47:17  <wumpus> MarcoFalke: yes, hebasto tested in #bitcoin-builds: hebasto | signed 0.19.2rc1 tested on Big Sur -- the signature is vaild
316 2021-01-05T15:47:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
317 2021-01-05T15:47:40  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/4e7b4ce7eb17...15877d160cb8
318 2021-01-05T15:47:40  <bitcoin-git> bitcoin/0.21 15877d1 Wladimir J. van der Laan: qt: Pre-rc5 translations update
319 2021-01-05T15:47:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
320 2021-01-05T15:48:25  *** aqquadro <aqquadro!02ee6c29@unaffiliated/aqquadro> has quit IRC (Ping timeout: 245 seconds)
321 2021-01-05T15:55:14  <wumpus> so I guess this means we're ready to tag rc5?
322 2021-01-05T16:00:14  *** sr_gi <sr_gi!~sr_gi@> has joined #bitcoin-core-dev
323 2021-01-05T16:05:37  <vasild> wumpus: include none of https://github.com/bitcoin/bitcoin/pull/20849 or https://github.com/bitcoin/bitcoin/pull/20852 ?
324 2021-01-05T16:06:31  <wumpus> I think we need to get a rc out to get testing started again
325 2021-01-05T16:06:40  <wumpus> the only focus right now is the macos signing issue
326 2021-01-05T16:07:58  <wumpus> they aren't even in master yet, I think it's fine to include those in a later rc
327 2021-01-05T16:08:33  <vasild> jonatack: wrt https://github.com/bitcoin/bitcoin/pull/20849#issuecomment-754602325 -- I can reproduce the issue and was about to reply to your comment, but I wonder if that can be perceived as a step-by-step guide on how to create an evil node on the network that can circumvent the discouragement mechanism of anybody who connects to it...
328 2021-01-05T16:08:44  <vasild> wumpus: ok
329 2021-01-05T16:08:47  <wumpus> I mean the whole point of rcs is that people test them, I'm sure people will find other issues as well
330 2021-01-05T16:09:00  <wumpus> but it continues getting derailed by macos signing issues
331 2021-01-05T16:16:14  <luke-jr> >_<
332 2021-01-05T16:16:14  <wumpus> well, there we go...
333 2021-01-05T16:16:37  <jonatack> #20829 targets 0.21.0 and has 3 acks
334 2021-01-05T16:16:38  <gribble> https://github.com/bitcoin/bitcoin/issues/20829 | doc: add -netinfo help by jonatack · Pull Request #20829 · bitcoin/bitcoin · GitHub
335 2021-01-05T16:17:00  <jonatack> too late i guess but as it's a help doc for users
336 2021-01-05T16:19:49  <jonatack> vasild: thanks, sent you a message
337 2021-01-05T16:20:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
338 2021-01-05T16:20:46  <bitcoin-git> [bitcoin] laanwj pushed tag v0.21.0rc5: https://github.com/bitcoin/bitcoin/compare/v0.21.0rc5
339 2021-01-05T16:20:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
340 2021-01-05T16:21:39  <wumpus> ^^
341 2021-01-05T16:22:45  <wumpus> jonatack: will take a look
342 2021-01-05T16:25:20  *** alko89 <alko89!~alko89@unaffiliated/alko89> has quit IRC (Quit: ZNC 1.8.2 - https://znc.in)
343 2021-01-05T16:25:39  *** alko89 <alko89!~alko89@unaffiliated/alko89> has joined #bitcoin-core-dev
344 2021-01-05T16:39:12  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has joined #bitcoin-core-dev
345 2021-01-05T16:43:27  *** gleb <gleb!~gleb@> has joined #bitcoin-core-dev
346 2021-01-05T16:58:50  <wumpus> and also at vasild's PRs
347 2021-01-05T16:58:56  <achow101> jonasschnelli: you can change the codesign_allocate that codesign uses by setting the CODESIGN_ALLOCATE environment variable. Unfortunately it enforces that the codesign_allocate used is signed by Apple so this is utterly useless
348 2021-01-05T17:26:54  <jonasschnelli> ok... makes sense
349 2021-01-05T17:29:04  *** MrSquanchee <MrSquanchee!uid421192@gateway/web/irccloud.com/x-yqpslvoomgtehmbg> has quit IRC (Quit: Connection closed for inactivity)
350 2021-01-05T17:35:50  *** pergaminho <pergaminho!~Cleber@> has joined #bitcoin-core-dev
351 2021-01-05T17:58:46  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
352 2021-01-05T18:00:21  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
353 2021-01-05T18:03:57  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
354 2021-01-05T18:34:19  <sdaftuar> gleb: around?
355 2021-01-05T18:39:04  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has joined #bitcoin-core-dev
356 2021-01-05T18:41:07  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
357 2021-01-05T18:44:14  *** molz_ <molz_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 260 seconds)
358 2021-01-05T18:44:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
359 2021-01-05T18:44:41  <bitcoin-git> [bitcoin] miketwenty1 opened pull request #20858: adding Michael Tidwell to key fingerprint (master...master) https://github.com/bitcoin/bitcoin/pull/20858
360 2021-01-05T18:44:43  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
361 2021-01-05T18:45:02  *** shesek <shesek!~shesek@> has joined #bitcoin-core-dev
362 2021-01-05T18:46:34  *** dviola <dviola!~diego@unaffiliated/dviola> has joined #bitcoin-core-dev
363 2021-01-05T18:48:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
364 2021-01-05T18:48:47  <bitcoin-git> [bitcoin] miketwenty1 closed pull request #20858: adding Michael Tidwell to key fingerprint (master...master) https://github.com/bitcoin/bitcoin/pull/20858
365 2021-01-05T18:48:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
366 2021-01-05T18:53:25  <gleb> sdaftuar: what's up?
367 2021-01-05T18:53:53  <sdaftuar> i was wondering whether the erlay bip was going to include a p2p version bump for any reason
368 2021-01-05T18:54:17  <sdaftuar> i'm including a version bump in my own proposal, and didn't want to conflict...
369 2021-01-05T18:54:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
370 2021-01-05T18:54:36  <bitcoin-git> [bitcoin] miketwenty1 opened pull request #20859: Michael Tidwell key submit (master...master) https://github.com/bitcoin/bitcoin/pull/20859
371 2021-01-05T18:54:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
372 2021-01-05T18:57:04  <gleb> sdaftuar: Let me refresh the reasoning. Why did we bump the version for WTXID if there's a special message anyway?
373 2021-01-05T18:58:05  <sdaftuar> there was some feedback on the mailing list that introducing a new p2p message, particularly between version and verack, should be accompanied by a version bump
374 2021-01-05T18:58:43  <sdaftuar> since then, there has been some pushback against the idea, with bip 155 being deployed without a version bump, but then that resulted in some last minute changes before the latest release to avoid causing problems for other software
375 2021-01-05T18:58:56  <jonasschnelli> achow101: I tested and pushed the rc5 sig: https://github.com/bitcoin-core/bitcoin-detached-sigs/commits/0.21 (your turn)
376 2021-01-05T18:58:58  <sdaftuar> i'd say that many people here think it's not necessary to bump the version to introduce a new p2p message
377 2021-01-05T18:59:15  <sdaftuar> but that others in the community may disagree
378 2021-01-05T18:59:57  <gleb> I don't see a reason to bump the version for Erlay, but of course I can't promise.
379 2021-01-05T19:00:11  <gleb> I'm not planning to do it for now.
380 2021-01-05T19:00:41  *** raz10 <raz10!4d89517f@> has joined #bitcoin-core-dev
381 2021-01-05T19:00:50  <achow101> jonasschnelli: can you merge all of the rc5 gitian.sigs prs?
382 2021-01-05T19:01:21  <sdaftuar> cool, thanks
383 2021-01-05T19:01:41  <jnewbery> can someone ban taurus228 from the repo? Lots of spam comments
384 2021-01-05T19:02:58  <sipa> jnewbery: done
385 2021-01-05T19:03:04  <jnewbery> sipa: thanks!
386 2021-01-05T19:03:32  <jonasschnelli> achow101: can I merge there? I never did before... lets see
387 2021-01-05T19:04:18  <jnewbery> It seems like you can't delete the 'review comments' that a spammer leaves, and once they're banned from the repo, you can no longer even update them to '.' :(
388 2021-01-05T19:04:36  <jnewbery> (you can delete PR comments but not review comments)
389 2021-01-05T19:05:46  <sipa> jnewbery: yeah, i noticed
390 2021-01-05T19:05:52  <sipa> i'd have collapsed them otherwise
391 2021-01-05T19:11:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
392 2021-01-05T19:11:48  <bitcoin-git> [bitcoin] guggero opened pull request #20860: gitian-keys: add key for guggero (master...guggero-gpg-key) https://github.com/bitcoin/bitcoin/pull/20860
393 2021-01-05T19:11:53  <jonasschnelli> achow101: merged the ones that had a travis pass
394 2021-01-05T19:11:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
395 2021-01-05T19:11:59  <achow101> thanks
396 2021-01-05T19:21:29  *** pergaminho <pergaminho!~Cleber@> has quit IRC (Quit: Saindo)
397 2021-01-05T19:24:09  <achow101> gitian builders: 0.21.0rc5 sigs pushed
398 2021-01-05T19:25:25  *** promag_ <promag_!~promag@> has joined #bitcoin-core-dev
399 2021-01-05T19:25:40  *** promag <promag!~promag@> has quit IRC (Ping timeout: 246 seconds)
400 2021-01-05T19:26:45  <wumpus> achow101: jonasschnelli: thanks for the quick sigs push
401 2021-01-05T19:28:57  *** promag_ <promag_!~promag@> has quit IRC (Remote host closed the connection)
402 2021-01-05T19:30:01  *** promag <promag!~promag@> has joined #bitcoin-core-dev
403 2021-01-05T19:30:28  *** EnochSeven <EnochSeven!6cfd2db9@108-253-45-185.lightspeed.hstntx.sbcglobal.net> has joined #bitcoin-core-dev
404 2021-01-05T19:30:38  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
405 2021-01-05T19:31:10  *** promag <promag!~promag@> has joined #bitcoin-core-dev
406 2021-01-05T19:33:19  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
407 2021-01-05T19:34:25  *** promag <promag!~promag@> has joined #bitcoin-core-dev
408 2021-01-05T19:34:49  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
409 2021-01-05T19:35:31  *** promag <promag!~promag@> has joined #bitcoin-core-dev
410 2021-01-05T19:36:07  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
411 2021-01-05T19:36:20  *** EnochSeven <EnochSeven!6cfd2db9@108-253-45-185.lightspeed.hstntx.sbcglobal.net> has quit IRC (Remote host closed the connection)
412 2021-01-05T19:36:43  *** promag <promag!~promag@> has joined #bitcoin-core-dev
413 2021-01-05T19:38:18  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
414 2021-01-05T19:38:50  *** promag <promag!~promag@> has joined #bitcoin-core-dev
415 2021-01-05T19:39:25  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
416 2021-01-05T19:40:03  *** promag <promag!~promag@> has joined #bitcoin-core-dev
417 2021-01-05T19:42:15  <jonasschnelli> 20148367b46453ed4681ea6b1a50e4e8a354ccf101f9353bf4a07f6ce6d3ff75  bitcoin-osx-signed.dmg
418 2021-01-05T19:44:59  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
419 2021-01-05T19:45:02  <jonasschnelli> (code signature is valid)
420 2021-01-05T19:45:15  <sipa> \o/
421 2021-01-05T19:52:14  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
422 2021-01-05T19:52:16  <achow101> jonasschnelli: using which tool?
423 2021-01-05T19:52:48  <jonasschnelli> Yours
424 2021-01-05T19:52:50  *** promag <promag!~promag@> has joined #bitcoin-core-dev
425 2021-01-05T19:53:15  <achow101> cool
426 2021-01-05T19:59:58  <jonatack> v nice
427 2021-01-05T20:00:24  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
428 2021-01-05T20:01:16  *** promag <promag!~promag@> has joined #bitcoin-core-dev
429 2021-01-05T20:01:48  <wumpus> 🎉
430 2021-01-05T20:05:21  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
431 2021-01-05T20:05:54  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
432 2021-01-05T20:08:53  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
433 2021-01-05T20:08:56  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
434 2021-01-05T20:09:32  *** promag <promag!~promag@> has joined #bitcoin-core-dev
435 2021-01-05T20:09:41  *** sr_gi <sr_gi!~sr_gi@> has quit IRC (Read error: Connection reset by peer)
436 2021-01-05T20:10:19  *** sr_gi <sr_gi!~sr_gi@> has joined #bitcoin-core-dev
437 2021-01-05T20:13:51  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
438 2021-01-05T20:13:53  *** sdaftuar_ <sdaftuar_!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
439 2021-01-05T20:14:26  *** promag <promag!~promag@> has joined #bitcoin-core-dev
440 2021-01-05T20:16:43  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Ping timeout: 240 seconds)
441 2021-01-05T20:17:43  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
442 2021-01-05T20:19:29  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Quit: Leaving)
443 2021-01-05T20:21:14  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
444 2021-01-05T20:22:00  *** promag <promag!~promag@> has joined #bitcoin-core-dev
445 2021-01-05T20:25:39  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
446 2021-01-05T20:26:28  *** promag <promag!~promag@> has joined #bitcoin-core-dev
447 2021-01-05T20:26:43  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
448 2021-01-05T20:27:46  *** promag <promag!~promag@> has joined #bitcoin-core-dev
449 2021-01-05T20:28:39  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
450 2021-01-05T20:29:20  *** promag <promag!~promag@> has joined #bitcoin-core-dev
451 2021-01-05T20:33:59  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
452 2021-01-05T20:34:48  *** promag <promag!~promag@> has joined #bitcoin-core-dev
453 2021-01-05T20:38:09  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
454 2021-01-05T20:38:55  *** promag <promag!~promag@> has joined #bitcoin-core-dev
455 2021-01-05T20:49:00  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
456 2021-01-05T20:49:35  *** promag <promag!~promag@> has joined #bitcoin-core-dev
457 2021-01-05T20:50:39  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
458 2021-01-05T20:52:40  *** promag <promag!~promag@> has joined #bitcoin-core-dev
459 2021-01-05T20:54:18  *** lightningbot <lightningbot!lightningb@cerulean.erisian.com.au> has joined #bitcoin-core-dev
460 2021-01-05T21:08:25  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Remote host closed the connection)
461 2021-01-05T21:09:37  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
462 2021-01-05T21:13:50  *** DeadWeen <DeadWeen!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
463 2021-01-05T21:30:52  *** DeadWeen <DeadWeen!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
464 2021-01-05T21:33:36  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
465 2021-01-05T21:35:00  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
466 2021-01-05T21:43:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
467 2021-01-05T21:43:45  <bitcoin-git> [bitcoin] sipa opened pull request #20861: Implement Bech32m and use it for v1+ segwit addresses (master...202101_bech32m) https://github.com/bitcoin/bitcoin/pull/20861
468 2021-01-05T21:43:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
469 2021-01-05T22:00:08  *** roconnor <roconnor!~roconnor@host-184-164-7-193.dyn.295.ca> has joined #bitcoin-core-dev
470 2021-01-05T22:30:15  *** tripleslash <tripleslash!~triplesla@unaffiliated/imsaguy> has quit IRC (Read error: Connection reset by peer)
471 2021-01-05T22:31:35  *** tripleslash <tripleslash!~triplesla@unaffiliated/imsaguy> has joined #bitcoin-core-dev
472 2021-01-05T22:44:56  *** troygior1hev <troygior1hev!~troygiors@bras-base-barion1858w-grc-01-216-209-164-24.dsl.bell.ca> has joined #bitcoin-core-dev
473 2021-01-05T22:50:21  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
474 2021-01-05T22:53:27  *** GankMove <GankMove!~GankMove@> has joined #bitcoin-core-dev
475 2021-01-05T22:54:46  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has quit IRC (Remote host closed the connection)
476 2021-01-05T23:04:42  *** raz10 <raz10!4d89517f@> has quit IRC (Remote host closed the connection)
477 2021-01-05T23:07:56  *** davec_ <davec_!~davec@072-183-054-196.res.spectrum.com> has quit IRC (Ping timeout: 268 seconds)
478 2021-01-05T23:09:17  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
479 2021-01-05T23:09:57  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
480 2021-01-05T23:29:16  *** andytoshi <andytoshi!~apoelstra@unaffiliated/andytoshi> has quit IRC (Read error: Connection reset by peer)
481 2021-01-05T23:29:40  *** andytoshi <andytoshi!~apoelstra@S0106d45d64bd1001.vs.shawcable.net> has joined #bitcoin-core-dev
482 2021-01-05T23:31:57  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
483 2021-01-05T23:39:46  *** troygior1hev <troygior1hev!~troygiors@bras-base-barion1858w-grc-01-216-209-164-24.dsl.bell.ca> has quit IRC (Ping timeout: 246 seconds)
484 2021-01-05T23:40:54  *** troygior1hev <troygior1hev!~troygiors@bras-base-barion1858w-grc-01-216-209-164-24.dsl.bell.ca> has joined #bitcoin-core-dev
485 2021-01-05T23:44:57  *** MTennis <MTennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
486 2021-01-05T23:48:08  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Ping timeout: 260 seconds)
487 2021-01-05T23:55:35  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408> has joined #bitcoin-core-dev
488 2021-01-05T23:58:08  *** lightlike <lightlike!~lightlike@p200300c7ef1d9b00481bd2d83e623161.dip0.t-ipconnect.de> has quit IRC (Quit: Leaving)