1 2021-01-07T00:27:34  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:ad75:1255:fdff:5733> has joined #bitcoin-core-dev
  2 2021-01-07T00:39:30  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
  3 2021-01-07T00:41:15  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 265 seconds)
  4 2021-01-07T01:07:25  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 264 seconds)
  5 2021-01-07T01:34:36  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Quit: Leaving)
  6 2021-01-07T01:36:44  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
  7 2021-01-07T01:36:45  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
  8 2021-01-07T01:36:48  *** vasild_ is now known as vasild
  9 2021-01-07T01:56:28  *** hsmiths <hsmiths!uid95325@gateway/web/irccloud.com/x-ufabxdwlsjukdbgi> has quit IRC (Quit: Connection closed for inactivity)
 10 2021-01-07T02:11:37  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC ()
 11 2021-01-07T02:20:36  *** rah1 <rah1!~rah@> has joined #bitcoin-core-dev
 12 2021-01-07T02:26:48  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
 13 2021-01-07T02:34:50  *** justan0theruser <justan0theruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 264 seconds)
 14 2021-01-07T03:05:43  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Ping timeout: 240 seconds)
 15 2021-01-07T03:08:43  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
 16 2021-01-07T03:09:14  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
 17 2021-01-07T03:15:19  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
 18 2021-01-07T03:42:59  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
 19 2021-01-07T04:24:35  *** hsmiths <hsmiths!uid95325@gateway/web/irccloud.com/x-jciiusfwpzvadsvk> has joined #bitcoin-core-dev
 20 2021-01-07T05:00:32  <achow101> huh, it probably does. at least it is able to correctly apply the rc5 signature
 21 2021-01-07T05:01:45  *** jespada <jespada!~jespada@> has quit IRC (Ping timeout: 240 seconds)
 22 2021-01-07T05:03:08  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
 23 2021-01-07T05:03:32  *** jespada <jespada!~jespada@> has joined #bitcoin-core-dev
 24 2021-01-07T05:04:00  <sipa> achow101: nice
 25 2021-01-07T05:05:37  *** molz_ <molz_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 264 seconds)
 26 2021-01-07T05:08:37  *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-fnpkgibmglqpjsad> has quit IRC (Quit: Connection closed for inactivity)
 27 2021-01-07T05:14:05  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
 28 2021-01-07T05:23:27  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Quit: Leaving)
 29 2021-01-07T05:27:03  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:ad75:1255:fdff:5733> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 30 2021-01-07T05:42:45  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:ad75:1255:fdff:5733> has joined #bitcoin-core-dev
 31 2021-01-07T05:46:54  *** dermoth_ <dermoth_!~dermoth@unaffiliated/dermoth> has joined #bitcoin-core-dev
 32 2021-01-07T05:47:13  *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has quit IRC (Disconnected by services)
 33 2021-01-07T05:47:15  *** dermoth_ is now known as dermoth
 34 2021-01-07T06:11:42  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:ad75:1255:fdff:5733> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 35 2021-01-07T06:31:28  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@> has joined #bitcoin-core-dev
 36 2021-01-07T06:31:50  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has quit IRC (Ping timeout: 264 seconds)
 37 2021-01-07T06:39:35  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has joined #bitcoin-core-dev
 38 2021-01-07T07:35:37  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@> has quit IRC (Ping timeout: 264 seconds)
 39 2021-01-07T08:01:39  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@ppp-223-24-94-18.revip6.asianet.co.th> has joined #bitcoin-core-dev
 40 2021-01-07T08:07:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 41 2021-01-07T08:07:37  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3b6d1b61d316...f13e03cda272
 42 2021-01-07T08:07:38  <bitcoin-git> bitcoin/master 1c65c07 practicalswift: Don't declare de facto const member functions as non-const
 43 2021-01-07T08:07:38  <bitcoin-git> bitcoin/master 31b136e practicalswift: Don't declare de facto const reference variables as non-const
 44 2021-01-07T08:07:39  <bitcoin-git> bitcoin/master f13e03c MarcoFalke: Merge #20584: Declare de facto const reference variables/member functions ...
 45 2021-01-07T08:07:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 46 2021-01-07T08:07:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 47 2021-01-07T08:07:57  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20584: Declare de facto const reference variables/member functions as const (master...const-member-fn-and-const-ref-var) https://github.com/bitcoin/bitcoin/pull/20584
 48 2021-01-07T08:07:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 49 2021-01-07T08:10:14  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@ppp-223-24-94-18.revip6.asianet.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 50 2021-01-07T08:10:16  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 51 2021-01-07T08:10:16  <bitcoin-git> [gui] MarcoFalke merged pull request #165: Save QSplitter state in QSettings (master...201225-geo) https://github.com/bitcoin-core/gui/pull/165
 52 2021-01-07T08:10:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 53 2021-01-07T08:10:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 54 2021-01-07T08:10:36  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f13e03cda272...8a720ced5ff2
 55 2021-01-07T08:10:37  <bitcoin-git> bitcoin/master 90f9fc2 Hennadii Stepanov: qt: Save QSplitter state in QSettings
 56 2021-01-07T08:10:37  <bitcoin-git> bitcoin/master 8a720ce MarcoFalke: Merge bitcoin-core/gui#165: Save QSplitter state in QSettings
 57 2021-01-07T08:10:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 58 2021-01-07T08:17:44  *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
 59 2021-01-07T08:19:23  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@ppp-223-24-94-18.revip6.asianet.co.th> has joined #bitcoin-core-dev
 60 2021-01-07T08:24:50  <jonasschnelli> should we remove? https://github.com/bitcoin/bitcoin/issues/9913#issuecomment-755960500
 61 2021-01-07T08:29:44  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
 62 2021-01-07T08:35:08  <jonasschnelli> nm... I missread the issue
 63 2021-01-07T08:39:03  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
 64 2021-01-07T08:42:44  *** joelklabo <joelklabo!~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net> has quit IRC (Ping timeout: 260 seconds)
 65 2021-01-07T08:43:29  *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f24de009c017d5b6f0c8201.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
 66 2021-01-07T08:45:18  *** m1rror51 <m1rror51!~cataly5m@static.> has quit IRC (Ping timeout: 256 seconds)
 67 2021-01-07T08:46:31  <wumpus> yeah I think promising people a bounty for implementing something is okay
 68 2021-01-07T08:47:35  *** m1rror51 <m1rror51!~cataly5m@static.> has joined #bitcoin-core-dev
 69 2021-01-07T08:50:43  <wumpus> given the amount of work involved $300 is not that much, but it does show people want this particular feature badly, and actually offering money is much better than the usual entitled "when????" github post
 70 2021-01-07T09:15:33  <jonasschnelli> indeed
 71 2021-01-07T09:16:44  <jonasschnelli> I vaguely remember getting a BTC bounty when I implemented the initial HD wallets patch
 72 2021-01-07T09:16:53  <jonasschnelli> Can't remember the website though
 73 2021-01-07T09:17:26  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has quit IRC (Ping timeout: 264 seconds)
 74 2021-01-07T09:40:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 75 2021-01-07T09:40:29  <bitcoin-git> [bitcoin] stackman27 opened pull request #20874: test: Run mempool_limit.py even with wallet disabled (master...diswallet_mempoollimit) https://github.com/bitcoin/bitcoin/pull/20874
 76 2021-01-07T09:40:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 77 2021-01-07T10:04:36  *** kexkey <kexkey!~kexkey@static-198-54-132-107.cust.tzulo.com> has quit IRC (Ping timeout: 240 seconds)
 78 2021-01-07T10:06:59  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@ppp-223-24-94-18.revip6.asianet.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 79 2021-01-07T10:23:38  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1> has joined #bitcoin-core-dev
 80 2021-01-07T10:29:09  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
 81 2021-01-07T10:57:22  <jonatack> I received a (non-trivial) bounty recently for some larger PR reviewing done in October just before the feature freeze.
 82 2021-01-07T10:57:36  <jonatack> jonasschnelli: maybe from bitcoin acks
 83 2021-01-07T10:58:14  <jonasschnelli> jonatack: nice. No mine was before bitcoinacks existed
 84 2021-01-07T10:59:35  <jonatack> there is a 2M sat bounty open since Sept for reviewing #19160 at my suggestion, no one has reviewed it yet since https://twitter.com/TooWumboToFail/status/1347110826008735744?s=20
 85 2021-01-07T10:59:38  <gribble> https://github.com/bitcoin/bitcoin/issues/19160 | multiprocess: Add basic spawn and IPC support by ryanofsky · Pull Request #19160 · bitcoin/bitcoin · GitHub
 86 2021-01-07T11:18:42  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
 87 2021-01-07T11:34:51  <wumpus> jonatack: something that surprised me (but no big deal) is that "-netinfo help" only works when there is a remote server, even though the help message is entirely formatted locally
 88 2021-01-07T11:38:23  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Ping timeout: 240 seconds)
 89 2021-01-07T11:39:03  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
 90 2021-01-07T11:39:37  <jonatack> wumpus: ah! i didn't think of trying that. you are referring to "error: Could not connect to the server  Make sure the bitcoind server is running and that you are connecting to the correct RPC port."?
 91 2021-01-07T11:43:33  <jonatack> i'll see if can move the help check earlier
 92 2021-01-07T11:43:49  <wumpus> jonatack: yes, that, while testing the help message I did somehow not expect it to need the RPC server running
 93 2021-01-07T11:48:13  <wumpus> jonatack: I also noticed that "netinfo 5" behaves like "netinfo 0", instead of "netinfo 4"
 94 2021-01-07T11:50:01  <jonatack> wumpus: good point, maybe invalid integers should raise too
 95 2021-01-07T11:51:25  <jonatack> yes, just as the summary help doesn't need the server, e.g. ./src/bitcoin-cli -h | grep -A4 netinfo
 96 2021-01-07T11:52:06  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
 97 2021-01-07T11:55:28  <wumpus> jonatack: the behavior I'd personally expect is either a) higher, not (yet?) defined levels act as the highest defined level  b) it raises an error
 98 2021-01-07T11:55:36  <wumpus> yes maybe an explicit error is best
 99 2021-01-07T12:01:20  <wumpus> I think something we need to expicitly warn against is using this output in scripts in favor of parsing JSON, it's not a stable interface, maybe we do this already
100 2021-01-07T12:01:59  <wumpus> (the same we did for readelf, human readable formats are for humans not for machine parsing)
101 2021-01-07T12:04:11  <jonatack> in the new help, as suggested here? https://github.com/bitcoin/bitcoin/pull/20829#issuecomment-755420094
102 2021-01-07T12:07:49  <jonatack> i thought it was understood that software clients shouldn't depend on client-side cli commands, e.g. instead of -netinfo they should consume getpeerinfo and getnetworkinfo that are subject to API stability constraints
103 2021-01-07T12:08:29  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
104 2021-01-07T12:11:32  <jonatack> hm, git grepping for "unstable\| stable" doesn't turn up much explanation on this. Maybe it's not obvious. I'll look at clarifying.
105 2021-01-07T12:11:43  <wumpus> I think it's generally understoof, but it doesn't hurt to explicitly mention it, a new user might not be aware what the division between client/server side is exactly
106 2021-01-07T12:12:05  <jonatack> 👍
107 2021-01-07T12:12:09  <wumpus> yes, as Luke-jr mentions too
108 2021-01-07T12:26:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
109 2021-01-07T12:26:32  <bitcoin-git> [bitcoin] SamuelMarks opened pull request #20875: [*.cc,*.cpp] Reduce push_back (master...push-back) https://github.com/bitcoin/bitcoin/pull/20875
110 2021-01-07T12:26:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
111 2021-01-07T12:31:54  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
112 2021-01-07T12:32:48  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
113 2021-01-07T12:41:37  *** real_or_random <real_or_random!~real_or_r@2a02:c207:3002:7468::1> has quit IRC (Quit: ZNC 1.7.5 - https://znc.in)
114 2021-01-07T12:43:26  *** real_or_random <real_or_random!~real_or_r@> has joined #bitcoin-core-dev
115 2021-01-07T12:43:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
116 2021-01-07T12:43:36  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8a720ced5ff2...efe03ceb582d
117 2021-01-07T12:43:37  <bitcoin-git> bitcoin/master f2d93b2 Michael Tidwell: gitian-keys: add miketwenty1 key
118 2021-01-07T12:43:37  <bitcoin-git> bitcoin/master efe03ce Wladimir J. van der Laan: Merge #20859: gitian-keys: add miketwenty1 key
119 2021-01-07T12:43:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
120 2021-01-07T12:43:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
121 2021-01-07T12:43:56  <bitcoin-git> [bitcoin] laanwj merged pull request #20859: gitian-keys: add miketwenty1 key (master...master) https://github.com/bitcoin/bitcoin/pull/20859
122 2021-01-07T12:43:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
123 2021-01-07T12:50:37  *** worc3131 <worc3131!~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20> has joined #bitcoin-core-dev
124 2021-01-07T12:51:14  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1> has joined #bitcoin-core-dev
125 2021-01-07T13:01:45  *** worc3131 <worc3131!~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20> has quit IRC (Ping timeout: 272 seconds)
126 2021-01-07T13:02:26  *** worc3131 <worc3131!~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20> has joined #bitcoin-core-dev
127 2021-01-07T13:05:18  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has quit IRC (Remote host closed the connection)
128 2021-01-07T13:07:23  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
129 2021-01-07T13:16:54  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
130 2021-01-07T13:23:52  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
131 2021-01-07T13:23:53  <wumpus> rc5 binaries up: https://bitcoincore.org/bin/bitcoin-core-0.21.0/test.rc5/
132 2021-01-07T13:24:05  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
133 2021-01-07T13:25:00  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
134 2021-01-07T13:25:52  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
135 2021-01-07T13:26:47  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 260 seconds)
136 2021-01-07T13:30:27  *** rah1 <rah1!~rah@> has quit IRC (Remote host closed the connection)
137 2021-01-07T13:36:26  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
138 2021-01-07T13:41:57  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
139 2021-01-07T13:42:27  *** opsec_x12 <opsec_x12!~opsec_x12@c-67-183-29-123.hsd1.wa.comcast.net> has joined #bitcoin-core-dev
140 2021-01-07T13:46:01  *** opsec_x12 <opsec_x12!~opsec_x12@c-67-183-29-123.hsd1.wa.comcast.net> has quit IRC (Client Quit)
141 2021-01-07T13:47:58  *** newz2000 <newz2000!~newz2000@> has joined #bitcoin-core-dev
142 2021-01-07T13:48:12  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1> has joined #bitcoin-core-dev
143 2021-01-07T13:59:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
144 2021-01-07T13:59:08  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/efe03ceb582d...42675e783337
145 2021-01-07T13:59:08  <bitcoin-git> bitcoin/master fa0a717 MarcoFalke: net: Move CConnman/NetEventsInterface after CNode in header file
146 2021-01-07T13:59:09  <bitcoin-git> bitcoin/master fa21068 MarcoFalke: net: Move SocketSendData lock annotation to header
147 2021-01-07T13:59:10  <bitcoin-git> bitcoin/master 42675e7 MarcoFalke: Merge #20864: net: Move SocketSendData lock annotation to header
148 2021-01-07T13:59:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
149 2021-01-07T13:59:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
150 2021-01-07T13:59:26  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20864: net: Move SocketSendData lock annotation to header (master...2101-netLock) https://github.com/bitcoin/bitcoin/pull/20864
151 2021-01-07T13:59:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
152 2021-01-07T14:00:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
153 2021-01-07T14:00:21  <bitcoin-git> [gui] MarcoFalke merged pull request #173: Follow Qt docs when implementing rowCount and columnCount (master...210102-table) https://github.com/bitcoin-core/gui/pull/173
154 2021-01-07T14:00:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
155 2021-01-07T14:00:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
156 2021-01-07T14:00:41  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/42675e783337...4b8b71e63041
157 2021-01-07T14:00:41  <bitcoin-git> bitcoin/master 195fcb5 Hennadii Stepanov: qt: Follow Qt docs when implementing rowCount and columnCount
158 2021-01-07T14:00:42  <bitcoin-git> bitcoin/master 4b8b71e MarcoFalke: Merge bitcoin-core/gui#173: Follow Qt docs when implementing rowCount and ...
159 2021-01-07T14:00:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
160 2021-01-07T14:01:02  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
161 2021-01-07T14:02:21  *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
162 2021-01-07T14:09:09  *** kexkey <kexkey!~kexkey@static-198-54-132-171.cust.tzulo.com> has joined #bitcoin-core-dev
163 2021-01-07T14:22:17  *** provoostenator <provoostenator!~quassel@provoostenator.sprovoost.nl> has quit IRC (Remote host closed the connection)
164 2021-01-07T14:28:55  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has quit IRC (Remote host closed the connection)
165 2021-01-07T14:29:17  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
166 2021-01-07T14:35:10  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
167 2021-01-07T14:44:42  *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
168 2021-01-07T14:46:34  *** MTennis <MTennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
169 2021-01-07T14:47:34  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Ping timeout: 246 seconds)
170 2021-01-07T14:47:53  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 260 seconds)
171 2021-01-07T14:48:16  *** belcher_ is now known as belcher
172 2021-01-07T14:53:45  *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has quit IRC (Remote host closed the connection)
173 2021-01-07T14:55:55  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
174 2021-01-07T15:07:21  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
175 2021-01-07T15:09:19  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has quit IRC (Remote host closed the connection)
176 2021-01-07T15:09:24  *** promag <promag!~promag@> has joined #bitcoin-core-dev
177 2021-01-07T15:09:38  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
178 2021-01-07T15:11:55  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
179 2021-01-07T15:17:56  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
180 2021-01-07T15:32:46  *** promag <promag!~promag@> has joined #bitcoin-core-dev
181 2021-01-07T15:32:47  *** lightlike <lightlike!~lightlike@p200300c7ef19fc0034e2d3ab670ebeac.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
182 2021-01-07T15:37:36  *** CubicEarth <CubicEarth!~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net> has quit IRC (Ping timeout: 240 seconds)
183 2021-01-07T15:39:43  *** CubicEarth <CubicEarth!~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net> has joined #bitcoin-core-dev
184 2021-01-07T15:41:21  *** worc3131 <worc3131!~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20> has quit IRC (Ping timeout: 272 seconds)
185 2021-01-07T15:42:02  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 264 seconds)
186 2021-01-07T15:46:07  *** nickler <nickler!~nickler@static.> has quit IRC (Remote host closed the connection)
187 2021-01-07T15:57:42  *** nickler <nickler!~nickler@static.> has joined #bitcoin-core-dev
188 2021-01-07T15:58:00  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
189 2021-01-07T16:02:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
190 2021-01-07T16:02:17  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20876: test: Replace getmempoolentry with testmempoolaccept in MiniWallet (master...2101-testMiniWalletNoSubmit) https://github.com/bitcoin/bitcoin/pull/20876
191 2021-01-07T16:02:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
192 2021-01-07T16:06:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
193 2021-01-07T16:06:07  <bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/4b8b71e63041...3a6acd177210
194 2021-01-07T16:06:08  <bitcoin-git> bitcoin/master fa121f0 MarcoFalke: fuzz: Use ConsumeNode in process_messages target
195 2021-01-07T16:06:08  <bitcoin-git> bitcoin/master fa42da2 MarcoFalke: fuzz: Use ConsumeNode in process_message target
196 2021-01-07T16:06:09  <bitcoin-git> bitcoin/master faaef94 MarcoFalke: fuzz: [refactor] Extract ALL_CONNECTION_TYPES constant
197 2021-01-07T16:06:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
198 2021-01-07T16:06:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
199 2021-01-07T16:06:27  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20789: fuzz: Rework strong and weak net enum fuzzing (master...2012-fuzzRefactor) https://github.com/bitcoin/bitcoin/pull/20789
200 2021-01-07T16:06:28  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
201 2021-01-07T16:21:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
202 2021-01-07T16:21:52  <bitcoin-git> [bitcoin] jonatack opened pull request #20877: netinfo: user help and argument parsing improvements (master...netinfo-help-follow-ups) https://github.com/bitcoin/bitcoin/pull/20877
203 2021-01-07T16:22:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
204 2021-01-07T16:55:26  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
205 2021-01-07T16:55:27  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
206 2021-01-07T16:55:29  *** vasild_ is now known as vasild
207 2021-01-07T16:57:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
208 2021-01-07T16:58:01  <bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/3a6acd177210...b6a71b80d28c
209 2021-01-07T16:58:01  <bitcoin-git> bitcoin/master 589f958 Fabian Jahr: build: Check for 128 bit integer support
210 2021-01-07T16:58:02  <bitcoin-git> bitcoin/master 0b4d290 Fabian Jahr: crypto: Add Num3072 implementation
211 2021-01-07T16:58:03  <bitcoin-git> bitcoin/master adc708c Fabian Jahr: crypto: Add MuHash3072 implementation
212 2021-01-07T16:58:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
213 2021-01-07T16:58:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
214 2021-01-07T16:58:19  <bitcoin-git> [bitcoin] laanwj merged pull request #19055: Add MuHash3072 implementation (master...csi-1-muhash) https://github.com/bitcoin/bitcoin/pull/19055
215 2021-01-07T16:58:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
216 2021-01-07T16:59:53  <jonatack> congrats fjahr! \o/
217 2021-01-07T17:01:56  <wumpus> yess
218 2021-01-07T17:03:57  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has joined #bitcoin-core-dev
219 2021-01-07T17:11:43  <fjahr> wohooo \o/
220 2021-01-07T17:12:17  <jnewbery> great!
221 2021-01-07T17:18:42  *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-netvovtobqfafxal> has joined #bitcoin-core-dev
222 2021-01-07T17:31:47  *** Jackielove4u <Jackielove4u!uid43977@gateway/web/irccloud.com/x-fqmqdesvfbargkli> has quit IRC (Quit: Connection closed for inactivity)
223 2021-01-07T17:31:54  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
224 2021-01-07T17:33:29  <wumpus> hebasto: #18710 is great, it needs very careful review due to script validation being consensus critical, but good to get rid of another boost::thread_group use (on of the last I think?)
225 2021-01-07T17:33:32  <gribble> https://github.com/bitcoin/bitcoin/issues/18710 | Add local thread pool to CCheckQueue by hebasto · Pull Request #18710 · bitcoin/bitcoin · GitHub
226 2021-01-07T17:33:38  *** davterra <davterra!~davterra@static-198-54-134-68.cust.tzulo.com> has joined #bitcoin-core-dev
227 2021-01-07T17:34:34  <wumpus> oh, only the scheduler left
228 2021-01-07T17:35:12  <hebasto> ^ right
229 2021-01-07T17:35:50  <sipa> oooh!
230 2021-01-07T17:36:29  *** promag <promag!~promag@> has joined #bitcoin-core-dev
231 2021-01-07T17:40:10  *** promag <promag!~promag@> has quit IRC (Remote host closed the connection)
232 2021-01-07T17:40:22  *** promag <promag!~promag@> has joined #bitcoin-core-dev
233 2021-01-07T17:42:56  *** kvaciral <kvaciral!~kvaciral@> has joined #bitcoin-core-dev
234 2021-01-07T18:10:52  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
235 2021-01-07T18:10:53  *** newz2000 <newz2000!~newz2000@> has quit IRC (Ping timeout: 260 seconds)
236 2021-01-07T18:14:34  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
237 2021-01-07T18:17:26  *** jespada <jespada!~jespada@> has quit IRC (Ping timeout: 264 seconds)
238 2021-01-07T18:19:33  *** jespada <jespada!~jespada@> has joined #bitcoin-core-dev
239 2021-01-07T18:21:29  *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f24de009c017d5b6f0c8201.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
240 2021-01-07T18:29:08  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
241 2021-01-07T18:42:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
242 2021-01-07T18:42:52  <bitcoin-git> [bitcoin] laanwj pushed 14 commits to master: https://github.com/bitcoin/bitcoin/compare/b6a71b80d28c...d7e2401c629b
243 2021-01-07T18:42:52  <bitcoin-git> bitcoin/master 02ccf69 Hennadii Stepanov: refactor: Move port mapping code to its own module
244 2021-01-07T18:42:53  <bitcoin-git> bitcoin/master 28e2961 Hennadii Stepanov: refactor: Replace magic number with named constant
245 2021-01-07T18:42:54  <bitcoin-git> bitcoin/master 8b50d1b Hennadii Stepanov: net: Keep trying to use UPnP when -upnp=1
246 2021-01-07T18:42:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
247 2021-01-07T18:43:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
248 2021-01-07T18:43:11  <bitcoin-git> [bitcoin] laanwj merged pull request #18077: net: Add NAT-PMP port forwarding support (master...20200130-natpmp) https://github.com/bitcoin/bitcoin/pull/18077
249 2021-01-07T18:43:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
250 2021-01-07T18:43:27  <hebasto> \o/
251 2021-01-07T18:43:37  <hebasto> wumpus: thanks!
252 2021-01-07T18:48:25  <wumpus> hebasto: thanks for sticking with it
253 2021-01-07T18:52:41  <jonasschnelli> Well done hebasto
254 2021-01-07T18:55:17  <wumpus> btw, is it time to tag 0.19.2? doesn't seem another rc is needed
255 2021-01-07T18:55:33  <hebasto> jonasschnelli: thanks
256 2021-01-07T18:55:41  <achow101> ack
257 2021-01-07T18:57:04  <jonasschnelli> wumpus: yes. ack.
258 2021-01-07T18:59:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
259 2021-01-07T18:59:18  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/33cbedef28eb...2f9f9b37b595
260 2021-01-07T18:59:18  <bitcoin-git> bitcoin/0.19 2f9f9b3 Wladimir J. van der Laan: build: Bump rc to final
261 2021-01-07T18:59:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
262 2021-01-07T18:59:20  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
263 2021-01-07T18:59:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
264 2021-01-07T18:59:33  <bitcoin-git> [bitcoin] laanwj pushed tag v0.19.2: https://github.com/bitcoin/bitcoin/compare/v0.19.2
265 2021-01-07T18:59:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
266 2021-01-07T18:59:44  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
267 2021-01-07T18:59:50  <wumpus> ^^
268 2021-01-07T18:59:59  <MarcoFalke> nice
269 2021-01-07T19:00:05  <achow101> just in time for the meeting
270 2021-01-07T19:00:18  <MarcoFalke> wen #20738 ?
271 2021-01-07T19:00:20  <gribble> https://github.com/bitcoin/bitcoin/issues/20738 | [0.20] final rc2 backports by MarcoFalke · Pull Request #20738 · bitcoin/bitcoin · GitHub
272 2021-01-07T19:00:57  <wumpus> MarcoFalke: next, I guess
273 2021-01-07T19:00:59  <wumpus> #startmeeting
274 2021-01-07T19:00:59  <core-meetingbot> Meeting started Thu Jan  7 19:00:59 2021 UTC.  The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
275 2021-01-07T19:00:59  <core-meetingbot> Available commands: action commands idea info link nick
276 2021-01-07T19:01:05  <jonasschnelli> hi
277 2021-01-07T19:01:07  <MarcoFalke> hi
278 2021-01-07T19:01:16  <sipa>    hi
279 2021-01-07T19:01:27  <hebasto> hi
280 2021-01-07T19:01:37  <wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
281 2021-01-07T19:01:38  <achow101> hi
282 2021-01-07T19:01:39  <wumpus> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus
283 2021-01-07T19:01:40  <jonasschnelli> first meeting in 2021 \o
284 2021-01-07T19:01:51  <jb55> hi
285 2021-01-07T19:02:07  <wumpus> i thought it's still december 2020 :)
286 2021-01-07T19:02:21  <MarcoFalke> wumpus: happy new year :)
287 2021-01-07T19:02:27  <jb55> eternal december
288 2021-01-07T19:02:30  <wumpus> no proposed meeting topics in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
289 2021-01-07T19:02:32  <sipa> it is March 313th
290 2021-01-07T19:02:39  <nehan> hi! happy new year
291 2021-01-07T19:02:40  <wumpus> MarcoFalke: thank you, same to you!
292 2021-01-07T19:02:45  <Murch> hi
293 2021-01-07T19:03:01  <MarcoFalke> #proposedmeetingtopic 0.21.0 release
294 2021-01-07T19:03:03  <jamesob> hi
295 2021-01-07T19:03:07  <wumpus> any last minute meeting topic suggestions?
296 2021-01-07T19:03:28  <wumpus> #topic High priority for review
297 2021-01-07T19:03:28  <core-meetingbot> topic: High priority for review
298 2021-01-07T19:03:43  <wumpus> https://github.com/bitcoin/bitcoin/projects/8  10 blockers, 1 chasing concept ACK
299 2021-01-07T19:04:13  <luke-jr> hi
300 2021-01-07T19:04:19  <jonatack> hi
301 2021-01-07T19:04:23  <wumpus> anything to add/remove, or almost ready to merge?
302 2021-01-07T19:05:41  <promag> #20017 for concept ack
303 2021-01-07T19:05:44  <gribble> https://github.com/bitcoin/bitcoin/issues/20017 | rpc: Add RPCContext by promag · Pull Request #20017 · bitcoin/bitcoin · GitHub
304 2021-01-07T19:05:51  <fjahr> hi
305 2021-01-07T19:06:31  <wumpus> promag: added
306 2021-01-07T19:06:53  <wumpus> anything else?
307 2021-01-07T19:07:18  <jnewbery> hi
308 2021-01-07T19:07:37  <ajonas> hi
309 2021-01-07T19:08:01  <wumpus> thanks sipa, good to see more review on #19806
310 2021-01-07T19:08:05  <gribble> https://github.com/bitcoin/bitcoin/issues/19806 | validation: UTXO snapshot activation by jamesob · Pull Request #19806 · bitcoin/bitcoin · GitHub
311 2021-01-07T19:08:23  <jamesob> yup, thanks sipa
312 2021-01-07T19:08:43  <jamesob> will look at, at least, the tsan error tonight
313 2021-01-07T19:09:12  <wumpus> #topic 0.21.0 release (MarcoFalke)
314 2021-01-07T19:09:13  <core-meetingbot> topic: 0.21.0 release (MarcoFalke)
315 2021-01-07T19:09:42  <MarcoFalke> https://github.com/bitcoin/bitcoin/milestone/45
316 2021-01-07T19:10:13  <sipa> so, #20849 and/or #20852, and rc6?
317 2021-01-07T19:10:15  <gribble> https://github.com/bitcoin/bitcoin/issues/20849 | net: disconnect peers by address without using a subnet by vasild · Pull Request #20849 · bitcoin/bitcoin · GitHub
318 2021-01-07T19:10:17  <gribble> https://github.com/bitcoin/bitcoin/issues/20852 | net: allow CSubNet of non-IP networks by vasild · Pull Request #20852 · bitcoin/bitcoin · GitHub
319 2021-01-07T19:10:18  <wumpus> let's at least wait a week or two before tagging final, I'm sure if people start testing issues will come up
320 2021-01-07T19:10:24  <MarcoFalke> sipa: Or none of them
321 2021-01-07T19:10:26  *** davterra <davterra!~davterra@static-198-54-134-68.cust.tzulo.com> has quit IRC (Remote host closed the connection)
322 2021-01-07T19:10:32  <jnewbery> wumpus: can we move #20557 to high priority bug fixes? PR #16702 broke some aspects of addrman deserialization and it'd be nice to fix them
323 2021-01-07T19:10:34  <gribble> https://github.com/bitcoin/bitcoin/issues/20557 | addrman: Fix new table bucketing during unserialization by jnewbery · Pull Request #20557 · bitcoin/bitcoin · GitHub
324 2021-01-07T19:10:38  <gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs · Pull Request #16702 · bitcoin/bitcoin · GitHub
325 2021-01-07T19:10:45  <wumpus> I'm confused about #20849
326 2021-01-07T19:10:57  <gribble> https://github.com/bitcoin/bitcoin/issues/20849 | net: disconnect peers by address without using a subnet by vasild · Pull Request #20849 · bitcoin/bitcoin · GitHub
327 2021-01-07T19:11:06  <MarcoFalke> wumpus: It is a smaller-impact fix than 20852
328 2021-01-07T19:11:08  <wumpus> (but I posted that on the issue)
329 2021-01-07T19:11:46  <wumpus> MarcoFalke: ok, yes that's true
330 2021-01-07T19:11:51  <sipa> wumpus: 20852 is the more general fix, but perhaps more invasive than what we want for 0.21
331 2021-01-07T19:11:59  <MarcoFalke> There havne't been any blocker issues  reported since rc3
332 2021-01-07T19:12:02  <wumpus> but using a diffrent solution for 0.21 is going to make future backports harder
333 2021-01-07T19:12:08  <MarcoFalke> rc4 and rc5 only contained test and doc fixups, IIRC
334 2021-01-07T19:12:34  <MarcoFalke> so I think we can also tag rc5 as -final
335 2021-01-07T19:12:48  <wumpus> so I'd prefer to just bite the bullet and do #20852 on both master and 0.21  (maybe 0.21.1?)
336 2021-01-07T19:12:50  <gribble> https://github.com/bitcoin/bitcoin/issues/20852 | net: allow CSubNet of non-IP networks by vasild · Pull Request #20852 · bitcoin/bitcoin · GitHub
337 2021-01-07T19:12:51  <sipa> not being able to disconnect misbehaving tor nodes seems like something worth addressing
338 2021-01-07T19:12:58  *** davterra <davterra!~davterra@static-198-54-134-68.cust.tzulo.com> has joined #bitcoin-core-dev
339 2021-01-07T19:13:07  <wumpus> yes, rc4 and rc5 were doc only
340 2021-01-07T19:13:23  <wumpus> apart from the torv2->torv3 signet seed change
341 2021-01-07T19:15:10  <wumpus> MarcoFalke: ofc, assuming nothing comes up with rc5
342 2021-01-07T19:15:53  <wumpus> so we could make it depend on that, if a rc6 is needed for another reason, include, say, 20852
343 2021-01-07T19:16:52  <wumpus> ok, this starts to be a monologue, any other topics?
344 2021-01-07T19:17:22  <MarcoFalke> sipa: *outbound tor nodes
345 2021-01-07T19:17:43  <MarcoFalke> sipa: Delaying the release will also delay already included bugfixes that exist in previous releases
346 2021-01-07T19:17:50  <MarcoFalke> So I think it is a trade-off
347 2021-01-07T19:18:00  <sipa> ?
348 2021-01-07T19:18:29  <wumpus> I don't think in itself it warrants delaying the release
349 2021-01-07T19:18:54  <sipa> ok
350 2021-01-07T19:21:31  <wumpus> of course we could merge it and do rc6 right now but that'd not be very mindful of people that just started testing rc5, better to stick with a rc per week at most
351 2021-01-07T19:22:42  <MarcoFalke> rc5 pretty much only needs testing on macOS
352 2021-01-07T19:22:56  <MarcoFalke> apart from the signature, nothing changed code-wise
353 2021-01-07T19:23:04  <luke-jr> could always just go 0.21.1 sooner too
354 2021-01-07T19:23:08  <wumpus> if there's no other topics, that's a short first meeting of the year
355 2021-01-07T19:23:17  <wumpus> MarcoFalke: luke-jr: agree
356 2021-01-07T19:23:19  <MarcoFalke> luke-jr: ;)
357 2021-01-07T19:23:24  <jonasschnelli> <MarcoFalke> rc5 pretty much only needs testing on macOS
358 2021-01-07T19:23:26  <jonasschnelli> ^ why?
359 2021-01-07T19:23:35  <MarcoFalke> jonasschnelli: Only documentation fixups were merged
360 2021-01-07T19:23:39  <luke-jr> MarcoFalke: no reason for that mess :P
361 2021-01-07T19:23:49  <MarcoFalke> (compared to rc3)
362 2021-01-07T19:23:53  <jonasschnelli> It was testable on macOS before rc5
363 2021-01-07T19:23:53  <luke-jr> oh, I have a possible topic
364 2021-01-07T19:24:05  <luke-jr> Debian wants to include bitcoin core again
365 2021-01-07T19:24:25  <wumpus> #topic Debian package (luke-jr)
366 2021-01-07T19:24:25  <core-meetingbot> topic: Debian package (luke-jr)
367 2021-01-07T19:24:27  <MarcoFalke> fedora as well
368 2021-01-07T19:24:28  <luke-jr> does anyone want to possibly maintain whatever version they release, for their maintenance period?
369 2021-01-07T19:24:34  <luke-jr> (IIRC 3 years?)
370 2021-01-07T19:25:02  <jonasschnelli> thats about 6 version steps?!...
371 2021-01-07T19:25:07  <luke-jr> they're also using system leveldb, which is another issue to resolve - not sure what they're going to do in that regard
372 2021-01-07T19:25:13  <luke-jr> jonasschnelli: yeah :/
373 2021-01-07T19:25:15  *** crisn2blink <crisn2blink!d12203c2@regus-business-centers-katy-209-34-3-194.consolidated.net> has joined #bitcoin-core-dev
374 2021-01-07T19:25:19  <wumpus> I don't particularly feel like repeating this discussion, we've had it before and I don't think anything changed?
375 2021-01-07T19:25:23  <jonasschnelli> Smells after troubles
376 2021-01-07T19:25:34  <luke-jr> wumpus: just thought I'd mention it in case anyone is interested :p
377 2021-01-07T19:25:49  <wumpus> FWIW, I still think it's a bad idea
378 2021-01-07T19:26:17  <luke-jr> IF they resolve the leveldb side, and if someone is willing to maintain it that long… not sure there's any other objections to have?
379 2021-01-07T19:26:27  <wumpus> but so is auto-updating bitcoin core in general
380 2021-01-07T19:26:32  <luke-jr> hmm
381 2021-01-07T19:26:44  <luke-jr> but we already allow auto-updates via Snap etc
382 2021-01-07T19:27:05  <wumpus> (defiitely between major releases, or when there's a softfork, or policy changes, or...)
383 2021-01-07T19:27:23  <sipa> oh i have a topic: how reasonable is it for us to produce a docker image inside gitian?
384 2021-01-07T19:27:38  <MarcoFalke> It is not auto update, only update on `apt update`, no?
385 2021-01-07T19:27:49  <luke-jr> MarcoFalke: Debian supports auto-upgrade optionally
386 2021-01-07T19:27:58  <sipa> MarcoFalke: i don't think that's a meaningful difference
387 2021-01-07T19:28:13  <sipa> it's not like you're going to review all the things that get changed when updating
388 2021-01-07T19:28:22  <sipa> also, auto-update can be enabled
389 2021-01-07T19:28:23  <luke-jr> If we are auto-updating via official Snaps, I don't think we can make that objection
390 2021-01-07T19:28:31  <wumpus> right, the point is that bitcoin needs *special* review compared to upgrading other software
391 2021-01-07T19:28:37  <MarcoFalke> I do review them (at least of the important packages)
392 2021-01-07T19:29:05  <luke-jr> MarcoFalke: can you confirm the Snap situation?
393 2021-01-07T19:29:21  <MarcoFalke> luke-jr: Yes, there is an auto-update footgun
394 2021-01-07T19:29:26  <MarcoFalke> I think it is optional
395 2021-01-07T19:29:56  <MarcoFalke> Also, there are tracks for previous releaes
396 2021-01-07T19:30:06  <sipa> regardless, i don't think we're ready for 3-year maintenance
397 2021-01-07T19:30:14  <MarcoFalke> So even with auto-update you can say "only auto update on the 0.19 branch"
398 2021-01-07T19:30:16  <jonasschnelli> yes
399 2021-01-07T19:30:42  <MarcoFalke> (no one uses the tracks, though)
400 2021-01-07T19:30:48  <wumpus> I definitely have no interest in maintaining a 3-year old release
401 2021-01-07T19:31:40  <jonasschnelli> plus core is very easy to "install" on most systems thanks to the static binaries
402 2021-01-07T19:31:50  <wumpus> maintaining he releases we do is already overwhelming enough sometimes
403 2021-01-07T19:32:04  <luke-jr> anyway, I guess it's moot unless someone wants to maintain for 3 years..
404 2021-01-07T19:32:04  <MarcoFalke> sipa: Creating a docker image should be trivial. Not sure if it is deterministic, though.
405 2021-01-07T19:32:04  <luke-jr> I've done it before, but having no funding, I'm not too inclinded to repeat it
406 2021-01-07T19:32:29  <jonasschnelli> no fun(ding)
407 2021-01-07T19:32:53  <wumpus> it's definitely a job that would require funding, no one is going to do it for fun :)
408 2021-01-07T19:33:25  <wumpus> if there are really companies that want to run a three-year old stable, make them fund it
409 2021-01-07T19:33:30  <sipa> MarcoFalke: i read that docker images can be identified by their hash, so if creating one is deterministic, that may be something people are interested in having
410 2021-01-07T19:33:39  <sipa> (i've never used docker myself, though)
411 2021-01-07T19:33:48  <wumpus> okok docker
412 2021-01-07T19:33:54  <wumpus> #topic Docker image generation in gitian
413 2021-01-07T19:33:54  <core-meetingbot> topic: Docker image generation in gitian
414 2021-01-07T19:33:57  <MarcoFalke> sipa:  me neither
415 2021-01-07T19:34:14  <achow101> in theory it is deterministic because you can specify parent image hashes
416 2021-01-07T19:34:15  <jonasschnelli> sipa: why inside gitian? What are the benefits?
417 2021-01-07T19:34:20  <achow101> in practice, I've had no such luck
418 2021-01-07T19:34:28  <MarcoFalke> jonasschnelli: For release binaries
419 2021-01-07T19:34:30  <sipa> jonasschnelli: otherwise we're relying on external people to do it?
420 2021-01-07T19:34:47  <MarcoFalke> We could also just include a docker script
421 2021-01-07T19:35:17  <jonasschnelli> Wait? For uploading the gitian built deterministic release binary?
422 2021-01-07T19:35:37  <sipa> jonasschnelli: the idea is that we could publish a docker image hash, together with the release binaries & their hashes
423 2021-01-07T19:35:38  <MarcoFalke> no, in parallel to the snap package, also offer a docker package
424 2021-01-07T19:36:09  <sipa> jonasschnelli: and if that hash if verified through gitian, it means it has the same standard of review and auditability as the rest of the release process
425 2021-01-07T19:36:33  <jonasschnelli> okay.. I see.
426 2021-01-07T19:37:24  <sipa> i'm just mentioning this because i saw https://github.com/bitcoin-core/packaging/issues/55, and it seems doing it inside gitian is an almost trivial change for us, apart from some initial work to set up the scripts
427 2021-01-07T19:37:57  <sipa> jamesob seems to maintain a script for building docker images?
428 2021-01-07T19:38:20  <MarcoFalke> I just feel that we need a docker expert to pull this off. Also, it would be sad if that blocked progress on guix
429 2021-01-07T19:38:38  <luke-jr> hmm, true
430 2021-01-07T19:38:42  <wumpus> so the question then would be: for what platforms?  we can't quite do {docker,tar.gz} for all supported platforms
431 2021-01-07T19:38:54  <sipa> wumpus: good point
432 2021-01-07T19:39:03  <sipa> do people do docker for more than just x86_64 linux?
433 2021-01-07T19:39:20  <luke-jr> can we add a file to the .tar.gz to run it as a docker?
434 2021-01-07T19:39:27  <MarcoFalke> sipa: Also arm
435 2021-01-07T19:39:33  <MarcoFalke> wumpus: Which is why I'd rather publish a docker script
436 2021-01-07T19:39:42  <wumpus> i'd be surprised if it wouldn't be used on arm64
437 2021-01-07T19:39:51  <wumpus> as for the other platforms, probably rarely
438 2021-01-07T19:40:02  <sipa> MarcoFalke: okay, i'm not all that familiar with the different mechanics
439 2021-01-07T19:40:04  <wumpus> MarcoFalke: agree, it's the same binaries anyhow packaged differently
440 2021-01-07T19:40:39  <MarcoFalke> sipa: the docker script builds the docker image, so it is just one step less to do for us
441 2021-01-07T19:40:58  <sipa> and your suggestion would be to have the script inside the release tgz?
442 2021-01-07T19:41:09  <MarcoFalke> jup
443 2021-01-07T19:41:14  <sipa> seems reasonable
444 2021-01-07T19:41:45  <sipa> (plus having some sort of CI to see if the script works?)
445 2021-01-07T19:42:50  <wumpus> yes
446 2021-01-07T19:42:51  <MarcoFalke> hmm, maybe the idea isn't that good because we couldn't reference the gitian built binaries in the script
447 2021-01-07T19:43:24  <luke-jr> why not?
448 2021-01-07T19:43:38  <wumpus> as i see it it'd convert a set of gitian-built binaries to a docker image, deterministically
449 2021-01-07T19:44:04  <MarcoFalke> ok, so the user has to provide the binaries. fair enough
450 2021-01-07T19:44:20  <luke-jr> the binaries are right there with the script, no?
451 2021-01-07T19:44:39  <sipa> if it's deterministic to do so even in a fairly uncontrolled environment, that'd still permit publishing the resulting hashes
452 2021-01-07T19:44:40  * dongcarl looks back at `guix pack --format=docker`
453 2021-01-07T19:44:48  <sipa> dongcarl: o?
454 2021-01-07T19:44:50  <wumpus> luke-jr: oh... of course
455 2021-01-07T19:45:03  <wumpus> luke-jr: it'd be shipped with the binary tarball, not the source one
456 2021-01-07T19:45:08  <luke-jr> right
457 2021-01-07T19:45:11  <sipa> right
458 2021-01-07T19:45:19  <luke-jr> (well, part of source too I assume)
459 2021-01-07T19:45:39  <wumpus> right it has to come from somewhere
460 2021-01-07T19:46:08  <wumpus> dongcarl: hah!
461 2021-01-07T19:46:33  * dongcarl still trying to find the goal of this discussion
462 2021-01-07T19:47:09  <sipa> dongcarl: it seems docker is popular (i don't know why, i've never used it), so it'd be great if we have a direct path from our release process to something people can run directly
463 2021-01-07T19:47:32  <wumpus> yes, for example btcpayserver uses docker IIRC?
464 2021-01-07T19:47:42  <dongcarl> sipa: Stupid question: why aren't the release binaries enough for this?
465 2021-01-07T19:48:04  <jonatack> yes iirc dockre is btcpay's recommended installation method
466 2021-01-07T19:48:15  <achow101> dongcarl: people are just using docker images published by other people that contain the release binaries. afaiu, the point is for us to publish those images instead
467 2021-01-07T19:48:18  <sipa> dongcarl: that requires people to build their own image from it, using a script they get from... somewhere?
468 2021-01-07T19:48:36  <sipa> MarcoFalke has a point that just making publishing the script as part of the process may be enough
469 2021-01-07T19:49:00  <wumpus> it would use the same release binaries, just package them
470 2021-01-07T19:49:02  <sipa> i think publishing the image directly would be slightly more convenient (and also allow others to build on top of it, i think?)
471 2021-01-07T19:49:03  <achow101> in the end, it's still our release binaries, but the images themselves may contain other stuff that could be malicious. hence the desire for the developers to create an official one
472 2021-01-07T19:49:46  <MarcoFalke> sipa:  The image can still be published, even if we include only the script in the release
473 2021-01-07T19:49:57  <sipa> MarcoFalke: if it's deterministic, yes
474 2021-01-07T19:50:29  <jonatack> https://docs.btcpayserver.org/Docker/
475 2021-01-07T19:50:46  <sipa> but i somehow expect that if a guix pack --format=docker exists... that'd be pretty likely to be deterministic ;)
476 2021-01-07T19:51:37  <sipa> there isn't so much to discuss here i guess, a lot depends on what work people are willing to put into it
477 2021-01-07T19:51:43  <sipa> but it's good to get an idea about the sentiment
478 2021-01-07T19:51:50  <dongcarl> I think the only risk is Docker's determinism
479 2021-01-07T19:51:55  <dongcarl> The actual Dockerfile will be like... 4 lines?
480 2021-01-07T19:52:21  <MarcoFalke> dongcarl: People will ask for features, so the file surely will grow
481 2021-01-07T19:52:54  <sipa> jamesob's Dockerfile seems quite a bit longer: https://github.com/jamesob/docker-bitcoind/blob/master/Dockerfile
482 2021-01-07T19:52:55  <wumpus> i guess it's bascially glibc and the bitcoind binary?
483 2021-01-07T19:53:14  <wumpus> if we'd link bitcoind statically with musl libc there wouldn't even be dependency on that
484 2021-01-07T19:53:28  <luke-jr> MarcoFalke: what features are even possible?
485 2021-01-07T19:53:35  <MarcoFalke> "I want to supply the cookie file from outside"
486 2021-01-07T19:53:47  <sipa> "I want it to mine signet!"
487 2021-01-07T19:53:58  <luke-jr> that's not runtime?
488 2021-01-07T19:54:26  <MarcoFalke> "I want to run the gui in docker"
489 2021-01-07T19:54:31  <wumpus> a docker image with bitcoind that's, just bitcoind :)
490 2021-01-07T19:54:31  <dongcarl> I'm not entirely sure I see the point in this, let them use the binaries, it's currently clear that the Dockerfiles are not official, and we can't account for all features. Is there a particular event that makes us more worried now?
491 2021-01-07T19:54:50  <sipa> dongcarl: no
492 2021-01-07T19:55:01  <wumpus> MarcoFalke: nah
493 2021-01-07T19:55:04  <MarcoFalke> dongcarl: ppl are asking for it for years
494 2021-01-07T19:55:10  <sipa> i think the dockerfiles being unofficial is suboptimal
495 2021-01-07T19:55:23  <sipa> s/official/not going through the same review process/
496 2021-01-07T19:55:56  <wumpus> there's plenty of ways to run sandboxed GUI (flatpak, snap) there's no point using docker for that, everyone uses docker for server components
497 2021-01-07T19:56:12  <dongcarl> I think we should do what we do for the systemd services
498 2021-01-07T19:56:21  <dongcarl> Make it clear that it's just for reference
499 2021-01-07T19:56:54  <dongcarl> If we do add a Dockerfile I don't want it to bloat over time
500 2021-01-07T19:58:03  <sipa> yes, that's a delicate line... but i think it'd be better if there was an actual dockerfile that was reviewed and known to be kept working
501 2021-01-07T19:59:10  <sipa> enough on this i guess
502 2021-01-07T19:59:27  <wumpus> okay, let's conclude the meeting then, thanks everyone for attending
503 2021-01-07T19:59:31  <wumpus> #endmeeting
504 2021-01-07T19:59:32  <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
505 2021-01-07T19:59:32  <core-meetingbot> Meeting ended Thu Jan  7 19:59:31 2021 UTC.
506 2021-01-07T19:59:32  <core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-01-07-19.00.moin.txt
507 2021-01-07T19:59:47  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
508 2021-01-07T20:01:09  <sipa> luke-jr: a comment on your addition to the release notes... i think it's confusing (mixing measuring support/opinions vs measuring safety of updating), and i don't think it means much in any case as update patterns for major versions are very different from minor ones
509 2021-01-07T20:02:27  <dongcarl> Would love to get some review on #19683, which is blocking Guix progress right now.
510 2021-01-07T20:02:28  <gribble> https://github.com/bitcoin/bitcoin/issues/19683 | depends: Pin clang search paths for darwin host by dongcarl · Pull Request #19683 · bitcoin/bitcoin · GitHub
511 2021-01-07T20:03:22  <sipa> that said the release notes should probably say something about non-active taproot support being included?
512 2021-01-07T20:03:30  <luke-jr> sipa: the goal is to encourage users to mimick the softofrk upgrade pattern
513 2021-01-07T20:04:09  <sipa> luke-jr: yes, i understand, but i don't think it achieves that
514 2021-01-07T20:04:20  <sipa> major releases are fundamentally different from minor ones
515 2021-01-07T20:04:27  <luke-jr> sipa: not perfectly, no, but it should get us closer?
516 2021-01-07T20:04:41  <sipa> as is, i think the comment adds more confusion than it helps anything
517 2021-01-07T20:04:45  <luke-jr> right now it looks like upgrades take a very long time
518 2021-01-07T20:05:08  <wumpus> luke-jr: can you rebase #14066 please? I think it makes sense to add a new platform in the beginning of the release cycle for 0.21, not at the end, or should I pick it up?
519 2021-01-07T20:05:11  <gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr · Pull Request #14066 · bitcoin/bitcoin · GitHub
520 2021-01-07T20:05:15  <wumpus> 22.0*
521 2021-01-07T20:05:30  <luke-jr> wumpus: sure
522 2021-01-07T20:05:50  <jonasschnelli> scanning a xpub with scanblocks (#20664) from block 400'000 to tip on a standard machine takes 1m35s (m/0/* m/1/*, range 0-250). That unexpected fast IMO.
523 2021-01-07T20:05:52  <gribble> https://github.com/bitcoin/bitcoin/issues/20664 | Add scanblocks RPC call by jonasschnelli · Pull Request #20664 · bitcoin/bitcoin · GitHub
524 2021-01-07T20:05:59  <sipa> jonasschnelli: nice
525 2021-01-07T20:06:48  <jonasschnelli> Combining this with rescanblockchain (importing older wallets),..
526 2021-01-07T20:06:59  <jonasschnelli> and add support for blockfilters in prune mode
527 2021-01-07T20:07:34  <jonasschnelli> from genesis ist also only 2m13s
528 2021-01-07T20:07:38  <sipa> jonasschnelli: the scanblocks approach can't be used for pre-descriptor wallets iirc, because we don't have a way to enumerate all sPKs that match a wallet (i think; achow101 may have)
529 2021-01-07T20:08:26  <luke-jr> sipa: eh, I would think it's easier for older wallets
530 2021-01-07T20:08:27  <jonasschnelli> sipa: good point
531 2021-01-07T20:08:34  <luke-jr> oh, because of the key mutability
532 2021-01-07T20:08:37  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 264 seconds)
533 2021-01-07T20:09:05  <achow101> there's a commit in the descriptor wallet migration pr to compute all spks for a legacy wallet
534 2021-01-07T20:09:44  <sipa> luke-jr: take things into account like importing a multisig script may result in suddenly making the P2SH version of it watched, but only under the condition that all the related keys are in the wallet etc
535 2021-01-07T20:09:50  <sipa> it's definitely possible, just nontrivial
536 2021-01-07T20:09:52  <sipa> achow101: ok cool
537 2021-01-07T20:10:52  <jonasschnelli> I guess fastscan versus deepscan could be an option for legacy wallets...
538 2021-01-07T20:11:44  <jonasschnelli> I guess there is no way to detect whether a deepscan is necessary for a legacy wallet before actually completing a deepscan and compare with a fastscan.
539 2021-01-07T20:11:59  <sipa> not sure what those terms mean
540 2021-01-07T20:12:17  <jonasschnelli> fastscan (blockfilter), deepscan (how we do it now)
541 2021-01-07T20:12:37  <sipa> they shouldn't ever differ?
542 2021-01-07T20:12:53  <jonasschnelli> [...]  because we don't have a way to enumerate all sPKs that match a wallet (i think; achow101 may have)
543 2021-01-07T20:12:54  <sipa> if we have the code for doing the fast one, and we're confident in it, we should use it
544 2021-01-07T20:12:59  <sipa> otherwise we shouldn't do it at all
545 2021-01-07T20:13:28  <sipa> jonasschnelli: i should have said "that is blocked on having such functionality, which is nontrivial" - but it's not impossible
546 2021-01-07T20:13:41  <jonasschnelli> ok
547 2021-01-07T20:16:51  *** Laur <Laur!d5e96edd@> has joined #bitcoin-core-dev
548 2021-01-07T20:21:58  *** Laur <Laur!d5e96edd@> has left #bitcoin-core-dev
549 2021-01-07T20:22:01  <sipa> fwiw, i've enabled cirrus CI for the bitcoin-core/secp256k1 repo
550 2021-01-07T20:22:18  <sipa> is that potentially using up some credits someone paid for?
551 2021-01-07T20:22:20  <sipa> MarcoFalke: ?
552 2021-01-07T20:22:35  <MarcoFalke> no
553 2021-01-07T20:23:04  <sipa> those are only on the bitcoin org?
554 2021-01-07T20:23:21  <MarcoFalke> There are some free credits: https://cirrus-ci.com/settings/github/bitcoin-core
555 2021-01-07T20:23:26  *** GankMove <GankMove!~GankMove@dsl-lprbng11-54f88d-13.dhcp.inet.fi> has quit IRC (Read error: Connection reset by peer)
556 2021-01-07T20:23:39  <MarcoFalke> But they won't get used unless you specify `use_compute_credits: true` in the yaml
557 2021-01-07T20:24:16  <MarcoFalke> Credits for the other org: https://cirrus-ci.com/settings/github/bitcoin
558 2021-01-07T20:25:13  <sipa> ok great
559 2021-01-07T20:25:17  <real_or_random> nice ok
560 2021-01-07T20:36:51  <sipa> dongcarl: the song on 19683 is great (thanks aj?)
561 2021-01-07T20:37:24  <dongcarl> Hehe yeah all credits to aj!
562 2021-01-07T20:38:27  <sipa> what is $$(...) ?
563 2021-01-07T20:38:36  <sipa> doesn't seem to work in my shell
564 2021-01-07T20:39:06  <sipa> in https://github.com/bitcoin/bitcoin/pull/19683/commits/107f33d434ebbe6f93fa187e2af1f6f850e82d3b
565 2021-01-07T20:41:07  <jb55> isnt that a makefile
566 2021-01-07T20:41:56  <sipa> oh, it's makefile-quoting $
567 2021-01-07T20:42:00  <sipa> jb55: thanks, indeed
568 2021-01-07T20:42:22  <wumpus> right it's token concatenation in make
569 2021-01-07T20:44:28  <wumpus> or, no, you're right, it's quoting
570 2021-01-07T20:48:12  <sipa> lol @ rwc2021 registration
571 2021-01-07T20:48:15  <sipa> "Enter the last name of one of the inventors of RSA to prove that you are human."
572 2021-01-07T20:49:22  <real_or_random> yeah they're using the same captcha for all their conferences now
573 2021-01-07T20:49:37  <sdaftuar> Cocks?
574 2021-01-07T20:49:45  <real_or_random> yes, Cocks workds
575 2021-01-07T20:50:19  <sipa> nice
576 2021-01-07T20:52:30  <real_or_random> and they'll have a virtual "cards against cryptography" game in the venue :D
577 2021-01-07T20:52:40  <real_or_random> "venue"
578 2021-01-07T20:53:12  *** troygior1hev <troygior1hev!~troygiors@bras-base-barion1858w-grc-01-216-209-164-24.dsl.bell.ca> has joined #bitcoin-core-dev
579 2021-01-07T20:53:26  <sipa> real_or_random: haha
580 2021-01-07T20:58:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
581 2021-01-07T20:58:37  <bitcoin-git> [bitcoin] achow101 opened pull request #20880: gitian: Use custom MacOS code signing tool (master...use-signapple) https://github.com/bitcoin/bitcoin/pull/20880
582 2021-01-07T20:58:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
583 2021-01-07T20:58:49  <achow101> ^ hopefully that's the end of this code signing saga
584 2021-01-07T20:59:06  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
585 2021-01-07T21:02:56  *** crisn2blink <crisn2blink!d12203c2@regus-business-centers-katy-209-34-3-194.consolidated.net> has quit IRC (Remote host closed the connection)
586 2021-01-07T21:04:57  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
587 2021-01-07T21:05:24  <dongcarl> sipa: When you eval a call in make, it is sometimes necessary to double-quote using $$, see: https://www.gnu.org/software/make/manual/html_node/Eval-Function.html
588 2021-01-07T21:06:16  * dongcarl has a branch that double-quotes all of our eval'd calls in depends and should publish that at some point
589 2021-01-07T21:06:53  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Read error: Connection reset by peer)
590 2021-01-07T21:07:07  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
591 2021-01-07T21:08:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
592 2021-01-07T21:08:11  <bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/d7e2401c629b...86a8b35f321d
593 2021-01-07T21:08:12  <bitcoin-git> bitcoin/master f6cec0b Evan Klitzke: util: Refactor FileCommit from an #if sequence nested in #else, to a seque...
594 2021-01-07T21:08:12  <bitcoin-git> bitcoin/master 844d650 Evan Klitzke: util: Prefer Mac-specific F_FULLSYNC over fdatasync in FileCommit
595 2021-01-07T21:08:13  <bitcoin-git> bitcoin/master ce5cbae Evan Klitzke: util.h: Document FileCommit function
596 2021-01-07T21:08:14  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
597 2021-01-07T21:08:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
598 2021-01-07T21:08:31  <bitcoin-git> [bitcoin] laanwj merged pull request #14501: Fix possible data race when committing block files (master...fsync_dir) https://github.com/bitcoin/bitcoin/pull/14501
599 2021-01-07T21:08:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
600 2021-01-07T21:09:07  <sipa> dongcarl: cool, thx
601 2021-01-07T21:09:22  <dongcarl> :-)
602 2021-01-07T21:15:27  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
603 2021-01-07T21:15:28  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has quit IRC (Remote host closed the connection)
604 2021-01-07T21:15:45  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
605 2021-01-07T21:15:51  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
606 2021-01-07T21:25:39  *** Kozuch <Kozuch!~Kozuch@> has joined #bitcoin-core-dev
607 2021-01-07T21:41:24  <sipa> achow101: i'm confused about 20871... it looks like p3yot3 is already using 0.21 code?
608 2021-01-07T21:41:41  <achow101> sipa: I'm pretty sure the problem is that the wallet version is 169900 but there is no hd seed
609 2021-01-07T21:41:55  <achow101> the only way to resolve that is to do the upgrade again with 0.21
610 2021-01-07T21:42:58  <achow101> this is quite an unfortunate bug. in 0.17, we added upgrading to hd wallets, but forgot about encrypted wallets. if you tried to do that with an encrypted wallet, the version number would be increased, but no hd stuff created
611 2021-01-07T21:45:45  <sipa> so what's the problem? i thought he didn't want to run pre-release code, but he clearly already is
612 2021-01-07T21:45:57  <achow101> the problem is he didn't do upgradewallet
613 2021-01-07T21:46:04  <achow101> I'm writing a response with some more detail
614 2021-01-07T21:46:53  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
615 2021-01-07T21:49:34  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 256 seconds)
616 2021-01-07T21:54:26  *** troygior1hev <troygior1hev!~troygiors@bras-base-barion1858w-grc-01-216-209-164-24.dsl.bell.ca> has quit IRC (Ping timeout: 256 seconds)
617 2021-01-07T21:57:56  *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-netvovtobqfafxal> has quit IRC (Quit: Connection closed for inactivity)
618 2021-01-07T21:59:44  *** MTennis <MTennis!~Tennis@unaffiliated/tennis> has quit IRC (Read error: Connection reset by peer)
619 2021-01-07T21:59:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
620 2021-01-07T21:59:51  <bitcoin-git> [gui] hebasto opened pull request #177: Use "fusion" style on macOS Big Sur with old Qt (master...210107-style) https://github.com/bitcoin-core/gui/pull/177
621 2021-01-07T21:59:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
622 2021-01-07T22:03:11  *** kvaciral <kvaciral!~kvaciral@> has quit IRC (Quit: leaving)
623 2021-01-07T22:07:55  *** Guyver2__ <Guyver2__!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
624 2021-01-07T22:10:32  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 256 seconds)
625 2021-01-07T22:10:35  *** Kozuch <Kozuch!~Kozuch@> has quit IRC (Quit: Leaving)
626 2021-01-07T22:11:37  *** Kozuch <Kozuch!~Kozuch@> has joined #bitcoin-core-dev
627 2021-01-07T22:14:09  *** tralfaz <tralfaz!~davterra@static-198-54-134-60.cust.tzulo.com> has joined #bitcoin-core-dev
628 2021-01-07T22:18:02  *** davterra <davterra!~davterra@static-198-54-134-68.cust.tzulo.com> has quit IRC (Ping timeout: 265 seconds)
629 2021-01-07T22:23:51  *** schulzemic <schulzemic!~ada@> has joined #bitcoin-core-dev
630 2021-01-07T22:24:42  *** Guyver2__ <Guyver2__!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
631 2021-01-07T22:36:16  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
632 2021-01-07T22:49:40  *** sr_gi <sr_gi!~sr_gi@> has quit IRC (Quit: The Lounge - https://thelounge.chat)
633 2021-01-07T23:02:26  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 264 seconds)
634 2021-01-07T23:12:27  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
635 2021-01-07T23:13:19  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
636 2021-01-07T23:18:10  *** lightlike <lightlike!~lightlike@p200300c7ef19fc0034e2d3ab670ebeac.dip0.t-ipconnect.de> has quit IRC (Quit: Leaving)
637 2021-01-07T23:31:02  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
638 2021-01-07T23:40:43  *** schulzemic <schulzemic!~ada@> has quit IRC (Quit: Konversation terminated!)
639 2021-01-07T23:42:50  *** Kozuch <Kozuch!~Kozuch@> has quit IRC (Quit: Leaving)
640 2021-01-07T23:45:47  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
641 2021-01-07T23:48:56  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 240 seconds)
642 2021-01-07T23:52:45  *** tralfaz is now known as davterra