1 2021-01-13T00:13:28  <amiti> #20811 might also be rfm / has 3 acks
  2 2021-01-13T00:13:31  <gribble> https://github.com/bitcoin/bitcoin/issues/20811 | refactor: move net_processing implementation details out of header by ajtowns · Pull Request #20811 · bitcoin/bitcoin · GitHub
  3 2021-01-13T00:22:42  *** elrifleman <elrifleman!63172455@99-23-36-85.lightspeed.hstntx.sbcglobal.net> has joined #bitcoin-core-dev
  4 2021-01-13T00:23:32  *** elrifleman <elrifleman!63172455@99-23-36-85.lightspeed.hstntx.sbcglobal.net> has quit IRC (Client Quit)
  5 2021-01-13T00:26:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
  6 2021-01-13T00:26:18  <bitcoin-git> [bitcoin] theStack opened pull request #20921: validation: don't try to invalidate genesis block in CChainState::InvalidateBlock (master...2021-rpc-forbid_invalidateblock_on_genesisblock) https://github.com/bitcoin/bitcoin/pull/20921
  7 2021-01-13T00:26:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
  8 2021-01-13T00:29:36  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has joined #bitcoin-core-dev
  9 2021-01-13T00:39:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 10 2021-01-13T00:39:24  <bitcoin-git> [bitcoin] sinetek closed pull request #20920: add include for std::bind. (master...FUNCTIONAL) https://github.com/bitcoin/bitcoin/pull/20920
 11 2021-01-13T00:39:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 12 2021-01-13T01:06:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 13 2021-01-13T01:06:29  <bitcoin-git> [gui] sinetek opened pull request #183: Add include for std::bind. (master...functional) https://github.com/bitcoin-core/gui/pull/183
 14 2021-01-13T01:06:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 15 2021-01-13T01:15:01  *** MasterdonX <MasterdonX!~masterdon@45.9.249.244> has joined #bitcoin-core-dev
 16 2021-01-13T01:16:45  *** rex4539_ <rex4539_!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Remote host closed the connection)
 17 2021-01-13T01:21:21  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:255c:8c1d:42fb:24ab:a8e9> has joined #bitcoin-core-dev
 18 2021-01-13T01:36:13  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
 19 2021-01-13T01:45:18  *** DevnySee <DevnySee!0ec9f4e1@14-201-244-225.tpgi.com.au> has joined #bitcoin-core-dev
 20 2021-01-13T01:45:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 21 2021-01-13T01:45:19  <bitcoin-git> [bitcoin] sinetek opened pull request #20922: switch over to std::shared_mutex. (master...stdsm) https://github.com/bitcoin/bitcoin/pull/20922
 22 2021-01-13T01:45:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 23 2021-01-13T01:48:47  *** ReleaseGreed24 <ReleaseGreed24!44eb20fe@static-68-235-32-254.cust.tzulo.com> has joined #bitcoin-core-dev
 24 2021-01-13T01:49:53  *** DevnySee <DevnySee!0ec9f4e1@14-201-244-225.tpgi.com.au> has quit IRC (Ping timeout: 248 seconds)
 25 2021-01-13T01:52:34  *** ReleaseGreed24 <ReleaseGreed24!44eb20fe@static-68-235-32-254.cust.tzulo.com> has quit IRC (Client Quit)
 26 2021-01-13T02:06:58  *** FrontSevens <FrontSevens!~FrontSeve@185.204.1.185> has quit IRC (Remote host closed the connection)
 27 2021-01-13T02:12:44  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
 28 2021-01-13T02:15:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 29 2021-01-13T02:15:21  <bitcoin-git> [bitcoin] sinetek closed pull request #20922: switch over to std::shared_mutex. (master...stdsm) https://github.com/bitcoin/bitcoin/pull/20922
 30 2021-01-13T02:15:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 31 2021-01-13T02:17:28  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 260 seconds)
 32 2021-01-13T02:23:57  *** MartinAS1 <MartinAS1!~MartinAS@185.163.110.125> has joined #bitcoin-core-dev
 33 2021-01-13T02:40:55  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
 34 2021-01-13T02:45:03  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 240 seconds)
 35 2021-01-13T02:54:09  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
 36 2021-01-13T02:54:18  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
 37 2021-01-13T02:57:42  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
 38 2021-01-13T02:59:56  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Remote host closed the connection)
 39 2021-01-13T03:17:22  *** achow101 <achow101!~achow101@unaffiliated/achow101> has quit IRC (Quit: Bye)
 40 2021-01-13T03:18:23  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
 41 2021-01-13T03:18:49  *** achow101 <achow101!~achow101@unaffiliated/achow101> has joined #bitcoin-core-dev
 42 2021-01-13T03:20:51  *** achow101 <achow101!~achow101@unaffiliated/achow101> has quit IRC (Client Quit)
 43 2021-01-13T03:21:01  *** achow101 <achow101!~achow101@unaffiliated/achow101> has joined #bitcoin-core-dev
 44 2021-01-13T03:27:49  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 264 seconds)
 45 2021-01-13T03:44:05  *** jespada <jespada!~jespada@90.254.245.49> has quit IRC (Ping timeout: 240 seconds)
 46 2021-01-13T03:47:07  *** jespada <jespada!~jespada@90.254.245.49> has joined #bitcoin-core-dev
 47 2021-01-13T03:53:30  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
 48 2021-01-13T03:58:24  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 272 seconds)
 49 2021-01-13T04:01:18  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
 50 2021-01-13T04:04:33  *** MartinAS1 <MartinAS1!~MartinAS@185.163.110.125> has quit IRC (Remote host closed the connection)
 51 2021-01-13T04:04:49  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Remote host closed the connection)
 52 2021-01-13T04:06:12  *** tomCook <tomCook!b2a5825e@178.165.130.94.wireless.dyn.drei.com> has joined #bitcoin-core-dev
 53 2021-01-13T04:07:59  *** tomCook <tomCook!b2a5825e@178.165.130.94.wireless.dyn.drei.com> has quit IRC (Client Quit)
 54 2021-01-13T04:16:29  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 260 seconds)
 55 2021-01-13T04:17:19  *** MasterdonX <MasterdonX!~masterdon@45.9.249.244> has quit IRC (Ping timeout: 246 seconds)
 56 2021-01-13T04:21:24  *** tadeo <tadeo!~tadeo@185.103.96.147> has joined #bitcoin-core-dev
 57 2021-01-13T04:29:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 58 2021-01-13T04:29:41  <bitcoin-git> [bitcoin] ajtowns opened pull request #20923: signet miner followups (master...202101-signet-tweak) https://github.com/bitcoin/bitcoin/pull/20923
 59 2021-01-13T04:29:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 60 2021-01-13T04:55:54  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
 61 2021-01-13T04:55:57  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
 62 2021-01-13T04:56:03  *** vasild_ is now known as vasild
 63 2021-01-13T05:04:17  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
 64 2021-01-13T05:24:39  *** tripleslash <tripleslash!~triplesla@unaffiliated/imsaguy> has quit IRC (Read error: Connection reset by peer)
 65 2021-01-13T05:25:59  *** tripleslash <tripleslash!~triplesla@unaffiliated/imsaguy> has joined #bitcoin-core-dev
 66 2021-01-13T05:54:18  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
 67 2021-01-13T06:05:37  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Remote host closed the connection)
 68 2021-01-13T06:14:17  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has quit IRC (Ping timeout: 260 seconds)
 69 2021-01-13T06:27:16  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 240 seconds)
 70 2021-01-13T06:44:35  *** thomaseizinger <thomaseizinger!thomaseizi@gateway/shell/matrix.org/x-kjdwehkpxcuxnxpm> has joined #bitcoin-core-dev
 71 2021-01-13T06:54:43  *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Remote host closed the connection)
 72 2021-01-13T07:18:34  *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
 73 2021-01-13T07:31:42  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 74 2021-01-13T07:43:18  <wumpus> jonatack: using @ in your ACK messages is messing with the github-merge script :)
 75 2021-01-13T07:44:12  <wumpus> (it has a detection for those to avoid @... mentions that would cause spam with github's email notification so it makes it warn about @'s in the merge message)
 76 2021-01-13T07:46:31  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has joined #bitcoin-core-dev
 77 2021-01-13T07:50:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 78 2021-01-13T07:50:39  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/7b975639ef93...8ffaf5c2f5aa
 79 2021-01-13T07:50:40  <bitcoin-git> bitcoin/master 95e61c1 Andrew Chow: Move Hashers to util/hasher.{cpp/h}
 80 2021-01-13T07:50:41  <bitcoin-git> bitcoin/master 210b693 Andrew Chow: Add generic SaltedSipHasher
 81 2021-01-13T07:50:42  <bitcoin-git> bitcoin/master 281fd1a Andrew Chow: Replace KeyIDHasher with SaltedSipHasher
 82 2021-01-13T07:50:43  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 83 2021-01-13T07:51:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 84 2021-01-13T07:51:03  <bitcoin-git> [bitcoin] laanwj merged pull request #19935: Move SaltedHashers to separate file and add some new ones (master...mv-saltedhash) https://github.com/bitcoin/bitcoin/pull/19935
 85 2021-01-13T07:51:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 86 2021-01-13T07:52:34  *** BGL <BGL!~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net> has quit IRC (Ping timeout: 256 seconds)
 87 2021-01-13T07:54:32  <wumpus> darosior: yes, the release notes are in the wiki during the release candidate phase for easy editing
 88 2021-01-13T07:57:47  <wumpus> darosior: invited you to the "frequent contributors" group for bitcoin and bitcoin-core orgs (this is not currently a requirement for editing the wiki but will likely become so)
 89 2021-01-13T08:01:45  <fanquake> wumpus: I like how GH is 2/4 when rendering your avatar in dark mode..
 90 2021-01-13T08:01:47  <fanquake> https://0bin.net/paste/6ajdCt0b#AVXlGRuYmR9zWXvQI7ymi7ej783qLPcu4isqeLBGdnv
 91 2021-01-13T08:02:05  *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
 92 2021-01-13T08:05:35  <wumpus> fanquake: yea it's interesting how many websites don't take transparency in avatars into account and do the weirdest things, github sometimes adds a white circle behind it, sometimes shows it as transparent... and sometimes, adds only weird white lines :)
 93 2021-01-13T08:20:13  *** asoltys <asoltys!~root@s207-81-214-2.bc.hsia.telus.net> has quit IRC (Ping timeout: 246 seconds)
 94 2021-01-13T08:25:08  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
 95 2021-01-13T08:31:22  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Remote host closed the connection)
 96 2021-01-13T08:32:52  *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f24de00a0f0fc7b4b585d7b.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
 97 2021-01-13T08:42:31  *** tadeo <tadeo!~tadeo@185.103.96.147> has quit IRC (Remote host closed the connection)
 98 2021-01-13T08:43:12  *** hoobop1 <hoobop1!~hoobop@84.39.117.57> has joined #bitcoin-core-dev
 99 2021-01-13T08:45:11  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
100 2021-01-13T08:46:23  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
101 2021-01-13T08:48:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
102 2021-01-13T08:48:50  <bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/8ffaf5c2f5aa...60427ee35f28
103 2021-01-13T08:48:50  <bitcoin-git> bitcoin/master 0d246a5 Anthony Towns: net, net_processing: move NetEventsInterface method docs to net.h
104 2021-01-13T08:48:51  <bitcoin-git> bitcoin/master 0df3d3f Anthony Towns: net_processing: make more of PeerManager private
105 2021-01-13T08:48:51  <bitcoin-git> bitcoin/master a568b82 Anthony Towns: net_processing: split PeerManager into interface and implementation classes
106 2021-01-13T08:48:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
107 2021-01-13T08:49:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
108 2021-01-13T08:49:10  <bitcoin-git> [bitcoin] laanwj merged pull request #20811: refactor: move net_processing implementation details out of header (master...202012-netproc-impl-split) https://github.com/bitcoin/bitcoin/pull/20811
109 2021-01-13T08:49:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
110 2021-01-13T08:52:18  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
111 2021-01-13T08:57:40  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 246 seconds)
112 2021-01-13T08:58:43  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:255c:8c1d:42fb:24ab:a8e9> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
113 2021-01-13T09:03:58  <wumpus> that said my avatar doesn't really work that well in dark mode (black on grey), should probably make it a color that works in either setting like purple
114 2021-01-13T09:04:26  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
115 2021-01-13T09:16:13  <darosior> re wiki: Ok, thanks
116 2021-01-13T09:16:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
117 2021-01-13T09:16:46  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/60427ee35f28...e7eb37128c31
118 2021-01-13T09:16:47  <bitcoin-git> bitcoin/master b5e93f8 Wladimir J. van der Laan: doc: Add manual page generation for bitcoin-util
119 2021-01-13T09:16:48  <bitcoin-git> bitcoin/master bc99ae7 Wladimir J. van der Laan: scripted-diff: Fix typo in stub manual pages
120 2021-01-13T09:16:49  <bitcoin-git> bitcoin/master e7eb371 Wladimir J. van der Laan: Merge #20913: doc: Add manual page generation for bitcoin-util
121 2021-01-13T09:16:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
122 2021-01-13T09:17:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
123 2021-01-13T09:17:09  <bitcoin-git> [bitcoin] laanwj merged pull request #20913: doc: Add manual page generation for bitcoin-util (master...2021_01_bitcoin_util_manpage) https://github.com/bitcoin/bitcoin/pull/20913
124 2021-01-13T09:17:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
125 2021-01-13T09:24:46  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
126 2021-01-13T09:27:05  <MarcoFalke> > [22:11] <wumpus> unless anything comes up, i plan on merging the wiki back into the branch then tagging 0.21.0 final tomorrow
127 2021-01-13T09:27:07  <MarcoFalke> ACK
128 2021-01-13T09:41:29  <jonatack> wumpus: oh! i know that well. trying to remember when i did that
129 2021-01-13T09:43:01  <jonatack> wumpus: ah, when i wrote @ <commit>?
130 2021-01-13T09:44:05  <jonatack> i wrote "ran node @ head as a sanity check", didn't realize that would cause an issue
131 2021-01-13T09:45:30  <jonatack> (fixed)
132 2021-01-13T09:45:49  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
133 2021-01-13T09:53:10  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
134 2021-01-13T09:53:24  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
135 2021-01-13T09:54:16  <wumpus> jonatack: thanks, it's not a big deal, @'s can appear for various reasons, but it prompted me to write https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/69
136 2021-01-13T10:04:32  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has quit IRC (Remote host closed the connection)
137 2021-01-13T10:04:52  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has joined #bitcoin-core-dev
138 2021-01-13T10:19:10  *** CubicEarth <CubicEarth!~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net> has quit IRC (Ping timeout: 256 seconds)
139 2021-01-13T10:27:38  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has quit IRC (Ping timeout: 264 seconds)
140 2021-01-13T10:36:42  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:255c:8c1d:42fb:24ab:a8e9> has joined #bitcoin-core-dev
141 2021-01-13T10:58:50  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:255c:8c1d:42fb:24ab:a8e9> has quit IRC (Ping timeout: 264 seconds)
142 2021-01-13T11:05:39  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC ()
143 2021-01-13T11:18:30  *** Alva35Walter <Alva35Walter!~Alva35Wal@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
144 2021-01-13T12:37:36  *** Alva35Walter <Alva35Walter!~Alva35Wal@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 240 seconds)
145 2021-01-13T12:44:31  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Remote host closed the connection)
146 2021-01-13T12:44:48  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
147 2021-01-13T12:56:03  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:255c:8c1d:42fb:24ab:a8e9> has joined #bitcoin-core-dev
148 2021-01-13T12:59:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
149 2021-01-13T12:59:49  <bitcoin-git> [bitcoin] jnewbery opened pull request #20925: RFC: Move Peer and PeerManagerImpl to separate header (master...2021-01-peermanimplh) https://github.com/bitcoin/bitcoin/pull/20925
150 2021-01-13T12:59:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
151 2021-01-13T13:05:28  *** dviola <dviola!~diego@unaffiliated/dviola> has quit IRC (Quit: WeeChat 3.0)
152 2021-01-13T13:27:16  *** norisgOG_ <norisgOG_!~norisgOG@89.45.6.92> has joined #bitcoin-core-dev
153 2021-01-13T13:27:43  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
154 2021-01-13T13:31:45  <norisgOG_> Hello all I have a question concering signatures in bitcoin, where in the transaction can I see which HASH_Type I have to use to calculate the transaction hash ?
155 2021-01-13T13:37:01  *** ogo <ogo!~ogo@gateway/tor-sasl/ogo> has quit IRC (Remote host closed the connection)
156 2021-01-13T13:37:07  *** Bitcoinr <Bitcoinr!~Bitcoinr@202.185.196.193> has joined #bitcoin-core-dev
157 2021-01-13T13:43:51  *** Bitcoinr is now known as ray
158 2021-01-13T13:44:11  <wumpus> norisgOG_: #bitcoin please, this channel is for development ony
159 2021-01-13T13:44:14  *** ray is now known as rayyy
160 2021-01-13T13:46:48  *** rayyy is now known as rayonx
161 2021-01-13T13:47:37  *** rayonx is now known as rayyy
162 2021-01-13T13:48:21  *** rayyy <rayyy!~Bitcoinr@202.185.196.193> has quit IRC (Quit: Exit game!)
163 2021-01-13T14:14:13  *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
164 2021-01-13T14:17:16  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 240 seconds)
165 2021-01-13T14:20:21  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Remote host closed the connection)
166 2021-01-13T14:22:38  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
167 2021-01-13T14:36:26  <vasild> wumpus: what about reverting https://github.com/bitcoin/bitcoin/pull/20852 ?
168 2021-01-13T14:37:11  <wumpus> vasild: sure, just make a PR that reverts it
169 2021-01-13T14:37:26  <vasild> ok
170 2021-01-13T14:41:07  <wumpus> it's too late to rush a revert, but still it's fairly easy to review
171 2021-01-13T14:43:04  *** lontivero <lontivero!~lontivero@186.183.48.235> has joined #bitcoin-core-dev
172 2021-01-13T14:44:26  <MarcoFalke> why revert?
173 2021-01-13T14:44:42  <MarcoFalke> Was it wrong? I think it is just incomplete.
174 2021-01-13T14:48:23  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
175 2021-01-13T14:48:26  <wumpus> in that case, better to improve it instead
176 2021-01-13T14:49:55  <wumpus> the only reason to revert it would be if it's causing major issues to people running master, or there's no clear way forward
177 2021-01-13T14:51:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
178 2021-01-13T14:51:50  <bitcoin-git> [bitcoin] vasild opened pull request #20926: revert #20852 net: allow CSubNet of non-IP networks (master...revert_20852) https://github.com/bitcoin/bitcoin/pull/20926
179 2021-01-13T14:51:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
180 2021-01-13T14:55:38  <wumpus> btw: my release notes pull request listing script can't distinguish between gui and main repo PRs, is there a way to do this based on the merge commit message?
181 2021-01-13T14:55:46  <wumpus> (i had to sort them out manually this time)
182 2021-01-13T14:56:28  <wumpus> (which is, still, pretty easy "low numbers are gui repo" but not really ideal)
183 2021-01-13T14:58:02  <MarcoFalke> the merge commits start with "bitcoin-core/gui#123 remove foobar"
184 2021-01-13T14:58:06  <gribble> https://github.com/bitcoin/bitcoin/issues/123 | Spent per txout by sipa · Pull Request #123 · bitcoin/bitcoin · GitHub
185 2021-01-13T14:58:47  <MarcoFalke> so you can do title.startswith('Merge bitcoin-core/gui#')
186 2021-01-13T14:59:10  <wumpus> MarcoFalke: thanks
187 2021-01-13T14:59:34  <wumpus> that sounds easy :)
188 2021-01-13T15:00:57  <wumpus> I did use the gui#1234 convention in the release notes, likely we need to update the bitcoin-core.org HTML-izing plugin as well to recognize these and generate valid links to them
189 2021-01-13T15:00:59  <gribble> https://github.com/bitcoin/bitcoin/issues/1234 | During initial sync, chain download pauses if peer goes away · Issue #1234 · bitcoin/bitcoin · GitHub
190 2021-01-13T15:06:17  <vasild> MarcoFalke: so you decide to ban torv3.onion, do "setban torv3.onion add". The ban is effective and works. 2 days later bitcoin core is restarted. The ban is lost, silently.
191 2021-01-13T15:06:41  <MarcoFalke> what would happen with the revert?
192 2021-01-13T15:06:49  <MarcoFalke> does the rpc fail silently or verbosely?
193 2021-01-13T15:07:17  <vasild> let me see...
194 2021-01-13T15:08:46  <MarcoFalke> Either way, it shouldn't matter much. We are aware of the issue and know that the file format needs to change. Reverting the pull doesn't help changing the file format.
195 2021-01-13T15:08:51  <wumpus> i guess it's this fragment: https://github.com/bitcoin-core/bitcoincore.org/blob/master/_includes/link-to-issues.md   also ping @harding
196 2021-01-13T15:09:16  <harding> hi
197 2021-01-13T15:09:17  <vasild> $ bitcoin-cli setban pg6mmjiyjmcrsslvykfwnntlaru7p5svn6y2ymmju6nubxndf4pscryd.onion add
198 2021-01-13T15:09:30  <vasild> $
199 2021-01-13T15:09:45  <MarcoFalke> So this also silently fails
200 2021-01-13T15:09:45  <vasild> (success)
201 2021-01-13T15:09:59  <vasild> the log says "SweepBanned: Removed banned node ip/subnet from banlist.dat: ::/0"
202 2021-01-13T15:10:08  <wumpus> harding: hi! for 0.21.0 we have a new kind of PR which comes from the bitcoin-core/gui repository, I've used the syntax "gui/#xxxx" to refer to these, if we want these to point to the right repository we'll need to update the link conversion
203 2021-01-13T15:10:09  <vasild> (but nobody reads the log anyway)
204 2021-01-13T15:10:58  <MarcoFalke> If you are worried that someone is running master and doesn't see the silent fail, you can turn it into a verbose fail. Though I'd rather prefer to spend the resources on fixing the file format
205 2021-01-13T15:11:09  <vasild> MarcoFalke: ok, but at least if the tries to verify if the ban succeeded he will see it did not. While with the PR it will work for some time, until a restart...
206 2021-01-13T15:11:23  <harding> wumpus: got it.  I think that should, if we do nothing, just not produce a link, which isn't ideal but at least isn't broken.  I'll look into making it work.  Thanks for the heads-up!
207 2021-01-13T15:12:12  <wumpus> harding: that's good to know! i was afraid it would make a link to the bitcoin/bitcoin issue of the same number that would be bad, but yes that seems acceptable really
208 2021-01-13T15:12:19  <vasild> but you are right, the difference is not so big, while the PR still fixes the DisconnectNode() issue properly
209 2021-01-13T15:12:45  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:255c:8c1d:42fb:24ab:a8e9> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
210 2021-01-13T15:16:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
211 2021-01-13T15:16:49  <bitcoin-git> [bitcoin] vasild closed pull request #20926: revert #20852 net: allow CSubNet of non-IP networks (master...revert_20852) https://github.com/bitcoin/bitcoin/pull/20926
212 2021-01-13T15:16:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
213 2021-01-13T15:18:26  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:255c:8c1d:42fb:24ab:a8e9> has joined #bitcoin-core-dev
214 2021-01-13T15:20:27  <vasild> What about changing banman to maintain a list of banned IP-subnets (like before 20852) - no format change in banlist.dat. Plus add a list of banned hosts and save it in `banhosts.dat` (always in addrv2 format)
215 2021-01-13T15:21:32  <vasild> that looks like a perfect forward/backward/sideways file format compatibility
216 2021-01-13T15:23:43  <MarcoFalke> #19748
217 2021-01-13T15:23:45  <gribble> https://github.com/bitcoin/bitcoin/issues/19748 | Deprecate banlist.dat · Issue #19748 · bitcoin/bitcoin · GitHub
218 2021-01-13T15:24:00  * vasild reading...
219 2021-01-13T15:26:06  <MarcoFalke> json probably means we can skip the serialization/deserialization and just dump the rpc argument directly
220 2021-01-13T15:28:45  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
221 2021-01-13T15:29:34  <MarcoFalke> Though on startup (when the json doesn't exist) you'd have to convert the banlist.dat once to json. Not sure if that is easily possible.
222 2021-01-13T15:30:32  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
223 2021-01-13T15:30:56  <vasild> MarcoFalke: we have CSubNet::ToString()
224 2021-01-13T15:31:06  <MarcoFalke> oh nice
225 2021-01-13T15:32:35  <vasild> so, looks like putting the entries in a .json would resolve any file format addrv1 vs addrv2 issues. Will be bigger on disk and slower to write/read, but insignificantly.
226 2021-01-13T15:34:10  <wumpus> most people aren't going to have that many bans for it to matter wrt start-up performance i guess :)
227 2021-01-13T15:34:17  <MarcoFalke> The network has 100k nodes, so even if all nodes are banned in the json file, it should be still smaller than the largest wallet.dat we've seen
228 2021-01-13T15:35:18  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
229 2021-01-13T15:35:40  <wumpus> i wouldn't suggest doing the same for the peers.dat
230 2021-01-13T15:36:35  <vasild> 100k x ~20 bytes per entry =~ 2MiB
231 2021-01-13T15:36:44  <jonatack> i used to have a lot of bans, but it's been awhile since i was able to find the banlist, is it still online/maintained?
232 2021-01-13T15:37:08  <vasild> yes! :-)
233 2021-01-13T15:37:25  <jonatack> iirc it was 700-1000 entries last time i saw it
234 2021-01-13T15:37:58  <wumpus> gmaxwell used to maintain a ban list, but don't know if he did for a while
235 2021-01-13T15:38:08  <jonatack> yes that one
236 2021-01-13T15:38:44  <vasild> my "yes!" was for the banlist.dat file in the datadir
237 2021-01-13T15:39:24  *** setpill <setpill!~setpill@unaffiliated/setpill> has joined #bitcoin-core-dev
238 2021-01-13T15:41:02  <vasild> I have a node that is permanently online and listening on ipv4/6 and banlist.dat is 37 bytes (I guess empty list). Lets focus on whether to put it in settings.json or in banlist.json ...
239 2021-01-13T15:41:33  <wumpus> a separate file still makes sense imo
240 2021-01-13T15:42:22  <jonatack> agree, banlist.json
241 2021-01-13T15:45:08  *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
242 2021-01-13T15:45:21  <vasild> +1
243 2021-01-13T15:45:24  <luke-jr> is github working poorly for others as well?
244 2021-01-13T15:47:38  <vasild> luke-jr: poorly == slowly?
245 2021-01-13T15:47:39  <jb55> like more than normal?
246 2021-01-13T15:51:31  <luke-jr> vasild: possibly; I clicked "cancel" (to change the scope of my review comment) and it ignored me
247 2021-01-13T15:52:03  <vasild> luke-jr: I have seen that too - clicks being ignored
248 2021-01-13T16:16:51  *** dviola <dviola!~diego@unaffiliated/dviola> has joined #bitcoin-core-dev
249 2021-01-13T16:23:06  *** pinheadmz <pinheadmz!~pinheadmz@68.161.139.178> has quit IRC (Remote host closed the connection)
250 2021-01-13T16:23:34  *** pinheadmz <pinheadmz!~pinheadmz@68.161.139.178> has joined #bitcoin-core-dev
251 2021-01-13T16:33:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
252 2021-01-13T16:33:12  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e7eb37128c31...22fa9673b02e
253 2021-01-13T16:33:12  <bitcoin-git> bitcoin/master fc726e0 Sebastian Falbesoner: doc, rpc: add missing signet mentions in network name lists
254 2021-01-13T16:33:13  <bitcoin-git> bitcoin/master 22fa967 MarcoFalke: Merge #20917: doc, rpc: add missing signet mentions in network name lists
255 2021-01-13T16:33:14  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
256 2021-01-13T16:33:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
257 2021-01-13T16:33:33  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20917: doc, rpc: add missing signet mentions in network name lists (master...2021-add_missing_signet_network_name) https://github.com/bitcoin/bitcoin/pull/20917
258 2021-01-13T16:33:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
259 2021-01-13T16:36:01  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:255c:8c1d:42fb:24ab:a8e9> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
260 2021-01-13T16:37:17  *** kexkey <kexkey!~kexkey@static-198-54-132-157.cust.tzulo.com> has joined #bitcoin-core-dev
261 2021-01-13T16:39:37  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@d5152f744.static.telenet.be> has quit IRC ()
262 2021-01-13T16:39:50  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:255c:18d1:c1a9:13be:6f9e> has joined #bitcoin-core-dev
263 2021-01-13T16:40:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
264 2021-01-13T16:40:00  <bitcoin-git> [bitcoin] jnewbery opened pull request #20927: [refactor] [net] Clean up InactivityCheck() (master...2021-01-timeout-cleanup) https://github.com/bitcoin/bitcoin/pull/20927
265 2021-01-13T16:40:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
266 2021-01-13T16:40:16  *** DeanWeen <DeanWeen!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
267 2021-01-13T16:41:45  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
268 2021-01-13T16:43:27  *** jouke <jouke!~jouke@a80-100-203-151.adsl.xs4all.nl> has quit IRC (Ping timeout: 260 seconds)
269 2021-01-13T16:43:41  *** jouke <jouke!~jouke@a80-100-203-151.adsl.xs4all.nl> has joined #bitcoin-core-dev
270 2021-01-13T16:47:31  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:255c:18d1:c1a9:13be:6f9e> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
271 2021-01-13T16:48:23  <wumpus> no problems here with github today (but haven't checked if blocking works again)
272 2021-01-13T16:49:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
273 2021-01-13T16:49:13  <bitcoin-git> [gui] MarcoFalke merged pull request #148: Bugfix: GUI: Restore SendConfirmationDialog button default to "Yes" (master...bugfix_gui_bumpyes) https://github.com/bitcoin-core/gui/pull/148
274 2021-01-13T16:49:14  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
275 2021-01-13T16:49:22  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Remote host closed the connection)
276 2021-01-13T16:49:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
277 2021-01-13T16:49:53  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/22fa9673b02e...cb2c57845177
278 2021-01-13T16:49:53  <bitcoin-git> bitcoin/master 8775691 Luke Dashjr: Bugfix: GUI: Restore SendConfirmationDialog button default to "Yes"
279 2021-01-13T16:49:54  <bitcoin-git> bitcoin/master cb2c578 MarcoFalke: Merge bitcoin-core/gui#148: Bugfix: GUI: Restore SendConfirmationDialog bu...
280 2021-01-13T16:49:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
281 2021-01-13T16:50:40  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
282 2021-01-13T16:52:57  <achow101> can someone invite me into ##bitcoin-core-gui?
283 2021-01-13T16:55:53  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@d5152f744.static.telenet.be> has joined #bitcoin-core-dev
284 2021-01-13T16:57:20  <hebasto> achow101: jonasschnelli can
285 2021-01-13T16:59:23  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
286 2021-01-13T16:59:32  <hebasto> achow101: cannot get op access to invite you
287 2021-01-13T17:00:38  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
288 2021-01-13T17:00:52  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Remote host closed the connection)
289 2021-01-13T17:03:43  *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f24de00a0f0fc7b4b585d7b.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
290 2021-01-13T17:04:31  *** larryruane_ <larryruane_!uid473749@gateway/web/irccloud.com/x-tuzsiyftnkimzhqh> has joined #bitcoin-core-dev
291 2021-01-13T17:05:40  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
292 2021-01-13T17:12:51  <harding> wumpus: for the website release notes, https://github.com/bitcoin-core/bitcoincore.org/pull/733
293 2021-01-13T17:14:57  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
294 2021-01-13T17:19:50  *** ggmonello <ggmonello!5d28fbe3@93-40-251-227.ip41.fastwebnet.it> has joined #bitcoin-core-dev
295 2021-01-13T17:21:24  *** ggmonello <ggmonello!5d28fbe3@93-40-251-227.ip41.fastwebnet.it> has quit IRC (Client Quit)
296 2021-01-13T17:23:01  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
297 2021-01-13T17:23:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
298 2021-01-13T17:23:11  <bitcoin-git> [bitcoin] cybercore-tech opened pull request #20928: Create sustainable_wallet (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20928
299 2021-01-13T17:23:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
300 2021-01-13T17:26:29  <wumpus> harding: thanks!!!
301 2021-01-13T17:34:15  <luke-jr> why is ##bitcoin-core-gui invite-only in the first place?
302 2021-01-13T17:35:45  <wumpus> to keep me out probably 😀
303 2021-01-13T17:36:43  <luke-jr> :|
304 2021-01-13T17:37:16  <wumpus> (TIL that that channel even exists)
305 2021-01-13T17:38:17  <luke-jr> I'm usually there, but the +i messes up my rejoin on reconnect :/
306 2021-01-13T17:41:40  *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has quit IRC (Quit: Leaving)
307 2021-01-13T17:45:36  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has joined #bitcoin-core-dev
308 2021-01-13T17:56:27  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
309 2021-01-13T17:56:47  *** Mercury_Vapor <Mercury_Vapor!~Mercury_V@174-082-158-108.res.spectrum.com> has quit IRC (Read error: Connection reset by peer)
310 2021-01-13T17:58:33  <achow101> luke-jr: I think it's because there was a bunch of spammers a few weeks ago
311 2021-01-13T18:00:06  *** jespada <jespada!~jespada@90.254.245.49> has quit IRC (Ping timeout: 272 seconds)
312 2021-01-13T18:00:39  *** setpill <setpill!~setpill@unaffiliated/setpill> has quit IRC (Quit: o/)
313 2021-01-13T18:00:50  <jb55> ah yes the antigui folks. ruthless bunch.
314 2021-01-13T18:02:21  *** jespada <jespada!~jespada@90.254.245.49> has joined #bitcoin-core-dev
315 2021-01-13T18:02:37  <luke-jr> XD
316 2021-01-13T18:03:54  <luke-jr> jb55: they only get that bad because Trump incited them <.< *hides*
317 2021-01-13T18:04:13  <wumpus> usually requiring nickserv sign in (+r) is enough to get rid of spammers
318 2021-01-13T18:05:35  <luke-jr> plot twist: the "spam" was just my IRC connection dropping/reconnecting in the first place
319 2021-01-13T18:16:13  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
320 2021-01-13T18:16:13  *** prayank <prayank!~andr0irc@2405:205:2180:41f3:133:6444:5db:787c> has joined #bitcoin-core-dev
321 2021-01-13T18:19:56  <prayank> Hello World. It will be helpful if one of the experienced devs could comment on this issue with : 1. Do we need to fix this? 2. What's the problem? 3. What should be the approach to fix it
322 2021-01-13T18:20:44  <prayank> https://github.com/bitcoin/bitcoin/issues/20795
323 2021-01-13T18:21:14  <wumpus> is everyone done editing the release notes for 0.21.0? i'd like to merge them back into the branch
324 2021-01-13T18:22:26  <sipa> prayank: there are several open PRs that improve coin selection, but there is currently not much activity on them
325 2021-01-13T18:23:00  <sipa> wumpus: i think that's fine
326 2021-01-13T18:23:02  <wumpus> if manual coin selection automatically adds an extra input in some case that does definitely sound like a bug
327 2021-01-13T18:24:25  <prayank> sipa: So the problem is with coin selection algorithm? Why is coin selection being used though if user had selected some inputs in initial tx? Or if it's designed to work like this then a warning is required so that user is aware of it
328 2021-01-13T18:24:33  *** CubicEarth <CubicEarth!~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net> has joined #bitcoin-core-dev
329 2021-01-13T18:24:46  <sipa> prayank: eh, the wallet doesn't know that the original transaction was using coin control
330 2021-01-13T18:24:59  <prayank> Interesting
331 2021-01-13T18:26:31  <sipa> so i think it's expected that if you use automatic fee bumping, you'll get whatever the coin selection algorithm decides
332 2021-01-13T18:27:01  <sipa> as for why it's not decreasing the change and instead adding another input... that may be a bug or a deficiency
333 2021-01-13T18:28:20  <luke-jr> wumpus: ugh, it looks like MarcoFalke simply deleted the Taproot paragraph -.-
334 2021-01-13T18:28:48  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
335 2021-01-13T18:31:56  <prayank> sipa: Thanks. I will do more research.
336 2021-01-13T18:32:35  *** Mercury_Vapor <Mercury_Vapor!~Mercury_V@174-082-158-108.res.spectrum.com> has joined #bitcoin-core-dev
337 2021-01-13T18:33:28  <luke-jr> wumpus: added it back in, with some rephrasing to hopefully address some of the concerns
338 2021-01-13T18:34:10  <sipa> luke-jr: nack
339 2021-01-13T18:34:31  <luke-jr> sipa: nack is not constructive
340 2021-01-13T18:34:49  <sipa> luke-jr: i've spent enough time arguing to explain my position
341 2021-01-13T18:34:59  <sipa> i don't see how this is any different from what you had before
342 2021-01-13T18:37:41  *** norisgOG_ <norisgOG_!~norisgOG@89.45.6.92> has quit IRC (Remote host closed the connection)
343 2021-01-13T18:37:44  <wumpus> many people disagree on adding that paragraph, including the people who worked on taproot, so we're not going to
344 2021-01-13T18:37:55  <luke-jr> 1) it suggests the bugfix-only releases as alternative upgrade paths
345 2021-01-13T18:38:11  <luke-jr> 2) it clarifies the absense of telemetry in the software in a way that should hopefully not be confusing
346 2021-01-13T18:38:38  <sipa> but you're still literally arguing for telemetry... just not one built-in to the software
347 2021-01-13T18:39:13  <luke-jr> sipa: the only "telemetry" already exists
348 2021-01-13T18:39:25  <sipa> yes, general upgrade patterns matter
349 2021-01-13T18:39:30  <sipa> upgrading to 0.21.0 does not
350 2021-01-13T18:39:46  <luke-jr> that's the point of the paragraph - to make it matter
351 2021-01-13T18:39:50  <sipa> it won't
352 2021-01-13T18:40:03  <luke-jr> if not, then nothing is lost
353 2021-01-13T18:40:16  <luke-jr> there are no downsides, just potential upsides
354 2021-01-13T18:40:36  <sipa> just confusion, imho
355 2021-01-13T18:40:52  <luke-jr> I rephrased it to avoid confusion
356 2021-01-13T18:40:58  <luke-jr> if you think you can phrase it better, feel free
357 2021-01-13T18:41:16  <luke-jr> but this is "perfect is enemy of the good" territory
358 2021-01-13T18:41:28  <sipa> i did; i added a paragraph about how taproot is included but without activation on mainnet, and that testing can be done on signet
359 2021-01-13T18:41:38  <luke-jr> that doesn't accomplish the same thing at all
360 2021-01-13T18:41:40  <sipa> i believe that is the extent to which bitcoin core should be involved with this
361 2021-01-13T18:44:13  <sipa> it just sounds bizarre, making it sound like bitcoin core's maintainers are going to use 0.21 upgrade numbers to decide how activation happens
362 2021-01-13T18:44:32  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC ()
363 2021-01-13T18:44:47  <luke-jr> developers have no business deciding such things in the first place
364 2021-01-13T18:44:59  <sipa> yes, so why is that paragraph there?
365 2021-01-13T18:45:15  <sipa> it'
366 2021-01-13T18:45:26  <luke-jr> because the upgrade speed of the network IS an important factor to making an educated guess on safe activation speed
367 2021-01-13T18:45:29  <sipa> s not our job to push for activation
368 2021-01-13T18:45:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
369 2021-01-13T18:45:29  <bitcoin-git> [bitcoin] laanwj opened pull request #20929: doc: Move 0.21.0 release notes from wiki (0.21...2021-01-relnot-0.21.0) https://github.com/bitcoin/bitcoin/pull/20929
370 2021-01-13T18:45:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
371 2021-01-13T18:46:22  <sipa> luke-jr: i agree with that, but i think (a) putting a note in the release notes will not meaningfully affect people's upgrade behavior (b) makes it sound like we (as software maintainers) are taking an active position in its deployment
372 2021-01-13T18:46:24  <luke-jr> you can ignore the data if you like, but what you're proposing by keeping the paragraph out, is interfering with others freely participating in such data review
373 2021-01-13T18:46:59  <sdaftuar> luke-jr: that paragraph doesn't add or detract from any data that anyone would review
374 2021-01-13T18:47:33  <luke-jr> yes it does
375 2021-01-13T18:49:12  <luke-jr> sipa: I disagree with (a) - if I'm wrong, there's no negative outcome; as for (b), what do you perceive in that way, and how can we avoid giving that impression?
376 2021-01-13T18:51:10  <sipa> by not talking about activation in our release notes, but just stating the facts: taproot is implemented, not active, can be tested and experimented with... we can add something about how mainnet activation is up for community discussion and will be implemented in a future version when there is agreement on that
377 2021-01-13T18:51:37  <luke-jr> throwing out the baby with the bathwater is not a solution
378 2021-01-13T18:53:42  *** ogo <ogo!~ogo@gateway/tor-sasl/ogo> has joined #bitcoin-core-dev
379 2021-01-13T18:54:06  <sipa> you argue that there is a reasonable chance it helps with anything; for that to be the case, either people would (a) adapt their 0.21 upgrade pattern to whatever they'll use for whatever potential release includes activation or (b) adapt their upgrade pattern for the release that includes activation to much what they're doing for 0.21; further it also requires (c) people participating in the
380 2021-01-13T18:54:12  <sipa> discussion on activation to have confidence...
381 2021-01-13T18:54:14  <sipa> that either (a) or (b) happens sufficiently take the 0.21 upgrade numbers specifically into account; i believe all 3 are false
382 2021-01-13T18:54:50  <luke-jr> even if all 3 were false, there is no harm done
383 2021-01-13T18:54:55  <sipa> yes there is
384 2021-01-13T18:54:58  <luke-jr> until we try, we won't know if you are right
385 2021-01-13T18:55:47  <sipa> bitcoin core's developers and maintainers shouldn't be using the release notes to further the goal of activation
386 2021-01-13T18:56:11  <sdaftuar> ^ completely agree
387 2021-01-13T18:56:21  <luke-jr> not even to the limited extent of helping the community coordinate better data?
388 2021-01-13T18:58:43  * jeremyrubin doubts anyone even reads the release notes
389 2021-01-13T18:59:10  <jeremyrubin> it's probably better to just do a separate blog post if you have a point to make IMO
390 2021-01-13T18:59:17  <luke-jr> hmm
391 2021-01-13T18:59:31  <luke-jr> I mean, if nobody reads them, why do we even write them? >.>
392 2021-01-13T18:59:46  <sdaftuar> jeremyrubin: i agree with that too. i think using the release notes to advocate one's own viewpoint is inappropriate in the face of disagreement from other contributors (such as the taproot author!)
393 2021-01-13T19:00:02  <luke-jr> sdaftuar: it's not even a viewpoint
394 2021-01-13T19:00:18  <sdaftuar> luke-jr: its a viewpoint about messaging
395 2021-01-13T19:00:39  <luke-jr> I see your point, I agree in that respect
396 2021-01-13T19:00:55  <luke-jr> hence why I asked
397 2021-01-13T19:00:57  <luke-jr> [18:56:21] <luke-jr> not even to the limited extent of helping the community coordinate better data?
398 2021-01-13T19:01:11  <jeremyrubin> I think a blog post is even more effective to that end
399 2021-01-13T19:01:54  <luke-jr> jeremyrubin: could be. though nothing limits it to one or the other, if we could agree on something
400 2021-01-13T19:02:04  <jeremyrubin> and w.r.t. "why write them if no one reads them", clearly people "read them". but I think it's unlikely it's anyone who is not already sufficiently plugged in that such a notice would change anything.
401 2021-01-13T19:02:44  <sipa> i think it's more likely that someone reads this and wonders why it's mentioned at all and what bitcoin core's role in this is, than that it would affect their upgrade behavior
402 2021-01-13T19:02:55  <sdaftuar> luke-jr: i also wouldn't really want to participate in some kind of shared "help the developers settle whether there's consensus for activation" process, for what it's worth.
403 2021-01-13T19:02:55  <luke-jr> what do folks think about wumpus simply including something to this effect in the ML release announcement?
404 2021-01-13T19:03:25  <luke-jr> sdaftuar: doh, I guess it's still too unclear, since it's not about consensus for activation :/
405 2021-01-13T19:03:49  <sdaftuar> i'm including method, timing, etc as part of all that
406 2021-01-13T19:04:18  <luke-jr> yeah, not even then - that's all discussion to be had *based on* this (and other) data
407 2021-01-13T19:04:47  <luke-jr> informed by*
408 2021-01-13T19:04:52  <sipa> it's a very subtle point, the distinction between consensus for activation, and deciding a safe activation mechanism... i think that distinction exists, but it's probably lost on most people
409 2021-01-13T19:05:33  <sdaftuar> well the point here is whether there is a group that is being spoken for in gathering information to inform debate, i believe
410 2021-01-13T19:05:59  <sdaftuar> and i am opposed to creating such a group that is somehow affiliated with the bitcoin core software
411 2021-01-13T19:06:24  <luke-jr> more of just telling people to speak for themselves
412 2021-01-13T19:06:41  <sdaftuar> i strongly agree with people speaking for themselves!
413 2021-01-13T19:06:51  <luke-jr> sipa: too subtle to come up with something that can be understood?
414 2021-01-13T19:07:28  <luke-jr> sdaftuar: well, that's all this is, to the extent that it's speaking at all
415 2021-01-13T19:15:05  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
416 2021-01-13T19:17:51  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
417 2021-01-13T19:22:25  *** queip <queip!~queip@unaffiliated/rezurus> has quit IRC (Ping timeout: 264 seconds)
418 2021-01-13T19:36:12  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
419 2021-01-13T19:52:12  *** queip <queip!~queip@unaffiliated/rezurus> has joined #bitcoin-core-dev
420 2021-01-13T19:58:38  <jeremyrubin> Has anyone come across an error where calling removed RPC generate *sometimes* returns error code -1, and sometimes the correct -32601?
421 2021-01-13T20:06:07  *** ironhelix <ironhelix!~p@136.144.43.97> has joined #bitcoin-core-dev
422 2021-01-13T20:10:05  <jeremyrubin> super bizzare
423 2021-01-13T20:11:30  <jeremyrubin> https://0bin.net/paste/QWvI7bfl#aJJFoALcc-ioThh+pajjWnNEhbfrg60/OsWe+zcD09j
424 2021-01-13T20:12:45  <jeremyrubin> here's a tcpdump showing a failed request
425 2021-01-13T20:14:17  *** prayank <prayank!~andr0irc@2405:205:2180:41f3:133:6444:5db:787c> has quit IRC (Ping timeout: 260 seconds)
426 2021-01-13T20:14:54  <jeremyrubin> https://0bin.net/paste/kmybFKne#nuo8Vr4gm29pYeylnP3cfhib051g617Qw+H9-ncdjX+
427 2021-01-13T20:15:06  <jeremyrubin> second pastebin tcpdump showing the correct response
428 2021-01-13T20:16:58  <jeremyrubin> Ah so it's the param null that is the issue
429 2021-01-13T20:17:15  <jeremyrubin> (was comparing curl and a library)
430 2021-01-13T20:17:43  <jeremyrubin> I think this is a bug in core though -- method not found should be returned before args are checked?
431 2021-01-13T20:18:21  <wumpus> jeremyrubin: it will give you -1 if you provide extra arguments
432 2021-01-13T20:18:45  <wumpus> honestly i have no opinion on the behavior of removed RPC calls :)
433 2021-01-13T20:19:42  <jeremyrubin> gotcha. It came up because I was working on testing https://github.com/jeremyrubin/rust-jsonrpc-async/ (async port of rust-jsonrpc)
434 2021-01-13T20:20:01  <jeremyrubin> The integration test checks that methodnotfound is returned for generate above some version
435 2021-01-13T20:20:22  <jeremyrubin> but it checks with params passed for generate, so it triggers a diff error!
436 2021-01-13T20:21:00  <jeremyrubin> I think we should probably return methodnotfound ahead of extraarguments?
437 2021-01-13T20:22:11  <wumpus> it's a by-effect of using RPCHelpMan in a way that's not entirely how it's supposed to, e.g. generate *implements a RPC call* that always gives an error that the RPC call doesn't exist, that said, I expect it's going to be entirely removed in another version or so, no need to put work in it
438 2021-01-13T20:22:53  <wumpus> RPCHelpMan needs to do it in this order because the argument check needs to happen before entering the inner function body
439 2021-01-13T20:23:32  <wumpus> sure, you could rewrite it without using RPCHelpMan, but my point is it really doesn't matter
440 2021-01-13T20:25:20  <jeremyrubin> it could be fixed by preserving the original args I 'spose
441 2021-01-13T20:25:34  <jeremyrubin> will fix it thos in the library :)
442 2021-01-13T20:28:06  <wumpus> why call a non-existing RPC at all :) it's only still there as a service to (human) users following old wiki pages with bitcoin-cli, and who tend to care more about the English message than the return code
443 2021-01-13T20:28:30  <jeremyrubin> To test that a library handles it correctly :)
444 2021-01-13T20:28:54  <sipa> do we need a test-only permanently-removed RPC? :p
445 2021-01-13T20:29:34  <jeremyrubin> the rpc is not removed though
446 2021-01-13T20:29:38  <jeremyrubin> that's what makes it funny
447 2021-01-13T20:29:51  <jeremyrubin> because it's an RPC which exists that returns methodnotfound
448 2021-01-13T20:31:14  <sipa> well, it's an RPC is "removed" state
449 2021-01-13T20:31:24  <sipa> implementation wise something still exists
450 2021-01-13T20:33:02  *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
451 2021-01-13T20:33:07  <wumpus> yes it's a bit of an easter egg, it's also intentionally not listed in "help"
452 2021-01-13T20:33:34  *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
453 2021-01-13T20:35:31  <wumpus> but if you want to deterministically generate a 'method not found' error, send a method name that is unlikely to ever exist like 'sendtoip' :-)
454 2021-01-13T20:36:51  <jeremyrubin> heh
455 2021-01-13T20:38:31  <sipa> inflatesupply()
456 2021-01-13T20:39:09  <jeremyrubin> it's not a huge deal; just a bit of an oddity
457 2021-01-13T21:03:29  *** prayank <prayank!~andr0irc@2405:205:2180:41f3:133:6444:5db:787c> has joined #bitcoin-core-dev
458 2021-01-13T21:03:34  *** jonatack <jonatack!~jon@134.19.179.235> has quit IRC (Ping timeout: 246 seconds)
459 2021-01-13T21:05:22  *** jonatack <jonatack!~jon@88.124.242.136> has joined #bitcoin-core-dev
460 2021-01-13T21:05:26  *** prayank <prayank!~andr0irc@2405:205:2180:41f3:133:6444:5db:787c> has quit IRC (Read error: Connection reset by peer)
461 2021-01-13T21:21:59  *** prayank <prayank!~andr0irc@2405:205:2180:41f3:133:6444:5db:787c> has joined #bitcoin-core-dev
462 2021-01-13T21:22:17  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
463 2021-01-13T21:38:16  *** lontivero <lontivero!~lontivero@186.183.48.235> has quit IRC (Ping timeout: 240 seconds)
464 2021-01-13T21:43:34  *** dviola <dviola!~diego@unaffiliated/dviola> has quit IRC (Ping timeout: 260 seconds)
465 2021-01-13T21:47:50  *** dviola <dviola!~diego@187.39.20.240> has joined #bitcoin-core-dev
466 2021-01-13T21:48:44  *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Ping timeout: 256 seconds)
467 2021-01-13T21:49:17  *** jonatack <jonatack!~jon@88.124.242.136> has joined #bitcoin-core-dev
468 2021-01-13T21:52:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
469 2021-01-13T21:52:53  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/15877d160cb8...91f06324640b
470 2021-01-13T21:52:54  <bitcoin-git> bitcoin/0.21 66e6742 Wladimir J. van der Laan: doc: Move 0.21.0 release notes from wiki
471 2021-01-13T21:52:54  <bitcoin-git> bitcoin/0.21 91f0632 Wladimir J. van der Laan: Merge #20929: doc: Move 0.21.0 release notes from wiki
472 2021-01-13T21:52:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
473 2021-01-13T21:53:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
474 2021-01-13T21:53:13  <bitcoin-git> [bitcoin] laanwj merged pull request #20929: doc: Move 0.21.0 release notes from wiki (0.21...2021-01-relnot-0.21.0) https://github.com/bitcoin/bitcoin/pull/20929
475 2021-01-13T21:53:14  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
476 2021-01-13T21:53:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
477 2021-01-13T21:53:33  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/91f06324640b...95ea54ba0896
478 2021-01-13T21:53:33  <bitcoin-git> bitcoin/0.21 95ea54b Wladimir J. van der Laan: build: Bump RC to 0 (-final)
479 2021-01-13T21:53:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
480 2021-01-13T21:54:23  <achow101> final soon?
481 2021-01-13T21:56:13  *** dviola <dviola!~diego@187.39.20.240> has left #bitcoin-core-dev
482 2021-01-13T21:56:42  *** dviola <dviola!~diego@unaffiliated/dviola> has joined #bitcoin-core-dev
483 2021-01-13T21:56:43  <wumpus> yess
484 2021-01-13T22:02:02  *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Ping timeout: 272 seconds)
485 2021-01-13T22:02:45  * luke-jr wonders if we should fix Big Sur compatibility
486 2021-01-13T22:02:58  <luke-jr> (for 0.21.0)
487 2021-01-13T22:03:39  *** jonatack <jonatack!~jon@88.124.242.136> has joined #bitcoin-core-dev
488 2021-01-13T22:04:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
489 2021-01-13T22:04:12  <bitcoin-git> [bitcoin] laanwj pushed tag v0.21.0: https://github.com/bitcoin/bitcoin/compare/v0.21.0
490 2021-01-13T22:04:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
491 2021-01-13T22:04:16  <jonatack> jeremyrubin: forgive me if not relevant to your discussion, #19455 was supposed to help here
492 2021-01-13T22:04:18  <gribble> https://github.com/bitcoin/bitcoin/issues/19455 | rpc generate: print useful help and error message by jonatack · Pull Request #19455 · bitcoin/bitcoin · GitHub
493 2021-01-13T22:04:22  <achow101> wooo
494 2021-01-13T22:04:32  <wumpus> ^^
495 2021-01-13T22:04:44  <luke-jr> I guess tha'ts a no
496 2021-01-13T22:05:02  <jonatack> ugh, freenode really does not like my vpn, i keep getting kicked
497 2021-01-13T22:05:09  <luke-jr> I suppose there's probably some workaround from the commandline or something
498 2021-01-13T22:05:15  <wumpus> we've held up the release on enough macos bs imo
499 2021-01-13T22:05:30  <midnight> connectivity to the freenode servers would be the issue due to ping timeout.
500 2021-01-13T22:05:30  <jonatack> wumpus: yay \,o,/
501 2021-01-13T22:06:09  <midnight> $5 vps/bouncer would do the same thing for you, and likely safer for you, jonatack
502 2021-01-13T22:06:16  <midnight> wumpus: also, yay!
503 2021-01-13T22:07:26  <wumpus> jonatack midnight  we did it we can still do releases! (well, this is only the tag... yet 🙂)
504 2021-01-13T22:08:19  <jonatack> midnight: thanks, yes i should. apparently my vpn is blocked by freenode since years, i should do something else, sorry for the logged in/out noise
505 2021-01-13T22:10:37  <jonatack> wumpus: yeah, not getting any hopes up prematurely ;p
506 2021-01-13T22:10:37  <achow101> has this been the longest rc cycle?
507 2021-01-13T22:11:13  <jeremyrubin> jonatack: it's relevant hah
508 2021-01-13T22:12:26  <sipa> fjahr, elichai2: i made a quick & dirty port of the secp256k1 safegcd modular inverse code to the muhash3072 field... finalizing is 45x faster with it ;)
509 2021-01-13T22:12:29  <sipa> https://github.com/sipa/bitcoin/commits/202101_muhash_safegcd
510 2021-01-13T22:12:59  <sipa> 4629892 ns to 77415 ns
511 2021-01-13T22:14:33  <wumpus> achow101: i'm not sure, 5 rcs is not unheard of at least
512 2021-01-13T22:14:57  <wumpus> for a major release
513 2021-01-13T22:18:50  <sipa> not going to PR this until the safegcd inverse code is in libsecp256k1 (and hopefully it's easy to convince the reviewers there to have a look at the muhash3072 version too)
514 2021-01-13T22:21:45  *** qubenix <qubenix!~qubenix@66.172.11.228> has quit IRC (Quit: quit)
515 2021-01-13T22:23:01  *** qubenix <qubenix!~qubenix@66.172.11.228> has joined #bitcoin-core-dev
516 2021-01-13T22:29:02  <elichai2> sipa: damn
517 2021-01-13T22:30:01  <sipa> elichai2: this isn't because safegcd is so amazing (it is, but not *that* amazing; a dumb extgcd based modular inverse would probably be a lot faster than the ladder approach too)
518 2021-01-13T22:30:50  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
519 2021-01-13T22:32:10  <elichai2> It's only 100 loc here, which is impressive
520 2021-01-13T22:33:55  *** spinza <spinza!~spin@102.132.245.16> has quit IRC (Quit: Coyote finally caught up with me...)
521 2021-01-13T22:37:22  *** spinza <spinza!~spin@102.132.245.16> has joined #bitcoin-core-dev
522 2021-01-13T22:44:07  <sipa> elichai2: 200 loc
523 2021-01-13T22:45:26  *** kexkey <kexkey!~kexkey@static-198-54-132-157.cust.tzulo.com> has quit IRC (Quit: Scaling pentatonically)
524 2021-01-13T22:46:10  *** qubenix <qubenix!~qubenix@66.172.11.228> has quit IRC (Quit: quit)
525 2021-01-13T22:46:23  *** qubenix <qubenix!~qubenix@66.172.11.228> has joined #bitcoin-core-dev
526 2021-01-13T22:46:41  <fjahr> sipa: wow, awesome!
527 2021-01-13T22:47:48  <elichai2> Oops (1am hehe)
528 2021-01-13T22:48:12  *** kexkey <kexkey!~kexkey@static-198-54-132-157.cust.tzulo.com> has joined #bitcoin-core-dev
529 2021-01-13T22:48:14  <sipa> elichai2: peak productivity
530 2021-01-13T22:49:38  <elichai2> I need to find time to read the long explanation you wrote in the libsecp PR about how the safegcd works, I want to understand how it works.
531 2021-01-13T22:49:55  <sipa> elichai2: please do; i've tried to keep it very accessible
532 2021-01-13T22:50:47  <fjahr> will check that out as well to get a better understanding :)
533 2021-01-13T22:51:31  <sipa> i have a markdown version of it here: https://gist.github.com/sipa/bddcf6434b25cf1ff03a277cd4927d73
534 2021-01-13T22:51:42  <sipa> (it's a bit outdated, the one in the PR has some improvements)
535 2021-01-13T22:51:55  <fjahr> sipa: thanks!
536 2021-01-13T22:53:30  <sipa> "very accessible" is of course a fairly subjective statement :)
537 2021-01-13T22:59:32  *** ctrlbreak_MAD <ctrlbreak_MAD!~ctrlbreak@159.2.165.130> has joined #bitcoin-core-dev
538 2021-01-13T23:02:16  *** ctrlbreak <ctrlbreak!~ctrlbreak@159.2.165.130> has quit IRC (Ping timeout: 240 seconds)
539 2021-01-13T23:09:09  <sipa> ooh, gitian time!
540 2021-01-13T23:09:56  <hebasto> yess
541 2021-01-13T23:23:56  *** kexkey <kexkey!~kexkey@static-198-54-132-157.cust.tzulo.com> has quit IRC (Quit: Scaling pentatonically)
542 2021-01-13T23:25:24  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
543 2021-01-13T23:28:00  *** copumpkin <copumpkin!~copumpkin@unaffiliated/copumpkin> has joined #bitcoin-core-dev
544 2021-01-13T23:37:18  *** kexkey <kexkey!~kexkey@static-198-54-132-157.cust.tzulo.com> has joined #bitcoin-core-dev
545 2021-01-13T23:47:26  *** prayank <prayank!~andr0irc@2405:205:2180:41f3:133:6444:5db:787c> has quit IRC (Ping timeout: 264 seconds)
546 2021-01-13T23:47:37  *** kexkey <kexkey!~kexkey@static-198-54-132-157.cust.tzulo.com> has quit IRC (Quit: Scaling pentatonically)
547 2021-01-13T23:48:00  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
548 2021-01-13T23:52:50  *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
549 2021-01-13T23:57:05  *** prayank <prayank!~andr0irc@2405:205:2180:41f3:133:6444:5db:787c> has joined #bitcoin-core-dev
550 2021-01-13T23:58:01  *** kexkey <kexkey!~kexkey@static-198-54-132-157.cust.tzulo.com> has joined #bitcoin-core-dev