1 2021-02-27T00:03:42  *** brg444 <brg444!uid207215@gateway/web/irccloud.com/x-xngputqdkmzpojmw> has quit IRC (Quit: Connection closed for inactivity)
  2 2021-02-27T00:38:03  *** jonatack_ <jonatack_!~jon@37.167.35.203> has joined #bitcoin-core-dev
  3 2021-02-27T00:42:34  *** jonatack_ <jonatack_!~jon@37.167.35.203> has quit IRC (Read error: Connection reset by peer)
  4 2021-02-27T00:44:52  *** grench <grench!grench@gateway/vpn/protonvpn/grench> has quit IRC (Quit: Leaving)
  5 2021-02-27T01:42:33  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 264 seconds)
  6 2021-02-27T01:49:02  *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
  7 2021-02-27T02:14:56  <sipa> achow101: i'm breaking my head... i don't understand how ProduceSignature ever worked at all
  8 2021-02-27T02:15:50  <achow101> sipa: where?
  9 2021-02-27T02:16:14  <sipa> if you call it through SignSignature, from multiple SPKMs, as far as i can see, if the first SPKM is able to sign, the second one will just wipe the witness
 10 2021-02-27T02:16:55  <achow101> It'll do VerifyScript and find it to be valid
 11 2021-02-27T02:17:06  <sipa> oh
 12 2021-02-27T02:17:14  <achow101> Then abort early and not change anything
 13 2021-02-27T02:17:28  <sipa> got it!
 14 2021-02-27T02:17:31  <sipa> this explains
 15 2021-02-27T02:17:33  <sipa> thanks
 16 2021-02-27T02:18:06  <sipa> it constructs a new checker objects, which doesn't have access to PrecomputedTransactionData, which is necessary to verify taproot sigs
 17 2021-02-27T02:18:17  <achow101> Yeah
 18 2021-02-27T02:18:23  <achow101> I have a pr for that actually
 19 2021-02-27T02:18:39  <sipa> oh?
 20 2021-02-27T02:18:42  <achow101> (for other reasons, but should give access to that)
 21 2021-02-27T02:19:10  <sipa> passing down the signaturecreator's checker, rather than constructing a new one?
 22 2021-02-27T02:19:14  <achow101> #21166
 23 2021-02-27T02:19:15  <gribble> https://github.com/bitcoin/bitcoin/issues/21166 | Have SignatureExtractorChecker subclass MutableTransactionSignatureChecker by achow101 · Pull Request #21166 · bitcoin/bitcoin · GitHub
 24 2021-02-27T02:20:29  <sipa> no, that doesn't work
 25 2021-02-27T02:20:37  <sipa> it's still creating a new checker
 26 2021-02-27T02:20:53  <sipa> (which includes a new MutableTransactionSignatureChecker)
 27 2021-02-27T02:20:53  <achow101> Ah, think I just don't know what you need
 28 2021-02-27T02:21:24  <sipa> yeah, it's a fine change, but it's orthogonal
 29 2021-02-27T02:22:55  <sipa> also: really, we're verifying every existing witness in a transaction being signed in every SPKM?
 30 2021-02-27T02:23:16  <achow101> I guess we are
 31 2021-02-27T02:23:21  <sipa> i'm sure there's a way to keep it in SignatureData form across those calls
 32 2021-02-27T02:23:32  <sipa> which would avoid that
 33 2021-02-27T02:23:45  <sipa> also orthogonal, of course
 34 2021-02-27T02:24:07  <achow101> Yeah. Signing performance hasn't really been a concern too
 35 2021-02-27T02:24:20  <sipa> yeah
 36 2021-02-27T02:24:29  <sipa> just seems a bit silly, it's not a big deal
 37 2021-02-27T02:29:19  <sipa> achow101: can you explain how 21166 fixes 21151? what function specifically is missing?
 38 2021-02-27T02:29:38  <achow101> CheckSequnce was missing
 39 2021-02-27T02:29:44  <sipa> i see
 40 2021-02-27T02:30:03  <achow101> Same with ChecLockTime, so op_cltv scripts don't work too
 41 2021-02-27T02:30:17  <sipa> yeah
 42 2021-02-27T02:47:17  *** brg444 <brg444!uid207215@gateway/web/irccloud.com/x-hpmuwukpfclzfzft> has joined #bitcoin-core-dev
 43 2021-02-27T02:53:01  <sipa> achow101: i think there is a simpler solution... just don't wipe scriptWitness
 44 2021-02-27T02:53:06  <sipa> unless sigdata.witness is false
 45 2021-02-27T02:57:52  *** aferreira44 <aferreira44!~andre@2001:1284:f013:8b30:d482:b4e6:24f7:b9c3> has quit IRC (Ping timeout: 260 seconds)
 46 2021-02-27T03:01:18  <achow101> what about scriptSig?
 47 2021-02-27T03:01:53  <sipa> there are a couple things
 48 2021-02-27T03:02:11  <sipa> ideally just these functions don't get called at all for things that are already signed
 49 2021-02-27T03:02:42  <sipa> the caller has the best context to determine that, i think
 50 2021-02-27T03:02:49  <sipa> caller = wallet, rpc, psbt, ...
 51 2021-02-27T03:03:20  <achow101> not necessarily
 52 2021-02-27T03:03:29  <sipa> e.g. if you lack amount information, a VerifyScript will fail for every witness
 53 2021-02-27T03:03:37  <sipa> that doesn't mean you should wipe it
 54 2021-02-27T03:03:41  <achow101> for these non-wallet inputs, no context knows until it runs through the verifier
 55 2021-02-27T03:04:16  <sipa> ok, setting aside the question of deciding whether an input is fully signed or not
 56 2021-02-27T03:04:53  <sipa> if you somehow think it's not yet fully signed, so try to sign yourself, and fail... there is no point in wiping anything at all
 57 2021-02-27T03:05:00  <achow101> right
 58 2021-02-27T03:06:35  <sipa> and i think that's a pretty simple change
 59 2021-02-27T03:07:39  <sipa> https://explorer.bc-2.jp/tx/da68fd6ccdfd0359b94012dfa613f69c934a99a84a90e53cf01413ca832bb1b6?expand
 60 2021-02-27T03:08:37  <achow101> that might be a simple change, but I think a better/longer term solution is to overhaul the signing to be more psbt like
 61 2021-02-27T03:09:05  <achow101> so it puts things inside of SignatureData and only attempts to create a scriptSig and scriptWitness when trying to finalize
 62 2021-02-27T03:09:08  <sipa> agree
 63 2021-02-27T03:09:12  <achow101> and those shouldn't be part of the SignatureData
 64 2021-02-27T03:09:42  *** aferreira44 <aferreira44!~andre@2001:1284:f013:c3de:2150:4a84:6f92:91d8> has joined #bitcoin-core-dev
 65 2021-02-27T03:09:52  <sipa> part of the complexity is the compatibility with the old raw transaction behavior where we want to be able to go from tx -> sigdata
 66 2021-02-27T03:10:04  <sipa> but we don't need that functionality for new script signing functionality
 67 2021-02-27T03:11:08  <achow101> I really just want to deprecate and remove signrawtransaction*
 68 2021-02-27T03:11:33  <achow101> but I think people still use it
 69 2021-02-27T03:11:38  <sipa> but we probably also want a function that can detect invalid scriptSig/witness data, so it can ignore it
 70 2021-02-27T03:12:00  <sipa> otherwise it'd just be: you already have witness/scriptSig -> no touch
 71 2021-02-27T03:31:36  <sipa> https://explorer.bc-2.jp/tx/dda4cb9290415952d93f52518df978d45ae1710e60e711e6786926e99d305ef9?expand <- script path spend
 72 2021-02-27T03:33:53  <sipa> made using sendtoaddress :)
 73 2021-02-27T03:40:22  <achow101> sipa: miniscript?
 74 2021-02-27T03:40:41  <achow101> or taproot?
 75 2021-02-27T03:41:40  <sipa> taproit
 76 2021-02-27T03:41:54  <sipa> *taproot
 77 2021-02-27T03:42:20  <achow101> nice
 78 2021-02-27T03:42:20  <sipa> branch needs a lot of cleaning up, but it does something now :)
 79 2021-02-27T04:45:21  *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
 80 2021-02-27T04:45:47  *** shesek <shesek!~shesek@164.90.217.137> has joined #bitcoin-core-dev
 81 2021-02-27T05:09:21  *** pox <pox!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
 82 2021-02-27T05:11:17  *** flag <flag!~flag@net-93-66-71-159.cust.vodafonedsl.it> has quit IRC (Remote host closed the connection)
 83 2021-02-27T05:17:58  *** flag <flag!~flag@net-5-95-187-105.cust.vodafonedsl.it> has joined #bitcoin-core-dev
 84 2021-02-27T05:36:02  *** aferreira44 <aferreira44!~andre@2001:1284:f013:c3de:2150:4a84:6f92:91d8> has quit IRC (Ping timeout: 264 seconds)
 85 2021-02-27T05:42:08  *** aferreira44 <aferreira44!~andre@2001:1284:f013:c3de:2150:4a84:6f92:91d8> has joined #bitcoin-core-dev
 86 2021-02-27T05:47:44  *** shafiunmiraz0 <shafiunmiraz0!~shafiunmi@103.220.205.190> has joined #bitcoin-core-dev
 87 2021-02-27T05:47:50  *** Patriot <Patriot!ae8a1cc6@174.138.28.198> has joined #bitcoin-core-dev
 88 2021-02-27T05:50:31  *** Patriot <Patriot!ae8a1cc6@174.138.28.198> has quit IRC (Client Quit)
 89 2021-02-27T05:50:55  *** pox <pox!~pox@gateway/tor-sasl/pox> has quit IRC (Remote host closed the connection)
 90 2021-02-27T05:50:58  *** shafiunmiraz0 <shafiunmiraz0!~shafiunmi@103.220.205.190> has quit IRC (Client Quit)
 91 2021-02-27T05:51:29  *** pox <pox!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
 92 2021-02-27T06:00:31  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has quit IRC (Remote host closed the connection)
 93 2021-02-27T06:00:52  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
 94 2021-02-27T06:21:04  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Remote host closed the connection)
 95 2021-02-27T06:22:16  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
 96 2021-02-27T06:40:06  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 268 seconds)
 97 2021-02-27T06:46:22  *** ossifrage <ossifrage!~ossifrage@unaffiliated/ossifrage> has quit IRC (Ping timeout: 272 seconds)
 98 2021-02-27T06:48:49  *** ossifrage <ossifrage!~ossifrage@unaffiliated/ossifrage> has joined #bitcoin-core-dev
 99 2021-02-27T07:05:28  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
100 2021-02-27T07:13:52  *** pox <pox!~pox@gateway/tor-sasl/pox> has quit IRC (Remote host closed the connection)
101 2021-02-27T07:14:19  *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has quit IRC (Ping timeout: 276 seconds)
102 2021-02-27T07:14:27  *** pox <pox!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
103 2021-02-27T07:35:32  *** aferreira44 <aferreira44!~andre@2001:1284:f013:c3de:2150:4a84:6f92:91d8> has quit IRC (Ping timeout: 260 seconds)
104 2021-02-27T07:36:54  *** brg444 <brg444!uid207215@gateway/web/irccloud.com/x-hpmuwukpfclzfzft> has quit IRC (Quit: Connection closed for inactivity)
105 2021-02-27T07:47:19  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 268 seconds)
106 2021-02-27T08:13:33  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
107 2021-02-27T08:22:31  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
108 2021-02-27T09:00:09  *** awesome_doge <awesome_doge!awesome-do@gateway/shell/matrix.org/x-odopplfpidrzxolv> has quit IRC (Quit: Idle for 30+ days)
109 2021-02-27T10:16:16  *** Aylin72Dietrich <Aylin72Dietrich!~Aylin72Di@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
110 2021-02-27T10:16:16  *** sr_gi <sr_gi!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has quit IRC (Read error: Connection reset by peer)
111 2021-02-27T10:16:45  *** sr_gi <sr_gi!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has joined #bitcoin-core-dev
112 2021-02-27T10:28:36  *** Aylin72Dietrich <Aylin72Dietrich!~Aylin72Di@static.57.1.216.95.clients.your-server.de> has quit IRC (Remote host closed the connection)
113 2021-02-27T10:29:46  *** Rigoberto1Kulas <Rigoberto1Kulas!~Rigoberto@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
114 2021-02-27T10:41:12  *** pox_ <pox_!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
115 2021-02-27T10:44:17  *** pox <pox!~pox@gateway/tor-sasl/pox> has quit IRC (Ping timeout: 268 seconds)
116 2021-02-27T10:55:16  *** Rigoberto1Kulas <Rigoberto1Kulas!~Rigoberto@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 240 seconds)
117 2021-02-27T11:04:07  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
118 2021-02-27T11:10:48  *** aferreira44 <aferreira44!~andre@2001:1284:f013:c3de:2150:4a84:6f92:91d8> has joined #bitcoin-core-dev
119 2021-02-27T11:18:21  *** Colton46Kreiger <Colton46Kreiger!~Colton46K@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
120 2021-02-27T11:20:10  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
121 2021-02-27T11:20:11  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
122 2021-02-27T11:20:12  *** vasild_ is now known as vasild
123 2021-02-27T11:20:52  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Remote host closed the connection)
124 2021-02-27T11:25:11  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
125 2021-02-27T12:15:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
126 2021-02-27T12:15:07  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5ba5becbb5d8...fb67caebe26f
127 2021-02-27T12:15:07  <bitcoin-git> bitcoin/master ace3f4c Jon Atack: test: improve assertions in feature_blockfilterindex_prune.py
128 2021-02-27T12:15:08  <bitcoin-git> bitcoin/master 88c4b9b Jon Atack: test: remove unneeded node from feature_blockfilterindex_prune.py
129 2021-02-27T12:15:08  <bitcoin-git> bitcoin/master fb67cae MarcoFalke: Merge #21297: test: feature_blockfilterindex_prune.py improvements
130 2021-02-27T12:15:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
131 2021-02-27T12:15:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
132 2021-02-27T12:15:26  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #21297: test: feature_blockfilterindex_prune.py improvements (master...feature_blockfilterindex_prune-improvements) https://github.com/bitcoin/bitcoin/pull/21297
133 2021-02-27T12:15:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
134 2021-02-27T12:25:32  *** peutetre <peutetre!~peutetre@185.163.110.108> has quit IRC (Remote host closed the connection)
135 2021-02-27T12:34:14  *** aferreira44 <aferreira44!~andre@2001:1284:f013:c3de:2150:4a84:6f92:91d8> has quit IRC (Ping timeout: 264 seconds)
136 2021-02-27T12:43:55  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 268 seconds)
137 2021-02-27T12:44:42  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
138 2021-02-27T12:47:38  *** elector <elector!~elector@gateway/tor-sasl/elector> has quit IRC (Ping timeout: 268 seconds)
139 2021-02-27T12:58:45  *** elector <elector!~elector@gateway/tor-sasl/elector> has joined #bitcoin-core-dev
140 2021-02-27T13:07:08  *** aferreira44 <aferreira44!~andre@2001:1284:f013:c3de:2150:4a84:6f92:91d8> has joined #bitcoin-core-dev
141 2021-02-27T13:14:47  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has quit IRC (Remote host closed the connection)
142 2021-02-27T13:15:12  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
143 2021-02-27T13:20:28  *** harland <harland!~harland@2408:8207:1854:af90:d01e:7d3b:9e2f:c711> has joined #bitcoin-core-dev
144 2021-02-27T13:26:36  *** Colton46Kreiger <Colton46Kreiger!~Colton46K@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 240 seconds)
145 2021-02-27T13:26:42  *** Harland70 <Harland70!12907e45@ec2-18-144-126-69.us-west-1.compute.amazonaws.com> has joined #bitcoin-core-dev
146 2021-02-27T13:40:57  *** CubicEarth_ <CubicEarth_!~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net> has quit IRC (Ping timeout: 246 seconds)
147 2021-02-27T13:43:44  *** CubicEarth <CubicEarth!~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net> has joined #bitcoin-core-dev
148 2021-02-27T13:58:55  *** mjevans- <mjevans-!~mjevans-@185.163.110.108> has joined #bitcoin-core-dev
149 2021-02-27T14:21:57  *** fyquah <fyquah!b9187ab5@185.24.122.181> has joined #bitcoin-core-dev
150 2021-02-27T14:26:26  *** sr_gi <sr_gi!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has quit IRC (Read error: Connection reset by peer)
151 2021-02-27T14:26:58  *** sr_gi <sr_gi!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has joined #bitcoin-core-dev
152 2021-02-27T14:39:33  *** honeybadger <honeybadger!~honeybadg@vps1648322.vs.webtropia-customer.com> has quit IRC (Ping timeout: 264 seconds)
153 2021-02-27T14:57:27  *** brian76 <brian76!71ad8d95@113.173.141.149> has joined #bitcoin-core-dev
154 2021-02-27T14:58:36  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@d5152f744.static.telenet.be> has quit IRC (Ping timeout: 240 seconds)
155 2021-02-27T14:58:57  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@d5152f744.static.telenet.be> has joined #bitcoin-core-dev
156 2021-02-27T14:59:54  *** brian76 <brian76!71ad8d95@113.173.141.149> has quit IRC (Client Quit)
157 2021-02-27T15:06:32  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
158 2021-02-27T15:14:54  *** smartineng <smartineng!~Icedove@88.135.18.171> has joined #bitcoin-core-dev
159 2021-02-27T15:17:31  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
160 2021-02-27T15:37:25  *** pinheadmz <pinheadmz!~pinheadmz@pool-71-105-114-182.nycmny.fios.verizon.net> has quit IRC (Ping timeout: 276 seconds)
161 2021-02-27T15:45:47  *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
162 2021-02-27T15:57:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
163 2021-02-27T15:57:35  <bitcoin-git> [gui] hebasto opened pull request #229: Fix regression with initial sorting after pr205 (master...210227-sort) https://github.com/bitcoin-core/gui/pull/229
164 2021-02-27T15:57:35  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
165 2021-02-27T16:14:12  *** pox <pox!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
166 2021-02-27T16:14:50  *** pox_ <pox_!~pox@gateway/tor-sasl/pox> has quit IRC (Ping timeout: 268 seconds)
167 2021-02-27T16:15:03  *** pox__ <pox__!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
168 2021-02-27T16:15:51  *** pox_ <pox_!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
169 2021-02-27T16:19:09  *** pox <pox!~pox@gateway/tor-sasl/pox> has quit IRC (Ping timeout: 268 seconds)
170 2021-02-27T16:19:46  *** pox__ <pox__!~pox@gateway/tor-sasl/pox> has quit IRC (Ping timeout: 268 seconds)
171 2021-02-27T16:27:10  *** pox_ <pox_!~pox@gateway/tor-sasl/pox> has quit IRC (Ping timeout: 268 seconds)
172 2021-02-27T16:41:22  *** pox <pox!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
173 2021-02-27T17:08:54  *** Harland70 <Harland70!12907e45@ec2-18-144-126-69.us-west-1.compute.amazonaws.com> has quit IRC (Quit: Connection closed)
174 2021-02-27T17:35:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
175 2021-02-27T17:35:07  <bitcoin-git> [gui] luke-jr opened pull request #230: Support backup to new text-based database dump format (master...gui_backup_formats) https://github.com/bitcoin-core/gui/pull/230
176 2021-02-27T17:35:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
177 2021-02-27T17:35:11  *** jonatack <jonatack!~jon@37.170.73.95> has joined #bitcoin-core-dev
178 2021-02-27T17:35:33  *** jungly <jungly!~jungly@host-79-49-186-213.retail.telecomitalia.it> has joined #bitcoin-core-dev
179 2021-02-27T17:45:48  <jonatack> vasild: I finished reviewing the I2P PR late last night, then my internet went down, and when I restarted GitHub had saved none of the many comments I had pending. Disheartening. I'm thinking that by default now on large PR reviews I'll start annotating the code directly, git commit and push my own branch, then refer to the branch in my review. That also takes much less GitHub space,
180 2021-02-27T17:45:49  <jonatack> which is good in order to avoid deeper "hidden items" clicking, which for me is up to 105 hidden items in that PR, and which continued to hide one of your commits even after clicking repeatedly to unhide everything.
181 2021-02-27T17:55:16  <jonatack> (Not a reflection on the PR itself--it looks very good!)
182 2021-02-27T17:55:43  *** prashkr <prashkr!6ac8ff4b@106.200.255.75> has joined #bitcoin-core-dev
183 2021-02-27T17:56:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
184 2021-02-27T17:56:01  <bitcoin-git> [bitcoin] ivanacostarubio opened pull request #21308: build: removing xcrun from darwin build (master...issue18959) https://github.com/bitcoin/bitcoin/pull/21308
185 2021-02-27T17:56:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
186 2021-02-27T17:56:33  *** prashkr <prashkr!6ac8ff4b@106.200.255.75> has quit IRC (Client Quit)
187 2021-02-27T18:07:43  *** aferreira44 <aferreira44!~andre@2001:1284:f013:c3de:2150:4a84:6f92:91d8> has quit IRC (Ping timeout: 272 seconds)
188 2021-02-27T18:08:43  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
189 2021-02-27T18:12:06  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
190 2021-02-27T18:15:22  *** smartineng <smartineng!~Icedove@88.135.18.171> has quit IRC (Ping timeout: 276 seconds)
191 2021-02-27T18:33:40  *** stortz <stortz!bb3fa187@187.63.161.135> has joined #bitcoin-core-dev
192 2021-02-27T18:41:16  *** brdro <brdro!587ec826@88.126.200.38> has joined #bitcoin-core-dev
193 2021-02-27T18:46:16  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
194 2021-02-27T18:46:16  <bitcoin-git> [bitcoin] theStack opened pull request #21310: zmq test: fix sync-up by matching notification to generated block (master...2021-zmq-fix_sync_up_procedure) https://github.com/bitcoin/bitcoin/pull/21310
195 2021-02-27T18:46:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
196 2021-02-27T18:50:09  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
197 2021-02-27T18:51:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
198 2021-02-27T18:51:49  <bitcoin-git> [gui] hebasto closed pull request #228: Drop unused parameter in GUIUtil::get{Save|Open}FileName (master...210224-file) https://github.com/bitcoin-core/gui/pull/228
199 2021-02-27T18:51:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
200 2021-02-27T18:56:34  <luke-jr> is interface_zmq having issues, or is there some incomprehensible bug in gui#230 I can't reproduce locally? :/
201 2021-02-27T18:56:36  <gribble> https://github.com/bitcoin/bitcoin/issues/230 | Update German translation to latest git. by TheBlueMatt · Pull Request #230 · bitcoin/bitcoin · GitHub
202 2021-02-27T18:58:25  * luke-jr peers at gribble
203 2021-02-27T19:02:10  *** jungly <jungly!~jungly@host-79-49-186-213.retail.telecomitalia.it> has quit IRC (Ping timeout: 276 seconds)
204 2021-02-27T19:03:48  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 268 seconds)
205 2021-02-27T19:05:03  *** deJavu <deJavu!4ebb29bb@78.187.41.187> has joined #bitcoin-core-dev
206 2021-02-27T19:09:44  <jeremyrubin> if I make a PR, and then I make another PR referincing that PR in the title, and then I change the first to reference the latter, and then put the number in IRC what does gribble do?
207 2021-02-27T19:10:06  <luke-jr> I doubt gribble responds to itself
208 2021-02-27T19:10:20  <luke-jr> gribble: echo gribble: echo hi
209 2021-02-27T19:10:30  <luke-jr> x.x
210 2021-02-27T19:10:59  <luke-jr> jeremyrubin: also, you'd need to be quick - gribble doesn't announce renames ;)
211 2021-02-27T19:11:15  <luke-jr> err, maybe not relevant if you manually enter it
212 2021-02-27T19:11:22  <luke-jr> anyway, off topic XD
213 2021-02-27T19:11:48  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Ping timeout: 272 seconds)
214 2021-02-27T19:18:41  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
215 2021-02-27T19:20:27  *** jonatack <jonatack!~jon@37.170.73.95> has quit IRC (Ping timeout: 246 seconds)
216 2021-02-27T19:20:33  *** jonatack_ <jonatack_!~jon@37.172.209.215> has joined #bitcoin-core-dev
217 2021-02-27T19:26:54  <phantomcircuit> jeremyrubin, it ignores itself as all irc bots that aren't instantly banned do
218 2021-02-27T19:41:16  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
219 2021-02-27T19:41:17  <bitcoin-git> [bitcoin] theStack opened pull request #21311: rpc: document optional fields for getchaintxstats result (master...2021-rpc-document_optional_getchaintxstats_fields) https://github.com/bitcoin/bitcoin/pull/21311
220 2021-02-27T19:41:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
221 2021-02-27T19:44:23  *** pinheadmz <pinheadmz!~pinheadmz@pool-71-105-114-182.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
222 2021-02-27T19:47:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
223 2021-02-27T19:47:59  <bitcoin-git> [bitcoin] vladyslavstartsev opened pull request #21312: wallet: remove lock during `listaddressgroupings` (master...listaddressgroupings-no-lock) https://github.com/bitcoin/bitcoin/pull/21312
224 2021-02-27T19:48:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
225 2021-02-27T20:22:59  *** smartineng <smartineng!~Icedove@88.135.18.171> has joined #bitcoin-core-dev
226 2021-02-27T20:30:52  *** pox <pox!~pox@gateway/tor-sasl/pox> has quit IRC (Remote host closed the connection)
227 2021-02-27T20:31:29  *** pox <pox!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
228 2021-02-27T20:43:58  *** deJavu <deJavu!4ebb29bb@78.187.41.187> has quit IRC (Quit: Connection closed)
229 2021-02-27T20:52:26  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
230 2021-02-27T20:53:03  *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has quit IRC (Ping timeout: 265 seconds)
231 2021-02-27T21:10:46  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
232 2021-02-27T21:47:36  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
233 2021-02-27T21:54:41  *** s7r <s7r!~s7r@openvpn/user/s7r> has joined #bitcoin-core-dev
234 2021-02-27T21:55:19  <s7r> building from source doesn't work any more cleanly on Debian.
235 2021-02-27T21:55:23  <s7r> I get A compiler with support for C++17 language features is required.
236 2021-02-27T21:56:05  <s7r> (current compiler does support C++17 though)
237 2021-02-27T21:58:07  <sipa> which compiler is that?
238 2021-02-27T22:06:49  <s7r> sipa, gcc
239 2021-02-27T22:07:15  <sipa> which version?
240 2021-02-27T22:07:56  <s7r> 4:6.3.0-4
241 2021-02-27T22:08:10  <s7r> sorry:  6.3.0-18+deb9u1
242 2021-02-27T22:08:55  <sipa> that may be too old
243 2021-02-27T22:12:12  *** mjevans- <mjevans-!~mjevans-@185.163.110.108> has quit IRC (Remote host closed the connection)
244 2021-02-27T22:16:36  *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
245 2021-02-27T22:18:02  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Remote host closed the connection)
246 2021-02-27T22:28:10  *** I440r <I440r!~I440r@217.146.82.202> has joined #bitcoin-core-dev
247 2021-02-27T22:33:07  *** landakram <landakram!~mark@2601:643:8002:3f20:9eb6:d0ff:fef0:5981> has joined #bitcoin-core-dev
248 2021-02-27T22:36:29  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
249 2021-02-27T22:40:25  *** zolferino <zolferino!~zolferino@host-79-37-103-102.retail.telecomitalia.it> has joined #bitcoin-core-dev
250 2021-02-27T22:41:09  *** zolferino <zolferino!~zolferino@host-79-37-103-102.retail.telecomitalia.it> has quit IRC (Excess Flood)
251 2021-02-27T22:47:30  *** landakram <landakram!~mark@2601:643:8002:3f20:9eb6:d0ff:fef0:5981> has quit IRC (Remote host closed the connection)
252 2021-02-27T23:03:13  *** zolferino <zolferino!~zolferino@host-79-37-103-102.retail.telecomitalia.it> has joined #bitcoin-core-dev
253 2021-02-27T23:03:22  *** zolferino <zolferino!~zolferino@host-79-37-103-102.retail.telecomitalia.it> has quit IRC (Excess Flood)
254 2021-02-27T23:14:36  *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Ping timeout: 240 seconds)
255 2021-02-27T23:20:21  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
256 2021-02-27T23:20:21  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
257 2021-02-27T23:20:22  *** vasild_ is now known as vasild
258 2021-02-27T23:26:19  *** zolferino <zolferino!~zolferino@host-79-37-103-102.retail.telecomitalia.it> has joined #bitcoin-core-dev
259 2021-02-27T23:26:19  *** zolferino <zolferino!~zolferino@host-79-37-103-102.retail.telecomitalia.it> has quit IRC (Excess Flood)
260 2021-02-27T23:28:42  *** smartineng <smartineng!~Icedove@88.135.18.171> has quit IRC (Quit: smartineng)
261 2021-02-27T23:29:43  *** stortz <stortz!bb3fa187@187.63.161.135> has quit IRC (Quit: Connection closed)
262 2021-02-27T23:35:56  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 265 seconds)
263 2021-02-27T23:45:50  *** zolferino <zolferino!~zolferino@host-79-37-103-102.retail.telecomitalia.it> has joined #bitcoin-core-dev
264 2021-02-27T23:45:50  *** zolferino <zolferino!~zolferino@host-79-37-103-102.retail.telecomitalia.it> has quit IRC (Excess Flood)
265 2021-02-27T23:51:19  *** zolferino <zolferino!~zolferino@host-79-37-103-102.retail.telecomitalia.it> has joined #bitcoin-core-dev
266 2021-02-27T23:51:19  *** zolferino <zolferino!~zolferino@host-79-37-103-102.retail.telecomitalia.it> has quit IRC (Excess Flood)
267 2021-02-27T23:58:43  *** ovovo <ovovo!~ovovo@unaffiliated/ovovo> has joined #bitcoin-core-dev