1 2021-03-09T00:31:39  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
  2 2021-03-09T00:31:40  *** jasonzhouu <jasonzhouu!~jasonzhou@> has quit IRC (Read error: Connection reset by peer)
  3 2021-03-09T00:31:59  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
  4 2021-03-09T00:53:55  *** queip <queip!~queip@unaffiliated/rezurus> has quit IRC (Ping timeout: 240 seconds)
  5 2021-03-09T01:01:12  <sipa_> anyone have i2p nodes to connect to?
  6 2021-03-09T01:05:22  <aj> sipa_: sed -i -e 's/AbstractThresholdConditionChecker/ThresholdConditionChecker/g' $(git grep -l AbstractThresholdConditionChecker src/)
  7 2021-03-09T01:05:26  <aj> gah
  8 2021-03-09T01:05:36  <aj> sipa_: https://bpa.st/OXKQ
  9 2021-03-09T01:05:38  <sipa_> i... don't think that works
 10 2021-03-09T01:05:54  <sipa_> ah, that's better
 11 2021-03-09T01:06:05  <sipa_> i hereby offer hnbbyjpxx54623l555sta7pocy3se4sdgmuebi5k6reesz5rjp6q.b32.i2p (mainnet)
 12 2021-03-09T01:53:45  *** theChief <theChief!~Mohamed@> has joined #bitcoin-core-dev
 13 2021-03-09T02:05:55  *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
 14 2021-03-09T02:09:15  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 265 seconds)
 15 2021-03-09T02:10:17  *** grubles <grubles!~unknown@> has joined #bitcoin-core-dev
 16 2021-03-09T02:19:03  *** LRSN <LRSN!d41dd2e6@> has quit IRC (Ping timeout: 240 seconds)
 17 2021-03-09T02:26:21  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
 18 2021-03-09T02:28:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 19 2021-03-09T02:28:22  <bitcoin-git> [bitcoin] amitiuttarwar opened pull request #21394: [doc] Improve comment about protected peers (master...2021-03-doc) https://github.com/bitcoin/bitcoin/pull/21394
 20 2021-03-09T02:28:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 21 2021-03-09T02:28:34  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 260 seconds)
 22 2021-03-09T02:41:25  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
 23 2021-03-09T02:45:14  <aj> achow101: rebased the fuzzer to pull in most of the rename and the threshold part
 24 2021-03-09T02:46:08  <achow101> aj: right now I'm trying to parameterize the period in the same way
 25 2021-03-09T02:46:40  <aj> achow101: i'm not sure that's a good idea -- different periods make the Warning thing in validation less useful
 26 2021-03-09T02:47:11  <aj> achow101: (for different thresholds, the RuleChangeActivatinThreshold just needs to be <= to them)
 27 2021-03-09T02:47:21  <achow101> it's already less useful because different thresholds
 28 2021-03-09T02:47:55  <achow101> mostly doing it for code organization reasons since a threshold doesn't make sense without what the maximum is
 29 2021-03-09T02:48:06  <achow101> not necessarily allowing for different thresholds
 30 2021-03-09T02:48:30  *** jr_ <jr_!~jr@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
 31 2021-03-09T02:48:51  *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has quit IRC (Ping timeout: 256 seconds)
 32 2021-03-09T02:49:18  *** jr_ <jr_!~jr@024-176-247-182.res.spectrum.com> has quit IRC (Client Quit)
 33 2021-03-09T02:49:39  <achow101> what I'm also working towards is having all the parameters set in a constructor for VBitsDeployment since I'm not convinced we don't have an initialized variable in a (test) deployment somewhere
 34 2021-03-09T02:49:40  *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
 35 2021-03-09T02:49:53  <achow101> *uninitialized
 36 2021-03-09T02:52:13  *** stortz <stortz!b1982779@> has joined #bitcoin-core-dev
 37 2021-03-09T02:52:30  <aj> hmm
 38 2021-03-09T02:54:39  <aj> well, the easy solution is add a check in the unit tests that the deployment periods all match the params period, and the dep thresholds are all >= the params rulechangethreshold
 39 2021-03-09T03:06:08  *** stortz <stortz!b1982779@> has quit IRC (Quit: Connection closed)
 40 2021-03-09T03:06:19  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Remote host closed the connection)
 41 2021-03-09T03:06:30  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
 42 2021-03-09T03:07:41  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Quit: Leaving)
 43 2021-03-09T03:10:41  <achow101> is having a fixed rule change threshold necessary? It could just search for the minimum threshold of all current deployments
 44 2021-03-09T03:15:52  <luke-jr> achow101: I'm guessing it is (or was) for the warnings
 45 2021-03-09T03:20:53  <aj> achow101: yes -- you still want warnings even if there are no current deployments (you're warning about things introduced in future releases of the code)
 46 2021-03-09T03:21:25  <achow101> luke-jr: it was for all activations, in 21392 it is just for the warnings
 47 2021-03-09T03:21:50  <achow101> aj: we always have testdummy, so when there are no active deployments, it uses testdummy's threshold
 48 2021-03-09T03:21:59  <luke-jr> hmm
 49 2021-03-09T03:26:31  <aj> achow101: seems nuts to me, we want a global "what's the lowest threshold any future deployment might have", why wouldn't we just have that as a field?
 50 2021-03-09T03:26:59  <achow101> true. we should probably lower it farther though. to 75% maybe
 51 2021-03-09T03:27:27  <aj> yep
 52 2021-03-09T03:28:38  <jeremyrubin> I think it probably makes sense to do a lower threshold -- anything over 0 probably suggests some sort of proposed rule change?
 53 2021-03-09T03:28:50  <jeremyrubin> We still warn any unknown vbit right?
 54 2021-03-09T03:29:01  <achow101> too low and we warn on all the asicboost crap
 55 2021-03-09T03:29:18  <aj> jeremyrubin: the warning is "unknown new rules activated (versionbit X)"
 56 2021-03-09T03:29:57  <aj> achow101: https://github.com/bitcoin/bitcoin/pull/21380/commits/6bea865c8e2c09150b1ebf9abce5d9684f6441f9#diff-f0697aa70d82dc886876d2b62b6c4d1c27d584c2001e1bf605f74d28a06b4d8dR250-R253
 57 2021-03-09T03:30:48  <luke-jr> I have a PR open to restore the unknown bit warnings in a asicboost-friendly way btw
 58 2021-03-09T03:31:08  <luke-jr> #15861
 59 2021-03-09T03:31:10  <gribble> https://github.com/bitcoin/bitcoin/issues/15861 | Restore warning for individual unknown version bits, as well as unknown version schemas by luke-jr · Pull Request #15861 · bitcoin/bitcoin · GitHub
 60 2021-03-09T03:32:52  <jeremyrubin> tbh I think that w.r.t. the threshold, the periods are probably of more concern?
 61 2021-03-09T03:32:59  <achow101> aj: oh nice. nit: name it m_threshold (something something style guide)
 62 2021-03-09T03:49:55  *** biff_ <biff_!~biff@cpe-174-104-42-57.neo.res.rr.com> has joined #bitcoin-core-dev
 63 2021-03-09T03:50:06  *** cltrbreak_MAD2 <cltrbreak_MAD2!~ctrlbreak@> has joined #bitcoin-core-dev
 64 2021-03-09T03:50:08  *** criley <criley!~criley@c-73-224-125-58.hsd1.fl.comcast.net> has joined #bitcoin-core-dev
 65 2021-03-09T03:50:27  *** biff_ <biff_!~biff@cpe-174-104-42-57.neo.res.rr.com> has quit IRC (Client Quit)
 66 2021-03-09T03:50:30  *** taky_ <taky_!~taky@> has joined #bitcoin-core-dev
 67 2021-03-09T03:50:34  *** TheRec_ <TheRec_!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
 68 2021-03-09T03:50:40  *** biff_ <biff_!~biff@cpe-174-104-42-57.neo.res.rr.com> has joined #bitcoin-core-dev
 69 2021-03-09T03:50:45  *** wumpus2 <wumpus2!~ircclient@pdpc/supporter/professional/wumpus> has joined #bitcoin-core-dev
 70 2021-03-09T03:50:47  *** ossifrage_ <ossifrage_!~ossifrage@unaffiliated/ossifrage> has joined #bitcoin-core-dev
 71 2021-03-09T03:51:26  *** rockhouse2 <rockhouse2!~rockhouse@unaffiliated/rockhouse> has joined #bitcoin-core-dev
 72 2021-03-09T03:51:39  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has quit IRC (Disconnected by services)
 73 2021-03-09T03:51:50  *** treyzania_ <treyzania_!~treyzania@paphos.tr3y.io> has joined #bitcoin-core-dev
 74 2021-03-09T03:51:55  *** biff_ <biff_!~biff@cpe-174-104-42-57.neo.res.rr.com> has quit IRC (Client Quit)
 75 2021-03-09T03:52:28  *** jnewbery_ <jnewbery_!~john@> has joined #bitcoin-core-dev
 76 2021-03-09T03:52:35  *** root <root!~echo@> has joined #bitcoin-core-dev
 77 2021-03-09T03:52:58  *** root is now known as Guest86647
 78 2021-03-09T03:53:01  *** dlb76_ <dlb76_!~dlb76@> has joined #bitcoin-core-dev
 79 2021-03-09T03:53:27  *** daveg <daveg!~biff@unaffiliated/daveg> has quit IRC (Killed (beckett.freenode.net (Nickname regained by services)))
 80 2021-03-09T03:53:50  *** tim <tim!~real_or_r@> has joined #bitcoin-core-dev
 81 2021-03-09T03:54:13  *** tim is now known as Guest52984
 82 2021-03-09T03:54:18  *** pinheadmz_ <pinheadmz_!~pinheadmz@hns-contributor.dev> has joined #bitcoin-core-dev
 83 2021-03-09T03:54:23  *** andytosh1 <andytosh1!~apoelstra@unaffiliated/andytoshi> has joined #bitcoin-core-dev
 84 2021-03-09T03:54:24  *** Artea_ <Artea_!~Lufia@artea.com.pt> has joined #bitcoin-core-dev
 85 2021-03-09T03:54:25  *** hirish <hirish!~hirish@ip85.ip-137-74-20.eu> has joined #bitcoin-core-dev
 86 2021-03-09T03:54:33  *** daveg <daveg!~biff@unaffiliated/daveg> has joined #bitcoin-core-dev
 87 2021-03-09T03:54:58  *** aj_ <aj_!aj@> has joined #bitcoin-core-dev
 88 2021-03-09T03:55:25  *** livestradamus_ <livestradamus_!~quassel@> has joined #bitcoin-core-dev
 89 2021-03-09T03:55:25  *** jtimon_ <jtimon_!~quassel@> has joined #bitcoin-core-dev
 90 2021-03-09T03:56:11  *** berndj-blackout <berndj-blackout!~berndj@ns2.linksynergy.co.za> has joined #bitcoin-core-dev
 91 2021-03-09T03:56:21  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
 92 2021-03-09T03:56:23  *** einyx_ <einyx_!einyx@fsf/member/einyx> has joined #bitcoin-core-dev
 93 2021-03-09T03:58:12  *** niska` <niska`!~niska@static.> has joined #bitcoin-core-dev
 94 2021-03-09T03:59:14  *** meshcoll- <meshcoll-!meshcollid@gateway/shell/ircnow/x-fxgnvsfciueukqqj> has joined #bitcoin-core-dev
 95 2021-03-09T03:59:24  *** JokerAscensionEx <JokerAscensionEx!~egp_@> has quit IRC (*.net *.split)
 96 2021-03-09T03:59:25  *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-ddmqaipvovndqpkj> has quit IRC (*.net *.split)
 97 2021-03-09T03:59:25  *** jtimon <jtimon!~quassel@> has quit IRC (*.net *.split)
 98 2021-03-09T03:59:25  *** einyx <einyx!einyx@fsf/member/einyx> has quit IRC (*.net *.split)
 99 2021-03-09T03:59:25  *** treyzania <treyzania!~treyzania@paphos.tr3y.io> has quit IRC (*.net *.split)
100 2021-03-09T03:59:25  *** criley_ <criley_!~criley@c-73-224-125-58.hsd1.fl.comcast.net> has quit IRC (*.net *.split)
101 2021-03-09T03:59:25  *** livestradamus <livestradamus!~quassel@unaffiliated/livestradamus> has quit IRC (*.net *.split)
102 2021-03-09T03:59:25  *** rockhouse <rockhouse!~rockhouse@unaffiliated/rockhouse> has quit IRC (*.net *.split)
103 2021-03-09T03:59:25  *** berndj <berndj!~berndj@ns1.linksynergy.co.za> has quit IRC (*.net *.split)
104 2021-03-09T03:59:25  *** pinheadmz <pinheadmz!~pinheadmz@hns-contributor.dev> has quit IRC (*.net *.split)
105 2021-03-09T03:59:26  *** ossifrage <ossifrage!~ossifrage@unaffiliated/ossifrage> has quit IRC (*.net *.split)
106 2021-03-09T03:59:26  *** dongcarl <dongcarl!~dongcarl@unaffiliated/dongcarl> has quit IRC (*.net *.split)
107 2021-03-09T03:59:26  *** thrasher` <thrasher`!~thrasher@> has quit IRC (*.net *.split)
108 2021-03-09T03:59:26  *** esotericnonsense <esotericnonsense!~esotericn@unaffiliated/esotericnonsense> has quit IRC (*.net *.split)
109 2021-03-09T03:59:26  *** so <so!~so@unaffiliated/so> has quit IRC (*.net *.split)
110 2021-03-09T03:59:26  *** taky <taky!~taky@unaffiliated/taky> has quit IRC (*.net *.split)
111 2021-03-09T03:59:27  *** aj <aj!aj@cerulean.erisian.com.au> has quit IRC (*.net *.split)
112 2021-03-09T03:59:27  *** real_or_random <real_or_random!~real_or_r@> has quit IRC (*.net *.split)
113 2021-03-09T03:59:27  *** dlb76 <dlb76!~dlb76@unaffiliated/dlb76> has quit IRC (*.net *.split)
114 2021-03-09T03:59:27  *** niftynei <niftynei!~niftynei@> has quit IRC (*.net *.split)
115 2021-03-09T03:59:27  *** niska <niska!~niska@static.> has quit IRC (*.net *.split)
116 2021-03-09T03:59:27  *** adiabat_ <adiabat_!~adiabat@> has quit IRC (*.net *.split)
117 2021-03-09T03:59:27  *** eSN-[i] <eSN-[i]!~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net> has quit IRC (*.net *.split)
118 2021-03-09T03:59:27  *** TheRec <TheRec!~toto@drupal.org/user/146860/view> has quit IRC (*.net *.split)
119 2021-03-09T03:59:28  *** Guest16537 <Guest16537!~echo@> has quit IRC (*.net *.split)
120 2021-03-09T03:59:28  *** wumpus <wumpus!~ircclient@pdpc/supporter/professional/wumpus> has quit IRC (*.net *.split)
121 2021-03-09T03:59:28  *** Artea <Artea!~Lufia@artea.com.pt> has quit IRC (*.net *.split)
122 2021-03-09T03:59:28  *** jnewbery <jnewbery!~john@> has quit IRC (*.net *.split)
123 2021-03-09T03:59:28  *** ctrlbreak_MAD <ctrlbreak_MAD!~ctrlbreak@> has quit IRC (*.net *.split)
124 2021-03-09T03:59:28  *** andytoshi <andytoshi!~apoelstra@unaffiliated/andytoshi> has quit IRC (*.net *.split)
125 2021-03-09T03:59:28  *** lio17 <lio17!~lio17@80.ip-145-239-89.eu> has quit IRC (*.net *.split)
126 2021-03-09T03:59:28  *** pingwindyktator <pingwindyktator!~pingwindy@pingwindyktator.me> has quit IRC (*.net *.split)
127 2021-03-09T03:59:29  *** hirish_ <hirish_!~hirish@ip85.ip-137-74-20.eu> has quit IRC (*.net *.split)
128 2021-03-09T03:59:29  *** nickler <nickler!~nickler@static.> has quit IRC (*.net *.split)
129 2021-03-09T03:59:31  *** berndj-blackout is now known as berndj
130 2021-03-09T03:59:31  *** rockhouse2 is now known as rockhouse
131 2021-03-09T04:00:03  *** lio17 <lio17!~lio17@80.ip-145-239-89.eu> has joined #bitcoin-core-dev
132 2021-03-09T04:00:14  *** thrasher` <thrasher`!~thrasher@> has joined #bitcoin-core-dev
133 2021-03-09T04:00:24  *** pingwindyktator <pingwindyktator!~pingwindy@pingwindyktator.me> has joined #bitcoin-core-dev
134 2021-03-09T04:00:47  *** adiabat_ <adiabat_!~adiabat@> has joined #bitcoin-core-dev
135 2021-03-09T04:01:42  *** nickler <nickler!~nickler@static.> has joined #bitcoin-core-dev
136 2021-03-09T04:01:45  *** esotericnonsense <esotericnonsense!~esotericn@unaffiliated/esotericnonsense> has joined #bitcoin-core-dev
137 2021-03-09T04:02:17  *** JokerAscensionEx <JokerAscensionEx!~egp_@> has joined #bitcoin-core-dev
138 2021-03-09T04:06:25  *** aj_ is now known as aj
139 2021-03-09T04:06:46  <jeremyrubin> Do we nuke all the validation caches after a soft fork activates?
140 2021-03-09T04:07:02  <jeremyrubin> E.g., the scriptcache?
141 2021-03-09T04:08:04  *** ossifrage_ is now known as ossifrage
142 2021-03-09T04:10:38  <jeremyrubin> Ah we commit to the validation caches for those
143 2021-03-09T04:10:39  *** so <so!~so@unaffiliated/so> has joined #bitcoin-core-dev
144 2021-03-09T04:10:43  <jeremyrubin> *validation flags
145 2021-03-09T04:15:35  *** niftynei <niftynei!~niftynei@> has joined #bitcoin-core-dev
146 2021-03-09T04:19:34  <sipa_> yup
147 2021-03-09T04:40:21  *** theChief <theChief!~Mohamed@> has quit IRC ()
148 2021-03-09T04:46:37  *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
149 2021-03-09T04:47:00  *** shesek <shesek!~shesek@> has joined #bitcoin-core-dev
150 2021-03-09T05:13:15  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 272 seconds)
151 2021-03-09T05:13:35  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
152 2021-03-09T05:17:13  *** BGL <BGL!~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net> has joined #bitcoin-core-dev
153 2021-03-09T05:26:49  *** gleb <gleb!~gleb@> has joined #bitcoin-core-dev
154 2021-03-09T05:36:59  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 268 seconds)
155 2021-03-09T05:38:31  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
156 2021-03-09T05:46:59  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC ()
157 2021-03-09T06:04:38  *** jtimon_ <jtimon_!~quassel@> has quit IRC (Ping timeout: 260 seconds)
158 2021-03-09T06:06:12  *** smctwo <smctwo!~smctwo@> has joined #bitcoin-core-dev
159 2021-03-09T06:08:57  *** leonardo_ <leonardo_!uid489830@gateway/web/irccloud.com/x-jmrvfqqpvornuvwi> has quit IRC (Quit: Connection closed for inactivity)
160 2021-03-09T06:10:50  *** smctwo <smctwo!~smctwo@> has quit IRC (Ping timeout: 264 seconds)
161 2021-03-09T06:21:18  *** jesseposner <jesseposner!~jp@2601:645:200:162f:3167:e7cf:cd0a:198e> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
162 2021-03-09T06:43:36  *** jesseposner <jesseposner!~jp@2601:645:200:162f:d2d:bec5:dbe:1d75> has joined #bitcoin-core-dev
163 2021-03-09T06:55:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
164 2021-03-09T06:55:29  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a8b0892b743b...6c156e49cb7a
165 2021-03-09T06:55:30  <bitcoin-git> bitcoin/master fa4e088 MarcoFalke: wallet: Mark replaced tx to not be in the mempool anymore
166 2021-03-09T06:55:30  <bitcoin-git> bitcoin/master 6c156e4 MarcoFalke: Merge #18842: wallet: Mark replaced tx to not be in the mempool anymore
167 2021-03-09T06:55:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
168 2021-03-09T06:55:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
169 2021-03-09T06:55:59  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18842: wallet: Mark replaced tx to not be in the mempool anymore (master...2004-walletBumpFeeReplacedTxNoMempool) https://github.com/bitcoin/bitcoin/pull/18842
170 2021-03-09T06:56:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
171 2021-03-09T07:05:26  *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has quit IRC (Ping timeout: 264 seconds)
172 2021-03-09T07:21:15  *** jesseposner <jesseposner!~jp@2601:645:200:162f:d2d:bec5:dbe:1d75> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
173 2021-03-09T07:29:39  *** jonatack <jonatack!~jon@> has joined #bitcoin-core-dev
174 2021-03-09T07:34:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
175 2021-03-09T07:34:47  <bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/6c156e49cb7a...738fc4a59517
176 2021-03-09T07:34:47  <bitcoin-git> bitcoin/master bf24774 Hennadii Stepanov: build, qt: Refactor internal _BITCOIN_QT_CHECK_STATIC_PLUGINS macro
177 2021-03-09T07:34:48  <bitcoin-git> bitcoin/master 6203457 Hennadii Stepanov: build, refactor: Rename internal _BITCOIN_QT_FIND_STATIC_PLUGINS macro
178 2021-03-09T07:34:49  <bitcoin-git> bitcoin/master 57b6522 Hennadii Stepanov: build, qt: Make Qt static libs check regardless of plugindir
179 2021-03-09T07:34:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
180 2021-03-09T07:35:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
181 2021-03-09T07:35:15  <bitcoin-git> [bitcoin] fanquake merged pull request #21363: build, qt: Improve Qt static plugins/libs check code (master...210304-qt) https://github.com/bitcoin/bitcoin/pull/21363
182 2021-03-09T07:35:16  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
183 2021-03-09T07:40:56  *** jesseposner <jesseposner!~jp@2601:645:200:162f:d38:a5c2:980:75b0> has joined #bitcoin-core-dev
184 2021-03-09T07:43:47  <fanquake> oh no indeed: https://0bin.net/paste/CVaNbQ-c#jnhc392Y+u9CBfbaN+0GIHJ-vI/jLQPHJkMe/CfyAZQ
185 2021-03-09T07:43:57  <fanquake> Apparently I'm no longer allowed to leave reviewss
186 2021-03-09T07:47:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
187 2021-03-09T07:47:35  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/738fc4a59517...461f0c781e5a
188 2021-03-09T07:47:36  <bitcoin-git> bitcoin/master 5129b36 Hennadii Stepanov: build: Clean remnants of QTBUG-34748 fix
189 2021-03-09T07:47:37  <bitcoin-git> bitcoin/master 173ef89 Hennadii Stepanov: build: Small libxcb.mk improvements
190 2021-03-09T07:47:37  <bitcoin-git> bitcoin/master 461f0c7 fanquake: Merge #21382: build: Clean remnants of QTBUG-34748 fix
191 2021-03-09T07:47:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
192 2021-03-09T07:48:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
193 2021-03-09T07:48:04  <bitcoin-git> [bitcoin] fanquake merged pull request #21382: build: Clean remnants of QTBUG-34748 fix (master...210307-libxcb) https://github.com/bitcoin/bitcoin/pull/21382
194 2021-03-09T07:48:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
195 2021-03-09T07:49:45  *** jonatack <jonatack!~jon@> has quit IRC (Read error: Connection reset by peer)
196 2021-03-09T07:50:19  *** jonatack <jonatack!~jon@> has joined #bitcoin-core-dev
197 2021-03-09T07:50:29  *** daveg <daveg!~biff@unaffiliated/daveg> has quit IRC (Quit: Leaving)
198 2021-03-09T07:55:20  *** pox <pox!~pox@gateway/tor-sasl/pox> has quit IRC (Quit: pox)
199 2021-03-09T07:56:09  *** pox <pox!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
200 2021-03-09T08:05:44  *** jungly <jungly!~jungly@host-79-19-187-19.retail.telecomitalia.it> has joined #bitcoin-core-dev
201 2021-03-09T08:32:04  *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
202 2021-03-09T08:33:02  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
203 2021-03-09T08:33:52  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
204 2021-03-09T08:42:10  *** kabaum <kabaum!~kabaum@h-13-35.A163.priv.bahnhof.se> has quit IRC (Ping timeout: 276 seconds)
205 2021-03-09T08:42:37  *** kabaum <kabaum!~kabaum@h-13-35.A163.priv.bahnhof.se> has joined #bitcoin-core-dev
206 2021-03-09T08:48:53  *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f1aca00c143e0318365b648.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
207 2021-03-09T09:12:45  <vasild> fanquake: "your browser did something unexpected" wtf!?
208 2021-03-09T09:14:24  <vasild> btw I was just logged out of my github account and had to enter user/pass again. This has not happened for months, if not years. May be related.
209 2021-03-09T09:21:58  *** Randolf <Randolf!~randolf@> has joined #bitcoin-core-dev
210 2021-03-09T09:32:23  <fanquake> I was also logged out earlier today
211 2021-03-09T09:36:58  *** meshcoll- <meshcoll-!meshcollid@gateway/shell/ircnow/x-fxgnvsfciueukqqj> has quit IRC (Ping timeout: 260 seconds)
212 2021-03-09T09:38:46  *** jonatack_ <jonatack_!~jon@> has joined #bitcoin-core-dev
213 2021-03-09T09:42:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
214 2021-03-09T09:42:05  <bitcoin-git> [bitcoin] jnewbery opened pull request #21395: Net processing: Remove redundant CNode.address member (master...2021-03-remove-address) https://github.com/bitcoin/bitcoin/pull/21395
215 2021-03-09T09:42:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
216 2021-03-09T09:42:34  *** jonatack <jonatack!~jon@> has quit IRC (Ping timeout: 260 seconds)
217 2021-03-09T09:43:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
218 2021-03-09T09:43:34  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/461f0c781e5a...e175ca9c6563
219 2021-03-09T09:43:35  <bitcoin-git> bitcoin/master fa476f1 MarcoFalke: Use C++11 member initializer in CNodeState
220 2021-03-09T09:43:36  <bitcoin-git> bitcoin/master e175ca9 fanquake: Merge #21370: Use C++11 member initializer in CNodeState
221 2021-03-09T09:43:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
222 2021-03-09T09:43:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
223 2021-03-09T09:43:56  <bitcoin-git> [bitcoin] fanquake merged pull request #21370: Use C++11 member initializer in CNodeState (master...2103-netCNodeStateRefactor) https://github.com/bitcoin/bitcoin/pull/21370
224 2021-03-09T09:43:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
225 2021-03-09T09:49:20  *** FrontSevens <FrontSevens!~FrontSeve@> has quit IRC (Remote host closed the connection)
226 2021-03-09T10:06:10  *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-qjonxuxpnxmzzqjx> has joined #bitcoin-core-dev
227 2021-03-09T10:09:02  <kallewoof> vasild: fanquake: there was some abundance-of-caution event that triggered a mass-expiry of all sessions: https://twitter.com/github/status/1369129888662306819?s=20
228 2021-03-09T10:11:59  *** hydenpype <hydenpype!7a1a1385@p1174134-ipoe.ipoe.ocn.ne.jp> has joined #bitcoin-core-dev
229 2021-03-09T10:13:59  *** hydenpype <hydenpype!7a1a1385@p1174134-ipoe.ipoe.ocn.ne.jp> has quit IRC (Client Quit)
230 2021-03-09T10:29:45  *** JLP1 <JLP1!~JLP@> has joined #bitcoin-core-dev
231 2021-03-09T10:33:55  <vasild> kallewoof: thanks for the link, "extremely rare security issue affecting a very small number of users" :-D
232 2021-03-09T11:11:14  *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-qjonxuxpnxmzzqjx> has quit IRC (Remote host closed the connection)
233 2021-03-09T11:13:35  *** DeanWeen <DeanWeen!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
234 2021-03-09T11:14:02  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
235 2021-03-09T11:16:09  *** jungly <jungly!~jungly@host-79-19-187-19.retail.telecomitalia.it> has quit IRC (Ping timeout: 264 seconds)
236 2021-03-09T11:18:28  *** Gerson58Tremblay <Gerson58Tremblay!~Gerson58T@static.> has joined #bitcoin-core-dev
237 2021-03-09T11:46:28  *** pinheadmz_ <pinheadmz_!~pinheadmz@hns-contributor.dev> has quit IRC (Quit: ZNC 1.8.2+deb1+bionic2 - https://znc.in)
238 2021-03-09T11:47:33  *** pinheadmz <pinheadmz!~pinheadmz@hns-contributor.dev> has joined #bitcoin-core-dev
239 2021-03-09T11:50:52  *** pinheadmz <pinheadmz!~pinheadmz@hns-contributor.dev> has quit IRC (Client Quit)
240 2021-03-09T12:00:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
241 2021-03-09T12:00:04  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #21397: fuzz: Bump FuzzedDataProvider.h (master...2103-fuzzInclude) https://github.com/bitcoin/bitcoin/pull/21397
242 2021-03-09T12:00:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
243 2021-03-09T12:05:49  *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-vbhvluwoeowgddsh> has joined #bitcoin-core-dev
244 2021-03-09T12:31:56  *** setpill <setpill!~setpill@unaffiliated/setpill> has joined #bitcoin-core-dev
245 2021-03-09T12:46:38  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 260 seconds)
246 2021-03-09T12:48:40  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
247 2021-03-09T12:51:44  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 245 seconds)
248 2021-03-09T12:54:15  *** belcher_ is now known as belcher
249 2021-03-09T12:54:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
250 2021-03-09T12:54:57  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e175ca9c6563...ee0dc02c6f93
251 2021-03-09T12:54:57  <bitcoin-git> bitcoin/master fa7dc7a MarcoFalke: fuzz: Bump FuzzedDataProvider.h
252 2021-03-09T12:54:58  <bitcoin-git> bitcoin/master ee0dc02 MarcoFalke: Merge #21397: fuzz: Bump FuzzedDataProvider.h
253 2021-03-09T12:55:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
254 2021-03-09T12:55:16  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
255 2021-03-09T12:55:17  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #21397: fuzz: Bump FuzzedDataProvider.h (master...2103-fuzzInclude) https://github.com/bitcoin/bitcoin/pull/21397
256 2021-03-09T12:55:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
257 2021-03-09T13:02:34  *** theprofessor0x <theprofessor0x!~Mohamed@bb121-6-182-56.singnet.com.sg> has joined #bitcoin-core-dev
258 2021-03-09T13:08:48  *** jungly <jungly!~jungly@host-79-19-187-19.retail.telecomitalia.it> has joined #bitcoin-core-dev
259 2021-03-09T13:10:43  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has joined #bitcoin-core-dev
260 2021-03-09T13:14:37  *** jnewbery_ is now known as jnewbery
261 2021-03-09T13:15:08  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has quit IRC (Remote host closed the connection)
262 2021-03-09T13:15:33  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
263 2021-03-09T13:16:22  *** RandolfR <RandolfR!~randolf@> has joined #bitcoin-core-dev
264 2021-03-09T13:17:08  *** Randolf <Randolf!~randolf@> has quit IRC (Ping timeout: 245 seconds)
265 2021-03-09T13:20:21  *** jonatack_ <jonatack_!~jon@> has quit IRC (Ping timeout: 264 seconds)
266 2021-03-09T13:20:42  *** Gerson58Tremblay <Gerson58Tremblay!~Gerson58T@static.> has quit IRC (Ping timeout: 246 seconds)
267 2021-03-09T13:30:27  *** JLP1 <JLP1!~JLP@> has quit IRC (Remote host closed the connection)
268 2021-03-09T13:30:49  *** jonatack <jonatack!~jon@> has joined #bitcoin-core-dev
269 2021-03-09T13:37:14  *** scedastik <scedastik!~scedastik@c-68-58-168-96.hsd1.mi.comcast.net> has joined #bitcoin-core-dev
270 2021-03-09T13:38:43  *** scedastik <scedastik!~scedastik@c-68-58-168-96.hsd1.mi.comcast.net> has quit IRC (Client Quit)
271 2021-03-09T13:42:45  *** kvaciral <kvaciral!~kvaciral@> has quit IRC (Quit: Lost terminal)
272 2021-03-09T13:46:43  *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-vbhvluwoeowgddsh> has quit IRC (Ping timeout: 260 seconds)
273 2021-03-09T13:48:18  *** kvaciral <kvaciral!~kvaciral@> has joined #bitcoin-core-dev
274 2021-03-09T13:55:21  <sdaftuar> jeremyrubin | Do we nuke all the validation caches after a soft fork activates? <------- the scriptcache includes a hash of the consensus flags that a transaction's scripts were validated with, so that when a softfork activates we just end up with cache misses, and not consensus failure
275 2021-03-09T13:56:09  *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-irngybgfmgpzypua> has joined #bitcoin-core-dev
276 2021-03-09T14:02:38  *** maop <maop!~maop@> has joined #bitcoin-core-dev
277 2021-03-09T14:10:05  *** morcos <morcos!~morcos@gateway/tor-sasl/morcos> has quit IRC (Remote host closed the connection)
278 2021-03-09T14:10:22  *** morcos <morcos!~morcos@gateway/tor-sasl/morcos> has joined #bitcoin-core-dev
279 2021-03-09T14:11:47  *** pinheadmz <pinheadmz!~pinheadmz@hns-contributor.dev> has joined #bitcoin-core-dev
280 2021-03-09T14:22:05  *** scedastik <scedastik!~scedastik@c-68-58-168-96.hsd1.mi.comcast.net> has joined #bitcoin-core-dev
281 2021-03-09T14:24:16  *** awesome_doge <awesome_doge!~Thunderbi@1-164-239-176.dynamic-ip.hinet.net> has joined #bitcoin-core-dev
282 2021-03-09T14:26:33  *** awesome_doge <awesome_doge!~Thunderbi@1-164-239-176.dynamic-ip.hinet.net> has quit IRC (Client Quit)
283 2021-03-09T14:27:02  *** awesome_doge <awesome_doge!~Thunderbi@1-164-239-176.dynamic-ip.hinet.net> has joined #bitcoin-core-dev
284 2021-03-09T14:29:44  <jnewbery> jeremyrubin: and for reference https://github.com/bitcoin/bitcoin/blob/ee0dc02c6f93de2a366bbff490eb4d37bca6a24f/src/validation.cpp#L982-L987
285 2021-03-09T14:37:12  *** jasonzhouu <jasonzhouu!~jasonzhou@> has joined #bitcoin-core-dev
286 2021-03-09T14:38:29  *** smctwo_ <smctwo_!~smctwo@> has joined #bitcoin-core-dev
287 2021-03-09T14:40:30  *** smctwo_ <smctwo_!~smctwo@> has quit IRC (Read error: Connection reset by peer)
288 2021-03-09T14:40:49  *** smctwo <smctwo!~smctwo@> has joined #bitcoin-core-dev
289 2021-03-09T14:43:16  *** sr_gi1 <sr_gi1!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has joined #bitcoin-core-dev
290 2021-03-09T14:44:03  *** sr_gi1 <sr_gi1!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has quit IRC (Client Quit)
291 2021-03-09T14:45:50  *** sr_gi1 <sr_gi1!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has joined #bitcoin-core-dev
292 2021-03-09T14:52:59  *** awesome_doge <awesome_doge!~Thunderbi@1-164-239-176.dynamic-ip.hinet.net> has quit IRC (Ping timeout: 245 seconds)
293 2021-03-09T14:57:46  *** jtimon <jtimon!~quassel@> has joined #bitcoin-core-dev
294 2021-03-09T15:00:06  *** sr_gi1 <sr_gi1!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has quit IRC (Quit: The Lounge - https://thelounge.chat)
295 2021-03-09T15:01:46  *** sr_gi1 <sr_gi1!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has joined #bitcoin-core-dev
296 2021-03-09T15:04:25  *** sanketh <sanketh!sid461832@gateway/web/irccloud.com/x-qyuwndufvvdayrxr> has left #bitcoin-core-dev
297 2021-03-09T15:07:00  *** awesome_doge <awesome_doge!~Thunderbi@1-164-239-176.dynamic-ip.hinet.net> has joined #bitcoin-core-dev
298 2021-03-09T15:11:46  *** awesome_doge <awesome_doge!~Thunderbi@1-164-239-176.dynamic-ip.hinet.net> has quit IRC (Ping timeout: 265 seconds)
299 2021-03-09T15:35:53  *** scedastik <scedastik!~scedastik@c-68-58-168-96.hsd1.mi.comcast.net> has quit IRC (Quit: scedastik)
300 2021-03-09T15:38:20  *** scedastik <scedastik!~scedastik@c-68-58-168-96.hsd1.mi.comcast.net> has joined #bitcoin-core-dev
301 2021-03-09T15:39:28  *** jespada <jespada!~jespada@> has quit IRC (Ping timeout: 276 seconds)
302 2021-03-09T15:41:29  *** jespada <jespada!~jespada@> has joined #bitcoin-core-dev
303 2021-03-09T15:42:08  <wumpus2> re: the "extreme rare github security issue" you might want to check https://github.com/settings/security-log that nothing weird has been done with your account, it doesn't show all events (like pushes) unfortunately
304 2021-03-09T15:47:05  <jonatack> good idea. "Logged in - Unknown location"... goooood
305 2021-03-09T15:52:03  *** wumpus2 is now known as wumpus
306 2021-03-09T15:54:26  *** JucaChavesFlamen <JucaChavesFlamen!8717734b@135-23-115-75.cpe.pppoe.ca> has joined #bitcoin-core-dev
307 2021-03-09T15:56:49  *** andytosh1 is now known as andytoshi
308 2021-03-09T15:57:24  *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
309 2021-03-09T15:58:49  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 245 seconds)
310 2021-03-09T16:01:32  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
311 2021-03-09T16:04:04  *** dongcarl <dongcarl!~dongcarl@unaffiliated/dongcarl> has joined #bitcoin-core-dev
312 2021-03-09T16:11:07  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
313 2021-03-09T16:24:49  <ariard> #19160 is pretty mature but still needs more reviewers :)
314 2021-03-09T16:24:52  <gribble> https://github.com/bitcoin/bitcoin/issues/19160 | multiprocess: Add basic spawn and IPC support by ryanofsky · Pull Request #19160 · bitcoin/bitcoin · GitHub
315 2021-03-09T16:27:27  *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
316 2021-03-09T16:28:11  <jonatack> ariard: indeed. it's on my list (sorry for the delay)
317 2021-03-09T16:28:27  *** shefsam <shefsam!6c5e4ec5@108-94-78-197.lightspeed.miamfl.sbcglobal.net> has joined #bitcoin-core-dev
318 2021-03-09T16:31:20  <shefsam> Where can I discuss a hacked Bitcoin Core Wallet? I recently opened my wallet after months if not years to find the last transaction - not mine and sweeping the entirety of my balance to an outside address I do not know.
319 2021-03-09T16:37:34  <wumpus> i also intend to look at the multiprocess stuff but haven't got around to it yet
320 2021-03-09T16:38:27  *** JucaChavesFlamen <JucaChavesFlamen!8717734b@135-23-115-75.cpe.pppoe.ca> has quit IRC (Quit: Connection closed)
321 2021-03-09T16:54:31  *** belcher_ is now known as belcher
322 2021-03-09T16:58:02  *** crazypython38 <crazypython38!627aa476@> has joined #bitcoin-core-dev
323 2021-03-09T17:08:06  *** crazypython38 <crazypython38!627aa476@> has quit IRC (Quit: Connection closed)
324 2021-03-09T17:14:11  *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
325 2021-03-09T17:18:20  *** Artea_ <Artea_!~Lufia@artea.com.pt> has left #bitcoin-core-dev
326 2021-03-09T17:18:49  *** Artea <Artea!~Lufia@artea.com.pt> has joined #bitcoin-core-dev
327 2021-03-09T17:18:53  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
328 2021-03-09T17:20:01  *** smctwo <smctwo!~smctwo@> has quit IRC (Remote host closed the connection)
329 2021-03-09T17:20:29  *** smctwo <smctwo!~smctwo@> has joined #bitcoin-core-dev
330 2021-03-09T17:21:47  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 265 seconds)
331 2021-03-09T17:21:58  *** sr_gi1 <sr_gi1!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has quit IRC (Quit: The Lounge - https://thelounge.chat)
332 2021-03-09T17:23:39  *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f1aca00c143e0318365b648.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
333 2021-03-09T17:25:25  *** smctwo <smctwo!~smctwo@> has quit IRC (Ping timeout: 276 seconds)
334 2021-03-09T17:31:44  *** sr_gi1 <sr_gi1!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has joined #bitcoin-core-dev
335 2021-03-09T17:34:17  *** sr_gi1 <sr_gi1!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has quit IRC (Client Quit)
336 2021-03-09T17:34:37  *** sr_gi1 <sr_gi1!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has joined #bitcoin-core-dev
337 2021-03-09T17:35:49  *** jonatack <jonatack!~jon@> has quit IRC (Ping timeout: 276 seconds)
338 2021-03-09T17:36:24  *** sr_gi1 <sr_gi1!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has quit IRC (Client Quit)
339 2021-03-09T17:36:56  *** sr_gi <sr_gi!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has joined #bitcoin-core-dev
340 2021-03-09T17:41:25  *** jonatack <jonatack!~jon@> has joined #bitcoin-core-dev
341 2021-03-09T17:50:53  *** setpill <setpill!~setpill@unaffiliated/setpill> has quit IRC (Quit: setpill)
342 2021-03-09T17:56:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
343 2021-03-09T17:56:10  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #21398: doc: Update fuzzing docs for afl-clang-lto (master...2103-docFuzzAflPlusPlus) https://github.com/bitcoin/bitcoin/pull/21398
344 2021-03-09T17:56:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
345 2021-03-09T17:56:45  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
346 2021-03-09T17:59:11  *** lightlike <lightlike!~lightlike@p200300c7ef188100a44b6800926d040e.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
347 2021-03-09T18:23:45  *** smctwo <smctwo!~smctwo@> has joined #bitcoin-core-dev
348 2021-03-09T18:24:25  <jonatack> vasild: good find! https://github.com/bitcoin/bitcoin/issues/11537
349 2021-03-09T18:36:07  *** shefsam <shefsam!6c5e4ec5@108-94-78-197.lightspeed.miamfl.sbcglobal.net> has quit IRC (Quit: Connection closed)
350 2021-03-09T18:37:35  *** jonatack_ <jonatack_!~jon@> has joined #bitcoin-core-dev
351 2021-03-09T18:37:44  *** jonatack <jonatack!~jon@> has quit IRC (Read error: Connection reset by peer)
352 2021-03-09T18:40:47  *** jonatack_ <jonatack_!~jon@> has quit IRC (Read error: Connection reset by peer)
353 2021-03-09T18:41:14  *** jonatack_ <jonatack_!~jon@> has joined #bitcoin-core-dev
354 2021-03-09T18:41:48  *** jonatack_ <jonatack_!~jon@> has quit IRC (Client Quit)
355 2021-03-09T18:42:06  *** jonatack <jonatack!~jon@> has joined #bitcoin-core-dev
356 2021-03-09T18:51:54  *** justin <justin!~justin@2605:a601:a0ca:2e00:4d1a:a05a:6265:94e8> has joined #bitcoin-core-dev
357 2021-03-09T18:52:19  *** justin is now known as Guest77068
358 2021-03-09T18:57:58  *** jungly <jungly!~jungly@host-79-19-187-19.retail.telecomitalia.it> has quit IRC (Ping timeout: 245 seconds)
359 2021-03-09T19:00:29  *** proofofkeags <proofofkeags!~proofofke@> has joined #bitcoin-core-dev
360 2021-03-09T19:13:09  *** jonatack <jonatack!~jon@> has quit IRC (Ping timeout: 246 seconds)
361 2021-03-09T19:16:09  *** RandolfR <RandolfR!~randolf@> has quit IRC (Quit: Leaving)
362 2021-03-09T19:19:40  *** jonatack <jonatack!~jon@> has joined #bitcoin-core-dev
363 2021-03-09T19:38:23  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
364 2021-03-09T19:51:06  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
365 2021-03-09T19:52:20  *** ovovo <ovovo!~ovovo@> has joined #bitcoin-core-dev
366 2021-03-09T19:54:15  *** stortz <stortz!c8b9cbcf@> has joined #bitcoin-core-dev
367 2021-03-09T19:54:39  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 245 seconds)
368 2021-03-09T20:20:45  *** stortz <stortz!c8b9cbcf@> has quit IRC (Quit: Connection closed)
369 2021-03-09T20:27:11  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
370 2021-03-09T20:42:43  *** smctwo <smctwo!~smctwo@> has quit IRC (Remote host closed the connection)
371 2021-03-09T20:43:11  *** smctwo <smctwo!~smctwo@> has joined #bitcoin-core-dev
372 2021-03-09T20:44:34  *** smctwo <smctwo!~smctwo@> has quit IRC (Remote host closed the connection)
373 2021-03-09T20:45:00  *** smctwo <smctwo!~smctwo@> has joined #bitcoin-core-dev
374 2021-03-09T20:46:09  *** jonatack <jonatack!~jon@> has quit IRC (Ping timeout: 264 seconds)
375 2021-03-09T20:47:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
376 2021-03-09T20:47:34  <bitcoin-git> [bitcoin] luke-jr opened pull request #21399: Genericide BIP9 in variable/type names and comments (master...vbits_rename) https://github.com/bitcoin/bitcoin/pull/21399
377 2021-03-09T20:47:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
378 2021-03-09T20:52:01  <jnewbery> Hi folks. We'll start the p2p meeting in 10 minutes.
379 2021-03-09T20:57:16  <jnewbery> Feel free to update your priorities in https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities
380 2021-03-09T20:57:31  *** JokerAscensionEx <JokerAscensionEx!~egp_@> has quit IRC (Read error: Connection reset by peer)
381 2021-03-09T21:00:11  <jnewbery> #startmeeting
382 2021-03-09T21:00:11  <core-meetingbot> Meeting started Tue Mar  9 21:00:11 2021 UTC.  The chair is jnewbery. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
383 2021-03-09T21:00:11  <core-meetingbot> Available commands: action commands idea info link nick
384 2021-03-09T21:00:17  <jnewbery> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
385 2021-03-09T21:00:23  <jnewbery> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus
386 2021-03-09T21:00:26  *** realname192 <realname192!~real@> has joined #bitcoin-core-dev
387 2021-03-09T21:00:27  <amiti> hi
388 2021-03-09T21:00:28  <hebasto> hi
389 2021-03-09T21:00:34  <gleb> hi
390 2021-03-09T21:00:38  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Remote host closed the connection)
391 2021-03-09T21:00:39  <ariard> hi
392 2021-03-09T21:00:48  <emzy> hi
393 2021-03-09T21:00:50  <aj> hi
394 2021-03-09T21:00:52  <ajonas> hello
395 2021-03-09T21:01:03  <jnewbery> topics are here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings
396 2021-03-09T21:01:24  <jnewbery> contributors' current priorities are here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities
397 2021-03-09T21:01:35  *** JokerAscensionEx <JokerAscensionEx!~egp_@> has joined #bitcoin-core-dev
398 2021-03-09T21:01:47  <jnewbery> There's one proposed topic this week: Erlay (gleb). Before we do that, does anyone have any other proposed topics or short updates?
399 2021-03-09T21:01:55  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
400 2021-03-09T21:02:06  <aj> would be interested in an update on disabletx and the thread on -dev about it
401 2021-03-09T21:02:12  <ajonas> I have a something i put together addrman and eclipse attacks (not quite a full topic)
402 2021-03-09T21:02:19  <fjahr> hi
403 2021-03-09T21:02:31  <ajonas> it should only take a couple of minutes
404 2021-03-09T21:02:45  <jnewbery> aj: yep, we can do that
405 2021-03-09T21:03:01  <jnewbery> ajonas: ok, if it's quick let's do that first
406 2021-03-09T21:03:09  <jnewbery> #topic addrman and eclipse attacks (ajonas)
407 2021-03-09T21:03:10  <core-meetingbot> topic: addrman and eclipse attacks (ajonas)
408 2021-03-09T21:03:30  <ajonas> This is a doc I put on the wiki: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Addrman-and-eclipse-attacks
409 2021-03-09T21:03:42  <ajonas> feedback would be appreciated
410 2021-03-09T21:03:49  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Remote host closed the connection)
411 2021-03-09T21:04:05  <ajonas> Thank you to those that helped track down the details and reviewed
412 2021-03-09T21:04:16  <ajonas> fin
413 2021-03-09T21:04:35  <jnewbery> thanks ajonas!
414 2021-03-09T21:04:46  <jnewbery> any questions or should we move on to the next topic?
415 2021-03-09T21:04:49  <ariard> ajonas: consider those papers https://www.comp.nus.edu.sg/~kangms/papers/erebus-attack.pdf and https://btc-hijack.ethz.ch/files/btc_hijack.pdf on infrastructure-level eclipse attacks against bitcoin nodes
416 2021-03-09T21:05:25  <gleb> pretty sure the former one is included
417 2021-03-09T21:05:52  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
418 2021-03-09T21:06:18  <ariard> right it mentipns asmap which is only one of the mitigation proposed in erebeus paper iirc
419 2021-03-09T21:06:53  <ariard> (but better to do feedback after meeting, let's mov on)
420 2021-03-09T21:07:00  <jnewbery> next topic?
421 2021-03-09T21:07:08  <jnewbery> #topic erlay (gleb)
422 2021-03-09T21:07:08  <core-meetingbot> topic: erlay (gleb)
423 2021-03-09T21:07:19  <gleb> Hi! Just a little update here. I was working on Erlay refactor in a separate branch, currently addressing great comments from jnewbery and ariard. Gonna finish that in a day or two.
424 2021-03-09T21:08:01  <gleb> jnewbery: perhaps we'll invite everyone to full review again, after you give a quick skim of the high-level encapsulation approach etc in couple days?
425 2021-03-09T21:08:23  <gleb> or i should just do it once im done, if you think it's good enough?
426 2021-03-09T21:09:08  <gleb> just trying to make review more focused and optimize efforts
427 2021-03-09T21:09:20  <phantomcircuit> HELLO
428 2021-03-09T21:09:55  <jnewbery> gleb: I've left my comments. I don't think you need to wait for another round from me before opening a PR for the new branch.
429 2021-03-09T21:10:09  <phantomcircuit> jnewbery, i'd like to talk about #21106 today as well
430 2021-03-09T21:10:12  <gribble> https://github.com/bitcoin/bitcoin/issues/21106 | persist IBD latch across restarts by pstratem · Pull Request #21106 · bitcoin/bitcoin · GitHub
431 2021-03-09T21:10:24  <gleb> jnewbery: alright, thank you. that's the plan then
432 2021-03-09T21:10:33  <gleb> im done :)
433 2021-03-09T21:11:16  <jnewbery> phantomcircuit: sounds good. Thanks
434 2021-03-09T21:11:26  <jnewbery> any questions about erlay before the next topic?
435 2021-03-09T21:11:43  <sipa_> hi
436 2021-03-09T21:11:47  *** sipa_ is now known as sipa
437 2021-03-09T21:12:07  <jnewbery> #topic update on disabletx (aj)
438 2021-03-09T21:12:07  <core-meetingbot> topic: update on disabletx (aj)
439 2021-03-09T21:13:18  <aj> jnewbery's post makes sense to me -- that we can use frelay and avoid needing disabletx; but i don't understand ariard's response; and see suhas has updated the pr some more
440 2021-03-09T21:14:25  <amiti> +1
441 2021-03-09T21:15:25  <jnewbery> aj: did you read the log from the general bitcoin core irc meeting last week? There was quite a lot of discussion about using a -blocksonly node and occasionally sending txs from it
442 2021-03-09T21:16:25  <aj> jnewbery: i did, but as i understand it we can cope with that via fRelay fine
443 2021-03-09T21:17:24  <jnewbery> I hadn't thought about it any more since then, but I wasn't sure if we could cope with that via fRelay
444 2021-03-09T21:18:16  <ariard> aj: my point was bip37 original scope was unclear if it concerns only inv(tx) or any tx-related message, bip338 has the merit to clarify
445 2021-03-09T21:18:38  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 268 seconds)
446 2021-03-09T21:18:46  <jnewbery> the scenario is that you have a border node, and then a core node that only connects to that border node, and is -blocksonly. You want to be able to send txs from the core node to the border node. If we disallowed tx relay based on fRelay=false, then that wouldn't work(?)
447 2021-03-09T21:18:52  <aj> jnewbery: hmm, i think what i specced out in https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-March/018526.html is self-consistent and works with -blocksonly sensibly, can't guarantee it's properly backwards compatible (didn't look hard enough)
448 2021-03-09T21:19:32  <aj> jnewbery: it differentiates tx's based on direction -- ie if i say fRelay=false, you won't send txs to me, but i might send the to you
449 2021-03-09T21:20:13  <jnewbery> txRelay isn't required for receiving txs?
450 2021-03-09T21:20:29  <jnewbery> if that's the case, then I think I agree with you, but need to think about it some more
451 2021-03-09T21:20:49  <aj> txrelay isn't required for receiving i think, just trequest.cpp
452 2021-03-09T21:20:54  <aj> trequest.cpp
453 2021-03-09T21:20:55  <aj> gah
454 2021-03-09T21:20:59  <aj> txrequest.cpp
455 2021-03-09T21:21:12  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
456 2021-03-09T21:21:20  <jnewbery> aj: yes, I think you're right
457 2021-03-09T21:21:26  <amiti> some small changes are needed to support, but yeah, we don't need the whole txrelay struct to receive
458 2021-03-09T21:22:31  *** smctwo <smctwo!~smctwo@> has quit IRC (Remote host closed the connection)
459 2021-03-09T21:22:37  *** smctwo <smctwo!~smctwo@> has joined #bitcoin-core-dev
460 2021-03-09T21:23:21  <aj> ariard: i think bip 37 without bip 111 (the service bit) is pretty dead? bip 60 seems to match what i described above
461 2021-03-09T21:24:27  <jnewbery> aj: I agree
462 2021-03-09T21:24:29  <aj> ariard: if you advertise the bloom service bit, then i think you just treat that as no possibility of being lightweight, and everything works fine; and obv if you don't advertise the service bit, you already kill the connection if they try doing bloom stuff to you
463 2021-03-09T21:25:20  <jnewbery> (I've pinged sdaftuar, since he's probably interested in this)
464 2021-03-09T21:25:32  <sdaftuar> hi, sorry i'm late to the discussion. i don't understand why we'd go to these contortions to avoid a new p2p message, but if someone is interested in implementing this a different way, please feel free
465 2021-03-09T21:26:14  <aj> sdaftuar: i think it should not end up that twisted fwiw
466 2021-03-09T21:26:15  <ariard> aj: bip 60 "Whether the remote peer should announce relayed transactions or not" is a bip-60 compliant client allows to send TX messages after receiving `fRelay=false`
467 2021-03-09T21:26:58  <aj> ariard: i don't follow what you said?
468 2021-03-09T21:27:37  <jeremyrubin> sdaftuar: don't we only have 8e28 possible p2p messages?
469 2021-03-09T21:28:13  <sipa> i think fewer p2p messages with meanings that differ slightly across versions is slightly worse than separate ones with clear well defined meaning :)
470 2021-03-09T21:28:58  <aj> ariard: I run a -blocksonly node. You run a bip60 compliant node. I tell you fRelay=false. You don't send me any txes. You told me fRelay=true. Therefore I can send you a tx, without violating bip60.
471 2021-03-09T21:30:29  <ariard> aj: that's my point the "You don't send me any txes" isn't clearly documented in the bip, a naive implementation of bip 60 could try to send raw, unannounced TX messages
472 2021-03-09T21:31:52  <ariard> and don't understand why the connection is severed
473 2021-03-09T21:32:21  <sipa> if you're going by reading the spec by the letter... what does bip60"s fRelay flag even mean for a client that chooses not.to implement bip37?
474 2021-03-09T21:32:34  *** stortz <stortz!c8b9cbcf@> has joined #bitcoin-core-dev
475 2021-03-09T21:32:48  <amiti> I'd like explicit p2p messages with clear meanings, but what I don't like about the current disabletx proposal is the implicit disabling of addrs. I understand the hesitation to want to have a better understanding of addr relay before implementing a new protocol message, but I think that having disabletx implicitly disable addrs would make it harder for us to have clear, explicit messages about relay in the
476 2021-03-09T21:32:48  <amiti> long-term. so that makes me more inclined to use what we have, since it suffices
477 2021-03-09T21:32:57  <aj> ariard: it's always the sender's choice to not send a tx?
478 2021-03-09T21:33:35  <ariard> aj: right but imo current bip60 semantic isn't clear with what the sender is allowed to do
479 2021-03-09T21:34:18  <sipa> aj: i think ariard is trying to point out that bip37/bip60 only talk about *announcing* transactions, not sending (possibly unannounced) transactions
480 2021-03-09T21:34:52  *** realname192 <realname192!~real@> has quit IRC (Remote host closed the connection)
481 2021-03-09T21:35:58  <sipa> amiti: i think that's fair... i also don't really know what the issue would be with a sendaddrtypes message with a bitvector of bip155 network types for example (apart from not wanting to deal with that too right now)
482 2021-03-09T21:35:59  <aj> sipa: ie, if I say fRelay=false, ariard shouldn't send me INVs but perhaps should reply to a GETDATA with a TX?
483 2021-03-09T21:36:17  <ariard> yes that's it, and sending unannounced transactions is tolerated behavior for now
484 2021-03-09T21:36:44  <sipa> aj: maybe, or maybe he could still send you an unannounced transaction
485 2021-03-09T21:37:52  <aj> ariard: hmm. i wouldnt tolerate a TX message from you if i'd connected to you as a block-relay-only peer
486 2021-03-09T21:39:25  <jnewbery> ok, next topic?
487 2021-03-09T21:39:37  <aj> anyway, should we let phantomcircuit have the floor?
488 2021-03-09T21:39:42  <jnewbery> thanks aj
489 2021-03-09T21:40:00  <jnewbery> #topic IBD latch across restarts (phantomcircuit)
490 2021-03-09T21:40:00  <core-meetingbot> topic: IBD latch across restarts (phantomcircuit)
491 2021-03-09T21:40:07  <ariard> aj: how I know I'm a block-relay-only peer ? e.g what the exact scope of "block-relay-only"?
492 2021-03-09T21:40:14  <ariard> but yeah let's move on
493 2021-03-09T21:40:21  <phantomcircuit> eh hem
494 2021-03-09T21:41:34  <phantomcircuit> after discussing this with a number of people sipa and sdaftuar especially i think the better approach to a network event that latches all of the listening peers into ibd is simply to make the headers sync peer selection algorithm looser at intervals since we made progress on getting out of ibd
495 2021-03-09T21:41:54  <phantomcircuit> that more directly addresses the issue
496 2021-03-09T21:42:18  <sipa> phantomcircuit: did you see sdaftuar last's response where he suspects the issue is block fetching, not header syncinf?
497 2021-03-09T21:42:22  <phantomcircuit> (can also serve headers when we're past the chains minimum work regardless of ibd)
498 2021-03-09T21:43:32  <phantomcircuit> sipa, yes, we discussed it here, he missed that compact blocks received will not trigger a getheaders when we're in ibd
499 2021-03-09T21:43:51  <sipa> ah
500 2021-03-09T21:44:04  <sipa> so what precisely do you propose to address this?
501 2021-03-09T21:45:02  <phantomcircuit> if we haven't made progress on headers sync in at least INTERVAL time simply request headers from all peers
502 2021-03-09T21:45:47  <phantomcircuit> im sure there's more nuisanced solutions that could be employed but that's the most direct to prevent the issue
503 2021-03-09T21:46:25  <gleb> is there a summary of the issue and this discussion anywhere? I find it difficult to follow without prior context
504 2021-03-09T21:46:43  <sipa> #21106
505 2021-03-09T21:46:45  <gribble> https://github.com/bitcoin/bitcoin/issues/21106 | persist IBD latch across restarts by pstratem · Pull Request #21106 · bitcoin/bitcoin · GitHub
506 2021-03-09T21:46:51  <gleb> thanks
507 2021-03-09T21:47:30  <jnewbery> phantomcircuit: The scenario that you're trying to address (all or most of the listening nodes are restarted) seems like it'd always need some kind of manual intervention.
508 2021-03-09T21:47:34  <aj> this was the recent dogecoin network failure more or less?
509 2021-03-09T21:47:55  <emzy> I think so.
510 2021-03-09T21:48:42  <phantomcircuit> jnewbery, sure, lets say there's a crash bug, which has existed in the past
511 2021-03-09T21:48:49  *** jtimon <jtimon!~quassel@> has quit IRC (Remote host closed the connection)
512 2021-03-09T21:49:08  <sipa> aj: yes
513 2021-03-09T21:49:25  <phantomcircuit> i'll note that what i describe in the pr has happened on an altcoin derived from the bitcoin codebase and is relatively recently backported so it's not ancient nonsense
514 2021-03-09T21:49:40  *** smctwo <smctwo!~smctwo@> has quit IRC (Remote host closed the connection)
515 2021-03-09T21:50:00  <sipa> 0.14 iirc
516 2021-03-09T21:50:10  *** smctwo <smctwo!~smctwo@> has joined #bitcoin-core-dev
517 2021-03-09T21:50:33  <aj> phantomcircuit: (nuanced, not nuisanced :)
518 2021-03-09T21:50:47  <aj> header polling sure sounds better than perma-latching !IBD to me?
519 2021-03-09T21:51:30  <sipa> phantomcircuit: given that the dont-ask-headers-from-everyone is purely a bandwidth-preservation heuristic, i think it makes perfect sense to disable/weaken it in cases where we're worrying about being unable to sync
520 2021-03-09T21:52:11  <jnewbery> it's really difficult to follow the PR to be honest. I
521 2021-03-09T21:52:19  <jnewbery> I'm not surprised that people are confused
522 2021-03-09T21:52:35  <sipa> ignore the code in the PR, it's just the discussion there that matters
523 2021-03-09T21:52:39  <jnewbery> there seem to have been several different approaches, and then comments left and later deleted
524 2021-03-09T21:52:43  <sipa> the code will be very different once it's hammered out
525 2021-03-09T21:53:55  <sipa> phantomcircuit, sdaftuar: would it be possible to just post a summary/update of your understanding of what should be addressed?
526 2021-03-09T21:54:49  <jnewbery> that seems like a sensible next step
527 2021-03-09T21:55:03  <sipa> because it seems there has been some progress on IRC that's not mentioned there
528 2021-03-09T21:55:09  *** smctwo <smctwo!~smctwo@> has quit IRC (Ping timeout: 264 seconds)
529 2021-03-09T21:55:56  <phantomcircuit> aj, English is hard
530 2021-03-09T21:56:21  <aj> phantomcircuit: nuance is often a nuisance, to be fair
531 2021-03-09T21:56:22  <sipa> but in any case, if there's reasonable evidence that all we need to do is making headers syncing less restrictive, i think weakening just that in case we haven't found new headers in a while seems like a reasonable approach
532 2021-03-09T21:56:42  <phantomcircuit> sipa, it's a little confusing, since there's a bunch of things that are potentially separately contributing to the issue
533 2021-03-09T21:56:44  <sipa> aj: that's a pretty unnuanced statement
534 2021-03-09T21:57:39  <jnewbery> ok, anyone have any final updates before we close the meeting?
535 2021-03-09T21:57:57  <phantomcircuit> sipa, i think relaxing the headers sync peer selection combined with serving headers if we're past minwork would get us a long way, but we ban peers for sending headers which are below out minwork and the minwork goes up overtime, so old peers that are restarted could get banned
536 2021-03-09T21:59:01  <sipa> phantomcircuit: but the banning is only for headers pre-last-checkpoint, which is ancient
537 2021-03-09T21:59:19  <sipa> and if clients are introduce a new checkpoint that'd need huge scrutiny anyway
538 2021-03-09T22:00:24  <sipa> so maybe that's not crazy to assume that any minpeerwork is going to be past any-reasonable-client's checkpoints
539 2021-03-09T22:00:43  <jnewbery> #endmeeting
540 2021-03-09T22:00:44  <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
541 2021-03-09T22:00:44  <core-meetingbot> Meeting ended Tue Mar  9 22:00:43 2021 UTC.
542 2021-03-09T22:00:44  <core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-03-09-21.00.moin.txt
543 2021-03-09T22:02:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
544 2021-03-09T22:02:44  <bitcoin-git> [bitcoin] hebasto opened pull request #21400: build, qt: Fix regression introduced in #21363 (master...210309-regression) https://github.com/bitcoin/bitcoin/pull/21400
545 2021-03-09T22:02:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
546 2021-03-09T22:05:14  <aj> ariard: you have no way of knowing you're a block-relay-only peer, apart from me setting fRelay=false
547 2021-03-09T22:07:28  <aj> ariard: (which could also mean i'm running with -blocksonly=true and, if you sent NODE_BLOOM, that i want to do bloom stuf later)
548 2021-03-09T22:08:16  <phantomcircuit> sipa, right so that's less dangerous
549 2021-03-09T22:11:56  *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
550 2021-03-09T22:15:25  *** stortz <stortz!c8b9cbcf@> has quit IRC (Quit: Connection closed)
551 2021-03-09T22:19:27  <sdaftuar> sorry i missed most of the meeting, had to step away
552 2021-03-09T22:19:35  <sdaftuar> phantomcircuit: headers sync is insufficient to solve the problem
553 2021-03-09T22:20:24  <sdaftuar> the biggest issue is that we don't call FindNextBlocksToDownload on inbound peers if we have outbound peers and we're in IBD
554 2021-03-09T22:21:20  <sdaftuar> if we relaxed that, i believe it would completely solve the problem. the issue you spotted with compact blocks shoulnd't be relevant, because we don't send a peer a block announcement via compact block unless they ask for it
555 2021-03-09T22:21:29  <sdaftuar> and we don't turn on compact block announcements on any of our peers until we're out of IBD
556 2021-03-09T22:22:23  <sdaftuar> that said, we could also loosen up headers sync with inbound peers anyway (in my model of how we get out of a situation like this, you have to wait for a block to be found; by syncing with inbound peers more aggressively than we do now you could shorten that window)
557 2021-03-09T22:22:44  <sdaftuar> but it's not enough to just treat this as a headers sync issue -- we have to fix the block fetching
558 2021-03-09T22:22:46  *** ogo <ogo!~ogo@gateway/tor-sasl/ogo> has quit IRC (Ping timeout: 268 seconds)
559 2021-03-09T22:38:00  *** ogo <ogo!~ogo@gateway/tor-sasl/ogo> has joined #bitcoin-core-dev
560 2021-03-09T22:51:21  <lightlike> aj: "you have no way of knowing you're a block-relay-only peer (...)" - wouldn't we still send FEEFILTER while running -blocksonly=true, but never on a block-relay-only connection (because m_tx_relay==null)?
561 2021-03-09T23:04:36  <phantomcircuit> sdaftuar, that's probably *also* something that's wrong, but what i see is that you can't get the headers first anyways
562 2021-03-09T23:05:58  *** scedastik <scedastik!~scedastik@c-68-58-168-96.hsd1.mi.comcast.net> has quit IRC (Quit: scedastik)
563 2021-03-09T23:16:02  <sdaftuar> phantomcircuit: do you have a mechanism for how a compact block could be delivered when headers haven't yet synced?
564 2021-03-09T23:16:11  <sdaftuar> (and while the node is in ibd)
565 2021-03-09T23:16:47  <phantomcircuit> sdaftuar, i meant the headers sync is broken in the other way
566 2021-03-09T23:17:32  <phantomcircuit> this is why it's so confusing, there's a bunch of different things which when in ibd might be the issue, but the only one i could observe is that no peer i could connect to and asked would give me headers
567 2021-03-09T23:19:35  <sdaftuar> my understanding is that at some point after an inbound peer connects to you (while you're in ibd), it should announce a new block
568 2021-03-09T23:19:47  <sdaftuar> at that point, that announcement will have to be via INV, and it will trigger headers sync
569 2021-03-09T23:20:07  <sdaftuar> however, due to the block fetching being broken as i described before, you'll be in the stuck state you observed
570 2021-03-09T23:20:28  <sdaftuar> i can't see a way for compact block relay to even start until you leave IBD so i think that's a completely separate issue
571 2021-03-09T23:21:56  <sdaftuar> of course if no blocks are found after that peer connects, then indeed you would never even get the chain they have
572 2021-03-09T23:22:35  <sdaftuar> but i don't think that's the root issue here?  you're concerned with inbound peers being your only bridge to the honest network, and making sure you eventually sync, i think
573 2021-03-09T23:33:41  <phantomcircuit> sdaftuar, right the gets to the other issue that i forgot about, we don't announce our address while in ibd, so starting a new listening peer you won't get inbound connections anyways
574 2021-03-09T23:33:46  <phantomcircuit> i forgot about that one
575 2021-03-09T23:34:35  <sdaftuar> don't we immediately push our address to our outbound peers when we initiate a connection, right at the end of ver/verack?
576 2021-03-09T23:35:41  <sdaftuar> oh, that is gated on IBD, i see
577 2021-03-09T23:36:00  <sdaftuar> still i don't think that's really a relevant concern here. we're just trying to make block sync work from an inbound peer i think?
578 2021-03-09T23:38:34  <sdaftuar> we could probably get rid of the addr relay gating stuff. i think the motivation is that we don't want peers to connect to us if we can't help them sync blocks, but given that good addr propagation takes much longer than block sync should, we should probably just announce our address always i think
579 2021-03-09T23:38:37  *** morcos <morcos!~morcos@gateway/tor-sasl/morcos> has quit IRC (Ping timeout: 268 seconds)
580 2021-03-09T23:39:27  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has quit IRC (Remote host closed the connection)
581 2021-03-09T23:39:43  <sdaftuar> i think a long time ago a peer that never responded to headers and never provided blocks could dos a bitcoin core node, but now that we time out an outbound peer that doesn't sync headers with us when we're looking for headers, this shouldn't be a big concern
582 2021-03-09T23:44:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
583 2021-03-09T23:44:25  <bitcoin-git> [bitcoin] achow101 opened pull request #21401: Refactor versionbits deployments to avoid potential uninitialized variables (master...encap-vbits-params) https://github.com/bitcoin/bitcoin/pull/21401
584 2021-03-09T23:44:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
585 2021-03-09T23:44:52  *** morcos <morcos!~morcos@gateway/tor-sasl/morcos> has joined #bitcoin-core-dev
586 2021-03-09T23:45:56  <phantomcircuit> sdaftuar, possibly? im not sure if that was eclipse related maybe sipa knows
587 2021-03-09T23:46:30  *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has quit IRC (Ping timeout: 246 seconds)
588 2021-03-09T23:48:33  <phantomcircuit> sdaftuar, for sure you won't get any inbound until you have finished ibd though
589 2021-03-09T23:50:25  *** smctwo <smctwo!~smctwo@> has joined #bitcoin-core-dev
590 2021-03-09T23:50:28  *** smctwo <smctwo!~smctwo@> has quit IRC (Remote host closed the connection)
591 2021-03-09T23:50:58  *** smctwo <smctwo!~smctwo@> has joined #bitcoin-core-dev
592 2021-03-09T23:51:06  <sdaftuar> phantomcircuit: have i managed to convince you that block fetching is all that we need to fix?  if you have some scenario in mind where that would be insufficient, i'd like to try to understand what that is
593 2021-03-09T23:55:28  *** smctwo <smctwo!~smctwo@> has quit IRC (Ping timeout: 245 seconds)
594 2021-03-09T23:55:40  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev