1 2021-04-12T00:01:04  *** b10c <b10c!~b10c@static.> has quit IRC (Quit: ZNC 1.8.1 - https://znc.in)
  2 2021-04-12T00:06:58  *** ishaqm <ishaqm!~ishaqm@host-92-30-116-245.as13285.net> has quit IRC (Remote host closed the connection)
  3 2021-04-12T00:11:15  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 250 seconds)
  4 2021-04-12T00:26:37  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
  5 2021-04-12T00:30:34  *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
  6 2021-04-12T00:51:04  *** IGHOR <IGHOR!~quassel@> has quit IRC (Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.)
  7 2021-04-12T00:51:17  *** IGHOR <IGHOR!~quassel@> has joined #bitcoin-core-dev
  8 2021-04-12T01:09:31  *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has quit IRC (Quit: Find me in #TheHolyRoger or https://theholyroger.com)
  9 2021-04-12T01:10:22  *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has joined #bitcoin-core-dev
 10 2021-04-12T01:29:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 11 2021-04-12T01:29:05  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/0b9a046c1ae0...e358b43f7d89
 12 2021-04-12T01:29:06  <bitcoin-git> bitcoin/0.21 7de019b Andrew Chow: Introduce DeferringSignatureChecker and inherit with SignatureExtractor
 13 2021-04-12T01:29:07  <bitcoin-git> bitcoin/0.21 f79189c Andrew Chow: Test that signrawtx works when a signed CSV and CLTV inputs are present
 14 2021-04-12T01:29:08  <bitcoin-git> bitcoin/0.21 e358b43 fanquake: Merge #21640: [0.21] Introduce DeferredSignatureChecker and have Signature...
 15 2021-04-12T01:29:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 16 2021-04-12T01:29:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 17 2021-04-12T01:29:24  <bitcoin-git> [bitcoin] fanquake merged pull request #21640: [0.21] Introduce DeferredSignatureChecker and have SignatureExtractorClass subclass it (0.21...0.21-sig-ext) https://github.com/bitcoin/bitcoin/pull/21640
 18 2021-04-12T01:29:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 19 2021-04-12T01:36:00  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 268 seconds)
 20 2021-04-12T01:45:25  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
 21 2021-04-12T01:45:56  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
 22 2021-04-12T01:52:12  <aj> "Canceled because of an ongoing incident!" well, that's a novel test result
 23 2021-04-12T02:07:33  <luke-jr> ?
 24 2021-04-12T02:21:17  *** stortz <stortz!c8b9c69a@unaffiliated/stortz> has joined #bitcoin-core-dev
 25 2021-04-12T02:22:34  *** jarthur <jarthur!~jarthur@cpe-70-114-198-37.austin.res.rr.com> has joined #bitcoin-core-dev
 26 2021-04-12T02:23:19  <jarthur> Am I a dummy? I configure with --enable-shared and still end up bitcoind being made dynamically linked
 27 2021-04-12T02:24:15  <sipa> shared means dynamically linked
 28 2021-04-12T02:24:23  <sipa> no?
 29 2021-04-12T02:24:37  <jarthur> Yes, sorry, sipa. I meant --enable-static :)
 30 2021-04-12T02:24:43  <jarthur> same problem
 31 2021-04-12T02:25:18  <sipa> is everything dynamically linked, or just system libraries?
 32 2021-04-12T02:25:25  <sipa> because iirc those can't be statically linked
 33 2021-04-12T02:26:07  <jarthur> According to ldd, I see libpthread, libboost*, libevent, libc all dynamically linked
 34 2021-04-12T02:26:58  <jarthur> Is there a bug open for the issue?
 35 2021-04-12T02:27:32  <sipa> tbh, i have no idea what --enable-shared and --enable-static are supposed to do
 36 2021-04-12T02:27:57  <sipa> i just vaguely recall it was a bit more complicated than that to get the static binaries we build for releases
 37 2021-04-12T02:28:26  <jarthur> Maybe I don't either. jgarzik hinted it ought to do what I'm trying to do in this comment https://github.com/bitcoin/bitcoin/issues/3781#issuecomment-36507746
 38 2021-04-12T02:33:39  <luke-jr> afaik --enable-static/shared is all about what libraries we *produce*
 39 2021-04-12T02:34:09  <sipa> jarthur: i think you can safely ignore anything said about the build system over 7 years ago :)
 40 2021-04-12T02:34:15  <luke-jr> XD
 41 2021-04-12T02:34:43  <luke-jr> jarthur: do you actually have static libraries to use installed?
 42 2021-04-12T02:38:29  <jarthur> I believe so. I see a libca and using the Debian -dev packages for the deps.
 43 2021-04-12T02:38:34  <jarthur> *libc.a
 44 2021-04-12T02:47:48  <jarthur> I see other projects have added a custom --enable-static-exec or --fully-static ./configure args, so maybe --enable-static means you only get static libbitcoin and libtest. Also tried adding --disable-shared without luck. I'll see if I can whip something up from older gitian when it built a static bitcoin core distributable.
 45 2021-04-12T02:48:12  <jarthur> My use case is tinier and more secure bitcoind Linux container images.
 46 2021-04-12T02:48:52  <sipa> can't you use the release binaries?
 47 2021-04-12T02:48:57  <sipa> they're statically linked
 48 2021-04-12T02:49:11  <jarthur> Including glibc?
 49 2021-04-12T02:49:55  <luke-jr> glibc doesn't support static linking…?
 50 2021-04-12T02:49:59  <sipa> i don't think so; i'm not sure that you can
 51 2021-04-12T02:50:39  <luke-jr> jarthur: static linking isn't more secure (nor tinier if you have more than one binary)
 52 2021-04-12T02:51:18  <luke-jr> the only real use case for it, is portability, and apparently that's defeated by us using Boost anyway :/
 53 2021-04-12T02:51:49  <sipa> we're pretty close to only having compile-tike boost dependencies
 54 2021-04-12T02:52:24  <jarthur> The idea is to remove bash and other distribution toolchain from the container's execution environment so that say a buffer overflow exploit has less toolchain available for further exploitation.
 55 2021-04-12T02:52:28  <luke-jr> sipa: that doesn't help
 56 2021-04-12T02:52:47  <luke-jr> sipa: boost compiles to code that only promises to work on the system that compiled it
 57 2021-04-12T02:53:03  <luke-jr> jarthur: sure, but that's not related to static linking
 58 2021-04-12T02:54:16  <luke-jr> sipa: and not even then sometimes ☺ (when I encountered this, the bitcoind was built on the same machine it was broken on!)
 59 2021-04-12T02:54:23  <sipa> luke-jr: the statx call thing?
 60 2021-04-12T02:54:26  <jarthur> luke-jr it is if it's my path to that execution environment, e.g. docker's scratch layer giving you pretty much just kernel->bitcoind in the execution environment. I'm definitely open to other ideas you have for getting there.
 61 2021-04-12T02:54:26  <luke-jr> yeah
 62 2021-04-12T02:55:20  <sipa> jarthur: you should just use release binaries
 63 2021-04-12T02:55:34  <luke-jr> (^ and build those yourself)
 64 2021-04-12T02:55:47  <sipa> luke-jr: that seems to be a pretty isolated case, imo
 65 2021-04-12T02:56:10  <sipa> (and specific to the filesystem library, which we'll droo)
 66 2021-04-12T02:56:29  <luke-jr> sipa: apparently other people with the issue are encountering it trying to run things in Docker
 67 2021-04-12T02:56:37  <luke-jr> because older Docker doesn't allow statx calls
 68 2021-04-12T02:57:19  <sipa> yeah, it's pretty annoying
 69 2021-04-12T02:57:46  <luke-jr> or you meant the issue itself was isolate
 70 2021-04-12T02:57:53  <sipa> but also, at leasst this specific case (statx) we'll get rid of by just dropping boost filesystem
 71 2021-04-12T02:58:06  <luke-jr> the scary thing is, I'm not sure we'd necessarily notice issues like this
 72 2021-04-12T02:58:25  <luke-jr> this time it happened to result in an exception that aborted early..
 73 2021-04-12T02:58:28  <sipa> well we'd presumably hear about stuff that doesn't work
 74 2021-04-12T02:58:34  <luke-jr> but who knows what other system calls missing might result in
 75 2021-04-12T02:58:49  <luke-jr> I'm glad we ban boost in consensus code :P
 76 2021-04-12T02:59:58  <sipa> are you sure stdc++ doesn't make similar assumptions? :)
 77 2021-04-12T03:00:07  <luke-jr> pretty sure
 78 2021-04-12T03:00:18  <sipa> yeah, i assume so.too
 79 2021-04-12T03:00:25  <sipa> but i don't actually know
 80 2021-04-12T03:00:46  <luke-jr> glibc at least actually insists you have a newer linux-headers than the kernel, in some cases
 81 2021-04-12T03:01:10  <luke-jr> as it doesn't have compile-time fallbacks, only runtime)(
 82 2021-04-12T03:01:46  <sipa> good
 83 2021-04-12T03:02:34  <luke-jr> the combination means that 2.6 system would have to switch to linux-headers-latest for glibc builds, and linux-headers-2.6.32 for boost builds >_<
 84 2021-04-12T03:02:53  <luke-jr> of course, 2.6 being as old as it is, my end conclusion was he's just gonna have to upgrade it :P
 85 2021-04-12T03:02:57  <luke-jr> one way or another
 86 2021-04-12T03:04:10  *** lord__ <lord__!~lord@c-66-229-1-22.hsd1.fl.comcast.net> has joined #bitcoin-core-dev
 87 2021-04-12T03:04:23  <sipa> statx was introduced in linux 4.11, which is from 2017
 88 2021-04-12T03:04:27  <sipa> that's not very old
 89 2021-04-12T03:05:11  *** lord_ <lord_!~lord@c-66-229-1-22.hsd1.fl.comcast.net> has quit IRC (Ping timeout: 240 seconds)
 90 2021-04-12T03:05:20  <luke-jr> hmm
 91 2021-04-12T03:05:35  <luke-jr> I think glibc allows linux-headers back to 3.2
 92 2021-04-12T03:06:07  <sipa> that's from 2012
 93 2021-04-12T03:08:56  <luke-jr> kinda sad there isn't really a comparable solution in 2021 (for Linux containers)
 94 2021-04-12T03:11:49  <jarthur> Just tried the release binary, is dynamically linked to libc unfortunately. It looks like it stopped being fully static after this: https://github.com/bitcoin/bitcoin/pull/4042
 95 2021-04-12T03:12:08  <sipa> jarthur: glibc doesn't support linking statically
 96 2021-04-12T03:12:26  <sipa> (you can make it work apparently, but it's very discouraged)
 97 2021-04-12T03:13:59  <sipa> why do you insist on statically linked libc?
 98 2021-04-12T03:14:54  <sipa> the release binaries are intended to work on fairly ancient libc versions, fwiw; way older than the ones of the system it's built on
 99 2021-04-12T03:18:41  <luke-jr> (not that you'd want to use an obsolete glibc)
100 2021-04-12T03:18:44  <jarthur> Minimal docker image without distro toolchain, or any part of the FHS file system really. It's not the end of the world if I have to include a copy of libc in the image, just would rather not. It's a common practice for small programs. I'm trying to apply it to bitcoind. The fact that fully static bitcoind binaries used to be distributed gave me hope it might be simple
101 2021-04-12T03:19:11  <sipa> oh i see
102 2021-04-12T03:19:38  <luke-jr> afaik we've always had to dynamic link to glibc?
103 2021-04-12T03:19:53  <sipa> there was some disgussion of playing around with uclibc or some other more minimalistic libc, which would allow that
104 2021-04-12T03:20:09  <sipa> right now, i wouldn't recommend straying from dynamic glibc
105 2021-04-12T03:22:10  <sipa> luke-jr: the commit jarthur linked to earlier apparently reverted an earlier commit that made release binaries fully static
106 2021-04-12T03:22:19  <sipa> but i don't know if that was ever used in a release
107 2021-04-12T03:23:04  *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
108 2021-04-12T03:26:07  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 265 seconds)
109 2021-04-12T03:30:41  <jarthur> I believe 0.9.1 and possibly 0.9.2 distributables had binaries with statically linked glibc. Can't check now though as bitcoin.org took them down for security reasons.
110 2021-04-12T03:32:17  <aj> jarthur: https://bitcoin.org/bin/insecure/bitcoin-core-0.9.1/ ?
111 2021-04-12T03:32:36  <jarthur> ty :)
112 2021-04-12T03:38:55  <jarthur> Looks like it was only Bitcoin Core 0.9.1     $file bitcoin-0.9.1-linux/bin/64/bitcoind.static
113 2021-04-12T03:38:55  <jarthur> bitcoin-0.9.1-linux/bin/64/bitcoind.static: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, for GNU/Linux 2.6.24, BuildID[sha1]=8b02de16c470e9de817d6c551325517d2ad16a05, stripped
114 2021-04-12T03:41:39  <jarthur> Is the biggest risk to issues stemming from kernel compatibility (and licensing if you distribute the binary outside of LGPL)? IMO you're already taking the kernel compatibility risk with shared glibc in your container image.
115 2021-04-12T03:42:54  <aj> if you statically link glibc then use it against a different version of the nss libraries (i think?) it fails; kernel licensing isn't an issue afaik
116 2021-04-12T03:50:17  <luke-jr> yeah, Linux's syscall interface is widely recognised as not considered a derivative work thus immune to GPL
117 2021-04-12T03:58:51  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
118 2021-04-12T04:02:22  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 265 seconds)
119 2021-04-12T04:02:59  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
120 2021-04-12T04:05:11  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
121 2021-04-12T04:05:24  <jarthur> aj I think the issues are with glibc licensing and not kernel licensing since you will technically be distributing glibc if you distribute your binary.
122 2021-04-12T04:15:12  *** S3RK_ <S3RK_!~S3RK@> has joined #bitcoin-core-dev
123 2021-04-12T04:15:13  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
124 2021-04-12T04:18:33  *** ensign <ensign!~ensign@integer.musalbas.com> has joined #bitcoin-core-dev
125 2021-04-12T04:19:12  *** wraithm_ <wraithm_!~wraithm@unaffiliated/wraithm> has joined #bitcoin-core-dev
126 2021-04-12T04:20:26  *** vadorovsky <vadorovsky!vadorovsky@gateway/shell/matrix.org/x-xnqyckauwgyqsnqb> has quit IRC (*.net *.split)
127 2021-04-12T04:20:26  *** SebastianNoelLbk <SebastianNoelLbk!sebasti49@gateway/shell/matrix.org/x-ublzcsqivnnxmfqo> has quit IRC (*.net *.split)
128 2021-04-12T04:20:27  *** Matcha4You[m] <Matcha4You[m]!matcha4you@gateway/shell/matrix.org/x-npyqwlmvydoetzdr> has quit IRC (*.net *.split)
129 2021-04-12T04:20:27  *** robert_spigler <robert_spigler!robertspig@gateway/shell/matrix.org/x-rhfptrmqzzhqagxv> has quit IRC (*.net *.split)
130 2021-04-12T04:20:27  *** Thomas[m]1 <Thomas[m]1!thomaseizi@gateway/shell/matrix.org/x-uwowawyniplcweyo> has quit IRC (*.net *.split)
131 2021-04-12T04:20:28  *** wraithm <wraithm!~wraithm@unaffiliated/wraithm> has quit IRC (*.net *.split)
132 2021-04-12T04:20:28  *** S3RK <S3RK!~S3RK@> has quit IRC (*.net *.split)
133 2021-04-12T04:20:28  *** ensign_ <ensign_!~ensign@integer.musalbas.com> has quit IRC (*.net *.split)
134 2021-04-12T04:23:15  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
135 2021-04-12T04:29:50  <luke-jr> true
136 2021-04-12T04:30:21  <luke-jr> afaik it doesn't add any restrictions over Qt tho
137 2021-04-12T04:30:34  *** lord__ <lord__!~lord@c-66-229-1-22.hsd1.fl.comcast.net> has quit IRC (Ping timeout: 252 seconds)
138 2021-04-12T04:39:09  *** robert_spigler <robert_spigler!robertspig@gateway/shell/matrix.org/x-kdqesaisvohrrlje> has joined #bitcoin-core-dev
139 2021-04-12T04:39:30  *** Matcha4You[m] <Matcha4You[m]!matcha4you@gateway/shell/matrix.org/x-czzxnyawnipemgdn> has joined #bitcoin-core-dev
140 2021-04-12T04:39:46  *** SebastianNoelLbk <SebastianNoelLbk!sebasti49@gateway/shell/matrix.org/x-vqdcwyaxvuvxkokq> has joined #bitcoin-core-dev
141 2021-04-12T04:41:09  *** Thomas[m]1 <Thomas[m]1!thomaseizi@gateway/shell/matrix.org/x-klceovtmtfzbkrlc> has joined #bitcoin-core-dev
142 2021-04-12T04:42:34  *** vadorovsky <vadorovsky!vadorovsky@gateway/shell/matrix.org/x-ljkmfuicsrsqmcng> has joined #bitcoin-core-dev
143 2021-04-12T04:45:56  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
144 2021-04-12T04:46:21  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
145 2021-04-12T04:55:05  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 250 seconds)
146 2021-04-12T05:13:09  *** awesome_doge1 <awesome_doge1!~Thunderbi@1-162-98-122.dynamic-ip.hinet.net> has joined #bitcoin-core-dev
147 2021-04-12T05:31:15  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
148 2021-04-12T05:31:40  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
149 2021-04-12T05:52:33  *** smartineng <smartineng!~Icedove@> has joined #bitcoin-core-dev
150 2021-04-12T05:52:36  *** smartineng <smartineng!~Icedove@> has quit IRC (Excess Flood)
151 2021-04-12T05:53:33  *** smartineng <smartineng!~Icedove@> has joined #bitcoin-core-dev
152 2021-04-12T06:08:48  *** awesome_doge1 <awesome_doge1!~Thunderbi@1-162-98-122.dynamic-ip.hinet.net> has quit IRC (Ping timeout: 252 seconds)
153 2021-04-12T06:14:55  *** sujaykumar <sujaykumar!6ad7eace@> has joined #bitcoin-core-dev
154 2021-04-12T06:15:37  *** sujaykumar <sujaykumar!6ad7eace@> has quit IRC (Client Quit)
155 2021-04-12T06:18:32  *** jungly <jungly!~jungly@host-212-171-242-56.retail.telecomitalia.it> has joined #bitcoin-core-dev
156 2021-04-12T06:21:00  *** b10c <b10c!~b10c@static.> has joined #bitcoin-core-dev
157 2021-04-12T06:21:55  *** jadi <jadi!~jadi@> has joined #bitcoin-core-dev
158 2021-04-12T06:35:25  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@d5152f744.static.telenet.be> has quit IRC (Ping timeout: 252 seconds)
159 2021-04-12T06:39:09  *** dviola <dviola!~diego@unaffiliated/dviola> has quit IRC (Quit: WeeChat 3.1)
160 2021-04-12T06:55:51  <instagibbs> someone ban chew917 here https://github.com/bitcoin/bitcoin/pull/21464
161 2021-04-12T06:55:56  <instagibbs> thanks
162 2021-04-12T07:16:06  *** jespada <jespada!~jespada@> has joined #bitcoin-core-dev
163 2021-04-12T07:25:57  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
164 2021-04-12T07:33:31  *** stortz <stortz!c8b9c69a@unaffiliated/stortz> has quit IRC (Quit: Connection closed)
165 2021-04-12T07:34:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
166 2021-04-12T07:34:03  <bitcoin-git> [bitcoin] hebasto closed pull request #21591: build, qt: Fix wrong cross-compiling detection on macOS (master...210403-cross) https://github.com/bitcoin/bitcoin/pull/21591
167 2021-04-12T07:34:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
168 2021-04-12T07:34:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
169 2021-04-12T07:34:22  <bitcoin-git> [bitcoin] hebasto reopened pull request #21591: build, qt: Fix wrong cross-compiling detection on macOS (master...210403-cross) https://github.com/bitcoin/bitcoin/pull/21591
170 2021-04-12T07:34:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
171 2021-04-12T07:40:57  *** dviola <dviola!~diego@unaffiliated/dviola> has joined #bitcoin-core-dev
172 2021-04-12T07:59:16  *** michagogo_ is now known as michagogo
173 2021-04-12T08:13:11  *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f169100afc5d2b75216b381.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
174 2021-04-12T08:13:11  *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f169100afc5d2b75216b381.dip0.t-ipconnect.de> has quit IRC (Remote host closed the connection)
175 2021-04-12T08:13:30  *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f169100afc5d2b75216b381.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
176 2021-04-12T08:13:35  *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
177 2021-04-12T08:13:58  *** shesek <shesek!~shesek@unaffiliated/shesek> has joined #bitcoin-core-dev
178 2021-04-12T08:28:17  *** jarthur <jarthur!~jarthur@cpe-70-114-198-37.austin.res.rr.com> has quit IRC (Quit: jarthur)
179 2021-04-12T08:29:23  *** ishaqm <ishaqm!~ishaqm@host-92-30-116-245.as13285.net> has joined #bitcoin-core-dev
180 2021-04-12T08:30:39  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
181 2021-04-12T08:57:58  *** nz <nz!d25601ef@210-86-1-239.adsl.xtra.co.nz> has joined #bitcoin-core-dev
182 2021-04-12T08:58:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
183 2021-04-12T08:58:59  <bitcoin-git> [bitcoin] fanquake closed pull request #19242: Add -uaappend option to append a literal string to user agent (master...uaappend) https://github.com/bitcoin/bitcoin/pull/19242
184 2021-04-12T08:59:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
185 2021-04-12T08:59:43  *** nz <nz!d25601ef@210-86-1-239.adsl.xtra.co.nz> has quit IRC (Client Quit)
186 2021-04-12T09:35:06  *** worc3131 <worc3131!~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20> has joined #bitcoin-core-dev
187 2021-04-12T10:16:52  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has quit IRC (Remote host closed the connection)
188 2021-04-12T10:17:11  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has joined #bitcoin-core-dev
189 2021-04-12T10:18:41  *** Monica59Wintheis <Monica59Wintheis!~Monica59W@static.> has joined #bitcoin-core-dev
190 2021-04-12T10:23:38  <wumpus> instagibbs: done
191 2021-04-12T10:26:23  *** worc3131 <worc3131!~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20> has quit IRC (Ping timeout: 260 seconds)
192 2021-04-12T10:27:16  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@d5152f744.static.telenet.be> has joined #bitcoin-core-dev
193 2021-04-12T10:30:58  *** Monica59Wintheis <Monica59Wintheis!~Monica59W@static.> has quit IRC (Ping timeout: 265 seconds)
194 2021-04-12T11:03:09  *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
195 2021-04-12T11:04:57  *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
196 2021-04-12T11:35:01  *** _kiara <_kiara!4fb7cf25@bzq-79-183-207-37.red.bezeqint.net> has joined #bitcoin-core-dev
197 2021-04-12T11:46:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
198 2021-04-12T11:46:04  <bitcoin-git> [bitcoin] AlbanAndrieu closed pull request #21646: -daemonwait change to -daemon (master...master) https://github.com/bitcoin/bitcoin/pull/21646
199 2021-04-12T11:46:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
200 2021-04-12T11:57:02  *** _kiara <_kiara!4fb7cf25@bzq-79-183-207-37.red.bezeqint.net> has quit IRC (Ping timeout: 240 seconds)
201 2021-04-12T11:59:15  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
202 2021-04-12T12:02:40  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 252 seconds)
203 2021-04-12T12:09:23  *** belcher_ is now known as belcher
204 2021-04-12T12:33:28  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
205 2021-04-12T12:40:06  *** biteskola <biteskola!~biteskola@> has joined #bitcoin-core-dev
206 2021-04-12T12:45:12  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
207 2021-04-12T12:45:57  *** rny <rny!~rny@gateway/tor-sasl/renlord> has quit IRC (Ping timeout: 240 seconds)
208 2021-04-12T12:46:12  *** rny <rny!~rny@gateway/tor-sasl/renlord> has joined #bitcoin-core-dev
209 2021-04-12T12:46:25  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 260 seconds)
210 2021-04-12T12:59:51  *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has quit IRC (Read error: Connection reset by peer)
211 2021-04-12T13:03:37  *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has joined #bitcoin-core-dev
212 2021-04-12T13:19:07  *** jungly <jungly!~jungly@host-212-171-242-56.retail.telecomitalia.it> has quit IRC (Ping timeout: 252 seconds)
213 2021-04-12T13:33:33  *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
214 2021-04-12T13:34:40  *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
215 2021-04-12T13:37:27  *** EricYuzo <EricYuzo!~EricYuzo@> has joined #bitcoin-core-dev
216 2021-04-12T13:39:57  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
217 2021-04-12T13:40:57  *** jungly <jungly!~jungly@host-79-55-175-219.retail.telecomitalia.it> has joined #bitcoin-core-dev
218 2021-04-12T13:44:17  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 268 seconds)
219 2021-04-12T13:51:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
220 2021-04-12T13:51:59  <bitcoin-git> [bitcoin] vasild opened pull request #21659: net: flag relevant Sock methods with [[nodiscard]] (master...Sock_nodiscard) https://github.com/bitcoin/bitcoin/pull/21659
221 2021-04-12T13:52:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
222 2021-04-12T13:57:37  *** moorcock75 <moorcock75!~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr> has quit IRC (Ping timeout: 252 seconds)
223 2021-04-12T13:59:26  *** niamh <niamh!~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr> has joined #bitcoin-core-dev
224 2021-04-12T14:02:46  *** tlev <tlev!~tlev@li120-195.members.linode.com> has quit IRC (Quit: Ping timeout (120 seconds))
225 2021-04-12T14:03:01  *** tlev <tlev!~tlev@li120-195.members.linode.com> has joined #bitcoin-core-dev
226 2021-04-12T14:10:32  *** lord__ <lord__!~lord@c-66-229-1-22.hsd1.fl.comcast.net> has joined #bitcoin-core-dev
227 2021-04-12T14:14:17  *** jonatack <jonatack!jon@gateway/vpn/airvpn/jonatack> has quit IRC (Quit: jonatack)
228 2021-04-12T14:18:02  *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Remote host closed the connection)
229 2021-04-12T14:18:23  *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
230 2021-04-12T14:23:29  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
231 2021-04-12T14:23:59  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
232 2021-04-12T14:29:27  *** niamh <niamh!~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr> has quit IRC (Remote host closed the connection)
233 2021-04-12T14:29:35  *** niamh <niamh!~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr> has joined #bitcoin-core-dev
234 2021-04-12T14:30:52  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
235 2021-04-12T14:31:18  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
236 2021-04-12T14:31:53  *** jungly <jungly!~jungly@host-79-55-175-219.retail.telecomitalia.it> has quit IRC (Ping timeout: 240 seconds)
237 2021-04-12T14:32:48  *** jonatack <jonatack!jon@gateway/vpn/airvpn/jonatack> has joined #bitcoin-core-dev
238 2021-04-12T14:35:36  *** jungly <jungly!~jungly@host-95-248-128-191.retail.telecomitalia.it> has joined #bitcoin-core-dev
239 2021-04-12T14:36:41  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
240 2021-04-12T14:41:54  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
241 2021-04-12T14:48:59  *** niamh <niamh!~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr> has quit IRC (Ping timeout: 246 seconds)
242 2021-04-12T15:03:48  *** _kiara <_kiara!8de25c4d@> has joined #bitcoin-core-dev
243 2021-04-12T15:08:21  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
244 2021-04-12T15:11:18  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 265 seconds)
245 2021-04-12T15:21:37  *** niamh <niamh!~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr> has joined #bitcoin-core-dev
246 2021-04-12T15:28:45  *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
247 2021-04-12T15:34:36  *** EricYuzo <EricYuzo!~EricYuzo@> has quit IRC (Ping timeout: 260 seconds)
248 2021-04-12T15:38:32  *** niamh <niamh!~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr> has quit IRC (Ping timeout: 240 seconds)
249 2021-04-12T15:38:43  *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
250 2021-04-12T15:39:23  *** ogo <ogo!~ogo@gateway/tor-sasl/ogo> has quit IRC (Quit: Leaving)
251 2021-04-12T15:42:00  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
252 2021-04-12T15:45:39  *** _kiara <_kiara!8de25c4d@> has quit IRC (Quit: Connection closed)
253 2021-04-12T15:45:49  *** niamh <niamh!~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr> has joined #bitcoin-core-dev
254 2021-04-12T15:53:12  *** oniijin <oniijin!~oniijin@> has joined #bitcoin-core-dev
255 2021-04-12T15:53:38  *** biteskola <biteskola!~biteskola@> has quit IRC (Ping timeout: 240 seconds)
256 2021-04-12T15:55:36  *** jungly <jungly!~jungly@host-95-248-128-191.retail.telecomitalia.it> has quit IRC (Ping timeout: 260 seconds)
257 2021-04-12T16:00:07  *** jungly <jungly!~jungly@host-79-42-191-252.retail.telecomitalia.it> has joined #bitcoin-core-dev
258 2021-04-12T16:20:24  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 252 seconds)
259 2021-04-12T16:20:58  *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f169100afc5d2b75216b381.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
260 2021-04-12T16:23:44  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
261 2021-04-12T16:25:23  *** lightlike <lightlike!~lightlike@p200300c7ef0eeb0004db876bc89db2cc.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
262 2021-04-12T16:25:54  *** jadi <jadi!~jadi@> has quit IRC (Ping timeout: 252 seconds)
263 2021-04-12T16:55:11  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
264 2021-04-12T16:56:07  *** joerodgers <joerodgers!~joerodger@c-76-125-83-191.hsd1.ar.comcast.net> has quit IRC (Read error: Connection reset by peer)
265 2021-04-12T17:01:44  *** ogo <ogo!~ogo@gateway/tor-sasl/ogo> has joined #bitcoin-core-dev
266 2021-04-12T17:05:55  *** ogo <ogo!~ogo@gateway/tor-sasl/ogo> has quit IRC (Remote host closed the connection)
267 2021-04-12T17:06:14  *** ogo <ogo!~ogo@gateway/tor-sasl/ogo> has joined #bitcoin-core-dev
268 2021-04-12T17:09:34  *** _kiara <_kiara!8de25c4d@> has joined #bitcoin-core-dev
269 2021-04-12T17:13:55  *** lightlike <lightlike!~lightlike@p200300c7ef0eeb0004db876bc89db2cc.dip0.t-ipconnect.de> has quit IRC (Ping timeout: 250 seconds)
270 2021-04-12T17:20:28  *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Read error: Connection reset by peer)
271 2021-04-12T17:24:21  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
272 2021-04-12T17:24:43  *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
273 2021-04-12T17:32:06  *** dgenr8 <dgenr8!~dgenr8@unaffiliated/dgenr8> has joined #bitcoin-core-dev
274 2021-04-12T17:34:06  *** dgenr8 <dgenr8!~dgenr8@unaffiliated/dgenr8> has quit IRC (Client Quit)
275 2021-04-12T17:36:31  *** jungly <jungly!~jungly@host-79-42-191-252.retail.telecomitalia.it> has quit IRC (Ping timeout: 252 seconds)
276 2021-04-12T17:37:35  *** oozebrood <oozebrood!~oozebrood@bishop.xerrero.com> has quit IRC (Quit: ZNC - https://znc.in)
277 2021-04-12T17:38:36  *** oozebrood <oozebrood!~oozebrood@bishop.xerrero.com> has joined #bitcoin-core-dev
278 2021-04-12T17:44:16  *** biteskola <biteskola!~biteskola@> has joined #bitcoin-core-dev
279 2021-04-12T17:54:18  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
280 2021-04-12T17:55:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
281 2021-04-12T17:55:39  <bitcoin-git> [bitcoin] Emzy opened pull request #21661: doc: Fix name of script guix-build (master...patch-2) https://github.com/bitcoin/bitcoin/pull/21661
282 2021-04-12T17:55:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
283 2021-04-12T17:58:32  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 265 seconds)
284 2021-04-12T17:59:52  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
285 2021-04-12T18:00:03  *** lightlike <lightlike!~lightlike@p200300c7ef0eeb003c5461af0b34e125.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
286 2021-04-12T18:00:56  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
287 2021-04-12T18:11:40  *** stortz <stortz!c8b9c69a@unaffiliated/stortz> has joined #bitcoin-core-dev
288 2021-04-12T18:13:41  *** ishaqm <ishaqm!~ishaqm@host-92-30-116-245.as13285.net> has quit IRC (Remote host closed the connection)
289 2021-04-12T18:15:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
290 2021-04-12T18:15:52  <bitcoin-git> [bitcoin] fdoving opened pull request #21662: build,boost: update download url. (master...fdov-boost-url) https://github.com/bitcoin/bitcoin/pull/21662
291 2021-04-12T18:15:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
292 2021-04-12T18:27:32  *** vv8 <vv8!~egp_@128-71-69-136.broadband.corbina.ru> has quit IRC (Ping timeout: 265 seconds)
293 2021-04-12T18:31:53  *** moorcock75 <moorcock75!~niamh@> has joined #bitcoin-core-dev
294 2021-04-12T18:34:11  *** niamh <niamh!~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr> has quit IRC (Ping timeout: 240 seconds)
295 2021-04-12T18:34:46  *** mars <mars!~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr> has joined #bitcoin-core-dev
296 2021-04-12T18:37:13  *** moorcock75 <moorcock75!~niamh@> has quit IRC (Ping timeout: 240 seconds)
297 2021-04-12T18:56:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
298 2021-04-12T18:57:00  <bitcoin-git> [bitcoin] hebasto opened pull request #21663: ci: Fix macOS brew install command (master...210412-brew) https://github.com/bitcoin/bitcoin/pull/21663
299 2021-04-12T18:57:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
300 2021-04-12T18:59:59  *** human01 <human01!4f8299de@athedsl-4401646.home.otenet.gr> has joined #bitcoin-core-dev
301 2021-04-12T19:01:10  *** jungly <jungly!~jungly@host-79-42-191-252.retail.telecomitalia.it> has joined #bitcoin-core-dev
302 2021-04-12T19:01:19  *** jorts is now known as nckx
303 2021-04-12T19:02:03  *** rny <rny!~rny@gateway/tor-sasl/renlord> has quit IRC (Remote host closed the connection)
304 2021-04-12T19:03:47  *** rny <rny!~rny@gateway/tor-sasl/renlord> has joined #bitcoin-core-dev
305 2021-04-12T19:09:55  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
306 2021-04-12T19:13:39  <wumpus> we really need to fix the CI it's failling on almost everything
307 2021-04-12T19:14:31  <wumpus> oh something with macos, looks like there is a PR for it #21663
308 2021-04-12T19:14:33  <gribble> https://github.com/bitcoin/bitcoin/issues/21663 | ci: Fix macOS brew install command by hebasto · Pull Request #21663 · bitcoin/bitcoin · GitHub
309 2021-04-12T19:15:35  <jakesyl> Anyone have any idea why a transaction version would be negative? https://github.com/btcsuite/btcd/pull/1701#issuecomment-817995493
310 2021-04-12T19:19:03  *** stortz <stortz!c8b9c69a@unaffiliated/stortz> has quit IRC (Quit: Connection closed)
311 2021-04-12T19:19:17  <sipa> jakesyl: it's a number, it can be anything
312 2021-04-12T19:19:26  <sipa> probably just someone playing around
313 2021-04-12T19:19:27  <luke-jr> jakesyl: see BIP 68
314 2021-04-12T19:19:41  <hebasto> wumpus: yeah, 21663 fixed brew, but ci log shows ridiculous configure failure
315 2021-04-12T19:20:11  <luke-jr> ie, it's not really signed
316 2021-04-12T19:20:21  * luke-jr wonders if there's anything that *does* treat it as signed
317 2021-04-12T19:21:11  <sipa> luke-jr: BIP68 treats it as signed, afaik
318 2021-04-12T19:21:27  <luke-jr> sipa: it explicitly doesn't…?
319 2021-04-12T19:21:28  <hebasto> wumpus: probably, it is related to new Autoconf 2.71
320 2021-04-12T19:21:46  <sipa> luke-jr: you are right
321 2021-04-12T19:21:58  <sipa> luke-jr: standardness rules may treat it as signed
322 2021-04-12T19:22:34  <luke-jr> src/policy/policy.cpp:    if (tx.nVersion > CTransaction::MAX_STANDARD_VERSION || tx.nVersion < 1) {
323 2021-04-12T19:22:41  *** jungly <jungly!~jungly@host-79-42-191-252.retail.telecomitalia.it> has quit IRC (Ping timeout: 240 seconds)
324 2021-04-12T19:22:49  <luke-jr> I'm not sure the sign matters for that
325 2021-04-12T19:23:04  <sipa> it does
326 2021-04-12T19:23:16  <luke-jr> how?
327 2021-04-12T19:23:34  <luke-jr> O.o even RPC treats it as unsigned: src/core_write.cpp:    entry.pushKV("version", static_cast<int64_t>(static_cast<uint32_t>(tx.nVersion)));
328 2021-04-12T19:23:36  <jakesyl> it looks like bip 68 casts nVersion to a uint32 (fEnforceBIP68)
329 2021-04-12T19:23:48  <sipa> luke-jr: nVersion is an int32_t
330 2021-04-12T19:24:20  <sipa> so if the serialization is 0xffffffff, it'd be interpreted as -1, and which be "< 1"
331 2021-04-12T19:24:44  <luke-jr> sipa: yes, but if it were interpreted as 0xffffffff it would be >CTransaction::MAX_STANDARD_VERSION
332 2021-04-12T19:24:54  <sipa> luke-jr: ah, good point!
333 2021-04-12T19:24:59  <sipa> indeed, it doesn't matter
334 2021-04-12T19:25:09  <sipa> at least with the current CTransaction::MAX_STANDARD_VERSION value
335 2021-04-12T19:25:16  <luke-jr> quickly glancing over the code, I think we treat it as unsigned everywhere XD
336 2021-04-12T19:25:34  <sipa> because the only two qualifying values are 1 and 2, and their serialization in signed and unsigned is identical
337 2021-04-12T19:25:35  <jakesyl> only exception I can think of *might* be the rpc interface
338 2021-04-12T19:25:54  <luke-jr> jakesyl: see above
339 2021-04-12T19:26:06  <sipa> i vaguely recall that the RPC interface was changed a few years ago, precisely because it's semantically unsigned everywhere already
340 2021-04-12T19:26:18  <sipa> but somehow didn't want to touch the actual data type for fear of consensus implications
341 2021-04-12T19:26:32  <jakesyl> oh read that wrong. Got it - thanks!
342 2021-04-12T19:26:42  <luke-jr> yeah, I'd want to do a lot more in-depth review before messing with it for that reason
343 2021-04-12T19:27:12  <jakesyl> yeah - on btcd think we'll just match the bitcoin-core rpc interface there
344 2021-04-12T19:27:12  <luke-jr> and frankly probably not worth it
345 2021-04-12T19:27:20  <sipa> but at least at first glance i agree that it most likely doesn't affect anything
346 2021-04-12T19:27:22  <jakesyl> (it's currently signed in our return)
347 2021-04-12T19:27:28  <luke-jr> but as far as documentation, IMO we should just say it's unsigned
348 2021-04-12T19:27:36  <sipa> yes, makes sense
349 2021-04-12T19:30:36  *** human01 <human01!4f8299de@athedsl-4401646.home.otenet.gr> has quit IRC (Quit: Connection closed)
350 2021-04-12T19:33:45  *** jungly <jungly!~jungly@host-79-42-191-252.retail.telecomitalia.it> has joined #bitcoin-core-dev
351 2021-04-12T19:35:14  *** smctwo <smctwo!~smctwo@bba597217.alshamil.net.ae> has quit IRC ()
352 2021-04-12T19:38:11  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
353 2021-04-12T19:45:40  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
354 2021-04-12T19:53:10  <jakesyl> oh interesting - btw  likely reason this is the first time we're seeing it (and it's on testnet) is b/c `IsStandardTx`isn't called w/ `-testnet`
355 2021-04-12T19:53:23  <sipa> yeah
356 2021-04-12T19:53:32  <sipa> you're unlikely to see that on mainnet
357 2021-04-12T19:57:43  *** _kiara <_kiara!8de25c4d@> has quit IRC (Ping timeout: 240 seconds)
358 2021-04-12T20:04:23  *** smartineng <smartineng!~Icedove@> has quit IRC (Quit: smartineng)
359 2021-04-12T20:06:23  *** meinwolf <meinwolf!~meinwolf@unaffiliated/meinwolf> has quit IRC (Remote host closed the connection)
360 2021-04-12T20:22:05  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
361 2021-04-12T20:22:45  <jamesob> Anyone seen these 403 forbidden errors during CI runs before? https://github.com/bitcoin/bitcoin/pull/21526/checks?check_run_id=2327358485
362 2021-04-12T20:25:06  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 260 seconds)
363 2021-04-12T20:25:24  <luke-jr> only recently; but I didn't find a solution
364 2021-04-12T20:25:56  <wumpus> jamesob: yes, see #21663
365 2021-04-12T20:25:58  <gribble> https://github.com/bitcoin/bitcoin/issues/21663 | ci: Fix macOS brew install command by hebasto · Pull Request #21663 · bitcoin/bitcoin · GitHub
366 2021-04-12T20:26:13  <jamesob> wumpus: thanks
367 2021-04-12T20:27:46  <wumpus> we should merge that soon but first waiting for CI to be green
368 2021-04-12T20:29:18  <luke-jr> oh, that's the same one?
369 2021-04-12T20:31:11  *** biteskola <biteskola!~biteskola@> has quit IRC (Ping timeout: 240 seconds)
370 2021-04-12T20:36:36  <wumpus> i think so
371 2021-04-12T20:40:43  <jamesob> wumpus: I ACK'd only on the basis of the macOS CI run being green
372 2021-04-12T20:47:46  *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has quit IRC (Read error: Connection reset by peer)
373 2021-04-12T20:50:48  *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has joined #bitcoin-core-dev
374 2021-04-12T20:52:30  *** justan0theruser <justan0theruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
375 2021-04-12T20:54:31  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 260 seconds)
376 2021-04-12T21:00:46  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
377 2021-04-12T21:03:17  *** vv8 <vv8!~egp_@> has joined #bitcoin-core-dev
378 2021-04-12T21:17:38  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
379 2021-04-12T21:17:41  *** jungly <jungly!~jungly@host-79-42-191-252.retail.telecomitalia.it> has quit IRC (Ping timeout: 240 seconds)
380 2021-04-12T21:20:29  *** lightlike <lightlike!~lightlike@p200300c7ef0eeb003c5461af0b34e125.dip0.t-ipconnect.de> has quit IRC (Quit: Leaving)
381 2021-04-12T21:22:13  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
382 2021-04-12T21:23:52  *** vdero133[m] <vdero133[m]!vdero133ma@gateway/shell/matrix.org/x-duupsqvhcumjbhav> has joined #bitcoin-core-dev
383 2021-04-12T21:30:17  *** bclync <bclync!~bclync@89-73-214-104.dynamic.chello.pl> has joined #bitcoin-core-dev
384 2021-04-12T21:32:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
385 2021-04-12T21:32:39  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f6c44e999b7d...708517b2dd64
386 2021-04-12T21:32:39  <bitcoin-git> bitcoin/master b738155 Hennadii Stepanov: ci: Fix macOS brew install command
387 2021-04-12T21:32:40  <bitcoin-git> bitcoin/master 708517b W. J. van der Laan: Merge #21663: ci: Fix macOS brew install command
388 2021-04-12T21:32:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
389 2021-04-12T21:32:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
390 2021-04-12T21:32:58  <bitcoin-git> [bitcoin] laanwj merged pull request #21663: ci: Fix macOS brew install command (master...210412-brew) https://github.com/bitcoin/bitcoin/pull/21663
391 2021-04-12T21:33:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
392 2021-04-12T21:33:18  *** bclync <bclync!~bclync@89-73-214-104.dynamic.chello.pl> has quit IRC (Client Quit)
393 2021-04-12T21:44:57  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
394 2021-04-12T21:45:55  *** ovovo <ovovo!~ovovo@2a02:29b8:dc01:1881::2e> has joined #bitcoin-core-dev
395 2021-04-12T21:47:21  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 260 seconds)
396 2021-04-12T21:54:52  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
397 2021-04-12T21:57:55  *** jungly <jungly!~jungly@host-79-42-191-252.retail.telecomitalia.it> has joined #bitcoin-core-dev
398 2021-04-12T22:10:50  *** jungly <jungly!~jungly@host-79-42-191-252.retail.telecomitalia.it> has quit IRC (Ping timeout: 265 seconds)
399 2021-04-12T22:15:55  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 252 seconds)
400 2021-04-12T22:56:28  *** pncl <pncl!~pncl___@> has joined #bitcoin-core-dev
401 2021-04-12T22:56:43  *** pncl_ <pncl_!~pncl___@> has joined #bitcoin-core-dev
402 2021-04-12T23:14:58  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
403 2021-04-12T23:15:22  *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
404 2021-04-12T23:34:53  *** pncl <pncl!~pncl___@> has quit IRC (Ping timeout: 240 seconds)
405 2021-04-12T23:35:11  *** pncl_ <pncl_!~pncl___@> has quit IRC (Ping timeout: 240 seconds)
406 2021-04-12T23:42:45  *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
407 2021-04-12T23:44:36  *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
408 2021-04-12T23:57:04  *** IGHOR <IGHOR!~quassel@> has quit IRC (Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.)