12021-04-20T00:00:36 *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
22021-04-20T00:03:27 *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 268 seconds)
32021-04-20T00:12:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
42021-04-20T00:12:06 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/13d27b452d4b...67a359313f79
52021-04-20T00:12:07 <bitcoin-git> bitcoin/master f2f2541 Sebastian Falbesoner: remove executable flag for src/net_processing.cpp
62021-04-20T00:12:07 <bitcoin-git> bitcoin/master 67a3593 fanquake: Merge #21728: remove executable flag for src/net_processing.cpp
72021-04-20T00:12:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
82021-04-20T00:12:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
92021-04-20T00:12:26 <bitcoin-git> [bitcoin] fanquake merged pull request #21728: remove executable flag for src/net_processing.cpp (master...2021-remove-exec-flag-from-net_processing) https://github.com/bitcoin/bitcoin/pull/21728
102021-04-20T00:12:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
112021-04-20T00:12:56 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
122021-04-20T00:15:33 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
132021-04-20T00:18:21 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
142021-04-20T00:20:46 *** nibbier <nibbier!~quassel@mx01.geekbox.info> has quit IRC (Ping timeout: 252 seconds)
152021-04-20T00:24:16 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
162021-04-20T00:26:55 *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
172021-04-20T00:28:39 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
182021-04-20T00:28:46 *** belcher_ is now known as belcher
192021-04-20T00:28:52 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
202021-04-20T00:31:02 *** nibbier <nibbier!~quassel@mx01.geekbox.info> has joined #bitcoin-core-dev
212021-04-20T00:32:38 *** cguida <cguida!~Adium@2601:282:200:ae00:c0b3:1fe8:c368:43ba> has joined #bitcoin-core-dev
222021-04-20T00:43:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
232021-04-20T00:43:30 <bitcoin-git> [bitcoin] fanquake pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/67a359313f79...a839303edc8a
242021-04-20T00:43:31 <bitcoin-git> bitcoin/master 70cdf67 Kiminuo: Move StripRedundantLastElementsOfPath before ArgsManager class.
252021-04-20T00:43:31 <bitcoin-git> bitcoin/master 1add318 Kiminuo: Move GetDataDir(fNetSpecific) implementation to ArgsManager.
262021-04-20T00:43:32 <bitcoin-git> bitcoin/master 1cb52ba Kiminuo: Modify "util_datadir" unit test to not use gArgs.
272021-04-20T00:43:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
282021-04-20T00:43:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
292021-04-20T00:43:50 <bitcoin-git> [bitcoin] fanquake merged pull request #21244: Move GetDataDir to ArgsManager (master...feature/2021-02-get-data-dir-args) https://github.com/bitcoin/bitcoin/pull/21244
302021-04-20T00:43:52 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
312021-04-20T00:46:31 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
322021-04-20T00:46:53 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
332021-04-20T00:50:38 *** molz_ <molz_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
342021-04-20T00:53:46 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 252 seconds)
352021-04-20T00:58:58 *** cguida <cguida!~Adium@2601:282:200:ae00:c0b3:1fe8:c368:43ba> has quit IRC (Quit: Leaving.)
362021-04-20T01:02:35 *** OP_NOP <OP_NOP!OP_NOP@gateway/vpn/privateinternetaccess/opnop/x-41418994> has joined #bitcoin-core-dev
372021-04-20T01:02:50 *** cguida <cguida!~Adium@2601:282:200:ae00:c0b3:1fe8:c368:43ba> has joined #bitcoin-core-dev
382021-04-20T01:07:19 *** cguida <cguida!~Adium@2601:282:200:ae00:c0b3:1fe8:c368:43ba> has quit IRC (Ping timeout: 250 seconds)
392021-04-20T01:08:11 *** duringo <duringo!ad004d11@173.0.77.17> has joined #bitcoin-core-dev
402021-04-20T01:14:37 *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
412021-04-20T01:17:49 *** molz_ <molz_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 252 seconds)
422021-04-20T01:20:01 *** cguida <cguida!~Adium@2601:282:200:ae00:c0b3:1fe8:c368:43ba> has joined #bitcoin-core-dev
432021-04-20T01:24:40 *** cguida <cguida!~Adium@2601:282:200:ae00:c0b3:1fe8:c368:43ba> has quit IRC (Ping timeout: 258 seconds)
442021-04-20T01:24:58 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
452021-04-20T01:27:05 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 260 seconds)
462021-04-20T01:34:22 *** killerfox <killerfox!322f7246@50.47.114.70> has quit IRC (Ping timeout: 240 seconds)
472021-04-20T01:34:23 *** patriot2939 <patriot2939!~patriot29@unaffiliated/patriot2939> has quit IRC (Quit: Leaving)
482021-04-20T01:36:34 *** cguida <cguida!~Adium@2601:282:200:ae00:c0b3:1fe8:c368:43ba> has joined #bitcoin-core-dev
492021-04-20T01:41:07 *** cguida <cguida!~Adium@2601:282:200:ae00:c0b3:1fe8:c368:43ba> has quit IRC (Ping timeout: 250 seconds)
502021-04-20T01:41:10 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
512021-04-20T01:58:53 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 265 seconds)
522021-04-20T02:06:37 *** cguida <cguida!~Adium@2601:282:200:ae00:c0b3:1fe8:c368:43ba> has joined #bitcoin-core-dev
532021-04-20T02:10:28 *** proofofkeags <proofofkeags!~proofofke@97-118-239-55.hlrn.qwest.net> has joined #bitcoin-core-dev
542021-04-20T02:11:43 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 252 seconds)
552021-04-20T02:12:49 *** cguida <cguida!~Adium@2601:282:200:ae00:c0b3:1fe8:c368:43ba> has quit IRC (Ping timeout: 276 seconds)
562021-04-20T02:17:15 *** cryptapus <cryptapus!~cryptapus@unaffiliated/cryptapus> has quit IRC (Quit: Konversation terminated!)
572021-04-20T02:18:50 *** cryptapus <cryptapus!~cryptapus@jupiter.osmus.org> has joined #bitcoin-core-dev
582021-04-20T02:39:14 *** cguida <cguida!~Adium@2601:282:200:ae00:c0b3:1fe8:c368:43ba> has joined #bitcoin-core-dev
592021-04-20T02:39:47 *** killerfox <killerfox!322f7246@50.47.114.70> has joined #bitcoin-core-dev
602021-04-20T02:40:55 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
612021-04-20T02:41:21 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
622021-04-20T02:43:38 *** cguida <cguida!~Adium@2601:282:200:ae00:c0b3:1fe8:c368:43ba> has quit IRC (Ping timeout: 258 seconds)
632021-04-20T02:48:19 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
642021-04-20T02:59:28 *** cguida <cguida!~Adium@2601:282:200:ae00:c0b3:1fe8:c368:43ba> has joined #bitcoin-core-dev
652021-04-20T03:04:20 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
662021-04-20T03:07:58 *** openoms_ <openoms_!~quassel@gateway/tor-sasl/openoms> has joined #bitcoin-core-dev
672021-04-20T03:09:33 *** openoms <openoms!~quassel@gateway/tor-sasl/openoms> has quit IRC (Ping timeout: 240 seconds)
682021-04-20T03:12:11 *** GarouDan <GarouDan!~GarouDan@191.242.119.219.fibra.plimtelecom.com.br> has quit IRC (Remote host closed the connection)
692021-04-20T03:17:27 *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
702021-04-20T03:21:11 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
712021-04-20T03:23:33 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
722021-04-20T03:29:37 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
732021-04-20T03:40:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
742021-04-20T03:40:41 <bitcoin-git> [bitcoin] ajtowns closed pull request #21378: Convert taproot to flag day activation (master...202103-taproot-flag-day) https://github.com/bitcoin/bitcoin/pull/21378
752021-04-20T03:40:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
762021-04-20T03:41:45 <aj> fanquake: ping re: #20353?
772021-04-20T03:41:46 <gribble> https://github.com/bitcoin/bitcoin/issues/20353 | configure: Support -fdebug-prefix-map and -fmacro-prefix-map by ajtowns · Pull Request #20353 · bitcoin/bitcoin · GitHub
782021-04-20T03:47:21 <fanquake> aj: good call. Will ACK/merge this arvo
792021-04-20T04:09:25 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
802021-04-20T04:09:41 *** ctrlbreak <ctrlbreak!~ctrlbreak@159.2.165.130> has quit IRC (Ping timeout: 240 seconds)
812021-04-20T04:30:58 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
822021-04-20T04:35:29 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 265 seconds)
832021-04-20T04:41:50 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 252 seconds)
842021-04-20T04:48:15 *** criley_ <criley_!~criley@c-73-224-125-58.hsd1.fl.comcast.net> has joined #bitcoin-core-dev
852021-04-20T04:50:11 *** criley <criley!~criley@c-73-224-125-58.hsd1.fl.comcast.net> has quit IRC (Ping timeout: 240 seconds)
862021-04-20T04:51:26 *** BGL <BGL!~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net> has quit IRC (Ping timeout: 265 seconds)
872021-04-20T05:12:41 *** GarouDan <GarouDan!~GarouDan@191.242.119.219.fibra.plimtelecom.com.br> has joined #bitcoin-core-dev
882021-04-20T05:16:46 *** GarouDan <GarouDan!~GarouDan@191.242.119.219.fibra.plimtelecom.com.br> has quit IRC (Ping timeout: 240 seconds)
892021-04-20T05:17:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
902021-04-20T05:17:16 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a839303edc8a...de77cbc9d855
912021-04-20T05:17:17 <bitcoin-git> bitcoin/master fad4167 MarcoFalke: test: Check that no versionbits are re-used
922021-04-20T05:17:18 <bitcoin-git> bitcoin/master faec1e9 MarcoFalke: test: Address outstanding versionbits_test feedback
932021-04-20T05:17:19 <bitcoin-git> bitcoin/master fa8eaee MarcoFalke: test: Run versionbits_sanity for all chains
942021-04-20T05:17:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
952021-04-20T05:17:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
962021-04-20T05:17:36 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #21691: test: Check that no versionbits are re-used (master...2104-testVersionbits) https://github.com/bitcoin/bitcoin/pull/21691
972021-04-20T05:17:36 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
982021-04-20T05:21:18 *** smartineng <smartineng!~Icedove@88.135.18.171> has joined #bitcoin-core-dev
992021-04-20T05:21:20 *** smartineng <smartineng!~Icedove@88.135.18.171> has quit IRC (Excess Flood)
1002021-04-20T05:21:58 *** smartineng <smartineng!~Icedove@88.135.18.171> has joined #bitcoin-core-dev
1012021-04-20T05:22:14 *** Guest72320 <Guest72320!~will@dynamic-190-25-109-205.dynamic.etb.net.co> has joined #bitcoin-core-dev
1022021-04-20T05:24:19 *** Guest72320 <Guest72320!~will@dynamic-190-25-109-205.dynamic.etb.net.co> has quit IRC (Client Quit)
1032021-04-20T05:38:49 <wumpus> is the merge bot broken?
1042021-04-20T05:38:53 <wumpus> oh nm
1052021-04-20T05:43:38 *** OP_NOP <OP_NOP!OP_NOP@gateway/vpn/privateinternetaccess/opnop/x-41418994> has quit IRC (Ping timeout: 265 seconds)
1062021-04-20T05:53:09 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
1072021-04-20T05:54:34 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
1082021-04-20T05:59:42 *** thaumavorio <thaumavorio!~thaumavor@thaumavor.io> has quit IRC (Quit: ZNC 1.8.2 - https://znc.in)
1092021-04-20T06:03:01 *** thaumavorio <thaumavorio!~thaumavor@thaumavor.io> has joined #bitcoin-core-dev
1102021-04-20T06:21:34 *** BGL <BGL!~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net> has joined #bitcoin-core-dev
1112021-04-20T06:29:23 *** killerfox <killerfox!322f7246@50.47.114.70> has quit IRC (Ping timeout: 240 seconds)
1122021-04-20T06:37:23 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
1132021-04-20T06:38:56 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1142021-04-20T06:59:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1152021-04-20T06:59:42 <bitcoin-git> [bitcoin] laanwj pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/de77cbc9d855...906ecb87c8c7
1162021-04-20T06:59:43 <bitcoin-git> bitcoin/master 84f3939 Pieter Wuille: Remove support for subdescriptors expanding to multiple scripts
1172021-04-20T06:59:43 <bitcoin-git> bitcoin/master a917478 Pieter Wuille: refactor: move population of out.scripts from ExpandHelper to MakeScripts
1182021-04-20T06:59:44 <bitcoin-git> bitcoin/master 4441c6f Pieter Wuille: Make DescriptorImpl support multiple subscripts
1192021-04-20T06:59:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1202021-04-20T07:00:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1212021-04-20T07:00:01 <bitcoin-git> [bitcoin] laanwj merged pull request #21238: A few descriptor improvements to prepare for Taproot support (master...202102_descriptor_prepare_taproot) https://github.com/bitcoin/bitcoin/pull/21238
1222021-04-20T07:00:02 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1232021-04-20T07:12:29 <MarcoFalke> looks like ci is red
1242021-04-20T07:12:39 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 268 seconds)
1252021-04-20T07:12:54 <MarcoFalke> There was a silent merge conflict
1262021-04-20T07:13:27 <MarcoFalke> script/descriptor.cpp:498:16: error: parameter 'script' not found in the function declaration [-Werror,-Wdocumentation]
1272021-04-20T07:13:37 <wumpus> strange, i did build locally
1282021-04-20T07:17:04 <MarcoFalke> Maybe Wdoc only works on a specific compiler?
1292021-04-20T07:17:58 <MarcoFalke> wumpus: Obviously not blaming you. It is impossible to find all silent merge conflicts.
1302021-04-20T07:18:37 <wumpus> my compiler (clang 13) does accept the flag, no idea if it does anything with it
1312021-04-20T07:19:47 <wumpus> right it's just that i try to be careful to avoid them by always running the build + tests locally, but definitely cannot do so for every platform / compiler combo
1322021-04-20T07:20:42 <wumpus> anyhow i'll do a PR...
1332021-04-20T07:30:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1342021-04-20T07:30:30 <bitcoin-git> [bitcoin] laanwj opened pull request #21736: doc: Fix doxygen comment silent merge conflict in descriptor.cpp (master...2021-04-parameter-documentation) https://github.com/bitcoin/bitcoin/pull/21736
1352021-04-20T07:30:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1362021-04-20T07:33:09 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
1372021-04-20T07:34:09 *** kabaum <kabaum!~kabaum@h-13-35.A163.priv.bahnhof.se> has quit IRC (Quit: Leaving)
1382021-04-20T07:34:34 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
1392021-04-20T07:39:54 *** jungly <jungly!~jungly@host-79-37-201-97.retail.telecomitalia.it> has joined #bitcoin-core-dev
1402021-04-20T07:48:58 <wumpus> it looks like my compiler does have the warning enabled, it is just not fatal, i've had bad experiences with Werror in the past (due to divergence between compiler versions) but will try enabling --enable-suppress-external-warnings --enable-werror locally maybe it is better now
1412021-04-20T07:52:13 <aj> wumpus: those options work for me fwiw
1422021-04-20T07:53:55 <wumpus> aj: i don't doubt they work :) the problem is that the set of warnings very much differs between compilers, it is often that new gcc has some new warnings
1432021-04-20T07:54:50 <wumpus> or clang for that matter (thinking of the locking annotation warnings)
1442021-04-20T07:55:32 <aj> wumpus: yep
1452021-04-20T07:55:42 <wumpus> so it is not a guarantee in any case, there might be local failures due to this that do not arise in the CI and the other way around
1462021-04-20T07:55:45 <aj> wumpus i took the release cadence date stuff to be referring to 23.0 not 22.0 fwiw
1472021-04-20T07:56:28 <wumpus> let's discuss that at the time we are planning the 23.0 date then, that will only be after the 22.0 release
1482021-04-20T07:56:31 *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f16910080dd1c3c4f92d269.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
1492021-04-20T07:56:36 <aj> wumpus: yeah
1502021-04-20T08:01:51 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 260 seconds)
1512021-04-20T08:16:46 *** ctrlbreak <ctrlbreak!~ctrlbreak@159.2.165.130> has joined #bitcoin-core-dev
1522021-04-20T08:21:29 <wumpus> definitely agree with the principle that planning a release around xmas is a bad idea
1532021-04-20T08:21:41 <wumpus> december tends to be a really quiet month in bitcoin dev
1542021-04-20T08:26:37 <MarcoFalke> yeah, it might be good to aim for October (or earlier) as a release month, as November might often delay into December
1552021-04-20T08:30:54 <MarcoFalke> Also branch-off right at the start of the new year might not be good either. Better wait till February (or later) to give reviewers some time to make up for the lack of review during December
1562021-04-20T08:32:08 <wumpus> october seems really early for 0.23?
1572021-04-20T08:32:53 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1582021-04-20T08:33:19 <wumpus> or do you mean for 22, that doesn't make sense to me either (postpone it by two months?)
1592021-04-20T08:33:28 <MarcoFalke> Could aim for February 2022?
1602021-04-20T08:33:34 <MarcoFalke> No need to change the 0.22 timeline
1612021-04-20T08:33:44 <MarcoFalke> I think that is already set pretty much
1622021-04-20T08:34:14 <wumpus> feb for 0.23 that would make sense (but as said, let's discuss 0.23 timeline when we get there)
1632021-04-20T08:35:19 <MarcoFalke> sure, just wanted to mention that 0.22+6 months collides with December ;)
1642021-04-20T08:36:05 <fanquake> yea -Wdocumentation requires --enable-suppress-external-warnings to be enabled
1652021-04-20T08:42:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1662021-04-20T08:42:46 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/906ecb87c8c7...572b36d4ff99
1672021-04-20T08:42:47 <bitcoin-git> bitcoin/master e5faec6 W. J. van der Laan: doc: Fix doxygen comment silent merge conflict in descriptor.cpp
1682021-04-20T08:42:48 <bitcoin-git> bitcoin/master 572b36d MarcoFalke: Merge bitcoin/bitcoin#21736: doc: Fix doxygen comment silent merge conflic...
1692021-04-20T08:42:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1702021-04-20T08:43:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1712021-04-20T08:43:06 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #21736: doc: Fix doxygen comment silent merge conflict in descriptor.cpp (master...2021-04-parameter-documentation) https://github.com/bitcoin/bitcoin/pull/21736
1722021-04-20T08:43:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1732021-04-20T08:45:02 <MarcoFalke> reset all failed ci builds from the last two hours
1742021-04-20T08:45:10 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
1752021-04-20T08:47:14 <wumpus> harding: your taproot activation write-up seems very clear to me, i'll leave it on the wiki for a few days so people can make corrections if they think that is necessary, then add it to the release notes on the 0.21 branch
1762021-04-20T08:49:26 *** justinTseng <justinTseng!~justintse@mmnet.ee.ntu.edu.tw> has joined #bitcoin-core-dev
1772021-04-20T08:49:28 *** justinTseng <justinTseng!~justintse@mmnet.ee.ntu.edu.tw> has quit IRC (Client Quit)
1782021-04-20T09:13:10 *** GarouDan <GarouDan!~GarouDan@191.242.119.219.fibra.plimtelecom.com.br> has joined #bitcoin-core-dev
1792021-04-20T09:17:25 *** GarouDan <GarouDan!~GarouDan@191.242.119.219.fibra.plimtelecom.com.br> has quit IRC (Ping timeout: 252 seconds)
1802021-04-20T09:48:21 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 260 seconds)
1812021-04-20T09:49:03 *** someone235 <someone235!uid419897@gateway/web/irccloud.com/x-lgclatcodxssvxbu> has joined #bitcoin-core-dev
1822021-04-20T09:53:18 *** jungly <jungly!~jungly@host-79-37-201-97.retail.telecomitalia.it> has quit IRC (Remote host closed the connection)
1832021-04-20T10:10:53 *** jonatack <jonatack!~jon@88.127.52.83> has quit IRC (Ping timeout: 240 seconds)
1842021-04-20T10:11:17 *** jonatack <jonatack!jon@gateway/vpn/airvpn/jonatack> has joined #bitcoin-core-dev
1852021-04-20T10:18:14 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1862021-04-20T10:18:39 *** Russell52Ferry <Russell52Ferry!~Russell52@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
1872021-04-20T10:19:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1882021-04-20T10:19:55 <bitcoin-git> [bitcoin] hebasto closed pull request #19213: util: Get rid of RecursiveMutex in Get{Blocks,Data}Dir (master...200608-path-mx) https://github.com/bitcoin/bitcoin/pull/19213
1892021-04-20T10:20:02 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1902021-04-20T10:20:28 *** biteskola <biteskola!~biteskola@170.76.76.188.dynamic.jazztel.es> has joined #bitcoin-core-dev
1912021-04-20T10:23:29 *** Russell52Ferry <Russell52Ferry!~Russell52@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 265 seconds)
1922021-04-20T10:47:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1932021-04-20T10:47:45 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #21738: test: Use clang-12 for ASAN, Add missing suppression (master...2104-asan) https://github.com/bitcoin/bitcoin/pull/21738
1942021-04-20T10:47:45 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1952021-04-20T10:55:55 *** nn50 <nn50!2d84e161@45.132.225.97> has joined #bitcoin-core-dev
1962021-04-20T10:57:57 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
1972021-04-20T10:59:36 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
1982021-04-20T11:07:09 *** _rny <_rny!~rny@gateway/tor-sasl/renlord> has joined #bitcoin-core-dev
1992021-04-20T11:07:33 *** rny <rny!~rny@gateway/tor-sasl/renlord> has quit IRC (Ping timeout: 240 seconds)
2002021-04-20T11:13:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2012021-04-20T11:13:35 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/572b36d4ff99...30a86bb814e3
2022021-04-20T11:13:35 <bitcoin-git> bitcoin/master de17d24 dplusplus1024: Re-add command to install vcpkg
2032021-04-20T11:13:36 <bitcoin-git> bitcoin/master 30a86bb MarcoFalke: Merge bitcoin/bitcoin#21733: build: Re-add command to install vcpkg
2042021-04-20T11:13:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2052021-04-20T11:13:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2062021-04-20T11:13:54 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #21733: build: Re-add command to install vcpkg (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21733
2072021-04-20T11:13:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2082021-04-20T11:17:16 *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
2092021-04-20T11:17:41 *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has quit IRC (Read error: Connection reset by peer)
2102021-04-20T11:22:23 *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has joined #bitcoin-core-dev
2112021-04-20T11:45:38 *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2122021-04-20T11:48:38 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 246 seconds)
2132021-04-20T11:52:27 *** Barras2 <Barras2!~Barras2@139.28.218.148> has quit IRC (Remote host closed the connection)
2142021-04-20T11:58:45 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
2152021-04-20T11:59:38 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
2162021-04-20T12:00:45 *** ShapeShifter499 <ShapeShifter499!~ShapeShif@unaffiliated/shapeshifter499> has joined #bitcoin-core-dev
2172021-04-20T12:00:52 <ShapeShifter499> hi
2182021-04-20T12:01:07 <ShapeShifter499> so I have a question about the client. I'm on linux and I'm wondering does it matter what Berkeley Database Bitcoin is compiled against if I want to recover old wallets?
2192021-04-20T12:06:12 *** nibbier <nibbier!~quassel@mx01.geekbox.info> has left #bitcoin-core-dev ("http://quassel-irc.org - Chat comfortably. Anywhere.")
2202021-04-20T12:27:36 *** ShapeShifter499 <ShapeShifter499!~ShapeShif@unaffiliated/shapeshifter499> has quit IRC (Quit: ShapeShifter499)
2212021-04-20T12:37:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2222021-04-20T12:37:05 <bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/30a86bb814e3...018045347110
2232021-04-20T12:37:06 <bitcoin-git> bitcoin/master db4d2c2 Jon Atack: cli: create AddrinfoRequestHandler class
2242021-04-20T12:37:06 <bitcoin-git> bitcoin/master 5056a37 Jon Atack: cli: add -addrinfo command
2252021-04-20T12:37:06 <bitcoin-git> bitcoin/master bb85cbc Jon Atack: doc: add cli -addrinfo release note
2262021-04-20T12:37:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2272021-04-20T12:37:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2282021-04-20T12:37:25 <bitcoin-git> [bitcoin] laanwj merged pull request #21595: cli: create -addrinfo (master...addressinfo) https://github.com/bitcoin/bitcoin/pull/21595
2292021-04-20T12:37:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2302021-04-20T12:39:50 *** jungly <jungly!~jungly@host-79-37-201-97.retail.telecomitalia.it> has joined #bitcoin-core-dev
2312021-04-20T12:41:24 *** GarouDan <GarouDan!~GarouDan@191.242.119.219.fibra.plimtelecom.com.br> has joined #bitcoin-core-dev
2322021-04-20T12:42:01 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
2332021-04-20T12:42:06 <wumpus> hebasto: sorry for only noticing this now in #21694 btw while i commented on the gitignore before :)
2342021-04-20T12:42:08 <gribble> https://github.com/bitcoin/bitcoin/issues/21694 | build: Use XLIFF file to provide more context to Transifex translators by hebasto · Pull Request #21694 · bitcoin/bitcoin · GitHub
2352021-04-20T12:43:10 <hebasto> wumpus: does this mean that src/qt/locale/bitcoin_en.xlf should be a part of the repo?
2362021-04-20T12:57:24 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2372021-04-20T12:58:45 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
2382021-04-20T12:59:37 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
2392021-04-20T13:00:11 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
2402021-04-20T13:02:00 <wumpus> hebasto: if it is what you want transifex to read, yes
2412021-04-20T13:02:47 <hebasto> wumpus: thanks for explanation
2422021-04-20T13:04:13 <wumpus> e.g. the auto-update URL for 0.21.x right now in the transifex interface is : https://raw.githubusercontent.com/bitcoin/bitcoin/master/src/qt/locale/bitcoin_en.ts
2432021-04-20T13:04:34 <wumpus> oh i should change that to the branch
2442021-04-20T13:06:21 <wumpus> thanks for making me check, it is not good if it keeps updating from master and the translations diverge
2452021-04-20T13:07:35 <hebasto> wumpus: nice that everything is ok now
2462021-04-20T13:18:45 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
2472021-04-20T13:20:03 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
2482021-04-20T13:38:51 <wumpus> btw; do we still need bitcoin_en.ts *at all* now? i think its only goal was to provide it to transifex? or is it used for other things as well?
2492021-04-20T13:40:08 <wumpus> hmm i guess it is embedded in the binary but is effectively a no-op]
2502021-04-20T13:43:15 <hebasto> is it used to generate `bitcoin_en.qm` for `QObject::tr()`?
2512021-04-20T13:45:02 <hebasto> yes. in en_US locale it is no-op :)
2522021-04-20T13:45:17 <wumpus> that seems a very useless thing to do :) but sure it might anyway
2532021-04-20T13:46:18 <wumpus> but yeah, let's leave it like that for this PR, no need to touch that
2542021-04-20T13:46:34 <hebasto> ok
2552021-04-20T13:50:49 <wumpus> i hope we'll still get .ts translations back from transifex with tx pull
2562021-04-20T13:51:15 <hebasto> we'll find out :)
2572021-04-20T13:51:15 <wumpus> if not the maintainer-tools/update-translations.py script will need to convert too
2582021-04-20T13:52:34 <wumpus> we'll find out for 22.0 i suppose (no good reason to backport this)
2592021-04-20T13:53:15 <hebasto> agree
2602021-04-20T13:59:14 *** ericbsd1 <ericbsd1!~ericbsd@139.28.218.148> has joined #bitcoin-core-dev
2612021-04-20T14:01:19 *** nn50 <nn50!2d84e161@45.132.225.97> has quit IRC (Quit: Connection closed)
2622021-04-20T14:02:33 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
2632021-04-20T14:03:14 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
2642021-04-20T14:09:02 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
2652021-04-20T14:09:51 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
2662021-04-20T14:11:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2672021-04-20T14:11:02 <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/018045347110...90e0faaa442b
2682021-04-20T14:11:03 <bitcoin-git> bitcoin/master 2045e4c Hennadii Stepanov: build: Use XLIFF file to provide more context to Transifex translators
2692021-04-20T14:11:04 <bitcoin-git> bitcoin/master f959b75 Hennadii Stepanov: build: Add Qt lconvert tool to depends
2702021-04-20T14:11:05 <bitcoin-git> bitcoin/master 99686b6 Hennadii Stepanov: qt [experimental]: Add a translation comment and a disambiguation string
2712021-04-20T14:11:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2722021-04-20T14:11:21 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2732021-04-20T14:11:22 <bitcoin-git> [bitcoin] laanwj merged pull request #21694: build: Use XLIFF file to provide more context to Transifex translators (master...210415-xliff) https://github.com/bitcoin/bitcoin/pull/21694
2742021-04-20T14:11:22 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2752021-04-20T14:15:23 *** duringo <duringo!ad004d11@173.0.77.17> has quit IRC (Ping timeout: 240 seconds)
2762021-04-20T14:23:09 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
2772021-04-20T14:24:36 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
2782021-04-20T14:29:43 <wumpus> btw we might want to do future translation-related changes in the gui repository
2792021-04-20T14:31:29 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
2802021-04-20T14:31:56 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
2812021-04-20T14:32:01 <hebasto> because they will touch the qt/ directory only?
2822021-04-20T14:32:44 <wumpus> yes, and because translation is only done for the GUI
2832021-04-20T14:34:09 <wumpus> i guess the exception is messages from bitcoind that get translated as well, but i mean changes that only affect src/qt sources yes
2842021-04-20T14:35:49 <hebasto> #21463, for example, is mixed qt and non-qt
2852021-04-20T14:35:51 <gribble> https://github.com/bitcoin/bitcoin/issues/21463 | doc: Address feedback from Transifex translator community by hebasto · Pull Request #21463 · bitcoin/bitcoin · GitHub
2862021-04-20T14:45:01 <wumpus> yes, agree
2872021-04-20T14:57:35 *** nst <nst!9d2ca33c@157.44.163.60> has joined #bitcoin-core-dev
2882021-04-20T14:58:41 *** biteskola <biteskola!~biteskola@170.76.76.188.dynamic.jazztel.es> has quit IRC (Ping timeout: 260 seconds)
2892021-04-20T14:58:53 *** nst <nst!9d2ca33c@157.44.163.60> has left #bitcoin-core-dev
2902021-04-20T15:00:15 *** cguida <cguida!~Adium@2601:282:200:ae00:c0b3:1fe8:c368:43ba> has quit IRC (Quit: Leaving.)
2912021-04-20T15:01:14 <jeremyrubin> Would anyone be opposed to adding an address type for OP_RETURN?
2922021-04-20T15:01:54 <jeremyrubin> I don't think they should be universally available, but it can be kind of annoying working in generic code that you can't get an address for an OP_RETURN output
2932021-04-20T15:04:08 <jeremyrubin> I guess this is better suited for mailing list...
2942021-04-20T15:06:37 *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2952021-04-20T15:06:49 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
2962021-04-20T15:07:36 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
2972021-04-20T15:10:14 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 246 seconds)
2982021-04-20T15:13:02 <luke-jr> addresses define a recipient. OP_RETURN doesn't have a recipient.
2992021-04-20T15:13:28 <jeremyrubin> then why can I pay a P2SH OP_RETURN and that has an address?
3002021-04-20T15:13:53 <luke-jr> furthermore, OP_RETURN should not be used except to represent something else more specific; that something else perhaps might need an address, which would then be impeded by a generic OP_RETURN address by folks who think there should only be one possible address per script
3012021-04-20T15:14:09 <luke-jr> there is no such thign as a P2SH OP_RETURN
3022021-04-20T15:14:18 <jeremyrubin> Howso?
3032021-04-20T15:14:28 <jeremyrubin> i can create a p2sh op_return quite easily
3042021-04-20T15:14:45 <luke-jr> OP_RETURN as a transaction type is defined as a scriptPK that begins with OP_RETURN
3052021-04-20T15:15:11 <jeremyrubin> That's beside the point
3062021-04-20T15:15:19 <jeremyrubin> [4/20/21 08:13] <luke-jr> addresses define a recipient. OP_RETURN doesn't have a recipient.
3072021-04-20T15:15:24 <luke-jr> you can't prove on-chain that a P2SH contains an OP_RETURN, and such an output will enter the database
3082021-04-20T15:15:25 <belcher> you could create it but why would you? op_return is used for embedding data but if that data is hashed behind a p2sh then it cant even do that(?)
3092021-04-20T15:15:44 <luke-jr> belcher: it's supposed to only be used for embedding hashes; one extra layer doesn't impede that
3102021-04-20T15:15:55 <luke-jr> but the P2SH does impede being able to prune it
3112021-04-20T15:16:24 <jeremyrubin> i'm less worried about the pay-to support, more worried about the parsing of data generically
3122021-04-20T15:16:33 <pinheadmz> jeremyrubin could propose to define a segwit version `16` (for example) that decodes to <OP_RETURN> <data>
3132021-04-20T15:16:38 <luke-jr> and prunability is what distinguishes OP_RETURN from other unspendable outputs
3142021-04-20T15:17:09 <luke-jr> jeremyrubin: it sounds like your undefined use case really ought to use raw scripts, not addresses
3152021-04-20T15:17:15 <jeremyrubin> not really
3162021-04-20T15:17:33 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Remote host closed the connection)
3172021-04-20T15:17:38 <jeremyrubin> I want to split out "is this something we know about" or "is this some custom thing entirely"
3182021-04-20T15:17:52 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
3192021-04-20T15:17:53 <luke-jr> there's no distinction in this case
3202021-04-20T15:18:00 <luke-jr> OP_RETURN is some custom thing entirely
3212021-04-20T15:18:13 <jeremyrubin> Every p2sh is also some custom thing
3222021-04-20T15:18:37 <jeremyrubin> because a p2sh can contain an OP_RETURN <blah>
3232021-04-20T15:18:42 <luke-jr> beside the point
3242021-04-20T15:18:46 <jeremyrubin> That is the point
3252021-04-20T15:19:15 <luke-jr> anyway, I think I've gone over the reasons not to do it afaik.
3262021-04-20T15:19:30 <jeremyrubin> If i can try to explain it back...
3272021-04-20T15:20:06 <jeremyrubin> We should only have addresses or descriptors for things we know exactly what they are, and also for things that represent something that is not only payable but also potentially spendable.
3282021-04-20T15:21:01 <jeremyrubin> OP_RETURN, being unspendable and usually proprietary in purpose, should not have an address
3292021-04-20T15:22:15 <jeremyrubin> Is that a correct restatement of your concern?
3302021-04-20T15:28:45 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
3312021-04-20T15:29:34 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
3322021-04-20T15:31:56 *** cguida <cguida!~Adium@205.209.28.54> has joined #bitcoin-core-dev
3332021-04-20T15:33:36 *** kehsandos <kehsandos!1fce62c6@31.206.98.198> has joined #bitcoin-core-dev
3342021-04-20T15:39:39 *** proofofkeags <proofofkeags!~proofofke@97-118-239-55.hlrn.qwest.net> has quit IRC (Ping timeout: 252 seconds)
3352021-04-20T15:45:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3362021-04-20T15:45:40 <bitcoin-git> [bitcoin] dongcarl closed pull request #18963: [WIP] rebase: Call ProcessNewBlock() asynchronously (master...2020-05-async-pnb) https://github.com/bitcoin/bitcoin/pull/18963
3372021-04-20T15:45:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3382021-04-20T15:51:31 *** cguida <cguida!~Adium@205.209.28.54> has quit IRC (Quit: Leaving.)
3392021-04-20T15:53:20 *** shesek <shesek!~shesek@164.90.217.137> has joined #bitcoin-core-dev
3402021-04-20T16:00:57 *** ja <ja!janus@anubis.0x90.dk> has left #bitcoin-core-dev
3412021-04-20T16:05:00 *** kehsandos92 <kehsandos92!1fce62c6@31.206.98.198> has joined #bitcoin-core-dev
3422021-04-20T16:05:53 *** kehsandos92 <kehsandos92!1fce62c6@31.206.98.198> has quit IRC (Client Quit)
3432021-04-20T16:07:22 *** kehsandos <kehsandos!1fce62c6@31.206.98.198> has quit IRC (Ping timeout: 240 seconds)
3442021-04-20T16:14:46 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
3452021-04-20T16:15:53 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
3462021-04-20T16:16:30 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
3472021-04-20T16:35:53 *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f16910080dd1c3c4f92d269.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
3482021-04-20T16:37:53 *** jasan <jasan!~j@n.bublina.eu.org> has joined #bitcoin-core-dev
3492021-04-20T16:47:57 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
3502021-04-20T16:49:33 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
3512021-04-20T17:03:52 *** jasan <jasan!~j@n.bublina.eu.org> has left #bitcoin-core-dev
3522021-04-20T17:05:24 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Read error: Connection reset by peer)
3532021-04-20T17:06:06 *** molz_ <molz_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
3542021-04-20T17:10:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3552021-04-20T17:10:14 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/90e0faaa442b...bca00942ed27
3562021-04-20T17:10:14 <bitcoin-git> bitcoin/master f02ca7a Aaron Clauson: Update msvc build to use Qt5.12.10 binaries.
3572021-04-20T17:10:15 <bitcoin-git> bitcoin/master bca0094 MarcoFalke: Merge bitcoin/bitcoin#21731: Update msvc build to use Qt5.12.10 binaries.
3582021-04-20T17:10:16 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3592021-04-20T17:11:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3602021-04-20T17:11:44 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #21731: Update msvc build to use Qt5.12.10 binaries. (master...msvc_qt5.12.10) https://github.com/bitcoin/bitcoin/pull/21731
3612021-04-20T17:11:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3622021-04-20T17:20:58 <jnewbery> Hi folks. Reminder that we have a p2p irc meeting in about 3.5 hours. Feel free to share your priorities here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities and add suggested topics here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings
3632021-04-20T17:21:15 <jnewbery> We currently have two suggested topics: Reduce addr blackholes (PR 21528) (Amiti)
3642021-04-20T17:21:24 <jnewbery> Moving forward with asmap (gleb)
3652021-04-20T17:34:00 *** Thor <Thor!8ff43c81@143.244.60.129> has joined #bitcoin-core-dev
3662021-04-20T17:36:58 <jeremyrubin> Out of curiosity; is it possible to construct a Script as hex which is also an address?
3672021-04-20T17:37:16 <jeremyrubin> AFAIK, in binary it should be possible, but not as hex
3682021-04-20T17:44:01 <hebasto> wumpus: re "oh i should change that to the branch" -- I received Transifex notification about updated content. Is this it?
3692021-04-20T17:44:46 *** jungly <jungly!~jungly@host-79-37-201-97.retail.telecomitalia.it> has quit IRC (Ping timeout: 240 seconds)
3702021-04-20T17:46:07 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 260 seconds)
3712021-04-20T17:57:26 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
3722021-04-20T18:01:32 *** molz_ <molz_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 252 seconds)
3732021-04-20T18:14:34 *** lightlike <lightlike!~lightlike@p200300c7ef19db0061d3c6a7964cab1b.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
3742021-04-20T18:15:06 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
3752021-04-20T18:27:31 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
3762021-04-20T18:32:21 *** GarouDan <GarouDan!~GarouDan@191.242.119.219.fibra.plimtelecom.com.br> has quit IRC (Remote host closed the connection)
3772021-04-20T18:34:11 *** smartineng <smartineng!~Icedove@88.135.18.171> has quit IRC (Ping timeout: 240 seconds)
3782021-04-20T18:34:36 *** smctwo <smctwo!~smctwo@bba597217.alshamil.net.ae> has joined #bitcoin-core-dev
3792021-04-20T18:35:14 *** smctwo <smctwo!~smctwo@bba597217.alshamil.net.ae> has quit IRC (Read error: Connection reset by peer)
3802021-04-20T18:35:35 *** smctwo <smctwo!~smctwo@bba597217.alshamil.net.ae> has joined #bitcoin-core-dev
3812021-04-20T18:47:01 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 268 seconds)
3822021-04-20T18:50:17 *** lightlike <lightlike!~lightlike@p200300c7ef19db0061d3c6a7964cab1b.dip0.t-ipconnect.de> has quit IRC (Ping timeout: 250 seconds)
3832021-04-20T18:54:55 *** GarouDan <GarouDan!~GarouDan@191.242.119.219.fibra.plimtelecom.com.br> has joined #bitcoin-core-dev
3842021-04-20T18:57:08 *** GarouDan <GarouDan!~GarouDan@191.242.119.219.fibra.plimtelecom.com.br> has quit IRC (Remote host closed the connection)
3852021-04-20T18:57:14 *** GarouDan <GarouDan!~GarouDan@191.242.119.219.fibra.plimtelecom.com.br> has joined #bitcoin-core-dev
3862021-04-20T18:59:12 *** OP_NOP <OP_NOP!OP_NOP@gateway/vpn/privateinternetaccess/opnop/x-41418994> has joined #bitcoin-core-dev
3872021-04-20T18:59:58 *** Thor <Thor!8ff43c81@143.244.60.129> has quit IRC (Quit: Connection closed)
3882021-04-20T19:05:27 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 260 seconds)
3892021-04-20T19:06:23 *** lightlike <lightlike!~lightlike@p200300c7ef19db00d1c579b9c97114e1.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
3902021-04-20T19:18:23 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
3912021-04-20T19:20:11 *** davec <davec!~davec@072-183-054-196.res.spectrum.com> has quit IRC (Ping timeout: 240 seconds)
3922021-04-20T19:22:21 *** lightlike <lightlike!~lightlike@p200300c7ef19db00d1c579b9c97114e1.dip0.t-ipconnect.de> has quit IRC (Ping timeout: 250 seconds)
3932021-04-20T19:23:09 *** lightlike <lightlike!~lightlike@p200300c7ef19db0020d8eadad0ae1a50.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
3942021-04-20T19:31:55 *** jungly <jungly!~jungly@host-79-37-201-97.retail.telecomitalia.it> has joined #bitcoin-core-dev
3952021-04-20T19:33:48 *** proofofkeags <proofofkeags!~proofofke@c-75-70-131-96.hsd1.co.comcast.net> has joined #bitcoin-core-dev
3962021-04-20T19:37:50 *** cguida <cguida!~Adium@c-75-70-131-96.hsd1.co.comcast.net> has joined #bitcoin-core-dev
3972021-04-20T19:42:11 *** davec <davec!~davec@072-183-054-196.res.spectrum.com> has joined #bitcoin-core-dev
3982021-04-20T20:14:04 *** smctwo <smctwo!~smctwo@bba597217.alshamil.net.ae> has quit IRC (Remote host closed the connection)
3992021-04-20T20:14:18 <ariard> jnewbery: yeah would like to propose "irc meetings on better L2s onchain support" as a topic but don't have the rights on wiki :/
4002021-04-20T20:20:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4012021-04-20T20:20:04 <bitcoin-git> [gui] hebasto merged pull request #263: Revamp context menus (master...210330-context) https://github.com/bitcoin-core/gui/pull/263
4022021-04-20T20:20:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4032021-04-20T20:20:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4042021-04-20T20:20:24 <bitcoin-git> [bitcoin] hebasto pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/bca00942ed27...f385ad765174
4052021-04-20T20:20:25 <bitcoin-git> bitcoin/master 1398a65 Hennadii Stepanov: qt, refactor: Make AddressBookPage::deleteAction a local variable
4062021-04-20T20:20:25 <bitcoin-git> bitcoin/master 963e120 Hennadii Stepanov: qt: Drop menu separator that separates nothing
4072021-04-20T20:20:26 <bitcoin-git> bitcoin/master 7931175 Hennadii Stepanov: qt: Do not assign Alt+<KEY> shortcuts to context menu actions
4082021-04-20T20:20:27 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4092021-04-20T20:37:26 *** jungly <jungly!~jungly@host-79-37-201-97.retail.telecomitalia.it> has quit IRC (Ping timeout: 245 seconds)
4102021-04-20T20:39:27 <amiti> ariard: added it for you
4112021-04-20T20:43:08 <ariard> amiti: thanks!
4122021-04-20T20:43:17 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
4132021-04-20T20:43:37 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
4142021-04-20T20:52:24 *** OP_NOP <OP_NOP!OP_NOP@gateway/vpn/privateinternetaccess/opnop/x-41418994> has quit IRC (Ping timeout: 252 seconds)
4152021-04-20T20:59:53 *** ericbsd1 <ericbsd1!~ericbsd@139.28.218.148> has quit IRC (Ping timeout: 240 seconds)
4162021-04-20T21:01:33 <jnewbery> #startmeeting
4172021-04-20T21:01:33 <core-meetingbot> Meeting started Tue Apr 20 21:01:33 2021 UTC. The chair is jnewbery. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
4182021-04-20T21:01:33 <core-meetingbot> Available commands: action commands idea info link nick
4192021-04-20T21:01:36 <amiti> hi
4202021-04-20T21:01:39 <ajonas> hi
4212021-04-20T21:01:45 <jnewbery> hi folks
4222021-04-20T21:01:52 <ariard> hi
4232021-04-20T21:01:54 <gleb> Hi
4242021-04-20T21:01:56 <lightlike> hi
4252021-04-20T21:02:16 <jnewbery> As a reminder, everyone is free to share their p2p priorities here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities
4262021-04-20T21:02:22 <promag> hi
4272021-04-20T21:02:39 <jnewbery> We also have three proposed topics for today's meeting: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#20-apr-2021
4282021-04-20T21:02:43 <gribble> https://github.com/bitcoin/bitcoin/issues/20 | JSON-RPC callback · Issue #20 · bitcoin/bitcoin · GitHub
4292021-04-20T21:02:45 <jnewbery> - Reduce addr blackholes (PR 21528) (Amiti)
4302021-04-20T21:02:49 <jnewbery> - Moving forward with asmap (gleb)
4312021-04-20T21:02:54 <jnewbery> - irc meetings on better L2s onchain support (ariard)
4322021-04-20T21:03:06 <jnewbery> Does anyone have any other proposed topics to add?
4332021-04-20T21:04:09 <jnewbery> oops, forgot
4342021-04-20T21:04:20 <jnewbery> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
4352021-04-20T21:04:26 <jnewbery> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus
4362021-04-20T21:04:44 <jnewbery> alright, let's get into the first topic
4372021-04-20T21:04:57 <jnewbery> #topic Reduce addr blackholes (amiti)
4382021-04-20T21:04:58 <core-meetingbot> topic: Reduce addr blackholes (amiti)
4392021-04-20T21:05:02 <amiti> hi!
4402021-04-20T21:05:15 <amiti> I want to discuss #21528
4412021-04-20T21:05:17 <gribble> https://github.com/bitcoin/bitcoin/issues/21528 | [p2p] Reduce addr blackholes by amitiuttarwar · Pull Request #21528 · bitcoin/bitcoin · GitHub
4422021-04-20T21:05:37 <amiti> I've mentioned it in a few different places, but I'll start with an overview of goals & motivation
4432021-04-20T21:05:59 <amiti> The goal is to reduce addr blackholes- aka relaying self advertisements to peers who are unlikely to continue relaying it to the network. Doing so would be a standalone improvement for addr propagation, and also, in my opinion, help with the disabletx project.
4442021-04-20T21:06:23 <amiti> The PR serves as a proof of concept for how this can be implemented in Bitcoin Core, but is currently in a draft because I have been trying to build confidence that this wouldnât harm other software on the network.
4452021-04-20T21:06:42 <amiti> I wrote to the mailing list: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-April/018784.html, and have not gotten any responses there
4462021-04-20T21:07:03 <amiti> Iâve also looked at the implementations of every other client Iâve heard of =P and been recording that here: https://github.com/bitcoin/bitcoin/pull/21528#issuecomment-809906430
4472021-04-20T21:07:36 <amiti> looks like almost all other clients are definitely ok. the only one I was very confused about is bitcore, so I'm hoping someone will respond to the issue I opened
4482021-04-20T21:08:07 <amiti> so, my main question for today is- do people think its reasonable for me to move forward with these changes? aka bring the PR into a "ready for review" state ?
4492021-04-20T21:08:19 <ariard> does it document bitcoinj, it's still maintained afaik?
4502021-04-20T21:08:23 <gleb> It looks like the stuff I attempted to do around a year ago, and at the time I also concluded it won't hurt other software.
4512021-04-20T21:08:47 <amiti> bitcoinj is not on the list. will look & add
4522021-04-20T21:08:48 <jnewbery> Yes, concept ACK
4532021-04-20T21:08:54 <amiti> gleb: what did you attempt?
4542021-04-20T21:09:35 <amiti> oh, another link is to a previous bitcoin-dev meeting where we discussed: http://www.erisian.com.au/bitcoin-core-dev/log-2021-03-25.html#l-954
4552021-04-20T21:09:50 <gleb> amiti: stop forwarding addr to nodes when it's useless.
4562021-04-20T21:10:19 <amiti> gleb: what did you try? did you PR?
4572021-04-20T21:10:21 <ariard> imo that's okay to move "ready for review", if no one yells on the ml and main bitcoin libraries are behaving like core
4582021-04-20T21:10:58 <gleb> amiti: I had a PR #17194, a core meeting discussion and several ML posts.
4592021-04-20T21:11:01 <gribble> https://github.com/bitcoin/bitcoin/issues/17194 | p2p: Avoid forwarding ADDR messages to SPV nodes by naumenkogs · Pull Request #17194 · bitcoin/bitcoin · GitHub
4602021-04-20T21:11:15 <amiti> gleb: thanks! I didn't realize :)
4612021-04-20T21:11:18 <gleb> The PR is only covers a subset of stuff I was suggesting
4622021-04-20T21:12:14 <gleb> I'll take a look and probably close mine, in case your work auguments it.
4632021-04-20T21:12:24 <amiti> cool, I'll check it out
4642021-04-20T21:12:29 <sipa> amiti: where did you land on sending/nonsending to non-relay peers? i remember you had some comments for sdaftuar_
4652021-04-20T21:12:32 <sipa> *from
4662021-04-20T21:13:07 <jnewbery> gleb: your PR disables addr relay based on the service bits sent by the peer. amiti's enables addr relay based on previous addr/getaddr messages received from the peer
4672021-04-20T21:13:09 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
4682021-04-20T21:13:30 <amiti> I'm still exploring the approach of not sending to non-relay peers
4692021-04-20T21:14:37 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
4702021-04-20T21:14:40 <amiti> sdaftuar expressed concern that if there is other software that doesn't send addr/getaddr messages but are relying on addr messages to discover peers, this change could make them vulnerable to a poor addrman / eclipse attacks
4712021-04-20T21:14:40 <sipa> but that's what the PR does?
4722021-04-20T21:14:53 <amiti> sipa: what?
4732021-04-20T21:15:07 <lightlike> I think an important difference is that the new PR would prevent sending to peers for whom we are their block-relay-only peer.
4742021-04-20T21:15:12 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
4752021-04-20T21:15:32 <sipa> amiti: not announcing to (assumed to be) non-relaying peers
4762021-04-20T21:15:43 <amiti> sipa: correct
4772021-04-20T21:15:52 <amiti> sipa: sorry, I don't understand your question
4782021-04-20T21:16:08 <sipa> amiti: just wanted to make sure i was up to date on the approach
4792021-04-20T21:16:22 <jnewbery> sipa: does "non-relaying peers" = "inbound block-relay-only peers" ?
4802021-04-20T21:17:23 <amiti> some context for the group: an alternative approach would be to identify "potential blackholes" and then add redundancy if those are selected. eg if you intend to relay to 2 peers but select a "potential blackhole", additionally relay to another peer
4812021-04-20T21:17:36 <sipa> jnewbery: an alternative approach would be still sending addr messages to everyone, but treat some subset as non-relaying (and thus not counting towards the 1 or 2 relay slots)
4822021-04-20T21:17:46 <jnewbery> sipa: ah. Got it. Thanks
4832021-04-20T21:18:00 <sipa> jnewbery: which would less risky for the network, but in my opinion weakly exploitable
4842021-04-20T21:18:33 <jnewbery> 'for the network' seems vague
4852021-04-20T21:18:42 <sipa> if we're confident this won't break anything, the current approach has my preference
4862021-04-20T21:18:57 <amiti> that is also my preference :)
4872021-04-20T21:19:24 <jnewbery> it'd be less risky for peers that want to receive addrs but don't ask for addrs, or am I missing some transitive behaviour?
4882021-04-20T21:19:24 <sipa> jnewbery: software that doesn't getaddr or send addrs, but still relies on receiving addresses
4892021-04-20T21:19:55 <sipa> jnewbery: i don't expect such software to exist, but it's also hard to be certain
4902021-04-20T21:19:59 <jnewbery> sipa: yep, that's my understanding
4912021-04-20T21:20:11 <amiti> I don't see much indication we will break things. I'll check bitcoinj and hope to hear back from bitcore, but beyond that I don't think there's much else I can do from my end
4922021-04-20T21:20:19 <sipa> ok
4932021-04-20T21:20:36 <jnewbery> I think amiti is doing a good job at analyzing the possible risk here: https://github.com/bitcoin/bitcoin/pull/21528#issuecomment-809906430
4942021-04-20T21:20:38 <ariard> at least ml + libraries inquiry let's build confidence, do we have other methods to improve such opinion?
4952021-04-20T21:20:57 *** morcos <morcos!~morcos@gateway/tor-sasl/morcos> has quit IRC (Remote host closed the connection)
4962021-04-20T21:21:02 <sipa> no, there is only so much we can do
4972021-04-20T21:21:35 <jnewbery> Great. Anything else on that, or shall we move to next topic?
4982021-04-20T21:21:42 *** morcos <morcos!~morcos@gateway/tor-sasl/morcos> has joined #bitcoin-core-dev
4992021-04-20T21:21:45 <amiti> just to conclude -
5002021-04-20T21:21:56 <amiti> I'll continue moving forward. if anyone has outstanding concerns, please let me know :)
5012021-04-20T21:22:03 <amiti> thanks!
5022021-04-20T21:22:22 <jnewbery> amiti: great. Thank you!
5032021-04-20T21:22:28 <jnewbery> #topic Moving forward with asmap (gleb)
5042021-04-20T21:22:28 <core-meetingbot> topic: Moving forward with asmap (gleb)
5052021-04-20T21:22:34 <gleb> We (me and sipa) want to move asmap forward and the main question is how to enable it by default. So far one priority is to help the maintainer to keep track of the BGP topology state updates.
5062021-04-20T21:22:48 <gleb> Basically, the maintainer would have to re-generate the compressed BGP topology map (asmap) for distribution and make sure itâs valid.
5072021-04-20T21:23:12 <gleb> Thereâs also testing of the existing tools and code in the Core, feel free to help:
5082021-04-20T21:23:12 <gleb> https://blog.bitmex.com/call-to-action-testing-and-improving-asmap/
5092021-04-20T21:23:23 <gleb> Once these tools are ready and stable, we will be able to enable it by default I think. Let me know if you have any thoughts or suggestions for other TODO to make progress here, otherwise Iâm done.
5102021-04-20T21:24:10 <ariard> Who is maintainer here ? bitcoin core or asmap tooling one?
5112021-04-20T21:24:28 <gleb> Bitcoin Core maintainers, every core release probably should get a new asmap file
5122021-04-20T21:24:47 <gleb> To maintain the best p2p robustness of the nodes.
5132021-04-20T21:24:50 <jeremyrubin> hi
5142021-04-20T21:25:25 <sipa> one critical component i think is tooling to produce human-readable diffs between asmap files
5152021-04-20T21:25:43 <sipa> because they can't be deterministically produced
5162021-04-20T21:26:10 <gleb> Yeah, everyone should be able to check the diff between the two easily.
5172021-04-20T21:27:07 <ariard> so it's about finishing asmap-rs as a functional bitcoin-asmap ?
5182021-04-20T21:27:27 <gleb> I think sipa still doesn't like rust, so we might end up using smething different...
5192021-04-20T21:28:03 <gleb> But basically yes, improving the tools.
5202021-04-20T21:28:28 <ariard> i think language choice is ultimately decided by who is maintaining the tool :p
5212021-04-20T21:29:09 <sipa> i certainly don't mind having good tooling in another language than one i'm familiar with, if it"s maintained
5222021-04-20T21:30:21 <gleb> I think I can commit to maintaining asmap-rs, but then, should we also translate sipa/asmap (compression part) into it?
5232021-04-20T21:30:31 <gleb> No need to answer now, I'll think about it after the meeting.
5242021-04-20T21:31:00 <ariard> gleb: nah you can link *.c/*.cpp in rust, we can talk about it in rust-bitcoin if you wanna
5252021-04-20T21:31:23 <gleb> alright, i'll check how nasty that is :)
5262021-04-20T21:32:33 <jnewbery> ariard: I don't think that's the problem. The question seems to be whether we should add some dependency on maintaining a rust tool to our release process.
5272021-04-20T21:32:51 <sipa> the only thing we neef reusable or usable from within Bitcoin Core is decoding/querying support, and we have that
5282021-04-20T21:33:36 <sipa> sure, it'd be nice if some tool shipped with core and possibly built from shared sources could do encoding too and other things, but i don't think that's a critical requirement
5292021-04-20T21:33:37 <ariard> jnewbery: yes as i'm planning to have rust dependency for altnet, if you think that's a real issue to have dependency in rust, let's have a discussion during main meeting?
5302021-04-20T21:33:49 <ariard> i think it was a subject a year ago
5312021-04-20T21:33:56 <sipa> those things just need to be available and usable
5322021-04-20T21:34:55 <jnewbery> ok, anything else on this topic, or move on?
5332021-04-20T21:35:04 <gleb> i think we can move on
5342021-04-20T21:35:09 <sipa> yeah
5352021-04-20T21:35:34 <jnewbery> #topic irc meetings on better L2s onchain support (ariard)
5362021-04-20T21:35:34 <core-meetingbot> topic: irc meetings on better L2s onchain support (ariard)
5372021-04-20T21:35:39 <ariard> hi!
5382021-04-20T21:36:18 <ariard> it has been a recurring topic among LN devs how to improve second-layer protocol layer by the base layer
5392021-04-20T21:36:28 <glozow> hi
5402021-04-20T21:36:36 <ariard> as current tx-relay and fee-bumping aren't really accurate
5412021-04-20T21:37:11 <ariard> we have the idea last year to do a share meeting between ln/core dev in 2021, but it doesn't seem it's going to be a thing even this year
5422021-04-20T21:37:44 <ariard> so instead, i'm working on setting up a bunch of irc meeting to talk about stuff like dust, full-rbf, package relay, standardness, coordinated security disclosures
5432021-04-20T21:38:01 <ariard> started a new repo about problem space there : https://github.com/ariard/L2-zoology
5442021-04-20T21:38:19 <ariard> and will do an announcement on the ml latter this week about process
5452021-04-20T21:38:35 <ariard> feel free to contribute if you're interested by those topics :)
5462021-04-20T21:39:02 <gleb> ariard: i think to motivate people to come, you (or any coordinator) should be really clear on how this is going to be useful, what are the possible useful outcomes, and why this stuff is blocker for L2 protocols.
5472021-04-20T21:39:21 <sipa> i think it would be useful if this was more concrete
5482021-04-20T21:39:49 <ariard> gleb: yes how this is going to be useful is described in threats/ performance/ section of new repo, possible useful outcomes are changes like full-rbf or package-relay
5492021-04-20T21:39:59 <ariard> but sure we'll make this really clear in ml post
5502021-04-20T21:40:26 <glozow> i'd be interested in seeing some simulations of attacks
5512021-04-20T21:41:16 <sipa> people (ariard in particular) oftrn brings up issues of unreliability or certain lack of guarantees offered by the p2p protocol and its current implementations, but it's hard to discuss thst in general as there simply can't be any guarantees really, and other layers need to be aware of that... bit that doesn't mean we can't have useful discussions about specific features or so
5522021-04-20T21:41:19 <ariard> glozow: yes we can try them on signet or mainet, main issue is having a realistic mempool, with sudden spikes
5532021-04-20T21:42:09 <sipa> so it would be much more interesting to me at least to discuss specific features or proposals for the p2p protocol
5542021-04-20T21:42:25 <ariard> sipa: i know this non-reliability point would be the starter point for such irc meetings
5552021-04-20T21:42:31 <sipa> rather than "fee bumping is insufficient"
5562021-04-20T21:42:59 <ariard> like there is quite a divide among L1 and L2 devs, and afaik matt or rusty I'm leaning toward more reliability expectations
5572021-04-20T21:43:17 <ariard> sipa: see rusty point here : https://github.com/bitcoin/bitcoin/issues/13283#issuecomment-398654468
5582021-04-20T21:43:57 <ariard> sipa: ultimately if we release something like package relay we have a question on the L2-side, is how much stability we can expect of such mechanism
5592021-04-20T21:44:10 <sipa> ariard: yeah the vbyte thing wasn't done as well as it could have been
5602021-04-20T21:44:27 <sipa> ariard: you can't expect transactions to be relayed, period
5612021-04-20T21:44:53 <sipa> they're likely to be, and we can discuss what will work in non-adverserial settings likely
5622021-04-20T21:45:05 <ariard> sipa: i agree, the best you can hope is an economic compatible tx-relay policy widely deployed on the network like bip125
5632021-04-20T21:45:51 <sipa> i'm afraid that economic compatibility is very hard without something like partial blocks
5642021-04-20T21:46:21 <sipa> because network bandwidth costs are ultimately in contradiction with always relaying the economically optimal final state
5652021-04-20T21:46:27 <ariard> sipa: by stability I didn't mean "every-full-node on the network must support it" more Core devs are not going to deprecate future or introduce api change break without some release process
5662021-04-20T21:46:38 <ariard> sipa: i don't know about partial blocks?
5672021-04-20T21:46:41 <sipa> oh, certainly
5682021-04-20T21:46:41 <glozow> er, what does economic compatible tx relay mean?
5692021-04-20T21:47:05 <sipa> glozow: say a tx is bumped by 1 satoshi in fee
5702021-04-20T21:47:12 <ariard> glozow: let's define better as incentive-compatible, apply this policy will increase your mempool feerate
5712021-04-20T21:48:09 <sipa> it won't get relayed by bitcoin core, because it's below the marginal feerate (the cost of relaying over the network is considered larger than what it's paying extra
5722021-04-20T21:48:20 <jnewbery> ariard: I don't think that's even it. incentive-compatible would mean that this policy increases the total fee of the top block's worth of transactions in your mempool
5732021-04-20T21:49:02 <sipa> glozow: but it is economically still better for miners to get that transaction; miner want it, but the network has no incentive to relay it
5742021-04-20T21:49:24 <sipa> that's a conflict, and the only general solution for it i know of is partial blocks
5752021-04-20T21:49:53 <ariard> jnewbery: i think accepting higher-feerate replacement transaction increase the odds to mine a higher fee block in the future?
5762021-04-20T21:50:10 <amiti> what is the goal from today's discussion?
5772021-04-20T21:50:18 <sipa> where miners broadcast partial solutions to PoW over the network (say at 1/10th the difficulty) to prove to the network "there is likely a significant portion of PoW working on this block"
5782021-04-20T21:50:39 <sipa> that would provide a natural incentive to switch mempools to the contents of such a blocm
5792021-04-20T21:50:40 <glozow> sipa: i see, thank you
5802021-04-20T21:51:20 <jnewbery> ariard: that's not incentive compatible for a miner. They only care about the contents of the next block.
5812021-04-20T21:51:21 <ariard> amiti: getting the feedbacks of folks here if they would like to participate to such meetings, once we have a clear scope :)
5822021-04-20T21:52:09 <glozow> oh cool, similar to like mining pool partial solutions for reward shares
5832021-04-20T21:52:29 <jnewbery> ariard: when are you planning to do this irc meeting?
5842021-04-20T21:52:33 <glozow> like broadcasting "this is the block i'm working on" before finding the solution
5852021-04-20T21:52:40 <sipa> glozow: indeed
5862021-04-20T21:53:08 <ariard> jnewbery: depends of your miner model? even if they loss the race to mine next block, they are still willingly to optimize fee of following blocks
5872021-04-20T21:53:14 <jnewbery> any final topics before we wrap up?
5882021-04-20T21:53:25 <ariard> jnewbery: end of may/june
5892021-04-20T21:53:35 <jnewbery> ariard: thanks!
5902021-04-20T21:53:47 <ariard> i'm done, thanks for your feedbacks :)
5912021-04-20T21:53:48 <sipa> glozow: and partial PoW means a natural rate limit for such partial blovks
5922021-04-20T21:54:00 <glozow> ariard: I'm interested in such a meeting if you're able to coordinate a time
5932021-04-20T21:54:01 <glozow> apart from that, I'll keep an eye on the docs in your repo, and am interested in turning some of them into functional tests or simulations for a more concrete measure of the attacks
5942021-04-20T21:54:27 <ariard> glozow: coool let me get back to you to do simulation of attacks!
5952021-04-20T21:54:51 <amiti> I'd be happy to participate if there was a clear scope, agenda & goals. I agree with sipa that its hard to make much progress in a purely abstract conversation.
5962021-04-20T21:55:07 <amiti> (around p2p guarantees)
5972021-04-20T21:55:21 <darosior> ariard: (re-mentioning here) happy to participate too
5982021-04-20T21:55:24 <ariard> amiti: that's the reason of braindumping in a repo to avoid abstract conversation (and working on attacks simulation)
5992021-04-20T21:55:35 <amiti> cool!
6002021-04-20T21:56:06 <jnewbery> seems like that's all. Thanks everyone!
6012021-04-20T21:56:09 <jnewbery> #endmeeting
6022021-04-20T21:56:09 <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
6032021-04-20T21:56:09 <core-meetingbot> Meeting ended Tue Apr 20 21:56:09 2021 UTC.
6042021-04-20T21:56:09 <core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-04-20-21.01.moin.txt
6052021-04-20T21:56:19 <glozow> thanks jnewbery
6062021-04-20T21:59:38 *** lightlike <lightlike!~lightlike@p200300c7ef19db0020d8eadad0ae1a50.dip0.t-ipconnect.de> has quit IRC (Quit: Leaving)
6072021-04-20T22:06:29 *** hirish_ <hirish_!~hirish@ip85.ip-137-74-20.eu> has joined #bitcoin-core-dev
6082021-04-20T22:07:18 *** hirish <hirish!~hirish@ip85.ip-137-74-20.eu> has quit IRC (Quit: ZNC - https://znc.in)
6092021-04-20T22:08:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6102021-04-20T22:08:13 <bitcoin-git> [gui] RandyMcMillan closed pull request #147: splash: New layout (master...splash) https://github.com/bitcoin-core/gui/pull/147
6112021-04-20T22:08:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6122021-04-20T22:08:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6132021-04-20T22:08:43 <bitcoin-git> [gui] RandyMcMillan closed pull request #208: docs: update README notes for /interfaces (master...interfaces-notes) https://github.com/bitcoin-core/gui/pull/208
6142021-04-20T22:08:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6152021-04-20T22:09:07 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6162021-04-20T22:09:08 <bitcoin-git> [gui] RandyMcMillan closed pull request #231: splash: new layout and new icon (master...new-icon) https://github.com/bitcoin-core/gui/pull/231
6172021-04-20T22:09:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6182021-04-20T23:01:05 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
6192021-04-20T23:06:07 *** proofofkeags_ <proofofkeags_!~proofofke@c-75-70-131-96.hsd1.co.comcast.net> has joined #bitcoin-core-dev
6202021-04-20T23:06:08 *** cguida1 <cguida1!~Adium@c-75-70-131-96.hsd1.co.comcast.net> has joined #bitcoin-core-dev
6212021-04-20T23:07:26 *** cguida <cguida!~Adium@c-75-70-131-96.hsd1.co.comcast.net> has quit IRC (Ping timeout: 245 seconds)
6222021-04-20T23:07:53 *** proofofkeags <proofofkeags!~proofofke@c-75-70-131-96.hsd1.co.comcast.net> has quit IRC (Ping timeout: 240 seconds)
6232021-04-20T23:23:38 *** owowo <owowo!~ovovo@unaffiliated/ovovo> has joined #bitcoin-core-dev
6242021-04-20T23:25:01 *** ovovo <ovovo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 260 seconds)
6252021-04-20T23:28:43 *** instagibbs <instagibbs!~greg@119247204116.ctinets.com> has quit IRC (Quit: Leaving)
6262021-04-20T23:30:41 *** ariard_ <ariard_!~ariard@167.99.46.220> has joined #bitcoin-core-dev
6272021-04-20T23:32:08 *** ariard <ariard!sid491650@gateway/web/irccloud.com/x-jbqoldgekvoxdsjd> has quit IRC ()
6282021-04-20T23:33:50 *** cguida1 <cguida1!~Adium@c-75-70-131-96.hsd1.co.comcast.net> has quit IRC (Quit: Leaving.)
6292021-04-20T23:35:04 *** ariard_ <ariard_!~ariard@167.99.46.220> has left #bitcoin-core-dev
6302021-04-20T23:36:07 *** ariard <ariard!~ariard@167.99.46.220> has joined #bitcoin-core-dev
6312021-04-20T23:38:26 *** dviola <dviola!~diego@unaffiliated/dviola> has quit IRC (Ping timeout: 260 seconds)
6322021-04-20T23:39:45 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
6332021-04-20T23:42:24 *** duringo <duringo!ad004d0f@173.0.77.15> has joined #bitcoin-core-dev
6342021-04-20T23:45:54 *** dviola <dviola!~diego@187.39.20.53> has joined #bitcoin-core-dev
6352021-04-20T23:51:08 *** asoltys_ <asoltys_!~root@s207-81-214-2.bc.hsia.telus.net> has quit IRC (Quit: leaving)
6362021-04-20T23:51:27 *** asoltys <asoltys!~root@s207-81-214-2.bc.hsia.telus.net> has joined #bitcoin-core-dev
6372021-04-20T23:55:43 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 260 seconds)
6382021-04-20T23:57:50 *** nn <nn!2d84e161@45.132.225.97> has joined #bitcoin-core-dev