12021-05-20T00:01:52  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
  22021-05-20T00:04:41  *** molz_ <molz_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
  32021-05-20T00:06:05  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
  42021-05-20T00:07:22  *** TheRec <TheRec!~toto@drupal.org/user/146860/view> has quit IRC ()
  52021-05-20T00:08:26  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 246 seconds)
  62021-05-20T00:23:39  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
  72021-05-20T00:26:18  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
  82021-05-20T00:26:58  *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
  92021-05-20T00:28:42  <wumpus> #bitcoin-core-dev, #bitcoin-builds, #bitcoin-core-pr-reviews have been reserved at least, if you need any more let me know
 102021-05-20T00:29:53  <wumpus> or kinlo
 112021-05-20T00:45:38  <aj> #bitcoin-anything is reserved apparently, i tried registering bitcoin-signet. presuably kalle can set it up if desired
 122021-05-20T00:57:11  *** proofofkeags <proofofkeags!~proofofke@> has quit IRC (Ping timeout: 240 seconds)
 132021-05-20T01:01:53  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
 142021-05-20T01:04:54  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
 152021-05-20T01:06:36  *** hirish <hirish!~hirish@ip85.ip-137-74-20.eu> has quit IRC (Quit: ZNC - https://znc.in)
 162021-05-20T01:10:24  *** jpe <jpe!~jpe@2001:16b8:5cb5:ec00:c516:ad22:ee7:f9cf> has quit IRC (Ping timeout: 245 seconds)
 172021-05-20T01:10:49  *** jpe__ <jpe__!~jpe@2001:16b8:5cb5:ec00:c516:ad22:ee7:f9cf> has quit IRC (Ping timeout: 245 seconds)
 182021-05-20T01:10:57  *** jpe <jpe!~jpe@2001:16b8:5c44:2f00:874e:5a2f:2a8a:8e0d> has joined #bitcoin-core-dev
 192021-05-20T01:11:26  *** jpe__ <jpe__!~jpe@2001:16b8:5c44:2f00:874e:5a2f:2a8a:8e0d> has joined #bitcoin-core-dev
 202021-05-20T01:13:09  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
 212021-05-20T01:13:48  *** hirish <hirish!~hirish@ip85.ip-137-74-20.eu> has joined #bitcoin-core-dev
 222021-05-20T01:17:55  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Quit: Leaving.)
 232021-05-20T01:18:28  <jeremyrubin> wumpus: ##ctv-bip-review, ##taproot{-bip-review,activation,}, ##miniscript, #sapio, #bitcoin-workshops, #bitmetas, #rust-bitcoin are all maybe good to nab if you can reserve them?
 242021-05-20T01:19:33  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
 252021-05-20T01:20:34  *** molz_ <molz_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
 262021-05-20T01:23:25  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
 272021-05-20T01:23:26  *** d <d!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
 282021-05-20T01:23:41  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
 292021-05-20T01:23:47  *** d is now known as Guest48619
 302021-05-20T01:25:09  *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has quit IRC (Ping timeout: 240 seconds)
 312021-05-20T01:25:23  *** molz_ <molz_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 265 seconds)
 322021-05-20T01:30:49  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 332021-05-20T02:09:19  *** niftynei <niftynei!~niftynei@> has quit IRC (Quit: ZNC - http://znc.in)
 342021-05-20T02:10:22  *** niftynei <niftynei!~niftynei@> has joined #bitcoin-core-dev
 352021-05-20T02:15:59  *** dviola <dviola!~diego@unaffiliated/dviola> has quit IRC (Quit: WeeChat 3.1)
 362021-05-20T02:17:30  *** niftynei <niftynei!~niftynei@> has quit IRC (Quit: ZNC - http://znc.in)
 372021-05-20T02:18:00  *** TheRec <TheRec!~toto@drupal.org/user/146860/view> has quit IRC ()
 382021-05-20T02:18:18  *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
 392021-05-20T02:18:40  *** niftynei <niftynei!~niftynei@> has joined #bitcoin-core-dev
 402021-05-20T02:25:48  *** undvrainbowvita8 is now known as white_green_ligh
 412021-05-20T02:25:56  *** white_green_ligh is now known as whitegreenlights
 422021-05-20T02:26:13  *** whitegreenlights is now known as whitgreenlightsa
 432021-05-20T02:26:19  *** whitgreenlightsa is now known as whitgreenlghtsbr
 442021-05-20T02:28:58  *** whitgreenlghtsbr <whitgreenlghtsbr!~egp_@128-71-13-3.broadband.corbina.ru> has quit IRC (Quit: EXIT)
 452021-05-20T02:29:31  *** whitgreenlghtsbr <whitgreenlghtsbr!~egp_@128-71-13-3.broadband.corbina.ru> has joined #bitcoin-core-dev
 462021-05-20T02:52:21  *** several27 <several27!881877e0@136-24-119-224.cab.webpass.net> has joined #bitcoin-core-dev
 472021-05-20T02:53:29  *** several27 <several27!881877e0@136-24-119-224.cab.webpass.net> has quit IRC (Client Quit)
 482021-05-20T02:57:23  *** Guest48619 is now known as davterra
 492021-05-20T03:07:56  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
 502021-05-20T03:08:13  <emcy> get the fuck outta here fresh prince
 512021-05-20T03:17:17  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
 522021-05-20T03:18:12  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
 532021-05-20T03:19:22  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
 542021-05-20T03:26:50  *** dhruvm <dhruvm!~dhruv@> has joined #bitcoin-core-dev
 552021-05-20T03:33:42  *** proofofkeags <proofofkeags!~proofofke@97-118-239-55.hlrn.qwest.net> has joined #bitcoin-core-dev
 562021-05-20T03:35:54  <BlueMatt> jeremyrubin: note that libera is doing aggressive registration of #X-*
 572021-05-20T03:36:13  <BlueMatt> jeremyrubin: relevant bitcoiners have the "bitcoin" group registered, so it probably makes sense to move more towards #bitcoin-X
 582021-05-20T03:36:33  <BlueMatt> jeremyrubin: eg, I'm suggesting #rust-bitcoin move to #bitcoin-rust (as #rust-* is technically owned by anyone who registers a rust organization)
 592021-05-20T03:38:00  *** niftynei <niftynei!~niftynei@> has quit IRC (Quit: ZNC - http://znc.in)
 602021-05-20T03:39:13  <gwillen> BlueMatt: are they actually more organized about it than freenode was? The documentation claims you need a group registration to get a single-hash prefix but that doesn't actually seem to be enforced by chanserv any more than it was here
 612021-05-20T03:39:16  *** niftynei <niftynei!~niftynei@> has joined #bitcoin-core-dev
 622021-05-20T03:39:37  <BlueMatt> gwillen: hmm, dunno? It seems like the whole thing was somewhat of a massive rushjob
 632021-05-20T03:39:50  <BlueMatt> gwillen: I mean the servers only came online like, today, so....who knows
 642021-05-20T03:39:53  <gwillen> I mean they just copied a lot of the documentation from freenode I think
 652021-05-20T03:40:02  <gwillen> but the group system on freenode has always been sort of aspirational at best
 662021-05-20T03:40:07  <BlueMatt> right
 672021-05-20T03:40:07  <gwillen> and they don't have any more staff, so
 682021-05-20T03:41:52  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 692021-05-20T03:42:24  *** ariard_ <ariard_!~ariard@> has joined #bitcoin-core-dev
 702021-05-20T03:53:19  *** mart <mart!~mart@c-76-97-33-113.hsd1.ga.comcast.net> has joined #bitcoin-core-dev
 712021-05-20T03:54:00  *** ariard__ <ariard__!~ariard@> has joined #bitcoin-core-dev
 722021-05-20T03:56:16  *** ariard__ <ariard__!~ariard@> has left #bitcoin-core-dev
 732021-05-20T03:58:57  *** ariard__ <ariard__!~ariard@> has joined #bitcoin-core-dev
 742021-05-20T04:01:06  *** ariard__ <ariard__!~ariard@> has left #bitcoin-core-dev
 752021-05-20T04:06:53  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
 762021-05-20T04:08:19  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
 772021-05-20T04:12:28  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 252 seconds)
 782021-05-20T04:21:49  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
 792021-05-20T04:24:49  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
 802021-05-20T04:26:13  *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
 812021-05-20T04:27:41  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Remote host closed the connection)
 822021-05-20T04:28:06  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
 832021-05-20T04:56:05  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
 842021-05-20T04:56:27  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
 852021-05-20T04:57:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 862021-05-20T04:57:22  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #21875: doc: fix spelling (master...fix-spelling) https://github.com/bitcoin/bitcoin/pull/21875
 872021-05-20T04:57:23  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
 882021-05-20T04:57:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 892021-05-20T04:59:35  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
 902021-05-20T05:19:45  *** bob52 <bob52!2d4fe47d@> has joined #bitcoin-core-dev
 912021-05-20T05:23:22  *** bob52 <bob52!2d4fe47d@> has left #bitcoin-core-dev
 922021-05-20T05:25:36  *** whitgreenlghtsbr <whitgreenlghtsbr!~egp_@128-71-13-3.broadband.corbina.ru> has quit IRC (Ping timeout: 265 seconds)
 932021-05-20T05:28:04  *** faketoshi <faketoshi!~quassel@> has joined #bitcoin-core-dev
 942021-05-20T05:28:04  *** bcman <bcman!~quassel@> has quit IRC (Read error: Connection reset by peer)
 952021-05-20T05:28:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 962021-05-20T05:28:33  <bitcoin-git> [bitcoin] patrickkamin opened pull request #22001: doc: Generate doxygen documentation for test sources (master...issue/19248) https://github.com/bitcoin/bitcoin/pull/22001
 972021-05-20T05:28:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 982021-05-20T05:35:22  *** mips <mips!~mips@gateway/tor-sasl/mips> has joined #bitcoin-core-dev
 992021-05-20T05:35:54  *** beefcadet <beefcadet!~KAblam@8-bit.pixelfucker.com> has joined #bitcoin-core-dev
1002021-05-20T05:37:19  *** faketoshi <faketoshi!~quassel@> has quit IRC (Read error: Connection reset by peer)
1012021-05-20T05:37:43  *** bcman <bcman!~quassel@> has joined #bitcoin-core-dev
1022021-05-20T05:44:30  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
1032021-05-20T05:45:00  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
1042021-05-20T05:45:50  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
1052021-05-20T05:46:20  *** jungly <jungly!~jungly@host-79-12-190-192.retail.telecomitalia.it> has joined #bitcoin-core-dev
1062021-05-20T05:47:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1072021-05-20T05:47:15  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
1082021-05-20T05:47:16  <bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/7d19c85f4a27...ea8b2e8e127b
1092021-05-20T05:47:16  <bitcoin-git> bitcoin/master eb4fb7e Karl-Johan Alm: rpc/gettxoutsetinfo: hash_or_height is a named argument
1102021-05-20T05:47:17  <bitcoin-git> bitcoin/master c8cf0a3 Karl-Johan Alm: rpc/getpeerinfo: bytesrecv_per_msg is a dynamic dictionary
1112021-05-20T05:47:18  <bitcoin-git> bitcoin/master dc4db23 Karl-Johan Alm: rpc: address:amount dictionaries are OBJ_USER_KEYS
1122021-05-20T05:47:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1132021-05-20T05:47:31  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 268 seconds)
1142021-05-20T05:47:35  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1152021-05-20T05:47:35  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #21913: rpc: RPCHelpMan fixes (master...202104-rpchelpman-fixes2) https://github.com/bitcoin/bitcoin/pull/21913
1162021-05-20T05:47:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1172021-05-20T05:48:49  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
1182021-05-20T05:55:44  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
1192021-05-20T05:58:19  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 245 seconds)
1202021-05-20T05:58:31  *** OJD <OJD!~OJDz@ool-182e587b.dyn.optonline.net> has joined #bitcoin-core-dev
1212021-05-20T06:04:45  *** Kiminuo <Kiminuo!~Kiminuo@> has joined #bitcoin-core-dev
1222021-05-20T06:07:21  *** proofofkeags <proofofkeags!~proofofke@97-118-239-55.hlrn.qwest.net> has quit IRC (Ping timeout: 260 seconds)
1232021-05-20T06:09:47  *** mips <mips!~mips@gateway/tor-sasl/mips> has quit IRC (Remote host closed the connection)
1242021-05-20T06:10:32  *** OJD <OJD!~OJDz@ool-182e587b.dyn.optonline.net> has quit IRC (Quit: Leaving)
1252021-05-20T06:15:11  *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has quit IRC (Read error: Connection reset by peer)
1262021-05-20T06:16:56  *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has joined #bitcoin-core-dev
1272021-05-20T06:25:39  *** whitgreenlghtsbr <whitgreenlghtsbr!~egp_@> has joined #bitcoin-core-dev
1282021-05-20T06:27:15  *** copumpkin <copumpkin!~copumpkin@unaffiliated/copumpkin> has quit IRC (Quit: Bye!)
1292021-05-20T06:31:47  *** copumpkin <copumpkin!~copumpkin@unaffiliated/copumpkin> has joined #bitcoin-core-dev
1302021-05-20T06:51:54  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
1312021-05-20T06:54:11  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
1322021-05-20T06:57:15  *** mrostecki <mrostecki!mrostecki@nat/suse/x-juoebxjtvfdhcbor> has quit IRC (Quit: WeeChat 1.8)
1332021-05-20T07:31:35  <vasild> https://libera.chat/guides/connect -- "Libera.Chat is not yet accessible by TOR but we intend to have this available soon.", trying to connect to irc.libera.chat via tor results in "You are banned from this server- Your Tor exit node must not allow connections to libera.chat. Email tor-kline@libera.chat for assistance."
1342021-05-20T07:34:07  *** amiti <amiti!sid373138@gateway/web/irccloud.com/x-vulccgszmcouznhh> has quit IRC (Ping timeout: 245 seconds)
1352021-05-20T07:34:30  <gwillen> vasild: from the phrasing I assume they intend to set up an onion service
1362021-05-20T07:34:35  *** schmidty <schmidty!sid297174@gateway/web/irccloud.com/x-grxxejclczikvdde> has quit IRC (Ping timeout: 260 seconds)
1372021-05-20T07:34:35  *** dergoegge <dergoegge!sid453889@gateway/web/irccloud.com/x-czxarejeuzvlyufi> has quit IRC (Ping timeout: 260 seconds)
1382021-05-20T07:34:38  *** arik__ <arik__!sid402902@gateway/web/irccloud.com/x-zooiexohjqornpgx> has quit IRC (Read error: Connection reset by peer)
1392021-05-20T07:34:52  *** beefcadet <beefcadet!~KAblam@8-bit.pixelfucker.com> has quit IRC (Ping timeout: 252 seconds)
1402021-05-20T07:34:57  *** Isthmus <Isthmus!sid302307@gateway/web/irccloud.com/x-lmuijapodzjsgcuk> has quit IRC (Ping timeout: 245 seconds)
1412021-05-20T07:35:00  *** prusnak <prusnak!sid403625@gateway/web/irccloud.com/x-wzqhjrpgybilcnwl> has quit IRC (Read error: Connection reset by peer)
1422021-05-20T07:35:03  <hebasto> wumpus: maybe reserve #bitcoin-core-gui as well?
1432021-05-20T07:35:08  <vasild> gwillen: yes, "soon"
1442021-05-20T07:35:47  *** Guest64813 <Guest64813!sid14086@gateway/web/irccloud.com/x-yidfjwsshibehnxn> has quit IRC (Ping timeout: 245 seconds)
1452021-05-20T07:35:47  *** Guest17882 <Guest17882!sid14316@gateway/web/irccloud.com/x-fnggfbjxyeacdwio> has quit IRC (Ping timeout: 245 seconds)
1462021-05-20T07:36:14  <gwillen> hebasto: I recommend just go ahead and do it if you think it might be useful, you can always hand it off later
1472021-05-20T07:36:19  *** pierre_rochard <pierre_rochard!sid299882@gateway/web/irccloud.com/x-ygzrmcocqptckjpt> has quit IRC (Ping timeout: 250 seconds)
1482021-05-20T07:36:27  <gwillen> mentioning things to reserve in public spaces before actually reserving them is a dangerous game ;-)
1492021-05-20T07:36:38  <gwillen> if the wrong people are listening.
1502021-05-20T07:36:45  *** th3ph3d <th3ph3d!sid300152@dc801/th3ph3d> has quit IRC (Ping timeout: 250 seconds)
1512021-05-20T07:36:49  *** Galvas <Galvas!sid459296@gateway/web/irccloud.com/x-svlucrzaqjuqvzcu> has quit IRC (Ping timeout: 276 seconds)
1522021-05-20T07:37:17  *** amiti <amiti!sid373138@gateway/web/irccloud.com/x-dwlrnxjminmpxqhh> has joined #bitcoin-core-dev
1532021-05-20T07:37:18  *** th3ph3d <th3ph3d!sid300152@dc801/th3ph3d> has joined #bitcoin-core-dev
1542021-05-20T07:37:24  *** Isthmus <Isthmus!sid302307@gateway/web/irccloud.com/x-sbuiglhocrvamuma> has joined #bitcoin-core-dev
1552021-05-20T07:37:24  *** arik__ <arik__!sid402902@gateway/web/irccloud.com/x-uohrymhfcajfojnv> has joined #bitcoin-core-dev
1562021-05-20T07:37:29  *** prusnak <prusnak!sid403625@gateway/web/irccloud.com/x-aclzvtmjrwcnlrih> has joined #bitcoin-core-dev
1572021-05-20T07:37:32  *** pierre_rochard <pierre_rochard!sid299882@gateway/web/irccloud.com/x-xcelhzbnfxkemrto> has joined #bitcoin-core-dev
1582021-05-20T07:37:34  *** schmidty <schmidty!sid297174@gateway/web/irccloud.com/x-sbuxkaywcneyulpk> has joined #bitcoin-core-dev
1592021-05-20T07:37:37  *** hugohn <hugohn!sid304114@gateway/web/irccloud.com/x-cwmqkdcoqbpkiouc> has quit IRC (Ping timeout: 250 seconds)
1602021-05-20T07:37:41  *** dergoegge <dergoegge!sid453889@gateway/web/irccloud.com/x-qyleughbhpeypguv> has joined #bitcoin-core-dev
1612021-05-20T07:37:43  *** Guest17882 <Guest17882!sid14316@gateway/web/irccloud.com/x-osqwfhvyebhztqex> has joined #bitcoin-core-dev
1622021-05-20T07:37:59  <gwillen> (I just popped into it to hold it, I haven't registered it but I'm holding ops and can hand them off to one of you guys)
1632021-05-20T07:38:02  *** Guest64813 <Guest64813!sid14086@gateway/web/irccloud.com/x-qgkhdcbjijinqogx> has joined #bitcoin-core-dev
1642021-05-20T07:38:07  <kinlo> I can handle reservation for #bitcoin-* channels
1652021-05-20T07:38:38  <gwillen> ahh right, I forget there's group registration
1662021-05-20T07:39:08  <hebasto> kinlo: see my message above
1672021-05-20T07:40:34  *** hugohn <hugohn!sid304114@gateway/web/irccloud.com/x-smgvedjqstsvfqqb> has joined #bitcoin-core-dev
1682021-05-20T07:40:49  *** Galvas <Galvas!sid459296@gateway/web/irccloud.com/x-hrfvgfzndmqxmrfv> has joined #bitcoin-core-dev
1692021-05-20T07:42:41  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
1702021-05-20T07:43:27  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
1712021-05-20T07:44:55  *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f17c5008054305c1f5681d7.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
1722021-05-20T07:54:44  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Quit: leaving)
1732021-05-20T08:00:16  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
1742021-05-20T08:05:48  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Remote host closed the connection)
1752021-05-20T08:06:01  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
1762021-05-20T08:06:14  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Client Quit)
1772021-05-20T08:06:25  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
1782021-05-20T08:07:37  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Client Quit)
1792021-05-20T08:09:25  *** b10c_ <b10c_!uid500648@gateway/web/irccloud.com/x-jdnfvtcslclegqdv> has joined #bitcoin-core-dev
1802021-05-20T08:15:59  *** jarthur_ <jarthur_!~jarthur@2603-8080-1540-002d-a1f4-7a0c-77c0-2833.res6.spectrum.com> has joined #bitcoin-core-dev
1812021-05-20T08:16:24  *** jarthur_ <jarthur_!~jarthur@2603-8080-1540-002d-a1f4-7a0c-77c0-2833.res6.spectrum.com> has quit IRC (Client Quit)
1822021-05-20T08:17:40  *** romanz <romanz!~romanz@> has quit IRC (Quit: WeeChat 2.3)
1832021-05-20T08:19:11  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-d161-31c0-12d1-b80a.res6.spectrum.com> has quit IRC (Ping timeout: 258 seconds)
1842021-05-20T08:22:20  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
1852021-05-20T08:22:41  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
1862021-05-20T08:24:18  *** visser_ <visser_!~visser_@> has quit IRC (Remote host closed the connection)
1872021-05-20T08:27:15  *** marcoagner <marcoagner!~user@2001:8a0:ffc6:8700:fbe1:d95d:7692:d3c7> has joined #bitcoin-core-dev
1882021-05-20T08:29:17  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
1892021-05-20T08:37:50  *** dunxen <dunxen!dunxen@gateway/vpn/protonvpn/dunxen> has joined #bitcoin-core-dev
1902021-05-20T08:38:38  *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has quit IRC (Remote host closed the connection)
1912021-05-20T08:39:03  *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
1922021-05-20T08:52:05  <real_or_random> shouldn't bitcoin and bitcoin-core be different namespaces even?
1932021-05-20T08:55:15  <real_or_random> (I mean... I guess they're not. But do we want different namespaces?)
1942021-05-20T09:03:37  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
1952021-05-20T09:08:42  *** patryk_ <patryk_!~patryk_@> has joined #bitcoin-core-dev
1962021-05-20T09:15:55  *** flag <flag!~flag@net-5-94-131-75.cust.vodafonedsl.it> has quit IRC (Quit: leaving)
1972021-05-20T09:16:06  *** dunxen <dunxen!dunxen@gateway/vpn/protonvpn/dunxen> has quit IRC (Remote host closed the connection)
1982021-05-20T09:16:18  *** dunxen <dunxen!dunxen@gateway/vpn/protonvpn/dunxen> has joined #bitcoin-core-dev
1992021-05-20T09:20:48  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2002021-05-20T09:21:50  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
2012021-05-20T09:23:19  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 245 seconds)
2022021-05-20T09:24:05  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
2032021-05-20T09:25:48  <jnewbery> #proposedmeetingtopic remove fuzzer from CI jobs
2042021-05-20T09:34:34  *** ossifrage <ossifrage!~ossifrage@unaffiliated/ossifrage> has quit IRC (Remote host closed the connection)
2052021-05-20T09:34:56  *** ossifrage <ossifrage!~ossifrage@pool-72-78-189-30.phlapa.fios.verizon.net> has joined #bitcoin-core-dev
2062021-05-20T09:36:42  *** vincenzopalazzo <vincenzopalazzo!~vincenzop@host-79-23-113-134.retail.telecomitalia.it> has joined #bitcoin-core-dev
2072021-05-20T09:37:53  *** jungly <jungly!~jungly@host-79-12-190-192.retail.telecomitalia.it> has quit IRC (Ping timeout: 246 seconds)
2082021-05-20T09:44:52  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
2092021-05-20T09:48:02  <hebasto> real_or_random: thinking the same
2102021-05-20T09:48:06  *** dunxen <dunxen!dunxen@gateway/vpn/protonvpn/dunxen> has quit IRC (Quit: Leaving...)
2112021-05-20T09:49:24  *** lukaz <lukaz!~greenluka@> has quit IRC (Ping timeout: 252 seconds)
2122021-05-20T09:49:57  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
2132021-05-20T09:52:00  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
2142021-05-20T10:10:27  *** _nick_ <_nick_!~nick@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
2152021-05-20T10:18:31  *** Lia52Wisoky <Lia52Wisoky!~Lia52Wiso@static.> has joined #bitcoin-core-dev
2162021-05-20T10:19:11  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
2172021-05-20T10:27:46  *** Lia52Wisoky <Lia52Wisoky!~Lia52Wiso@static.> has quit IRC (Ping timeout: 240 seconds)
2182021-05-20T10:33:19  *** pox <pox!~pox@gateway/tor-sasl/pox> has quit IRC (Quit: pox)
2192021-05-20T10:34:08  *** pox <pox!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
2202021-05-20T10:35:46  *** _nick_ <_nick_!~nick@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Ping timeout: 240 seconds)
2212021-05-20T10:36:42  *** contagious_meow <contagious_meow!~contagiou@> has joined #bitcoin-core-dev
2222021-05-20T10:47:02  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
2232021-05-20T10:48:17  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
2242021-05-20T10:55:24  *** murch <murch!~murch@gateway/tor-sasl/murch> has quit IRC (Remote host closed the connection)
2252021-05-20T10:55:56  *** contagious_meow <contagious_meow!~contagiou@> has quit IRC (Ping timeout: 260 seconds)
2262021-05-20T10:55:58  *** murch <murch!~murch@gateway/tor-sasl/murch> has joined #bitcoin-core-dev
2272021-05-20T10:58:26  *** contagious_meow <contagious_meow!~contagiou@> has joined #bitcoin-core-dev
2282021-05-20T10:59:21  *** sysadmin <sysadmin!~McCafe@> has joined #bitcoin-core-dev
2292021-05-20T11:00:40  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Read error: Connection reset by peer)
2302021-05-20T11:00:51  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
2312021-05-20T11:00:57  <sysadmin> This channel will be terminated. Any nicks remaining in the channel will also be terminated. This action cannot be undone. Please /connect to irc.butt.es and /join #gamme for more information.
2322021-05-20T11:02:01  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
2332021-05-20T11:03:12  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
2342021-05-20T11:07:49  <sysadmin> This channel will be terminated. Any nicks remaining in the channel will also be terminated. This action cannot be undone. Please /connect to irc.butt.es and /join #gamme for more information.
2352021-05-20T11:07:50  *** sysadmin <sysadmin!~McCafe@> has quit IRC (K-Lined)
2362021-05-20T11:08:10  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
2372021-05-20T11:08:36  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
2382021-05-20T11:13:06  *** network_operatio <network_operatio!~McCafe@> has joined #bitcoin-core-dev
2392021-05-20T11:13:35  *** network_operatio <network_operatio!~McCafe@> has quit IRC (K-Lined)
2402021-05-20T11:18:05  *** jungly <jungly!~jungly@host-79-12-190-192.retail.telecomitalia.it> has joined #bitcoin-core-dev
2412021-05-20T11:20:33  <michaelfolkson> ^ I think this from sysadmin is spam
2422021-05-20T11:21:52  *** mips <mips!~mips@gateway/tor-sasl/mips> has joined #bitcoin-core-dev
2432021-05-20T11:24:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2442021-05-20T11:24:10  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22002: Fix crash when parsing command line with -noincludeconf=0 (master...2105-parseCommandlineCrash) https://github.com/bitcoin/bitcoin/pull/22002
2452021-05-20T11:24:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2462021-05-20T11:37:06  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
2472021-05-20T11:39:33  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
2482021-05-20T11:43:44  *** mips <mips!~mips@gateway/tor-sasl/mips> has quit IRC (Quit: Leaving)
2492021-05-20T11:48:16  *** dviola <dviola!~diego@unaffiliated/dviola> has joined #bitcoin-core-dev
2502021-05-20T12:06:15  <Kiminuo> michaelfolkson, Will this channel stay or is something changing?
2512021-05-20T12:07:49  <michaelfolkson> Kiminuo: The last I heard/read we were claiming nicks and channels on Libera in case we move there but we are probably going to wait until the dust settles to decide whether we do
2522021-05-20T12:08:31  <Kiminuo> thanks for the info
2532021-05-20T12:08:44  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 245 seconds)
2542021-05-20T12:08:45  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
2552021-05-20T12:08:45  <michaelfolkson> I haven't heard anything regarding Freenode channels being terminated. I suspect this is highly unlikely despite the spam suggesting otherwise
2562021-05-20T12:09:07  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
2572021-05-20T12:09:19  <nkuttler> nothing was decided for #bitcoin* yet
2582021-05-20T12:09:42  <nkuttler> quite some channels are moving though, some to libera, some to oftc, others probably elsewhere
2592021-05-20T12:14:35  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 260 seconds)
2602021-05-20T12:22:14  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
2612021-05-20T12:23:02  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
2622021-05-20T12:24:14  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
2632021-05-20T12:27:04  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
2642021-05-20T12:28:02  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
2652021-05-20T12:31:10  *** molz_ <molz_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2662021-05-20T12:32:38  *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2672021-05-20T12:34:13  *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 260 seconds)
2682021-05-20T12:36:15  *** molz_ <molz_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 265 seconds)
2692021-05-20T12:50:05  *** pergaminho <pergaminho!~Cleber@> has joined #bitcoin-core-dev
2702021-05-20T12:50:52  *** lukaz <lukaz!~greenluka@> has joined #bitcoin-core-dev
2712021-05-20T12:56:37  *** jungly <jungly!~jungly@host-79-12-190-192.retail.telecomitalia.it> has quit IRC (Ping timeout: 260 seconds)
2722021-05-20T13:00:04  *** ghost43_ <ghost43_!~daer@gateway/tor-sasl/daer> has quit IRC (Remote host closed the connection)
2732021-05-20T13:00:05  *** openoms <openoms!~quassel@gateway/tor-sasl/openoms> has quit IRC (Remote host closed the connection)
2742021-05-20T13:00:05  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Write error: Connection reset by peer)
2752021-05-20T13:00:05  *** morcos <morcos!~morcos@gateway/tor-sasl/morcos> has quit IRC (Write error: Connection reset by peer)
2762021-05-20T13:00:05  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has quit IRC (Remote host closed the connection)
2772021-05-20T13:00:05  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Remote host closed the connection)
2782021-05-20T13:00:05  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Remote host closed the connection)
2792021-05-20T13:00:05  *** ogo <ogo!~ogo@gateway/tor-sasl/ogo> has quit IRC (Read error: Connection reset by peer)
2802021-05-20T13:00:05  *** murch <murch!~murch@gateway/tor-sasl/murch> has quit IRC (Read error: Connection reset by peer)
2812021-05-20T13:00:05  *** rny <rny!~rny@gateway/tor-sasl/renlord> has quit IRC (Read error: Connection reset by peer)
2822021-05-20T13:00:05  *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has quit IRC (Read error: Connection reset by peer)
2832021-05-20T13:00:05  *** pox <pox!~pox@gateway/tor-sasl/pox> has quit IRC (Read error: Connection reset by peer)
2842021-05-20T13:00:05  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Read error: Connection reset by peer)
2852021-05-20T13:00:16  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
2862021-05-20T13:00:17  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has joined #bitcoin-core-dev
2872021-05-20T13:00:22  *** morcos <morcos!~morcos@gateway/tor-sasl/morcos> has joined #bitcoin-core-dev
2882021-05-20T13:00:24  *** murch <murch!~murch@gateway/tor-sasl/murch> has joined #bitcoin-core-dev
2892021-05-20T13:00:25  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
2902021-05-20T13:00:27  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
2912021-05-20T13:00:29  *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
2922021-05-20T13:00:29  *** rny <rny!~rny@gateway/tor-sasl/renlord> has joined #bitcoin-core-dev
2932021-05-20T13:00:31  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
2942021-05-20T13:00:32  *** ogo <ogo!~ogo@gateway/tor-sasl/ogo> has joined #bitcoin-core-dev
2952021-05-20T13:00:37  *** openoms <openoms!~quassel@gateway/tor-sasl/openoms> has joined #bitcoin-core-dev
2962021-05-20T13:00:39  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
2972021-05-20T13:00:49  *** nickler <nickler!~nickler@static.> has quit IRC (Quit: leaving)
2982021-05-20T13:00:52  *** pox <pox!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
2992021-05-20T13:02:58  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
3002021-05-20T13:11:27  *** contagious_meow <contagious_meow!~contagiou@> has quit IRC (Read error: Connection reset by peer)
3012021-05-20T13:11:52  *** contagious_meow <contagious_meow!~contagiou@> has joined #bitcoin-core-dev
3022021-05-20T13:13:37  *** nickler <nickler!~nickler@static.> has joined #bitcoin-core-dev
3032021-05-20T13:14:09  <Kiminuo> I'm interested in the process of "merging of PRs in Bitcoin Core repo" in general. So I understand that a PR needs a certain number of code review ACKs to be eligible for merging. But what happens then? What actually makes a person to click the "merge" button?
3042021-05-20T13:15:03  *** owowo <owowo!~ovovo@> has joined #bitcoin-core-dev
3052021-05-20T13:17:11  *** jungly <jungly!~jungly@host-79-12-190-192.retail.telecomitalia.it> has joined #bitcoin-core-dev
3062021-05-20T13:17:11  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
3072021-05-20T13:18:28  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
3082021-05-20T13:28:21  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
3092021-05-20T13:30:27  *** patryk_ <patryk_!~patryk_@> has quit IRC (Remote host closed the connection)
3102021-05-20T13:33:22  *** ogo <ogo!~ogo@gateway/tor-sasl/ogo> has quit IRC (Remote host closed the connection)
3112021-05-20T13:33:46  *** ogo <ogo!~ogo@gateway/tor-sasl/ogo> has joined #bitcoin-core-dev
3122021-05-20T13:35:01  <wumpus> real_or_random: no idea if libera supports recursive namespaces, tbh i'm fine with the bitcoin core channels being under the bitcoin namespace no need to make this too complicated
3132021-05-20T13:35:43  <real_or_random> Yeah I think both options are reasonable in the end.
3142021-05-20T13:36:44  <real_or_random> I just thought that we had the same story for websites, github orgs etc, so it would be logical to have a proper separation from the beginning on
3152021-05-20T13:37:28  <real_or_random> But in the end, chat is less official, and it's like with all the other services: we can switch if they go crazy.
3162021-05-20T13:38:03  <wumpus> Kiminuo: the goal in a PR is to get consensus for merging it, there's some judgement involved by a maintainer regarding risk of the change versus number and thoroughness of reviews
3172021-05-20T13:38:03  *** pergaminho <pergaminho!~Cleber@> has quit IRC (Read error: Connection reset by peer)
3182021-05-20T13:38:37  <wumpus> no one is constantly paying attention to the whole list though, so if you see something with a lot of ACKs that isn't merged yet feel free to bring it up
3192021-05-20T13:39:34  *** pergaminho <pergaminho!~Cleber@> has joined #bitcoin-core-dev
3202021-05-20T13:40:26  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Ping timeout: 240 seconds)
3212021-05-20T13:42:48  <Kiminuo> I see. So it basically depends on people with merge right when they feel good about a PR.
3222021-05-20T13:45:30  <Kiminuo> wumpus, Well, for example, https://github.com/bitcoin/bitcoin/pull/21850 this is a PR of mine where I'm currently thinking whether I should apply the suggestion https://github.com/bitcoin/bitcoin/pull/21850#pullrequestreview-655658498 or not. If I'll apply it now I'll lose ACKs, if I'll leave it as it is then it may be merged and my next PR will be easier to review. But I guess this is something people cope with often
3232021-05-20T13:46:22  *** pergaminho <pergaminho!~Cleber@> has quit IRC (Read error: Connection reset by peer)
3242021-05-20T13:47:03  <Kiminuo> But given that the merging process is a somewhat non-deterministic process from my side, I can't really decide, I guess.
3252021-05-20T13:47:03  <wumpus> mostly how they feel about the *comments on a PR*, if you see something you'd absolutely do not want to see merged it's really important to bring that up too
3262021-05-20T13:48:10  <wumpus> of course, merges are not final, if someone finds a problem after something is merged it's possible to revert
3272021-05-20T13:48:18  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
3282021-05-20T13:48:34  *** pergaminho <pergaminho!~Cleber@> has joined #bitcoin-core-dev
3292021-05-20T13:48:39  <wumpus> Kiminuo: let me see
3302021-05-20T13:48:57  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
3312021-05-20T13:49:35  <wumpus> in general i don't think 'losing ACKs' should be a reason not to do something if it's otherwise a valid comment, it's easy enough to review the diff again, at least if it is a small change
3322021-05-20T13:51:45  <Kiminuo> ok, so I'll try to address that. Thanks
3332021-05-20T13:53:48  <wumpus> in this case as the whole point of the PR is to come up with better naming, i guess it makes sense to incorporate the suggestion, instead of doing a big rename yet again afterward
3342021-05-20T13:54:58  <Kiminuo> right
3352021-05-20T13:56:14  *** coinfarmer <coinfarmer!b02a96b5@> has joined #bitcoin-core-dev
3362021-05-20T14:00:10  *** coinfarmer <coinfarmer!b02a96b5@> has quit IRC (Client Quit)
3372021-05-20T14:04:46  <wumpus> michaelfolkson: i think it's not 100% clear, the infrastructure for freenode is hosted by various parties who donate a server, what happens depends on whether they go along with the new situation
3382021-05-20T14:05:51  *** kers <kers!~kers@> has joined #bitcoin-core-dev
3392021-05-20T14:05:57  <wumpus> that said i doubt any will just pull the plug with 2 minutes notice
3402021-05-20T14:06:37  *** ggus <ggus!b5d72e70@> has joined #bitcoin-core-dev
3412021-05-20T14:06:47  *** ggus <ggus!b5d72e70@> has quit IRC (Client Quit)
3422021-05-20T14:06:56  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
3432021-05-20T14:06:57  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
3442021-05-20T14:08:24  *** ggus <ggus!~gus@> has joined #bitcoin-core-dev
3452021-05-20T14:09:37  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
3462021-05-20T14:11:22  <michaelfolkson> Kiminuo: You can always cc those who have already ACKed it asking for a re-ACK clearly explaining what has changed since they last ACKed and hopefully they'll be happy to re-ACK
3472021-05-20T14:13:36  <Kiminuo> michaelfolkson, Yeah. I kind of want to optimize my workflow for "not bothering others needlessly" but in this case it is probably justifiable.
3482021-05-20T14:15:53  <michaelfolkson> Kiminuo: Right especially as the time for the reviewer to re-ACK will be minimal in comparison to the time they needed to ACK it in the first place (assuming the change is relatively small which in this case it looks to be)
3492021-05-20T14:16:16  <Kiminuo> yeah, thanks
3502021-05-20T14:16:29  <ggus> hi all, this is gus from the tor project. i don't know if this is the right channel to ask, but very soon tor project will deprecate and remove v2 onion services. i've checked that ~15% of bitcoin nodes are running over tor and many of them are running v2 onion. do you have thoughts on how we could warn these node operators and help them migrate to v3 onion services?
3512021-05-20T14:17:48  <hebasto> Kiminuo: to make re-ACKing a bit easier to reviewers, you'd not want to rebase without conflicts as well
3522021-05-20T14:18:05  <vasild> ggus: Hello!
3532021-05-20T14:18:54  <Kiminuo> hebasto, Yes, you have made me aware of it. It didn't occur to me back then.
3542021-05-20T14:19:23  <aj> i have an alias ---> git rebase -i $(git merge-base HEAD origin/master)     <--- for when i want to edit my commits without changing the base commit to make comparison a little easier
3552021-05-20T14:20:10  <hebasto> Kiminuo: sorry if I repeat myself, it was not address to you personally, rather a general advice
3562021-05-20T14:20:37  <Kiminuo> hebasto, np, it's useful advice!
3572021-05-20T14:21:50  <ggus> hello, vasild!
3582021-05-20T14:21:50  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
3592021-05-20T14:21:51  <Kiminuo> How do you guys review force-pushes? I use Github CLI and "gh pr checkout <number>" and when it is force-pushed, I use "gh pr checkout --force <number>". Then do you use simply "git diff old-commit..force-pushed-commit"?
3602021-05-20T14:22:06  <vasild> ggus: on warning those node operators, I have no idea, maybe some mailing list or blog (that gets picked by news web sites) may help. On helping them migrate to v3 - there are two cases - 1. statically configured onion service in torrc, the users need to edit their torrc, no need to upgrade bitcoin core; 2. an onion service that is automatically created by bitcoin core - this will be switched
3612021-05-20T14:22:12  <vasild> automatically to v3, but an upgrade to bitcoin core 0.21 is needed
3622021-05-20T14:22:49  <hebasto> Kiminuo: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Developer-Notes-for-Qt-Code#reviewing-pull-request
3632021-05-20T14:23:36  <Kiminuo> hebasto, ah, that's super helpful. I missed that. Thanks!
3642021-05-20T14:23:48  <hebasto> you need `git range-diff ...`
3652021-05-20T14:24:41  <Kiminuo> Great. That will make my life simpler :)
3662021-05-20T14:24:47  <Kiminuo> b for now
3672021-05-20T14:24:48  *** Kiminuo <Kiminuo!~Kiminuo@> has quit IRC (Quit: Leaving)
3682021-05-20T14:25:02  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
3692021-05-20T14:28:05  <vasild> ggus: hmm, actually in the 1. case, if the user just edits torrc and changes the v2 onion service to v3, then an old bitcoin core (<0.21) would be able to accept incoming tor connections, but if it wants to make outgoing connections to v3 addresses, then an upgrade to >=0.21 is needed
3702021-05-20T14:28:39  <ggus> vasild: do you have suggestions of mailing lists or forums that we should announce this? for the news, we can contact some news outlet. And do you know which tools people are using to automatically deploy a bitcoin node, so we can contact the developers?
3712021-05-20T14:29:22  <ggus> vasild: about #2: amazing! so we just need to ask people to upgrade their bitcoin core software
3722021-05-20T14:29:26  <gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
3732021-05-20T14:31:14  <vasild> ggus: there is bitcoin-dev@lists.linuxfoundation.org but I doubt it is the best way to reach users, maybe others would have better ideas, wumpus?
3742021-05-20T14:35:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3752021-05-20T14:35:11  <bitcoin-git> [bitcoin] ajtowns opened pull request #22003: txmempool: add thread safety annotations (master...202105-mempoolguards) https://github.com/bitcoin/bitcoin/pull/22003
3762021-05-20T14:35:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3772021-05-20T14:36:46  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 258 seconds)
3782021-05-20T14:38:21  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
3792021-05-20T14:39:50  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
3802021-05-20T14:40:11  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 240 seconds)
3812021-05-20T14:40:37  *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
3822021-05-20T14:41:07  *** proofofkeags <proofofkeags!~proofofke@97-118-239-55.hlrn.qwest.net> has joined #bitcoin-core-dev
3832021-05-20T14:47:57  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
3842021-05-20T14:49:37  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
3852021-05-20T14:50:20  <wumpus> I can post to the notification list (bitcoin-core-dev) and to the bitcoin core twitter account (would make sense to PR a new blog item to bitcoincore.org first, so it's possible to post a link to that)
3862021-05-20T14:53:54  *** nckx <nckx!~nckx@tobias.gr> has left #bitcoin-core-dev
3872021-05-20T14:58:18  *** pergaminho <pergaminho!~Cleber@> has quit IRC (Quit: Saindo)
3882021-05-20T14:58:49  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
3892021-05-20T15:00:45  *** ogo <ogo!~ogo@gateway/tor-sasl/ogo> has quit IRC (Ping timeout: 240 seconds)
3902021-05-20T15:05:28  <ggus> wumpus: oh, that would be awesome! could you link to this blog post? https://blog.torproject.org/v2-deprecation-timeline
3912021-05-20T15:11:25  <wumpus> it would be more useful to have bitcoin specific instructions
3922021-05-20T15:12:33  <wumpus> i mean i think tor deprecating tor v2 hidden services is well known at this point to tor users (they have been pretty loud about it), but bitcoin users might not know what to do dunno
3932021-05-20T15:12:33  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
3942021-05-20T15:12:50  <ggus> wumpus: yes, agree.
3952021-05-20T15:13:48  *** ogo <ogo!~ogo@gateway/tor-sasl/ogo> has joined #bitcoin-core-dev
3962021-05-20T15:14:10  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
3972021-05-20T15:15:31  *** proofofkeags <proofofkeags!~proofofke@97-118-239-55.hlrn.qwest.net> has quit IRC (Ping timeout: 260 seconds)
3982021-05-20T15:18:10  <sipa> ggus: hello! what is the exact timeframe within which we might expect v2 services to start failing?
3992021-05-20T15:18:52  <sipa> oh, you linked that above - sorry, i was reading backlog
4002021-05-20T15:19:42  *** tandeningklement <tandeningklement!~tandening@> has joined #bitcoin-core-dev
4012021-05-20T15:20:35  <sipa> july 15 is the next step on the timeline, and we're scheduled to have our next major release in august (though from experience, it always might slip a few weeks)
4022021-05-20T15:21:09  <sipa> we should not forget to include a mention in our release notes
4032021-05-20T15:23:09  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
4042021-05-20T15:24:38  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
4052021-05-20T15:25:52  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Remote host closed the connection)
4062021-05-20T15:26:15  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
4072021-05-20T15:28:02  *** tandeningklement <tandeningklement!~tandening@> has quit IRC ()
4082021-05-20T15:28:22  *** tandeningklement <tandeningklement!~tandening@> has joined #bitcoin-core-dev
4092021-05-20T15:29:58  *** proofofkeags <proofofkeags!~proofofke@> has joined #bitcoin-core-dev
4102021-05-20T15:30:58  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
4112021-05-20T15:34:07  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 265 seconds)
4122021-05-20T15:34:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4132021-05-20T15:34:23  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22004: fuzz: Speed up transaction fuzz target (master...2105-fuzzTx) https://github.com/bitcoin/bitcoin/pull/22004
4142021-05-20T15:34:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4152021-05-20T15:47:30  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
4162021-05-20T15:49:22  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
4172021-05-20T15:57:19  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has quit IRC (Quit: Lost terminal)
4182021-05-20T15:57:27  <BlueMatt> sipa: does it make sense to remove support for v2 services then?
4192021-05-20T15:57:36  <BlueMatt> huh, bye sipa
4202021-05-20T15:58:42  <BlueMatt> anyway, presumably it makes sense to remove v2 service support ~now, not that I'm volunteering to do it
4212021-05-20T16:01:54  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
4222021-05-20T16:03:51  *** contagious_meow <contagious_meow!~contagiou@> has quit IRC (Read error: Connection reset by peer)
4232021-05-20T16:04:18  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
4242021-05-20T16:04:18  *** dviola <dviola!~diego@unaffiliated/dviola> has left #bitcoin-core-dev ("WeeChat 3.1")
4252021-05-20T16:05:14  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4262021-05-20T16:05:14  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22005: fuzz: Speed up banman fuzz target (master...2105-fuzzBanSpeed) https://github.com/bitcoin/bitcoin/pull/22005
4272021-05-20T16:05:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4282021-05-20T16:06:00  *** romanz <romanz!~romanz@2a10:8000:d484:0:3cc0:1955:7f8c:46c9> has joined #bitcoin-core-dev
4292021-05-20T16:06:45  *** romanz <romanz!~romanz@2a10:8000:d484:0:3cc0:1955:7f8c:46c9> has quit IRC (Client Quit)
4302021-05-20T16:20:58  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has joined #bitcoin-core-dev
4312021-05-20T16:25:47  *** proofofkeags_ <proofofkeags_!~proofofke@> has joined #bitcoin-core-dev
4322021-05-20T16:27:46  *** proofofkeags <proofofkeags!~proofofke@> has quit IRC (Ping timeout: 240 seconds)
4332021-05-20T16:28:21  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
4342021-05-20T16:29:35  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
4352021-05-20T16:34:23  <wumpus> ack on removing v2 suport
4362021-05-20T16:35:18  *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f17c5008054305c1f5681d7.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
4372021-05-20T16:36:57  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
4382021-05-20T16:38:47  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
4392021-05-20T16:39:47  <sipa> wumpus: i guess i missed something, but right, if v2 support is going to be removed imminently from tor, might as well remove it in v22.0
4402021-05-20T16:41:01  <wumpus> yes, i think so too
4412021-05-20T16:42:03  <wumpus> tor (master) already refuses to connect to v2 hidden services so if we don't, we'll likely get a lot of complaints about people seeing their log full of failed connection attempts
4422021-05-20T16:47:11  <vasild> https://blog.torproject.org/v2-deprecation-timeline -- it is a bit unclear to me when v2 support is going to be dropped network-wise
4432021-05-20T16:48:54  <vasild> in July 0.4.6.x will be released (without v2 support), but it will not be stable?
4442021-05-20T16:49:36  <vasild> and in October a stable version without v2 support will be released
4452021-05-20T16:51:50  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
4462021-05-20T16:51:53  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 246 seconds)
4472021-05-20T16:52:06  <vasild> I assume after Oct v2 services will start being unreachable, but what about tor nodes that run 0.4.5.x (which supports v2) after Oct?
4482021-05-20T16:52:17  *** owowo <owowo!~ovovo@2a02:29b8:dc01:1881::2e> has joined #bitcoin-core-dev
4492021-05-20T16:52:56  <vasild> maybe with some luck v2 services could be reachable even after Oct (if only old nodes are involved in the routing)?
4502021-05-20T16:53:03  <vasild> ggus: ^ correct?
4512021-05-20T16:54:12  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
4522021-05-20T16:59:23  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
4532021-05-20T17:02:48  <sipa> ggus: thanks for reaching out, in any case
4542021-05-20T17:04:52  <ggus> vasild: yes, with some luck they could be reachable, but we're expecting that almost all tor relays will not support v2 onions anymore in October.
4552021-05-20T17:05:18  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
4562021-05-20T17:07:42  *** emcy_ <emcy_!~emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
4572021-05-20T17:09:45  <ggus> sipa: next week we will have an invite only Tor AMA about v2 onion services deprecation. it would be important to have some of bitcore-devs present there. if you pm your email, i'll send the invitation.
4582021-05-20T17:10:46  *** tandeningklement <tandeningklement!~tandening@> has quit IRC ()
4592021-05-20T17:11:01  *** emcy <emcy!~emcy@unaffiliated/emcy> has quit IRC (Ping timeout: 260 seconds)
4602021-05-20T17:11:04  *** tandeningklement <tandeningklement!~tandening@> has joined #bitcoin-core-dev
4612021-05-20T17:12:44  *** emcy_ <emcy_!~emcy@unaffiliated/emcy> has quit IRC (Read error: Connection reset by peer)
4622021-05-20T17:14:27  *** emcy <emcy!~emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
4632021-05-20T17:16:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4642021-05-20T17:16:22  <bitcoin-git> [bitcoin] 0xB10C opened pull request #22006: tracing: first tracepoints and documentation on User-Space, Statically Defined Tracing (USDT) (master...2021-05-initial-usdt-support) https://github.com/bitcoin/bitcoin/pull/22006
4652021-05-20T17:16:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4662021-05-20T17:20:03  *** lulito <lulito!8f8959df@> has joined #bitcoin-core-dev
4672021-05-20T17:21:59  *** lulito67 <lulito67!8f8959df@> has joined #bitcoin-core-dev
4682021-05-20T17:22:17  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
4692021-05-20T17:22:58  *** lulito <lulito!8f8959df@> has quit IRC (Client Quit)
4702021-05-20T17:23:03  *** lulito67 <lulito67!8f8959df@> has quit IRC (Client Quit)
4712021-05-20T17:23:57  *** tandeningklement <tandeningklement!~tandening@> has quit IRC ()
4722021-05-20T17:27:29  *** luke <luke!~luke@bitnomial/staff/luke> has joined #bitcoin-core-dev
4732021-05-20T17:30:36  <sipa> wumpus, vasild: we should probably (but perhaps not immediately) stop relaying v2 addresses
4742021-05-20T17:30:52  <sipa> so they stop being rumoured and taking space in addrmans
4752021-05-20T17:31:00  <wumpus> right
4762021-05-20T17:36:06  *** emcy_ <emcy_!~emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
4772021-05-20T17:37:25  *** sysadmin <sysadmin!~McCafe@> has joined #bitcoin-core-dev
4782021-05-20T17:38:46  *** emcy <emcy!~emcy@unaffiliated/emcy> has quit IRC (Ping timeout: 240 seconds)
4792021-05-20T17:44:51  *** jungly <jungly!~jungly@host-79-12-190-192.retail.telecomitalia.it> has quit IRC (Ping timeout: 260 seconds)
4802021-05-20T17:49:02  <sipa> ggus: see PM, note that the project is called "bitcoin core"; there is an unrelated piece of software called bitcore too
4812021-05-20T17:57:27  <jonatack> catching up with the tor v2 discussion, i've been running bitcoind with tor- for a couple of months now that rejects v2 addresses
4822021-05-20T17:57:35  *** lightlike <lightlike!~lightlike@p200300c7ef193f00852cd8ab26120ff6.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
4832021-05-20T17:57:46  <jonatack> and working on removing v2 support
4842021-05-20T17:58:03  <jonatack> after discussions on doing this with wumpus and vasild
4852021-05-20T17:59:00  <jonatack> if someone else is also working on this, please let me know to coordinate
4862021-05-20T17:59:04  <wumpus> yes we discussed in #21351
4872021-05-20T17:59:06  <gribble> https://github.com/bitcoin/bitcoin/issues/21351 | net: No more v2 onion support in upstream Tor master · Issue #21351 · bitcoin/bitcoin · GitHub
4882021-05-20T17:59:12  *** dviola <dviola!~diego@unaffiliated/dviola> has joined #bitcoin-core-dev
4892021-05-20T17:59:33  <jonatack> wumpus: yes, that was the starting point for me running the new tor, have stayed with it since
4902021-05-20T18:01:13  *** luke <luke!~luke@bitnomial/staff/luke> has quit IRC (Quit: sleep)
4912021-05-20T18:07:08  *** network_operatio <network_operatio!~McCafe@> has joined #bitcoin-core-dev
4922021-05-20T18:07:08  *** network_operatio <network_operatio!~McCafe@> has quit IRC (Max SendQ exceeded)
4932021-05-20T18:07:32  *** network_operatio <network_operatio!~McCafe@> has joined #bitcoin-core-dev
4942021-05-20T18:10:13  *** sysadmin <sysadmin!~McCafe@> has quit IRC (Ping timeout: 260 seconds)
4952021-05-20T18:11:04  *** network_operatio <network_operatio!~McCafe@> has left #bitcoin-core-dev
4962021-05-20T18:11:04  *** network_operatio <network_operatio!~McCafe@> has joined #bitcoin-core-dev
4972021-05-20T18:11:06  <wumpus> same, it works for mainnet, but wasn't able to connect to testnet it would be nice to have v3 hardcoded seeds for testnet too (and remove the v2 ones), though i'm not aware of anyone even running one
4982021-05-20T18:11:40  *** network_operatio <network_operatio!~McCafe@> has quit IRC (Remote host closed the connection)
4992021-05-20T18:11:57  *** network_operatio <network_operatio!~McCafe@> has joined #bitcoin-core-dev
5002021-05-20T18:12:13  <jonatack> -addrinfo on testnet shows 24 v3 peers for me
5012021-05-20T18:12:26  <wumpus> great!
5022021-05-20T18:12:35  <jonatack> (and 15 on signet)
5032021-05-20T18:13:47  *** nickithename <nickithename!~Username@> has joined #bitcoin-core-dev
5042021-05-20T18:14:04  <jonatack> ah indeed, #21560 added on mainnet only
5052021-05-20T18:14:04  *** jungly <jungly!~jungly@host-79-12-190-192.retail.telecomitalia.it> has joined #bitcoin-core-dev
5062021-05-20T18:14:07  <gribble> https://github.com/bitcoin/bitcoin/issues/21560 | net: Add Tor v3 hardcoded seeds by laanwj · Pull Request #21560 · bitcoin/bitcoin · GitHub
5072021-05-20T18:16:21  <wumpus> yeh that was most urgent; the reason i'm bringing it up really is that contrib/seeds/nodes_test.txt *only* contains v2 onions, it also hasn't been touched since 2015 (besides adding port #'s), another option would be to just get rid of it
5082021-05-20T18:17:08  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
5092021-05-20T18:17:39  *** RandyMcMillan <RandyMcMillan!2578cb53@> has joined #bitcoin-core-dev
5102021-05-20T18:17:43  *** eris <eris!~McCafe@> has joined #bitcoin-core-dev
5112021-05-20T18:18:28  <jonatack> speaking of which, #21843 is probably rfm
5122021-05-20T18:18:30  <gribble> https://github.com/bitcoin/bitcoin/issues/21843 | p2p, rpc: enable GetAddr, GetAddresses, and getnodeaddresses by network by jonatack · Pull Request #21843 · bitcoin/bitcoin · GitHub
5132021-05-20T18:18:44  *** RandyMcMillan <RandyMcMillan!2578cb53@> has quit IRC (Client Quit)
5142021-05-20T18:19:22  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
5152021-05-20T18:19:49  *** RandyMcMillan <RandyMcMillan!2578cb53@> has joined #bitcoin-core-dev
5162021-05-20T18:19:54  <jonatack> e.g. getnodeaddresses 24 onion
5172021-05-20T18:20:50  *** RandyMcMillan <RandyMcMillan!2578cb53@> has quit IRC (Client Quit)
5182021-05-20T18:21:08  *** RandyMcMillan <RandyMcMillan!2578cb53@> has joined #bitcoin-core-dev
5192021-05-20T18:21:48  *** RandyMcMillan <RandyMcMillan!2578cb53@> has quit IRC (Client Quit)
5202021-05-20T18:21:50  *** network_operatio <network_operatio!~McCafe@> has quit IRC (Ping timeout: 265 seconds)
5212021-05-20T18:22:07  *** RandyMcMillan <RandyMcMillan!2578cb53@> has joined #bitcoin-core-dev
5222021-05-20T18:23:14  *** evandb <evandb!~evan@> has joined #bitcoin-core-dev
5232021-05-20T18:26:28  *** eris <eris!~McCafe@> has quit IRC (Remote host closed the connection)
5242021-05-20T18:26:56  *** eris <eris!~McCafe@> has joined #bitcoin-core-dev
5252021-05-20T18:28:25  <wumpus> jonatack: agreed, it looks pretty much rfm
5262021-05-20T18:32:08  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
5272021-05-20T18:33:33  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
5282021-05-20T18:33:42  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
5292021-05-20T18:34:37  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
5302021-05-20T18:47:57  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
5312021-05-20T18:49:36  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
5322021-05-20T18:53:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5332021-05-20T18:53:43  <bitcoin-git> [bitcoin] laanwj pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/ea8b2e8e127b...37e9f07996d3
5342021-05-20T18:53:43  <bitcoin-git> bitcoin/master d35ddca Jon Atack: p2p: enable CAddrMan::GetAddr_() by network, add doxygen
5352021-05-20T18:53:44  <bitcoin-git> bitcoin/master c38981e João Barbosa: p2p: pull time call out of loop in CAddrMan::GetAddr_()
5362021-05-20T18:53:44  <bitcoin-git> bitcoin/master a49f3dd Jon Atack: p2p: allow CAddrMan::GetAddr() by network, add doxygen
5372021-05-20T18:53:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5382021-05-20T18:54:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5392021-05-20T18:54:03  <bitcoin-git> [bitcoin] laanwj merged pull request #21843: p2p, rpc: enable GetAddr, GetAddresses, and getnodeaddresses by network (master...getnodeaddresses-by-network) https://github.com/bitcoin/bitcoin/pull/21843
5402021-05-20T18:54:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5412021-05-20T18:54:44  <jonatack> turns out there are many more v3 peers on testnet once you addnode the ones you know
5422021-05-20T18:54:51  *** jungly <jungly!~jungly@host-79-12-190-192.retail.telecomitalia.it> has quit IRC (Ping timeout: 260 seconds)
5432021-05-20T18:59:23  <provoostenator> jonatack: I guess the DNS seeds don't crawl them and currently can't announce using the v2 address message?
5442021-05-20T18:59:26  <provoostenator> (format)
5452021-05-20T18:59:50  <provoostenator> But I would still expect most other nodes to gossip them.
5462021-05-20T18:59:52  <wumpus> was about to say, you're basically performing the DNS seed crawler's work manually now :-)\
5472021-05-20T19:00:13  <provoostenator> But I guess you can't specifically ask for them?
5482021-05-20T19:01:15  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
5492021-05-20T19:01:35  <wumpus> created an issue wrt collecting torv3/i2p addresses in the crawler https://github.com/sipa/bitcoin-seeder/issues/92  even though there's no point in adding them to the actual DNS seeds, it would still be useful to have a way to keep tabs on them for the hardcoded seeds updates
5502021-05-20T19:01:44  <meshcollider> Meeting? Or is my timezone wrong
5512021-05-20T19:02:05  <wumpus> #startmeeting
5522021-05-20T19:02:05  <core-meetingbot> Meeting started Thu May 20 19:02:05 2021 UTC.  The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
5532021-05-20T19:02:05  <core-meetingbot> Available commands: action commands idea info link nick
5542021-05-20T19:02:13  <wumpus> meshcollider: you're right
5552021-05-20T19:02:16  <jnewbery> hi
5562021-05-20T19:02:19  <hebasto> hi
5572021-05-20T19:02:21  <sipsorcery> hi
5582021-05-20T19:02:22  <achow101> hi
5592021-05-20T19:02:26  <meshcollider> hi
5602021-05-20T19:02:27  <wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
5612021-05-20T19:02:29  <wumpus> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus
5622021-05-20T19:02:39  <jonatack> hi
5632021-05-20T19:02:39  <michaelfolkson> hi
5642021-05-20T19:02:51  <fjahr> hi
5652021-05-20T19:03:34  <wumpus> three proposed meetings for today: moving to oftc or libera.chat (aj), windows code signing certificate update (achow101), remove fuzzer from CI jobs (jnewbery)
5662021-05-20T19:03:34  <sipa> bhi
5672021-05-20T19:03:44  <wumpus> any last minute topics?
5682021-05-20T19:04:33  <wumpus> #topic High priority for review
5692021-05-20T19:04:33  <core-meetingbot> topic: High priority for review
5702021-05-20T19:04:55  <wumpus> https://github.com/bitcoin/bitcoin/projects/8 : currently 9 blockers, no bugfixes, no chasing concept ACK
5712021-05-20T19:04:59  <provoostenator> https://github.com/bitcoin-core/gui/pull/4 HWW GUI support would be cool, though technically doesn't block anything
5722021-05-20T19:05:05  <wumpus> anything to add/remove or that is (almost) ready for merge
5732021-05-20T19:05:33  <wumpus> is it possible to add a GUI PR there?
5742021-05-20T19:05:59  <wumpus> unfortunately i don't think so
5752021-05-20T19:06:21  *** eris <eris!~McCafe@> has quit IRC (Remote host closed the connection)
5762021-05-20T19:06:36  <hebasto> it should work to add with full link
5772021-05-20T19:06:42  <wumpus> let me try
5782021-05-20T19:08:21  <wumpus> right i could add it through a 'note'
5792021-05-20T19:08:51  <hebasto> wumpus: provoostenator: thanks!
5802021-05-20T19:09:35  <wumpus> amything else for high prio?
5812021-05-20T19:10:31  <wumpus> #topic Moving to oftc or libera.chat (aj)
5822021-05-20T19:10:32  <core-meetingbot> topic: Moving to oftc or libera.chat (aj)
5832021-05-20T19:11:21  <wumpus> i'm not sure how much of a discussion this is anymore, fwiw: we've already reserved the namespace and channels in libera.chat
5842021-05-20T19:11:49  <wumpus> it makes sense to register your nickname there if you haven't done so yet (works the same as here, with nickserv)
5852021-05-20T19:12:21  <hebasto> how long it would take to switch from freenode?
5862021-05-20T19:12:54  <wumpus> i don't think there's any work left to be done?
5872021-05-20T19:13:17  <michaelfolkson> This is still up in the air right? We're going to wait until dust has settled to decide rather than move in say the next week or two?
5882021-05-20T19:13:20  <wumpus> okay, the merges bot isn't there yet, and we need to update the bitcoincore.org website
5892021-05-20T19:13:35  <BlueMatt> I dont think it should be a question on if things should move, there's not really any doubt that it should have moved already, only question is libera, oftc, or something else
5902021-05-20T19:14:45  <michaelfolkson> BlueMatt: Because new owner is "malicious"? I haven't been following it that closely. Are there any devs still left on the Freenode side?
5912021-05-20T19:14:52  <wumpus> from what i've seen there is pretty broad agreement to move
5922021-05-20T19:15:25  <hebasto> is current lack of tor support on libera a blocker?
5932021-05-20T19:15:29  <wumpus> michaelfolkson: it's really fishy what happened, legal threats against admins etc
5942021-05-20T19:16:13  <wumpus> https://gist.github.com/joepie91/df80d8d36cd9d1bde46ba018af497409
5952021-05-20T19:16:14  <achow101> oftc seems to be a bit harder to register with since they don't support sasl
5962021-05-20T19:17:04  <hebasto> ^ without public plans to add such support?
5972021-05-20T19:17:05  <BlueMatt> michaelfolkson: the people behind the freenode acquisition have been known hostile to bitcoin for years, I kinda suggested moving, but wasnt worth the effort, this seems like a good excuse more than anything.
5982021-05-20T19:17:25  <b10c_> hi
5992021-05-20T19:17:31  <wumpus> hebasto: libera is planning to add tor support at least they mention so on their page
6002021-05-20T19:17:34  <michaelfolkson> BlueMatt: Ok thanks
6012021-05-20T19:17:48  <sipa> today i was briefly able to connect to libera over tor
6022021-05-20T19:17:59  <hebasto> nice
6032021-05-20T19:18:17  *** jungly <jungly!~jungly@host-79-12-190-192.retail.telecomitalia.it> has joined #bitcoin-core-dev
6042021-05-20T19:18:17  <BlueMatt> (the actual freenode admins have been fairly friendly to bitcoin stuff, at least after a *ton* of effort on the part of some of the #bitcoin mods, most of those admins have moved to libera now)
6052021-05-20T19:19:22  <provoostenator> I registered provoostenator on the other side :-)
6062021-05-20T19:20:04  *** nkuttler <nkuttler!~nkuttler@unaffiliated/nkuttler> has quit IRC (Quit: K-Lined)
6072021-05-20T19:20:12  <murch> provoostenator: Well, that settles it then. ;)
6082021-05-20T19:20:43  <wumpus> it's wise to register your name there, to prevent it from being grabbed by someone else
6092021-05-20T19:20:57  *** nkuttler <nkuttler!~nkuttler@unaffiliated/nkuttler> has joined #bitcoin-core-dev
6102021-05-20T19:20:57  <provoostenator> And then confirm it here.
6112021-05-20T19:21:07  <wumpus> yes
6122021-05-20T19:21:07  <michaelfolkson> I suppose my second and final question would be there isn't the possibility of a reversal and everyone makes up and goes back to Freenode right? This often seems to happen in scenarios like this. A protest which results in a new agreement
6132021-05-20T19:21:19  <hebasto> am I understand correctly hat there is a consensus to move from freenode?
6142021-05-20T19:21:22  <provoostenator> (depending on *how* hostile the IRC overloards are here of course)
6152021-05-20T19:21:48  <hebasto> * that
6162021-05-20T19:21:52  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
6172021-05-20T19:22:39  <achow101> it's prudent to maintain accounts on multiple networks so that switching is merely changing a url
6182021-05-20T19:23:04  <wumpus> michaelfolkson: i sincerely doubt it (but cannot really go into details)
6192021-05-20T19:23:31  <wumpus> read the gist i posted for some information
6202021-05-20T19:23:32  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
6212021-05-20T19:23:45  <BlueMatt> michaelfolkson: I think if we find much wrong with libera, we will move to oftc or elsewhere, there's about zero chance we end up back on freenode
6222021-05-20T19:24:13  <michaelfolkson> wumpus BlueMatt: Ok, sounds like it is just a question of timing then
6232021-05-20T19:25:03  <jonatack> https://libera.chat/guides/registration
6242021-05-20T19:25:37  <hebasto> my vote is for libera
6252021-05-20T19:25:59  <achow101> libera is fine with me
6262021-05-20T19:26:04  <wumpus> same
6272021-05-20T19:26:18  <michaelfolkson> Yeah libera seems obvious choice
6282021-05-20T19:26:18  <jonatack> yup
6292021-05-20T19:27:21  <provoostenator> Who wants to register satoshi to keep out the name squatters,  and receive lots of legal threats? :-)
6302021-05-20T19:27:59  <wumpus> so the remaining question is timeframe
6312021-05-20T19:28:19  <wumpus> where is next week's IRC meeting?
6322021-05-20T19:28:52  <provoostenator> It could make sense to do that on libera, but maybe ask right before the meeting if anyone objects.
6332021-05-20T19:28:55  <sipa> maybe let's plan to have next week's meeting be the last one here?
6342021-05-20T19:29:02  <sipa> unless there are exigent circumstances
6352021-05-20T19:29:15  <achow101> There are also all of the side meetings (e.g. wallet, p2p)
6362021-05-20T19:29:39  <jnewbery> those should follow the main meeting
6372021-05-20T19:29:42  <ariard> hi
6382021-05-20T19:29:46  <michaelfolkson> Yeah it is good to keep people informed and not move quickly unless forced to (I think)
6392021-05-20T19:30:06  <jonatack> next wallet meeting is tomorrow (here, presumably)
6402021-05-20T19:30:08  <michaelfolkson> Last Core dev meeting here next week sounds good to me (and gives time for people to get set up)
6412021-05-20T19:30:20  <wumpus> sgtm
6422021-05-20T19:30:24  <hebasto> agree
6432021-05-20T19:30:27  <achow101> ack
6442021-05-20T19:30:40  <jonatack> i'm fine to switch as soon as people want to
6452021-05-20T19:31:22  <wumpus> #topic Windows code signing certificate update (achow101)
6462021-05-20T19:31:22  <core-meetingbot> topic: Windows code signing certificate update (achow101)
6472021-05-20T19:31:22  <hebasto> how people will be informed about moving?
6482021-05-20T19:31:40  <wumpus> hebasto: we can set the topic here i guess
6492021-05-20T19:31:50  <hebasto> wumpus: ok
6502021-05-20T19:31:50  <achow101> It looks like we will be getting the windows code signing certificate shortly, hopefully within in the next week
6512021-05-20T19:31:57  <wumpus> achow101: great news!!!
6522021-05-20T19:32:11  <sipa> awesöme
6532021-05-20T19:32:18  <wumpus> hebasto: and we'll need to badger people talking here for a while to move maybe :)
6542021-05-20T19:32:21  <achow101> We have created Bitcoin Core Code Signing LLC registerd in Delaware and the cert will be issued to this new LLC
6552021-05-20T19:32:46  <wumpus> hebasto: then at some point maybe set it to +m
6562021-05-20T19:32:59  <achow101> it's been validated already, so all that's left is waiting for Digicert to issue the cert itself
6572021-05-20T19:33:06  <wumpus> achow101: glad to hear that
6582021-05-20T19:33:37  <achow101> that's all
6592021-05-20T19:33:51  <provoostenator> Nice!
6602021-05-20T19:34:21  <wumpus> #topic Remove fuzzer from CI jobs (jnewbery)
6612021-05-20T19:34:21  <core-meetingbot> topic: Remove fuzzer from CI jobs (jnewbery)
6622021-05-20T19:35:33  <jnewbery> hi!
6632021-05-20T19:36:07  <jnewbery> It seems that cirrus CI very frequently times out after two hours on the job that runs the fuzz corpus
6642021-05-20T19:36:35  <jnewbery> and that causes the CI to show as failed for PRs that don't actually have any problems
6652021-05-20T19:36:56  <wumpus> yes, it happens intermittently but quite often
6662021-05-20T19:37:13  <jnewbery> There are two problems here: 1. a run time of two hours is a really slow feedback loop, which is terrible for productivity
6672021-05-20T19:37:24  <wumpus> i wonder if there are any specific cases that are so slow or it's necessarily like this
6682021-05-20T19:37:40  <sipa> i think the fuzz test sets are also just too big
6692021-05-20T19:37:41  <provoostenator> Is it possible to a much more limited fuzz? Just to catch really obvious mistakes?
6702021-05-20T19:37:47  <wumpus> two hour is long yes
6712021-05-20T19:37:49  <jnewbery> 2. a CI that has false failures reduces people's trust in the system and hides actual failures
6722021-05-20T19:37:57  <jonatack> protip, push on sunday
6732021-05-20T19:38:03  <jnewbery> I personally don't think we should be running the fuzz corpus on PRs
6742021-05-20T19:38:16  <sipa> jnewbery: you mean just run it on master?
6752021-05-20T19:38:21  <sipa> that'd be fine by me
6762021-05-20T19:38:40  <ajonas> so oss-fuzz does have a ci intergration
6772021-05-20T19:38:50  <jnewbery> if the code that the corpus is testing hasn't changed, then you're just running the same code paths as every other path. If it has changed, then the corpus isn't going to get good coverage (since it's optimized for the old code)
6782021-05-20T19:38:51  <ajonas> no idea what the run time would be but it's something to maybe consider
6792021-05-20T19:38:55  <jnewbery> yes, just run on master
6802021-05-20T19:39:17  <jnewbery> I feel like a CI is not the right place for fuzzing
6812021-05-20T19:39:26  <jonatack> at the same time, the fuzz CI helpfully catches when you forget to update the fuzzers for your changes
6822021-05-20T19:39:49  <sipa> jonatack: we can build the fuzz code without running it
6832021-05-20T19:39:50  <jnewbery> jonatack: we should still build the fuzz binaries
6842021-05-20T19:39:53  <hebasto> ^ we have fuzz binary by default
6852021-05-20T19:40:00  <michaelfolkson> provoostenator: I don't think we're at a point where we can draw a clear divide between obvious fuzzing and non obvious fuzzing (but someone can correct me if wrong)
6862021-05-20T19:40:31  <sipa> another possibility is just running the a small random subset of fuzz inputs
6872021-05-20T19:40:58  <sipa> but i think i agree with jnewbery that in general, (PR) CI is not the right place for fuzzing
6882021-05-20T19:41:14  <jnewbery> sorry, typo in my earlier statement: s/the same code path as every other path/the same code path as every other branch/
6892021-05-20T19:41:14  <ajonas> The fuzzer is not the only thing that's slow
6902021-05-20T19:41:27  <sipa> well, what we're doing isn't even actual fuzzing, it's running unit tests that are automatically derived from fuzzing corpus :)
6912021-05-20T19:41:36  <ajonas> it will knock the feedback loop down some but it's not the only issue if that's what the goal is
6922021-05-20T19:41:40  *** RandyMcMillan <RandyMcMillan!2578cb53@> has quit IRC (Quit: Connection closed)
6932021-05-20T19:42:05  <sipa> ajonas: what else is?
6942021-05-20T19:42:10  <jnewbery> sipa: not really unit tests, since they don't necessarily assert that the behaviour is correct.
6952021-05-20T19:42:23  <jnewbery> they just try to hit path coverage
6962021-05-20T19:42:23  <sipa> jnewbery: true
6972021-05-20T19:42:24  <glozow> the fuzzer is the one that’s timing out a lot though right?
6982021-05-20T19:42:25  *** nickler_ <nickler_!~nickler@static.> has joined #bitcoin-core-dev
6992021-05-20T19:42:37  *** lukaz_ <lukaz_!~greenluka@> has joined #bitcoin-core-dev
7002021-05-20T19:43:07  <ajonas> the macbuild actually takes longer on average
7012021-05-20T19:43:18  <jonatack> and there is still a fuzzer run on bitcoinbuilds atm
7022021-05-20T19:43:18  <ajonas> same with tsan
7032021-05-20T19:43:23  <wumpus> glozow: yes it's why your testmempoolaccept PR is failing the CI
7042021-05-20T19:43:30  <michaelfolkson> glozow: Nothing else takes two hours as far as I know :)
7052021-05-20T19:43:31  <glozow> yes :’(
7062021-05-20T19:43:37  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-a1f4-7a0c-77c0-2833.res6.spectrum.com> has joined #bitcoin-core-dev
7072021-05-20T19:43:51  *** nickler_ <nickler_!~nickler@static.> has quit IRC (Client Quit)
7082021-05-20T19:43:53  <jonatack> michaelfolkson: i have the impression that it can vary quite a bit
7092021-05-20T19:44:00  <jnewbery> my proposal would be to remove the fuzz corpus testing from our CI. I also think separately we should all aim to drive down the CI time - fast feedback loops are really important
7102021-05-20T19:44:01  *** lukaz <lukaz!~greenluka@> has quit IRC (Ping timeout: 260 seconds)
7112021-05-20T19:45:00  <ajonas> sorry that's wrong https://usercontent.irccloud-cdn.com/file/9vK4c0d1/Screen%20Shot%202021-05-20%20at%203.44.36%20PM.png
7122021-05-20T19:45:07  <ajonas> this is the last 7 days
7132021-05-20T19:45:08  <wumpus> left by itself the time taken by test frameworks seems to be forever increasing :)
7142021-05-20T19:45:16  <jnewbery> wumpus: yes :(
7152021-05-20T19:45:42  <jonatack> ajonas: thanks!
7162021-05-20T19:45:59  <ajonas> that's just the queue
7172021-05-20T19:46:11  <ajonas> https://usercontent.irccloud-cdn.com/file/8Cv7Yv85/Screen%20Shot%202021-05-20%20at%203.45.46%20PM.png
7182021-05-20T19:46:20  <ajonas> that's the build duration
7192021-05-20T19:46:36  <jnewbery> ajonas: is that data pulled from cirrus?
7202021-05-20T19:46:44  <ajonas> yes
7212021-05-20T19:47:18  <michaelfolkson> So ACK on removing fuzzer from CI. Does there need to be a separate conversation on the increasing time taken by test frameworks? Or is it inevitable that slowly goes up over time?
7222021-05-20T19:47:40  <jnewbery> it's good to have that data
7232021-05-20T19:47:53  <sipa> there is always the possibility of splitting up a very slow CI target in two
7242021-05-20T19:47:54  <lightlike> has there ever been an instance where the fuzzer corpus run found a bug on a PR?
7252021-05-20T19:48:14  <jnewbery> It doesn't match what I'm seeing on some PRs. For example 20833 has failed many times in a row because the fuzzer times out after two hours
7262021-05-20T19:48:15  *** nickler <nickler!~nickler@static.> has quit IRC (Quit: Lost terminal)
7272021-05-20T19:48:23  <jnewbery> that seems unlikely if the mean really is 40 minutes
7282021-05-20T19:48:27  *** nickler <nickler!~nickler@static.> has joined #bitcoin-core-dev
7292021-05-20T19:48:32  <wumpus> yes, i'm also fine with removing the fuzzer from the CI, i think it was mostly useful to that the fuzz tests got compiled, but that's the default now
7302021-05-20T19:48:41  <jnewbery> unless there's something in that PR that causes the fuzzer job time to triple
7312021-05-20T19:50:01  <sipa> jnewbery: maybe it's only the mean of successful jobs?
7322021-05-20T19:50:24  <ajonas> definitely possible
7332021-05-20T19:50:27  <ajonas> can check on that
7342021-05-20T19:50:39  <michaelfolkson> lightlike: I'm not sure from the CI on a PR. But many bugs found by fuzzing generally https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Fuzz-Trophies
7352021-05-20T19:50:58  <glozow> this might be a dumb question but can we just run fuzz tests that are changed in the pr?
7362021-05-20T19:51:08  <sipa> glozow: not sure how we'd do that
7372021-05-20T19:51:32  <glozow> me neither 😅
7382021-05-20T19:51:49  <sipa> michaelfolkson: those are all due to actual fuzzing
7392021-05-20T19:52:05  <michaelfolkson> sipa: Ok
7402021-05-20T19:52:06  <jnewbery> I'm also not sure of the value of running a fuzz corpus derived from an old branch on the new branch
7412021-05-20T19:52:20  <sipa> jnewbery: it could detect certain regressions
7422021-05-20T19:52:53  <jnewbery> either the code is the same and you're running the same executions, or the code is different and the fuzz corpus won't penetrate very deeply into the new code paths
7432021-05-20T19:53:10  <sipa> jnewbery: i think that's a bit unnuanced
7442021-05-20T19:53:10  <jnewbery> maybe I just don't understand the idea of corpuses
7452021-05-20T19:53:21  *** jungly <jungly!~jungly@host-79-12-190-192.retail.telecomitalia.it> has quit IRC (Ping timeout: 260 seconds)
7462021-05-20T19:53:33  <sipa> you're certainly right for certain types of changes, but not all
7472021-05-20T19:53:33  <jnewbery> sipa: probably :)
7482021-05-20T19:53:33  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
7492021-05-20T19:54:12  <ajonas> I don’t know think a slow and fast makes sense.  Fanquake also brought up that much of the Mac build is brew installing stuff. We can do better.
7502021-05-20T19:54:26  *** vincenzopalazzo <vincenzopalazzo!~vincenzop@host-79-23-113-134.retail.telecomitalia.it> has quit IRC (Quit: Leaving)
7512021-05-20T19:54:39  *** vincenzopalazzo <vincenzopalazzo!~vincenzop@host-79-23-113-134.retail.telecomitalia.it> has joined #bitcoin-core-dev
7522021-05-20T19:54:39  <sipa> in any case, i agree that there is little value in running these tests in CI on every PR
7532021-05-20T19:54:39  <ajonas> That was garbled. A slow and fast test separation makes sense.
7542021-05-20T19:54:44  <jnewbery> I think there's probably more analysis to be done. Knowing how many regressions were caught by running the fuzz corpus would be really interesting
7552021-05-20T19:55:18  <sipa> jnewbery: a useful test could be trying to reintroduce an old bug that was found by fuzzing
7562021-05-20T19:55:19  <jnewbery> do we have a CI job on the master branch after every merge? Would that be a better place for this test?
7572021-05-20T19:55:26  <sipa> (but without straight up reverting the code)
7582021-05-20T19:55:45  <sipa> jnewbery: i think so
7592021-05-20T19:55:50  <jnewbery> I know we used to with Travis. I'm not very familiar with the cirrus config
7602021-05-20T19:55:59  <sipa> hmm, not sure either
7612021-05-20T19:56:02  <sipa> MarcoFalke: ^
7622021-05-20T19:56:15  <hebasto> yes we have
7632021-05-20T19:56:46  <sipa> https://cirrus-ci.com/build/5945300410957824 e.g.
7642021-05-20T19:57:02  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
7652021-05-20T19:57:09  <sipa> so it seems we indeed do
7662021-05-20T19:57:12  <jnewbery> https://cirrus-ci.com/github/bitcoin/bitcoin/master
7672021-05-20T19:57:51  <jnewbery> it looks like many of those jobs have timed out after 2 hours as well :(
7682021-05-20T19:58:13  <sipa> well ne reason why those would be faster than the CI ones
7692021-05-20T19:58:15  <sipa> *no
7702021-05-20T19:58:26  <jnewbery> I guess there must be huge variance in the fuzz job time
7712021-05-20T19:58:58  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
7722021-05-20T19:59:44  <wumpus> meeting ending in a bit
7732021-05-20T19:59:54  <ajonas> Chaincode has a dashboard that we can clean up and make available.
7742021-05-20T20:00:04  <ajonas> Happy to do that if there is interest.
7752021-05-20T20:00:23  <jnewbery> ajonas: thanks for all your work looking into this. I think it'll be really useful once we have reliable, fast CI
7762021-05-20T20:00:27  <jnewbery> makes a huge difference
7772021-05-20T20:00:57  <ajonas> Marco has done great work getting the functional test suite in shape.
7782021-05-20T20:01:06  <jnewbery> thanks MarcoFalke!
7792021-05-20T20:01:10  <ajonas> Lots still to do but help is appreciated.
7802021-05-20T20:01:21  <jnewbery> I don't have anything else to add
7812021-05-20T20:01:38  <jnewbery> (in this meeting)
7822021-05-20T20:01:40  <wumpus> #endmeeting
7832021-05-20T20:01:40  <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
7842021-05-20T20:01:40  <core-meetingbot> Meeting ended Thu May 20 20:01:40 2021 UTC.
7852021-05-20T20:01:40  <core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-05-20-19.02.moin.txt
7862021-05-20T20:01:43  <jnewbery> thanks wumpus!
7872021-05-20T20:01:55  <midnight> kkk/w 29
7882021-05-20T20:02:01  <midnight> er. sorry.
7892021-05-20T20:02:10  *** smartineng <smartineng!~Icedove@> has joined #bitcoin-core-dev
7902021-05-20T20:02:26  <sipa> jonatack: am i missing something here? https://github.com/bitcoin/bitcoin/pull/21843#discussion_r636431728
7912021-05-20T20:02:56  <sipa> (pinging directly so i don't forget this; i'm happy to fix it if needed)
7922021-05-20T20:04:37  <jnewbery> glozow: it looks like the fuzz job got a lot faster after #21931 was merged: https://cirrus-ci.com/build/5207270301630464. Perhaps try rebasing on recent master
7932021-05-20T20:04:38  <gribble> https://github.com/bitcoin/bitcoin/issues/21931 | ci: Bump cirrus fuzz CPUs to avoid timeout by MarcoFalke · Pull Request #21931 · bitcoin/bitcoin · GitHub
7942021-05-20T20:04:53  *** vincenzopalazzo <vincenzopalazzo!~vincenzop@host-79-23-113-134.retail.telecomitalia.it> has quit IRC (Quit: Leaving)
7952021-05-20T20:05:05  *** vincenzopalazzo <vincenzopalazzo!~vincenzop@host-79-23-113-134.retail.telecomitalia.it> has joined #bitcoin-core-dev
7962021-05-20T20:06:02  <glozow> jnewbery: will do
7972021-05-20T20:06:07  <jonatack> sipa: saw your comment via email notifs, looking at it
7982021-05-20T20:06:08  *** jnewbery <jnewbery!~john@> has quit IRC (Quit: Changing server)
7992021-05-20T20:06:15  <michaelfolkson> ajonas: Re dashboard, yeah at least personally I'd be interested in anything you are able to open source/make public
8002021-05-20T20:06:24  *** jnewbery <jnewbery!~john@> has joined #bitcoin-core-dev
8012021-05-20T20:07:32  *** jungly <jungly!~jungly@host-79-12-190-192.retail.telecomitalia.it> has joined #bitcoin-core-dev
8022021-05-20T20:09:12  <michaelfolkson> Presumably anything that is found from oss-fuzz will be added to the fuzz trophies page
8032021-05-20T20:09:45  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
8042021-05-20T20:09:55  *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
8052021-05-20T20:10:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
8062021-05-20T20:10:50  <bitcoin-git> [gui] laanwj merged pull request #281: set shortcuts for console's resize buttons (master...mul-shortcuts-resize) https://github.com/bitcoin-core/gui/pull/281
8072021-05-20T20:10:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
8082021-05-20T20:11:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
8092021-05-20T20:11:19  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/37e9f07996d3...710c8ba82953
8102021-05-20T20:11:20  <bitcoin-git> bitcoin/master 4ee9ee7 Hennadii Stepanov: qt: Use native presentation of shortcut
8112021-05-20T20:11:20  <bitcoin-git> bitcoin/master a2e122f Hennadii Stepanov: qt: Add GUIUtil::AddButtonShortcut
8122021-05-20T20:11:21  <bitcoin-git> bitcoin/master 2a45134 Hennadii Stepanov: qt: Add shortcuts for console font resize buttons
8132021-05-20T20:11:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
8142021-05-20T20:11:51  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
8152021-05-20T20:12:02  *** contagious_meow <contagious_meow!~contagiou@> has joined #bitcoin-core-dev
8162021-05-20T20:12:36  <jnewbery> sipa: isn't the for loop bounded by the size of vRandom? How would you get an infinite loop?
8172021-05-20T20:14:31  <sipa> jnewbery: oh you're right
8182021-05-20T20:14:42  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
8192021-05-20T20:14:46  <jnewbery> phew
8202021-05-20T20:14:51  <jonatack> yes
8212021-05-20T20:15:11  <sipa> i should learn to read instead of assuming i know what code does...
8222021-05-20T20:16:05  <jonatack> thanks for checking
8232021-05-20T20:19:35  *** salitos <salitos!~contagiou@> has joined #bitcoin-core-dev
8242021-05-20T20:20:42  *** contagious_meow <contagious_meow!~contagiou@> has quit IRC (Read error: Connection reset by peer)
8252021-05-20T20:23:47  *** Kiminuo <Kiminuo!~Kiminuo@> has joined #bitcoin-core-dev
8262021-05-20T20:24:41  *** jungly <jungly!~jungly@host-79-12-190-192.retail.telecomitalia.it> has quit IRC (Ping timeout: 260 seconds)
8272021-05-20T20:31:30  *** nickithename <nickithename!~Username@> has quit IRC (Read error: Connection reset by peer)
8282021-05-20T20:36:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
8292021-05-20T20:36:13  <bitcoin-git> [bitcoin] achow101 opened pull request #22008: wallet: Cleanup and refactor CreateTransactionInternal (master...refactor-createtx) https://github.com/bitcoin/bitcoin/pull/22008
8302021-05-20T20:36:14  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
8312021-05-20T20:37:17  *** vincenzopalazzo <vincenzopalazzo!~vincenzop@host-79-23-113-134.retail.telecomitalia.it> has quit IRC (Remote host closed the connection)
8322021-05-20T20:38:44  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 245 seconds)
8332021-05-20T20:38:45  *** jungly <jungly!~jungly@host-79-12-190-192.retail.telecomitalia.it> has joined #bitcoin-core-dev
8342021-05-20T20:46:59  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
8352021-05-20T20:48:27  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
8362021-05-20T20:49:55  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
8372021-05-20T20:54:28  *** murrayn <murrayn!~murray@unaffiliated/murrayn> has quit IRC (Quit: ZNC 1.8.2 - https://znc.in)
8382021-05-20T20:55:15  *** murray_ <murray_!~murray@static.> has joined #bitcoin-core-dev
8392021-05-20T20:58:14  *** pdb <pdb!~pdb@host-79-17-74-30.retail.telecomitalia.it> has joined #bitcoin-core-dev
8402021-05-20T20:58:32  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Quit: WeeChat 3.1)
8412021-05-20T20:59:39  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
8422021-05-20T21:00:14  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Client Quit)
8432021-05-20T21:00:46  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
8442021-05-20T21:01:26  *** jungly <jungly!~jungly@host-79-12-190-192.retail.telecomitalia.it> has quit IRC (Ping timeout: 240 seconds)
8452021-05-20T21:01:58  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
8462021-05-20T21:02:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
8472021-05-20T21:02:49  <bitcoin-git> [gui] hebasto merged pull request #335: test: Use QSignalSpy instead of QEventLoop (master...apptest-spy) https://github.com/bitcoin-core/gui/pull/335
8482021-05-20T21:02:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
8492021-05-20T21:03:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
8502021-05-20T21:03:08  <bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/710c8ba82953...e2b55cd20103
8512021-05-20T21:03:08  <bitcoin-git> bitcoin/master 7eea659 Jarol Rodriguez: qt, test: use qsignalspy instead of qeventloop
8522021-05-20T21:03:09  <bitcoin-git> bitcoin/master e2b55cd Hennadii Stepanov: Merge bitcoin-core/gui#335: test: Use QSignalSpy instead of QEventLoop
8532021-05-20T21:03:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
8542021-05-20T21:04:27  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
8552021-05-20T21:08:46  *** jungly <jungly!~jungly@host-79-12-190-192.retail.telecomitalia.it> has joined #bitcoin-core-dev
8562021-05-20T21:19:07  *** evandb <evandb!~evan@> has quit IRC (Quit: Leaving)
8572021-05-20T21:19:36  *** yamz <yamz!~contagiou@> has joined #bitcoin-core-dev
8582021-05-20T21:23:01  *** salitos <salitos!~contagiou@> has quit IRC (Ping timeout: 260 seconds)
8592021-05-20T21:23:08  *** Henry100 <Henry100!6802dc59@104-2-220-89.lightspeed.jcvlfl.sbcglobal.net> has joined #bitcoin-core-dev
8602021-05-20T21:25:22  *** Henry100 <Henry100!6802dc59@104-2-220-89.lightspeed.jcvlfl.sbcglobal.net> has quit IRC (Client Quit)
8612021-05-20T21:29:32  *** schulzemic <schulzemic!ada@gateway/vpn/mullvad/schulzemic> has joined #bitcoin-core-dev
8622021-05-20T21:36:57  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
8632021-05-20T21:38:50  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
8642021-05-20T21:40:16  <aj> jnewbery: i think the variance in fuzz time is that the job is "[compile] [fuzz] [add compile results to ccache]" -- if a previous job succeeded in <2h, ccache is up to date making compile much quicker; but if not, compile is slow, fuzz is slow, and 2h elapses before ccache gets updated causing every run to fail?
8652021-05-20T21:40:31  *** smartineng <smartineng!~Icedove@> has quit IRC (Quit: smartineng)
8662021-05-20T21:51:53  *** bandnyquist <bandnyquist!~Rheanna@> has quit IRC (Remote host closed the connection)
8672021-05-20T21:53:25  *** bandnyquist <bandnyquist!~Rheanna@> has joined #bitcoin-core-dev
8682021-05-20T22:06:11  *** Kiminuo <Kiminuo!~Kiminuo@> has quit IRC (Ping timeout: 260 seconds)
8692021-05-20T22:13:59  *** schulzemic <schulzemic!ada@gateway/vpn/mullvad/schulzemic> has quit IRC (Quit: Konversation terminated!)
8702021-05-20T22:16:01  *** nullptr| <nullptr|!~nullptr|@ip-94-112-128-60.net.upcbroadband.cz> has quit IRC (Quit: ZNC - http://znc.in)
8712021-05-20T22:16:53  *** nullptr| <nullptr|!~nullptr|@ip-94-112-128-60.net.upcbroadband.cz> has joined #bitcoin-core-dev
8722021-05-20T22:18:11  *** mart <mart!~mart@c-76-97-33-113.hsd1.ga.comcast.net> has quit IRC (Ping timeout: 240 seconds)
8732021-05-20T22:18:26  *** mart <mart!~mart@c-76-97-33-113.hsd1.ga.comcast.net> has joined #bitcoin-core-dev
8742021-05-20T22:19:37  *** salitos <salitos!~contagiou@> has joined #bitcoin-core-dev
8752021-05-20T22:23:06  *** yamz <yamz!~contagiou@> has quit IRC (Ping timeout: 260 seconds)
8762021-05-20T22:25:31  *** lightlike <lightlike!~lightlike@p200300c7ef193f00852cd8ab26120ff6.dip0.t-ipconnect.de> has quit IRC (Quit: Leaving)
8772021-05-20T22:26:36  *** nullptr| <nullptr|!~nullptr|@ip-94-112-128-60.net.upcbroadband.cz> has quit IRC (Ping timeout: 260 seconds)
8782021-05-20T22:29:12  *** nullptr| <nullptr|!~nullptr|@ip-94-112-128-60.net.upcbroadband.cz> has joined #bitcoin-core-dev
8792021-05-20T22:42:56  *** salitos <salitos!~contagiou@> has quit IRC (Ping timeout: 260 seconds)
8802021-05-20T22:47:19  *** pdb__ <pdb__!~pdb@host-79-17-74-30.retail.telecomitalia.it> has joined #bitcoin-core-dev
8812021-05-20T22:50:06  *** pdb <pdb!~pdb@host-79-17-74-30.retail.telecomitalia.it> has quit IRC (Ping timeout: 240 seconds)
8822021-05-20T22:50:26  *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has quit IRC (Ping timeout: 240 seconds)
8832021-05-20T22:50:58  *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
8842021-05-20T23:04:47  *** salitos <salitos!~contagiou@> has joined #bitcoin-core-dev
8852021-05-20T23:09:54  *** jungly <jungly!~jungly@host-79-12-190-192.retail.telecomitalia.it> has quit IRC (Ping timeout: 265 seconds)
8862021-05-20T23:25:49  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 245 seconds)
8872021-05-20T23:27:41  *** TD-Linux <TD-Linux!~Thomas@about/essy/indecisive/TD-Linux> has quit IRC (Ping timeout: 258 seconds)
8882021-05-20T23:27:52  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
8892021-05-20T23:29:39  *** TD-Linux <TD-Linux!~Thomas@kyoko.thomasdaede.com> has joined #bitcoin-core-dev
8902021-05-20T23:34:31  *** marcoagner <marcoagner!~user@2001:8a0:ffc6:8700:fbe1:d95d:7692:d3c7> has quit IRC (Ping timeout: 260 seconds)
8912021-05-20T23:37:24  <murch> I've registered the nickname "murch" on Libera.
8922021-05-20T23:39:53  <aj> i'm _aj_ :(
8932021-05-20T23:40:09  *** proofofkeags_ <proofofkeags_!~proofofke@> has quit IRC (Ping timeout: 260 seconds)
8942021-05-20T23:43:28  *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
8952021-05-20T23:43:54  *** shesek <shesek!~shesek@> has joined #bitcoin-core-dev
8962021-05-20T23:46:38  *** nullptr| <nullptr|!~nullptr|@ip-94-112-128-60.net.upcbroadband.cz> has quit IRC (Ping timeout: 246 seconds)
8972021-05-20T23:50:03  *** nullptr| <nullptr|!~nullptr|@ip-94-112-128-60.net.upcbroadband.cz> has joined #bitcoin-core-dev
8982021-05-20T23:55:20  *** salitos <salitos!~contagiou@> has quit IRC (Quit: Leaving)