1 2021-06-02T00:08:22  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
  2 2021-06-02T00:53:06  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 264 seconds)
  3 2021-06-02T01:18:34  *** jarthur_ <jarthur_!~jarthur@2603-8080-1540-002d-1dc8-ad8e-06d0-f812.res6.spectrum.com> has joined #bitcoin-core-dev
  4 2021-06-02T01:21:33  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-55bf-0755-4786-625d.res6.spectrum.com> has quit IRC (Ping timeout: 265 seconds)
  5 2021-06-02T01:40:37  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 252 seconds)
  6 2021-06-02T01:46:06  *** klement <klement!~klement@> has joined #bitcoin-core-dev
  7 2021-06-02T02:04:36  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
  8 2021-06-02T02:40:35  *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has joined #bitcoin-core-dev
  9 2021-06-02T02:41:56  *** kvs <kvs!~root@> has joined #bitcoin-core-dev
 10 2021-06-02T02:45:56  *** kvs <kvs!~root@> has left #bitcoin-core-dev (WeeChat 3.1)
 11 2021-06-02T02:46:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 12 2021-06-02T02:46:17  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7e83e74e7fca...0a3b8ea11ad2
 13 2021-06-02T02:46:17  <bitcoin-git> bitcoin/master 610151f fanquake: validation: change ProcessNewBlock() to take a CBlock reference
 14 2021-06-02T02:46:17  <bitcoin-git> bitcoin/master e12f287 fanquake: net: cleanup newly added PeerManagerImpl::ProcessNewBlock
 15 2021-06-02T02:46:17  <bitcoin-git> bitcoin/master 0a3b8ea fanquake: Merge bitcoin/bitcoin#22106: refactor: address ProcessNewBlock comments fr...
 16 2021-06-02T02:46:17  *** kvs <kvs!~root@> has joined #bitcoin-core-dev
 17 2021-06-02T02:46:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 18 2021-06-02T02:46:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 19 2021-06-02T02:46:34  <bitcoin-git> [bitcoin] fanquake merged pull request #22106: refactor: address ProcessNewBlock comments from #21713 (master...fixup_21713) https://github.com/bitcoin/bitcoin/pull/22106
 20 2021-06-02T02:46:35  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 21 2021-06-02T02:48:03  *** kvs <kvs!~root@> has left #bitcoin-core-dev (WeeChat 3.1)
 22 2021-06-02T02:52:31  *** kvs <kvs!~root@> has joined #bitcoin-core-dev
 23 2021-06-02T03:32:20  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 24 2021-06-02T03:35:49  *** Xr <Xr!~Eos@> has joined #bitcoin-core-dev
 25 2021-06-02T03:35:51  <Xr> Her geli�menin ve kurtulu�un anas� H�rriyettir. Mustafa Gurur, Kemal Onur, Atat�rk �ereftir!
 26 2021-06-02T03:39:50  *** Xr <Xr!~Eos@> has quit IRC ()
 27 2021-06-02T03:41:03  *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has quit IRC (Ping timeout: 268 seconds)
 28 2021-06-02T03:50:23  *** achow101 <achow101!~achow101@user/achow101> has quit IRC (Remote host closed the connection)
 29 2021-06-02T03:51:47  *** achow101 <achow101!~achow101@user/achow101> has joined #bitcoin-core-dev
 30 2021-06-02T04:12:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 31 2021-06-02T04:12:57  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0a3b8ea11ad2...a83bbf02c762
 32 2021-06-02T04:12:57  <bitcoin-git> bitcoin/master fa416ce Hennadii Stepanov: depends: Bump Qt version to 5.12.11
 33 2021-06-02T04:12:57  <bitcoin-git> bitcoin/master a83bbf0 fanquake: Merge bitcoin/bitcoin#22054: depends: Bump Qt version to 5.12.11
 34 2021-06-02T04:12:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 35 2021-06-02T04:13:14  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 36 2021-06-02T04:13:14  <bitcoin-git> [bitcoin] fanquake merged pull request #22054: depends: Bump Qt version to 5.12.11 (master...210525-bump) https://github.com/bitcoin/bitcoin/pull/22054
 37 2021-06-02T04:13:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 38 2021-06-02T04:22:33  *** EPiSKiNG- <EPiSKiNG-!~EPiSKiNG-@episking.com> has joined #bitcoin-core-dev
 39 2021-06-02T04:33:00  *** belcher_ <belcher_!~belcher@user/belcher> has joined #bitcoin-core-dev
 40 2021-06-02T04:35:51  *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 265 seconds)
 41 2021-06-02T04:56:42  *** DeanGuss <DeanGuss!~dean@nonplayercharacter.me> has joined #bitcoin-core-dev
 42 2021-06-02T05:46:19  *** goatpig <goatpig!~goat@h-94-254-2-155.A498.priv.bahnhof.se> has quit IRC (Quit: Konversation terminated!)
 43 2021-06-02T05:47:32  *** klement <klement!~klement@> has quit IRC (Ping timeout: 250 seconds)
 44 2021-06-02T05:56:38  *** jarthur_ <jarthur_!~jarthur@2603-8080-1540-002d-1dc8-ad8e-06d0-f812.res6.spectrum.com> has quit IRC (Ping timeout: 272 seconds)
 45 2021-06-02T05:57:01  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-c9ff-b6a0-236c-2bdd.res6.spectrum.com> has joined #bitcoin-core-dev
 46 2021-06-02T05:59:41  *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has joined #bitcoin-core-dev
 47 2021-06-02T06:05:53  *** kvs <kvs!~root@> has left #bitcoin-core-dev (WeeChat 3.1)
 48 2021-06-02T06:09:16  *** calvinalvin <calvinalvin!~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com> has joined #bitcoin-core-dev
 49 2021-06-02T06:09:21  *** kcalvinalvin <kcalvinalvin!~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com> has quit IRC (Ping timeout: 272 seconds)
 50 2021-06-02T06:09:48  *** calvinalvin is now known as kcalvinalvin
 51 2021-06-02T06:10:34  *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has quit IRC (Ping timeout: 272 seconds)
 52 2021-06-02T06:25:24  *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has joined #bitcoin-core-dev
 53 2021-06-02T06:25:39  *** jarthur_ <jarthur_!~jarthur@2603-8080-1540-002d-f41b-1ba7-b2bc-ba31.res6.spectrum.com> has joined #bitcoin-core-dev
 54 2021-06-02T06:29:06  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-c9ff-b6a0-236c-2bdd.res6.spectrum.com> has quit IRC (Ping timeout: 264 seconds)
 55 2021-06-02T06:35:05  *** jarthur_ <jarthur_!~jarthur@2603-8080-1540-002d-f41b-1ba7-b2bc-ba31.res6.spectrum.com> has quit IRC (Quit: jarthur_)
 56 2021-06-02T06:53:56  *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has joined #bitcoin-core-dev
 57 2021-06-02T06:59:53  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
 58 2021-06-02T07:03:54  *** dvd <dvd!~dvd@nat-pool-rdu-t.redhat.com> has quit IRC (Read error: Connection reset by peer)
 59 2021-06-02T07:04:13  *** dvd <dvd!~dvd@nat-pool-rdu-t.redhat.com> has joined #bitcoin-core-dev
 60 2021-06-02T07:21:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 61 2021-06-02T07:21:42  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a83bbf02c762...2fccd9cf3036
 62 2021-06-02T07:21:42  <bitcoin-git> bitcoin/master e3c866e Martin Ankerl: test: update nanobench from release 4.0.0 to 4.3.4
 63 2021-06-02T07:21:42  <bitcoin-git> bitcoin/master 44d05d0 Martin Ankerl: test: remove sanitizer suppression for nanobench
 64 2021-06-02T07:21:42  <bitcoin-git> bitcoin/master 2fccd9c MarcoFalke: Merge bitcoin/bitcoin#22082: test: update nanobench from release 4.0.0 to ...
 65 2021-06-02T07:21:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 66 2021-06-02T07:21:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 67 2021-06-02T07:21:58  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22082: test: update nanobench from release 4.0.0 to 4.3.4 (master...2021-05-update-nanobench) https://github.com/bitcoin/bitcoin/pull/22082
 68 2021-06-02T07:21:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 69 2021-06-02T07:33:03  *** morcos <morcos!~morcos@gateway/tor-sasl/morcos> has quit IRC (Remote host closed the connection)
 70 2021-06-02T07:33:22  *** morcos <morcos!~morcos@gateway/tor-sasl/morcos> has joined #bitcoin-core-dev
 71 2021-06-02T07:33:43  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 252 seconds)
 72 2021-06-02T07:42:09  *** linuxgeek <linuxgeek!linuxgeek@14-203-172-78.tpgi.com.au> has joined #bitcoin-core-dev
 73 2021-06-02T07:44:44  *** Kiminuo <Kiminuo!~Kiminuo@> has joined #bitcoin-core-dev
 74 2021-06-02T07:49:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 75 2021-06-02T07:49:30  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22121: doc: Various validation doc fixups (master...2106-docVal) https://github.com/bitcoin/bitcoin/pull/22121
 76 2021-06-02T07:49:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 77 2021-06-02T07:52:57  *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f03bc00450477d61102fa6c.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
 78 2021-06-02T08:04:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 79 2021-06-02T08:04:34  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22122: ci: Bump macOS image to big-sur-xcode-12.5 (master...2106-ciMac) https://github.com/bitcoin/bitcoin/pull/22122
 80 2021-06-02T08:04:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 81 2021-06-02T08:25:57  *** ksprd2 <ksprd2!~ksprd@> has joined #bitcoin-core-dev
 82 2021-06-02T08:31:14  <hebasto> gh did not update a pr after force pushing my local branch -- any advice?
 83 2021-06-02T08:32:45  <_aj_> push the parent commit, then re-push the commit you actually want
 84 2021-06-02T08:33:17  <hebasto> _aj_: thanks, will try it
 85 2021-06-02T08:33:37  <jnewbery> github doesn't seem to be letting me leave comments right now. Maybe they're having a partial outage?
 86 2021-06-02T08:33:42  <_aj_> (or make a dummy child commit, then get rid of it)
 87 2021-06-02T08:35:57  *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
 88 2021-06-02T08:36:41  <jnewbery> yeah, github is having lots of issues right now
 89 2021-06-02T08:37:33  <hebasto> indeed, https://www.githubstatus.com/incidents/76nv9h8pmkv4?utm_ts=1622622945
 90 2021-06-02T08:41:46  *** smartin <smartin!~Icedove@> has joined #bitcoin-core-dev
 91 2021-06-02T09:06:01  *** evias <evias!~evias__@196.red-88-6-131.staticip.rima-tde.net> has joined #bitcoin-core-dev
 92 2021-06-02T09:06:35  <promag> yup, issues downloading archives for depends build
 93 2021-06-02T09:07:58  <jnewbery> I'm able to leave comments again, so it's at least partially resolved
 94 2021-06-02T09:10:57  <hebasto> works for me too
 95 2021-06-02T09:11:39  <promag> #22123 fixes depends for m1
 96 2021-06-02T09:11:40  <gribble> https://github.com/bitcoin/bitcoin/issues/22123 | depends: Fix qt.mk for mac arm64 by promag · Pull Request #22123 · bitcoin/bitcoin · GitHub
 97 2021-06-02T09:27:32  *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has quit IRC (Ping timeout: 272 seconds)
 98 2021-06-02T09:28:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 99 2021-06-02T09:28:44  <bitcoin-git> [bitcoin] promag opened pull request #22123: depends: Fix qt.mk for mac arm64 (master...2021-06-fix-aarch64_darwin) https://github.com/bitcoin/bitcoin/pull/22123
100 2021-06-02T09:28:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
101 2021-06-02T09:30:41  *** hendi <hendi!sid489601@id-489601.tooting.irccloud.com> has joined #bitcoin-core-dev
102 2021-06-02T09:30:42  *** ksprd2 <ksprd2!~ksprd@> has quit IRC (Ping timeout: 272 seconds)
103 2021-06-02T09:36:37  *** ksprd2 <ksprd2!~ksprd@> has joined #bitcoin-core-dev
104 2021-06-02T09:41:02  *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Quit: Ping timeout (120 seconds))
105 2021-06-02T09:41:13  *** ksprd2 <ksprd2!~ksprd@> has quit IRC (Ping timeout: 244 seconds)
106 2021-06-02T09:43:25  *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has joined #bitcoin-core-dev
107 2021-06-02T09:56:37  *** ksprd2 <ksprd2!~ksprd@> has joined #bitcoin-core-dev
108 2021-06-02T10:05:32  *** ksprd2 <ksprd2!~ksprd@> has quit IRC (Ping timeout: 272 seconds)
109 2021-06-02T10:16:25  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
110 2021-06-02T10:16:51  *** ksprd2 <ksprd2!~ksprd@> has joined #bitcoin-core-dev
111 2021-06-02T10:18:12  *** belcher_ <belcher_!~belcher@user/belcher> has quit IRC (Ping timeout: 272 seconds)
112 2021-06-02T10:24:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
113 2021-06-02T10:24:42  <bitcoin-git> [gui] laanwj merged pull request #351: Translations update (master...210601-tr) https://github.com/bitcoin-core/gui/pull/351
114 2021-06-02T10:24:43  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
115 2021-06-02T10:25:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
116 2021-06-02T10:25:01  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2fccd9cf3036...e3d644a127e1
117 2021-06-02T10:25:01  <bitcoin-git> bitcoin/master 0680460 Hennadii Stepanov: qt: Translations update
118 2021-06-02T10:25:01  <bitcoin-git> bitcoin/master e3d644a W. J. van der Laan: Merge bitcoin-core/gui#351: Translations update
119 2021-06-02T10:25:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
120 2021-06-02T10:28:21  *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
121 2021-06-02T10:29:05  <fanquake> promag: what's wrong with it now. I thought that line had already been added to fix it
122 2021-06-02T10:29:57  <fanquake> I wouldn't have to ask if that PR, or even the commit had a useful description
123 2021-06-02T10:30:43  <fanquake> Why does this trend of opening description-less, or just very poorly explained PRs seem to be becoming more frequent
124 2021-06-02T10:32:51  *** ksprd2 <ksprd2!~ksprd@> has quit IRC (Ping timeout: 245 seconds)
125 2021-06-02T10:35:09  <laanwj> yes lets encourage PRs to have useful descriptions
126 2021-06-02T10:36:10  <laanwj> at the least: what does it change, what does it fix, even more helpful "how to test" "how to review"
127 2021-06-02T10:40:46  *** ksprd2 <ksprd2!~ksprd@> has joined #bitcoin-core-dev
128 2021-06-02T10:45:17  *** ksprd2 <ksprd2!~ksprd@> has quit IRC (Ping timeout: 244 seconds)
129 2021-06-02T10:46:30  *** ksprd2 <ksprd2!~ksprd@> has joined #bitcoin-core-dev
130 2021-06-02T10:50:05  <fanquake> laanwj: Yes. I've tried to summarize something similar here: https://github.com/bitcoin/bitcoin/pull/21570#issuecomment-819220600
131 2021-06-02T10:50:58  *** ksprd2 <ksprd2!~ksprd@> has quit IRC (Ping timeout: 244 seconds)
132 2021-06-02T10:51:58  *** Guest64 <Guest64!~Guest64@> has joined #bitcoin-core-dev
133 2021-06-02T10:52:20  *** ksprd2 <ksprd2!~ksprd@> has joined #bitcoin-core-dev
134 2021-06-02T10:55:27  <_aj_> yay for descriptive PR descriptions
135 2021-06-02T10:56:58  <michaelfolkson> Is this worth putting in CONTRIBUTING.md? (the fanquake guidance)
136 2021-06-02T10:57:28  *** ksprd2 <ksprd2!~ksprd@> has quit IRC (Ping timeout: 272 seconds)
137 2021-06-02T10:57:45  <laanwj> definitely (if there isn't anything like that in there yet)
138 2021-06-02T10:58:11  *** ksprd2 <ksprd2!~ksprd@> has joined #bitcoin-core-dev
139 2021-06-02T10:59:58  <michaelfolkson> OK happy to add this to my to do list (assuming fanquake doesn't want to open the PR)
140 2021-06-02T11:02:01  <fanquake> I'm not fussed. I'd like to think it's obvious that when you open a PR, you should take 2 minutes to summarize your change, including relevant / useful info, and save reviewers having to ask dumb things like "what is the bug", "how does it fix it" etc.
141 2021-06-02T11:02:50  *** belcher <belcher!~belcher@user/belcher> has quit IRC (Quit: Leaving)
142 2021-06-02T11:05:46  *** ksprd2 <ksprd2!~ksprd@> has quit IRC (Ping timeout: 245 seconds)
143 2021-06-02T11:06:08  <laanwj> i agree, but mentioning it explicitly in a document might be useful to point people to instead of having to type it out time after time
144 2021-06-02T11:06:51  <michaelfolkson> fanquake: Right but sometimes people struggle with what needs explaining to others when it is obvious to them. Guidance often helps as a reminder not to take shortcuts with explanations
145 2021-06-02T11:09:58  *** ksprd2 <ksprd2!~ksprd@> has joined #bitcoin-core-dev
146 2021-06-02T11:10:19  <michaelfolkson> I'll open the PR adding fanquake as a co-author then
147 2021-06-02T11:10:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
148 2021-06-02T11:10:53  <bitcoin-git> [bitcoin] hebasto opened pull request #22124: 0.20: Update translations after closing 0.20.x on Transifex (0.20...210602-0.20-tr) https://github.com/bitcoin/bitcoin/pull/22124
149 2021-06-02T11:10:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
150 2021-06-02T11:14:32  *** ksprd2 <ksprd2!~ksprd@> has quit IRC (Ping timeout: 252 seconds)
151 2021-06-02T11:15:49  *** ksprd2 <ksprd2!~ksprd@> has joined #bitcoin-core-dev
152 2021-06-02T11:43:35  *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
153 2021-06-02T11:57:05  *** belcher <belcher!~belcher@user/belcher> has quit IRC (Quit: Leaving)
154 2021-06-02T11:57:24  *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
155 2021-06-02T12:01:15  <hebasto> the Transifex.com labeled 33 languages with the "no translators" label. Those languages look abandoned as zero strings are translated for all versions. Suggesting to remove them to keep our repository tide. Or is this a topic for a weekly meeting?
156 2021-06-02T12:02:19  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
157 2021-06-02T12:03:54  <laanwj> hebasto: the transifex import script is supposed to strip empty translations, doesn't it do this anymore?
158 2021-06-02T12:06:03  <laanwj> that would be the place to solve it, i think it's okay to leave the languages on transifex so that people who want to translate them can do so
159 2021-06-02T12:06:04  <hebasto> ah, right -- no empty translations in the repo, it works
160 2021-06-02T12:07:25  <laanwj> i tend to universally accept requests to add base languages (e.g. "nl"), but careful about adding dialects "nl_EN", too easy to come up with nonsense ones and i don't have time to investigate this
161 2021-06-02T12:07:56  <hebasto> sounds reasonable to me
162 2021-06-02T12:12:37  <laanwj> though i wish the language requests came with a description field so people can provide more information about the language they want to translate to, this would make it easier to recognize non-flippant requests
163 2021-06-02T12:15:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
164 2021-06-02T12:15:24  <bitcoin-git> [bitcoin] dgoncharov opened pull request #22126: build: Disable make builtin rules. (master...disable_builtin_rules) https://github.com/bitcoin/bitcoin/pull/22126
165 2021-06-02T12:15:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
166 2021-06-02T12:15:26  <laanwj> unfortunately translations provide a fairly easy vandalism angle for people that want to mess with things, because it's inherently hard to check for language you don't know
167 2021-06-02T12:27:51  <hebasto> as usually in open-source, translationss are done and kept in a good state by people who care about it. If nobody cares, the result is unpredicted
168 2021-06-02T12:28:04  <hebasto> *translations
169 2021-06-02T12:30:50  <laanwj> right, it's just even more complicated by language barriers
170 2021-06-02T12:34:22  *** Kiminuo <Kiminuo!~Kiminuo@> has quit IRC (Ping timeout: 272 seconds)
171 2021-06-02T12:47:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
172 2021-06-02T12:47:42  <bitcoin-git> [bitcoin] Vaultbank opened pull request #22128: Create Lil* (master...patch-1) https://github.com/bitcoin/bitcoin/pull/22128
173 2021-06-02T12:47:43  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
174 2021-06-02T12:48:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
175 2021-06-02T12:48:21  <bitcoin-git> [bitcoin] fanquake closed pull request #22128: Create Lil* (master...patch-1) https://github.com/bitcoin/bitcoin/pull/22128
176 2021-06-02T12:48:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
177 2021-06-02T12:48:52  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 252 seconds)
178 2021-06-02T12:48:58  <laanwj> that was fast :)
179 2021-06-02T13:06:31  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
180 2021-06-02T13:18:20  <ufotofu> are the build instructions for linux slightly out of date? the past couple of times i've attempted building have resulted in a libboost related error that was resolved by installing libboost-all-dev (on ubuntu).
181 2021-06-02T13:18:50  <laanwj> as far as i know they are up to date, which version of ubuntu are you using
182 2021-06-02T13:19:03  <ufotofu> not sure which package it needed specifically, out of the many libboost-all-dev installs
183 2021-06-02T13:19:06  <ufotofu> 21.04
184 2021-06-02T13:19:14  <laanwj> libboost-all-dev is al extreme sledgehammer so we would like to avoid that
185 2021-06-02T13:19:22  <ufotofu> yeah understood
186 2021-06-02T13:20:31  <ufotofu> this occurred on ppc64le and now on riscv64 too. can't remember if i ran into it on x86_64.
187 2021-06-02T13:22:49  <promag> fanquake: yup my bad
188 2021-06-02T13:23:04  <laanwj> that might explain things, i suppose most people following the instrucitons will be using x86_64, ppc and risc-v are usually cross-compiled, anyhow let us know if you figure out which package is missing
189 2021-06-02T13:24:11  <laanwj> it might also be a bug in the platform-specific parts of the boost detection am scripting (vaguely remember that a architecture-specific path is injected somewhere)
190 2021-06-02T13:31:46  <ufotofu> pretty sure i ran into it on arm64 too so you're probably right
191 2021-06-02T13:34:06  *** ksprd2 <ksprd2!~ksprd@> has quit IRC (Ping timeout: 245 seconds)
192 2021-06-02T13:36:03  *** ksprd2 <ksprd2!~ksprd@> has joined #bitcoin-core-dev
193 2021-06-02T13:48:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
194 2021-06-02T13:48:08  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/55631547ea88...8b5c83b4aa8c
195 2021-06-02T13:48:08  <bitcoin-git> bitcoin/0.20 56baeba Hennadii Stepanov: 0.20: Update translations after closing 0.20.x on Transifex
196 2021-06-02T13:48:08  <bitcoin-git> bitcoin/0.20 8b5c83b W. J. van der Laan: Merge bitcoin/bitcoin#22124: 0.20: Finalize translations after closing 0.2...
197 2021-06-02T13:48:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
198 2021-06-02T13:48:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
199 2021-06-02T13:48:25  <bitcoin-git> [bitcoin] laanwj merged pull request #22124: 0.20: Finalize translations after closing 0.20.x on Transifex (0.20...210602-0.20-tr) https://github.com/bitcoin/bitcoin/pull/22124
200 2021-06-02T13:48:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
201 2021-06-02T13:53:34  *** thedragon <thedragon!~thedragon@user/thedragon> has quit IRC (Quit: Leaving)
202 2021-06-02T13:58:30  *** davterra <davterra!~davterra@> has quit IRC (Ping timeout: 264 seconds)
203 2021-06-02T13:58:53  <laanwj> ufotofu: see also #17010
204 2021-06-02T13:58:55  <gribble> https://github.com/bitcoin/bitcoin/issues/17010 | Missing Boost::System on ARM Ubuntu 18.04 · Issue #17010 · bitcoin/bitcoin · GitHub
205 2021-06-02T13:59:43  <laanwj> might need a similar change like #18558 for ppc and risc-v
206 2021-06-02T13:59:45  <gribble> https://github.com/bitcoin/bitcoin/issues/18558 | build: Fix boost detection for arch armv7l by hebasto · Pull Request #18558 · bitcoin/bitcoin · GitHub
207 2021-06-02T13:59:52  *** davterra <davterra!~davterra@> has joined #bitcoin-core-dev
208 2021-06-02T14:00:14  <laanwj> unfortunately there's all kinds of variability in directory names and it needs to be handled per platform...
209 2021-06-02T14:02:59  <ufotofu> hm might be related. i'm running into it after running `make`.
210 2021-06-02T14:03:18  <laanwj> okay that seems to be a different issue
211 2021-06-02T14:03:20  <ufotofu> configure doesn't seem to catch that it's missing
212 2021-06-02T14:10:16  <laanwj> i'd be very interested to know t he exact error you are getting
213 2021-06-02T14:15:51  <ufotofu> https://pastebin.com/raw/GfvaFpXG
214 2021-06-02T14:15:57  <ufotofu> that's all that was still in my buffer
215 2021-06-02T14:19:15  <laanwj> thanks-that looks like boost_thread isn't linked correctly, which is weird, i guess this is for 0.21? fwiw the master branch no longer uses boost thread at all so might have solved this issue
216 2021-06-02T14:19:19  *** thedragon <thedragon!~thedragon@user/thedragon> has joined #bitcoin-core-dev
217 2021-06-02T14:19:29  <ufotofu> v0.21.1
218 2021-06-02T14:23:30  *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has quit IRC (Quit: Konversation terminated!)
219 2021-06-02T14:24:24  <hebasto> ufotofu: https://github.com/bitcoin/bitcoin/blob/0.21/doc/build-unix.md mentions the `libboost-thread-dev` package
220 2021-06-02T14:25:08  <promag> fanquake: added details
221 2021-06-02T14:26:51  <ufotofu> hebasto: hmm not under the ubuntu & debian dependency build instructions though
222 2021-06-02T14:28:11  <ufotofu> i don't see where it specifically mentions libboost-thread-dev either
223 2021-06-02T14:28:44  <hebasto> have you followed the link https://github.com/bitcoin/bitcoin/blob/0.21/doc/build-unix.md ?
224 2021-06-02T14:29:12  <ufotofu> oh, right
225 2021-06-02T14:29:13  <laanwj> it might be that you followed the instructions on the master branch, which don't mention installing boost-thread-dev because it is no longer needed
226 2021-06-02T14:29:23  <ufotofu> aha ok that makes sense
227 2021-06-02T14:32:47  <ufotofu> ok sorry for wasting your time >_>
228 2021-06-02T14:33:30  <hebasto> np, happy your problem is solved
229 2021-06-02T14:33:52  <laanwj> no problem, i think it's a bug that configure doesn't report the missing library but it fails at link time, though probably not worth fixing anymore
230 2021-06-02T14:53:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
231 2021-06-02T14:53:43  <bitcoin-git> [bitcoin] laanwj pushed 17 commits to master: https://github.com/bitcoin/bitcoin/compare/e3d644a127e1...a7d17daa5cd8
232 2021-06-02T14:53:43  <bitcoin-git> bitcoin/master 883a5c7 fanquake: test: remove BasicTestingSetup from allocator unit tests
233 2021-06-02T14:53:43  <bitcoin-git> bitcoin/master 0559065 fanquake: test: remove BasicTestingSetup from amount unit tests
234 2021-06-02T14:53:43  <bitcoin-git> bitcoin/master 4c389ba fanquake: test: remove BasicTestingSetup from arith_uint256 unit tests
235 2021-06-02T14:53:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
236 2021-06-02T14:53:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
237 2021-06-02T14:54:00  <bitcoin-git> [bitcoin] laanwj merged pull request #22086: test: remove BasicTestingSetup from unit tests that don't need it (master...remove_unneeded_test_setup) https://github.com/bitcoin/bitcoin/pull/22086
238 2021-06-02T14:54:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
239 2021-06-02T15:01:35  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
240 2021-06-02T15:01:35  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a7d17daa5cd8...1186910b6b7b
241 2021-06-02T15:01:35  <bitcoin-git> bitcoin/master dafab2b Jarol Rodriguez: doc: improve note on choosing posix mingw32
242 2021-06-02T15:01:35  <bitcoin-git> bitcoin/master 1186910 W. J. van der Laan: Merge bitcoin/bitcoin#22088: doc: improve note on choosing posix mingw32
243 2021-06-02T15:01:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
244 2021-06-02T15:01:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
245 2021-06-02T15:01:52  <bitcoin-git> [bitcoin] laanwj merged pull request #22088: doc: improve note on choosing posix mingw32 (master...windows-ubuntu-note) https://github.com/bitcoin/bitcoin/pull/22088
246 2021-06-02T15:01:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
247 2021-06-02T15:25:15  *** Guest64 <Guest64!~Guest64@> has quit IRC (Quit: Client closed)
248 2021-06-02T15:26:56  *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
249 2021-06-02T15:50:51  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-f5de-bb6e-193b-06d2.res6.spectrum.com> has joined #bitcoin-core-dev
250 2021-06-02T15:59:05  *** jonatack <jonatack!jonatack@user/jonatack> has left #bitcoin-core-dev
251 2021-06-02T16:18:00  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
252 2021-06-02T16:20:59  <hebasto> achow101: meshcollider: how we could get debugging info about wallet load crash in a way safe for users? (context -- #22083)
253 2021-06-02T16:21:00  <gribble> https://github.com/bitcoin/bitcoin/issues/22083 | Bitcoin-Qt crashes on OS X · Issue #22083 · bitcoin/bitcoin · GitHub
254 2021-06-02T16:25:36  *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f03bc00450477d61102fa6c.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
255 2021-06-02T16:28:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
256 2021-06-02T16:28:57  <bitcoin-git> [bitcoin] theStack opened pull request #22130: test: refactor: dedup utility function chain_transaction() (master...20210601-test-dedup_chain_transaction) https://github.com/bitcoin/bitcoin/pull/22130
257 2021-06-02T16:28:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
258 2021-06-02T16:40:21  *** ksprd2 <ksprd2!~ksprd@> has quit IRC (Ping timeout: 245 seconds)
259 2021-06-02T16:42:59  *** evias <evias!~evias__@user/evias> has quit IRC (Quit: Leaving)
260 2021-06-02T16:54:21  <hebasto> laanwj: could you have a look at https://github.com/bitcoin/bitcoin/pull/21654#issuecomment-839428062, please?
261 2021-06-02T16:56:54  <achow101> hebasto: the best way would be to get them to be able to replicate the crash on testnet or regtest and then send us the offending wallet file
262 2021-06-02T17:01:31  *** lightlike <lightlike!~lightlike@user/lightlike> has joined #bitcoin-core-dev
263 2021-06-02T17:13:25  *** b10c <b10c!uid500648@id-500648.charlton.irccloud.com> has joined #bitcoin-core-dev
264 2021-06-02T17:16:11  *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has quit IRC (Ping timeout: 245 seconds)
265 2021-06-02T17:23:44  *** AaronvanW <AaronvanW!~AaronvanW@> has joined #bitcoin-core-dev
266 2021-06-02T17:23:57  *** AaronvanW <AaronvanW!~AaronvanW@> has quit IRC (Remote host closed the connection)
267 2021-06-02T17:25:42  *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has joined #bitcoin-core-dev
268 2021-06-02T17:30:52  *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has quit IRC (Ping timeout: 244 seconds)
269 2021-06-02T17:43:29  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 272 seconds)
270 2021-06-02T17:43:54  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
271 2021-06-02T18:08:07  *** bomb-on <bomb-on!~bomb-on@> has joined #bitcoin-core-dev
272 2021-06-02T18:24:10  *** AaronvanW <AaronvanW!~AaronvanW@> has joined #bitcoin-core-dev
273 2021-06-02T18:31:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
274 2021-06-02T18:31:03  <bitcoin-git> [bitcoin] hebasto opened pull request #22133: build, qt: Make QWindowsVistaStylePlugin available again (regression) (master...210602-style) https://github.com/bitcoin/bitcoin/pull/22133
275 2021-06-02T18:31:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
276 2021-06-02T18:37:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
277 2021-06-02T18:37:50  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1186910b6b7b...2aab8a6dd0b5
278 2021-06-02T18:37:50  <bitcoin-git> bitcoin/master 9a09695 Fu Yong Quah: build: Add /opt/homebrew to path to look for boost libraries
279 2021-06-02T18:37:50  <bitcoin-git> bitcoin/master 2aab8a6 W. J. van der Laan: Merge bitcoin/bitcoin#21231: Add /opt/homebrew to path to look for boost l...
280 2021-06-02T18:37:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
281 2021-06-02T18:38:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
282 2021-06-02T18:38:07  <bitcoin-git> [bitcoin] laanwj merged pull request #21231: Add /opt/homebrew to path to look for boost libraries (master...modify-boost-path-for-m1-macs) https://github.com/bitcoin/bitcoin/pull/21231
283 2021-06-02T18:38:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
284 2021-06-02T18:38:51  *** roconnor_ <roconnor_!~roconnor@host-45-58-218-136.dyn.295.ca> has joined #bitcoin-core-dev
285 2021-06-02T18:39:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
286 2021-06-02T18:39:49  <bitcoin-git> [gui] hebasto closed pull request #322: Improve Overview tab look on Windows (master...210508-frame) https://github.com/bitcoin-core/gui/pull/322
287 2021-06-02T18:39:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
288 2021-06-02T18:41:08  *** roconnor <roconnor!~roconnor@host-184-164-3-109.dyn.295.ca> has quit IRC (Ping timeout: 252 seconds)
289 2021-06-02T18:41:58  *** powerjungle <powerjungle!~powerjung@h081217087223.dyn.cm.kabsi.at> has quit IRC (Quit: ZNC - https://znc.in)
290 2021-06-02T18:52:59  *** roconnor_ is now known as roconnor
291 2021-06-02T19:02:24  *** powerjungle <powerjungle!~powerjung@h081217087223.dyn.cm.kabsi.at> has joined #bitcoin-core-dev
292 2021-06-02T19:29:13  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
293 2021-06-02T19:57:19  *** smartin <smartin!~Icedove@> has quit IRC (Quit: smartin)
294 2021-06-02T20:23:06  *** b10c <b10c!uid500648@id-500648.charlton.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
295 2021-06-02T20:42:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
296 2021-06-02T20:42:01  <bitcoin-git> [bitcoin] kiminuo opened pull request #22135: CRegTestParams: Use `args` instead of `gArgs`. (master...feature/2021-06-02-chainparams-n-gArgs) https://github.com/bitcoin/bitcoin/pull/22135
297 2021-06-02T20:42:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
298 2021-06-02T20:52:59  *** AaronvanW <AaronvanW!~AaronvanW@> has quit IRC (Remote host closed the connection)
299 2021-06-02T21:02:49  *** evias <evias!~evias__@196.red-88-6-131.staticip.rima-tde.net> has joined #bitcoin-core-dev
300 2021-06-02T22:43:08  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 252 seconds)
301 2021-06-02T22:58:46  *** evias <evias!~evias__@user/evias> has quit IRC (Quit: This computer has gone to sleep)
302 2021-06-02T23:07:08  *** bomb-on <bomb-on!~bomb-on@> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
303 2021-06-02T23:31:40  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev