1 2021-06-03T00:02:42  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-f5de-bb6e-193b-06d2.res6.spectrum.com> has quit IRC (Ping timeout: 264 seconds)
  2 2021-06-03T00:07:43  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-f5de-bb6e-193b-06d2.res6.spectrum.com> has joined #bitcoin-core-dev
  3 2021-06-03T00:07:52  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
  4 2021-06-03T00:08:30  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 272 seconds)
  5 2021-06-03T00:10:52  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 252 seconds)
  6 2021-06-03T00:11:41  *** lightlike <lightlike!~lightlike@user/lightlike> has quit IRC (Quit: Leaving)
  7 2021-06-03T00:14:29  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
  8 2021-06-03T00:21:52  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 252 seconds)
  9 2021-06-03T00:39:08  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 10 2021-06-03T00:39:32  *** Zenton <Zenton!~user@user/zenton> has quit IRC (Remote host closed the connection)
 11 2021-06-03T00:55:26  <fanquake> promag: thanks
 12 2021-06-03T01:19:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 13 2021-06-03T01:19:04  <bitcoin-git> [bitcoin] Empact reopened pull request #13226: Optimize SelectCoinsBnB by tracking the selection by index rather than by position (master...select-bnb-by-index) https://github.com/bitcoin/bitcoin/pull/13226
 14 2021-06-03T01:19:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 15 2021-06-03T01:24:28  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-f5de-bb6e-193b-06d2.res6.spectrum.com> has quit IRC (Remote host closed the connection)
 16 2021-06-03T01:24:50  *** jarthur_ <jarthur_!~jarthur@cpe-70-114-198-37.austin.res.rr.com> has joined #bitcoin-core-dev
 17 2021-06-03T01:25:07  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 252 seconds)
 18 2021-06-03T01:34:10  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 19 2021-06-03T02:56:18  *** jarthur_ <jarthur_!~jarthur@cpe-70-114-198-37.austin.res.rr.com> has quit IRC (Read error: Connection reset by peer)
 20 2021-06-03T03:00:28  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-f5de-bb6e-193b-06d2.res6.spectrum.com> has joined #bitcoin-core-dev
 21 2021-06-03T04:31:02  *** jarthur_ <jarthur_!~jarthur@2603-8080-1540-002d-2dc9-1669-3128-3208.res6.spectrum.com> has joined #bitcoin-core-dev
 22 2021-06-03T04:32:54  *** belcher_ <belcher_!~belcher@user/belcher> has joined #bitcoin-core-dev
 23 2021-06-03T04:35:06  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-f5de-bb6e-193b-06d2.res6.spectrum.com> has quit IRC (Ping timeout: 264 seconds)
 24 2021-06-03T04:36:11  *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 245 seconds)
 25 2021-06-03T04:43:03  *** dongcarl <dongcarl!~dongcarl@96.224.58.144> has quit IRC (Ping timeout: 244 seconds)
 26 2021-06-03T05:01:33  *** dongcarl <dongcarl!~dongcarl@96.224.58.144> has joined #bitcoin-core-dev
 27 2021-06-03T05:47:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 28 2021-06-03T05:47:51  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2aab8a6dd0b5...fd7a770d32af
 29 2021-06-03T05:47:51  <bitcoin-git> bitcoin/master faa8dfd MarcoFalke: ci: Bump macOS image to big-sur-xcode-12.5
 30 2021-06-03T05:47:51  <bitcoin-git> bitcoin/master fd7a770 MarcoFalke: Merge bitcoin/bitcoin#22122: ci: Bump macOS image to big-sur-xcode-12.5
 31 2021-06-03T05:47:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 32 2021-06-03T05:48:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 33 2021-06-03T05:48:09  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22122: ci: Bump macOS image to big-sur-xcode-12.5 (master...2106-ciMac) https://github.com/bitcoin/bitcoin/pull/22122
 34 2021-06-03T05:48:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 35 2021-06-03T06:16:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 36 2021-06-03T06:16:38  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fd7a770d32af...001116719191
 37 2021-06-03T06:16:38  <bitcoin-git> bitcoin/master 5f23531 Kiminuo: CRegTestParams: Use `args` instead of `gArgs`.
 38 2021-06-03T06:16:38  <bitcoin-git> bitcoin/master 0011167 MarcoFalke: Merge bitcoin/bitcoin#22135: CRegTestParams: Use `args` instead of `gArgs`...
 39 2021-06-03T06:16:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 40 2021-06-03T06:16:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 41 2021-06-03T06:16:54  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22135: CRegTestParams: Use `args` instead of `gArgs`. (master...feature/2021-06-02-chainparams-n-gArgs) https://github.com/bitcoin/bitcoin/pull/22135
 42 2021-06-03T06:16:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 43 2021-06-03T06:19:38  *** senx8 <senx8!~senx@2600:1700:42f0:f60:c0f4:898b:4a73:14b1> has joined #bitcoin-core-dev
 44 2021-06-03T06:20:43  *** SenX <SenX!~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1> has joined #bitcoin-core-dev
 45 2021-06-03T06:22:06  *** senx8 <senx8!~senx@2600:1700:42f0:f60:c0f4:898b:4a73:14b1> has quit IRC (Client Quit)
 46 2021-06-03T06:25:15  *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has joined #bitcoin-core-dev
 47 2021-06-03T06:27:18  *** linuxgeek <linuxgeek!linuxgeek@14-203-172-78.tpgi.com.au> has left #bitcoin-core-dev
 48 2021-06-03T06:44:32  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-7c3e-5f85-a09f-91e1.res6.spectrum.com> has joined #bitcoin-core-dev
 49 2021-06-03T06:48:08  *** jarthur_ <jarthur_!~jarthur@2603-8080-1540-002d-2dc9-1669-3128-3208.res6.spectrum.com> has quit IRC (Ping timeout: 272 seconds)
 50 2021-06-03T06:54:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 51 2021-06-03T06:54:20  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/001116719191...a9435e34457e
 52 2021-06-03T06:54:20  <bitcoin-git> bitcoin/master 3737126 practicalswift: Mark `CheckTxInputs` `[[nodiscard]]` (out-param `txfee` only set if call i...
 53 2021-06-03T06:54:20  <bitcoin-git> bitcoin/master a9435e3 MarcoFalke: Merge bitcoin/bitcoin#22065: Mark `CheckTxInputs` `[[nodiscard]]`. Avoid U...
 54 2021-06-03T06:54:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 55 2021-06-03T06:54:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 56 2021-06-03T06:54:37  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22065: Mark `CheckTxInputs` `[[nodiscard]]`. Avoid UUM in fuzzing harness `coins_view`. (master...nodiscard-CheckTxInputs) https://github.com/bitcoin/bitcoin/pull/22065
 57 2021-06-03T06:54:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 58 2021-06-03T07:05:53  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
 59 2021-06-03T07:08:00  *** smartin <smartin!~Icedove@88.135.18.171> has joined #bitcoin-core-dev
 60 2021-06-03T07:46:43  *** SenX <SenX!~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1> has quit IRC (Quit: My iMac has gone to sleep. ZZZzzz…)
 61 2021-06-03T07:57:13  *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f03bc009e794642704b3134.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
 62 2021-06-03T07:59:24  *** evias <evias!~evias__@196.red-88-6-131.staticip.rima-tde.net> has joined #bitcoin-core-dev
 63 2021-06-03T08:15:16  *** belcher_ <belcher_!~belcher@user/belcher> has quit IRC (Quit: Leaving)
 64 2021-06-03T08:15:21  *** promag <promag!~promag@188.250.84.129> has quit IRC (Read error: Connection reset by peer)
 65 2021-06-03T08:15:38  *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
 66 2021-06-03T08:15:50  *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
 67 2021-06-03T08:16:41  *** belcher <belcher!~belcher@user/belcher> has quit IRC (Remote host closed the connection)
 68 2021-06-03T08:17:02  *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
 69 2021-06-03T08:43:30  *** LEI <LEI!~LEI@185.57.220.232> has joined #bitcoin-core-dev
 70 2021-06-03T08:45:47  *** LEI <LEI!~LEI@185.57.220.232> has quit IRC (Client Quit)
 71 2021-06-03T08:55:24  *** kvs <kvs!~root@175.102.16.34> has joined #bitcoin-core-dev
 72 2021-06-03T08:59:28  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 73 2021-06-03T08:59:28  <bitcoin-git> [gui] promag opened pull request #354: Refactor open date range to use std::optional (master...2021-06-date-range) https://github.com/bitcoin-core/gui/pull/354
 74 2021-06-03T08:59:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 75 2021-06-03T09:04:52  *** metta <metta!~Advanced@2a01:4f8:1c0c:49df::1> has quit IRC (Quit: metta)
 76 2021-06-03T09:05:04  *** upekkha <upekkha!~Advanced@2a01:4f8:1c0c:49df::1> has joined #bitcoin-core-dev
 77 2021-06-03T09:07:50  *** kvs <kvs!~root@175.102.16.34> has left #bitcoin-core-dev (WeeChat 3.1)
 78 2021-06-03T09:15:50  *** thedragon <thedragon!~thedragon@user/thedragon> has quit IRC (Read error: Connection reset by peer)
 79 2021-06-03T09:16:05  *** thedragon <thedragon!~thedragon@user/thedragon> has joined #bitcoin-core-dev
 80 2021-06-03T09:20:46  *** orionwl[m] <orionwl[m]!~orionwlx0@2001:470:69fc:105::80> has quit IRC (Ping timeout: 268 seconds)
 81 2021-06-03T09:21:01  *** vincenzopalazzo <vincenzopalazzo!~vincenzop@2001:470:69fc:105::a67> has quit IRC (Ping timeout: 244 seconds)
 82 2021-06-03T09:21:01  *** dongcarl[m] <dongcarl[m]!~dongcarlm@2001:470:69fc:105::82> has quit IRC (Ping timeout: 244 seconds)
 83 2021-06-03T09:21:01  *** kvaciral[m] <kvaciral[m]!~kvaciralx@2001:470:69fc:105::17b> has quit IRC (Ping timeout: 244 seconds)
 84 2021-06-03T09:21:23  *** mrjumper[m] <mrjumper[m]!~mr-jumper@2001:470:69fc:105::7f1> has quit IRC (Ping timeout: 268 seconds)
 85 2021-06-03T09:21:39  *** prusnak[m] <prusnak[m]!~stickmatr@2001:470:69fc:105::98c> has quit IRC (Ping timeout: 272 seconds)
 86 2021-06-03T09:38:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 87 2021-06-03T09:38:38  <bitcoin-git> [bitcoin] promag opened pull request #22136: Add --disable-rpc configure option (master...2021-06-disable-rpc) https://github.com/bitcoin/bitcoin/pull/22136
 88 2021-06-03T09:38:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 89 2021-06-03T09:42:43  *** evias <evias!~evias__@user/evias> has quit IRC (Quit: This computer has gone to sleep)
 90 2021-06-03T09:48:54  *** evias <evias!~evias__@196.red-88-6-131.staticip.rima-tde.net> has joined #bitcoin-core-dev
 91 2021-06-03T09:48:54  *** evias <evias!~evias__@user/evias> has quit IRC (Client Quit)
 92 2021-06-03T09:56:17  *** evias <evias!~evias__@196.red-88-6-131.staticip.rima-tde.net> has joined #bitcoin-core-dev
 93 2021-06-03T09:56:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 94 2021-06-03T09:56:21  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22137: util: Properly handle -noincludeconf on command line (master...2106-utilTake2) https://github.com/bitcoin/bitcoin/pull/22137
 95 2021-06-03T09:56:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 96 2021-06-03T10:01:20  *** berndj <berndj!~berndj@ns1.linksynergy.co.za> has quit IRC (*.net *.split)
 97 2021-06-03T10:01:20  *** tripleslash <tripleslash!~triplesla@50.225.175.210> has quit IRC (*.net *.split)
 98 2021-06-03T10:01:20  *** fanquake <fanquake!sid369002@user/fanquake> has quit IRC (*.net *.split)
 99 2021-06-03T10:01:20  *** FelixWeis <FelixWeis!sid154231@id-154231.stonehaven.irccloud.com> has quit IRC (*.net *.split)
100 2021-06-03T10:01:20  *** elichai2 <elichai2!sid212594@id-212594.stonehaven.irccloud.com> has quit IRC (*.net *.split)
101 2021-06-03T10:01:20  *** ryanofsky <ryanofsky!~russ@jumpy.yanofsky.org> has quit IRC (*.net *.split)
102 2021-06-03T10:01:20  *** kabaum <kabaum!~kabaum@h-46-59-13-35.A163.priv.bahnhof.se> has quit IRC (*.net *.split)
103 2021-06-03T10:01:20  *** xycco <xycco!~okihus@cs.uef.fi> has quit IRC (*.net *.split)
104 2021-06-03T10:01:20  *** dr-orlovsky <dr-orlovsky!~dr-orlovs@31.14.40.19> has quit IRC (*.net *.split)
105 2021-06-03T10:01:20  *** emzy <emzy!~quassel@user/emzy> has quit IRC (*.net *.split)
106 2021-06-03T10:01:20  *** meshcollider <meshcollider!meshcollid@user/meshcollider> has quit IRC (*.net *.split)
107 2021-06-03T10:01:20  *** warren <warren!~warren@fedora/wombat/warren> has quit IRC (*.net *.split)
108 2021-06-03T10:01:20  *** nickler <nickler!~nickler@static.219.205.69.159.clients.your-server.de> has quit IRC (*.net *.split)
109 2021-06-03T10:01:20  *** jnewbery <jnewbery!~john@user/jnewbery> has quit IRC (*.net *.split)
110 2021-06-03T10:01:21  *** MarcoFalke <MarcoFalke!~none@198.12.116.246> has quit IRC (*.net *.split)
111 2021-06-03T10:01:21  *** laanwj <laanwj!~laanwj@user/laanwj> has quit IRC (*.net *.split)
112 2021-06-03T10:01:21  *** glozow <glozow!sid453516@user/glozow> has quit IRC (*.net *.split)
113 2021-06-03T10:04:33  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
114 2021-06-03T10:11:24  *** berndj <berndj!~berndj@ns1.linksynergy.co.za> has joined #bitcoin-core-dev
115 2021-06-03T10:11:24  *** tripleslash <tripleslash!~triplesla@50.225.175.210> has joined #bitcoin-core-dev
116 2021-06-03T10:11:24  *** fanquake <fanquake!sid369002@user/fanquake> has joined #bitcoin-core-dev
117 2021-06-03T10:11:24  *** elichai2 <elichai2!sid212594@id-212594.stonehaven.irccloud.com> has joined #bitcoin-core-dev
118 2021-06-03T10:11:24  *** FelixWeis <FelixWeis!sid154231@id-154231.stonehaven.irccloud.com> has joined #bitcoin-core-dev
119 2021-06-03T10:11:24  *** ryanofsky <ryanofsky!~russ@jumpy.yanofsky.org> has joined #bitcoin-core-dev
120 2021-06-03T10:11:24  *** kabaum <kabaum!~kabaum@h-46-59-13-35.A163.priv.bahnhof.se> has joined #bitcoin-core-dev
121 2021-06-03T10:11:24  *** xycco <xycco!~okihus@cs.uef.fi> has joined #bitcoin-core-dev
122 2021-06-03T10:11:24  *** dr-orlovsky <dr-orlovsky!~dr-orlovs@31.14.40.19> has joined #bitcoin-core-dev
123 2021-06-03T10:11:24  *** emzy <emzy!~quassel@user/emzy> has joined #bitcoin-core-dev
124 2021-06-03T10:11:24  *** meshcollider <meshcollider!meshcollid@user/meshcollider> has joined #bitcoin-core-dev
125 2021-06-03T10:11:24  *** warren <warren!~warren@fedora/wombat/warren> has joined #bitcoin-core-dev
126 2021-06-03T10:11:24  *** nickler <nickler!~nickler@static.219.205.69.159.clients.your-server.de> has joined #bitcoin-core-dev
127 2021-06-03T10:11:24  *** laanwj <laanwj!~laanwj@user/laanwj> has joined #bitcoin-core-dev
128 2021-06-03T10:11:24  *** jnewbery <jnewbery!~john@user/jnewbery> has joined #bitcoin-core-dev
129 2021-06-03T10:11:24  *** MarcoFalke <MarcoFalke!~none@198.12.116.246> has joined #bitcoin-core-dev
130 2021-06-03T10:11:24  *** glozow <glozow!sid453516@user/glozow> has joined #bitcoin-core-dev
131 2021-06-03T10:36:01  <jonasschnelli> #proposedmeetingtopic: Bitcoin Code Signing Association Switzerland
132 2021-06-03T10:38:40  *** thedragon <thedragon!~thedragon@user/thedragon> has quit IRC (Quit: Leaving)
133 2021-06-03T10:40:14  <michaelfolkson> #proposedmeetingtopic Reviewing progress of fortnightly Core subsystem (P2P, wallet, GUI etc) meetings
134 2021-06-03T10:45:59  *** SenX <SenX!~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1> has joined #bitcoin-core-dev
135 2021-06-03T10:58:40  *** orionwl[m] <orionwl[m]!~orionwlx0@2001:470:69fc:105::80> has joined #bitcoin-core-dev
136 2021-06-03T11:09:13  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
137 2021-06-03T11:12:11  *** SenX <SenX!~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1> has quit IRC (Quit: My iMac has gone to sleep. ZZZzzz…)
138 2021-06-03T11:37:21  *** vincenzopalazzo <vincenzopalazzo!~vincenzop@2001:470:69fc:105::a67> has joined #bitcoin-core-dev
139 2021-06-03T11:37:30  *** dongcarl[m] <dongcarl[m]!~dongcarlm@2001:470:69fc:105::82> has joined #bitcoin-core-dev
140 2021-06-03T11:58:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
141 2021-06-03T11:58:30  <bitcoin-git> [bitcoin] jonatack opened pull request #22138: script: fix spelling linter raising spuriously on "invokable" (master...fix-spurious-linter-spelling) https://github.com/bitcoin/bitcoin/pull/22138
142 2021-06-03T11:58:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
143 2021-06-03T12:10:15  *** AaronvanW <AaronvanW!~AaronvanW@207.200.214.109> has joined #bitcoin-core-dev
144 2021-06-03T12:12:29  *** kvaciral[m] <kvaciral[m]!~kvaciralx@2001:470:69fc:105::17b> has joined #bitcoin-core-dev
145 2021-06-03T12:13:21  *** thedragon <thedragon!~thedragon@user/thedragon> has joined #bitcoin-core-dev
146 2021-06-03T12:30:36  *** lightlike <lightlike!~lightlike@user/lightlike> has joined #bitcoin-core-dev
147 2021-06-03T12:37:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
148 2021-06-03T12:37:57  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a9435e34457e...d331e262f5b2
149 2021-06-03T12:37:57  <bitcoin-git> bitcoin/master 8050eb4 Jon Atack: script: fix spelling linter raising spuriously on "invokable"
150 2021-06-03T12:37:57  <bitcoin-git> bitcoin/master d331e26 MarcoFalke: Merge bitcoin/bitcoin#22138: script: fix spelling linter raising spuriousl...
151 2021-06-03T12:37:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
152 2021-06-03T12:38:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
153 2021-06-03T12:38:14  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22138: script: fix spelling linter raising spuriously on "invokable" (master...fix-spurious-linter-spelling) https://github.com/bitcoin/bitcoin/pull/22138
154 2021-06-03T12:38:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
155 2021-06-03T12:40:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
156 2021-06-03T12:40:46  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d331e262f5b2...6fe012c6bd6a
157 2021-06-03T12:40:46  <bitcoin-git> bitcoin/master ab86ac7 Hennadii Stepanov: build, qt: Make QWindowsVistaStylePlugin available again (regression)
158 2021-06-03T12:40:46  <bitcoin-git> bitcoin/master 6fe012c fanquake: Merge bitcoin/bitcoin#22133: build, qt: Make QWindowsVistaStylePlugin avai...
159 2021-06-03T12:40:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
160 2021-06-03T12:41:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
161 2021-06-03T12:41:03  <bitcoin-git> [bitcoin] fanquake merged pull request #22133: build, qt: Make QWindowsVistaStylePlugin available again (regression) (master...210602-style) https://github.com/bitcoin/bitcoin/pull/22133
162 2021-06-03T12:41:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
163 2021-06-03T12:42:18  *** AaronvanW <AaronvanW!~AaronvanW@207.200.214.109> has quit IRC (Remote host closed the connection)
164 2021-06-03T12:44:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
165 2021-06-03T12:44:58  <bitcoin-git> [bitcoin] fanquake opened pull request #22139: test: add type annotations to util.get_rpc_proxy (master...type_annotations_get_rpc_proxy) https://github.com/bitcoin/bitcoin/pull/22139
166 2021-06-03T12:45:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
167 2021-06-03T12:47:07  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
168 2021-06-03T12:58:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
169 2021-06-03T12:58:18  <bitcoin-git> [bitcoin] jonatack opened pull request #22140: p2p, refactor: remove unneeded CNetAddr::UnserializeV1Array() (master...p2p-remove-unused-UnserializeV1Array) https://github.com/bitcoin/bitcoin/pull/22140
170 2021-06-03T12:58:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
171 2021-06-03T13:02:26  *** thedragon <thedragon!~thedragon@user/thedragon> has quit IRC (Ping timeout: 272 seconds)
172 2021-06-03T13:05:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
173 2021-06-03T13:05:16  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6fe012c6bd6a...fcfd37f3f9dc
174 2021-06-03T13:05:16  <bitcoin-git> bitcoin/master 3b36395 João Barbosa: depends: Fix qt.mk for mac arm64
175 2021-06-03T13:05:16  <bitcoin-git> bitcoin/master fcfd37f fanquake: Merge bitcoin/bitcoin#22123: depends: Fix qt.mk for mac arm64
176 2021-06-03T13:05:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
177 2021-06-03T13:05:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
178 2021-06-03T13:05:33  <bitcoin-git> [bitcoin] fanquake merged pull request #22123: depends: Fix qt.mk for mac arm64 (master...2021-06-fix-aarch64_darwin) https://github.com/bitcoin/bitcoin/pull/22123
179 2021-06-03T13:05:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
180 2021-06-03T13:06:10  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
181 2021-06-03T13:08:08  * fanquake requests an embargo on future Qt PRs
182 2021-06-03T13:08:45  <hebasto> fanquake: accepted
183 2021-06-03T13:11:06  <promag> fanquake: you mean just on depends?
184 2021-06-03T13:11:53  <hebasto> promag: https://github.com/bitcoin/bitcoin/pull/21589#issuecomment-853847289
185 2021-06-03T13:12:11  <fanquake> promag: yes. Although I'm just being selfish, and trying to save myself rebase hassle
186 2021-06-03T13:12:31  *** thedragon <thedragon!~thedragon@user/thedragon> has joined #bitcoin-core-dev
187 2021-06-03T13:12:47  <fanquake> Will open a (mostly working) draft PR shortly that will explain
188 2021-06-03T13:14:03  <promag> ah kk
189 2021-06-03T13:14:15  <hebasto> fanquake: will it solve the problem  #20641 aims to solve?
190 2021-06-03T13:14:17  <gribble> https://github.com/bitcoin/bitcoin/issues/20641 | depends: Use Qt top-level build facilities by hebasto · Pull Request #20641 · bitcoin/bitcoin · GitHub
191 2021-06-03T13:15:05  <laanwj> right just on build system ones, not GUI changes in general
192 2021-06-03T13:15:31  <fanquake> It's not super clear to me what that PR is trying to achieve. Although I don't think these changes would make it any less possible
193 2021-06-03T13:15:45  <promag> since you are around, what you think about --disable-rpc? (or similar)
194 2021-06-03T13:15:46  <hebasto> fanquake: "integrate new modules into static builds"
195 2021-06-03T13:16:05  <fanquake> Sure, but what new modules do we need?
196 2021-06-03T13:16:06  <laanwj> because this is the right moment to merge last-minute GUI change PRs, before the translation freeze
197 2021-06-03T13:16:20  <hebasto> fanquake: QML, ofc
198 2021-06-03T13:17:03  <fanquake> That seems like a much larger discussion, which needs good motivation, and buy in from multiple devs, before we worry about hacking up the builds system to support it
199 2021-06-03T13:17:10  <laanwj> i don't see a point for --disable-rpc, why increase compile time complexity?
200 2021-06-03T13:17:29  <fanquake> I also have very little interest in rewriting our GUI in a new language.
201 2021-06-03T13:19:10  <laanwj> all the different compile-time combinatorial complexity makes it really hard to cover all possibilities, they all take work to maintain
202 2021-06-03T13:19:34  <promag> laanwj: be able to build without support for rpc - build for mobile for instance
203 2021-06-03T13:19:40  <laanwj> fanquake: it's not like you need to do that :)
204 2021-06-03T13:19:50  <hebasto> oh, it seems you missed the Project Horizon presentation :)
205 2021-06-03T13:19:55  <laanwj> promag: why wouldn't rpc be useful on mobile?
206 2021-06-03T13:20:02  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Quit: Leaving)
207 2021-06-03T13:20:33  <laanwj> it's not like the RPC code is large compared to anything else, if you're going the 'embeddes sytsems need to minimize code' angle
208 2021-06-03T13:20:36  <hebasto> QML seems the right way to lure designers into the GUI development
209 2021-06-03T13:20:42  <promag> laanwj: just a way to be on the safe side?
210 2021-06-03T13:20:48  <laanwj> the safe side of what?
211 2021-06-03T13:21:15  <laanwj> just run with server=0 if you don't want to open a RPC port
212 2021-06-03T13:21:46  <laanwj> even more, even the GUI needs most of the RPC code because of the debug console
213 2021-06-03T13:23:12  <promag> laanwj: ok, didn't think of that
214 2021-06-03T13:24:01  <hebasto> one of the QML use case right now is #16883
215 2021-06-03T13:24:04  <gribble> https://github.com/bitcoin/bitcoin/issues/16883 | WIP: Qt: add QML based mobile GUI by icota · Pull Request #16883 · bitcoin/bitcoin · GitHub
216 2021-06-03T13:24:35  <promag> laanwj: actually the RPC code seems to be already well split
217 2021-06-03T13:24:38  <laanwj> but i don't see why RPC would be a bad thing inherently on mobile, sure, access control works differently, but you might still want to give other applications access in some cases-or even use the cli through somethig like termux
218 2021-06-03T13:24:50  *** orionwl[m] <orionwl[m]!~orionwlx0@2001:470:69fc:105::80> has quit IRC (Quit: node-irc says goodbye)
219 2021-06-03T13:24:50  *** vincenzopalazzo <vincenzopalazzo!~vincenzop@2001:470:69fc:105::a67> has quit IRC (Quit: node-irc says goodbye)
220 2021-06-03T13:24:50  *** dongcarl[m] <dongcarl[m]!~dongcarlm@2001:470:69fc:105::82> has quit IRC (Quit: node-irc says goodbye)
221 2021-06-03T13:24:50  *** kvaciral[m] <kvaciral[m]!~kvaciralx@2001:470:69fc:105::17b> has quit IRC (Quit: node-irc says goodbye)
222 2021-06-03T13:25:46  *** orionwl[m] <orionwl[m]!~orionwlx0@2001:470:69fc:105::80> has joined #bitcoin-core-dev
223 2021-06-03T13:26:01  <promag> laanwj: we can build with --disable-wallet  think its reasonable to to have the
224 2021-06-03T13:26:09  <promag> same thing for rpc
225 2021-06-03T13:26:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
226 2021-06-03T13:26:09  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fcfd37f3f9dc...8837f1ebde05
227 2021-06-03T13:26:09  <bitcoin-git> bitcoin/master a58868d Hennadii Stepanov: build: Makes rcc output always deterministic
228 2021-06-03T13:26:09  <bitcoin-git> bitcoin/master 8837f1e fanquake: Merge bitcoin/bitcoin#21654: build, qt: Make Qt rcc output always determin...
229 2021-06-03T13:26:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
230 2021-06-03T13:26:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
231 2021-06-03T13:26:25  <bitcoin-git> [bitcoin] fanquake merged pull request #21654: build, qt: Make Qt rcc output always deterministic (master...210411-rcc) https://github.com/bitcoin/bitcoin/pull/21654
232 2021-06-03T13:26:26  <promag> but I agree it shouldn't add burden
233 2021-06-03T13:26:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
234 2021-06-03T13:26:42  <laanwj> i really don't like that but anyhow
235 2021-06-03T13:27:15  <promag> what? the option? or to maintain the option?
236 2021-06-03T13:27:20  <laanwj> both
237 2021-06-03T13:27:49  <promag> so just use runtime control
238 2021-06-03T13:27:55  <laanwj> i think both run-time and compile-time configurability of bitcoind is getting out of hand, and i see this specific change as a good example of something that isn't really needed
239 2021-06-03T13:27:57  <laanwj> yes
240 2021-06-03T13:28:20  *** vincenzopalazzo <vincenzopalazzo!~vincenzop@2001:470:69fc:105::a67> has joined #bitcoin-core-dev
241 2021-06-03T13:28:20  *** prusnak[m] <prusnak[m]!~stickmatr@2001:470:69fc:105::98c> has joined #bitcoin-core-dev
242 2021-06-03T13:28:23  <promag> i guess you also dont like --without-libevent
243 2021-06-03T13:28:25  <laanwj> we already disable RPC by default in bitcoin-qt iirc, and have always done so
244 2021-06-03T13:28:31  *** kvaciral[m] <kvaciral[m]!~kvaciralx@2001:470:69fc:105::17b> has joined #bitcoin-core-dev
245 2021-06-03T13:28:32  *** dongcarl[m] <dongcarl[m]!~dongcarlm@2001:470:69fc:105::82> has joined #bitcoin-core-dev
246 2021-06-03T13:28:32  *** mrjumper[m] <mrjumper[m]!~mr-jumper@2001:470:69fc:105::7f1> has joined #bitcoin-core-dev
247 2021-06-03T13:28:34  <laanwj> for fact, no, i don't
248 2021-06-03T13:29:10  <laanwj> but that's mostly because the original plan for libevent was to use it for P2P as well
249 2021-06-03T13:29:28  <promag> ok, I'll close the draft
250 2021-06-03T13:29:29  <laanwj> nothing happened with that so i feel less strongly about that now
251 2021-06-03T13:29:32  <promag> oh really?
252 2021-06-03T13:30:02  <promag> fanquake: who said rewrite gui?
253 2021-06-03T13:30:25  <laanwj> libevent's http server isn't *that* great, but also, no way we want to implement and maintain our own
254 2021-06-03T13:30:49  <fanquake> My assumption is that if people want a new language to write the gui in, which is what I  understand qml to be, we would be rewriting
255 2021-06-03T13:30:56  <fanquake> god forbid we end up with 2 guis
256 2021-06-03T13:31:37  *** ksprd2 <ksprd2!~ksprd@dfe52.neoplus.adsl.tpnet.pl> has joined #bitcoin-core-dev
257 2021-06-03T13:32:02  <hebasto> 2 guis seems awful
258 2021-06-03T13:32:31  <laanwj> it could make sense for a transitional phase but yea...
259 2021-06-03T13:32:50  <fanquake> 2 guis actually being 6 or 8, or maybe 10+ by the time you take into various platforms and runtime modes and etc etc
260 2021-06-03T13:33:14  <laanwj> i don't disagree with the point that qt widgets is basically dead, development-wise, and QML is (with regard to Qt) the future
261 2021-06-03T13:34:06  <fanquake> It's also unclear how easy a transition to qt 6 is going to be. Given they've seemingly thrown support for autotools /  pkg-config out the window
262 2021-06-03T13:34:25  <hebasto> the idea is to implement Bitcoin Design Guide ideas in new widgets with QML, making transition on widget/window base
263 2021-06-03T13:34:39  <fanquake> If we want to move to 5.15, we'll need to start maintaining x libs in depends, because at that version qt is no longer bundling them in tree
264 2021-06-03T13:35:11  <hebasto> is reverting back  pkg-config  support in Qt6 plans?
265 2021-06-03T13:35:32  <laanwj> wait, they removed pkg-config support? oh no... that's another boost level monstriosity
266 2021-06-03T13:35:55  <fanquake> https://bugreports.qt.io/browse/QTBUG-86080
267 2021-06-03T13:36:12  <fanquake> "Somewhat important", but doesn't seem to have any sort of priority
268 2021-06-03T13:36:17  <laanwj> it's so nice to be able to use pkg-config instead of manually scanning the system in the configure scripts (like we have to do for boost, often failing)
269 2021-06-03T13:37:27  <laanwj> well, let's stick with qt5 at least until that is fixed
270 2021-06-03T13:38:16  <laanwj> i wonder what they suggest autotools-based projects *do*, is cmake the only option now?
271 2021-06-03T13:38:16  <promag> regardless I'll be working on qml gui, fork is fine to me and lack of qml in depends isn't a blocker
272 2021-06-03T13:38:41  <laanwj> promag: qml + qt5 is fine with me
273 2021-06-03T13:38:47  <promag> laanwj: yup they went cmake
274 2021-06-03T13:38:58  <hebasto> qt 5.15 is, actually, qt 6.beta, so there could be less benefits to move to qt 5.15
275 2021-06-03T13:39:00  <promag> re qt6 I'm just waiting to 6.2
276 2021-06-03T13:40:07  <promag> qtquick controls still lacks lots of features compared to qt widgets
277 2021-06-03T13:40:27  <laanwj> there is no direct mapping, no
278 2021-06-03T13:40:29  <promag> treeview and tableviews suck
279 2021-06-03T13:41:02  <hebasto> promag: re "qml in depends isn't a blocker" -- compiling only with system packages?
280 2021-06-03T13:42:30  <promag> hebasto: yes - why do we want qml now in depends?
281 2021-06-03T13:42:32  <laanwj> fwiw i also maintained the qt based GUI as a fork for a fair while before it was merged upstream
282 2021-06-03T13:42:42  <promag> laanwj: exactly
283 2021-06-03T13:43:00  <laanwj> though we might want to limit changes to the interface for a while
284 2021-06-03T13:43:17  <hebasto> promag: to make standard guix releases
285 2021-06-03T13:43:23  <laanwj> so it's less of a rebase nightmare
286 2021-06-03T13:43:26  <promag> same thing ryanofsky is doing with multiprocess
287 2021-06-03T13:44:24  *** thedragon <thedragon!~thedragon@user/thedragon> has quit IRC (Quit: Leaving)
288 2021-06-03T13:44:37  <hebasto> promag: have you the QML fork already?
289 2021-06-03T13:44:37  <laanwj> (that was no option at the time because the GUI and core were joined at the hip, there's better separation now)
290 2021-06-03T13:44:54  <promag> hebasto: no :)
291 2021-06-03T13:46:23  <hebasto> laanwj: what are drawbacks if QML fork of the GUI will live under bitcoin-core?
292 2021-06-03T13:46:30  *** ksprd3 <ksprd3!~ksprd@dhd218.neoplus.adsl.tpnet.pl> has joined #bitcoin-core-dev
293 2021-06-03T13:48:39  *** ksprd2 <ksprd2!~ksprd@dfe52.neoplus.adsl.tpnet.pl> has quit IRC (Ping timeout: 244 seconds)
294 2021-06-03T13:48:56  <laanwj> hebasto: do you prefer a new repository or is a branch of the existing gui repository ok?
295 2021-06-03T13:50:37  <hebasto> a dedicated branch in the current GUI repo should be fine; promag what do you think?
296 2021-06-03T13:51:11  *** devrandom[m] <devrandom[m]!~devrandom@2001:470:69fc:105::d4d> has joined #bitcoin-core-dev
297 2021-06-03T13:52:19  <hebasto> won't it break the interaction between the GUI and the main repos?
298 2021-06-03T13:52:40  <laanwj> you would have to be more careful in that case with force-pushes and rebases
299 2021-06-03T13:52:59  *** devrandom[m] is now known as devrandom
300 2021-06-03T13:53:13  <laanwj> wouldn't want to overwrite the master branch accidentally
301 2021-06-03T13:53:25  <hebasto> right
302 2021-06-03T13:53:54  <laanwj> but no, in principle there is no reason why branches in the bitcoin-core/gui repo would interfere with anything in bitcoin/bitccoin
303 2021-06-03T13:54:25  <fanquake> Yes, please nothing that's is going to interfere with the actual repo, or generate any more commits then the GUI repo already does etc.
304 2021-06-03T13:54:41  <promag> only reason for another repo is to have different maintainers
305 2021-06-03T13:54:49  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
306 2021-06-03T13:56:04  <laanwj> better to create a new repo then maybe
307 2021-06-03T13:56:17  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
308 2021-06-03T13:56:27  <hebasto> ^ ok
309 2021-06-03T13:56:47  *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has joined #bitcoin-core-dev
310 2021-06-03T13:57:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
311 2021-06-03T13:57:59  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8837f1ebde05...907d636e5e76
312 2021-06-03T13:57:59  <bitcoin-git> bitcoin/master 985430d Russell Yanofsky: test: Add gui test for wallet receive requests
313 2021-06-03T13:57:59  <bitcoin-git> bitcoin/master 62252c9 Russell Yanofsky: interfaces: Stop exposing wallet destdata to gui
314 2021-06-03T13:57:59  <bitcoin-git> bitcoin/master f5ba424 Russell Yanofsky: wallet: Add IsAddressUsed / SetAddressUsed methods
315 2021-06-03T13:58:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
316 2021-06-03T13:58:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
317 2021-06-03T13:58:16  <bitcoin-git> [bitcoin] laanwj merged pull request #21353: interfaces: Stop exposing wallet destdata to gui (master...pr/nodestg) https://github.com/bitcoin/bitcoin/pull/21353
318 2021-06-03T13:58:16  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
319 2021-06-03T13:58:19  <laanwj> gah i can't even fork gui into a new project under bitcoin-core
320 2021-06-03T13:58:28  <fanquake> I'm happy for anyone to experiment, but certainly not at the expense of frequent code churn, notification noise, etc etc for the actual repo.
321 2021-06-03T13:58:40  <laanwj> *sigh* github
322 2021-06-03T13:58:42  <laanwj> fanquake: yes, agree
323 2021-06-03T13:58:46  <fanquake> Given recent dicussions / interactions on the GUI repo, I'm very happy that we've got it split out
324 2021-06-03T13:59:03  <laanwj> fanquake: same
325 2021-06-03T13:59:23  <laanwj> it just makes sense, the *kind* of discussion is very different
326 2021-06-03T14:02:55  <hebasto> laanwj: re "gah i can't even fork gui into a new project under bitcoin-core" -- could this be worked around?
327 2021-06-03T14:03:22  <laanwj> hebasto: yes, i think if you fork it, rename it, and then move the project to bitcoin-core you can work around it
328 2021-06-03T14:03:53  <promag> fanquake: +1 thats why I said fork originally
329 2021-06-03T14:05:40  <laanwj> alternatively i can fork it from bitcoin/bitcoin that might work buut it'd make less sense semantically, or maybe create a new repo without 'forked from' connection but that has other drawbacks, github is silly in that way
330 2021-06-03T14:08:14  <hebasto> I don't think github let me fork the repo that is already forked under the same username
331 2021-06-03T14:08:57  <laanwj> AHHH of couuurse you're right
332 2021-06-03T14:10:01  <laanwj> maybe i can fork it into an organization that doesn't have a fork of bitcoin yet and do the trick
333 2021-06-03T14:10:28  <hebasto> hope you will success
334 2021-06-03T14:11:47  <laanwj> "bitcoin-core already has a repository in the bitcoin-core/gui network" gah
335 2021-06-03T14:11:51  <laanwj> at least i trieeed
336 2021-06-03T14:13:10  <hebasto> laanwj: re "create a new repo without 'forked from' connection but that has other drawbacks" -- what drawbacks?
337 2021-06-03T14:13:35  <laanwj> you can't create a PR directly in that case
338 2021-06-03T14:14:01  <laanwj> nor can other people with a fork of the existing repo send you PRs
339 2021-06-03T14:14:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
340 2021-06-03T14:14:59  <bitcoin-git> [bitcoin] promag closed pull request #22136: Add --disable-rpc configure option (master...2021-06-disable-rpc) https://github.com/bitcoin/bitcoin/pull/22136
341 2021-06-03T14:14:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
342 2021-06-03T14:16:33  *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has quit IRC (Ping timeout: 244 seconds)
343 2021-06-03T14:18:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
344 2021-06-03T14:18:11  <bitcoin-git> [bitcoin] jnewbery opened pull request #22141: net processing: Remove hash and fValidatedHeaders from QueuedBlock (master...2021-06-blocks-in-flight) https://github.com/bitcoin/bitcoin/pull/22141
345 2021-06-03T14:18:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
346 2021-06-03T14:18:35  <hebasto> I think they are acceptable, wrt github restrictions
347 2021-06-03T14:20:11  <laanwj> fanquake: regarding qt dependencies we already have the 'problem' that the release binaries don't support wayland (#19950), due to our static linkage of qt (not that there's any good alternative)
348 2021-06-03T14:20:12  <gribble> https://github.com/bitcoin/bitcoin/issues/19950 | [Linux] Add wayland support · Issue #19950 · bitcoin/bitcoin · GitHub
349 2021-06-03T14:20:32  <laanwj> hebasto: ok, what would you like the repo to be called, gui-qml?
350 2021-06-03T14:20:47  <hebasto> lgtm
351 2021-06-03T14:25:46  <hebasto> laanwj: thanks!
352 2021-06-03T14:28:06  <laanwj> hebasto: it's set up, same permissions as for gui, let me know if you need anything else
353 2021-06-03T14:40:43  <promag> github ninja
354 2021-06-03T14:45:25  <laanwj> hehe
355 2021-06-03T14:45:48  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
356 2021-06-03T14:47:05  *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
357 2021-06-03T14:48:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
358 2021-06-03T14:48:51  <bitcoin-git> [bitcoin] fanquake opened pull request #22142: [WIP] build: split depends Qt into native and target builds (master...split_qt_again) https://github.com/bitcoin/bitcoin/pull/22142
359 2021-06-03T14:48:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
360 2021-06-03T15:02:38  *** GIANTWORLDKEEPER <GIANTWORLDKEEPER!~pjetcetal@2.95.204.25> has quit IRC (Read error: Connection reset by peer)
361 2021-06-03T15:05:21  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
362 2021-06-03T15:05:34  *** GIANTWORLDKEEPER <GIANTWORLDKEEPER!~pjetcetal@2.95.204.25> has joined #bitcoin-core-dev
363 2021-06-03T15:07:27  *** martinus <martinus!~martinus@046125249061.public.t-mobile.at> has joined #bitcoin-core-dev
364 2021-06-03T15:12:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
365 2021-06-03T15:12:27  <bitcoin-git> [bitcoin] laanwj closed pull request #21760: Add -flushwalletinterval command line arg (master...flushwalletinterval) https://github.com/bitcoin/bitcoin/pull/21760
366 2021-06-03T15:12:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
367 2021-06-03T15:19:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
368 2021-06-03T15:19:49  <bitcoin-git> [bitcoin] jonatack opened pull request #22143: p2p: pass spans in CNetAddr by reference to const (master...netaddress-pass-spans-by-reference-to-const) https://github.com/bitcoin/bitcoin/pull/22143
369 2021-06-03T15:19:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
370 2021-06-03T15:20:54  *** tripleslash <tripleslash!~triplesla@50.225.175.210> has quit IRC (Remote host closed the connection)
371 2021-06-03T15:21:13  *** tripleslash <tripleslash!~triplesla@50.225.175.210> has joined #bitcoin-core-dev
372 2021-06-03T15:21:51  *** tripleslash <tripleslash!~triplesla@user/tripleslash> has quit IRC (Remote host closed the connection)
373 2021-06-03T15:22:37  *** tripleslash <tripleslash!~triplesla@user/tripleslash> has joined #bitcoin-core-dev
374 2021-06-03T15:29:56  *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f03bc009e794642704b3134.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
375 2021-06-03T15:57:10  *** thedragon <thedragon!~thedragon@user/thedragon> has joined #bitcoin-core-dev
376 2021-06-03T16:03:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
377 2021-06-03T16:03:10  <bitcoin-git> [bitcoin] jonatack closed pull request #22143: p2p: pass spans in CNetAddr by reference to const (master...netaddress-pass-spans-by-reference-to-const) https://github.com/bitcoin/bitcoin/pull/22143
378 2021-06-03T16:03:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
379 2021-06-03T16:44:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
380 2021-06-03T16:44:42  <bitcoin-git> [bitcoin] laanwj pushed 14 commits to master: https://github.com/bitcoin/bitcoin/compare/907d636e5e76...07ededa30c94
381 2021-06-03T16:44:42  <bitcoin-git> bitcoin/master 0f1c58a Jon Atack: test: update feature_proxy to torv3
382 2021-06-03T16:44:42  <bitcoin-git> bitcoin/master f8e9400 Jon Atack: p2p: remove torv2/ADDR_TORV2_SIZE from SetTor()
383 2021-06-03T16:44:42  <bitcoin-git> bitcoin/master c56a1c9 Jon Atack: p2p: drop onions from IsAddrV1Compatible(), no longer relay torv2
384 2021-06-03T16:44:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
385 2021-06-03T16:44:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
386 2021-06-03T16:44:59  <bitcoin-git> [bitcoin] laanwj merged pull request #22050: p2p: remove tor v2 support (master...torv2-remove-support) https://github.com/bitcoin/bitcoin/pull/22050
387 2021-06-03T16:45:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
388 2021-06-03T16:46:50  <achow101> are we going to do 0.20.2rc2?
389 2021-06-03T16:47:27  <sipa> do we have tor v3 support in 0.20?
390 2021-06-03T16:47:37  <sipa> i forget if it was 0.20 or 0.21
391 2021-06-03T16:48:17  <achow101> I think that was 0.21
392 2021-06-03T16:48:19  <sipa> indeed,  0.21
393 2021-06-03T16:52:16  <sipa> that's kind of unfortunate if we want to do a new 0.20 release
394 2021-06-03T16:52:29  <achow101> is it hard to backport torv3?
395 2021-06-03T16:52:46  <sipa> it means backporting bip155
396 2021-06-03T16:52:51  <laanwj> not sure how big of a problem it is, people can still use tor, just not hidden services
397 2021-06-03T16:53:13  <sipa> that's fair, we can get away by putting it in the release notes
398 2021-06-03T16:53:16  <laanwj> i expect it would be an awful lot of work to backport
399 2021-06-03T16:53:33  <laanwj> p2p code changed a lot since
400 2021-06-03T16:53:58  <laanwj> for something that is going to see very little testing
401 2021-06-03T16:54:27  <sipa> good point, yes
402 2021-06-03T16:54:35  <sipa> it was half a dozen PRs probably
403 2021-06-03T16:55:09  <laanwj>  as for 0.20.2rc2, sure, let's do that
404 2021-06-03T16:56:37  <sipa> at least PRs 19360 19534 19841 19845 19628 20119 19954 20564 20661
405 2021-06-03T16:58:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
406 2021-06-03T16:58:02  <bitcoin-git> [bitcoin] laanwj pushed tag v0.20.2rc2: https://github.com/bitcoin/bitcoin/commit/5d2ebdd2b71f
407 2021-06-03T16:58:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
408 2021-06-03T16:58:16  <laanwj> ^^
409 2021-06-03T17:09:41  *** SenX <SenX!~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1> has joined #bitcoin-core-dev
410 2021-06-03T17:26:15  *** SenX <SenX!~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1> has quit IRC (Quit: My iMac has gone to sleep. ZZZzzz…)
411 2021-06-03T17:27:55  *** SenX <SenX!~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1> has joined #bitcoin-core-dev
412 2021-06-03T17:35:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
413 2021-06-03T17:35:06  <bitcoin-git> [bitcoin] sipa opened pull request #22144: Randomize message processing peer order (master...202106_rand_peers) https://github.com/bitcoin/bitcoin/pull/22144
414 2021-06-03T17:35:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
415 2021-06-03T17:37:13  *** Kiminuo <Kiminuo!~Kiminuo@70.151.broadband3.iol.cz> has joined #bitcoin-core-dev
416 2021-06-03T17:37:50  *** Kiminuo58 <Kiminuo58!~Kiminuo@141.98.103.92> has joined #bitcoin-core-dev
417 2021-06-03T17:41:42  *** Kiminuo <Kiminuo!~Kiminuo@70.151.broadband3.iol.cz> has quit IRC (Ping timeout: 264 seconds)
418 2021-06-03T17:47:29  *** upekkha is now known as metta
419 2021-06-03T18:06:03  *** martinus <martinus!~martinus@046125249061.public.t-mobile.at> has quit IRC (Remote host closed the connection)
420 2021-06-03T18:15:56  *** ksprd3 <ksprd3!~ksprd@dhd218.neoplus.adsl.tpnet.pl> has quit IRC (Ping timeout: 272 seconds)
421 2021-06-03T18:21:04  *** ksprd3 <ksprd3!~ksprd@dfq101.neoplus.adsl.tpnet.pl> has joined #bitcoin-core-dev
422 2021-06-03T18:26:04  *** ksprd3 <ksprd3!~ksprd@dfq101.neoplus.adsl.tpnet.pl> has quit IRC (Ping timeout: 272 seconds)
423 2021-06-03T18:27:53  <Kiminuo58> laanwj: Thank you for having a look at https://github.com/bitcoin/bitcoin/pull/21422. A silly question - why clang 13? It's not even released yet, is it?
424 2021-06-03T18:35:14  *** ksprd3 <ksprd3!~ksprd@public-gprs385937.centertel.pl> has joined #bitcoin-core-dev
425 2021-06-03T18:37:52  *** ksprd3 <ksprd3!~ksprd@public-gprs385937.centertel.pl> has quit IRC (Read error: Connection reset by peer)
426 2021-06-03T18:50:21  *** SenX <SenX!~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1> has quit IRC (Quit: My iMac has gone to sleep. ZZZzzz…)
427 2021-06-03T18:52:30  *** ksprd3 <ksprd3!~ksprd@public-gprs385937.centertel.pl> has joined #bitcoin-core-dev
428 2021-06-03T18:57:03  *** thedragon <thedragon!~thedragon@user/thedragon> has quit IRC (Quit: Leaving)
429 2021-06-03T19:02:03  <laanwj> #startmeeting
430 2021-06-03T19:02:03  <core-meetingbot> Meeting started Thu Jun  3 19:02:03 2021 UTC.  The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
431 2021-06-03T19:02:03  <core-meetingbot> Available commands: action commands idea info link nick
432 2021-06-03T19:02:08  <jonasschnelli> hi
433 2021-06-03T19:02:11  <hebasto> hi
434 2021-06-03T19:02:16  <kvaciral[m]> hi
435 2021-06-03T19:02:18  <michaelfolkson> hi
436 2021-06-03T19:02:36  <sipa> hi
437 2021-06-03T19:02:46  <laanwj> Kiminuo58: correct, one of my builds uses clang from git, I'm not sure the error happens with other versions I thought I'd note it because it completely blocks compilation
438 2021-06-03T19:03:04  <laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos
439 2021-06-03T19:03:06  <laanwj> nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
440 2021-06-03T19:03:12  <achow101> hi
441 2021-06-03T19:03:25  <jonatack> hi
442 2021-06-03T19:03:35  <darosior> hi
443 2021-06-03T19:03:41  <jarolrod> Hi
444 2021-06-03T19:03:51  <laanwj> two proposed meeting topics for today: Bitcoin Code Signing Association Switzerland (jonasschnelli), Reviewing progress of fortnightly Core subsystem (P2P, wallet, GUI etc) meetings (michaelfolkson)
445 2021-06-03T19:04:02  <laanwj> any last minute ideas for topics?
446 2021-06-03T19:04:35  <laanwj> #topic High priority for review
447 2021-06-03T19:04:35  <core-meetingbot> topic: High priority for review
448 2021-06-03T19:05:09  <laanwj> https://github.com/bitcoin/bitcoin/projects/8   currently has 11 blockers, 0 bugfixes, 0 chasing concept ACK
449 2021-06-03T19:05:16  <laanwj> anything to add/remove or that is ready for merge?
450 2021-06-03T19:05:36  <dongcarl> Would like to add #21866, where we say farewell to global chainman
451 2021-06-03T19:05:38  <gribble> https://github.com/bitcoin/bitcoin/issues/21866 | [Bundle 7/7] validation: Farewell, global Chainstate! by dongcarl · Pull Request #21866 · bitcoin/bitcoin · GitHub
452 2021-06-03T19:05:44  <achow101> #22051 has 4 acks
453 2021-06-03T19:05:46  <gribble> https://github.com/bitcoin/bitcoin/issues/22051 | Basic Taproot derivation support for descriptors by sipa · Pull Request #22051 · bitcoin/bitcoin · GitHub
454 2021-06-03T19:06:05  <laanwj> we are getting close to the point where we need to prioritize what we still want to make into 0.22
455 2021-06-03T19:06:23  <provoostenator> hi
456 2021-06-03T19:06:25  <jonatack> pushed a (close-to-final?) big update to #21261, hoping it can be tagged/merged for v0.22
457 2021-06-03T19:06:28  <gribble> https://github.com/bitcoin/bitcoin/issues/21261 | p2p: update inbound eviction protection for multiple networks, add I2P peers by jonatack · Pull Request #21261 · bitcoin/bitcoin · GitHub
458 2021-06-03T19:06:41  <laanwj> feature freeze is the 15th according to #20851
459 2021-06-03T19:06:42  <gribble> https://github.com/bitcoin/bitcoin/issues/20851 | Release schedule for 22.0 · Issue #20851 · bitcoin/bitcoin · GitHub
460 2021-06-03T19:06:49  <laanwj> which is in less than two weeks
461 2021-06-03T19:07:45  <jonatack> (been working on it behind the scenes these past weeks with helpful offline review feedback from vasild)
462 2021-06-03T19:08:34  <laanwj> achow101: yes, that one seems ready for merge
463 2021-06-03T19:08:45  <laanwj> dongcarl: added
464 2021-06-03T19:08:59  <laanwj> jonatack: tagged for 22.0
465 2021-06-03T19:09:16  <laanwj> anything else for high prio?
466 2021-06-03T19:10:11  <laanwj> #topic Bitcoin Code Signing Association Switzerland (jonasschnelli)
467 2021-06-03T19:10:11  <core-meetingbot> topic: Bitcoin Code Signing Association Switzerland (jonasschnelli)
468 2021-06-03T19:10:24  <jonasschnelli> The swiss association is now officially registered
469 2021-06-03T19:10:31  <laanwj> congrats!
470 2021-06-03T19:10:31  <jonasschnelli> Which means we can get code signing certificates again
471 2021-06-03T19:10:49  <laanwj> also for macosx?
472 2021-06-03T19:10:51  <jonasschnelli> It comes with some maintenance costs as we needed a domicile...
473 2021-06-03T19:11:08  <jonasschnelli> macOS should be no problem
474 2021-06-03T19:11:51  <jonasschnelli> (also the current macOS cert is still valid for a few months)
475 2021-06-03T19:12:10  <laanwj> i guess we could use the coredev funds for that
476 2021-06-03T19:12:17  <jonasschnelli> the question is, do we want to keep the swiss association or do we want to focus on the US LLC?
477 2021-06-03T19:12:26  <jonasschnelli> agree with the coredev funds
478 2021-06-03T19:12:39  <provoostenator> Maybe keep them both for a while?
479 2021-06-03T19:12:53  <jonasschnelli> Yes. That's also what I thought provoostenator
480 2021-06-03T19:12:53  <laanwj> yeah some redundancy couldn't hurt
481 2021-06-03T19:12:55  <achow101> I think it makes sense to keep both as a backup
482 2021-06-03T19:13:18  <jonasschnelli> okay... lets keep it and see when we might want to use it
483 2021-06-03T19:13:24  <provoostenator> Can we have certificates from both at the same time too? (but only use one)
484 2021-06-03T19:14:14  <achow101> I was also thinking we could alternate every year, so after say 9 months, try to get a cert using the other org. that would give us 3 months to work out any issues with getting a cert issued
485 2021-06-03T19:15:42  <laanwj> that sounds sensible to me
486 2021-06-03T19:16:52  <jonasschnelli> agree
487 2021-06-03T19:17:06  <laanwj> #topic Reviewing progress of fortnightly Core subsystem meetings (michaelfolkson)
488 2021-06-03T19:17:06  <core-meetingbot> topic: Reviewing progress of fortnightly Core subsystem meetings (michaelfolkson)
489 2021-06-03T19:17:42  <michaelfolkson> So with the Libera transition I thought it would be a good point to discuss how the subsystem meetings are going, how they could be improved etc
490 2021-06-03T19:18:14  <michaelfolkson> The P2P ones started with a really good format https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings
491 2021-06-03T19:18:26  <michaelfolkson> But they've kind of run out of steam in recent weeks
492 2021-06-03T19:18:50  <michaelfolkson> The wallet one appears to struggle with attendance a lot of the time (from what I've seen)
493 2021-06-03T19:18:59  *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has joined #bitcoin-core-dev
494 2021-06-03T19:19:18  <michaelfolkson> I like the idea of them, I personally would like to hear what people are working on but that's just me, sample size of 1
495 2021-06-03T19:19:51  <michaelfolkson> Perhaps 2 weeks is too regular, come round too often. Do you think attendance would be better if they were monthly?
496 2021-06-03T19:20:12  <michaelfolkson> I think there are GUI meetings on Jitsi or at least there were
497 2021-06-03T19:20:13  <provoostenator> I don't often show up for wallet meetings, but when I do, I find them useful.
498 2021-06-03T19:20:31  <laanwj> wouldn't this be better to discuss in those meetings themselves, with the people attending them?
499 2021-06-03T19:20:36  <provoostenator> (or at least quick)
500 2021-06-03T19:20:43  <achow101> I don't think having them more or less frequently would make that much of a difference
501 2021-06-03T19:20:52  <achow101> it isn't that much effort to have a short meeting with little discussion
502 2021-06-03T19:20:54  <michaelfolkson> laanwj: I guess but I thought it might be useful to compare notes
503 2021-06-03T19:21:04  <jonatack> provoostenator: achow101: agree
504 2021-06-03T19:21:09  <achow101> but it's still useful to have the meetings for when there are things to discuss
505 2021-06-03T19:21:24  <michaelfolkson> achow101: I think the expectation that not many will attend means that other people don't bother
506 2021-06-03T19:21:32  <provoostenator> I don't like the time of day, but timezones are just what they are: annoying.
507 2021-06-03T19:21:34  <jarolrod> The “GUI” meetings on jitsi are not really core dev related
508 2021-06-03T19:21:58  <jarolrod> I think it’s fair to say there are no GUI meetings
509 2021-06-03T19:22:02  <achow101> michaelfolkson: I don't think that's necessarily true
510 2021-06-03T19:22:15  <jonatack> the p2p ones are really late now for CET people, so e.g. vasild and i don't attend, but i get value from reading the meeting log the next day
511 2021-06-03T19:22:33  <michaelfolkson> But ok I'll bring up in the subsystem meetings and see how we can encourage attendance, participation
512 2021-06-03T19:22:54  <achow101> I think that frequently, it appears that few people are attending because no one speaks. but when there is actually something to discuss, there are many more people speaking than you may think
513 2021-06-03T19:22:58  <michaelfolkson> As I said the P2P ones started really strongly but have lost steam in recent weeks
514 2021-06-03T19:23:23  <achow101> I suspect many people just lurk with IRC open during the meetings
515 2021-06-03T19:23:25  <michaelfolkson> With P2P contributors were posting on the dev wiki what they were working on but I don't think many people are bothering anymore
516 2021-06-03T19:23:48  <michaelfolkson> I like the idea but you can't force people to do it
517 2021-06-03T19:23:49  *** Guest45 <Guest45!~Guest45@91.98.166.114> has joined #bitcoin-core-dev
518 2021-06-03T19:23:54  <laanwj> the libera migration was kind of brutal, maybe not everyone caught up yet
519 2021-06-03T19:24:10  <michaelfolkson> Indeed, this week appears quiet with Libera and Miami
520 2021-06-03T19:24:19  <michaelfolkson> But I think the trend started before then
521 2021-06-03T19:24:22  <laanwj> in any case it's going to fluctuate
522 2021-06-03T19:24:41  <michaelfolkson> Ok thanks, I will bring up in the individual subsystem meetings.
523 2021-06-03T19:24:50  *** Guest45 <Guest45!~Guest45@91.98.166.114> has quit IRC (Client Quit)
524 2021-06-03T19:24:51  <provoostenator> Even with low attendance the logs can be useful for later, so you can even just have a monologue :-)
525 2021-06-03T19:24:52  <jonatack> the wallet meetings are cool as-is IMO :)
526 2021-06-03T19:25:08  <michaelfolkson> Good to know the feedback, thanks
527 2021-06-03T19:25:15  <laanwj> anecdotally i don't think doing the meeting less often results in higher attendance, if anything it makes people forget about it more :)
528 2021-06-03T19:25:33  <jonatack> yup
529 2021-06-03T19:25:54  <michaelfolkson> Ok leaving as is seems the preference
530 2021-06-03T19:26:16  <laanwj> i think that concludes today's meeting
531 2021-06-03T19:26:30  <laanwj> thanks everyone who still made it :)
532 2021-06-03T19:26:31  <laanwj> #endmeeting
533 2021-06-03T19:26:32  <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
534 2021-06-03T19:26:32  <core-meetingbot> Meeting ended Thu Jun  3 19:26:31 2021 UTC.
535 2021-06-03T19:26:32  <core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-06-03-19.02.moin.txt
536 2021-06-03T19:27:01  <jonatack> o/ fare-thee-well, global chainstate
537 2021-06-03T19:27:14  <laanwj> it was a long journey
538 2021-06-03T19:29:32  *** smartin <smartin!~Icedove@88.135.18.171> has quit IRC (Quit: smartin)
539 2021-06-03T19:30:14  *** martinus <martinus!~martinus@046125249061.public.t-mobile.at> has joined #bitcoin-core-dev
540 2021-06-03T19:59:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
541 2021-06-03T19:59:31  <bitcoin-git> [bitcoin] laanwj pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/07ededa30c94...c7dd9ff71b9c
542 2021-06-03T19:59:31  <bitcoin-git> bitcoin/master 4b1cc08 Pieter Wuille: Make XOnlyPubKey act like byte container
543 2021-06-03T19:59:31  <bitcoin-git> bitcoin/master 31df02a Pieter Wuille: Change Solver() output for WITNESS_V1_TAPROOT
544 2021-06-03T19:59:31  <bitcoin-git> bitcoin/master 41839bd Pieter Wuille: Avoid dependence on CTxDestination index order
545 2021-06-03T19:59:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
546 2021-06-03T19:59:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
547 2021-06-03T19:59:48  <bitcoin-git> [bitcoin] laanwj merged pull request #22051: Basic Taproot derivation support for descriptors (master...202105_taproot_derive) https://github.com/bitcoin/bitcoin/pull/22051
548 2021-06-03T19:59:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
549 2021-06-03T20:09:35  <hebasto> laanwj: update-translations.py informs about multiple format specifiers mismatches; what is the best way to inform translators about that?
550 2021-06-03T20:19:23  <laanwj> hebasto: i don't know ... maybe a notification with a list in it of languages and messages affected
551 2021-06-03T20:20:14  <laanwj> alternatively, if they're straightforward we could fix them ourselves
552 2021-06-03T20:21:38  <hebasto> fix them ourselves on Transifex, right?
553 2021-06-03T20:21:42  <laanwj> yes
554 2021-06-03T20:21:56  <hebasto> ok, I'll try it
555 2021-06-03T20:22:50  <laanwj> often it's something trivial like 4% instead of %4
556 2021-06-03T20:23:03  <hebasto> you are right
557 2021-06-03T20:23:38  <hebasto> how do right-to-left systems work?
558 2021-06-03T20:27:56  *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has joined #bitcoin-core-dev
559 2021-06-03T20:30:28  <laanwj> string index 0 is rightmost, index len-1 is leftmost
560 2021-06-03T20:30:56  <luke-jr> pretty sure %4 still tho, not 4%
561 2021-06-03T20:31:12  <hebasto> luke-jr: thanks
562 2021-06-03T20:31:57  <sipa> well if your editor is LTR, i'd expect you'd see all strings in source code for RTL languages in reverse
563 2021-06-03T20:31:57  <laanwj> it will still be %4 when displayed from left-to-right
564 2021-06-03T20:31:59  <hebasto> most of mismatches are 4% for right-to-left systems
565 2021-06-03T20:32:38  <laanwj> e.g. the % must have an index below the 4
566 2021-06-03T20:32:39  <luke-jr> if you're looking at it RTL, it might look like 4% while being "4%" in byte order
567 2021-06-03T20:32:52  <luke-jr> err "%4" in byte order
568 2021-06-03T20:32:56  <laanwj> yes
569 2021-06-03T20:34:59  * luke-jr wonders if the fileformat change enabled us to have translations marked "incomplete" on Transifex?
570 2021-06-03T20:35:06  <laanwj> i guess theoretically the import script could automatically correct for this specific case when it knows (through some language db) whether it is right-to-left and left-to-right ... though it would be preferable if the translators simply learned to do it right
571 2021-06-03T20:35:33  <luke-jr> I have a script for filling in missing translations based on close matches, but ideally we'd still want a translator to look over and approve (or retranslate) them
572 2021-06-03T20:37:24  <hebasto> luke-jr: on transifex.com translation level for 22.x looks pretty high for active languages
573 2021-06-03T20:38:02  <hebasto> so file format had no effect on translation status
574 2021-06-03T20:38:37  <hebasto> but it dropped the "reviewed" status
575 2021-06-03T20:40:56  <hebasto> is there a way on transifex to see if a language is RTL or LTR?
576 2021-06-03T20:55:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
577 2021-06-03T20:55:30  <bitcoin-git> [gui] hebasto opened pull request #355: qt: Avoid ambiguous interpreting of placeholders (master...210603-placeholder) https://github.com/bitcoin-core/gui/pull/355
578 2021-06-03T20:55:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
579 2021-06-03T20:59:03  *** evias <evias!~evias__@user/evias> has quit IRC (Quit: This computer has gone to sleep)
580 2021-06-03T21:03:45  <luke-jr> hebasto: IIRC % in format strings need to be replaced by % or such, not sure if that applies to Qt
581 2021-06-03T21:21:37  *** evias <evias!~evias__@user/evias> has joined #bitcoin-core-dev
582 2021-06-03T21:41:44  <nanotube> btw, the website still seems to point to freenode irc (e.g., at the bottom here: https://bitcoincore.org/en/2021/05/01/release-0.21.1/ ). not sure if someone wants to update it to point to libera.
583 2021-06-03T21:55:07  *** Kiminuo58 <Kiminuo58!~Kiminuo@141.98.103.92> has quit IRC (Ping timeout: 272 seconds)
584 2021-06-03T22:01:03  <harding> nanotube: yeah, I think we decided here https://github.com/bitcoin-core/bitcoincore.org/pull/778#issue-651534929 not to change historical documents like release blogs.
585 2021-06-03T22:04:35  <nanotube> harding: ok sounds reasonable, just making sure it was not forgotten. :)
586 2021-06-03T22:10:42  <hebasto> laanwj: luke-jr: jonasschnelli: may I ask you to look into https://github.com/bitcoin-core/gui/issues/356?
587 2021-06-03T22:26:45  <luke-jr> looks straightforwardish. kinda surprised it isn't a standard check though
588 2021-06-03T22:29:09  *** AaronvanW <AaronvanW!~AaronvanW@74.212.158.196> has joined #bitcoin-core-dev
589 2021-06-03T22:41:07  *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
590 2021-06-03T22:43:12  <luke-jr> hebasto: enabled for XLIFF only as a warning for now
591 2021-06-03T22:43:48  <hebasto> luke-jr: thanks
592 2021-06-03T22:44:00  <luke-jr> hebasto: is there one I can look at to verify it worked?
593 2021-06-03T22:44:47  <hebasto> let me see...
594 2021-06-03T22:45:40  <luke-jr> looking at a random one, it looks like the placeholders appear like that %1% you thought was a problem
595 2021-06-03T22:46:24  <luke-jr> and now the %1% looks sane
596 2021-06-03T22:47:52  <hebasto> luke-jr: lang Malayalam, 22.x, id 120
597 2021-06-03T22:48:00  <hebasto> looks great
598 2021-06-03T22:48:50  <luke-jr> hmm, I don't see the warning on it when I view
599 2021-06-03T22:49:28  <hebasto> place holder is well-formed, but no warnings
600 2021-06-03T22:49:44  <hebasto> maybe raise level to "error"?
601 2021-06-03T22:50:09  <luke-jr> I removed the extra space on the end and saved, then the warning showed
602 2021-06-03T22:50:16  <luke-jr> so I guess it just didn't re-check existing stuff
603 2021-06-03T22:51:06  <hebasto> hmm, warning could be ignored
604 2021-06-03T22:51:19  <luke-jr> I assume that's the difference between error and warning
605 2021-06-03T22:51:44  <hebasto> even deleted -- https://docs.transifex.com/translation-checks/introduction-to-translation-checks#section-deleting-warnings
606 2021-06-03T22:52:09  <luke-jr> but hopefully translators aren't going to do that? :P
607 2021-06-03T22:52:23  <hebasto> what are drawbacks if level will be set to "error"?
608 2021-06-03T22:52:37  <luke-jr> I guess if I made a mistake it might be more annoying
609 2021-06-03T22:53:28  <hebasto> isn't not merging wrong translated string into the release more annoying?
610 2021-06-03T22:53:40  <luke-jr> we already have a check for that
611 2021-06-03T22:54:08  <hebasto> our check just ignore such strings without any feedback to translators
612 2021-06-03T22:54:12  <luke-jr> I don't feel strongly about whether it's error or warning
613 2021-06-03T22:54:19  <luke-jr> well, translators get preemptive feedback now ☺
614 2021-06-03T22:54:56  <hebasto> right, let see how it will be used by them
615 2021-06-03T22:58:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
616 2021-06-03T22:58:07  <bitcoin-git> [gui] hebasto closed pull request #355: qt: Avoid ambiguous interpreting of placeholders (master...210603-placeholder) https://github.com/bitcoin-core/gui/pull/355
617 2021-06-03T22:58:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
618 2021-06-03T23:02:40  *** SenX <SenX!~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1> has joined #bitcoin-core-dev
619 2021-06-03T23:07:14  *** AaronvanW <AaronvanW!~AaronvanW@74.212.158.196> has quit IRC (Remote host closed the connection)
620 2021-06-03T23:39:18  *** SenX <SenX!~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1> has quit IRC (Quit: My iMac has gone to sleep. ZZZzzz…)