12021-06-15T00:05:28  *** Guest21 <Guest21!~Guest21@176.100.15.46> has joined #bitcoin-core-dev
  22021-06-15T00:07:02  *** Guest21 <Guest21!~Guest21@176.100.15.46> has quit IRC (Client Quit)
  32021-06-15T00:46:43  *** l3kk0 <l3kk0!~l3kk0@c-73-22-213-40.hsd1.il.comcast.net> has joined #bitcoin-core-dev
  42021-06-15T01:14:17  <BlueMatt> Does the bitcoin core windows installer show you the software license?
  52021-06-15T01:15:20  <fanquake> iirc you should be able to see it in the installer somewhere
  62021-06-15T01:17:28  <BlueMatt> can you provide screenshots?
  72021-06-15T01:17:39  <BlueMatt> or, like, someone with a windowz box
  82021-06-15T01:18:30  <achow101> BlueMatt: like the MIT license somewhere?
  92021-06-15T01:18:36  <fanquake> hmm. Just ran through the installer in a VM, didn't see license mentioned anywhere
 102021-06-15T01:18:46  <BlueMatt> fanquake: thanks
 112021-06-15T01:18:49  <BlueMatt> achow101: yes
 122021-06-15T01:19:03  <fanquake> I does get "installed" somewhere though
 132021-06-15T01:19:24  <BlueMatt> yea
 142021-06-15T01:20:15  <fanquake> NSIS certainly has options for adding a license page, if that's something we should add
 152021-06-15T01:21:25  <achow101> the license gets put in C:\Program Files\Bitcoin\COPYING.txt
 162021-06-15T01:21:29  <achow101> but it isn't ever shown
 172021-06-15T01:21:54  <BlueMatt> thanks achow101
 182021-06-15T01:22:44  <achow101> the gui also has "Help" > "About Bitcoin Core" which has a link to the license on opensource.org
 192021-06-15T01:26:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 202021-06-15T01:26:31  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3f68f02db919...eb63b1db2c4d
 212021-06-15T01:26:31  <bitcoin-git> bitcoin/master aab7fd0 Aaron Clauson: Switch Appveyor CI to VS2019 stable image
 222021-06-15T01:26:31  <bitcoin-git> bitcoin/master eb63b1d fanquake: Merge bitcoin/bitcoin#22247: Switch Appveyor CI to VS2019 stable image
 232021-06-15T01:26:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 242021-06-15T01:26:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 252021-06-15T01:26:47  <bitcoin-git> [bitcoin] fanquake merged pull request #22247: Switch Appveyor CI to VS2019 stable image (master...appveyor-image-stable) https://github.com/bitcoin/bitcoin/pull/22247
 262021-06-15T01:26:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 272021-06-15T01:27:21  <sipa> achow101: does the loading screen show anything about copyright?
 282021-06-15T01:28:43  <achow101> the copyright line is there, but no mention of the license
 292021-06-15T01:45:09  *** Alina-malina <Alina-malina!~Alina-mal@user/alina-malina> has joined #bitcoin-core-dev
 302021-06-15T01:49:42  *** Alina-malina <Alina-malina!~Alina-mal@user/alina-malina> has quit IRC (Ping timeout: 272 seconds)
 312021-06-15T02:11:35  *** logarus <logarus!~logarus@110.140.4.230> has quit IRC (Ping timeout: 244 seconds)
 322021-06-15T02:11:36  *** logarus1 <logarus1!~logarus@2001:8004:1d60:82a0:fc19:6bd2:ed16:1c0d> has joined #bitcoin-core-dev
 332021-06-15T02:14:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 342021-06-15T02:14:16  <bitcoin-git> [bitcoin] fanquake closed pull request #22241: MacOS Monterey(12.0 beta) support confirmed (master...patch-1) https://github.com/bitcoin/bitcoin/pull/22241
 352021-06-15T02:14:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 362021-06-15T02:18:01  *** logarus2 <logarus2!~logarus@2001:8003:4d47:a500:fc19:6bd2:ed16:1c0d> has joined #bitcoin-core-dev
 372021-06-15T02:21:33  *** logarus1 <logarus1!~logarus@2001:8004:1d60:82a0:fc19:6bd2:ed16:1c0d> has quit IRC (Ping timeout: 256 seconds)
 382021-06-15T02:54:21  *** davterra <davterra!~davterra@178.128.106.205> has quit IRC (Quit: Leaving)
 392021-06-15T02:56:17  *** DeanWeen is now known as DeanGuss
 402021-06-15T03:14:28  *** Guest12 <Guest12!~Guest12@2601:647:4600:215b:69ea:fd86:b50c:6eea> has joined #bitcoin-core-dev
 412021-06-15T03:16:50  *** Guest12 <Guest12!~Guest12@2601:647:4600:215b:69ea:fd86:b50c:6eea> has quit IRC (Client Quit)
 422021-06-15T03:23:26  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-8815-2cb8-7761-b8f0.res6.spectrum.com> has quit IRC (Ping timeout: 272 seconds)
 432021-06-15T03:26:15  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-75b5-effb-8a85-a266.res6.spectrum.com> has joined #bitcoin-core-dev
 442021-06-15T03:40:58  *** cold <cold!~cold@user/cold> has quit IRC (Ping timeout: 244 seconds)
 452021-06-15T04:34:32  *** belcher_ <belcher_!~belcher@user/belcher> has joined #bitcoin-core-dev
 462021-06-15T04:37:47  *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 252 seconds)
 472021-06-15T05:40:59  *** smartin <smartin!~Icedove@88.135.18.171> has joined #bitcoin-core-dev
 482021-06-15T05:48:48  *** belcher_ <belcher_!~belcher@user/belcher> has quit IRC (Quit: Leaving)
 492021-06-15T05:51:42  *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has joined #bitcoin-core-dev
 502021-06-15T06:14:19  *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has joined #bitcoin-core-dev
 512021-06-15T06:41:52  *** martinus <martinus!~martinus@212095005140.public.telering.at> has joined #bitcoin-core-dev
 522021-06-15T06:50:24  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
 532021-06-15T06:55:39  *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has quit IRC (Ping timeout: 272 seconds)
 542021-06-15T06:56:24  *** b10c <b10c!uid500648@id-500648.charlton.irccloud.com> has joined #bitcoin-core-dev
 552021-06-15T07:08:33  <laanwj> NSIS has a possibility to add an EULA, and some projects use that to show the license, but always found it strange to show an open source license as one, you don't need to accept the license to use the software as it doesn't impose any instructions on use
 562021-06-15T07:08:54  <laanwj> instructions->limitations
 572021-06-15T07:09:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 582021-06-15T07:09:51  <bitcoin-git> [bitcoin] S3RK opened pull request #22249: test: kill process group to avoid dangling processes when using `--failfast` (master...test_kill_process_group) https://github.com/bitcoin/bitcoin/pull/22249
 592021-06-15T07:09:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 602021-06-15T07:20:42  *** jespada <jespada!~jespada@90.254.242.55> has quit IRC (Ping timeout: 264 seconds)
 612021-06-15T07:22:14  *** jespada <jespada!~jespada@90.254.242.55> has joined #bitcoin-core-dev
 622021-06-15T07:42:10  *** karliatto <karliatto!~karliatto@195.122.197.178> has joined #bitcoin-core-dev
 632021-06-15T07:50:31  <vasild> laanwj: open source licenses usually contain something like "the author is not liable for any damages due to the use of software"
 642021-06-15T07:52:33  <laanwj> yes
 652021-06-15T07:53:50  <laanwj> i'm not opposed to showing the license, but treating it as an EULA that you have to agree to before continuing is strange for a FOSS license
 662021-06-15T08:01:40  *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f03bc006aa596b89d3e737b.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
 672021-06-15T08:35:17  <instagibbs_> elichai2, ok well yes you're going to miss messages like that on block connect with such a low watermark
 682021-06-15T08:45:22  *** evias <evias!~evias__@196.red-88-6-131.staticip.rima-tde.net> has joined #bitcoin-core-dev
 692021-06-15T09:17:56  *** evias <evias!~evias__@user/evias> has quit IRC (Quit: This computer has gone to sleep)
 702021-06-15T09:30:10  <glozow> could I ask for a rerun of this CI job please? https://github.com/bitcoin/bitcoin/pull/21800/checks?check_run_id=2821522273
 712021-06-15T09:41:22  <laanwj> glozow: done
 722021-06-15T09:41:33  <glozow> laanwj: thank you! :)
 732021-06-15T09:45:41  *** evias <evias!~evias__@196.red-88-6-131.staticip.rima-tde.net> has joined #bitcoin-core-dev
 742021-06-15T10:37:54  *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has joined #bitcoin-core-dev
 752021-06-15T10:44:43  *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has quit IRC (Ping timeout: 264 seconds)
 762021-06-15T10:58:04  *** stevenroose <stevenroose!~steven@2001:19f0:6801:83a:5157:a229:22ca:bdf9> has quit IRC (Quit: ZNC 1.7.4 - https://znc.in)
 772021-06-15T10:58:19  *** stevenroose <stevenroose!~steven@2001:19f0:6801:83a:5b0:2160:99b2:6c0e> has joined #bitcoin-core-dev
 782021-06-15T11:09:14  *** cdecker <cdecker!~cdecker@243.86.254.84.ftth.as8758.net> has joined #bitcoin-core-dev
 792021-06-15T11:15:54  *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
 802021-06-15T11:29:41  <laanwj> we could use some more review for the taproot signing / descriptor support (#22166, #21365) would be nice to get into 22.0
 812021-06-15T11:29:42  <gribble> https://github.com/bitcoin/bitcoin/issues/22166 | Add support for inferring tr() descriptors by sipa · Pull Request #22166 · bitcoin/bitcoin · GitHub
 822021-06-15T11:29:44  <gribble> https://github.com/bitcoin/bitcoin/issues/21365 | Basic Taproot signing support for descriptor wallets by sipa · Pull Request #21365 · bitcoin/bitcoin · GitHub
 832021-06-15T11:50:56  *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has joined #bitcoin-core-dev
 842021-06-15T12:07:12  *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has quit IRC (Ping timeout: 272 seconds)
 852021-06-15T12:14:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 862021-06-15T12:14:36  <bitcoin-git> [bitcoin] vasild opened pull request #22250: doc: add basic I2P documentation (master...i2p_doc) https://github.com/bitcoin/bitcoin/pull/22250
 872021-06-15T12:14:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 882021-06-15T12:25:59  <vasild> fanquake: wrt https://github.com/bitcoin/bitcoin/pull/22250#issuecomment-861453715 maybe jonatack meant "can be merged _even_ after FF", i.e. can be merged before or after FF
 892021-06-15T12:41:49  *** l3kk0 <l3kk0!~l3kk0@c-73-22-213-40.hsd1.il.comcast.net> has quit IRC (Remote host closed the connection)
 902021-06-15T12:42:02  *** l3kk0 <l3kk0!~l3kk0@c-73-22-213-40.hsd1.il.comcast.net> has joined #bitcoin-core-dev
 912021-06-15T13:05:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 922021-06-15T13:05:51  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22251: [WIP] ci: Use cirrus isolation feature (master...2106-ciTest) https://github.com/bitcoin/bitcoin/pull/22251
 932021-06-15T13:05:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 942021-06-15T13:08:21  *** belcher <belcher!~belcher@user/belcher> has quit IRC (Remote host closed the connection)
 952021-06-15T13:08:39  <fanquake> vasild: I guess. Documentation can be merged / fixed any time.
 962021-06-15T13:10:57  *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
 972021-06-15T13:24:44  *** Nick3 <Nick3!~Nick3@mx2.inteco-constr.com> has joined #bitcoin-core-dev
 982021-06-15T13:25:47  *** niska <niska!~niska@static.38.6.217.95.clients.your-server.de> has quit IRC (Ping timeout: 252 seconds)
 992021-06-15T13:27:12  *** niska <niska!~niska@static.38.6.217.95.clients.your-server.de> has joined #bitcoin-core-dev
1002021-06-15T13:31:06  *** davterra <davterra!~davterra@178.128.106.205> has joined #bitcoin-core-dev
1012021-06-15T13:46:03  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 272 seconds)
1022021-06-15T13:53:28  *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has joined #bitcoin-core-dev
1032021-06-15T13:59:19  *** karliatto <karliatto!~karliatto@195.122.197.178> has quit IRC (Quit: Konversation terminated!)
1042021-06-15T13:59:21  *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has quit IRC (Ping timeout: 265 seconds)
1052021-06-15T14:10:40  <jonatack> fanquake: vasild: yes, that's what i was trying to say, in case the pull was opened today with urgent intention ;)
1062021-06-15T14:10:56  *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has quit IRC (Quit: Konversation terminated!)
1072021-06-15T14:20:34  *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has joined #bitcoin-core-dev
1082021-06-15T14:23:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1092021-06-15T14:23:23  <bitcoin-git> [bitcoin] glozow opened pull request #22252: policy: Trim Packages when transaction with same txid exists in mempool (master...2021-06-mempool-matches) https://github.com/bitcoin/bitcoin/pull/22252
1102021-06-15T14:23:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1112021-06-15T14:24:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1122021-06-15T14:24:42  <bitcoin-git> [bitcoin] glozow opened pull request #22253: [validation/mempool] distinguish between same tx and same nonwitness tx already in mempool (master...2021-06-same-txid-diff-wtxid) https://github.com/bitcoin/bitcoin/pull/22253
1132021-06-15T14:24:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1142021-06-15T14:25:44  *** sibilant_ <sibilant_!~sibilant@194.59.250.58> has joined #bitcoin-core-dev
1152021-06-15T14:27:03  *** b10c <b10c!uid500648@id-500648.charlton.irccloud.com> has quit IRC ()
1162021-06-15T14:27:14  *** b10c <b10c!uid500648@id-500648.charlton.irccloud.com> has joined #bitcoin-core-dev
1172021-06-15T14:28:42  *** sibilant <sibilant!~sibilant@user/sibilant> has quit IRC (Ping timeout: 268 seconds)
1182021-06-15T14:38:30  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1192021-06-15T14:41:25  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 252 seconds)
1202021-06-15T14:41:28  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
1212021-06-15T14:41:57  *** Nick3 <Nick3!~Nick3@mx2.inteco-constr.com> has quit IRC (Quit: Leaving)
1222021-06-15T14:44:36  *** [\\\] <[\\\]!~triplesla@user/tripleslash> has quit IRC (Read error: Connection reset by peer)
1232021-06-15T14:45:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1242021-06-15T14:45:07  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #22251: [WIP] ci: Use cirrus isolation feature (master...2106-ciTest) https://github.com/bitcoin/bitcoin/pull/22251
1252021-06-15T14:45:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1262021-06-15T14:46:10  *** tripleslash <tripleslash!~triplesla@user/tripleslash> has joined #bitcoin-core-dev
1272021-06-15T14:51:19  *** major1 <major1!~major@gateway/tor-sasl/major> has quit IRC (Ping timeout: 252 seconds)
1282021-06-15T14:52:26  *** major1 <major1!~major@gateway/tor-sasl/major> has joined #bitcoin-core-dev
1292021-06-15T15:03:06  *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has quit IRC (Ping timeout: 268 seconds)
1302021-06-15T15:11:14  *** sibilant__ <sibilant__!~sibilant@194.59.250.58> has joined #bitcoin-core-dev
1312021-06-15T15:15:04  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 265 seconds)
1322021-06-15T15:15:04  *** sibilant_ <sibilant_!~sibilant@user/sibilant> has quit IRC (Ping timeout: 265 seconds)
1332021-06-15T15:15:04  *** niska <niska!~niska@static.38.6.217.95.clients.your-server.de> has quit IRC (Quit: Leaving)
1342021-06-15T15:15:16  *** niska <niska!~niska@static.38.6.217.95.clients.your-server.de> has joined #bitcoin-core-dev
1352021-06-15T15:35:17  *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f03bc006aa596b89d3e737b.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
1362021-06-15T15:37:23  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Remote host closed the connection)
1372021-06-15T15:38:47  *** cdecker <cdecker!~cdecker@243.86.254.84.ftth.as8758.net> has quit IRC (Ping timeout: 272 seconds)
1382021-06-15T15:40:49  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 252 seconds)
1392021-06-15T15:48:32  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1402021-06-15T15:53:38  *** cdecker <cdecker!~cdecker@243.86.254.84.ftth.as8758.net> has joined #bitcoin-core-dev
1412021-06-15T16:08:03  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
1422021-06-15T16:10:07  *** reez <reez!~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net> has joined #bitcoin-core-dev
1432021-06-15T16:12:42  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 240 seconds)
1442021-06-15T16:15:44  *** reez <reez!~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
1452021-06-15T16:18:30  *** nanotube <nanotube!~nanotube@user/nanotube> has joined #bitcoin-core-dev
1462021-06-15T16:24:16  *** Guest142 <Guest142!~Guest14@177-86-157-80.netecom.net.br> has joined #bitcoin-core-dev
1472021-06-15T16:25:13  *** Guest142 <Guest142!~Guest14@177-86-157-80.netecom.net.br> has quit IRC (Client Quit)
1482021-06-15T16:25:24  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
1492021-06-15T16:29:38  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Read error: Connection reset by peer)
1502021-06-15T16:30:19  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
1512021-06-15T16:30:57  *** yanmaani1 is now known as yanmaani
1522021-06-15T16:35:28  *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has joined #bitcoin-core-dev
1532021-06-15T16:35:39  *** lightlike <lightlike!~lightlike@user/lightlike> has joined #bitcoin-core-dev
1542021-06-15T16:42:06  *** reez <reez!~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net> has joined #bitcoin-core-dev
1552021-06-15T16:44:01  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
1562021-06-15T16:44:09  *** reez <reez!~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net> has quit IRC (Client Quit)
1572021-06-15T16:49:43  *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has quit IRC (Ping timeout: 272 seconds)
1582021-06-15T16:55:40  *** dhruv <dhruv!~dhruv@165.227.49.220> has quit IRC (Remote host closed the connection)
1592021-06-15T16:57:34  *** dhruv <dhruv!~dhruv@165.227.49.220> has joined #bitcoin-core-dev
1602021-06-15T17:01:25  *** reez <reez!~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net> has joined #bitcoin-core-dev
1612021-06-15T17:02:42  <jnewbery_> Hi folks. As a reminder, we have a p2p meeting scheduled for today in around 4 hours time. If you have any topics that you'd like to discuss, feel free to add them to the wiki page here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings
1622021-06-15T17:06:39  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 244 seconds)
1632021-06-15T17:07:40  *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has joined #bitcoin-core-dev
1642021-06-15T17:11:27  <jnewbery_> As always, feel free to update your own priorities at https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities to let others know what you're working on
1652021-06-15T17:16:36  <sipa> has #21528 and #22245 be
1662021-06-15T17:16:38  <gribble> https://github.com/bitcoin/bitcoin/issues/21528 | [p2p] Reduce addr blackholes by amitiuttarwar · Pull Request #21528 · bitcoin/bitcoin · GitHub
1672021-06-15T17:16:39  <gribble> https://github.com/bitcoin/bitcoin/issues/22245 | [p2p] Stop sending SENDADDRV2 message to block-relay-only peers by amitiuttarwar · Pull Request #22245 · bitcoin/bitcoin · GitHub
1682021-06-15T17:16:42  <sipa> has #21528 and #22245 been brought up?
1692021-06-15T17:16:42  <gribble> https://github.com/bitcoin/bitcoin/issues/21528 | [p2p] Reduce addr blackholes by amitiuttarwar · Pull Request #21528 · bitcoin/bitcoin · GitHub
1702021-06-15T17:16:43  <gribble> https://github.com/bitcoin/bitcoin/issues/22245 | [p2p] Stop sending SENDADDRV2 message to block-relay-only peers by amitiuttarwar · Pull Request #22245 · bitcoin/bitcoin · GitHub
1712021-06-15T17:16:54  <sipa> sorry for double-gribbling
1722021-06-15T17:19:23  <amiti> hi sipa! I was going to give a quick update about 21528, but didn't put it as a meeting topic. do you wanna discuss? I'm happy to put them both on the agenda
1732021-06-15T17:20:43  <sipa> i saw some discussion with laanwj about bip155 changes, so maybe it's useful
1742021-06-15T17:20:59  <sipa> (i don't have much to add myself specifically)
1752021-06-15T17:21:06  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
1762021-06-15T17:22:29  <sipa> i'd like to see #22144 and #22147 in 22.0 too, if people want to discuss those
1772021-06-15T17:22:31  <gribble> https://github.com/bitcoin/bitcoin/issues/22144 | Randomize message processing peer order by sipa · Pull Request #22144 · bitcoin/bitcoin · GitHub
1782021-06-15T17:22:33  <gribble> https://github.com/bitcoin/bitcoin/issues/22147 | p2p: Protect last outbound HB compact block peer by sdaftuar · Pull Request #22147 · bitcoin/bitcoin · GitHub
1792021-06-15T17:23:01  *** reez <reez!~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
1802021-06-15T17:27:21  <ariard> i would be glad to log mines, but i don't have w/ access to this board since it has been moved :/
1812021-06-15T17:27:58  <ariard> another reminder, transaction relay workshop a hour and half from now on #l2-onchain-support (19:00 utc)
1822021-06-15T17:37:17  <amiti> sipa: ok! I'll add as a topic and we can discuss or it'll just be a quick update
1832021-06-15T17:41:20  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
1842021-06-15T17:42:48  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
1852021-06-15T17:45:29  *** orionwl[m] <orionwl[m]!~orionwlx0@2001:470:69fc:105::80> has quit IRC (Quit: Client limit exceeded: 10000)
1862021-06-15T17:48:34  *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has quit IRC (Ping timeout: 272 seconds)
1872021-06-15T17:56:16  *** CaptainLionBTC <CaptainLionBTC!~User@47.157.125.162> has joined #bitcoin-core-dev
1882021-06-15T18:18:01  *** prusnak[m] <prusnak[m]!~stickmatr@2001:470:69fc:105::98c> has quit IRC (Quit: Client limit exceeded: 10000)
1892021-06-15T18:19:27  *** gmaxwell <gmaxwell!~gmaxwell@user/gmaxwell> has joined #bitcoin-core-dev
1902021-06-15T18:20:45  *** gmaxwell <gmaxwell!~gmaxwell@user/gmaxwell> has left #bitcoin-core-dev
1912021-06-15T18:22:12  *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has joined #bitcoin-core-dev
1922021-06-15T18:28:56  *** Henry151 <Henry151!~bishop@user/henry151> has joined #bitcoin-core-dev
1932021-06-15T18:30:06  *** Henry151 <Henry151!~bishop@user/henry151> has quit IRC (Client Quit)
1942021-06-15T18:32:34  *** dongcarl[m] <dongcarl[m]!~dongcarlm@2001:470:69fc:105::82> has quit IRC (Quit: Client limit exceeded: 10000)
1952021-06-15T18:32:50  *** Henry151 <Henry151!~bishop@user/henry151> has joined #bitcoin-core-dev
1962021-06-15T18:45:05  *** swambo <swambo!~swambo@46.221.8.248> has joined #bitcoin-core-dev
1972021-06-15T18:50:51  *** gleb <gleb!~gleb@178.150.137.228> has joined #bitcoin-core-dev
1982021-06-15T18:51:32  *** prayank <prayank!~andr0irc@51.15.9.205> has joined #bitcoin-core-dev
1992021-06-15T18:56:15  *** cold <cold!~cold@user/cold> has joined #bitcoin-core-dev
2002021-06-15T18:56:48  *** devrandom <devrandom!~devrandom@2001:470:69fc:105::d4d> has quit IRC (Quit: Client limit exceeded: 10000)
2012021-06-15T18:57:28  *** swambo_ <swambo_!~swambo@176.237.239.28> has joined #bitcoin-core-dev
2022021-06-15T19:00:18  *** swambo <swambo!~swambo@46.221.8.248> has quit IRC (Ping timeout: 240 seconds)
2032021-06-15T19:01:19  *** kvaciral[m] <kvaciral[m]!~kvaciralx@2001:470:69fc:105::17b> has quit IRC (Quit: Client limit exceeded: 10000)
2042021-06-15T19:05:52  <provoostenator> Can of worms of the day...  #22254
2052021-06-15T19:05:52  *** orionwl[m] <orionwl[m]!~orionwlx0@2001:470:69fc:105::80> has joined #bitcoin-core-dev
2062021-06-15T19:05:53  <gribble> https://github.com/bitcoin/bitcoin/issues/22254 | Boost::ASIO (used by Boost::Process) uses (falsely?) deprecated std::allocator · Issue #22254 · bitcoin/bitcoin · GitHub
2072021-06-15T19:06:42  <provoostenator> When people start blaming compilers,  I start running.
2082021-06-15T19:06:43  *** dongcarl[m] <dongcarl[m]!~dongcarlm@2001:470:69fc:105::82> has joined #bitcoin-core-dev
2092021-06-15T19:07:06  *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has quit IRC (Ping timeout: 240 seconds)
2102021-06-15T19:07:29  *** takinbo <takinbo!~takinbo@2a01:4f8:160:60aa:fee::10> has joined #bitcoin-core-dev
2112021-06-15T19:07:50  *** kvaciral[m] <kvaciral[m]!~kvaciralx@2001:470:69fc:105::17b> has joined #bitcoin-core-dev
2122021-06-15T19:07:50  *** devrandom <devrandom!~devrandom@2001:470:69fc:105::d4d> has joined #bitcoin-core-dev
2132021-06-15T19:07:50  *** prusnak[m] <prusnak[m]!~stickmatr@2001:470:69fc:105::98c> has joined #bitcoin-core-dev
2142021-06-15T19:07:59  <achow101> What's the difference between --enable-fuzz and --enable-fuzz-binary?
2152021-06-15T19:08:30  <provoostenator> I think --enable-fuzz is what you need to actually fuzz, but then you don't get any of the other binaries.
2162021-06-15T19:08:52  <provoostenator> Whereas --enable-fuzz-binary just makes sure you didn't break anything? (it's slow though)
2172021-06-15T19:08:59  <achow101> but the fuzz binary built without enable-fuzz doesn't seem to work?
2182021-06-15T19:09:19  <provoostenator> (slow to build that is, I think it's not supposed to work)
2192021-06-15T19:09:52  <sipa> achow101: it works, it just doesn't fuzz
2202021-06-15T19:10:05  <sipa> you need to provide it an input on stdin
2212021-06-15T19:10:10  <achow101> oh
2222021-06-15T19:10:15  <sipa> rather than finding fuzzing inputs on its own
2232021-06-15T19:15:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2242021-06-15T19:15:01  <bitcoin-git> [bitcoin] luke-jr opened pull request #22255: [0.21] wallet: Do not iterate a directory if having an error while accessing it (0.21...listwalletdir_iterate_inf-0.19) https://github.com/bitcoin/bitcoin/pull/22255
2252021-06-15T19:15:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2262021-06-15T19:20:20  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
2272021-06-15T19:21:41  <achow101> provoostenator: interestingly, compiling 5c06af49efba407f062fdbf124b6d571fedd73fa from #21935 with --enable-fuzz --disable-external-signer works, but does not with only --disable-external-signer
2282021-06-15T19:21:45  <gribble> https://github.com/bitcoin/bitcoin/issues/21935 | Enable external signer support by default, reduce #ifdef by Sjors · Pull Request #21935 · bitcoin/bitcoin · GitHub
2292021-06-15T19:23:14  <achow101> oh, it disables the wallet with --enable-fuzz
2302021-06-15T19:26:14  *** mrjumper[m] <mrjumper[m]!~mr-jumper@2001:470:69fc:105::7f1> has quit IRC (Quit: Client limit exceeded: 10000)
2312021-06-15T19:51:12  *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
2322021-06-15T19:56:28  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
2332021-06-15T19:58:00  *** takinbo is now known as takinbo_
2342021-06-15T19:59:11  *** takinbo_ <takinbo_!~takinbo@user/takinbo> has quit IRC (Quit: takinbo_)
2352021-06-15T19:59:29  *** takinbo <takinbo!~takinbo@user/takinbo> has joined #bitcoin-core-dev
2362021-06-15T20:00:58  *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Ping timeout: 252 seconds)
2372021-06-15T20:01:54  *** swambo_ <swambo_!~swambo@176.237.239.28> has quit IRC (Ping timeout: 240 seconds)
2382021-06-15T20:08:18  *** Ara <Ara!~Ara@user/ara> has quit IRC (Quit: Leaving)
2392021-06-15T20:09:27  *** reez <reez!~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net> has joined #bitcoin-core-dev
2402021-06-15T20:12:27  *** CaptainLionBTC <CaptainLionBTC!~User@47.157.125.162> has quit IRC (Ping timeout: 244 seconds)
2412021-06-15T20:20:46  *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 252 seconds)
2422021-06-15T20:21:30  *** roconnor <roconnor!~roconnor@host-184-164-16-124.dyn.295.ca> has quit IRC (Remote host closed the connection)
2432021-06-15T20:21:32  *** Ara <Ara!~Ara@user/ara> has joined #bitcoin-core-dev
2442021-06-15T20:22:35  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
2452021-06-15T20:28:52  *** reez <reez!~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
2462021-06-15T20:31:41  *** Ara <Ara!~Ara@user/ara> has quit IRC (Quit: Leaving)
2472021-06-15T20:32:07  *** DougieBot5000 <DougieBot5000!~Ara@user/ara> has joined #bitcoin-core-dev
2482021-06-15T20:34:05  *** DougieBot5000 <DougieBot5000!~Ara@user/ara> has quit IRC (Client Quit)
2492021-06-15T20:37:50  *** prayank <prayank!~andr0irc@51.15.9.205> has quit IRC (Quit: irc thread exit)
2502021-06-15T20:41:09  *** Ara <Ara!~Ara@user/ara> has joined #bitcoin-core-dev
2512021-06-15T20:51:31  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 268 seconds)
2522021-06-15T20:54:55  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Read error: Connection reset by peer)
2532021-06-15T20:55:30  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
2542021-06-15T20:56:43  *** cdecker <cdecker!~cdecker@243.86.254.84.ftth.as8758.net> has quit IRC (Ping timeout: 264 seconds)
2552021-06-15T21:00:16  <jnewbery_> #startmeeting
2562021-06-15T21:00:17  <core-meetingbot> Meeting started Tue Jun 15 21:00:16 2021 UTC.  The chair is jnewbery_. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
2572021-06-15T21:00:17  <core-meetingbot> Available commands: action commands idea info link nick
2582021-06-15T21:00:17  *** mrjumper[m] <mrjumper[m]!~mr-jumper@2001:470:69fc:105::7f1> has joined #bitcoin-core-dev
2592021-06-15T21:00:23  <jnewbery_> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
2602021-06-15T21:00:29  <jnewbery_> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus
2612021-06-15T21:00:34  <amiti> hi
2622021-06-15T21:00:40  <ariard> yo
2632021-06-15T21:00:45  <lightlike> hi
2642021-06-15T21:00:58  <michaelfolkson> hi
2652021-06-15T21:01:07  <jnewbery_> Hi folks. We have two items on the agenda today: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#15-jun-2021
2662021-06-15T21:01:11  <gribble> https://github.com/bitcoin/bitcoin/issues/15 | Option to specify external IP address · Issue #15 · bitcoin/bitcoin · GitHub
2672021-06-15T21:01:12  <jnewbery_> Does anyone have any last minute topics to add?
2682021-06-15T21:02:11  <jnewbery_> ok, let's get started on the topics
2692021-06-15T21:02:24  <jnewbery_> #topic locking in net_processing
2702021-06-15T21:02:25  <core-meetingbot> topic: locking in net_processing
2712021-06-15T21:02:39  <_aj_> hi
2722021-06-15T21:03:16  <sipa> hi
2732021-06-15T21:03:23  <jnewbery_> #21527 is currently waiting for review. It adds a new lock to PeerMan, which I think later can be used to replace all the usage of cs_main in net_processing.
2742021-06-15T21:03:28  <gribble> https://github.com/bitcoin/bitcoin/issues/21527 | net_processing: lock clean up by ajtowns · Pull Request #21527 · bitcoin/bitcoin · GitHub
2752021-06-15T21:03:51  <jnewbery_> It'd unblock a lot of work to modularize net_processing and enforce clearer interfaces with validation and net
2762021-06-15T21:04:09  <glozow> hi
2772021-06-15T21:04:41  <jnewbery_> The PR is languishing a bit and had some pushback from vasild, but I think it's probably the right direction to take
2782021-06-15T21:06:01  <ariard> doesn't sound to big, i can have a look on it this week
2792021-06-15T21:06:19  <jnewbery_> Thanks ariard
2802021-06-15T21:06:41  *** swambo_ <swambo_!~swambo@176.237.239.28> has joined #bitcoin-core-dev
2812021-06-15T21:07:04  <amiti> I'm a concept / approach ACK on the pr. I intend to review it, hopefully soon
2822021-06-15T21:07:32  <michaelfolkson> Seems like vasild can give an ACK (with reservations) from his comments which might help it along too
2832021-06-15T21:08:31  <jnewbery_> ok, if there aren't any questions on the approach, then we can move on to the next topic
2842021-06-15T21:08:51  <jnewbery_> #topic Reduce addr blackholes
2852021-06-15T21:08:52  <core-meetingbot> topic: Reduce addr blackholes
2862021-06-15T21:08:56  <jnewbery_> (amiti)
2872021-06-15T21:09:34  <amiti> hi! I brought #21528 out of draft this week, and opened #22245 as a small change I'd like to see in v22
2882021-06-15T21:09:37  <gribble> https://github.com/bitcoin/bitcoin/issues/21528 | [p2p] Reduce addr blackholes by amitiuttarwar · Pull Request #21528 · bitcoin/bitcoin · GitHub
2892021-06-15T21:09:39  <gribble> https://github.com/bitcoin/bitcoin/issues/22245 | [p2p] Stop sending SENDADDRV2 message to block-relay-only peers by amitiuttarwar · Pull Request #22245 · bitcoin/bitcoin · GitHub
2902021-06-15T21:10:21  <amiti> the biggest concern about 21528 was around compatibility of other software on the network, and I looked at every client I could, opened issues confirming my understanding, posted on mailing list, mentioned it here multiple times... so I feel like its okay to move forward with these changes :)
2912021-06-15T21:10:52  <sipa> so the policy is going to be "if you ever send anything addr related, we assume you care about addresses"?
2922021-06-15T21:11:13  <amiti> yeah
2932021-06-15T21:11:25  <amiti> updated from "we assume you care about addresses regardless"
2942021-06-15T21:11:54  *** swambo_ <swambo_!~swambo@176.237.239.28> has quit IRC (Ping timeout: 240 seconds)
2952021-06-15T21:13:20  *** cdecker <cdecker!~cdecker@243.86.254.84.ftth.as8758.net> has joined #bitcoin-core-dev
2962021-06-15T21:13:47  <amiti> and then there was a question about BIP155 on #22245, I've posted my thoughts on the PR, but want to give anyone the chance to raise questions / any remaining concerns
2972021-06-15T21:13:48  <gribble> https://github.com/bitcoin/bitcoin/issues/22245 | [p2p] Stop sending SENDADDRV2 message to block-relay-only peers by amitiuttarwar · Pull Request #22245 · bitcoin/bitcoin · GitHub
2982021-06-15T21:14:58  <amiti> ok, if not, this is just an update then :)
2992021-06-15T21:15:05  <lightlike> #22245 would make sendaddrv2 kind of non-parallel with the other feature negotiation message wtxidrelay (which must be send regardless of whether we do tx relay)
3002021-06-15T21:15:06  <gribble> https://github.com/bitcoin/bitcoin/issues/22245 | [p2p] Stop sending SENDADDRV2 message to block-relay-only peers by amitiuttarwar · Pull Request #22245 · bitcoin/bitcoin · GitHub
3012021-06-15T21:15:09  <lightlike>  not sure if consistency something that is valuable at this spot though
3022021-06-15T21:16:00  <sipa> i don't think so
3032021-06-15T21:16:01  <amiti> lightlike: why must wtxidrelay be sent regardless of tx relay?
3042021-06-15T21:16:13  <sipa> if you don't care about addresses, sending sendaddrv2 is just irrelevant
3052021-06-15T21:16:33  <lightlike> "The wtxidrelay message MUST be sent in response to a version message from a peer whose protocol version is >= 70016 and prior to sending a verack" (BIP 339)
3062021-06-15T21:16:34  <sipa> so presumably, someone who doesn't care about addresses at all is not going to send it
3072021-06-15T21:16:39  <ariard> sounds more an oddity of bip339
3082021-06-15T21:16:44  <amiti> lightlike: ah, gotcha
3092021-06-15T21:17:01  <sipa> in order to implement BIP339 you must send wtxidrelay
3102021-06-15T21:17:06  <sipa> but you're free not to implement BIP339
3112021-06-15T21:18:00  <sipa> someone who doesn't care about addrv2 isn't going to implement BIP155, and thus isn't going to send sendaddrv2 either?
3122021-06-15T21:18:07  <jnewbery_> lightlike: that MUST means "you must send it if you want the peer to relay transactions using wtxid". I disagreed with using that language at the time because I thought it was confusing.
3132021-06-15T21:18:17  <sipa> (which also applies to anyone who doesn't care about addresses in the first place)
3142021-06-15T21:19:07  <lightlike> jnewbery_: ah, ok, then it is not an issue.
3152021-06-15T21:20:27  <michaelfolkson> What's the latest on #21061 amiti? Is the new approach finalized/agreed or is it still up in the air somewhat?
3162021-06-15T21:20:30  <gribble> https://github.com/bitcoin/bitcoin/issues/21061 | [p2p] Introduce node rebroadcast module by amitiuttarwar · Pull Request #21061 · bitcoin/bitcoin · GitHub
3172021-06-15T21:21:03  <michaelfolkson> I read the Suhas comments
3182021-06-15T21:21:03  <amiti> michaelfolkson: still working on it, I'll post an update on the PR when its more concrete
3192021-06-15T21:21:18  <michaelfolkson> Cool
3202021-06-15T21:21:23  <amiti> ok, I guess that concludes the Reduce addr blackholes topic
3212021-06-15T21:21:33  <jnewbery_> thanks amiti
3222021-06-15T21:21:43  <ariard> w.r.t to erlay, gleb should release the new version of the simulator this week
3232021-06-15T21:21:55  <ariard> and down to review more minisketch once i'm done with the current package-PRs
3242021-06-15T21:22:55  <jnewbery_> ariard: good to hear that it's still being worked on!
3252021-06-15T21:23:12  <jnewbery_> ok, any last updates before we end the meeting?
3262021-06-15T21:23:38  <jnewbery_> #endmeeting
3272021-06-15T21:23:39  <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
3282021-06-15T21:23:39  <core-meetingbot> Meeting ended Tue Jun 15 21:23:38 2021 UTC.
3292021-06-15T21:23:39  <core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-06-15-21.00.moin.txt
3302021-06-15T21:30:40  *** CaptainLion <CaptainLion!~User@47.157.125.162> has joined #bitcoin-core-dev
3312021-06-15T21:41:13  *** smartin <smartin!~Icedove@88.135.18.171> has quit IRC (Quit: smartin)
3322021-06-15T21:46:52  *** sibilant__ is now known as sibilant
3332021-06-15T21:47:45  *** prayank <prayank!~andr0irc@51.158.144.32> has joined #bitcoin-core-dev
3342021-06-15T21:47:56  *** haakon <haakon!~haakonn@82.196.8.209> has quit IRC (Ping timeout: 252 seconds)
3352021-06-15T21:48:04  *** haakon <haakon!~haakonn@82.196.8.209> has joined #bitcoin-core-dev
3362021-06-15T21:52:13  <prayank> Can we merge this? https://github.com/bitcoin/bitcoin/pull/21157 or if anyone has issues with the changes in PR feel free to comment
3372021-06-15T22:02:48  <achow101> are we pushing back feature freeze? there are still 15 open prs in the milestone
3382021-06-15T22:07:04  *** martinus_ <martinus_!~martinus@046125249003.public.t-mobile.at> has joined #bitcoin-core-dev
3392021-06-15T22:10:08  *** martinus <martinus!~martinus@212095005140.public.telering.at> has quit IRC (Ping timeout: 272 seconds)
3402021-06-15T22:25:43  *** sibilant_ <sibilant_!~sibilant@host-95-197-90-27.mobileonline.telia.com> has joined #bitcoin-core-dev
3412021-06-15T22:27:54  *** sibilant <sibilant!~sibilant@user/sibilant> has quit IRC (Ping timeout: 240 seconds)
3422021-06-15T22:41:06  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 240 seconds)
3432021-06-15T22:41:10  *** evias <evias!~evias__@user/evias> has quit IRC (Ping timeout: 272 seconds)
3442021-06-15T22:48:55  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
3452021-06-15T22:49:57  *** pigeons_ is now known as pigeons
3462021-06-15T22:51:11  *** TallTim_ is now known as TallTim
3472021-06-15T22:53:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3482021-06-15T22:53:21  <bitcoin-git> [bitcoin] theStack opened pull request #22257: test: refactor: use `{From,To}Hex` helpers for msg (de)serialization from/to hex (master...202106-test-refactor-replace_manual_deser_with_fromtohex) https://github.com/bitcoin/bitcoin/pull/22257
3492021-06-15T22:53:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3502021-06-15T23:05:00  *** roconnor <roconnor!~roconnor@host-184-164-16-124.dyn.295.ca> has joined #bitcoin-core-dev
3512021-06-15T23:17:48  *** ratelius <ratelius!ratelius@gateway/vpn/protonvpn/ratelius> has quit IRC (Ping timeout: 268 seconds)
3522021-06-15T23:18:28  *** promag_ <promag_!~promag@188.250.84.129> has joined #bitcoin-core-dev
3532021-06-15T23:18:28  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
3542021-06-15T23:21:06  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 240 seconds)
3552021-06-15T23:21:42  *** promag <promag!~promag@188.250.84.129> has quit IRC (Ping timeout: 272 seconds)
3562021-06-15T23:29:08  *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
3572021-06-15T23:29:44  *** prayank <prayank!~andr0irc@51.158.144.32> has quit IRC (Quit: irc thread exit)
3582021-06-15T23:30:37  *** lightlike <lightlike!~lightlike@user/lightlike> has quit IRC (Quit: Leaving)
3592021-06-15T23:32:32  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
3602021-06-15T23:37:58  *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has quit IRC (Quit: Leaving)
3612021-06-15T23:38:52  *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
3622021-06-15T23:42:51  *** jespada <jespada!~jespada@90.254.242.55> has quit IRC (Ping timeout: 272 seconds)
3632021-06-15T23:44:10  *** jespada <jespada!~jespada@90.254.247.46> has joined #bitcoin-core-dev