12021-06-19T00:06:40 *** belcher_ <belcher_!~belcher@user/belcher> has joined #bitcoin-core-dev
22021-06-19T00:07:55 *** zesty <zesty!uid446484@id-446484.charlton.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
32021-06-19T00:10:05 *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 252 seconds)
42021-06-19T00:27:14 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 268 seconds)
52021-06-19T00:37:38 *** gwillen <gwillen!gwillen@user/gwillen> has joined #bitcoin-core-dev
62021-06-19T00:40:05 *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has joined #bitcoin-core-dev
72021-06-19T00:43:31 *** gwillen <gwillen!gwillen@user/gwillen> has quit IRC (Quit: WeeChat 3.2)
82021-06-19T00:43:41 *** gwillen <gwillen!gwillen@2600:3c01::f03c:92ff:fe31:d7fb> has joined #bitcoin-core-dev
92021-06-19T00:45:18 *** gwillen <gwillen!gwillen@user/gwillen> has quit IRC (Client Quit)
102021-06-19T00:45:28 *** gwillen <gwillen!gwillen@user/gwillen> has joined #bitcoin-core-dev
112021-06-19T00:46:24 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
122021-06-19T00:50:31 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 252 seconds)
132021-06-19T00:56:07 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 268 seconds)
142021-06-19T00:58:03 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
152021-06-19T01:08:38 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
162021-06-19T01:09:07 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
172021-06-19T01:11:11 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
182021-06-19T01:11:32 *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has quit IRC (Ping timeout: 268 seconds)
192021-06-19T01:49:23 *** jtrag <jtrag!~jtrag@c-71-207-125-151.hsd1.pa.comcast.net> has quit IRC (Quit: <----- is PODAK (Passed out drunk at keyboard), and he has somehow managed to quit/disconnect...)
202021-06-19T02:52:37 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 252 seconds)
212021-06-19T03:04:57 *** zesty <zesty!uid446484@id-446484.charlton.irccloud.com> has joined #bitcoin-core-dev
222021-06-19T03:39:39 *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has quit IRC (Quit: aллилѹÑа!)
232021-06-19T03:46:34 *** Guest6974 <Guest6974!~Guest69@218.212.21.21> has joined #bitcoin-core-dev
242021-06-19T03:49:07 *** Guest6974 <Guest6974!~Guest69@218.212.21.21> has quit IRC (Client Quit)
252021-06-19T04:07:26 *** dvd <dvd!~dvd@nat-pool-rdu-t.redhat.com> has quit IRC (Quit: ZNC 1.7.5 - https://znc.in)
262021-06-19T04:07:43 *** dvd <dvd!~dvd@nat-pool-rdu-t.redhat.com> has joined #bitcoin-core-dev
272021-06-19T04:08:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
282021-06-19T04:08:28 <bitcoin-git> [bitcoin] hebasto opened pull request #22281: build: Avoid @GLIBC_2.29 libm symbols when --enable-glibc-back-compat (master...210619-lm) https://github.com/bitcoin/bitcoin/pull/22281
292021-06-19T04:08:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
302021-06-19T04:40:58 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
312021-06-19T04:41:22 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
322021-06-19T05:47:25 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
332021-06-19T05:49:47 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has quit IRC (Remote host closed the connection)
342021-06-19T05:51:21 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has joined #bitcoin-core-dev
352021-06-19T05:51:21 *** ChanServ sets mode: +o gribble
362021-06-19T06:05:29 *** morcos <morcos!~morcos@gateway/tor-sasl/morcos> has quit IRC (Remote host closed the connection)
372021-06-19T06:06:13 *** morcos <morcos!~morcos@gateway/tor-sasl/morcos> has joined #bitcoin-core-dev
382021-06-19T06:13:48 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has quit IRC (Remote host closed the connection)
392021-06-19T06:14:14 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has joined #bitcoin-core-dev
402021-06-19T06:25:44 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has quit IRC (Remote host closed the connection)
412021-06-19T06:30:04 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has joined #bitcoin-core-dev
422021-06-19T06:30:04 *** ChanServ sets mode: +o gribble
432021-06-19T06:47:34 *** morcos <morcos!~morcos@gateway/tor-sasl/morcos> has quit IRC (Remote host closed the connection)
442021-06-19T06:47:49 *** morcos <morcos!~morcos@gateway/tor-sasl/morcos> has joined #bitcoin-core-dev
452021-06-19T06:50:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
462021-06-19T06:50:37 <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/0f47e01d7d49...e172ea880498
472021-06-19T06:50:37 <bitcoin-git> bitcoin/master faff3f3 MarcoFalke: test: Add txin.sequence option to MiniWallet
482021-06-19T06:50:37 <bitcoin-git> bitcoin/master fab871f MarcoFalke: test: Remove unused generate() from test
492021-06-19T06:50:37 <bitcoin-git> bitcoin/master fab7e99 MarcoFalke: test: Use MiniWallet in test_no_inherited_signaling RBF test
502021-06-19T06:50:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
512021-06-19T06:50:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
522021-06-19T06:50:54 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22210: test: Use MiniWallet in test_no_inherited_signaling RBF test (master...2106-testMiniWallet) https://github.com/bitcoin/bitcoin/pull/22210
532021-06-19T06:50:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
542021-06-19T07:40:49 *** major1 <major1!~major@gateway/tor-sasl/major> has quit IRC (Ping timeout: 252 seconds)
552021-06-19T07:42:18 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
562021-06-19T07:42:19 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e172ea880498...965e93743454
572021-06-19T07:42:19 <bitcoin-git> bitcoin/master 906d791 Andrew Poelstra: fuzz: add missing ECCVerifyHandle to base_encode_decode
582021-06-19T07:42:19 <bitcoin-git> bitcoin/master 965e937 MarcoFalke: Merge bitcoin/bitcoin#22279: fuzz: add missing ECCVerifyHandle to base_enc...
592021-06-19T07:42:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
602021-06-19T07:42:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
612021-06-19T07:42:35 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22279: fuzz: add missing ECCVerifyHandle to base_encode_decode (master...2021-06--fuzztestix) https://github.com/bitcoin/bitcoin/pull/22279
622021-06-19T07:42:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
632021-06-19T07:42:42 *** major1 <major1!~major@gateway/tor-sasl/major> has joined #bitcoin-core-dev
642021-06-19T07:49:40 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
652021-06-19T07:50:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
662021-06-19T07:50:39 <bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/419f9b3b3b7c...926f76cb205c
672021-06-19T07:50:39 <bitcoin-git> bitcoin/0.21 65ce833 Andrew Chow: gitian: install signapple in gitian-osx-signer.yml
682021-06-19T07:50:39 <bitcoin-git> bitcoin/0.21 2f33e33 Andrew Chow: gitian: use signapple to apply the MacOS code signature
692021-06-19T07:50:39 <bitcoin-git> bitcoin/0.21 27d691b Andrew Chow: gitian: use signapple to create the MacOS code signature
702021-06-19T07:50:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
712021-06-19T07:50:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
722021-06-19T07:50:57 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22191: [0.21] gitian: Use custom MacOS code signing tool (0.21...0.21-signapple) https://github.com/bitcoin/bitcoin/pull/22191
732021-06-19T07:50:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
742021-06-19T07:54:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
752021-06-19T07:54:20 <bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/5d2ebdd2b71f...466acb3fbcf5
762021-06-19T07:54:20 <bitcoin-git> bitcoin/0.20 a2650f6 Andrew Chow: gitian: install signapple in gitian-osx-signer.yml
772021-06-19T07:54:20 <bitcoin-git> bitcoin/0.20 f834485 Andrew Chow: gitian: use signapple to apply the MacOS code signature
782021-06-19T07:54:20 <bitcoin-git> bitcoin/0.20 9c7c0e6 Andrew Chow: gitian: use signapple to create the MacOS code signature
792021-06-19T07:54:22 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
802021-06-19T07:54:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
812021-06-19T07:54:38 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22192: [0.20] gitian: Use custom MacOS code signing tool (0.20...0.20-signapple) https://github.com/bitcoin/bitcoin/pull/22192
822021-06-19T07:54:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
832021-06-19T08:02:07 *** belcher_ is now known as belcher
842021-06-19T08:54:48 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
852021-06-19T09:02:46 *** kexkey <kexkey!~kexkey@static-198-54-132-126.cust.tzulo.com> has joined #bitcoin-core-dev
862021-06-19T09:04:31 *** kexkey_ <kexkey_!~kexkey@static-198-54-132-110.cust.tzulo.com> has quit IRC (Ping timeout: 268 seconds)
872021-06-19T09:06:04 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
882021-06-19T09:13:36 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
892021-06-19T09:13:36 <bitcoin-git> [bitcoin] klementtan opened pull request #22282: refactor: CheckFinalTx pass by reference instead of ptr (master...CheckFinalTx_ptr_to_ref) https://github.com/bitcoin/bitcoin/pull/22282
902021-06-19T09:13:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
912021-06-19T09:32:12 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Remote host closed the connection)
922021-06-19T09:48:45 *** emcy <emcy!~emcy@user/emcy> has quit IRC (Quit: Leaving)
932021-06-19T09:55:30 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 264 seconds)
942021-06-19T10:00:09 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
952021-06-19T10:01:24 *** emcy <emcy!~emcy@user/emcy> has joined #bitcoin-core-dev
962021-06-19T10:02:56 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
972021-06-19T10:17:54 *** ratelius <ratelius!ratelius@gateway/vpn/protonvpn/ratelius> has quit IRC (Ping timeout: 268 seconds)
982021-06-19T10:19:04 *** ratelius <ratelius!ratelius@gateway/vpn/protonvpn/ratelius> has joined #bitcoin-core-dev
992021-06-19T10:37:58 *** major1 <major1!~major@gateway/tor-sasl/major> has quit IRC (Quit: Bye)
1002021-06-19T10:46:59 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 272 seconds)
1012021-06-19T10:47:15 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
1022021-06-19T10:58:04 *** brcolow <brcolow!~brcolow@ip68-0-136-132.tc.ph.cox.net> has quit IRC ()
1032021-06-19T11:17:23 *** chrysanthematic <chrysanthematic!~chrysanth@user/chrysanthematic> has joined #bitcoin-core-dev
1042021-06-19T11:21:54 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 264 seconds)
1052021-06-19T11:29:03 *** vnogueir- <vnogueir-!~vnogueira@user/vnogueira> has joined #bitcoin-core-dev
1062021-06-19T11:29:37 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has quit IRC (Ping timeout: 252 seconds)
1072021-06-19T11:37:48 <glozow> ariard: thanks, I'll take a look.
1082021-06-19T11:43:53 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
1092021-06-19T11:44:04 *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has joined #bitcoin-core-dev
1102021-06-19T11:47:51 *** goatpig <goatpig!~goat@h-94-254-2-155.A498.priv.bahnhof.se> has quit IRC (Quit: Konversation terminated!)
1112021-06-19T11:55:51 *** Guest31 <Guest31!~Guest31@43.224.1.253> has joined #bitcoin-core-dev
1122021-06-19T12:18:42 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 265 seconds)
1132021-06-19T12:24:56 *** klement <klement!~klement@218.212.21.21> has joined #bitcoin-core-dev
1142021-06-19T12:38:33 *** evias <evias!~evias__@196.red-88-6-131.staticip.rima-tde.net> has joined #bitcoin-core-dev
1152021-06-19T13:00:52 *** chrysanthematic <chrysanthematic!~chrysanth@user/chrysanthematic> has quit IRC (Quit: chrysanthematic)
1162021-06-19T13:18:54 *** Guest31 <Guest31!~Guest31@43.224.1.253> has quit IRC (Quit: Client closed)
1172021-06-19T13:20:21 *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has joined #bitcoin-core-dev
1182021-06-19T13:35:59 *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has quit IRC (Ping timeout: 258 seconds)
1192021-06-19T13:47:41 *** Guest62 <Guest62!~Guest62@182.69.199.37> has joined #bitcoin-core-dev
1202021-06-19T14:30:20 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1212021-06-19T14:40:59 *** evias <evias!~evias__@user/evias> has quit IRC (Quit: This computer has gone to sleep)
1222021-06-19T14:41:47 *** l3kk0 <l3kk0!~l3kk0@c-73-22-213-40.hsd1.il.comcast.net> has quit IRC (Ping timeout: 244 seconds)
1232021-06-19T14:42:00 *** l3kk0 <l3kk0!~l3kk0@107.117.175.33> has joined #bitcoin-core-dev
1242021-06-19T14:56:24 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
1252021-06-19T15:23:16 *** Guest62 <Guest62!~Guest62@182.69.199.37> has quit IRC (Ping timeout: 246 seconds)
1262021-06-19T15:51:41 *** cryptapus <cryptapus!~cryptapus@user/cryptapus> has quit IRC (Ping timeout: 252 seconds)
1272021-06-19T15:55:02 *** zesty <zesty!uid446484@id-446484.charlton.irccloud.com> has quit IRC ()
1282021-06-19T16:08:39 *** cryptapus <cryptapus!~cryptapus@user/cryptapus> has joined #bitcoin-core-dev
1292021-06-19T16:19:16 *** chrysanthematic <chrysanthematic!~chrysanth@user/chrysanthematic> has joined #bitcoin-core-dev
1302021-06-19T16:19:57 *** chrysanthematic <chrysanthematic!~chrysanth@user/chrysanthematic> has quit IRC (Client Quit)
1312021-06-19T16:24:12 *** chrysanthematic <chrysanthematic!~chrysanth@user/chrysanthematic> has joined #bitcoin-core-dev
1322021-06-19T16:25:28 *** reez <reez!~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net> has joined #bitcoin-core-dev
1332021-06-19T16:38:02 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1342021-06-19T16:38:02 <bitcoin-git> [bitcoin] dgoncharov opened pull request #22283: build: Replace $(AT) with .SILENCE. (master...replace_AT_with_dotsilence) https://github.com/bitcoin/bitcoin/pull/22283
1352021-06-19T16:38:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1362021-06-19T16:41:45 *** mekster <mekster!~mekster@user/mekster> has quit IRC (Quit: Ping timeout (120 seconds))
1372021-06-19T16:42:03 *** mekster <mekster!~mekster@user/mekster> has joined #bitcoin-core-dev
1382021-06-19T16:59:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1392021-06-19T16:59:44 <bitcoin-git> [bitcoin] jonatack opened pull request #22284: p2p, refactor: performance improvements to ProtectEvictionCandidatesByRatio() (master...ProtectEvictionCandidatesByRatio-perf-enhancements) https://github.com/bitcoin/bitcoin/pull/22284
1402021-06-19T16:59:45 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1412021-06-19T17:08:23 *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has joined #bitcoin-core-dev
1422021-06-19T17:41:01 *** chrysanthematic <chrysanthematic!~chrysanth@user/chrysanthematic> has quit IRC (Quit: chrysanthematic)
1432021-06-19T17:56:22 *** emcy <emcy!~emcy@user/emcy> has quit IRC (Remote host closed the connection)
1442021-06-19T17:56:50 *** kittywhiskers <kittywhiskers!~kittywhis@43.242.227.145> has joined #bitcoin-core-dev
1452021-06-19T18:01:18 *** copumpkin <copumpkin!~woohoo@user/copumpkin> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1462021-06-19T18:15:03 *** emcy <emcy!~emcy@user/emcy> has joined #bitcoin-core-dev
1472021-06-19T18:15:55 *** reez <reez!~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1482021-06-19T18:17:47 <kittywhiskers> noticed the addition of crc32c to the subtree, been a bit since i've seen recent developments
1492021-06-19T18:19:38 <kittywhiskers> how is a library decided to be committed to the source tree or added as depends pkg?
1502021-06-19T18:20:43 <kittywhiskers> i get why submodules are not ideal, github doesn't generate source archives with submodule trees but i'm still curious as to how those decisions are made
1512021-06-19T18:20:56 <sipa> we use git subtrees
1522021-06-19T18:22:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1532021-06-19T18:22:34 <bitcoin-git> [bitcoin] whitslack opened pull request #22285: contrib/init: (OpenRC) use -startupnotify to wait for startup completion (master...openrc-startupnotify) https://github.com/bitcoin/bitcoin/pull/22285
1542021-06-19T18:22:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1552021-06-19T18:22:43 <kittywhiskers> never heard of it till now, a light reading shows that it creates a bit of overhead but that makes sense for a project like core
1562021-06-19T18:23:05 <sipa> and the decision to use a subtree vs external dependency depends on (a) how tightly consensus code needs it (we don't want consensus-relevant things to just pick whatever version is available on your system and (b) how readily available it is as a package
1572021-06-19T18:23:42 <sipa> crc32 is a dependency of leveldb, en leveldb is used for the UTXO set, so we want control over the version used
1582021-06-19T18:24:26 <sipa> libqrencode for example is just used by the GUI, and easily available
1592021-06-19T18:24:41 <sipa> so that isn't a subtree
1602021-06-19T18:25:53 <kittywhiskers> makes sense then, just figured that maybe core could fork the repo, issue a core-specific release and link the URL to that archive as a depends pkg
1612021-06-19T18:26:29 <kittywhiskers> best of both worlds, i'm asking as i'm interested in implementing cmake secp support
1622021-06-19T18:26:47 <kittywhiskers> just dipping my toes in the pond to see if that's welcome
1632021-06-19T18:27:02 <sipa> we do have our fork of leveldb; https://github.com/bitcoin-core/leveldb
1642021-06-19T18:27:11 <sipa> that's what's being subtreed
1652021-06-19T18:27:37 <kittywhiskers> i thought that repo was abandoned for some reason, huh
1662021-06-19T18:27:57 <sipa> hmm, maybe we use upstream now
1672021-06-19T18:28:05 <sipa> i'm not entirely sure!
1682021-06-19T18:28:26 <kittywhiskers> yeah, the basic dev docs don't mention subtrees anywhere so this is news to me
1692021-06-19T18:28:56 <kittywhiskers> i've usually just went along with it, just now that i think about it, figured i'd pop in and ask instead of filing a github issue about it :P
1702021-06-19T18:29:36 <sipa> oh they are documented somewhere
1712021-06-19T18:30:25 <sipa> in doc/developer-notes.md
1722021-06-19T18:30:42 <sipa> regarding libsecp256k1... #secp256k1 is probably a better place
1732021-06-19T18:31:03 <sipa> but in short, there is a (rather slow) ongoing effort of reducing the burden of the build system
1742021-06-19T18:31:29 <sipa> and we're pretty close to just being able to build by invoking a C compiler in many settings
1752021-06-19T18:31:43 <kittywhiskers> i did some preliminary work on getting bitcoin core to build using cmake, like how monero does it
1762021-06-19T18:32:00 <kittywhiskers> that then got me into univalue, secp256k1 and then so on and so forth, luckily leveldb already uses cmake
1772021-06-19T18:32:35 <sipa> well i don't think bitcoib core will switch to cmake
1782021-06-19T18:32:56 <kittywhiskers> i don't mean as a replacement, the current system seems more than efficient
1792021-06-19T18:33:06 <kittywhiskers> merely in parallel
1802021-06-19T18:33:10 <sipa> ok
1812021-06-19T18:33:33 <kittywhiskers> though i do think long term with process separation, cmake does seem like a good option
1822021-06-19T18:34:39 <kittywhiskers> also, turns out the first references to subtrees were five years ago, i should really read more than build-generic.md :P
1832021-06-19T18:36:05 <kittywhiskers> would a PR that tries to unify all instances of the word "Bitcoin" be welcome?
1842021-06-19T18:36:51 <sipa> what do you mean?
1852021-06-19T18:37:23 <kittywhiskers> similar to the PR that unified all uses of BTC across the codebase, now that with the word Bitcoin itself
1862021-06-19T18:38:27 <kittywhiskers> i think the idea of having a refactor where all references to bitcoin in filenames are replaced with core and all mentions of Bitcoin in the source lead back to a static variable is worth considering
1872021-06-19T18:38:34 <sipa> i'd need to see the PR to know what you mean... generally PRs that touch code in lots of different places are annoying
1882021-06-19T18:38:53 <kittywhiskers> yeah, it would break tons of existing PRs so it'll have to be done in small bits
1892021-06-19T18:39:35 <sipa> that doesn't sound worth doing... just high cost low benefit
1902021-06-19T18:42:13 <kittywhiskers> afaik there's already precedent with Cryptonote doing something similar, you name the asset something and keep the name separate from the software that implement's the underlying protocol, marking a distinction between the two
1912021-06-19T18:43:06 <kittywhiskers> yeah, it would be a pain to manoeuvre but figured if done in an organised fashion, it would be viable
1922021-06-19T18:44:37 <kittywhiskers> starting with class names, filenames and then slowly changing out references across the interface to the static value, in a similar way to something like the CAmount refactor or the ticker refactor
1932021-06-19T18:45:33 <sipa> oh you mean in the source code, not something observable?
1942021-06-19T18:45:49 <sipa> i think that's very unlikely to attract reviewer attention
1952021-06-19T18:52:30 *** chrysanthematic <chrysanthematic!~chrysanth@user/chrysanthematic> has joined #bitcoin-core-dev
1962021-06-19T18:52:57 <kittywhiskers> i was hoping to start with non-observable portions and then work up my way to the UI
1972021-06-19T18:59:40 <kittywhiskers> my interest in this stems from the core's forks resorting to a very liberal use of search-and-replace that makes porting changes to-and-from projects a real inconvenience, even if they're fundamentally based on the same version
1982021-06-19T19:00:28 <kittywhiskers> i think even litecoin, which is relatively conservative in their use of SaR deals with merge conflicts from inlining
1992021-06-19T19:00:33 <sipa> no offense, but i couldn't care less about that
2002021-06-19T19:00:54 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 264 seconds)
2012021-06-19T19:02:24 <kittywhiskers> eh, fair enough
2022021-06-19T19:03:44 <kittywhiskers> no offence taken
2032021-06-19T19:05:08 <kittywhiskers> still think it's a neat refactoring idea, figured i'd ask as there already seemed to be precedent
2042021-06-19T19:06:11 <kittywhiskers> i don't mind having to rebase the repo again and again, i planned on doing it as a series of scripted-diffs anyways, just wanted to see the response before i sit down and get to it
2052021-06-19T19:11:32 *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has quit IRC (Ping timeout: 252 seconds)
2062021-06-19T19:19:08 *** CaptainLion <CaptainLion!~User@47.157.125.162> has quit IRC (Quit: Konversation terminated!)
2072021-06-19T19:59:31 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
2082021-06-19T20:25:10 *** l3kk0 <l3kk0!~l3kk0@107.117.175.33> has quit IRC (Read error: Connection reset by peer)
2092021-06-19T20:25:56 *** l3kk0 <l3kk0!~l3kk0@c-73-22-213-40.hsd1.il.comcast.net> has joined #bitcoin-core-dev
2102021-06-19T20:41:51 *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has joined #bitcoin-core-dev
2112021-06-19T21:14:21 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
2122021-06-19T21:24:48 *** chrysanthematic <chrysanthematic!~chrysanth@user/chrysanthematic> has quit IRC (Quit: chrysanthematic)
2132021-06-19T21:45:10 *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has quit IRC (Ping timeout: 252 seconds)
2142021-06-19T21:45:30 *** copumpkin <copumpkin!~woohoo@user/copumpkin> has joined #bitcoin-core-dev
2152021-06-19T21:52:49 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
2162021-06-19T21:59:29 *** evias <evias!~evias__@user/evias> has joined #bitcoin-core-dev
2172021-06-19T22:04:01 *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
2182021-06-19T22:09:43 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
2192021-06-19T22:43:10 *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has quit IRC (Remote host closed the connection)
2202021-06-19T22:49:00 *** evias <evias!~evias__@user/evias> has quit IRC (Quit: This computer has gone to sleep)
2212021-06-19T23:00:44 *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
2222021-06-19T23:05:06 *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has quit IRC (Ping timeout: 252 seconds)
2232021-06-19T23:24:38 *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
2242021-06-19T23:29:07 *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has quit IRC (Ping timeout: 265 seconds)
2252021-06-19T23:41:06 *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
2262021-06-19T23:45:29 *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has quit IRC (Ping timeout: 258 seconds)