1 2021-06-23T00:01:32  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 268 seconds)
  2 2021-06-23T00:07:36  *** belcher_ <belcher_!~belcher@user/belcher> has joined #bitcoin-core-dev
  3 2021-06-23T00:11:10  *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 252 seconds)
  4 2021-06-23T00:17:34  *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has quit IRC (Remote host closed the connection)
  5 2021-06-23T00:20:47  *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
  6 2021-06-23T00:21:34  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
  7 2021-06-23T00:24:09  *** S3RK <S3RK!~S3RK@user/s3rk> has quit IRC (Ping timeout: 272 seconds)
  8 2021-06-23T00:26:34  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 252 seconds)
  9 2021-06-23T00:30:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 10 2021-06-23T00:30:08  <bitcoin-git> [bitcoin] prayank23 opened pull request #22316: doc: Add 5 privacy recommendations in tor.md (master...tor-privacy-recommend) https://github.com/bitcoin/bitcoin/pull/22316
 11 2021-06-23T00:30:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 12 2021-06-23T00:30:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 13 2021-06-23T00:30:25  <bitcoin-git> [bitcoin] prayank23 opened pull request #22317: doc: Highlight DNS requests part in tor.md (master...highlight-dns-request) https://github.com/bitcoin/bitcoin/pull/22317
 14 2021-06-23T00:30:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 15 2021-06-23T00:41:06  *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has quit IRC (Remote host closed the connection)
 16 2021-06-23T00:48:25  <luke-jr> how to restart bitcoinbuilds CI jobs? https://bitcoinbuilds.org/?job=8eba38f6-e542-4497-9330-d9a0f1183f80 seems stalled for nothing related to PR
 17 2021-06-23T00:50:45  *** S3RK <S3RK!~S3RK@user/s3rk> has joined #bitcoin-core-dev
 18 2021-06-23T00:50:58  *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
 19 2021-06-23T00:56:16  *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has quit IRC (Remote host closed the connection)
 20 2021-06-23T01:19:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 21 2021-06-23T01:19:09  <bitcoin-git> [bitcoin] prayank23 closed pull request #21157: doc: Improve Tor docs (master...tor-docs-add) https://github.com/bitcoin/bitcoin/pull/21157
 22 2021-06-23T01:19:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 23 2021-06-23T01:20:07  *** jesseposner <jesseposner!~jesse@2601:647:0:89:6de9:9aa6:8bb7:1691> has quit IRC (Ping timeout: 250 seconds)
 24 2021-06-23T01:21:56  *** jesseposner <jesseposner!~jesse@2601:647:0:89:dcb5:c682:ac61:4798> has joined #bitcoin-core-dev
 25 2021-06-23T02:11:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 26 2021-06-23T02:11:45  <bitcoin-git> [bitcoin] hebasto opened pull request #22318: build: Avoid @GLIBC_2.25 symbols for compatibility (master...210623-random) https://github.com/bitcoin/bitcoin/pull/22318
 27 2021-06-23T02:11:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 28 2021-06-23T02:13:09  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-f9cc-6895-8b3d-e0f4.res6.spectrum.com> has quit IRC (Quit: jarthur)
 29 2021-06-23T02:13:31  *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
 30 2021-06-23T02:14:52  *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has quit IRC (Remote host closed the connection)
 31 2021-06-23T02:16:46  *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
 32 2021-06-23T02:20:00  *** bomb-on <bomb-on!~bomb-on@> has quit IRC (Quit: aллилѹіа!)
 33 2021-06-23T02:21:13  *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has quit IRC (Ping timeout: 265 seconds)
 34 2021-06-23T02:23:00  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
 35 2021-06-23T02:27:30  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 265 seconds)
 36 2021-06-23T02:53:56  *** sagi <sagi!~sagi@bzq-79-179-156-161.red.bezeqint.net> has joined #bitcoin-core-dev
 37 2021-06-23T03:03:23  *** stonefox <stonefox!~stonefox@user/stonefox> has joined #bitcoin-core-dev
 38 2021-06-23T03:04:42  *** pigeons <pigeons!~pigeons@androzani.sysevolve.com> has joined #bitcoin-core-dev
 39 2021-06-23T03:21:50  *** sagi <sagi!~sagi@bzq-79-179-156-161.red.bezeqint.net> has quit IRC (Ping timeout: 252 seconds)
 40 2021-06-23T03:24:46  <meshcollider> dongcarl: it's been a while but it may be a mistake, I think -r is a diff-tree flag not a diff flag
 41 2021-06-23T03:25:09  <meshcollider> To recurse into subtrees
 42 2021-06-23T03:42:19  *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has quit IRC (Ping timeout: 244 seconds)
 43 2021-06-23T03:55:26  *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
 44 2021-06-23T04:23:52  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
 45 2021-06-23T04:28:33  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 258 seconds)
 46 2021-06-23T05:33:24  *** sagi <sagi!~sagi@bzq-79-179-156-161.red.bezeqint.net> has joined #bitcoin-core-dev
 47 2021-06-23T06:08:35  *** dermoth_ <dermoth_!~dermoth@user/dermoth> has joined #bitcoin-core-dev
 48 2021-06-23T06:08:49  *** dermoth <dermoth!~dermoth@user/dermoth> has quit IRC (Killed (NickServ (GHOST command used by dermoth_)))
 49 2021-06-23T06:08:51  *** dermoth_ is now known as dermoth
 50 2021-06-23T06:09:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 51 2021-06-23T06:09:48  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c93e123dc72b...03aa59a4e58f
 52 2021-06-23T06:09:48  <bitcoin-git> bitcoin/master fafd916 MarcoFalke: test: Add missing sync_all to feature_coinstatsindex
 53 2021-06-23T06:09:48  <bitcoin-git> bitcoin/master 03aa59a MarcoFalke: Merge bitcoin/bitcoin#22313: test: Add missing sync_all to feature_coinsta...
 54 2021-06-23T06:09:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 55 2021-06-23T06:10:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 56 2021-06-23T06:10:04  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22313: test: Add missing sync_all to feature_coinstatsindex (master...2106-testSync) https://github.com/bitcoin/bitcoin/pull/22313
 57 2021-06-23T06:10:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 58 2021-06-23T06:21:38  *** sagi <sagi!~sagi@bzq-79-179-156-161.red.bezeqint.net> has quit IRC (Ping timeout: 258 seconds)
 59 2021-06-23T06:24:29  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
 60 2021-06-23T06:29:10  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 265 seconds)
 61 2021-06-23T06:34:20  *** smartin <smartin!~Icedove@> has joined #bitcoin-core-dev
 62 2021-06-23T06:54:41  *** sagi <sagi!~sagi@bzq-79-179-156-161.red.bezeqint.net> has joined #bitcoin-core-dev
 63 2021-06-23T06:56:34  *** cfields <cfields!~cfields@> has quit IRC (Read error: Connection reset by peer)
 64 2021-06-23T06:57:12  *** cfields <cfields!~cfields@> has joined #bitcoin-core-dev
 65 2021-06-23T07:05:43  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
 66 2021-06-23T07:08:11  *** gleb <gleb!~gleb@> has joined #bitcoin-core-dev
 67 2021-06-23T07:16:50  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
 68 2021-06-23T07:48:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 69 2021-06-23T07:48:38  <bitcoin-git> [bitcoin] fanquake opened pull request #22320: build: set minimum required Boost to 1.64.0 (master...minimum_ubuntu_18_04) https://github.com/bitcoin/bitcoin/pull/22320
 70 2021-06-23T07:48:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 71 2021-06-23T07:59:48  *** belcher_ is now known as belcher
 72 2021-06-23T08:03:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 73 2021-06-23T08:03:29  <bitcoin-git> [bitcoin] hebasto opened pull request #22321: build: Avoid qt-specific @GLIBC_2.28 symbols for compatibility (master...210623-statx) https://github.com/bitcoin/bitcoin/pull/22321
 74 2021-06-23T08:03:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 75 2021-06-23T08:04:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 76 2021-06-23T08:04:10  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/03aa59a4e58f...d6e0d78c3155
 77 2021-06-23T08:04:10  <bitcoin-git> bitcoin/master d197977 Vasil Dimov: banman: save the banlist in a JSON format on disk
 78 2021-06-23T08:04:10  <bitcoin-git> bitcoin/master dd4e957 Vasil Dimov: test: ensure banlist can be read from disk after restart
 79 2021-06-23T08:04:10  <bitcoin-git> bitcoin/master 24b10eb Vasil Dimov: doc: fix grammar in doc/files.md
 80 2021-06-23T08:04:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 81 2021-06-23T08:04:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 82 2021-06-23T08:04:27  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20966: banman: save the banlist in a JSON format on disk (master...json_bans) https://github.com/bitcoin/bitcoin/pull/20966
 83 2021-06-23T08:04:28  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 84 2021-06-23T08:12:30  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 244 seconds)
 85 2021-06-23T08:25:14  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
 86 2021-06-23T08:25:38  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
 87 2021-06-23T08:30:17  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 268 seconds)
 88 2021-06-23T08:46:27  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
 89 2021-06-23T09:00:19  *** vnogueir- <vnogueir-!~vnogueira@user/vnogueira> has joined #bitcoin-core-dev
 90 2021-06-23T09:00:33  *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has quit IRC (Ping timeout: 244 seconds)
 91 2021-06-23T09:02:45  *** kexkey_ <kexkey_!~kexkey@static-198-54-132-116.cust.tzulo.com> has joined #bitcoin-core-dev
 92 2021-06-23T09:04:33  *** kexkey <kexkey!~kexkey@static-198-54-132-132.cust.tzulo.com> has quit IRC (Ping timeout: 258 seconds)
 93 2021-06-23T09:37:42  <vasild> * Added support for running Bitcoin Core as an [I2P (Invisible Internet Project)](https://en.wikipedia.org/wiki/I2P) service and connect to such services. See doc/i2p.md for details. (#20685)
 94 2021-06-23T09:37:45  <gribble> https://github.com/bitcoin/bitcoin/issues/20685 | Add I2P support using I2P SAM by vasild · Pull Request #20685 · bitcoin/bitcoin · GitHub
 95 2021-06-23T09:38:18  <vasild> MarcoFalke: am I supposed to edit https://github.com/bitcoin-core/bitcoin-devwiki/wiki/22.0-Release-Notes-draft directly and add the above?
 96 2021-06-23T09:39:04  *** evias <evias!~evias__@196.red-88-6-131.staticip.rima-tde.net> has joined #bitcoin-core-dev
 97 2021-06-23T09:41:43  <jonatack> vasild: I think so. The notes are in the wiki for team editing until -final.
 98 2021-06-23T09:43:30  <vasild> done
 99 2021-06-23T09:43:48  <jonatack> vasild: Probably place it under "Notable changes"
100 2021-06-23T09:43:49  <vasild> why would it be in a wiki otherwise
101 2021-06-23T09:44:16  <vasild> yes, there, just before dropping support for torv2
102 2021-06-23T09:44:35  <jonatack> just saw it lgtm
103 2021-06-23T09:45:13  <vasild> it assumes #22250 is merged (which adds doc/i2p.md)
104 2021-06-23T09:45:16  <gribble> https://github.com/bitcoin/bitcoin/issues/22250 | doc: add basic I2P documentation by vasild · Pull Request #22250 · bitcoin/bitcoin · GitHub
105 2021-06-23T09:49:01  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 258 seconds)
106 2021-06-23T09:49:37  <vasild> I think it is reasonable to s/8333/0/ all i2p ports in addrman as a temporary measure
107 2021-06-23T09:49:52  <vasild> wrt https://github.com/bitcoin/bitcoin/pull/22112#issuecomment-866677980
108 2021-06-23T09:51:11  <vasild> it will only be a problem if some bitcoin node exists which uses SAM 3.2 and "listens" on port 8333 only (checks TO_PORT and drops the incoming connection if it is not 8333)
109 2021-06-23T09:53:17  <vasild> and it advertises itself as foo:8333 and we change that to foo:0
110 2021-06-23T10:13:21  <jonatack> sgtm. we need something like that if I2P addrs are valid with port number 0 only, which is unfortunate.  i don't know of a way to remove or update the existing I2P addrman entries manually from 8333 to 0 (other than deleting peers.dat) so outbound and addnode connections work.
111 2021-06-23T10:13:53  *** [\\\] <[\\\]!~triplesla@user/tripleslash> has quit IRC (Ping timeout: 268 seconds)
112 2021-06-23T10:16:00  <jonatack> and unfortunate that setting the port number to 0 or ignoring the port number would be necessary for SAM < 3.2, i wonder if the remedy is worse than having (short-lived) double connections
113 2021-06-23T10:22:34  *** tripleslash <tripleslash!~triplesla@user/tripleslash> has joined #bitcoin-core-dev
114 2021-06-23T10:24:36  <hebasto> sipa: https://github.com/bitcoin/bitcoin/pull/21365/files#r656962860
115 2021-06-23T10:27:38  *** blkncd <blkncd!uid505676@id-505676.brockwell.irccloud.com> has joined #bitcoin-core-dev
116 2021-06-23T10:32:47  <fanquake> That's annoying. Just another reason to bump the minimum required macOS version
117 2021-06-23T10:33:14  <hebasto> for 22.0 or later?
118 2021-06-23T10:33:14  <fanquake> Then we'll get std::unordered_map::merge and std::filesystem
119 2021-06-23T10:33:33  *** logarus <logarus!~logarus@> has quit IRC (Quit: Leaving)
120 2021-06-23T10:34:34  <fanquake> I would have thought our 10.14 build in the CI would have caught this, as it's building against a 10.15.x SDK, but setting the runtime version to 10.14.x
121 2021-06-23T10:35:28  <hebasto> yeah, build fails with sdk 10.14.6
122 2021-06-23T10:36:16  *** stevenroose <stevenroose!~steven@2001:19f0:6801:83a:ec57:5e94:994a:afff> has quit IRC (Quit: ZNC 1.7.4 - https://znc.in)
123 2021-06-23T10:36:32  *** stevenroose <stevenroose!~steven@2001:19f0:6801:83a:d5d9:4321:5b93:c47b> has joined #bitcoin-core-dev
124 2021-06-23T10:43:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
125 2021-06-23T10:43:16  <bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/d6e0d78c3155...567670bec5ec
126 2021-06-23T10:43:16  <bitcoin-git> bitcoin/master 29e5dd1 Pieter Wuille: consensus refactor: extract ComputeTapleafHash, ComputeTaprootMerkleRoot
127 2021-06-23T10:43:16  <bitcoin-git> bitcoin/master c7388e5 Pieter Wuille: Report address as solvable based on inferred descriptor
128 2021-06-23T10:43:16  <bitcoin-git> bitcoin/master d637a9b Pieter Wuille: Taproot descriptor inference
129 2021-06-23T10:43:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
130 2021-06-23T10:43:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
131 2021-06-23T10:43:38  <bitcoin-git> [bitcoin] meshcollider merged pull request #22166: Add support for inferring tr() descriptors (master...202106_infer_tap) https://github.com/bitcoin/bitcoin/pull/22166
132 2021-06-23T10:43:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
133 2021-06-23T10:51:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
134 2021-06-23T10:51:12  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22322: fuzz: Check banman roundtrip (master...2106-fuzzBanman) https://github.com/bitcoin/bitcoin/pull/22322
135 2021-06-23T10:51:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
136 2021-06-23T10:52:01  *** GIANTWORLDKEEPER <GIANTWORLDKEEPER!~pjetcetal@> has quit IRC (Remote host closed the connection)
137 2021-06-23T11:36:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
138 2021-06-23T11:36:37  <bitcoin-git> [bitcoin] jonatack opened pull request #22323: script, doc: spelling update (master...spelling-update) https://github.com/bitcoin/bitcoin/pull/22323
139 2021-06-23T11:36:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
140 2021-06-23T11:54:35  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Remote host closed the connection)
141 2021-06-23T11:54:49  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
142 2021-06-23T12:10:18  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
143 2021-06-23T12:14:54  *** evias <evias!~evias__@user/evias> has quit IRC (Quit: This computer has gone to sleep)
144 2021-06-23T12:15:22  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 268 seconds)
145 2021-06-23T12:32:33  *** GIANTWORLDKEEPER <GIANTWORLDKEEPER!~pjetcetal@> has joined #bitcoin-core-dev
146 2021-06-23T12:41:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
147 2021-06-23T12:41:54  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22327: cli: Avoid truncating -rpcwaittimeout (master...2106-cliTrunkTime) https://github.com/bitcoin/bitcoin/pull/22327
148 2021-06-23T12:41:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
149 2021-06-23T12:49:08  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
150 2021-06-23T12:49:59  <vasild> #22179 May be considered for 22.0, it also has 3 ACKs
151 2021-06-23T12:50:00  <gribble> https://github.com/bitcoin/bitcoin/issues/22179 | Torv2 removal followups by vasild · Pull Request #22179 · bitcoin/bitcoin · GitHub
152 2021-06-23T12:50:32  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 252 seconds)
153 2021-06-23T12:50:39  *** Guyver2_ is now known as Guyver2
154 2021-06-23T12:50:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
155 2021-06-23T12:50:55  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/567670bec5ec...c0e30933e0d3
156 2021-06-23T12:50:55  <bitcoin-git> bitcoin/master 184d453 Jon Atack: script, doc: spelling update
157 2021-06-23T12:50:55  <bitcoin-git> bitcoin/master c0e3093 MarcoFalke: Merge bitcoin/bitcoin#22323: doc: spelling update
158 2021-06-23T12:50:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
159 2021-06-23T12:51:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
160 2021-06-23T12:51:12  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22323: doc: spelling update (master...spelling-update) https://github.com/bitcoin/bitcoin/pull/22323
161 2021-06-23T12:51:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
162 2021-06-23T13:14:44  *** pigeons <pigeons!~pigeons@androzani.sysevolve.com> has quit IRC (Ping timeout: 252 seconds)
163 2021-06-23T13:15:06  *** doubleqp <doubleqp!~doubleqp@> has quit IRC (Ping timeout: 252 seconds)
164 2021-06-23T13:15:37  *** doubleqp <doubleqp!~doubleqp@> has joined #bitcoin-core-dev
165 2021-06-23T13:16:30  *** pigeons <pigeons!~pigeons@androzani.sysevolve.com> has joined #bitcoin-core-dev
166 2021-06-23T14:05:54  *** kabaum <kabaum!~kabaum@host-78-79-185-3.mobileonline.telia.com> has joined #bitcoin-core-dev
167 2021-06-23T14:06:01  <vasild> jonatack: addrman does not support holding >1 entries that have the same address (and differ only by port), hmm...
168 2021-06-23T14:10:40  <vasild> and if it already holds i2p:8333 and we try to add i2p:0, then it will leave the original (will not update the port) :-(
169 2021-06-23T14:17:02  <jonatack> i tried this too... rpc addpeeraddress no go... edit-in-place or remove-then-add?
170 2021-06-23T14:17:23  <vasild> What about dropping both #21514 and #22112 and leaving #21389 unfixed?
171 2021-06-23T14:17:25  <gribble> https://github.com/bitcoin/bitcoin/issues/21514 | p2p: Ignore ports on I2P addresses by vasild · Pull Request #21514 · bitcoin/bitcoin · GitHub
172 2021-06-23T14:17:27  <gribble> https://github.com/bitcoin/bitcoin/issues/22112 | Force port 0 in I2P by vasild · Pull Request #22112 · bitcoin/bitcoin · GitHub
173 2021-06-23T14:17:28  <gribble> https://github.com/bitcoin/bitcoin/issues/21389 | It is possible to open >1 connections to the same I2P node · Issue #21389 · bitcoin/bitcoin · GitHub
174 2021-06-23T14:18:20  <vasild> editing addrman's entries (changing ports) would require re-bucketing
175 2021-06-23T14:18:27  <jonatack> yes, as i wrote this morning: "i wonder if the remedy is worse than having (short-lived) double connections"
176 2021-06-23T14:18:53  <vasild> Why short-lived?
177 2021-06-23T14:19:22  <jonatack> only that i see that they are infrequent and don't last long
178 2021-06-23T14:20:38  <jonatack> e.g. less than 5 minutes, most often 1 or 2 minutes
179 2021-06-23T14:21:22  <vasild> I have no explanation for that, but short-lived or long-lived is not very important
180 2021-06-23T14:23:26  <jonatack> they seem to have become very rare as well (for me).  i currently know of 14 i2p peers and am usually connected to 11-12 of them at a time, e.g. right now 6 outbound, 6 inbound
181 2021-06-23T14:24:09  <jonatack> (double connections become very rare, they used to be common)
182 2021-06-23T14:25:03  <vasild> the issue 21389 only happens when addnode is (mis)used
183 2021-06-23T14:25:07  <vasild> or -connect=...
184 2021-06-23T14:25:43  <vasild> (mis)used == addnode same i2p addr with different ports
185 2021-06-23T14:25:58  <jonatack> either same one in and out (both sides adding the other) or two in at once (maybe because addnode was used twice, with and with port)
186 2021-06-23T14:26:20  <jonatack> *with and without port
187 2021-06-23T14:26:26  <vasild> yes
188 2021-06-23T14:26:51  <vasild> maybe we played more with addnode before and recently have left it alone
189 2021-06-23T14:27:11  <jonatack> wait until SAM 3.2 then?
190 2021-06-23T14:27:54  <vasild> and do what if/when we start using SAM 3.2?
191 2021-06-23T14:27:57  <jonatack> that's probably true about less addnode use
192 2021-06-23T14:34:18  *** kabaum <kabaum!~kabaum@host-78-79-185-3.mobileonline.telia.com> has quit IRC (Ping timeout: 252 seconds)
193 2021-06-23T14:39:24  <jamesob> maintainers: anything else you'd like to see for #21526 to merge? once that goes in I can open a number of other smaller AU PRs
194 2021-06-23T14:39:28  <gribble> https://github.com/bitcoin/bitcoin/issues/21526 | validation: UpdateTip/CheckBlockIndex assumeutxo support by jamesob · Pull Request #21526 · bitcoin/bitcoin · GitHub
195 2021-06-23T14:40:31  <jonatack> looking at https://geti2p.net/en/docs/api/samv3, SAM 3.2 introduces options FROM_PORT and TO_PORT, and in SAM 3.3, "incoming packets and streams will be routed based on I2P protocol and to-port"
196 2021-06-23T14:44:41  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 268 seconds)
197 2021-06-23T14:45:18  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
198 2021-06-23T14:51:53  *** Guest97 <Guest97!~Guest97@115-37-168-243.area8a.commufa.jp> has joined #bitcoin-core-dev
199 2021-06-23T14:52:34  *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f03bc007d5a943c0e3a0f32.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
200 2021-06-23T14:58:30  *** Guest87 <Guest87!~Guest87@115-37-168-243.area8a.commufa.jp> has joined #bitcoin-core-dev
201 2021-06-23T14:58:50  *** Guest97 <Guest97!~Guest97@115-37-168-243.area8a.commufa.jp> has quit IRC (Quit: Client closed)
202 2021-06-23T14:59:03  *** Guest87 <Guest87!~Guest87@115-37-168-243.area8a.commufa.jp> has quit IRC (Client Quit)
203 2021-06-23T14:59:46  *** Guest42 <Guest42!~Guest42@115-37-168-243.area8a.commufa.jp> has joined #bitcoin-core-dev
204 2021-06-23T15:03:24  *** Guest34 <Guest34!~Guest34@115-37-168-243.area8a.commufa.jp> has joined #bitcoin-core-dev
205 2021-06-23T15:05:06  *** Guest34 <Guest34!~Guest34@115-37-168-243.area8a.commufa.jp> has quit IRC (Client Quit)
206 2021-06-23T15:05:29  *** Guest3948 <Guest3948!~Guest39@115-37-168-243.area8a.commufa.jp> has joined #bitcoin-core-dev
207 2021-06-23T15:05:45  *** Guest3948 <Guest3948!~Guest39@115-37-168-243.area8a.commufa.jp> has quit IRC (Client Quit)
208 2021-06-23T15:10:41  *** Guest42 <Guest42!~Guest42@115-37-168-243.area8a.commufa.jp> has quit IRC (Quit: Client closed)
209 2021-06-23T15:10:55  *** Guest4748 <Guest4748!~Guest47@115-37-168-243.area8a.commufa.jp> has joined #bitcoin-core-dev
210 2021-06-23T15:11:07  *** Guest4748 <Guest4748!~Guest47@115-37-168-243.area8a.commufa.jp> has quit IRC (Client Quit)
211 2021-06-23T15:14:01  <vasild> jonatack: posted a summary at https://github.com/bitcoin/bitcoin/issues/21389#issuecomment-866925116, will sleep over this and re-evaluate
212 2021-06-23T15:30:55  <jonatack> vasild: good summary, same. thanks!
213 2021-06-23T15:56:02  *** powerjungle <powerjungle!~powerjung@h081217087223.dyn.cm.kabsi.at> has quit IRC (Quit: ZNC - https://znc.in)
214 2021-06-23T15:59:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
215 2021-06-23T15:59:02  <bitcoin-git> [bitcoin] theStack opened pull request #22330: test: use MiniWallet for simple doublespend sub-test in feature_rbf.py (master...202106-test-feature_rbf_use_miniwallet_for_doublespend) https://github.com/bitcoin/bitcoin/pull/22330
216 2021-06-23T15:59:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
217 2021-06-23T16:01:56  *** powerjungle <powerjungle!~powerjung@h081217087223.dyn.cm.kabsi.at> has joined #bitcoin-core-dev
218 2021-06-23T16:02:09  *** earnestly <earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
219 2021-06-23T16:08:10  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
220 2021-06-23T16:10:48  *** lightlike <lightlike!~lightlike@user/lightlike> has joined #bitcoin-core-dev
221 2021-06-23T16:22:08  *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f03bc007d5a943c0e3a0f32.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
222 2021-06-23T16:27:39  *** emcy <emcy!~emcy@user/emcy> has quit IRC (Remote host closed the connection)
223 2021-06-23T16:34:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
224 2021-06-23T16:34:56  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c0e30933e0d3...7317e14a44c6
225 2021-06-23T16:34:56  <bitcoin-git> bitcoin/master 615c1ad James O'Beirne: refactor: wrap CCoinsViewCursor in unique_ptr
226 2021-06-23T16:34:56  <bitcoin-git> bitcoin/master 0f8a5a4 James O'Beirne: move-only(ish): don't expose CCoinsViewDBCursor
227 2021-06-23T16:34:56  <bitcoin-git> bitcoin/master 7ad414f James O'Beirne: doc: add comment about CCoinsViewDBCursor constructor
228 2021-06-23T16:34:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
229 2021-06-23T16:35:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
230 2021-06-23T16:35:13  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22263: refactor: wrap CCoinsViewCursor in unique_ptr (master...2021-06-cursor-unique-ptr) https://github.com/bitcoin/bitcoin/pull/22263
231 2021-06-23T16:35:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
232 2021-06-23T16:39:14  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
233 2021-06-23T16:40:33  *** davterra <davterra!~davterra@> has quit IRC (Quit: Leaving)
234 2021-06-23T16:40:36  *** ron-slc <ron-slc!~Ron@c-98-202-48-169.hsd1.ut.comcast.net> has joined #bitcoin-core-dev
235 2021-06-23T16:48:15  *** dunxen <dunxen!dunxen@gateway/vpn/protonvpn/dunxen> has joined #bitcoin-core-dev
236 2021-06-23T16:52:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
237 2021-06-23T16:52:39  <bitcoin-git> [bitcoin] dhruv opened pull request #22331: [crypto] Fix K1/K2 use in ChaCha20-Poly1305 AEAD (master...15649-followups) https://github.com/bitcoin/bitcoin/pull/22331
238 2021-06-23T16:52:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
239 2021-06-23T16:54:04  *** dunxen <dunxen!dunxen@gateway/vpn/protonvpn/dunxen> has quit IRC (Quit: Leaving...)
240 2021-06-23T17:07:12  *** Guest25 <Guest25!~Guest25@111-252-182-161.dynamic-ip.hinet.net> has joined #bitcoin-core-dev
241 2021-06-23T17:08:36  *** Guest25 <Guest25!~Guest25@111-252-182-161.dynamic-ip.hinet.net> has quit IRC (Client Quit)
242 2021-06-23T17:09:07  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 250 seconds)
243 2021-06-23T17:13:18  *** Neojack <Neojack!Neojack@pear.bnc4free.com> has quit IRC (Ping timeout: 268 seconds)
244 2021-06-23T17:25:05  *** emcy <emcy!~emcy@user/emcy> has joined #bitcoin-core-dev
245 2021-06-23T17:28:30  *** Neojack <Neojack!Neojack@pear.bnc4free.com> has joined #bitcoin-core-dev
246 2021-06-23T17:42:08  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
247 2021-06-23T17:57:49  *** kexkey <kexkey!~kexkey@static-198-54-132-100.cust.tzulo.com> has joined #bitcoin-core-dev
248 2021-06-23T17:59:38  *** kexkey_ <kexkey_!~kexkey@static-198-54-132-116.cust.tzulo.com> has quit IRC (Ping timeout: 252 seconds)
249 2021-06-23T18:13:05  *** evias <evias!~evias__@196.red-88-6-131.staticip.rima-tde.net> has joined #bitcoin-core-dev
250 2021-06-23T18:14:03  *** evias <evias!~evias__@user/evias> has quit IRC (Client Quit)
251 2021-06-23T18:23:06  *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
252 2021-06-23T18:32:32  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 244 seconds)
253 2021-06-23T18:35:41  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
254 2021-06-23T18:37:05  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 250 seconds)
255 2021-06-23T18:37:12  *** Guyver2_ is now known as Guyver2
256 2021-06-23T18:41:24  *** evias <evias!~evias__@196.red-88-6-131.staticip.rima-tde.net> has joined #bitcoin-core-dev
257 2021-06-23T18:52:21  *** evias <evias!~evias__@user/evias> has quit IRC (Quit: This computer has gone to sleep)
258 2021-06-23T18:52:26  *** jespada <jespada!~jespada@> has quit IRC (Ping timeout: 252 seconds)
259 2021-06-23T18:55:45  *** jespada <jespada!~jespada@> has joined #bitcoin-core-dev
260 2021-06-23T18:59:18  *** jeremyru_ <jeremyru_!~jeremyrub@024-176-247-182.res.spectrum.com> has quit IRC ()
261 2021-06-23T19:03:18  *** bomb-on <bomb-on!~bomb-on@> has joined #bitcoin-core-dev
262 2021-06-23T19:21:54  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
263 2021-06-23T19:29:29  <jamesob> where's the list of PRs that need review before feature freeze?
264 2021-06-23T19:35:00  <sipa> milestone 22.0? https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A22.0
265 2021-06-23T19:47:34  <jamesob> sipa: danke
266 2021-06-23T19:58:29  *** Guest9030 <Guest9030!~Guest90@> has joined #bitcoin-core-dev
267 2021-06-23T20:14:51  *** kabaum <kabaum!~kabaum@host-78-79-185-3.mobileonline.telia.com> has joined #bitcoin-core-dev
268 2021-06-23T20:17:08  *** sagi <sagi!~sagi@bzq-79-179-156-161.red.bezeqint.net> has quit IRC (Ping timeout: 252 seconds)
269 2021-06-23T20:38:49  *** kabaum <kabaum!~kabaum@host-78-79-185-3.mobileonline.telia.com> has quit IRC (Ping timeout: 246 seconds)
270 2021-06-23T20:42:03  *** Guest9030 <Guest9030!~Guest90@> has quit IRC (Quit: Client closed)
271 2021-06-23T20:43:34  *** kabaum <kabaum!~kabaum@host-78-79-185-3.mobileonline.telia.com> has joined #bitcoin-core-dev
272 2021-06-23T20:52:28  *** kabaum <kabaum!~kabaum@host-78-79-185-3.mobileonline.telia.com> has quit IRC (Ping timeout: 246 seconds)
273 2021-06-23T20:55:54  *** sagi <sagi!~sagi@bzq-79-179-156-161.red.bezeqint.net> has joined #bitcoin-core-dev
274 2021-06-23T21:16:54  *** l3kk0 <l3kk0!~l3kk0@c-73-22-213-40.hsd1.il.comcast.net> has quit IRC (Read error: Connection reset by peer)
275 2021-06-23T21:19:59  *** gleb <gleb!~gleb@> has quit IRC (Quit: Ping timeout (120 seconds))
276 2021-06-23T21:20:21  *** gleb <gleb!~gleb@> has joined #bitcoin-core-dev
277 2021-06-23T21:27:49  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
278 2021-06-23T21:57:13  *** sagi <sagi!~sagi@bzq-79-179-156-161.red.bezeqint.net> has quit IRC (Ping timeout: 246 seconds)
279 2021-06-23T22:02:03  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
280 2021-06-23T22:03:34  *** lightlike <lightlike!~lightlike@user/lightlike> has quit IRC (Quit: Leaving)
281 2021-06-23T22:38:17  *** sagi <sagi!~sagi@bzq-79-179-156-161.red.bezeqint.net> has joined #bitcoin-core-dev
282 2021-06-23T22:50:04  *** evias <evias!~evias__@196.red-88-6-131.staticip.rima-tde.net> has joined #bitcoin-core-dev
283 2021-06-23T22:51:32  *** evias <evias!~evias__@user/evias> has quit IRC (Client Quit)
284 2021-06-23T22:59:20  *** TheRec <TheRec!~toto@user/therec> has quit IRC ()
285 2021-06-23T23:05:42  *** gleb <gleb!~gleb@> has quit IRC (Quit: Ping timeout (120 seconds))
286 2021-06-23T23:06:05  *** gleb <gleb!~gleb@> has joined #bitcoin-core-dev
287 2021-06-23T23:09:36  *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
288 2021-06-23T23:23:24  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Remote host closed the connection)
289 2021-06-23T23:23:31  *** sagi <sagi!~sagi@bzq-79-179-156-161.red.bezeqint.net> has quit IRC (Ping timeout: 250 seconds)
290 2021-06-23T23:45:30  *** smartin <smartin!~Icedove@> has quit IRC (Quit: smartin)
291 2021-06-23T23:53:56  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
292 2021-06-23T23:59:15  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 258 seconds)