1 2021-07-19T00:06:21  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
  2 2021-07-19T00:13:07  *** grettke is now known as grettke-away
  3 2021-07-19T00:27:20  *** Aaronvan_ <Aaronvan_!~AaronvanW@178.239.167.159> has quit IRC (Remote host closed the connection)
  4 2021-07-19T00:28:49  *** grettke-away is now known as grettke
  5 2021-07-19T00:34:35  *** dr_orlovsky <dr_orlovsky!~dr-orlovs@31.14.40.19> has quit IRC (Quit: ZNC 1.8.0 - https://znc.in)
  6 2021-07-19T00:34:36  *** earnestly <earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 268 seconds)
  7 2021-07-19T00:40:56  *** grettke is now known as grettke-away
  8 2021-07-19T00:44:13  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 246 seconds)
  9 2021-07-19T00:49:01  *** gwillen1 is now known as gwillen
 10 2021-07-19T00:51:09  *** lightlike_ <lightlike_!~lightlike@p200300c7ef049500bcc71827ff80d40b.dip0.t-ipconnect.de> has quit IRC (Quit: Leaving)
 11 2021-07-19T00:53:06  *** naiza <naiza!~naiza@180.188.251.91> has quit IRC (Ping timeout: 268 seconds)
 12 2021-07-19T00:58:19  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.159> has joined #bitcoin-core-dev
 13 2021-07-19T01:03:15  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.159> has quit IRC (Ping timeout: 258 seconds)
 14 2021-07-19T01:05:01  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has joined #bitcoin-core-dev
 15 2021-07-19T01:06:10  *** Guest62 <Guest62!~Guest62@2001:8003:d80c:8801:6518:f6d3:d5d7:146b> has joined #bitcoin-core-dev
 16 2021-07-19T01:06:43  *** Guest62 <Guest62!~Guest62@2001:8003:d80c:8801:6518:f6d3:d5d7:146b> has quit IRC (Client Quit)
 17 2021-07-19T01:11:31  *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 246 seconds)
 18 2021-07-19T01:12:50  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has quit IRC (Ping timeout: 258 seconds)
 19 2021-07-19T01:22:28  *** grettke-away is now known as grettke
 20 2021-07-19T01:26:59  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.159> has joined #bitcoin-core-dev
 21 2021-07-19T01:31:28  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.159> has quit IRC (Ping timeout: 246 seconds)
 22 2021-07-19T01:44:46  *** grettke is now known as grettke-away
 23 2021-07-19T01:45:34  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.216> has joined #bitcoin-core-dev
 24 2021-07-19T01:48:35  *** grettke-away is now known as grettke
 25 2021-07-19T01:49:57  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.216> has quit IRC (Ping timeout: 255 seconds)
 26 2021-07-19T02:03:12  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has joined #bitcoin-core-dev
 27 2021-07-19T02:06:36  *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has quit IRC (Ping timeout: 255 seconds)
 28 2021-07-19T02:07:44  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has quit IRC (Ping timeout: 252 seconds)
 29 2021-07-19T02:09:43  *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has joined #bitcoin-core-dev
 30 2021-07-19T02:20:35  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.159> has joined #bitcoin-core-dev
 31 2021-07-19T02:23:56  <achow101> can someone familiar with DEBUG_LOCKORDER help me out with #22489?
 32 2021-07-19T02:23:57  <gribble> https://github.com/bitcoin/bitcoin/issues/22489 | The dumpwallet RPC command stops/kills bitcoind · Issue #22489 · bitcoin/bitcoin · GitHub
 33 2021-07-19T02:24:42  <achow101> istm there shouldn't be a lock order issue detected because the function should have exited and the locks released by the time that the different lock order is being used
 34 2021-07-19T02:25:17  <sipa> that's not what lock order detection does :)
 35 2021-07-19T02:25:27  <sipa> it verifies that the same locks are always taken in the same order
 36 2021-07-19T02:25:30  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.159> has quit IRC (Ping timeout: 255 seconds)
 37 2021-07-19T02:25:37  <sipa> if they are _ever_ held simultaneously
 38 2021-07-19T02:25:43  <achow101> ah
 39 2021-07-19T02:26:20  <sipa> it's perfectly possible that it detects inconsistencies that cannot ever result in actual deadlocks
 40 2021-07-19T02:27:11  <sipa> (but that generally does mean the code is fragile, as calling things a bit differently can cause a deadlock)
 41 2021-07-19T02:28:32  <achow101> indeed
 42 2021-07-19T02:29:51  <achow101> does it only detect locks held simultaneously or does it also detect the order of locks taken after one is released?
 43 2021-07-19T02:29:58  *** Guest18 <Guest18!~Guest18@107.175.104.83> has joined #bitcoin-core-dev
 44 2021-07-19T02:30:21  *** Guest18 <Guest18!~Guest18@107.175.104.83> has quit IRC (Client Quit)
 45 2021-07-19T02:32:01  <sipa> if locks A and B are ever held simultaneously, it will remember their relative order
 46 2021-07-19T02:32:19  <sipa> if two conflicting relative orders are observed, it will abort
 47 2021-07-19T02:32:54  <sipa> "order" here means "A is locked while B was held" -> "A > B"
 48 2021-07-19T02:33:17  *** grettke is now known as grettke-away
 49 2021-07-19T02:34:31  <achow101> ok
 50 2021-07-19T02:36:52  <sipa> so you can't have code that in some place locks A while B is held
 51 2021-07-19T02:37:00  <sipa> and elsewhere locks B whila A is held
 52 2021-07-19T02:37:18  <achow101> and yet we do
 53 2021-07-19T02:38:03  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has joined #bitcoin-core-dev
 54 2021-07-19T02:38:13  <achow101> but only if you try to do dumpwallet and have loaded the wallet when there is an unconfirmed transaction belonging to it in the mempool
 55 2021-07-19T02:46:34  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has quit IRC (Ping timeout: 268 seconds)
 56 2021-07-19T02:56:03  *** freesprung <freesprung!~freesprun@136-25-131-81.cab.webpass.net> has joined #bitcoin-core-dev
 57 2021-07-19T03:11:46  *** Bilnon <Bilnon!~8iIn0n@2a01:4b00:8e07:7900:86dd:c745:c933:bc6a> has joined #bitcoin-core-dev
 58 2021-07-19T03:13:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 59 2021-07-19T03:13:18  <bitcoin-git> [bitcoin] achow101 opened pull request #22492: wallet: Reorder locks in dumpwallet to avoid lock order assertion (master...dumpwallet-lock-order) https://github.com/bitcoin/bitcoin/pull/22492
 60 2021-07-19T03:13:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 61 2021-07-19T03:14:41  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.216> has joined #bitcoin-core-dev
 62 2021-07-19T03:19:14  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.216> has quit IRC (Ping timeout: 252 seconds)
 63 2021-07-19T03:31:44  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has joined #bitcoin-core-dev
 64 2021-07-19T03:36:20  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has quit IRC (Ping timeout: 255 seconds)
 65 2021-07-19T03:38:20  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-f109-9e55-0d51-bd0d.res6.spectrum.com> has joined #bitcoin-core-dev
 66 2021-07-19T03:50:03  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has joined #bitcoin-core-dev
 67 2021-07-19T03:54:35  *** grettke-away is now known as grettke
 68 2021-07-19T03:54:36  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has quit IRC (Ping timeout: 258 seconds)
 69 2021-07-19T04:06:36  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has joined #bitcoin-core-dev
 70 2021-07-19T04:06:56  *** piku <piku!~piku@47.202.125.123> has quit IRC (Ping timeout: 255 seconds)
 71 2021-07-19T04:11:23  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has quit IRC (Ping timeout: 265 seconds)
 72 2021-07-19T04:14:26  *** grettke is now known as grettke-away
 73 2021-07-19T04:23:40  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.216> has joined #bitcoin-core-dev
 74 2021-07-19T04:28:10  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.216> has quit IRC (Ping timeout: 252 seconds)
 75 2021-07-19T04:28:30  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
 76 2021-07-19T04:32:39  *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
 77 2021-07-19T04:33:37  *** grettke-away <grettke-away!~grettke@cpe-65-29-228-30.wi.res.rr.com> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 78 2021-07-19T04:41:24  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has joined #bitcoin-core-dev
 79 2021-07-19T04:46:12  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has quit IRC (Ping timeout: 268 seconds)
 80 2021-07-19T04:46:16  <robertspigler> luke-jr: makes sense, thanks!
 81 2021-07-19T04:54:00  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-f109-9e55-0d51-bd0d.res6.spectrum.com> has quit IRC (Ping timeout: 255 seconds)
 82 2021-07-19T04:59:09  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-7828-89c1-5bc4-4b6a.res6.spectrum.com> has joined #bitcoin-core-dev
 83 2021-07-19T05:01:22  *** uasf <uasf!~uasf@2604:a880:2:d0::1bda:1001> has quit IRC (Remote host closed the connection)
 84 2021-07-19T05:02:00  *** uasf <uasf!~uasf@2604:a880:2:d0::1bda:1001> has joined #bitcoin-core-dev
 85 2021-07-19T05:05:12  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has joined #bitcoin-core-dev
 86 2021-07-19T05:10:15  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has quit IRC (Ping timeout: 268 seconds)
 87 2021-07-19T05:21:52  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.216> has joined #bitcoin-core-dev
 88 2021-07-19T05:26:28  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.216> has quit IRC (Ping timeout: 252 seconds)
 89 2021-07-19T05:30:45  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has joined #bitcoin-core-dev
 90 2021-07-19T05:35:16  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has quit IRC (Ping timeout: 252 seconds)
 91 2021-07-19T05:47:09  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has joined #bitcoin-core-dev
 92 2021-07-19T05:51:46  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has quit IRC (Ping timeout: 252 seconds)
 93 2021-07-19T06:03:12  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.157> has joined #bitcoin-core-dev
 94 2021-07-19T06:08:00  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.157> has quit IRC (Ping timeout: 258 seconds)
 95 2021-07-19T06:20:08  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.158> has joined #bitcoin-core-dev
 96 2021-07-19T06:24:54  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.158> has quit IRC (Ping timeout: 255 seconds)
 97 2021-07-19T06:31:22  *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
 98 2021-07-19T06:37:38  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.157> has joined #bitcoin-core-dev
 99 2021-07-19T06:42:16  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.157> has quit IRC (Ping timeout: 246 seconds)
100 2021-07-19T06:53:45  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has joined #bitcoin-core-dev
101 2021-07-19T06:56:18  *** belcher_ is now known as belcher
102 2021-07-19T06:58:39  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has quit IRC (Ping timeout: 255 seconds)
103 2021-07-19T07:01:13  <vasild> achow101: sipa: but does our lock order detect potential issues like: lock A, lock B, unlock B, unlock A; at this time the lock stack for the thread would be empty, then at a later time: lock B, lock A.
104 2021-07-19T07:02:46  <vasild> looking at src/sync.cpp I think it will not detect ^
105 2021-07-19T07:05:26  *** davterra <davterra!~davterra@143.244.186.214> has joined #bitcoin-core-dev
106 2021-07-19T07:06:00  *** user__ <user__!~davterra@143.244.186.214> has quit IRC (Read error: Connection reset by peer)
107 2021-07-19T07:11:00  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has joined #bitcoin-core-dev
108 2021-07-19T07:16:03  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has quit IRC (Ping timeout: 268 seconds)
109 2021-07-19T07:28:04  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
110 2021-07-19T07:28:33  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
111 2021-07-19T07:29:17  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has joined #bitcoin-core-dev
112 2021-07-19T07:31:52  *** goatpig <goatpig!~goat@2a01cb0801f0f600be47f4aa218cbe13.ipv6.abo.wanadoo.fr> has joined #bitcoin-core-dev
113 2021-07-19T07:34:12  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has quit IRC (Ping timeout: 255 seconds)
114 2021-07-19T07:45:42  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has joined #bitcoin-core-dev
115 2021-07-19T07:46:35  <laanwj> no, it doesn't detect that, i guess it would require quite a lot of extra record-keeping
116 2021-07-19T07:47:12  <laanwj> keeping track of current locking state versus historical locking state
117 2021-07-19T07:47:37  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-7828-89c1-5bc4-4b6a.res6.spectrum.com> has quit IRC (Quit: jarthur)
118 2021-07-19T07:50:35  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has quit IRC (Ping timeout: 268 seconds)
119 2021-07-19T07:52:07  <vasild> right, that would be significant runtime performance overhead
120 2021-07-19T07:52:39  <S3RK> now I'm confused. What's the difference between "conflicting relative orders are observed" and "locking state versus hisotrical locking state"?
121 2021-07-19T07:53:44  <vasild> hmm, actually not, the "lock orders" database can be global, need not be per-thread, so at least the size/memory overhead would not be too much
122 2021-07-19T07:54:28  *** user__ <user__!~davterra@143.244.186.214> has joined #bitcoin-core-dev
123 2021-07-19T07:55:16  <vasild> S3RK: "conflicting relative orders are observed" probably means that some thread locked A, B (in that order) and another thread locked B and tries to lock A, _while_ the first thread still holds both mutexes
124 2021-07-19T07:56:52  *** davterra <davterra!~davterra@143.244.186.214> has quit IRC (Ping timeout: 258 seconds)
125 2021-07-19T07:57:00  <vasild> while "locking state versus hisotrical locking state" imples that we remember that the first thread has locked A,B even after it releases those mutexes, so if we do that it is possible to detect if another thread locks B,A even after the first thread has released all mutexes
126 2021-07-19T07:57:12  <S3RK> how is it possible that the second thred locked B while the first thread still holds both?
127 2021-07-19T07:58:15  *** kiran <kiran!~kiran@218.185.248.66> has joined #bitcoin-core-dev
128 2021-07-19T07:58:16  *** kiran21 <kiran21!~kiran@218.185.248.66> has joined #bitcoin-core-dev
129 2021-07-19T07:58:33  *** cold <cold!~cold@user/cold> has quit IRC (Ping timeout: 265 seconds)
130 2021-07-19T07:58:39  *** kiran21 <kiran21!~kiran@218.185.248.66> has quit IRC (Client Quit)
131 2021-07-19T07:59:07  <vasild> it is not possible, of course, I am talking nonsense. The scenario is: thread1: lock A, thread2: lock B, thread1: try to lock B, thread2: try to lock A
132 2021-07-19T08:00:35  <vasild> The thing is that after a thread releases a lock we delete it from its lock-stack == we forget that it ever locked it.
133 2021-07-19T08:00:36  <S3RK> hm... this sounds like deadlock detection. I thought debug_lockorder is something more
134 2021-07-19T08:00:55  *** cold <cold!~cold@user/cold> has joined #bitcoin-core-dev
135 2021-07-19T08:02:49  <vasild> see push_lock() and pop_lock() in src/sync.cpp
136 2021-07-19T08:02:59  <S3RK> will do, thanks
137 2021-07-19T08:03:08  *** earnestly <earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
138 2021-07-19T08:06:32  *** jarthur <jarthur!~jarthur@cpe-70-114-198-37.austin.res.rr.com> has joined #bitcoin-core-dev
139 2021-07-19T08:22:42  <S3RK> lockorder is actually removed in DeleteLock() but I'm not familiar with the code at all to understnd fully how it works
140 2021-07-19T08:33:32  <jnewbery> vasild: with DEBUG_LOCKORDER, we keep a global object to track all the previous lock stacks, to detect any potential lock inversions: https://github.com/bitcoin/bitcoin/blob/e8f85e0e86e92e583b8984455b7bf9d0a777578a/src/sync.cpp#L90-L104
141 2021-07-19T08:34:46  <vasild> aha, so we already do!
142 2021-07-19T08:36:56  <vasild> but wait, we do erase() from DeleteLock()
143 2021-07-19T08:47:06  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 255 seconds)
144 2021-07-19T08:48:24  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
145 2021-07-19T08:52:26  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has joined #bitcoin-core-dev
146 2021-07-19T08:55:01  *** jarthur <jarthur!~jarthur@cpe-70-114-198-37.austin.res.rr.com> has quit IRC (Quit: jarthur)
147 2021-07-19T08:56:56  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has quit IRC (Ping timeout: 252 seconds)
148 2021-07-19T09:03:02  <laanwj> huh, I thought the idea behind using thread-local storage in DEBUG_LOCKORDER was to avoid the overhead of having any global synchronized objects in the lock tracking
149 2021-07-19T09:03:32  <laanwj> but yeah that can't be the case, it has to cross-check
150 2021-07-19T09:04:40  <laanwj> it was never intended to be really efficient or low-overhead, that's why it's only enabled with debug builds
151 2021-07-19T09:07:33  *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
152 2021-07-19T09:07:46  <jnewbery> I think DeleteLock() is called when the mutex is destroyed, not when the lock is released
153 2021-07-19T09:08:17  <jnewbery> LeaveCritical() is the function called when the lock is released
154 2021-07-19T09:10:16  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has joined #bitcoin-core-dev
155 2021-07-19T09:12:32  <laanwj> that seems to be the case, it is called from the destructor of AnnotatedMixin, which is used to define RecursiveMutex etc
156 2021-07-19T09:15:00  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has quit IRC (Ping timeout: 255 seconds)
157 2021-07-19T09:28:22  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has joined #bitcoin-core-dev
158 2021-07-19T09:32:44  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has quit IRC (Ping timeout: 255 seconds)
159 2021-07-19T09:36:50  <_aj_> laanwj: it's not really thread local storage, it's a global map (GetLockData()) indexed by thread id? it used to be thread local prior to #18881 by the looks
160 2021-07-19T09:36:53  <gribble> https://github.com/bitcoin/bitcoin/issues/18881 | Prevent UB in DeleteLock() function by hebasto · Pull Request #18881 · bitcoin/bitcoin · GitHub
161 2021-07-19T09:37:35  <laanwj> _aj_: correct, the TLS is only used for the thread names
162 2021-07-19T09:37:57  <laanwj> I must have mixed a few things up
163 2021-07-19T09:38:25  <laanwj> I remember it differently than that it is
164 2021-07-19T09:43:25  <laanwj> it did use thread_local before last year (26c093a9957756f3743c2347fe0abd90f81159c4, #18881)
165 2021-07-19T09:43:28  <gribble> https://github.com/bitcoin/bitcoin/issues/18881 | Prevent UB in DeleteLock() function by hebasto · Pull Request #18881 · bitcoin/bitcoin · GitHub
166 2021-07-19T09:44:47  <vasild> A simple confirmation that lock order is being remembered: https://bpa.st/2CBQ
167 2021-07-19T09:45:53  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.157> has joined #bitcoin-core-dev
168 2021-07-19T09:50:28  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.157> has quit IRC (Ping timeout: 252 seconds)
169 2021-07-19T10:01:48  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 255 seconds)
170 2021-07-19T10:02:32  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.216> has joined #bitcoin-core-dev
171 2021-07-19T10:07:04  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.216> has quit IRC (Ping timeout: 256 seconds)
172 2021-07-19T10:19:23  <vasild> It seems some i2p nodes run #22112 while others don't (yet): https://bpa.st/LUGQ
173 2021-07-19T10:19:26  <gribble> https://github.com/bitcoin/bitcoin/issues/22112 | Force port 0 in I2P by vasild · Pull Request #22112 · bitcoin/bitcoin · GitHub
174 2021-07-19T10:21:06  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.157> has joined #bitcoin-core-dev
175 2021-07-19T10:23:41  <vasild> This is the list of i2p nodes I am aware of: https://bpa.st/UOXQ, I (tried to) connect to each one and observed whether they advertise themselves with port 0 or 8333.
176 2021-07-19T10:25:04  <vasild> jonatack: do you have more i2p addresses than listed in https://bpa.st/UOXQ ?
177 2021-07-19T10:25:40  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.157> has quit IRC (Ping timeout: 252 seconds)
178 2021-07-19T10:25:53  *** naiza <naiza!~naiza@180.188.251.163> has joined #bitcoin-core-dev
179 2021-07-19T10:26:49  <jonatack> yes, 3 other i2p ones, otherwise i have the same list
180 2021-07-19T10:29:35  <jonatack> 4, sent them to you
181 2021-07-19T10:30:52  *** promag <promag!~promag@188.250.84.129> has quit IRC (Quit: Leaving...)
182 2021-07-19T10:39:01  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.158> has joined #bitcoin-core-dev
183 2021-07-19T10:42:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
184 2021-07-19T10:42:44  <bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/e8f85e0e86e9...d3474b8df2f9
185 2021-07-19T10:42:44  <bitcoin-git> bitcoin/master 0d64b8f Pieter Wuille: Rate limit the processing of incoming addr messages
186 2021-07-19T10:42:44  <bitcoin-git> bitcoin/master 5648138 Pieter Wuille: Randomize the order of addr processing
187 2021-07-19T10:42:44  <bitcoin-git> bitcoin/master b4ece8a Pieter Wuille: Functional tests for addr rate limiting
188 2021-07-19T10:42:45  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 255 seconds)
189 2021-07-19T10:42:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
190 2021-07-19T10:43:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
191 2021-07-19T10:43:02  <bitcoin-git> [bitcoin] laanwj merged pull request #22387: Rate limit the processing of rumoured addresses (master...202106_rate_limit_addr) https://github.com/bitcoin/bitcoin/pull/22387
192 2021-07-19T10:43:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
193 2021-07-19T10:43:25  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
194 2021-07-19T10:43:38  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.158> has quit IRC (Ping timeout: 252 seconds)
195 2021-07-19T10:44:42  *** dr-orlovsky <dr-orlovsky!~dr-orlovs@31.14.40.19> has joined #bitcoin-core-dev
196 2021-07-19T10:45:13  <emzy> vasild: I will update my i2p node to master later today.
197 2021-07-19T10:47:15  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
198 2021-07-19T10:50:15  *** dr-orlovsky <dr-orlovsky!~dr-orlovs@31.14.40.19> has quit IRC (Quit: ZNC 1.8.0 - https://znc.in)
199 2021-07-19T10:53:11  *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has joined #bitcoin-core-dev
200 2021-07-19T10:53:16  *** grettke is now known as grettke-away
201 2021-07-19T10:56:20  *** grettke-away is now known as grettke
202 2021-07-19T10:57:10  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has joined #bitcoin-core-dev
203 2021-07-19T11:01:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
204 2021-07-19T11:01:10  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22493: fuzz: Extend addrman fuzz test with deserialize (master...2107-fuzzAddrDeser) https://github.com/bitcoin/bitcoin/pull/22493
205 2021-07-19T11:01:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
206 2021-07-19T11:02:12  <jnewbery> vasild: in 22112, is there anything stopping peers from gossipping non-port 0 I2P addresses to us? Will those addresses be entered into our addrman?
207 2021-07-19T11:08:01  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
208 2021-07-19T11:13:19  <michaelfolkson> fanquake robertspigler: Added a StackExchange post for the discussion of Guix within Gitian. Happy to edit/take it down if you don't want it up https://bitcoin.stackexchange.com/questions/107638/whats-the-purpose-of-using-guix-within-gitian-doesnt-that-reintroduce-depende/
209 2021-07-19T11:17:40  <laanwj> IIRC nothing is stopping peers from gossiping non-port 0 I2P addresses, they will get stored (but not connected to, until our I2P SAM support supports non-zero ports, or other software that does). After next start (when CAddrMan::ResetI2PPorts is invoked) the ports will be changed to 0. That's meant to be a temporary measure.
210 2021-07-19T11:19:50  <laanwj> I sometimes wonder if ResetI2PPorts is needed at all--I mean, the amount of I2P peers that has already been gossipped is bound to be very low, peers will broadcast the new port after upgrading, the old ones will drop from the database at some point
211 2021-07-19T11:20:11  <laanwj> the old behavior has never been in a release
212 2021-07-19T11:22:08  *** naiza <naiza!~naiza@180.188.251.163> has quit IRC (Ping timeout: 252 seconds)
213 2021-07-19T11:24:07  <jonatack> It was needed to continue making outbound connections to existing I2P peers with port 8333 in the addrman, which otherwise can no longer be connected to nor (afaik) manually removed from the addrman.  The alternative would be for the existing 20-30 peers that have run an I2P service to delete their peers.dat
214 2021-07-19T11:25:12  <vasild> emzy: great! you may also want to pick up https://github.com/bitcoin/bitcoin/pull/22471
215 2021-07-19T11:25:14  <jonatack> or to have all upgraded to current master and restarted, so that ResetI2PPorts() can then be removed before 22.0 instead of at some point afterward
216 2021-07-19T11:25:37  <jonatack> as it was planned to be a transitory measure
217 2021-07-19T11:25:58  <laanwj> right
218 2021-07-19T11:26:30  <jonatack> (I considered adding a hidden RPC to manually remove addresses from addrman, but that seems like an unneeded attack vector)
219 2021-07-19T11:27:03  <vasild> yeah, I don't have a strong opinion but removing ResetI2PPorts() from final 22.0 looks plausible
220 2021-07-19T11:27:55  <laanwj> if it's a one-time upgrade, some versioning mechanism that runs it only once (instead of every node start) would make sense, that said, not having it end up in a release at all would maybe be best
221 2021-07-19T11:28:03  <jonatack> seems most prudent
222 2021-07-19T11:28:05  <fanquake> I'm not yet caught up on the all new addrman brokenness, but surely we shouldn't be writing code to compensate for code that was already broken when added to master.
223 2021-07-19T11:28:13  <fanquake> All the bugs should be fixed, and anyone running master just needs to update, delete their peers.dat / whatever. It's not like there is  any significant amount of people actually using i2p yet.
224 2021-07-19T11:28:41  <laanwj> fanquake: right
225 2021-07-19T11:28:57  <fanquake> Working around broken code in master so as not to inconvinience a minority that are running pre-production software seems backwards .
226 2021-07-19T11:29:41  <jonatack> istm they need to all delete peers.dat (or upgrade to current master first) though
227 2021-07-19T11:29:42  <laanwj> could even add a release note, though there may be better ways of reaching the few people who test I2P with bitcoin core master
228 2021-07-19T11:30:26  <jonatack> yes, i know who all of them are except the bitcorn one
229 2021-07-19T11:30:37  <laanwj> in any case it's complciated a bit by having ResetI2PPorts in master as well... like, eveyrone who ran master *in between* that function being added and re moved will not need to remove peers.dat :)
230 2021-07-19T11:31:13  <jonatack> right :)
231 2021-07-19T11:34:20  <vasild> I like solving problems by deleting code :) especially if the code looks risky/hackish and especially if I wrote it ;)
232 2021-07-19T11:35:06  <laanwj> vasild: agree, glad you're ok with it
233 2021-07-19T11:35:49  <vasild> ok, should we leave master for some more time with ResetI2PPorts() or remove it immediately?
234 2021-07-19T11:36:55  <laanwj> we could have a PR and merge it as last thing before the branch-off
235 2021-07-19T11:37:15  <laanwj> but I imagine that's going to be soon
236 2021-07-19T11:37:53  <laanwj> with #22387 merged and the I2P addrman issues solved I don't think there's any blockers left?
237 2021-07-19T11:37:56  <gribble> https://github.com/bitcoin/bitcoin/issues/22387 | Rate limit the processing of rumoured addresses by sipa · Pull Request #22387 · bitcoin/bitcoin · GitHub
238 2021-07-19T11:38:47  <laanwj> this would replace both #22471 and #22468
239 2021-07-19T11:38:48  <gribble> https://github.com/bitcoin/bitcoin/issues/22471 | addrman: reset I2P ports in all "new" buckets by vasild · Pull Request #22471 · bitcoin/bitcoin · GitHub
240 2021-07-19T11:38:49  <gribble> https://github.com/bitcoin/bitcoin/issues/22468 | addrman: dont overwrite addr_info when resetting I2P ports by vasild · Pull Request #22468 · bitcoin/bitcoin · GitHub
241 2021-07-19T11:39:24  <laanwj> but not  #22455
242 2021-07-19T11:39:25  <gribble> https://github.com/bitcoin/bitcoin/issues/22455 | addrman: detect on-disk corrupted nNew and nTried during unserialization by vasild · Pull Request #22455 · bitcoin/bitcoin · GitHub
243 2021-07-19T11:40:50  <jonatack> right
244 2021-07-19T11:41:47  <MarcoFalke> Wouldn't #22465 need to go in before rc1?
245 2021-07-19T11:41:48  <gribble> https://github.com/bitcoin/bitcoin/issues/22465 | guix: Pin kernel-header version, time-machine to upstream 1.3.0 commit by dongcarl · Pull Request #22465 · bitcoin/bitcoin · GitHub
246 2021-07-19T11:42:02  <laanwj> MarcoFalke: yes
247 2021-07-19T11:43:51  <laanwj> though I am honestly not sure how much of a difference it makes in practice; kernel version dependency is generally an issue for static linking of libc
248 2021-07-19T11:44:21  <laanwj> libc is supposed to abstract the kernel details from the application; but this might be leaky in some cases
249 2021-07-19T11:47:32  <laanwj> (for example when the application, or one of the statically linked libraries, manually invokes syscalls without handling the non-present case)
250 2021-07-19T11:47:49  <jonatack> can open the pull
251 2021-07-19T11:47:49  <laanwj> i don't think this is the case for us but...
252 2021-07-19T11:48:30  <jonatack> (vasild: can open the pull)
253 2021-07-19T11:49:38  <vasild> yes, I will shortly
254 2021-07-19T11:51:27  *** orionwl[m] <orionwl[m]!~orionwlx0@2001:470:69fc:105::80> has quit IRC (Quit: Bridge terminating on SIGTERM)
255 2021-07-19T11:51:27  *** robertspigler <robertspigler!~robertspi@2001:470:69fc:105::2d53> has quit IRC (Quit: Bridge terminating on SIGTERM)
256 2021-07-19T11:51:27  *** merkle_noob[m] <merkle_noob[m]!~merklenoo@2001:470:69fc:105::bad0> has quit IRC (Quit: Bridge terminating on SIGTERM)
257 2021-07-19T11:51:28  *** mrjumper[m] <mrjumper[m]!~mr-jumper@2001:470:69fc:105::7f1> has quit IRC (Quit: Bridge terminating on SIGTERM)
258 2021-07-19T11:51:28  *** prusnak[m] <prusnak[m]!~stickmatr@2001:470:69fc:105::98c> has quit IRC (Quit: Bridge terminating on SIGTERM)
259 2021-07-19T11:51:28  *** RCasatta[m] <RCasatta[m]!~rcasattam@2001:470:69fc:105::c85> has quit IRC (Quit: Bridge terminating on SIGTERM)
260 2021-07-19T11:51:28  *** Enki[m] <Enki[m]!~enkimatri@2001:470:69fc:105::382c> has quit IRC (Quit: Bridge terminating on SIGTERM)
261 2021-07-19T11:51:28  *** cdecker[m] <cdecker[m]!~cdeckerma@2001:470:69fc:105::2e8e> has quit IRC (Quit: Bridge terminating on SIGTERM)
262 2021-07-19T11:51:28  *** vasanth2[m] <vasanth2[m]!~vasanth2m@2001:470:69fc:105::3548> has quit IRC (Quit: Bridge terminating on SIGTERM)
263 2021-07-19T11:51:28  *** eli[m] <eli[m]!~elinixbit@2001:470:69fc:105::ba64> has quit IRC (Quit: Bridge terminating on SIGTERM)
264 2021-07-19T11:51:28  *** prayank[m] <prayank[m]!~prayankni@2001:470:69fc:105::ba63> has quit IRC (Quit: Bridge terminating on SIGTERM)
265 2021-07-19T11:51:28  *** M0xb10c[m] <M0xb10c[m]!~M0xb10cni@2001:470:69fc:105::bac4> has quit IRC (Quit: Bridge terminating on SIGTERM)
266 2021-07-19T11:51:28  *** poucatreta[m] <poucatreta[m]!~poucatret@2001:470:69fc:105::20ae> has quit IRC (Quit: Bridge terminating on SIGTERM)
267 2021-07-19T11:51:28  *** vhs43[m] <vhs43[m]!~vhs43matr@2001:470:69fc:105::ba6d> has quit IRC (Quit: Bridge terminating on SIGTERM)
268 2021-07-19T11:51:28  *** kvaciral[m] <kvaciral[m]!~kvaciralx@2001:470:69fc:105::17b> has quit IRC (Quit: Bridge terminating on SIGTERM)
269 2021-07-19T11:51:28  *** tutwidi[m] <tutwidi[m]!~tutwidima@2001:470:69fc:105::ead> has quit IRC (Quit: Bridge terminating on SIGTERM)
270 2021-07-19T11:51:28  *** vincenzopalazzo <vincenzopalazzo!~vincenzop@2001:470:69fc:105::a67> has quit IRC (Quit: Bridge terminating on SIGTERM)
271 2021-07-19T11:51:28  *** devrandom <devrandom!~devrandom@2001:470:69fc:105::d4d> has quit IRC (Quit: Bridge terminating on SIGTERM)
272 2021-07-19T11:53:49  *** orionwl[m] <orionwl[m]!~orionwlx0@2001:470:69fc:105::80> has joined #bitcoin-core-dev
273 2021-07-19T11:55:14  *** vincenzopalazzo <vincenzopalazzo!~vincenzop@2001:470:69fc:105::a67> has joined #bitcoin-core-dev
274 2021-07-19T11:55:15  *** devrandom <devrandom!~devrandom@2001:470:69fc:105::d4d> has joined #bitcoin-core-dev
275 2021-07-19T11:55:15  *** prusnak[m] <prusnak[m]!~stickmatr@2001:470:69fc:105::98c> has joined #bitcoin-core-dev
276 2021-07-19T11:55:15  *** robertspigler <robertspigler!~robertspi@2001:470:69fc:105::2d53> has joined #bitcoin-core-dev
277 2021-07-19T11:55:15  *** merkle_noob[m] <merkle_noob[m]!~merklenoo@2001:470:69fc:105::bad0> has joined #bitcoin-core-dev
278 2021-07-19T11:55:15  *** eli[m] <eli[m]!~elinixbit@2001:470:69fc:105::ba64> has joined #bitcoin-core-dev
279 2021-07-19T11:55:26  *** mrjumper[m] <mrjumper[m]!~mr-jumper@2001:470:69fc:105::7f1> has joined #bitcoin-core-dev
280 2021-07-19T11:55:26  *** vasanth2[m] <vasanth2[m]!~vasanth2m@2001:470:69fc:105::3548> has joined #bitcoin-core-dev
281 2021-07-19T11:55:26  *** Enki[m] <Enki[m]!~enkimatri@2001:470:69fc:105::382c> has joined #bitcoin-core-dev
282 2021-07-19T11:55:26  *** vhs43[m] <vhs43[m]!~vhs43matr@2001:470:69fc:105::ba6d> has joined #bitcoin-core-dev
283 2021-07-19T11:55:26  *** poucatreta[m] <poucatreta[m]!~poucatret@2001:470:69fc:105::20ae> has joined #bitcoin-core-dev
284 2021-07-19T11:55:27  *** tutwidi[m] <tutwidi[m]!~tutwidima@2001:470:69fc:105::ead> has joined #bitcoin-core-dev
285 2021-07-19T11:55:27  *** cdecker[m] <cdecker[m]!~cdeckerma@2001:470:69fc:105::2e8e> has joined #bitcoin-core-dev
286 2021-07-19T11:55:27  *** M0xb10c[m] <M0xb10c[m]!~M0xb10cni@2001:470:69fc:105::bac4> has joined #bitcoin-core-dev
287 2021-07-19T11:55:27  *** kvaciral[m] <kvaciral[m]!~kvaciralx@2001:470:69fc:105::17b> has joined #bitcoin-core-dev
288 2021-07-19T11:55:27  *** RCasatta[m] <RCasatta[m]!~rcasattam@2001:470:69fc:105::c85> has joined #bitcoin-core-dev
289 2021-07-19T11:55:28  *** prayank[m] <prayank[m]!~prayankni@2001:470:69fc:105::ba63> has joined #bitcoin-core-dev
290 2021-07-19T12:03:34  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has quit IRC (Ping timeout: 252 seconds)
291 2021-07-19T12:05:47  *** piku <piku!~piku@47.202.125.123> has joined #bitcoin-core-dev
292 2021-07-19T12:14:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
293 2021-07-19T12:14:11  <bitcoin-git> [bitcoin] theStack opened pull request #22495: p2p: refactor: tidy up `PeerManagerImpl::Misbehaving(...)` (master...202107-net-tidy_up_misbehaving) https://github.com/bitcoin/bitcoin/pull/22495
294 2021-07-19T12:14:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
295 2021-07-19T12:16:39  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has joined #bitcoin-core-dev
296 2021-07-19T12:21:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
297 2021-07-19T12:21:30  <bitcoin-git> [bitcoin] jnewbery opened pull request #22496: [addrman] Remove RemoveInvalid() and ResetI2PPorts() (master...2021-07-remove-addrman-hotfix) https://github.com/bitcoin/bitcoin/pull/22496
298 2021-07-19T12:21:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
299 2021-07-19T12:21:35  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has quit IRC (Ping timeout: 268 seconds)
300 2021-07-19T12:26:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
301 2021-07-19T12:26:49  <bitcoin-git> [bitcoin] vasild opened pull request #22497: scripted-diff: remove ResetI2PPorts() (revert e0a2b390c14) (master...remove_ResetI2PPorts) https://github.com/bitcoin/bitcoin/pull/22497
302 2021-07-19T12:26:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
303 2021-07-19T12:27:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
304 2021-07-19T12:27:49  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d3474b8df2f9...54e31742d208
305 2021-07-19T12:27:49  <bitcoin-git> bitcoin/master 816f29e Vasil Dimov: addrman: detect on-disk corrupted nNew and nTried during unserialization
306 2021-07-19T12:27:49  <bitcoin-git> bitcoin/master 54e3174 MarcoFalke: Merge bitcoin/bitcoin#22455: addrman: detect on-disk corrupted nNew and nT...
307 2021-07-19T12:27:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
308 2021-07-19T12:28:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
309 2021-07-19T12:28:06  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22455: addrman: detect on-disk corrupted nNew and nTried during unserialization (master...addrman_detect_negative) https://github.com/bitcoin/bitcoin/pull/22455
310 2021-07-19T12:28:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
311 2021-07-19T12:32:27  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.157> has joined #bitcoin-core-dev
312 2021-07-19T12:35:39  *** lightlike <lightlike!~lightlike@user/lightlike> has joined #bitcoin-core-dev
313 2021-07-19T12:36:49  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.157> has quit IRC (Ping timeout: 246 seconds)
314 2021-07-19T12:49:05  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has joined #bitcoin-core-dev
315 2021-07-19T12:53:59  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.217> has quit IRC (Ping timeout: 268 seconds)
316 2021-07-19T12:55:13  *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has quit IRC (Ping timeout: 268 seconds)
317 2021-07-19T13:01:49  *** grettke <grettke!~grettke@2605:a000:bfc0:6:8139:caa:65c0:6ba8> has joined #bitcoin-core-dev
318 2021-07-19T13:05:51  *** instagibbs <instagibbs!~instagibb@119247204116.ctinets.com> has quit IRC (Ping timeout: 255 seconds)
319 2021-07-19T13:06:08  *** instagibbs <instagibbs!~instagibb@45.128.36.162> has joined #bitcoin-core-dev
320 2021-07-19T13:07:22  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.216> has joined #bitcoin-core-dev
321 2021-07-19T13:10:49  *** Bilnon <Bilnon!~8iIn0n@2a01:4b00:8e07:7900:86dd:c745:c933:bc6a> has quit IRC (Quit: Leaving)
322 2021-07-19T13:11:53  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.216> has quit IRC (Ping timeout: 255 seconds)
323 2021-07-19T13:14:37  *** kiran <kiran!~kiran@218.185.248.66> has quit IRC (Ping timeout: 246 seconds)
324 2021-07-19T13:24:18  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has joined #bitcoin-core-dev
325 2021-07-19T13:26:22  *** sebx2a <sebx2a!sid356034@id-356034.highgate.irccloud.com> has quit IRC ()
326 2021-07-19T13:26:36  *** sebx2a <sebx2a!sid356034@id-356034.highgate.irccloud.com> has joined #bitcoin-core-dev
327 2021-07-19T13:29:15  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has quit IRC (Ping timeout: 255 seconds)
328 2021-07-19T13:40:43  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.157> has joined #bitcoin-core-dev
329 2021-07-19T13:43:35  *** grettke <grettke!~grettke@2605:a000:bfc0:6:8139:caa:65c0:6ba8> has quit IRC (Ping timeout: 252 seconds)
330 2021-07-19T13:44:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
331 2021-07-19T13:44:20  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22498: Check that CAddrMan::m_key is not null after deserialize (master...2107-addrmanKeyZero) https://github.com/bitcoin/bitcoin/pull/22498
332 2021-07-19T13:44:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
333 2021-07-19T13:45:19  *** AaronvanW <AaronvanW!~AaronvanW@178.239.167.157> has quit IRC (Ping timeout: 258 seconds)
334 2021-07-19T13:46:42  <MarcoFalke> Should addrman related pull requests be tagged with "p2p"?
335 2021-07-19T13:47:26  *** instagibbs <instagibbs!~instagibb@45.128.36.162> has quit IRC (Ping timeout: 255 seconds)
336 2021-07-19T13:52:58  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
337 2021-07-19T13:54:27  *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has joined #bitcoin-core-dev
338 2021-07-19T13:55:44  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 265 seconds)
339 2021-07-19T13:55:48  *** Guyver2_ is now known as Guyver2
340 2021-07-19T13:56:55  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has joined #bitcoin-core-dev
341 2021-07-19T14:02:06  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.218> has quit IRC (Ping timeout: 268 seconds)
342 2021-07-19T14:02:08  *** instagibbs <instagibbs!~instagibb@119247204116.ctinets.com> has joined #bitcoin-core-dev
343 2021-07-19T14:10:12  <laanwj> I think so, yes
344 2021-07-19T14:10:32  <MarcoFalke> ok, adjusting DrahtBot to do so
345 2021-07-19T14:14:26  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.216> has joined #bitcoin-core-dev
346 2021-07-19T14:16:01  *** Guest9039 <Guest9039!~Guest90@pool-70-106-180-198.clppva.fios.verizon.net> has joined #bitcoin-core-dev
347 2021-07-19T14:16:09  <MarcoFalke> Done: https://github.com/bitcoin/bitcoin/pull/22498#event-5038754615
348 2021-07-19T14:16:17  <laanwj> thanks!
349 2021-07-19T14:17:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
350 2021-07-19T14:17:56  <bitcoin-git> [bitcoin] sriramdvt opened pull request #22499: Update assumed chain params (master...update_chainparams) https://github.com/bitcoin/bitcoin/pull/22499
351 2021-07-19T14:17:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
352 2021-07-19T14:19:01  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.216> has quit IRC (Ping timeout: 246 seconds)
353 2021-07-19T14:23:08  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.216> has joined #bitcoin-core-dev
354 2021-07-19T14:27:05  *** Guest9039 <Guest9039!~Guest90@pool-70-106-180-198.clppva.fios.verizon.net> has quit IRC (Quit: Ping timeout (120 seconds))
355 2021-07-19T14:51:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
356 2021-07-19T14:51:47  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22500: Assert in CAddrMan::Check() (master...2107-addrmanCheckAssert) https://github.com/bitcoin/bitcoin/pull/22500
357 2021-07-19T14:51:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
358 2021-07-19T14:56:53  *** josibake <josibake!sid509132@id-509132.brockwell.irccloud.com> has joined #bitcoin-core-dev
359 2021-07-19T15:00:30  *** Guest9080 <Guest9080!~Guest90@pool-70-106-180-198.clppva.fios.verizon.net> has joined #bitcoin-core-dev
360 2021-07-19T15:00:31  *** Guest9080 <Guest9080!~Guest90@pool-70-106-180-198.clppva.fios.verizon.net> has quit IRC (Client Quit)
361 2021-07-19T15:01:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
362 2021-07-19T15:01:20  <bitcoin-git> [bitcoin] jonatack opened pull request #22501: cli: add new address statistics to -netinfo (master...netinfo-addr-statistics) https://github.com/bitcoin/bitcoin/pull/22501
363 2021-07-19T15:01:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
364 2021-07-19T15:13:05  *** grettke is now known as grettke-away
365 2021-07-19T15:20:48  *** johnpc <johnpc!~johnpc@c-68-42-75-183.hsd1.mi.comcast.net> has joined #bitcoin-core-dev
366 2021-07-19T15:27:26  *** AaronvanW <AaronvanW!~AaronvanW@178.239.173.216> has quit IRC (Ping timeout: 252 seconds)
367 2021-07-19T15:29:33  *** AaronvanW <AaronvanW!~AaronvanW@209.235.170.242> has joined #bitcoin-core-dev
368 2021-07-19T15:32:57  <josibake> for anyone who's interested, #22235 (automatic generation of example bitcoin.conf) is ready for review
369 2021-07-19T15:32:59  <gribble> https://github.com/bitcoin/bitcoin/issues/22235 | script: add script to generate example bitcoin.conf by josibake · Pull Request #22235 · bitcoin/bitcoin · GitHub
370 2021-07-19T15:37:51  *** johnpc <johnpc!~johnpc@c-68-42-75-183.hsd1.mi.comcast.net> has quit IRC (Quit: johnpc)
371 2021-07-19T15:42:08  <dergoegge> is anyone aware of `sendrawtransaction` being used in the way that gleb mentioned here: https://github.com/bitcoin/bitcoin/pull/22340#issuecomment-875542706 ?
372 2021-07-19T15:43:10  *** user__ <user__!~davterra@143.244.186.214> has quit IRC (Quit: Leaving)
373 2021-07-19T15:48:23  *** AaronvanW <AaronvanW!~AaronvanW@209.235.170.242> has quit IRC (Remote host closed the connection)
374 2021-07-19T15:50:34  *** pncl <pncl!~pncl___@5.245.211.197> has joined #bitcoin-core-dev
375 2021-07-19T15:52:49  *** Jaamg <Jaamg!jaamg@kapsi.fi> has quit IRC (Ping timeout: 268 seconds)
376 2021-07-19T15:52:56  *** Jaamg <Jaamg!jaamg@kapsi.fi> has joined #bitcoin-core-dev
377 2021-07-19T15:56:06  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-acff-de01-3c77-7564.res6.spectrum.com> has joined #bitcoin-core-dev
378 2021-07-19T15:58:00  *** AaronvanW <AaronvanW!~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net> has joined #bitcoin-core-dev
379 2021-07-19T16:18:49  <jarolrod> MarcoFalke: circling back on drahtbot and updating it to label addrman changed `P2P`. Maybe it also should remove the `Needs Guix Build` label when it posts its guix build. We still want people to run a guix build and compare hashes right?
380 2021-07-19T16:19:03  <jarolrod> ^ should not remove
381 2021-07-19T16:19:11  *** johnpc <johnpc!~johnpc@c-68-42-75-183.hsd1.mi.comcast.net> has joined #bitcoin-core-dev
382 2021-07-19T16:19:44  <MarcoFalke> Anyone is free to run as many guix builds as they wish
383 2021-07-19T16:20:05  <MarcoFalke> Not sure if we should use the label to indicate *someone* (other than DrahtBot) should run the build
384 2021-07-19T16:20:25  <hebasto> ^ yeah :)
385 2021-07-19T16:20:33  <jarolrod> oh ok i see, it's for drahtbot
386 2021-07-19T16:21:04  <MarcoFalke> I guess DrahtBot could use "Build" as label to create a guix build
387 2021-07-19T16:21:27  <MarcoFalke> Not sure if it will be fast enough to keep up, though
388 2021-07-19T16:21:44  <MarcoFalke> It is running on half a core (one thread)
389 2021-07-19T16:21:57  <jarolrod> that's ok, no need for change then
390 2021-07-19T16:23:51  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
391 2021-07-19T16:30:08  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
392 2021-07-19T16:30:20  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
393 2021-07-19T16:46:01  *** grettke-away is now known as grettke
394 2021-07-19T16:46:31  *** grettke is now known as grettke-away
395 2021-07-19T16:52:04  *** grettke-away is now known as grettke
396 2021-07-19T17:00:56  *** johnpc <johnpc!~johnpc@c-68-42-75-183.hsd1.mi.comcast.net> has quit IRC (Ping timeout: 268 seconds)
397 2021-07-19T17:05:17  *** davterra <davterra!~davterra@143.244.186.214> has joined #bitcoin-core-dev
398 2021-07-19T17:14:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
399 2021-07-19T17:14:00  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22502: scripted-diff: Revert "fuzz: Add Temporary debug assert for oss-fuzz issue" (master...2107-fuzzTempRevert) https://github.com/bitcoin/bitcoin/pull/22502
400 2021-07-19T17:14:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
401 2021-07-19T17:23:02  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 245 seconds)
402 2021-07-19T17:34:33  *** AaronvanW <AaronvanW!~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net> has quit IRC (Remote host closed the connection)
403 2021-07-19T17:35:21  *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
404 2021-07-19T17:50:06  *** Guest62 <Guest62!~Guest62@210.14.100.70> has joined #bitcoin-core-dev
405 2021-07-19T17:51:00  *** Guest62 <Guest62!~Guest62@210.14.100.70> has quit IRC (Client Quit)
406 2021-07-19T17:54:49  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
407 2021-07-19T17:59:28  *** user__ <user__!~davterra@178.128.106.205> has joined #bitcoin-core-dev
408 2021-07-19T18:01:22  *** davterra <davterra!~davterra@143.244.186.214> has quit IRC (Ping timeout: 256 seconds)
409 2021-07-19T18:02:48  *** pncl <pncl!~pncl___@5.245.211.197> has quit IRC (Quit: Leaving)
410 2021-07-19T18:03:11  *** pncl <pncl!~pncl___@5.245.211.197> has joined #bitcoin-core-dev
411 2021-07-19T18:04:18  *** pncl <pncl!~pncl___@5.245.211.197> has quit IRC (Remote host closed the connection)
412 2021-07-19T18:04:51  *** pncl <pncl!~pncl___@5.245.211.197> has joined #bitcoin-core-dev
413 2021-07-19T18:05:05  *** AaronvanW <AaronvanW!~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net> has joined #bitcoin-core-dev
414 2021-07-19T18:10:20  *** AaronvanW <AaronvanW!~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net> has quit IRC (Ping timeout: 268 seconds)
415 2021-07-19T18:15:48  *** Guest85 <Guest85!~Guest85@1-14-107-185.static.kviknet.dk> has joined #bitcoin-core-dev
416 2021-07-19T18:16:38  <Guest85> Hey guys! I'm new here, just a quick question?
417 2021-07-19T18:17:15  *** user__ <user__!~davterra@178.128.106.205> has quit IRC (Ping timeout: 255 seconds)
418 2021-07-19T18:25:59  <laanwj> i guess we could rename the label to something like Drahtbot: GUIX build, if that's more clear
419 2021-07-19T18:28:01  *** Guest85 <Guest85!~Guest85@1-14-107-185.static.kviknet.dk> has quit IRC (Quit: Client closed)
420 2021-07-19T18:28:20  <laanwj> i understand the confusion because the other 'needs...' labels imply a contributor has to do something
421 2021-07-19T18:29:05  <sipa> drahtbuild-requested
422 2021-07-19T18:29:56  <jarolrod> ^^ I had been using that label to find pr's that need a guix build done :)
423 2021-07-19T18:40:03  *** AaronvanW <AaronvanW!~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net> has joined #bitcoin-core-dev
424 2021-07-19T18:40:30  *** Alexandme <Alexandme!~Alexandme@31.4.207.203> has joined #bitcoin-core-dev
425 2021-07-19T18:42:58  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
426 2021-07-19T18:45:05  *** Alexandme <Alexandme!~Alexandme@31.4.207.203> has quit IRC (Ping timeout: 258 seconds)
427 2021-07-19T18:45:09  *** AaronvanW <AaronvanW!~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net> has quit IRC (Ping timeout: 255 seconds)
428 2021-07-19T19:02:00  <MarcoFalke> Sure, will rename
429 2021-07-19T19:25:36  *** pncl <pncl!~pncl___@5.245.211.197> has quit IRC (Quit: Leaving)
430 2021-07-19T19:37:34  *** AaronvanW <AaronvanW!~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net> has joined #bitcoin-core-dev
431 2021-07-19T19:40:18  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 240 seconds)
432 2021-07-19T19:44:00  *** AaronvanW <AaronvanW!~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net> has quit IRC (Remote host closed the connection)
433 2021-07-19T19:44:38  *** AaronvanW <AaronvanW!~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net> has joined #bitcoin-core-dev
434 2021-07-19T19:59:26  *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has joined #bitcoin-core-dev
435 2021-07-19T20:23:52  <jonatack> fwiw seeing 4 new I2P addresses since a few hours ago and 5 inbound I2Ps advertising port 8333 (running with marco's ADDRMAN_DEBUG assert branch)
436 2021-07-19T20:24:18  <jonatack> s/running/i am running/
437 2021-07-19T20:24:21  *** hex17or <hex17or!~hex17or@gateway/tor-sasl/hex17or> has quit IRC (Ping timeout: 244 seconds)
438 2021-07-19T20:26:13  *** hex17or <hex17or!~hex17or@gateway/tor-sasl/hex17or> has joined #bitcoin-core-dev
439 2021-07-19T20:29:36  *** davterra <davterra!~davterra@178.128.106.205> has joined #bitcoin-core-dev
440 2021-07-19T20:54:35  *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
441 2021-07-19T20:55:21  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 244 seconds)
442 2021-07-19T20:55:52  *** jarthur_ <jarthur_!~jarthur@2603-8080-1540-002d-c49d-5e9c-d3a7-cf1f.res6.spectrum.com> has joined #bitcoin-core-dev
443 2021-07-19T20:58:42  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-acff-de01-3c77-7564.res6.spectrum.com> has quit IRC (Ping timeout: 240 seconds)
444 2021-07-19T21:00:52  *** grettke is now known as grettke-away
445 2021-07-19T21:03:20  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
446 2021-07-19T21:08:42  *** jarthur_ <jarthur_!~jarthur@2603-8080-1540-002d-c49d-5e9c-d3a7-cf1f.res6.spectrum.com> has quit IRC (Ping timeout: 255 seconds)
447 2021-07-19T21:12:40  *** grettke-away <grettke-away!~grettke@cpe-65-29-228-30.wi.res.rr.com> has quit IRC (Ping timeout: 265 seconds)
448 2021-07-19T21:16:23  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-8911-e5b6-6ab4-72d3.res6.spectrum.com> has joined #bitcoin-core-dev
449 2021-07-19T21:45:15  *** lightlike <lightlike!~lightlike@user/lightlike> has quit IRC (Quit: Leaving)
450 2021-07-19T21:57:11  *** ufotofu_ <ufotofu_!~ufotofu@user/ufotofu> has left #bitcoin-core-dev (WeeChat 2.7.1)
451 2021-07-19T22:00:56  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
452 2021-07-19T22:10:18  <jonatack> never mind about the port 8333 part; i had not noticed that the ADDRMAN_DEBUG assert branch was before the I2P Port 0 merge...rebased, rebuilt, restarted, no inbound I2Ps with port 8333 -> to bed
453 2021-07-19T22:12:02  *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has joined #bitcoin-core-dev
454 2021-07-19T22:26:09  <dhruv> btc-irc
455 2021-07-19T22:27:02  <dhruv> whoops, gotta be careful. sorry.
456 2021-07-19T22:31:20  *** AaronvanW <AaronvanW!~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net> has quit IRC (Remote host closed the connection)
457 2021-07-19T22:34:59  *** grettke is now known as grettke-away
458 2021-07-19T22:39:49  *** AaronvanW <AaronvanW!~AaronvanW@209.235.170.242> has joined #bitcoin-core-dev
459 2021-07-19T22:43:03  *** Ge0g3 <Ge0g3!~Geoge@2a02:c7f:aead:e900:c15d:3f7:c2ca:c564> has quit IRC (Remote host closed the connection)
460 2021-07-19T22:43:03  *** Ge0ge <Ge0ge!~Geoge@2a02:c7f:aead:e900:c15d:3f7:c2ca:c564> has quit IRC (Remote host closed the connection)
461 2021-07-19T22:43:21  *** Ge0ge <Ge0ge!~Geoge@2a02:c7f:aead:e900:ff42:84f:3162:e0d3> has joined #bitcoin-core-dev
462 2021-07-19T22:43:22  *** Ge0g3 <Ge0g3!~Geoge@2a02:c7f:aead:e900:ff42:84f:3162:e0d3> has joined #bitcoin-core-dev
463 2021-07-19T22:43:29  *** Geoge <Geoge!~Geoge@2a02:c7f:aead:e900:c15d:3f7:c2ca:c564> has quit IRC (Remote host closed the connection)
464 2021-07-19T22:43:46  *** Geoge <Geoge!~Geoge@2a02:c7f:aead:e900:ff42:84f:3162:e0d3> has joined #bitcoin-core-dev
465 2021-07-19T22:48:08  *** emcy <emcy!~emcy@user/emcy> has quit IRC (Quit: Leaving)
466 2021-07-19T22:54:42  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 245 seconds)
467 2021-07-19T22:57:48  *** hex17or <hex17or!~hex17or@gateway/tor-sasl/hex17or> has quit IRC (Ping timeout: 244 seconds)
468 2021-07-19T23:08:43  *** emcy <emcy!~emcy@user/emcy> has joined #bitcoin-core-dev
469 2021-07-19T23:18:45  *** lukedashjr <lukedashjr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
470 2021-07-19T23:19:33  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 258 seconds)
471 2021-07-19T23:20:14  *** vysn <vysn!~vysn@user/vysn> has quit IRC (Remote host closed the connection)
472 2021-07-19T23:20:22  *** lukedashjr is now known as luke-jr
473 2021-07-19T23:28:13  *** kexkey <kexkey!~kexkey@static-198-54-132-135.cust.tzulo.com> has joined #bitcoin-core-dev
474 2021-07-19T23:29:38  *** Aaronvan_ <Aaronvan_!~AaronvanW@159.48.55.175> has joined #bitcoin-core-dev
475 2021-07-19T23:33:18  *** grettke-away is now known as grettke
476 2021-07-19T23:33:18  *** kexkey <kexkey!~kexkey@static-198-54-132-135.cust.tzulo.com> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
477 2021-07-19T23:33:20  *** AaronvanW <AaronvanW!~AaronvanW@209.235.170.242> has quit IRC (Ping timeout: 255 seconds)
478 2021-07-19T23:34:31  *** kexkey <kexkey!~kexkey@static-198-54-132-135.cust.tzulo.com> has joined #bitcoin-core-dev
479 2021-07-19T23:38:46  *** kexkey <kexkey!~kexkey@static-198-54-132-135.cust.tzulo.com> has quit IRC (Ping timeout: 252 seconds)
480 2021-07-19T23:39:33  *** kexkey <kexkey!~kexkey@dsl-173-206-97-88.tor.primus.ca> has joined #bitcoin-core-dev
481 2021-07-19T23:45:52  *** kexkey <kexkey!~kexkey@dsl-173-206-97-88.tor.primus.ca> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
482 2021-07-19T23:47:38  *** kexkey <kexkey!~kexkey@dsl-173-206-97-88.tor.primus.ca> has joined #bitcoin-core-dev
483 2021-07-19T23:51:28  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
484 2021-07-19T23:56:25  *** belcher_ <belcher_!~belcher@user/belcher> has joined #bitcoin-core-dev
485 2021-07-19T23:59:54  *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 265 seconds)