12021-09-08T00:02:02 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Quit: Client closed)
22021-09-08T00:02:17 *** stevenroose <stevenroose!~steven@irc.roose.io> has quit IRC (Quit: ZNC 1.7.4 - https://znc.in)
32021-09-08T00:02:33 *** stevenroose <stevenroose!~steven@irc.roose.io> has joined #bitcoin-core-dev
42021-09-08T00:16:51 *** belcher_ <belcher_!~belcher@user/belcher> has joined #bitcoin-core-dev
52021-09-08T00:20:26 *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 252 seconds)
62021-09-08T00:26:58 *** b10c <b10c!uid500648@id-500648.ilkley.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
72021-09-08T00:42:29 *** earnestly <earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 252 seconds)
82021-09-08T00:56:24 *** Guest50 <Guest50!~Guest50@72.12.140.130> has joined #bitcoin-core-dev
92021-09-08T00:57:13 *** Guest50 <Guest50!~Guest50@72.12.140.130> has quit IRC (Client Quit)
102021-09-08T01:03:56 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 252 seconds)
112021-09-08T01:13:50 *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-b82e-8865-a976-d9c2.res6.spectrum.com> has quit IRC (Ping timeout: 252 seconds)
122021-09-08T01:26:56 *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-b453-a897-4f94-54c0.res6.spectrum.com> has joined #bitcoin-core-dev
132021-09-08T01:35:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
142021-09-08T01:35:10 <bitcoin-git> [gui] luke-jr closed pull request #230: Support backup to new text-based database dump format (master...gui_backup_formats) https://github.com/bitcoin-core/gui/pull/230
152021-09-08T01:35:11 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
162021-09-08T04:01:02 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
172021-09-08T04:01:09 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
182021-09-08T04:14:33 *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
192021-09-08T04:26:13 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
202021-09-08T05:04:10 *** jespada <jespada!~jespada@90.254.245.194> has quit IRC (Ping timeout: 240 seconds)
212021-09-08T05:05:44 *** jespada <jespada!~jespada@90.254.245.194> has joined #bitcoin-core-dev
222021-09-08T05:40:02 *** saranshsharma <saranshsharma!~saranshsh@2401:4900:120c:8155:2c35:7671:4347:733b> has joined #bitcoin-core-dev
232021-09-08T05:57:57 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
242021-09-08T06:03:07 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
252021-09-08T06:16:40 *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has joined #bitcoin-core-dev
262021-09-08T06:59:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
272021-09-08T06:59:12 <bitcoin-git> [bitcoin] fujicoin opened pull request #22913: Fix the case where the peer status is not updated (master...fix210908) https://github.com/bitcoin/bitcoin/pull/22913
282021-09-08T06:59:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
292021-09-08T07:01:11 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has quit IRC (Remote host closed the connection)
302021-09-08T07:01:29 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has joined #bitcoin-core-dev
312021-09-08T07:08:04 *** saranshsharma <saranshsharma!~saranshsh@2401:4900:120c:8155:2c35:7671:4347:733b> has quit IRC (Remote host closed the connection)
322021-09-08T07:12:14 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has joined #bitcoin-core-dev
332021-09-08T07:18:14 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
342021-09-08T07:18:15 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ecf580e40f60...7d7d5e8efde9
352021-09-08T07:18:15 <bitcoin-git> bitcoin/master facce4c MarcoFalke: test: Remove useless overwrite
362021-09-08T07:18:15 <bitcoin-git> bitcoin/master fab0b55 MarcoFalke: addrman: Fix format string in deserialize error
372021-09-08T07:18:15 <bitcoin-git> bitcoin/master 7d7d5e8 fanquake: Merge bitcoin/bitcoin#22879: addrman: Fix format string in deserialize err...
382021-09-08T07:18:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
392021-09-08T07:18:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
402021-09-08T07:18:32 <bitcoin-git> [bitcoin] fanquake merged pull request #22879: addrman: Fix format string in deserialize error (master...2109-testPeersDat) https://github.com/bitcoin/bitcoin/pull/22879
412021-09-08T07:18:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
422021-09-08T07:22:09 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has quit IRC (Remote host closed the connection)
432021-09-08T07:27:45 <vasild> Is anybody running a CJDNS node?
442021-09-08T07:32:24 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has joined #bitcoin-core-dev
452021-09-08T07:36:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
462021-09-08T07:36:00 <bitcoin-git> [bitcoin] fanquake opened pull request #22914: util: remove libevent <= 2.0.18 back-compat code (master...libevent_cleanup) https://github.com/bitcoin/bitcoin/pull/22914
472021-09-08T07:36:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
482021-09-08T07:37:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
492021-09-08T07:37:50 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22915: Remove confusing CAddrDB (master...2109-noAddrDb) https://github.com/bitcoin/bitcoin/pull/22915
502021-09-08T07:37:51 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
512021-09-08T07:39:23 *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has quit IRC (Quit: Konversation terminated!)
522021-09-08T07:41:16 *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f389600dda8b22aaea27669.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
532021-09-08T07:44:29 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
542021-09-08T07:52:55 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has quit IRC (Remote host closed the connection)
552021-09-08T07:58:15 *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has joined #bitcoin-core-dev
562021-09-08T08:14:09 *** aechu <aechu!~major@gateway/tor-sasl/major> has quit IRC (Ping timeout: 276 seconds)
572021-09-08T08:14:48 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 276 seconds)
582021-09-08T08:16:36 *** aechu <aechu!~major@gateway/tor-sasl/major> has joined #bitcoin-core-dev
592021-09-08T08:25:35 *** earnestly <earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
602021-09-08T08:29:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
612021-09-08T08:29:45 <bitcoin-git> [bitcoin] fanquake opened pull request #22916: doc: add missing copyright header to getuniquepath.cpp (master...missing_copyright_header) https://github.com/bitcoin/bitcoin/pull/22916
622021-09-08T08:29:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
632021-09-08T08:44:17 *** smartin <smartin!~Icedove@88.135.18.171> has joined #bitcoin-core-dev
642021-09-08T08:49:57 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
652021-09-08T08:58:53 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
662021-09-08T08:58:53 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7d7d5e8efde9...5e3380b9f594
672021-09-08T08:58:53 <bitcoin-git> bitcoin/master 69a439b fanquake: doc: add missing copyright header to getuniquepath.cpp
682021-09-08T08:58:53 <bitcoin-git> bitcoin/master 5e3380b MarcoFalke: Merge bitcoin/bitcoin#22916: doc: add missing copyright header to getuniqu...
692021-09-08T08:58:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
702021-09-08T08:59:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
712021-09-08T08:59:10 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22916: doc: add missing copyright header to getuniquepath.cpp (master...missing_copyright_header) https://github.com/bitcoin/bitcoin/pull/22916
722021-09-08T08:59:11 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
732021-09-08T09:01:52 *** Guest44 <Guest44!~Guest44@122.97.78.46> has joined #bitcoin-core-dev
742021-09-08T09:02:18 *** Guest44 <Guest44!~Guest44@122.97.78.46> has quit IRC (Client Quit)
752021-09-08T09:02:58 *** kexkey <kexkey!~kexkey@static-198-54-132-122.cust.tzulo.com> has quit IRC (Ping timeout: 252 seconds)
762021-09-08T09:05:27 *** kexkey <kexkey!~kexkey@static-198-54-132-90.cust.tzulo.com> has joined #bitcoin-core-dev
772021-09-08T09:25:58 *** belcher_ is now known as belcher
782021-09-08T09:26:01 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has joined #bitcoin-core-dev
792021-09-08T09:30:25 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has quit IRC (Ping timeout: 260 seconds)
802021-09-08T09:38:36 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
812021-09-08T10:17:14 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has joined #bitcoin-core-dev
822021-09-08T10:19:23 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 252 seconds)
832021-09-08T10:21:44 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has quit IRC (Ping timeout: 265 seconds)
842021-09-08T10:27:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
852021-09-08T10:27:06 <bitcoin-git> [bitcoin] hebasto opened pull request #22917: build: Copy appropriate MSVC build output to src/qt automatically (master...210908-copy) https://github.com/bitcoin/bitcoin/pull/22917
862021-09-08T10:27:07 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
872021-09-08T10:27:46 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
882021-09-08T10:32:04 *** b10c <b10c!uid500648@id-500648.ilkley.irccloud.com> has joined #bitcoin-core-dev
892021-09-08T10:37:22 <hebasto> MarcoFalke: should we in https://ci.appveyor.com/project/DrahtBot/bitcoin/settings check box "Skip branches without `appveyor.yml`" ?
902021-09-08T10:40:07 <MarcoFalke> hebasto: Maybe. Currently I can't login
912021-09-08T10:41:00 <MarcoFalke> I used up my rate limit to lock all historic pull requests to prevent spam
922021-09-08T11:10:22 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
932021-09-08T11:10:22 <bitcoin-git> [bitcoin] kiminuo opened pull request #22918: rpc: Add level 3 verbosity to getblock RPC call (#21245 modified) (master...feature/2021-09-verbose-level-3-for-getblock) https://github.com/bitcoin/bitcoin/pull/22918
942021-09-08T11:10:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
952021-09-08T11:17:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
962021-09-08T11:17:21 <bitcoin-git> [bitcoin] fanquake closed pull request #21245: rpc: Add level 3 verbosity to getblock RPC call. (master...verbosity-level-3-getblock) https://github.com/bitcoin/bitcoin/pull/21245
972021-09-08T11:17:22 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
982021-09-08T11:18:55 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
992021-09-08T11:30:11 *** ArctVaulMarsHMPJ <ArctVaulMarsHMPJ!~pjetcetal@2.95.102.85> has quit IRC (Quit: EXIT)
1002021-09-08T11:32:47 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
1012021-09-08T11:57:21 *** vysn <vysn!~vysn@user/vysn> has quit IRC (Quit: WeeChat 3.2)
1022021-09-08T11:57:37 *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
1032021-09-08T12:05:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1042021-09-08T12:05:41 <bitcoin-git> [bitcoin] RohitRanjangit opened pull request #22919: fees: skip pointless fee parameter calculation during IBD (master...lazy_update) https://github.com/bitcoin/bitcoin/pull/22919
1052021-09-08T12:05:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1062021-09-08T12:45:04 *** copumpkin <copumpkin!~woohoo@user/copumpkin> has quit IRC (Ping timeout: 252 seconds)
1072021-09-08T13:09:10 *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 260 seconds)
1082021-09-08T13:15:33 *** prayank <prayank!~andr0irc@51.158.144.31> has joined #bitcoin-core-dev
1092021-09-08T13:18:39 <prayank> debug=mempool -> debug.log -> replacing tx <original txid>
1102021-09-08T13:19:03 <prayank> Does removing this information from logs affect any functionality?
1112021-09-08T13:20:16 <sipa> no, it's a log...
1122021-09-08T13:20:22 <sipa> logs don't have functionality
1132021-09-08T13:20:36 <sipa> apart from logging what's going on
1142021-09-08T13:20:37 <laanwj> it affects the functionality of: being able to debug that functionality of the mempool by checking the logs
1152021-09-08T13:20:48 <prayank> I mean is someone using them and any projects depend on it?
1162021-09-08T13:21:05 <laanwj> i think you should start from the start, why do you want to remove it
1172021-09-08T13:21:21 <michaelfolkson> Debuggers rely on debug logs to locate bugs
1182021-09-08T13:21:29 <laanwj> exactly
1192021-09-08T13:21:49 <laanwj> it's troubleshooting information not more
1202021-09-08T13:22:55 <prayank> Privacy. I don't think others need to know about my replacement details. X replaced Y. This is not available on blockchain and a user who starts running node today won't be able to get it for past transactions. It's available for only wallet transactions using gettransaction.
1212021-09-08T13:23:16 <michaelfolkson> So don't share your debug log with anyone
1222021-09-08T13:23:27 <laanwj> there's a lot of debug functionality that can be enabled that is potentially privacy sensitive
1232021-09-08T13:23:28 <prayank> It's not something you control
1242021-09-08T13:23:38 <prayank> Debug logs are available for all running nodes
1252021-09-08T13:23:49 <laanwj> only if the 'mempool' flag is enabled in this case right
1262021-09-08T13:24:02 <laanwj> which you wouldn't enable unless you want to see mempool internals
1272021-09-08T13:24:20 <prayank> Okay let me rephrase my question
1282021-09-08T13:25:05 <laanwj> just be really careful with giving bitcoin debug logs to people, they're never "safe" from a privacy perspective, if possible only post a relevant excerpt and if you post to public forums, censor information you don't want known
1292021-09-08T13:25:22 <sipa> debug=net will list every network message received
1302021-09-08T13:25:26 <sipa> e.g.
1312021-09-08T13:25:29 <laanwj> there is nothing especially bad about this message in that regard?
1322021-09-08T13:25:44 <michaelfolkson> You don
1332021-09-08T13:25:46 <prayank> If we change "replacing tx <original txid>" to "replacing tx <>". Does this affect any debugging or any projects?
1342021-09-08T13:26:02 <laanwj> yes, it make it pointless
1352021-09-08T13:26:14 <michaelfolkson> Yes if someone is trying to debug a problem with RBF
1362021-09-08T13:26:43 <laanwj> the specific information is what you need to trace problems, why debug logging exists
1372021-09-08T13:27:45 <laanwj> say, if some specific transaction gets mis-handled, it is good to see when/what
1382021-09-08T13:28:42 <sipa> there may also be functional tests that rely on debug messages, though i'm not sure that's the case specifically for this one
1392021-09-08T13:28:56 <laanwj> yes
1402021-09-08T13:29:10 <sipa> in any case: if you don't want mempool details in your logs, don't enable mempool debug logs
1412021-09-08T13:30:06 <prayank> It's not about my logs. Others can see replacement done by me in their logs.
1422021-09-08T13:30:28 <laanwj> well it's public information
1432021-09-08T13:30:38 <sipa> ooh, now i understand
1442021-09-08T13:30:44 <sipa> well, yes, it's public information
1452021-09-08T13:33:37 <prayank> I wish we could remove it. Maybe I will experiment more with it and see if anything can be changed. I think this is similar to confidential transactions in which amounts are hidden which can affect verification of supply or other debugging.
1462021-09-08T13:33:56 <sipa> no
1472021-09-08T13:34:11 <sipa> in CT the information is secret
1482021-09-08T13:34:24 <laanwj> confidential transactions is completely different, it means peers *don't have* this information, so can't log it if they wanted, playing hide and seek with log messages is not going to make anyone more safe
1492021-09-08T13:35:31 <sipa> just because information isn't logged doesn't mean it isn't there; anyone who actually cares about it can still log it
1502021-09-08T13:35:51 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has joined #bitcoin-core-dev
1512021-09-08T13:38:08 <laanwj> yes; as far as we know, spy nodes do not generally run bitcoin core at all, or if they do, i'd expect them to use a heavily patched version that logs all kinds of extra stuff
1522021-09-08T13:40:11 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has quit IRC (Ping timeout: 252 seconds)
1532021-09-08T13:40:13 *** r-ush <r-ush!~r-ush@52.187.184.81> has joined #bitcoin-core-dev
1542021-09-08T13:42:48 <laanwj> besides, it's an unencrypted P2P network, information about transaction propagation can be sniffed passively
1552021-09-08T13:45:02 *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1562021-09-08T13:45:55 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 260 seconds)
1572021-09-08T13:46:02 *** Guyver2_ is now known as Guyver2
1582021-09-08T13:46:21 <laanwj> crippling our own debugging capability in any way for a false sense of privacy seems a bad trade-off
1592021-09-08T13:48:39 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has quit IRC (Remote host closed the connection)
1602021-09-08T13:53:50 *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has quit IRC (Quit: Konversation terminated!)
1612021-09-08T14:17:01 <laanwj> should we tag 22.0 final ?
1622021-09-08T14:18:47 *** lucaferr <lucaferr!~lucaferr@c188-151-171-114.bredband.tele2.se> has joined #bitcoin-core-dev
1632021-09-08T14:19:28 *** lucaferr <lucaferr!~lucaferr@c188-151-171-114.bredband.tele2.se> has quit IRC (Client Quit)
1642021-09-08T14:19:54 *** lucaferr <lucaferr!~lucaferr@c188-151-171-114.bredband.tele2.se> has joined #bitcoin-core-dev
1652021-09-08T14:21:11 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
1662021-09-08T14:22:44 <hebasto> everything looks done for 22.0 final
1672021-09-08T14:23:28 <laanwj> yes-just removed #22681 from the milestone, there's #22857 but I don't think it has anything critical that needs an extra rc, could just as well be 22.1 items?
1682021-09-08T14:23:29 <gribble> https://github.com/bitcoin/bitcoin/issues/22681 | Manual page generation on master broken · Issue #22681 · bitcoin/bitcoin · GitHub
1692021-09-08T14:23:30 <gribble> https://github.com/bitcoin/bitcoin/issues/22857 | [22.x] Backports by fanquake · Pull Request #22857 · bitcoin/bitcoin · GitHub
1702021-09-08T14:26:02 <lucaferr> I'm trying to find an example TapRoot keypath transaction in the test vectors linked from bip341. Any suggestions on how to find one?
1712021-09-08T14:27:54 <laanwj> although fanquake has a point that they could be merged without a rc, it's a doc change and a minor build system one
1722021-09-08T14:32:19 <laanwj> first things first, let's merge the release notes back from the wiki
1732021-09-08T14:35:37 <sipa> lucaferr: around half of them probably are
1742021-09-08T14:35:58 <lucaferr> @sipa: ah, ok.. A bit unsure on how to interpret the comment field
1752021-09-08T14:36:33 <lucaferr> I was hoping for one without annex or just as vanilla as possible
1762021-09-08T14:39:09 <sipa> lucaferr: easier to look at the generating code: https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_taproot.py
1772021-09-08T14:40:47 <lucaferr> will do, thanks
1782021-09-08T14:41:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1792021-09-08T14:41:55 <bitcoin-git> [bitcoin] laanwj opened pull request #22920: doc: Move 22.0 release notes from wiki (22.x...2021-09-release-notes) https://github.com/bitcoin/bitcoin/pull/22920
1802021-09-08T14:41:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1812021-09-08T15:04:35 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has joined #bitcoin-core-dev
1822021-09-08T15:05:45 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1832021-09-08T15:05:45 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/86de56776aae...fbf498d26bd2
1842021-09-08T15:05:45 <bitcoin-git> bitcoin/22.x d447972 W. J. van der Laan: doc: Move 22.0 release notes from wiki
1852021-09-08T15:05:45 <bitcoin-git> bitcoin/22.x fbf498d W. J. van der Laan: Merge bitcoin/bitcoin#22920: doc: Move 22.0 release notes from wiki
1862021-09-08T15:05:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1872021-09-08T15:06:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1882021-09-08T15:06:02 <bitcoin-git> [bitcoin] laanwj merged pull request #22920: doc: Move 22.0 release notes from wiki (22.x...2021-09-release-notes) https://github.com/bitcoin/bitcoin/pull/22920
1892021-09-08T15:06:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1902021-09-08T15:15:49 *** copumpkin <copumpkin!~woohoo@user/copumpkin> has joined #bitcoin-core-dev
1912021-09-08T15:17:44 <sipa> lucaferr: both the "sig/bitflip" cases in unit_test_data/script_assets_test.json are key path spends without annex
1922021-09-08T15:19:26 <lucaferr> sipa: thank you! that's very helpful
1932021-09-08T15:19:57 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 265 seconds)
1942021-09-08T15:20:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1952021-09-08T15:20:28 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/fbf498d26bd2...03f142278620
1962021-09-08T15:20:28 <bitcoin-git> bitcoin/22.x 0640bf5 Pieter Wuille: doc: mention bech32m/BIP350 in doc/descriptors.md
1972021-09-08T15:20:28 <bitcoin-git> bitcoin/22.x 303bc8a Carl Dong: guix/prelude: Override VERSION with FORCE_VERSION
1982021-09-08T15:20:28 <bitcoin-git> bitcoin/22.x 03f1422 W. J. van der Laan: Merge bitcoin/bitcoin#22857: [22.x] Backports
1992021-09-08T15:20:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2002021-09-08T15:20:35 *** rockhouse <rockhouse!~rockhouse@user/rockhouse> has quit IRC (Remote host closed the connection)
2012021-09-08T15:20:45 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2022021-09-08T15:20:45 <bitcoin-git> [bitcoin] laanwj merged pull request #22857: [22.x] Backports (22.x...more_22_x_backports) https://github.com/bitcoin/bitcoin/pull/22857
2032021-09-08T15:20:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2042021-09-08T15:21:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2052021-09-08T15:21:50 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/03f142278620...f75615ebdda9
2062021-09-08T15:21:50 <bitcoin-git> bitcoin/22.x afbee40 W. J. van der Laan: build: Bump version to 22.0 final
2072021-09-08T15:21:50 <bitcoin-git> bitcoin/22.x f75615e W. J. van der Laan: doc: Manual pages update for 22.0 final
2082021-09-08T15:21:52 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2092021-09-08T15:22:06 <laanwj> phew
2102021-09-08T15:22:16 *** rockhouse <rockhouse!~rockhouse@user/rockhouse> has joined #bitcoin-core-dev
2112021-09-08T15:25:13 <sipa> i guess the switch to guix should be listed under build system changes in the release notes?
2122021-09-08T15:26:11 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
2132021-09-08T15:26:19 <sipa> ping dongcarl ?
2142021-09-08T15:27:35 <sipa> provoostenator: also, there is a release notes section for new RPCs, but the new external signer RPCs aren't listed under it
2152021-09-08T15:27:50 <sipa> in general, please read the release notes to see if things are missing
2162021-09-08T15:28:18 <laanwj> it would have been handier to do this when the release notes were still on the wiki
2172021-09-08T15:28:22 <laanwj> but yes
2182021-09-08T15:28:25 *** lucaferr <lucaferr!~lucaferr@c188-151-171-114.bredband.tele2.se> has quit IRC (Remote host closed the connection)
2192021-09-08T15:28:50 <sipa> laanwj: yes, agree
2202021-09-08T15:29:16 <laanwj> now I'm not sure whether to hold off tagging final for now, or for how long
2212021-09-08T15:29:22 <sipa> oh, ok
2222021-09-08T15:29:30 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Quit: Client closed)
2232021-09-08T15:31:06 <sipa> well let me PR a very short reference at least then
2242021-09-08T15:31:12 *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
2252021-09-08T15:31:17 <laanwj> sure
2262021-09-08T15:32:00 <sipa> actually, these new RPCs are listed, but under the wallet section
2272021-09-08T15:32:10 <laanwj> that seems ok
2282021-09-08T15:32:16 <sipa> so i'll just remove the empty section, and mention it
2292021-09-08T15:37:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2302021-09-08T15:37:43 <bitcoin-git> [bitcoin] sipa opened pull request #22921: Some small improvements to release notes (22.x...202109_22xrelease) https://github.com/bitcoin/bitcoin/pull/22921
2312021-09-08T15:37:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2322021-09-08T15:38:10 <ryanofsky> achow101, just saw earlier WalletContext/CWallet question, replied https://github.com/bitcoin/bitcoin/pull/22183#issuecomment-915348120
2332021-09-08T15:47:47 *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-b453-a897-4f94-54c0.res6.spectrum.com> has quit IRC (Ping timeout: 252 seconds)
2342021-09-08T15:50:45 *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-99ef-1e4e-a8ff-fad3.res6.spectrum.com> has joined #bitcoin-core-dev
2352021-09-08T15:53:18 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 265 seconds)
2362021-09-08T15:57:37 *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f389600dda8b22aaea27669.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
2372021-09-08T16:00:06 *** prayank[m] <prayank[m]!~prayankni@2001:470:69fc:105::ba63> has quit IRC (Quit: You have been kicked for being idle)
2382021-09-08T16:00:57 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
2392021-09-08T16:12:07 *** gleb7 <gleb7!~gleb@178.150.137.228> has quit IRC (Ping timeout: 245 seconds)
2402021-09-08T16:12:39 <achow101> ryanofsky: I see. The reason I asked is that #19602 currently makes new CWallets from within a CWallet. I'll try to rework that to not be a member function then.
2412021-09-08T16:12:42 <gribble> https://github.com/bitcoin/bitcoin/issues/19602 | wallet: Migrate legacy wallets to descriptor wallets by achow101 · Pull Request #19602 · bitcoin/bitcoin · GitHub
2422021-09-08T16:20:10 *** lightlike <lightlike!~lightlike@user/lightlike> has joined #bitcoin-core-dev
2432021-09-08T16:24:20 <ryanofsky> I think the part of 19602 that makes new cwallets in a cwallet method looks fine. It's just the part that messes with the vpwallets array should be pulled out to the caller
2442021-09-08T16:24:59 <ryanofsky> i.e. CWallet::MigrateToDescriptor could simply return the new CWallets instead of adding them to ::vpwallets
2452021-09-08T16:25:44 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has joined #bitcoin-core-dev
2462021-09-08T16:27:56 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has quit IRC (Remote host closed the connection)
2472021-09-08T16:28:22 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has joined #bitcoin-core-dev
2482021-09-08T16:39:50 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has quit IRC (Remote host closed the connection)
2492021-09-08T16:42:45 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2502021-09-08T16:48:46 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2512021-09-08T16:50:53 <jonatack> sipa: feel free to ignore, but while you're there, i hesitated to add a release note about the addr rate limiting in "P2P and network changes" (and the additional getpeerinfo fields in "Updated RPCs")
2522021-09-08T16:52:20 <laanwj> sipa: something went wrong with your PR
2532021-09-08T16:54:48 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 276 seconds)
2542021-09-08T16:55:34 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
2552021-09-08T16:58:40 <sipa> jonatack: mentioning the new fields seems fine, that's standard practice
2562021-09-08T16:59:38 <sipa> laanwj: hmm, will fix soom
2572021-09-08T16:59:42 <laanwj> just briefly mentioning them is good, you don't actually need (or should) write documentation in the release notes
2582021-09-08T17:00:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2592021-09-08T17:00:01 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22922: ci: Fix and enable tests on Windows (master...2109-testWin) https://github.com/bitcoin/bitcoin/pull/22922
2602021-09-08T17:00:02 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2612021-09-08T17:00:14 <jonatack> sipa: wondered if the omission was intentional :D at any rate, no one is spamming addresses (per the rate limiting) to me any longer lately
2622021-09-08T17:01:01 *** raj <raj!~raj_@115.187.59.1> has joined #bitcoin-core-dev
2632021-09-08T17:03:40 <sipa> jonatack: oh good to hear, i hadn't paid too much attention to it lately
2642021-09-08T17:04:46 *** JohnnyD <JohnnyD!~JohnnyD@2605:a601:af6e:b800:111:47c9:4f75:56f5> has joined #bitcoin-core-dev
2652021-09-08T17:06:17 *** JohnnyD <JohnnyD!~JohnnyD@2605:a601:af6e:b800:111:47c9:4f75:56f5> has quit IRC (Client Quit)
2662021-09-08T17:07:48 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 276 seconds)
2672021-09-08T17:07:54 *** prayank <prayank!~andr0irc@51.158.144.31> has quit IRC (Quit: irc thread exit)
2682021-09-08T17:09:48 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2692021-09-08T17:09:48 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22923: ci: Switch multiprocess to clang i686 build (master...2109-ciClang686) https://github.com/bitcoin/bitcoin/pull/22923
2702021-09-08T17:09:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2712021-09-08T17:12:02 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
2722021-09-08T17:12:05 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 265 seconds)
2732021-09-08T17:12:24 <sipa> laanwj: fixed; seems i just hadn't pulled in the latest upstream/22.x
2742021-09-08T17:12:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2752021-09-08T17:12:50 <bitcoin-git> [bitcoin] mjdietzx opened pull request #22924: refactor: merge ScriptPubKeyToUniv and ScriptToUniv into a single function (master...refactor_ScriptToUniv) https://github.com/bitcoin/bitcoin/pull/22924
2762021-09-08T17:12:51 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2772021-09-08T17:24:05 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
2782021-09-08T17:24:39 *** gleb7 <gleb7!~gleb@178.150.137.228> has joined #bitcoin-core-dev
2792021-09-08T17:28:26 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
2802021-09-08T17:31:18 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
2812021-09-08T17:34:43 *** AaronvanW <AaronvanW!~AaronvanW@190.242.161.186> has joined #bitcoin-core-dev
2822021-09-08T17:37:45 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 252 seconds)
2832021-09-08T17:38:32 <dongcarl> sipa: I will take a look at the branch right now, apologies I missed the release notes in the wiki stage
2842021-09-08T17:38:57 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
2852021-09-08T17:46:53 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 265 seconds)
2862021-09-08T17:46:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2872021-09-08T17:46:54 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22925: test: Add missing suppression signed-integer-overflow:addrman.cpp (master...2109-testSupFuzz) https://github.com/bitcoin/bitcoin/pull/22925
2882021-09-08T17:46:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2892021-09-08T17:47:32 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
2902021-09-08T18:02:29 *** vysn <vysn!~vysn@user/vysn> has quit IRC (Quit: WeeChat 3.2)
2912021-09-08T18:08:43 *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
2922021-09-08T18:11:17 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 252 seconds)
2932021-09-08T18:11:24 *** Guyver2_ is now known as Guyver2
2942021-09-08T18:12:09 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has joined #bitcoin-core-dev
2952021-09-08T18:16:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2962021-09-08T18:16:42 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/f75615ebdda9...a0988140b714
2972021-09-08T18:16:42 <bitcoin-git> bitcoin/22.x 9f9ffe5 Pieter Wuille: Some small improvements to release notes
2982021-09-08T18:16:42 <bitcoin-git> bitcoin/22.x a098814 W. J. van der Laan: Merge bitcoin/bitcoin#22921: Some small improvements to release notes
2992021-09-08T18:16:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3002021-09-08T18:16:51 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has quit IRC (Ping timeout: 265 seconds)
3012021-09-08T18:17:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3022021-09-08T18:17:00 <bitcoin-git> [bitcoin] laanwj merged pull request #22921: Some small improvements to release notes (22.x...202109_22xrelease) https://github.com/bitcoin/bitcoin/pull/22921
3032021-09-08T18:17:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3042021-09-08T18:17:18 <dongcarl> Hmm, is there an IRC channel just for C++ questions?
3052021-09-08T18:17:24 <dongcarl> Can't seem to find any on libera
3062021-09-08T18:17:38 <sipa> #c++ ?
3072021-09-08T18:17:45 <sipa> (i haven't tried)
3082021-09-08T18:18:06 <sipa> but stackoverflow probably works
3092021-09-08T18:18:37 <dongcarl> oh dope that works
3102021-09-08T18:19:09 <sipa> i would advise against using dope to answer C++ questions
3112021-09-08T18:19:54 <dongcarl> ð¬
3122021-09-08T18:22:34 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Quit: Client closed)
3132021-09-08T18:22:45 *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
3142021-09-08T18:23:39 <laanwj> it might help make undefined behavior more understandable
3152021-09-08T18:24:58 <dongcarl> XP
3162021-09-08T18:25:58 <shiza> C++ has no owner. Old days freenode would then have ##C++ as well...
3172021-09-08T18:26:36 <shiza> But yes everything is in StackOverflow already.
3182021-09-08T18:26:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3192021-09-08T18:26:54 <bitcoin-git> [bitcoin] laanwj pushed tag v22.0: https://github.com/bitcoin/bitcoin/compare/v22.0
3202021-09-08T18:26:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3212021-09-08T18:27:04 <hebasto> \o/
3222021-09-08T18:27:04 <achow101> \o/
3232021-09-08T18:27:17 <shiza> You can go ask StackOverflow and your question be closed.
3242021-09-08T18:27:24 <shiza> Congrats on the new release!
3252021-09-08T18:29:04 <laanwj> ^^
3262021-09-08T18:29:25 <dongcarl> hip hip hooray
3272021-09-08T18:59:32 *** mxcl <mxcl!~mxcl@ec2-34-238-66-213.compute-1.amazonaws.com> has quit IRC (Quit: The Lounge - https://thelounge.chat)
3282021-09-08T18:59:35 <jamesob> does this mean it's time for another guix build?
3292021-09-08T18:59:53 <laanwj> jamesob: yep
3302021-09-08T19:02:32 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
3312021-09-08T19:13:11 <stick> wohooo 22.0 \o/
3322021-09-08T19:17:21 <sipa> you take one up, pass it around, 22 cores of bitcoin on the wall
3332021-09-08T19:17:36 <sipa> i guess that doesn't roll off the tongue that well
3342021-09-08T19:18:38 <stick> 22 luftballons auf ihrem weg zum horizont :D
3352021-09-08T19:18:58 <laanwj> hehe
3362021-09-08T19:19:41 <b10c> \o/
3372021-09-08T19:24:04 <dodo> nice
3382021-09-08T19:25:51 <jb55> \o/ gj team
3392021-09-08T19:32:04 <cfields> :)
3402021-09-08T19:43:11 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3412021-09-08T19:43:11 <bitcoin-git> [bitcoin] hebasto closed pull request #22917: build: Copy appropriate MSVC build output to src/qt automatically (master...210908-copy) https://github.com/bitcoin/bitcoin/pull/22917
3422021-09-08T19:43:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3432021-09-08T19:44:49 *** gleb7 <gleb7!~gleb@178.150.137.228> has quit IRC (Ping timeout: 265 seconds)
3442021-09-08T19:54:59 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
3452021-09-08T20:02:39 *** Guyver2_ <Guyver2_!~Guyver@2001:985:f3f:1:a12e:280:8f07:cc3a> has joined #bitcoin-core-dev
3462021-09-08T20:03:40 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 265 seconds)
3472021-09-08T20:03:49 *** Guyver2_ is now known as Guyver2
3482021-09-08T20:14:54 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Quit: Konversation terminated!)
3492021-09-08T20:28:13 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
3502021-09-08T20:29:28 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has joined #bitcoin-core-dev
3512021-09-08T20:34:07 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has quit IRC (Ping timeout: 265 seconds)
3522021-09-08T20:39:45 <dongcarl> Wondering how our lock annotations interact with inheritance. Let's say I have "class A { virtual int foo() EXCLUSIVE_LOCK_REQUIRED(cs_a) = 0; }", and "class B { int foo() override EXCLUSIVE_LOCK_REQUIRED(cs_b) { return 1 }; }", would calling B::foo lock both cs_a and cs_b?
3532021-09-08T20:43:02 *** raj <raj!~raj_@115.187.59.1> has quit IRC (Quit: Leaving)
3542021-09-08T20:45:20 *** smartin <smartin!~Icedove@88.135.18.171> has quit IRC (Ping timeout: 252 seconds)
3552021-09-08T20:54:12 <dongcarl> s/lock both/require both/g
3562021-09-08T21:02:56 <jonatack> dongcarl: IDK, but you have me reading https://clang.llvm.org/docs/ThreadSafetyAnalysis.html now :)
3572021-09-08T21:09:23 <jonatack> https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#lexical-scope
3582021-09-08T21:24:07 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3592021-09-08T21:24:08 <bitcoin-git> [bitcoin] hebasto opened pull request #22926: doc: Set PYTHONUTF8=1 for functional tests on Windows (master...210908-utf) https://github.com/bitcoin/bitcoin/pull/22926
3602021-09-08T21:24:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3612021-09-08T21:42:34 <emzy> \o/
3622021-09-08T21:48:55 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
3632021-09-08T21:56:02 <cfields> dongcarl: I kinda doubt clang is smart enough to figure that out. It's very picky about requiring exact variables and iirc isn't able to follow copies or anything complicated...
3642021-09-08T21:56:14 <cfields> that said, it should be easy enough to whip up a quick test-case and see :)
3652021-09-08T21:57:27 <dongcarl> cfields: Yeah I did a quick test and you right
3662021-09-08T21:57:53 <dongcarl> It's a dumb mechanism, oh well
3672021-09-08T21:59:06 <cfields> dongcarl: could maybe use CRTP if static polymorphism is enough :)
3682021-09-08T21:59:50 *** Guyver2 <Guyver2!~Guyver@2001:985:f3f:1:a12e:280:8f07:cc3a> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
3692021-09-08T21:59:56 <cfields> (assuming it could even figure out that much)
3702021-09-08T22:03:19 <dongcarl> Huh... Will read up on CRTP
3712021-09-08T22:14:57 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has joined #bitcoin-core-dev
3722021-09-08T22:15:30 *** gene <gene!~gene@gateway/tor-sasl/gene> has joined #bitcoin-core-dev
3732021-09-08T22:19:29 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has quit IRC (Ping timeout: 265 seconds)
3742021-09-08T22:19:50 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
3752021-09-08T22:27:02 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 252 seconds)
3762021-09-08T22:28:54 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 276 seconds)
3772021-09-08T22:40:19 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
3782021-09-08T22:55:40 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 252 seconds)
3792021-09-08T23:05:24 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has joined #bitcoin-core-dev
3802021-09-08T23:10:14 *** saranshsharma <saranshsharma!~saranshsh@112.133.224.115> has quit IRC (Ping timeout: 265 seconds)
3812021-09-08T23:19:33 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
3822021-09-08T23:34:18 *** lightlike <lightlike!~lightlike@user/lightlike> has quit IRC (Quit: Leaving)
3832021-09-08T23:59:28 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 256 seconds)