1 2021-09-08T00:02:02  *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Quit: Client closed)
  2 2021-09-08T00:02:17  *** stevenroose <stevenroose!~steven@irc.roose.io> has quit IRC (Quit: ZNC 1.7.4 - https://znc.in)
  3 2021-09-08T00:02:33  *** stevenroose <stevenroose!~steven@irc.roose.io> has joined #bitcoin-core-dev
  4 2021-09-08T00:16:51  *** belcher_ <belcher_!~belcher@user/belcher> has joined #bitcoin-core-dev
  5 2021-09-08T00:20:26  *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 252 seconds)
  6 2021-09-08T00:26:58  *** b10c <b10c!uid500648@id-500648.ilkley.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
  7 2021-09-08T00:42:29  *** earnestly <earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 252 seconds)
  8 2021-09-08T00:56:24  *** Guest50 <Guest50!~Guest50@> has joined #bitcoin-core-dev
  9 2021-09-08T00:57:13  *** Guest50 <Guest50!~Guest50@> has quit IRC (Client Quit)
 10 2021-09-08T01:03:56  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 252 seconds)
 11 2021-09-08T01:13:50  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-b82e-8865-a976-d9c2.res6.spectrum.com> has quit IRC (Ping timeout: 252 seconds)
 12 2021-09-08T01:26:56  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-b453-a897-4f94-54c0.res6.spectrum.com> has joined #bitcoin-core-dev
 13 2021-09-08T01:35:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 14 2021-09-08T01:35:10  <bitcoin-git> [gui] luke-jr closed pull request #230: Support backup to new text-based database dump format (master...gui_backup_formats) https://github.com/bitcoin-core/gui/pull/230
 15 2021-09-08T01:35:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 16 2021-09-08T04:01:02  *** cmirror <cmirror!~cmirror@> has quit IRC (Remote host closed the connection)
 17 2021-09-08T04:01:09  *** cmirror <cmirror!~cmirror@> has joined #bitcoin-core-dev
 18 2021-09-08T04:14:33  *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
 19 2021-09-08T04:26:13  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 20 2021-09-08T05:04:10  *** jespada <jespada!~jespada@> has quit IRC (Ping timeout: 240 seconds)
 21 2021-09-08T05:05:44  *** jespada <jespada!~jespada@> has joined #bitcoin-core-dev
 22 2021-09-08T05:40:02  *** saranshsharma <saranshsharma!~saranshsh@2401:4900:120c:8155:2c35:7671:4347:733b> has joined #bitcoin-core-dev
 23 2021-09-08T05:57:57  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
 24 2021-09-08T06:03:07  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
 25 2021-09-08T06:16:40  *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has joined #bitcoin-core-dev
 26 2021-09-08T06:59:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 27 2021-09-08T06:59:12  <bitcoin-git> [bitcoin] fujicoin opened pull request #22913: Fix the case where the peer status is not updated (master...fix210908) https://github.com/bitcoin/bitcoin/pull/22913
 28 2021-09-08T06:59:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 29 2021-09-08T07:01:11  *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has quit IRC (Remote host closed the connection)
 30 2021-09-08T07:01:29  *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has joined #bitcoin-core-dev
 31 2021-09-08T07:08:04  *** saranshsharma <saranshsharma!~saranshsh@2401:4900:120c:8155:2c35:7671:4347:733b> has quit IRC (Remote host closed the connection)
 32 2021-09-08T07:12:14  *** saranshsharma <saranshsharma!~saranshsh@> has joined #bitcoin-core-dev
 33 2021-09-08T07:18:14  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 34 2021-09-08T07:18:15  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ecf580e40f60...7d7d5e8efde9
 35 2021-09-08T07:18:15  <bitcoin-git> bitcoin/master facce4c MarcoFalke: test: Remove useless overwrite
 36 2021-09-08T07:18:15  <bitcoin-git> bitcoin/master fab0b55 MarcoFalke: addrman: Fix format string in deserialize error
 37 2021-09-08T07:18:15  <bitcoin-git> bitcoin/master 7d7d5e8 fanquake: Merge bitcoin/bitcoin#22879: addrman: Fix format string in deserialize err...
 38 2021-09-08T07:18:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 39 2021-09-08T07:18:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 40 2021-09-08T07:18:32  <bitcoin-git> [bitcoin] fanquake merged pull request #22879: addrman: Fix format string in deserialize error (master...2109-testPeersDat) https://github.com/bitcoin/bitcoin/pull/22879
 41 2021-09-08T07:18:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 42 2021-09-08T07:22:09  *** saranshsharma <saranshsharma!~saranshsh@> has quit IRC (Remote host closed the connection)
 43 2021-09-08T07:27:45  <vasild> Is anybody running a CJDNS node?
 44 2021-09-08T07:32:24  *** saranshsharma <saranshsharma!~saranshsh@> has joined #bitcoin-core-dev
 45 2021-09-08T07:36:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 46 2021-09-08T07:36:00  <bitcoin-git> [bitcoin] fanquake opened pull request #22914: util: remove libevent <= 2.0.18 back-compat code (master...libevent_cleanup) https://github.com/bitcoin/bitcoin/pull/22914
 47 2021-09-08T07:36:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 48 2021-09-08T07:37:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 49 2021-09-08T07:37:50  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22915: Remove confusing CAddrDB (master...2109-noAddrDb) https://github.com/bitcoin/bitcoin/pull/22915
 50 2021-09-08T07:37:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 51 2021-09-08T07:39:23  *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has quit IRC (Quit: Konversation terminated!)
 52 2021-09-08T07:41:16  *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f389600dda8b22aaea27669.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
 53 2021-09-08T07:44:29  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
 54 2021-09-08T07:52:55  *** saranshsharma <saranshsharma!~saranshsh@> has quit IRC (Remote host closed the connection)
 55 2021-09-08T07:58:15  *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has joined #bitcoin-core-dev
 56 2021-09-08T08:14:09  *** aechu <aechu!~major@gateway/tor-sasl/major> has quit IRC (Ping timeout: 276 seconds)
 57 2021-09-08T08:14:48  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 276 seconds)
 58 2021-09-08T08:16:36  *** aechu <aechu!~major@gateway/tor-sasl/major> has joined #bitcoin-core-dev
 59 2021-09-08T08:25:35  *** earnestly <earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
 60 2021-09-08T08:29:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 61 2021-09-08T08:29:45  <bitcoin-git> [bitcoin] fanquake opened pull request #22916: doc: add missing copyright header to getuniquepath.cpp (master...missing_copyright_header) https://github.com/bitcoin/bitcoin/pull/22916
 62 2021-09-08T08:29:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 63 2021-09-08T08:44:17  *** smartin <smartin!~Icedove@> has joined #bitcoin-core-dev
 64 2021-09-08T08:49:57  *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
 65 2021-09-08T08:58:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 66 2021-09-08T08:58:53  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7d7d5e8efde9...5e3380b9f594
 67 2021-09-08T08:58:53  <bitcoin-git> bitcoin/master 69a439b fanquake: doc: add missing copyright header to getuniquepath.cpp
 68 2021-09-08T08:58:53  <bitcoin-git> bitcoin/master 5e3380b MarcoFalke: Merge bitcoin/bitcoin#22916: doc: add missing copyright header to getuniqu...
 69 2021-09-08T08:58:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 70 2021-09-08T08:59:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 71 2021-09-08T08:59:10  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22916: doc: add missing copyright header to getuniquepath.cpp (master...missing_copyright_header) https://github.com/bitcoin/bitcoin/pull/22916
 72 2021-09-08T08:59:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 73 2021-09-08T09:01:52  *** Guest44 <Guest44!~Guest44@> has joined #bitcoin-core-dev
 74 2021-09-08T09:02:18  *** Guest44 <Guest44!~Guest44@> has quit IRC (Client Quit)
 75 2021-09-08T09:02:58  *** kexkey <kexkey!~kexkey@static-198-54-132-122.cust.tzulo.com> has quit IRC (Ping timeout: 252 seconds)
 76 2021-09-08T09:05:27  *** kexkey <kexkey!~kexkey@static-198-54-132-90.cust.tzulo.com> has joined #bitcoin-core-dev
 77 2021-09-08T09:25:58  *** belcher_ is now known as belcher
 78 2021-09-08T09:26:01  *** saranshsharma <saranshsharma!~saranshsh@> has joined #bitcoin-core-dev
 79 2021-09-08T09:30:25  *** saranshsharma <saranshsharma!~saranshsh@> has quit IRC (Ping timeout: 260 seconds)
 80 2021-09-08T09:38:36  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
 81 2021-09-08T10:17:14  *** saranshsharma <saranshsharma!~saranshsh@> has joined #bitcoin-core-dev
 82 2021-09-08T10:19:23  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 252 seconds)
 83 2021-09-08T10:21:44  *** saranshsharma <saranshsharma!~saranshsh@> has quit IRC (Ping timeout: 265 seconds)
 84 2021-09-08T10:27:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 85 2021-09-08T10:27:06  <bitcoin-git> [bitcoin] hebasto opened pull request #22917: build: Copy appropriate MSVC build output to src/qt automatically (master...210908-copy) https://github.com/bitcoin/bitcoin/pull/22917
 86 2021-09-08T10:27:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 87 2021-09-08T10:27:46  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
 88 2021-09-08T10:32:04  *** b10c <b10c!uid500648@id-500648.ilkley.irccloud.com> has joined #bitcoin-core-dev
 89 2021-09-08T10:37:22  <hebasto> MarcoFalke: should we in https://ci.appveyor.com/project/DrahtBot/bitcoin/settings check box "Skip branches without `appveyor.yml`" ?
 90 2021-09-08T10:40:07  <MarcoFalke> hebasto: Maybe. Currently I can't login
 91 2021-09-08T10:41:00  <MarcoFalke> I used up my rate limit to lock all historic pull requests to prevent spam
 92 2021-09-08T11:10:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 93 2021-09-08T11:10:22  <bitcoin-git> [bitcoin] kiminuo opened pull request #22918: rpc: Add level 3 verbosity to getblock RPC call (#21245 modified) (master...feature/2021-09-verbose-level-3-for-getblock) https://github.com/bitcoin/bitcoin/pull/22918
 94 2021-09-08T11:10:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 95 2021-09-08T11:17:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 96 2021-09-08T11:17:21  <bitcoin-git> [bitcoin] fanquake closed pull request #21245: rpc: Add level 3 verbosity to getblock RPC call. (master...verbosity-level-3-getblock) https://github.com/bitcoin/bitcoin/pull/21245
 97 2021-09-08T11:17:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 98 2021-09-08T11:18:55  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
 99 2021-09-08T11:30:11  *** ArctVaulMarsHMPJ <ArctVaulMarsHMPJ!~pjetcetal@> has quit IRC (Quit: EXIT)
100 2021-09-08T11:32:47  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
101 2021-09-08T11:57:21  *** vysn <vysn!~vysn@user/vysn> has quit IRC (Quit: WeeChat 3.2)
102 2021-09-08T11:57:37  *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
103 2021-09-08T12:05:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
104 2021-09-08T12:05:41  <bitcoin-git> [bitcoin] RohitRanjangit opened pull request #22919: fees: skip pointless fee parameter calculation during IBD (master...lazy_update) https://github.com/bitcoin/bitcoin/pull/22919
105 2021-09-08T12:05:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
106 2021-09-08T12:45:04  *** copumpkin <copumpkin!~woohoo@user/copumpkin> has quit IRC (Ping timeout: 252 seconds)
107 2021-09-08T13:09:10  *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 260 seconds)
108 2021-09-08T13:15:33  *** prayank <prayank!~andr0irc@> has joined #bitcoin-core-dev
109 2021-09-08T13:18:39  <prayank> debug=mempool -> debug.log -> replacing tx <original txid>
110 2021-09-08T13:19:03  <prayank> Does removing this information from logs affect any functionality?
111 2021-09-08T13:20:16  <sipa> no, it's a log...
112 2021-09-08T13:20:22  <sipa> logs don't have functionality
113 2021-09-08T13:20:36  <sipa> apart from logging what's going on
114 2021-09-08T13:20:37  <laanwj> it affects the functionality of: being able to debug that functionality of the mempool by checking the logs
115 2021-09-08T13:20:48  <prayank> I mean is someone using them and any projects depend on it?
116 2021-09-08T13:21:05  <laanwj> i think you should start from the start, why do you want to remove it
117 2021-09-08T13:21:21  <michaelfolkson> Debuggers rely on debug logs to locate bugs
118 2021-09-08T13:21:29  <laanwj> exactly
119 2021-09-08T13:21:49  <laanwj> it's troubleshooting information not more
120 2021-09-08T13:22:55  <prayank> Privacy. I don't think others need to know about my replacement details. X replaced Y. This is not available on blockchain and a user who starts running node today won't be able to get it for past transactions. It's available for only wallet transactions using gettransaction.
121 2021-09-08T13:23:16  <michaelfolkson> So don't share your debug log with anyone
122 2021-09-08T13:23:27  <laanwj> there's a lot of debug functionality that can be enabled that is potentially privacy sensitive
123 2021-09-08T13:23:28  <prayank> It's not something you control
124 2021-09-08T13:23:38  <prayank> Debug logs are available for all running nodes
125 2021-09-08T13:23:49  <laanwj> only if the 'mempool' flag is enabled in this case right
126 2021-09-08T13:24:02  <laanwj> which you wouldn't enable unless you want to see mempool internals
127 2021-09-08T13:24:20  <prayank> Okay let me rephrase my question
128 2021-09-08T13:25:05  <laanwj> just be really careful with giving bitcoin debug logs to people, they're never "safe" from a privacy perspective, if possible only post a relevant excerpt and if you post to public forums, censor information you don't want known
129 2021-09-08T13:25:22  <sipa> debug=net will list every network message received
130 2021-09-08T13:25:26  <sipa> e.g.
131 2021-09-08T13:25:29  <laanwj> there is nothing especially bad about this message in that regard?
132 2021-09-08T13:25:44  <michaelfolkson> You don
133 2021-09-08T13:25:46  <prayank> If we change "replacing tx <original txid>" to "replacing tx <>". Does this affect any debugging or any projects?
134 2021-09-08T13:26:02  <laanwj> yes, it make it pointless
135 2021-09-08T13:26:14  <michaelfolkson> Yes if someone is trying to debug a problem with RBF
136 2021-09-08T13:26:43  <laanwj> the specific information is what you need to trace problems, why debug logging exists
137 2021-09-08T13:27:45  <laanwj> say, if some specific transaction gets mis-handled, it is good to see when/what
138 2021-09-08T13:28:42  <sipa> there may also be functional tests that rely on debug messages, though i'm not sure that's the case specifically for this one
139 2021-09-08T13:28:56  <laanwj> yes
140 2021-09-08T13:29:10  <sipa> in any case: if you don't want mempool details in your logs, don't enable mempool debug logs
141 2021-09-08T13:30:06  <prayank> It's not about my logs. Others can see replacement done by me in their logs.
142 2021-09-08T13:30:28  <laanwj> well it's public information
143 2021-09-08T13:30:38  <sipa> ooh, now i understand
144 2021-09-08T13:30:44  <sipa> well, yes, it's public information
145 2021-09-08T13:33:37  <prayank> I wish we could remove it. Maybe I will experiment more with it and see if anything can be changed. I think this is similar to confidential transactions in which amounts are hidden which can affect verification of supply or other debugging.
146 2021-09-08T13:33:56  <sipa> no
147 2021-09-08T13:34:11  <sipa> in CT the information is secret
148 2021-09-08T13:34:24  <laanwj> confidential transactions is completely different, it means peers *don't have* this information, so can't log it if they wanted, playing hide and seek with log messages is not going to make anyone more safe
149 2021-09-08T13:35:31  <sipa> just because information isn't logged doesn't mean it isn't there; anyone who actually cares about it can still log it
150 2021-09-08T13:35:51  *** saranshsharma <saranshsharma!~saranshsh@> has joined #bitcoin-core-dev
151 2021-09-08T13:38:08  <laanwj> yes; as far as we know, spy nodes do not generally run bitcoin core at all, or if they do, i'd expect them to use a heavily patched version that logs all kinds of extra stuff
152 2021-09-08T13:40:11  *** saranshsharma <saranshsharma!~saranshsh@> has quit IRC (Ping timeout: 252 seconds)
153 2021-09-08T13:40:13  *** r-ush <r-ush!~r-ush@> has joined #bitcoin-core-dev
154 2021-09-08T13:42:48  <laanwj> besides, it's an unencrypted P2P network, information about transaction propagation can be sniffed passively
155 2021-09-08T13:45:02  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
156 2021-09-08T13:45:55  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 260 seconds)
157 2021-09-08T13:46:02  *** Guyver2_ is now known as Guyver2
158 2021-09-08T13:46:21  <laanwj> crippling our own debugging capability in any way for a false sense of privacy seems a bad trade-off
159 2021-09-08T13:48:39  *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has quit IRC (Remote host closed the connection)
160 2021-09-08T13:53:50  *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has quit IRC (Quit: Konversation terminated!)
161 2021-09-08T14:17:01  <laanwj> should we tag 22.0 final ?
162 2021-09-08T14:18:47  *** lucaferr <lucaferr!~lucaferr@c188-151-171-114.bredband.tele2.se> has joined #bitcoin-core-dev
163 2021-09-08T14:19:28  *** lucaferr <lucaferr!~lucaferr@c188-151-171-114.bredband.tele2.se> has quit IRC (Client Quit)
164 2021-09-08T14:19:54  *** lucaferr <lucaferr!~lucaferr@c188-151-171-114.bredband.tele2.se> has joined #bitcoin-core-dev
165 2021-09-08T14:21:11  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
166 2021-09-08T14:22:44  <hebasto> everything looks done for 22.0 final
167 2021-09-08T14:23:28  <laanwj> yes-just removed #22681 from the milestone, there's #22857 but I don't think it has anything critical that needs an extra rc, could just as well be 22.1 items?
168 2021-09-08T14:23:29  <gribble> https://github.com/bitcoin/bitcoin/issues/22681 | Manual page generation on master broken · Issue #22681 · bitcoin/bitcoin · GitHub
169 2021-09-08T14:23:30  <gribble> https://github.com/bitcoin/bitcoin/issues/22857 | [22.x] Backports by fanquake · Pull Request #22857 · bitcoin/bitcoin · GitHub
170 2021-09-08T14:26:02  <lucaferr> I'm trying to find an example TapRoot keypath transaction in the test vectors linked from bip341. Any suggestions on how to find one?
171 2021-09-08T14:27:54  <laanwj> although fanquake has a point that they could be merged without a rc, it's a doc change and a minor build system one
172 2021-09-08T14:32:19  <laanwj> first things first, let's merge the release notes back from the wiki
173 2021-09-08T14:35:37  <sipa> lucaferr: around half of them probably are
174 2021-09-08T14:35:58  <lucaferr> @sipa: ah, ok.. A bit unsure on how to interpret the comment field
175 2021-09-08T14:36:33  <lucaferr> I was hoping for one without annex or just as vanilla as possible
176 2021-09-08T14:39:09  <sipa> lucaferr: easier to look at the generating code: https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_taproot.py
177 2021-09-08T14:40:47  <lucaferr> will do, thanks
178 2021-09-08T14:41:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
179 2021-09-08T14:41:55  <bitcoin-git> [bitcoin] laanwj opened pull request #22920: doc: Move 22.0 release notes from wiki (22.x...2021-09-release-notes) https://github.com/bitcoin/bitcoin/pull/22920
180 2021-09-08T14:41:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
181 2021-09-08T15:04:35  *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has joined #bitcoin-core-dev
182 2021-09-08T15:05:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
183 2021-09-08T15:05:45  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/86de56776aae...fbf498d26bd2
184 2021-09-08T15:05:45  <bitcoin-git> bitcoin/22.x d447972 W. J. van der Laan: doc: Move 22.0 release notes from wiki
185 2021-09-08T15:05:45  <bitcoin-git> bitcoin/22.x fbf498d W. J. van der Laan: Merge bitcoin/bitcoin#22920: doc: Move 22.0 release notes from wiki
186 2021-09-08T15:05:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
187 2021-09-08T15:06:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
188 2021-09-08T15:06:02  <bitcoin-git> [bitcoin] laanwj merged pull request #22920: doc: Move 22.0 release notes from wiki (22.x...2021-09-release-notes) https://github.com/bitcoin/bitcoin/pull/22920
189 2021-09-08T15:06:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
190 2021-09-08T15:15:49  *** copumpkin <copumpkin!~woohoo@user/copumpkin> has joined #bitcoin-core-dev
191 2021-09-08T15:17:44  <sipa> lucaferr: both the "sig/bitflip" cases in unit_test_data/script_assets_test.json are key path spends without annex
192 2021-09-08T15:19:26  <lucaferr> sipa: thank you! that's very helpful
193 2021-09-08T15:19:57  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 265 seconds)
194 2021-09-08T15:20:28  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
195 2021-09-08T15:20:28  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/fbf498d26bd2...03f142278620
196 2021-09-08T15:20:28  <bitcoin-git> bitcoin/22.x 0640bf5 Pieter Wuille: doc: mention bech32m/BIP350 in doc/descriptors.md
197 2021-09-08T15:20:28  <bitcoin-git> bitcoin/22.x 303bc8a Carl Dong: guix/prelude: Override VERSION with FORCE_VERSION
198 2021-09-08T15:20:28  <bitcoin-git> bitcoin/22.x 03f1422 W. J. van der Laan: Merge bitcoin/bitcoin#22857: [22.x] Backports
199 2021-09-08T15:20:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
200 2021-09-08T15:20:35  *** rockhouse <rockhouse!~rockhouse@user/rockhouse> has quit IRC (Remote host closed the connection)
201 2021-09-08T15:20:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
202 2021-09-08T15:20:45  <bitcoin-git> [bitcoin] laanwj merged pull request #22857: [22.x] Backports  (22.x...more_22_x_backports) https://github.com/bitcoin/bitcoin/pull/22857
203 2021-09-08T15:20:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
204 2021-09-08T15:21:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
205 2021-09-08T15:21:50  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/03f142278620...f75615ebdda9
206 2021-09-08T15:21:50  <bitcoin-git> bitcoin/22.x afbee40 W. J. van der Laan: build: Bump version to 22.0 final
207 2021-09-08T15:21:50  <bitcoin-git> bitcoin/22.x f75615e W. J. van der Laan: doc: Manual pages update for 22.0 final
208 2021-09-08T15:21:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
209 2021-09-08T15:22:06  <laanwj> phew
210 2021-09-08T15:22:16  *** rockhouse <rockhouse!~rockhouse@user/rockhouse> has joined #bitcoin-core-dev
211 2021-09-08T15:25:13  <sipa> i guess the switch to guix should be listed under build system changes in the release notes?
212 2021-09-08T15:26:11  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
213 2021-09-08T15:26:19  <sipa> ping dongcarl ?
214 2021-09-08T15:27:35  <sipa> provoostenator: also, there is a release notes section for new RPCs, but the new external signer RPCs aren't listed under it
215 2021-09-08T15:27:50  <sipa> in general, please read the release notes to see if things are missing
216 2021-09-08T15:28:18  <laanwj> it would have been handier to do this when the release notes were still on the wiki
217 2021-09-08T15:28:22  <laanwj> but yes
218 2021-09-08T15:28:25  *** lucaferr <lucaferr!~lucaferr@c188-151-171-114.bredband.tele2.se> has quit IRC (Remote host closed the connection)
219 2021-09-08T15:28:50  <sipa> laanwj: yes, agree
220 2021-09-08T15:29:16  <laanwj> now I'm not sure whether to hold off tagging final for now, or for how long
221 2021-09-08T15:29:22  <sipa> oh, ok
222 2021-09-08T15:29:30  *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Quit: Client closed)
223 2021-09-08T15:31:06  <sipa> well let me PR a very short reference at least then
224 2021-09-08T15:31:12  *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
225 2021-09-08T15:31:17  <laanwj> sure
226 2021-09-08T15:32:00  <sipa> actually, these new RPCs are listed, but under the wallet section
227 2021-09-08T15:32:10  <laanwj> that seems ok
228 2021-09-08T15:32:16  <sipa> so i'll just remove the empty section, and mention it
229 2021-09-08T15:37:43  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
230 2021-09-08T15:37:43  <bitcoin-git> [bitcoin] sipa opened pull request #22921: Some small improvements to release notes (22.x...202109_22xrelease) https://github.com/bitcoin/bitcoin/pull/22921
231 2021-09-08T15:37:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
232 2021-09-08T15:38:10  <ryanofsky> achow101, just saw earlier WalletContext/CWallet question, replied https://github.com/bitcoin/bitcoin/pull/22183#issuecomment-915348120
233 2021-09-08T15:47:47  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-b453-a897-4f94-54c0.res6.spectrum.com> has quit IRC (Ping timeout: 252 seconds)
234 2021-09-08T15:50:45  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-99ef-1e4e-a8ff-fad3.res6.spectrum.com> has joined #bitcoin-core-dev
235 2021-09-08T15:53:18  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 265 seconds)
236 2021-09-08T15:57:37  *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f389600dda8b22aaea27669.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
237 2021-09-08T16:00:06  *** prayank[m] <prayank[m]!~prayankni@2001:470:69fc:105::ba63> has quit IRC (Quit: You have been kicked for being idle)
238 2021-09-08T16:00:57  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
239 2021-09-08T16:12:07  *** gleb7 <gleb7!~gleb@> has quit IRC (Ping timeout: 245 seconds)
240 2021-09-08T16:12:39  <achow101> ryanofsky: I see. The reason I asked is that #19602 currently makes new CWallets from within a CWallet. I'll try to rework that to not be a member function then.
241 2021-09-08T16:12:42  <gribble> https://github.com/bitcoin/bitcoin/issues/19602 | wallet: Migrate legacy wallets to descriptor wallets by achow101 · Pull Request #19602 · bitcoin/bitcoin · GitHub
242 2021-09-08T16:20:10  *** lightlike <lightlike!~lightlike@user/lightlike> has joined #bitcoin-core-dev
243 2021-09-08T16:24:20  <ryanofsky> I think the part of 19602 that makes new cwallets in a cwallet method looks fine. It's just the part that messes with the vpwallets array should be pulled out to the caller
244 2021-09-08T16:24:59  <ryanofsky> i.e. CWallet::MigrateToDescriptor could simply return the new CWallets instead of adding them to ::vpwallets
245 2021-09-08T16:25:44  *** saranshsharma <saranshsharma!~saranshsh@> has joined #bitcoin-core-dev
246 2021-09-08T16:27:56  *** saranshsharma <saranshsharma!~saranshsh@> has quit IRC (Remote host closed the connection)
247 2021-09-08T16:28:22  *** saranshsharma <saranshsharma!~saranshsh@> has joined #bitcoin-core-dev
248 2021-09-08T16:39:50  *** saranshsharma <saranshsharma!~saranshsh@> has quit IRC (Remote host closed the connection)
249 2021-09-08T16:42:45  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
250 2021-09-08T16:48:46  *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
251 2021-09-08T16:50:53  <jonatack> sipa: feel free to ignore, but while you're there, i hesitated to add a release note about the addr rate limiting in "P2P and network changes" (and the additional getpeerinfo fields in "Updated RPCs")
252 2021-09-08T16:52:20  <laanwj> sipa: something went wrong with your PR
253 2021-09-08T16:54:48  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 276 seconds)
254 2021-09-08T16:55:34  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
255 2021-09-08T16:58:40  <sipa> jonatack: mentioning the new fields seems fine, that's standard practice
256 2021-09-08T16:59:38  <sipa> laanwj: hmm, will fix soom
257 2021-09-08T16:59:42  <laanwj> just briefly mentioning them is good, you don't actually need (or should) write documentation in the release notes
258 2021-09-08T17:00:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
259 2021-09-08T17:00:01  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22922: ci: Fix and enable tests on Windows (master...2109-testWin) https://github.com/bitcoin/bitcoin/pull/22922
260 2021-09-08T17:00:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
261 2021-09-08T17:00:14  <jonatack> sipa: wondered if the omission was intentional :D  at any rate, no one is spamming addresses (per the rate limiting) to me any longer lately
262 2021-09-08T17:01:01  *** raj <raj!~raj_@> has joined #bitcoin-core-dev
263 2021-09-08T17:03:40  <sipa> jonatack: oh good to hear, i hadn't paid too much attention to it lately
264 2021-09-08T17:04:46  *** JohnnyD <JohnnyD!~JohnnyD@2605:a601:af6e:b800:111:47c9:4f75:56f5> has joined #bitcoin-core-dev
265 2021-09-08T17:06:17  *** JohnnyD <JohnnyD!~JohnnyD@2605:a601:af6e:b800:111:47c9:4f75:56f5> has quit IRC (Client Quit)
266 2021-09-08T17:07:48  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 276 seconds)
267 2021-09-08T17:07:54  *** prayank <prayank!~andr0irc@> has quit IRC (Quit: irc thread exit)
268 2021-09-08T17:09:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
269 2021-09-08T17:09:48  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22923: ci: Switch multiprocess to clang i686 build (master...2109-ciClang686) https://github.com/bitcoin/bitcoin/pull/22923
270 2021-09-08T17:09:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
271 2021-09-08T17:12:02  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
272 2021-09-08T17:12:05  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 265 seconds)
273 2021-09-08T17:12:24  <sipa> laanwj: fixed; seems i just hadn't pulled in the latest upstream/22.x
274 2021-09-08T17:12:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
275 2021-09-08T17:12:50  <bitcoin-git> [bitcoin] mjdietzx opened pull request #22924: refactor: merge ScriptPubKeyToUniv and ScriptToUniv into a single function (master...refactor_ScriptToUniv) https://github.com/bitcoin/bitcoin/pull/22924
276 2021-09-08T17:12:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
277 2021-09-08T17:24:05  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
278 2021-09-08T17:24:39  *** gleb7 <gleb7!~gleb@> has joined #bitcoin-core-dev
279 2021-09-08T17:28:26  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
280 2021-09-08T17:31:18  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
281 2021-09-08T17:34:43  *** AaronvanW <AaronvanW!~AaronvanW@> has joined #bitcoin-core-dev
282 2021-09-08T17:37:45  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 252 seconds)
283 2021-09-08T17:38:32  <dongcarl> sipa: I will take a look at the branch right now, apologies I missed the release notes in the wiki stage
284 2021-09-08T17:38:57  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
285 2021-09-08T17:46:53  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 265 seconds)
286 2021-09-08T17:46:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
287 2021-09-08T17:46:54  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22925: test: Add missing suppression signed-integer-overflow:addrman.cpp (master...2109-testSupFuzz) https://github.com/bitcoin/bitcoin/pull/22925
288 2021-09-08T17:46:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
289 2021-09-08T17:47:32  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
290 2021-09-08T18:02:29  *** vysn <vysn!~vysn@user/vysn> has quit IRC (Quit: WeeChat 3.2)
291 2021-09-08T18:08:43  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
292 2021-09-08T18:11:17  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 252 seconds)
293 2021-09-08T18:11:24  *** Guyver2_ is now known as Guyver2
294 2021-09-08T18:12:09  *** saranshsharma <saranshsharma!~saranshsh@> has joined #bitcoin-core-dev
295 2021-09-08T18:16:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
296 2021-09-08T18:16:42  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/f75615ebdda9...a0988140b714
297 2021-09-08T18:16:42  <bitcoin-git> bitcoin/22.x 9f9ffe5 Pieter Wuille: Some small improvements to release notes
298 2021-09-08T18:16:42  <bitcoin-git> bitcoin/22.x a098814 W. J. van der Laan: Merge bitcoin/bitcoin#22921: Some small improvements to release notes
299 2021-09-08T18:16:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
300 2021-09-08T18:16:51  *** saranshsharma <saranshsharma!~saranshsh@> has quit IRC (Ping timeout: 265 seconds)
301 2021-09-08T18:17:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
302 2021-09-08T18:17:00  <bitcoin-git> [bitcoin] laanwj merged pull request #22921: Some small improvements to release notes (22.x...202109_22xrelease) https://github.com/bitcoin/bitcoin/pull/22921
303 2021-09-08T18:17:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
304 2021-09-08T18:17:18  <dongcarl> Hmm, is there an IRC channel just for C++ questions?
305 2021-09-08T18:17:24  <dongcarl> Can't seem to find any on libera
306 2021-09-08T18:17:38  <sipa> #c++ ?
307 2021-09-08T18:17:45  <sipa> (i haven't tried)
308 2021-09-08T18:18:06  <sipa> but stackoverflow probably works
309 2021-09-08T18:18:37  <dongcarl> oh dope that works
310 2021-09-08T18:19:09  <sipa> i would advise against using dope to answer C++ questions
311 2021-09-08T18:19:54  <dongcarl> 😬
312 2021-09-08T18:22:34  *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Quit: Client closed)
313 2021-09-08T18:22:45  *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
314 2021-09-08T18:23:39  <laanwj> it might help make undefined behavior more understandable
315 2021-09-08T18:24:58  <dongcarl> XP
316 2021-09-08T18:25:58  <shiza> C++ has no owner. Old days freenode would then have ##C++ as well...
317 2021-09-08T18:26:36  <shiza> But yes everything is in StackOverflow already.
318 2021-09-08T18:26:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
319 2021-09-08T18:26:54  <bitcoin-git> [bitcoin] laanwj pushed tag v22.0: https://github.com/bitcoin/bitcoin/compare/v22.0
320 2021-09-08T18:26:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
321 2021-09-08T18:27:04  <hebasto> \o/
322 2021-09-08T18:27:04  <achow101> \o/
323 2021-09-08T18:27:17  <shiza> You can go ask StackOverflow and your question be closed.
324 2021-09-08T18:27:24  <shiza> Congrats on the new release!
325 2021-09-08T18:29:04  <laanwj> ^^
326 2021-09-08T18:29:25  <dongcarl> hip hip hooray
327 2021-09-08T18:59:32  *** mxcl <mxcl!~mxcl@ec2-34-238-66-213.compute-1.amazonaws.com> has quit IRC (Quit: The Lounge - https://thelounge.chat)
328 2021-09-08T18:59:35  <jamesob> does this mean it's time for another guix build?
329 2021-09-08T18:59:53  <laanwj> jamesob: yep
330 2021-09-08T19:02:32  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
331 2021-09-08T19:13:11  <stick> wohooo 22.0 \o/
332 2021-09-08T19:17:21  <sipa> you take one up, pass it around, 22 cores of bitcoin on the wall
333 2021-09-08T19:17:36  <sipa> i guess that doesn't roll off the tongue that well
334 2021-09-08T19:18:38  <stick> 22 luftballons auf ihrem weg zum horizont :D
335 2021-09-08T19:18:58  <laanwj> hehe
336 2021-09-08T19:19:41  <b10c> \o/
337 2021-09-08T19:24:04  <dodo> nice
338 2021-09-08T19:25:51  <jb55> \o/ gj team
339 2021-09-08T19:32:04  <cfields> :)
340 2021-09-08T19:43:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
341 2021-09-08T19:43:11  <bitcoin-git> [bitcoin] hebasto closed pull request #22917: build: Copy appropriate MSVC build output to src/qt automatically (master...210908-copy) https://github.com/bitcoin/bitcoin/pull/22917
342 2021-09-08T19:43:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
343 2021-09-08T19:44:49  *** gleb7 <gleb7!~gleb@> has quit IRC (Ping timeout: 265 seconds)
344 2021-09-08T19:54:59  *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
345 2021-09-08T20:02:39  *** Guyver2_ <Guyver2_!~Guyver@2001:985:f3f:1:a12e:280:8f07:cc3a> has joined #bitcoin-core-dev
346 2021-09-08T20:03:40  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 265 seconds)
347 2021-09-08T20:03:49  *** Guyver2_ is now known as Guyver2
348 2021-09-08T20:14:54  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Quit: Konversation terminated!)
349 2021-09-08T20:28:13  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
350 2021-09-08T20:29:28  *** saranshsharma <saranshsharma!~saranshsh@> has joined #bitcoin-core-dev
351 2021-09-08T20:34:07  *** saranshsharma <saranshsharma!~saranshsh@> has quit IRC (Ping timeout: 265 seconds)
352 2021-09-08T20:39:45  <dongcarl> Wondering how our lock annotations interact with inheritance. Let's say I have "class A { virtual int foo() EXCLUSIVE_LOCK_REQUIRED(cs_a) = 0; }", and "class B { int foo() override EXCLUSIVE_LOCK_REQUIRED(cs_b) {  return 1 }; }", would calling B::foo lock both cs_a and cs_b?
353 2021-09-08T20:43:02  *** raj <raj!~raj_@> has quit IRC (Quit: Leaving)
354 2021-09-08T20:45:20  *** smartin <smartin!~Icedove@> has quit IRC (Ping timeout: 252 seconds)
355 2021-09-08T20:54:12  <dongcarl> s/lock both/require both/g
356 2021-09-08T21:02:56  <jonatack> dongcarl: IDK, but you have me reading https://clang.llvm.org/docs/ThreadSafetyAnalysis.html now :)
357 2021-09-08T21:09:23  <jonatack> https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#lexical-scope
358 2021-09-08T21:24:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
359 2021-09-08T21:24:08  <bitcoin-git> [bitcoin] hebasto opened pull request #22926: doc: Set PYTHONUTF8=1 for functional tests on Windows (master...210908-utf) https://github.com/bitcoin/bitcoin/pull/22926
360 2021-09-08T21:24:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
361 2021-09-08T21:42:34  <emzy> \o/
362 2021-09-08T21:48:55  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
363 2021-09-08T21:56:02  <cfields> dongcarl: I kinda doubt clang is smart enough to figure that out. It's very picky about requiring exact variables and iirc isn't able to follow copies or anything complicated...
364 2021-09-08T21:56:14  <cfields> that said, it should be easy enough to whip up a quick test-case and see :)
365 2021-09-08T21:57:27  <dongcarl> cfields: Yeah I did a quick test and you right
366 2021-09-08T21:57:53  <dongcarl> It's a dumb mechanism, oh well
367 2021-09-08T21:59:06  <cfields> dongcarl: could maybe use CRTP if static polymorphism is enough :)
368 2021-09-08T21:59:50  *** Guyver2 <Guyver2!~Guyver@2001:985:f3f:1:a12e:280:8f07:cc3a> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
369 2021-09-08T21:59:56  <cfields> (assuming it could even figure out that much)
370 2021-09-08T22:03:19  <dongcarl> Huh... Will read up on CRTP
371 2021-09-08T22:14:57  *** saranshsharma <saranshsharma!~saranshsh@> has joined #bitcoin-core-dev
372 2021-09-08T22:15:30  *** gene <gene!~gene@gateway/tor-sasl/gene> has joined #bitcoin-core-dev
373 2021-09-08T22:19:29  *** saranshsharma <saranshsharma!~saranshsh@> has quit IRC (Ping timeout: 265 seconds)
374 2021-09-08T22:19:50  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
375 2021-09-08T22:27:02  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 252 seconds)
376 2021-09-08T22:28:54  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 276 seconds)
377 2021-09-08T22:40:19  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
378 2021-09-08T22:55:40  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 252 seconds)
379 2021-09-08T23:05:24  *** saranshsharma <saranshsharma!~saranshsh@> has joined #bitcoin-core-dev
380 2021-09-08T23:10:14  *** saranshsharma <saranshsharma!~saranshsh@> has quit IRC (Ping timeout: 265 seconds)
381 2021-09-08T23:19:33  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
382 2021-09-08T23:34:18  *** lightlike <lightlike!~lightlike@user/lightlike> has quit IRC (Quit: Leaving)
383 2021-09-08T23:59:28  *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 256 seconds)