1 2021-09-17T00:17:29  *** belcher_ <belcher_!~belcher@user/belcher> has joined #bitcoin-core-dev
  2 2021-09-17T00:20:40  *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 240 seconds)
  3 2021-09-17T01:46:10  *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 240 seconds)
  4 2021-09-17T02:19:57  *** dviola <dviola!~diego@user/dviola> has quit IRC (Ping timeout: 265 seconds)
  5 2021-09-17T02:37:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
  6 2021-09-17T02:37:25  <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/6ef84e050399...f7189c4ce950
  7 2021-09-17T02:37:25  <bitcoin-git> bitcoin/master 65ed198 Sebastian Falbesoner: wallet: refactor: inline function ReadOrderPos()
  8 2021-09-17T02:37:25  <bitcoin-git> bitcoin/master 973d8ba Sebastian Falbesoner: wallet: refactor: inline function WriteOrderPos()
  9 2021-09-17T02:37:25  <bitcoin-git> bitcoin/master 98cf19c Sebastian Falbesoner: wallet: refactor: avoid duplicate lookup on `mapValue["timesmart"]`
 10 2021-09-17T02:37:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 11 2021-09-17T02:37:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 12 2021-09-17T02:37:42  <bitcoin-git> [bitcoin] fanquake merged pull request #22941: wallet: refactor: inline functions `{Read,Write}OrderPos` (master...202109-refactor-wallet-inline_readwrite_orderpos) https://github.com/bitcoin/bitcoin/pull/22941
 13 2021-09-17T02:37:43  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 14 2021-09-17T02:45:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 15 2021-09-17T02:45:46  <bitcoin-git> [bitcoin] ryanofsky opened pull request #23003: multiprocess: Make interfaces::Chain::isTaprootActive non-const (master...pr/ipc-tapc) https://github.com/bitcoin/bitcoin/pull/23003
 16 2021-09-17T02:45:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 17 2021-09-17T02:47:33  *** b10c <b10c!uid500648@id-500648.ilkley.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
 18 2021-09-17T02:47:43  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 19 2021-09-17T02:47:43  <bitcoin-git> [bitcoin] ryanofsky opened pull request #23004: multiprocess: Run external signer in wallet not node process (master...pr/ipc-signer) https://github.com/bitcoin/bitcoin/pull/23004
 20 2021-09-17T02:47:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 21 2021-09-17T02:50:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 22 2021-09-17T02:50:56  <bitcoin-git> [bitcoin] ryanofsky opened pull request #23005: multiprocess: Delay wallet client construction (master...pr/ipc-client) https://github.com/bitcoin/bitcoin/pull/23005
 23 2021-09-17T02:50:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 24 2021-09-17T03:01:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 25 2021-09-17T03:01:40  <bitcoin-git> [bitcoin] ryanofsky opened pull request #23006: multiprocess: Add new bitcoin-gui, bitcoin-qt, bitcoin-wallet init implementations (master...pr/ipc-init) https://github.com/bitcoin/bitcoin/pull/23006
 26 2021-09-17T03:01:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 27 2021-09-17T03:04:39  *** dviola <dviola!~diego@> has joined #bitcoin-core-dev
 28 2021-09-17T03:05:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 29 2021-09-17T03:05:48  <bitcoin-git> [bitcoin] fanquake closed pull request #22936: test: don't try and use os.killpg() on Windows (master...windows_no_killpg) https://github.com/bitcoin/bitcoin/pull/22936
 30 2021-09-17T03:05:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 31 2021-09-17T03:17:05  *** mersible <mersible!~mersible@> has quit IRC (Quit: Leaving)
 32 2021-09-17T03:25:30  *** dermoth <dermoth!~dermoth@user/dermoth> has quit IRC (Ping timeout: 260 seconds)
 33 2021-09-17T03:29:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 34 2021-09-17T03:29:13  <bitcoin-git> [bitcoin] fanquake opened pull request #23007: doc: remove WSL install instructions and point to upstream (master...remove_verbose_WSL_instructions) https://github.com/bitcoin/bitcoin/pull/23007
 35 2021-09-17T03:29:14  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 36 2021-09-17T03:37:50  *** dermoth <dermoth!~dermoth@user/dermoth> has joined #bitcoin-core-dev
 37 2021-09-17T04:21:42  *** Guest17 <Guest17!~Guest17@> has joined #bitcoin-core-dev
 38 2021-09-17T04:23:55  *** Guest17 <Guest17!~Guest17@> has quit IRC (Client Quit)
 39 2021-09-17T04:36:48  *** ArctVaulMarsHMPJ <ArctVaulMarsHMPJ!~pjetcetal@> has joined #bitcoin-core-dev
 40 2021-09-17T04:37:04  *** ArctVaulMarsHMPJ <ArctVaulMarsHMPJ!~pjetcetal@> has quit IRC (Read error: Connection reset by peer)
 41 2021-09-17T05:07:11  *** roconnor <roconnor!~roconnor@host-45-58-209-171.dyn.295.ca> has quit IRC (Ping timeout: 265 seconds)
 42 2021-09-17T05:28:26  *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
 43 2021-09-17T05:37:06  *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 260 seconds)
 44 2021-09-17T05:38:41  *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
 45 2021-09-17T05:43:20  *** Victorsueca <Victorsueca!~Victorsue@> has joined #bitcoin-core-dev
 46 2021-09-17T05:46:18  *** vnogueir- <vnogueir-!~vnogueira@user/vnogueira> has quit IRC (Ping timeout: 276 seconds)
 47 2021-09-17T06:00:55  *** kappa <kappa!~kappa@host-79-24-59-35.retail.telecomitalia.it> has joined #bitcoin-core-dev
 48 2021-09-17T06:06:07  *** AaronvanW <AaronvanW!~AaronvanW@> has quit IRC (Remote host closed the connection)
 49 2021-09-17T06:07:18  <shiza> `getnewaddress "" p2sh-segwit` or `getnewaddress "" bech32` seem to return P2PKH invoice addresses.
 50 2021-09-17T06:13:56  *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has joined #bitcoin-core-dev
 51 2021-09-17T06:17:48  *** babasancheti <babasancheti!~babasanch@> has joined #bitcoin-core-dev
 52 2021-09-17T06:18:42  <shiza> What's the first walletversion fully supporting P2SH?
 53 2021-09-17T06:19:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 54 2021-09-17T06:19:23  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f7189c4ce950...6401de0133e3
 55 2021-09-17T06:19:23  <bitcoin-git> bitcoin/master 1231338 James O'Beirne: doc: test: unittest segfault gdb
 56 2021-09-17T06:19:23  <bitcoin-git> bitcoin/master 6401de0 merge-script: Merge bitcoin/bitcoin#22226: doc: add unittest core dump instructions
 57 2021-09-17T06:19:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 58 2021-09-17T06:22:04  <shiza> I used `upgradewallet` without an argument, it seems it upgraded it to 169900, still seeming to be returning P2PKH invoice addresses.
 59 2021-09-17T06:26:23  <shiza> It upgraded to HD without request, does it mean pre-HD keys are lost?
 60 2021-09-17T06:27:07  *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has joined #bitcoin-core-dev
 61 2021-09-17T06:28:01  <shiza> I once used importprivkey on a contemporary wallet and it seemed to fail because being HD.
 62 2021-09-17T06:36:29  <shiza> I suppose I will park this wallet as a probably failed upgrade and stay with the pre-upgrade backup for actual use.
 63 2021-09-17T06:44:26  <meshcollider> shiza: upgradewallet won't delete your old keys, they'll still be there, don't worry
 64 2021-09-17T06:45:19  <meshcollider> Why do you think it failed?
 65 2021-09-17T06:46:19  <shiza> meshcollider: Because it apparently returns P2PKH invoice address for `getnewaddress "" p2sh-segwit` or `getnewaddress "" bech32`.
 66 2021-09-17T06:46:45  <shiza> Even after restarting bitcoind.
 67 2021-09-17T06:50:36  <meshcollider> shiza: you probably just need to clear out your keypool to start using the new addresses
 68 2021-09-17T06:51:00  <meshcollider> shiza: just call getnewaddress a bunch of times and it'll start working when all your uncompressed keys are "used"
 69 2021-09-17T06:51:03  <shiza> Oh I understand that, lemme test a thing.
 70 2021-09-17T06:52:40  <shiza> I batched it 2000 times and I now see invoice addresses aparently being P2SH. Thank you very much.
 71 2021-09-17T06:54:29  <shiza> I see nothing apparently being Bech32 or similar, but that doesn't worry me.
 72 2021-09-17T06:58:13  <shiza> Hah, after refilling the key pool, here are Bech32[m] invoice addresses.
 73 2021-09-17T06:58:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 74 2021-09-17T06:58:21  <bitcoin-git> [bitcoin] fanquake closed pull request #22226: doc: add unittest core dump instructions (master...2021-06-tests-core-dump) https://github.com/bitcoin/bitcoin/pull/22226
 75 2021-09-17T06:58:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 76 2021-09-17T06:59:49  *** kabaum <kabaum!~kabaum@h-46-59-13-35.a163.priv.bahnhof.se> has quit IRC (Ping timeout: 252 seconds)
 77 2021-09-17T07:13:34  *** kabaum <kabaum!~kabaum@h-46-59-13-35.A163.priv.bahnhof.se> has joined #bitcoin-core-dev
 78 2021-09-17T07:14:04  <meshcollider> shiza: no worries :)
 79 2021-09-17T07:36:14  *** Henrik <Henrik!~textual@> has joined #bitcoin-core-dev
 80 2021-09-17T07:42:33  *** earnestly <earnestly!~earnest@user/earnestly> has quit IRC (Quit: WeeChat 3.2)
 81 2021-09-17T07:44:08  *** earnestly <earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
 82 2021-09-17T07:47:32  *** belcher_ is now known as belcher
 83 2021-09-17T08:10:32  *** Henrik <Henrik!~textual@> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzz…)
 84 2021-09-17T08:29:00  *** smartin <smartin!~Icedove@> has joined #bitcoin-core-dev
 85 2021-09-17T08:29:57  *** Henrik <Henrik!~textual@> has joined #bitcoin-core-dev
 86 2021-09-17T08:33:47  *** Henrik <Henrik!~textual@> has quit IRC (Client Quit)
 87 2021-09-17T08:44:51  *** Henrik <Henrik!~textual@> has joined #bitcoin-core-dev
 88 2021-09-17T08:45:46  *** Henrik <Henrik!~textual@> has quit IRC (Client Quit)
 89 2021-09-17T08:46:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 90 2021-09-17T08:46:02  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #23008: ci: clang-13 msan (master...2109-ciMsan13) https://github.com/bitcoin/bitcoin/pull/23008
 91 2021-09-17T08:46:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 92 2021-09-17T08:54:49  <laanwj> i remember having this as well, we might want to document it better, or have an option to retire the current keypool immediately
 93 2021-09-17T08:58:27  *** jespada <jespada!~jespada@2803:9800:9842:7a62:95e0:d2b5:ae88:676> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 94 2021-09-17T09:10:31  *** Guest90 <Guest90!~Guest90@2405:201:a001:d083:9131:bc30:c42:541a> has joined #bitcoin-core-dev
 95 2021-09-17T09:11:03  *** Guest90 <Guest90!~Guest90@2405:201:a001:d083:9131:bc30:c42:541a> has quit IRC (Client Quit)
 96 2021-09-17T09:48:45  *** babasancheti <babasancheti!~babasanch@> has quit IRC (Quit: Connection closed)
 97 2021-09-17T09:50:17  *** babasancheti <babasancheti!~babasanch@> has joined #bitcoin-core-dev
 98 2021-09-17T09:58:26  *** Henrik <Henrik!~textual@> has joined #bitcoin-core-dev
 99 2021-09-17T09:59:54  *** Henrik <Henrik!~textual@> has quit IRC (Client Quit)
100 2021-09-17T10:16:53  *** jespada <jespada!~jespada@host244.190-3-30.dynamic.telmex.net.ar> has joined #bitcoin-core-dev
101 2021-09-17T10:54:53  <meshcollider> laanwj: agreed, I guess if it's a new backup you could use `sethdseed true` but that's pretty ugly
102 2021-09-17T10:56:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
103 2021-09-17T10:56:08  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #23014: ci: Misc updates (master...2109-ciUpdates) https://github.com/bitcoin/bitcoin/pull/23014
104 2021-09-17T10:56:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
105 2021-09-17T11:24:04  *** babasancheti <babasancheti!~babasanch@> has quit IRC (Quit: Connection closed)
106 2021-09-17T11:47:18  *** mersible <mersible!~mersible@> has joined #bitcoin-core-dev
107 2021-09-17T12:06:41  *** Henrik <Henrik!~textual@> has joined #bitcoin-core-dev
108 2021-09-17T12:09:16  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
109 2021-09-17T12:16:10  *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 240 seconds)
110 2021-09-17T12:26:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
111 2021-09-17T12:26:54  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6401de0133e3...e69cbac628bf
112 2021-09-17T12:26:54  <bitcoin-git> bitcoin/master 330d3aa Sebastian Falbesoner: refactor: net: avoid duplicate map lookups to `mapLocalHost`
113 2021-09-17T12:26:54  <bitcoin-git> bitcoin/master e69cbac merge-script: Merge bitcoin/bitcoin#22896: refactor: net: avoid duplicate map lookups to...
114 2021-09-17T12:26:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
115 2021-09-17T12:27:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
116 2021-09-17T12:27:10  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22896: refactor: net: avoid duplicate map lookups to `mapLocalHost` (master...202109-refactor-net-avoid_duplicate_mapLocalHost_lookups) https://github.com/bitcoin/bitcoin/pull/22896
117 2021-09-17T12:27:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
118 2021-09-17T12:33:04  *** Henrik <Henrik!~textual@> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzz…)
119 2021-09-17T12:34:55  *** Henrik <Henrik!~textual@> has joined #bitcoin-core-dev
120 2021-09-17T12:48:20  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
121 2021-09-17T12:52:27  *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
122 2021-09-17T13:07:07  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Quit: Konversation terminated!)
123 2021-09-17T13:09:32  *** Henrik <Henrik!~textual@> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzz…)
124 2021-09-17T13:10:10  *** Henrik <Henrik!~textual@> has joined #bitcoin-core-dev
125 2021-09-17T13:10:28  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
126 2021-09-17T13:22:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
127 2021-09-17T13:22:40  <bitcoin-git> [bitcoin] jonatack closed pull request #22999: bench: add `-quiet` and `-iters=<n>` benchmark config args (master...bench-add-quiet-and-iters-args) https://github.com/bitcoin/bitcoin/pull/22999
128 2021-09-17T13:22:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
129 2021-09-17T13:24:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
130 2021-09-17T13:24:30  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #23017: test: Replace MiniWallet scan_blocks with rescan_utxos (master...2109-testMiniWalletCleanup) https://github.com/bitcoin/bitcoin/pull/23017
131 2021-09-17T13:24:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
132 2021-09-17T13:25:56  *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has quit IRC (Quit: Konversation terminated!)
133 2021-09-17T13:27:30  <jonatack> Closed #22999, but it is fully operational and I will use its features for my own Bitcoin Core benchmarking. If anyone else would like to use them, they can cherry-pick that branch for their own use.
134 2021-09-17T13:27:32  <gribble> https://github.com/bitcoin/bitcoin/issues/22999 | bench: add `-quiet` and `-iters= ` benchmark config args by jonatack · Pull Request #22999 · bitcoin/bitcoin · GitHub
135 2021-09-17T13:29:23  <jonatack> For around a dozen lines of code it provides some handy functionality.
136 2021-09-17T13:49:42  *** goatpig <goatpig!~goat@h-94-254-2-155.A498.priv.bahnhof.se> has joined #bitcoin-core-dev
137 2021-09-17T13:57:42  *** tla2k21 <tla2k21!~tla2k21@gateway/tor-sasl/tla2k21> has quit IRC (Ping timeout: 276 seconds)
138 2021-09-17T14:03:55  <laanwj> any specific reason for closing?
139 2021-09-17T14:04:22  <shiza> meshcollider and laanwj: I'm going to repeat the same "test", just batching the ~2000 getnewaddress requests **before** upgrading the wallet. Wallet version is long older than Bech32 existed.
140 2021-09-17T14:05:24  <laanwj> make sure to disable new keypool generation first somehow, otherwise it will happily generate a new batch of keys
141 2021-09-17T14:08:28  <shiza> I think I don't understand that, but I'll make sure I don't lose invoice addresses or private keys unless on purpose.
142 2021-09-17T14:10:41  <shiza> I'm simply curious if p2sh-segwit and Bech32 invoice addresses have been added in a way that doesn't require upgrading the wallet (IDK how!).
143 2021-09-17T14:10:51  *** tla2k21 <tla2k21!~tla2k21@gateway/tor-sasl/tla2k21> has joined #bitcoin-core-dev
144 2021-09-17T14:21:28  <laanwj> oh i misunderstood, i thought you were trying to exhaust the keypool, which wouldn't happen because it keeps generating new addresses, but that's the idea
145 2021-09-17T14:22:44  <jonatack> laanwj: it looked like tough sell :) and i'm fine with just using it myself
146 2021-09-17T14:42:38  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
147 2021-09-17T14:43:41  <shiza> I requested it 3000 bech32 addresses and 2000 p2sh-segwit addresses, and apparently generated 5000 P2PKH invoice addresses.
148 2021-09-17T14:44:12  <sipa> shiza: is it a descriptor wallet or legacy wallet?
149 2021-09-17T14:44:49  <shiza> Wallet was first created around 2011 and never upgraded.
150 2021-09-17T14:45:05  <sipa> ok, so you have a legacy wallet - those don't distinguish between types of addresses
151 2021-09-17T14:45:34  <sipa> when you generate a new key, it always gets all three (p2pkh, p2wpkh, p2sh-p2pkh) address types
152 2021-09-17T14:46:02  <sipa> in descriptor wallets each of the address types is drawn from its own chain of keys
153 2021-09-17T14:52:33  *** earnestly <earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 268 seconds)
154 2021-09-17T14:53:19  *** prayank <prayank!~andr0irc@> has joined #bitcoin-core-dev
155 2021-09-17T14:53:57  <prayank> shiza: Have you tried using a label in the command?
156 2021-09-17T14:54:18  <prayank> getnewaddress "somelabel" bech32
157 2021-09-17T14:54:35  <shiza> Nope, just "", but I'll try right now.
158 2021-09-17T14:54:37  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
159 2021-09-17T14:55:28  <shiza> I think there might be something different in bitcoind, stdout...
160 2021-09-17T14:59:24  <shiza> Nah, no change, but that makes sense.
161 2021-09-17T15:00:37  <sipa> what is the problem?
162 2021-09-17T15:01:49  <shiza> Nothing really, this has been an edge use, it's understandable that can't output bech32 or P2SH if wallet version is so ancient.
163 2021-09-17T15:02:28  <sipa> what bitcoind version?
164 2021-09-17T15:02:29  <shiza> Several hours ago I upgraded the wallet and everything worked flawlessly.
165 2021-09-17T15:03:08  <shiza> (This is a different wallet from a backup pre upgrade and just a discard-wallet test).
166 2021-09-17T15:03:28  <shiza> Ehm this is v22.0rc3.
167 2021-09-17T15:03:38  <sipa> oh ok
168 2021-09-17T15:03:43  <sipa> and what RPC are you using?
169 2021-09-17T15:05:44  <shiza> I'm doing bash loops on /PATH/TO/bitcoin-cli -datadir=/PATH/TO/DATADIR/ getnewaddress STUFF (bech32|p2sh-segwit) redirecting stdout appending to some file
170 2021-09-17T15:06:08  <sipa> have you tried starting with -upgradewallet or issues upgradewallet RPC?
171 2021-09-17T15:06:13  <sipa> (you'll need a new backup)
172 2021-09-17T15:06:51  <shiza> Yeah, meshcollider helped me with that and that exact command worked fine.
173 2021-09-17T15:07:06  <shiza> I justd wanted to confuse the software on purpose.
174 2021-09-17T15:07:15  <sipa> i see
175 2021-09-17T15:07:17  <sipa> good testing
176 2021-09-17T15:08:47  <shiza> I suppose it could warn that won't ever generate bech32 on such an ancient wallet, but as long as it doesn't lose keys, this is robust enough for me.
177 2021-09-17T15:09:22  <sipa> i think it's a bug
178 2021-09-17T15:09:29  <sipa> it should be able to
179 2021-09-17T15:09:30  <sipa> oh!
180 2021-09-17T15:09:34  <sipa> 2011!
181 2021-09-17T15:09:46  <sipa> that means it may be using uncompressed pubkeys still
182 2021-09-17T15:09:51  <sipa> and those are incompatible with segwit
183 2021-09-17T15:10:01  <shiza> It's a 5 digits walletversion.
184 2021-09-17T15:10:43  <sipa> which one?
185 2021-09-17T15:11:52  <shiza> 1XXXX ·_·U
186 2021-09-17T15:12:29  *** earnestly <earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
187 2021-09-17T15:12:38  <sipa> yeah, that's pre compressed keys
188 2021-09-17T15:13:15  <shiza> I think meshc. figured it somehow.
189 2021-09-17T15:13:44  <shiza> But I don't know about compressed keys because I've been living under a rock.
190 2021-09-17T15:13:58  <sipa> valid numbers are 10500 (ancient), 40000 (encryption), 60000 (compressed keys), 130000 (hd), 139900 (split hd), 159900 (removed default key), 169900 (split keypool)
191 2021-09-17T15:14:35  <prayank> Transactions involving pre compressed keys won't even be standard imo
192 2021-09-17T15:14:53  <sipa> prayank: they are
193 2021-09-17T15:15:10  <sipa> prayank: only in segwit they aren't
194 2021-09-17T15:15:22  <prayank> Okay
195 2021-09-17T15:15:27  <sipa> (which is why his uncompressed-pubkey wallet refuses to generate segwit addresses)
196 2021-09-17T15:15:49  <sipa> shiza: in any case, compressed pubkeys were introduced in november 2011 :)
197 2021-09-17T15:15:59  <sipa> about time you start using them ;)
198 2021-09-17T15:17:20  <shiza> I'm a woman.
199 2021-09-17T15:17:35  <shiza> First transaction is from october, that's for sure.
200 2021-09-17T15:17:45  <sipa> shiza: my apologies!
201 2021-09-17T15:17:50  <shiza> np
202 2021-09-17T15:34:04  *** prayank <prayank!~andr0irc@> has quit IRC (Ping timeout: 265 seconds)
203 2021-09-17T15:38:26  *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
204 2021-09-17T15:40:30  *** gleb7 <gleb7!~gleb@> has quit IRC (Ping timeout: 260 seconds)
205 2021-09-17T15:51:56  *** AaronvanW <AaronvanW!~AaronvanW@> has joined #bitcoin-core-dev
206 2021-09-17T15:56:00  <shiza> Again thank you all very much.
207 2021-09-17T15:56:08  <shiza> Round of booze on me (at 2021 prices).
208 2021-09-17T16:10:10  <jamesob> Hey, do we not upload unsigned binaries to bitcoincore.org? There are hashes listed for '*-unsigned' binaries in SHA256SUMS, but they aren't present at https://bitcoincore.org/bin/bitcoin-core-22.0/
209 2021-09-17T16:10:14  <jamesob> cc BlueMatt
210 2021-09-17T16:10:36  <jamesob> no big deal if not, just want to be aware if we have an explicit policy about that
211 2021-09-17T16:10:45  <BlueMatt> ask dongcarl
212 2021-09-17T16:11:02  *** Aaronvan_ <Aaronvan_!~AaronvanW@> has joined #bitcoin-core-dev
213 2021-09-17T16:11:05  *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 252 seconds)
214 2021-09-17T16:11:07  <BlueMatt> but that feels right?
215 2021-09-17T16:11:26  <BlueMatt> like, no reason for someone to want a binary that their shitty os wont let them run when the only difference is presence of a signature and cert?
216 2021-09-17T16:11:55  <dongcarl> I think we don't upload the unsigned _tarballs_
217 2021-09-17T16:12:02  <dongcarl> but we do upload the unsigned binaries
218 2021-09-17T16:12:12  <dongcarl> e.g. bitcoin-0.21.0-win64-setup-unsigned.exe
219 2021-09-17T16:13:00  <dongcarl> In any case, most people will need the --ignore-missing flag of sha256sum anyway
220 2021-09-17T16:14:35  *** AaronvanW <AaronvanW!~AaronvanW@> has quit IRC (Ping timeout: 260 seconds)
221 2021-09-17T16:15:02  <jamesob> dongcarl: bitcoin-22.0-osx-unsigned.dmg exists in SHA256SUMS but not as a binary on bitcoincore.org
222 2021-09-17T16:15:42  <jamesob> I'm not running into any CLI errors, just trying to nail down our policy since there's a disparity here
223 2021-09-17T16:17:13  <dongcarl> What's strange is that if you look at 0.21: https://bitcoincore.org/bin/bitcoin-core-0.21.0/
224 2021-09-17T16:17:14  <sipa> i guess because for macOS we only distribute the installer and not the binary individually?
225 2021-09-17T16:17:29  <dongcarl> We have bitcoin-0.21.0-win64-setup-unsigned.exe but not bitcoin-0.21.0-osx-unsigned.dmg
226 2021-09-17T16:17:30  <sipa> btw, somewhat relevant, if someone wants to answer: https://bitcoin.stackexchange.com/questions/109706/full-node-install-upgrade-question
227 2021-09-17T16:17:44  <sipa> dongcarl: oh, nvm, seems like just an inconsistency then
228 2021-09-17T16:19:07  <dongcarl> To me it seems fine if we just distribute the codesigned ones
229 2021-09-17T16:23:24  <theStack> talking about inconsistencies, what i noticed recently was that the verify.py script fails on some versions because the SHA256SUMS.asc files on bitcoin.org and bitcoincore.org differ, e.g. for 0.21.0
230 2021-09-17T16:39:55  <sipa> theStack: that's intentional
231 2021-09-17T16:40:32  <BlueMatt> huh?!
232 2021-09-17T16:40:55  <BlueMatt> is someone else signing the files on bitcoin.org?
233 2021-09-17T16:41:23  <sipa> oh
234 2021-09-17T16:41:26  <sipa> i misread, sorry
235 2021-09-17T16:41:34  <BlueMatt> no, that's very surprising.
236 2021-09-17T16:42:06  <sipa> yes, it is - i'm saying i was wrong to say that was intentional
237 2021-09-17T16:42:18  *** Henrik <Henrik!~textual@> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzz…)
238 2021-09-17T16:43:59  <BlueMatt> huh. bitcoincore.org has bitcoin-0.21.0-win64-setup-unsigned.exe but bitcoin.org has bitcoin-0.21.0-win64-setup-unsigned.exe
239 2021-09-17T16:44:02  <BlueMatt> that seems strange?
240 2021-09-17T16:44:46  <BlueMatt> laanwj: do you know why bitcoincore.org is missing the signed win64 setup exe?
241 2021-09-17T16:45:21  <sipa> BlueMatt: you're listing the same filename twice
242 2021-09-17T16:45:38  <BlueMatt> oh, sorry, bitcoin.org has bitcoin-0.21.0-win64-setup.exe
243 2021-09-17T16:45:49  <BlueMatt> bitcoincore.org only has the unsigned one, bitcoin.org only has the signed one
244 2021-09-17T16:46:44  <sipa> strange
245 2021-09-17T16:46:56  <BlueMatt> very
246 2021-09-17T16:51:42  *** kappa <kappa!~kappa@host-79-24-59-35.retail.telecomitalia.it> has quit IRC (Quit: Client closed)
247 2021-09-17T16:59:42  *** bairen <bairen!~bairen@gateway/tor-sasl/bairen> has quit IRC (Ping timeout: 276 seconds)
248 2021-09-17T17:01:20  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
249 2021-09-17T17:01:53  *** bairen <bairen!~bairen@gateway/tor-sasl/bairen> has joined #bitcoin-core-dev
250 2021-09-17T17:07:04  *** bairen <bairen!~bairen@gateway/tor-sasl/bairen> has quit IRC (Remote host closed the connection)
251 2021-09-17T17:07:22  *** bairen <bairen!~bairen@gateway/tor-sasl/bairen> has joined #bitcoin-core-dev
252 2021-09-17T17:31:16  <BlueMatt> very
253 2021-09-17T17:31:20  <BlueMatt> oops
254 2021-09-17T17:35:59  <laanwj> BlueMatt: there was a problem with that signed version and we had to remove it Iirc
255 2021-09-17T17:36:15  <BlueMatt> ah, so it was not removed from bitcoin.org, only bitcoincore.org? ugh
256 2021-09-17T17:36:23  <laanwj> like, the signining key was revoked
257 2021-09-17T17:36:27  <laanwj> achow101 knows more
258 2021-09-17T17:36:28  <BlueMatt> lol, right
259 2021-09-17T17:36:40  <BlueMatt> man this whole binary-signing security theatre thing is annoying
260 2021-09-17T17:37:04  <BlueMatt> the cargo cult of CAs solving *everything* is obnoxious
261 2021-09-17T17:37:12  <sipa> "man this security theatre thing is annoying" FTFY
262 2021-09-17T17:37:15  <laanwj> i only upload binaries to bitcoincore.org, i don't know whoever manages bitcoin.org/bin these days
263 2021-09-17T17:37:32  <BlueMatt> sipa: heh, true
264 2021-09-17T17:38:14  <achow101> For 0.21.0 and 0.21.1, we uploaded the non-codesigned windows bins
265 2021-09-17T17:39:04  <achow101> laanwj: I think cobra is mirroring them
266 2021-09-17T17:39:18  <laanwj> achow101: probably!
267 2021-09-17T17:40:13  <laanwj> in any case to answer jamesob, we generally only upload the codesigned ones, no need to confuse the user with extra non-codesigned ones (except when codesigning doesn't work)
268 2021-09-17T17:40:44  <laanwj> there's a lot of stuff in the SHA256SUMS that isn't distributed, because it would be confusing or just impracticly big, like the debug information
269 2021-09-17T17:42:05  <laanwj> it's still useful to list them; the nice thing about deterministic building is that if you do your own build, you know which hashes to expect
270 2021-09-17T17:45:40  <sipa> laanwj: makes sense
271 2021-09-17T17:46:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
272 2021-09-17T17:46:39  <bitcoin-git> [bitcoin] lsilva01 opened pull request #23019: rpc: Add listaddresses RPC (master...list_addresses_rpc) https://github.com/bitcoin/bitcoin/pull/23019
273 2021-09-17T17:46:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
274 2021-09-17T17:53:45  *** Guest52 <Guest52!~Guest52@> has joined #bitcoin-core-dev
275 2021-09-17T18:04:16  *** Henrik <Henrik!~textual@> has joined #bitcoin-core-dev
276 2021-09-17T18:06:15  *** tla2k21 <tla2k21!~tla2k21@gateway/tor-sasl/tla2k21> has quit IRC (Remote host closed the connection)
277 2021-09-17T18:06:27  *** tla2k21 <tla2k21!~tla2k21@gateway/tor-sasl/tla2k21> has joined #bitcoin-core-dev
278 2021-09-17T18:07:32  *** Guest52 <Guest52!~Guest52@> has quit IRC (Quit: Client closed)
279 2021-09-17T18:32:58  *** Aaronvan_ is now known as AaronvanW
280 2021-09-17T18:58:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
281 2021-09-17T18:58:08  <bitcoin-git> [bitcoin] jamesob opened pull request #23020: fix: contrib: allow multi-sig binary verification (master...2021-09-binary-verify) https://github.com/bitcoin/bitcoin/pull/23020
282 2021-09-17T18:58:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
283 2021-09-17T18:59:37  <jamesob> Alright, new binary verification script up ^. I'll start working on a bitcoincore.org update. cc laanwj theStack dongcarl BlueMatt
284 2021-09-17T18:59:40  *** jesseposner <jesseposner!~jesse@c-24-5-105-39.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 240 seconds)
285 2021-09-17T19:22:13  <laanwj> jamesob: awesome!
286 2021-09-17T19:27:58  *** bomb-on <bomb-on!~bomb-on@> has joined #bitcoin-core-dev
287 2021-09-17T19:28:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
288 2021-09-17T19:28:12  <bitcoin-git> [bitcoin] Sjors opened pull request #23021: net: switch to signet DNS seed (master...2021/09/signet_dns_seed) https://github.com/bitcoin/bitcoin/pull/23021
289 2021-09-17T19:28:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
290 2021-09-17T19:30:52  <provoostenator> ^ could probably use an additional DNS seed if anyone feels like spinning one up
291 2021-09-17T19:50:34  *** smartin <smartin!~Icedove@> has quit IRC (Quit: smartin)
292 2021-09-17T19:52:00  <jamesob> provoostenator: yeah that's been on my todo list for awhile
293 2021-09-17T19:52:08  *** Henrik <Henrik!~textual@> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzz…)
294 2021-09-17T19:52:55  <BlueMatt> provoostenator: fwiw, i dont think dynamic dns seeds are very useful on test networks. for a long time testnet3 basically only worked because my testnet dnsseed was just a static list of nodes that were actually online and had all the data to sync from.
295 2021-09-17T19:54:14  <BlueMatt> (not to say dnsseeds shouldnt be added, but they may be better off with just a static list and not the standard network crawlers)
296 2021-09-17T19:56:34  *** Henrik <Henrik!~textual@> has joined #bitcoin-core-dev
297 2021-09-17T19:56:51  *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
298 2021-09-17T20:00:41  *** prayank <prayank!~andr0irc@> has joined #bitcoin-core-dev
299 2021-09-17T20:00:53  <prayank> https://github.com/bitcoin/bitcoin/issues/23016#issuecomment-922036386
300 2021-09-17T20:00:59  <prayank> This is malware
301 2021-09-17T20:02:54  *** prayank <prayank!~andr0irc@> has quit IRC (Client Quit)
302 2021-09-17T20:16:00  <sipa> banned
303 2021-09-17T20:47:50  *** Henrik <Henrik!~textual@> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzz…)
304 2021-09-17T20:55:03  *** Henrik <Henrik!~textual@> has joined #bitcoin-core-dev
305 2021-09-17T21:03:02  *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
306 2021-09-17T21:07:49  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
307 2021-09-17T21:25:23  *** Henrik <Henrik!~textual@> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzz…)
308 2021-09-17T21:28:15  <harding> kallewoof: do you maintain https://signetfaucet.com/ ?  If so, FYI, it seems to timeout with a "gateway error" on bech32m addresses (without and with captcha); works fine with P2WPKH bech32 addresses (only tried with captcha).
309 2021-09-17T21:39:39  *** TallTim_ <TallTim_!~TallTim@184-83-239-155-dynamic.midco.net> has joined #bitcoin-core-dev
310 2021-09-17T21:40:29  *** TallTim <TallTim!~TallTim@184-83-239-155-dynamic.midco.net> has quit IRC (Ping timeout: 252 seconds)
311 2021-09-17T21:53:04  *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 252 seconds)
312 2021-09-17T22:28:22  *** jesseposner <jesseposner!~jesse@c-24-5-105-39.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
313 2021-09-17T22:31:21  *** kappa <kappa!~kappa@host-79-24-59-35.retail.telecomitalia.it> has joined #bitcoin-core-dev
314 2021-09-17T22:43:46  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
315 2021-09-17T23:07:34  *** kappa <kappa!~kappa@host-79-24-59-35.retail.telecomitalia.it> has quit IRC (Ping timeout: 256 seconds)
316 2021-09-17T23:22:33  *** c_arc <c_arc!~c_arc@> has joined #bitcoin-core-dev
317 2021-09-17T23:25:40  *** sdaftuar1 <sdaftuar1!~sdaftuar@user/sdaftuar> has joined #bitcoin-core-dev
318 2021-09-17T23:27:51  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
319 2021-09-17T23:31:52  *** c_arc <c_arc!~c_arc@> has quit IRC (Remote host closed the connection)
320 2021-09-17T23:32:00  *** c_arc <c_arc!~c_arc@> has joined #bitcoin-core-dev
321 2021-09-17T23:38:22  *** c_arc <c_arc!~c_arc@> has quit IRC (Remote host closed the connection)
322 2021-09-17T23:38:29  *** c_arc <c_arc!~c_arc@> has joined #bitcoin-core-dev
323 2021-09-17T23:47:27  *** c_arc <c_arc!~c_arc@> has quit IRC (Remote host closed the connection)
324 2021-09-17T23:47:36  *** c_arc <c_arc!~c_arc@> has joined #bitcoin-core-dev
325 2021-09-17T23:54:48  *** c_arc <c_arc!~c_arc@> has quit IRC (Remote host closed the connection)
326 2021-09-17T23:54:56  *** c_arc <c_arc!~c_arc@> has joined #bitcoin-core-dev
327 2021-09-17T23:58:56  *** c_arc <c_arc!~c_arc@> has quit IRC (Remote host closed the connection)
328 2021-09-17T23:59:04  *** c_arc <c_arc!~c_arc@> has joined #bitcoin-core-dev