12021-09-30T00:00:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
22021-09-30T00:00:29 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
32021-09-30T00:04:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
42021-09-30T00:04:19 <bitcoin-git> [bitcoin] meshcollider opened pull request #23141: Fix intermitent failure in wallet_basic.py (master...202109_fix_test_rounding) https://github.com/bitcoin/bitcoin/pull/23141
52021-09-30T00:04:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
62021-09-30T00:08:38 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
72021-09-30T00:08:46 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
82021-09-30T00:09:38 *** AaronvanW <AaronvanW!~AaronvanW@190.242.161.186> has quit IRC (Quit: Leaving...)
92021-09-30T00:15:10 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
102021-09-30T00:15:18 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
112021-09-30T00:19:29 *** c_arc_ <c_arc_!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
122021-09-30T00:19:29 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
132021-09-30T00:23:29 *** c_arc_ <c_arc_!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
142021-09-30T00:23:37 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
152021-09-30T00:27:38 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
162021-09-30T00:27:45 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
172021-09-30T00:37:16 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
182021-09-30T00:37:24 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
192021-09-30T00:44:22 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
202021-09-30T00:44:30 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
212021-09-30T00:48:30 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
222021-09-30T00:48:39 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
232021-09-30T00:53:07 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
242021-09-30T00:53:07 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/419afa93419e...69a66dcd0dac
252021-09-30T00:53:07 <bitcoin-git> bitcoin/master 2b90eae fanquake: doc: update developer docs for subtree renaming
262021-09-30T00:53:07 <bitcoin-git> bitcoin/master 69a66dc fanquake: Merge bitcoin/bitcoin#23126: doc: update developer docs for subtree renami...
272021-09-30T00:53:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
282021-09-30T00:53:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
292021-09-30T00:53:23 <bitcoin-git> [bitcoin] fanquake merged pull request #23126: doc: update developer docs for subtree renaming (master...document_subtree_renaming) https://github.com/bitcoin/bitcoin/pull/23126
302021-09-30T00:53:24 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
312021-09-30T00:57:25 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
322021-09-30T00:57:34 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
332021-09-30T00:57:44 *** prayank <prayank!~andr0irc@51.15.0.88> has quit IRC (Quit: irc thread exit)
342021-09-30T01:00:08 *** jawed <jawed!~jawed@195.181.160.175.adsl.inet-telecom.org> has joined #bitcoin-core-dev
352021-09-30T01:00:20 <jawed> BIP meeting is happening nowish?
362021-09-30T01:04:08 <michaelfolkson> jawed: Happened on #bitcoin-dev channel. I'll send a summary and a conversation log to the mailing list
372021-09-30T01:04:25 <jawed> michaelfolkson thanks look like I had the wrong time
382021-09-30T01:05:22 *** jawed <jawed!~jawed@195.181.160.175.adsl.inet-telecom.org> has left #bitcoin-core-dev
392021-09-30T01:09:23 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
402021-09-30T01:09:31 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
412021-09-30T01:13:31 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
422021-09-30T01:13:39 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
432021-09-30T01:19:56 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
442021-09-30T01:20:04 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
452021-09-30T01:24:04 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
462021-09-30T01:24:12 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
472021-09-30T01:28:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
482021-09-30T01:28:20 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
492021-09-30T01:32:20 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
502021-09-30T01:32:28 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
512021-09-30T01:36:28 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
522021-09-30T01:36:37 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
532021-09-30T01:39:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
542021-09-30T01:39:01 <bitcoin-git> [bitcoin] meshcollider opened pull request #23142: Return false on corrupt tx rather than asserting (master...202109_no_assert_corruption) https://github.com/bitcoin/bitcoin/pull/23142
552021-09-30T01:39:02 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
562021-09-30T01:43:02 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
572021-09-30T01:43:09 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
582021-09-30T01:44:00 *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-49f9-d8e9-21a2-a096.res6.spectrum.com> has quit IRC (Quit: jarthur)
592021-09-30T01:48:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
602021-09-30T01:48:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
612021-09-30T01:52:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
622021-09-30T01:52:16 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
632021-09-30T01:53:59 *** lukedashjr <lukedashjr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
642021-09-30T01:55:42 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 268 seconds)
652021-09-30T01:56:09 *** lukedashjr is now known as luke-jr
662021-09-30T01:56:59 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Client Quit)
672021-09-30T01:57:18 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
682021-09-30T01:58:37 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
692021-09-30T02:00:34 *** hex17or <hex17or!~hex17or@gateway/tor-sasl/hex17or> has quit IRC (Remote host closed the connection)
702021-09-30T02:01:10 *** hex17or <hex17or!~hex17or@gateway/tor-sasl/hex17or> has joined #bitcoin-core-dev
712021-09-30T02:03:34 *** commmon <commmon!~common@096-033-221-075.res.spectrum.com> has joined #bitcoin-core-dev
722021-09-30T02:06:30 *** common <common!~common@096-033-221-075.res.spectrum.com> has quit IRC (Ping timeout: 250 seconds)
732021-09-30T02:12:28 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
742021-09-30T02:12:36 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
752021-09-30T02:16:36 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
762021-09-30T02:16:45 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
772021-09-30T02:20:45 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
782021-09-30T02:20:53 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
792021-09-30T02:23:31 *** earnestly <earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 252 seconds)
802021-09-30T02:27:58 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
812021-09-30T02:28:06 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
822021-09-30T02:29:05 *** Henrik <Henrik!~textual@84.212.107.177> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzzâ¦)
832021-09-30T02:33:05 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
842021-09-30T02:33:14 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
852021-09-30T02:37:14 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
862021-09-30T02:37:25 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
872021-09-30T02:41:47 <jarolrod> fanquake: please delete these comments https://github.com/bitcoin-core/gui/pull/437#issuecomment-930703150
882021-09-30T02:41:52 <jarolrod> maybe also ban that user
892021-09-30T02:54:26 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
902021-09-30T02:54:33 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
912021-09-30T02:58:33 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
922021-09-30T02:58:42 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
932021-09-30T03:02:43 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
942021-09-30T03:02:51 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
952021-09-30T03:06:52 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
962021-09-30T03:07:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
972021-09-30T03:11:01 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
982021-09-30T03:11:09 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
992021-09-30T03:15:10 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1002021-09-30T03:15:17 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1012021-09-30T03:18:54 *** dviola <dviola!~diego@user/dviola> has quit IRC (Ping timeout: 265 seconds)
1022021-09-30T03:25:44 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1032021-09-30T03:25:52 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1042021-09-30T03:30:50 *** saranshsharma <saranshsharma!~saranshsh@202.142.81.26> has joined #bitcoin-core-dev
1052021-09-30T03:34:50 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1062021-09-30T03:34:59 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1072021-09-30T03:38:59 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1082021-09-30T03:39:09 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1092021-09-30T03:41:55 *** dviola <dviola!~diego@179.235.12.99> has joined #bitcoin-core-dev
1102021-09-30T03:45:55 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1112021-09-30T03:46:05 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1122021-09-30T03:50:05 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1132021-09-30T03:50:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1142021-09-30T03:54:14 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1152021-09-30T03:54:22 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1162021-09-30T03:58:00 *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-f169-568c-84c0-edb5.res6.spectrum.com> has joined #bitcoin-core-dev
1172021-09-30T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
1182021-09-30T04:01:14 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
1192021-09-30T04:04:02 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
1202021-09-30T04:04:16 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
1212021-09-30T04:05:16 *** saranshsharma <saranshsharma!~saranshsh@202.142.81.26> has quit IRC (Remote host closed the connection)
1222021-09-30T04:06:56 *** saranshsharma <saranshsharma!~saranshsh@202.142.81.26> has joined #bitcoin-core-dev
1232021-09-30T04:10:56 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1242021-09-30T04:11:04 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1252021-09-30T04:22:39 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1262021-09-30T04:22:47 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1272021-09-30T04:26:17 *** dermoth <dermoth!~dermoth@user/dermoth> has quit IRC (Ping timeout: 252 seconds)
1282021-09-30T04:31:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1292021-09-30T04:31:09 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1302021-09-30T04:35:09 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1312021-09-30T04:35:17 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1322021-09-30T04:39:18 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1332021-09-30T04:39:25 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1342021-09-30T04:43:26 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1352021-09-30T04:43:34 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1362021-09-30T04:47:35 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1372021-09-30T04:47:43 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1382021-09-30T04:51:43 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1392021-09-30T04:51:51 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1402021-09-30T04:55:52 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1412021-09-30T04:56:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1422021-09-30T05:00:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1432021-09-30T05:00:09 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1442021-09-30T05:02:22 *** jespada <jespada!~jespada@2803:9800:9842:7a62:9cdc:f08c:7ab8:bd6a> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1452021-09-30T05:09:25 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1462021-09-30T05:09:33 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1472021-09-30T05:13:41 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1482021-09-30T05:13:49 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1492021-09-30T05:17:50 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1502021-09-30T05:17:58 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1512021-09-30T05:22:32 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1522021-09-30T05:22:40 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1532021-09-30T05:25:03 *** saranshsharma <saranshsharma!~saranshsh@202.142.81.26> has quit IRC (Remote host closed the connection)
1542021-09-30T05:29:03 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1552021-09-30T05:29:07 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1562021-09-30T05:29:12 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1572021-09-30T05:29:22 *** saranshs_ <saranshs_!~saranshsh@106.211.129.29> has joined #bitcoin-core-dev
1582021-09-30T05:32:37 *** saranshs_ <saranshs_!~saranshsh@106.211.129.29> has quit IRC (Remote host closed the connection)
1592021-09-30T05:33:58 *** saranshsharma <saranshsharma!~saranshsh@202.142.81.85> has joined #bitcoin-core-dev
1602021-09-30T05:42:55 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1612021-09-30T05:43:03 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1622021-09-30T05:53:46 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1632021-09-30T05:53:54 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1642021-09-30T05:57:54 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1652021-09-30T05:58:02 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1662021-09-30T06:00:02 <laanwj> jarolrod: blocked them
1672021-09-30T06:04:02 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1682021-09-30T06:04:10 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1692021-09-30T06:08:10 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1702021-09-30T06:08:18 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1712021-09-30T06:10:09 *** Nebraskka <Nebraskka!~Nebraskka@user/nebraskka> has quit IRC (Quit: Good day old chaps)
1722021-09-30T06:12:29 *** Nebraskka <Nebraskka!~Nebraskka@user/nebraskka> has joined #bitcoin-core-dev
1732021-09-30T06:16:29 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1742021-09-30T06:16:37 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1752021-09-30T06:20:37 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1762021-09-30T06:20:46 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1772021-09-30T06:21:19 *** commmon <commmon!~common@096-033-221-075.res.spectrum.com> has quit IRC (Remote host closed the connection)
1782021-09-30T06:22:46 *** commmon <commmon!~common@096-033-221-075.res.spectrum.com> has joined #bitcoin-core-dev
1792021-09-30T06:29:05 *** smartin <smartin!~Icedove@88.135.18.171> has joined #bitcoin-core-dev
1802021-09-30T06:34:32 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1812021-09-30T06:34:40 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1822021-09-30T06:38:41 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1832021-09-30T06:38:49 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1842021-09-30T06:40:05 *** saranshsharma <saranshsharma!~saranshsh@202.142.81.85> has quit IRC (Remote host closed the connection)
1852021-09-30T06:40:25 *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
1862021-09-30T06:46:28 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1872021-09-30T06:46:36 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1882021-09-30T06:51:42 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1892021-09-30T06:51:50 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1902021-09-30T06:59:06 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1912021-09-30T06:59:14 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1922021-09-30T07:01:41 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1932021-09-30T07:10:01 *** Nebraskka <Nebraskka!~Nebraskka@user/nebraskka> has quit IRC (Quit: Good day old chaps)
1942021-09-30T07:10:59 *** Nebraskka <Nebraskka!~Nebraskka@user/nebraskka> has joined #bitcoin-core-dev
1952021-09-30T07:15:51 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1962021-09-30T07:16:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1972021-09-30T07:20:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1982021-09-30T07:20:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1992021-09-30T07:22:20 *** saranshsharma <saranshsharma!~saranshsh@202.142.81.26> has joined #bitcoin-core-dev
2002021-09-30T07:26:21 *** saranshsharma <saranshsharma!~saranshsh@202.142.81.26> has quit IRC (Ping timeout: 245 seconds)
2012021-09-30T07:30:25 *** mikehu44 <mikehu44!~quassel@206.189.41.250> has joined #bitcoin-core-dev
2022021-09-30T07:35:48 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2032021-09-30T07:35:57 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2042021-09-30T07:39:57 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2052021-09-30T07:40:05 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2062021-09-30T07:46:29 *** adiabat <adiabat!~adiabat@63.209.32.102> has quit IRC (Ping timeout: 252 seconds)
2072021-09-30T07:47:32 *** adiabat <adiabat!~adiabat@63.209.32.102> has joined #bitcoin-core-dev
2082021-09-30T07:49:06 <jonatack> meshcollider: was looking into it too and updated that assertion helper in #23136 â¦Ëâ¡Ëâ£
2092021-09-30T07:49:07 <gribble> https://github.com/bitcoin/bitcoin/issues/23136 | test: update fee rate assertion helper in the functional test framework by jonatack · Pull Request #23136 · bitcoin/bitcoin · GitHub
2102021-09-30T07:54:38 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2112021-09-30T07:54:46 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2122021-09-30T07:55:04 <S3RK> #proposedwalletmeetingtopic two descriptors generating same scriptpubkey
2132021-09-30T07:59:04 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2142021-09-30T07:59:11 *** Henrik <Henrik!~textual@84.212.107.177> has joined #bitcoin-core-dev
2152021-09-30T07:59:12 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2162021-09-30T08:00:06 <vasild> laanwj: right, a "node" victim.com:80 that never speaks bitcoin p2p would propagate less and fall out of addrmans. So a rate from a well propagated real bitcoin node with public ipv4 address and port 80 would give an upper bound. If that is not high enough to be considered as a dos attack, then a lower number will also not be.
2172021-09-30T08:01:27 <vasild> s/and port 80/and port 8333/
2182021-09-30T08:05:28 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2192021-09-30T08:05:35 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2202021-09-30T08:10:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2212021-09-30T08:10:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2222021-09-30T08:10:40 *** dermoth <dermoth!~dermoth@dsl-199-102-159-155.mtl.aei.ca> has joined #bitcoin-core-dev
2232021-09-30T08:11:18 <laanwj> vasild: okay, good point
2242021-09-30T08:13:52 *** earnestly <earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
2252021-09-30T08:16:51 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2262021-09-30T08:16:52 <bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/69a66dcd0dac...f52929063f48
2272021-09-30T08:16:52 <bitcoin-git> bitcoin/master 489060d Hennadii Stepanov: qt: Do not show unused widgets at startup
2282021-09-30T08:16:52 <bitcoin-git> bitcoin/master f529290 Hennadii Stepanov: Merge bitcoin-core/gui#439: Do not show unused widgets at startup
2292021-09-30T08:16:53 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2302021-09-30T08:17:23 <_aj_> vasild: would it propogate less? i didn't think whether you'd tested a node influenced its propogation?
2312021-09-30T08:19:37 <vasild> _aj_: I did not test whether it will propagate less, but the point is that it is an _upper bound_ (even if it propagates equally well). But anyway, I _guess_ it will propagate less because it will drop from some addrmans.
2322021-09-30T08:21:15 <vasild> during gossip we don't test a peer (try to connect to it) and we gossip it regardless, but I think this "initial" propagation is not enough to get the peer in everybody's addrmans.
2332021-09-30T08:21:41 <_aj_> vasild: no it's not, but all propogation is just repeats of this "initial" propogation
2342021-09-30T08:22:02 <vasild> getaddr?
2352021-09-30T08:25:58 *** fedecuci <fedecuci!~fedecuci@ww090827.uvt.nl> has joined #bitcoin-core-dev
2362021-09-30T08:29:17 <_aj_> vasild: hmm, does that count for a non-trivial number of addresses?
2372021-09-30T08:29:26 <laanwj> oh crap, had to shut down the node to move around a few things, a disk is full
2382021-09-30T08:29:42 <jnewbery> whether or not an address is actually a viable peer does not affect how well it propagates in addr gossip
2392021-09-30T08:30:16 <vasild> _aj_: I don't know
2402021-09-30T08:30:47 <_aj_> jnewbery: it does for getaddr; normal propogation you'll relay before you test it, but for getaddr there's a decent chance you'll have dropped a bad address before you get the getaddr request
2412021-09-30T08:32:07 <_aj_> vasild: could be significant for nodes that aren't online all the time, but i wonder if that's a plausible set of nodes for creating a botnet in the first place
2422021-09-30T08:32:29 <vasild> anyway, I do not insist that a junk address propagates worse than a real one. I insist that it propagates worse, or equally well (it does not propagate better for sure). So, a number from a real node will be an upper bound.
2432021-09-30T08:33:50 <_aj_> vasild: the other thing is you could relay "secret-nuclear-facility.gov:22" and then wait for the cia to start going after node operators with "why are you trying to hack into our nuclear facilities" ? i don't know if anyone still overreacts to connection attempts in this day and age like that though
2442021-09-30T08:34:53 <vasild> :)
2452021-09-30T08:35:52 * _aj_ remembers telnet'ing to the smtp port for some AusCERT computers and getting a stern talking to back in his uni days
2462021-09-30T08:35:53 <vasild> my !=8333 port node is getting 5 incoming connections per minute
2472021-09-30T08:37:14 <laanwj> i wonder if logic like "don't connect to ports under 1024" or such makes sense
2482021-09-30T08:37:56 <laanwj> i mean if we're talking about old school sysadmins getting pissed about connections, that was usually the threshold below not to mess around with :)
2492021-09-30T08:39:27 <jnewbery> _aj_: right, that's why I referred to addr gossip specifically, which I think is what matters more here. getaddr requests won't return bogus addresses that are IsTerrible()
2502021-09-30T08:39:40 <laanwj> and on UNIX-like operating systems you'd need to run bitcoind as root to do that
2512021-09-30T08:41:17 <vasild> in case anybody is curious how many incoming connections his node is getting (and lazy to type wretched bash commands), assuming debug=net is switched off on the node: bitcoin-cli logging '["net"]' && sleep 3600 && bitcoin-cli logging '[]' '["net"]'
2522021-09-30T08:41:30 <vasild> and then: grep -E '2021-09-30.+connection from .+ accepted' debug.log |grep -v '\[' |grep -v 127.0.0.1 |grep -v i2p |wc -l
2532021-09-30T08:43:04 <laanwj> i tried that but my disk was almost full and the ballooning debug.log pushed it over the edge, will try it again later
2542021-09-30T08:43:20 <vasild> :-X
2552021-09-30T08:45:55 *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
2562021-09-30T08:49:01 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 265 seconds)
2572021-09-30T08:49:06 *** Guyver2_ is now known as Guyver2
2582021-09-30T08:53:06 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2592021-09-30T08:53:15 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2602021-09-30T08:54:15 *** saranshsharma <saranshsharma!~saranshsh@202.142.81.26> has joined #bitcoin-core-dev
2612021-09-30T08:58:16 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2622021-09-30T08:58:23 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2632021-09-30T09:02:23 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2642021-09-30T09:02:33 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2652021-09-30T09:06:33 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2662021-09-30T09:06:41 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2672021-09-30T09:10:41 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2682021-09-30T09:10:49 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2692021-09-30T09:13:13 *** saranshsharma <saranshsharma!~saranshsh@202.142.81.26> has quit IRC (Remote host closed the connection)
2702021-09-30T09:17:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2712021-09-30T09:17:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2722021-09-30T09:21:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2732021-09-30T09:21:30 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2742021-09-30T09:31:15 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2752021-09-30T09:31:24 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2762021-09-30T09:35:24 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2772021-09-30T09:35:32 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2782021-09-30T09:35:48 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2792021-09-30T09:35:48 <bitcoin-git> [bitcoin] laanwj pushed 11 commits to master: https://github.com/bitcoin/bitcoin/compare/f52929063f48...81e7748bc18a
2802021-09-30T09:35:48 <bitcoin-git> bitcoin/master 13f6188 Hennadii Stepanov: qt: Add GUIUtil::ShowModalDialogAndDeleteOnClose
2812021-09-30T09:35:48 <bitcoin-git> bitcoin/master 7830cd0 Hennadii Stepanov: qt, refactor: Keep OptionsDialog in the main event loop
2822021-09-30T09:35:48 <bitcoin-git> bitcoin/master 59f7ba4 Hennadii Stepanov: qt, refactor: Keep CoinControlDialog in the main event loop
2832021-09-30T09:35:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2842021-09-30T09:36:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2852021-09-30T09:36:05 <bitcoin-git> [gui] laanwj merged pull request #336: Do not exit and re-enter main event loop during shutdown (master...210516-loop) https://github.com/bitcoin-core/gui/pull/336
2862021-09-30T09:36:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2872021-09-30T09:40:37 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2882021-09-30T09:40:46 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2892021-09-30T09:45:59 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2902021-09-30T09:46:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2912021-09-30T09:47:31 *** Henrik <Henrik!~textual@84.212.107.177> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzzâ¦)
2922021-09-30T09:51:31 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2932021-09-30T09:51:39 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2942021-09-30T09:55:39 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2952021-09-30T09:55:47 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2962021-09-30T09:59:47 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2972021-09-30T09:59:55 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2982021-09-30T10:03:09 *** Henrik <Henrik!~textual@84.212.107.177> has joined #bitcoin-core-dev
2992021-09-30T10:05:23 *** fedecuci <fedecuci!~fedecuci@ww090827.uvt.nl> has quit IRC (Quit: Client closed)
3002021-09-30T10:11:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3012021-09-30T10:11:27 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/81e7748bc18a...80b4e8fb87a2
3022021-09-30T10:11:27 <bitcoin-git> bitcoin/master 90be29c Sebastian Falbesoner: wallet: enable SQLite extended result codes
3032021-09-30T10:11:27 <bitcoin-git> bitcoin/master 80b4e8f W. J. van der Laan: Merge bitcoin/bitcoin#23112: wallet: enable SQLite extended result codes
3042021-09-30T10:11:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3052021-09-30T10:11:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3062021-09-30T10:11:43 <bitcoin-git> [bitcoin] laanwj merged pull request #23112: wallet: enable SQLite extended result codes (master...202109-wallet-enable_sqlite_extended_result_codes) https://github.com/bitcoin/bitcoin/pull/23112
3072021-09-30T10:11:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3082021-09-30T10:15:44 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3092021-09-30T10:15:53 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3102021-09-30T10:19:53 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3112021-09-30T10:20:02 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3122021-09-30T10:20:20 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Quit: Konversation terminated!)
3132021-09-30T10:24:20 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3142021-09-30T10:24:26 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
3152021-09-30T10:24:28 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3162021-09-30T10:28:28 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3172021-09-30T10:28:36 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3182021-09-30T10:32:36 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3192021-09-30T10:32:44 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3202021-09-30T10:34:22 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3212021-09-30T10:34:23 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/80b4e8fb87a2...dbbb7fbcc02e
3222021-09-30T10:34:23 <bitcoin-git> bitcoin/master 8ff3743 Hennadii Stepanov: Revert "doc: Remove outdated comments"
3232021-09-30T10:34:23 <bitcoin-git> bitcoin/master dbbb7fb W. J. van der Laan: Merge bitcoin/bitcoin#23130: doc: Revert "Remove outdated comments" and pl...
3242021-09-30T10:34:24 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3252021-09-30T10:34:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3262021-09-30T10:34:40 <bitcoin-git> [bitcoin] laanwj merged pull request #23130: doc: Revert "Remove outdated comments" and place comment correctly (master...210929-revert) https://github.com/bitcoin/bitcoin/pull/23130
3272021-09-30T10:34:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3282021-09-30T10:38:41 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3292021-09-30T10:38:50 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3302021-09-30T10:45:10 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3312021-09-30T10:45:19 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3322021-09-30T10:46:46 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 245 seconds)
3332021-09-30T10:47:21 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
3342021-09-30T10:51:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3352021-09-30T10:51:30 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3362021-09-30T10:52:02 *** fedecuci <fedecuci!~fedecuci@ww090827.uvt.nl> has joined #bitcoin-core-dev
3372021-09-30T10:59:39 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3382021-09-30T10:59:47 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3392021-09-30T11:03:47 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3402021-09-30T11:03:55 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3412021-09-30T11:10:27 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3422021-09-30T11:10:35 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3432021-09-30T11:13:30 *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
3442021-09-30T11:15:22 *** nanotube <nanotube!~nanotube@user/nanotube> has quit IRC (Ping timeout: 252 seconds)
3452021-09-30T11:16:21 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 245 seconds)
3462021-09-30T11:16:31 *** Guyver2_ is now known as Guyver2
3472021-09-30T11:24:09 *** Guyver2_ <Guyver2_!~Guyver@2001:985:f3f:1:9897:b926:f3e9:ee7a> has joined #bitcoin-core-dev
3482021-09-30T11:25:56 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 245 seconds)
3492021-09-30T11:26:00 *** Guyver2_ is now known as Guyver2
3502021-09-30T11:30:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3512021-09-30T11:30:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3522021-09-30T11:34:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3532021-09-30T11:34:17 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3542021-09-30T11:38:17 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3552021-09-30T11:38:25 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3562021-09-30T11:40:18 *** jtrag <jtrag!~jtrag@c-71-207-125-151.hsd1.pa.comcast.net> has joined #bitcoin-core-dev
3572021-09-30T11:44:18 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3582021-09-30T11:44:27 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3592021-09-30T11:44:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3602021-09-30T11:44:34 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dbbb7fbcc02e...bd40cd81083a
3612021-09-30T11:44:34 <bitcoin-git> bitcoin/master 1d44513 MarcoFalke: Squashed 'src/crc32c/' changes from b5ef9be675..0d624261ef
3622021-09-30T11:44:34 <bitcoin-git> bitcoin/master fac1c13 MarcoFalke: Update crc32c subtree
3632021-09-30T11:44:34 <bitcoin-git> bitcoin/master bd40cd8 fanquake: Merge bitcoin/bitcoin#23133: Update crc32c subtree
3642021-09-30T11:44:36 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3652021-09-30T11:44:51 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3662021-09-30T11:44:51 <bitcoin-git> [bitcoin] fanquake merged pull request #23133: Update crc32c subtree (master...2109-subtreeCrc32c) https://github.com/bitcoin/bitcoin/pull/23133
3672021-09-30T11:44:52 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3682021-09-30T11:48:52 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3692021-09-30T11:49:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3702021-09-30T11:53:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3712021-09-30T11:53:09 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3722021-09-30T11:53:16 <fedecuci> Hi guys, I am curious, how many people have a very strong understanding of the Bitcoin protocol and source code? I am talking about people that are comfortable with at least 80% of the codebase and would know almost immediately where to go to fix a bug in case it arises. Any estimate?
3732021-09-30T11:54:04 <fedecuci> Also please let me know if this is not the place to ask such questions and I won't anymore of course.
3742021-09-30T11:58:04 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3752021-09-30T11:58:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3762021-09-30T12:00:35 *** kpcyrd <kpcyrd!~kpcyrd@archlinux/trusteduser/kpcyrd> has left #bitcoin-core-dev
3772021-09-30T12:03:51 *** mikehu44 <mikehu44!~quassel@206.189.41.250> has quit IRC (Ping timeout: 245 seconds)
3782021-09-30T12:07:51 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3792021-09-30T12:07:59 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3802021-09-30T12:13:06 *** mikehu44 <mikehu44!~quassel@206.189.41.250> has joined #bitcoin-core-dev
3812021-09-30T12:14:35 *** jespada <jespada!~jespada@2803:9800:9842:7a62:a5:6e91:7fa0:aa24> has joined #bitcoin-core-dev
3822021-09-30T12:21:51 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3832021-09-30T12:21:59 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3842021-09-30T12:23:05 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
3852021-09-30T12:27:05 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3862021-09-30T12:27:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3872021-09-30T12:30:43 *** Henrik <Henrik!~textual@84.212.107.177> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzzâ¦)
3882021-09-30T12:34:43 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3892021-09-30T12:34:51 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3902021-09-30T12:37:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3912021-09-30T12:37:13 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/bd40cd81083a...7f81f5459ffa
3922021-09-30T12:37:13 <bitcoin-git> bitcoin/master e56100c fanquake: build: remove arm includes from getauxval() check
3932021-09-30T12:37:13 <bitcoin-git> bitcoin/master 4446ef0 fanquake: build: remove support for weak linking getauxval()
3942021-09-30T12:37:13 <bitcoin-git> bitcoin/master 7f81f54 W. J. van der Laan: Merge bitcoin/bitcoin#23082: build: improve gexauxval() detection, remove ...
3952021-09-30T12:37:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3962021-09-30T12:37:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3972021-09-30T12:37:30 <bitcoin-git> [bitcoin] laanwj merged pull request #23082: build: improve gexauxval() detection, remove getauxval() weak linking (master...remove_weak_auxval) https://github.com/bitcoin/bitcoin/pull/23082
3982021-09-30T12:37:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3992021-09-30T12:41:31 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4002021-09-30T12:41:39 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4012021-09-30T12:42:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4022021-09-30T12:42:44 <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/7f81f5459ffa...1cf7fb9fd658
4032021-09-30T12:42:44 <bitcoin-git> bitcoin/master faffaa8 MarcoFalke: log: Avoid broken SELECTCOINS log
4042021-09-30T12:42:44 <bitcoin-git> bitcoin/master faeae29 MarcoFalke: log: Avoid broken DEBUG_LOCKORDER log
4052021-09-30T12:42:44 <bitcoin-git> bitcoin/master fa6c1e8 MarcoFalke: test: Fix typos in tests
4062021-09-30T12:42:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4072021-09-30T12:43:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4082021-09-30T12:43:01 <bitcoin-git> [bitcoin] laanwj merged pull request #23104: log: Avoid breaking single log lines over multiple lines in the log file (master...2109-logCont) https://github.com/bitcoin/bitcoin/pull/23104
4092021-09-30T12:43:02 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4102021-09-30T12:47:02 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4112021-09-30T12:47:11 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4122021-09-30T12:51:11 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4132021-09-30T12:51:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4142021-09-30T12:54:49 *** Guest38 <Guest38!~Guest38@2a02:908:1a8:a6a0:ccc:55d7:8471:5ec5> has joined #bitcoin-core-dev
4152021-09-30T12:54:58 *** Guest38 <Guest38!~Guest38@2a02:908:1a8:a6a0:ccc:55d7:8471:5ec5> has quit IRC (Client Quit)
4162021-09-30T13:02:36 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4172021-09-30T13:02:45 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4182021-09-30T13:06:46 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4192021-09-30T13:06:54 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4202021-09-30T13:15:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4212021-09-30T13:15:36 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1cf7fb9fd658...2d8e0c0c3c0d
4222021-09-30T13:15:36 <bitcoin-git> bitcoin/master 4747db8 practicalswift: util: Introduce ToIntegral<T>(const std::string&) for locale independent p...
4232021-09-30T13:15:36 <bitcoin-git> bitcoin/master 2d8e0c0 W. J. van der Laan: Merge bitcoin/bitcoin#20457: util: Make Parse{Int,UInt}{32,64} use locale ...
4242021-09-30T13:15:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4252021-09-30T13:15:51 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4262021-09-30T13:15:52 <bitcoin-git> [bitcoin] laanwj merged pull request #20457: util: Make Parse{Int,UInt}{32,64} use locale independent std::from_chars(â¦) (C++17) instead of locale dependent strto{l,ll,ul,ull} (master...locale-independent-parseint) https://github.com/bitcoin/bitcoin/pull/20457
4272021-09-30T13:15:53 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4282021-09-30T13:19:53 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4292021-09-30T13:20:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4302021-09-30T13:24:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4312021-09-30T13:24:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4322021-09-30T13:24:46 *** fedecuci <fedecuci!~fedecuci@ww090827.uvt.nl> has quit IRC (Quit: Client closed)
4332021-09-30T13:28:46 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4342021-09-30T13:28:55 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4352021-09-30T13:29:22 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4362021-09-30T13:29:23 <bitcoin-git> [gui] hebasto closed pull request #59: Do not block GUI thread in RPCConsole (master...200814-rpc) https://github.com/bitcoin-core/gui/pull/59
4372021-09-30T13:29:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4382021-09-30T13:33:23 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4392021-09-30T13:33:31 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4402021-09-30T13:34:36 <TallTim> I'd like to report using addnode to sync bitcoin core client with my personal full node has sped up my sync time. Thanks again to sipa for the advice.
4412021-09-30T13:35:43 <sipa> :)
4422021-09-30T13:41:34 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4432021-09-30T13:41:42 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4442021-09-30T13:42:44 <laanwj> nice!
4452021-09-30T13:46:44 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4462021-09-30T13:46:52 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4472021-09-30T13:47:58 <TallTim> I appreciate the work you put in. Its obvious core has continually improved. Thank you.
4482021-09-30T13:58:18 <shiza> +1
4492021-09-30T14:04:39 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Quit: <----- is PODAK (Passed out drunk at keyboard), and he has somehow managed to quit/disconnect...)
4502021-09-30T14:09:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4512021-09-30T14:09:29 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4522021-09-30T14:14:06 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4532021-09-30T14:14:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4542021-09-30T14:18:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4552021-09-30T14:18:22 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4562021-09-30T14:22:22 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4572021-09-30T14:22:31 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4582021-09-30T14:24:06 <jamesob> Are there people who're attesting to release binaries using opentimestamps?
4592021-09-30T14:24:33 *** Henrik <Henrik!~textual@84.212.107.177> has joined #bitcoin-core-dev
4602021-09-30T14:29:36 *** saranshsharma <saranshsharma!~saranshsh@202.142.81.26> has joined #bitcoin-core-dev
4612021-09-30T14:35:48 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4622021-09-30T14:35:48 <bitcoin-git> [bitcoin] hebasto pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/2d8e0c0c3c0d...9013f23b0a6e
4632021-09-30T14:35:48 <bitcoin-git> bitcoin/master f9b633e Hennadii Stepanov: qt, wallet: Move activity progress dialog from data member to local
4642021-09-30T14:35:48 <bitcoin-git> bitcoin/master 4a024fc Hennadii Stepanov: qt, wallet, refactor: Move connection to QObject::deleteLater to ctor
4652021-09-30T14:35:48 <bitcoin-git> bitcoin/master f6991cb Hennadii Stepanov: qt, wallet: Add LoadWalletsActivity class
4662021-09-30T14:35:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4672021-09-30T14:36:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4682021-09-30T14:36:04 <bitcoin-git> [gui] hebasto merged pull request #342: wallet: Move wallets loading out from the main GUI thread (master...210521-wallet) https://github.com/bitcoin-core/gui/pull/342
4692021-09-30T14:36:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4702021-09-30T14:41:16 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4712021-09-30T14:41:25 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4722021-09-30T14:44:34 <sipa> jamesob: i'm interested in knowing whether "-flto" and/or "-fdata-sections -ffunction-sections -Wl,--gc-sections" are possible/beneficial with our current compiler suite; what would be a good way to have your test infrastructure benchmark things?
4732021-09-30T14:47:16 <laanwj> jamesob: not that i know, there's https://bitcoincore.org/bin/bitcoin-core-22.0/SHA256SUMS.ots but it gets generated prior to upload, it's not part of any of the attestations
4742021-09-30T14:51:38 *** AaronvanW <AaronvanW!~AaronvanW@190.242.161.186> has joined #bitcoin-core-dev
4752021-09-30T14:55:39 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4762021-09-30T14:55:46 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4772021-09-30T14:57:44 *** saranshsharma <saranshsharma!~saranshsh@202.142.81.26> has quit IRC (Remote host closed the connection)
4782021-09-30T15:00:17 *** Henrik <Henrik!~textual@84.212.107.177> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzzâ¦)
4792021-09-30T15:04:17 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4802021-09-30T15:04:26 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4812021-09-30T15:07:27 *** kexkey <kexkey!~kexkey@static-198-54-132-172.cust.tzulo.com> has joined #bitcoin-core-dev
4822021-09-30T15:08:46 <cfields> sipa: +1, I'd like to know about lto as well. It seems mature enough across the board to switch to imo, as long as there are no obvious regressions.
4832021-09-30T15:09:07 <cfields> (IIRC last time you tested it there were some weird slowdowns)
4842021-09-30T15:13:07 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4852021-09-30T15:13:15 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4862021-09-30T15:17:15 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4872021-09-30T15:17:20 <jamesob> sipa cfields: not familiar with that stuff, will investigate though
4882021-09-30T15:17:24 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4892021-09-30T15:21:24 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4902021-09-30T15:21:33 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4912021-09-30T15:25:48 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4922021-09-30T15:25:57 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4932021-09-30T15:26:12 *** tralfaz <tralfaz!~davterra@143.198.56.186> has joined #bitcoin-core-dev
4942021-09-30T15:26:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4952021-09-30T15:26:32 <bitcoin-git> [bitcoin] jonatack opened pull request #23146: Test transactions conflicted by double spend in listtransactions (master...test-txns-conflicted-by-double-spend-in-listtransactions) https://github.com/bitcoin/bitcoin/pull/23146
4962021-09-30T15:26:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4972021-09-30T15:27:36 *** davterra <davterra!~davterra@143.198.56.186> has quit IRC (Ping timeout: 245 seconds)
4982021-09-30T15:31:36 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4992021-09-30T15:31:44 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5002021-09-30T15:35:29 *** emcy <emcy!~emcy@user/emcy> has quit IRC (Remote host closed the connection)
5012021-09-30T15:40:27 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5022021-09-30T15:40:35 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5032021-09-30T15:44:00 *** emcy <emcy!~emcy@user/emcy> has joined #bitcoin-core-dev
5042021-09-30T15:48:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5052021-09-30T15:48:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5062021-09-30T15:57:27 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5072021-09-30T15:57:35 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5082021-09-30T15:59:02 *** mikehu44 <mikehu44!~quassel@206.189.41.250> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
5092021-09-30T16:00:45 *** mikehu44 <mikehu44!~quassel@206.189.41.250> has joined #bitcoin-core-dev
5102021-09-30T16:04:45 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5112021-09-30T16:04:54 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5122021-09-30T16:08:54 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5132021-09-30T16:09:03 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5142021-09-30T16:14:16 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5152021-09-30T16:14:25 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5162021-09-30T16:18:25 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5172021-09-30T16:18:33 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5182021-09-30T16:22:33 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5192021-09-30T16:22:41 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5202021-09-30T16:30:14 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5212021-09-30T16:30:23 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5222021-09-30T16:31:17 <cfields> sipa: blah, good point about mixed-use codebases. I guess https://github.com/sipa/minisketch/pull/51 is kinda a counterpoint to disabling the warning wholesale, as it pointed out something legal but logically broken.
5232021-09-30T16:31:36 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
5242021-09-30T16:32:08 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
5252021-09-30T16:33:55 <sipa> cfields: FWIW, libsecp256k1 does assume that some signed integer behavior is actually well-defined (and it has compile-time assertions to check that), which means it's not fully C language neutral
5262021-09-30T16:34:14 <sipa> (not UB though; only parts of signed integer behavior that are implementation defined)
5272021-09-30T16:36:17 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
5282021-09-30T16:36:34 <sipa> cfields: but i do think that we probably want to disable unsigned-integer sanitizers wholesale for minisketch
5292021-09-30T16:39:59 *** gleb7 <gleb7!~gleb@178.150.137.228> has quit IRC (Ping timeout: 252 seconds)
5302021-09-30T16:43:25 <laanwj> disabling unsigned-integer sanitizers for cryptographic code makes a lot of sense
5312021-09-30T16:48:38 <cfields> ACK, will just do it there. I'm still surprised that this happens rarely enough for our tests to pass with only a few exceptions. Guess it is pretty specific to crypto/mathy stuff.
5322021-09-30T16:48:39 <sipa> we already pretty much do that
5332021-09-30T16:49:03 <sipa> it's disputable whether minisketch is cryptographic, but it's pretty mathy :)
5342021-09-30T16:49:18 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 276 seconds)
5352021-09-30T16:49:51 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
5362021-09-30T16:56:50 <laanwj> right, it would have been nice if C had explicit wraparound and non-wraparound arithmetic, but this works
5372021-09-30T16:59:01 <sipa> compilers actually do make use of this, FWIW; sometimes using signed integer as a loop variable is faster, because the compiler can assume it can't run forever
5382021-09-30T16:59:15 <sipa> even if it never takes on a negative value
5392021-09-30T16:59:50 <cfields> sipa: heh, I remember that as an ancient gcc bug. hope that's not still the case :)
5402021-09-30T17:00:01 *** AaronvanW <AaronvanW!~AaronvanW@190.242.161.186> has quit IRC (Remote host closed the connection)
5412021-09-30T17:04:03 *** smartin <smartin!~Icedove@88.135.18.171> has quit IRC (Quit: smartin)
5422021-09-30T17:04:39 <laanwj> not related to signed/unsigned or wraparound but i recently learned that on RISC-V 64-bit, explicitly using 64-bit loop counters can be much faster, as it doesn't have 32-bit arithmetic, so if the compiler can't reason that your value won't wrap, it will add AND (1<<32)-1 everywhere ... this is pretty annoying for code that needs to be fast on 32-bit hardware too
5432021-09-30T17:05:48 *** lightlike <lightlike!~lightlike@user/lightlike> has joined #bitcoin-core-dev
5442021-09-30T17:06:15 <sipa> cfields: not sure what you're referring too, but it may well not be a bug; a for (int x = 0;; x++) { ... } loop, which doesn't modify x in the body is guaranteed to not run forever for example (because that would require a signed int overflow, which is UB)
5452021-09-30T17:06:27 <laanwj> of course, this only matters for really tiny loops, as in micro-benchmarks, normally the work actually done in the loop dominates
5462021-09-30T17:07:20 <cfields> laanwj: I wonder if that's a case that int_fast32_t is suited for?
5472021-09-30T17:07:39 <sipa> hmm, what is int_fast32_t on x86_64 and riscv64?
5482021-09-30T17:08:00 <laanwj> lets see
5492021-09-30T17:08:10 *** emcy_ <emcy_!~emcy@user/emcy> has joined #bitcoin-core-dev
5502021-09-30T17:08:18 *** promag_ <promag_!~promag@188.250.84.129> has joined #bitcoin-core-dev
5512021-09-30T17:08:20 *** common <common!~common@096-033-221-075.res.spectrum.com> has joined #bitcoin-core-dev
5522021-09-30T17:09:48 <cfields> sipa: blah, I can't remember it now, but it was a relatively widely-known missed (safe) optimization. So maybe the loop count is known.
5532021-09-30T17:10:56 *** dodo__ <dodo__!~dodo@user/dodo> has joined #bitcoin-core-dev
5542021-09-30T17:11:07 <laanwj> both int_fast32_t and int_fast64_t are 64 bit on 64-bit RISC-V
5552021-09-30T17:11:15 *** adiabat_ <adiabat_!~adiabat@63.209.32.102> has joined #bitcoin-core-dev
5562021-09-30T17:11:30 *** javi404_ <javi404_!~quassel@pool-173-63-15-246.nwrknj.fios.verizon.net> has joined #bitcoin-core-dev
5572021-09-30T17:11:50 *** lukedashjr <lukedashjr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
5582021-09-30T17:12:02 *** Guest65 <Guest65!~Guest65@dynamic-adsl-78-15-71-43.clienti.tiscali.it> has joined #bitcoin-core-dev
5592021-09-30T17:12:34 *** sturles_ <sturles_!~sturles@sauron.uio.no> has joined #bitcoin-core-dev
5602021-09-30T17:12:40 *** diego <diego!~diego@179.235.12.99> has joined #bitcoin-core-dev
5612021-09-30T17:12:56 <cfields> same on x86_64.
5622021-09-30T17:13:08 <sipa> that makes sense
5632021-09-30T17:13:29 <sipa> it's not universal though... iirc 64-bit multiplication and division are slower on x86_64 than 32-bit ones
5642021-09-30T17:13:31 *** mikehu44_ <mikehu44_!~quassel@206.189.41.250> has joined #bitcoin-core-dev
5652021-09-30T17:13:41 *** Guest65 <Guest65!~Guest65@dynamic-adsl-78-15-71-43.clienti.tiscali.it> has quit IRC (Quit: Connection closed)
5662021-09-30T17:17:35 *** lightlike <lightlike!~lightlike@user/lightlike> has quit IRC (*.net *.split)
5672021-09-30T17:17:36 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (*.net *.split)
5682021-09-30T17:17:36 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (*.net *.split)
5692021-09-30T17:17:36 *** mikehu44 <mikehu44!~quassel@206.189.41.250> has quit IRC (*.net *.split)
5702021-09-30T17:17:36 *** emcy <emcy!~emcy@user/emcy> has quit IRC (*.net *.split)
5712021-09-30T17:17:36 *** jespada <jespada!~jespada@2803:9800:9842:7a62:a5:6e91:7fa0:aa24> has quit IRC (*.net *.split)
5722021-09-30T17:17:36 *** adiabat <adiabat!~adiabat@63.209.32.102> has quit IRC (*.net *.split)
5732021-09-30T17:17:36 *** commmon <commmon!~common@096-033-221-075.res.spectrum.com> has quit IRC (*.net *.split)
5742021-09-30T17:17:36 *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-f169-568c-84c0-edb5.res6.spectrum.com> has quit IRC (*.net *.split)
5752021-09-30T17:17:36 *** dviola <dviola!~diego@179.235.12.99> has quit IRC (*.net *.split)
5762021-09-30T17:17:36 *** dodo <dodo!~dodo@user/dodo> has quit IRC (*.net *.split)
5772021-09-30T17:17:36 *** upekkha <upekkha!~Advanced@2a01:4f8:1c0c:49df::1> has quit IRC (*.net *.split)
5782021-09-30T17:17:36 *** promag <promag!~promag@188.250.84.129> has quit IRC (*.net *.split)
5792021-09-30T17:17:37 *** sturles <sturles!~sturles@sauron.uio.no> has quit IRC (*.net *.split)
5802021-09-30T17:17:37 *** javi404 <javi404!~quassel@pool-173-63-15-246.nwrknj.fios.verizon.net> has quit IRC (*.net *.split)
5812021-09-30T17:17:37 *** Lightsword <Lightsword!~Lightswor@user/lightsword> has quit IRC (*.net *.split)
5822021-09-30T17:17:37 *** cryptolightning <cryptolightning!~cryptolig@user/cryptolightning> has quit IRC (*.net *.split)
5832021-09-30T17:17:46 *** lukedashjr is now known as luke-jr
5842021-09-30T17:17:57 *** dodo__ is now known as dodo
5852021-09-30T17:18:11 *** cryptolightning <cryptolightning!~cryptolig@70-131-42-184.lightspeed.rlghnc.sbcglobal.net> has joined #bitcoin-core-dev
5862021-09-30T17:20:17 *** lightlike <lightlike!~lightlike@user/lightlike> has joined #bitcoin-core-dev
5872021-09-30T17:21:03 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
5882021-09-30T17:21:24 *** mekster66 <mekster66!~mekster@user/mekster> has quit IRC (Read error: Connection reset by peer)
5892021-09-30T17:21:33 *** mekster66 <mekster66!~mekster@user/mekster> has joined #bitcoin-core-dev
5902021-09-30T17:21:40 *** rockhouse3 <rockhouse3!~rockhouse@user/rockhouse> has joined #bitcoin-core-dev
5912021-09-30T17:22:07 *** jespada <jespada!~jespada@2803:9800:9842:7a62:a5:6e91:7fa0:aa24> has joined #bitcoin-core-dev
5922021-09-30T17:22:07 *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-f169-568c-84c0-edb5.res6.spectrum.com> has joined #bitcoin-core-dev
5932021-09-30T17:22:07 *** upekkha <upekkha!~Advanced@2a01:4f8:1c0c:49df::1> has joined #bitcoin-core-dev
5942021-09-30T17:22:07 *** Lightsword <Lightsword!~Lightswor@user/lightsword> has joined #bitcoin-core-dev
5952021-09-30T17:23:46 *** promag_ <promag_!~promag@188.250.84.129> has quit IRC (Ping timeout: 265 seconds)
5962021-09-30T17:23:58 <shiza> Functional tests runner defaults to as many jobs as virtual processors? And, shouldn't it default to one job for consistency with "make check"?
5972021-09-30T17:24:15 *** rockhouse <rockhouse!~rockhouse@user/rockhouse> has quit IRC (Ping timeout: 265 seconds)
5982021-09-30T17:24:15 *** Victorsueca <Victorsueca!~Victorsue@user/victorsueca> has quit IRC (Ping timeout: 265 seconds)
5992021-09-30T17:24:15 *** rockhouse3 is now known as rockhouse
6002021-09-30T17:24:34 *** tripleslash <tripleslash!~triplesla@user/tripleslash> has quit IRC (Read error: Connection reset by peer)
6012021-09-30T17:26:25 *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-f169-568c-84c0-edb5.res6.spectrum.com> has quit IRC (Quit: jarthur)
6022021-09-30T17:26:39 *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-5422-0cb4-aeaf-4572.res6.spectrum.com> has joined #bitcoin-core-dev
6032021-09-30T17:27:25 <laanwj> that makes sense if they're different instructions; for RISC-V there's work on an extension that adds explicit 32-bit arithmetic (as part of more general bit manipulation extensions)
6042021-09-30T17:28:22 <laanwj> shiza: have you tried that it runs faster in that case? the functional tests tend to peg 100% CPU already here so i don't think it'd make a difference
6052021-09-30T17:29:32 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
6062021-09-30T17:29:39 *** dongcarl <dongcarl!~dongcarl@70.107.207.192> has quit IRC (Read error: Connection reset by peer)
6072021-09-30T17:29:43 <laanwj> oh, sorry, read it wrong, thought you meant defaulting to number of cores + 1
6082021-09-30T17:29:44 *** dongcarl7 <dongcarl7!~dongcarl@70.107.207.192> has joined #bitcoin-core-dev
6092021-09-30T17:29:45 <shiza> If a random functional test tends to peg to 100% CPU already, why at all default to more than 1 or 2?
6102021-09-30T17:30:00 <shiza> Alright, then I haven't written anything.
6112021-09-30T17:31:37 <shiza> I should try it around more, before being sure it feels weird.
6122021-09-30T17:32:07 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
6132021-09-30T17:33:16 <shiza> I suppose "make check" honors equivalence with "make -j 1 check". :thonking:
6142021-09-30T17:33:29 <shiza> But I don't know.
6152021-09-30T17:34:49 <shiza> Sometimes I've used "make -j TARGET" and it somehow exploded exponentially, but that's a topic for another day.
6162021-09-30T17:34:57 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Client Quit)
6172021-09-30T17:35:30 <shiza> Well not exponentially, but exploded further than the number of virtual processors.
6182021-09-30T17:35:32 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
6192021-09-30T17:39:32 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6202021-09-30T17:39:41 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6212021-09-30T17:40:15 <cfields> shiza: -j launches every possible build job simultaneously. It's not intended to be bounded by cpu count.
6222021-09-30T17:40:38 <cfields> If you use a bare -j, you probably want -l too.
6232021-09-30T17:42:32 *** glix_ <glix_!~glix@152.67.8.183> has joined #bitcoin-core-dev
6242021-09-30T17:43:02 <shiza> It looked like -j was being passed to nested makes, but I imagine how -l would help, didn't knew that, thanks.
6252021-09-30T17:43:16 *** jnewbery_ <jnewbery_!~john@user/jnewbery> has joined #bitcoin-core-dev
6262021-09-30T17:44:15 *** _aj__ <_aj__!aj@cerulean.erisian.com.au> has joined #bitcoin-core-dev
6272021-09-30T17:44:18 *** __nick__ <__nick__!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
6282021-09-30T17:44:25 <cfields> Yes, nested "$(MAKE)" invocations will share the same jobqueue, but manual "make"s will start over, potentially launching new parallel builds.
6292021-09-30T17:44:29 *** glix <glix!~glix@user/glix> has quit IRC (Ping timeout: 265 seconds)
6302021-09-30T17:44:29 *** _aj_ <_aj_!aj@user/aj/x-5857768> has quit IRC (Ping timeout: 265 seconds)
6312021-09-30T17:44:29 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has quit IRC (Ping timeout: 265 seconds)
6322021-09-30T17:44:30 *** jnewbery <jnewbery!~john@user/jnewbery> has quit IRC (Ping timeout: 265 seconds)
6332021-09-30T17:44:30 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Ping timeout: 265 seconds)
6342021-09-30T17:44:30 *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has quit IRC (Ping timeout: 265 seconds)
6352021-09-30T17:44:56 <cfields> -l doesn't always help a ton though. Sometimes the jobs ramp up faster than the load can reflect.
6362021-09-30T17:45:09 *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has joined #bitcoin-core-dev
6372021-09-30T17:47:24 *** bijoo <bijoo!~bijoo@96.86.11.105> has joined #bitcoin-core-dev
6382021-09-30T17:50:04 <shiza> Remembering now, every project demonstrates parallel make useless when matured enough.
6392021-09-30T17:51:21 <shiza> "Useless". Not exactly.
6402021-09-30T17:55:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6412021-09-30T17:55:30 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6422021-09-30T17:59:30 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6432021-09-30T17:59:39 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6442021-09-30T18:00:05 <laanwj> i don't know about useless? bitcoin core's build should have plenty of potential parallelism, i once saw a screenshot of someone building on a 64-core machine, all cores 100%, though probably this won't be the case in the latter parts of the process during linking etc which have to merge a lot of build artifacts
6452021-09-30T18:01:24 <laanwj> haven't personally tried with more than 8
6462021-09-30T18:09:30 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6472021-09-30T18:09:38 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6482021-09-30T18:13:39 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6492021-09-30T18:13:39 <shiza> I've seen many projects having problems with more than one make job, different problems on different projects. If I remember correctly, increasing the number of parallel makes on a CI server will tend to be better than increasing the number of make jobs.
6502021-09-30T18:13:47 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6512021-09-30T18:14:34 <shiza> Naturally, multiple Make jobs will work OK most of the time.
6522021-09-30T18:15:40 <shiza> But on the CI server it has to work OK all of the time, and it seems the only way to guarantee that is by running make without multiple nested jobs.
6532021-09-30T18:16:51 <shiza> Again I mean the only way to guarantee that for every single project generically.
6542021-09-30T18:17:06 <sipa> i build bitcoin core with -j48
6552021-09-30T18:17:14 <sipa> without ccache it takes a minute or two
6562021-09-30T18:18:33 <shiza> If it never fails, let's hope it stays that good forever. But there are a million different projects using or depending on Make.
6572021-09-30T18:19:42 <laanwj> fwiw, some other build systems (such as meson/ninja) default to number_of_cores and always assume parallelism
6582021-09-30T18:19:52 <shiza> Maybe what I once read was about naive projects getting lost at Make complexity.
6592021-09-30T18:20:07 <shiza> Don't remember clearly.
6602021-09-30T18:21:00 <laanwj> it's fairly easy with make to make a mistake with regard to ordering dependencies which causes issues (either errors or non-determinism) with high parallelism, if you find such a issue with bitcoin core please report it
6612021-09-30T18:21:50 <laanwj> i think it's more likely nowadays for projects to get this correct because everyone has multicore PCs
6622021-09-30T18:21:53 <sipa> ccache -C && git clean -dfx && ./autogen && ./configure --with-incompatible-bdb && time make -j48 check
6632021-09-30T18:21:56 <shiza> Of course I would, and I doubt I'll find them, I won't be using master normally.
6642021-09-30T18:21:57 <sipa> real 2m49.548s
6652021-09-30T18:21:57 <sipa> user 53m18.218s
6662021-09-30T18:21:57 <sipa> sys 4m41.772s
6672021-09-30T18:22:11 <sipa> (which includes 30s of the single-threaded libsecp tests)
6682021-09-30T18:23:21 <laanwj> that *is* fast
6692021-09-30T18:25:25 *** tripleslash <tripleslash!~triplesla@user/tripleslash> has joined #bitcoin-core-dev
6702021-09-30T18:29:25 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6712021-09-30T18:29:33 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6722021-09-30T18:33:34 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6732021-09-30T18:33:42 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6742021-09-30T18:41:27 *** TheRec_ <TheRec_!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
6752021-09-30T18:41:30 *** tralfaz <tralfaz!~davterra@143.198.56.186> has quit IRC (Remote host closed the connection)
6762021-09-30T18:41:30 *** TheRec <TheRec!~toto@user/therec> has quit IRC (Read error: Connection reset by peer)
6772021-09-30T18:41:40 *** tralfaz <tralfaz!~davterra@143.198.56.186> has joined #bitcoin-core-dev
6782021-09-30T18:42:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6792021-09-30T18:42:58 <bitcoin-git> [gui] shaavan closed pull request #437: Show received bitcoins in green (master...green-coins) https://github.com/bitcoin-core/gui/pull/437
6802021-09-30T18:43:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6812021-09-30T18:50:11 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6822021-09-30T18:50:11 <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/9013f23b0a6e...571bb94dfb50
6832021-09-30T18:50:11 <bitcoin-git> bitcoin/master 6c00649 Samuel Dobson: Remove outdated dummy wallet -salvagewallet arg
6842021-09-30T18:50:11 <bitcoin-git> bitcoin/master f963b0f Samuel Dobson: Corrupt wallet tx shouldn't trigger rescan of all wallets
6852021-09-30T18:50:11 <bitcoin-git> bitcoin/master bccd1d9 Samuel Dobson: Remove -rescan startup parameter
6862021-09-30T18:50:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6872021-09-30T18:51:35 <cfields> sipa: I'm stepping through the individual minisketch ubsan warnings and making sure they're all false-positives before marking them as such. ok if I pm you with a few of the less obvious ones?
6882021-09-30T18:55:36 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6892021-09-30T18:55:43 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6902021-09-30T18:57:59 *** CoinForensics <CoinForensics!CoinForens@gateway/vpn/protonvpn/coinforensics> has joined #bitcoin-core-dev
6912021-09-30T19:00:38 *** diego <diego!~diego@179.235.12.99> has quit IRC (Quit: WeeChat 3.2.1)
6922021-09-30T19:01:32 <hebasto> meeting?
6932021-09-30T19:01:54 <laanwj> #startmeeting
6942021-09-30T19:01:54 <core-meetingbot> Meeting started Thu Sep 30 19:01:54 2021 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
6952021-09-30T19:01:55 <core-meetingbot> Available commands: action commands idea info link nick
6962021-09-30T19:02:07 <kvaciral[m]> hi
6972021-09-30T19:02:18 <ariard> hi
6982021-09-30T19:02:25 <hebasto> hi
6992021-09-30T19:02:27 <jonatack> hi
7002021-09-30T19:02:50 <laanwj> no proposed meeting topics for this week, any last-minute ones?
7012021-09-30T19:02:52 <cfields> hi
7022021-09-30T19:03:30 <meshcollider> hi
7032021-09-30T19:03:30 <achow101> hi
7042021-09-30T19:03:46 <larryruane> Hi
7052021-09-30T19:03:46 <meshcollider> Proposed topic: giving fanquake permissions in the repo to block users
7062021-09-30T19:03:55 *** gleb7 <gleb7!~gleb@178.150.137.228> has joined #bitcoin-core-dev
7072021-09-30T19:03:58 <laanwj> #23123 this is weird, i just merged it and it's not showing as such on github
7082021-09-30T19:04:57 <meshcollider> laanwj: I've had that issue a few times too, so have the other maintainers, it's become quite common
7092021-09-30T19:05:15 <laanwj> meshcollider: i don't think he's here, might be weird to discuss it behind his back
7102021-09-30T19:05:32 <meshcollider> laanwj: I asked him yesterday if he was okay with me proposing it :)
7112021-09-30T19:05:37 <laanwj> okay
7122021-09-30T19:05:38 <gleb7> hi
7132021-09-30T19:06:00 <ariard> I see 23123 as opened on my GH
7142021-09-30T19:06:27 <laanwj> i'm not actually sure what priv that is, i think you need full admin privileges over the github t be able to do that
7152021-09-30T19:06:58 <meshcollider> e.g. #23097 also didn't close on GH
7162021-09-30T19:07:08 *** gene <gene!~gene@gateway/tor-sasl/gene> has joined #bitcoin-core-dev
7172021-09-30T19:07:13 <meshcollider> laanwj: yeah I think so
7182021-09-30T19:07:24 <gene> hi
7192021-09-30T19:07:50 <laanwj> #topic High priority for review
7202021-09-30T19:07:51 <core-meetingbot> topic: High priority for review
7212021-09-30T19:08:23 <laanwj> https://github.com/bitcoin/bitcoin/projects/8 7 blockers, 2 chasing concept ACK at the moment
7222021-09-30T19:08:28 <achow101> #22019 for me please
7232021-09-30T19:08:48 *** r-ush <r-ush!~r-ush@52.187.184.81> has quit IRC (Quit: ZNC 1.7.5+deb4 - https://znc.in)
7242021-09-30T19:09:03 *** r-ush <r-ush!~r-ush@52.187.184.81> has joined #bitcoin-core-dev
7252021-09-30T19:09:25 <laanwj> achow101: added
7262021-09-30T19:09:34 <laanwj> anything else to add/remove or that is ready for merge?
7272021-09-30T19:09:55 *** _aj__ is now known as _aj_
7282021-09-30T19:11:22 <laanwj> I think #20487 is getting close to ready
7292021-09-30T19:11:50 <laanwj> https://github.com/bitcoin/bitcoin/pull/20487 Add syscall sandboxing using seccomp-bpf (Linux secure computing mode)
7302021-09-30T19:11:53 <laanwj> gah no gribble
7312021-09-30T19:12:01 <jonatack> #21943 soon hopefully
7322021-09-30T19:12:18 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
7332021-09-30T19:12:18 <bitcoin-git> [bitcoin] meshcollider closed pull request #23123: Remove `-rescan` startup parameter (master...202109_remove_rescan) https://github.com/bitcoin/bitcoin/pull/23123
7342021-09-30T19:12:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
7352021-09-30T19:12:26 <laanwj> yes, that one too
7362021-09-30T19:12:46 <jonatack> can i add ##22932
7372021-09-30T19:13:24 <laanwj> jonatack: added
7382021-09-30T19:14:05 <laanwj> anything else?
7392021-09-30T19:15:16 <laanwj> #topic Giving fanquake permissions in the repo to block users (meshcollider)
7402021-09-30T19:15:17 <core-meetingbot> topic: Giving fanquake permissions in the repo to block users (meshcollider)
7412021-09-30T19:16:01 <laanwj> so we have a pretty bad spam/troll problem lately so i think it makes sense, but there doesn't seem to be a fine-grained way to give this permission
7422021-09-30T19:16:10 <laanwj> well maybe through the API i need to check
7432021-09-30T19:16:47 <meshcollider> Indeed, fanquake seems a sensible choice of person to be given the extra permissions
7442021-09-30T19:16:58 <achow101> I think the "maintain" permission can?
7452021-09-30T19:16:59 <laanwj> yes
7462021-09-30T19:18:06 <achow101> ack
7472021-09-30T19:19:06 <luke-jr> NACK
7482021-09-30T19:19:26 <luke-jr> fanquake merged the BIP9 consensus change without community consensus, he shouldn't have any access at this point
7492021-09-30T19:19:27 <meshcollider> luke-jr: please provide reasoning for your nack
7502021-09-30T19:19:36 <hebasto> agree to give additional permissions to fanquake
7512021-09-30T19:20:31 <meshcollider> This could also be something which we leave for people to discuss throughout the week and make a decision at next week's meeting too, if that's more comfortable
7522021-09-30T19:20:46 <meshcollider> So others that aren't online can weigh in if they have anything to say
7532021-09-30T19:20:51 <ariard> meshcollider: yes i agree here
7542021-09-30T19:21:27 <laanwj> ok...
7552021-09-30T19:21:49 <luke-jr> developers are not supposed to be deciding consensus changes; someone who doesn't understand that isn't suited to having roles that can be abused for it
7562021-09-30T19:22:01 <laanwj> i feel really uncomfortable with this behind his back, i'm ending this topic
7572021-09-30T19:22:12 <laanwj> any other topics?
7582021-09-30T19:22:19 <meshcollider> Sounds good, although he probably won't be up at 3am next week either :)
7592021-09-30T19:23:08 <gene> is there a good time to reschedule, so that fanquake can attend?
7602021-09-30T19:23:10 <laanwj> #endmeeting
7612021-09-30T19:23:11 <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
7622021-09-30T19:23:11 <core-meetingbot> Meeting ended Thu Sep 30 19:23:10 2021 UTC.
7632021-09-30T19:23:11 <core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-09-30-19.01.moin.txt
7642021-09-30T19:23:22 <laanwj> i'm sure things can be discussed outside the meeting
7652021-09-30T19:23:29 <gene> +1
7662021-09-30T19:23:39 <jonatack> laanwj: thanks for adding
7672021-09-30T19:24:49 <luke-jr> (I agree he should be present for any such discussion, FWIW)
7682021-09-30T19:26:28 *** Guest92 <Guest92!~Guest92@p200300f1171dcd00492658d988dcfa1b.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
7692021-09-30T19:27:24 <Guest92> luke-jr: Seeing how the pr you refer to hasn't been reverted since, doesn't that mean the other maintainers implicitly endorsed it (and thus, should als be fired in your logic)?
7702021-09-30T19:29:03 <meshcollider> +1 on discussing when he's online, just thought the meeting was a good place to propose it formally
7712021-09-30T19:29:18 <meshcollider> luke-jr: (Which PR is this specifically anyway?)
7722021-09-30T19:29:51 *** TallTim <TallTim!~TallTim@184-83-239-155-dynamic.midco.net> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
7732021-09-30T19:34:43 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
7742021-09-30T19:34:51 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
7752021-09-30T19:37:14 *** Guest92 <Guest92!~Guest92@p200300f1171dcd00492658d988dcfa1b.dip0.t-ipconnect.de> has quit IRC (Quit: Client closed)
7762021-09-30T19:39:08 *** TallTim <TallTim!~TallTim@184-83-239-155-dynamic.midco.net> has joined #bitcoin-core-dev
7772021-09-30T19:39:45 <luke-jr> meshcollider: #21377
7782021-09-30T19:41:11 <laanwj> meshcollider: yes, imo good idea to bring it up
7792021-09-30T19:43:08 *** CoinForensics <CoinForensics!CoinForens@gateway/vpn/protonvpn/coinforensics> has quit IRC (Ping timeout: 252 seconds)
7802021-09-30T19:44:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
7812021-09-30T19:44:10 <bitcoin-git> [gui] achow101 opened pull request #441: Add Create Unsigned button to SendConfirmationDialog (master...create-unsigned-sendconfdialog) https://github.com/bitcoin-core/gui/pull/441
7822021-09-30T19:44:11 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
7832021-09-30T19:44:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
7842021-09-30T19:44:26 <bitcoin-git> [bitcoin] achow101 closed pull request #18789: qt: Add Create Unsigned button to SendConfirmationDialog (master...create-unsigned-sendconfdialog) https://github.com/bitcoin/bitcoin/pull/18789
7852021-09-30T19:44:27 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
7862021-09-30T19:44:43 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
7872021-09-30T19:45:48 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
7882021-09-30T19:51:37 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
7892021-09-30T19:51:45 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
7902021-09-30T19:55:45 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
7912021-09-30T19:55:53 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
7922021-09-30T19:56:11 *** gene <gene!~gene@gateway/tor-sasl/gene> has quit IRC (Quit: gene)
7932021-09-30T20:03:46 *** Neojack <Neojack!Neojack@pear.bnc4free.com> has quit IRC (Ping timeout: 250 seconds)
7942021-09-30T20:03:47 *** pigeons <pigeons!~pigeons@androzani.sysevolve.com> has quit IRC (Ping timeout: 240 seconds)
7952021-09-30T20:04:38 *** rockhouse <rockhouse!~rockhouse@user/rockhouse> has quit IRC (Ping timeout: 250 seconds)
7962021-09-30T20:04:39 *** takinbo <takinbo!~takinbo@user/takinbo> has quit IRC (Ping timeout: 250 seconds)
7972021-09-30T20:04:58 *** emzy <emzy!~quassel@user/emzy> has quit IRC (Ping timeout: 260 seconds)
7982021-09-30T20:05:20 *** doubleqp <doubleqp!~doubleqp@162.55.6.42> has quit IRC (Ping timeout: 260 seconds)
7992021-09-30T20:06:10 *** rockhouse <rockhouse!~rockhouse@user/rockhouse> has joined #bitcoin-core-dev
8002021-09-30T20:06:41 *** emzy <emzy!~quassel@user/emzy> has joined #bitcoin-core-dev
8012021-09-30T20:06:42 *** takinbo <takinbo!~takinbo@user/takinbo> has joined #bitcoin-core-dev
8022021-09-30T20:07:42 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
8032021-09-30T20:07:42 *** SpellChecker <SpellChecker!~SpellChec@gateway/tor-sasl/spellchecker> has quit IRC (Remote host closed the connection)
8042021-09-30T20:07:42 *** hex17or <hex17or!~hex17or@gateway/tor-sasl/hex17or> has quit IRC (Read error: Connection reset by peer)
8052021-09-30T20:07:42 *** dunxen <dunxen!~dunxen@gateway/tor-sasl/dunxen> has quit IRC (Read error: Connection reset by peer)
8062021-09-30T20:07:42 *** tla2k21 <tla2k21!~tla2k21@gateway/tor-sasl/tla2k21> has quit IRC (Read error: Connection reset by peer)
8072021-09-30T20:07:42 *** bairen <bairen!~bairen@gateway/tor-sasl/bairen> has quit IRC (Write error: Connection reset by peer)
8082021-09-30T20:07:42 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has quit IRC (Read error: Connection reset by peer)
8092021-09-30T20:07:42 *** vasild <vasild!~vd@user/vasild> has quit IRC (Read error: Connection reset by peer)
8102021-09-30T20:07:42 *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Read error: Connection reset by peer)
8112021-09-30T20:07:55 *** SpellChecker <SpellChecker!~SpellChec@gateway/tor-sasl/spellchecker> has joined #bitcoin-core-dev
8122021-09-30T20:07:56 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has joined #bitcoin-core-dev
8132021-09-30T20:07:59 *** bairen <bairen!~bairen@gateway/tor-sasl/bairen> has joined #bitcoin-core-dev
8142021-09-30T20:08:04 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
8152021-09-30T20:08:11 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
8162021-09-30T20:08:32 *** doubleqp <doubleqp!~doubleqp@162.55.6.42> has joined #bitcoin-core-dev
8172021-09-30T20:08:34 *** Neojack <Neojack!Neojack@pear.bnc4free.com> has joined #bitcoin-core-dev
8182021-09-30T20:09:25 *** pigeons <pigeons!~pigeons@androzani.sysevolve.com> has joined #bitcoin-core-dev
8192021-09-30T20:10:04 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
8202021-09-30T20:12:23 *** tla2k21 <tla2k21!~tla2k21@gateway/tor-sasl/tla2k21> has joined #bitcoin-core-dev
8212021-09-30T20:12:23 *** hex17or <hex17or!~hex17or@gateway/tor-sasl/hex17or> has joined #bitcoin-core-dev
8222021-09-30T20:12:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
8232021-09-30T20:12:49 <bitcoin-git> [bitcoin] kiminuo closed pull request #21577: refactor: Remove superfluous "return" from "addUnchecked" in txmempool.cpp (master...feature/2021-04-02-superfluous-return) https://github.com/bitcoin/bitcoin/pull/21577
8242021-09-30T20:12:51 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
8252021-09-30T20:19:47 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8262021-09-30T20:19:55 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8272021-09-30T20:23:56 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8282021-09-30T20:24:03 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8292021-09-30T20:24:59 *** mikehu44_ <mikehu44_!~quassel@206.189.41.250> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
8302021-09-30T20:28:59 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8312021-09-30T20:29:07 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8322021-09-30T20:34:33 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8332021-09-30T20:34:42 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8342021-09-30T20:40:58 <yanmaani> why'd you take out the -rescan?
8352021-09-30T20:41:14 <yanmaani> I recall having problems that caused Core to not start, but it didn't offer to do a rescan.
8362021-09-30T20:45:14 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8372021-09-30T20:45:22 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8382021-09-30T20:48:35 *** tripleslash <tripleslash!~triplesla@user/tripleslash> has quit IRC (Ping timeout: 252 seconds)
8392021-09-30T20:52:36 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8402021-09-30T20:52:43 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8412021-09-30T20:53:19 *** tripleslash <tripleslash!~triplesla@user/tripleslash> has joined #bitcoin-core-dev
8422021-09-30T20:54:38 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 252 seconds)
8432021-09-30T20:55:50 *** Guest2123 <Guest2123!~Guest2123@185.49.110.238> has joined #bitcoin-core-dev
8442021-09-30T20:56:29 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
8452021-09-30T21:00:47 *** Guest2123 <Guest2123!~Guest2123@185.49.110.238> has quit IRC (Quit: Client closed)
8462021-09-30T21:04:47 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8472021-09-30T21:04:56 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8482021-09-30T21:10:12 <yanmaani> Has it been discussed to standardize all the argument parsing boilerplate in the RPCs?
8492021-09-30T21:16:47 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8502021-09-30T21:16:55 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8512021-09-30T21:21:16 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8522021-09-30T21:21:24 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8532021-09-30T21:24:53 *** Guyver2 <Guyver2!~Guyver@2001:985:f3f:1:9897:b926:f3e9:ee7a> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
8542021-09-30T21:28:33 <luke-jr> yanmaani: are you confusing -rescan with -reindex?
8552021-09-30T21:28:49 <luke-jr> yanmaani: what "boilerplate" do you mean?
8562021-09-30T21:29:10 <luke-jr> I tried this but no review: https://github.com/bitcoin/bitcoin/pull/17356
8572021-09-30T21:30:20 <luke-jr> (can rebase if people say they want to review..)
8582021-09-30T21:33:16 <sipa> yanmaani: -rescan in happy cases is _never_ necessary; the wallet stores itself up to where it is in sync (since 0.3.21; 2011) and will at startup rescan whatever part is necessary
8592021-09-30T21:33:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
8602021-09-30T21:33:37 <bitcoin-git> [bitcoin] meshcollider opened pull request #23147: trivial refactor: rename DBErrors::RESCAN_REQUIRED to NEED_RESCAN (master...202110_rename_rescan_enum) https://github.com/bitcoin/bitcoin/pull/23147
8612021-09-30T21:33:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
8622021-09-30T21:34:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
8632021-09-30T21:34:05 <bitcoin-git> [bitcoin] meshcollider closed pull request #23141: test: Fix intermitent failure in wallet_basic.py (master...202109_fix_test_rounding) https://github.com/bitcoin/bitcoin/pull/23141
8642021-09-30T21:34:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
8652021-09-30T21:34:12 <sipa> and it's very annoying with the introduction of multiwallet, as now wallets can be loaded and unloaded on demand, rather than always being a single wallet at startup thing
8662021-09-30T21:34:24 <sipa> so there is a rescan RPC instead now, if you really need it
8672021-09-30T21:38:25 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8682021-09-30T21:38:33 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8692021-09-30T21:43:06 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8702021-09-30T21:43:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8712021-09-30T21:47:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8722021-09-30T21:47:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8732021-09-30T21:52:38 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8742021-09-30T21:52:46 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8752021-09-30T21:53:53 *** lightlike <lightlike!~lightlike@user/lightlike> has quit IRC (Quit: Leaving)
8762021-09-30T21:59:17 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8772021-09-30T21:59:26 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8782021-09-30T22:05:23 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8792021-09-30T22:05:31 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8802021-09-30T22:08:04 *** tralfaz is now known as davterra
8812021-09-30T22:12:04 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8822021-09-30T22:12:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8832021-09-30T22:19:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8842021-09-30T22:19:17 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8852021-09-30T22:19:57 <yanmaani> luke-jr: sorry, yeah, I mean reindex.
8862021-09-30T22:22:12 <yanmaani> luke-jr: yeah, that would be very cool and clean up a lot of code. Does this fix the part where you have to specify the types separately for the docs and for the CLI too?
8872021-09-30T22:27:49 <yanmaani> e.g. on lines 566-567 of your patch, it specifies bantime is RPCArg::Type::NUM and absolute is BOOL. But you also need to, in /src/rpc/client.cpp (lines 160-161), specify that bantime and absolute are non-string RPC arguments that need to be converted from JSON.
8882021-09-30T22:28:29 <yanmaani> Likewise with the default values, which are (correct me if I'm wrong here) implemented by checking if(null) value = myDefault, but also specified (unchecked!) in the docs. Which is a violaiton of DRY and generally ungainly
8892021-09-30T22:32:29 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8902021-09-30T22:32:33 <yanmaani> also, I think I'm missing something - most methods invoke RPCTypeCheck() on their request, but setban doesn't, even before your PR. Is this intentional? Would your PR obviate the need for it?
8912021-09-30T22:32:37 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8922021-09-30T22:35:26 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has quit IRC (Remote host closed the connection)
8932021-09-30T22:35:44 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has joined #bitcoin-core-dev
8942021-09-30T22:38:32 <meshcollider> yanmaani: We don't need to typecheck optional parameters that use e.g. get_int, get_str, get_bool, etc. because those functions will typecheck when called
8952021-09-30T22:39:17 <meshcollider> setban uses get_str and get_int64
8962021-09-30T22:44:55 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8972021-09-30T22:45:03 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8982021-09-30T22:46:33 *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has joined #bitcoin-core-dev
8992021-09-30T22:48:32 *** __nick__ <__nick__!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Ping timeout: 252 seconds)
9002021-09-30T22:51:05 *** bijoo <bijoo!~bijoo@96.86.11.105> has quit IRC (Quit: Client closed)
9012021-09-30T22:54:17 *** Guest64 <Guest64!~Guest64@a85-15-119-151.pppoe.vtelecom.ru> has joined #bitcoin-core-dev
9022021-09-30T22:56:35 <Guest64> Guys, hello. Tell me who's in the subject. I send a certain amount of money from Bitcoin Core to a Bitcoin address, the commission is generally acceptable. But the balance of the wallet itself is reduced by an amount that is 42 times more than the amount of funds sent. I canceled the operation. What can be wrong?
9032021-09-30T22:58:00 <yanmaani> meshcollider: ohh, right
9042021-09-30T22:58:17 <yanmaani> So the need for that would be a separate patch, yes?
9052021-09-30T22:59:52 <yanmaani> (1) default values, (2) non-string arguments in RPC client, and (3) RPCTypeCheck
9062021-09-30T23:01:17 <meshcollider> yanmaani: as I said, we don't need RPCTypeCheck? Not sure what you mean
9072021-09-30T23:01:26 <jonatack> yanmaani: have a look in src/univalue/lib/univalue_get.cpp for the get_int, get_str, get_bool, etc. type checking, if you're curious
9082021-09-30T23:01:33 *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 250 seconds)
9092021-09-30T23:04:55 <yanmaani> meshcollider: I'm asking if luke-jr's patch would obviate the need for RPCTypeCheck.
9102021-09-30T23:05:00 <yanmaani> Or if that would be a separate thing.
9112021-09-30T23:05:12 <yanmaani> (Or if it's not needed in new code)
9122021-09-30T23:05:25 <yanmaani> jonatack: right, but that only works for primitive/normal types, right?
9132021-09-30T23:09:25 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
9142021-09-30T23:09:34 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
9152021-09-30T23:10:04 <jonatack> yanmaani: best to review it :) ...from looking at it quickly, the patch seems to add named args. so that for instance, instead of:
9162021-09-30T23:10:14 <jonatack> bool absolute{request.params[3].isTrue() ? true : false)
9172021-09-30T23:10:23 <jonatack> we could write
9182021-09-30T23:10:27 <jonatack> bool absolute{request.m_params["absolute"].isTrue() ? true : false)
9192021-09-30T23:12:42 <jonatack> er, more correct examples: const bool absolute{request.params[3].isTrue() ? true : false}; -> const bool absolute{request.m_params["absolute"].isTrue() ? true : false};
9202021-09-30T23:12:57 <jonatack> etc.
9212021-09-30T23:15:02 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
9222021-09-30T23:15:37 *** Guest64 <Guest64!~Guest64@a85-15-119-151.pppoe.vtelecom.ru> has quit IRC (Quit: Client closed)
9232021-09-30T23:20:49 *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 252 seconds)
9242021-09-30T23:27:18 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
9252021-09-30T23:27:27 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
9262021-09-30T23:31:28 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
9272021-09-30T23:31:36 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
9282021-09-30T23:32:33 *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
9292021-09-30T23:36:34 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
9302021-09-30T23:36:43 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
9312021-09-30T23:40:43 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
9322021-09-30T23:40:51 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
9332021-09-30T23:47:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
9342021-09-30T23:47:29 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
9352021-09-30T23:53:52 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
9362021-09-30T23:54:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
9372021-09-30T23:58:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
9382021-09-30T23:58:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev