1 2021-10-22T00:03:23  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 258 seconds)
  2 2021-10-22T00:04:35  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
  3 2021-10-22T00:09:23  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 264 seconds)
  4 2021-10-22T00:09:53  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
  5 2021-10-22T00:38:36  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
  6 2021-10-22T00:43:15  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 258 seconds)
  7 2021-10-22T01:12:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
  8 2021-10-22T01:12:09  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/12ff8993bcc7...81cdbecd75ae
  9 2021-10-22T01:12:09  <bitcoin-git> bitcoin/master b00646b Hennadii Stepanov: ci, refactor: Rename VCPKG_TAG variable and vcpkg_cache script
 10 2021-10-22T01:12:09  <bitcoin-git> bitcoin/master e8692cf Hennadii Stepanov: ci: Improve vcpkg binary cache settings
 11 2021-10-22T01:12:09  <bitcoin-git> bitcoin/master 81cdbec fanquake: Merge bitcoin/bitcoin#23329: ci: Define cases when invalidate vcpkg binary...
 12 2021-10-22T01:12:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 13 2021-10-22T01:12:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 14 2021-10-22T01:12:26  <bitcoin-git> [bitcoin] fanquake merged pull request #23329: ci: Define cases when invalidate vcpkg binary cache (master...211020-vcpkg) https://github.com/bitcoin/bitcoin/pull/23329
 15 2021-10-22T01:12:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 16 2021-10-22T01:18:00  *** earnestly <earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 260 seconds)
 17 2021-10-22T01:31:07  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@d137-186-173-66.abhsia.telus.net> has joined #bitcoin-core-dev
 18 2021-10-22T01:35:46  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@d137-186-173-66.abhsia.telus.net> has quit IRC (Ping timeout: 260 seconds)
 19 2021-10-22T01:39:01  *** jespada <jespada!~jespada@2803:9800:9842:7a62:9560:3718:bb2f:f5ee> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 20 2021-10-22T01:57:48  *** copumpkin <copumpkin!~woohoo@user/copumpkin> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
 21 2021-10-22T01:58:26  *** copumpkin <copumpkin!~woohoo@user/copumpkin> has joined #bitcoin-core-dev
 22 2021-10-22T02:03:39  *** Guest17 <Guest17!~Guest17@2804-4b9c-7d-8e00-c1ec-9aac-f99d-4c12.seegfibras.com.br> has joined #bitcoin-core-dev
 23 2021-10-22T02:06:09  *** Guest17 <Guest17!~Guest17@2804-4b9c-7d-8e00-c1ec-9aac-f99d-4c12.seegfibras.com.br> has quit IRC (Client Quit)
 24 2021-10-22T02:17:37  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
 25 2021-10-22T02:22:09  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 258 seconds)
 26 2021-10-22T02:22:18  *** gene <gene!~gene@gateway/tor-sasl/gene> has quit IRC (Quit: gene)
 27 2021-10-22T02:27:25  *** lsilva_ <lsilva_!sid489830@id-489830.helmsley.irccloud.com> has quit IRC (Ping timeout: 260 seconds)
 28 2021-10-22T02:27:25  *** schmidty <schmidty!sid297174@id-297174.lymington.irccloud.com> has quit IRC (Ping timeout: 260 seconds)
 29 2021-10-22T02:27:54  *** stick <stick!sid403625@user/prusnak> has quit IRC (Ping timeout: 258 seconds)
 30 2021-10-22T02:28:22  *** schmidty <schmidty!sid297174@lymington.irccloud.com> has joined #bitcoin-core-dev
 31 2021-10-22T02:28:38  *** sebx2a_ <sebx2a_!sid356034@uxbridge.irccloud.com> has joined #bitcoin-core-dev
 32 2021-10-22T02:28:40  *** sebx2a <sebx2a!sid356034@id-356034.uxbridge.irccloud.com> has quit IRC (Ping timeout: 258 seconds)
 33 2021-10-22T02:28:40  *** sebx2a_ is now known as sebx2a
 34 2021-10-22T02:28:51  *** stick <stick!sid403625@user/prusnak> has joined #bitcoin-core-dev
 35 2021-10-22T02:29:32  *** lsilva_ <lsilva_!sid489830@helmsley.irccloud.com> has joined #bitcoin-core-dev
 36 2021-10-22T02:42:59  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
 37 2021-10-22T02:50:34  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
 38 2021-10-22T02:50:45  *** masta`` <masta``!~oyster@user/masta/x-2645138> has quit IRC (Remote host closed the connection)
 39 2021-10-22T02:54:55  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 252 seconds)
 40 2021-10-22T03:12:57  *** Guest9846 <Guest9846!~Guest98@2001:df1:800:c004:2::1> has joined #bitcoin-core-dev
 41 2021-10-22T03:16:44  *** Guest9846 <Guest9846!~Guest98@2001:df1:800:c004:2::1> has quit IRC (Client Quit)
 42 2021-10-22T03:18:12  *** BlueMatt_ <BlueMatt_!~BlueMatt@ircb.bluematt.me> has quit IRC (Read error: Connection reset by peer)
 43 2021-10-22T03:18:27  *** BlueMatt <BlueMatt!~BlueMatt@ircb.bluematt.me> has joined #bitcoin-core-dev
 44 2021-10-22T03:40:40  *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has joined #bitcoin-core-dev
 45 2021-10-22T03:44:01  *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has quit IRC (Client Quit)
 46 2021-10-22T03:44:45  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
 47 2021-10-22T03:47:40  *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has quit IRC (Quit: aллилѹіа!)
 48 2021-10-22T03:49:35  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 264 seconds)
 49 2021-10-22T03:51:56  *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has joined #bitcoin-core-dev
 50 2021-10-22T03:52:58  *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has quit IRC (Client Quit)
 51 2021-10-22T04:01:02  *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
 52 2021-10-22T04:01:08  *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
 53 2021-10-22T04:08:55  *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Ping timeout: 260 seconds)
 54 2021-10-22T04:20:36  *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 258 seconds)
 55 2021-10-22T04:24:51  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
 56 2021-10-22T04:31:43  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 252 seconds)
 57 2021-10-22T04:33:26  *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
 58 2021-10-22T05:07:22  *** BlueMatt <BlueMatt!~BlueMatt@ircb.bluematt.me> has quit IRC (Ping timeout: 258 seconds)
 59 2021-10-22T05:09:46  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
 60 2021-10-22T05:14:16  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 258 seconds)
 61 2021-10-22T05:15:39  *** BlueMatt <BlueMatt!~BlueMatt@ircb.bluematt.me> has joined #bitcoin-core-dev
 62 2021-10-22T05:18:59  *** sirdigby727 <sirdigby727!uid523338@lymington.irccloud.com> has quit IRC (Ping timeout: 264 seconds)
 63 2021-10-22T05:18:59  *** Jackielove4u <Jackielove4u!uid43977@user/jackielove4u> has quit IRC (Ping timeout: 264 seconds)
 64 2021-10-22T05:22:10  *** Jackielove4u <Jackielove4u!uid43977@user/jackielove4u> has joined #bitcoin-core-dev
 65 2021-10-22T05:22:14  *** sirdigby727 <sirdigby727!uid523338@id-523338.lymington.irccloud.com> has joined #bitcoin-core-dev
 66 2021-10-22T05:23:39  *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
 67 2021-10-22T05:23:58  *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
 68 2021-10-22T05:27:08  *** BlueMatt <BlueMatt!~BlueMatt@ircb.bluematt.me> has quit IRC (Quit: Quit)
 69 2021-10-22T05:27:23  *** BlueMatt <BlueMatt!~BlueMatt@ircb.bluematt.me> has joined #bitcoin-core-dev
 70 2021-10-22T05:40:11  *** jarthur_ <jarthur_!~jarthur@2603-8080-1540-002d-2cdd-ee6c-360d-1986.res6.spectrum.com> has quit IRC (Quit: jarthur_)
 71 2021-10-22T05:49:06  *** commmon <commmon!~common@096-033-221-075.res.spectrum.com> has quit IRC (Read error: Connection reset by peer)
 72 2021-10-22T05:49:31  *** commmon <commmon!~common@096-033-221-075.res.spectrum.com> has joined #bitcoin-core-dev
 73 2021-10-22T05:57:36  *** mikehu44_ <mikehu44_!~quassel@206.189.41.250> has joined #bitcoin-core-dev
 74 2021-10-22T06:00:56  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
 75 2021-10-22T06:05:13  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 252 seconds)
 76 2021-10-22T06:31:00  *** ArctVaulMarsHMPJ <ArctVaulMarsHMPJ!~pjetcetal@128-71-225-36.broadband.corbina.ru> has joined #bitcoin-core-dev
 77 2021-10-22T06:31:22  *** ArctVaulMarsHMPJ <ArctVaulMarsHMPJ!~pjetcetal@128-71-225-36.broadband.corbina.ru> has quit IRC (Read error: Connection reset by peer)
 78 2021-10-22T06:33:30  *** goatpig <goatpig!~goat@static-193-13-33-110.cust.tele2.se> has joined #bitcoin-core-dev
 79 2021-10-22T06:48:23  *** BlueMatt <BlueMatt!~BlueMatt@ircb.bluematt.me> has quit IRC (Ping timeout: 264 seconds)
 80 2021-10-22T06:51:30  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
 81 2021-10-22T06:55:49  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 252 seconds)
 82 2021-10-22T07:03:28  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 83 2021-10-22T07:03:28  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/81cdbecd75ae...9469ffcb17f0
 84 2021-10-22T07:03:28  <bitcoin-git> bitcoin/master fa38d98 MarcoFalke: doc: Add note on deleting past-EOL release branches
 85 2021-10-22T07:03:28  <bitcoin-git> bitcoin/master 9469ffc MarcoFalke: Merge bitcoin/bitcoin#23323: doc: Add note on deleting past-EOL release br...
 86 2021-10-22T07:03:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 87 2021-10-22T07:03:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 88 2021-10-22T07:03:45  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23323: doc: Add note on deleting past-EOL release branches (master...2110-docRelDel) https://github.com/bitcoin/bitcoin/pull/23323
 89 2021-10-22T07:03:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 90 2021-10-22T07:04:18  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 260 seconds)
 91 2021-10-22T07:04:38  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
 92 2021-10-22T07:09:10  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 260 seconds)
 93 2021-10-22T07:09:17  *** mikehu44__ <mikehu44__!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
 94 2021-10-22T07:11:33  *** BlueMatt <BlueMatt!~BlueMatt@ircb.bluematt.me> has joined #bitcoin-core-dev
 95 2021-10-22T07:26:08  *** mikehu44__ <mikehu44__!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 258 seconds)
 96 2021-10-22T07:26:27  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
 97 2021-10-22T07:29:57  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Client Quit)
 98 2021-10-22T07:32:56  *** smartin <smartin!~Icedove@88.135.18.171> has joined #bitcoin-core-dev
 99 2021-10-22T07:42:52  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
100 2021-10-22T07:47:13  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 258 seconds)
101 2021-10-22T07:58:26  *** dougefish <dougefish!~dougefish@5.29.58.227> has quit IRC (Ping timeout: 260 seconds)
102 2021-10-22T08:05:10  *** commmon <commmon!~common@096-033-221-075.res.spectrum.com> has quit IRC (Remote host closed the connection)
103 2021-10-22T08:06:36  *** commmon <commmon!~common@096-033-221-075.res.spectrum.com> has joined #bitcoin-core-dev
104 2021-10-22T08:25:03  *** earnestly <earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
105 2021-10-22T08:29:40  *** jesseposner_ <jesseposner_!~jesse@c-24-5-105-39.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 260 seconds)
106 2021-10-22T08:34:06  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
107 2021-10-22T08:38:40  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 252 seconds)
108 2021-10-22T09:01:11  *** BUSY <BUSY!~BUSY@user/busy> has quit IRC (Ping timeout: 265 seconds)
109 2021-10-22T09:07:23  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
110 2021-10-22T09:07:47  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
111 2021-10-22T09:19:07  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
112 2021-10-22T09:23:47  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 264 seconds)
113 2021-10-22T09:26:21  <jnewbery> laanwj fanquake: #23042 seems ready for merge
114 2021-10-22T09:26:22  <gribble> https://github.com/bitcoin/bitcoin/issues/23042 | net: Avoid logging AlreadyHaveTx when disconnecting misbehaving peer by MarcoFalke · Pull Request #23042 · bitcoin/bitcoin · GitHub
115 2021-10-22T09:28:43  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
116 2021-10-22T09:29:21  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
117 2021-10-22T09:51:20  <jnewbery> also #23140
118 2021-10-22T09:51:22  <gribble> https://github.com/bitcoin/bitcoin/issues/23140 | Make CAddrman::Select_ select buckets, not positions, first by sipa · Pull Request #23140 · bitcoin/bitcoin · GitHub
119 2021-10-22T09:53:25  <michaelfolkson> sipa: Right, just a template sketched out roadmap over multiple major versions to have discussions around. Some people raised on the mailing list (reasonably imo) that we shouldn't attempt this given it isn't binding in any way, no authority to ensure it happens, hard to predict what should be in future major versions etc
120 2021-10-22T09:55:24  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
121 2021-10-22T09:55:45  <michaelfolkson> But some things should be phased in/out over multiple major versions (if they are to happen at all) so to attempt this it needs a sketched out roadmap which hopefully reviewers will engage with and provide feedback. Deprecation of BDB is in similar boat
122 2021-10-22T09:56:41  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
123 2021-10-22T10:00:04  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 252 seconds)
124 2021-10-22T10:01:16  *** dougefish <dougefish!~dougefish@5.29.58.227> has joined #bitcoin-core-dev
125 2021-10-22T10:23:06  *** goatpig <goatpig!~goat@static-193-13-33-110.cust.tele2.se> has quit IRC (Ping timeout: 260 seconds)
126 2021-10-22T10:29:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
127 2021-10-22T10:29:25  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9469ffcb17f0...4833d1fdf39f
128 2021-10-22T10:29:25  <bitcoin-git> bitcoin/master 077a875 Joan Karadimov: refactor: include a missing <limits> header in fs.cpp
129 2021-10-22T10:29:25  <bitcoin-git> bitcoin/master 4833d1f MarcoFalke: Merge bitcoin/bitcoin#23335: refactor: include a missing <limits> header i...
130 2021-10-22T10:29:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
131 2021-10-22T10:29:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
132 2021-10-22T10:29:42  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23335: refactor: include a missing <limits> header in fs.cpp (master...include-missing-header) https://github.com/bitcoin/bitcoin/pull/23335
133 2021-10-22T10:29:43  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
134 2021-10-22T10:29:53  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
135 2021-10-22T10:30:35  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
136 2021-10-22T10:30:35  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4833d1fdf39f...c001da306b29
137 2021-10-22T10:30:35  <bitcoin-git> bitcoin/master d50fbd4 glozow: create explicit GenTxid::{Txid, Wtxid} ctors
138 2021-10-22T10:30:35  <bitcoin-git> bitcoin/master 4307849 glozow: [mempool] delete exists(uint256) function
139 2021-10-22T10:30:35  <bitcoin-git> bitcoin/master c001da3 MarcoFalke: Merge bitcoin/bitcoin#23325: mempool: delete exists(uint256) function
140 2021-10-22T10:30:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
141 2021-10-22T10:30:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
142 2021-10-22T10:30:52  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23325: mempool: delete exists(uint256) function (master...2021-10-exists-txid) https://github.com/bitcoin/bitcoin/pull/23325
143 2021-10-22T10:30:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
144 2021-10-22T10:34:21  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 258 seconds)
145 2021-10-22T10:36:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
146 2021-10-22T10:36:23  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #23336: refactor: Make GenTxid boolean constructor private (master...2110-delGenTxid) https://github.com/bitcoin/bitcoin/pull/23336
147 2021-10-22T10:36:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
148 2021-10-22T10:36:32  <laanwj> jnewbery: will have a look, thanks
149 2021-10-22T10:53:34  *** goatpig <goatpig!~goat@static-193-13-33-110.cust.tele2.se> has joined #bitcoin-core-dev
150 2021-10-22T10:57:09  *** goatpig <goatpig!~goat@static-193-13-33-110.cust.tele2.se> has quit IRC (Read error: Connection reset by peer)
151 2021-10-22T10:58:10  *** goatpig <goatpig!~goat@static-193-13-33-110.cust.tele2.se> has joined #bitcoin-core-dev
152 2021-10-22T11:06:52  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has joined #bitcoin-core-dev
153 2021-10-22T11:20:58  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
154 2021-10-22T11:23:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
155 2021-10-22T11:23:07  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c001da306b29...788909f3c79c
156 2021-10-22T11:23:07  <bitcoin-git> bitcoin/master fa2662c MarcoFalke: net: Avoid logging AlreadyHaveTx when disconnecting misbehaving peer
157 2021-10-22T11:23:07  <bitcoin-git> bitcoin/master 788909f fanquake: Merge bitcoin/bitcoin#23042: net: Avoid logging AlreadyHaveTx when disconn...
158 2021-10-22T11:23:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
159 2021-10-22T11:23:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
160 2021-10-22T11:23:24  <bitcoin-git> [bitcoin] fanquake merged pull request #23042: net: Avoid logging AlreadyHaveTx when disconnecting misbehaving peer (master...2109-netLogDisconnect) https://github.com/bitcoin/bitcoin/pull/23042
161 2021-10-22T11:23:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
162 2021-10-22T11:25:20  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 258 seconds)
163 2021-10-22T11:32:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
164 2021-10-22T11:32:24  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/788909f3c79c...02feae54a53f
165 2021-10-22T11:32:24  <bitcoin-git> bitcoin/master f19ad40 Andrew Chow: rpc, wallet: Descriptor wallets are no longer experimental
166 2021-10-22T11:32:24  <bitcoin-git> bitcoin/master 9c1052a Andrew Chow: wallet: Default new wallets to descriptor wallets
167 2021-10-22T11:32:24  <bitcoin-git> bitcoin/master 02feae5 MarcoFalke: Merge bitcoin/bitcoin#23002: Make descriptor wallets by default
168 2021-10-22T11:32:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
169 2021-10-22T11:32:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
170 2021-10-22T11:32:41  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23002: Make descriptor wallets by default (master...default-desc-wallets) https://github.com/bitcoin/bitcoin/pull/23002
171 2021-10-22T11:32:43  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
172 2021-10-22T11:34:59  <dougefish> Is there any demand to speed up the CI runs? For example, 04_install.sh updates/installs ubuntu packages every run. One way to decrease runtime is to create a fixed docker image. The default image ubuntu:bionic in .cirrus.yml would be replaced by our own image (e.g. itcoin-core:ubuntu-$SHA1). This also provides reproducale build/CI results, as well as easier to run locally.
173 2021-10-22T11:35:45  <dougefish> One downside i see is maintaince of this new image and where to "push" it
174 2021-10-22T11:39:38  *** dougefish <dougefish!~dougefish@5.29.58.227> has quit IRC (Quit: dougefish)
175 2021-10-22T11:41:23  *** dougefish <dougefish!~dougefish@5.29.58.227> has joined #bitcoin-core-dev
176 2021-10-22T11:43:07  *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has joined #bitcoin-core-dev
177 2021-10-22T11:44:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
178 2021-10-22T11:44:23  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #21954: Some minor code changes to improve efficiency of processing TXs (master...TXcatches) https://github.com/bitcoin/bitcoin/pull/21954
179 2021-10-22T11:44:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
180 2021-10-22T11:46:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
181 2021-10-22T11:46:24  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #21841: Send fewer feefilter messages (avoid the wobbling number issue) (master...SteadierFeefilter) https://github.com/bitcoin/bitcoin/pull/21841
182 2021-10-22T11:46:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
183 2021-10-22T11:48:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
184 2021-10-22T11:48:00  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #21827: Display progress of LoadBlockDB() on splash screen (master...SplashLoadBlockProgress) https://github.com/bitcoin/bitcoin/pull/21827
185 2021-10-22T11:48:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
186 2021-10-22T11:48:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
187 2021-10-22T11:48:51  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #21618: WIP: Reduce MinRelayFee slower when Mempool utilised and faster when needed. (master...MinRelayFeeReductionChanges) https://github.com/bitcoin/bitcoin/pull/21618
188 2021-10-22T11:48:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
189 2021-10-22T11:49:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
190 2021-10-22T11:49:41  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #21780: WIP - Add maxmempool RPC (master...MaxMempoolRPC) https://github.com/bitcoin/bitcoin/pull/21780
191 2021-10-22T11:49:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
192 2021-10-22T11:51:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
193 2021-10-22T11:51:01  <bitcoin-git> [bitcoin] dougEfresh opened pull request #23337: tests: Add assert_less_than and assert_less_than_or_equal to test framework (master...23119-assert_less) https://github.com/bitcoin/bitcoin/pull/23337
194 2021-10-22T11:51:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
195 2021-10-22T11:55:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
196 2021-10-22T11:55:36  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/02feae54a53f...58275db3717e
197 2021-10-22T11:55:36  <bitcoin-git> bitcoin/master 632aad9 Pieter Wuille: Make CAddrman::Select_ select buckets, not positions, first
198 2021-10-22T11:55:36  <bitcoin-git> bitcoin/master 58275db W. J. van der Laan: Merge bitcoin/bitcoin#23140: Make CAddrman::Select_ select buckets, not po...
199 2021-10-22T11:55:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
200 2021-10-22T11:55:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
201 2021-10-22T11:55:53  <bitcoin-git> [bitcoin] laanwj merged pull request #23140: Make CAddrman::Select_ select buckets, not positions, first (master...202109_addrmanbias) https://github.com/bitcoin/bitcoin/pull/23140
202 2021-10-22T11:55:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
203 2021-10-22T11:56:46  <jnewbery> thanks fanquake and laanwj!
204 2021-10-22T12:00:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
205 2021-10-22T12:00:46  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18902: Bugfix: Only use git for build info if the repository is actually the right one (master...fix_gitdir_again) https://github.com/bitcoin/bitcoin/pull/18902
206 2021-10-22T12:00:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
207 2021-10-22T12:01:06  *** mikehu44_ <mikehu44_!~quassel@206.189.41.250> has quit IRC (Ping timeout: 260 seconds)
208 2021-10-22T12:02:02  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has quit IRC (Ping timeout: 260 seconds)
209 2021-10-22T12:09:37  *** masta`` <masta``!~oyster@user/masta/x-2645138> has joined #bitcoin-core-dev
210 2021-10-22T12:10:59  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
211 2021-10-22T12:13:16  <real_or_random> dougefish: one neat possibility for cirrus CI is that you can use Cirrus to build the image, let them store it and then use it to run CI
212 2021-10-22T12:14:17  <real_or_random> we do this in secp256k1. it works pretty well there. though I think it's not compatible with some other features
213 2021-10-22T12:15:23  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 264 seconds)
214 2021-10-22T12:16:47  <MarcoFalke> dougefish: Our CI is platfrom agnostic. You should be able to run it on any CI provider, or even locally. I am not sure how much hassle this would be with self-made docker images.
215 2021-10-22T12:19:30  *** ravan <ravan!~ravan@user/ravan> has quit IRC (Quit: Leaving)
216 2021-10-22T12:28:24  <MarcoFalke> jonasschnelli: I was about to ask you whether you planned to remove your fingerprint from the "trusted-keys" for merging, but it looks like this will break verify-commits ...
217 2021-10-22T12:31:40  <laanwj> you would also have a add all his merge commits to exceptions, i guess
218 2021-10-22T12:32:38  <laanwj> or patch the script to allow different key for different ranges of commits
219 2021-10-22T12:33:04  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has joined #bitcoin-core-dev
220 2021-10-22T12:36:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
221 2021-10-22T12:36:05  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/58275db3717e...5bb03fba049b
222 2021-10-22T12:36:05  <bitcoin-git> bitcoin/master 6911ab9 Sebastian Falbesoner: wallet: fix segfault by avoiding invalid default-ctored `external_spk_mana...
223 2021-10-22T12:36:05  <bitcoin-git> bitcoin/master 5bb03fb fanquake: Merge bitcoin/bitcoin#23333: wallet: fix segfault by avoiding invalid defa...
224 2021-10-22T12:36:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
225 2021-10-22T12:36:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
226 2021-10-22T12:36:21  <bitcoin-git> [bitcoin] fanquake merged pull request #23333: wallet: fix segfault by avoiding invalid default-ctored `external_spk_managers` entry (master...202110-wallet-fix_getwalletinfo_segfault_after_importing_descriptor) https://github.com/bitcoin/bitcoin/pull/23333
227 2021-10-22T12:36:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
228 2021-10-22T12:39:11  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
229 2021-10-22T12:47:05  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
230 2021-10-22T12:52:41  *** SpellChecker <SpellChecker!~SpellChec@gateway/tor-sasl/spellchecker> has quit IRC (Remote host closed the connection)
231 2021-10-22T12:55:23  *** SpellChecker <SpellChecker!~SpellChec@gateway/tor-sasl/spellchecker> has joined #bitcoin-core-dev
232 2021-10-22T13:01:10  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
233 2021-10-22T13:05:25  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 252 seconds)
234 2021-10-22T13:13:23  *** jespada <jespada!~jespada@2803:9800:9842:7a62:c904:aff:1e1a:fc0a> has joined #bitcoin-core-dev
235 2021-10-22T13:14:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
236 2021-10-22T13:14:45  <bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/5bb03fba049b...12eda278ac03
237 2021-10-22T13:14:45  <bitcoin-git> bitcoin/master a5595b1 Andrew Chow: tests: Remove global vCoins and testWallet from coinselector_tests
238 2021-10-22T13:14:45  <bitcoin-git> bitcoin/master 5e54aa9 Andrew Chow: bench: remove global testWallet from CoinSelection benchmark
239 2021-10-22T13:14:45  <bitcoin-git> bitcoin/master 9bf0243 Andrew Chow: bench: Use DescriptorScriptPubKeyMan for wallet things
240 2021-10-22T13:14:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
241 2021-10-22T13:15:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
242 2021-10-22T13:15:02  <bitcoin-git> [bitcoin] laanwj merged pull request #23288: tests: remove usage of LegacyScriptPubKeyMan from some wallet tests (master...rm-testWallet-tests) https://github.com/bitcoin/bitcoin/pull/23288
243 2021-10-22T13:15:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
244 2021-10-22T13:15:43  <jonasschnelli> MarcoFalke: I had no plan to remove my keyid,… would that make sense and how would you fix verify commits?
245 2021-10-22T13:16:01  <jonasschnelli> Ideally, we should set en expiration date next to those keyid
246 2021-10-22T13:30:25  *** Guest54 <Guest54!~Guest54@75.177.176.83> has joined #bitcoin-core-dev
247 2021-10-22T13:30:49  *** Guest54 <Guest54!~Guest54@75.177.176.83> has quit IRC (Client Quit)
248 2021-10-22T13:44:02  <laanwj> intermittent error in unit tests: ./src/test/blockfilter_index_tests.cpp(140): fatal error: in "blockfilter_index_tests/blockfilter_index_initial_sync": critical check time_start + timeout_ms > GetTimeMillis() has failed
249 2021-10-22T13:47:35  *** goatpig <goatpig!~goat@static-193-13-33-110.cust.tele2.se> has quit IRC (Remote host closed the connection)
250 2021-10-22T13:52:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
251 2021-10-22T13:52:02  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/12eda278ac03...a685da55b5d4
252 2021-10-22T13:52:02  <bitcoin-git> bitcoin/master ea4b61a Pasta: refactor: remove references to deprecated values under std::allocator
253 2021-10-22T13:52:02  <bitcoin-git> bitcoin/master a685da5 W. J. van der Laan: Merge bitcoin/bitcoin#23181: refactor: remove references to deprecated val...
254 2021-10-22T13:52:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
255 2021-10-22T13:52:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
256 2021-10-22T13:52:19  <bitcoin-git> [bitcoin] laanwj merged pull request #23181: refactor: remove references to deprecated values under std::allocator (master...btc-allocator) https://github.com/bitcoin/bitcoin/pull/23181
257 2021-10-22T13:52:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
258 2021-10-22T13:55:36  *** BUSY <BUSY!~BUSY@user/busy> has joined #bitcoin-core-dev
259 2021-10-22T13:59:25  *** Guest48 <Guest48!~Guest48@2600:1700:b950:d740:d85b:abae:b59f:78b1> has quit IRC (Quit: Ping timeout (120 seconds))
260 2021-10-22T14:00:48  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
261 2021-10-22T14:04:29  *** Guest48 <Guest48!~Guest48@2600:1700:b950:d740:d85b:abae:b59f:78b1> has joined #bitcoin-core-dev
262 2021-10-22T14:05:22  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 252 seconds)
263 2021-10-22T14:13:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
264 2021-10-22T14:13:29  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a685da55b5d4...91c7d66c8b84
265 2021-10-22T14:13:29  <bitcoin-git> bitcoin/master d047ed7 Sebastian Falbesoner: external_signer: improve fingerprint matching logic (stop on first match)
266 2021-10-22T14:13:29  <bitcoin-git> bitcoin/master 91c7d66 W. J. van der Laan: Merge bitcoin/bitcoin#22789: external_signer: improve fingerprint matching...
267 2021-10-22T14:13:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
268 2021-10-22T14:13:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
269 2021-10-22T14:13:45  <bitcoin-git> [bitcoin] laanwj merged pull request #22789: external_signer: improve fingerprint matching logic (stop on first match) (master...202108-external_signer-improve_fingerprint_matching) https://github.com/bitcoin/bitcoin/pull/22789
270 2021-10-22T14:13:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
271 2021-10-22T14:14:38  *** Guest48 <Guest48!~Guest48@2600:1700:b950:d740:d85b:abae:b59f:78b1> has quit IRC (Quit: Client closed)
272 2021-10-22T14:22:42  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
273 2021-10-22T14:27:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
274 2021-10-22T14:27:24  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/91c7d66c8b84...a1d55ced099f
275 2021-10-22T14:27:24  <bitcoin-git> bitcoin/master d95913f Jon Atack: rpc: fix "trusted" description in TransactionDescriptionString
276 2021-10-22T14:27:24  <bitcoin-git> bitcoin/master 296cfa3 Jon Atack: test: add listtransactions/listsinceblock "trusted" coverage
277 2021-10-22T14:27:24  <bitcoin-git> bitcoin/master 66f6efc Jon Atack: rpc: improve TransactionDescriptionString() "generated" help
278 2021-10-22T14:27:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
279 2021-10-22T14:27:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
280 2021-10-22T14:27:41  <bitcoin-git> [bitcoin] laanwj merged pull request #23139: rpc: fix "trusted" field in TransactionDescriptionString(), add coverage (master...fix-rpc-trusted-field-help) https://github.com/bitcoin/bitcoin/pull/23139
281 2021-10-22T14:27:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
282 2021-10-22T14:28:57  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 258 seconds)
283 2021-10-22T15:02:56  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
284 2021-10-22T15:18:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
285 2021-10-22T15:18:25  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a1d55ced099f...224e90d9fdf8
286 2021-10-22T15:18:25  <bitcoin-git> bitcoin/master faeb9a5 MarcoFalke: remove unused CTxMemPool::info(const uint256& txid)
287 2021-10-22T15:18:25  <bitcoin-git> bitcoin/master fa4ec1c MarcoFalke: Make GenTxid boolean constructor private
288 2021-10-22T15:18:25  <bitcoin-git> bitcoin/master 224e90d MarcoFalke: Merge bitcoin/bitcoin#23336: refactor: Make GenTxid boolean constructor pr...
289 2021-10-22T15:18:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
290 2021-10-22T15:18:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
291 2021-10-22T15:18:42  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23336: refactor: Make GenTxid boolean constructor private (master...2110-delGenTxid) https://github.com/bitcoin/bitcoin/pull/23336
292 2021-10-22T15:18:43  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
293 2021-10-22T15:29:56  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9127:9bab:6e25:cfb7> has joined #bitcoin-core-dev
294 2021-10-22T15:42:27  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9127:9bab:6e25:cfb7> has quit IRC (Quit: Client closed)
295 2021-10-22T15:51:58  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:2477:6740:a868:bcf7> has joined #bitcoin-core-dev
296 2021-10-22T16:04:14  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
297 2021-10-22T16:07:00  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 260 seconds)
298 2021-10-22T16:09:59  <michaelfolkson> glozow: Just looking at #23121. Was there a reason to put the 2 things the PR does in the same PR?
299 2021-10-22T16:10:01  <gribble> https://github.com/bitcoin/bitcoin/issues/23121 | [policy] check ancestor feerate in RBF, remove BIP125 Rule2 by glozow · Pull Request #23121 · bitcoin/bitcoin · GitHub
300 2021-10-22T16:10:12  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has joined #bitcoin-core-dev
301 2021-10-22T16:13:16  <michaelfolkson> This getting through the fog of what is a bug and what isn't, how it should be disclosed if it is, how we should deal with policy long term going forward etc is hard to wade through (and it isn't your fault, I'm unsure too)
302 2021-10-22T16:18:57  *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
303 2021-10-22T16:19:26  <michaelfolkson> Btw I'm not suggesting you split into 2 PRs, just want to understand why you thought they should go together
304 2021-10-22T16:30:20  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
305 2021-10-22T16:31:56  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has joined #bitcoin-core-dev
306 2021-10-22T16:35:45  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has quit IRC (Client Quit)
307 2021-10-22T16:39:34  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Remote host closed the connection)
308 2021-10-22T16:39:58  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@d137-186-173-66.abhsia.telus.net> has joined #bitcoin-core-dev
309 2021-10-22T16:51:36  *** ravan <ravan!~ravan@user/ravan> has joined #bitcoin-core-dev
310 2021-10-22T16:57:07  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
311 2021-10-22T16:57:17  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Client Quit)
312 2021-10-22T16:58:38  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
313 2021-10-22T17:06:37  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@d137-186-173-66.abhsia.telus.net> has quit IRC (Remote host closed the connection)
314 2021-10-22T17:07:16  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
315 2021-10-22T17:13:01  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 258 seconds)
316 2021-10-22T17:13:07  <jnewbery> achow101: is it possible that #23288 has made `make check` run a lot more slowly?
317 2021-10-22T17:13:09  <gribble> https://github.com/bitcoin/bitcoin/issues/23288 | tests: remove usage of LegacyScriptPubKeyMan from some wallet tests by achow101 · Pull Request #23288 · bitcoin/bitcoin · GitHub
318 2021-10-22T17:13:14  <jnewbery> on master:
319 2021-10-22T17:13:15  <jnewbery> time ./src/test/test_bitcoin --run_test=coinselector_tests
320 2021-10-22T17:13:15  <jnewbery> [...]
321 2021-10-22T17:13:15  <jnewbery> real	1m13.509s
322 2021-10-22T17:13:25  <jnewbery> on 12eda278ac038fb998c2e6c19c4f07c91fcb83c2~ (commit before #23288 merge):
323 2021-10-22T17:13:26  <gribble> https://github.com/bitcoin/bitcoin/issues/23288 | tests: remove usage of LegacyScriptPubKeyMan from some wallet tests by achow101 · Pull Request #23288 · bitcoin/bitcoin · GitHub
324 2021-10-22T17:13:28  <jnewbery> time ./src/test/test_bitcoin --run_test=coinselector_tests
325 2021-10-22T17:13:31  <jnewbery> [...]
326 2021-10-22T17:13:33  <jnewbery> real	0m4.267s
327 2021-10-22T17:13:57  <jnewbery> so that single unit test has gone from ~4s to ~1min13s for me
328 2021-10-22T17:14:08  <achow101> jnewbery: seems plausible
329 2021-10-22T17:14:33  <achow101> each test case is doing setup now rather than having it occur globally
330 2021-10-22T17:14:52  <achow101> setup for descriptors may also take a little bit longer than setup for legacy
331 2021-10-22T17:14:53  <jnewbery> coinselector_tests is one of the last unit tests run, so even with -j it adds a lot of time to the `make check` run
332 2021-10-22T17:15:47  <achow101> I will see if it can be sped up
333 2021-10-22T17:15:54  <jnewbery> thank you!
334 2021-10-22T17:25:54  *** gene <gene!~gene@gateway/tor-sasl/gene> has joined #bitcoin-core-dev
335 2021-10-22T17:47:20  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
336 2021-10-22T17:51:59  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 264 seconds)
337 2021-10-22T18:07:17  *** xavihers <xavihers!~xavihers@2803:2d60:1103:24c:2589:6983:ad21:29ac> has joined #bitcoin-core-dev
338 2021-10-22T18:07:59  <xavihers> Hello everyone, good afternoon
339 2021-10-22T18:08:08  <xavihers> one question!
340 2021-10-22T18:08:42  <xavihers> I want develop a wallet for bitcoin on my country.
341 2021-10-22T18:09:31  <xavihers> What do you recommend?
342 2021-10-22T18:09:42  <xavihers> Regards,
343 2021-10-22T18:12:09  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
344 2021-10-22T18:12:43  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has joined #bitcoin-core-dev
345 2021-10-22T18:12:45  <sipa> this channel is for development of the bitcoin core software, not recommendations for other software
346 2021-10-22T18:13:25  <xavihers> Ok I understand!
347 2021-10-22T18:17:11  *** xavihers <xavihers!~xavihers@2803:2d60:1103:24c:2589:6983:ad21:29ac> has quit IRC (Quit: Client closed)
348 2021-10-22T18:18:25  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
349 2021-10-22T18:23:45  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:2477:6740:a868:bcf7> has quit IRC (Quit: Client closed)
350 2021-10-22T18:31:01  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 252 seconds)
351 2021-10-22T18:31:16  *** jesseposner <jesseposner!~jesse@c-24-5-105-39.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
352 2021-10-22T18:36:13  <michaelfolkson> Don't think gnusha picked up these for the wallet meeting in 30 minutes
353 2021-10-22T18:36:23  <michaelfolkson> [21:46:21]  <achow101> #proposedwalletmeetingtopic feature_segwit.py
354 2021-10-22T18:36:23  <michaelfolkson> [21:46:28]  <achow101> #proposedwalletmeetingtopic feature_segwit.py's dependency on legacy wallet
355 2021-10-22T18:38:05  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
356 2021-10-22T18:46:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
357 2021-10-22T18:46:02  <bitcoin-git> [bitcoin] JeremyRubin closed pull request #22948: [Tests] Compute the Power Set of all flags instead of one by one exclusion (master...flag-powerset) https://github.com/bitcoin/bitcoin/pull/22948
358 2021-10-22T18:46:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
359 2021-10-22T18:47:11  <jeremyrubin> does anyone have any feelings on #22954 and #22876?
360 2021-10-22T18:47:12  <gribble> https://github.com/bitcoin/bitcoin/issues/22954 | [TESTS] Allow tx_invalid.json tests to include flag rules for if_unset: [A,B,C] then_unset: [D] by JeremyRubin · Pull Request #22954 · bitcoin/bitcoin · GitHub
361 2021-10-22T18:47:13  <gribble> https://github.com/bitcoin/bitcoin/issues/22876 | [TESTS] Update Transaction Tests to permit setting a flag as always on and disabling the exhaustive failure test by JeremyRubin · Pull Request #22876 · bitcoin/bitcoin · GitHub
362 2021-10-22T18:49:04  <jeremyrubin> i recall sipa ack'd this approach in IRC a while back as being the lesser evil (of that, or making CTV valid in mempool before active)
363 2021-10-22T18:49:18  <jeremyrubin> but i don't think that approach ack extended to these testing changes
364 2021-10-22T18:56:45  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
365 2021-10-22T18:56:49  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:2477:6740:a868:bcf7> has joined #bitcoin-core-dev
366 2021-10-22T19:00:49  <achow101> #startmeeting
367 2021-10-22T19:00:49  <core-meetingbot> Meeting started Fri Oct 22 19:00:49 2021 UTC.  The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
368 2021-10-22T19:00:49  <core-meetingbot> Available commands: action commands idea info link nick
369 2021-10-22T19:01:08  <achow101> #bitcoin-core-dev Wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd
370 2021-10-22T19:01:08  <achow101> phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
371 2021-10-22T19:01:20  <michaelfolkson> hi
372 2021-10-22T19:01:29  <S3RK> hi
373 2021-10-22T19:01:33  <meshcollider> hi
374 2021-10-22T19:02:00  <achow101> there is one preproposed topic, any other topics?
375 2021-10-22T19:03:00  <achow101> #topic feature_segwit.py's dependency on legacy wallet (achow101)
376 2021-10-22T19:03:00  <core-meetingbot> topic: feature_segwit.py's dependency on legacy wallet (achow101)
377 2021-10-22T19:03:19  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
378 2021-10-22T19:03:38  <achow101> feature_segwit.py is currently legacy wallet only test
379 2021-10-22T19:03:47  <brunoerg> hi
380 2021-10-22T19:03:55  <achow101> I was wondering if we thought it was important enough to refactor to not depend on the lgacy wallet
381 2021-10-22T19:03:56  <gene> hi
382 2021-10-22T19:04:00  <achow101> or if it was ok to just ditch it
383 2021-10-22T19:04:20  <achow101> it seems like a big chunk of it is testing legacy wallet only things
384 2021-10-22T19:04:32  <achow101> but there is also a part that tests segwit activation and non-wallet things
385 2021-10-22T19:04:34  <sipa> let me see
386 2021-10-22T19:05:15  <michaelfolkson> Is this resolved by extending the functionality of MiniWallet (longer term potentially)?
387 2021-10-22T19:05:28  <achow101> michaelfolkson: no, it's specifically testing weird IsMine behavior
388 2021-10-22T19:05:43  <achow101> and how the legacy wallet deals with imports, adding segwit addresses, etc.
389 2021-10-22T19:06:00  <sipa> as long as we have the legacy wallet, i think it's important that those things get tested
390 2021-10-22T19:06:06  <S3RK> is it covered by other tests?
391 2021-10-22T19:06:12  <sipa> but it should be separate from testing segwit consensus/activation logic
392 2021-10-22T19:06:34  <achow101> sipa: yes, but after legacy wallet removal?
393 2021-10-22T19:06:49  <sipa> what do you mean by removal?
394 2021-10-22T19:07:18  <achow101> sipa: I've been experimenting with removing the legacy wallet outright (except for migration) and seeing what other things will need to be done in order to get that through
395 2021-10-22T19:07:36  <sipa> that's useful i guess to see what unnecessarily depends on it
396 2021-10-22T19:07:57  <sipa> though, i hope we're not planning to actually drop support for legacy wallets anytime soon?
397 2021-10-22T19:08:05  <michaelfolkson> For the benefit of those following along achow101 is in process of deprecating both the legacy wallet and BerkeleyDB https://github.com/bitcoin/bitcoin/issues/20160
398 2021-10-22T19:08:07  <achow101> see #20160
399 2021-10-22T19:08:08  <gribble> https://github.com/bitcoin/bitcoin/issues/20160 | Proposed Timeline for Legacy Wallet and BDB removal · Issue #20160 · bitcoin/bitcoin · GitHub
400 2021-10-22T19:08:28  <achow101> sipa: the plan is for a few years
401 2021-10-22T19:08:28  <michaelfolkson> Legacy wallet is non-descriptor wallet
402 2021-10-22T19:08:49  <michaelfolkson> "The 4 combinations of type and format are: legacy-bdb, legacy-sqlite, descriptor-bdb, and descriptor-sqlite"
403 2021-10-22T19:08:49  <sipa> yeah, ok, a few years from now
404 2021-10-22T19:09:55  <sipa> i think in principle, tests testing the wallet behavior should be separate from tests of other behavior
405 2021-10-22T19:10:52  <achow101> agreed
406 2021-10-22T19:10:56  <sipa> the feature_segwit.py test does seem to mix these
407 2021-10-22T19:11:27  <michaelfolkson> So split feature_segwit.py up into 2+ files?
408 2021-10-22T19:11:44  <sipa> i don't think files matter
409 2021-10-22T19:11:57  <sipa> just cleanly separating the tests would be a nice improvement already
410 2021-10-22T19:13:02  <michaelfolkson> It seems to me that legacy wallet support in the tests has to linger to a limited extent to do migration test etc
411 2021-10-22T19:13:36  <achow101> #23312 puts all of the legacy wallet specific tests of feature_segwit behind --legacy-wallet
412 2021-10-22T19:13:37  <gribble> https://github.com/bitcoin/bitcoin/issues/23312 | tests: reduce feature_segwit.py usage of the legacy wallet by achow101 · Pull Request #23312 · bitcoin/bitcoin · GitHub
413 2021-10-22T19:13:52  <sipa> there is a difference between a test _of non-wallet code_ that happens to use the wallet
414 2021-10-22T19:13:58  <sipa> and a test of the wallet code itself
415 2021-10-22T19:14:15  <achow101> although I'm not sure if the first part that does some stuff with multisig is testing legacy wallet or just incidental
416 2021-10-22T19:15:18  <michaelfolkson> "a test _of non-wallet code_ that happens to use the wallet" should use MiniWallet longer term right?
417 2021-10-22T19:15:30  <sipa> maybe, i haven't paid attention to that
418 2021-10-22T19:15:33  <sipa> but probably, yes
419 2021-10-22T19:15:36  <michaelfolkson> But not "a test of the wallet code itself"
420 2021-10-22T19:17:13  <achow101> ok, I guess I will try to split it up
421 2021-10-22T19:17:32  <sipa> FWIW, i think a bunch of non-wallet tests of script features etc can probably be redone in feature_taproot.py
422 2021-10-22T19:17:46  <sipa> it has a whole framework of randomly constructing errors/transactions/scripts
423 2021-10-22T19:17:57  <michaelfolkson> Hmm I guess a refactor would be better but maybe someone other than achow101 could attempt it (if he has enough to do!)
424 2021-10-22T19:18:33  <michaelfolkson> Interested S3RK? :)
425 2021-10-22T19:18:36  <sipa> and feature_taproot.py itself might be portable to use miniwallet for the wallet side of things (it already mostly does its own utxo management etc)
426 2021-10-22T19:19:15  <S3RK> i can take on it, once i finish the coin selection improvement that I started
427 2021-10-22T19:20:24  <S3RK> i hope it can wait, because with my speed it might take a while :)
428 2021-10-22T19:20:44  <sipa> it's been there for 4 years, it won't run away
429 2021-10-22T19:21:11  <achow101> I have another topic if we're done with this one?
430 2021-10-22T19:21:58  <achow101> #topic having ScriptPubKeyMans fetch keys from a wallet keystore rather than handling keys individually
431 2021-10-22T19:21:58  <core-meetingbot> topic: having ScriptPubKeyMans fetch keys from a wallet keystore rather than handling keys individually
432 2021-10-22T19:23:05  <achow101> one of the issues with setting up multisigs and setting up new descriptors is that keys are tied to ScriptPubKeyMans, so it is difficult to get a "wallet key"
433 2021-10-22T19:23:18  <sipa> (judging based just on the one-line summary) that sounds like a good idea... you could think of it as the integrated "software signing device" of the wallet
434 2021-10-22T19:23:38  <S3RK> do you mean master key, right?
435 2021-10-22T19:24:20  <achow101> sipa: yes, I was thinking of something in the same model of external hardware signer but internal and software
436 2021-10-22T19:24:45  <sipa> i think it makes sense... there is nothing that makes private keys tied to specific SPKmans
437 2021-10-22T19:24:51  <achow101> S3RK: kind of
438 2021-10-22T19:25:10  <sipa> spkmans mostly ought to live in the "deciding what is ours" domain, not in the "what can we sign" domain
439 2021-10-22T19:25:33  <achow101> sipa: but "what can we sign" should align with "what is ours"
440 2021-10-22T19:25:57  <sipa> achow101: well, maybe- there are also external signers, watch-only wallets, multisig you can participate in
441 2021-10-22T19:26:11  <sipa> those are modeled by spkmans, but their signing story is kind of orthogonal
442 2021-10-22T19:26:36  <achow101> sipa: but all of those things would be tied to a spkman that should be in the wallet
443 2021-10-22T19:26:53  <sipa> right, but does it matter _which_ spkman?
444 2021-10-22T19:26:58  <sipa> holds the keys
445 2021-10-22T19:27:17  <sipa> like you can sign for something, or you can't
446 2021-10-22T19:27:47  <achow101> sure
447 2021-10-22T19:27:47  <sipa> if you'd have the same pubkey/xpub in multiple distinct descriptors, would you ever not want to sign with one, because it was linked with another descriptor?
448 2021-10-22T19:27:56  <sipa> you have the key, might as well use it
449 2021-10-22T19:28:04  <achow101> I think that's fine
450 2021-10-22T19:28:13  <achow101> what I want to avoid is signing for things for which we don't have a spkman for
451 2021-10-22T19:28:26  <achow101> e.g. if the wallet only has a wpkh(), then it shouldn't sign for multisigs even if it has the keys
452 2021-10-22T19:28:51  <sipa> i think that's fine; i'm not sure it's necessarily a problem if it's different
453 2021-10-22T19:29:24  <sipa> once an output is created it's "too late" in a sense - if you can sign for it, and it's in a transaction that you agree with, why wouldn't you?
454 2021-10-22T19:30:16  <sipa> of course, in practice, in order to sign you'll likely need access to an SPKMan to pull things like redeemscripts and whatnot
455 2021-10-22T19:30:32  <achow101> if it's in a psbt, not necessarily
456 2021-10-22T19:30:34  <sipa> right
457 2021-10-22T19:30:59  <sipa> in a psbt, i think there is no problem at all with signing whatever you can, independent of whether it's something you consider yours or not
458 2021-10-22T19:31:20  <sipa> but i'm also fine with "that's too hard to make work, and isn't supported"
459 2021-10-22T19:31:44  <achow101> it's probably easier to make that work given the way our signing code is setup
460 2021-10-22T19:32:17  <achow101> in any case, it seems like this change would be a good idea
461 2021-10-22T19:32:38  <S3RK> fwiw, I think it's good
462 2021-10-22T19:33:01  <achow101> it would also make adding new descriptors like tr() easier
463 2021-10-22T19:33:14  <S3RK> and multisig
464 2021-10-22T19:33:21  <achow101> any other topics
465 2021-10-22T19:33:27  <sipa> right, import the same xpub (maybe different branch), and signing will just work?
466 2021-10-22T19:34:22  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
467 2021-10-22T19:34:23  <achow101> #endmeeting
468 2021-10-22T19:34:23  <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
469 2021-10-22T19:34:23  <core-meetingbot> Meeting ended Fri Oct 22 19:34:23 2021 UTC.
470 2021-10-22T19:34:23  <core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-10-22-19.00.moin.txt
471 2021-10-22T19:34:30  <S3RK> achow101: do you plan to implement it before doing "upgrade wallet to tr" feature?
472 2021-10-22T19:35:03  <achow101> S3RK: probably
473 2021-10-22T19:35:34  <S3RK> i was about to ask how is it going. but I guess this topic was the answer
474 2021-10-22T19:35:34  <achow101> I'm going to try it on monday
475 2021-10-22T19:36:02  *** tralfaz <tralfaz!~davterra@143.198.56.186> has joined #bitcoin-core-dev
476 2021-10-22T19:36:26  <achow101> S3RK: I do have a functional branch that does tr upgrade. but I don't really like that approach which is why there isn't a PR for it
477 2021-10-22T19:36:53  *** freesprung <freesprung!~freesprun@user/freesprung> has joined #bitcoin-core-dev
478 2021-10-22T19:36:59  <S3RK> understandable, it's hacky. well looking forward to it
479 2021-10-22T19:37:28  <michaelfolkson> This functional branch does what exactly?
480 2021-10-22T19:37:36  *** davterra <davterra!~davterra@143.198.56.186> has quit IRC (Ping timeout: 245 seconds)
481 2021-10-22T19:38:06  <michaelfolkson> tr(KEY) is supported already so this branch upgrades to what?
482 2021-10-22T19:38:09  <achow101> michaelfolkson: automagically adds a tr descriptor to a wallet
483 2021-10-22T19:38:18  <michaelfolkson> Ah ok
484 2021-10-22T19:38:29  <michaelfolkson> Without user generating it?
485 2021-10-22T19:38:36  <achow101> yes-ish
486 2021-10-22T19:39:02  <achow101> it requires knowing the spkman id for something already in the wallet and it pulls the key to use from there
487 2021-10-22T19:39:06  <achow101> kinda shit in terms of ux
488 2021-10-22T19:40:06  <S3RK> wouldn't you have the same problem when trying to pull the keys from spkman to the wallet?
489 2021-10-22T19:40:26  <S3RK> how do you know which key to pick? (in case different descriptors have different keys)
490 2021-10-22T19:40:47  <achow101> my current idea is that there would be a record in the wallet similar to the hdchain record
491 2021-10-22T19:41:04  <achow101> it would store the xpub of the key last used for autogenerating descriptors
492 2021-10-22T19:41:17  <S3RK> but that's only for the new wallets. What about the existing ones?
493 2021-10-22T19:41:38  <achow101> for existing wallets, we can determine that with a bit of heuristics. it would pretty much be the only key that has a descriptor for each address type
494 2021-10-22T19:41:56  <achow101> I think it is highly unlikely that someone would import 1 descriptor for each address type all using the same key
495 2021-10-22T19:42:08  <S3RK> should work 99% of the time :)
496 2021-10-22T19:42:19  <achow101> and if they did, I feel like they would expect that key to be used for tr too, so not really a problem :)
497 2021-10-22T19:42:32  <achow101> s/expect/want
498 2021-10-22T19:42:50  <S3RK> yes, that make sense to me
499 2021-10-22T19:43:28  <achow101> additionally, we should try to get this in before 23.0 because then we can say "it was experimental :shrug:"
500 2021-10-22T19:43:34  <S3RK> so it'll be some upgrade wallet code at load time (w/o explicit user action)?
501 2021-10-22T19:43:47  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:2477:6740:a868:bcf7> has quit IRC (Quit: Client closed)
502 2021-10-22T19:43:59  <S3RK> I'd happily review and test this
503 2021-10-22T19:44:05  <achow101> yes, I don't think it will need any explicit user action
504 2021-10-22T19:44:21  <S3RK> sounds goot to me
505 2021-10-22T19:44:29  <S3RK> s/goot/good/
506 2021-10-22T19:46:20  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
507 2021-10-22T19:46:59  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
508 2021-10-22T20:04:25  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Ping timeout: 260 seconds)
509 2021-10-22T20:10:42  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Remote host closed the connection)
510 2021-10-22T20:11:14  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
511 2021-10-22T20:15:31  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 245 seconds)
512 2021-10-22T20:18:37  *** gene <gene!~gene@gateway/tor-sasl/gene> has quit IRC (Quit: gene)
513 2021-10-22T20:20:56  *** kinlo <kinlo!~peter@user/kinlo> has quit IRC (Ping timeout: 245 seconds)
514 2021-10-22T20:22:41  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
515 2021-10-22T20:26:02  *** promag <promag!~promag@188.250.84.129> has quit IRC (Read error: Connection reset by peer)
516 2021-10-22T20:26:21  *** kinlo <kinlo!~peter@user/kinlo> has joined #bitcoin-core-dev
517 2021-10-22T20:39:27  *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
518 2021-10-22T20:41:03  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 276 seconds)
519 2021-10-22T20:44:35  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@d137-186-173-66.abhsia.telus.net> has joined #bitcoin-core-dev
520 2021-10-22T20:48:51  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@d137-186-173-66.abhsia.telus.net> has quit IRC (Ping timeout: 245 seconds)
521 2021-10-22T20:50:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
522 2021-10-22T20:50:53  <bitcoin-git> [gui] hebasto merged pull request #454: Use only Qt translation primitives in GUI code (master...2021-10-qt-use-at-translation) https://github.com/bitcoin-core/gui/pull/454
523 2021-10-22T20:50:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
524 2021-10-22T20:51:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
525 2021-10-22T20:51:18  <bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/224e90d9fdf8...bdbefdcd5cce
526 2021-10-22T20:51:18  <bitcoin-git> bitcoin/master 58765a4 W. J. van der Laan: qt: Use only Qt translation primitives in GUI code
527 2021-10-22T20:51:18  <bitcoin-git> bitcoin/master bdbefdc Hennadii Stepanov: Merge bitcoin-core/gui#454: Use only Qt translation primitives in GUI code...
528 2021-10-22T20:51:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
529 2021-10-22T20:53:53  *** copumpkin <copumpkin!~woohoo@user/copumpkin> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
530 2021-10-22T20:58:27  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
531 2021-10-22T21:09:33  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
532 2021-10-22T21:09:39  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
533 2021-10-22T21:10:10  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
534 2021-10-22T21:21:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
535 2021-10-22T21:21:17  <bitcoin-git> [bitcoin] achow101 opened pull request #23338: tests: speed up coinselector_tests (master...speed-up-cs-tests) https://github.com/bitcoin/bitcoin/pull/23338
536 2021-10-22T21:21:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
537 2021-10-22T21:31:26  *** fjahr <fjahr!sid374480@uxbridge.irccloud.com> has quit IRC (*.net *.split)
538 2021-10-22T21:31:26  *** jarolrod <jarolrod!sid475272@uxbridge.irccloud.com> has quit IRC (*.net *.split)
539 2021-10-22T21:31:26  *** Evolver <Evolver!sid32215@user/evolver> has quit IRC (*.net *.split)
540 2021-10-22T21:31:26  *** jkczyz <jkczyz!sid419941@lymington.irccloud.com> has quit IRC (*.net *.split)
541 2021-10-22T21:31:26  *** lightlike <lightlike!uid521075@user/lightlike> has quit IRC (*.net *.split)
542 2021-10-22T21:31:26  *** gribble <gribble!~gribble@bitcoin/bot/gribble> has quit IRC (*.net *.split)
543 2021-10-22T21:31:26  *** Keele <Keele!~keele@91-158-68-128.elisa-laajakaista.fi> has quit IRC (*.net *.split)
544 2021-10-22T21:31:26  *** sturles <sturles!~sturles@sauron.uio.no> has quit IRC (*.net *.split)
545 2021-10-22T21:31:26  *** Nebraskka <Nebraskka!~Nebraskka@user/nebraskka> has quit IRC (*.net *.split)
546 2021-10-22T21:31:26  *** hendi <hendi!sid489601@lymington.irccloud.com> has quit IRC (*.net *.split)
547 2021-10-22T21:31:26  *** larryruane <larryruane!sid473749@uxbridge.irccloud.com> has quit IRC (*.net *.split)
548 2021-10-22T21:31:26  *** darosior <darosior!~darosior@194.36.189.246> has quit IRC (*.net *.split)
549 2021-10-22T21:31:26  *** real_or_random <real_or_random!~real_or_r@user/real-or-random/x-4440763> has quit IRC (*.net *.split)
550 2021-10-22T21:31:26  *** willcl_ark <willcl_ark!~quassel@user/willcl-ark/x-8282106> has quit IRC (*.net *.split)
551 2021-10-22T21:31:26  *** cdecker <cdecker!~cdecker@243.86.254.84.ftth.as8758.net> has quit IRC (*.net *.split)
552 2021-10-22T21:31:33  *** jarolrod <jarolrod!sid475272@id-475272.uxbridge.irccloud.com> has joined #bitcoin-core-dev
553 2021-10-22T21:31:34  *** fjahr <fjahr!sid374480@id-374480.uxbridge.irccloud.com> has joined #bitcoin-core-dev
554 2021-10-22T21:31:37  *** sturles <sturles!~sturles@sauron.uio.no> has joined #bitcoin-core-dev
555 2021-10-22T21:31:37  *** Keele <Keele!~keele@91-158-68-128.elisa-laajakaista.fi> has joined #bitcoin-core-dev
556 2021-10-22T21:31:45  *** lightlike <lightlike!sid521075@user/lightlike> has joined #bitcoin-core-dev
557 2021-10-22T21:31:53  *** larryruane <larryruane!sid473749@id-473749.uxbridge.irccloud.com> has joined #bitcoin-core-dev
558 2021-10-22T21:31:59  *** jkczyz <jkczyz!sid419941@id-419941.lymington.irccloud.com> has joined #bitcoin-core-dev
559 2021-10-22T21:32:05  *** Evolver <Evolver!sid32215@user/evolver> has joined #bitcoin-core-dev
560 2021-10-22T21:32:46  *** hendi <hendi!sid489601@id-489601.lymington.irccloud.com> has joined #bitcoin-core-dev
561 2021-10-22T21:33:25  *** Nebraskka <Nebraskka!~Nebraskka@user/nebraskka> has joined #bitcoin-core-dev
562 2021-10-22T21:33:32  *** real_or_random <real_or_random!~real_or_r@user/real-or-random/x-4440763> has joined #bitcoin-core-dev
563 2021-10-22T21:34:13  *** darosior <darosior!~darosior@194.36.189.246> has joined #bitcoin-core-dev
564 2021-10-22T21:38:32  *** gribble <gribble!~gribble@bitcoin/bot/gribble> has joined #bitcoin-core-dev
565 2021-10-22T21:38:32  *** ChanServ sets mode: +o gribble
566 2021-10-22T21:42:16  *** smartin <smartin!~Icedove@88.135.18.171> has quit IRC (Quit: smartin)
567 2021-10-22T21:43:56  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
568 2021-10-22T21:54:17  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Remote host closed the connection)
569 2021-10-22T21:54:29  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
570 2021-10-22T22:37:16  *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has quit IRC (Quit: aллилѹіа!)
571 2021-10-22T22:58:31  *** jespada <jespada!~jespada@2803:9800:9842:7a62:c904:aff:1e1a:fc0a> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
572 2021-10-22T23:00:56  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has joined #bitcoin-core-dev
573 2021-10-22T23:02:32  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has quit IRC (Client Quit)
574 2021-10-22T23:18:17  *** ravan <ravan!~ravan@user/ravan> has quit IRC (Remote host closed the connection)
575 2021-10-22T23:18:36  *** ravan <ravan!~ravan@user/ravan> has joined #bitcoin-core-dev
576 2021-10-22T23:19:29  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Remote host closed the connection)
577 2021-10-22T23:20:03  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
578 2021-10-22T23:24:43  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has quit IRC (Ping timeout: 252 seconds)
579 2021-10-22T23:31:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
580 2021-10-22T23:31:25  <bitcoin-git> [bitcoin] PastaPastaPasta opened pull request #23340: build: upgrade to boost 1.73 to fix c++20 compilation (master...bump-boost-version-1.73-btc) https://github.com/bitcoin/bitcoin/pull/23340
581 2021-10-22T23:31:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
582 2021-10-22T23:39:51  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te4021dky9o7qud.ipv6.telus.net> has joined #bitcoin-core-dev
583 2021-10-22T23:47:30  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev