1 2021-10-26T00:15:15  *** tla2k21 <tla2k21!~tla2k21@gateway/tor-sasl/tla2k21> has quit IRC (Remote host closed the connection)
  2 2021-10-26T00:33:24  *** tla2k21 <tla2k21!~tla2k21@gateway/tor-sasl/tla2k21> has joined #bitcoin-core-dev
  3 2021-10-26T00:56:43  *** davterra <davterra!~davterra@143.198.56.186> has quit IRC (Quit: Leaving)
  4 2021-10-26T02:02:15  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te5agy0cavumpf2.ipv6.telus.net> has quit IRC (Remote host closed the connection)
  5 2021-10-26T02:02:27  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te5agy0cavumpf2.ipv6.telus.net> has joined #bitcoin-core-dev
  6 2021-10-26T02:30:42  *** jespada <jespada!~jespada@181.28.253.200> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
  7 2021-10-26T02:36:30  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 276 seconds)
  8 2021-10-26T02:36:57  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
  9 2021-10-26T02:41:19  *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 244 seconds)
 10 2021-10-26T02:53:35  *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
 11 2021-10-26T03:26:22  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te5agy0cavumpf2.ipv6.telus.net> has quit IRC (Remote host closed the connection)
 12 2021-10-26T03:26:59  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te5agy0cavumpf2.ipv6.telus.net> has joined #bitcoin-core-dev
 13 2021-10-26T03:33:26  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te5agy0cavumpf2.ipv6.telus.net> has quit IRC (Ping timeout: 245 seconds)
 14 2021-10-26T03:39:17  *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 15 2021-10-26T03:40:17  *** masta`` <masta``!~oyster@user/masta/x-2645138> has quit IRC (Read error: Connection reset by peer)
 16 2021-10-26T03:54:41  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te5agy0cavumpf2.ipv6.telus.net> has joined #bitcoin-core-dev
 17 2021-10-26T04:01:02  *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
 18 2021-10-26T04:01:08  *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
 19 2021-10-26T04:06:25  *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has quit IRC (Quit: aллилѹіа!)
 20 2021-10-26T04:09:02  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has joined #bitcoin-core-dev
 21 2021-10-26T04:23:49  *** lihuadong <lihuadong!~Guest91@222.128.5.76> has joined #bitcoin-core-dev
 22 2021-10-26T04:49:11  *** mikehu44_ <mikehu44_!~quassel@206.189.41.250> has joined #bitcoin-core-dev
 23 2021-10-26T04:54:59  *** mikehu44_ <mikehu44_!~quassel@206.189.41.250> has quit IRC (Ping timeout: 264 seconds)
 24 2021-10-26T04:55:18  *** mikehu44_ <mikehu44_!~quassel@206.189.41.250> has joined #bitcoin-core-dev
 25 2021-10-26T04:59:08  *** jesseposner <jesseposner!~jesse@c-24-5-105-39.hsd1.ca.comcast.net> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
 26 2021-10-26T05:12:24  *** jesseposner <jesseposner!~jesse@c-24-5-105-39.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
 27 2021-10-26T05:22:38  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 28 2021-10-26T05:36:47  *** infernix <infernix!nix@2a02:22a0:bbb1:d500::2> has quit IRC (Ping timeout: 246 seconds)
 29 2021-10-26T05:41:43  *** Cory <Cory!~Cory@user/pasha> has quit IRC (Ping timeout: 252 seconds)
 30 2021-10-26T05:59:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 31 2021-10-26T05:59:54  <bitcoin-git> [gui] jarolrod closed pull request #310: Introduce Icon Policy Documentation (master...icon_policy_doc) https://github.com/bitcoin-core/gui/pull/310
 32 2021-10-26T05:59:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 33 2021-10-26T06:08:59  *** infernix <infernix!nix@spirit.infernix.net> has joined #bitcoin-core-dev
 34 2021-10-26T06:23:44  *** goatpig <goatpig!~goat@static-193-13-33-110.cust.tele2.se> has joined #bitcoin-core-dev
 35 2021-10-26T07:14:25  *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has joined #bitcoin-core-dev
 36 2021-10-26T07:29:39  *** tla2k21 <tla2k21!~tla2k21@gateway/tor-sasl/tla2k21> has quit IRC (Ping timeout: 276 seconds)
 37 2021-10-26T07:29:44  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
 38 2021-10-26T07:37:37  *** tla2k21 <tla2k21!~tla2k21@gateway/tor-sasl/tla2k21> has joined #bitcoin-core-dev
 39 2021-10-26T07:43:23  *** lihuadong <lihuadong!~Guest91@222.128.5.76> has quit IRC (Quit: Client closed)
 40 2021-10-26T08:18:08  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Remote host closed the connection)
 41 2021-10-26T09:00:10  *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
 42 2021-10-26T09:15:42  *** pigeons <pigeons!~pigeons@androzani.sysevolve.com> has quit IRC (Ping timeout: 265 seconds)
 43 2021-10-26T09:45:58  *** synaps3 <synaps3!~void@178-221-103-129.dynamic.isp.telekom.rs> has joined #bitcoin-core-dev
 44 2021-10-26T09:55:19  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
 45 2021-10-26T09:56:21  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
 46 2021-10-26T09:58:01  *** goatpig <goatpig!~goat@static-193-13-33-110.cust.tele2.se> has quit IRC (Ping timeout: 245 seconds)
 47 2021-10-26T10:08:57  *** Henrik_ <Henrik_!~textual@84.212.107.177> has joined #bitcoin-core-dev
 48 2021-10-26T10:16:09  *** goatpig <goatpig!~goat@static-193-13-33-110.cust.tele2.se> has joined #bitcoin-core-dev
 49 2021-10-26T10:39:38  *** jespada <jespada!~jespada@181.28.253.200> has joined #bitcoin-core-dev
 50 2021-10-26T10:42:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 51 2021-10-26T10:42:35  <bitcoin-git> [bitcoin] hebasto opened pull request #23360: Revert "build: fix ASLR for bitcoin-cli on Windows" (master...211026-win-aslr) https://github.com/bitcoin/bitcoin/pull/23360
 52 2021-10-26T10:42:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 53 2021-10-26T10:42:43  *** synaps3 <synaps3!~void@178-221-103-129.dynamic.isp.telekom.rs> has quit IRC (Quit: Leaving)
 54 2021-10-26T10:53:08  *** belcher <belcher!~belcher@user/belcher> has quit IRC (Quit: Leaving)
 55 2021-10-26T10:57:51  *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 56 2021-10-26T11:09:59  *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
 57 2021-10-26T11:27:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 58 2021-10-26T11:27:38  <bitcoin-git> [bitcoin] hebasto opened pull request #23362: util: Add "importfromcoldcard" command to bitcoin-wallet tool (master...211025-cc) https://github.com/bitcoin/bitcoin/pull/23362
 59 2021-10-26T11:27:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 60 2021-10-26T11:28:03  *** Henrik_ <Henrik_!~textual@84.212.107.177> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
 61 2021-10-26T11:40:41  *** masta`` <masta``!~oyster@user/masta/x-2645138> has joined #bitcoin-core-dev
 62 2021-10-26T11:40:44  *** masta_ <masta_!~oyster@user/masta/x-2645138> has joined #bitcoin-core-dev
 63 2021-10-26T11:49:20  *** masta_ <masta_!~oyster@user/masta/x-2645138> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
 64 2021-10-26T12:10:27  *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has joined #bitcoin-core-dev
 65 2021-10-26T12:14:55  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
 66 2021-10-26T12:15:24  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 67 2021-10-26T12:28:16  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te5agy0cavumpf2.ipv6.telus.net> has quit IRC (Remote host closed the connection)
 68 2021-10-26T12:28:28  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te5agy0cavumpf2.ipv6.telus.net> has joined #bitcoin-core-dev
 69 2021-10-26T12:46:11  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
 70 2021-10-26T12:46:47  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 71 2021-10-26T12:49:22  <MarcoFalke> jnewbery: Done, updated comment
 72 2021-10-26T12:51:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 73 2021-10-26T12:51:42  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/22a90186496a...af4275e8dbde
 74 2021-10-26T12:51:42  <bitcoin-git> bitcoin/master fa8fef6 MarcoFalke: doc: Fix CWalletTx::Confirmation doc
 75 2021-10-26T12:51:42  <bitcoin-git> bitcoin/master af4275e MarcoFalke: Merge bitcoin/bitcoin#23332: doc: Fix CWalletTx::Confirmation doc
 76 2021-10-26T12:51:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 77 2021-10-26T13:09:59  *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has quit IRC (Ping timeout: 265 seconds)
 78 2021-10-26T13:15:09  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a443:99fa:7edf:26be> has joined #bitcoin-core-dev
 79 2021-10-26T13:23:52  <jnewbery> MarcoFalke. Thank you!
 80 2021-10-26T13:31:46  *** goatpig <goatpig!~goat@static-193-13-33-110.cust.tele2.se> has quit IRC (Remote host closed the connection)
 81 2021-10-26T13:43:38  *** Ottman <Ottman!~Ottman@ool-944baa5e.dyn.optonline.net> has joined #bitcoin-core-dev
 82 2021-10-26T13:55:30  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
 83 2021-10-26T14:01:01  *** jespada <jespada!~jespada@181.28.253.200> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 84 2021-10-26T14:06:06  *** smartin <smartin!~Icedove@88.135.18.171> has joined #bitcoin-core-dev
 85 2021-10-26T14:11:55  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
 86 2021-10-26T14:12:31  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 87 2021-10-26T14:21:20  *** Ottman <Ottman!~Ottman@ool-944baa5e.dyn.optonline.net> has quit IRC (Quit: Client closed)
 88 2021-10-26T14:22:31  *** SpellChecker <SpellChecker!~SpellChec@gateway/tor-sasl/spellchecker> has quit IRC (Remote host closed the connection)
 89 2021-10-26T14:22:49  *** SpellChecker <SpellChecker!~SpellChec@gateway/tor-sasl/spellchecker> has joined #bitcoin-core-dev
 90 2021-10-26T14:27:31  *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has joined #bitcoin-core-dev
 91 2021-10-26T14:28:16  *** RDK <RDK!~RDK@p200300db671acc931746b1c4d3238ccc.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
 92 2021-10-26T14:41:54  *** roconnor <roconnor!~roconnor@host-45-58-217-8.dyn.295.ca> has joined #bitcoin-core-dev
 93 2021-10-26T14:43:34  *** white5moke <white5moke!~white5mok@ip72-219-109-30.oc.oc.cox.net> has joined #bitcoin-core-dev
 94 2021-10-26T14:47:31  *** ishaqm <ishaqm!~IshaqM@128.210.107.81> has joined #bitcoin-core-dev
 95 2021-10-26T14:48:26  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a443:99fa:7edf:26be> has quit IRC (Quit: Client closed)
 96 2021-10-26T14:56:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 97 2021-10-26T14:56:41  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/af4275e8dbde...e77d9679fd0c
 98 2021-10-26T14:56:41  <bitcoin-git> bitcoin/master d5f985e Russell Yanofsky: multiprocess: Add new bitcoin-gui, bitcoin-qt, bitcoin-wallet init impleme...
 99 2021-10-26T14:56:41  <bitcoin-git> bitcoin/master e77d967 MarcoFalke: Merge bitcoin/bitcoin#23006: multiprocess: Add new bitcoin-gui, bitcoin-qt...
100 2021-10-26T14:56:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
101 2021-10-26T14:56:51  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 276 seconds)
102 2021-10-26T14:56:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
103 2021-10-26T14:56:58  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23006: multiprocess: Add new bitcoin-gui, bitcoin-qt, bitcoin-wallet init implementations (master...pr/ipc-init) https://github.com/bitcoin/bitcoin/pull/23006
104 2021-10-26T14:56:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
105 2021-10-26T15:01:39  *** davterra <davterra!~davterra@143.198.56.186> has joined #bitcoin-core-dev
106 2021-10-26T15:02:11  *** mikehu44_ <mikehu44_!~quassel@206.189.41.250> has quit IRC (Ping timeout: 264 seconds)
107 2021-10-26T15:06:36  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
108 2021-10-26T15:07:07  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
109 2021-10-26T15:07:31  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has quit IRC (Ping timeout: 260 seconds)
110 2021-10-26T15:52:24  *** b10c <b10c!uid500648@id-500648.ilkley.irccloud.com> has joined #bitcoin-core-dev
111 2021-10-26T16:08:12  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a443:99fa:7edf:26be> has joined #bitcoin-core-dev
112 2021-10-26T16:14:22  *** Guest73 <Guest73!~Guest73@185.146.71.230> has joined #bitcoin-core-dev
113 2021-10-26T16:16:46  *** gene <gene!~gene@gateway/tor-sasl/gene> has joined #bitcoin-core-dev
114 2021-10-26T16:37:11  *** Guest73 <Guest73!~Guest73@185.146.71.230> has quit IRC (Ping timeout: 256 seconds)
115 2021-10-26T16:38:46  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
116 2021-10-26T16:39:20  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Client Quit)
117 2021-10-26T16:40:45  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
118 2021-10-26T16:49:17  *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has joined #bitcoin-core-dev
119 2021-10-26T16:52:23  *** dviola <dviola!~diego@user/dviola> has quit IRC (Quit: WeeChat 3.3)
120 2021-10-26T16:54:59  *** dviola <dviola!~diego@user/dviola> has joined #bitcoin-core-dev
121 2021-10-26T16:58:25  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
122 2021-10-26T17:06:46  *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has joined #bitcoin-core-dev
123 2021-10-26T17:25:23  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-9d27-c755-80ea-123e.res6.spectrum.com> has joined #bitcoin-core-dev
124 2021-10-26T17:26:43  *** dviola <dviola!~diego@user/dviola> has quit IRC (Quit: WeeChat 3.3)
125 2021-10-26T17:39:47  *** bairen <bairen!~bairen@gateway/tor-sasl/bairen> has joined #bitcoin-core-dev
126 2021-10-26T17:49:15  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
127 2021-10-26T18:14:57  *** meshcollider <meshcollider!meshcollid@user/meshcollider> has quit IRC (Remote host closed the connection)
128 2021-10-26T18:14:57  *** paulo <paulo!paulo@user/paulo/x-9032687> has quit IRC (Remote host closed the connection)
129 2021-10-26T18:15:16  *** RDK <RDK!~RDK@p200300db671acc931746b1c4d3238ccc.dip0.t-ipconnect.de> has quit IRC (Quit: Leaving)
130 2021-10-26T18:35:29  *** meshcollider <meshcollider!meshcollid@jujube.ircnow.org> has joined #bitcoin-core-dev
131 2021-10-26T18:37:33  *** paulo <paulo!paulo@user/paulo/x-9032687> has joined #bitcoin-core-dev
132 2021-10-26T18:41:07  *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has left #bitcoin-core-dev (Closing Window)
133 2021-10-26T18:41:30  *** jespada <jespada!~jespada@181.28.253.200> has joined #bitcoin-core-dev
134 2021-10-26T18:43:48  *** jespada <jespada!~jespada@181.28.253.200> has quit IRC (Client Quit)
135 2021-10-26T18:45:27  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a443:99fa:7edf:26be> has quit IRC (Quit: Client closed)
136 2021-10-26T18:46:04  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a443:99fa:7edf:26be> has joined #bitcoin-core-dev
137 2021-10-26T18:49:35  *** jespada <jespada!~jespada@181.28.253.200> has joined #bitcoin-core-dev
138 2021-10-26T19:13:28  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
139 2021-10-26T19:13:28  <bitcoin-git> [bitcoin] dougEfresh closed pull request #23344: ci: Reuse pre-built docker builder image for rapid local CI iteration testing (master...ci_reuse_container) https://github.com/bitcoin/bitcoin/pull/23344
140 2021-10-26T19:13:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
141 2021-10-26T19:13:45  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
142 2021-10-26T19:22:11  <theStack> taproot question: i'm just trying to convert a simple P2WSH script (OP_TRUE, i.e. any-one-can-spend) to P2TR. what would one choose as internal key in this case, if key-path spending is not used? i guess it doesn't matter that much, as long as it's a valid x-only-pubkey?
143 2021-10-26T19:24:29  <sipa> theStack: BIP341 has recommendations
144 2021-10-26T19:28:40  <theStack> sipa: thanks, will take a look
145 2021-10-26T19:34:58  *** white5moke <white5moke!~white5mok@ip72-219-109-30.oc.oc.cox.net> has quit IRC (Quit: Leaving...)
146 2021-10-26T19:45:48  *** bairen <bairen!~bairen@gateway/tor-sasl/bairen> has quit IRC (Remote host closed the connection)
147 2021-10-26T19:46:26  *** bairen <bairen!~bairen@gateway/tor-sasl/bairen> has joined #bitcoin-core-dev
148 2021-10-26T19:48:27  *** smartin <smartin!~Icedove@88.135.18.171> has quit IRC (Quit: smartin)
149 2021-10-26T19:52:20  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a443:99fa:7edf:26be> has quit IRC (Quit: Client closed)
150 2021-10-26T20:04:43  *** lukedashjr <lukedashjr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
151 2021-10-26T20:04:48  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Ping timeout: 260 seconds)
152 2021-10-26T20:07:54  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 260 seconds)
153 2021-10-26T20:08:09  *** lukedashjr is now known as luke-jr
154 2021-10-26T20:12:11  *** b10c <b10c!uid500648@id-500648.ilkley.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
155 2021-10-26T20:25:37  *** lukedashjr <lukedashjr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
156 2021-10-26T20:26:06  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 260 seconds)
157 2021-10-26T20:27:21  *** lukedashjr is now known as luke-jr
158 2021-10-26T20:52:34  *** ishi <ishi!~ishi@49.207.220.27> has joined #bitcoin-core-dev
159 2021-10-26T20:55:55  *** lukedashjr <lukedashjr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
160 2021-10-26T20:57:03  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 260 seconds)
161 2021-10-26T20:57:39  *** lukedashjr is now known as luke-jr
162 2021-10-26T21:02:39  *** ishaqm <ishaqm!~IshaqM@128.210.107.81> has quit IRC (Remote host closed the connection)
163 2021-10-26T21:10:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
164 2021-10-26T21:11:00  <bitcoin-git> [bitcoin] denis2342 opened pull request #23364: Add a test and optimize HexStr() by 27% (master...master) https://github.com/bitcoin/bitcoin/pull/23364
165 2021-10-26T21:11:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
166 2021-10-26T21:11:54  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 276 seconds)
167 2021-10-26T21:13:24  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
168 2021-10-26T21:13:31  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Client Quit)
169 2021-10-26T21:13:45  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
170 2021-10-26T21:19:32  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a443:99fa:7edf:26be> has joined #bitcoin-core-dev
171 2021-10-26T21:29:00  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a443:99fa:7edf:26be> has quit IRC (Quit: Client closed)
172 2021-10-26T21:36:43  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 260 seconds)
173 2021-10-26T21:37:04  *** lukedashjr <lukedashjr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
174 2021-10-26T21:38:49  *** lukedashjr is now known as luke-jr
175 2021-10-26T21:53:52  *** Kaizen_K_ <Kaizen_K_!~Kaizen_Ki@d198-53-43-219.abhsia.telus.net> has joined #bitcoin-core-dev
176 2021-10-26T21:56:15  *** Kaizen___ <Kaizen___!~Kaizen_Ki@node-1w7jr9yi65te7aswxjyf8efmc.ipv6.telus.net> has joined #bitcoin-core-dev
177 2021-10-26T21:57:23  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te5agy0cavumpf2.ipv6.telus.net> has quit IRC (Ping timeout: 264 seconds)
178 2021-10-26T21:59:07  *** Kaizen_K_ <Kaizen_K_!~Kaizen_Ki@d198-53-43-219.abhsia.telus.net> has quit IRC (Ping timeout: 260 seconds)
179 2021-10-26T22:05:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
180 2021-10-26T22:05:38  <bitcoin-git> [bitcoin] mzumsande opened pull request #23365: index: Fix backwards search for bestblock (master...202110_index_backtrack) https://github.com/bitcoin/bitcoin/pull/23365
181 2021-10-26T22:05:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
182 2021-10-26T22:06:48  *** jespada <jespada!~jespada@181.28.253.200> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
183 2021-10-26T22:07:50  <_aj_> sipa: conditional code with ranges or a fallback? i was just meaning once we switched everything to c++20 in a few years, that's a cool thing we could use. if we were really excited, we could also include the ranges library backported to c++17, but meh. conditional code seems nuts?
184 2021-10-26T22:08:36  <_aj_> sipa: once we switched to c++20 as the minimum standard, i mean
185 2021-10-26T22:11:56  <sipa> _aj_: oh sure, once we switch to depending on c++20, using ranges goes from nuts to go nuts
186 2021-10-26T22:12:20  <sipa> but that seems like a discussion for a reasonably far future that we don't need to care
187 2021-10-26T22:16:57  <_aj_> sipa: yeah, that's how i took that entire issue. ah, i guess i see how you went from my "can't rely" to "just make it conditional then", my bad
188 2021-10-26T22:20:32  <sipa> but say, something that lets us switch to a safer (stricter types e.g.) interface for Span in C++20, would perhaps be worth it
189 2021-10-26T22:20:36  <sipa> even conditionally
190 2021-10-26T22:21:30  <sipa> even if that adds conditional code, it may help catch bugs in caller code that's not C++20 specific
191 2021-10-26T22:21:51  <_aj_> as long as it's not conditional at every call site, sure
192 2021-10-26T22:22:32  <sipa> actually, we can probably modernize Span using some C++17 features already
193 2021-10-26T22:23:05  <sipa> ah, no, it needs C++20
194 2021-10-26T22:23:06  <sipa>     /** Construct a span from a begin and end pointer.
195 2021-10-26T22:23:06  <sipa>      *
196 2021-10-26T22:23:06  <sipa>      * This implements a subset of the iterator-based std::span constructor in C++20,
197 2021-10-26T22:23:09  <sipa>      * which is hard to implement without std::address_of.
198 2021-10-26T22:23:14  <_aj_> you've seen #23226 ?
199 2021-10-26T22:23:15  <gribble> https://github.com/bitcoin/bitcoin/issues/23226 | c++20: Opt-in to modeling view and borrowed_range for Span by theuni · Pull Request #23226 · bitcoin/bitcoin · GitHub
200 2021-10-26T22:23:35  <sipa> yes, but that's for the range interface, which _would_ require conditional code on the caller side
201 2021-10-26T22:23:48  <sipa> right?
202 2021-10-26T22:25:51  <_aj_> maybe? i've been trying to avoid learning anything about c++20 so i don't feel sad that i can't use the features for years
203 2021-10-26T22:25:52  <cfields> 23226 turns some range compilation failures into valid code. But it only has any meaning when the caller is c++20.
204 2021-10-26T22:26:20  <sipa> i'm wrong about the code i quoted too
205 2021-10-26T22:26:39  <sipa> the currently supported interface is a strict subset of what is allowed by the C++20 std::span constructor
206 2021-10-26T22:26:55  <sipa> so enabling it in C++20 mode doesn't add anything for non-C++20 callers
207 2021-10-26T22:28:03  *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has quit IRC (Ping timeout: 260 seconds)
208 2021-10-26T22:28:50  <cfields> for that PR, correct. It's only useful for playing with c++20.
209 2021-10-26T22:29:41  <cfields> I guess you two are discussing conditionally adding the c++20 ctors and other functionality if in c++20 mode?
210 2021-10-26T22:30:03  *** Guest80 <Guest80!~Guest80@199.167.159.17> has joined #bitcoin-core-dev
211 2021-10-26T22:30:31  *** Guest80 <Guest80!~Guest80@199.167.159.17> has quit IRC (Client Quit)
212 2021-10-26T22:30:34  <sipa> i think that was mostly a tangent i got on, thinking it would be an actual benefit to non-C++20-code, to add the full iterators-based Span constructor in C++20 mode
213 2021-10-26T22:30:39  <sipa> but i was wrong
214 2021-10-26T22:31:05  <sipa> adding concepts-based checks could be useful though
215 2021-10-26T22:31:15  <sipa> in that it may give nicer compiler error messages
216 2021-10-26T22:34:43  <_aj_> you'd only get nicer compiler error messages if you did your dev with c++20 enabled, which would then not give you errors at all when you use non-c++17 features?
217 2021-10-26T22:35:13  <sipa> in theory, possibly
218 2021-10-26T22:35:33  <sipa> but in practice, almost certainly yes, only an inscrutible wall of errors
219 2021-10-26T22:36:44  <_aj_> well, it's still c++? :)
220 2021-10-26T22:38:16  <sipa> if you're not familiar with concepts: e.g. you're instantiating an std::map with a type that doesn't have an operator<
221 2021-10-26T22:38:54  <sipa> due to SFINAE, you don't get an error when instantiating the type, but in the call site where that actually is a problem (e.g. insertion), and then really the compiler error is just "i tried all of these things to make it work, but none work"
222 2021-10-26T22:39:25  <sipa> with concepts, the type itself can get a compile-time constraint on properties its template parameters must have
223 2021-10-26T22:57:59  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
224 2021-10-26T23:02:38  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-9d27-c755-80ea-123e.res6.spectrum.com> has quit IRC (Quit: jarthur)
225 2021-10-26T23:30:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
226 2021-10-26T23:30:08  <bitcoin-git> [bitcoin] denis2342 closed pull request #23364: Add a test and optimize HexStr() by 27% (master...master) https://github.com/bitcoin/bitcoin/pull/23364
227 2021-10-26T23:30:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
228 2021-10-26T23:30:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
229 2021-10-26T23:30:49  <bitcoin-git> [bitcoin] denis2342 reopened pull request #23364: Add a test and optimize HexStr() by 27% (master...master) https://github.com/bitcoin/bitcoin/pull/23364
230 2021-10-26T23:30:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
231 2021-10-26T23:33:51  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 245 seconds)
232 2021-10-26T23:54:30  *** Kaizen___ <Kaizen___!~Kaizen_Ki@node-1w7jr9yi65te7aswxjyf8efmc.ipv6.telus.net> has quit IRC (Remote host closed the connection)
233 2021-10-26T23:54:58  *** Kaizen_Kintsugi <Kaizen_Kintsugi!~Kaizen_Ki@node-1w7jr9yi65te7aswxjyf8efmc.ipv6.telus.net> has joined #bitcoin-core-dev