1 2021-12-16T00:00:03 *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has quit IRC (*.net *.split)
2 2021-12-16T00:00:03 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (*.net *.split)
3 2021-12-16T00:00:03 *** b10c <b10c!uid500648@id-500648.ilkley.irccloud.com> has quit IRC (*.net *.split)
4 2021-12-16T00:00:03 *** dermoth <dermoth!~dermoth@user/dermoth> has quit IRC (*.net *.split)
5 2021-12-16T00:00:03 *** jespada <jespada!~jespada@87.74.33.157> has quit IRC (*.net *.split)
6 2021-12-16T00:00:03 *** jamesob <jamesob!~jamesob@pool-108-31-54-223.washdc.fios.verizon.net> has quit IRC (*.net *.split)
7 2021-12-16T00:00:03 *** x88x88x <x88x88x!~x88x88x@2001:19f0:5:39a8:5400:3ff:feb6:73cb> has quit IRC (*.net *.split)
8 2021-12-16T00:00:03 *** infernix <infernix!nix@2a02:22a0:bbb1:d500::2> has quit IRC (*.net *.split)
9 2021-12-16T00:00:03 *** dongcarl <dongcarl!~dongcarl@70.107.207.192> has quit IRC (*.net *.split)
10 2021-12-16T00:00:03 *** stickies-v <stickies-v!~stickies-@81.178.227.161> has quit IRC (*.net *.split)
11 2021-12-16T00:00:03 *** BUSY <BUSY!~BUSY@user/busy> has quit IRC (*.net *.split)
12 2021-12-16T00:00:03 *** baldur <baldur!~baldur@71.183.150.231> has quit IRC (*.net *.split)
13 2021-12-16T00:00:03 *** Victorsueca <Victorsueca!~Victorsue@user/victorsueca> has quit IRC (*.net *.split)
14 2021-12-16T00:00:04 *** Jackielove4u <Jackielove4u!uid43977@user/jackielove4u> has quit IRC (*.net *.split)
15 2021-12-16T00:00:04 *** hendi <hendi!sid489601@id-489601.lymington.irccloud.com> has quit IRC (*.net *.split)
16 2021-12-16T00:00:04 *** ogola <ogola!~ogola@dolos.media.mit.edu> has quit IRC (*.net *.split)
17 2021-12-16T00:00:04 *** uasf <uasf!~uasf@2604:a880:2:d0::1bda:1001> has quit IRC (*.net *.split)
18 2021-12-16T00:00:04 *** koolazer <koolazer!~koo@user/koolazer> has quit IRC (*.net *.split)
19 2021-12-16T00:00:04 *** TallTim <TallTim!~talltim@184-83-239-155-dynamic.midco.net> has quit IRC (*.net *.split)
20 2021-12-16T00:00:04 *** raj_ <raj_!~raj@167.182.81.172.lunanode-rdns.com> has quit IRC (*.net *.split)
21 2021-12-16T00:00:04 *** willcl_ark <willcl_ark!~quassel@user/willcl-ark/x-8282106> has quit IRC (*.net *.split)
22 2021-12-16T00:00:04 *** gnusha <gnusha!~gnusha@user/gnusha> has quit IRC (*.net *.split)
23 2021-12-16T00:00:04 *** gleb74 <gleb74!~gleb@178.150.137.228> has quit IRC (*.net *.split)
24 2021-12-16T00:00:05 *** Alina-malina <Alina-malina!~Alina-mal@user/alina-malina> has quit IRC (*.net *.split)
25 2021-12-16T00:00:05 *** M0xb10c[m] <M0xb10c[m]!~M0xb10cni@2001:470:69fc:105::bac4> has quit IRC (*.net *.split)
26 2021-12-16T00:00:05 *** RCasatta[m] <RCasatta[m]!~rcasattam@2001:470:69fc:105::c85> has quit IRC (*.net *.split)
27 2021-12-16T00:00:05 *** TheRec <TheRec!~toto@user/therec> has quit IRC (*.net *.split)
28 2021-12-16T00:00:05 *** berndj <berndj!~berndj@ns1.linksynergy.co.za> has quit IRC (*.net *.split)
29 2021-12-16T00:00:05 *** jrawsthorne <jrawsthorne!~jrawsthor@static.235.41.217.95.clients.your-server.de> has quit IRC (*.net *.split)
30 2021-12-16T00:00:05 *** emcy <emcy!~emcy@user/emcy> has quit IRC (*.net *.split)
31 2021-12-16T00:00:05 *** EPiSKiNG- <EPiSKiNG-!~EPiSKiNG-@episking.com> has quit IRC (*.net *.split)
32 2021-12-16T00:00:05 *** achow101 <achow101!~achow101@user/achow101> has quit IRC (*.net *.split)
33 2021-12-16T00:00:05 *** jarolrod <jarolrod!sid475272@id-475272.uxbridge.irccloud.com> has quit IRC (*.net *.split)
34 2021-12-16T00:00:05 *** S3RK <S3RK!~S3RK@user/s3rk> has quit IRC (*.net *.split)
35 2021-12-16T00:00:18 *** stickies-v <stickies-v!~stickies-@81.178.227.161> has joined #bitcoin-core-dev
36 2021-12-16T00:00:22 *** gleb74 <gleb74!~gleb@178.150.137.228> has joined #bitcoin-core-dev
37 2021-12-16T00:00:26 *** TallTim <TallTim!~talltim@184-83-239-155-dynamic.midco.net> has joined #bitcoin-core-dev
38 2021-12-16T00:00:39 *** emcy <emcy!~emcy@205.85.7.51.dyn.plus.net> has joined #bitcoin-core-dev
39 2021-12-16T00:00:42 *** jarolrod <jarolrod!sid475272@2a03:5180:f:5::7:4088> has joined #bitcoin-core-dev
40 2021-12-16T00:00:43 *** raj <raj!~raj@2602:ffb6:4:e396:f816:3eff:fe47:ca2a> has joined #bitcoin-core-dev
41 2021-12-16T00:00:47 *** b10c <b10c!uid500648@ilkley.irccloud.com> has joined #bitcoin-core-dev
42 2021-12-16T00:00:48 *** jrawsthorne <jrawsthorne!~jrawsthor@static.235.41.217.95.clients.your-server.de> has joined #bitcoin-core-dev
43 2021-12-16T00:00:50 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
44 2021-12-16T00:00:54 *** achow101 <achow101!~achow101@user/achow101> has joined #bitcoin-core-dev
45 2021-12-16T00:00:54 *** ogola <ogola!~ogola@dolos.media.mit.edu> has joined #bitcoin-core-dev
46 2021-12-16T00:00:55 *** Jackielove4u <Jackielove4u!uid43977@user/jackielove4u> has joined #bitcoin-core-dev
47 2021-12-16T00:00:57 *** emcy <emcy!~emcy@205.85.7.51.dyn.plus.net> has quit IRC (Remote host closed the connection)
48 2021-12-16T00:00:57 *** hendi <hendi!sid489601@2a03:5180:f:2::7:7881> has joined #bitcoin-core-dev
49 2021-12-16T00:01:16 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 268 seconds)
50 2021-12-16T00:03:27 *** uasf <uasf!~uasf@2604:a880:2:d0::1bda:1001> has joined #bitcoin-core-dev
51 2021-12-16T00:04:04 *** berndj <berndj!~berndj@ns2.linksynergy.co.za> has joined #bitcoin-core-dev
52 2021-12-16T00:04:39 *** x88x88x <x88x88x!~x88x88x@2001:19f0:5:39a8:5400:3ff:feb6:73cb> has joined #bitcoin-core-dev
53 2021-12-16T00:04:43 *** willcl_ark <willcl_ark!~quassel@user/willcl-ark/x-8282106> has joined #bitcoin-core-dev
54 2021-12-16T00:05:01 *** Alina-malina <Alina-malina!~Alina-mal@user/alina-malina> has joined #bitcoin-core-dev
55 2021-12-16T00:05:14 *** gnusha <gnusha!~gnusha@user/gnusha> has joined #bitcoin-core-dev
56 2021-12-16T00:05:15 *** S3RK <S3RK!~S3RK@user/s3rk> has joined #bitcoin-core-dev
57 2021-12-16T00:05:30 *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has joined #bitcoin-core-dev
58 2021-12-16T00:05:36 *** koolazer <koolazer!~koo@user/koolazer> has joined #bitcoin-core-dev
59 2021-12-16T00:06:21 *** jespada <jespada!~jespada@87.74.33.157> has joined #bitcoin-core-dev
60 2021-12-16T00:07:16 *** emcy <emcy!~emcy@user/emcy> has joined #bitcoin-core-dev
61 2021-12-16T00:07:26 *** M0xb10c[m] <M0xb10c[m]!~M0xb10cni@2001:470:69fc:105::bac4> has joined #bitcoin-core-dev
62 2021-12-16T00:07:29 *** RCasatta[m] <RCasatta[m]!~rcasattam@2001:470:69fc:105::c85> has joined #bitcoin-core-dev
63 2021-12-16T00:08:27 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
64 2021-12-16T00:10:24 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
65 2021-12-16T00:12:57 *** Victorsueca <Victorsueca!~Victorsue@user/victorsueca> has joined #bitcoin-core-dev
66 2021-12-16T00:14:10 *** infernix <infernix!~nix@155.137.21.90> has joined #bitcoin-core-dev
67 2021-12-16T00:14:24 *** emcy <emcy!~emcy@user/emcy> has quit IRC (Quit: Leaving)
68 2021-12-16T00:14:59 *** emcy <emcy!~emcy@user/emcy> has joined #bitcoin-core-dev
69 2021-12-16T00:26:33 *** EPiSKiNG- <EPiSKiNG-!~EPiSKiNG-@episking.com> has joined #bitcoin-core-dev
70 2021-12-16T00:33:23 *** jb55 <jb55!~jb55@S010660e327dca171.vc.shawcable.net> has quit IRC (Ping timeout: 256 seconds)
71 2021-12-16T00:34:39 *** roconnor <roconnor!~roconnor@coq/roconnor> has joined #bitcoin-core-dev
72 2021-12-16T00:49:29 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
73 2021-12-16T00:52:39 *** BUSY <BUSY!~BUSY@user/busy> has joined #bitcoin-core-dev
74 2021-12-16T00:55:21 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 276 seconds)
75 2021-12-16T01:02:19 <jeremyrubin> well it's always kind of a negotiation of if the nits need to be addressed here or later. part of the joy of having a guideline on how to handle is that there's a default answer.
76 2021-12-16T01:02:58 <jeremyrubin> I think we may even get better quality code, because right now i don't nit things i don't want to bother the author to fix given the costs of re-review
77 2021-12-16T01:04:44 <sipa> occasionally i don't bother leaving nits on the PRs directly, but make a follow-up PR myself after it's merged.
78 2021-12-16T01:10:44 <jeremyrubin> i think that's reasonable -- no nits, but just fix it yourself as a follow up. they who nit-it fix-it?
79 2021-12-16T01:21:17 <luke-jr> I planned to do that with NAT-PMP but never got around to it :x
80 2021-12-16T01:21:45 *** ozawa <ozawa!~ozawa@cpe-98-14-66-91.nyc.res.rr.com> has quit IRC (Quit: Connection closed)
81 2021-12-16T01:22:55 *** b10c <b10c!uid500648@ilkley.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
82 2021-12-16T01:47:12 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
83 2021-12-16T01:52:33 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 276 seconds)
84 2021-12-16T02:03:01 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Read error: Connection reset by peer)
85 2021-12-16T02:04:52 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
86 2021-12-16T02:09:17 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
87 2021-12-16T02:09:27 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
88 2021-12-16T02:12:51 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 250 seconds)
89 2021-12-16T02:13:19 *** ozawa <ozawa!~ozawa@cpe-98-14-66-91.nyc.res.rr.com> has joined #bitcoin-core-dev
90 2021-12-16T02:21:53 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Read error: Connection reset by peer)
91 2021-12-16T02:21:53 *** zonemix_ <zonemix_!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
92 2021-12-16T02:30:15 <ariard> laanwj: yeah sad with the premature merge of 22674, commit e12fafd was added on the last push and not previously reviewed, you have a good chunk of context with implications for the rest of package relay support imho :(
93 2021-12-16T02:30:30 <ariard> nice if past reviewers can re-look on that
94 2021-12-16T02:39:57 <laanwj> okay, sorry
95 2021-12-16T02:41:21 <laanwj> yes i screwed up well it's the last PR i'll merge for a while
96 2021-12-16T02:45:22 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
97 2021-12-16T02:48:35 <laanwj> and reverting e12fafd would make sense then (better to do it as a new PR)
98 2021-12-16T02:53:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
99 2021-12-16T02:53:01 <bitcoin-git> [bitcoin] laanwj opened pull request #23793: validation: Revert "de-duplicate package transactions already in mempool" (master...2021-12-revert-package-dedup) https://github.com/bitcoin/bitcoin/pull/23793
100 2021-12-16T02:53:02 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
101 2021-12-16T02:58:15 <laanwj> there
102 2021-12-16T03:00:29 *** earnestly <earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 250 seconds)
103 2021-12-16T03:02:24 <laanwj> oh, it isn't possible to revert it by itself, revert the entire PR then?
104 2021-12-16T03:05:16 <laanwj> ok: it introduces MempoolAcceptResult::ResultType::MEMPOOL_ENTRY which is used in the commit after it, but that's only tests, could remove or comment out the test for now
105 2021-12-16T03:15:22 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
106 2021-12-16T03:18:14 <laanwj> done that
107 2021-12-16T03:24:39 *** zonemix_ <zonemix_!~zonemix@216.16.35.204> has quit IRC (Remote host closed the connection)
108 2021-12-16T03:25:12 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
109 2021-12-16T03:28:40 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
110 2021-12-16T03:35:54 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 276 seconds)
111 2021-12-16T03:49:25 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Remote host closed the connection)
112 2021-12-16T03:49:58 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
113 2021-12-16T04:15:51 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Remote host closed the connection)
114 2021-12-16T04:16:27 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
115 2021-12-16T04:17:34 *** tla2k21 <tla2k21!~tla2k21@gateway/tor-sasl/tla2k21> has quit IRC (Remote host closed the connection)
116 2021-12-16T04:22:17 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
117 2021-12-16T04:32:10 *** tla2k21 <tla2k21!~tla2k21@gateway/tor-sasl/tla2k21> has joined #bitcoin-core-dev
118 2021-12-16T04:44:01 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
119 2021-12-16T04:50:43 *** jarthur <jarthur!~jarthur@cpe-70-114-198-37.austin.res.rr.com> has joined #bitcoin-core-dev
120 2021-12-16T04:51:02 *** ozawa <ozawa!~ozawa@cpe-98-14-66-91.nyc.res.rr.com> has quit IRC (Quit: Connection closed)
121 2021-12-16T05:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
122 2021-12-16T05:01:09 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
123 2021-12-16T05:02:22 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
124 2021-12-16T05:08:12 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 276 seconds)
125 2021-12-16T05:10:43 *** mikehu44 <mikehu44!~quassel@206.189.41.250> has joined #bitcoin-core-dev
126 2021-12-16T05:31:11 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 268 seconds)
127 2021-12-16T05:36:29 *** mikehu44 <mikehu44!~quassel@206.189.41.250> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
128 2021-12-16T05:47:50 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 268 seconds)
129 2021-12-16T06:16:26 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
130 2021-12-16T06:22:37 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
131 2021-12-16T06:29:05 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
132 2021-12-16T06:30:37 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
133 2021-12-16T06:35:57 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 276 seconds)
134 2021-12-16T06:47:45 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
135 2021-12-16T06:49:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
136 2021-12-16T06:49:20 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fee16b15fa34...98c362a4d3d8
137 2021-12-16T06:49:20 <bitcoin-git> bitcoin/master 71115a5 seaona: test: include two more interruptions points
138 2021-12-16T06:49:20 <bitcoin-git> bitcoin/master 618f4d2 seaona: test: re-organized array according to order of logs and included 2 more in...
139 2021-12-16T06:49:20 <bitcoin-git> bitcoin/master 98c362a MarcoFalke: Merge bitcoin/bitcoin#23782: test: include two more interruptions points
140 2021-12-16T06:49:22 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
141 2021-12-16T06:49:36 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
142 2021-12-16T06:49:36 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23782: test: include two more interruptions points (master...2021-12-feature-init-test-interruptions) https://github.com/bitcoin/bitcoin/pull/23782
143 2021-12-16T06:49:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
144 2021-12-16T07:11:05 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
145 2021-12-16T07:11:30 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
146 2021-12-16T07:43:18 *** freesprung <freesprung!~freesprun@user/freesprung> has quit IRC (Ping timeout: 260 seconds)
147 2021-12-16T07:44:02 *** freesprung <freesprung!~freesprun@user/freesprung> has joined #bitcoin-core-dev
148 2021-12-16T07:45:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
149 2021-12-16T07:45:58 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/98c362a4d3d8...a30642926a5e
150 2021-12-16T07:45:58 <bitcoin-git> bitcoin/master 4807f73 w0xlt: refactor: Implement restorewallet() logic in the wallet section
151 2021-12-16T07:45:58 <bitcoin-git> bitcoin/master abbb7ec w0xlt: refactor: Move restorewallet() RPC logic to the wallet section
152 2021-12-16T07:45:58 <bitcoin-git> bitcoin/master 62fa61f w0xlt: refactor: remove the wallet folder if the restore fails
153 2021-12-16T07:46:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
154 2021-12-16T07:46:14 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
155 2021-12-16T07:46:14 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23721: wallet, refactor: Move restorewallet() logic to the wallet section (master...restore_wallet_gui) https://github.com/bitcoin/bitcoin/pull/23721
156 2021-12-16T07:46:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
157 2021-12-16T07:48:36 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
158 2021-12-16T07:48:36 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a30642926a5e...ce463cf45053
159 2021-12-16T07:48:36 <bitcoin-git> bitcoin/master 65efbba Antoine Poinsot: rpcwallet: mention labels are deactivated for ranged descriptors
160 2021-12-16T07:48:36 <bitcoin-git> bitcoin/master ce463cf MarcoFalke: Merge bitcoin/bitcoin#23750: rpcwallet: mention labels are disabled for ra...
161 2021-12-16T07:48:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
162 2021-12-16T07:48:51 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
163 2021-12-16T07:48:51 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23750: rpcwallet: mention labels are disabled for ranged descriptors (master...no_label_range_descriptors) https://github.com/bitcoin/bitcoin/pull/23750
164 2021-12-16T07:48:52 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
165 2021-12-16T07:51:43 *** gleb74 <gleb74!~gleb@178.150.137.228> has quit IRC (Quit: Ping timeout (120 seconds))
166 2021-12-16T07:52:05 *** gleb74 <gleb74!~gleb@178.150.137.228> has joined #bitcoin-core-dev
167 2021-12-16T07:57:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
168 2021-12-16T07:57:41 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ce463cf45053...df6e961c417b
169 2021-12-16T07:57:41 <bitcoin-git> bitcoin/master e4a8d56 Martin Zumsande: doc: add explanations for assert in index and magic numbers in test
170 2021-12-16T07:57:41 <bitcoin-git> bitcoin/master df6e961 MarcoFalke: Merge bitcoin/bitcoin#23777: doc: follow-ups from #23365 (index backwards ...
171 2021-12-16T07:57:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
172 2021-12-16T07:57:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
173 2021-12-16T07:57:58 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23777: doc: follow-ups from #23365 (index backwards search) (master...202112_index_followups) https://github.com/bitcoin/bitcoin/pull/23777
174 2021-12-16T07:58:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
175 2021-12-16T08:00:29 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 256 seconds)
176 2021-12-16T08:00:48 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
177 2021-12-16T08:06:18 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 276 seconds)
178 2021-12-16T08:15:17 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
179 2021-12-16T08:17:43 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
180 2021-12-16T08:37:30 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 276 seconds)
181 2021-12-16T08:41:45 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 268 seconds)
182 2021-12-16T08:43:02 *** jarthur <jarthur!~jarthur@cpe-70-114-198-37.austin.res.rr.com> has quit IRC (Quit: jarthur)
183 2021-12-16T08:48:04 *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-e0b9-1b23-8395-a665.res6.spectrum.com> has joined #bitcoin-core-dev
184 2021-12-16T08:51:17 *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-e0b9-1b23-8395-a665.res6.spectrum.com> has quit IRC (Client Quit)
185 2021-12-16T08:51:19 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
186 2021-12-16T08:51:44 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
187 2021-12-16T08:55:02 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
188 2021-12-16T08:57:00 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 276 seconds)
189 2021-12-16T08:58:21 *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
190 2021-12-16T08:59:47 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
191 2021-12-16T09:03:57 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
192 2021-12-16T09:09:57 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
193 2021-12-16T09:17:02 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
194 2021-12-16T09:27:56 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
195 2021-12-16T09:28:51 *** geyaeb <geyaeb!~geyaeb@gateway/tor-sasl/geyaeb> has quit IRC (Ping timeout: 276 seconds)
196 2021-12-16T09:30:39 *** geyaeb <geyaeb!~geyaeb@gateway/tor-sasl/geyaeb> has joined #bitcoin-core-dev
197 2021-12-16T09:49:43 *** saranshsharma <saranshsharma!~saranshsh@59.93.34.136> has joined #bitcoin-core-dev
198 2021-12-16T09:50:52 *** nat <nat!~nat@nazareth.nekopon.pl> has quit IRC (Quit: ZNC 1.8.2 - https://znc.in)
199 2021-12-16T09:51:13 *** nat <nat!~nat@nazareth.nekopon.pl> has joined #bitcoin-core-dev
200 2021-12-16T09:52:27 *** nathanael <nathanael!~nathanael@user/nathanael> has quit IRC (Quit: connection reset by purr)
201 2021-12-16T09:53:03 *** nathanael <nathanael!~nathanael@user/nathanael> has joined #bitcoin-core-dev
202 2021-12-16T10:03:59 *** kexkey <kexkey!~kexkey@static-198-54-132-137.cust.tzulo.com> has quit IRC (Ping timeout: 252 seconds)
203 2021-12-16T10:05:10 *** kexkey <kexkey!~kexkey@static-198-54-132-121.cust.tzulo.com> has joined #bitcoin-core-dev
204 2021-12-16T10:27:12 *** boxframes <boxframes!~Saloframe@2607:9000:2000:15::a45d> has quit IRC (Remote host closed the connection)
205 2021-12-16T10:27:31 *** boxframes <boxframes!~Saloframe@2607:9000:2000:15::a45d> has joined #bitcoin-core-dev
206 2021-12-16T10:27:39 *** boxframes <boxframes!~Saloframe@2607:9000:2000:15::a45d> has quit IRC (Remote host closed the connection)
207 2021-12-16T10:35:21 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 245 seconds)
208 2021-12-16T10:39:34 *** saranshsharma <saranshsharma!~saranshsh@59.93.34.136> has quit IRC (Remote host closed the connection)
209 2021-12-16T10:40:50 *** saranshsharma <saranshsharma!~saranshsh@59.93.34.136> has joined #bitcoin-core-dev
210 2021-12-16T10:42:14 *** saranshsharma <saranshsharma!~saranshsh@59.93.34.136> has quit IRC (Remote host closed the connection)
211 2021-12-16T10:44:59 *** dr-orlovsky <dr-orlovsky!~dr-orlovs@31.14.40.18> has joined #bitcoin-core-dev
212 2021-12-16T10:50:29 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
213 2021-12-16T10:56:55 *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has joined #bitcoin-core-dev
214 2021-12-16T11:01:52 *** earnestly <earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
215 2021-12-16T11:08:51 *** Victorsueca <Victorsueca!~Victorsue@user/victorsueca> has quit IRC (Ping timeout: 250 seconds)
216 2021-12-16T11:18:33 *** Victorsueca <Victorsueca!~Victorsue@user/victorsueca> has joined #bitcoin-core-dev
217 2021-12-16T11:30:10 *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Remote host closed the connection)
218 2021-12-16T11:30:24 *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
219 2021-12-16T11:44:57 *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 240 seconds)
220 2021-12-16T11:45:09 *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
221 2021-12-16T11:54:08 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 268 seconds)
222 2021-12-16T11:57:12 *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has quit IRC (Quit: aллилѹÑа!)
223 2021-12-16T12:01:45 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
224 2021-12-16T12:06:57 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
225 2021-12-16T12:19:01 *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has joined #bitcoin-core-dev
226 2021-12-16T12:21:28 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
227 2021-12-16T12:38:43 *** willcl_ark <willcl_ark!~quassel@user/willcl-ark/x-8282106> has quit IRC (Ping timeout: 256 seconds)
228 2021-12-16T12:40:55 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
229 2021-12-16T12:42:51 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
230 2021-12-16T12:43:05 *** saranshsharma <saranshsharma!~saranshsh@59.93.34.136> has joined #bitcoin-core-dev
231 2021-12-16T12:44:03 *** willcl_ark <willcl_ark!~quassel@user/willcl-ark/x-8282106> has joined #bitcoin-core-dev
232 2021-12-16T12:47:47 *** saranshsharma <saranshsharma!~saranshsh@59.93.34.136> has quit IRC (Ping timeout: 268 seconds)
233 2021-12-16T12:54:54 *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:91ca:42ff:4987:327> has joined #bitcoin-core-dev
234 2021-12-16T13:06:33 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
235 2021-12-16T13:06:45 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
236 2021-12-16T13:08:57 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
237 2021-12-16T13:15:23 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Remote host closed the connection)
238 2021-12-16T13:16:32 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
239 2021-12-16T13:23:19 *** nat <nat!~nat@nazareth.nekopon.pl> has quit IRC (Quit: ZNC 1.8.2 - https://znc.in)
240 2021-12-16T13:23:37 *** nat <nat!~nat@nazareth.nekopon.pl> has joined #bitcoin-core-dev
241 2021-12-16T13:25:50 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 252 seconds)
242 2021-12-16T13:32:30 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
243 2021-12-16T13:40:26 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
244 2021-12-16T13:43:16 *** noonien <noonien!~noonien@user/noonien> has quit IRC (Quit: The Lounge - https://thelounge.chat)
245 2021-12-16T13:43:40 *** noonien <noonien!~noonien@user/noonien> has joined #bitcoin-core-dev
246 2021-12-16T13:53:56 <MarcoFalke> PSA: Due to "activity" on archived issues and pull requests, I'll be locking everything up to Dec 31st 2019.
247 2021-12-16T13:54:29 <MarcoFalke> Please open a new issue or leave a question on IRC if something relevant to a locked issue or pull request comes p
248 2021-12-16T13:54:31 <MarcoFalke> *up
249 2021-12-16T13:58:57 *** dr-orlovsky <dr-orlovsky!~dr-orlovs@31.14.40.18> has quit IRC (Ping timeout: 240 seconds)
250 2021-12-16T13:59:09 *** dr-orlovsky <dr-orlovsky!~dr-orlovs@31.14.40.18> has joined #bitcoin-core-dev
251 2021-12-16T13:59:18 <MarcoFalke> Preemptively locking helps against spam attacks on archived threds. Also, it reduces harrassment of people's inbox that left a comment on a thread more than two years ago.
252 2021-12-16T13:59:24 <MarcoFalke> *threads
253 2021-12-16T14:01:49 <jnewbery> MarcoFalke: ACK. Seems like a good policy. Please thank drahtbot for beings so active on issue/pr management :)
254 2021-12-16T14:02:43 <MarcoFalke> Drahty will get some nice carrots for new years
255 2021-12-16T14:03:06 *** jamesob <jamesob!~jamesob@pool-108-31-54-223.washdc.fios.verizon.net> has joined #bitcoin-core-dev
256 2021-12-16T14:08:10 <sipa> MarcoFalke: sounds good to me
257 2021-12-16T14:09:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
258 2021-12-16T14:09:03 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/df6e961c417b...6b212cbbb9d7
259 2021-12-16T14:09:03 <bitcoin-git> bitcoin/master aeeccd9 Martin Zumsande: test: Fix intermittent issue in p2p_addr_relay.py
260 2021-12-16T14:09:03 <bitcoin-git> bitcoin/master 261dddb Martin Zumsande: test: Combine addr generation helper functions
261 2021-12-16T14:09:03 <bitcoin-git> bitcoin/master 6b212cb MarcoFalke: Merge bitcoin/bitcoin#23720: test: Refactor addr_relay.py addr generation,...
262 2021-12-16T14:09:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
263 2021-12-16T14:09:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
264 2021-12-16T14:09:23 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23720: test: Refactor addr_relay.py addr generation, increase mocktime (master...202112_test_addrrelay) https://github.com/bitcoin/bitcoin/pull/23720
265 2021-12-16T14:09:24 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
266 2021-12-16T14:14:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
267 2021-12-16T14:14:55 <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/6b212cbbb9d7...8c0bd871fcf6
268 2021-12-16T14:14:55 <bitcoin-git> bitcoin/master fa3d62c MarcoFalke: Move FindForkInGlobalIndex from BlockManager to CChainState
269 2021-12-16T14:14:55 <bitcoin-git> bitcoin/master fa47b5c MarcoFalke: Move AcceptBlockHeader to ChainstateManager
270 2021-12-16T14:14:55 <bitcoin-git> bitcoin/master facd213 MarcoFalke: Move m_failed_blocks to ChainstateManager
271 2021-12-16T14:14:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
272 2021-12-16T14:15:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
273 2021-12-16T14:15:12 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23785: refactor: Move stuff to ChainstateManager (master...2112-moveCMan) https://github.com/bitcoin/bitcoin/pull/23785
274 2021-12-16T14:15:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
275 2021-12-16T14:15:58 *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has quit IRC (Quit: ZzzZ)
276 2021-12-16T14:29:17 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
277 2021-12-16T14:36:14 *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has quit IRC (Quit: aллилѹÑа!)
278 2021-12-16T14:39:45 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
279 2021-12-16T14:42:55 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
280 2021-12-16T14:43:19 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
281 2021-12-16T14:45:05 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 256 seconds)
282 2021-12-16T14:45:20 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Quit: ð)
283 2021-12-16T14:46:13 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
284 2021-12-16T14:50:57 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
285 2021-12-16T14:51:35 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Client Quit)
286 2021-12-16T14:52:03 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
287 2021-12-16T14:53:22 *** jespada <jespada!~jespada@87.74.33.157> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
288 2021-12-16T14:53:50 *** jespada <jespada!~jespada@87.74.33.157> has joined #bitcoin-core-dev
289 2021-12-16T15:03:04 *** jtrag is now known as Guest7615
290 2021-12-16T15:03:08 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
291 2021-12-16T15:05:13 *** jtrag_ is now known as jtrag
292 2021-12-16T15:06:17 *** Guest7615 <Guest7615!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
293 2021-12-16T15:07:57 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 240 seconds)
294 2021-12-16T15:17:12 <laanwj> MarcoFalke: ACK, assuming you mean closed issues and PRs
295 2021-12-16T15:17:34 <MarcoFalke> jup, closed ones
296 2021-12-16T15:22:32 <laanwj> great!
297 2021-12-16T15:24:22 *** b10c <b10c!uid500648@id-500648.ilkley.irccloud.com> has joined #bitcoin-core-dev
298 2021-12-16T15:24:52 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
299 2021-12-16T15:24:52 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #23795: refactor: Remove implicit-integer-sign-change suppressions in validation (master...2112-refValSup) https://github.com/bitcoin/bitcoin/pull/23795
300 2021-12-16T15:24:53 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
301 2021-12-16T15:27:44 *** saranshsharma <saranshsharma!~saranshsh@59.93.34.136> has joined #bitcoin-core-dev
302 2021-12-16T15:42:42 *** saranshsharma <saranshsharma!~saranshsh@59.93.34.136> has quit IRC (Remote host closed the connection)
303 2021-12-16T15:44:54 <glozow> MarcoFalke: ACK, will bring carrots for Drahty
304 2021-12-16T15:46:31 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
305 2021-12-16T15:46:32 *** jtrag is now known as Guest2357
306 2021-12-16T15:46:52 *** jtrag_ is now known as jtrag
307 2021-12-16T15:48:33 *** Guest2357 <Guest2357!~jtrag@user/jtrag> has quit IRC (Ping timeout: 256 seconds)
308 2021-12-16T15:49:28 *** evbo <evbo!~bosats@2601:47:4383:560:563:2655:147d:d700> has joined #bitcoin-core-dev
309 2021-12-16T16:00:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
310 2021-12-16T16:00:31 <bitcoin-git> [bitcoin] theStack opened pull request #23796: test: check that pruneblockchain RPC fails for future block or timestamp (master...202112-test-add_pruneblockchain_test_coverage) https://github.com/bitcoin/bitcoin/pull/23796
311 2021-12-16T16:00:32 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
312 2021-12-16T16:12:14 *** joshuajbouw <joshuajbouw!~jbouw@user/joshua> has quit IRC (Ping timeout: 250 seconds)
313 2021-12-16T16:18:22 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
314 2021-12-16T16:18:41 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
315 2021-12-16T16:18:46 *** jtrag is now known as Guest1840
316 2021-12-16T16:19:50 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
317 2021-12-16T16:21:37 *** Guest1840 <Guest1840!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
318 2021-12-16T16:21:52 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Remote host closed the connection)
319 2021-12-16T16:22:25 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
320 2021-12-16T16:26:37 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
321 2021-12-16T16:35:41 *** masta`` <masta``!~oyster@user/masta/x-2645138> has joined #bitcoin-core-dev
322 2021-12-16T16:40:23 *** b10c_ <b10c_!~quassel@2a01:4f8:200:1036::1> has joined #bitcoin-core-dev
323 2021-12-16T16:41:46 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
324 2021-12-16T16:42:47 *** b10c <b10c!uid500648@user/b10c> has quit IRC ()
325 2021-12-16T16:42:59 *** b10c_ is now known as b10c
326 2021-12-16T16:43:43 *** bomb-on <bomb-on!~bomb-on@213.220.127.153> has joined #bitcoin-core-dev
327 2021-12-16T17:09:20 *** jtrag__ <jtrag__!~jtrag@user/jtrag> has joined #bitcoin-core-dev
328 2021-12-16T17:11:57 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
329 2021-12-16T17:38:46 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Remote host closed the connection)
330 2021-12-16T17:39:40 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
331 2021-12-16T17:40:37 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
332 2021-12-16T17:47:00 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
333 2021-12-16T17:48:42 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Ping timeout: 276 seconds)
334 2021-12-16T18:07:41 *** jb55 <jb55!~jb55@S010660e327dca171.vc.shawcable.net> has joined #bitcoin-core-dev
335 2021-12-16T18:14:27 *** Trinity96 <Trinity96!~Trinity@2a01:e0a:81c:c420:fe:a91e:2b17:2cf5> has joined #bitcoin-core-dev
336 2021-12-16T18:16:21 *** Trinity96 <Trinity96!~Trinity@2a01:e0a:81c:c420:fe:a91e:2b17:2cf5> has quit IRC (Client Quit)
337 2021-12-16T18:20:45 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Remote host closed the connection)
338 2021-12-16T18:21:22 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
339 2021-12-16T18:28:12 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 268 seconds)
340 2021-12-16T18:37:28 *** bomb-on <bomb-on!~bomb-on@213.220.127.153> has quit IRC (Read error: Connection reset by peer)
341 2021-12-16T18:38:23 *** bomb-on_ <bomb-on_!~bomb-on@213.220.127.153> has joined #bitcoin-core-dev
342 2021-12-16T18:43:56 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
343 2021-12-16T18:47:57 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
344 2021-12-16T18:58:30 *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:91ca:42ff:4987:327> has quit IRC (Remote host closed the connection)
345 2021-12-16T18:59:02 *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:91ca:42ff:4987:327> has joined #bitcoin-core-dev
346 2021-12-16T19:00:02 <laanwj> #startmeeting
347 2021-12-16T19:00:03 <core-meetingbot> Meeting started Thu Dec 16 19:00:02 2021 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
348 2021-12-16T19:00:03 <core-meetingbot> Available commands: action commands idea info link nick
349 2021-12-16T19:00:07 <achow101> hi
350 2021-12-16T19:00:14 <laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball
351 2021-12-16T19:00:15 <hebasto> hi
352 2021-12-16T19:00:16 <laanwj> morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
353 2021-12-16T19:00:28 <kvaciral[m]> hi
354 2021-12-16T19:00:30 <jb55> hi
355 2021-12-16T19:00:31 <jamesob> hi
356 2021-12-16T19:00:35 <jamesob> wow, thursday already
357 2021-12-16T19:00:37 <laanwj> welcome to what i guess is the last general IRC meeting of 2021
358 2021-12-16T19:00:40 <michaelfolkson> hi
359 2021-12-16T19:00:44 <luke-jr> hi
360 2021-12-16T19:00:46 <ariard> hi
361 2021-12-16T19:00:50 <sipa> hi
362 2021-12-16T19:01:02 <fjahr> hi
363 2021-12-16T19:01:02 <b10c> hi
364 2021-12-16T19:01:15 <lightlike> hi
365 2021-12-16T19:01:47 <laanwj> there haven't been any pre-proposed meeting topics (use #proposedmeetingtopic during any time of the week)
366 2021-12-16T19:01:55 <laanwj> any last minute one?
367 2021-12-16T19:02:06 <achow101> suggested topic: wallet maintainer
368 2021-12-16T19:02:33 <jonatack> hi
369 2021-12-16T19:02:43 <luke-jr> achow101: are you volunteering? :P
370 2021-12-16T19:02:49 <achow101> yes
371 2021-12-16T19:02:55 <laanwj> jamesob: yeah time flies when you're having-- well, time flies anyway
372 2021-12-16T19:02:59 <cfields_> hi
373 2021-12-16T19:03:03 <jamesob> laanwj: haha
374 2021-12-16T19:03:04 <jb55> achow101 it is then, that was easy
375 2021-12-16T19:03:05 <luke-jr> laanwj: lol
376 2021-12-16T19:03:17 *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:91ca:42ff:4987:327> has quit IRC (Ping timeout: 240 seconds)
377 2021-12-16T19:03:41 <michaelfolkson> That was too easy. NACK to achow101
378 2021-12-16T19:03:42 <laanwj> #topic Wallet maintainer
379 2021-12-16T19:03:42 <core-meetingbot> topic: Wallet maintainer
380 2021-12-16T19:03:43 <MarcoFalke> jamesob is having a rebase party (fun)
381 2021-12-16T19:03:44 <michaelfolkson> jokez
382 2021-12-16T19:03:47 <luke-jr> x.x
383 2021-12-16T19:04:02 <jamesob> MarcoFalke: how did you know?? ;)
384 2021-12-16T19:04:04 *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:91ca:42ff:4987:327> has joined #bitcoin-core-dev
385 2021-12-16T19:04:15 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
386 2021-12-16T19:04:16 <luke-jr> I need to have a rebase party too soon :x
387 2021-12-16T19:04:32 <MarcoFalke> jamesob: I can hear your keyboard
388 2021-12-16T19:04:39 <jamesob> lol
389 2021-12-16T19:04:54 <laanwj> hahaha
390 2021-12-16T19:05:01 <jamesob> nope, that's just PTSD from _actually_ hearing my keyboard two years ago
391 2021-12-16T19:05:13 <luke-jr> ._.
392 2021-12-16T19:05:15 <jb55> rebase party sounds fun but I might have too many conflicts
393 2021-12-16T19:05:21 <cfields_> lol
394 2021-12-16T19:06:05 <MarcoFalke> achow101: Looks like there are no objections. Just promise to merge no bugs, ok?
395 2021-12-16T19:06:06 <laanwj> ok, on topic, ack to achow101 wallet maintainer
396 2021-12-16T19:06:15 <cfields_> ack
397 2021-12-16T19:06:16 <jb55> ack
398 2021-12-16T19:06:18 <michaelfolkson> ACK
399 2021-12-16T19:06:20 <ariard> ack
400 2021-12-16T19:06:20 <fjahr> ack
401 2021-12-16T19:06:21 <luke-jr> should probably post to ML first, but SGTM
402 2021-12-16T19:06:30 <jamesob> ack achow
403 2021-12-16T19:06:41 <laanwj> no, this is a project decision, not a ML decision
404 2021-12-16T19:06:41 <luke-jr> (or not since it's just a Core internal thing idk)
405 2021-12-16T19:06:43 <b10c> ach ackow101
406 2021-12-16T19:06:47 <laanwj> luke-jr: right
407 2021-12-16T19:06:49 <sipa> ack
408 2021-12-16T19:06:51 <jonatack> ACK modulo no bugs :p
409 2021-12-16T19:06:52 <luke-jr> laanwj: right, but some people might not be here
410 2021-12-16T19:06:53 <jamesob> b10c: god bless you
411 2021-12-16T19:06:59 <achow101> MarcoFalke: those aren't bugs, they're features :p
412 2021-12-16T19:07:06 <MarcoFalke> jup bitcoin-core-dev is only for releases
413 2021-12-16T19:07:09 <laanwj> luke-jr: we'll not immediately assign it so other people have time to comment
414 2021-12-16T19:07:09 <kvaciral[m]> ack
415 2021-12-16T19:07:53 <MarcoFalke> There will also be a pull request, which people can comment on
416 2021-12-16T19:07:56 <laanwj> it's not an actual decision in the meeting just an oppertunity to bring up objections
417 2021-12-16T19:07:59 <laanwj> right
418 2021-12-16T19:08:01 <luke-jr> MarcoFalke: good point
419 2021-12-16T19:08:26 <MarcoFalke> I expect that pull to be open for a week at least, maybe longer because holidays?
420 2021-12-16T19:08:50 <laanwj> yeah
421 2021-12-16T19:09:34 <achow101> i'll open it after the meeting then
422 2021-12-16T19:10:17 <sipa> sgtm
423 2021-12-16T19:10:25 <laanwj> oh github has something new, if you click projects you get "projects (beta)" which doesn't actually have the projects... was afraid for a moment they were all gone
424 2021-12-16T19:10:57 <laanwj> #topic High priority for review
425 2021-12-16T19:10:57 <core-meetingbot> topic: High priority for review
426 2021-12-16T19:11:07 <MarcoFalke> can I haz ACK/NACK on #23411 ?
427 2021-12-16T19:11:08 <gribble> https://github.com/bitcoin/bitcoin/issues/23411 | refactor: Avoid integer overflow in ApplyStats when activating snapshot by MarcoFalke · Pull Request #23411 · bitcoin/bitcoin · GitHub
428 2021-12-16T19:11:15 <jamesob> will look
429 2021-12-16T19:11:21 <achow101> #22558 for me
430 2021-12-16T19:11:22 <gribble> https://github.com/bitcoin/bitcoin/issues/22558 | psbt: Taproot fields for PSBT by achow101 · Pull Request #22558 · bitcoin/bitcoin · GitHub
431 2021-12-16T19:11:34 <laanwj> https://github.com/bitcoin/bitcoin/projects/8 7 blockers, 1 chasing concept ACK
432 2021-12-16T19:12:43 <jonatack> review beg for #22932, up since 3 months, has (drum roll...) one concept ack (thanks promag!)
433 2021-12-16T19:12:46 <gribble> https://github.com/bitcoin/bitcoin/issues/22932 | Guard CBlockIndex::nStatus by cs_main, require GetBlockPos/GetUndoPos to hold cs_main by jonatack · Pull Request #22932 · bitcoin/bitcoin · GitHub
434 2021-12-16T19:12:50 <laanwj> MarcoFalke: achow101: added
435 2021-12-16T19:13:08 <jamesob> jonatack: will look
436 2021-12-16T19:13:27 <jonatack> jamesob: thank you
437 2021-12-16T19:13:30 <laanwj> jonatack: some people seem to be confused why it's necessary, was my conclusion from the comments
438 2021-12-16T19:13:41 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 256 seconds)
439 2021-12-16T19:13:51 <fjahr> I would like to re-add #21726 but I am still working on a rebase, so I can ask again but it should be ready later tonight
440 2021-12-16T19:13:57 <jonatack> laanwj: good point. I rewrote the OP to state the issue, the fixes, and how to review/test it
441 2021-12-16T19:13:58 <gribble> https://github.com/bitcoin/bitcoin/issues/21726 | Improve Indices on pruned nodes via prune blockers by fjahr · Pull Request #21726 · bitcoin/bitcoin · GitHub
442 2021-12-16T19:13:59 <MarcoFalke> I've removed #21702 from hi-prio
443 2021-12-16T19:14:02 <gribble> https://github.com/bitcoin/bitcoin/issues/21702 | Implement BIP-119 Validation (CheckTemplateVerify) by JeremyRubin · Pull Request #21702 · bitcoin/bitcoin · GitHub
444 2021-12-16T19:14:09 <laanwj> jonatack: thanks!
445 2021-12-16T19:14:46 <michaelfolkson> #22674 will be reverted? If it is that will need to go back into high prio
446 2021-12-16T19:14:48 <gribble> https://github.com/bitcoin/bitcoin/issues/22674 | validation: mempool validation and submission for packages of 1 child + parents by glozow · Pull Request #22674 · bitcoin/bitcoin · GitHub
447 2021-12-16T19:15:01 <laanwj> fjahr: added
448 2021-12-16T19:15:08 <jamesob> MarcoFalke: just on the basis that you think e.g. ML discussion, "consensus gathering" is needed first?
449 2021-12-16T19:15:10 <fjahr> laanwj: thanks!
450 2021-12-16T19:15:19 <MarcoFalke> also removed #21160
451 2021-12-16T19:15:23 <gribble> https://github.com/bitcoin/bitcoin/issues/21160 | net/net processing: Move tx inventory into net_processing by jnewbery · Pull Request #21160 · bitcoin/bitcoin · GitHub
452 2021-12-16T19:15:37 <ariard> michaelfolkson: i think that's good enough if past reviwers re-ack, will review back this evening
453 2021-12-16T19:15:45 <MarcoFalke> jamesob: No, see my comment on the pull
454 2021-12-16T19:15:47 <michaelfolkson> ariard: Ok
455 2021-12-16T19:16:17 <MarcoFalke> hi-prio for review doesn't make a lot of sense when the pull can't be reviewed due to needing rebase
456 2021-12-16T19:16:45 <laanwj> MarcoFalke: i guess jnewbery isn't going to get around to it for the forseeable future? should we mark it up for grabs?
457 2021-12-16T19:17:11 <sipa> Let's perhaps leave that question up to him.
458 2021-12-16T19:17:16 <jonatack> (correction, the pull i mentioned has two concept acks by promag and MarcoFalke)
459 2021-12-16T19:17:27 <laanwj> sipa: yes, good point
460 2021-12-16T19:18:30 <laanwj> any other PRs? any other topics?
461 2021-12-16T19:18:51 <laanwj> michaelfolkson: the idea is to revert one of the commits, not the entire PR
462 2021-12-16T19:18:58 <luke-jr> achow101: please don't drop BDB support any time soon tho :P
463 2021-12-16T19:19:10 <laanwj> michaelfolkson: see #23793
464 2021-12-16T19:19:10 <jamesob> death to BDB
465 2021-12-16T19:19:11 <gribble> https://github.com/bitcoin/bitcoin/issues/23793 | validation: Revert "de-duplicate package transactions already in mempool" by laanwj · Pull Request #23793 · bitcoin/bitcoin · GitHub
466 2021-12-16T19:19:31 <sipa> i wish BDB a painful, but very slow, death
467 2021-12-16T19:19:45 <laanwj> michaelfolkson: but according to achow101 it's unreachable anyway
468 2021-12-16T19:20:20 <luke-jr> XD
469 2021-12-16T19:20:25 <laanwj> in any case reverting the entire seems unnecessary, most of the commits did have extensive review, it was only that one that didn't
470 2021-12-16T19:20:46 *** jtrag__ is now known as jtrag
471 2021-12-16T19:20:52 <ariard> yeah it's not used currently, submitpackage rpc hasn't been yet introduced afaik, though critical path for future package relay support
472 2021-12-16T19:21:14 <achow101> if it were reachable, i would recommend revert because there's a crashing bug, but it's not reachable, so meh
473 2021-12-16T19:21:20 <michaelfolkson> laanwj: Gotcha, thanks. Have you ever thought of giving advance warning that you're intending to merge something? I've always wondered that
474 2021-12-16T19:21:38 <michaelfolkson> Something like "I think this is ready for merge. Intending to merge in say 3 days"
475 2021-12-16T19:21:49 <laanwj> michaelfolkson: i do that sometimes
476 2021-12-16T19:21:55 <michaelfolkson> Ah ok
477 2021-12-16T19:22:16 <luke-jr> these issues are rare enough that reverting when there's a problem is probably a better approach IMO
478 2021-12-16T19:22:29 <laanwj> i made mistake here
479 2021-12-16T19:23:06 <michaelfolkson> It has secondary effect of being like "last orders" or "last chance to review before merging"
480 2021-12-16T19:23:24 <MarcoFalke> laanwj: I think mistakes are impossible to avoid in general
481 2021-12-16T19:23:26 <laanwj> luke-jr: it only makes sense for extensive or somewhat controversial PRs, not for run of the mill ones
482 2021-12-16T19:23:36 <MarcoFalke> I've merged silent merge conflicts twice in the last week or so
483 2021-12-16T19:23:44 <michaelfolkson> But maybe it has downsides, I don't know. I guess the author would generally prefer immediate merging to avoid need for more rebases
484 2021-12-16T19:23:55 <luke-jr> laanwj: right
485 2021-12-16T19:24:07 <MarcoFalke> They are just too hard to catch while merging
486 2021-12-16T19:24:17 <jamesob> merge-freezes and plenty of testing before releases are the only saving graces afaict
487 2021-12-16T19:24:55 <laanwj> MarcoFalke: yes that happens often enough to me too, usually my local build catches them but it's impossible to run for every platform combo
488 2021-12-16T19:25:21 <MarcoFalke> I'll experiment with DrahtBot re-running the CI on weekends
489 2021-12-16T19:25:34 <MarcoFalke> There is less "real" traffic on weekends
490 2021-12-16T19:25:48 <laanwj> that would be useful
491 2021-12-16T19:25:51 <luke-jr> btw, any reason not to set `greedy` in Cirrus CI stuff?
492 2021-12-16T19:26:03 <sipa> greedy?
493 2021-12-16T19:26:07 <luke-jr> and bump up the -j
494 2021-12-16T19:26:12 <MarcoFalke> luke-jr: Sure, go for it
495 2021-12-16T19:26:13 <luke-jr> sipa: lets the VM use more CPU if it's idle
496 2021-12-16T19:26:26 <sipa> oh, cool
497 2021-12-16T19:26:45 <luke-jr> MarcoFalke: k
498 2021-12-16T19:26:47 <MarcoFalke> sipa: If there is idle CPU on the host it will consume it, even if less CPU was requested
499 2021-12-16T19:26:48 <laanwj> thanks to ariard for doing another review round and catching it anyhow
500 2021-12-16T19:27:07 <MarcoFalke> https://medium.com/cirruslabs/introducing-greedy-container-instances-29aad06dc2b4
501 2021-12-16T19:27:25 <sipa> got it... the only reason you wouldn't want greedy is when you're doing benchmarks i assume...
502 2021-12-16T19:27:46 <MarcoFalke> Oh, and we should be cautious about OOM
503 2021-12-16T19:28:06 <luke-jr> hmm
504 2021-12-16T19:28:08 <MarcoFalke> If there is too many CPUs running msan, it will crash the whole VM
505 2021-12-16T19:28:11 <laanwj> benchmarks and too-tight timeouts
506 2021-12-16T19:28:18 <MarcoFalke> memory isn't assigned in greedy
507 2021-12-16T19:28:18 <sipa> right
508 2021-12-16T19:28:22 <luke-jr> MarcoFalke: how about bumping that one job to 8 CPUs / 32 GB RAM?
509 2021-12-16T19:29:05 <MarcoFalke> There is a pool of CPUs that can be used. If one task uses a lot, then other tasks will be scheduled later
510 2021-12-16T19:29:29 <MarcoFalke> Most efficient scheduling (I think) is to use least amount of CPU per task, but many tasks in parallel
511 2021-12-16T19:29:49 <hebasto> ^ agree
512 2021-12-16T19:30:11 <MarcoFalke> Or, if someone has a credit card with unlimited money, we could use that
513 2021-12-16T19:30:21 <MarcoFalke> Maybe 40k-110k per year or so
514 2021-12-16T19:30:35 <luke-jr> could turn off greedy for that one task then I guess
515 2021-12-16T19:30:59 <sipa> Well there is a constant cost (at least cloning repo / configure scripts) which don't run multithreaded.
516 2021-12-16T19:31:14 <sipa> Which puts a limit on how much splitting things up makes sense.
517 2021-12-16T19:32:05 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
518 2021-12-16T19:32:47 <MarcoFalke> sipa: Jup, that's why the least amount of number of CPUs is the most efficient (highest total CPU usage)
519 2021-12-16T19:33:07 <laanwj> multithreaded configure sounds pretty cursed
520 2021-12-16T19:33:58 <luke-jr> laanwj: eh, in theory it sounds easy (in practice, tho..)
521 2021-12-16T19:34:15 <laanwj> think of the dependency graph :-)
522 2021-12-16T19:34:43 <sipa> Yes, and in theory, there is no difference between theory and practice; in practice however...
523 2021-12-16T19:34:47 <luke-jr> XD
524 2021-12-16T19:34:48 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
525 2021-12-16T19:34:48 <bitcoin-git> [bitcoin] luke-jr opened pull request #23797: ci: Use Cirrus "greedy" flag to use idle CPU time when available (master...cirrus_greedy) https://github.com/bitcoin/bitcoin/pull/23797
526 2021-12-16T19:34:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
527 2021-12-16T19:35:07 <MarcoFalke> Most of the time only one CPU is used: https://cirrus-ci.com/task/4949915049656320
528 2021-12-16T19:35:18 <MarcoFalke> So I am not sure how much greedy helps us
529 2021-12-16T19:35:19 <laanwj> hehe
530 2021-12-16T19:35:36 <luke-jr> MarcoFalke: I guess we'll see when Cirrus does the PR's CI
531 2021-12-16T19:36:07 <laanwj> right
532 2021-12-16T19:36:10 <sipa> For the functional tests, I've found that (with enough RAM) running more tests in parallel than your number of CPU cores is beneficial.
533 2021-12-16T19:36:10 <luke-jr> hmm, maybe -j60 or something for the tests would be more time-saving?
534 2021-12-16T19:36:17 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
535 2021-12-16T19:36:30 <sipa> Because the tests spend a lot of time waiting.
536 2021-12-16T19:36:33 <MarcoFalke> another option would be to use self-hosted machines (#21652)
537 2021-12-16T19:36:34 <gribble> https://github.com/bitcoin/bitcoin/issues/21652 | [WIP NOMERGE DRAFT] ci: Switch more tasks to self-hosted by MarcoFalke · Pull Request #21652 · bitcoin/bitcoin · GitHub
538 2021-12-16T19:37:05 <MarcoFalke> luke-jr: No, there is one unit test that takes a long time. It will block a single CPU
539 2021-12-16T19:37:16 <luke-jr> I've found if I forget to specify -j64, builds take a looong time :x
540 2021-12-16T19:37:49 <jonatack> -j 4 or 5 here :D
541 2021-12-16T19:37:50 <MarcoFalke> sipa: Right, CI uses 2x or 4x the -j of the number of CPUs available
542 2021-12-16T19:38:02 <b10c> where / who runs the self hosted CI runners?
543 2021-12-16T19:38:07 <laanwj> jonatack: same
544 2021-12-16T19:38:20 <MarcoFalke> b10c: Drahty right now
545 2021-12-16T19:38:37 <hebasto> b10c: bitcoinbuilds.org
546 2021-12-16T19:38:55 <MarcoFalke> sipa: For example https://cirrus-ci.com/task/4949915049656320 has two CPUs and "MAKEJOBS:-j4" env var
547 2021-12-16T19:39:09 <MarcoFalke> hebasto: That is a separate CI system
548 2021-12-16T19:39:17 <sipa> It has 2 CPUs, or 2 CPU threads?
549 2021-12-16T19:39:30 <hebasto> MarcoFalke: right
550 2021-12-16T19:39:33 <MarcoFalke> 2 CPU threads
551 2021-12-16T19:39:37 <sipa> As in: how many entries would /proc/cpuinfo show?
552 2021-12-16T19:39:41 <sipa> Ok.
553 2021-12-16T19:39:48 <MarcoFalke> aka vCPU
554 2021-12-16T19:40:26 <MarcoFalke> For example https://cirrus-ci.com/task/6075814956498944 is run by Drahty
555 2021-12-16T19:40:27 <sipa> For make I wouldn't go above the actual thread count. But for the functional_test runner you can go significantly above it.
556 2021-12-16T19:40:37 <MarcoFalke> env var: "worker:DrahtBot-small-cpx21-ci-bb-001"
557 2021-12-16T19:40:38 <michaelfolkson> c-lightning has been having CI problems due to tests taking up a lot of memory https://btctranscripts.com/c-lightning/2021-11-29-developer-call/#ci-problems. Core tests generally use less memory and so haven't experienced same problems?
558 2021-12-16T19:40:45 <laanwj> jonatack: i have way too many computers but not one with >8 cores or enough memory for -j64 :)
559 2021-12-16T19:40:51 <jonatack> sipa: added the "-j60 tip for running the functional tests to https://jonatack.github.io/articles/how-to-compile-bitcoin-core-and-run-the-tests (near the end) but increased -j for this never worked well for me
560 2021-12-16T19:41:03 <luke-jr> michaelfolkson: eh, Cirrus allows up to 32 GB RAM O.o
561 2021-12-16T19:41:23 <jonatack> laanwj: yes, those purisms don't have many
562 2021-12-16T19:41:23 <MarcoFalke> sipa: I think there is no downside using a higher -j (if you have enough memory)
563 2021-12-16T19:41:37 <jonatack> sipa: (with 32go RAM)
564 2021-12-16T19:41:56 <sipa> jonattack: well, benchmark on your own system which amount works best. I imagine it's a complex function of cpu / diskspeed etc.
565 2021-12-16T19:41:58 <luke-jr> laanwj: mine is only 16 cores, but they're SMT4
566 2021-12-16T19:42:00 <laanwj> jonatack: right, neither do ARM and RV boards for that matter
567 2021-12-16T19:42:10 <b10c> MarcoFalke: thanks, so hetzner cloud (based on cpx21)
568 2021-12-16T19:42:23 <MarcoFalke> b10c: heh, right
569 2021-12-16T19:42:36 <_aj_> jonatack: test_runner.py -j 24 # works pretty well for me with 16GB; usually get one spurious failure though
570 2021-12-16T19:42:46 <laanwj> luke-jr: ye that helps
571 2021-12-16T19:43:00 <jonatack> i do have to use timeout-factor tho, otherwise a few tests time out frequently (rpc_misc mostly, then feature_blockfilterindex_prune and feature_assumevalid)
572 2021-12-16T19:43:34 <sipa> I/O speed matters a lot too.
573 2021-12-16T19:44:02 <laanwj> the way around that is to mount /tmp as tmpfs
574 2021-12-16T19:44:41 <jonatack> maybe my disk encryption doesn't help matters
575 2021-12-16T19:44:44 <jonatack> aj: nice
576 2021-12-16T19:44:59 <laanwj> or at least, whatever temp directory you use for the functional tests
577 2021-12-16T19:44:59 <_aj_> jonatack: (/tmp is on ssd)
578 2021-12-16T19:45:10 <luke-jr> laanwj: I have a zram :p
579 2021-12-16T19:45:33 <luke-jr> not sure I can recommend it though, as it seems Linux is buggy
580 2021-12-16T19:45:48 <luke-jr> (the zram's ext4 fs gets corrupted sometimes)
581 2021-12-16T19:46:38 <MarcoFalke> I also use tmpfs for /tmp
582 2021-12-16T19:46:42 <laanwj> TIL about zram
583 2021-12-16T19:46:56 <sipa> same
584 2021-12-16T19:47:55 <laanwj> i guess that concludes the topic? let's see what #23797 does
585 2021-12-16T19:47:56 <gribble> https://github.com/bitcoin/bitcoin/issues/23797 | ci: Use Cirrus "greedy" flag to use idle CPU time when available by luke-jr · Pull Request #23797 · bitcoin/bitcoin · GitHub
586 2021-12-16T19:48:08 <luke-jr> also handy for putting swap on
587 2021-12-16T19:48:36 <luke-jr> (haven't noticed any swap-zram issues, so I'm guessing the mentioned bugs are probably ext4)
588 2021-12-16T19:49:18 <laanwj> i don't think it makes sense to do a meeting next week (dec 23th) or after (dec 30th), so next one will be jan 6
589 2021-12-16T19:49:54 <sipa> yeah, agree
590 2021-12-16T19:50:22 <michaelfolkson> Cool. Next week's Core PR review club is on multiprocess if anyone wants to use that as an excuse to play around with the multiprocess stuff :)
591 2021-12-16T19:50:24 <michaelfolkson> https://bitcoincore.reviews/10102
592 2021-12-16T19:50:51 <laanwj> michaelfolkson: thanks for the heads up
593 2021-12-16T19:51:16 <laanwj> #endmeeting
594 2021-12-16T19:51:17 <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
595 2021-12-16T19:51:17 <core-meetingbot> Meeting ended Thu Dec 16 19:51:16 2021 UTC.
596 2021-12-16T19:51:17 <core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-12-16-19.00.moin.txt
597 2021-12-16T19:51:50 <evbo> thank you
598 2021-12-16T19:52:31 *** lukedashjr <lukedashjr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
599 2021-12-16T19:53:10 *** evbo <evbo!~bosats@2601:47:4383:560:563:2655:147d:d700> has quit IRC (Remote host closed the connection)
600 2021-12-16T19:54:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
601 2021-12-16T19:54:06 <bitcoin-git> [bitcoin] achow101 opened pull request #23798: contrib: add achow101 to trusted keys (master...wallet-maintainer-key) https://github.com/bitcoin/bitcoin/pull/23798
602 2021-12-16T19:54:07 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
603 2021-12-16T19:54:56 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
604 2021-12-16T19:55:03 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 256 seconds)
605 2021-12-16T19:57:53 *** lukedashjr <lukedashjr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 256 seconds)
606 2021-12-16T19:59:29 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
607 2021-12-16T19:59:35 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 256 seconds)
608 2021-12-16T20:07:27 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
609 2021-12-16T20:07:29 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Remote host closed the connection)
610 2021-12-16T20:08:02 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
611 2021-12-16T20:13:01 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 268 seconds)
612 2021-12-16T20:22:58 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
613 2021-12-16T20:25:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
614 2021-12-16T20:25:33 <bitcoin-git> [bitcoin] sipa opened pull request #23799: Let test_runner.py start multiple jobs per timeslot (master...202112_multitesturn) https://github.com/bitcoin/bitcoin/pull/23799
615 2021-12-16T20:25:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
616 2021-12-16T20:28:31 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
617 2021-12-16T20:31:07 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Remote host closed the connection)
618 2021-12-16T20:31:40 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
619 2021-12-16T20:36:27 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 268 seconds)
620 2021-12-16T20:38:51 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
621 2021-12-16T20:47:20 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Remote host closed the connection)
622 2021-12-16T20:47:54 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
623 2021-12-16T20:52:17 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
624 2021-12-16T21:10:03 <jb55> I ran the functional test suite for the first time today, all is good except feature_dbcrash.py seems to hang, is this a known issue?
625 2021-12-16T21:17:35 <sipa> On what kind of system? I don't see any problems.
626 2021-12-16T21:19:41 <jb55> linux (nixos). hmm ok now I need to figure out how to debug this...
627 2021-12-16T21:20:39 *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has joined #bitcoin-core-dev
628 2021-12-16T21:23:03 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
629 2021-12-16T21:25:09 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
630 2021-12-16T21:27:39 *** jtrag is now known as Guest6729
631 2021-12-16T21:27:59 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 256 seconds)
632 2021-12-16T21:28:05 *** jtrag_ is now known as jtrag
633 2021-12-16T21:28:33 *** Guest6729 <Guest6729!~jtrag@user/jtrag> has quit IRC (Ping timeout: 256 seconds)
634 2021-12-16T21:52:31 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC ()
635 2021-12-16T21:56:49 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
636 2021-12-16T22:01:33 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 268 seconds)
637 2021-12-16T22:01:55 <jb55> sipa: ah it wasn't hanging, it looks like the test goes through 40 iterations and each iteration takes over a minute.
638 2021-12-16T22:05:04 <sipa> Slow disk I/O?
639 2021-12-16T22:05:37 <jb55> it's a new SSD, every other test ran quickly
640 2021-12-16T22:07:23 <jb55> Iteration 16, generating 2500 transactions - looks like this is taking about a minute each iteration...
641 2021-12-16T22:12:00 <jb55> will see if --perf helps here...
642 2021-12-16T22:19:14 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
643 2021-12-16T22:19:15 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Client Quit)
644 2021-12-16T22:22:31 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
645 2021-12-16T22:29:11 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 256 seconds)
646 2021-12-16T22:56:35 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
647 2021-12-16T23:01:22 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 268 seconds)
648 2021-12-16T23:01:50 <luke-jr> gitian builds please * [new tag] v21.2.knots20210629 -> v21.2.knots20210629
649 2021-12-16T23:05:04 *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
650 2021-12-16T23:06:16 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
651 2021-12-16T23:07:35 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
652 2021-12-16T23:18:46 *** adiabat <adiabat!~adiabat@63.209.32.102> has joined #bitcoin-core-dev
653 2021-12-16T23:24:47 *** boxframes <boxframes!~Saloframe@2607:9000:2000:15::a45d> has joined #bitcoin-core-dev
654 2021-12-16T23:25:42 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
655 2021-12-16T23:29:57 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
656 2021-12-16T23:29:58 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
657 2021-12-16T23:30:57 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 256 seconds)
658 2021-12-16T23:45:56 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
659 2021-12-16T23:47:40 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
660 2021-12-16T23:49:21 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Quit: ð)
661 2021-12-16T23:52:39 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Remote host closed the connection)
662 2021-12-16T23:53:12 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev