1 2021-12-22T00:05:22  *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has joined #bitcoin-core-dev
  2 2021-12-22T00:09:50  *** gnaf <gnaf!~pi@86-91-224-60.opennet.kpn.net> has quit IRC (Quit: Konversation terminated!)
  3 2021-12-22T00:18:53  *** z0d <z0d!~z0d@c-73-238-143-196.hsd1.ct.comcast.net> has quit IRC (Quit: ZZZzzz…)
  4 2021-12-22T00:23:44  *** z0d <z0d!~z0d@c-73-238-143-196.hsd1.ct.comcast.net> has joined #bitcoin-core-dev
  5 2021-12-22T00:31:17  *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has quit IRC (Quit: ZzzZ)
  6 2021-12-22T00:32:59  <jamesob> _aj_: yup, those flags are applied to both nodes
  7 2021-12-22T00:33:04  *** z0d <z0d!~z0d@c-73-238-143-196.hsd1.ct.comcast.net> has quit IRC (Quit: ZZZzzz…)
  8 2021-12-22T00:52:06  *** bitcoin_alien[m] <bitcoin_alien[m]!~bitcoinal@2001:470:69fc:105::1:5503> has joined #bitcoin-core-dev
  9 2021-12-22T00:58:50  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
 10 2021-12-22T00:58:50  *** z0d <z0d!~z0d@c-73-238-143-196.hsd1.ct.comcast.net> has joined #bitcoin-core-dev
 11 2021-12-22T00:59:17  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
 12 2021-12-22T01:13:06  *** grettke <grettke!~grettke@184.62.226.206> has joined #bitcoin-core-dev
 13 2021-12-22T01:28:15  *** grettke <grettke!~grettke@184.62.226.206> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 14 2021-12-22T01:41:31  *** z0d <z0d!~z0d@c-73-238-143-196.hsd1.ct.comcast.net> has quit IRC (Quit: ZZZzzz…)
 15 2021-12-22T01:56:42  *** z0d <z0d!~z0d@c-73-238-143-196.hsd1.ct.comcast.net> has joined #bitcoin-core-dev
 16 2021-12-22T01:57:26  *** grettke <grettke!~grettke@184.62.226.206> has joined #bitcoin-core-dev
 17 2021-12-22T02:11:15  *** z0d <z0d!~z0d@c-73-238-143-196.hsd1.ct.comcast.net> has quit IRC (Quit: ZZZzzz…)
 18 2021-12-22T02:19:49  *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has joined #bitcoin-core-dev
 19 2021-12-22T02:27:00  *** z0d <z0d!~z0d@c-73-238-143-196.hsd1.ct.comcast.net> has joined #bitcoin-core-dev
 20 2021-12-22T02:31:06  *** masta`` <masta``!~oyster@user/masta/x-2645138> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
 21 2021-12-22T02:31:37  *** lukedashjr <lukedashjr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
 22 2021-12-22T02:33:57  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 276 seconds)
 23 2021-12-22T02:34:31  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
 24 2021-12-22T02:34:36  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 276 seconds)
 25 2021-12-22T02:35:29  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
 26 2021-12-22T02:36:10  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 268 seconds)
 27 2021-12-22T02:36:20  *** lukedashjr is now known as luke-jr
 28 2021-12-22T02:55:36  *** earnestly <earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 256 seconds)
 29 2021-12-22T03:00:11  *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has quit IRC (Quit: ZzzZ)
 30 2021-12-22T03:40:37  *** jespada <jespada!~jespada@87.74.33.157> has quit IRC (Ping timeout: 240 seconds)
 31 2021-12-22T03:41:45  *** jespada <jespada!~jespada@87.74.33.157> has joined #bitcoin-core-dev
 32 2021-12-22T03:48:03  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 276 seconds)
 33 2021-12-22T04:01:37  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
 34 2021-12-22T04:04:50  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC ()
 35 2021-12-22T04:37:28  *** x88x88x <x88x88x!~x88x88x@2001:19f0:5:39a8:5400:3ff:feb6:73cb> has joined #bitcoin-core-dev
 36 2021-12-22T04:43:39  *** saranshsharma <saranshsharma!~saranshsh@59.93.238.217> has joined #bitcoin-core-dev
 37 2021-12-22T04:47:44  *** saranshs_ <saranshs_!~saranshsh@59.93.238.217> has joined #bitcoin-core-dev
 38 2021-12-22T04:47:47  *** saranshsharma <saranshsharma!~saranshsh@59.93.238.217> has quit IRC (Read error: Connection reset by peer)
 39 2021-12-22T04:56:57  *** saranshs_ <saranshs_!~saranshsh@59.93.238.217> has quit IRC (Remote host closed the connection)
 40 2021-12-22T04:58:32  *** z0d <z0d!~z0d@c-73-238-143-196.hsd1.ct.comcast.net> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
 41 2021-12-22T04:58:41  *** saranshsharma <saranshsharma!~saranshsh@59.93.238.217> has joined #bitcoin-core-dev
 42 2021-12-22T05:01:02  *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
 43 2021-12-22T05:01:13  *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
 44 2021-12-22T05:02:35  *** saranshsharma <saranshsharma!~saranshsh@59.93.238.217> has quit IRC (Remote host closed the connection)
 45 2021-12-22T05:02:54  *** saranshsharma <saranshsharma!~saranshsh@59.93.238.217> has joined #bitcoin-core-dev
 46 2021-12-22T05:04:47  *** saranshsharma <saranshsharma!~saranshsh@59.93.238.217> has quit IRC (Remote host closed the connection)
 47 2021-12-22T05:05:49  *** saranshsharma <saranshsharma!~saranshsh@59.93.238.217> has joined #bitcoin-core-dev
 48 2021-12-22T05:14:45  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 49 2021-12-22T05:24:47  *** grettke <grettke!~grettke@184.62.226.206> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 50 2021-12-22T05:28:54  *** RobYatty <RobYatty!~me@107-139-231-17.lightspeed.irvnca.sbcglobal.net> has joined #bitcoin-core-dev
 51 2021-12-22T05:30:12  *** geyaeb <geyaeb!~geyaeb@gateway/tor-sasl/geyaeb> has quit IRC (Remote host closed the connection)
 52 2021-12-22T05:30:43  *** geyaeb <geyaeb!~geyaeb@gateway/tor-sasl/geyaeb> has joined #bitcoin-core-dev
 53 2021-12-22T05:31:19  *** RoyBatty <RoyBatty!~me@user/robyatty> has quit IRC (Ping timeout: 268 seconds)
 54 2021-12-22T05:40:08  *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has quit IRC (Remote host closed the connection)
 55 2021-12-22T05:40:29  *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has joined #bitcoin-core-dev
 56 2021-12-22T05:43:04  *** grettke <grettke!~grettke@184.62.226.206> has joined #bitcoin-core-dev
 57 2021-12-22T05:43:08  *** grettke <grettke!~grettke@184.62.226.206> has quit IRC (Client Quit)
 58 2021-12-22T05:43:37  *** jb55 <jb55!~jb55@user/jb55> has quit IRC (Ping timeout: 240 seconds)
 59 2021-12-22T05:45:26  *** lukedashjr <lukedashjr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
 60 2021-12-22T05:46:26  *** RobYatty is now known as RoyBatty
 61 2021-12-22T05:46:43  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 268 seconds)
 62 2021-12-22T05:46:47  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
 63 2021-12-22T05:47:09  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
 64 2021-12-22T05:47:31  *** lukedashjr is now known as luke-jr
 65 2021-12-22T05:53:53  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
 66 2021-12-22T05:54:32  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 67 2021-12-22T06:25:37  *** saranshsharma <saranshsharma!~saranshsh@59.93.238.217> has quit IRC (Remote host closed the connection)
 68 2021-12-22T06:26:03  *** saranshsharma <saranshsharma!~saranshsh@59.93.238.217> has joined #bitcoin-core-dev
 69 2021-12-22T06:43:04  *** RoyBatty <RoyBatty!~me@user/robyatty> has quit IRC (Remote host closed the connection)
 70 2021-12-22T06:55:45  *** amnrst <amnrst!~amnrst@p509394a3.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
 71 2021-12-22T06:56:57  *** amnrst <amnrst!~amnrst@p509394a3.dip0.t-ipconnect.de> has quit IRC (Remote host closed the connection)
 72 2021-12-22T07:04:33  *** nanotube <nanotube!~nanotube@user/nanotube> has joined #bitcoin-core-dev
 73 2021-12-22T07:05:31  *** saranshsharma <saranshsharma!~saranshsh@59.93.238.217> has quit IRC (Ping timeout: 256 seconds)
 74 2021-12-22T07:13:26  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
 75 2021-12-22T07:17:46  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Client Quit)
 76 2021-12-22T07:27:50  *** saranshsharma <saranshsharma!~saranshsh@2401:4900:234d:963e:1d98:9a31:15e5:c875> has joined #bitcoin-core-dev
 77 2021-12-22T07:53:22  *** saranshsharma <saranshsharma!~saranshsh@2401:4900:234d:963e:1d98:9a31:15e5:c875> has quit IRC (Remote host closed the connection)
 78 2021-12-22T08:22:10  *** Guest55 <Guest55!~Guest55@58.red-81-42-209.staticip.rima-tde.net> has joined #bitcoin-core-dev
 79 2021-12-22T08:22:21  *** Guest55 <Guest55!~Guest55@58.red-81-42-209.staticip.rima-tde.net> has quit IRC (Client Quit)
 80 2021-12-22T08:40:43  *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
 81 2021-12-22T09:10:45  *** grettke <grettke!~grettke@184.62.226.206> has joined #bitcoin-core-dev
 82 2021-12-22T09:11:15  *** grettke <grettke!~grettke@184.62.226.206> has quit IRC (Client Quit)
 83 2021-12-22T09:18:57  *** Victorsueca <Victorsueca!~Victorsue@user/victorsueca> has quit IRC (Ping timeout: 240 seconds)
 84 2021-12-22T09:26:14  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
 85 2021-12-22T09:30:00  *** raj <raj!~raj@2602:ffb6:4:e396:f816:3eff:fe47:ca2a> has quit IRC (Killed (NickServ (GHOST command used by Guest2756!uid72176@user/raj)))
 86 2021-12-22T09:30:43  *** raj_ <raj_!~raj@167.182.81.172.lunanode-rdns.com> has joined #bitcoin-core-dev
 87 2021-12-22T09:40:22  *** Victorsueca <Victorsueca!~Victorsue@user/victorsueca> has joined #bitcoin-core-dev
 88 2021-12-22T09:47:10  *** RoyBatty <RoyBatty!~me@107-139-231-17.lightspeed.irvnca.sbcglobal.net> has joined #bitcoin-core-dev
 89 2021-12-22T09:58:24  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
 90 2021-12-22T10:33:42  <laanwj> this issue while testing seems to always come back, sometimes it'd be useful to be able to completely override the IBD logic
 91 2021-12-22T10:48:18  *** gnaf <gnaf!~pi@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
 92 2021-12-22T11:09:47  *** tla2k21 <tla2k21!~tla2k21@gateway/tor-sasl/tla2k21> has quit IRC (Remote host closed the connection)
 93 2021-12-22T11:09:59  *** tla2k21 <tla2k21!~tla2k21@gateway/tor-sasl/tla2k21> has joined #bitcoin-core-dev
 94 2021-12-22T11:15:58  *** Common <Common!~Common@user/common> has quit IRC (Quit: Leaving)
 95 2021-12-22T11:16:54  *** Gimble <Gimble!~G1mble2@2a01:4b00:8e07:7900:e79c:6460:44ed:8423> has joined #bitcoin-core-dev
 96 2021-12-22T11:36:49  *** earnestly <earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
 97 2021-12-22T11:51:39  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 276 seconds)
 98 2021-12-22T11:57:23  *** Common <Common!~Common@096-033-221-075.res.spectrum.com> has joined #bitcoin-core-dev
 99 2021-12-22T12:00:25  *** jespada <jespada!~jespada@87.74.33.157> has quit IRC (Ping timeout: 268 seconds)
100 2021-12-22T12:02:56  *** jespada <jespada!~jespada@87.74.33.157> has joined #bitcoin-core-dev
101 2021-12-22T12:31:59  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has joined #bitcoin-core-dev
102 2021-12-22T13:05:17  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has quit IRC (Ping timeout: 240 seconds)
103 2021-12-22T13:06:09  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has joined #bitcoin-core-dev
104 2021-12-22T13:07:56  *** masta`` <masta``!~oyster@user/masta/x-2645138> has joined #bitcoin-core-dev
105 2021-12-22T13:13:01  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has quit IRC (Ping timeout: 240 seconds)
106 2021-12-22T13:14:24  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has joined #bitcoin-core-dev
107 2021-12-22T13:24:36  *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 276 seconds)
108 2021-12-22T13:35:35  *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
109 2021-12-22T13:47:25  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has quit IRC (Ping timeout: 240 seconds)
110 2021-12-22T13:48:31  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has joined #bitcoin-core-dev
111 2021-12-22T14:09:13  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
112 2021-12-22T14:10:27  *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
113 2021-12-22T14:11:42  *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
114 2021-12-22T14:13:59  *** masta`` <masta``!~oyster@user/masta/x-2645138> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
115 2021-12-22T14:15:37  *** gnaf <gnaf!~pi@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 256 seconds)
116 2021-12-22T14:31:45  *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
117 2021-12-22T14:35:12  *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 268 seconds)
118 2021-12-22T14:35:16  *** Guyver2_ is now known as Guyver2
119 2021-12-22T14:42:13  *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has joined #bitcoin-core-dev
120 2021-12-22T15:19:37  *** x88x88x <x88x88x!~x88x88x@2001:19f0:5:39a8:5400:3ff:feb6:73cb> has quit IRC (Ping timeout: 240 seconds)
121 2021-12-22T15:22:03  *** x88x88x <x88x88x!~x88x88x@149.28.53.172> has joined #bitcoin-core-dev
122 2021-12-22T15:30:30  *** gnaf <gnaf!~pi@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
123 2021-12-22T15:33:39  *** Guest97 <Guest97!~Guest97@181-191-0-203.uplinkx.com.br> has joined #bitcoin-core-dev
124 2021-12-22T15:36:33  *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 276 seconds)
125 2021-12-22T15:39:33  <michaelfolkson> bitcoin-node in multiprocess uses UNIX sockets https://github.com/bitcoin/bitcoin/pull/19460
126 2021-12-22T15:39:50  <michaelfolkson> How did it get around the libevent stuff?
127 2021-12-22T15:39:58  <sipa> It doesn't use libevent.
128 2021-12-22T15:41:17  <michaelfolkson> What does it do instead?
129 2021-12-22T15:41:55  <michaelfolkson> So at least until UNIX sockets are implemented in Core non-multiprocess that's a reason for using multiprocess? If you want to use UNIX sockets?
130 2021-12-22T15:42:14  <sipa> I can't understand your reasoning.
131 2021-12-22T15:42:20  <sipa> They do different things.
132 2021-12-22T15:42:35  <sipa> You don't "want" to use UNIX sockets. They're a tool to accomplish a goal.
133 2021-12-22T15:42:58  <sipa> Using multiprocess doesn't let you make RPC connections over UNIX sockets.
134 2021-12-22T15:43:09  <sipa> Because multiprocess isn't RPC.
135 2021-12-22T15:43:51  <earnestly> capn proto is rpc
136 2021-12-22T15:44:09  <sipa> Yes, multiprocess uses capnproto under the hood/
137 2021-12-22T15:44:58  <sipa> But it doesn't (and can't) provide the Bitcoin Core RPC interface. It's used to provide the multiprocess interface.
138 2021-12-22T15:45:25  <sipa> P2P also doesn't use libevent; it uses raw socket. It also doesn't provide the RPC interface (nor the multiprocess interface); it provides the P2P interface.
139 2021-12-22T15:46:58  <sipa> If you're using Linux, and using bitcoin-qt, Qt is likely for some part at least using a UNIX domain socket to communicate with the X graphics driver. So if your goal was "I want my Bitcoin Core to use UNIX domain sockets!!!", then you probably already have it.
140 2021-12-22T15:48:00  <MarcoFalke> why would using sockets be a goal by itself?
141 2021-12-22T15:48:27  <sipa> It's not. That was my point - you don't care about using UNIX domain sockets on itself.
142 2021-12-22T15:48:54  <MarcoFalke> right. It shouldn't matter too much to the user what multiprocess uses internally to communicate
143 2021-12-22T15:49:11  <sipa> RPC, P2P, multiprocess, UI... they're all distinct ways in which Bitcoin Core interacts with other processes/systems; ... and they all have different needs, and use different tools to accomplish that. Just because one uses a particular technology under the hood doesn't mean it's easy to make another one use the same technology.
144 2021-12-22T15:59:52  <michaelfolkson> I was thinking (incorrectly) that because multiprocess uses UNIX sockets that meant there was UNIX socket support for the equivalent of multiprocess RPC
145 2021-12-22T15:59:59  <michaelfolkson> Thanks for the explanation
146 2021-12-22T16:06:04  *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
147 2021-12-22T16:10:52  *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has quit IRC (Quit: aллилѹіа!)
148 2021-12-22T16:13:22  *** grettke <grettke!~grettke@184.62.226.206> has joined #bitcoin-core-dev
149 2021-12-22T16:14:03  *** jespada <jespada!~jespada@87.74.33.157> has quit IRC (Ping timeout: 256 seconds)
150 2021-12-22T16:14:31  *** grettke <grettke!~grettke@184.62.226.206> has quit IRC (Read error: Connection reset by peer)
151 2021-12-22T16:17:13  *** jespada <jespada!~jespada@87.74.33.157> has joined #bitcoin-core-dev
152 2021-12-22T16:18:45  *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has joined #bitcoin-core-dev
153 2021-12-22T16:20:33  *** arythmetic <arythmetic!~arythmeti@2605:8d80:680:c4f1:490d:4a8e:de79:f1a4> has joined #bitcoin-core-dev
154 2021-12-22T16:24:37  *** x88x88x <x88x88x!~x88x88x@149.28.53.172> has quit IRC (Ping timeout: 240 seconds)
155 2021-12-22T16:25:28  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-2893-5a12-7df9-5067.res6.spectrum.com> has joined #bitcoin-core-dev
156 2021-12-22T16:31:10  *** grettke <grettke!~grettke@184.62.226.206> has joined #bitcoin-core-dev
157 2021-12-22T16:31:55  *** x88x88x <x88x88x!~x88x88x@2001:19f0:5:39a8:5400:3ff:feb6:73cb> has joined #bitcoin-core-dev
158 2021-12-22T16:32:21  *** grettke <grettke!~grettke@184.62.226.206> has quit IRC (Read error: Connection reset by peer)
159 2021-12-22T16:41:59  *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
160 2021-12-22T16:42:40  *** erik1 <erik1!~erik@181-191-0-203.uplinkx.com.br> has joined #bitcoin-core-dev
161 2021-12-22T16:42:52  *** Guest97 <Guest97!~Guest97@181-191-0-203.uplinkx.com.br> has quit IRC (Quit: Client closed)
162 2021-12-22T16:44:18  *** kexkey <kexkey!~kexkey@static-198-54-132-89.cust.tzulo.com> has joined #bitcoin-core-dev
163 2021-12-22T16:45:25  <jamesob> Okay, it seems something has changed with how -maxtipage is handled... I wonder if any of the commandline args handling stuff has changed (in this case `args.GetIntArg`)? Because I'm passing `-maxtipage=999999999999` and by the time we hit IsIBD, its value is 0
164 2021-12-22T16:45:48  <jamesob> This wasn't the case last time I did assumeutxo functional testing a month or two ago
165 2021-12-22T16:48:13  <jamesob> Hm, wonder if it was this change: https://github.com/bitcoin/bitcoin/commit/4343f114cc661cf031ec915538c11b9b030e2e15#diff-19427b0dd1a791adc728c82e88f267751ba4f1c751e19262cac03cccd2822216L597-R595
166 2021-12-22T16:51:45  *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
167 2021-12-22T16:51:55  *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
168 2021-12-22T16:53:56  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
169 2021-12-22T16:54:26  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
170 2021-12-22T16:55:31  *** arythmetic <arythmetic!~arythmeti@2605:8d80:680:c4f1:490d:4a8e:de79:f1a4> has quit IRC (Remote host closed the connection)
171 2021-12-22T16:56:16  *** geyaeb <geyaeb!~geyaeb@gateway/tor-sasl/geyaeb> has quit IRC (Remote host closed the connection)
172 2021-12-22T16:59:19  <jamesob> Ah yep, that was it. The value I'd been passing in the test script was too large for int64; old code I guess interpreted it as `std::numeric_limits<uint64_t>::max()`, new code gives 0. Little concerning that we don't warn on the incompatibility
173 2021-12-22T16:59:27  *** geyaeb <geyaeb!~geyaeb@gateway/tor-sasl/geyaeb> has joined #bitcoin-core-dev
174 2021-12-22T17:00:39  *** arythmetic <arythmetic!~arythmeti@38.112.106.99> has joined #bitcoin-core-dev
175 2021-12-22T17:01:26  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
176 2021-12-22T17:01:48  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
177 2021-12-22T17:06:17  *** x88x88x <x88x88x!~x88x88x@2001:19f0:5:39a8:5400:3ff:feb6:73cb> has quit IRC (Ping timeout: 240 seconds)
178 2021-12-22T17:09:24  *** tla2k21 <tla2k21!~tla2k21@gateway/tor-sasl/tla2k21> has quit IRC (Remote host closed the connection)
179 2021-12-22T17:09:37  *** tla2k21 <tla2k21!~tla2k21@gateway/tor-sasl/tla2k21> has joined #bitcoin-core-dev
180 2021-12-22T17:13:02  *** jb55 <jb55!~jb55@user/jb55> has joined #bitcoin-core-dev
181 2021-12-22T17:21:44  <MarcoFalke> jamesob: Integer overflow inside atoi is UB or at least unspecified behavior, last time I checked
182 2021-12-22T17:22:38  *** x88x88x <x88x88x!~x88x88x@149.28.53.172> has joined #bitcoin-core-dev
183 2021-12-22T17:22:49  <MarcoFalke> That is: Parsing 999999999999 can give you any value (it doesn't have to be 0 or max or 999999999999 mod max)
184 2021-12-22T17:23:55  <MarcoFalke> jamesob: It is also not used in consensus code, so this is not a consensus change
185 2021-12-22T17:24:39  <jamesob> this is not consensus? https://github.com/bitcoin/bitcoin/pull/20452/files#diff-1db27ed1bfbf61ea0fe64447413ef9f24238be710e7ca4ae9c7bc7a5c994eca0L72-R72
186 2021-12-22T17:26:01  <jamesob> so here's the tricky thing: our atoi64 wasn't actually using atoi, but strtoll - for which oveflow behavior is well defined: "The strtol() function returns the result of the conversion, unless the value would underflow or overflow. If an underflow occurs, strtol() returns LONG_MIN. If an overflow occurs, strtol() returns LONG_MAX."
187 2021-12-22T17:26:27  <jamesob> ("The strtoll() function works just like the strtol() function but returns a long long integer value.")
188 2021-12-22T17:28:10  <MarcoFalke> Yeah, not consensus. Could be used by bitcoin-util or some RPC function.
189 2021-12-22T17:29:40  <jamesob> Phew
190 2021-12-22T17:29:58  <MarcoFalke> Oh, I wasn't aware it is safe and saturating to produce an overflow. Still, an explicit error would be better than silent saturation.
191 2021-12-22T17:32:46  <jamesob> Right... I think we should implement either full backwards compatibility to strtoll or an explicit error
192 2021-12-22T17:36:52  <luke-jr> idk, being able to put 9999999999999 is convenient :p
193 2021-12-22T17:37:09  <luke-jr> depends on the context it's used I suppose
194 2021-12-22T17:37:13  <jamesob> luke-jr: I certainly thought so haha
195 2021-12-22T17:37:34  <jamesob> but I mean the point is that IMO (even if it's a minor issue) we shouldn't change that behavior implicitly
196 2021-12-22T17:38:23  <sipa> It was an unintended behavior change; such things should be caught during review.
197 2021-12-22T17:38:35  <sipa> Whether the change is desirable or not, it shouldn't be made unintentionally.
198 2021-12-22T17:41:34  <MarcoFalke> for bitcoin-tx it was broken either way (with or without overflow), already fixed in #23227
199 2021-12-22T17:41:35  <gribble> https://github.com/bitcoin/bitcoin/issues/23227 | bitcoin-tx: Avoid treating integer overflow as OP_0 by MarcoFalke · Pull Request #23227 · bitcoin/bitcoin · GitHub
200 2021-12-22T17:42:23  <MarcoFalke> Same for rest, also fixed (#23213)
201 2021-12-22T17:42:25  <gribble> https://github.com/bitcoin/bitcoin/issues/23213 | rest: Return error when header count is not integral by MarcoFalke · Pull Request #23213 · bitcoin/bitcoin · GitHub
202 2021-12-22T17:42:43  <MarcoFalke> I think arg parsing is the only place remaining that is affected by odd behavior
203 2021-12-22T17:43:22  <MarcoFalke> If saturation is something that people rely on, we should have a test for this
204 2021-12-22T17:43:51  <MarcoFalke> *should have had
205 2021-12-22T17:44:58  <MarcoFalke> For a quick fix I expect saturation to be easier to re-add. Still, (long term) I'd prefer InitError on startup
206 2021-12-22T17:46:44  <jamesob> I'll add saturation in the PR
207 2021-12-22T17:48:16  <jamesob> Will also create an issue to surface InitErrors if we don't already have one
208 2021-12-22T17:48:20  <luke-jr> MarcoFalke: kinda hard to remember maxint64's value tho; maybe if we also parse "inf" or something? :/
209 2021-12-22T17:48:35  <luke-jr> or "max" might be more correct
210 2021-12-22T17:48:58  <jamesob> luke-jr: I think just maintaining strict compatbility with the old method (strtoll) is probably the way to go
211 2021-12-22T17:49:40  <MarcoFalke> jamesob: If you add saturation, please also add a test ;)
212 2021-12-22T17:50:28  <jamesob> MarcoFalke: sure; though technically the one I already wrote should cover it, but agree that's maybe too implicit
213 2021-12-22T17:50:48  <MarcoFalke> luke-jr: I understand why you don't want to rebase this and I support your choice, but practically speaking it takes less than a few seconds for you to rebase. However, modifying the merge script will take at least a few minutes. So picking the way of least resistance should be trivial here.
214 2021-12-22T17:51:36  <jamesob> MarcoFalke: luke-jr: I think I'm missing context here... talking about same issue?
215 2021-12-22T17:51:37  <MarcoFalke> jamesob: Right, should be enough if you add one more case for negative overflow
216 2021-12-22T17:51:52  <MarcoFalke> jamesob: It is a separate thread
217 2021-12-22T17:51:57  <jamesob> gotcha
218 2021-12-22T17:52:02  <MarcoFalke> (didn't want to spam github for it)
219 2021-12-22T17:59:38  *** x88x88x <x88x88x!~x88x88x@149.28.53.172> has quit IRC (Ping timeout: 260 seconds)
220 2021-12-22T18:06:54  *** x88x88x <x88x88x!~x88x88x@149.28.53.172> has joined #bitcoin-core-dev
221 2021-12-22T18:13:23  <sipa> ha, i didn't know this: cirrus has a big bitcoin core logo on their site under "Trusted by Open Source": https://cirrus-ci.org/
222 2021-12-22T18:18:20  *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has quit IRC (Quit: aллилѹіа!)
223 2021-12-22T18:25:15  <luke-jr> MarcoFalke: perhaps, but shouldn't the merge script get fixed anyway?
224 2021-12-22T18:25:29  <luke-jr> what's very curious there, is that my PR doesn't even *touch* the "conflicted" file
225 2021-12-22T18:25:41  *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has joined #bitcoin-core-dev
226 2021-12-22T18:25:51  <MarcoFalke> Yeah, it is a GitHub bug, but they are not interested in fixing it
227 2021-12-22T18:25:54  <luke-jr> so I'm really at a loss for what's going on there
228 2021-12-22T18:26:13  <MarcoFalke> I am not going to fix the merge script, maybe someone else?
229 2021-12-22T18:26:23  <luke-jr> jamesob: we're discussing #23027
230 2021-12-22T18:26:24  <gribble> https://github.com/bitcoin/bitcoin/issues/23027 | Bugfix: Skip tests for tools not being built by luke-jr · Pull Request #23027 · bitcoin/bitcoin · GitHub
231 2021-12-22T18:26:40  <luke-jr> MarcoFalke: does the merge script care what GitHub thinks? why? O.o
232 2021-12-22T18:27:04  <MarcoFalke> Just a belt-and-suspender? Idk, I didn't write that
233 2021-12-22T18:27:10  <MarcoFalke> Or to detect GitHub malfunction?
234 2021-12-22T18:27:42  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
235 2021-12-22T18:27:43  <jamesob> luke-jr: ah,t hanks
236 2021-12-22T18:28:06  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
237 2021-12-22T18:29:17  <luke-jr> skimming through the merge script, I don't see anything that I would expect to fail :/
238 2021-12-22T18:31:28  <MarcoFalke> luke-jr: It fetches /merge from GitHub and compares it with the local one
239 2021-12-22T18:31:50  <MarcoFalke> Just run it against your pull
240 2021-12-22T18:32:15  <luke-jr> oh, and /merge doesn't exist because of github's issue :/
241 2021-12-22T18:35:39  <luke-jr> sigh, rebased it
242 2021-12-22T18:35:46  <luke-jr> do you happen to have the issue # for the github issue handy?
243 2021-12-22T18:39:23  <MarcoFalke> No, it is an email thread from June 2018
244 2021-12-22T18:39:37  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-2893-5a12-7df9-5067.res6.spectrum.com> has quit IRC (Ping timeout: 240 seconds)
245 2021-12-22T19:10:59  *** ChanServ sets mode: -b *!*@42.117.112.245
246 2021-12-22T19:13:57  *** x88x88x <x88x88x!~x88x88x@149.28.53.172> has quit IRC (Ping timeout: 240 seconds)
247 2021-12-22T19:25:57  *** x88x88x <x88x88x!~x88x88x@2001:19f0:5:39a8:5400:3ff:feb6:73cb> has joined #bitcoin-core-dev
248 2021-12-22T19:26:18  *** dviola <dviola!~diego@2803:2a00:2:f91d:76c:deb:ee80:6b4c> has joined #bitcoin-core-dev
249 2021-12-22T19:42:17  *** dviola <dviola!~diego@2803:2a00:2:f91d:76c:deb:ee80:6b4c> has left #bitcoin-core-dev (WeeChat 3.3)
250 2021-12-22T19:43:02  *** x88x88x <x88x88x!~x88x88x@2001:19f0:5:39a8:5400:3ff:feb6:73cb> has quit IRC (Ping timeout: 240 seconds)
251 2021-12-22T19:43:54  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-800a-95c0-a608-9494.res6.spectrum.com> has joined #bitcoin-core-dev
252 2021-12-22T19:51:16  *** x88x88x <x88x88x!~x88x88x@149.28.53.172> has joined #bitcoin-core-dev
253 2021-12-22T20:00:47  <jamesob> Hm, did @gribble stop reporting on opened PRs?
254 2021-12-22T20:07:52  *** lukedashjr <lukedashjr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
255 2021-12-22T20:10:37  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 240 seconds)
256 2021-12-22T20:11:06  *** lukedashjr is now known as luke-jr
257 2021-12-22T20:19:57  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 276 seconds)
258 2021-12-22T20:22:04  *** mikehu44 <mikehu44!~quassel@206.189.41.250> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
259 2021-12-22T20:27:02  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
260 2021-12-22T20:30:20  *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has joined #bitcoin-core-dev
261 2021-12-22T20:31:02  *** Guest5811 <Guest5811!~Guest58@c-24-5-204-159.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
262 2021-12-22T20:31:25  *** Guest5811 <Guest5811!~Guest58@c-24-5-204-159.hsd1.ca.comcast.net> has quit IRC (Client Quit)
263 2021-12-22T20:34:45  *** grettke <grettke!~grettke@184.62.226.206> has joined #bitcoin-core-dev
264 2021-12-22T20:39:49  *** kexkey <kexkey!~kexkey@static-198-54-132-89.cust.tzulo.com> has quit IRC (Ping timeout: 256 seconds)
265 2021-12-22T20:41:04  *** kexkey <kexkey!~kexkey@static-198-54-132-103.cust.tzulo.com> has joined #bitcoin-core-dev
266 2021-12-22T20:44:09  *** lukedashjr <lukedashjr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
267 2021-12-22T20:46:37  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 256 seconds)
268 2021-12-22T20:46:48  *** lukedashjr is now known as luke-jr
269 2021-12-22T21:04:26  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Ping timeout: 260 seconds)
270 2021-12-22T21:16:10  *** darosior <darosior!~darosior@194.36.189.246> has quit IRC (Quit: darosior)
271 2021-12-22T21:16:11  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
272 2021-12-22T21:17:59  *** darosior <darosior!~darosior@194.36.189.246> has joined #bitcoin-core-dev
273 2021-12-22T21:31:56  <dongcarl> Hey all, wondering if anyone has an idea on how best to test this functionality: https://github.com/bitcoin/bitcoin/blob/63b5dfac21613b984803347bfe81454da667016e/src/validation.cpp#L2225-L2230
274 2021-12-22T21:31:56  <dongcarl> Basically we don't want to prune past the blockfilter index's best block.
275 2021-12-22T21:31:56  <dongcarl> Thinking naively, a test would likely: 1. generate 200 blocks 2. sync the index up to
276 2021-12-22T21:32:56  <dongcarl> 200 blocks, 3. Stop the index, 4. generate another 500 blocks, 5. attempt to prune 300 blocks, 6. assert that only 200 were pruned
277 2021-12-22T21:33:30  *** arythmetic <arythmetic!~arythmeti@38.112.106.99> has quit IRC (Remote host closed the connection)
278 2021-12-22T21:34:41  <dongcarl> Okay I might have answered my own question by typing it out... 😅
279 2021-12-22T21:34:45  *** lukedashjr <lukedashjr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
280 2021-12-22T21:34:53  <_aj_> dongcarl: was trying to figure out what the subtlety was :)
281 2021-12-22T21:35:49  <dongcarl> :)
282 2021-12-22T21:37:32  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 240 seconds)
283 2021-12-22T21:38:06  *** lukedashjr is now known as luke-jr
284 2021-12-22T21:56:43  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
285 2021-12-22T22:22:37  *** Gimble <Gimble!~G1mble2@2a01:4b00:8e07:7900:e79c:6460:44ed:8423> has quit IRC (Quit: Leaving)
286 2021-12-22T23:10:30  *** Guyver2_ <Guyver2_!~Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
287 2021-12-22T23:12:49  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 256 seconds)
288 2021-12-22T23:12:51  *** Guyver2_ is now known as Guyver2
289 2021-12-22T23:16:55  *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:6834:5866:4b21:4a8b> has joined #bitcoin-core-dev
290 2021-12-22T23:17:53  *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has quit IRC (Quit: ZzzZ)
291 2021-12-22T23:19:17  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-800a-95c0-a608-9494.res6.spectrum.com> has quit IRC (Ping timeout: 240 seconds)
292 2021-12-22T23:20:50  *** grettke <grettke!~grettke@184.62.226.206> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
293 2021-12-22T23:24:37  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-4ce9-7fd7-2373-9fbb.res6.spectrum.com> has joined #bitcoin-core-dev
294 2021-12-22T23:36:04  *** grettke <grettke!~grettke@184.62.226.206> has joined #bitcoin-core-dev
295 2021-12-22T23:41:58  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-4ce9-7fd7-2373-9fbb.res6.spectrum.com> has quit IRC (Quit: jarthur)
296 2021-12-22T23:45:42  *** grettke <grettke!~grettke@184.62.226.206> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
297 2021-12-22T23:55:08  *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-4ce9-7fd7-2373-9fbb.res6.spectrum.com> has joined #bitcoin-core-dev
298 2021-12-22T23:55:55  *** grettke <grettke!~grettke@184.62.226.206> has joined #bitcoin-core-dev
299 2021-12-22T23:59:20  <luke-jr> dongcarl: did you see #21726 ?
300 2021-12-22T23:59:27  <gribble> https://github.com/bitcoin/bitcoin/issues/21726 | Improve Indices on pruned nodes via prune blockers by fjahr · Pull Request #21726 · bitcoin/bitcoin · GitHub
301 2021-12-22T23:59:45  <dongcarl> luke-jr: Did not! Will take a look