1 2022-03-31T00:00:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
  2 2022-03-31T00:00:02  <bitcoin-git> [bitcoin] jonatack opened pull request #24718: rpc: getblock/getrawtransaction/decode*/gettxout fixups (master...rpc-fixups) https://github.com/bitcoin/bitcoin/pull/24718
  3 2022-03-31T00:00:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
  4 2022-03-31T00:03:22  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
  5 2022-03-31T00:03:48  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has joined #bitcoin-core-dev
  6 2022-03-31T00:04:07  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
  7 2022-03-31T00:08:16  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has quit IRC (Ping timeout: 245 seconds)
  8 2022-03-31T00:10:53  *** An0rak <An0rak!An0rak@user/an0rak> has quit IRC (Ping timeout: 272 seconds)
  9 2022-03-31T00:18:23  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
 10 2022-03-31T00:19:10  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
 11 2022-03-31T00:35:43  *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Ping timeout: 260 seconds)
 12 2022-03-31T00:37:31  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
 13 2022-03-31T00:40:51  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
 14 2022-03-31T00:44:38  *** shesek <shesek!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
 15 2022-03-31T00:44:56  *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 240 seconds)
 16 2022-03-31T00:45:03  *** shesek <shesek!~shesek@user/shesek> has joined #bitcoin-core-dev
 17 2022-03-31T00:45:13  *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
 18 2022-03-31T00:45:46  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Remote host closed the connection)
 19 2022-03-31T00:55:49  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
 20 2022-03-31T00:59:07  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹіа!)
 21 2022-03-31T01:01:38  *** shesek <shesek!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
 22 2022-03-31T01:02:02  *** shesek <shesek!~shesek@user/shesek> has joined #bitcoin-core-dev
 23 2022-03-31T01:11:29  *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
 24 2022-03-31T01:11:34  *** jonasschnelli <jonasschnelli!~jonasschn@2a01:4f9:2a:2510::2> has joined #bitcoin-core-dev
 25 2022-03-31T01:12:22  *** core-meetingbot <core-meetingbot!~meetingbo@2a01:4f9:2a:2510::2> has joined #bitcoin-core-dev
 26 2022-03-31T01:14:11  *** pigeons_ is now known as pigeons
 27 2022-03-31T01:16:13  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Quit: 404)
 28 2022-03-31T01:17:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 29 2022-03-31T01:17:02  <bitcoin-git> [bitcoin] tristanhcole opened pull request #24719: readme: Omit phrasing; 'experimental' (master...tristanhcole-update-readme) https://github.com/bitcoin/bitcoin/pull/24719
 30 2022-03-31T01:17:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 31 2022-03-31T01:18:09  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
 32 2022-03-31T01:22:23  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
 33 2022-03-31T01:22:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 34 2022-03-31T01:22:45  <bitcoin-git> [bitcoin] tristanhcole closed pull request #24719: readme: Omit phrasing; 'experimental' (master...tristanhcole-update-readme) https://github.com/bitcoin/bitcoin/pull/24719
 35 2022-03-31T01:22:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 36 2022-03-31T01:25:24  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
 37 2022-03-31T01:25:46  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
 38 2022-03-31T01:27:15  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Quit: 404)
 39 2022-03-31T01:27:31  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 260 seconds)
 40 2022-03-31T01:33:38  *** shesek <shesek!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
 41 2022-03-31T01:34:04  *** shesek <shesek!~shesek@user/shesek> has joined #bitcoin-core-dev
 42 2022-03-31T01:36:51  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
 43 2022-03-31T01:39:52  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
 44 2022-03-31T01:40:59  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 256 seconds)
 45 2022-03-31T01:44:57  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 256 seconds)
 46 2022-03-31T01:51:04  *** shesek_ <shesek_!~shesek@user/shesek> has joined #bitcoin-core-dev
 47 2022-03-31T01:51:48  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
 48 2022-03-31T01:52:55  *** shesek <shesek!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
 49 2022-03-31T01:56:36  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 240 seconds)
 50 2022-03-31T02:01:27  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
 51 2022-03-31T02:01:46  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
 52 2022-03-31T02:05:25  *** Willtech <Willtech!~Willtech@user/Willtech> has quit IRC (Quit: Willtech)
 53 2022-03-31T02:06:04  *** Willtech <Willtech!~Willtech@user/Willtech> has joined #bitcoin-core-dev
 54 2022-03-31T02:08:43  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has joined #bitcoin-core-dev
 55 2022-03-31T02:10:32  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
 56 2022-03-31T02:13:01  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has quit IRC (Ping timeout: 240 seconds)
 57 2022-03-31T02:13:29  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Remote host closed the connection)
 58 2022-03-31T02:21:18  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
 59 2022-03-31T02:22:05  *** mikehu44 <mikehu44!~quassel@159.65.11.175> has joined #bitcoin-core-dev
 60 2022-03-31T02:22:06  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
 61 2022-03-31T02:23:35  *** pinkfl0YD <pinkfl0YD!~pinkfl0YD@106.213.98.128> has quit IRC (Ping timeout: 252 seconds)
 62 2022-03-31T02:28:21  *** mikehu44 <mikehu44!~quassel@159.65.11.175> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
 63 2022-03-31T02:29:06  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:1c3e:c153:e75f:59c3> has joined #bitcoin-core-dev
 64 2022-03-31T02:43:05  *** shesek__ <shesek__!~shesek@user/shesek> has joined #bitcoin-core-dev
 65 2022-03-31T02:44:57  *** shesek_ <shesek_!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
 66 2022-03-31T02:51:06  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
 67 2022-03-31T02:55:19  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 246 seconds)
 68 2022-03-31T02:57:08  *** nanotube <nanotube!~nanotube@user/nanotube> has quit IRC (Quit: *poof*)
 69 2022-03-31T03:09:17  *** pinkfl0YD <pinkfl0YD!~pinkfl0YD@106.213.98.128> has joined #bitcoin-core-dev
 70 2022-03-31T03:14:12  *** pinkfl0YD <pinkfl0YD!~pinkfl0YD@106.213.98.128> has quit IRC (Remote host closed the connection)
 71 2022-03-31T03:19:36  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
 72 2022-03-31T03:20:05  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
 73 2022-03-31T03:20:18  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
 74 2022-03-31T03:20:26  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 75 2022-03-31T03:21:00  *** pinkfl0YD <pinkfl0YD!~pinkfl0YD@106.213.98.128> has joined #bitcoin-core-dev
 76 2022-03-31T03:21:07  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
 77 2022-03-31T03:21:27  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
 78 2022-03-31T03:25:35  *** pinkfl0YD <pinkfl0YD!~pinkfl0YD@106.213.98.128> has quit IRC (Ping timeout: 260 seconds)
 79 2022-03-31T03:26:16  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 240 seconds)
 80 2022-03-31T03:29:38  *** shesek__ <shesek__!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
 81 2022-03-31T03:30:03  *** shesek__ <shesek__!~shesek@user/shesek> has joined #bitcoin-core-dev
 82 2022-03-31T03:31:24  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:1c3e:c153:e75f:59c3> has quit IRC (Ping timeout: 240 seconds)
 83 2022-03-31T03:37:52  *** pinkfl0YD <pinkfl0YD!~pinkfl0YD@106.213.98.128> has joined #bitcoin-core-dev
 84 2022-03-31T03:42:28  *** pinkfl0YD <pinkfl0YD!~pinkfl0YD@106.213.98.128> has quit IRC (Ping timeout: 260 seconds)
 85 2022-03-31T03:49:31  *** pinkfl0YD <pinkfl0YD!~pinkfl0YD@106.213.98.128> has joined #bitcoin-core-dev
 86 2022-03-31T03:53:50  *** pinkfl0YD <pinkfl0YD!~pinkfl0YD@106.213.98.128> has quit IRC (Client Quit)
 87 2022-03-31T04:01:11  *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
 88 2022-03-31T04:02:00  *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
 89 2022-03-31T04:02:39  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has joined #bitcoin-core-dev
 90 2022-03-31T04:18:25  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
 91 2022-03-31T04:19:16  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
 92 2022-03-31T04:32:23  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
 93 2022-03-31T04:32:43  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
 94 2022-03-31T04:35:04  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
 95 2022-03-31T04:41:18  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
 96 2022-03-31T04:45:56  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 240 seconds)
 97 2022-03-31T04:46:16  *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 240 seconds)
 98 2022-03-31T04:47:34  *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
 99 2022-03-31T05:00:06  *** rrrrrrrrrr <rrrrrrrrrr!~rrrrrrrrr@208.201.242.22> has quit IRC (Remote host closed the connection)
100 2022-03-31T05:01:18  *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
101 2022-03-31T05:05:55  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has quit IRC (Ping timeout: 260 seconds)
102 2022-03-31T05:07:27  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
103 2022-03-31T05:08:08  *** shesek__ <shesek__!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
104 2022-03-31T05:08:19  *** nanotube <nanotube!~nanotube@user/nanotube> has joined #bitcoin-core-dev
105 2022-03-31T05:08:32  *** shesek__ <shesek__!~shesek@user/shesek> has joined #bitcoin-core-dev
106 2022-03-31T05:11:22  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
107 2022-03-31T05:12:11  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
108 2022-03-31T05:19:18  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
109 2022-03-31T05:19:54  *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
110 2022-03-31T05:22:13  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
111 2022-03-31T05:23:16  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9y8hk7mf7twfp4735dkf.ipv6.telus.net> has joined #bitcoin-core-dev
112 2022-03-31T05:25:46  *** Kaizen_K_ <Kaizen_K_!~Kaizen_Ki@node-1w7jr9yi65te62u6vnj7wqa10.ipv6.telus.net> has quit IRC (Ping timeout: 245 seconds)
113 2022-03-31T05:36:12  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has joined #bitcoin-core-dev
114 2022-03-31T05:43:30  *** An0rak <An0rak!An0rak@user/an0rak> has joined #bitcoin-core-dev
115 2022-03-31T05:46:09  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
116 2022-03-31T05:46:33  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
117 2022-03-31T05:49:37  *** baldur <baldur!~baldur@pool-74-108-229-157.nycmny.fios.verizon.net> has quit IRC (Ping timeout: 240 seconds)
118 2022-03-31T05:50:12  *** baldur <baldur!~baldur@pool-74-108-229-157.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
119 2022-03-31T06:01:11  *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
120 2022-03-31T06:01:14  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
121 2022-03-31T06:10:16  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 240 seconds)
122 2022-03-31T06:20:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
123 2022-03-31T06:20:53  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/74b011bbfa3b...87dc1dc55ffa
124 2022-03-31T06:20:53  <bitcoin-git> bitcoin/master 7c9fe25 Anthony Towns: wallet: move Assert() check into constructor
125 2022-03-31T06:20:53  <bitcoin-git> bitcoin/master 2ef47ba Anthony Towns: util/check: stop using lambda for Assert/Assume
126 2022-03-31T06:20:53  <bitcoin-git> bitcoin/master 87dc1dc MarcoFalke: Merge bitcoin/bitcoin#24714: util/check: Don't use a lambda for Assert/Ass...
127 2022-03-31T06:20:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
128 2022-03-31T06:21:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
129 2022-03-31T06:21:08  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24714: util/check: Don't use a lambda for Assert/Assume (master...202203-assume) https://github.com/bitcoin/bitcoin/pull/24714
130 2022-03-31T06:21:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
131 2022-03-31T06:24:08  *** shesek__ <shesek__!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
132 2022-03-31T06:24:34  *** shesek__ <shesek__!~shesek@user/shesek> has joined #bitcoin-core-dev
133 2022-03-31T06:25:10  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9y8hk7mf7twfp4735dkf.ipv6.telus.net> has quit IRC (Remote host closed the connection)
134 2022-03-31T06:25:56  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@d162-157-52-46.abhsia.telus.net> has joined #bitcoin-core-dev
135 2022-03-31T06:26:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
136 2022-03-31T06:26:39  <bitcoin-git> [bitcoin] inclusive-coding-bot opened pull request #24720: Switch to gender neutral terms (master...switch-to-inclusive-terms) https://github.com/bitcoin/bitcoin/pull/24720
137 2022-03-31T06:26:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
138 2022-03-31T06:29:16  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
139 2022-03-31T06:29:17  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/87dc1dc55ffa...d2b4355c5868
140 2022-03-31T06:29:17  <bitcoin-git> bitcoin/master dc0774c Hennadii Stepanov: build, test: Fix test logfile name
141 2022-03-31T06:29:17  <bitcoin-git> bitcoin/master 8b517fa Hennadii Stepanov: build, refactor: Replace tabs with spaces
142 2022-03-31T06:29:17  <bitcoin-git> bitcoin/master d2b4355 MarcoFalke: Merge bitcoin/bitcoin#24715: build, test: Fix test logfile name
143 2022-03-31T06:29:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
144 2022-03-31T06:29:21  *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
145 2022-03-31T06:29:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
146 2022-03-31T06:29:34  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24715: build, test: Fix test logfile name (master...220330-testlog) https://github.com/bitcoin/bitcoin/pull/24715
147 2022-03-31T06:29:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
148 2022-03-31T06:30:10  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
149 2022-03-31T06:30:35  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
150 2022-03-31T06:30:36  <bitcoin-git> [bitcoin] fanquake closed pull request #24720: Switch to gender neutral terms (master...switch-to-inclusive-terms) https://github.com/bitcoin/bitcoin/pull/24720
151 2022-03-31T06:30:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
152 2022-03-31T06:30:36  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@d162-157-52-46.abhsia.telus.net> has quit IRC (Ping timeout: 240 seconds)
153 2022-03-31T06:33:35  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
154 2022-03-31T06:33:35  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/d2b4355c5868...a2e1590f67fc
155 2022-03-31T06:33:35  <bitcoin-git> bitcoin/master 828a094 Michael Dietz: refactor: merge ScriptPubKeyToUniv & ScriptToUniv into one function
156 2022-03-31T06:33:35  <bitcoin-git> bitcoin/master 22f25a6 Michael Dietz: refactor: prefer snake case, TxToUniv arg hashBlock renamed block_hash
157 2022-03-31T06:33:35  <bitcoin-git> bitcoin/master 8b9efeb Michael Dietz: refactor: use named args when ScriptToUniv or TxToUniv are invoked
158 2022-03-31T06:33:35  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
159 2022-03-31T06:33:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
160 2022-03-31T06:33:49  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24673: refactor: followup of remove -deprecatedrpc=addresses flag (master...22924_rebased) https://github.com/bitcoin/bitcoin/pull/24673
161 2022-03-31T06:33:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
162 2022-03-31T06:36:15  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@d162-157-52-46.abhsia.telus.net> has joined #bitcoin-core-dev
163 2022-03-31T06:37:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
164 2022-03-31T06:37:06  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a2e1590f67fc...e1e6a3386fc7
165 2022-03-31T06:37:06  <bitcoin-git> bitcoin/master 1764849 willcl-ark: doc: Speed up functional test runs using ramdisk
166 2022-03-31T06:37:06  <bitcoin-git> bitcoin/master e1e6a33 MarcoFalke: Merge bitcoin/bitcoin#24707: doc: Speed up functional test runs using ramd...
167 2022-03-31T06:37:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
168 2022-03-31T06:37:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
169 2022-03-31T06:37:21  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24707: doc: Speed up functional test runs using ramdisk (master...tmpfs-test) https://github.com/bitcoin/bitcoin/pull/24707
170 2022-03-31T06:37:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
171 2022-03-31T06:39:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
172 2022-03-31T06:39:33  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e1e6a3386fc7...c8ac7e6a6513
173 2022-03-31T06:39:33  <bitcoin-git> bitcoin/master d6bc232 brunoerg: test: -peerblockfilters without -blockfilterindex raises an error
174 2022-03-31T06:39:33  <bitcoin-git> bitcoin/master c8ac7e6 MarcoFalke: Merge bitcoin/bitcoin#24698: test: -peerblockfilters without -blockfilteri...
175 2022-03-31T06:39:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
176 2022-03-31T06:39:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
177 2022-03-31T06:39:50  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24698: test: -peerblockfilters without -blockfilterindex raises an error (master...2022-03-peerblockfilters-init-error) https://github.com/bitcoin/bitcoin/pull/24698
178 2022-03-31T06:39:50  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
179 2022-03-31T06:40:58  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@d162-157-52-46.abhsia.telus.net> has quit IRC (Ping timeout: 260 seconds)
180 2022-03-31T06:40:58  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has quit IRC (Ping timeout: 260 seconds)
181 2022-03-31T06:48:38  *** shesek__ <shesek__!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
182 2022-03-31T06:49:04  *** shesek__ <shesek__!~shesek@user/shesek> has joined #bitcoin-core-dev
183 2022-03-31T06:51:38  *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
184 2022-03-31T06:54:27  *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
185 2022-03-31T07:10:38  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
186 2022-03-31T07:12:08  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
187 2022-03-31T07:12:26  *** gnaf <gnaf!~gnaf@163-172-90-106.rev.poneytelecom.eu> has joined #bitcoin-core-dev
188 2022-03-31T07:20:39  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
189 2022-03-31T07:21:38  *** shesek__ <shesek__!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
190 2022-03-31T07:22:04  *** shesek__ <shesek__!~shesek@user/shesek> has joined #bitcoin-core-dev
191 2022-03-31T07:26:13  *** An0rak <An0rak!An0rak@user/an0rak> has quit IRC (Ping timeout: 246 seconds)
192 2022-03-31T07:26:31  *** dermoth <dermoth!~dermoth@user/dermoth> has quit IRC (Ping timeout: 250 seconds)
193 2022-03-31T07:26:34  *** emcy <emcy!~emcy@user/emcy> has quit IRC (Read error: Connection reset by peer)
194 2022-03-31T07:27:06  *** emcy <emcy!~emcy@user/emcy> has joined #bitcoin-core-dev
195 2022-03-31T07:27:20  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has joined #bitcoin-core-dev
196 2022-03-31T07:28:53  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9y8hk7mgn7ohjr3n9duz.ipv6.telus.net> has joined #bitcoin-core-dev
197 2022-03-31T07:29:05  *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
198 2022-03-31T07:39:30  *** dermoth <dermoth!~dermoth@user/dermoth> has joined #bitcoin-core-dev
199 2022-03-31T08:00:47  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
200 2022-03-31T08:02:14  *** Kaizen_K_ <Kaizen_K_!~Kaizen_Ki@d162-157-52-46.abhsia.telus.net> has joined #bitcoin-core-dev
201 2022-03-31T08:04:08  *** shesek__ <shesek__!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
202 2022-03-31T08:04:33  *** shesek__ <shesek__!~shesek@user/shesek> has joined #bitcoin-core-dev
203 2022-03-31T08:05:21  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9y8hk7mgn7ohjr3n9duz.ipv6.telus.net> has quit IRC (Ping timeout: 245 seconds)
204 2022-03-31T08:06:32  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
205 2022-03-31T08:06:43  *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
206 2022-03-31T08:07:23  *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
207 2022-03-31T08:11:21  *** hsmiths <hsmiths!uid95325@id-95325.helmsley.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
208 2022-03-31T08:11:27  *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has left #bitcoin-core-dev (Closing Window)
209 2022-03-31T08:12:06  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
210 2022-03-31T08:18:26  *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
211 2022-03-31T08:19:01  *** jonatack85 <jonatack85!jonatack@user/jonatack> has joined #bitcoin-core-dev
212 2022-03-31T08:22:51  *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 260 seconds)
213 2022-03-31T08:30:40  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
214 2022-03-31T08:31:01  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
215 2022-03-31T08:31:01  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has quit IRC (Ping timeout: 256 seconds)
216 2022-03-31T08:32:22  *** Kaizen_K_ <Kaizen_K_!~Kaizen_Ki@d162-157-52-46.abhsia.telus.net> has quit IRC (Ping timeout: 246 seconds)
217 2022-03-31T08:35:16  *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has quit IRC (Read error: Connection reset by peer)
218 2022-03-31T08:35:52  *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has joined #bitcoin-core-dev
219 2022-03-31T08:41:21  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Ping timeout: 272 seconds)
220 2022-03-31T08:45:06  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
221 2022-03-31T08:52:21  *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has quit IRC (Read error: Connection reset by peer)
222 2022-03-31T08:52:26  *** jespada_ <jespada_!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has joined #bitcoin-core-dev
223 2022-03-31T08:55:21  *** jespada_ <jespada_!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has quit IRC (Read error: Connection reset by peer)
224 2022-03-31T08:55:51  *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has joined #bitcoin-core-dev
225 2022-03-31T09:00:06  *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has quit IRC (Read error: Connection reset by peer)
226 2022-03-31T09:00:18  *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has joined #bitcoin-core-dev
227 2022-03-31T09:01:26  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
228 2022-03-31T09:01:45  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
229 2022-03-31T09:04:23  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 260 seconds)
230 2022-03-31T09:04:47  *** kexkey <kexkey!~kexkey@static-198-54-132-121.cust.tzulo.com> has quit IRC (Ping timeout: 272 seconds)
231 2022-03-31T09:06:05  *** kexkey <kexkey!~kexkey@static-198-54-132-105.cust.tzulo.com> has joined #bitcoin-core-dev
232 2022-03-31T09:15:07  *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has quit IRC (Read error: Connection reset by peer)
233 2022-03-31T09:16:00  *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has joined #bitcoin-core-dev
234 2022-03-31T09:17:29  *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has quit IRC (Read error: Connection reset by peer)
235 2022-03-31T09:17:56  *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has joined #bitcoin-core-dev
236 2022-03-31T09:21:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
237 2022-03-31T09:21:42  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c8ac7e6a6513...1a54c060b3b3
238 2022-03-31T09:21:42  <bitcoin-git> bitcoin/master 71038a1 laanwj: rpc: Fix documentation assertion for `getrawtransaction`
239 2022-03-31T09:21:42  <bitcoin-git> bitcoin/master 1a54c06 MarcoFalke: Merge bitcoin/bitcoin#24716: rpc: Fix documentation assertion for `getrawt...
240 2022-03-31T09:21:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
241 2022-03-31T09:21:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
242 2022-03-31T09:21:58  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24716: rpc: Fix documentation assertion for `getrawtransaction` (master...2022-03-rpc-getrawtransaction-assert) https://github.com/bitcoin/bitcoin/pull/24716
243 2022-03-31T09:21:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
244 2022-03-31T09:26:21  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
245 2022-03-31T09:26:32  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9y8hk7meqszmjwlf09et.ipv6.telus.net> has joined #bitcoin-core-dev
246 2022-03-31T09:26:44  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
247 2022-03-31T09:28:06  *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has quit IRC (Read error: Connection reset by peer)
248 2022-03-31T09:28:41  *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has joined #bitcoin-core-dev
249 2022-03-31T09:35:02  *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has quit IRC (Read error: Connection reset by peer)
250 2022-03-31T09:35:29  *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has joined #bitcoin-core-dev
251 2022-03-31T09:40:12  *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has quit IRC (Read error: Connection reset by peer)
252 2022-03-31T09:40:31  *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has joined #bitcoin-core-dev
253 2022-03-31T09:46:28  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 260 seconds)
254 2022-03-31T09:46:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
255 2022-03-31T09:46:57  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #24721: doc: Use DecodeTxDoc helper (master...2203-doc-rpc-raw-tx-🚁) https://github.com/bitcoin/bitcoin/pull/24721
256 2022-03-31T09:46:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
257 2022-03-31T09:50:08  *** Guest77 <Guest77!~Guest77@host-82-56-171-4.retail.telecomitalia.it> has joined #bitcoin-core-dev
258 2022-03-31T09:50:31  *** Guest77 <Guest77!~Guest77@host-82-56-171-4.retail.telecomitalia.it> has quit IRC (Client Quit)
259 2022-03-31T09:52:13  *** Willtech <Willtech!~Willtech@user/Willtech> has quit IRC (Read error: Connection reset by peer)
260 2022-03-31T09:52:18  *** Willtech_ <Willtech_!~Willtech@user/Willtech> has joined #bitcoin-core-dev
261 2022-03-31T09:52:46  *** Willtech_ is now known as Willtech
262 2022-03-31T09:57:28  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
263 2022-03-31T09:59:38  *** shesek__ <shesek__!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
264 2022-03-31T10:00:04  *** shesek__ <shesek__!~shesek@user/shesek> has joined #bitcoin-core-dev
265 2022-03-31T10:02:25  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 272 seconds)
266 2022-03-31T10:03:47  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
267 2022-03-31T10:12:23  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
268 2022-03-31T10:12:43  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
269 2022-03-31T10:15:32  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has joined #bitcoin-core-dev
270 2022-03-31T10:19:18  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
271 2022-03-31T10:19:59  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has quit IRC (Ping timeout: 260 seconds)
272 2022-03-31T10:21:24  *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 260 seconds)
273 2022-03-31T10:24:03  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
274 2022-03-31T10:26:56  *** noonien <noonien!~noonien@user/noonien> has quit IRC (Quit: The Lounge - https://thelounge.chat)
275 2022-03-31T10:27:15  *** noonien <noonien!~noonien@user/noonien> has joined #bitcoin-core-dev
276 2022-03-31T10:40:59  *** bfsfhkacjzgcytf9 <bfsfhkacjzgcytf9!~bfsfhkacj@user/bfsfhkacjzgcytf> has quit IRC (Ping timeout: 260 seconds)
277 2022-03-31T10:43:38  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9y8hk7meqszmjwlf09et.ipv6.telus.net> has quit IRC (Ping timeout: 260 seconds)
278 2022-03-31T10:49:44  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has joined #bitcoin-core-dev
279 2022-03-31T10:50:38  *** shesek__ <shesek__!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
280 2022-03-31T10:51:03  *** shesek__ <shesek__!~shesek@user/shesek> has joined #bitcoin-core-dev
281 2022-03-31T10:52:53  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
282 2022-03-31T11:02:14  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9y8hk7mfcda03vuyuiff.ipv6.telus.net> has joined #bitcoin-core-dev
283 2022-03-31T11:03:57  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
284 2022-03-31T11:04:07  *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
285 2022-03-31T11:07:08  *** shesek__ <shesek__!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
286 2022-03-31T11:07:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
287 2022-03-31T11:07:22  <bitcoin-git> [bitcoin] fanquake opened pull request #24722: build: patch around qt duplicate symbol issue (master...more_qt_nonsense) https://github.com/bitcoin/bitcoin/pull/24722
288 2022-03-31T11:07:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
289 2022-03-31T11:07:34  *** shesek__ <shesek__!~shesek@user/shesek> has joined #bitcoin-core-dev
290 2022-03-31T11:20:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
291 2022-03-31T11:20:05  <bitcoin-git> [bitcoin] fanquake pushed 16 commits to 23.x: https://github.com/bitcoin/bitcoin/compare/7d03cf632d16...c243e0835166
292 2022-03-31T11:20:05  <bitcoin-git> bitcoin/23.x 2a6fcf9 Jon Atack: init, doc: improve -onlynet help and tor/i2p documentation
293 2022-03-31T11:20:05  <bitcoin-git> bitcoin/23.x ef6a37b Jon Atack: rpc: rename getdeploymentinfo status-next to status_next
294 2022-03-31T11:20:05  <bitcoin-git> bitcoin/23.x b1646f1 Martin Zumsande: test: set segwit height back to 0 on regtest
295 2022-03-31T11:20:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
296 2022-03-31T11:20:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
297 2022-03-31T11:20:21  <bitcoin-git> [bitcoin] fanquake merged pull request #24512: 23.x backports (23.x...23.x-onlynet-help-and-doc-improvements) https://github.com/bitcoin/bitcoin/pull/24512
298 2022-03-31T11:20:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
299 2022-03-31T11:20:32  <hebasto> rc3?
300 2022-03-31T11:32:21  *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
301 2022-03-31T11:32:42  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
302 2022-03-31T11:53:01  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has quit IRC (Ping timeout: 250 seconds)
303 2022-03-31T11:54:50  <willcl_ark> Should I be able to use the `redeemScript` from a `bitcoin-cli createmultisig 1-of-4` as the signet challenge for a custom signet? Struggling to get it working like this...
304 2022-03-31T11:57:31  *** Kaizen_K_ <Kaizen_K_!~Kaizen_Ki@d162-157-52-46.abhsia.telus.net> has joined #bitcoin-core-dev
305 2022-03-31T11:59:51  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9y8hk7mfcda03vuyuiff.ipv6.telus.net> has quit IRC (Ping timeout: 260 seconds)
306 2022-03-31T12:08:59  <_aj_> willcl_ark: should start with 51 and end with 54ae? yeah, should work.
307 2022-03-31T12:10:43  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
308 2022-03-31T12:10:49  <willcl_ark> _aj_: hmmm thanks.It does indeed start and end with those chars
309 2022-03-31T12:11:04  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
310 2022-03-31T12:11:13  <_aj_> willcl_ark: (they're "1" and "of 4 CHECKMULTISIG" respectively)
311 2022-03-31T12:11:15  <provoostenator> Pre heating CPU for Guix...
312 2022-03-31T12:11:29  <willcl_ark> (I have been documenting my steps here: https://hackmd.io/KLaH9u6iTBuNokLhgJ0lnA?view=#Notes )
313 2022-03-31T12:12:08  <willcl_ark> Right! The error thrown by bitcoind when trying to mine (on a machine which only has one of the private keys imported) is "Specified sighash value does not match value stored in PSBT"
314 2022-03-31T12:12:20  <_aj_> willcl_ark: last time i tried, i had difficulty generating a private key then importing it into a wallet that i could use with the signet it was signing for -- wallets use the network magic to stop you from using your mainnet wallet on testnet, but the network magic for signet depends on the signet challenge
315 2022-03-31T12:12:22  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
316 2022-03-31T12:12:43  <_aj_> willcl_ark: update to newer master / 23.x rc, fix for that was merged a few hours ago i think
317 2022-03-31T12:13:01  <_aj_> not 23.x rc, 23.x branch; hasn't been a new rc for it yet i think
318 2022-03-31T12:13:01  <willcl_ark> oh, that woudl be nice!
319 2022-03-31T12:13:12  <willcl_ark> will try, thanks!
320 2022-03-31T12:13:35  <_aj_> https://github.com/bitcoin/bitcoin/pull/24553
321 2022-03-31T12:14:02  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
322 2022-03-31T12:16:28  *** provoostenator <provoostenator!~quassel@user/provoostenator> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
323 2022-03-31T12:17:23  <willcl_ark> Worked!
324 2022-03-31T12:17:26  <willcl_ark> thanks v. much :)
325 2022-03-31T12:18:56  *** provoostenator <provoostenator!~quassel@user/provoostenator> has joined #bitcoin-core-dev
326 2022-03-31T12:21:52  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
327 2022-03-31T12:29:41  *** provoostenator <provoostenator!~quassel@user/provoostenator> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
328 2022-03-31T12:33:46  *** provoostenator <provoostenator!~quassel@user/provoostenator> has joined #bitcoin-core-dev
329 2022-03-31T12:46:03  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
330 2022-03-31T12:50:40  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 246 seconds)
331 2022-03-31T12:56:50  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
332 2022-03-31T13:02:48  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
333 2022-03-31T13:09:13  *** Kaizen_K_ <Kaizen_K_!~Kaizen_Ki@d162-157-52-46.abhsia.telus.net> has quit IRC (Ping timeout: 246 seconds)
334 2022-03-31T13:12:19  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Ping timeout: 256 seconds)
335 2022-03-31T13:21:55  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
336 2022-03-31T13:26:23  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 260 seconds)
337 2022-03-31T13:27:22  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
338 2022-03-31T13:28:11  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
339 2022-03-31T13:28:42  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9y8hk7mdjgu7wgtidmlu.ipv6.telus.net> has joined #bitcoin-core-dev
340 2022-03-31T13:29:26  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
341 2022-03-31T13:33:54  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
342 2022-03-31T13:39:30  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
343 2022-03-31T13:46:42  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has joined #bitcoin-core-dev
344 2022-03-31T13:54:10  *** hsmiths <hsmiths!uid95325@id-95325.helmsley.irccloud.com> has joined #bitcoin-core-dev
345 2022-03-31T13:55:30  <laanwj> going to tag rc3 in a bit
346 2022-03-31T13:58:16  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
347 2022-03-31T13:58:16  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1a54c060b3b3...243197ba9c4b
348 2022-03-31T13:58:16  <bitcoin-git> bitcoin/master fa58427 MarcoFalke: doc: Use DecodeTxDoc helper
349 2022-03-31T13:58:16  <bitcoin-git> bitcoin/master 243197b MarcoFalke: Merge bitcoin/bitcoin#24721: doc: Use DecodeTxDoc helper
350 2022-03-31T13:58:16  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
351 2022-03-31T13:58:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
352 2022-03-31T13:58:31  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24721: doc: Use DecodeTxDoc helper (master...2203-doc-rpc-raw-tx-🚁) https://github.com/bitcoin/bitcoin/pull/24721
353 2022-03-31T13:58:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
354 2022-03-31T14:00:22  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
355 2022-03-31T14:00:46  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
356 2022-03-31T14:10:01  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
357 2022-03-31T14:14:43  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 260 seconds)
358 2022-03-31T14:15:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
359 2022-03-31T14:15:07  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to 23.x: https://github.com/bitcoin/bitcoin/compare/c243e0835166...e181e94e8663
360 2022-03-31T14:15:07  <bitcoin-git> bitcoin/23.x 2a1d3a4 laanwj: build: Bump rc to 23.0rc3
361 2022-03-31T14:15:07  <bitcoin-git> bitcoin/23.x 752c9d8 laanwj: qt: 23.0rc3 translations update
362 2022-03-31T14:15:07  <bitcoin-git> bitcoin/23.x e181e94 laanwj: doc: Update manual pages for 23.0rc3
363 2022-03-31T14:15:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
364 2022-03-31T14:15:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
365 2022-03-31T14:15:22  <bitcoin-git> [bitcoin] laanwj pushed tag v23.0rc3: https://github.com/bitcoin/bitcoin/compare/v23.0rc3
366 2022-03-31T14:15:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
367 2022-03-31T14:15:25  <laanwj> ^^
368 2022-03-31T14:15:33  <fanquake> 🚀
369 2022-03-31T14:16:24  <sipa> Boom.
370 2022-03-31T14:20:38  *** shesek__ <shesek__!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
371 2022-03-31T14:21:03  *** shesek__ <shesek__!~shesek@user/shesek> has joined #bitcoin-core-dev
372 2022-03-31T14:23:09  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has quit IRC (Remote host closed the connection)
373 2022-03-31T14:24:59  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9y8hk7mdjgu7wgtidmlu.ipv6.telus.net> has quit IRC (Ping timeout: 260 seconds)
374 2022-03-31T14:26:46  *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has quit IRC (Read error: Connection reset by peer)
375 2022-03-31T14:28:06  *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has joined #bitcoin-core-dev
376 2022-03-31T14:31:21  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
377 2022-03-31T14:32:09  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
378 2022-03-31T14:34:18  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
379 2022-03-31T14:39:10  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has joined #bitcoin-core-dev
380 2022-03-31T14:40:17  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has quit IRC (Remote host closed the connection)
381 2022-03-31T14:42:24  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
382 2022-03-31T14:45:42  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9y8hk7mdjgu7wgtidmlu.ipv6.telus.net> has joined #bitcoin-core-dev
383 2022-03-31T14:46:57  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 256 seconds)
384 2022-03-31T14:58:00  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
385 2022-03-31T15:01:31  *** Kaizen_K_ <Kaizen_K_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has joined #bitcoin-core-dev
386 2022-03-31T15:02:35  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 256 seconds)
387 2022-03-31T15:05:14  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9y8hk7mdjgu7wgtidmlu.ipv6.telus.net> has quit IRC (Ping timeout: 260 seconds)
388 2022-03-31T15:10:51  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 272 seconds)
389 2022-03-31T15:13:25  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
390 2022-03-31T15:13:47  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
391 2022-03-31T15:16:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
392 2022-03-31T15:16:37  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #24723: ci: Bump msan to clang-14 (master...2203-msan-ci-bump-🔏) https://github.com/bitcoin/bitcoin/pull/24723
393 2022-03-31T15:16:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
394 2022-03-31T15:17:39  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has joined #bitcoin-core-dev
395 2022-03-31T15:29:21  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
396 2022-03-31T15:29:35  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
397 2022-03-31T15:29:45  * stick 🖤 v23.0rc3
398 2022-03-31T15:36:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
399 2022-03-31T15:36:06  <bitcoin-git> [bitcoin] fanquake opened pull request #24724: test: fix incorrect named args in txpackage tests (master...txpackage_named_args) https://github.com/bitcoin/bitcoin/pull/24724
400 2022-03-31T15:36:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
401 2022-03-31T15:51:53  *** Kaizen_K_ <Kaizen_K_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has quit IRC (Ping timeout: 256 seconds)
402 2022-03-31T15:58:59  *** real_or_random <real_or_random!~real_or_r@user/real-or-random/x-4440763> has quit IRC (Quit: ZNC 1.8.2 - https://znc.in)
403 2022-03-31T16:00:17  *** real_or_random <real_or_random!~real_or_r@user/real-or-random/x-4440763> has joined #bitcoin-core-dev
404 2022-03-31T16:01:31  *** Guest5843 <Guest5843!~Guest58@93.100.104.234> has joined #bitcoin-core-dev
405 2022-03-31T16:05:07  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has joined #bitcoin-core-dev
406 2022-03-31T16:06:48  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
407 2022-03-31T16:11:28  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 260 seconds)
408 2022-03-31T16:18:02  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has quit IRC (Ping timeout: 260 seconds)
409 2022-03-31T16:43:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
410 2022-03-31T16:43:45  <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/243197ba9c4b...b7d78e624474
411 2022-03-31T16:43:45  <bitcoin-git> bitcoin/master aeee419 Hennadii Stepanov: wallet, refactor: Add wallet::NotifyWalletLoaded() function
412 2022-03-31T16:43:45  <bitcoin-git> bitcoin/master 0c12f01 Hennadii Stepanov: wallet: Postpone NotifyWalletLoaded() for encrypted wallets
413 2022-03-31T16:43:45  <bitcoin-git> bitcoin/master b7d78e6 Andrew Chow: Merge bitcoin/bitcoin#24711: wallet: Postpone wallet loading notification ...
414 2022-03-31T16:43:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
415 2022-03-31T16:43:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
416 2022-03-31T16:44:00  <bitcoin-git> [bitcoin] achow101 merged pull request #24711: wallet: Postpone wallet loading notification for encrypted wallets (master...220329-taproot) https://github.com/bitcoin/bitcoin/pull/24711
417 2022-03-31T16:44:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
418 2022-03-31T16:46:14  *** jarthur <jarthur!~jarthur@cpe-70-114-198-37.austin.res.rr.com> has joined #bitcoin-core-dev
419 2022-03-31T16:46:16  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has joined #bitcoin-core-dev
420 2022-03-31T16:52:55  *** gnaf <gnaf!~gnaf@163-172-90-106.rev.poneytelecom.eu> has quit IRC (Ping timeout: 260 seconds)
421 2022-03-31T16:53:06  *** gnaf <gnaf!~gnaf@163-172-90-118.rev.poneytelecom.eu> has joined #bitcoin-core-dev
422 2022-03-31T16:54:14  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
423 2022-03-31T17:01:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
424 2022-03-31T17:01:18  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #24725: 23.0: rc4 backport (23.x...2203-23rc4-🏅) https://github.com/bitcoin/bitcoin/pull/24725
425 2022-03-31T17:01:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
426 2022-03-31T17:02:10  <MarcoFalke> If ^ makes it in fast enough we could abort rc3 and put the eggs into the rc4 basket, hoping it will be the final rc?
427 2022-03-31T17:02:53  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
428 2022-03-31T17:07:24  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has quit IRC (Ping timeout: 250 seconds)
429 2022-03-31T17:09:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
430 2022-03-31T17:09:17  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #24723: ci: Bump msan to clang-14 (master...2203-msan-ci-bump-🔏) https://github.com/bitcoin/bitcoin/pull/24723
431 2022-03-31T17:09:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
432 2022-03-31T17:09:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
433 2022-03-31T17:09:41  <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b7d78e624474...1021e4cc6877
434 2022-03-31T17:09:41  <bitcoin-git> bitcoin/master 21520b9 Martin Zumsande: fuzz: add target for coinselection
435 2022-03-31T17:09:41  <bitcoin-git> bitcoin/master 1021e4c Andrew Chow: Merge bitcoin/bitcoin#24602: fuzz: add target for coinselection algorithms...
436 2022-03-31T17:09:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
437 2022-03-31T17:09:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
438 2022-03-31T17:09:55  <bitcoin-git> [bitcoin] achow101 merged pull request #24602: fuzz: add target for coinselection algorithms (master...202203_fuzz_coinselection) https://github.com/bitcoin/bitcoin/pull/24602
439 2022-03-31T17:09:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
440 2022-03-31T17:11:56  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
441 2022-03-31T17:13:40  *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
442 2022-03-31T17:16:38  *** shesek__ <shesek__!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
443 2022-03-31T17:17:04  *** shesek__ <shesek__!~shesek@user/shesek> has joined #bitcoin-core-dev
444 2022-03-31T17:20:15  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has joined #bitcoin-core-dev
445 2022-03-31T17:50:13  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has quit IRC (Ping timeout: 240 seconds)
446 2022-03-31T18:00:22  <laanwj> i don't really think it makes sense to abort rc3 now, one rc per week should be a good testing pace
447 2022-03-31T18:02:18  <laanwj> rcs being doa should imo be reserved for when something goes wrong in the build process
448 2022-03-31T18:02:42  <laanwj> not to slip in some patch last minute
449 2022-03-31T18:08:32  <jonatack85> agree (i did think we were waiting for the remaining bugfixes to be backported before rc3)
450 2022-03-31T18:08:56  <jonatack85> agree it's not doa though
451 2022-03-31T18:08:58  <laanwj> there's always more bugfixes to wait for
452 2022-03-31T18:09:05  <jonatack85> heh true
453 2022-03-31T18:09:10  <laanwj> i think it was a good idea to cut another rc
454 2022-03-31T18:09:53  <laanwj> at least the binaries should have the right name now (no more manual remame for macos)
455 2022-03-31T18:10:30  <jonatack85> yes, and anyway there is also still #24454
456 2022-03-31T18:10:32  <gribble> https://github.com/bitcoin/bitcoin/issues/24454 | tests: Calculate input weight more accurately by achow101 · Pull Request #24454 · bitcoin/bitcoin · GitHub
457 2022-03-31T18:11:15  <fanquake> I'd rather get our first (proper) rc out and hopefully have more people test it
458 2022-03-31T18:11:39  <fanquake> clearly plenty of things aren't being tested if the gui was broken for months and no-one noticed
459 2022-03-31T18:11:46  <jonatack85> yes
460 2022-03-31T18:11:59  <laanwj> the gui was broken for months?
461 2022-03-31T18:12:58  <fanquake> laanwj: #24711 is a fix for https://github.com/bitcoin-core/gui/issues/571
462 2022-03-31T18:12:59  <gribble> https://github.com/bitcoin/bitcoin/issues/24711 | wallet: Postpone wallet loading notification for encrypted wallets by hebasto · Pull Request #24711 · bitcoin/bitcoin · GitHub
463 2022-03-31T18:13:12  <jonatack85> since dec 22
464 2022-03-31T18:13:22  <jonatack85> of last year
465 2022-03-31T18:13:33  <fanquake> basically if you created a new wallet, and encrypted it, you couldn't use Bech32m
466 2022-03-31T18:13:55  <laanwj> ok, i wouldn't call that "the gui is broken" it's one specific issue in a specific condition
467 2022-03-31T18:14:35  <laanwj> still a serious issue but let's not overstate it
468 2022-03-31T18:14:58  <fanquake> Yes, although given it's one of the new exciting things for 23.0, it's very surprising nobody noticed it didn't work until now
469 2022-03-31T18:15:20  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has joined #bitcoin-core-dev
470 2022-03-31T18:15:52  <laanwj> wallet encryption seems more like a danger than something useful sometimes </rant>
471 2022-03-31T18:20:08  *** shesek__ <shesek__!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
472 2022-03-31T18:20:17  <laanwj> at least the problem was caught in the rc phase, that's what it's for
473 2022-03-31T18:20:33  *** shesek__ <shesek__!~shesek@user/shesek> has joined #bitcoin-core-dev
474 2022-03-31T18:21:00  <fanquake> indeed. it's good to get bug reports from (new) users
475 2022-03-31T18:29:01  <provoostenator> You couldn't use bech32m immedidately after creation, but you could after a restart.
476 2022-03-31T18:29:42  <sipa> "gui is broken" sounds more like the whole of bitcoin-qt is unusable
477 2022-03-31T18:29:48  <provoostenator> It's definately not a good experience if we want people to start using bech32m.
478 2022-03-31T18:30:11  <hebasto> ^^^ or wallet reload
479 2022-03-31T18:30:45  <provoostenator> No strong preference on whether we should do rc4 now.  But I'm happy to guix build it.
480 2022-03-31T18:31:50  <hebasto> rc4 could accept more bugfixes, e.g., #24726
481 2022-03-31T18:31:51  <gribble> https://github.com/bitcoin/bitcoin/issues/24726 | Cross-compiled `bitcoind -signet` silently fails on Windows · Issue #24726 · bitcoin/bitcoin · GitHub
482 2022-03-31T18:33:03  <fanquake> so is that literally "signet is broken"
483 2022-03-31T18:33:03  <laanwj> sigh
484 2022-03-31T18:33:35  <fanquake> hebasto: does it just stop after "[0%]..." ?
485 2022-03-31T18:33:36  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has quit IRC (Remote host closed the connection)
486 2022-03-31T18:33:51  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has joined #bitcoin-core-dev
487 2022-03-31T18:34:07  <hebasto> in 50% cases
488 2022-03-31T18:34:31  <hebasto> in another 50% of cases  it fails immediately
489 2022-03-31T18:35:18  <laanwj> that's really bad
490 2022-03-31T18:35:32  <sipa> That's bizarre.
491 2022-03-31T18:35:54  <fanquake> definitely only happens for cross-compiled windows?
492 2022-03-31T18:36:33  <MarcoFalke> Another compiler bug?
493 2022-03-31T18:38:04  <hebasto> ^^ that is I can say
494 2022-03-31T18:38:30  <laanwj> either that or undefined c++ behavior
495 2022-03-31T18:39:11  <laanwj> which ahppens to be compiled correctly on MSVC but faulty in mingw, but yeahh who knows, if there's not any kind of error
496 2022-03-31T18:39:59  <MarcoFalke> Does it crash in gdb.exe as well?
497 2022-03-31T18:40:02  <laanwj> might try to compile with hardening disabled (to test, not to release), it has been a source of compile bugs on windows
498 2022-03-31T18:41:07  <laanwj> i don't have windows i could try in wine though
499 2022-03-31T18:42:24  <lightlike> hebasto: does that also happen when syncing signet fresh from genesis? In the log linked in 24726, you seems to use an existing datadir synced to 99%.
500 2022-03-31T18:43:55  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Quit: Leaving...)
501 2022-03-31T18:46:00  <hebasto> lightlike: removed signet dir, and it fails immediately appr. in a half of cases
502 2022-03-31T18:46:46  <fanquake> I'm trying to recreate. cross-compiled master and running bitcoind.exe -signet under wine
503 2022-03-31T18:46:51  <fanquake> haven't seen a crash yet
504 2022-03-31T18:47:00  <lightlike> oh - i had no problems syncing signet with win 10, but will try more times if it happens only sometimes
505 2022-03-31T18:48:14  <hebasto> fwiw, currently testing on Windows 11 Pro 21H2 virtual machine
506 2022-03-31T18:49:00  <laanwj> the report was for rc2 not master (if that makes the difference it would be interesting ofc)
507 2022-03-31T18:49:25  <laanwj> slightly differnt guix env maybe
508 2022-03-31T18:50:32  <laanwj> or maybe it's not a problem in wine but only on windows 11 that points even more at a possible issue with hardening features
509 2022-03-31T18:51:10  <fanquake> have downloaded the rc2 bins to test under wine
510 2022-03-31T18:52:11  <fanquake> ok, got a crash
511 2022-03-31T18:52:24  <fanquake> wine: Unhandled page fault on read access to FFFFFFFFFFFFFFFF at address 000000014051CC65 (thread 003f), starting debugger...
512 2022-03-31T18:52:43  <laanwj> happy to see it reproduces
513 2022-03-31T18:55:40  <laanwj> and that it's apparently fixed on master 9?)
514 2022-03-31T18:59:28  <fanquake> got one with -debug, so a bit more info: https://github.com/bitcoin/bitcoin/issues/24726#issuecomment-1084989560
515 2022-03-31T19:00:59  <laanwj> #startmeeting
516 2022-03-31T19:00:59  <core-meetingbot> Meeting started Thu Mar 31 19:00:59 2022 UTC.  The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
517 2022-03-31T19:00:59  <core-meetingbot> Available commands: action commands idea info link nick
518 2022-03-31T19:01:02  <achow101> hi
519 2022-03-31T19:01:21  <fanquake> hi
520 2022-03-31T19:01:23  <sipa> hi
521 2022-03-31T19:01:24  <laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball
522 2022-03-31T19:01:26  <laanwj> morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
523 2022-03-31T19:01:28  <sipsorcery> hi
524 2022-03-31T19:01:38  <hebasto> hi
525 2022-03-31T19:01:42  <cfields> hi
526 2022-03-31T19:01:52  <laanwj> fanquake: i don't have the debug symbols handy for rc2 right now, but it should be possible to figure out where that is in the binary
527 2022-03-31T19:02:18  <fjahr> hi
528 2022-03-31T19:02:20  <laanwj> PSA: 23.0rc3 has been tagged, please start your guix builders :)
529 2022-03-31T19:02:31  <jonatack85> hi
530 2022-03-31T19:02:48  <laanwj> welcome to the weekly general bitcoin-core-dev meeting
531 2022-03-31T19:03:00  <laanwj> there have been no pre-propsed meeting topics, any last minute ones?
532 2022-03-31T19:05:23  <laanwj> ok, let's discuss high priority for review
533 2022-03-31T19:05:31  <laanwj> #topic High priority for review
534 2022-03-31T19:05:32  <core-meetingbot> topic: High priority for review
535 2022-03-31T19:05:46  <laanwj> https://github.com/bitcoin/bitcoin/projects/8 10 blockers, 1 chasing concept ACK
536 2022-03-31T19:06:06  <Murch> hi
537 2022-03-31T19:06:07  <laanwj> i'd reallly ask to review and test #22702 it would be good to get that in early in the release window
538 2022-03-31T19:06:10  <gribble> https://github.com/bitcoin/bitcoin/issues/22702 | Add allocator for node based containers by martinus · Pull Request #22702 · bitcoin/bitcoin · GitHub
539 2022-03-31T19:06:30  <jonatack85> +1 for 22702, will do
540 2022-03-31T19:06:53  <laanwj> anything to add, remove, or that is in the list and almost ready for merge?
541 2022-03-31T19:07:57  <luke-jr> #24294 should probably be in the list
542 2022-03-31T19:07:59  <gribble> https://github.com/bitcoin/bitcoin/issues/24294 | RPC: Switch getblockfrompeer back to standard param names blockhash and nodeid by luke-jr · Pull Request #24294 · bitcoin/bitcoin · GitHub
543 2022-03-31T19:08:43  *** kvaciral[m] <kvaciral[m]!~kvaciralx@2001:470:69fc:105::17b> has joined #bitcoin-core-dev
544 2022-03-31T19:09:16  <laanwj> luke-jr: added, though you have two in the list now
545 2022-03-31T19:09:56  <luke-jr> oops, wrong list. I meant the 23.0 list
546 2022-03-31T19:10:35  <luke-jr> sorry
547 2022-03-31T19:11:26  <laanwj> ok
548 2022-03-31T19:11:28  <jonatack85> luke-jr: i argued against that change in my review feedback there but agree there's something to be said for the principle of least surprise. so ~0 but in that case the developer notes about rpc argument naming should maybe be clarified
549 2022-03-31T19:11:36  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has quit IRC (Remote host closed the connection)
550 2022-03-31T19:11:53  <laanwj> i've added it to 23.0 milestone, no opinion on the change really
551 2022-03-31T19:12:11  <jonatack85> there's maybe also a question of naming consistency within an rpc, versus across rpcs
552 2022-03-31T19:12:17  <luke-jr> I kinda see it as 23.0 or not worth the effort, myself
553 2022-03-31T19:12:19  <laanwj> but agree that if it is to be changed back it needs to be before the release
554 2022-03-31T19:12:45  <laanwj> otherwise it's another breaking change
555 2022-03-31T19:13:18  *** kvaciral[m] <kvaciral[m]!~kvaciralx@2001:470:69fc:105::17b> has left #bitcoin-core-dev
556 2022-03-31T19:13:44  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
557 2022-03-31T19:14:38  <laanwj> anything else? any other topics?
558 2022-03-31T19:14:53  <jeremyrubin> hi
559 2022-03-31T19:16:05  *** kvaciral[m] <kvaciral[m]!~kvaciralx@2001:470:69fc:105::17b> has joined #bitcoin-core-dev
560 2022-03-31T19:16:16  <laanwj> there's something to be said for standardizing parameter names across RPCs, it's kind of annoying as user if every RPC has slightly different inconsistent spelling for the same thing
561 2022-03-31T19:17:00  <laanwj> it's also a lot of work and may result in breaking changes in itself if persued too obsessively, so it's more of a best effort within the other constraints thing
562 2022-03-31T19:17:48  <jeremyrubin> i am indifferent -- i don't think we have strong enough consistency in the RPCs right now that one more inconsistency hurts, if we want things to be really strongly consistent we should fix it all up in a big breaking API changes release. the worst case, IMO, is subtle small changes that might not get caught. better to just have nothing work than
563 2022-03-31T19:17:49  <jeremyrubin> for things to seem to work.
564 2022-03-31T19:18:09  <jeremyrubin> otoh, this seems like a good one since it's a reversion of an unecessary change
565 2022-03-31T19:18:23  <glozow> hi
566 2022-03-31T19:19:27  <laanwj> jeremyrubin: right, for new RPCs it makes sense to choose a parameter name already used by other RPCs for a same thing instead of trying to come up with something cleverer
567 2022-03-31T19:19:48  <laanwj> i definitely agree absolute consistency is not a goal let that be clear
568 2022-03-31T19:20:51  <laanwj> anyhow, any other topics?
569 2022-03-31T19:21:52  *** gribble <gribble!~gribble@bitcoin/bot/gribble> has quit IRC (Remote host closed the connection)
570 2022-03-31T19:22:10  <laanwj> #endmeeting
571 2022-03-31T19:22:10  <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
572 2022-03-31T19:22:10  <core-meetingbot> Meeting ended Thu Mar 31 19:22:10 2022 UTC.
573 2022-03-31T19:22:10  <core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2022/bitcoin-core-dev.2022-03-31-19.00.moin.txt
574 2022-03-31T19:26:37  <laanwj> fanquake: i suppose it also happens on rc3?
575 2022-03-31T19:26:43  *** gribble <gribble!~gribble@bitcoin/bot/gribble> has joined #bitcoin-core-dev
576 2022-03-31T19:26:44  *** ChanServ sets mode: +o gribble
577 2022-03-31T19:27:23  <fanquake> laanwj: not sure. doing a cross compile of master with mingw-w64 and gcc 10.3 to match guix, and see if it still happens
578 2022-03-31T19:28:03  <fanquake> i would assume it would though
579 2022-03-31T19:28:48  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has joined #bitcoin-core-dev
580 2022-03-31T19:28:55  <laanwj> that's a good thing to try
581 2022-03-31T19:33:27  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has quit IRC (Ping timeout: 260 seconds)
582 2022-03-31T19:34:21  <fanquake> can't make that crash
583 2022-03-31T19:39:02  *** Guest5843 <Guest5843!~Guest58@93.100.104.234> has quit IRC (Quit: Client closed)
584 2022-03-31T19:40:58  <laanwj> interesting, so there's really something different on master
585 2022-03-31T19:42:18  <fanquake> i couldn't make the self-compiled 23.x, built with GCC 9 crash either, only the release binaries so far, so I'm leaning towards something in guix
586 2022-03-31T19:42:55  <hebasto> ^ agree
587 2022-03-31T19:43:03  <laanwj> trying freshly built 23.0rc3 bitcoind.exe -signet in wine now
588 2022-03-31T19:44:11  <laanwj> it's at block 1000, when is it supposed to crash
589 2022-03-31T19:44:25  <hebasto> at start
590 2022-03-31T19:44:36  <hebasto> try to stop and re-run it
591 2022-03-31T19:44:45  <laanwj> ok-seems that guix rc3 doesn't have the problem, then
592 2022-03-31T19:44:53  <laanwj> oh it's at restart?
593 2022-03-31T19:45:02  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
594 2022-03-31T19:45:10  <hebasto> yes
595 2022-03-31T19:45:16  <laanwj> it doesn't crash here
596 2022-03-31T19:45:39  <hebasto> with `-signet`, right?
597 2022-03-31T19:45:42  <laanwj> yes
598 2022-03-31T19:45:52  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
599 2022-03-31T19:49:02  <hebasto> hmm, our guix environment has no significant changes between rc2 and rc3
600 2022-03-31T19:49:21  *** An0rak <An0rak!An0rak@user/an0rak> has joined #bitcoin-core-dev
601 2022-03-31T19:49:46  <laanwj> same with rc2, no crash
602 2022-03-31T19:50:31  <laanwj> wine-7.4 (staging) fwiw
603 2022-03-31T19:51:01  <laanwj> let's try with ubuntu 22.04 standard wine
604 2022-03-31T19:56:51  <laanwj> ok: wine 6.0.3, fresh environment, let rc2 sync to block 1000 again, restarted, no crash
605 2022-03-31T20:01:21  <laanwj> restarted about 10 times, no crashes, i'm afraid i cannot help reproduce here
606 2022-03-31T20:04:07  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
607 2022-03-31T20:05:57  *** bytes1440000 <bytes1440000!~bytes1440@yal.riseup.net> has joined #bitcoin-core-dev
608 2022-03-31T20:06:20  <bytes1440000> I had some issues with rc2 on windows. It was crashing and I had to restart 10 times to finally use it (bitcoind and bitcoin-qt). Could not find anything in logs. Never had this issue with any release in past.
609 2022-03-31T20:06:20  <laanwj> could it depend on the processor architecture ?
610 2022-03-31T20:06:32  <bytes1440000> Ignored because it could have been a system specific issue or something wrong with windows.
611 2022-03-31T20:06:53  <bytes1440000> Can troubleshoot or provide more logs if someone can guide me.
612 2022-03-31T20:07:35  <laanwj> anyhow fanquake's report has a memory map we shoudl be able to find out where it crashes
613 2022-03-31T20:08:10  <luke-jr> laanwj: bytes1440000 is talking about the same issue?
614 2022-03-31T20:08:41  <laanwj> luke-jr: could be?
615 2022-03-31T20:08:48  <bytes1440000> luke-jr: I am not sure
616 2022-03-31T20:13:20  <laanwj> rebuilding rc2 guix to get the debug information
617 2022-03-31T20:15:32  <laanwj> as it happens semi-randomly it could be some kind of race condition, in worst case threading is broken in the guix windows env
618 2022-03-31T20:17:38  *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 260 seconds)
619 2022-03-31T20:20:43  *** bytes1440000 <bytes1440000!~bytes1440@yal.riseup.net> has left #bitcoin-core-dev
620 2022-03-31T20:23:17  <laanwj> wait… is DEBUG_LOCKORDER on for the guix build?
621 2022-03-31T20:24:11  <laanwj> i'm seeing "Enter: lock contention m_mutex, ./checkqueue.h:…" early in -debug output
622 2022-03-31T20:24:52  <jonatack85> it's no longer a build option, it's a runtime one
623 2022-03-31T20:25:18  <laanwj> seems like heavy overhead to always be doing that, i don't expect it to be the cause of the issue ofc
624 2022-03-31T20:25:35  <jonatack85> the "lock" logging category
625 2022-03-31T20:26:11  <laanwj> so for every lock it first does try_lock then lock?
626 2022-03-31T20:26:27  <laanwj> even with lock debugging disabled
627 2022-03-31T20:27:30  <jonatack85> yes
628 2022-03-31T20:28:49  <sipa> that sounds expensive; was the impact of that benchmarked?
629 2022-03-31T20:29:31  <laanwj> right, try_lock might be more expensive
630 2022-03-31T20:29:55  <laanwj> really depends on the platform
631 2022-03-31T20:29:59  <jonatack85> discussion in 22736
632 2022-03-31T20:30:45  <laanwj> i even posted that there https://github.com/bitcoin/bitcoin/pull/22736#discussion_r691277896
633 2022-03-31T20:31:22  <fanquake> It certainly looks like there was never really any benchmarking done? It's mentioned in the thread a number of times
634 2022-03-31T20:31:38  <laanwj> you didn't gate the try_lock on the debug category as i suggested
635 2022-03-31T20:31:58  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has quit IRC (Remote host closed the connection)
636 2022-03-31T20:32:34  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has joined #bitcoin-core-dev
637 2022-03-31T20:34:22  <jonatack85> initially yes, it did
638 2022-03-31T20:35:43  <laanwj> i really think we shouldn't mess with the good-weather case (simply calling ::lock) if there's no reason not to
639 2022-03-31T20:37:50  <sipa> thinking about how it's likely implemented (but i don't know exactly), i suspect that a succesful lock and succesful try_lock are very similar in performance
640 2022-03-31T20:37:58  <laanwj> our synchronization wrappers probably inline quite a lot of overhead to every lock call in any case
641 2022-03-31T20:37:58  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has quit IRC (Ping timeout: 260 seconds)
642 2022-03-31T20:38:25  <sipa> which would mean that a change like this mostly hurts in case there is contention, not so much in happy cases
643 2022-03-31T20:38:35  <laanwj> it's unnecessary though
644 2022-03-31T20:38:40  <sipa> yes
645 2022-03-31T20:38:45  <jonatack85> sipa: that was my conclusion
646 2022-03-31T20:39:06  <sipa> i'd still like to see benchmarks...
647 2022-03-31T20:39:23  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Remote host closed the connection)
648 2022-03-31T20:39:37  <jonatack85> more precisely https://github.com/bitcoin/bitcoin/pull/22736#issuecomment-902851054
649 2022-03-31T20:40:15  <laanwj> i mean this affects every single lock call in the program
650 2022-03-31T20:40:39  <laanwj> did it noticably affect binary size, for example?
651 2022-03-31T20:41:31  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has joined #bitcoin-core-dev
652 2022-03-31T20:41:47  <laanwj> anyhow, probably a distraction from the windows crash issue
653 2022-03-31T20:43:35  <laanwj> i still haven't been able to reproduce that
654 2022-03-31T20:44:40  <cfields> laanwj: fwiw, i _really_ didn't like that change either, complained at the time for a different reason here: https://github.com/bitcoin/bitcoin/pull/22904#issuecomment-930484001
655 2022-03-31T20:46:06  <laanwj> cfields: whoa
656 2022-03-31T20:46:21  <cfields> (I think we're talking about the same change, at least)
657 2022-03-31T20:46:59  <laanwj> cfields: my intuition says the same really, it's fine to have as a compile time option, this is not something that should be on by default
658 2022-03-31T20:47:39  <laanwj> would really prefer for #22904 and #22736 to be reverted
659 2022-03-31T20:47:41  <gribble> https://github.com/bitcoin/bitcoin/issues/22904 | sync, log: inline lock contention logging macro to fix duration, improve BCLog::LogMsg() by jonatack · Pull Request #22904 · bitcoin/bitcoin · GitHub
660 2022-03-31T20:47:42  <gribble> https://github.com/bitcoin/bitcoin/issues/22736 | log, sync: change lock contention from preprocessor directive to log category by jonatack · Pull Request #22736 · bitcoin/bitcoin · GitHub
661 2022-03-31T20:47:57  <jonatack85> cfields: that was the checkqueue unit tests causing a large log file because the test is *intended* to create contentions
662 2022-03-31T20:48:44  <jonatack85> see https://github.com/bitcoin/bitcoin/pull/23223
663 2022-03-31T20:49:51  <cfields> jonatack85: right, I was complaining about the contention tracking itself there, not the specific test failure.
664 2022-03-31T20:49:58  <jonatack85> yes, it was an issue with DEBUG_LOCKCONTENTION  defined as well
665 2022-03-31T20:50:03  <laanwj> even it it's unlikely to cause any issues, complicating the locking default case seems risky
666 2022-03-31T20:50:16  <laanwj> jonatack85: yes, but that was only enabled for debugging, not in production
667 2022-03-31T20:50:18  <jonatack85> the lock logging on by default in the unit tests only revealed it
668 2022-03-31T20:51:05  <laanwj> most users won't want to debug lock contention and don't need that overhead, so it makes sense to disable it in the release builds
669 2022-03-31T20:52:29  <cfields> right, the only reason I can think of that we'd want it on for release builds is if we intended to actually use it for decision making: if (contended_time > x), which would be a really nasty idea :)
670 2022-03-31T20:53:11  <laanwj> now that is the kind fo cursed idea i like to hear ! :)
671 2022-03-31T20:55:11  <jonatack85> is the suggestion is to remove it from releases while leaving as a runtime option on master?
672 2022-03-31T20:55:25  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has joined #bitcoin-core-dev
673 2022-03-31T20:56:05  <sipa> laanwj: Don't give anyone ideas, please!
674 2022-03-31T20:58:28  <laanwj> jonatack85: i think it should be a compile-time option, which is disabled unless something is passed to --configure, i don't mind if it's also gated by a runtime option or not
675 2022-03-31T20:58:51  <laanwj> master or a branch shouldn't matter
676 2022-03-31T20:59:40  <cfields> I believe that's what I tried to do here, but I can't remember now what I was actually fixing at the time heh: https://github.com/bitcoin/bitcoin/pull/22904#issuecomment-930486533
677 2022-03-31T21:00:05  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has quit IRC (Ping timeout: 252 seconds)
678 2022-03-31T21:02:11  *** larpsus <larpsus!~larpsus@yal.riseup.net> has joined #bitcoin-core-dev
679 2022-03-31T21:02:39  *** larpsus <larpsus!~larpsus@yal.riseup.net> has left #bitcoin-core-dev
680 2022-03-31T21:03:12  *** larpsus <larpsus!~larpsus@yal.riseup.net> has joined #bitcoin-core-dev
681 2022-03-31T21:03:15  <larpsus> sipa: lol
682 2022-03-31T21:03:20  <jonatack85> cfields: might compile quicker, iiuc? DEBUG_LOCKCONTENTION took a long time to build and couldn't be turned off at run time, impractical to use for development
683 2022-03-31T21:03:24  *** larpsus <larpsus!~larpsus@yal.riseup.net> has left #bitcoin-core-dev
684 2022-03-31T21:04:14  <laanwj> eeeeeekkkkkkk
685 2022-03-31T21:05:34  <cfields> jonatack85: eh, it's been a while and I've largely forgotten the details now. I'll just stay out of it and review a follow-up PR if something arises :)
686 2022-03-31T21:05:47  <laanwj> fanquake: 0x000000014051cc65: sha256d64_avx2::Transform_8way(unsigned char*, unsigned char const*) at /distsrc-base/distsrc-23.0rc2-x86_64-w64-mingw32/src/crypto/sha256_avx2.cpp:316
687 2022-03-31T21:06:18  <laanwj> this explains why i can't reproduce it; i don't have a avx2 capable CPU
688 2022-03-31T21:06:19  <cfields> OoOooh
689 2022-03-31T21:06:22  *** gnaf <gnaf!~gnaf@163-172-90-118.rev.poneytelecom.eu> has quit IRC (Quit: Konversation terminated!)
690 2022-03-31T21:07:25  <sipa> You may need an AVX2 capacable CPU which does not have SHA-NI.
691 2022-03-31T21:07:26  <sipa> *capable
692 2022-03-31T21:07:50  <jonatack85> laanwj, cfields: ok
693 2022-03-31T21:18:15  <sipa> @laa
694 2022-03-31T21:18:26  <cfields> jonatack85: just had another look, yeah, looks like I moved the defines out of the header so that you only have to recompile 1 object instead of everything, and also lends itself to runtime switching. IIRC the only real downside was lost inlining for some lock operations.
695 2022-03-31T21:18:26  <sipa> laanwj: Do you know exactly what instruction it's failing on?
696 2022-03-31T21:19:09  <sipa> It wouldn't surprise me that the lost cost of inlining is worse than what is gained by doing lock instead of trylock+lock.
697 2022-03-31T21:20:08  <sipa> (because the happy path of trylock and lock both on x86 is just a memory fetch)
698 2022-03-31T21:21:04  <jonatack85> cfields: nice. I'll start with reverting for now and happy to review if you take that further.
699 2022-03-31T21:21:15  <sipa> > Unhandled page fault on read access to FFFFFFFFFFFFFFFF at address 000000014051CC65
700 2022-03-31T21:22:05  <cfields> sipa: I don't disagree about the cost, but there's so much fluff in our locking I think there's ~0 chance it currently compiles down to a fetch.
701 2022-03-31T21:22:43  <sipa> Easy to find out.
702 2022-03-31T21:23:44  <laanwj> sipa: vmovdqa %ymm4, 0x260(%rsp)
703 2022-03-31T21:24:19  <sipa> heh, that's just copying a variable from the stack
704 2022-03-31T21:24:29  <sipa> so... stack underflow?
705 2022-03-31T21:24:50  <cfields> sure that's the crashing thread?
706 2022-03-31T21:26:15  <laanwj> could it be a misalignment or something
707 2022-03-31T21:26:35  <laanwj> misaligned stack pointer, it would explain the chance element
708 2022-03-31T21:28:42  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
709 2022-03-31T21:29:52  <laanwj> nah there's other vmovdqa instructions in the function as well, why would it choose this one to crash
710 2022-03-31T21:33:09  <sipa> this is in the output producing part of Transform_8way
711 2022-03-31T21:33:20  <sipa> the only memory that should be accessing is the output
712 2022-03-31T21:33:23  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 272 seconds)
713 2022-03-31T21:33:25  <sipa> which it can't assume is aligned
714 2022-03-31T21:34:39  <laanwj> the other vmovdqa instructions involve other registers or rip-relative addressing, this is the first stack relative one
715 2022-03-31T21:35:10  <sipa> But why would it be copying anything to the stack in the first place. It should be accessing the output.
716 2022-03-31T21:35:53  <sipa> And it's not an alignment problem I think... 0xFFFFFFFFFFFFFFFF actually sounds like a bogus address being addressed.
717 2022-03-31T21:35:56  <laanwj> i don't know it's likely a compiler bug, we haven't seen this on other platforms
718 2022-03-31T21:36:41  <laanwj> i don't know enough about wine error reporting to know if that message is really showing an address or it doesn't know what to do with avx2 instructions
719 2022-03-31T21:36:53  <sipa> Fair.
720 2022-03-31T21:36:56  <cfields> fanquake: ^^ how's that clang+mingtw work coming along? :)
721 2022-03-31T21:37:15  <cfields> *mingw
722 2022-03-31T21:37:45  <laanwj> getting 0xFFFFFFFFFFFFFFFF exactly on a %esp+0x260 access would be pretty unlikely as well :)
723 2022-03-31T21:38:20  <sipa> Yeah, indeed.
724 2022-03-31T21:38:38  <laanwj> i think it's writing to a stack temporary (spilling)
725 2022-03-31T21:43:28  <sipa> The x86_64 ABI requires %sp+8 to be 16-byte aligned on entry/exit of functions.
726 2022-03-31T21:43:38  <laanwj> the ABI defines the stack should be 16-byte aligned on windows at function calls, is this enough? ymms are 256 bits? but i don't know the alignment requirements
727 2022-03-31T21:43:49  <laanwj> oh, %sp+8?
728 2022-03-31T21:44:08  <sipa> ymms are 256 bits and require 16-byte alignment.
729 2022-03-31T21:44:25  <sipa> oh, or maybe even 32-byte alignment
730 2022-03-31T21:44:30  <laanwj> it pushes %r12, %rbx, then subtracts 0x338 from %rsp
731 2022-03-31T21:44:48  <laanwj> (at function prolog)
732 2022-03-31T21:45:32  <sipa> yeah, it needs 32-byte alignment
733 2022-03-31T21:45:56  <laanwj> 50 50 then :)
734 2022-03-31T21:50:30  <laanwj> here's the entire disassembly of the function: https://gist.github.com/laanwj/95d97cd218d99c68c1437115e0db9394
735 2022-03-31T21:52:53  <sipa> could it be some inconsistent ABI issue?
736 2022-03-31T21:53:12  <sipa> -mavx2 code expecting higher alignment of stack pointers, e.g.
737 2022-03-31T21:54:52  <laanwj> but i think we found the compiler bug: it runs out of registers, spills to the stack using vmovdqa, and forgets it cannot make a 32-byte alignment assumption
738 2022-03-31T21:54:54  <laanwj> right
739 2022-03-31T21:55:35  <sipa> right, that sounds like a plausible explanation
740 2022-03-31T21:58:00  <laanwj> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54412 an ancient bug report about avx which is still open
741 2022-03-31T21:58:54  <laanwj> i think we'll want to avoid using 256 bit types on windows
742 2022-03-31T21:59:00  <sipa> that looks like it could be it
743 2022-03-31T21:59:23  <sipa> easy to just #ifdef out the avx2 logic on win
744 2022-03-31T22:00:09  *** shesek__ <shesek__!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
745 2022-03-31T22:00:17  <laanwj> at least for mingw, apparently MSVC is ok
746 2022-03-31T22:00:34  *** shesek__ <shesek__!~shesek@user/shesek> has joined #bitcoin-core-dev
747 2022-03-31T22:00:59  <sipa> may just be that the avx2 detection or compilation doesn't work in the first place on msvc?
748 2022-03-31T22:01:24  <sipa> (but sure, no reason to expect this bug exists on MSVC as well)
749 2022-03-31T22:02:05  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has joined #bitcoin-core-dev
750 2022-03-31T22:04:55  <laanwj> right, i don't know
751 2022-03-31T22:06:36  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has quit IRC (Ping timeout: 245 seconds)
752 2022-03-31T22:07:26  <cfields> laanwj: that gcc bug report you linked mentions that it's not a problem if __m256i's are passed around via const ref, which we don't do.
753 2022-03-31T22:07:51  <cfields> I'm not suggesting we make that change, but we might be able to use it to verify if we're affected by that bug or not.
754 2022-03-31T22:09:30  <laanwj> please
755 2022-03-31T22:10:06  <laanwj> oh to verify, yeah sure
756 2022-03-31T22:10:30  <laanwj> but i really don't want some brittle workaround, it's not that important
757 2022-03-31T22:10:48  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Remote host closed the connection)
758 2022-03-31T22:10:50  <laanwj> newer systems will have SHANI and others will fall back to some other optimized sha256 implementation
759 2022-03-31T22:11:11  <jonatack85> cfields: this one? "As a workaround, one can either use __attribute__((always_inline)) for *all* the functions accepting __m256 or pass *all* arguments by const-ref. Const-ref arguments are passed correctly."
760 2022-03-31T22:11:34  <laanwj> cfields: i also don't think that considers register spilling
761 2022-03-31T22:14:01  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
762 2022-03-31T22:17:08  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹіа!)
763 2022-03-31T22:17:46  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
764 2022-03-31T22:19:38  <sipa> the shani code uses only 128bit registers afaik
765 2022-03-31T22:19:45  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Remote host closed the connection)
766 2022-03-31T22:20:16  <cfields> jonatack85: right
767 2022-03-31T22:22:34  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Ping timeout: 246 seconds)
768 2022-03-31T22:24:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
769 2022-03-31T22:24:38  <bitcoin-git> [bitcoin] laanwj opened pull request #24727: build: Disable AVX2 code path on mingw builds (master...2022-03-windows-noavx2) https://github.com/bitcoin/bitcoin/pull/24727
770 2022-03-31T22:24:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
771 2022-03-31T22:25:20  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has quit IRC (Remote host closed the connection)
772 2022-03-31T22:25:55  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has joined #bitcoin-core-dev
773 2022-03-31T22:26:18  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:a9cc:44af:baaa:f1dc> has joined #bitcoin-core-dev
774 2022-03-31T22:27:11  <cfields> laanwj: from your asm dump it looks like all of those calls are inlined already anyway, so agreed that wouldn't change the spilling.
775 2022-03-31T22:28:10  <laanwj> sipa: yep, also verified that
776 2022-03-31T22:28:22  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has quit IRC (Remote host closed the connection)
777 2022-03-31T22:28:37  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has joined #bitcoin-core-dev
778 2022-03-31T22:33:25  <reardencode> Is there a way in PSBT to encode a position or ordering of signatures, or is it expected that the finalizer will (if needed for a particular script) do O(n^2) sig verifications to get the sigs in the right order (when order matters)?
779 2022-03-31T22:34:08  *** surveillancechai <surveillancechai!~surveilla@garza.riseup.net> has joined #bitcoin-core-dev
780 2022-03-31T22:34:11  <surveillancechai> bitcoin, privacy, censorship, monero etc. love that altcoiners still would comeback, contribute and use bitcoin if bitcoin developers care about privacy at protocol level
781 2022-03-31T22:34:12  <sipa> @reardencode It can just look at the order of keys in the script?
782 2022-03-31T22:34:20  <surveillancechai> https://nitter.net/stephanlivera/status/1509240817319387145
783 2022-03-31T22:34:33  *** surveillancechai <surveillancechai!~surveilla@garza.riseup.net> has left #bitcoin-core-dev
784 2022-03-31T22:36:13  <laanwj> cfields: right, the problem doesn't arise with function arguments in our case
785 2022-03-31T22:36:23  <reardencode> @sipa "just look at the order" meaning try verify(sig, pubkey) for each sig for each pubkey?
786 2022-03-31T22:36:50  <laanwj> cfields: it's kind of disappointing, if they'd use the non-aligned store it'd maybe fractionally slower but at least not crash
787 2022-03-31T22:37:16  <sipa> @reardencode No. The script has pubkeys in a particular order. The PSBT has a map from keys to sigs. The finalizer just needs to emit the sigs in the order implied by their corresponding keys.
788 2022-03-31T22:37:54  <reardencode> @sipa ah, thank you! I was not seeing that the partial signatures are a map!
789 2022-03-31T22:39:26  <cfields> laanwj: yeah, i was just reading up on -mavx256-split-unaligned-store, thinking toggling that on/off might change the heuristic used to decide on aligned/unaligned. But even if it did work, that'd just be more voodoo to rely on.
790 2022-03-31T22:39:39  *** Victorsueca <Victorsueca!~Victorsue@user/victorsueca> has quit IRC (Ping timeout: 260 seconds)
791 2022-03-31T22:47:22  <laanwj> cfields: it's intersting that such a flag exists at all
792 2022-03-31T22:48:30  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
793 2022-03-31T22:48:57  <sipa> my entirely uninformed guess is that that flag wouldn't do anything, because this is a store which GCC (for better of worse) considers to be aligned
794 2022-03-31T22:51:56  <laanwj> maybe gcc got 'smarter' about alignment in newer versions explaining why it turns up now
795 2022-03-31T22:51:58  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has quit IRC (Remote host closed the connection)
796 2022-03-31T22:52:09  *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
797 2022-03-31T22:52:34  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has joined #bitcoin-core-dev
798 2022-03-31T22:54:17  *** hashfunc159a <hashfunc159a!~user@2601:5c0:c280:7090:4533:6252:8e32:243> has joined #bitcoin-core-dev
799 2022-03-31T22:54:36  *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 240 seconds)
800 2022-03-31T22:57:14  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has quit IRC (Ping timeout: 252 seconds)
801 2022-03-31T22:59:28  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has joined #bitcoin-core-dev
802 2022-03-31T23:24:30  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
803 2022-03-31T23:29:07  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Ping timeout: 260 seconds)
804 2022-03-31T23:31:56  *** upekkha <upekkha!~Advanced@2a01:4f8:1c0c:49df::1> has quit IRC (Quit: upekkha)
805 2022-03-31T23:32:06  *** upekkha <upekkha!~Advanced@2a01:4f8:1c0c:49df::1> has joined #bitcoin-core-dev
806 2022-03-31T23:32:35  *** shesek_ <shesek_!~shesek@user/shesek> has joined #bitcoin-core-dev
807 2022-03-31T23:34:39  *** shesek__ <shesek__!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
808 2022-03-31T23:36:37  *** Victorsueca <Victorsueca!~Victorsue@user/victorsueca> has joined #bitcoin-core-dev
809 2022-03-31T23:43:45  *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
810 2022-03-31T23:49:09  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has quit IRC (Remote host closed the connection)
811 2022-03-31T23:49:45  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has joined #bitcoin-core-dev
812 2022-03-31T23:58:59  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has quit IRC (Ping timeout: 260 seconds)