12022-04-05T00:04:07  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹіа!)
  22022-04-05T00:06:47  *** emcy_ <emcy_!~emcy@user/emcy> has joined #bitcoin-core-dev
  32022-04-05T00:08:07  *** warren <warren!~warren@fedora/wombat/warren> has quit IRC (Ping timeout: 256 seconds)
  42022-04-05T00:08:18  *** roconnor <roconnor!~roconnor@coq/roconnor> has quit IRC (Remote host closed the connection)
  52022-04-05T00:08:47  *** b10c <b10c!~quassel@user/b10c> has quit IRC (Remote host closed the connection)
  62022-04-05T00:08:52  *** warren <warren!~warren@fedora/wombat/warren> has joined #bitcoin-core-dev
  72022-04-05T00:09:09  *** emcy <emcy!~emcy@user/emcy> has quit IRC (Write error: Connection reset by peer)
  82022-04-05T00:10:00  *** b10c <b10c!~quassel@static.33.106.217.95.clients.your-server.de> has joined #bitcoin-core-dev
  92022-04-05T00:12:39  *** pinheadmz <pinheadmz!~pinheadmz@hns-contributor.dev> has quit IRC (Ping timeout: 256 seconds)
 102022-04-05T00:13:47  *** jnewbery <jnewbery!~john@user/jnewbery> has quit IRC (Ping timeout: 256 seconds)
 112022-04-05T00:13:47  *** sdaftuar <sdaftuar!~sdaftuar@user/sdaftuar> has quit IRC (Ping timeout: 256 seconds)
 122022-04-05T00:13:47  *** _aj_ <_aj_!aj@user/aj/x-5857768> has quit IRC (Ping timeout: 256 seconds)
 132022-04-05T00:13:57  *** jnewbery <jnewbery!~john@user/jnewbery> has joined #bitcoin-core-dev
 142022-04-05T00:14:21  *** pigeons <pigeons!~pigeons@androzani.sysevolve.com> has quit IRC (Ping timeout: 256 seconds)
 152022-04-05T00:14:32  *** pinheadmz <pinheadmz!~pinheadmz@hns-contributor.dev> has joined #bitcoin-core-dev
 162022-04-05T00:15:23  *** _aj_ <_aj_!aj@azure.erisian.com.au> has joined #bitcoin-core-dev
 172022-04-05T00:15:24  *** sdaftuar <sdaftuar!~sdaftuar@user/sdaftuar> has joined #bitcoin-core-dev
 182022-04-05T00:15:46  *** pigeons <pigeons!~pigeons@androzani.sysevolve.com> has joined #bitcoin-core-dev
 192022-04-05T00:18:57  *** Jackielove4u <Jackielove4u!uid43977@user/jackielove4u> has quit IRC (Quit: Connection closed for inactivity)
 202022-04-05T00:41:56  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
 212022-04-05T00:46:17  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 248 seconds)
 222022-04-05T00:49:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 232022-04-05T00:49:48  <bitcoin-git> [bitcoin] uvhw opened pull request #24767: 23.x (master...23.x) https://github.com/bitcoin/bitcoin/pull/24767
 242022-04-05T00:49:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 252022-04-05T01:05:57  *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
 262022-04-05T01:15:05  *** bfsfhkacjzgcytf9 <bfsfhkacjzgcytf9!~bfsfhkacj@user/bfsfhkacjzgcytf> has quit IRC (Ping timeout: 246 seconds)
 272022-04-05T01:34:59  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
 282022-04-05T01:40:38  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 260 seconds)
 292022-04-05T02:09:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 302022-04-05T02:09:38  <bitcoin-git> [bitcoin] wangalan0118 opened pull request #24768: thx's (master...master) https://github.com/bitcoin/bitcoin/pull/24768
 312022-04-05T02:09:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 322022-04-05T02:11:05  *** cfields <cfields!~cfields@user/cfields> has quit IRC (Ping timeout: 256 seconds)
 332022-04-05T02:11:34  *** cfields <cfields!~cfields@user/cfields> has joined #bitcoin-core-dev
 342022-04-05T02:25:09  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Quit: 404)
 352022-04-05T02:26:12  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
 362022-04-05T02:26:18  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
 372022-04-05T02:35:14  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Read error: Connection reset by peer)
 382022-04-05T02:36:13  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 240 seconds)
 392022-04-05T02:37:01  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
 402022-04-05T02:41:14  *** gnaf_ <gnaf_!gnaf@gateway/vpn/protonvpn/gnaf> has joined #bitcoin-core-dev
 412022-04-05T02:41:18  *** gnaf <gnaf!gnaf@gateway/vpn/protonvpn/gnaf> has quit IRC (Ping timeout: 260 seconds)
 422022-04-05T02:46:34  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Remote host closed the connection)
 432022-04-05T02:48:28  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
 442022-04-05T02:53:25  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Remote host closed the connection)
 452022-04-05T02:53:45  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
 462022-04-05T02:57:11  *** CoinForensics <CoinForensics!~coinforen@user/CoinForensics> has quit IRC ()
 472022-04-05T02:57:26  *** gnaf_ <gnaf_!gnaf@gateway/vpn/protonvpn/gnaf> has quit IRC (Quit: Konversation terminated!)
 482022-04-05T03:02:35  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Remote host closed the connection)
 492022-04-05T03:02:42  *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
 502022-04-05T03:02:56  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
 512022-04-05T03:04:38  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has quit IRC (Ping timeout: 260 seconds)
 522022-04-05T03:06:00  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has joined #bitcoin-core-dev
 532022-04-05T03:18:40  *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
 542022-04-05T03:24:22  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
 552022-04-05T03:28:57  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 248 seconds)
 562022-04-05T03:46:17  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has quit IRC (Ping timeout: 246 seconds)
 572022-04-05T03:46:43  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 582022-04-05T03:47:56  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
 592022-04-05T03:49:11  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has joined #bitcoin-core-dev
 602022-04-05T03:58:25  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
 612022-04-05T04:01:02  *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
 622022-04-05T04:01:32  *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
 632022-04-05T04:02:44  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 246 seconds)
 642022-04-05T04:07:49  *** stevenroose <stevenroose!~steven@irc.roose.io> has quit IRC (Ping timeout: 256 seconds)
 652022-04-05T04:08:05  *** stevenroose <stevenroose!~steven@irc.roose.io> has joined #bitcoin-core-dev
 662022-04-05T04:09:02  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has quit IRC (Ping timeout: 246 seconds)
 672022-04-05T04:10:31  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has joined #bitcoin-core-dev
 682022-04-05T04:15:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 692022-04-05T04:15:40  <bitcoin-git> [bitcoin] fanquake closed pull request #24768: thx's (master...master) https://github.com/bitcoin/bitcoin/pull/24768
 702022-04-05T04:15:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 712022-04-05T04:16:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 722022-04-05T04:16:11  <bitcoin-git> [bitcoin] fanquake closed pull request #24767: 23.x (master...23.x) https://github.com/bitcoin/bitcoin/pull/24767
 732022-04-05T04:16:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 742022-04-05T04:31:33  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has quit IRC (Ping timeout: 260 seconds)
 752022-04-05T04:31:56  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has joined #bitcoin-core-dev
 762022-04-05T04:46:02  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has quit IRC (Remote host closed the connection)
 772022-04-05T04:46:45  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has joined #bitcoin-core-dev
 782022-04-05T04:48:00  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
 792022-04-05T04:52:09  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 248 seconds)
 802022-04-05T05:01:45  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has quit IRC (Ping timeout: 248 seconds)
 812022-04-05T05:05:10  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has joined #bitcoin-core-dev
 822022-04-05T05:28:43  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has quit IRC (Ping timeout: 260 seconds)
 832022-04-05T05:29:22  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has joined #bitcoin-core-dev
 842022-04-05T05:37:24  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
 852022-04-05T05:42:08  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 268 seconds)
 862022-04-05T05:59:38  <kalle> Can someone point me at the actual error in https://cirrus-ci.com/task/5999546579812352 ? All I see is a test case entering at the last line.
 872022-04-05T05:59:53  <kalle> This is from https://cirrus-ci.com/task/5999546579812352?logs=ci#L5066
 882022-04-05T06:00:35  * kalle realizes belatedly that those links were both the same page.  Meant https://github.com/bitcoin/bitcoin/pull/24058
 892022-04-05T06:20:51  *** dviola <dviola!~diego@user/dviola> has joined #bitcoin-core-dev
 902022-04-05T06:23:55  <_aj_> kalle: seen a bunch of those, seems to be the CI job crashing?
 912022-04-05T06:24:15  <kalle> _aj_: ahh.. wish it would stop doing that
 922022-04-05T06:27:00  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
 932022-04-05T06:28:08  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
 942022-04-05T06:40:28  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 260 seconds)
 952022-04-05T06:41:36  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
 962022-04-05T06:44:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 972022-04-05T06:44:14  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/47bac475f044...4262100b8cff
 982022-04-05T06:44:14  <bitcoin-git> bitcoin/master fa82e89 MarcoFalke: Move lint script and data file to avoid lint- prefix
 992022-04-05T06:44:14  <bitcoin-git> bitcoin/master fae211c MarcoFalke: lint: Start to use py lint scripts
1002022-04-05T06:44:14  <bitcoin-git> bitcoin/master 4262100 MarcoFalke: Merge bitcoin/bitcoin#24762: lint: Start to use py lint scripts
1012022-04-05T06:44:14  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1022022-04-05T06:44:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1032022-04-05T06:44:31  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24762:  lint: Start to use py lint scripts  (master...2204-lint-with-py-🥂) https://github.com/bitcoin/bitcoin/pull/24762
1042022-04-05T06:44:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1052022-04-05T06:47:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1062022-04-05T06:47:46  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #24751: refactor: Remove ParseHex(const char*) from public interface (master...2204-no-pointer-💴) https://github.com/bitcoin/bitcoin/pull/24751
1072022-04-05T06:47:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1082022-04-05T06:52:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1092022-04-05T06:52:43  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24755: [23.x] Further build backports (23.x...rc4_backports) https://github.com/bitcoin/bitcoin/pull/24755
1102022-04-05T06:52:43  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1112022-04-05T06:52:52  <hebasto> rc4?
1122022-04-05T06:56:43  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
1132022-04-05T07:04:57  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 248 seconds)
1142022-04-05T07:07:56  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
1152022-04-05T07:09:17  *** ronoaldo <ronoaldo!~ronoaldo@187.75.45.227> has quit IRC (Ping timeout: 246 seconds)
1162022-04-05T07:11:27  *** dunxen <dunxen!~dunxen@gateway/tor-sasl/dunxen> has quit IRC (Remote host closed the connection)
1172022-04-05T07:13:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1182022-04-05T07:13:54  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4262100b8cff...24c6b20c1430
1192022-04-05T07:13:54  <bitcoin-git> bitcoin/master fa4943e MarcoFalke: doc: Add template for empty release notes
1202022-04-05T07:13:54  <bitcoin-git> bitcoin/master 24c6b20 MarcoFalke: Merge bitcoin/bitcoin#24583: doc: Add template for empty release notes
1212022-04-05T07:13:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1222022-04-05T07:14:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1232022-04-05T07:14:10  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24583: doc: Add template for empty release notes (master...2203-docRel-🌟) https://github.com/bitcoin/bitcoin/pull/24583
1242022-04-05T07:14:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1252022-04-05T07:21:25  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
1262022-04-05T07:24:35  *** Jackielove4u <Jackielove4u!uid43977@user/jackielove4u> has joined #bitcoin-core-dev
1272022-04-05T07:28:37  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 240 seconds)
1282022-04-05T07:36:41  *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1292022-04-05T07:45:04  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
1302022-04-05T07:50:22  *** gnaf <gnaf!gnaf@gateway/vpn/protonvpn/gnaf> has joined #bitcoin-core-dev
1312022-04-05T07:52:48  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 260 seconds)
1322022-04-05T08:08:22  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
1332022-04-05T08:10:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1342022-04-05T08:10:15  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/24c6b20c1430...44e7d6d6ddad
1352022-04-05T08:10:15  <bitcoin-git> bitcoin/master 7c218da fanquake: build: specify cmake build dir for multiprocess depends build
1362022-04-05T08:10:15  <bitcoin-git> bitcoin/master 44e7d6d fanquake: Merge bitcoin/bitcoin#24754: build: specify cmake build dir for multiproce...
1372022-04-05T08:10:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1382022-04-05T08:10:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1392022-04-05T08:10:31  <bitcoin-git> [bitcoin] fanquake merged pull request #24754: build: specify cmake build dir for multiprocess depends build (master...libmultiprocess_cmake_dir) https://github.com/bitcoin/bitcoin/pull/24754
1402022-04-05T08:10:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1412022-04-05T08:21:45  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 248 seconds)
1422022-04-05T08:34:54  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
1432022-04-05T08:34:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1442022-04-05T08:34:55  <bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/44e7d6d6ddad...0baf6aded5fa
1452022-04-05T08:34:55  <bitcoin-git> bitcoin/master bc7cc57 fanquake: doc: explain why we clear CXXFLAGS with enable-debug
1462022-04-05T08:34:55  <bitcoin-git> bitcoin/master 35c3fd4 fanquake: build: stop overriding user CPPFLAGS
1472022-04-05T08:34:55  <bitcoin-git> bitcoin/master 3e2ef23 fanquake: build: stop overriding user LDFLAGS
1482022-04-05T08:34:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1492022-04-05T08:35:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1502022-04-05T08:35:11  <bitcoin-git> [bitcoin] fanquake merged pull request #24391: build: stop overriding user autoconf flags (master...stop_overriding_user_flags) https://github.com/bitcoin/bitcoin/pull/24391
1512022-04-05T08:35:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1522022-04-05T08:35:16  <fanquake> achow101 and dongcarl rejoice
1532022-04-05T08:41:29  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 248 seconds)
1542022-04-05T08:56:30  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
1552022-04-05T09:03:10  *** kexkey <kexkey!~kexkey@static-198-54-132-105.cust.tzulo.com> has quit IRC (Ping timeout: 268 seconds)
1562022-04-05T09:03:42  *** kexkey <kexkey!~kexkey@static-198-54-132-105.cust.tzulo.com> has joined #bitcoin-core-dev
1572022-04-05T09:03:44  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 246 seconds)
1582022-04-05T09:17:50  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
1592022-04-05T09:31:05  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 248 seconds)
1602022-04-05T09:46:27  <laanwj> now we wouldn't have this issue if C++ had a borrow checker https://github.com/bitcoin/bitcoin/pull/24764#issuecomment-1088393028 :)
1612022-04-05T09:46:43  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
1622022-04-05T09:51:13  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 260 seconds)
1632022-04-05T09:59:10  *** Willtech <Willtech!~Willtech@user/Willtech> has quit IRC (Read error: Connection reset by peer)
1642022-04-05T09:59:44  *** Willtech <Willtech!~Willtech@user/Willtech> has joined #bitcoin-core-dev
1652022-04-05T10:02:10  <fanquake> I'm confused by #24734.
1662022-04-05T10:02:12  <gribble> https://github.com/bitcoin/bitcoin/issues/24734 | Put lock contention logging behind `DEBUG_LOCKCONTENTION` preprocessor directive by jonatack · Pull Request #24734 · bitcoin/bitcoin · GitHub
1672022-04-05T10:02:18  <fanquake> The first two commits just seem to add includes and then move some code.
1682022-04-05T10:02:25  <fanquake> Not sure why they can't both be dropped and missing includes just added with the 3rd commit with the code change.
1692022-04-05T10:02:34  <fanquake> I've done that here, https://github.com/fanquake/bitcoin/tree/simplfied_24734, and things compile.
1702022-04-05T10:02:54  <fanquake> I don't think we should be adding unnecessary changes to PRs we might want to backport.
1712022-04-05T10:02:57  <jonatack> fanquake: i replied in the pull
1722022-04-05T10:03:47  <fanquake> I don't understand your explanation, or why the first two commits are need, if my branch works without the additional changes
1732022-04-05T10:05:42  <jonatack> fanquake: you're adding missing headers in net.h in the same commit as the primary change. those are only related because it happens that net.h was relying on headers in sync.h (see the commit message in the first commit)
1742022-04-05T10:06:17  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
1752022-04-05T10:08:37  <laanwj> i'm starting to regret we added the syscall sandbox at all
1762022-04-05T10:09:06  <laanwj> it's just unmaintainable
1772022-04-05T10:09:41  <fanquake> I'm not sure what the problem is with adding needed-for-compilation headers in the same commit as the "primary change"? That change is really the only one we care about, and that needs backporting.
1782022-04-05T10:15:47  <vasild> laanwj: yes, sure, the email addresses themselves are signed by my private key; I am stupid
1792022-04-05T10:15:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1802022-04-05T10:15:55  <bitcoin-git> [bitcoin] uvhw opened pull request #24769: Bitcoin vn (master...bitcoin-vn) https://github.com/bitcoin/bitcoin/pull/24769
1812022-04-05T10:15:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1822022-04-05T10:18:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1832022-04-05T10:18:38  <bitcoin-git> [bitcoin] fanquake closed pull request #24769: Bitcoin vn (master...bitcoin-vn) https://github.com/bitcoin/bitcoin/pull/24769
1842022-04-05T10:18:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1852022-04-05T10:18:51  <jonatack> opened a one-commit no-frills version of #24734 for backport
1862022-04-05T10:18:52  <gribble> https://github.com/bitcoin/bitcoin/issues/24734 | Put lock contention logging behind `DEBUG_LOCKCONTENTION` preprocessor directive by jonatack · Pull Request #24734 · bitcoin/bitcoin · GitHub
1872022-04-05T10:18:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1882022-04-05T10:18:54  <bitcoin-git> [bitcoin] jonatack opened pull request #24770: Put lock logging behind DEBUG_LOCKCONTENTION preprocessor directive (master...change-lock-logging-to-DEBUG_LOCKCONTENTION-one-commit) https://github.com/bitcoin/bitcoin/pull/24770
1892022-04-05T10:18:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1902022-04-05T10:19:45  <jonatack> can rebase the fixes in the original pull over after
1912022-04-05T10:22:06  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 268 seconds)
1922022-04-05T10:29:01  <fanquake> Surely we don't need 3 pulls. If there are other unrelated / uneeded (for backporting) changes in 24734, just take them out, and put them in 24757, which is already a followup
1932022-04-05T10:29:51  <fanquake> all we need in 24734 is the single code  change, that fixes the problem, and id
1942022-04-05T10:30:00  <fanquake>  *I'd say also the documentation commit
1952022-04-05T10:30:25  <fanquake> any unrelated frills / followups / changes etc can go into 24757
1962022-04-05T10:31:50  <jonatack> There are good changes in the original pull that would be worthy to merge if not backport. It doesn't make any difference whether those are open now or later, it entails a separate pull in either case
1972022-04-05T10:32:20  <jonatack> One for backport, one for the non-backported things
1982022-04-05T10:32:36  <fanquake> yea, and they will be merged, in the followup you already have open
1992022-04-05T10:35:38  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
2002022-04-05T10:41:48  <jonatack> ok updating
2012022-04-05T10:44:37  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 240 seconds)
2022022-04-05T10:45:10  *** Alina-ma- <Alina-ma-!~Alina-mal@37.252.83.224> has joined #bitcoin-core-dev
2032022-04-05T10:45:28  *** Alina-malina <Alina-malina!~Alina-mal@user/alina-malina> has quit IRC (Ping timeout: 260 seconds)
2042022-04-05T10:53:59  <fanquake> the newly opened PR should be closed
2052022-04-05T10:54:55  <fanquake> just move the unrelated changes out of 24734 and into 24757.
2062022-04-05T10:58:38  <jonatack> I've complied making the new pull 2 commits, instead of just 1 commit to ease backport.  Why does it  matter which PR is the full one and which is the backport one?
2072022-04-05T10:59:48  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
2082022-04-05T11:01:00  <fanquake> because there was no need for a new PR at all, when you could just move the unrelated changes to the followup you already had open.
2092022-04-05T11:01:17  <fanquake> I don't know what "full" one even means here. Wouldn't that be the followup that was already open, with the CI and additional changes
2102022-04-05T11:01:59  <fanquake> Ideally, we keep discussion, in the PR that's already open, rather than fragmenting it even further, and making this set of changes more spread out / confusing
2112022-04-05T11:02:10  <jonatack> What follow-up? There are only two PRs. The original one and the minimalized one.
2122022-04-05T11:03:11  <fanquake> I must be going crazy
2132022-04-05T11:03:19  <fanquake> #24734
2142022-04-05T11:03:21  <gribble> https://github.com/bitcoin/bitcoin/issues/24734 | Put lock contention logging behind `DEBUG_LOCKCONTENTION` preprocessor directive by jonatack · Pull Request #24734 · bitcoin/bitcoin · GitHub
2152022-04-05T11:03:22  <fanquake> #24757
2162022-04-05T11:03:23  <gribble> https://github.com/bitcoin/bitcoin/issues/24757 | build, ci: add `DEBUG_LOCKCONTENTION` to --enable-debug and CI by jonatack · Pull Request #24757 · bitcoin/bitcoin · GitHub
2172022-04-05T11:03:24  <fanquake> #24770
2182022-04-05T11:03:25  <gribble> https://github.com/bitcoin/bitcoin/issues/24770 | Put lock logging behind DEBUG_LOCKCONTENTION preprocessor directive by jonatack · Pull Request #24770 · bitcoin/bitcoin · GitHub
2192022-04-05T11:03:32  <fanquake> You currently have 3 PRs open
2202022-04-05T11:03:34  <jonatack> I linked to the original one in the minimal one. The original one  the non-messed-around-with reference with the correct fixes.
2212022-04-05T11:03:54  <jonatack> The other one is a draft for a different change.
2222022-04-05T11:09:06  <jonatack> These headers fixes are wholly unrelated to that draft.
2232022-04-05T11:13:28  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 260 seconds)
2242022-04-05T11:22:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2252022-04-05T11:22:54  <bitcoin-git> [bitcoin] laanwj pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/0baf6aded5fa...d492dc1cdaab
2262022-04-05T11:22:54  <bitcoin-git> bitcoin/master 31ec6ae Antoine Poinsot: script: make IsPushdataOp non-static
2272022-04-05T11:22:54  <bitcoin-git> bitcoin/master f4e289f Antoine Poinsot: script: move CheckMinimalPush from interpreter to script.h
2282022-04-05T11:22:54  <bitcoin-git> bitcoin/master 4fe2936 Antoine Poinsot: script: expose getter for CScriptNum, add a BuildScript helper
2292022-04-05T11:22:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2302022-04-05T11:23:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2312022-04-05T11:23:10  <bitcoin-git> [bitcoin] laanwj merged pull request #24147: Miniscript integration (master...updated_miniscript) https://github.com/bitcoin/bitcoin/pull/24147
2322022-04-05T11:23:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2332022-04-05T11:27:58  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
2342022-04-05T11:34:06  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 245 seconds)
2352022-04-05T11:49:28  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
2362022-04-05T11:57:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2372022-04-05T11:57:51  <bitcoin-git> [bitcoin] hebasto opened pull request #24772: refactor: Use [[maybe_unused]] attribute (master...220405-void) https://github.com/bitcoin/bitcoin/pull/24772
2382022-04-05T11:57:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2392022-04-05T11:58:03  *** Guyver2_ <Guyver2_!~Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
2402022-04-05T11:58:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2412022-04-05T11:58:24  <bitcoin-git> [bitcoin] ayush933 closed pull request #24749: test: use MiniWallet for mempool_unbroadcast.py (master...miniwallet-mempool_unbroadcast) https://github.com/bitcoin/bitcoin/pull/24749
2422022-04-05T11:58:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2432022-04-05T11:58:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2442022-04-05T11:58:39  <bitcoin-git> [bitcoin] ayush933 reopened pull request #24749: test: use MiniWallet for mempool_unbroadcast.py (master...miniwallet-mempool_unbroadcast) https://github.com/bitcoin/bitcoin/pull/24749
2452022-04-05T11:58:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2462022-04-05T11:59:09  *** Guyver2_ <Guyver2_!~Guyver@guyver2.xs4all.nl> has left #bitcoin-core-dev
2472022-04-05T11:59:51  *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
2482022-04-05T12:00:05  *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
2492022-04-05T12:00:43  *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 260 seconds)
2502022-04-05T12:00:57  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 248 seconds)
2512022-04-05T12:04:23  *** agrosant <agrosant!~agrosant@79.103.182.92.dsl.dyn.forthnet.gr> has quit IRC (Read error: Connection reset by peer)
2522022-04-05T12:04:57  *** agrosant <agrosant!~agrosant@79.103.182.92.dsl.dyn.forthnet.gr> has joined #bitcoin-core-dev
2532022-04-05T12:06:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2542022-04-05T12:06:21  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d492dc1cdaab...ee9af95f0954
2552022-04-05T12:06:21  <bitcoin-git> bitcoin/master d2ba43f Ayush Sharma: test: use MiniWallet for mempool_unbroadcast.py
2562022-04-05T12:06:21  <bitcoin-git> bitcoin/master ee9af95 MarcoFalke: Merge bitcoin/bitcoin#24749: test: use MiniWallet for mempool_unbroadcast....
2572022-04-05T12:06:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2582022-04-05T12:06:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2592022-04-05T12:06:36  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24749: test: use MiniWallet for mempool_unbroadcast.py (master...miniwallet-mempool_unbroadcast) https://github.com/bitcoin/bitcoin/pull/24749
2602022-04-05T12:06:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2612022-04-05T12:17:29  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
2622022-04-05T12:20:29  *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Quit: Connection closed)
2632022-04-05T12:27:08  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 260 seconds)
2642022-04-05T12:41:55  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
2652022-04-05T13:12:02  *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
2662022-04-05T13:36:52  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
2672022-04-05T13:39:08  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2682022-04-05T13:39:09  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ee9af95f0954...f421de5be611
2692022-04-05T13:39:09  <bitcoin-git> bitcoin/master fa9112a MarcoFalke: Remove utxo db upgrade code
2702022-04-05T13:39:09  <bitcoin-git> bitcoin/master f421de5 laanwj: Merge bitcoin/bitcoin#24236: Remove utxo db upgrade code
2712022-04-05T13:39:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2722022-04-05T13:39:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2732022-04-05T13:39:26  <bitcoin-git> [bitcoin] laanwj merged pull request #24236: Remove utxo db upgrade code (master...2202-txdbNoUpgrade) https://github.com/bitcoin/bitcoin/pull/24236
2742022-04-05T13:39:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2752022-04-05T13:39:38  *** Guest11 <Guest11!~Guest11@185.47.104.164> has joined #bitcoin-core-dev
2762022-04-05T13:40:21  *** Guest11 <Guest11!~Guest11@185.47.104.164> has quit IRC (Client Quit)
2772022-04-05T13:42:56  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
2782022-04-05T13:50:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2792022-04-05T13:50:12  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f421de5be611...fe66dad8a779
2802022-04-05T13:50:12  <bitcoin-git> bitcoin/master 19538dd Jon Atack: Add concrete steps in doc/cjdns.md to easily find a friend
2812022-04-05T13:50:12  <bitcoin-git> bitcoin/master 6a02355 Jon Atack: Add and improve informational links in doc/cjdns.md
2822022-04-05T13:50:12  <bitcoin-git> bitcoin/master fe66dad laanwj: Merge bitcoin/bitcoin#24710: Add concrete steps in doc/cjdns.md to easily ...
2832022-04-05T13:50:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2842022-04-05T13:50:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2852022-04-05T13:50:27  <bitcoin-git> [bitcoin] laanwj merged pull request #24710: Add concrete steps in doc/cjdns.md to easily find a friend (master...doc-cjdns-how-to-find-a-friend) https://github.com/bitcoin/bitcoin/pull/24710
2862022-04-05T13:50:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2872022-04-05T13:56:17  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
2882022-04-05T14:02:31  *** Alina-ma- <Alina-ma-!~Alina-mal@37.252.83.224> has quit IRC (Quit: !be back soon)
2892022-04-05T14:03:25  *** Alina-malina <Alina-malina!~Alina-mal@user/alina-malina> has joined #bitcoin-core-dev
2902022-04-05T14:19:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2912022-04-05T14:19:48  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fe66dad8a779...9ce1c506a3a5
2922022-04-05T14:19:48  <bitcoin-git> bitcoin/master 304ef73 Sjors Provoost: validation: improve connect bench logging
2932022-04-05T14:19:48  <bitcoin-git> bitcoin/master 9ce1c50 laanwj: Merge bitcoin/bitcoin#24216: validation: improve connect bench logging
2942022-04-05T14:19:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2952022-04-05T14:20:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2962022-04-05T14:20:03  <bitcoin-git> [bitcoin] laanwj merged pull request #24216: validation: improve connect bench logging (master...2022/01/bench_log) https://github.com/bitcoin/bitcoin/pull/24216
2972022-04-05T14:20:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2982022-04-05T14:39:33  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
2992022-04-05T14:50:29  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
3002022-04-05T14:55:16  *** Earnestly <Earnestly!~earnest@user/earnestly> has quit IRC (Read error: Connection reset by peer)
3012022-04-05T14:55:17  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 268 seconds)
3022022-04-05T14:59:24  *** Earnestly <Earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
3032022-04-05T15:05:26  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
3042022-04-05T15:13:10  *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Ping timeout: 268 seconds)
3052022-04-05T15:24:53  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
3062022-04-05T15:39:39  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
3072022-04-05T15:43:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3082022-04-05T15:43:52  <bitcoin-git> [bitcoin] hebasto opened pull request #24773: [POC] Enable AVX2 implementation of SHA256 for MSVC builds (master...220405-avx2) https://github.com/bitcoin/bitcoin/pull/24773
3092022-04-05T15:43:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3102022-04-05T15:57:52  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
3112022-04-05T16:13:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3122022-04-05T16:13:03  <bitcoin-git> [bitcoin] hebasto opened pull request #24774: build, refactor: Rely on `AC_DEFINE` macro (master...220405-config) https://github.com/bitcoin/bitcoin/pull/24774
3132022-04-05T16:13:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3142022-04-05T16:46:55  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
3152022-04-05T16:47:04  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
3162022-04-05T16:51:00  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 252 seconds)
3172022-04-05T17:06:13  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
3182022-04-05T17:06:37  *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
3192022-04-05T17:14:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3202022-04-05T17:14:21  <bitcoin-git> [bitcoin] hebasto opened pull request #24775: build: Do not modify `common.init.vcxproj` directly (master...220405-toolset) https://github.com/bitcoin/bitcoin/pull/24775
3212022-04-05T17:14:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3222022-04-05T17:15:13  *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
3232022-04-05T17:15:28  *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
3242022-04-05T17:37:39  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Remote host closed the connection)
3252022-04-05T17:37:59  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
3262022-04-05T17:49:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3272022-04-05T17:49:29  <bitcoin-git> [bitcoin] brunoerg opened pull request #24776: docs: update `/rest/chaininfo` doc according to `getblockchaininfo` (master...2022-04-rest-doc-improv) https://github.com/bitcoin/bitcoin/pull/24776
3282022-04-05T17:49:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3292022-04-05T18:05:50  *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 268 seconds)
3302022-04-05T18:11:14  *** TerminalTapper <TerminalTapper!~TerminalT@75.165.57.243> has joined #bitcoin-core-dev
3312022-04-05T18:26:09  <theStack> is anyone else here seeing the GitHub "Add a suggestion" button for code review comments disabled? not a big deal, a diff can be posted anyways, just wondering if I'm doing something wrong
3322022-04-05T18:27:03  <hebasto> theStack: me too
3332022-04-05T18:27:49  <hebasto> it seems the button is not active in commit-by-commit view
3342022-04-05T18:29:59  <lightlike> hasn't it been like this always/for a long time, that you'd have to got to the "Files changed" view to add suggestions?
3352022-04-05T18:30:23  <hebasto> lightlike: yeap
3362022-04-05T18:31:10  <hebasto> I mean, to see that button active :)
3372022-04-05T18:32:32  *** TerminalTapper <TerminalTapper!~TerminalT@75.165.57.243> has quit IRC (Ping timeout: 260 seconds)
3382022-04-05T18:34:18  <theStack> oh, i thought that it was also possible on the commit-by-commit view earlier (like weeks ago); good to know that it works with the "Files changed" view, i never used that one for adding comments/suggestions, but will from now on i guess
3392022-04-05T18:34:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3402022-04-05T18:34:23  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/9ce1c506a3a5...15220ec9039a
3412022-04-05T18:34:23  <bitcoin-git> bitcoin/master 2391fb7 Hennadii Stepanov: build, refactor: Add set_properties() to msvc-autogen.py
3422022-04-05T18:34:23  <bitcoin-git> bitcoin/master ba0bf79 Hennadii Stepanov: build: Do not modify `common.init.vcxproj` directly
3432022-04-05T18:34:23  <bitcoin-git> bitcoin/master 15220ec MarcoFalke: Merge bitcoin/bitcoin#24775: build: Do not modify `common.init.vcxproj` di...
3442022-04-05T18:34:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3452022-04-05T18:34:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3462022-04-05T18:34:39  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24775: build: Do not modify `common.init.vcxproj` directly (master...220405-toolset) https://github.com/bitcoin/bitcoin/pull/24775
3472022-04-05T18:34:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3482022-04-05T18:37:40  <lightlike> I also never used that view and wondered for a long time how all the other people managed to add these suggestions  :)
3492022-04-05T18:43:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3502022-04-05T18:43:42  <bitcoin-git> [bitcoin] sipa closed pull request #23995: Simplify test_runner.py a bit (master...202201_partestrun_fix) https://github.com/bitcoin/bitcoin/pull/23995
3512022-04-05T18:43:42  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3522022-04-05T18:53:20  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
3532022-04-05T18:55:00  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
3542022-04-05T18:55:28  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Client Quit)
3552022-04-05T18:57:06  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
3562022-04-05T19:10:44  *** Nekorand <Nekorand!~Random@cm-188-171-200-176.telecable.es> has joined #bitcoin-core-dev
3572022-04-05T19:12:05  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
3582022-04-05T19:19:56  *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
3592022-04-05T19:21:37  *** dvd <dvd!~dvd@nat-pool-rdu-t.redhat.com> has quit IRC (Quit: ZNC 1.7.5 - https://znc.in)
3602022-04-05T19:24:14  *** Nekorand <Nekorand!~Random@cm-188-171-200-176.telecable.es> has quit IRC (Quit: Leaving)
3612022-04-05T19:25:08  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@node-1w7jr9yi65te40puxn0mq5c1l.ipv6.telus.net> has quit IRC (Remote host closed the connection)
3622022-04-05T19:25:43  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
3632022-04-05T19:59:27  *** sjors[m] <sjors[m]!~sjorsspro@2001:470:69fc:105::1:f0d3> has joined #bitcoin-core-dev
3642022-04-05T20:04:11  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Ping timeout: 246 seconds)
3652022-04-05T20:09:09  *** provoostenator <provoostenator!~quassel@user/provoostenator> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
3662022-04-05T20:09:30  *** sjors[m] <sjors[m]!~sjorsspro@2001:470:69fc:105::1:f0d3> has quit IRC (Quit: Reconnecting)
3672022-04-05T20:09:40  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
3682022-04-05T20:09:45  *** sjors[m] <sjors[m]!~provooste@user/provoostenator> has joined #bitcoin-core-dev
3692022-04-05T20:13:27  *** sjors[m] is now known as provoostenator
3702022-04-05T20:15:44  <provoostenator> Pieter: when taproot miniscript?
3712022-04-05T20:19:47  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
3722022-04-05T20:22:24  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
3732022-04-05T20:23:18  <provoostenator> That should have been sipa; Matrix bridge bug...
3742022-04-05T20:24:05  <sipa> sjors: hmm
3752022-04-05T20:27:05  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 248 seconds)
3762022-04-05T20:29:50  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
3772022-04-05T20:42:34  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
3782022-04-05T20:43:22  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
3792022-04-05T20:48:03  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 260 seconds)
3802022-04-05T20:49:11  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Remote host closed the connection)
3812022-04-05T20:51:00  *** Guest38 <Guest38!~Guest38@2a02:908:1a7:82c0:cccf:7304:f184:7c5a> has joined #bitcoin-core-dev
3822022-04-05T21:01:31  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
3832022-04-05T21:05:16  *** Guest38 <Guest38!~Guest38@2a02:908:1a7:82c0:cccf:7304:f184:7c5a> has quit IRC (Quit: Client closed)
3842022-04-05T21:06:09  *** Kaizen_K_ <Kaizen_K_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
3852022-04-05T21:06:31  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 272 seconds)
3862022-04-05T21:07:06  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
3872022-04-05T21:11:21  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 248 seconds)
3882022-04-05T21:17:40  *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
3892022-04-05T21:40:22  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
3902022-04-05T21:44:41  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 252 seconds)
3912022-04-05T22:04:37  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 240 seconds)
3922022-04-05T22:10:21  *** gnaf <gnaf!gnaf@gateway/vpn/protonvpn/gnaf> has quit IRC (Quit: Konversation terminated!)
3932022-04-05T22:11:39  *** Kaizen_K_ <Kaizen_K_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 250 seconds)
3942022-04-05T22:15:53  *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 248 seconds)
3952022-04-05T22:24:29  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
3962022-04-05T22:29:47  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 246 seconds)
3972022-04-05T22:31:47  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
3982022-04-05T22:35:20  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
3992022-04-05T22:40:15  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 268 seconds)
4002022-04-05T22:41:42  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
4012022-04-05T22:46:35  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 272 seconds)
4022022-04-05T22:55:11  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
4032022-04-05T22:58:58  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
4042022-04-05T23:00:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4052022-04-05T23:00:34  <bitcoin-git> [bitcoin] fjahr opened pull request #24778: lint: Convert Python dead code linter test to Python (master...202204-dead-py) https://github.com/bitcoin/bitcoin/pull/24778
4062022-04-05T23:00:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4072022-04-05T23:03:41  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 268 seconds)
4082022-04-05T23:07:50  *** ronoaldo <ronoaldo!~ronoaldo@187.75.45.227> has joined #bitcoin-core-dev
4092022-04-05T23:12:43  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
4102022-04-05T23:16:57  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
4112022-04-05T23:25:05  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 246 seconds)
4122022-04-05T23:37:53  *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
4132022-04-05T23:39:36  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has joined #bitcoin-core-dev
4142022-04-05T23:47:00  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
4152022-04-05T23:49:45  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:cdd9:4917:288f:d8c7> has quit IRC (Ping timeout: 248 seconds)
4162022-04-05T23:59:23  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹіа!)