1 2022-04-13T00:04:02  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 250 seconds)
  2 2022-04-13T00:10:32  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
  3 2022-04-13T00:14:48  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 248 seconds)
  4 2022-04-13T00:16:36  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
  5 2022-04-13T00:20:56  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 250 seconds)
  6 2022-04-13T00:24:13  *** Jackielove4u <Jackielove4u!uid43977@user/jackielove4u> has quit IRC (Quit: Connection closed for inactivity)
  7 2022-04-13T00:26:45  *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
  8 2022-04-13T00:27:24  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
  9 2022-04-13T00:31:53  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 248 seconds)
 10 2022-04-13T00:33:28  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
 11 2022-04-13T00:35:10  *** ronoaldo <ronoaldo!~ronoaldo@187.75.45.227> has quit IRC (Quit: Konversation terminated!)
 12 2022-04-13T00:37:55  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 260 seconds)
 13 2022-04-13T00:42:06  *** An0rak <An0rak!An0rak@user/an0rak> has quit IRC (Ping timeout: 246 seconds)
 14 2022-04-13T00:44:16  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
 15 2022-04-13T00:48:57  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 248 seconds)
 16 2022-04-13T00:50:23  *** NorrinRadd <NorrinRadd!~username@102.67.16.112> has quit IRC (Ping timeout: 256 seconds)
 17 2022-04-13T01:14:28  *** geyaeb2 <geyaeb2!~geyaeb@gateway/tor-sasl/geyaeb> has quit IRC (Quit: WeeChat 3.4.1)
 18 2022-04-13T01:14:46  *** geyaeb <geyaeb!~geyaeb@gateway/tor-sasl/geyaeb> has joined #bitcoin-core-dev
 19 2022-04-13T01:18:02  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
 20 2022-04-13T01:22:32  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 248 seconds)
 21 2022-04-13T01:25:53  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Quit: Leaving...)
 22 2022-04-13T01:28:50  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
 23 2022-04-13T01:33:12  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 248 seconds)
 24 2022-04-13T01:34:54  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
 25 2022-04-13T01:39:22  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 250 seconds)
 26 2022-04-13T01:45:41  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
 27 2022-04-13T01:50:17  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 248 seconds)
 28 2022-04-13T01:51:52  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
 29 2022-04-13T01:52:55  *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
 30 2022-04-13T01:56:33  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 256 seconds)
 31 2022-04-13T02:04:43  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
 32 2022-04-13T02:15:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 33 2022-04-13T02:15:15  <bitcoin-git> [bitcoin] whiteh0rse opened pull request #24840: test: port 'lint-shell.sh' to python (master...24783-port-lint-shell-to-python) https://github.com/bitcoin/bitcoin/pull/24840
 34 2022-04-13T02:15:16  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 35 2022-04-13T03:01:06  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
 36 2022-04-13T03:07:04  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 248 seconds)
 37 2022-04-13T03:13:31  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
 38 2022-04-13T03:30:24  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
 39 2022-04-13T03:34:35  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 256 seconds)
 40 2022-04-13T03:42:33  *** NorrinRadd <NorrinRadd!~username@102.67.16.112> has joined #bitcoin-core-dev
 41 2022-04-13T04:01:01  *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
 42 2022-04-13T04:01:35  *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
 43 2022-04-13T04:06:26  *** Willtech <Willtech!~Willtech@user/Willtech> has quit IRC (Read error: Connection reset by peer)
 44 2022-04-13T04:07:03  *** Willtech <Willtech!~Willtech@user/Willtech> has joined #bitcoin-core-dev
 45 2022-04-13T04:18:50  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 250 seconds)
 46 2022-04-13T04:25:20  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9> has joined #bitcoin-core-dev
 47 2022-04-13T06:14:21  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
 48 2022-04-13T06:14:51  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
 49 2022-04-13T06:54:08  *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 260 seconds)
 50 2022-04-13T06:55:53  *** nanotube <nanotube!~nanotube@user/nanotube> has quit IRC (Ping timeout: 260 seconds)
 51 2022-04-13T06:57:21  *** nanotube <nanotube!~nanotube@user/nanotube> has joined #bitcoin-core-dev
 52 2022-04-13T06:57:52  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 250 seconds)
 53 2022-04-13T07:01:59  *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
 54 2022-04-13T07:04:55  *** jarthur_ <jarthur_!~jarthur@user/jarthur> has joined #bitcoin-core-dev
 55 2022-04-13T07:06:37  *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 240 seconds)
 56 2022-04-13T07:15:30  *** Jackielove4u <Jackielove4u!uid43977@user/jackielove4u> has joined #bitcoin-core-dev
 57 2022-04-13T07:22:21  *** gnaf <gnaf!~gnaf@195-154-105-157.rev.poneytelecom.eu> has quit IRC (Quit: Konversation terminated!)
 58 2022-04-13T07:33:50  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Ping timeout: 250 seconds)
 59 2022-04-13T07:36:01  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
 60 2022-04-13T07:40:31  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 256 seconds)
 61 2022-04-13T07:44:14  *** bfsfhkacjzgcytf9 <bfsfhkacjzgcytf9!~bfsfhkacj@user/bfsfhkacjzgcytf> has quit IRC (Ping timeout: 250 seconds)
 62 2022-04-13T07:44:50  *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
 63 2022-04-13T08:44:35  *** Willtech <Willtech!~Willtech@user/Willtech> has quit IRC (Remote host closed the connection)
 64 2022-04-13T09:00:25  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
 65 2022-04-13T09:04:27  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 240 seconds)
 66 2022-04-13T09:04:31  *** kexkey <kexkey!~kexkey@static-198-54-132-110.cust.tzulo.com> has quit IRC (Ping timeout: 256 seconds)
 67 2022-04-13T09:05:40  *** kexkey <kexkey!~kexkey@178.249.214.27> has joined #bitcoin-core-dev
 68 2022-04-13T09:12:39  *** goatpig <goatpig!~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2> has joined #bitcoin-core-dev
 69 2022-04-13T09:15:24  *** meshcollider <meshcollider!meshcollid@meshcollider.jujube.ircnow.org> has quit IRC (Ping timeout: 240 seconds)
 70 2022-04-13T09:21:10  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
 71 2022-04-13T09:45:25  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
 72 2022-04-13T09:49:27  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 240 seconds)
 73 2022-04-13T10:05:29  *** mikehu44 <mikehu44!~quassel@159.65.11.175> has joined #bitcoin-core-dev
 74 2022-04-13T10:10:58  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
 75 2022-04-13T10:30:22  *** dougefish2 <dougefish2!~dougefish@2a00:a040:19e:67b8:8ed1:c610:9029:1239> has joined #bitcoin-core-dev
 76 2022-04-13T10:37:44  *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Ping timeout: 248 seconds)
 77 2022-04-13T10:39:12  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Read error: Connection reset by peer)
 78 2022-04-13T10:40:07  *** realies <realies!~realies@user/realies> has quit IRC (Quit: Ping timeout (120 seconds))
 79 2022-04-13T10:40:21  *** realies <realies!~realies@user/realies> has joined #bitcoin-core-dev
 80 2022-04-13T10:42:00  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
 81 2022-04-13T10:47:15  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
 82 2022-04-13T10:51:52  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 250 seconds)
 83 2022-04-13T10:57:05  <fanquake> hebasto / laanwj: I've added another GCC patch to our Guix build, that may fix https://github.com/bitcoin-core/gui/issues/582: https://github.com/fanquake/bitcoin/tree/guix_fix_windows_longjmp, if you wanted to test
 84 2022-04-13T10:57:38  <hebasto> fanquake: thanks!
 85 2022-04-13T10:57:46  <fanquake> unlike the vmov fix, this isn't being backported by distros as far as I can tell.
 86 2022-04-13T10:57:58  <fanquake> Bit of a stab in the dark based on  GCC commits
 87 2022-04-13T11:10:36  *** TheRec <TheRec!~toto@user/therec> has quit IRC ()
 88 2022-04-13T11:19:02  *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
 89 2022-04-13T11:47:40  <hebasto> fanquake: I've applied your patch into the 23.x branch, and tested it on Windows 11 Pro and in `wine` on Ubuntu 22.04
 90 2022-04-13T11:47:54  <hebasto> everything works flawlessly
 91 2022-04-13T11:48:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 92 2022-04-13T11:48:52  <bitcoin-git> [bitcoin] hebasto closed pull request #24838: build, windows: Use Direct2D plugin (master...220412-d2d) https://github.com/bitcoin/bitcoin/pull/24838
 93 2022-04-13T11:48:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 94 2022-04-13T11:57:38  *** ronoaldo <ronoaldo!~ronoaldo@191.19.24.11> has joined #bitcoin-core-dev
 95 2022-04-13T11:58:53  <fanquake> I guess I should  turn that into a considerable patch
 96 2022-04-13T11:58:56  <laanwj> fanquake: that's absolutely great
 97 2022-04-13T12:00:58  <laanwj> fixing SEH is the right way to fix this
 98 2022-04-13T12:03:12  <laanwj> better than a freetype/qt specific workaround, it potentially affects other uses of frame unwinding as well liee C++ exceptions
 99 2022-04-13T12:04:11  <fanquake> I'll write a proper commit message, split it out of the vmov patch handling, and open a PR
100 2022-04-13T12:04:58  *** mikehu44 <mikehu44!~quassel@159.65.11.175> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
101 2022-04-13T12:07:49  <laanwj> thank you
102 2022-04-13T12:10:51  *** dougefish2 <dougefish2!~dougefish@2a00:a040:19e:67b8:8ed1:c610:9029:1239> has quit IRC (Quit: Client closed)
103 2022-04-13T12:15:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
104 2022-04-13T12:15:47  <bitcoin-git> [bitcoin] chinggg opened pull request #24841: test: fix connman UB by calling derived constructor (master...fix-test-connman-ub) https://github.com/bitcoin/bitcoin/pull/24841
105 2022-04-13T12:15:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
106 2022-04-13T12:18:02  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
107 2022-04-13T12:36:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
108 2022-04-13T12:36:21  <bitcoin-git> [bitcoin] fanquake opened pull request #24842: guix: fix GCC 10.3.0 + mingw-w64 setjmp/longjmp issues (master...guix_fix_windows_longjmp) https://github.com/bitcoin/bitcoin/pull/24842
109 2022-04-13T12:36:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
110 2022-04-13T13:02:34  *** An0rak <An0rak!An0rak@user/an0rak> has joined #bitcoin-core-dev
111 2022-04-13T13:04:30  *** Flow <Flow!~none@gentoo/developer/flow> has joined #bitcoin-core-dev
112 2022-04-13T13:08:47  *** An0rak <An0rak!An0rak@user/an0rak> has quit IRC ()
113 2022-04-13T13:09:28  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
114 2022-04-13T13:09:29  <bitcoin-git> [bitcoin] fanquake opened pull request #24843: [23.x] rc5 backports (23.x...rc5_backports) https://github.com/bitcoin/bitcoin/pull/24843
115 2022-04-13T13:09:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
116 2022-04-13T13:11:42  *** meshcollider <meshcollider!meshcollid@meshcollider.jujube.ircnow.org> has joined #bitcoin-core-dev
117 2022-04-13T13:25:45  *** An0rak <An0rak!An0rak@user/an0rak> has joined #bitcoin-core-dev
118 2022-04-13T14:14:53  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
119 2022-04-13T14:19:00  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 250 seconds)
120 2022-04-13T14:33:51  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
121 2022-04-13T14:34:06  *** mekster66949 <mekster66949!~mekster@user/mekster> has quit IRC (Quit: mekster66949)
122 2022-04-13T14:34:27  *** mekster66949 <mekster66949!~mekster@user/mekster> has joined #bitcoin-core-dev
123 2022-04-13T14:46:23  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
124 2022-04-13T14:50:06  <hebasto> #24157 looks good, maybe final review and merge it?
125 2022-04-13T14:50:08  <gribble> https://github.com/bitcoin/bitcoin/issues/24157 | p2p: Replace RecursiveMutex `cs_totalBytesSent` with Mutex and rename it by w0xlt · Pull Request #24157 · bitcoin/bitcoin · GitHub
126 2022-04-13T14:59:57  *** Nekorand <Nekorand!~Random@cm-188-171-200-176.telecable.es> has joined #bitcoin-core-dev
127 2022-04-13T15:00:51  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9> has quit IRC (Remote host closed the connection)
128 2022-04-13T15:01:00  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
129 2022-04-13T15:02:46  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
130 2022-04-13T15:03:33  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Client Quit)
131 2022-04-13T15:05:16  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
132 2022-04-13T15:06:00  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9> has joined #bitcoin-core-dev
133 2022-04-13T15:06:07  *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Ping timeout: 240 seconds)
134 2022-04-13T15:10:07  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9> has quit IRC (Ping timeout: 240 seconds)
135 2022-04-13T15:11:56  *** Nekorand <Nekorand!~Random@cm-188-171-200-176.telecable.es> has quit IRC (Quit: Leaving)
136 2022-04-13T15:14:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
137 2022-04-13T15:14:37  <bitcoin-git> [gui] hebasto closed pull request #108: WIP: mempool stats chart (master...2020/03/mempool_graph) https://github.com/bitcoin-core/gui/pull/108
138 2022-04-13T15:14:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
139 2022-04-13T15:15:27  *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
140 2022-04-13T15:16:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
141 2022-04-13T15:16:05  <bitcoin-git> [gui] hebasto closed pull request #305: Display send/recv in Bps instead of totals in the debug window (master...SendRecvSpeed-gui) https://github.com/bitcoin-core/gui/pull/305
142 2022-04-13T15:16:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
143 2022-04-13T15:16:49  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9> has joined #bitcoin-core-dev
144 2022-04-13T15:21:07  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9> has quit IRC (Ping timeout: 240 seconds)
145 2022-04-13T15:22:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
146 2022-04-13T15:22:06  <bitcoin-git> [gui] hebasto closed pull request #494: Replace testnet with signet as a default network for Android (master...211201-signet) https://github.com/bitcoin-core/gui/pull/494
147 2022-04-13T15:22:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
148 2022-04-13T15:22:59  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
149 2022-04-13T15:27:27  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 256 seconds)
150 2022-04-13T15:29:03  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9> has joined #bitcoin-core-dev
151 2022-04-13T15:33:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
152 2022-04-13T15:33:05  <bitcoin-git> [gui] w0xlt opened pull request #583: Add translator comments to `TransactionDesc::FormatTxStatus` (master...translator_comments_transactiondesc) https://github.com/bitcoin-core/gui/pull/583
153 2022-04-13T15:33:05  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
154 2022-04-13T15:42:14  *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
155 2022-04-13T16:16:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
156 2022-04-13T16:16:26  <bitcoin-git> [bitcoin] Kvaciral opened pull request #24844: lint: Convert lint-whitespace.sh to Python (master...lint-whitespace-port) https://github.com/bitcoin/bitcoin/pull/24844
157 2022-04-13T16:16:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
158 2022-04-13T16:21:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
159 2022-04-13T16:21:36  <bitcoin-git> [gui] hebasto opened pull request #584: Getting ready to Qt 6 (5/n). Do not assume `qDBusRegisterMetaType` return type (master...220413-metatype) https://github.com/bitcoin-core/gui/pull/584
160 2022-04-13T16:21:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
161 2022-04-13T16:25:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
162 2022-04-13T16:25:30  <bitcoin-git> [bitcoin] furszy opened pull request #24845: wallet: createTransaction, return proper error description for  "too-long-mempool-chain" + introduce generic Result classes (master...2022_wallet_operationresult) https://github.com/bitcoin/bitcoin/pull/24845
163 2022-04-13T16:25:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
164 2022-04-13T16:25:47  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
165 2022-04-13T16:40:49  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
166 2022-04-13T16:45:07  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 240 seconds)
167 2022-04-13T16:47:01  *** Skyz <Skyz!~Skyz@user/skyz> has joined #bitcoin-core-dev
168 2022-04-13T16:48:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
169 2022-04-13T16:48:29  <bitcoin-git> [bitcoin] jamesob opened pull request #24846: developer-notes: allow lowerCamelCase for methods (master...jamesob-22-04-dev-notes-methods) https://github.com/bitcoin/bitcoin/pull/24846
170 2022-04-13T16:48:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
171 2022-04-13T17:05:59  *** Skyz <Skyz!~Skyz@user/skyz> has quit IRC (Quit: Client closed)
172 2022-04-13T17:40:47  *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 240 seconds)
173 2022-04-13T17:47:24  *** goatpig <goatpig!~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2> has quit IRC (Remote host closed the connection)
174 2022-04-13T17:51:27  *** An0rak <An0rak!An0rak@user/an0rak> has quit IRC (Ping timeout: 240 seconds)
175 2022-04-13T18:18:28  *** Earnestly <Earnestly!~earnest@user/earnestly> has quit IRC (Read error: Connection reset by peer)
176 2022-04-13T18:19:56  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 250 seconds)
177 2022-04-13T18:21:18  *** Earnestly <Earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
178 2022-04-13T18:29:54  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
179 2022-04-13T18:38:19  *** lowhope <lowhope!~lowhope@2602:fffa:fff:108a:0:16:3e86:c70e> has quit IRC (Ping timeout: 256 seconds)
180 2022-04-13T18:51:44  *** jarthur_ is now known as jarthur
181 2022-04-13T19:07:36  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
182 2022-04-13T19:08:55  *** An0rak <An0rak!An0rak@user/an0rak> has joined #bitcoin-core-dev
183 2022-04-13T19:16:59  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
184 2022-04-13T19:17:36  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
185 2022-04-13T19:36:46  *** lowhope <lowhope!~lowhope@cow9.org> has joined #bitcoin-core-dev
186 2022-04-13T19:47:16  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
187 2022-04-13T19:47:31  *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
188 2022-04-13T19:50:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
189 2022-04-13T19:50:21  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f60a63cc5f16...3bbc46ddafb6
190 2022-04-13T19:50:21  <bitcoin-git> bitcoin/master 0cea7b1 /dev/fd0: print `(none)` if no warnings in -getinfo
191 2022-04-13T19:50:21  <bitcoin-git> bitcoin/master 3bbc46d laanwj: Merge bitcoin/bitcoin#24632: add `(none)` in -getinfo `Warnings:` if no wa...
192 2022-04-13T19:50:21  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
193 2022-04-13T19:50:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
194 2022-04-13T19:50:37  <bitcoin-git> [bitcoin] laanwj merged pull request #24632: add `(none)` in -getinfo `Warnings:` if no warning returned (master...getinfo-warning) https://github.com/bitcoin/bitcoin/pull/24632
195 2022-04-13T19:50:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
196 2022-04-13T19:51:08  <sipa> laanwj: I think you left https://github.com/bitcoin/bitcoin/pull/24846#issuecomment-1098420896 in the wrong PR
197 2022-04-13T19:51:32  <sipa> Ah, it's gone.
198 2022-04-13T19:53:51  <laanwj> sipa: hehe i noticed, it was for #24632
199 2022-04-13T19:53:53  <gribble> https://github.com/bitcoin/bitcoin/issues/24632 | add `(none)` in -getinfo `Warnings:` if no warning returned by 1440000bytes · Pull Request #24632 · bitcoin/bitcoin · GitHub
200 2022-04-13T19:56:51  <laanwj> it's good that we have the commit id in the ACK message or it could be a dangerous mistake :<
201 2022-04-13T20:03:59  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Ping timeout: 256 seconds)
202 2022-04-13T20:04:00  *** Guest60 <Guest60!~Guest60@2001:861:3204:e660:1425:6fd1:eb83:c179> has joined #bitcoin-core-dev
203 2022-04-13T20:25:40  *** Saloframes <Saloframes!~Saloframe@user/Saloframes> has joined #bitcoin-core-dev
204 2022-04-13T20:26:53  *** Guest60 <Guest60!~Guest60@2001:861:3204:e660:1425:6fd1:eb83:c179> has quit IRC (Quit: Client closed)
205 2022-04-13T20:28:28  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
206 2022-04-13T20:28:28  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3bbc46ddafb6...9b7eb584ade2
207 2022-04-13T20:28:28  <bitcoin-git> bitcoin/master e644591 Hennadii Stepanov: build, refactor: Drop useless `call` Make function
208 2022-04-13T20:28:28  <bitcoin-git> bitcoin/master 9b7eb58 laanwj: Merge bitcoin/bitcoin#24285: build, refactor: Drop useless `call` Make fun...
209 2022-04-13T20:28:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
210 2022-04-13T20:28:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
211 2022-04-13T20:28:47  <bitcoin-git> [bitcoin] laanwj merged pull request #24285: build, refactor: Drop useless `call` Make function (master...220207-call) https://github.com/bitcoin/bitcoin/pull/24285
212 2022-04-13T20:28:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
213 2022-04-13T20:45:44  <laanwj> re: #24559 how does a functional test explicitly request a bdb wallet?
214 2022-04-13T20:45:45  <gribble> https://github.com/bitcoin/bitcoin/issues/24559 | test: add test for signet miner script by theStack · Pull Request #24559 · bitcoin/bitcoin · GitHub
215 2022-04-13T20:46:57  <laanwj> it would be better not to, but it makes use of importprivkey at the moment
216 2022-04-13T20:47:09  *** kexkey <kexkey!~kexkey@178.249.214.27> has quit IRC (Ping timeout: 246 seconds)
217 2022-04-13T20:47:57  <laanwj> maybe someone has a better idea
218 2022-04-13T20:48:56  *** kexkey <kexkey!~kexkey@178.249.214.10> has joined #bitcoin-core-dev
219 2022-04-13T20:53:12  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9> has quit IRC (Remote host closed the connection)
220 2022-04-13T20:58:23  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9> has joined #bitcoin-core-dev
221 2022-04-13T21:00:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
222 2022-04-13T21:00:13  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9b7eb584ade2...decde9bba6f9
223 2022-04-13T21:00:13  <bitcoin-git> bitcoin/master 1633f5e Hennadii Stepanov: util, refactor: Add UNIQUE_NAME helper macro
224 2022-04-13T21:00:13  <bitcoin-git> bitcoin/master decde9b laanwj: Merge bitcoin/bitcoin#24355: util, refactor: Add UNIQUE_NAME helper macro
225 2022-04-13T21:00:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
226 2022-04-13T21:00:28  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
227 2022-04-13T21:00:29  <bitcoin-git> [bitcoin] laanwj merged pull request #24355: util, refactor: Add UNIQUE_NAME helper macro (master...220216-unique) https://github.com/bitcoin/bitcoin/pull/24355
228 2022-04-13T21:00:29  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
229 2022-04-13T21:05:12  *** hashfuncb3b <hashfuncb3b!~user@2601:5c0:c280:7090:fd34:28ad:6238:526d> has joined #bitcoin-core-dev
230 2022-04-13T21:07:56  *** geyaeb <geyaeb!~geyaeb@gateway/tor-sasl/geyaeb> has quit IRC (Ping timeout: 240 seconds)
231 2022-04-13T21:09:15  *** geyaeb <geyaeb!~geyaeb@gateway/tor-sasl/geyaeb> has joined #bitcoin-core-dev
232 2022-04-13T21:11:37  <theStack> laanwj: i just noticed that our functional test framework maps `importprivkey` to `importdescriptors` for descriptor wallets (class RPCOverloadWrapper)
233 2022-04-13T21:12:05  <theStack> so maybe my assumption that it only works for legacy wallets is just wrong... i will try in a bit
234 2022-04-13T21:31:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
235 2022-04-13T21:31:25  <bitcoin-git> [bitcoin] hebasto opened pull request #24847: ci: Bump vcpkg to the latest version `2022.04.12` (master...220413-vcpkg) https://github.com/bitcoin/bitcoin/pull/24847
236 2022-04-13T21:31:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
237 2022-04-13T21:31:54  *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 250 seconds)
238 2022-04-13T21:33:52  <laanwj> theStack: that would explain things
239 2022-04-13T21:34:40  <laanwj> i mean after all it's passing, it doesn't explicitly request a bdb wallet, and descriptor wallets are the default nowadays?
240 2022-04-13T21:36:02  <laanwj> this really confused me, but yes, that it maps the method could well be the explanation
241 2022-04-13T21:36:10  <theStack> right now it does explicitly request bdb, there is a call to "self.skip_if_no_bdb()"
242 2022-04-13T21:36:20  <theStack> would be nice if it works with both legacy and descriptor wallets though
243 2022-04-13T21:38:36  <theStack> oh wait, skip_if_no_bdb doesn't mean that a run with descriptor wallets is prevented right... hm
244 2022-04-13T21:40:07  <theStack> (locally calling the test with --descriptors fails for me, so i'm even more confused :D)
245 2022-04-13T21:40:27  *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
246 2022-04-13T21:42:40  <laanwj> skip_if_no_bdb means 'skip if bitcoind is not built with bdb', it does not do amnything else
247 2022-04-13T21:43:09  *** shesek <shesek!~shesek@user/shesek> has joined #bitcoin-core-dev
248 2022-04-13T21:45:26  <laanwj> that's very strange as --descriptors defaults to true
249 2022-04-13T21:49:07  <laanwj> you're right though, it does
250 2022-04-13T21:49:49  <laanwj> can't we make this test work without wallet?
251 2022-04-13T21:51:49  <laanwj> it doesn't ever check the wallet, what does it use it for
252 2022-04-13T21:51:58  <theStack> looks like the default used is BDB, ("# Prefer BDB unless it isn't available"), see test_framework.py:216 oO probably this should be changed to default to descriptor wallets
253 2022-04-13T21:53:13  <theStack> the signet mining script calls the `walletprocesspsbt` RPC, that's why a wallet is needed on the node
254 2022-04-13T21:53:16  <laanwj> that's super surprising after first defaulting the other way around
255 2022-04-13T21:53:36  <laanwj> ohh it's internal to the script, that makes sense
256 2022-04-13T21:56:08  <theStack> and that seems also to be the call that fails if a descriptor wallet is used, i'm trying to find out why...
257 2022-04-13T22:00:12  <laanwj> but the answer to my initial question "how does a functional test explicitly request a bdb wallet?" seems to be "it doesn't", it's decided from outside, all it can do is skip the test if self.options.descriptors==True
258 2022-04-13T22:03:52  *** ExEric3 <ExEric3!~exeric3@mail.miners-zone.net> has quit IRC (Read error: Connection reset by peer)
259 2022-04-13T22:04:14  *** ExEric3 <ExEric3!~exeric3@mail.miners-zone.net> has joined #bitcoin-core-dev
260 2022-04-13T22:04:33  <theStack> yes, i agree
261 2022-04-13T22:05:08  <theStack> interesting that the CI didn't fail, i thought we have a target that only has descriptor wallet support but not legacy wallet (didn't check though)
262 2022-04-13T22:05:40  <theStack> ah, but then the test is skipped due to bdb missing
263 2022-04-13T22:05:42  *** An0rak <An0rak!An0rak@user/an0rak> has quit IRC (Ping timeout: 250 seconds)
264 2022-04-13T22:15:32  <laanwj> yes, if bdb is available it will apparently run with that, if bdb is missing it skips due to skip_if_no_bdb
265 2022-04-13T22:16:55  *** shesek <shesek!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
266 2022-04-13T22:17:19  *** shesek <shesek!~shesek@user/shesek> has joined #bitcoin-core-dev
267 2022-04-13T22:19:37  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 248 seconds)
268 2022-04-13T22:23:23  <theStack> so, it seems that the problem is that the descriptor wallet can't sign the 1-of-1 multisig script
269 2022-04-13T22:23:41  <theStack> if i change the signetchallenge to a p2wpkh script, it works with both legacy and descriptor wallet
270 2022-04-13T22:24:03  *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
271 2022-04-13T22:24:14  <theStack> (1-of-1 multisig doesn't make sense of course, but for some reason i wrongly assumed that signet requests a multisig challenge)
272 2022-04-13T22:29:24  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
273 2022-04-13T22:35:10  *** hashfuncb3b <hashfuncb3b!~user@2601:5c0:c280:7090:fd34:28ad:6238:526d> has quit IRC (Ping timeout: 250 seconds)
274 2022-04-13T22:41:24  *** shesek <shesek!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
275 2022-04-13T22:41:49  *** shesek <shesek!~shesek@user/shesek> has joined #bitcoin-core-dev
276 2022-04-13T22:49:34  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹіа!)
277 2022-04-13T22:57:25  *** shesek <shesek!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
278 2022-04-13T22:57:49  *** shesek <shesek!~shesek@user/shesek> has joined #bitcoin-core-dev
279 2022-04-13T23:03:21  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 248 seconds)
280 2022-04-13T23:16:25  *** shesek <shesek!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
281 2022-04-13T23:16:49  *** shesek <shesek!~shesek@user/shesek> has joined #bitcoin-core-dev
282 2022-04-13T23:25:32  <laanwj> 1-of-1 multisig heh
283 2022-04-13T23:26:55  *** shesek <shesek!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
284 2022-04-13T23:27:19  *** shesek <shesek!~shesek@user/shesek> has joined #bitcoin-core-dev
285 2022-04-13T23:27:51  <sipa> Trivia: is 0-of-0 OP_CHECKMULTISIG-based multisig allowed?
286 2022-04-13T23:34:50  *** shesek_ <shesek_!~shesek@user/shesek> has joined #bitcoin-core-dev
287 2022-04-13T23:35:41  <theStack> i would have guessed no, but looking at the code it seems like it is allowed by consensus rules, but we don't treat it as standard?
288 2022-04-13T23:36:15  *** shesek <shesek!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
289 2022-04-13T23:38:16  <theStack> (if that is true, i wonder how many 0-of-0 multisig outputs can be found on the main chain :D)