1 2022-04-28T00:06:27  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581> has quit IRC (Remote host closed the connection)
  2 2022-04-28T00:20:42  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has quit IRC (Ping timeout: 246 seconds)
  3 2022-04-28T00:21:20  *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has joined #bitcoin-core-dev
  4 2022-04-28T00:23:18  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581> has joined #bitcoin-core-dev
  5 2022-04-28T00:27:48  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581> has quit IRC (Ping timeout: 250 seconds)
  6 2022-04-28T00:41:10  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581> has joined #bitcoin-core-dev
  7 2022-04-28T00:56:01  *** Willtech <Willtech!~Willtech@user/Willtech> has quit IRC (Quit: Willtech)
  8 2022-04-28T00:56:38  *** Willtech <Willtech!~Willtech@user/Willtech> has joined #bitcoin-core-dev
  9 2022-04-28T01:14:57  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹіа!)
 10 2022-04-28T01:17:45  *** test_ <test_!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
 11 2022-04-28T01:20:39  *** _flood <_flood!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Ping timeout: 240 seconds)
 12 2022-04-28T01:42:43  *** Willtech <Willtech!~Willtech@user/Willtech> has quit IRC (Quit: Willtech)
 13 2022-04-28T01:43:20  *** Willtech <Willtech!~Willtech@user/Willtech> has joined #bitcoin-core-dev
 14 2022-04-28T01:43:52  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581> has quit IRC (Ping timeout: 260 seconds)
 15 2022-04-28T01:51:20  <jamesob> hmmmmm have we totally-definitely-certainly outlawed `goto` use?
 16 2022-04-28T01:52:04  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
 17 2022-04-28T01:53:30  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 18 2022-04-28T01:55:20  <_aj_> jamesob: "how can i do [pastebin] better than using goto?"
 19 2022-04-28T01:59:01  *** NorrinRadd <NorrinRadd!~username@> has joined #bitcoin-core-dev
 20 2022-04-28T01:59:28  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
 21 2022-04-28T02:03:44  <jamesob> _aj_: it's just so tempting to pretend I'm a kernel hacker rather than introduce yet another refactoring commit
 22 2022-04-28T02:06:16  <jamesob> and debatably what this would be replacing is less clear than goto IMO (using `continue` in a do-while to do poor man's recursion during init)
 23 2022-04-28T02:06:47  <jamesob> but I'll relent, despite always being on the lookout for innovative ways to make assumeutxo PRs harder to merge
 24 2022-04-28T02:07:44  <sipa> Unless you're using it in a super tight performance-critical loop, and there is no way to achieve the same performance with a more structured approach... I'd say no.
 25 2022-04-28T02:11:15  <jamesob> sipa: you mean "yes[, we have outlawed goto]"
 26 2022-04-28T02:13:36  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581> has joined #bitcoin-core-dev
 27 2022-04-28T02:18:38  *** a1ph4byte <a1ph4byte!~a1ph4byte@2600:1700:22f0:a7c0:bc46:d63f:2e5f:7485> has joined #bitcoin-core-dev
 28 2022-04-28T02:20:47  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c> has quit IRC (Remote host closed the connection)
 29 2022-04-28T02:21:04  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Ping timeout: 240 seconds)
 30 2022-04-28T02:21:18  <sipa> we have a goto somewhere in the codebase!
 31 2022-04-28T02:21:18  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
 32 2022-04-28T02:21:52  <sipa> there's at least one in src/crypto/poly1305 i believe
 33 2022-04-28T02:22:02  <sipa> (but it's code copied from elsewhere)
 34 2022-04-28T02:26:02  <jamesob> IIRC dongcarl tried to introduce one recently to the libbitcoinkernel client code
 35 2022-04-28T02:27:06  <dongcarl> Yup
 36 2022-04-28T02:27:30  <dongcarl> It's example code and will be moved to src/kernel/example in future PRs tho
 37 2022-04-28T02:49:34  <luke-jr> aren't examples usually under contrib/ ?
 38 2022-04-28T02:56:04  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Ping timeout: 240 seconds)
 39 2022-04-28T03:17:11  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581> has quit IRC (Ping timeout: 260 seconds)
 40 2022-04-28T03:27:40  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c> has joined #bitcoin-core-dev
 41 2022-04-28T03:31:01  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581> has joined #bitcoin-core-dev
 42 2022-04-28T03:33:00  <jeremyrubin> jamesob: show me a code snippet and i'll show you goto free code
 43 2022-04-28T03:36:52  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
 44 2022-04-28T03:44:04  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Ping timeout: 240 seconds)
 45 2022-04-28T03:50:04  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
 46 2022-04-28T03:52:06  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 47 2022-04-28T03:57:17  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c> has quit IRC (Remote host closed the connection)
 48 2022-04-28T04:01:01  *** cmirror <cmirror!~cmirror@> has quit IRC (Remote host closed the connection)
 49 2022-04-28T04:01:35  *** cmirror <cmirror!~cmirror@> has joined #bitcoin-core-dev
 50 2022-04-28T04:10:55  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c> has joined #bitcoin-core-dev
 51 2022-04-28T04:19:38  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c> has quit IRC (Ping timeout: 250 seconds)
 52 2022-04-28T04:38:35  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
 53 2022-04-28T04:40:02  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
 54 2022-04-28T04:46:36  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 276 seconds)
 55 2022-04-28T04:47:46  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
 56 2022-04-28T05:19:03  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c> has joined #bitcoin-core-dev
 57 2022-04-28T05:23:20  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c> has quit IRC (Ping timeout: 250 seconds)
 58 2022-04-28T05:25:34  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Ping timeout: 240 seconds)
 59 2022-04-28T05:43:59  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 256 seconds)
 60 2022-04-28T05:44:30  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
 61 2022-04-28T05:44:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 62 2022-04-28T05:44:31  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f0a834e2f10a...4381681e554d
 63 2022-04-28T05:44:31  <bitcoin-git> bitcoin/master 786b3a7 Andrew Chow: tests: Do not always create a descriptor wallet in wallet_createwallet
 64 2022-04-28T05:44:31  <bitcoin-git> bitcoin/master 4381681 MacroFake: Merge bitcoin/bitcoin#25011: tests: Do not always create a descriptor wall...
 65 2022-04-28T05:44:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 66 2022-04-28T05:44:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 67 2022-04-28T05:44:47  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25011: tests: Do not always create a descriptor wallet in wallet_createwallet (master...fix-legacy-createwallet-test) https://github.com/bitcoin/bitcoin/pull/25011
 68 2022-04-28T05:44:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 69 2022-04-28T05:55:18  *** Alina-malina <Alina-malina!~Alina-mal@user/alina-malina> has quit IRC (Ping timeout: 246 seconds)
 70 2022-04-28T05:59:29  *** Alina-malina <Alina-malina!~Alina-mal@user/alina-malina> has joined #bitcoin-core-dev
 71 2022-04-28T06:05:00  *** mikehu44_ <mikehu44_!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
 72 2022-04-28T06:08:55  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 256 seconds)
 73 2022-04-28T06:24:14  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
 74 2022-04-28T06:30:36  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Remote host closed the connection)
 75 2022-04-28T06:32:01  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
 76 2022-04-28T06:46:32  *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 250 seconds)
 77 2022-04-28T06:55:25  *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has joined #bitcoin-core-dev
 78 2022-04-28T07:00:53  *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
 79 2022-04-28T07:01:14  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
 80 2022-04-28T07:09:55  *** hashfunc1ebd <hashfunc1ebd!~user@128-092-093-090.biz.spectrum.com> has joined #bitcoin-core-dev
 81 2022-04-28T07:14:42  *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 250 seconds)
 82 2022-04-28T07:16:22  *** mikehu44_ <mikehu44_!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 272 seconds)
 83 2022-04-28T07:17:38  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
 84 2022-04-28T07:22:04  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
 85 2022-04-28T07:22:22  *** Willtech <Willtech!~Willtech@user/Willtech> has quit IRC (Remote host closed the connection)
 86 2022-04-28T07:28:00  *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
 87 2022-04-28T07:31:49  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 88 2022-04-28T07:32:10  <laanwj> if you're running a patched version you should be able to ask git for the necessary information yourself, though
 89 2022-04-28T07:33:14  <laanwj> so i'm still not really convinced
 90 2022-04-28T07:33:39  <laanwj> jamesob: yes, goto has no place in C++ code, in C code it's sometimes ok
 91 2022-04-28T07:34:40  <laanwj> in C code it's useful (often, the least insane way) to do cleanup in case of errors, in C++ code you should use RAII for cleanup instead
 92 2022-04-28T07:36:22  <laanwj> please avoid "kernel hacking" in this project if possible, if dumb, easy to understand code (in far as that's even possible with C++) suffices, go for that, the less tricks and surprises the better
 93 2022-04-28T07:36:31  *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
 94 2022-04-28T07:39:59  <laanwj> anyhow wrt the merge list: the only thing git log --merges v.... v.... *doesn't* do is sort the PRs per category, but this is a painstaking process anyway, there's some automation using the github API and labels but it's often only a heuristic and still needs careful checking
 95 2022-04-28T07:40:46  <laanwj> for 23.0 i just didn't get around to that, if someone else does i'm not going to stop them
 96 2022-04-28T07:40:57  <laanwj> well, for next release i man, for 23.0 it's too late
 97 2022-04-28T07:41:00  <laanwj> mean*
 98 2022-04-28T07:42:59  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581> has quit IRC (Ping timeout: 240 seconds)
 99 2022-04-28T07:44:52  *** hashfunc1ebd <hashfunc1ebd!~user@128-092-093-090.biz.spectrum.com> has quit IRC (Ping timeout: 272 seconds)
100 2022-04-28T07:51:59  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 240 seconds)
101 2022-04-28T07:54:34  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
102 2022-04-28T07:59:01  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581> has joined #bitcoin-core-dev
103 2022-04-28T08:08:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
104 2022-04-28T08:08:53  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/4381681e554d...9446de160f37
105 2022-04-28T08:08:53  <bitcoin-git> bitcoin/master c79ad93 fanquake: refactor: fix includes in src/compat
106 2022-04-28T08:08:53  <bitcoin-git> bitcoin/master 74cd038 fanquake: refactor: fix includes in src/init
107 2022-04-28T08:08:53  <bitcoin-git> bitcoin/master 9b0a13a fanquake: tidy: Add include-what-you-use
108 2022-04-28T08:08:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
109 2022-04-28T08:09:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
110 2022-04-28T08:09:09  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24831: tidy: add include-what-you-use (master...include_what_you_use) https://github.com/bitcoin/bitcoin/pull/24831
111 2022-04-28T08:09:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
112 2022-04-28T08:51:15  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
113 2022-04-28T09:00:06  *** robertspigler <robertspigler!~robertspi@2001:470:69fc:105::2d53> has quit IRC (Quit: You have been kicked for being idle)
114 2022-04-28T09:00:39  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581> has quit IRC (Ping timeout: 260 seconds)
115 2022-04-28T09:10:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
116 2022-04-28T09:10:26  <bitcoin-git> [bitcoin] laanwj opened pull request #25012: doc: Update blurb in README.md (master...2022-04-readme-blurb) https://github.com/bitcoin/bitcoin/pull/25012
117 2022-04-28T09:10:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
118 2022-04-28T09:12:31  *** NorrinRadd <NorrinRadd!~username@> has quit IRC (Ping timeout: 256 seconds)
119 2022-04-28T09:14:47  *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
120 2022-04-28T09:14:50  *** NorrinRadd <NorrinRadd!~username@> has joined #bitcoin-core-dev
121 2022-04-28T09:24:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
122 2022-04-28T09:24:07  <bitcoin-git> [bitcoin] laanwj closed pull request #25012: doc: Update blurb in README.md (master...2022-04-readme-blurb) https://github.com/bitcoin/bitcoin/pull/25012
123 2022-04-28T09:24:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
124 2022-04-28T09:25:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
125 2022-04-28T09:25:41  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #25013: Remove cs_main from verifymessage, move msg utils to new file (master...2204-rpc-misc-🔌) https://github.com/bitcoin/bitcoin/pull/25013
126 2022-04-28T09:25:41  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
127 2022-04-28T09:29:07  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:899d:3cb8:f5ed:1581> has joined #bitcoin-core-dev
128 2022-04-28T09:47:34  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Ping timeout: 240 seconds)
129 2022-04-28T09:50:43  <laanwj> re: #25012 I really hoped to remove the 'whether bitcoin is experimental' concern from our repo once and for all, but seems it just comes back in a different form then, really, never mind
130 2022-04-28T09:50:44  <gribble> https://github.com/bitcoin/bitcoin/issues/25012 | doc: Update blurb in README.md by laanwj · Pull Request #25012 · bitcoin/bitcoin · GitHub
131 2022-04-28T09:54:53  <laanwj> 'File "..." contains a shebang line, but has the file permission 775 instead of the expected executable permission 755. Do "chmod 755 test/lint/lint-python-mutable-default-parameters.py" (or remove the shebang line)'  huh
132 2022-04-28T09:55:08  <fanquake> laanwj: I think removing that is fine
133 2022-04-28T10:10:19  <laanwj> fanquake: thanks
134 2022-04-28T10:12:29  <_aj_> laanwj: <3
135 2022-04-28T10:17:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
136 2022-04-28T10:17:10  <bitcoin-git> [bitcoin] MarcoFalke pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/9446de160f37...b51e60f91472
137 2022-04-28T10:17:10  <bitcoin-git> bitcoin/master 98f4bda Carl Dong: refactor: Convert warningcache to std::array
138 2022-04-28T10:17:10  <bitcoin-git> bitcoin/master 6e747e8 Anthony Towns: validation: default initialize and guard chainman members
139 2022-04-28T10:17:10  <bitcoin-git> bitcoin/master 5921b86 Carl Dong: init: Reset mempool and chainman via reconstruction
140 2022-04-28T10:17:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
141 2022-04-28T10:17:25  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
142 2022-04-28T10:17:26  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22564: refactor: Move mutable globals cleared in `::UnloadBlockIndex` to `BlockManager` (master...2021-07-kirby-inhale-global-muts) https://github.com/bitcoin/bitcoin/pull/22564
143 2022-04-28T10:17:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
144 2022-04-28T10:18:16  <laanwj> _aj_: 💜
145 2022-04-28T10:29:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
146 2022-04-28T10:29:30  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b51e60f91472...85aea18ae660
147 2022-04-28T10:29:30  <bitcoin-git> bitcoin/master 29f44fe hiago: Converting `lint-all.sh` to `lint-all.py`.
148 2022-04-28T10:29:30  <bitcoin-git> bitcoin/master 85aea18 laanwj: Merge bitcoin/bitcoin#24982: tests: Port `lint-all.sh` to `lint-all.py`
149 2022-04-28T10:29:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
150 2022-04-28T10:29:44  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
151 2022-04-28T10:29:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
152 2022-04-28T10:29:46  <bitcoin-git> [bitcoin] laanwj merged pull request #24982: tests: Port `lint-all.sh` to `lint-all.py` (master...port_lint-all.sh_to_python) https://github.com/bitcoin/bitcoin/pull/24982
153 2022-04-28T10:29:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
154 2022-04-28T10:40:31  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Quit: Konversation terminated!)
155 2022-04-28T10:40:50  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
156 2022-04-28T10:42:46  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Client Quit)
157 2022-04-28T10:43:02  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
158 2022-04-28T10:59:33  *** evanlinjin_ <evanlinjin_!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
159 2022-04-28T10:59:34  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Ping timeout: 240 seconds)
160 2022-04-28T11:09:02  *** Guest50 <Guest50!~Guest50@2601:58b:c600:c390:dbf2:b052:d8fb:6245> has joined #bitcoin-core-dev
161 2022-04-28T11:29:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
162 2022-04-28T11:29:27  <bitcoin-git> [bitcoin] laanwj opened pull request #25015: test: Use permissions from git in lint-files.py (master...2022-04-lint-permissions-git) https://github.com/bitcoin/bitcoin/pull/25015
163 2022-04-28T11:29:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
164 2022-04-28T11:30:38  *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
165 2022-04-28T11:32:50  *** mikehu44_ <mikehu44_!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
166 2022-04-28T11:32:52  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 272 seconds)
167 2022-04-28T11:40:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
168 2022-04-28T11:40:56  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/85aea18ae660...e36c612e5a9b
169 2022-04-28T11:40:56  <bitcoin-git> bitcoin/master fa82a1e MacroFake: lint: Mention NONFATAL_UNREACHABLE in lint-assertions.py
170 2022-04-28T11:40:56  <bitcoin-git> bitcoin/master e36c612 fanquake: Merge bitcoin/bitcoin#24988: lint: Mention NONFATAL_UNREACHABLE in lint-as...
171 2022-04-28T11:40:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
172 2022-04-28T11:41:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
173 2022-04-28T11:41:12  <bitcoin-git> [bitcoin] fanquake merged pull request #24988: lint: Mention NONFATAL_UNREACHABLE in lint-assertions.py (master...2204-lint-abort-🐛) https://github.com/bitcoin/bitcoin/pull/24988
174 2022-04-28T11:41:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
175 2022-04-28T11:44:59  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
176 2022-04-28T11:45:12  *** mikehu44_ <mikehu44_!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 276 seconds)
177 2022-04-28T11:48:45  *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
178 2022-04-28T12:27:34  *** dougefish <dougefish!~dougefish@2a00:a040:19e:67b8:8ed1:c610:9029:1239> has quit IRC (Ping timeout: 250 seconds)
179 2022-04-28T12:33:18  *** dougefish <dougefish!~dougefish@> has joined #bitcoin-core-dev
180 2022-04-28T12:38:52  *** test_ is now known as _flood
181 2022-04-28T12:48:04  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
182 2022-04-28T12:50:16  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
183 2022-04-28T13:05:08  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
184 2022-04-28T13:39:43  <jamesob> jeremyrubin: no trouble constructing the goto-free code, just entails a lot of refactoring etc.
185 2022-04-28T13:39:56  <jamesob> laanwj: don't worry, I was kidding about the "kernel hacking" comment
186 2022-04-28T13:40:48  <jamesob> attempted humor not conveying well I guess
187 2022-04-28T13:48:18  <_aj_> laanwj: or 🍦
188 2022-04-28T13:48:28  *** evanlinjin_ <evanlinjin_!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Quit: Konversation terminated!)
189 2022-04-28T13:49:16  <laanwj> jamesob: sorry for taking it so serious, it's hard to gauge sometimes!
190 2022-04-28T13:49:19  <laanwj> _aj_: yess
191 2022-04-28T13:50:01  <jamesob> laanwj: no worries, I was just delirious and in a rambling mood during a rebase last night :)
192 2022-04-28T13:50:57  <laanwj> jamesob: i meann remmeber that we have an actual system call sandbox in bitcoin core, it's scary close to kernel hacking
193 2022-04-28T13:51:16  <jamesob> haha, good point!
194 2022-04-28T13:54:19  *** jespada <jespada!~jespada@> has quit IRC (Ping timeout: 240 seconds)
195 2022-04-28T13:55:51  *** jespada <jespada!~jespada@> has joined #bitcoin-core-dev
196 2022-04-28T13:58:14  <jonatack> 10 PRINT "HELLO WORLD" 20 GOTO 10
197 2022-04-28T13:58:31  <sipa> what a basic joke
198 2022-04-28T13:58:34  <jonatack> I think that was the first program I ever wrote :D
199 2022-04-28T13:58:48  <sipa> mine's probably close
200 2022-04-28T13:58:50  <jonatack> indeed basic
201 2022-04-28T13:59:56  <jamesob> you guys are old-timers! my first program was in *visual* basic, truly high-tech stuff
202 2022-04-28T14:00:39  <sipa> which version? i used visual basic 3, 5, and 6
203 2022-04-28T14:02:00  *** gnaf <gnaf!~gnaf@163-172-90-106.rev.poneytelecom.eu> has joined #bitcoin-core-dev
204 2022-04-28T14:02:21  <jamesob> all I remember was that it was on Windows ME...
205 2022-04-28T14:02:51  <sipa> My condolences.
206 2022-04-28T14:03:32  <jamesob> lol
207 2022-04-28T14:15:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
208 2022-04-28T14:15:01  <bitcoin-git> [bitcoin] fanquake pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/e36c612e5a9b...dd17c42a1642
209 2022-04-28T14:15:01  <bitcoin-git> bitcoin/master 1392e8e Carl Dong: build: Don't add unrelated libs to LIBTEST_*
210 2022-04-28T14:15:01  <bitcoin-git> bitcoin/master 64caf94 Carl Dong: build: Remove vestigial LIBLEVELDB_SSE42
211 2022-04-28T14:15:01  <bitcoin-git> bitcoin/master 05d1525 Carl Dong: build: Create .la library for crc32c
212 2022-04-28T14:15:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
213 2022-04-28T14:15:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
214 2022-04-28T14:15:19  <bitcoin-git> [bitcoin] fanquake merged pull request #24322: [kernel 1/n] Introduce initial `libbitcoinkernel` (master...2022-02-libbitcoinkernel-p1-minimal) https://github.com/bitcoin/bitcoin/pull/24322
215 2022-04-28T14:15:19  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
216 2022-04-28T14:15:29  <laanwj> in MSX basic you could do this cursed thing where you stripped the line numbers, and replaced gotos by assignments to the interpreter pointer in the token stream—
217 2022-04-28T14:16:47  <laanwj> there are things much worse than gotos :)
218 2022-04-28T14:17:30  <sipa> Duff's device?
219 2022-04-28T14:19:28  *** Guest50 <Guest50!~Guest50@2601:58b:c600:c390:dbf2:b052:d8fb:6245> has quit IRC (Quit: Client closed)
220 2022-04-28T14:20:58  <laanwj> yes, i'd say that qualifies
221 2022-04-28T14:39:24  <laanwj> or what about the gcc computed goto extension
222 2022-04-28T14:41:00  <laanwj> maybe it could be combined with a Duff's device for extra curse points
223 2022-04-28T14:46:11  <cfields> libbitcoinkernel \o/
224 2022-04-28T14:48:45  <sipa> laanwj: Throw in another longjmp() too
225 2022-04-28T14:49:31  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
226 2022-04-28T14:49:31  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #20030: validation: Remove useless call to mempool->clear() (master...2009-valMemClear) https://github.com/bitcoin/bitcoin/pull/20030
227 2022-04-28T14:49:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
228 2022-04-28T14:49:57  <laanwj> cfields: oh no
229 2022-04-28T14:50:01  <lightlike> maybe disguise the goto as  "do{...} while(false)" with breaks and hope no one will notice (I think we had this kind  of thing until recently)
230 2022-04-28T14:52:51  <roconnor> https://github.com/bitcoin-core/secp256k1/blob/master/src/util.h#L93
231 2022-04-28T14:53:23  <laanwj> sipa: ah ye our old friend longjmp, was surpised to see it actually used in freetype in #582
232 2022-04-28T14:53:24  <gribble> https://github.com/bitcoin/bitcoin/issues/582 | Bitcoin-Qt signmessage GUI by luke-jr · Pull Request #582 · bitcoin/bitcoin · GitHub
233 2022-04-28T14:53:29  <sipa> That doesn't simulate a goto; it's a trick to construct a macro that works without branches in an if then else
234 2022-04-28T14:53:50  <roconnor> oh, "with breaks"
235 2022-04-28T14:54:09  <laanwj> the other 582 https://github.com/bitcoin-core/gui/issues/582
236 2022-04-28T14:54:10  <roconnor> ... wait, I don't get it.
237 2022-04-28T14:54:44  <sipa> roconnor: https://stackoverflow.com/questions/257418/do-while-0-what-is-it-good-for
238 2022-04-28T14:56:11  <sipa> (not that we permit branchless if/then/elses in the first place, but it doesn't hurt...)
239 2022-04-28T14:56:52  <roconnor> https://stackoverflow.com/a/257421 -- okay I'm impressed.
240 2022-04-28T14:58:41  <sipa> lightlike roconnor: that approach has the advance that it still works in C++ code with new variables defined in the body (in C++ a goto cannot cross the definition of a variable)
241 2022-04-28T14:59:38  <sipa> I don't know... I think that do ... break ... break ... while(0) pattern is a slight improvement over a goto, but I can see it'd be controversial
242 2022-04-28T15:00:53  <roconnor> For me it has the advantage that it is supported by VST while goto is not.
243 2022-04-28T15:01:07  <laanwj> i'd agree, it's "an improvement over a goto" but then also everything is said, if awkward constructions can completely be avoided that'd be even better
244 2022-04-28T15:01:55  <roconnor> C has fewer ways of avoiding akward constructions than C++ does.
245 2022-04-28T15:02:06  <laanwj> yes, very true
246 2022-04-28T15:02:43  <sipa> at some point you just resort to an asm { ... } block ;)
247 2022-04-28T15:03:26  <laanwj> sometimes a high level language just gets in the way :)
248 2022-04-28T15:04:34  *** a1ph4byte <a1ph4byte!~a1ph4byte@2600:1700:22f0:a7c0:bc46:d63f:2e5f:7485> has quit IRC (Quit: Client closed)
249 2022-04-28T15:04:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
250 2022-04-28T15:04:40  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #19909: txmempool: Remove unused clear() member function (master...2009-noTxpoolClear) https://github.com/bitcoin/bitcoin/pull/19909
251 2022-04-28T15:04:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
252 2022-04-28T15:06:07  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 256 seconds)
253 2022-04-28T15:17:47  *** pk-b2 <pk-b2!noc_@gateway/vpn/protonvpn/noc/x-98562394> has joined #bitcoin-core-dev
254 2022-04-28T15:20:43  *** a1ph4byte <a1ph4byte!~a1ph4byte@2600:1700:22f0:a7c0:7962:a6a5:10e5:4fc> has joined #bitcoin-core-dev
255 2022-04-28T15:57:41  *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has quit IRC (Ping timeout: 256 seconds)
256 2022-04-28T16:20:18  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
257 2022-04-28T16:31:36  *** pk-b2 <pk-b2!noc_@gateway/vpn/protonvpn/noc/x-98562394> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
258 2022-04-28T16:32:46  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Remote host closed the connection)
259 2022-04-28T16:33:21  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
260 2022-04-28T16:39:27  *** bfsfhkacjzgcytf9 <bfsfhkacjzgcytf9!~bfsfhkacj@user/bfsfhkacjzgcytf> has joined #bitcoin-core-dev
261 2022-04-28T16:52:49  <cfields> laanwj: "oh no" ?
262 2022-04-28T16:53:55  <laanwj> cfields: i mean in the sense that there's an actual kernel in bitcoin now so we can't have anything against "kernel hacking"
263 2022-04-28T16:54:44  *** salvatoshi <salvatoshi!~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr> has joined #bitcoin-core-dev
264 2022-04-28T16:54:52  <laanwj> jamesob won
265 2022-04-28T16:55:46  <sipa> "kernel" and "core" are practically synonyms anyway
266 2022-04-28T16:55:52  *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Ping timeout: 248 seconds)
267 2022-04-28T16:56:10  <cfields> oh :)
268 2022-04-28T17:04:52  <laanwj> but yeah i can see how that could be interpreted wrong, to be clear i really like libbitcoinkernel
269 2022-04-28T17:11:40  *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
270 2022-04-28T17:16:39  *** pk-b2 <pk-b2!noc_@gateway/vpn/protonvpn/noc/x-98562394> has joined #bitcoin-core-dev
271 2022-04-28T17:17:15  *** pk-b2 <pk-b2!noc_@gateway/vpn/protonvpn/noc/x-98562394> has quit IRC (Client Quit)
272 2022-04-28T17:18:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
273 2022-04-28T17:18:18  <bitcoin-git> [bitcoin] jonatack opened pull request #25016: blockstorage, refactor: improve GetFirstStoredBlock() (master...GetFirstStoredBlock-improvements) https://github.com/bitcoin/bitcoin/pull/25016
274 2022-04-28T17:18:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
275 2022-04-28T17:19:31  *** salvatoshi <salvatoshi!~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr> has quit IRC (Ping timeout: 260 seconds)
276 2022-04-28T17:25:18  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
277 2022-04-28T17:26:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
278 2022-04-28T17:26:18  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dd17c42a1642...47b8256da872
279 2022-04-28T17:26:18  <bitcoin-git> bitcoin/master fafd674 MarcoFalke: test: Remove previous release check
280 2022-04-28T17:26:18  <bitcoin-git> bitcoin/master 47b8256 laanwj: Merge bitcoin/bitcoin#24937: test: Remove previous release check in featur...
281 2022-04-28T17:26:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
282 2022-04-28T17:26:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
283 2022-04-28T17:26:34  <bitcoin-git> [bitcoin] laanwj merged pull request #24937: test: Remove previous release check in feature_taproot.py (master...2204-noPrevRelTap-🏥) https://github.com/bitcoin/bitcoin/pull/24937
284 2022-04-28T17:26:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
285 2022-04-28T17:27:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
286 2022-04-28T17:27:18  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/47b8256da872...8730bd3fc87c
287 2022-04-28T17:27:18  <bitcoin-git> bitcoin/master bbbcb96 Hennadii Stepanov: build, refactor: Fix indentation
288 2022-04-28T17:27:18  <bitcoin-git> bitcoin/master 65cddf6 Hennadii Stepanov: build: Fix `AC_CHECK_HEADERS` and `AC_CHECK_LIB` for `miniupnpc` package
289 2022-04-28T17:27:18  <bitcoin-git> bitcoin/master 1659034 Hennadii Stepanov: build: Fix `AC_CHECK_HEADERS` and `AC_CHECK_LIB` for `libnatpmp` package
290 2022-04-28T17:27:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
291 2022-04-28T17:27:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
292 2022-04-28T17:27:34  <bitcoin-git> [bitcoin] laanwj merged pull request #24958: build: Fix macOS Apple M1 build with miniupnpc and libnatpmp. Again :) (master...220424-flags) https://github.com/bitcoin/bitcoin/pull/24958
293 2022-04-28T17:27:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
294 2022-04-28T17:31:39  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Remote host closed the connection)
295 2022-04-28T17:31:59  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
296 2022-04-28T17:33:13  *** Guest60 <Guest60!~Guest60@ip5f5becb1.dynamic.kabel-deutschland.de> has joined #bitcoin-core-dev
297 2022-04-28T17:33:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
298 2022-04-28T17:33:51  <bitcoin-git> [bitcoin] jonatack opened pull request #25017: validation: make the CScriptCheck::swap() member function `noexcept` (master...swap-noexcept) https://github.com/bitcoin/bitcoin/pull/25017
299 2022-04-28T17:33:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
300 2022-04-28T17:34:45  *** Guest60 <Guest60!~Guest60@ip5f5becb1.dynamic.kabel-deutschland.de> has quit IRC (Client Quit)
301 2022-04-28T17:50:08  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
302 2022-04-28T17:54:46  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
303 2022-04-28T18:02:23  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
304 2022-04-28T18:02:24  <bitcoin-git> [bitcoin] scgbckbone opened pull request #25019: normalize (lowercase) master fp in ExternalSigner::SignTransaction (master...lower_master_fp_of_ext_signer_in_SignTransaction) https://github.com/bitcoin/bitcoin/pull/25019
305 2022-04-28T18:02:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
306 2022-04-28T18:03:39  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
307 2022-04-28T18:07:08  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Remote host closed the connection)
308 2022-04-28T18:09:18  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c> has joined #bitcoin-core-dev
309 2022-04-28T18:14:07  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c> has quit IRC (Remote host closed the connection)
310 2022-04-28T18:14:44  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c> has joined #bitcoin-core-dev
311 2022-04-28T18:17:41  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c> has quit IRC (Remote host closed the connection)
312 2022-04-28T18:20:27  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c> has joined #bitcoin-core-dev
313 2022-04-28T18:25:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
314 2022-04-28T18:25:58  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8730bd3fc87c...dabec990135c
315 2022-04-28T18:25:58  <bitcoin-git> bitcoin/master fab34d3 MarcoFalke: Call CHECK_NONFATAL only once where needed
316 2022-04-28T18:25:58  <bitcoin-git> bitcoin/master dabec99 MacroFake: Merge bitcoin/bitcoin#24956: Call CHECK_NONFATAL only once where needed
317 2022-04-28T18:25:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
318 2022-04-28T18:26:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
319 2022-04-28T18:26:13  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24956: Call CHECK_NONFATAL only once where needed (master...2204-once-check-tip-🦅) https://github.com/bitcoin/bitcoin/pull/24956
320 2022-04-28T18:26:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
321 2022-04-28T18:36:40  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c> has quit IRC (Remote host closed the connection)
322 2022-04-28T18:37:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
323 2022-04-28T18:37:12  <bitcoin-git> [bitcoin] hebasto opened pull request #25020: contrib: Check symbols in the `bitcoinconsensus` shared library (master...220428-shared) https://github.com/bitcoin/bitcoin/pull/25020
324 2022-04-28T18:37:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
325 2022-04-28T18:43:56  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:5186:7734:3ca6:271c> has joined #bitcoin-core-dev
326 2022-04-28T18:54:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
327 2022-04-28T18:54:55  <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dabec990135c...4cf9fa0b662a
328 2022-04-28T18:54:55  <bitcoin-git> bitcoin/master 2052e3a Martin Zumsande: wallet: ignore chainStateFlushed notifications while attaching chain
329 2022-04-28T18:54:55  <bitcoin-git> bitcoin/master 4cf9fa0 Andrew Chow: Merge bitcoin/bitcoin#24984: wallet: ignore chainStateFlushed notification...
330 2022-04-28T18:54:55  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
331 2022-04-28T18:55:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
332 2022-04-28T18:55:10  <bitcoin-git> [bitcoin] achow101 merged pull request #24984: wallet: ignore chainStateFlushed notifications while attaching chain (master...202204_wallet_rescan) https://github.com/bitcoin/bitcoin/pull/24984
333 2022-04-28T18:55:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
334 2022-04-28T18:55:15  <hebasto> cfields: in the context of your https://github.com/bitcoin/bitcoin/pull/24322#issuecomment-1112453779 mind looking into #24387 ?
335 2022-04-28T18:55:16  <gribble> https://github.com/bitcoin/bitcoin/issues/24387 | build: Fail to build `libmultiprocess` for the `arm-linux-gnueabihf` target · Issue #24387 · bitcoin/bitcoin · GitHub
336 2022-04-28T19:00:52  <laanwj> #startmeeting
337 2022-04-28T19:00:52  <core-meetingbot> Meeting started Thu Apr 28 19:00:52 2022 UTC.  The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
338 2022-04-28T19:00:52  <core-meetingbot> Available commands: action commands idea info link nick
339 2022-04-28T19:01:03  <hebasto> hi
340 2022-04-28T19:01:19  <laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball
341 2022-04-28T19:01:20  <laanwj> morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
342 2022-04-28T19:01:24  <glozow> hi
343 2022-04-28T19:01:31  <sipsorcery> hi
344 2022-04-28T19:01:48  <sipa> hi
345 2022-04-28T19:01:49  <laanwj> welcome to the weekly general bitcoin-core-dev meeting!
346 2022-04-28T19:02:07  <laanwj> there have been no topics proposed in advance using #proposedmeetingtopic, any last minute ones people would like to discuss today?
347 2022-04-28T19:02:49  <cfields> hi
348 2022-04-28T19:02:55  <jonatack> 10 print "hi" 20 goto 10
349 2022-04-28T19:03:10  <dongcarl> I can give a very quick update/announcement on libbitcoinkernel if no other topics are there
350 2022-04-28T19:03:33  <lightlike> hi
351 2022-04-28T19:03:50  <laanwj> dongcarl: sounds good to me, let's have that as topic after high prio for review
352 2022-04-28T19:03:57  <dongcarl> cool
353 2022-04-28T19:04:09  <jonatack> dongcarl: post-merge ack modulo the clang build chatter ;)
354 2022-04-28T19:04:11  <kanzure> hi
355 2022-04-28T19:04:12  <jeremyrubin> Hi
356 2022-04-28T19:04:38  <laanwj> #topic High priority for review
357 2022-04-28T19:04:38  <core-meetingbot> topic: High priority for review
358 2022-04-28T19:05:02  <laanwj> currently 11 blockers 1 chasing concept ACK https://github.com/bitcoin/bitcoin/projects/8
359 2022-04-28T19:05:32  <laanwj> anything to add/remove?
360 2022-04-28T19:05:45  <achow101> hi
361 2022-04-28T19:05:49  <laanwj> or that's on the list and (almost) ready for merge
362 2022-04-28T19:06:38  <lightlike> #24322 was merged and can be removed
363 2022-04-28T19:06:40  <gribble> https://github.com/bitcoin/bitcoin/issues/24322 | [kernel 1/n] Introduce initial `libbitcoinkernel` by dongcarl · Pull Request #24322 · bitcoin/bitcoin · GitHub
364 2022-04-28T19:06:54  <glozow> #23443 seems close, though needs rebase
365 2022-04-28T19:06:58  <gribble> https://github.com/bitcoin/bitcoin/issues/23443 | p2p: Erlay support signaling by naumenkogs · Pull Request #23443 · bitcoin/bitcoin · GitHub
366 2022-04-28T19:07:30  <jonatack>  #24757 for me, please
367 2022-04-28T19:07:31  <gribble> https://github.com/bitcoin/bitcoin/issues/24757 | build, ci: add `DEBUG_LOCKCONTENTION` to --enable-debug and CI by jonatack · Pull Request #24757 · bitcoin/bitcoin · GitHub
368 2022-04-28T19:07:57  <laanwj> lightlike: even better! should we add the next one dongcarl?
369 2022-04-28T19:08:05  <laanwj> glozow: thanks!
370 2022-04-28T19:08:14  <dongcarl> Yes! #24410 it is
371 2022-04-28T19:08:15  <gribble> https://github.com/bitcoin/bitcoin/issues/24410 | [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` by dongcarl · Pull Request #24410 · bitcoin/bitcoin · GitHub
372 2022-04-28T19:08:40  <laanwj> jonatack: added
373 2022-04-28T19:08:40  <sipa> kernel 2a is written in c++2a?
374 2022-04-28T19:09:02  <dongcarl> Hahaha I wish!
375 2022-04-28T19:09:10  <laanwj> dongcarl: added
376 2022-04-28T19:09:15  <dongcarl> laanwj: Thanks!
377 2022-04-28T19:10:45  <laanwj> #topic Quick update on libbitcoinkernel (dongcarl)
378 2022-04-28T19:10:45  <core-meetingbot> topic: Quick update on libbitcoinkernel (dongcarl)
379 2022-04-28T19:10:53  <dongcarl> Hi all, after the merge of #24322, the initial build systems changes of libbitcoinkernel are done.
380 2022-04-28T19:10:55  <gribble> https://github.com/bitcoin/bitcoin/issues/24322 | [kernel 1/n] Introduce initial `libbitcoinkernel` by dongcarl · Pull Request #24322 · bitcoin/bitcoin · GitHub
381 2022-04-28T19:11:03  <dongcarl> We will now be doing the more meaningful part of decoupling consensus from other modules. I hope that these PRs will have a wider review base, since it doesn’t require any knowledge of build system minutiae.
382 2022-04-28T19:11:15  <dongcarl> The first PR ready for review is #24410, which is fairly straightforward.
383 2022-04-28T19:11:16  <gribble> https://github.com/bitcoin/bitcoin/issues/24410 | [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` by dongcarl · Pull Request #24410 · bitcoin/bitcoin · GitHub
384 2022-04-28T19:11:24  <dongcarl> A lot of these PRs are not dependent on each other, so at times we will have multiple PRs that are ready for review and not based on one another. There’s no need to wait for a PR to be merged to review the other one!
385 2022-04-28T19:11:32  <jonatack> laanwj: ty!
386 2022-04-28T19:11:37  <dongcarl> One last note: I’m happy to chat about any of these PRs to get people up to speed. It also helps me know what parts are unclear so I can improve my docs/commit messages.
387 2022-04-28T19:11:56  <dongcarl> Hit me up on any communication channel, and I'm also more than happy to do a video/audio call for better bandwidth
388 2022-04-28T19:12:27  * dongcarl is done, but can answer questions if people have any
389 2022-04-28T19:12:46  <sipa> Cool.
390 2022-04-28T19:12:47  <laanwj> dongcarl: thanks for the update
391 2022-04-28T19:13:17  <dongcarl> :)
392 2022-04-28T19:13:32  <laanwj> sounds clear to me, there's a lot to review but hopefully we can make quite some progress before 24.0
393 2022-04-28T19:14:09  <dongcarl> Yup that is my hope too. If anyone spots anything that I could be doing to make things easier to review, let me know!
394 2022-04-28T19:14:30  <hebasto> dongcarl: thanks!
395 2022-04-28T19:14:41  <jonatack> dongcarl: do you recommend we developers build with --enable-experimental-util-chainstate or --with-experimental-kernel-lib? (for the moment i have both in my bash alias)
396 2022-04-28T19:15:21  <dongcarl> jonatack: setting --enable-experimental-util-chainstate will automatically turn on --with-experimental-kernel-lib, unless you set --without-experimental-kernel-lib, in which case configure will fail
397 2022-04-28T19:16:08  <laanwj> heh
398 2022-04-28T19:16:30  <jonatack> ok, thanks, so --enable-experimental-util-chainstate sgtm then (and [kernel 2a/n] looks straightforward to review)
399 2022-04-28T19:16:47  <dongcarl> jonatack: :-)
400 2022-04-28T19:17:03  <cfields> atm the results are intended to be not very usable, but the kernel lib and bitcoin-chainstate (excluding some windows weirdness) should at least build successfully. Please report if that's not the case anywhere.
401 2022-04-28T19:18:00  <dongcarl> Many thanks to cfields who got me through various tough situations in kernel 1/n and in upcoming PRs
402 2022-04-28T19:19:16  <cfields> thanks ryanofsky for great review as well.
403 2022-04-28T19:19:49  <dongcarl> ryan truly is of the sky
404 2022-04-28T19:21:24  <laanwj> i guess that concludes the meeting, or does anyone have any last last minute topic
405 2022-04-28T19:21:34  <jonatack>  following the review feedback by both of you on [kernel 1a] was enlightening, as were the excellent commit messages
406 2022-04-28T19:23:09  <laanwj> thanks everyone for attending, see you next week
407 2022-04-28T19:23:11  <laanwj> #endmeeting
408 2022-04-28T19:23:11  <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
409 2022-04-28T19:23:11  <core-meetingbot> Meeting ended Thu Apr 28 19:23:11 2022 UTC.
410 2022-04-28T19:23:11  <core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2022/bitcoin-core-dev.2022-04-28-19.00.moin.txt
411 2022-04-28T19:23:21  <dongcarl> jonatack: Haha I'm glad you think so! :-)
412 2022-04-28T19:23:32  <dongcarl> laanwj: Thanks!
413 2022-04-28T19:29:15  *** salvatoshi <salvatoshi!~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr> has joined #bitcoin-core-dev
414 2022-04-28T19:44:20  <jamesob> dongcarl: looking forward to reviewing 2/n!
415 2022-04-28T19:49:52  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
416 2022-04-28T19:51:18  <dongcarl> jamesob: 🎉
417 2022-04-28T20:00:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
418 2022-04-28T20:00:11  <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4cf9fa0b662a...606ce05ec225
419 2022-04-28T20:00:11  <bitcoin-git> bitcoin/master 9687659 Seibart Nedor: wallet: ensure wallet files are not reused across chains
420 2022-04-28T20:00:11  <bitcoin-git> bitcoin/master 5f21321 Seibart Nedor: tests: add tests for cross-chain wallet use prevention
421 2022-04-28T20:00:11  <bitcoin-git> bitcoin/master 606ce05 Andrew Chow: Merge bitcoin/bitcoin#18554: wallet: ensure wallet files are not reused ac...
422 2022-04-28T20:00:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
423 2022-04-28T20:00:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
424 2022-04-28T20:00:28  <bitcoin-git> [bitcoin] achow101 merged pull request #18554: wallet: ensure wallet files are not reused across chains (master...wallet-file-reuse-prevention) https://github.com/bitcoin/bitcoin/pull/18554
425 2022-04-28T20:00:28  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
426 2022-04-28T20:33:00  *** bfsfhkacjzgcytf9 <bfsfhkacjzgcytf9!~bfsfhkacj@user/bfsfhkacjzgcytf> has quit IRC (Ping timeout: 276 seconds)
427 2022-04-28T20:41:58  <fanquake> jonatack: what clang build chatter ?
428 2022-04-28T20:46:24  *** salvatoshi <salvatoshi!~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr> has quit IRC (Ping timeout: 246 seconds)
429 2022-04-28T21:25:55  <jonatack> fanquake: https://github.com/bitcoin/bitcoin/pull/24322#issuecomment-1079367319
430 2022-04-28T21:29:09  <jonatack> can be ironed gradually along with any other more significant issues that come up
431 2022-04-28T21:41:11  *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
432 2022-04-28T21:42:19  *** dlb76 <dlb76!~dlb76@user/dlb76> has joined #bitcoin-core-dev
433 2022-04-28T21:57:47  <dongcarl> achow101: Known failure? https://cirrus-ci.com/task/4571677035069440
434 2022-04-28T22:04:42  <cfields> hebasto: i'm not ignoring you btw, just investigating more fully and waiting to put all my thoughts in one place.
435 2022-04-28T22:07:02  *** a1ph4byte <a1ph4byte!~a1ph4byte@2600:1700:22f0:a7c0:7962:a6a5:10e5:4fc> has quit IRC (Quit: Client closed)
436 2022-04-28T22:16:35  <achow101> dongcarl: not to me
437 2022-04-28T22:19:05  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 248 seconds)
438 2022-04-28T22:22:54  *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Remote host closed the connection)
439 2022-04-28T22:25:54  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
440 2022-04-28T22:30:24  <jonatack> fixing
441 2022-04-28T22:32:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
442 2022-04-28T22:32:47  <bitcoin-git> [bitcoin] jonatack opened pull request #25021: test: fix intermittent wallet_encryption functional test (master...fix-intermittent-wallet_encryption-test) https://github.com/bitcoin/bitcoin/pull/25021
443 2022-04-28T22:32:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
444 2022-04-28T23:01:06  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 250 seconds)
445 2022-04-28T23:20:12  *** tecnecio <tecnecio!~tecnecio_@> has joined #bitcoin-core-dev
446 2022-04-28T23:22:36  <hebasto> cfields: thank you
447 2022-04-28T23:34:48  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹіа!)